{"action":"created","issue":{"url":"https://api.github.com/repos/ravendb/ravendb/issues/7310","repository_url":"https://api.github.com/repos/ravendb/ravendb","labels_url":"https://api.github.com/repos/ravendb/ravendb/issues/7310/labels{/name}","comments_url":"https://api.github.com/repos/ravendb/ravendb/issues/7310/comments","events_url":"https://api.github.com/repos/ravendb/ravendb/issues/7310/events","html_url":"https://github.com/ravendb/ravendb/pull/7310","id":349314063,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NDYxNTU2","number":7310,"title":"[DO-NOT-MERGE] For review only: Generalized Allocators","user":{"login":"redknightlois","id":1045411,"node_id":"MDQ6VXNlcjEwNDU0MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1045411?v=4","gravatar_id":"","url":"https://api.github.com/users/redknightlois","html_url":"https://github.com/redknightlois","followers_url":"https://api.github.com/users/redknightlois/followers","following_url":"https://api.github.com/users/redknightlois/following{/other_user}","gists_url":"https://api.github.com/users/redknightlois/gists{/gist_id}","starred_url":"https://api.github.com/users/redknightlois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redknightlois/subscriptions","organizations_url":"https://api.github.com/users/redknightlois/orgs","repos_url":"https://api.github.com/users/redknightlois/repos","events_url":"https://api.github.com/users/redknightlois/events{/privacy}","received_events_url":"https://api.github.com/users/redknightlois/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-08-09T22:29:50Z","updated_at":"2018-08-13T06:09:49Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/ravendb/ravendb/pulls/7310","html_url":"https://github.com/ravendb/ravendb/pull/7310","diff_url":"https://github.com/ravendb/ravendb/pull/7310.diff","patch_url":"https://github.com/ravendb/ravendb/pull/7310.patch"},"body":"This is the first working implementation of Generalized Allocators, includes stress testing facilities, crude leaks detection, ByteString implementation using the new allocators, Spanified Memory Access, Spanified Pointer Types...\r\n\r\nBecause this is going to be the foundation of memory management at Voron and in some fashion the POC for spanification of the core we must get this right from day 1. Please take your time to review, and anything that crosses your mind even if you think it could be a dumb comment, do it anyway :) ... \r\n\r\nAll release FastTests work, Debug fails because of memory leaks detected by the allocators. Many things missing.\r\n\r\nCopy for review anyone you think it should take a look into this. cc @ayende, @arekpalinski, @ppekrol.\r\n\r\nPS: I left the history in case anyone wants to look into the design history. If you think it is better to collapse the history, let me know and I will squash it. "},"comment":{"url":"https://api.github.com/repos/ravendb/ravendb/issues/comments/412417110","html_url":"https://github.com/ravendb/ravendb/pull/7310#issuecomment-412417110","issue_url":"https://api.github.com/repos/ravendb/ravendb/issues/7310","id":412417110,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjQxNzExMA==","user":{"login":"ayende","id":116915,"node_id":"MDQ6VXNlcjExNjkxNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/116915?v=4","gravatar_id":"","url":"https://api.github.com/users/ayende","html_url":"https://github.com/ayende","followers_url":"https://api.github.com/users/ayende/followers","following_url":"https://api.github.com/users/ayende/following{/other_user}","gists_url":"https://api.github.com/users/ayende/gists{/gist_id}","starred_url":"https://api.github.com/users/ayende/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayende/subscriptions","organizations_url":"https://api.github.com/users/ayende/orgs","repos_url":"https://api.github.com/users/ayende/repos","events_url":"https://api.github.com/users/ayende/events{/privacy}","received_events_url":"https://api.github.com/users/ayende/received_events","type":"User","site_admin":false},"created_at":"2018-08-13T06:09:49Z","updated_at":"2018-08-13T06:09:49Z","author_association":"MEMBER","body":"I'm talking specifically here about the `AsSpan` calls with the `start`, `length` calls where we _have_ to do bound checking in prod as well"}}
{"actor":{"display_login":"ayende"}}