{"action":"created","comment":{"url":"https://api.github.com/repos/locationtech/geotrellis/pulls/comments/177542267","pull_request_review_id":107431857,"id":177542267,"diff_hunk":"@@ -24,16 +24,19 @@ import geotrellis.raster.crop._\n import geotrellis.raster.io.geotiff._\n import geotrellis.raster.io.geotiff.compression.{Compression, NoCompression}\n import geotrellis.spark._\n-import geotrellis.spark.io.{AttributeNotFoundError, AttributeStore, LayerNotFoundError, LayerOutOfKeyBoundsError}\n+import geotrellis.spark.io.{AttributeNotFoundError, AttributeStore, LayerNotFoundError, LayerOutOfKeyBoundsError, Writer}\n import geotrellis.spark.io.index._\n import geotrellis.util.LazyLogging\n \n import org.apache.spark.rdd.RDD\n import spray.json._\n \n+import java.net.URI\n+import java.util.ServiceLoader\n+\n import scala.reflect._\n \n-trait COGLayerWriter extends LazyLogging with Serializable {\n+abstract class COGLayerWriter[ID] extends LazyLogging with Serializable {","path":"spark/src/main/scala/geotrellis/spark/io/cog/COGLayerWriter.scala","position":18,"original_position":18,"commit_id":"8d90d529ada19b2668c47c389772d127a241b6ae","original_commit_id":"8d90d529ada19b2668c47c389772d127a241b6ae","user":{"login":"jbouffard","id":11041248,"avatar_url":"https://avatars3.githubusercontent.com/u/11041248?v=4","gravatar_id":"","url":"https://api.github.com/users/jbouffard","html_url":"https://github.com/jbouffard","followers_url":"https://api.github.com/users/jbouffard/followers","following_url":"https://api.github.com/users/jbouffard/following{/other_user}","gists_url":"https://api.github.com/users/jbouffard/gists{/gist_id}","starred_url":"https://api.github.com/users/jbouffard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbouffard/subscriptions","organizations_url":"https://api.github.com/users/jbouffard/orgs","repos_url":"https://api.github.com/users/jbouffard/repos","events_url":"https://api.github.com/users/jbouffard/events{/privacy}","received_events_url":"https://api.github.com/users/jbouffard/received_events","type":"User","site_admin":false},"body":"Oh, never mind. I thought I had `ID` there haha. We can get rid of the `ID` then","created_at":"2018-03-27T19:17:59Z","updated_at":"2018-03-27T19:17:59Z","html_url":"https://github.com/locationtech/geotrellis/pull/2592#discussion_r177542267","pull_request_url":"https://api.github.com/repos/locationtech/geotrellis/pulls/2592","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/locationtech/geotrellis/pulls/comments/177542267"},"html":{"href":"https://github.com/locationtech/geotrellis/pull/2592#discussion_r177542267"},"pull_request":{"href":"https://api.github.com/repos/locationtech/geotrellis/pulls/2592"}},"in_reply_to_id":177531305},"pull_request":{"url":"https://api.github.com/repos/locationtech/geotrellis/pulls/2592","id":177536376,"html_url":"https://github.com/locationtech/geotrellis/pull/2592","diff_url":"https://github.com/locationtech/geotrellis/pull/2592.diff","patch_url":"https://github.com/locationtech/geotrellis/pull/2592.patch","issue_url":"https://api.github.com/repos/locationtech/geotrellis/issues/2592","number":2592,"state":"open","locked":false,"title":"COGLayerProviders","user":{"login":"jbouffard","id":11041248,"avatar_url":"https://avatars3.githubusercontent.com/u/11041248?v=4","gravatar_id":"","url":"https://api.github.com/users/jbouffard","html_url":"https://github.com/jbouffard","followers_url":"https://api.github.com/users/jbouffard/followers","following_url":"https://api.github.com/users/jbouffard/following{/other_user}","gists_url":"https://api.github.com/users/jbouffard/gists{/gist_id}","starred_url":"https://api.github.com/users/jbouffard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbouffard/subscriptions","organizations_url":"https://api.github.com/users/jbouffard/orgs","repos_url":"https://api.github.com/users/jbouffard/repos","events_url":"https://api.github.com/users/jbouffard/events{/privacy}","received_events_url":"https://api.github.com/users/jbouffard/received_events","type":"User","site_admin":false},"body":"## Overview\r\n\r\nThis PR adds `LayerProvider` support for `COGLayer`s based on the Java SPI.\r\n\r\n### Checklist\r\n\r\n- [x] `docs/CHANGELOG.rst` updated, if necessary\r\n- [x] `docs` guides update, if necessary\r\n- [x] New user API has useful Scaladoc strings\r\n- [x] Unit tests added for bug-fix or new feature\r\n\r\n### Demo\r\n\r\n```scala\r\n\r\nval path = \"file:///tmp/test-catalog\"\r\nval reader = COGFileLayerReader(path)\r\n```","created_at":"2018-03-26T18:56:01Z","updated_at":"2018-03-27T19:17:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac35fcd4f54175f64da210c312dd363158161ee0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/locationtech/geotrellis/pulls/2592/commits","review_comments_url":"https://api.github.com/repos/locationtech/geotrellis/pulls/2592/comments","review_comment_url":"https://api.github.com/repos/locationtech/geotrellis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/locationtech/geotrellis/issues/2592/comments","statuses_url":"https://api.github.com/repos/locationtech/geotrellis/statuses/8d90d529ada19b2668c47c389772d127a241b6ae","head":{"label":"jbouffard:feature/cog/layer-provider","ref":"feature/cog/layer-provider","sha":"8d90d529ada19b2668c47c389772d127a241b6ae","user":{"login":"jbouffard","id":11041248,"avatar_url":"https://avatars3.githubusercontent.com/u/11041248?v=4","gravatar_id":"","url":"https://api.github.com/users/jbouffard","html_url":"https://github.com/jbouffard","followers_url":"https://api.github.com/users/jbouffard/followers","following_url":"https://api.github.com/users/jbouffard/following{/other_user}","gists_url":"https://api.github.com/users/jbouffard/gists{/gist_id}","starred_url":"https://api.github.com/users/jbouffard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbouffard/subscriptions","organizations_url":"https://api.github.com/users/jbouffard/orgs","repos_url":"https://api.github.com/users/jbouffard/repos","events_url":"https://api.github.com/users/jbouffard/events{/privacy}","received_events_url":"https://api.github.com/users/jbouffard/received_events","type":"User","site_admin":false},"repo":{"id":60871739,"name":"geotrellis","full_name":"jbouffard/geotrellis","owner":{"login":"jbouffard","id":11041248,"avatar_url":"https://avatars3.githubusercontent.com/u/11041248?v=4","gravatar_id":"","url":"https://api.github.com/users/jbouffard","html_url":"https://github.com/jbouffard","followers_url":"https://api.github.com/users/jbouffard/followers","following_url":"https://api.github.com/users/jbouffard/following{/other_user}","gists_url":"https://api.github.com/users/jbouffard/gists{/gist_id}","starred_url":"https://api.github.com/users/jbouffard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbouffard/subscriptions","organizations_url":"https://api.github.com/users/jbouffard/orgs","repos_url":"https://api.github.com/users/jbouffard/repos","events_url":"https://api.github.com/users/jbouffard/events{/privacy}","received_events_url":"https://api.github.com/users/jbouffard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jbouffard/geotrellis","description":"GeoTrellis is a geographic data processing engine for high performance applications.","fork":true,"url":"https://api.github.com/repos/jbouffard/geotrellis","forks_url":"https://api.github.com/repos/jbouffard/geotrellis/forks","keys_url":"https://api.github.com/repos/jbouffard/geotrellis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbouffard/geotrellis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbouffard/geotrellis/teams","hooks_url":"https://api.github.com/repos/jbouffard/geotrellis/hooks","issue_events_url":"https://api.github.com/repos/jbouffard/geotrellis/issues/events{/number}","events_url":"https://api.github.com/repos/jbouffard/geotrellis/events","assignees_url":"https://api.github.com/repos/jbouffard/geotrellis/assignees{/user}","branches_url":"https://api.github.com/repos/jbouffard/geotrellis/branches{/branch}","tags_url":"https://api.github.com/repos/jbouffard/geotrellis/tags","blobs_url":"https://api.github.com/repos/jbouffard/geotrellis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbouffard/geotrellis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbouffard/geotrellis/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbouffard/geotrellis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbouffard/geotrellis/statuses/{sha}","languages_url":"https://api.github.com/repos/jbouffard/geotrellis/languages","stargazers_url":"https://api.github.com/repos/jbouffard/geotrellis/stargazers","contributors_url":"https://api.github.com/repos/jbouffard/geotrellis/contributors","subscribers_url":"https://api.github.com/repos/jbouffard/geotrellis/subscribers","subscription_url":"https://api.github.com/repos/jbouffard/geotrellis/subscription","commits_url":"https://api.github.com/repos/jbouffard/geotrellis/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbouffard/geotrellis/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbouffard/geotrellis/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbouffard/geotrellis/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbouffard/geotrellis/contents/{+path}","compare_url":"https://api.github.com/repos/jbouffard/geotrellis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbouffard/geotrellis/merges","archive_url":"https://api.github.com/repos/jbouffard/geotrellis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbouffard/geotrellis/downloads","issues_url":"https://api.github.com/repos/jbouffard/geotrellis/issues{/number}","pulls_url":"https://api.github.com/repos/jbouffard/geotrellis/pulls{/number}","milestones_url":"https://api.github.com/repos/jbouffard/geotrellis/milestones{/number}","notifications_url":"https://api.github.com/repos/jbouffard/geotrellis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbouffard/geotrellis/labels{/name}","releases_url":"https://api.github.com/repos/jbouffard/geotrellis/releases{/id}","deployments_url":"https://api.github.com/repos/jbouffard/geotrellis/deployments","created_at":"2016-06-10T19:23:32Z","updated_at":"2016-06-10T19:23:45Z","pushed_at":"2018-03-27T18:07:32Z","git_url":"git://github.com/jbouffard/geotrellis.git","ssh_url":"git@github.com:jbouffard/geotrellis.git","clone_url":"https://github.com/jbouffard/geotrellis.git","svn_url":"https://github.com/jbouffard/geotrellis","homepage":"http://geotrellis.io","size":523586,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"locationtech:master","ref":"master","sha":"43f08e89d2762ce1aa60c6367cd87cd790f9987c","user":{"login":"locationtech","id":1991411,"avatar_url":"https://avatars2.githubusercontent.com/u/1991411?v=4","gravatar_id":"","url":"https://api.github.com/users/locationtech","html_url":"https://github.com/locationtech","followers_url":"https://api.github.com/users/locationtech/followers","following_url":"https://api.github.com/users/locationtech/following{/other_user}","gists_url":"https://api.github.com/users/locationtech/gists{/gist_id}","starred_url":"https://api.github.com/users/locationtech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/locationtech/subscriptions","organizations_url":"https://api.github.com/users/locationtech/orgs","repos_url":"https://api.github.com/users/locationtech/repos","events_url":"https://api.github.com/users/locationtech/events{/privacy}","received_events_url":"https://api.github.com/users/locationtech/received_events","type":"Organization","site_admin":false},"repo":{"id":3040675,"name":"geotrellis","full_name":"locationtech/geotrellis","owner":{"login":"locationtech","id":1991411,"avatar_url":"https://avatars2.githubusercontent.com/u/1991411?v=4","gravatar_id":"","url":"https://api.github.com/users/locationtech","html_url":"https://github.com/locationtech","followers_url":"https://api.github.com/users/locationtech/followers","following_url":"https://api.github.com/users/locationtech/following{/other_user}","gists_url":"https://api.github.com/users/locationtech/gists{/gist_id}","starred_url":"https://api.github.com/users/locationtech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/locationtech/subscriptions","organizations_url":"https://api.github.com/users/locationtech/orgs","repos_url":"https://api.github.com/users/locationtech/repos","events_url":"https://api.github.com/users/locationtech/events{/privacy}","received_events_url":"https://api.github.com/users/locationtech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/locationtech/geotrellis","description":"GeoTrellis is a geographic data processing engine for high performance applications.","fork":false,"url":"https://api.github.com/repos/locationtech/geotrellis","forks_url":"https://api.github.com/repos/locationtech/geotrellis/forks","keys_url":"https://api.github.com/repos/locationtech/geotrellis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/locationtech/geotrellis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/locationtech/geotrellis/teams","hooks_url":"https://api.github.com/repos/locationtech/geotrellis/hooks","issue_events_url":"https://api.github.com/repos/locationtech/geotrellis/issues/events{/number}","events_url":"https://api.github.com/repos/locationtech/geotrellis/events","assignees_url":"https://api.github.com/repos/locationtech/geotrellis/assignees{/user}","branches_url":"https://api.github.com/repos/locationtech/geotrellis/branches{/branch}","tags_url":"https://api.github.com/repos/locationtech/geotrellis/tags","blobs_url":"https://api.github.com/repos/locationtech/geotrellis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/locationtech/geotrellis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/locationtech/geotrellis/git/refs{/sha}","trees_url":"https://api.github.com/repos/locationtech/geotrellis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/locationtech/geotrellis/statuses/{sha}","languages_url":"https://api.github.com/repos/locationtech/geotrellis/languages","stargazers_url":"https://api.github.com/repos/locationtech/geotrellis/stargazers","contributors_url":"https://api.github.com/repos/locationtech/geotrellis/contributors","subscribers_url":"https://api.github.com/repos/locationtech/geotrellis/subscribers","subscription_url":"https://api.github.com/repos/locationtech/geotrellis/subscription","commits_url":"https://api.github.com/repos/locationtech/geotrellis/commits{/sha}","git_commits_url":"https://api.github.com/repos/locationtech/geotrellis/git/commits{/sha}","comments_url":"https://api.github.com/repos/locationtech/geotrellis/comments{/number}","issue_comment_url":"https://api.github.com/repos/locationtech/geotrellis/issues/comments{/number}","contents_url":"https://api.github.com/repos/locationtech/geotrellis/contents/{+path}","compare_url":"https://api.github.com/repos/locationtech/geotrellis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/locationtech/geotrellis/merges","archive_url":"https://api.github.com/repos/locationtech/geotrellis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/locationtech/geotrellis/downloads","issues_url":"https://api.github.com/repos/locationtech/geotrellis/issues{/number}","pulls_url":"https://api.github.com/repos/locationtech/geotrellis/pulls{/number}","milestones_url":"https://api.github.com/repos/locationtech/geotrellis/milestones{/number}","notifications_url":"https://api.github.com/repos/locationtech/geotrellis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/locationtech/geotrellis/labels{/name}","releases_url":"https://api.github.com/repos/locationtech/geotrellis/releases{/id}","deployments_url":"https://api.github.com/repos/locationtech/geotrellis/deployments","created_at":"2011-12-23T14:56:54Z","updated_at":"2018-03-27T17:41:52Z","pushed_at":"2018-03-27T18:07:34Z","git_url":"git://github.com/locationtech/geotrellis.git","ssh_url":"git@github.com:locationtech/geotrellis.git","clone_url":"https://github.com/locationtech/geotrellis.git","svn_url":"https://github.com/locationtech/geotrellis","homepage":"http://geotrellis.io","size":523807,"stargazers_count":662,"watchers_count":662,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":211,"mirror_url":null,"archived":false,"open_issues_count":150,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":211,"open_issues":150,"watchers":662,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/locationtech/geotrellis/pulls/2592"},"html":{"href":"https://github.com/locationtech/geotrellis/pull/2592"},"issue":{"href":"https://api.github.com/repos/locationtech/geotrellis/issues/2592"},"comments":{"href":"https://api.github.com/repos/locationtech/geotrellis/issues/2592/comments"},"review_comments":{"href":"https://api.github.com/repos/locationtech/geotrellis/pulls/2592/comments"},"review_comment":{"href":"https://api.github.com/repos/locationtech/geotrellis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/locationtech/geotrellis/pulls/2592/commits"},"statuses":{"href":"https://api.github.com/repos/locationtech/geotrellis/statuses/8d90d529ada19b2668c47c389772d127a241b6ae"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jbouffard"}}