{"action":"created","comment":{"url":"https://api.github.com/repos/apache/carbondata/pulls/comments/212600140","pull_request_review_id":149269307,"id":212600140,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjYwMDE0MA==","diff_hunk":"@@ -434,4 +477,61 @@ public CarbonLoadModel getLoadModel() {\n       return loadModel;\n     }\n   }\n+\n+  public static class CarbonMultiRecordWriter","path":"hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableOutputFormat.java","position":null,"original_position":55,"commit_id":"dd8bd2beb4491c80a45bed64a09ba01c96a1e9b0","original_commit_id":"0c4782ebafd8eff5ae51629b2327a98877a6e064","user":{"login":"ajantha-bhat","id":5889404,"node_id":"MDQ6VXNlcjU4ODk0MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5889404?v=4","gravatar_id":"","url":"https://api.github.com/users/ajantha-bhat","html_url":"https://github.com/ajantha-bhat","followers_url":"https://api.github.com/users/ajantha-bhat/followers","following_url":"https://api.github.com/users/ajantha-bhat/following{/other_user}","gists_url":"https://api.github.com/users/ajantha-bhat/gists{/gist_id}","starred_url":"https://api.github.com/users/ajantha-bhat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajantha-bhat/subscriptions","organizations_url":"https://api.github.com/users/ajantha-bhat/orgs","repos_url":"https://api.github.com/users/ajantha-bhat/repos","events_url":"https://api.github.com/users/ajantha-bhat/events{/privacy}","received_events_url":"https://api.github.com/users/ajantha-bhat/received_events","type":"User","site_admin":false},"body":"done. overrided","created_at":"2018-08-24T11:35:40Z","updated_at":"2018-08-24T11:35:41Z","html_url":"https://github.com/apache/carbondata/pull/2653#discussion_r212600140","pull_request_url":"https://api.github.com/repos/apache/carbondata/pulls/2653","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/carbondata/pulls/comments/212600140"},"html":{"href":"https://github.com/apache/carbondata/pull/2653#discussion_r212600140"},"pull_request":{"href":"https://api.github.com/repos/apache/carbondata/pulls/2653"}},"in_reply_to_id":212532764},"pull_request":{"url":"https://api.github.com/repos/apache/carbondata/pulls/2653","id":210515548,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNTE1NTQ4","html_url":"https://github.com/apache/carbondata/pull/2653","diff_url":"https://github.com/apache/carbondata/pull/2653.diff","patch_url":"https://github.com/apache/carbondata/pull/2653.patch","issue_url":"https://api.github.com/repos/apache/carbondata/issues/2653","number":2653,"state":"open","locked":false,"title":"[CARBONDATA-2874] Support SDK writer as thread safe api  ","user":{"login":"ajantha-bhat","id":5889404,"node_id":"MDQ6VXNlcjU4ODk0MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5889404?v=4","gravatar_id":"","url":"https://api.github.com/users/ajantha-bhat","html_url":"https://github.com/ajantha-bhat","followers_url":"https://api.github.com/users/ajantha-bhat/followers","following_url":"https://api.github.com/users/ajantha-bhat/following{/other_user}","gists_url":"https://api.github.com/users/ajantha-bhat/gists{/gist_id}","starred_url":"https://api.github.com/users/ajantha-bhat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajantha-bhat/subscriptions","organizations_url":"https://api.github.com/users/ajantha-bhat/orgs","repos_url":"https://api.github.com/users/ajantha-bhat/repos","events_url":"https://api.github.com/users/ajantha-bhat/events{/privacy}","received_events_url":"https://api.github.com/users/ajantha-bhat/received_events","type":"User","site_admin":false},"body":"Problem: Currently CarbonWriter.write() not a thread safe. if multiple threads calls .write() for one writer.\r\nData count inconsistency is observed.\r\n\r\nroot casue: As all the threads are writing to same batch of blocking queue. need to synchronize this. Else one thread data overwrite the other thread data.\r\n\r\nSolution: \r\na) DataLoadExecutor is using only one iterator, take number of threads as input and internally create that many iterator to loop over the data. This will reduce the blocking time of queue as each iterator has its own queue.\r\nb) InputProcessor step is taking only default 2 cores (2 thread) for data load in SDK flow, can use the same number as number of threads created by user.\r\nc) writer step is using only 2 cores  (2 thread). can use the same number as number of threads created by user.\r\n\r\nBe sure to do all of the following checklist to help us incorporate \r\nyour contribution quickly and easily:\r\n\r\n - [ ] Any interfaces changed? NA. Added new interface\r\n \r\n - [ ] Any backward compatibility impacted? NA\r\n \r\n - [ ] Document update required? yes,  udpated\r\n\r\n - [ ] Testing done. Yes, updated the test case\r\n      \r\n - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. NA\r\n\r\n","created_at":"2018-08-23T17:06:12Z","updated_at":"2018-08-24T11:35:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b77b3608ee0131a9efb0832c6e9563bcec90e453","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/carbondata/pulls/2653/commits","review_comments_url":"https://api.github.com/repos/apache/carbondata/pulls/2653/comments","review_comment_url":"https://api.github.com/repos/apache/carbondata/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/carbondata/issues/2653/comments","statuses_url":"https://api.github.com/repos/apache/carbondata/statuses/dd8bd2beb4491c80a45bed64a09ba01c96a1e9b0","head":{"label":"ajantha-bhat:master_new","ref":"master_new","sha":"dd8bd2beb4491c80a45bed64a09ba01c96a1e9b0","user":{"login":"ajantha-bhat","id":5889404,"node_id":"MDQ6VXNlcjU4ODk0MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5889404?v=4","gravatar_id":"","url":"https://api.github.com/users/ajantha-bhat","html_url":"https://github.com/ajantha-bhat","followers_url":"https://api.github.com/users/ajantha-bhat/followers","following_url":"https://api.github.com/users/ajantha-bhat/following{/other_user}","gists_url":"https://api.github.com/users/ajantha-bhat/gists{/gist_id}","starred_url":"https://api.github.com/users/ajantha-bhat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajantha-bhat/subscriptions","organizations_url":"https://api.github.com/users/ajantha-bhat/orgs","repos_url":"https://api.github.com/users/ajantha-bhat/repos","events_url":"https://api.github.com/users/ajantha-bhat/events{/privacy}","received_events_url":"https://api.github.com/users/ajantha-bhat/received_events","type":"User","site_admin":false},"repo":{"id":115105646,"node_id":"MDEwOlJlcG9zaXRvcnkxMTUxMDU2NDY=","name":"carbondata","full_name":"ajantha-bhat/carbondata","owner":{"login":"ajantha-bhat","id":5889404,"node_id":"MDQ6VXNlcjU4ODk0MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5889404?v=4","gravatar_id":"","url":"https://api.github.com/users/ajantha-bhat","html_url":"https://github.com/ajantha-bhat","followers_url":"https://api.github.com/users/ajantha-bhat/followers","following_url":"https://api.github.com/users/ajantha-bhat/following{/other_user}","gists_url":"https://api.github.com/users/ajantha-bhat/gists{/gist_id}","starred_url":"https://api.github.com/users/ajantha-bhat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajantha-bhat/subscriptions","organizations_url":"https://api.github.com/users/ajantha-bhat/orgs","repos_url":"https://api.github.com/users/ajantha-bhat/repos","events_url":"https://api.github.com/users/ajantha-bhat/events{/privacy}","received_events_url":"https://api.github.com/users/ajantha-bhat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ajantha-bhat/carbondata","description":"Mirror of Apache CarbonData","fork":true,"url":"https://api.github.com/repos/ajantha-bhat/carbondata","forks_url":"https://api.github.com/repos/ajantha-bhat/carbondata/forks","keys_url":"https://api.github.com/repos/ajantha-bhat/carbondata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajantha-bhat/carbondata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajantha-bhat/carbondata/teams","hooks_url":"https://api.github.com/repos/ajantha-bhat/carbondata/hooks","issue_events_url":"https://api.github.com/repos/ajantha-bhat/carbondata/issues/events{/number}","events_url":"https://api.github.com/repos/ajantha-bhat/carbondata/events","assignees_url":"https://api.github.com/repos/ajantha-bhat/carbondata/assignees{/user}","branches_url":"https://api.github.com/repos/ajantha-bhat/carbondata/branches{/branch}","tags_url":"https://api.github.com/repos/ajantha-bhat/carbondata/tags","blobs_url":"https://api.github.com/repos/ajantha-bhat/carbondata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajantha-bhat/carbondata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajantha-bhat/carbondata/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajantha-bhat/carbondata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajantha-bhat/carbondata/statuses/{sha}","languages_url":"https://api.github.com/repos/ajantha-bhat/carbondata/languages","stargazers_url":"https://api.github.com/repos/ajantha-bhat/carbondata/stargazers","contributors_url":"https://api.github.com/repos/ajantha-bhat/carbondata/contributors","subscribers_url":"https://api.github.com/repos/ajantha-bhat/carbondata/subscribers","subscription_url":"https://api.github.com/repos/ajantha-bhat/carbondata/subscription","commits_url":"https://api.github.com/repos/ajantha-bhat/carbondata/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajantha-bhat/carbondata/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajantha-bhat/carbondata/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajantha-bhat/carbondata/issues/comments{/number}","contents_url":"https://api.github.com/repos/ajantha-bhat/carbondata/contents/{+path}","compare_url":"https://api.github.com/repos/ajantha-bhat/carbondata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajantha-bhat/carbondata/merges","archive_url":"https://api.github.com/repos/ajantha-bhat/carbondata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajantha-bhat/carbondata/downloads","issues_url":"https://api.github.com/repos/ajantha-bhat/carbondata/issues{/number}","pulls_url":"https://api.github.com/repos/ajantha-bhat/carbondata/pulls{/number}","milestones_url":"https://api.github.com/repos/ajantha-bhat/carbondata/milestones{/number}","notifications_url":"https://api.github.com/repos/ajantha-bhat/carbondata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajantha-bhat/carbondata/labels{/name}","releases_url":"https://api.github.com/repos/ajantha-bhat/carbondata/releases{/id}","deployments_url":"https://api.github.com/repos/ajantha-bhat/carbondata/deployments","created_at":"2017-12-22T10:35:58Z","updated_at":"2018-08-07T14:48:02Z","pushed_at":"2018-08-24T11:34:42Z","git_url":"git://github.com/ajantha-bhat/carbondata.git","ssh_url":"git@github.com:ajantha-bhat/carbondata.git","clone_url":"https://github.com/ajantha-bhat/carbondata.git","svn_url":"https://github.com/ajantha-bhat/carbondata","homepage":"","size":83869,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"6029b28006d54db74682e9348a92bebdf518d07d","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":62117818,"node_id":"MDEwOlJlcG9zaXRvcnk2MjExNzgxOA==","name":"carbondata","full_name":"apache/carbondata","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/carbondata","description":"Mirror of Apache CarbonData","fork":false,"url":"https://api.github.com/repos/apache/carbondata","forks_url":"https://api.github.com/repos/apache/carbondata/forks","keys_url":"https://api.github.com/repos/apache/carbondata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/carbondata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/carbondata/teams","hooks_url":"https://api.github.com/repos/apache/carbondata/hooks","issue_events_url":"https://api.github.com/repos/apache/carbondata/issues/events{/number}","events_url":"https://api.github.com/repos/apache/carbondata/events","assignees_url":"https://api.github.com/repos/apache/carbondata/assignees{/user}","branches_url":"https://api.github.com/repos/apache/carbondata/branches{/branch}","tags_url":"https://api.github.com/repos/apache/carbondata/tags","blobs_url":"https://api.github.com/repos/apache/carbondata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/carbondata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/carbondata/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/carbondata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/carbondata/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/carbondata/languages","stargazers_url":"https://api.github.com/repos/apache/carbondata/stargazers","contributors_url":"https://api.github.com/repos/apache/carbondata/contributors","subscribers_url":"https://api.github.com/repos/apache/carbondata/subscribers","subscription_url":"https://api.github.com/repos/apache/carbondata/subscription","commits_url":"https://api.github.com/repos/apache/carbondata/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/carbondata/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/carbondata/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/carbondata/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/carbondata/contents/{+path}","compare_url":"https://api.github.com/repos/apache/carbondata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/carbondata/merges","archive_url":"https://api.github.com/repos/apache/carbondata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/carbondata/downloads","issues_url":"https://api.github.com/repos/apache/carbondata/issues{/number}","pulls_url":"https://api.github.com/repos/apache/carbondata/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/carbondata/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/carbondata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/carbondata/labels{/name}","releases_url":"https://api.github.com/repos/apache/carbondata/releases{/id}","deployments_url":"https://api.github.com/repos/apache/carbondata/deployments","created_at":"2016-06-28T07:00:06Z","updated_at":"2018-08-23T11:33:55Z","pushed_at":"2018-08-24T11:34:43Z","git_url":"git://github.com/apache/carbondata.git","ssh_url":"git@github.com:apache/carbondata.git","clone_url":"https://github.com/apache/carbondata.git","svn_url":"https://github.com/apache/carbondata","homepage":"","size":61608,"stargazers_count":728,"watchers_count":728,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":450,"mirror_url":null,"archived":false,"open_issues_count":94,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":450,"open_issues":94,"watchers":728,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/carbondata/pulls/2653"},"html":{"href":"https://github.com/apache/carbondata/pull/2653"},"issue":{"href":"https://api.github.com/repos/apache/carbondata/issues/2653"},"comments":{"href":"https://api.github.com/repos/apache/carbondata/issues/2653/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/carbondata/pulls/2653/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/carbondata/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/carbondata/pulls/2653/commits"},"statuses":{"href":"https://api.github.com/repos/apache/carbondata/statuses/dd8bd2beb4491c80a45bed64a09ba01c96a1e9b0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ajantha-bhat"}}