{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/pulls/comments/196701846","pull_request_review_id":130303079,"id":196701846,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjcwMTg0Ng==","diff_hunk":"@@ -133,6 +148,30 @@ public void setRegion(String region) {\n         save();\n     }\n \n+    public String getCredentialsId() {\n+        return credentialsId;\n+    }\n+\n+    @DataBoundSetter\n+    public void setCredentialsId(String credentialsId) {\n+        this.credentialsId = credentialsId;","path":"src/main/java/io/jenkins/plugins/artifact_manager_jclouds/s3/S3BlobStoreConfig.java","position":70,"original_position":70,"commit_id":"225efc0f914c32fdd5f33479aa1cb75a19ffd8b5","original_commit_id":"225efc0f914c32fdd5f33479aa1cb75a19ffd8b5","user":{"login":"kuisathaverat","id":5400788,"node_id":"MDQ6VXNlcjU0MDA3ODg=","avatar_url":"https://avatars1.githubusercontent.com/u/5400788?v=4","gravatar_id":"","url":"https://api.github.com/users/kuisathaverat","html_url":"https://github.com/kuisathaverat","followers_url":"https://api.github.com/users/kuisathaverat/followers","following_url":"https://api.github.com/users/kuisathaverat/following{/other_user}","gists_url":"https://api.github.com/users/kuisathaverat/gists{/gist_id}","starred_url":"https://api.github.com/users/kuisathaverat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuisathaverat/subscriptions","organizations_url":"https://api.github.com/users/kuisathaverat/orgs","repos_url":"https://api.github.com/users/kuisathaverat/repos","events_url":"https://api.github.com/users/kuisathaverat/events{/privacy}","received_events_url":"https://api.github.com/users/kuisathaverat/received_events","type":"User","site_admin":false},"body":"I will ensure that it is \"\" if it is blank, I do not like the null values ;)","created_at":"2018-06-20T09:10:26Z","updated_at":"2018-06-20T09:10:26Z","html_url":"https://github.com/jenkinsci/artifact-manager-s3-plugin/pull/58#discussion_r196701846","pull_request_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/pulls/58","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/pulls/comments/196701846"},"html":{"href":"https://github.com/jenkinsci/artifact-manager-s3-plugin/pull/58#discussion_r196701846"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/pulls/58"}},"in_reply_to_id":196491972},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/pulls/58","id":195204678,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MjA0Njc4","html_url":"https://github.com/jenkinsci/artifact-manager-s3-plugin/pull/58","diff_url":"https://github.com/jenkinsci/artifact-manager-s3-plugin/pull/58.diff","patch_url":"https://github.com/jenkinsci/artifact-manager-s3-plugin/pull/58.patch","issue_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/issues/58","number":58,"state":"open","locked":false,"title":"[JENKINS-51396] Support for AWS Credentials","user":{"login":"kuisathaverat","id":5400788,"node_id":"MDQ6VXNlcjU0MDA3ODg=","avatar_url":"https://avatars1.githubusercontent.com/u/5400788?v=4","gravatar_id":"","url":"https://api.github.com/users/kuisathaverat","html_url":"https://github.com/kuisathaverat","followers_url":"https://api.github.com/users/kuisathaverat/followers","following_url":"https://api.github.com/users/kuisathaverat/following{/other_user}","gists_url":"https://api.github.com/users/kuisathaverat/gists{/gist_id}","starred_url":"https://api.github.com/users/kuisathaverat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuisathaverat/subscriptions","organizations_url":"https://api.github.com/users/kuisathaverat/orgs","repos_url":"https://api.github.com/users/kuisathaverat/repos","events_url":"https://api.github.com/users/kuisathaverat/events{/privacy}","received_events_url":"https://api.github.com/users/kuisathaverat/received_events","type":"User","site_admin":false},"body":"[JENKINS-51396](https://issues.jenkins-ci.org/browse/JENKINS-51396)\r\n\r\n* Add support to configure credentials\r\n* update README","created_at":"2018-06-15T15:10:39Z","updated_at":"2018-06-20T09:10:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c17cd00a821ade4f3b2b257ff40ecd49513aada4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"carlossg","id":23651,"node_id":"MDQ6VXNlcjIzNjUx","avatar_url":"https://avatars2.githubusercontent.com/u/23651?v=4","gravatar_id":"","url":"https://api.github.com/users/carlossg","html_url":"https://github.com/carlossg","followers_url":"https://api.github.com/users/carlossg/followers","following_url":"https://api.github.com/users/carlossg/following{/other_user}","gists_url":"https://api.github.com/users/carlossg/gists{/gist_id}","starred_url":"https://api.github.com/users/carlossg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlossg/subscriptions","organizations_url":"https://api.github.com/users/carlossg/orgs","repos_url":"https://api.github.com/users/carlossg/repos","events_url":"https://api.github.com/users/carlossg/events{/privacy}","received_events_url":"https://api.github.com/users/carlossg/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/pulls/58/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/pulls/58/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/issues/58/comments","statuses_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/statuses/225efc0f914c32fdd5f33479aa1cb75a19ffd8b5","head":{"label":"jenkinsci:JENKINS-51396","ref":"JENKINS-51396","sha":"225efc0f914c32fdd5f33479aa1cb75a19ffd8b5","user":{"login":"jenkinsci","id":107424,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzQyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/107424?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":127051186,"node_id":"MDEwOlJlcG9zaXRvcnkxMjcwNTExODY=","name":"artifact-manager-s3-plugin","full_name":"jenkinsci/artifact-manager-s3-plugin","owner":{"login":"jenkinsci","id":107424,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzQyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/107424?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/artifact-manager-s3-plugin","description":" Artifact manager implementation for Amazon S3","fork":false,"url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin","forks_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/deployments","created_at":"2018-03-27T22:07:06Z","updated_at":"2018-06-19T17:42:48Z","pushed_at":"2018-06-19T17:42:46Z","git_url":"git://github.com/jenkinsci/artifact-manager-s3-plugin.git","ssh_url":"git@github.com:jenkinsci/artifact-manager-s3-plugin.git","clone_url":"https://github.com/jenkinsci/artifact-manager-s3-plugin.git","svn_url":"https://github.com/jenkinsci/artifact-manager-s3-plugin","homepage":"","size":1516,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":5,"open_issues":3,"watchers":5,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"ec082ef33bf15ab9d0e4ed210db81fe905b8b1a1","user":{"login":"jenkinsci","id":107424,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzQyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/107424?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":127051186,"node_id":"MDEwOlJlcG9zaXRvcnkxMjcwNTExODY=","name":"artifact-manager-s3-plugin","full_name":"jenkinsci/artifact-manager-s3-plugin","owner":{"login":"jenkinsci","id":107424,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzQyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/107424?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/artifact-manager-s3-plugin","description":" Artifact manager implementation for Amazon S3","fork":false,"url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin","forks_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/deployments","created_at":"2018-03-27T22:07:06Z","updated_at":"2018-06-19T17:42:48Z","pushed_at":"2018-06-19T17:42:46Z","git_url":"git://github.com/jenkinsci/artifact-manager-s3-plugin.git","ssh_url":"git@github.com:jenkinsci/artifact-manager-s3-plugin.git","clone_url":"https://github.com/jenkinsci/artifact-manager-s3-plugin.git","svn_url":"https://github.com/jenkinsci/artifact-manager-s3-plugin","homepage":"","size":1516,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":5,"open_issues":3,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/pulls/58"},"html":{"href":"https://github.com/jenkinsci/artifact-manager-s3-plugin/pull/58"},"issue":{"href":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/issues/58"},"comments":{"href":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/artifact-manager-s3-plugin/statuses/225efc0f914c32fdd5f33479aa1cb75a19ffd8b5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kuisathaverat"}}