{"action":"created","issue":{"url":"https://api.github.com/repos/dcos/dcos/issues/3940","repository_url":"https://api.github.com/repos/dcos/dcos","labels_url":"https://api.github.com/repos/dcos/dcos/issues/3940/labels{/name}","comments_url":"https://api.github.com/repos/dcos/dcos/issues/3940/comments","events_url":"https://api.github.com/repos/dcos/dcos/issues/3940/events","html_url":"https://github.com/dcos/dcos/pull/3940","id":390488067,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MjQyOTgx","number":3940,"title":"Gather Prometheus metrics from tasks","user":{"login":"philipnrmn","id":2989362,"node_id":"MDQ6VXNlcjI5ODkzNjI=","avatar_url":"https://avatars3.githubusercontent.com/u/2989362?v=4","gravatar_id":"","url":"https://api.github.com/users/philipnrmn","html_url":"https://github.com/philipnrmn","followers_url":"https://api.github.com/users/philipnrmn/followers","following_url":"https://api.github.com/users/philipnrmn/following{/other_user}","gists_url":"https://api.github.com/users/philipnrmn/gists{/gist_id}","starred_url":"https://api.github.com/users/philipnrmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philipnrmn/subscriptions","organizations_url":"https://api.github.com/users/philipnrmn/orgs","repos_url":"https://api.github.com/users/philipnrmn/repos","events_url":"https://api.github.com/users/philipnrmn/events{/privacy}","received_events_url":"https://api.github.com/users/philipnrmn/received_events","type":"User","site_admin":false},"labels":[{"id":364877915,"node_id":"MDU6TGFiZWwzNjQ4Nzc5MTU=","url":"https://api.github.com/repos/dcos/dcos/labels/Work%20In%20Progress","name":"Work In Progress","color":"c5def5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-12-13T02:10:35Z","updated_at":"2018-12-18T21:02:35Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/dcos/dcos/pulls/3940","html_url":"https://github.com/dcos/dcos/pull/3940","diff_url":"https://github.com/dcos/dcos/pull/3940.diff","patch_url":"https://github.com/dcos/dcos/pull/3940.patch"},"body":"## High-level description\r\n\r\nThis PR enables Prometheus metrics collection from ports on tasks which specify `DCOS_METRICS_FORMAT=prometheus` in their labels.\r\n\r\n## Corresponding DC/OS tickets (obligatory)\r\n\r\nThese DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:\r\n\r\n  - [DCOS_OSS-3717](https://jira.mesosphere.com/browse/DCOS_OSS-3717) Add Mesos service discovery to the Telegraf prometheus metrics input plugin\r\n\r\n\r\n## Checklist for all PRs\r\n\r\n  - [x] Added a comprehensible changelog entry to `CHANGES.md` or explain why this is not a user-facing change:\r\n  - [x] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:\r\n  - [x] Read the [DC/OS contributing guidelines](https://github.com/dcos/dcos/blob/master/contributing.md)\r\n  - [x] Followed relevant code rules [Rules for Packages and Systemd](https://github.com/dcos/dcos/tree/master/docs)\r\n\r\n\r\n## Checklist for component/package updates:\r\n\r\nIf you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath `packages`), then in addition to the above please also include:\r\n\r\n  - [x] Change log from the last version integrated (this should be a link to commits for easy verification and review): [example](https://github.com/dcos/telegraf/compare/a88d78350c9244336607e37cc808bb76a40e8b89...ba18887f5d6358e3eb73d5df7e16a2c19c3cbfda)\r\n  - [x] Test Results: [link to CI job test results for component](https://jenkins.mesosphere.com/service/jenkins/job/public-dcos-cluster-ops/job/telegraf/job/telegraf-dcos-pulls/161/)\r\n  - [x] Code Coverage (if available): [link to code coverage report](https://jenkins.mesosphere.com/service/jenkins/job/public-dcos-cluster-ops/job/telegraf/job/telegraf-dcos-pulls/161/)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/dcos/dcos/issues/comments/448369221","html_url":"https://github.com/dcos/dcos/pull/3940#issuecomment-448369221","issue_url":"https://api.github.com/repos/dcos/dcos/issues/3940","id":448369221,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0ODM2OTIyMQ==","user":{"login":"mesosphere-mergebot","id":22822961,"node_id":"MDQ6VXNlcjIyODIyOTYx","avatar_url":"https://avatars3.githubusercontent.com/u/22822961?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere-mergebot","html_url":"https://github.com/mesosphere-mergebot","followers_url":"https://api.github.com/users/mesosphere-mergebot/followers","following_url":"https://api.github.com/users/mesosphere-mergebot/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere-mergebot/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere-mergebot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere-mergebot/subscriptions","organizations_url":"https://api.github.com/users/mesosphere-mergebot/orgs","repos_url":"https://api.github.com/users/mesosphere-mergebot/repos","events_url":"https://api.github.com/users/mesosphere-mergebot/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere-mergebot/received_events","type":"User","site_admin":false},"created_at":"2018-12-18T21:02:35Z","updated_at":"2018-12-18T21:02:35Z","author_association":"COLLABORATOR","body":"Your pull request's branch is not based on the most recent version of `master`. Please rebase your changes against this repo's `master` branch."}}
{"actor":{"display_login":"mesosphere-mergebot"}}