{"action":"created","comment":{"url":"https://api.github.com/repos/mudcoders/guildmud/pulls/comments/176956143","pull_request_review_id":106745508,"id":176956143,"diff_hunk":"@@ -742,10 +745,21 @@ void next_cmd_from_buffer(D_SOCKET *dsock)\n     {\n       telopt = 1;\n     }\n-    else if (telopt == 1 && (dsock->inbuf[i] == (signed char) DO || dsock->inbuf[i] == (signed char) DONT))\n+    else if (telopt == 1\n+             && (dsock->inbuf[i] == (signed char) DO\n+                 || dsock->inbuf[i] == (signed char) DONT\n+                 || dsock->inbuf[i] == (signed char) SB))\n     {\n       telopt = 2;\n     }\n+    else if (telopt == 1 && gmcp && dsock->inbuf[i] == (signed char) SE)\n+    {\n+      telopt = 0;\n+      gmcp = FALSE;\n+      dsock->next_command[j] = '\\0';\n+      gmcpReceived(dsock);\n+      dsock->next_command[j = 0] = '\\0';","path":"src/socket.c","position":42,"original_position":42,"commit_id":"7278b90780462c5f1b24b447d03db67ebc64787d","original_commit_id":"7278b90780462c5f1b24b447d03db67ebc64787d","user":{"login":"LiquidityC","id":164039,"avatar_url":"https://avatars2.githubusercontent.com/u/164039?v=4","gravatar_id":"","url":"https://api.github.com/users/LiquidityC","html_url":"https://github.com/LiquidityC","followers_url":"https://api.github.com/users/LiquidityC/followers","following_url":"https://api.github.com/users/LiquidityC/following{/other_user}","gists_url":"https://api.github.com/users/LiquidityC/gists{/gist_id}","starred_url":"https://api.github.com/users/LiquidityC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiquidityC/subscriptions","organizations_url":"https://api.github.com/users/LiquidityC/orgs","repos_url":"https://api.github.com/users/LiquidityC/repos","events_url":"https://api.github.com/users/LiquidityC/events{/privacy}","received_events_url":"https://api.github.com/users/LiquidityC/received_events","type":"User","site_admin":false},"body":"Might be. But I think it's one of those, \"once you extend it you can clean it up a bit\" situations. :D\r\n\r\nDidn't want to overthink things now since I don't know how it will be used in the future.\r\n\r\n","created_at":"2018-03-25T22:07:06Z","updated_at":"2018-03-25T22:07:06Z","html_url":"https://github.com/mudcoders/guildmud/pull/24#discussion_r176956143","pull_request_url":"https://api.github.com/repos/mudcoders/guildmud/pulls/24","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/mudcoders/guildmud/pulls/comments/176956143"},"html":{"href":"https://github.com/mudcoders/guildmud/pull/24#discussion_r176956143"},"pull_request":{"href":"https://api.github.com/repos/mudcoders/guildmud/pulls/24"}},"in_reply_to_id":176918195},"pull_request":{"url":"https://api.github.com/repos/mudcoders/guildmud/pulls/24","id":176770369,"html_url":"https://github.com/mudcoders/guildmud/pull/24","diff_url":"https://github.com/mudcoders/guildmud/pull/24.diff","patch_url":"https://github.com/mudcoders/guildmud/pull/24.patch","issue_url":"https://api.github.com/repos/mudcoders/guildmud/issues/24","number":24,"state":"open","locked":false,"title":"Adds gmcp support","user":{"login":"LiquidityC","id":164039,"avatar_url":"https://avatars2.githubusercontent.com/u/164039?v=4","gravatar_id":"","url":"https://api.github.com/users/LiquidityC","html_url":"https://github.com/LiquidityC","followers_url":"https://api.github.com/users/LiquidityC/followers","following_url":"https://api.github.com/users/LiquidityC/following{/other_user}","gists_url":"https://api.github.com/users/LiquidityC/gists{/gist_id}","starred_url":"https://api.github.com/users/LiquidityC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiquidityC/subscriptions","organizations_url":"https://api.github.com/users/LiquidityC/orgs","repos_url":"https://api.github.com/users/LiquidityC/repos","events_url":"https://api.github.com/users/LiquidityC/events{/privacy}","received_events_url":"https://api.github.com/users/LiquidityC/received_events","type":"User","site_admin":false},"body":"I added an embryo of GMCP support. It's usable and works. I'd love some comments. And if it's approved I think it's up to someone with a bigger perspective on the project to decide how to use it. Some sort of JSON module would likely help.\r\n\r\nPlease get back with any improvement suggestions etc. I'm not assuming this will go straight into the devel branch ;)","created_at":"2018-03-22T13:01:00Z","updated_at":"2018-03-25T22:07:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f92fae8bb9b50ae0b3457fd23196dde5d80c71f6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mudcoders/guildmud/pulls/24/commits","review_comments_url":"https://api.github.com/repos/mudcoders/guildmud/pulls/24/comments","review_comment_url":"https://api.github.com/repos/mudcoders/guildmud/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mudcoders/guildmud/issues/24/comments","statuses_url":"https://api.github.com/repos/mudcoders/guildmud/statuses/7278b90780462c5f1b24b447d03db67ebc64787d","head":{"label":"LiquidityC:add_gmcp_support","ref":"add_gmcp_support","sha":"7278b90780462c5f1b24b447d03db67ebc64787d","user":{"login":"LiquidityC","id":164039,"avatar_url":"https://avatars2.githubusercontent.com/u/164039?v=4","gravatar_id":"","url":"https://api.github.com/users/LiquidityC","html_url":"https://github.com/LiquidityC","followers_url":"https://api.github.com/users/LiquidityC/followers","following_url":"https://api.github.com/users/LiquidityC/following{/other_user}","gists_url":"https://api.github.com/users/LiquidityC/gists{/gist_id}","starred_url":"https://api.github.com/users/LiquidityC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiquidityC/subscriptions","organizations_url":"https://api.github.com/users/LiquidityC/orgs","repos_url":"https://api.github.com/users/LiquidityC/repos","events_url":"https://api.github.com/users/LiquidityC/events{/privacy}","received_events_url":"https://api.github.com/users/LiquidityC/received_events","type":"User","site_admin":false},"repo":{"id":126300863,"name":"guildmud","full_name":"LiquidityC/guildmud","owner":{"login":"LiquidityC","id":164039,"avatar_url":"https://avatars2.githubusercontent.com/u/164039?v=4","gravatar_id":"","url":"https://api.github.com/users/LiquidityC","html_url":"https://github.com/LiquidityC","followers_url":"https://api.github.com/users/LiquidityC/followers","following_url":"https://api.github.com/users/LiquidityC/following{/other_user}","gists_url":"https://api.github.com/users/LiquidityC/gists{/gist_id}","starred_url":"https://api.github.com/users/LiquidityC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiquidityC/subscriptions","organizations_url":"https://api.github.com/users/LiquidityC/orgs","repos_url":"https://api.github.com/users/LiquidityC/repos","events_url":"https://api.github.com/users/LiquidityC/events{/privacy}","received_events_url":"https://api.github.com/users/LiquidityC/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LiquidityC/guildmud","description":"A SocketMUD-based Multi-User Dungeon built and managed by the members of The MUD Coders Guild.","fork":true,"url":"https://api.github.com/repos/LiquidityC/guildmud","forks_url":"https://api.github.com/repos/LiquidityC/guildmud/forks","keys_url":"https://api.github.com/repos/LiquidityC/guildmud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LiquidityC/guildmud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LiquidityC/guildmud/teams","hooks_url":"https://api.github.com/repos/LiquidityC/guildmud/hooks","issue_events_url":"https://api.github.com/repos/LiquidityC/guildmud/issues/events{/number}","events_url":"https://api.github.com/repos/LiquidityC/guildmud/events","assignees_url":"https://api.github.com/repos/LiquidityC/guildmud/assignees{/user}","branches_url":"https://api.github.com/repos/LiquidityC/guildmud/branches{/branch}","tags_url":"https://api.github.com/repos/LiquidityC/guildmud/tags","blobs_url":"https://api.github.com/repos/LiquidityC/guildmud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LiquidityC/guildmud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LiquidityC/guildmud/git/refs{/sha}","trees_url":"https://api.github.com/repos/LiquidityC/guildmud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LiquidityC/guildmud/statuses/{sha}","languages_url":"https://api.github.com/repos/LiquidityC/guildmud/languages","stargazers_url":"https://api.github.com/repos/LiquidityC/guildmud/stargazers","contributors_url":"https://api.github.com/repos/LiquidityC/guildmud/contributors","subscribers_url":"https://api.github.com/repos/LiquidityC/guildmud/subscribers","subscription_url":"https://api.github.com/repos/LiquidityC/guildmud/subscription","commits_url":"https://api.github.com/repos/LiquidityC/guildmud/commits{/sha}","git_commits_url":"https://api.github.com/repos/LiquidityC/guildmud/git/commits{/sha}","comments_url":"https://api.github.com/repos/LiquidityC/guildmud/comments{/number}","issue_comment_url":"https://api.github.com/repos/LiquidityC/guildmud/issues/comments{/number}","contents_url":"https://api.github.com/repos/LiquidityC/guildmud/contents/{+path}","compare_url":"https://api.github.com/repos/LiquidityC/guildmud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LiquidityC/guildmud/merges","archive_url":"https://api.github.com/repos/LiquidityC/guildmud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LiquidityC/guildmud/downloads","issues_url":"https://api.github.com/repos/LiquidityC/guildmud/issues{/number}","pulls_url":"https://api.github.com/repos/LiquidityC/guildmud/pulls{/number}","milestones_url":"https://api.github.com/repos/LiquidityC/guildmud/milestones{/number}","notifications_url":"https://api.github.com/repos/LiquidityC/guildmud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LiquidityC/guildmud/labels{/name}","releases_url":"https://api.github.com/repos/LiquidityC/guildmud/releases{/id}","deployments_url":"https://api.github.com/repos/LiquidityC/guildmud/deployments","created_at":"2018-03-22T08:05:32Z","updated_at":"2018-03-22T08:05:34Z","pushed_at":"2018-03-22T19:13:18Z","git_url":"git://github.com/LiquidityC/guildmud.git","ssh_url":"git@github.com:LiquidityC/guildmud.git","clone_url":"https://github.com/LiquidityC/guildmud.git","svn_url":"https://github.com/LiquidityC/guildmud","homepage":"","size":100,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"mudcoders:develop","ref":"develop","sha":"66e8c461ebaee90f90f0856b792b3e74db0ede46","user":{"login":"mudcoders","id":17859886,"avatar_url":"https://avatars2.githubusercontent.com/u/17859886?v=4","gravatar_id":"","url":"https://api.github.com/users/mudcoders","html_url":"https://github.com/mudcoders","followers_url":"https://api.github.com/users/mudcoders/followers","following_url":"https://api.github.com/users/mudcoders/following{/other_user}","gists_url":"https://api.github.com/users/mudcoders/gists{/gist_id}","starred_url":"https://api.github.com/users/mudcoders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mudcoders/subscriptions","organizations_url":"https://api.github.com/users/mudcoders/orgs","repos_url":"https://api.github.com/users/mudcoders/repos","events_url":"https://api.github.com/users/mudcoders/events{/privacy}","received_events_url":"https://api.github.com/users/mudcoders/received_events","type":"Organization","site_admin":false},"repo":{"id":118978584,"name":"guildmud","full_name":"mudcoders/guildmud","owner":{"login":"mudcoders","id":17859886,"avatar_url":"https://avatars2.githubusercontent.com/u/17859886?v=4","gravatar_id":"","url":"https://api.github.com/users/mudcoders","html_url":"https://github.com/mudcoders","followers_url":"https://api.github.com/users/mudcoders/followers","following_url":"https://api.github.com/users/mudcoders/following{/other_user}","gists_url":"https://api.github.com/users/mudcoders/gists{/gist_id}","starred_url":"https://api.github.com/users/mudcoders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mudcoders/subscriptions","organizations_url":"https://api.github.com/users/mudcoders/orgs","repos_url":"https://api.github.com/users/mudcoders/repos","events_url":"https://api.github.com/users/mudcoders/events{/privacy}","received_events_url":"https://api.github.com/users/mudcoders/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mudcoders/guildmud","description":"A SocketMUD-based Multi-User Dungeon built and managed by the members of The MUD Coders Guild.","fork":false,"url":"https://api.github.com/repos/mudcoders/guildmud","forks_url":"https://api.github.com/repos/mudcoders/guildmud/forks","keys_url":"https://api.github.com/repos/mudcoders/guildmud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mudcoders/guildmud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mudcoders/guildmud/teams","hooks_url":"https://api.github.com/repos/mudcoders/guildmud/hooks","issue_events_url":"https://api.github.com/repos/mudcoders/guildmud/issues/events{/number}","events_url":"https://api.github.com/repos/mudcoders/guildmud/events","assignees_url":"https://api.github.com/repos/mudcoders/guildmud/assignees{/user}","branches_url":"https://api.github.com/repos/mudcoders/guildmud/branches{/branch}","tags_url":"https://api.github.com/repos/mudcoders/guildmud/tags","blobs_url":"https://api.github.com/repos/mudcoders/guildmud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mudcoders/guildmud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mudcoders/guildmud/git/refs{/sha}","trees_url":"https://api.github.com/repos/mudcoders/guildmud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mudcoders/guildmud/statuses/{sha}","languages_url":"https://api.github.com/repos/mudcoders/guildmud/languages","stargazers_url":"https://api.github.com/repos/mudcoders/guildmud/stargazers","contributors_url":"https://api.github.com/repos/mudcoders/guildmud/contributors","subscribers_url":"https://api.github.com/repos/mudcoders/guildmud/subscribers","subscription_url":"https://api.github.com/repos/mudcoders/guildmud/subscription","commits_url":"https://api.github.com/repos/mudcoders/guildmud/commits{/sha}","git_commits_url":"https://api.github.com/repos/mudcoders/guildmud/git/commits{/sha}","comments_url":"https://api.github.com/repos/mudcoders/guildmud/comments{/number}","issue_comment_url":"https://api.github.com/repos/mudcoders/guildmud/issues/comments{/number}","contents_url":"https://api.github.com/repos/mudcoders/guildmud/contents/{+path}","compare_url":"https://api.github.com/repos/mudcoders/guildmud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mudcoders/guildmud/merges","archive_url":"https://api.github.com/repos/mudcoders/guildmud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mudcoders/guildmud/downloads","issues_url":"https://api.github.com/repos/mudcoders/guildmud/issues{/number}","pulls_url":"https://api.github.com/repos/mudcoders/guildmud/pulls{/number}","milestones_url":"https://api.github.com/repos/mudcoders/guildmud/milestones{/number}","notifications_url":"https://api.github.com/repos/mudcoders/guildmud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mudcoders/guildmud/labels{/name}","releases_url":"https://api.github.com/repos/mudcoders/guildmud/releases{/id}","deployments_url":"https://api.github.com/repos/mudcoders/guildmud/deployments","created_at":"2018-01-25T23:12:54Z","updated_at":"2018-03-24T07:57:14Z","pushed_at":"2018-03-23T13:34:42Z","git_url":"git://github.com/mudcoders/guildmud.git","ssh_url":"git@github.com:mudcoders/guildmud.git","clone_url":"https://github.com/mudcoders/guildmud.git","svn_url":"https://github.com/mudcoders/guildmud","homepage":"","size":99,"stargazers_count":13,"watchers_count":13,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":8,"open_issues":3,"watchers":13,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/mudcoders/guildmud/pulls/24"},"html":{"href":"https://github.com/mudcoders/guildmud/pull/24"},"issue":{"href":"https://api.github.com/repos/mudcoders/guildmud/issues/24"},"comments":{"href":"https://api.github.com/repos/mudcoders/guildmud/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/mudcoders/guildmud/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/mudcoders/guildmud/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mudcoders/guildmud/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/mudcoders/guildmud/statuses/7278b90780462c5f1b24b447d03db67ebc64787d"}},"author_association":"NONE"}}
{"actor":{"display_login":"LiquidityC"}}