{"action":"closed","issue":{"url":"https://api.github.com/repos/Automattic/mongoose/issues/6718","repository_url":"https://api.github.com/repos/Automattic/mongoose","labels_url":"https://api.github.com/repos/Automattic/mongoose/issues/6718/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/mongoose/issues/6718/comments","events_url":"https://api.github.com/repos/Automattic/mongoose/issues/6718/events","html_url":"https://github.com/Automattic/mongoose/issues/6718","id":340714634,"node_id":"MDU6SXNzdWUzNDA3MTQ2MzQ=","number":6718,"title":"KeepAlive mongodb-core 3.1 changes","user":{"login":"simllll","id":5757263,"node_id":"MDQ6VXNlcjU3NTcyNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/5757263?v=4","gravatar_id":"","url":"https://api.github.com/users/simllll","html_url":"https://github.com/simllll","followers_url":"https://api.github.com/users/simllll/followers","following_url":"https://api.github.com/users/simllll/following{/other_user}","gists_url":"https://api.github.com/users/simllll/gists{/gist_id}","starred_url":"https://api.github.com/users/simllll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simllll/subscriptions","organizations_url":"https://api.github.com/users/simllll/orgs","repos_url":"https://api.github.com/users/simllll/repos","events_url":"https://api.github.com/users/simllll/events{/privacy}","received_events_url":"https://api.github.com/users/simllll/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-12T16:39:58Z","updated_at":"2018-07-15T18:14:06Z","closed_at":"2018-07-15T18:14:06Z","author_association":"CONTRIBUTOR","body":"This is a wrong/missing documentation \"bug\":\r\n\r\nIn mongodb-native they have changed the \"keepalive\" paramtere. it is now a boolean, and keepAliveInitialDelay is the time to wait for a second.\r\n\r\nThis means the documentation here: http://mongoosejs.com/docs/connections.html is wrong. And should be cleaned up anyway regarding keepalive. There is a mix up of booleans and numbers.\r\n\r\nSee also http://mongodb.github.io/node-mongodb-native/3.1/api/MongoClient.html\r\nand change  notes:\r\n### `keepAlive`\r\n\r\nWherever it occurs, the option `keepAlive` has been changed. `keepAlive` is now a boolean that enables/disables `keepAlive`, while `keepAliveInitialDelay` specifies how long to wait before initiating keepAlive. This brings the API in line with [NodeJS's socket api](https://nodejs.org/dist/latest-v9.x/docs/api/all.html#net_socket_setkeepalive_enable_initialdelay)\r\n\r\nkeepAlive | boolean | true | optionalTCP Connection keep alive enabled\r\n-- | -- | -- | --\r\nkeepAliveInitialDelay | number | 30000 | optionalThe number of milliseconds to wait before initiating keepAlive on the TCP socket\r\n"}}
{"actor":{"display_login":"vkarpov15"}}