{"action":"created","issue":{"url":"https://api.github.com/repos/MaslowCNC/GroundControl/issues/603","repository_url":"https://api.github.com/repos/MaslowCNC/GroundControl","labels_url":"https://api.github.com/repos/MaslowCNC/GroundControl/issues/603/labels{/name}","comments_url":"https://api.github.com/repos/MaslowCNC/GroundControl/issues/603/comments","events_url":"https://api.github.com/repos/MaslowCNC/GroundControl/issues/603/events","html_url":"https://github.com/MaslowCNC/GroundControl/issues/603","id":293658755,"number":603,"title":"Machine won't start again after pressing stop","user":{"login":"BarbourSmith","id":9359447,"avatar_url":"https://avatars0.githubusercontent.com/u/9359447?v=4","gravatar_id":"","url":"https://api.github.com/users/BarbourSmith","html_url":"https://github.com/BarbourSmith","followers_url":"https://api.github.com/users/BarbourSmith/followers","following_url":"https://api.github.com/users/BarbourSmith/following{/other_user}","gists_url":"https://api.github.com/users/BarbourSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/BarbourSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BarbourSmith/subscriptions","organizations_url":"https://api.github.com/users/BarbourSmith/orgs","repos_url":"https://api.github.com/users/BarbourSmith/repos","events_url":"https://api.github.com/users/BarbourSmith/events{/privacy}","received_events_url":"https://api.github.com/users/BarbourSmith/received_events","type":"User","site_admin":false},"labels":[{"id":140588403,"url":"https://api.github.com/repos/MaslowCNC/GroundControl/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":{"login":"BarbourSmith","id":9359447,"avatar_url":"https://avatars0.githubusercontent.com/u/9359447?v=4","gravatar_id":"","url":"https://api.github.com/users/BarbourSmith","html_url":"https://github.com/BarbourSmith","followers_url":"https://api.github.com/users/BarbourSmith/followers","following_url":"https://api.github.com/users/BarbourSmith/following{/other_user}","gists_url":"https://api.github.com/users/BarbourSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/BarbourSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BarbourSmith/subscriptions","organizations_url":"https://api.github.com/users/BarbourSmith/orgs","repos_url":"https://api.github.com/users/BarbourSmith/repos","events_url":"https://api.github.com/users/BarbourSmith/events{/privacy}","received_events_url":"https://api.github.com/users/BarbourSmith/received_events","type":"User","site_admin":false},"assignees":[{"login":"BarbourSmith","id":9359447,"avatar_url":"https://avatars0.githubusercontent.com/u/9359447?v=4","gravatar_id":"","url":"https://api.github.com/users/BarbourSmith","html_url":"https://github.com/BarbourSmith","followers_url":"https://api.github.com/users/BarbourSmith/followers","following_url":"https://api.github.com/users/BarbourSmith/following{/other_user}","gists_url":"https://api.github.com/users/BarbourSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/BarbourSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BarbourSmith/subscriptions","organizations_url":"https://api.github.com/users/BarbourSmith/orgs","repos_url":"https://api.github.com/users/BarbourSmith/repos","events_url":"https://api.github.com/users/BarbourSmith/events{/privacy}","received_events_url":"https://api.github.com/users/BarbourSmith/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-02-01T19:43:09Z","updated_at":"2018-02-01T23:09:48Z","closed_at":null,"author_association":"OWNER","body":"For some reason my machine has stopped starting again after the stop button is pressed. It will stop immediately, but not move again until GC is restarted. \r\n\r\nThis is a new behavior."},"comment":{"url":"https://api.github.com/repos/MaslowCNC/GroundControl/issues/comments/362432828","html_url":"https://github.com/MaslowCNC/GroundControl/issues/603#issuecomment-362432828","issue_url":"https://api.github.com/repos/MaslowCNC/GroundControl/issues/603","id":362432828,"user":{"login":"BarbourSmith","id":9359447,"avatar_url":"https://avatars0.githubusercontent.com/u/9359447?v=4","gravatar_id":"","url":"https://api.github.com/users/BarbourSmith","html_url":"https://github.com/BarbourSmith","followers_url":"https://api.github.com/users/BarbourSmith/followers","following_url":"https://api.github.com/users/BarbourSmith/following{/other_user}","gists_url":"https://api.github.com/users/BarbourSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/BarbourSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BarbourSmith/subscriptions","organizations_url":"https://api.github.com/users/BarbourSmith/orgs","repos_url":"https://api.github.com/users/BarbourSmith/repos","events_url":"https://api.github.com/users/BarbourSmith/events{/privacy}","received_events_url":"https://api.github.com/users/BarbourSmith/received_events","type":"User","site_admin":false},"created_at":"2018-02-01T23:09:48Z","updated_at":"2018-02-01T23:09:48Z","author_association":"OWNER","body":"As expertly summarized by @krkeegan :\r\n\r\n> oooh ooh, I think I understand what you are describing now.\r\n> \r\n> So let me see if I have this right.  \r\n> \r\n> 1. Send some command \"G0 X5\"\r\n> 2. While the command is executing send \"!\"\r\n> 3. Firmware sends \"ok\" response to \"!\" command\r\n> 3b. GC sees the \"ok\" recognizes that it was in response to a quick command and clears only that portion of the buffer.\r\n> 4. Firmware bails out of routines that it is running\r\n> 5. Firmware dumps contents of serial buffer\r\n> 6. Firmware waits for new commands\r\n> 7. Meanwhile GC is still waiting for confirmation of \"G0 X5\" command\r\n> 8. aaaaand we are stuck\r\n> \r\n> I think I get it.\r\n> \r\n> I see two solutions:\r\n> 1. The firmware sends the necessary \"ok\"s to clear everything\r\n> 2. GC recognizes that a stop dumps the buffer contents on the machine and clears it's own tracking buffer when it receives the stop \"ok\"\r\n> \r\n> I think this is all a matter of perspective and what we want an \"ok\" message to mean.\r\n> \r\n> I am inclined to say GC should handle this, that the firmware is correct in not sending an ok to the \"G0 X5\" command because that command never successfully completed.  Plus this design would allow us to queue more than one line on the machine (which I think we can do eventually) otherwise if we had multiple lines, we would need the firmware to say \"ok\" to those extra lines in the buffer, even though it hadn't even started performing them.\r\n> \r\n> Thoughts? I am open to considering the alternative."}}
{"actor":{"display_login":"BarbourSmith"}}