{"action":"created","issue":{"url":"https://api.github.com/repos/go-gitea/gitea/issues/3748","repository_url":"https://api.github.com/repos/go-gitea/gitea","labels_url":"https://api.github.com/repos/go-gitea/gitea/issues/3748/labels{/name}","comments_url":"https://api.github.com/repos/go-gitea/gitea/issues/3748/comments","events_url":"https://api.github.com/repos/go-gitea/gitea/issues/3748/events","html_url":"https://github.com/go-gitea/gitea/pull/3748","id":310621336,"number":3748,"title":"Pull request review/approval and comment on code","user":{"login":"lafriks","id":165205,"avatar_url":"https://avatars2.githubusercontent.com/u/165205?v=4","gravatar_id":"","url":"https://api.github.com/users/lafriks","html_url":"https://github.com/lafriks","followers_url":"https://api.github.com/users/lafriks/followers","following_url":"https://api.github.com/users/lafriks/following{/other_user}","gists_url":"https://api.github.com/users/lafriks/gists{/gist_id}","starred_url":"https://api.github.com/users/lafriks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lafriks/subscriptions","organizations_url":"https://api.github.com/users/lafriks/orgs","repos_url":"https://api.github.com/users/lafriks/repos","events_url":"https://api.github.com/users/lafriks/events{/privacy}","received_events_url":"https://api.github.com/users/lafriks/received_events","type":"User","site_admin":false},"labels":[{"id":474798837,"url":"https://api.github.com/repos/go-gitea/gitea/labels/kind/feature","name":"kind/feature","color":"006b75","default":false},{"id":475283583,"url":"https://api.github.com/repos/go-gitea/gitea/labels/lgtm/need%202","name":"lgtm/need 2","color":"d93f0b","default":false},{"id":475688599,"url":"https://api.github.com/repos/go-gitea/gitea/labels/status/wip","name":"status/wip","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/go-gitea/gitea/milestones/21","html_url":"https://github.com/go-gitea/gitea/milestone/21","labels_url":"https://api.github.com/repos/go-gitea/gitea/milestones/21/labels","id":3004249,"number":21,"title":"1.5.0","description":"","creator":{"login":"lunny","id":81045,"avatar_url":"https://avatars2.githubusercontent.com/u/81045?v=4","gravatar_id":"","url":"https://api.github.com/users/lunny","html_url":"https://github.com/lunny","followers_url":"https://api.github.com/users/lunny/followers","following_url":"https://api.github.com/users/lunny/following{/other_user}","gists_url":"https://api.github.com/users/lunny/gists{/gist_id}","starred_url":"https://api.github.com/users/lunny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lunny/subscriptions","organizations_url":"https://api.github.com/users/lunny/orgs","repos_url":"https://api.github.com/users/lunny/repos","events_url":"https://api.github.com/users/lunny/events{/privacy}","received_events_url":"https://api.github.com/users/lunny/received_events","type":"User","site_admin":false},"open_issues":42,"closed_issues":192,"state":"open","created_at":"2017-12-30T04:21:56Z","updated_at":"2018-05-13T15:22:54Z","due_on":"2018-05-23T07:00:00Z","closed_at":null},"comments":10,"created_at":"2018-04-02T21:42:22Z","updated_at":"2018-05-14T12:07:34Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/go-gitea/gitea/pulls/3748","html_url":"https://github.com/go-gitea/gitea/pull/3748","diff_url":"https://github.com/go-gitea/gitea/pull/3748.diff","patch_url":"https://github.com/go-gitea/gitea/pull/3748.patch"},"body":"This is merge of my started work on PR approval feature and @lunny comment on code.\r\n\r\nWill obsolete #2583 and resolve #124 and #3580 \r\n\r\nScreenshot:\r\n![attels](https://user-images.githubusercontent.com/165205/38217623-b8da6334-36d7-11e8-9486-fa32b9421530.png)\r\n\r\nWork needs to be done:\r\n* [x] Implement UI for code review and comments\r\n* [ ] Implement database changes and needed handlers\r\n* [ ] Review display in comment section\r\n* [ ] Add tests"},"comment":{"url":"https://api.github.com/repos/go-gitea/gitea/issues/comments/388794096","html_url":"https://github.com/go-gitea/gitea/pull/3748#issuecomment-388794096","issue_url":"https://api.github.com/repos/go-gitea/gitea/issues/3748","id":388794096,"user":{"login":"JonasFranzDEV","id":5757182,"avatar_url":"https://avatars3.githubusercontent.com/u/5757182?v=4","gravatar_id":"","url":"https://api.github.com/users/JonasFranzDEV","html_url":"https://github.com/JonasFranzDEV","followers_url":"https://api.github.com/users/JonasFranzDEV/followers","following_url":"https://api.github.com/users/JonasFranzDEV/following{/other_user}","gists_url":"https://api.github.com/users/JonasFranzDEV/gists{/gist_id}","starred_url":"https://api.github.com/users/JonasFranzDEV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonasFranzDEV/subscriptions","organizations_url":"https://api.github.com/users/JonasFranzDEV/orgs","repos_url":"https://api.github.com/users/JonasFranzDEV/repos","events_url":"https://api.github.com/users/JonasFranzDEV/events{/privacy}","received_events_url":"https://api.github.com/users/JonasFranzDEV/received_events","type":"User","site_admin":false},"created_at":"2018-05-14T12:07:34Z","updated_at":"2018-05-14T12:07:34Z","author_association":"MEMBER","body":"TODOs and other stuff from the merged PR lafriks/gitea#2:\r\n\r\n## Reviews\r\nReviews should bundle all code comments created for the initial review. All code comments created for this review are linked to the review model.\r\n\r\n## Comment types\r\n`CommentTypeCode`: A comment at a line of a code of a PR\r\n`CommentTypeReview`: Notifies the participants about the review\r\n## TODO\r\n- [x] Render code comments on the right place\r\n- [x] Add support for comments on both sides\r\n- [ ] Show code comments in the \"conversation\" after a review got submitted\r\n- [ ] Show single code comment in the \"conversation\"\r\n- [ ] Remove dummy data from \"code comment form\" (line, path, side)\r\n- [x] Add support for \"Add single comments\"\r\n- [ ] Order/Separate code comments by thread/review\r\n- [x] ~~Blocked by go-gitea/git#116~~"}}
{"actor":{"display_login":"JonasFranzDEV"}}