{"action":"created","comment":{"url":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/comments/209913398","pull_request_review_id":146017044,"id":209913398,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTkxMzM5OA==","diff_hunk":"@@ -459,7 +459,8 @@ def add_hvm_or_pv(help_text, hvm_or_pv):\n                 logging.warning(\"Unknown virt type hvm_or_pv, using default.\")\n                 return \"\"\n \n-        def add_mem(help_text, mem, maxmem=None, hugepage=False):\n+        def add_mem(help_text, mem, maxmem=None, hugepage=False,\n+                    hotplugmaxmem=None, hotplugmemslots=1):","path":"virttest/libvirt_vm.py","position":6,"original_position":6,"commit_id":"a73f6424569b7e3db2dca2208b035df57dd4a9f0","original_commit_id":"a73f6424569b7e3db2dca2208b035df57dd4a9f0","user":{"login":"balamuruhans","id":16498077,"node_id":"MDQ6VXNlcjE2NDk4MDc3","avatar_url":"https://avatars0.githubusercontent.com/u/16498077?v=4","gravatar_id":"","url":"https://api.github.com/users/balamuruhans","html_url":"https://github.com/balamuruhans","followers_url":"https://api.github.com/users/balamuruhans/followers","following_url":"https://api.github.com/users/balamuruhans/following{/other_user}","gists_url":"https://api.github.com/users/balamuruhans/gists{/gist_id}","starred_url":"https://api.github.com/users/balamuruhans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balamuruhans/subscriptions","organizations_url":"https://api.github.com/users/balamuruhans/orgs","repos_url":"https://api.github.com/users/balamuruhans/repos","events_url":"https://api.github.com/users/balamuruhans/events{/privacy}","received_events_url":"https://api.github.com/users/balamuruhans/received_events","type":"User","site_admin":false},"body":"why do we have to set `hotplugmemslot` default as 1 ?, it can be `None`","created_at":"2018-08-14T11:15:59Z","updated_at":"2018-08-14T11:17:39Z","html_url":"https://github.com/avocado-framework/avocado-vt/pull/1712#discussion_r209913398","pull_request_url":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/1712","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/comments/209913398"},"html":{"href":"https://github.com/avocado-framework/avocado-vt/pull/1712#discussion_r209913398"},"pull_request":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/1712"}}},"pull_request":{"url":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/1712","id":208237603,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MjM3NjAz","html_url":"https://github.com/avocado-framework/avocado-vt/pull/1712","diff_url":"https://github.com/avocado-framework/avocado-vt/pull/1712.diff","patch_url":"https://github.com/avocado-framework/avocado-vt/pull/1712.patch","issue_url":"https://api.github.com/repos/avocado-framework/avocado-vt/issues/1712","number":1712,"state":"open","locked":false,"title":"Add support for memory hotplug virt-install options","user":{"login":"sathnaga","id":1841809,"node_id":"MDQ6VXNlcjE4NDE4MDk=","avatar_url":"https://avatars3.githubusercontent.com/u/1841809?v=4","gravatar_id":"","url":"https://api.github.com/users/sathnaga","html_url":"https://github.com/sathnaga","followers_url":"https://api.github.com/users/sathnaga/followers","following_url":"https://api.github.com/users/sathnaga/following{/other_user}","gists_url":"https://api.github.com/users/sathnaga/gists{/gist_id}","starred_url":"https://api.github.com/users/sathnaga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sathnaga/subscriptions","organizations_url":"https://api.github.com/users/sathnaga/orgs","repos_url":"https://api.github.com/users/sathnaga/repos","events_url":"https://api.github.com/users/sathnaga/events{/privacy}","received_events_url":"https://api.github.com/users/sathnaga/received_events","type":"User","site_admin":false},"body":"Add support for memory hotplug virt-install options\r\n\r\nSigned-off-by: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>","created_at":"2018-08-14T10:34:23Z","updated_at":"2018-08-14T11:17:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5145e835f36ae3f8bdc7c564593a4b9a26940d1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/1712/commits","review_comments_url":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/1712/comments","review_comment_url":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/avocado-framework/avocado-vt/issues/1712/comments","statuses_url":"https://api.github.com/repos/avocado-framework/avocado-vt/statuses/a73f6424569b7e3db2dca2208b035df57dd4a9f0","head":{"label":"sathnaga:maxmem_virtinstall_options","ref":"maxmem_virtinstall_options","sha":"a73f6424569b7e3db2dca2208b035df57dd4a9f0","user":{"login":"sathnaga","id":1841809,"node_id":"MDQ6VXNlcjE4NDE4MDk=","avatar_url":"https://avatars3.githubusercontent.com/u/1841809?v=4","gravatar_id":"","url":"https://api.github.com/users/sathnaga","html_url":"https://github.com/sathnaga","followers_url":"https://api.github.com/users/sathnaga/followers","following_url":"https://api.github.com/users/sathnaga/following{/other_user}","gists_url":"https://api.github.com/users/sathnaga/gists{/gist_id}","starred_url":"https://api.github.com/users/sathnaga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sathnaga/subscriptions","organizations_url":"https://api.github.com/users/sathnaga/orgs","repos_url":"https://api.github.com/users/sathnaga/repos","events_url":"https://api.github.com/users/sathnaga/events{/privacy}","received_events_url":"https://api.github.com/users/sathnaga/received_events","type":"User","site_admin":false},"repo":{"id":40166495,"node_id":"MDEwOlJlcG9zaXRvcnk0MDE2NjQ5NQ==","name":"avocado-vt","full_name":"sathnaga/avocado-vt","owner":{"login":"sathnaga","id":1841809,"node_id":"MDQ6VXNlcjE4NDE4MDk=","avatar_url":"https://avatars3.githubusercontent.com/u/1841809?v=4","gravatar_id":"","url":"https://api.github.com/users/sathnaga","html_url":"https://github.com/sathnaga","followers_url":"https://api.github.com/users/sathnaga/followers","following_url":"https://api.github.com/users/sathnaga/following{/other_user}","gists_url":"https://api.github.com/users/sathnaga/gists{/gist_id}","starred_url":"https://api.github.com/users/sathnaga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sathnaga/subscriptions","organizations_url":"https://api.github.com/users/sathnaga/orgs","repos_url":"https://api.github.com/users/sathnaga/repos","events_url":"https://api.github.com/users/sathnaga/events{/privacy}","received_events_url":"https://api.github.com/users/sathnaga/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sathnaga/avocado-vt","description":"Avocado VT Plugin","fork":true,"url":"https://api.github.com/repos/sathnaga/avocado-vt","forks_url":"https://api.github.com/repos/sathnaga/avocado-vt/forks","keys_url":"https://api.github.com/repos/sathnaga/avocado-vt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sathnaga/avocado-vt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sathnaga/avocado-vt/teams","hooks_url":"https://api.github.com/repos/sathnaga/avocado-vt/hooks","issue_events_url":"https://api.github.com/repos/sathnaga/avocado-vt/issues/events{/number}","events_url":"https://api.github.com/repos/sathnaga/avocado-vt/events","assignees_url":"https://api.github.com/repos/sathnaga/avocado-vt/assignees{/user}","branches_url":"https://api.github.com/repos/sathnaga/avocado-vt/branches{/branch}","tags_url":"https://api.github.com/repos/sathnaga/avocado-vt/tags","blobs_url":"https://api.github.com/repos/sathnaga/avocado-vt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sathnaga/avocado-vt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sathnaga/avocado-vt/git/refs{/sha}","trees_url":"https://api.github.com/repos/sathnaga/avocado-vt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sathnaga/avocado-vt/statuses/{sha}","languages_url":"https://api.github.com/repos/sathnaga/avocado-vt/languages","stargazers_url":"https://api.github.com/repos/sathnaga/avocado-vt/stargazers","contributors_url":"https://api.github.com/repos/sathnaga/avocado-vt/contributors","subscribers_url":"https://api.github.com/repos/sathnaga/avocado-vt/subscribers","subscription_url":"https://api.github.com/repos/sathnaga/avocado-vt/subscription","commits_url":"https://api.github.com/repos/sathnaga/avocado-vt/commits{/sha}","git_commits_url":"https://api.github.com/repos/sathnaga/avocado-vt/git/commits{/sha}","comments_url":"https://api.github.com/repos/sathnaga/avocado-vt/comments{/number}","issue_comment_url":"https://api.github.com/repos/sathnaga/avocado-vt/issues/comments{/number}","contents_url":"https://api.github.com/repos/sathnaga/avocado-vt/contents/{+path}","compare_url":"https://api.github.com/repos/sathnaga/avocado-vt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sathnaga/avocado-vt/merges","archive_url":"https://api.github.com/repos/sathnaga/avocado-vt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sathnaga/avocado-vt/downloads","issues_url":"https://api.github.com/repos/sathnaga/avocado-vt/issues{/number}","pulls_url":"https://api.github.com/repos/sathnaga/avocado-vt/pulls{/number}","milestones_url":"https://api.github.com/repos/sathnaga/avocado-vt/milestones{/number}","notifications_url":"https://api.github.com/repos/sathnaga/avocado-vt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sathnaga/avocado-vt/labels{/name}","releases_url":"https://api.github.com/repos/sathnaga/avocado-vt/releases{/id}","deployments_url":"https://api.github.com/repos/sathnaga/avocado-vt/deployments","created_at":"2015-08-04T06:07:17Z","updated_at":"2018-08-14T10:35:12Z","pushed_at":"2018-08-14T11:02:16Z","git_url":"git://github.com/sathnaga/avocado-vt.git","ssh_url":"git@github.com:sathnaga/avocado-vt.git","clone_url":"https://github.com/sathnaga/avocado-vt.git","svn_url":"https://github.com/sathnaga/avocado-vt","homepage":"http://avocado-vt.readthedocs.org/","size":28449,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"avocado-framework:master","ref":"master","sha":"1371abb9811ac22b704aa98ca1d47ae8180a0707","user":{"login":"avocado-framework","id":7245719,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyNDU3MTk=","avatar_url":"https://avatars3.githubusercontent.com/u/7245719?v=4","gravatar_id":"","url":"https://api.github.com/users/avocado-framework","html_url":"https://github.com/avocado-framework","followers_url":"https://api.github.com/users/avocado-framework/followers","following_url":"https://api.github.com/users/avocado-framework/following{/other_user}","gists_url":"https://api.github.com/users/avocado-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/avocado-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avocado-framework/subscriptions","organizations_url":"https://api.github.com/users/avocado-framework/orgs","repos_url":"https://api.github.com/users/avocado-framework/repos","events_url":"https://api.github.com/users/avocado-framework/events{/privacy}","received_events_url":"https://api.github.com/users/avocado-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":36371959,"node_id":"MDEwOlJlcG9zaXRvcnkzNjM3MTk1OQ==","name":"avocado-vt","full_name":"avocado-framework/avocado-vt","owner":{"login":"avocado-framework","id":7245719,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyNDU3MTk=","avatar_url":"https://avatars3.githubusercontent.com/u/7245719?v=4","gravatar_id":"","url":"https://api.github.com/users/avocado-framework","html_url":"https://github.com/avocado-framework","followers_url":"https://api.github.com/users/avocado-framework/followers","following_url":"https://api.github.com/users/avocado-framework/following{/other_user}","gists_url":"https://api.github.com/users/avocado-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/avocado-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avocado-framework/subscriptions","organizations_url":"https://api.github.com/users/avocado-framework/orgs","repos_url":"https://api.github.com/users/avocado-framework/repos","events_url":"https://api.github.com/users/avocado-framework/events{/privacy}","received_events_url":"https://api.github.com/users/avocado-framework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/avocado-framework/avocado-vt","description":"Avocado VT Plugin","fork":false,"url":"https://api.github.com/repos/avocado-framework/avocado-vt","forks_url":"https://api.github.com/repos/avocado-framework/avocado-vt/forks","keys_url":"https://api.github.com/repos/avocado-framework/avocado-vt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/avocado-framework/avocado-vt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/avocado-framework/avocado-vt/teams","hooks_url":"https://api.github.com/repos/avocado-framework/avocado-vt/hooks","issue_events_url":"https://api.github.com/repos/avocado-framework/avocado-vt/issues/events{/number}","events_url":"https://api.github.com/repos/avocado-framework/avocado-vt/events","assignees_url":"https://api.github.com/repos/avocado-framework/avocado-vt/assignees{/user}","branches_url":"https://api.github.com/repos/avocado-framework/avocado-vt/branches{/branch}","tags_url":"https://api.github.com/repos/avocado-framework/avocado-vt/tags","blobs_url":"https://api.github.com/repos/avocado-framework/avocado-vt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/avocado-framework/avocado-vt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/avocado-framework/avocado-vt/git/refs{/sha}","trees_url":"https://api.github.com/repos/avocado-framework/avocado-vt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/avocado-framework/avocado-vt/statuses/{sha}","languages_url":"https://api.github.com/repos/avocado-framework/avocado-vt/languages","stargazers_url":"https://api.github.com/repos/avocado-framework/avocado-vt/stargazers","contributors_url":"https://api.github.com/repos/avocado-framework/avocado-vt/contributors","subscribers_url":"https://api.github.com/repos/avocado-framework/avocado-vt/subscribers","subscription_url":"https://api.github.com/repos/avocado-framework/avocado-vt/subscription","commits_url":"https://api.github.com/repos/avocado-framework/avocado-vt/commits{/sha}","git_commits_url":"https://api.github.com/repos/avocado-framework/avocado-vt/git/commits{/sha}","comments_url":"https://api.github.com/repos/avocado-framework/avocado-vt/comments{/number}","issue_comment_url":"https://api.github.com/repos/avocado-framework/avocado-vt/issues/comments{/number}","contents_url":"https://api.github.com/repos/avocado-framework/avocado-vt/contents/{+path}","compare_url":"https://api.github.com/repos/avocado-framework/avocado-vt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/avocado-framework/avocado-vt/merges","archive_url":"https://api.github.com/repos/avocado-framework/avocado-vt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/avocado-framework/avocado-vt/downloads","issues_url":"https://api.github.com/repos/avocado-framework/avocado-vt/issues{/number}","pulls_url":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls{/number}","milestones_url":"https://api.github.com/repos/avocado-framework/avocado-vt/milestones{/number}","notifications_url":"https://api.github.com/repos/avocado-framework/avocado-vt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/avocado-framework/avocado-vt/labels{/name}","releases_url":"https://api.github.com/repos/avocado-framework/avocado-vt/releases{/id}","deployments_url":"https://api.github.com/repos/avocado-framework/avocado-vt/deployments","created_at":"2015-05-27T14:22:13Z","updated_at":"2018-08-14T09:34:39Z","pushed_at":"2018-08-14T11:10:16Z","git_url":"git://github.com/avocado-framework/avocado-vt.git","ssh_url":"git@github.com:avocado-framework/avocado-vt.git","clone_url":"https://github.com/avocado-framework/avocado-vt.git","svn_url":"https://github.com/avocado-framework/avocado-vt","homepage":"http://avocado-vt.readthedocs.org/","size":28497,"stargazers_count":34,"watchers_count":34,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":140,"mirror_url":null,"archived":false,"open_issues_count":129,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":140,"open_issues":129,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/1712"},"html":{"href":"https://github.com/avocado-framework/avocado-vt/pull/1712"},"issue":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/issues/1712"},"comments":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/issues/1712/comments"},"review_comments":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/1712/comments"},"review_comment":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/1712/commits"},"statuses":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/statuses/a73f6424569b7e3db2dca2208b035df57dd4a9f0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"balamuruhans"}}