{"action":"created","issue":{"url":"https://api.github.com/repos/ember-learn/ember-styleguide/issues/102","repository_url":"https://api.github.com/repos/ember-learn/ember-styleguide","labels_url":"https://api.github.com/repos/ember-learn/ember-styleguide/issues/102/labels{/name}","comments_url":"https://api.github.com/repos/ember-learn/ember-styleguide/issues/102/comments","events_url":"https://api.github.com/repos/ember-learn/ember-styleguide/issues/102/events","html_url":"https://github.com/ember-learn/ember-styleguide/pull/102","id":367655382,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMDE1NzMz","number":102,"title":"General fixes - remove excess padding, remove display flex, fixing logo","user":{"login":"mansona","id":594890,"node_id":"MDQ6VXNlcjU5NDg5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/594890?v=4","gravatar_id":"","url":"https://api.github.com/users/mansona","html_url":"https://github.com/mansona","followers_url":"https://api.github.com/users/mansona/followers","following_url":"https://api.github.com/users/mansona/following{/other_user}","gists_url":"https://api.github.com/users/mansona/gists{/gist_id}","starred_url":"https://api.github.com/users/mansona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mansona/subscriptions","organizations_url":"https://api.github.com/users/mansona/orgs","repos_url":"https://api.github.com/users/mansona/repos","events_url":"https://api.github.com/users/mansona/events{/privacy}","received_events_url":"https://api.github.com/users/mansona/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-08T06:42:22Z","updated_at":"2018-10-08T07:31:32Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/ember-learn/ember-styleguide/pulls/102","html_url":"https://github.com/ember-learn/ember-styleguide/pull/102","diff_url":"https://github.com/ember-learn/ember-styleguide/pull/102.diff","patch_url":"https://github.com/ember-learn/ember-styleguide/pull/102.patch"},"body":"I have checked this locally and it does fix https://github.com/ember-learn/guides-app/pull/252 👍 \r\n\r\nThis has a bunch of changes that will allow the Percy build to pass for Guides App: \r\n\r\n- removing excessive padding from section styles\r\n- removing `display: flex` from section styles (allow apps to define that themselves)\r\n- adding \"no padding for first paragraph\" styles for cases where the first paragraph is in a section\r\n- fixing the ember logo SVGJar issue (not found because it was in the wrong public folder)"},"comment":{"url":"https://api.github.com/repos/ember-learn/ember-styleguide/issues/comments/427743060","html_url":"https://github.com/ember-learn/ember-styleguide/pull/102#issuecomment-427743060","issue_url":"https://api.github.com/repos/ember-learn/ember-styleguide/issues/102","id":427743060,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzc0MzA2MA==","user":{"login":"mansona","id":594890,"node_id":"MDQ6VXNlcjU5NDg5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/594890?v=4","gravatar_id":"","url":"https://api.github.com/users/mansona","html_url":"https://github.com/mansona","followers_url":"https://api.github.com/users/mansona/followers","following_url":"https://api.github.com/users/mansona/following{/other_user}","gists_url":"https://api.github.com/users/mansona/gists{/gist_id}","starred_url":"https://api.github.com/users/mansona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mansona/subscriptions","organizations_url":"https://api.github.com/users/mansona/orgs","repos_url":"https://api.github.com/users/mansona/repos","events_url":"https://api.github.com/users/mansona/events{/privacy}","received_events_url":"https://api.github.com/users/mansona/received_events","type":"User","site_admin":false},"created_at":"2018-10-08T07:31:32Z","updated_at":"2018-10-08T07:31:32Z","author_association":"MEMBER","body":"It looks like the changes I have made to the location of the logo haven't actually worked 🤔 https://percy.io/Ember/guides-app/builds/1065954?utm_campaign=Ember&utm_content=guides-app&utm_source=github_status\r\n\r\nI have a feeling there is a different behavior depending on if you are running this linked vs installed from elsewhere 🤔 is there any particular reason why we're using SVGJar? Does anyone object to us removing it? "}}
{"actor":{"display_login":"mansona"}}