{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments/199329829","pull_request_review_id":133433760,"id":199329829,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTMyOTgyOQ==","diff_hunk":"@@ -360,21 +360,24 @@ NNVM_REGISTER_OP(take)\n \n This function slices the input array along a particular axis with the provided indices.\n \n-Given an input array with shape ``(d0, d1, d2)`` and indices with shape ``(i0, i1)``, the output\n-will have shape ``(i0, i1, d1, d2)``, computed by::\n+Given an input tensor with shape ``(d0, d1, d2)`` and indices with shape ``(i0, i1)``, and axis=1,\n+the output will have shape ``(d0, i0, i1, d2)``, computed by::\n \n-  output[i,j,:,:] = input[indices[i,j],:,:]\n+  output[:,i,j,:] = input[:,indices[i,j],:]\n \n .. note::\n-   - `axis`- Only slicing along axis 0 is supported for now.\n-   - `mode`- Only `clip` mode is supported for now.\n+   - `axis`- Could be from -r to r-1 where r is the rank of input tensor\n+   - `mode`- Could be either `clip` or `wrap`.","path":"src/operator/tensor/indexing_op.cc","position":16,"original_position":16,"commit_id":"fdd788f27b47dbf00fb9790612930701abefb5d1","original_commit_id":"fdd788f27b47dbf00fb9790612930701abefb5d1","user":{"login":"szha","id":2626883,"node_id":"MDQ6VXNlcjI2MjY4ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/2626883?v=4","gravatar_id":"","url":"https://api.github.com/users/szha","html_url":"https://github.com/szha","followers_url":"https://api.github.com/users/szha/followers","following_url":"https://api.github.com/users/szha/following{/other_user}","gists_url":"https://api.github.com/users/szha/gists{/gist_id}","starred_url":"https://api.github.com/users/szha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szha/subscriptions","organizations_url":"https://api.github.com/users/szha/orgs","repos_url":"https://api.github.com/users/szha/repos","events_url":"https://api.github.com/users/szha/events{/privacy}","received_events_url":"https://api.github.com/users/szha/received_events","type":"User","site_admin":false},"body":"You can move this explanation to the respective arguments and delete the note.","created_at":"2018-06-30T19:00:23Z","updated_at":"2018-06-30T19:00:24Z","html_url":"https://github.com/apache/incubator-mxnet/pull/11326#discussion_r199329829","pull_request_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/11326","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments/199329829"},"html":{"href":"https://github.com/apache/incubator-mxnet/pull/11326#discussion_r199329829"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/11326"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/11326","id":195597497,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NTk3NDk3","html_url":"https://github.com/apache/incubator-mxnet/pull/11326","diff_url":"https://github.com/apache/incubator-mxnet/pull/11326.diff","patch_url":"https://github.com/apache/incubator-mxnet/pull/11326.patch","issue_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/11326","number":11326,"state":"open","locked":false,"title":"[MXNET-381] Enhancement of take operator","user":{"login":"haojin2","id":11465736,"node_id":"MDQ6VXNlcjExNDY1NzM2","avatar_url":"https://avatars3.githubusercontent.com/u/11465736?v=4","gravatar_id":"","url":"https://api.github.com/users/haojin2","html_url":"https://github.com/haojin2","followers_url":"https://api.github.com/users/haojin2/followers","following_url":"https://api.github.com/users/haojin2/following{/other_user}","gists_url":"https://api.github.com/users/haojin2/gists{/gist_id}","starred_url":"https://api.github.com/users/haojin2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haojin2/subscriptions","organizations_url":"https://api.github.com/users/haojin2/orgs","repos_url":"https://api.github.com/users/haojin2/repos","events_url":"https://api.github.com/users/haojin2/events{/privacy}","received_events_url":"https://api.github.com/users/haojin2/received_events","type":"User","site_admin":false},"body":"## Description ##\r\nPreviously our `take` operator only supports axis=0 and mode = 'clip' case, this PR adds support for axis in range [-r, r-1] and an additional mode 'wrap'.\r\n\r\n## Checklist ##\r\n### Essentials ###\r\n- [x] Changes are complete (i.e. I finished coding on this PR)\r\n- [x] All changes have test coverage:\r\n- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)\r\n- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)\r\n- Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)\r\n- [x] Code is well-documented: \r\n- For user-facing API changes, API doc string has been updated. \r\n- For new C++ functions in header files, their functionalities and arguments are documented. \r\n- For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable\r\n- Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html\r\n- [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change\r\n\r\n### Changes ###\r\n- [x] Support for take on any dimension\r\n- [x] New mode 'wrap' for indices\r\n- [x] Unit tests for enhanced take operator\r\n\r\n## Comments ##\r\nThe legacy implementation for axis=0 and mode='clip' is still preserved to ensure there's no performance or accuracy regression after the enhancement.","created_at":"2018-06-18T17:37:00Z","updated_at":"2018-06-30T19:00:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea256982a3a32b179db24f7c148c59d05a9f9eeb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/11326/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/11326/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/11326/comments","statuses_url":"https://api.github.com/repos/apache/incubator-mxnet/statuses/fdd788f27b47dbf00fb9790612930701abefb5d1","head":{"label":"haojin2:take_op_enhance","ref":"take_op_enhance","sha":"fdd788f27b47dbf00fb9790612930701abefb5d1","user":{"login":"haojin2","id":11465736,"node_id":"MDQ6VXNlcjExNDY1NzM2","avatar_url":"https://avatars3.githubusercontent.com/u/11465736?v=4","gravatar_id":"","url":"https://api.github.com/users/haojin2","html_url":"https://github.com/haojin2","followers_url":"https://api.github.com/users/haojin2/followers","following_url":"https://api.github.com/users/haojin2/following{/other_user}","gists_url":"https://api.github.com/users/haojin2/gists{/gist_id}","starred_url":"https://api.github.com/users/haojin2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haojin2/subscriptions","organizations_url":"https://api.github.com/users/haojin2/orgs","repos_url":"https://api.github.com/users/haojin2/repos","events_url":"https://api.github.com/users/haojin2/events{/privacy}","received_events_url":"https://api.github.com/users/haojin2/received_events","type":"User","site_admin":false},"repo":{"id":114436356,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ0MzYzNTY=","name":"incubator-mxnet","full_name":"haojin2/incubator-mxnet","owner":{"login":"haojin2","id":11465736,"node_id":"MDQ6VXNlcjExNDY1NzM2","avatar_url":"https://avatars3.githubusercontent.com/u/11465736?v=4","gravatar_id":"","url":"https://api.github.com/users/haojin2","html_url":"https://github.com/haojin2","followers_url":"https://api.github.com/users/haojin2/followers","following_url":"https://api.github.com/users/haojin2/following{/other_user}","gists_url":"https://api.github.com/users/haojin2/gists{/gist_id}","starred_url":"https://api.github.com/users/haojin2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haojin2/subscriptions","organizations_url":"https://api.github.com/users/haojin2/orgs","repos_url":"https://api.github.com/users/haojin2/repos","events_url":"https://api.github.com/users/haojin2/events{/privacy}","received_events_url":"https://api.github.com/users/haojin2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/haojin2/incubator-mxnet","description":"Lightweight, Portable, Flexible Distributed/Mobile Deep Learning with Dynamic, Mutation-aware Dataflow Dep Scheduler; for Python, R, Julia, Scala, Go, Javascript and more","fork":true,"url":"https://api.github.com/repos/haojin2/incubator-mxnet","forks_url":"https://api.github.com/repos/haojin2/incubator-mxnet/forks","keys_url":"https://api.github.com/repos/haojin2/incubator-mxnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haojin2/incubator-mxnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haojin2/incubator-mxnet/teams","hooks_url":"https://api.github.com/repos/haojin2/incubator-mxnet/hooks","issue_events_url":"https://api.github.com/repos/haojin2/incubator-mxnet/issues/events{/number}","events_url":"https://api.github.com/repos/haojin2/incubator-mxnet/events","assignees_url":"https://api.github.com/repos/haojin2/incubator-mxnet/assignees{/user}","branches_url":"https://api.github.com/repos/haojin2/incubator-mxnet/branches{/branch}","tags_url":"https://api.github.com/repos/haojin2/incubator-mxnet/tags","blobs_url":"https://api.github.com/repos/haojin2/incubator-mxnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haojin2/incubator-mxnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haojin2/incubator-mxnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/haojin2/incubator-mxnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haojin2/incubator-mxnet/statuses/{sha}","languages_url":"https://api.github.com/repos/haojin2/incubator-mxnet/languages","stargazers_url":"https://api.github.com/repos/haojin2/incubator-mxnet/stargazers","contributors_url":"https://api.github.com/repos/haojin2/incubator-mxnet/contributors","subscribers_url":"https://api.github.com/repos/haojin2/incubator-mxnet/subscribers","subscription_url":"https://api.github.com/repos/haojin2/incubator-mxnet/subscription","commits_url":"https://api.github.com/repos/haojin2/incubator-mxnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/haojin2/incubator-mxnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/haojin2/incubator-mxnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/haojin2/incubator-mxnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/haojin2/incubator-mxnet/contents/{+path}","compare_url":"https://api.github.com/repos/haojin2/incubator-mxnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haojin2/incubator-mxnet/merges","archive_url":"https://api.github.com/repos/haojin2/incubator-mxnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haojin2/incubator-mxnet/downloads","issues_url":"https://api.github.com/repos/haojin2/incubator-mxnet/issues{/number}","pulls_url":"https://api.github.com/repos/haojin2/incubator-mxnet/pulls{/number}","milestones_url":"https://api.github.com/repos/haojin2/incubator-mxnet/milestones{/number}","notifications_url":"https://api.github.com/repos/haojin2/incubator-mxnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haojin2/incubator-mxnet/labels{/name}","releases_url":"https://api.github.com/repos/haojin2/incubator-mxnet/releases{/id}","deployments_url":"https://api.github.com/repos/haojin2/incubator-mxnet/deployments","created_at":"2017-12-16T05:29:32Z","updated_at":"2018-06-28T00:34:49Z","pushed_at":"2018-06-29T22:40:43Z","git_url":"git://github.com/haojin2/incubator-mxnet.git","ssh_url":"git@github.com:haojin2/incubator-mxnet.git","clone_url":"https://github.com/haojin2/incubator-mxnet.git","svn_url":"https://github.com/haojin2/incubator-mxnet","homepage":"http://mxnet.io","size":38007,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"e8923011523f900b1f7e9f180feecb89c1a1d6e1","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":34864402,"node_id":"MDEwOlJlcG9zaXRvcnkzNDg2NDQwMg==","name":"incubator-mxnet","full_name":"apache/incubator-mxnet","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-mxnet","description":"Lightweight, Portable, Flexible Distributed/Mobile Deep Learning with Dynamic, Mutation-aware Dataflow Dep Scheduler; for Python, R, Julia, Scala, Go, Javascript and more","fork":false,"url":"https://api.github.com/repos/apache/incubator-mxnet","forks_url":"https://api.github.com/repos/apache/incubator-mxnet/forks","keys_url":"https://api.github.com/repos/apache/incubator-mxnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-mxnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-mxnet/teams","hooks_url":"https://api.github.com/repos/apache/incubator-mxnet/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-mxnet/events","assignees_url":"https://api.github.com/repos/apache/incubator-mxnet/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-mxnet/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-mxnet/tags","blobs_url":"https://api.github.com/repos/apache/incubator-mxnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-mxnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-mxnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-mxnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-mxnet/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-mxnet/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-mxnet/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-mxnet/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-mxnet/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-mxnet/subscription","commits_url":"https://api.github.com/repos/apache/incubator-mxnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-mxnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-mxnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-mxnet/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-mxnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-mxnet/merges","archive_url":"https://api.github.com/repos/apache/incubator-mxnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-mxnet/downloads","issues_url":"https://api.github.com/repos/apache/incubator-mxnet/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-mxnet/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-mxnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-mxnet/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-mxnet/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-mxnet/deployments","created_at":"2015-04-30T16:21:15Z","updated_at":"2018-06-30T17:15:31Z","pushed_at":"2018-06-30T17:15:05Z","git_url":"git://github.com/apache/incubator-mxnet.git","ssh_url":"git@github.com:apache/incubator-mxnet.git","clone_url":"https://github.com/apache/incubator-mxnet.git","svn_url":"https://github.com/apache/incubator-mxnet","homepage":"https://mxnet.apache.org","size":38215,"stargazers_count":14301,"watchers_count":14301,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5289,"mirror_url":null,"archived":false,"open_issues_count":989,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5289,"open_issues":989,"watchers":14301,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/11326"},"html":{"href":"https://github.com/apache/incubator-mxnet/pull/11326"},"issue":{"href":"https://api.github.com/repos/apache/incubator-mxnet/issues/11326"},"comments":{"href":"https://api.github.com/repos/apache/incubator-mxnet/issues/11326/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/11326/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/11326/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-mxnet/statuses/fdd788f27b47dbf00fb9790612930701abefb5d1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"szha"}}