{"action":"created","issue":{"url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1492","repository_url":"https://api.github.com/repos/mixxxdj/mixxx","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1492/labels{/name}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1492/comments","events_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1492/events","html_url":"https://github.com/mixxxdj/mixxx/pull/1492","id":290743460,"number":1492,"title":"lp1744550: Fix use-after-free (and more serious issues) in GlobalTrackCache","user":{"login":"uklotzde","id":1474154,"avatar_url":"https://avatars1.githubusercontent.com/u/1474154?v=4","gravatar_id":"","url":"https://api.github.com/users/uklotzde","html_url":"https://github.com/uklotzde","followers_url":"https://api.github.com/users/uklotzde/followers","following_url":"https://api.github.com/users/uklotzde/following{/other_user}","gists_url":"https://api.github.com/users/uklotzde/gists{/gist_id}","starred_url":"https://api.github.com/users/uklotzde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uklotzde/subscriptions","organizations_url":"https://api.github.com/users/uklotzde/orgs","repos_url":"https://api.github.com/users/uklotzde/repos","events_url":"https://api.github.com/users/uklotzde/events{/privacy}","received_events_url":"https://api.github.com/users/uklotzde/received_events","type":"User","site_admin":false},"labels":[{"id":818997362,"url":"https://api.github.com/repos/mixxxdj/mixxx/labels/critical%20bug","name":"critical bug","color":"b60205","default":false},{"id":519656219,"url":"https://api.github.com/repos/mixxxdj/mixxx/labels/library","name":"library","color":"1d76db","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":42,"created_at":"2018-01-23T08:05:11Z","updated_at":"2018-02-24T11:28:17Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1492","html_url":"https://github.com/mixxxdj/mixxx/pull/1492","diff_url":"https://github.com/mixxxdj/mixxx/pull/1492.diff","patch_url":"https://github.com/mixxxdj/mixxx/pull/1492.patch"},"body":"https://bugs.launchpad.net/mixxx/+bug/1744550\r\n\r\nThis one is a real killer that sooner or later crashes Mixxx and might cause serious memory corruption!!\r\n\r\nThere was a race condition in the custom deleter that must be resolved within GlobalTrackCache. The new multi-threaded regression test reliably crashes with debug assertions and finally a SIGSEGV without the fix applied.\r\n\r\n~~I also found a memory leak: We cannot use QObject::deleteLater() for temporary Track objects! Otherwise those objects will never be deleted.~~ Nope, we actually should use deleteLater()!"},"comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/issues/comments/368221939","html_url":"https://github.com/mixxxdj/mixxx/pull/1492#issuecomment-368221939","issue_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1492","id":368221939,"user":{"login":"uklotzde","id":1474154,"avatar_url":"https://avatars1.githubusercontent.com/u/1474154?v=4","gravatar_id":"","url":"https://api.github.com/users/uklotzde","html_url":"https://github.com/uklotzde","followers_url":"https://api.github.com/users/uklotzde/followers","following_url":"https://api.github.com/users/uklotzde/following{/other_user}","gists_url":"https://api.github.com/users/uklotzde/gists{/gist_id}","starred_url":"https://api.github.com/users/uklotzde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uklotzde/subscriptions","organizations_url":"https://api.github.com/users/uklotzde/orgs","repos_url":"https://api.github.com/users/uklotzde/repos","events_url":"https://api.github.com/users/uklotzde/events{/privacy}","received_events_url":"https://api.github.com/users/uklotzde/received_events","type":"User","site_admin":false},"created_at":"2018-02-24T11:28:17Z","updated_at":"2018-02-24T11:28:17Z","author_association":"CONTRIBUTOR","body":"@daschuer Thanks for the clever _save-before-deletion_ solution :+1: I didn't notice that we could achieve a better separation of concerns and simplify the code.\r\n\r\nI just made some minor changes on top of your commits and adjusted the naming to better reflect the actual purpose."}}
{"actor":{"display_login":"uklotzde"}}