{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/pulls/comments/181198215","pull_request_review_id":111742146,"id":181198215,"diff_hunk":"@@ -0,0 +1,63 @@\n+﻿// Copyright (c) Microsoft Corporation. All rights reserved.\n+// Licensed under the MIT License.\n+\n+using System.Collections.Generic;\n+using System.Threading.Tasks;\n+using Microsoft.Bot.Builder.Prompts;\n+using static Microsoft.Bot.Builder.Prompts.PromptValidatorEx;\n+\n+namespace Microsoft.Bot.Builder.Dialogs\n+{\n+    /// <summary>\n+    /// Basic configuration options supported by all prompts.\n+    /// </summary>\n+    public abstract class Prompt<T> : Control where T : PromptResult\n+    {\n+        public Prompt()\n+        {\n+        }\n+\n+        public override bool HasDialogContinue => true;\n+\n+        public override bool HasDialogResume => false;\n+\n+        protected abstract Task OnPrompt(DialogContext dc, PromptOptions options, bool isRetry);\n+\n+        protected abstract Task<T> OnRecognize(DialogContext dc, PromptOptions options);\n+\n+        public override async Task DialogBegin(DialogContext dc, object dialogArgs)","path":"libraries/Microsoft.Bot.Builder.Dialogs/Prompts/Prompt.cs","position":28,"original_position":28,"commit_id":"7271a79295eca812ed74429717597bece5581140","original_commit_id":"7271a79295eca812ed74429717597bece5581140","user":{"login":"cleemullins","id":1165321,"avatar_url":"https://avatars1.githubusercontent.com/u/1165321?v=4","gravatar_id":"","url":"https://api.github.com/users/cleemullins","html_url":"https://github.com/cleemullins","followers_url":"https://api.github.com/users/cleemullins/followers","following_url":"https://api.github.com/users/cleemullins/following{/other_user}","gists_url":"https://api.github.com/users/cleemullins/gists{/gist_id}","starred_url":"https://api.github.com/users/cleemullins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cleemullins/subscriptions","organizations_url":"https://api.github.com/users/cleemullins/orgs","repos_url":"https://api.github.com/users/cleemullins/repos","events_url":"https://api.github.com/users/cleemullins/events{/privacy}","received_events_url":"https://api.github.com/users/cleemullins/received_events","type":"User","site_admin":false},"body":"Why this? Strong type and avoid the cast. \r\n\r\npublic override new async Task DialogBeging(DialogContext dc, PromptOptions dialogArgs)","created_at":"2018-04-12T19:36:54Z","updated_at":"2018-04-12T19:40:34Z","html_url":"https://github.com/Microsoft/botbuilder-dotnet/pull/408#discussion_r181198215","pull_request_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/pulls/408","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/pulls/comments/181198215"},"html":{"href":"https://github.com/Microsoft/botbuilder-dotnet/pull/408#discussion_r181198215"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/pulls/408"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/pulls/408","id":181064954,"html_url":"https://github.com/Microsoft/botbuilder-dotnet/pull/408","diff_url":"https://github.com/Microsoft/botbuilder-dotnet/pull/408.diff","patch_url":"https://github.com/Microsoft/botbuilder-dotnet/pull/408.patch","issue_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/issues/408","number":408,"state":"open","locked":false,"title":"Johtaylo/dialogs","user":{"login":"johnataylor","id":2523898,"avatar_url":"https://avatars1.githubusercontent.com/u/2523898?v=4","gravatar_id":"","url":"https://api.github.com/users/johnataylor","html_url":"https://github.com/johnataylor","followers_url":"https://api.github.com/users/johnataylor/followers","following_url":"https://api.github.com/users/johnataylor/following{/other_user}","gists_url":"https://api.github.com/users/johnataylor/gists{/gist_id}","starred_url":"https://api.github.com/users/johnataylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnataylor/subscriptions","organizations_url":"https://api.github.com/users/johnataylor/orgs","repos_url":"https://api.github.com/users/johnataylor/repos","events_url":"https://api.github.com/users/johnataylor/events{/privacy}","received_events_url":"https://api.github.com/users/johnataylor/received_events","type":"User","site_admin":false},"body":"all working - manually tested and samples for basic prompt, dialog, waterfall and combinations\r\nneeds many unit tests\r\nmodel is exactly same as javascript - except validator\r\n","created_at":"2018-04-12T00:56:21Z","updated_at":"2018-04-12T19:40:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4adcf2a95ee65dbc0f348e3368749c4429d9463d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/pulls/408/commits","review_comments_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/pulls/408/comments","review_comment_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/issues/408/comments","statuses_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/statuses/7271a79295eca812ed74429717597bece5581140","head":{"label":"Microsoft:johtaylo/dialogs","ref":"johtaylo/dialogs","sha":"7271a79295eca812ed74429717597bece5581140","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":117021670,"name":"botbuilder-dotnet","full_name":"Microsoft/botbuilder-dotnet","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/botbuilder-dotnet","description":".NET SDK used to build chat bots for the Microsoft Bot Framework.","fork":false,"url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet","forks_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/forks","keys_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/teams","hooks_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/events","assignees_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/tags","blobs_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/languages","stargazers_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/subscription","commits_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/merges","archive_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/downloads","issues_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/deployments","created_at":"2018-01-10T23:03:16Z","updated_at":"2018-04-12T16:13:26Z","pushed_at":"2018-04-12T18:59:05Z","git_url":"git://github.com/Microsoft/botbuilder-dotnet.git","ssh_url":"git@github.com:Microsoft/botbuilder-dotnet.git","clone_url":"https://github.com/Microsoft/botbuilder-dotnet.git","svn_url":"https://github.com/Microsoft/botbuilder-dotnet","homepage":null,"size":2826,"stargazers_count":82,"watchers_count":82,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":35,"mirror_url":null,"archived":false,"open_issues_count":63,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":35,"open_issues":63,"watchers":82,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"2d3244d5a05045f18859628f5652e895b6e83f89","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":117021670,"name":"botbuilder-dotnet","full_name":"Microsoft/botbuilder-dotnet","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/botbuilder-dotnet","description":".NET SDK used to build chat bots for the Microsoft Bot Framework.","fork":false,"url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet","forks_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/forks","keys_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/teams","hooks_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/events","assignees_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/tags","blobs_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/languages","stargazers_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/subscription","commits_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/merges","archive_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/downloads","issues_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/deployments","created_at":"2018-01-10T23:03:16Z","updated_at":"2018-04-12T16:13:26Z","pushed_at":"2018-04-12T18:59:05Z","git_url":"git://github.com/Microsoft/botbuilder-dotnet.git","ssh_url":"git@github.com:Microsoft/botbuilder-dotnet.git","clone_url":"https://github.com/Microsoft/botbuilder-dotnet.git","svn_url":"https://github.com/Microsoft/botbuilder-dotnet","homepage":null,"size":2826,"stargazers_count":82,"watchers_count":82,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":35,"mirror_url":null,"archived":false,"open_issues_count":63,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":35,"open_issues":63,"watchers":82,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/pulls/408"},"html":{"href":"https://github.com/Microsoft/botbuilder-dotnet/pull/408"},"issue":{"href":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/issues/408"},"comments":{"href":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/issues/408/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/pulls/408/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/pulls/408/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/statuses/7271a79295eca812ed74429717597bece5581140"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"cleemullins"}}