{"action":"created","comment":{"url":"https://api.github.com/repos/uxmal/reko/pulls/comments/217913161","pull_request_review_id":155743742,"id":217913161,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzkxMzE2MQ==","diff_hunk":"@@ -159,6 +159,8 @@ public MemoryIdentifier(string name, DataType dt, Storage stg) : base(name, dt,\n         {\n         }\n \n+        public bool IsFpuStack => Name.StartsWith(\"ST\"); //$HACK: gross hack but we have to start somewhere.\n+","path":"src/Core/Expressions/Identifier.cs","position":5,"original_position":5,"commit_id":"bf3f60317ccdd52cb565156e5726c689690377b7","original_commit_id":"bf3f60317ccdd52cb565156e5726c689690377b7","user":{"login":"uxmal","id":10154465,"node_id":"MDQ6VXNlcjEwMTU0NDY1","avatar_url":"https://avatars2.githubusercontent.com/u/10154465?v=4","gravatar_id":"","url":"https://api.github.com/users/uxmal","html_url":"https://github.com/uxmal","followers_url":"https://api.github.com/users/uxmal/followers","following_url":"https://api.github.com/users/uxmal/following{/other_user}","gists_url":"https://api.github.com/users/uxmal/gists{/gist_id}","starred_url":"https://api.github.com/users/uxmal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uxmal/subscriptions","organizations_url":"https://api.github.com/users/uxmal/orgs","repos_url":"https://api.github.com/users/uxmal/repos","events_url":"https://api.github.com/users/uxmal/events{/privacy}","received_events_url":"https://api.github.com/users/uxmal/received_events","type":"User","site_admin":false},"body":"I wish to avoid this X86 specific code in this General purpose class. See my other comment.","created_at":"2018-09-16T12:46:40Z","updated_at":"2018-09-16T12:46:40Z","html_url":"https://github.com/uxmal/reko/pull/687#discussion_r217913161","pull_request_url":"https://api.github.com/repos/uxmal/reko/pulls/687","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/uxmal/reko/pulls/comments/217913161"},"html":{"href":"https://github.com/uxmal/reko/pull/687#discussion_r217913161"},"pull_request":{"href":"https://api.github.com/repos/uxmal/reko/pulls/687"}}},"pull_request":{"url":"https://api.github.com/repos/uxmal/reko/pulls/687","id":215816314,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1ODE2MzE0","html_url":"https://github.com/uxmal/reko/pull/687","diff_url":"https://github.com/uxmal/reko/pull/687.diff","patch_url":"https://github.com/uxmal/reko/pull/687.patch","issue_url":"https://api.github.com/repos/uxmal/reko/issues/687","number":687,"state":"open","locked":false,"title":"SsaEvaluationContext: do not search imported procedures in FPU stack","user":{"login":"ptomin","id":13188041,"node_id":"MDQ6VXNlcjEzMTg4MDQx","avatar_url":"https://avatars3.githubusercontent.com/u/13188041?v=4","gravatar_id":"","url":"https://api.github.com/users/ptomin","html_url":"https://github.com/ptomin","followers_url":"https://api.github.com/users/ptomin/followers","following_url":"https://api.github.com/users/ptomin/following{/other_user}","gists_url":"https://api.github.com/users/ptomin/gists{/gist_id}","starred_url":"https://api.github.com/users/ptomin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptomin/subscriptions","organizations_url":"https://api.github.com/users/ptomin/orgs","repos_url":"https://api.github.com/users/ptomin/repos","events_url":"https://api.github.com/users/ptomin/events{/privacy}","received_events_url":"https://api.github.com/users/ptomin/received_events","type":"User","site_admin":false},"body":"4 unit tests failed (see https://github.com/uxmal/reko/commit/148ef1e08062976862abc9940430d598900a31f3#commitcomment-30520684) during trying to resolve FPU stack access as import reference on X86 real mode. Modification of `SsaEvaluationContext` to avoid search imported procedures in FPU stack could fix that","created_at":"2018-09-16T10:46:23Z","updated_at":"2018-09-16T12:46:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4eb6e7fac9945ef54e5a91d48dd922eda4cbccb7","assignee":{"login":"ptomin","id":13188041,"node_id":"MDQ6VXNlcjEzMTg4MDQx","avatar_url":"https://avatars3.githubusercontent.com/u/13188041?v=4","gravatar_id":"","url":"https://api.github.com/users/ptomin","html_url":"https://github.com/ptomin","followers_url":"https://api.github.com/users/ptomin/followers","following_url":"https://api.github.com/users/ptomin/following{/other_user}","gists_url":"https://api.github.com/users/ptomin/gists{/gist_id}","starred_url":"https://api.github.com/users/ptomin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptomin/subscriptions","organizations_url":"https://api.github.com/users/ptomin/orgs","repos_url":"https://api.github.com/users/ptomin/repos","events_url":"https://api.github.com/users/ptomin/events{/privacy}","received_events_url":"https://api.github.com/users/ptomin/received_events","type":"User","site_admin":false},"assignees":[{"login":"ptomin","id":13188041,"node_id":"MDQ6VXNlcjEzMTg4MDQx","avatar_url":"https://avatars3.githubusercontent.com/u/13188041?v=4","gravatar_id":"","url":"https://api.github.com/users/ptomin","html_url":"https://github.com/ptomin","followers_url":"https://api.github.com/users/ptomin/followers","following_url":"https://api.github.com/users/ptomin/following{/other_user}","gists_url":"https://api.github.com/users/ptomin/gists{/gist_id}","starred_url":"https://api.github.com/users/ptomin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptomin/subscriptions","organizations_url":"https://api.github.com/users/ptomin/orgs","repos_url":"https://api.github.com/users/ptomin/repos","events_url":"https://api.github.com/users/ptomin/events{/privacy}","received_events_url":"https://api.github.com/users/ptomin/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":240704127,"node_id":"MDU6TGFiZWwyNDA3MDQxMjc=","url":"https://api.github.com/repos/uxmal/reko/labels/bug","name":"bug","color":"fc2929","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/uxmal/reko/pulls/687/commits","review_comments_url":"https://api.github.com/repos/uxmal/reko/pulls/687/comments","review_comment_url":"https://api.github.com/repos/uxmal/reko/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uxmal/reko/issues/687/comments","statuses_url":"https://api.github.com/repos/uxmal/reko/statuses/bf3f60317ccdd52cb565156e5726c689690377b7","head":{"label":"ptomin:analysis-development","ref":"analysis-development","sha":"bf3f60317ccdd52cb565156e5726c689690377b7","user":{"login":"ptomin","id":13188041,"node_id":"MDQ6VXNlcjEzMTg4MDQx","avatar_url":"https://avatars3.githubusercontent.com/u/13188041?v=4","gravatar_id":"","url":"https://api.github.com/users/ptomin","html_url":"https://github.com/ptomin","followers_url":"https://api.github.com/users/ptomin/followers","following_url":"https://api.github.com/users/ptomin/following{/other_user}","gists_url":"https://api.github.com/users/ptomin/gists{/gist_id}","starred_url":"https://api.github.com/users/ptomin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptomin/subscriptions","organizations_url":"https://api.github.com/users/ptomin/orgs","repos_url":"https://api.github.com/users/ptomin/repos","events_url":"https://api.github.com/users/ptomin/events{/privacy}","received_events_url":"https://api.github.com/users/ptomin/received_events","type":"User","site_admin":false},"repo":{"id":48247195,"node_id":"MDEwOlJlcG9zaXRvcnk0ODI0NzE5NQ==","name":"reko","full_name":"ptomin/reko","private":false,"owner":{"login":"ptomin","id":13188041,"node_id":"MDQ6VXNlcjEzMTg4MDQx","avatar_url":"https://avatars3.githubusercontent.com/u/13188041?v=4","gravatar_id":"","url":"https://api.github.com/users/ptomin","html_url":"https://github.com/ptomin","followers_url":"https://api.github.com/users/ptomin/followers","following_url":"https://api.github.com/users/ptomin/following{/other_user}","gists_url":"https://api.github.com/users/ptomin/gists{/gist_id}","starred_url":"https://api.github.com/users/ptomin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptomin/subscriptions","organizations_url":"https://api.github.com/users/ptomin/orgs","repos_url":"https://api.github.com/users/ptomin/repos","events_url":"https://api.github.com/users/ptomin/events{/privacy}","received_events_url":"https://api.github.com/users/ptomin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ptomin/reko","description":"Reko is a binary decompiler.","fork":true,"url":"https://api.github.com/repos/ptomin/reko","forks_url":"https://api.github.com/repos/ptomin/reko/forks","keys_url":"https://api.github.com/repos/ptomin/reko/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ptomin/reko/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ptomin/reko/teams","hooks_url":"https://api.github.com/repos/ptomin/reko/hooks","issue_events_url":"https://api.github.com/repos/ptomin/reko/issues/events{/number}","events_url":"https://api.github.com/repos/ptomin/reko/events","assignees_url":"https://api.github.com/repos/ptomin/reko/assignees{/user}","branches_url":"https://api.github.com/repos/ptomin/reko/branches{/branch}","tags_url":"https://api.github.com/repos/ptomin/reko/tags","blobs_url":"https://api.github.com/repos/ptomin/reko/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ptomin/reko/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ptomin/reko/git/refs{/sha}","trees_url":"https://api.github.com/repos/ptomin/reko/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ptomin/reko/statuses/{sha}","languages_url":"https://api.github.com/repos/ptomin/reko/languages","stargazers_url":"https://api.github.com/repos/ptomin/reko/stargazers","contributors_url":"https://api.github.com/repos/ptomin/reko/contributors","subscribers_url":"https://api.github.com/repos/ptomin/reko/subscribers","subscription_url":"https://api.github.com/repos/ptomin/reko/subscription","commits_url":"https://api.github.com/repos/ptomin/reko/commits{/sha}","git_commits_url":"https://api.github.com/repos/ptomin/reko/git/commits{/sha}","comments_url":"https://api.github.com/repos/ptomin/reko/comments{/number}","issue_comment_url":"https://api.github.com/repos/ptomin/reko/issues/comments{/number}","contents_url":"https://api.github.com/repos/ptomin/reko/contents/{+path}","compare_url":"https://api.github.com/repos/ptomin/reko/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ptomin/reko/merges","archive_url":"https://api.github.com/repos/ptomin/reko/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ptomin/reko/downloads","issues_url":"https://api.github.com/repos/ptomin/reko/issues{/number}","pulls_url":"https://api.github.com/repos/ptomin/reko/pulls{/number}","milestones_url":"https://api.github.com/repos/ptomin/reko/milestones{/number}","notifications_url":"https://api.github.com/repos/ptomin/reko/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ptomin/reko/labels{/name}","releases_url":"https://api.github.com/repos/ptomin/reko/releases{/id}","deployments_url":"https://api.github.com/repos/ptomin/reko/deployments","created_at":"2015-12-18T17:15:47Z","updated_at":"2018-08-24T10:42:57Z","pushed_at":"2018-09-16T12:16:16Z","git_url":"git://github.com/ptomin/reko.git","ssh_url":"git@github.com:ptomin/reko.git","clone_url":"https://github.com/ptomin/reko.git","svn_url":"https://github.com/ptomin/reko","homepage":"https://uxmal.github.io/reko","size":274403,"stargazers_count":3,"watchers_count":3,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"uxmal:analysis-development","ref":"analysis-development","sha":"148ef1e08062976862abc9940430d598900a31f3","user":{"login":"uxmal","id":10154465,"node_id":"MDQ6VXNlcjEwMTU0NDY1","avatar_url":"https://avatars2.githubusercontent.com/u/10154465?v=4","gravatar_id":"","url":"https://api.github.com/users/uxmal","html_url":"https://github.com/uxmal","followers_url":"https://api.github.com/users/uxmal/followers","following_url":"https://api.github.com/users/uxmal/following{/other_user}","gists_url":"https://api.github.com/users/uxmal/gists{/gist_id}","starred_url":"https://api.github.com/users/uxmal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uxmal/subscriptions","organizations_url":"https://api.github.com/users/uxmal/orgs","repos_url":"https://api.github.com/users/uxmal/repos","events_url":"https://api.github.com/users/uxmal/events{/privacy}","received_events_url":"https://api.github.com/users/uxmal/received_events","type":"User","site_admin":false},"repo":{"id":39718308,"node_id":"MDEwOlJlcG9zaXRvcnkzOTcxODMwOA==","name":"reko","full_name":"uxmal/reko","private":false,"owner":{"login":"uxmal","id":10154465,"node_id":"MDQ6VXNlcjEwMTU0NDY1","avatar_url":"https://avatars2.githubusercontent.com/u/10154465?v=4","gravatar_id":"","url":"https://api.github.com/users/uxmal","html_url":"https://github.com/uxmal","followers_url":"https://api.github.com/users/uxmal/followers","following_url":"https://api.github.com/users/uxmal/following{/other_user}","gists_url":"https://api.github.com/users/uxmal/gists{/gist_id}","starred_url":"https://api.github.com/users/uxmal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uxmal/subscriptions","organizations_url":"https://api.github.com/users/uxmal/orgs","repos_url":"https://api.github.com/users/uxmal/repos","events_url":"https://api.github.com/users/uxmal/events{/privacy}","received_events_url":"https://api.github.com/users/uxmal/received_events","type":"User","site_admin":false},"html_url":"https://github.com/uxmal/reko","description":"Reko is a binary decompiler.","fork":false,"url":"https://api.github.com/repos/uxmal/reko","forks_url":"https://api.github.com/repos/uxmal/reko/forks","keys_url":"https://api.github.com/repos/uxmal/reko/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uxmal/reko/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uxmal/reko/teams","hooks_url":"https://api.github.com/repos/uxmal/reko/hooks","issue_events_url":"https://api.github.com/repos/uxmal/reko/issues/events{/number}","events_url":"https://api.github.com/repos/uxmal/reko/events","assignees_url":"https://api.github.com/repos/uxmal/reko/assignees{/user}","branches_url":"https://api.github.com/repos/uxmal/reko/branches{/branch}","tags_url":"https://api.github.com/repos/uxmal/reko/tags","blobs_url":"https://api.github.com/repos/uxmal/reko/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uxmal/reko/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uxmal/reko/git/refs{/sha}","trees_url":"https://api.github.com/repos/uxmal/reko/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uxmal/reko/statuses/{sha}","languages_url":"https://api.github.com/repos/uxmal/reko/languages","stargazers_url":"https://api.github.com/repos/uxmal/reko/stargazers","contributors_url":"https://api.github.com/repos/uxmal/reko/contributors","subscribers_url":"https://api.github.com/repos/uxmal/reko/subscribers","subscription_url":"https://api.github.com/repos/uxmal/reko/subscription","commits_url":"https://api.github.com/repos/uxmal/reko/commits{/sha}","git_commits_url":"https://api.github.com/repos/uxmal/reko/git/commits{/sha}","comments_url":"https://api.github.com/repos/uxmal/reko/comments{/number}","issue_comment_url":"https://api.github.com/repos/uxmal/reko/issues/comments{/number}","contents_url":"https://api.github.com/repos/uxmal/reko/contents/{+path}","compare_url":"https://api.github.com/repos/uxmal/reko/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uxmal/reko/merges","archive_url":"https://api.github.com/repos/uxmal/reko/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uxmal/reko/downloads","issues_url":"https://api.github.com/repos/uxmal/reko/issues{/number}","pulls_url":"https://api.github.com/repos/uxmal/reko/pulls{/number}","milestones_url":"https://api.github.com/repos/uxmal/reko/milestones{/number}","notifications_url":"https://api.github.com/repos/uxmal/reko/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uxmal/reko/labels{/name}","releases_url":"https://api.github.com/repos/uxmal/reko/releases{/id}","deployments_url":"https://api.github.com/repos/uxmal/reko/deployments","created_at":"2015-07-26T07:58:30Z","updated_at":"2018-09-16T12:18:16Z","pushed_at":"2018-09-16T12:18:14Z","git_url":"git://github.com/uxmal/reko.git","ssh_url":"git@github.com:uxmal/reko.git","clone_url":"https://github.com/uxmal/reko.git","svn_url":"https://github.com/uxmal/reko","homepage":"https://uxmal.github.io/reko","size":275837,"stargazers_count":280,"watchers_count":280,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":48,"mirror_url":null,"archived":false,"open_issues_count":91,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":48,"open_issues":91,"watchers":280,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uxmal/reko/pulls/687"},"html":{"href":"https://github.com/uxmal/reko/pull/687"},"issue":{"href":"https://api.github.com/repos/uxmal/reko/issues/687"},"comments":{"href":"https://api.github.com/repos/uxmal/reko/issues/687/comments"},"review_comments":{"href":"https://api.github.com/repos/uxmal/reko/pulls/687/comments"},"review_comment":{"href":"https://api.github.com/repos/uxmal/reko/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uxmal/reko/pulls/687/commits"},"statuses":{"href":"https://api.github.com/repos/uxmal/reko/statuses/bf3f60317ccdd52cb565156e5726c689690377b7"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"uxmal"}}