{"action":"opened","number":337,"pull_request":{"url":"https://api.github.com/repos/pharo-ide/Calypso/pulls/337","id":219527204,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NTI3MjA0","html_url":"https://github.com/pharo-ide/Calypso/pull/337","diff_url":"https://github.com/pharo-ide/Calypso/pull/337.diff","patch_url":"https://github.com/pharo-ide/Calypso/pull/337.patch","issue_url":"https://api.github.com/repos/pharo-ide/Calypso/issues/337","number":337,"state":"open","locked":false,"title":"hiddenOverriddenMethods","user":{"login":"dionisiydk","id":8149664,"node_id":"MDQ6VXNlcjgxNDk2NjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/8149664?v=4","gravatar_id":"","url":"https://api.github.com/users/dionisiydk","html_url":"https://github.com/dionisiydk","followers_url":"https://api.github.com/users/dionisiydk/followers","following_url":"https://api.github.com/users/dionisiydk/following{/other_user}","gists_url":"https://api.github.com/users/dionisiydk/gists{/gist_id}","starred_url":"https://api.github.com/users/dionisiydk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dionisiydk/subscriptions","organizations_url":"https://api.github.com/users/dionisiydk/orgs","repos_url":"https://api.github.com/users/dionisiydk/repos","events_url":"https://api.github.com/users/dionisiydk/events{/privacy}","received_events_url":"https://api.github.com/users/dionisiydk/received_events","type":"User","site_admin":false},"body":"Implementation of #304 issue.\r \rNew class scope ClyIncreasedClassScope is introduced to explicitly model increased method visibility of selected classes.\rIt is created on class basis like other class scopes but in addition it includes list of extra visible classes.\rIncreased scope analyses if methods of extra classes are overridden by basis classes and it allows to hide them from the user:\r```Smalltalk\rincreasedScope hideOverriddenMethods.\r```\rIn addition this class adds settings to system to control the default visibility of overridden methods:\r```\rClyIncreasedClassScope toggleOverriddenMethodVisibility\r```  \rAnd there is new command for method browser menu to toggle this logic in live.\r\rIntroduction of new scope into browser required refactoring of browser mode. Before all state was managed by methodGroupQuery and it was enough to work equaly in protocol and variable modes. \rNow the browser mode is reified and separate classes manage protocol and  variables mode of browser:\r- ClyClassBrowserMethodGroupsMode\r- ClyClassBrowserVariablesMode\r(it called class browser mode because it represent how to browse selected classes: eighter with method groups or with variables).\rFullBrowser methodGroupQuery and metaLevelScope are moved to classBrowserMode component.\rThe mode instance is supposed to be immutable object and new instance is created for any related change in the browser. Methods with prefix #switch perform convertation where new query and metaLevel are constructed:\r- classBrowserMode switchToVariables\r- classBrowserMode switchToNewClassSelection\r- classBrowserMode switchToMetaLevelScope:\r- classBrowserMode switchMethodVisibilityTo:\rAll methods return new mode instances and browser uses it to set up new browser state.\rGenerally this refactoring simplifies and cleans the logic of this part of browser. And it fixes some special cases with traits visibility","created_at":"2018-10-01T21:51:07Z","updated_at":"2018-10-01T21:51:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pharo-ide/Calypso/pulls/337/commits","review_comments_url":"https://api.github.com/repos/pharo-ide/Calypso/pulls/337/comments","review_comment_url":"https://api.github.com/repos/pharo-ide/Calypso/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pharo-ide/Calypso/issues/337/comments","statuses_url":"https://api.github.com/repos/pharo-ide/Calypso/statuses/e0ba1423dfb43b46865efd15a67582bd9782fff2","head":{"label":"dionisiydk:hiddenOverriddenMethods","ref":"hiddenOverriddenMethods","sha":"e0ba1423dfb43b46865efd15a67582bd9782fff2","user":{"login":"dionisiydk","id":8149664,"node_id":"MDQ6VXNlcjgxNDk2NjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/8149664?v=4","gravatar_id":"","url":"https://api.github.com/users/dionisiydk","html_url":"https://github.com/dionisiydk","followers_url":"https://api.github.com/users/dionisiydk/followers","following_url":"https://api.github.com/users/dionisiydk/following{/other_user}","gists_url":"https://api.github.com/users/dionisiydk/gists{/gist_id}","starred_url":"https://api.github.com/users/dionisiydk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dionisiydk/subscriptions","organizations_url":"https://api.github.com/users/dionisiydk/orgs","repos_url":"https://api.github.com/users/dionisiydk/repos","events_url":"https://api.github.com/users/dionisiydk/events{/privacy}","received_events_url":"https://api.github.com/users/dionisiydk/received_events","type":"User","site_admin":false},"repo":{"id":141917807,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE5MTc4MDc=","name":"Calypso","full_name":"dionisiydk/Calypso","private":false,"owner":{"login":"dionisiydk","id":8149664,"node_id":"MDQ6VXNlcjgxNDk2NjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/8149664?v=4","gravatar_id":"","url":"https://api.github.com/users/dionisiydk","html_url":"https://github.com/dionisiydk","followers_url":"https://api.github.com/users/dionisiydk/followers","following_url":"https://api.github.com/users/dionisiydk/following{/other_user}","gists_url":"https://api.github.com/users/dionisiydk/gists{/gist_id}","starred_url":"https://api.github.com/users/dionisiydk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dionisiydk/subscriptions","organizations_url":"https://api.github.com/users/dionisiydk/orgs","repos_url":"https://api.github.com/users/dionisiydk/repos","events_url":"https://api.github.com/users/dionisiydk/events{/privacy}","received_events_url":"https://api.github.com/users/dionisiydk/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dionisiydk/Calypso","description":"Pharo system browser","fork":true,"url":"https://api.github.com/repos/dionisiydk/Calypso","forks_url":"https://api.github.com/repos/dionisiydk/Calypso/forks","keys_url":"https://api.github.com/repos/dionisiydk/Calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dionisiydk/Calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dionisiydk/Calypso/teams","hooks_url":"https://api.github.com/repos/dionisiydk/Calypso/hooks","issue_events_url":"https://api.github.com/repos/dionisiydk/Calypso/issues/events{/number}","events_url":"https://api.github.com/repos/dionisiydk/Calypso/events","assignees_url":"https://api.github.com/repos/dionisiydk/Calypso/assignees{/user}","branches_url":"https://api.github.com/repos/dionisiydk/Calypso/branches{/branch}","tags_url":"https://api.github.com/repos/dionisiydk/Calypso/tags","blobs_url":"https://api.github.com/repos/dionisiydk/Calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dionisiydk/Calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dionisiydk/Calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/dionisiydk/Calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dionisiydk/Calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/dionisiydk/Calypso/languages","stargazers_url":"https://api.github.com/repos/dionisiydk/Calypso/stargazers","contributors_url":"https://api.github.com/repos/dionisiydk/Calypso/contributors","subscribers_url":"https://api.github.com/repos/dionisiydk/Calypso/subscribers","subscription_url":"https://api.github.com/repos/dionisiydk/Calypso/subscription","commits_url":"https://api.github.com/repos/dionisiydk/Calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/dionisiydk/Calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/dionisiydk/Calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/dionisiydk/Calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/dionisiydk/Calypso/contents/{+path}","compare_url":"https://api.github.com/repos/dionisiydk/Calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dionisiydk/Calypso/merges","archive_url":"https://api.github.com/repos/dionisiydk/Calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dionisiydk/Calypso/downloads","issues_url":"https://api.github.com/repos/dionisiydk/Calypso/issues{/number}","pulls_url":"https://api.github.com/repos/dionisiydk/Calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/dionisiydk/Calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/dionisiydk/Calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dionisiydk/Calypso/labels{/name}","releases_url":"https://api.github.com/repos/dionisiydk/Calypso/releases{/id}","deployments_url":"https://api.github.com/repos/dionisiydk/Calypso/deployments","created_at":"2018-07-22T17:47:18Z","updated_at":"2018-07-22T17:47:25Z","pushed_at":"2018-10-01T21:18:16Z","git_url":"git://github.com/dionisiydk/Calypso.git","ssh_url":"git@github.com:dionisiydk/Calypso.git","clone_url":"https://github.com/dionisiydk/Calypso.git","svn_url":"https://github.com/dionisiydk/Calypso","homepage":"http://dionisiydk.blogspot.com/2017/07/calypso-update-many-improvements-and.html","size":5157,"stargazers_count":0,"watchers_count":0,"language":"Smalltalk","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pharo-ide:dev","ref":"dev","sha":"ff85881256037ca70fd9a4a847d458a5e9dfbcf8","user":{"login":"pharo-ide","id":38942603,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4OTQyNjAz","avatar_url":"https://avatars0.githubusercontent.com/u/38942603?v=4","gravatar_id":"","url":"https://api.github.com/users/pharo-ide","html_url":"https://github.com/pharo-ide","followers_url":"https://api.github.com/users/pharo-ide/followers","following_url":"https://api.github.com/users/pharo-ide/following{/other_user}","gists_url":"https://api.github.com/users/pharo-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/pharo-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pharo-ide/subscriptions","organizations_url":"https://api.github.com/users/pharo-ide/orgs","repos_url":"https://api.github.com/users/pharo-ide/repos","events_url":"https://api.github.com/users/pharo-ide/events{/privacy}","received_events_url":"https://api.github.com/users/pharo-ide/received_events","type":"Organization","site_admin":false},"repo":{"id":76751516,"node_id":"MDEwOlJlcG9zaXRvcnk3Njc1MTUxNg==","name":"Calypso","full_name":"pharo-ide/Calypso","private":false,"owner":{"login":"pharo-ide","id":38942603,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4OTQyNjAz","avatar_url":"https://avatars0.githubusercontent.com/u/38942603?v=4","gravatar_id":"","url":"https://api.github.com/users/pharo-ide","html_url":"https://github.com/pharo-ide","followers_url":"https://api.github.com/users/pharo-ide/followers","following_url":"https://api.github.com/users/pharo-ide/following{/other_user}","gists_url":"https://api.github.com/users/pharo-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/pharo-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pharo-ide/subscriptions","organizations_url":"https://api.github.com/users/pharo-ide/orgs","repos_url":"https://api.github.com/users/pharo-ide/repos","events_url":"https://api.github.com/users/pharo-ide/events{/privacy}","received_events_url":"https://api.github.com/users/pharo-ide/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pharo-ide/Calypso","description":"Pharo system browser","fork":false,"url":"https://api.github.com/repos/pharo-ide/Calypso","forks_url":"https://api.github.com/repos/pharo-ide/Calypso/forks","keys_url":"https://api.github.com/repos/pharo-ide/Calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pharo-ide/Calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pharo-ide/Calypso/teams","hooks_url":"https://api.github.com/repos/pharo-ide/Calypso/hooks","issue_events_url":"https://api.github.com/repos/pharo-ide/Calypso/issues/events{/number}","events_url":"https://api.github.com/repos/pharo-ide/Calypso/events","assignees_url":"https://api.github.com/repos/pharo-ide/Calypso/assignees{/user}","branches_url":"https://api.github.com/repos/pharo-ide/Calypso/branches{/branch}","tags_url":"https://api.github.com/repos/pharo-ide/Calypso/tags","blobs_url":"https://api.github.com/repos/pharo-ide/Calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pharo-ide/Calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pharo-ide/Calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/pharo-ide/Calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pharo-ide/Calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/pharo-ide/Calypso/languages","stargazers_url":"https://api.github.com/repos/pharo-ide/Calypso/stargazers","contributors_url":"https://api.github.com/repos/pharo-ide/Calypso/contributors","subscribers_url":"https://api.github.com/repos/pharo-ide/Calypso/subscribers","subscription_url":"https://api.github.com/repos/pharo-ide/Calypso/subscription","commits_url":"https://api.github.com/repos/pharo-ide/Calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/pharo-ide/Calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/pharo-ide/Calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/pharo-ide/Calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/pharo-ide/Calypso/contents/{+path}","compare_url":"https://api.github.com/repos/pharo-ide/Calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pharo-ide/Calypso/merges","archive_url":"https://api.github.com/repos/pharo-ide/Calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pharo-ide/Calypso/downloads","issues_url":"https://api.github.com/repos/pharo-ide/Calypso/issues{/number}","pulls_url":"https://api.github.com/repos/pharo-ide/Calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/pharo-ide/Calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/pharo-ide/Calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pharo-ide/Calypso/labels{/name}","releases_url":"https://api.github.com/repos/pharo-ide/Calypso/releases{/id}","deployments_url":"https://api.github.com/repos/pharo-ide/Calypso/deployments","created_at":"2016-12-17T22:46:57Z","updated_at":"2018-09-18T06:32:36Z","pushed_at":"2018-10-01T12:11:53Z","git_url":"git://github.com/pharo-ide/Calypso.git","ssh_url":"git@github.com:pharo-ide/Calypso.git","clone_url":"https://github.com/pharo-ide/Calypso.git","svn_url":"https://github.com/pharo-ide/Calypso","homepage":"http://dionisiydk.blogspot.com/2017/07/calypso-update-many-improvements-and.html","size":5094,"stargazers_count":31,"watchers_count":31,"language":"Smalltalk","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":69,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":15,"open_issues":69,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pharo-ide/Calypso/pulls/337"},"html":{"href":"https://github.com/pharo-ide/Calypso/pull/337"},"issue":{"href":"https://api.github.com/repos/pharo-ide/Calypso/issues/337"},"comments":{"href":"https://api.github.com/repos/pharo-ide/Calypso/issues/337/comments"},"review_comments":{"href":"https://api.github.com/repos/pharo-ide/Calypso/pulls/337/comments"},"review_comment":{"href":"https://api.github.com/repos/pharo-ide/Calypso/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pharo-ide/Calypso/pulls/337/commits"},"statuses":{"href":"https://api.github.com/repos/pharo-ide/Calypso/statuses/e0ba1423dfb43b46865efd15a67582bd9782fff2"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":23,"additions":1198,"deletions":248,"changed_files":40}}
{"actor":{"display_login":"dionisiydk"}}