{"action":"created","issue":{"url":"https://api.github.com/repos/bhilburn/powerlevel9k/issues/833","repository_url":"https://api.github.com/repos/bhilburn/powerlevel9k","labels_url":"https://api.github.com/repos/bhilburn/powerlevel9k/issues/833/labels{/name}","comments_url":"https://api.github.com/repos/bhilburn/powerlevel9k/issues/833/comments","events_url":"https://api.github.com/repos/bhilburn/powerlevel9k/issues/833/events","html_url":"https://github.com/bhilburn/powerlevel9k/pull/833","id":321935481,"number":833,"title":"Rewrite - Test branch in progress","user":{"login":"onaforeignshore","id":704406,"avatar_url":"https://avatars3.githubusercontent.com/u/704406?v=4","gravatar_id":"","url":"https://api.github.com/users/onaforeignshore","html_url":"https://github.com/onaforeignshore","followers_url":"https://api.github.com/users/onaforeignshore/followers","following_url":"https://api.github.com/users/onaforeignshore/following{/other_user}","gists_url":"https://api.github.com/users/onaforeignshore/gists{/gist_id}","starred_url":"https://api.github.com/users/onaforeignshore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onaforeignshore/subscriptions","organizations_url":"https://api.github.com/users/onaforeignshore/orgs","repos_url":"https://api.github.com/users/onaforeignshore/repos","events_url":"https://api.github.com/users/onaforeignshore/events{/privacy}","received_events_url":"https://api.github.com/users/onaforeignshore/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-05-10T13:41:48Z","updated_at":"2018-05-23T13:38:28Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/bhilburn/powerlevel9k/pulls/833","html_url":"https://github.com/bhilburn/powerlevel9k/pull/833","diff_url":"https://github.com/bhilburn/powerlevel9k/pull/833.diff","patch_url":"https://github.com/bhilburn/powerlevel9k/pull/833.patch"},"body":"After the various discussions about streamlining and speeding up powerlevel9k - especially with precompiling as much as possible and removing tests wherever possible, I have updated the entire code base (based on #771).\r\n\r\nThis is a WIP as it does not now have a rewritten zsh-async.p9k yet, but it seems to be a whole lot faster.\r\n\r\n@bhilburn @dritter Please give it a try and let me know what you think."},"comment":{"url":"https://api.github.com/repos/bhilburn/powerlevel9k/issues/comments/391349737","html_url":"https://github.com/bhilburn/powerlevel9k/pull/833#issuecomment-391349737","issue_url":"https://api.github.com/repos/bhilburn/powerlevel9k/issues/833","id":391349737,"user":{"login":"bhilburn","id":569571,"avatar_url":"https://avatars1.githubusercontent.com/u/569571?v=4","gravatar_id":"","url":"https://api.github.com/users/bhilburn","html_url":"https://github.com/bhilburn","followers_url":"https://api.github.com/users/bhilburn/followers","following_url":"https://api.github.com/users/bhilburn/following{/other_user}","gists_url":"https://api.github.com/users/bhilburn/gists{/gist_id}","starred_url":"https://api.github.com/users/bhilburn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhilburn/subscriptions","organizations_url":"https://api.github.com/users/bhilburn/orgs","repos_url":"https://api.github.com/users/bhilburn/repos","events_url":"https://api.github.com/users/bhilburn/events{/privacy}","received_events_url":"https://api.github.com/users/bhilburn/received_events","type":"User","site_admin":false},"created_at":"2018-05-23T13:38:28Z","updated_at":"2018-05-23T13:38:28Z","author_association":"OWNER","body":"@onaforeignshore - Holy crap! This is a _ton_ of work. Right off the bat, I can tell you I'm seeing a significant improvement in performance relative to the current HEAD of `next`, but it appears to actually be slower compared to the work in #771 on my machine:\r\n\r\ncurrent HEAD of `next`:\r\n<img width=\"546\" alt=\"screen shot 2018-05-23 at 09 27 48\" src=\"https://user-images.githubusercontent.com/569571/40427429-b3888512-5e6b-11e8-9298-0f8261a023ee.png\">\r\n\r\ncurrent HEAD of this dev branch:\r\n<img width=\"539\" alt=\"screen shot 2018-05-23 at 09 27 54\" src=\"https://user-images.githubusercontent.com/569571/40427447-c078dea2-5e6b-11e8-8079-7cf02e195d62.png\">\r\n\r\n553c788e8382 from #771:\r\n<img width=\"596\" alt=\"screen shot 2018-05-23 at 09 30 56\" src=\"https://user-images.githubusercontent.com/569571/40427603-2c82c324-5e6c-11e8-9fd1-5fa69f45820c.png\">\r\n\r\nYou can also see there are some minor hiccups with colors and icons, but I realize this is all WIP.\r\n\r\nSo, just to make sure I understand, this branch is built on top of #771, and is basically meant to apply the discussion from #817 regarding Speed vs Flexibility to the code base, right?\r\n\r\nI haven't reviewed the code as thoroughly as @dritter has, but everything I've looked at so far is much better organized and easier to understand.\r\n\r\n@onaforeignshore - What kinds of performance numbers are you getting on this branch relative to #771? I wonder if something is just wonky with my configuration / machine.\r\n"}}
{"actor":{"display_login":"bhilburn"}}