{"action":"created","issue":{"url":"https://api.github.com/repos/croogo/croogo/issues/853","repository_url":"https://api.github.com/repos/croogo/croogo","labels_url":"https://api.github.com/repos/croogo/croogo/issues/853/labels{/name}","comments_url":"https://api.github.com/repos/croogo/croogo/issues/853/comments","events_url":"https://api.github.com/repos/croogo/croogo/issues/853/events","html_url":"https://github.com/croogo/croogo/pull/853","id":293501022,"node_id":"MDExOlB1bGxSZXF1ZXN0MTY2NTE1NDQx","number":853,"title":"Improve FileManager plugin by adapting xintesa/assets","user":{"login":"rchavik","id":39490,"node_id":"MDQ6VXNlcjM5NDkw","avatar_url":"https://avatars3.githubusercontent.com/u/39490?v=4","gravatar_id":"","url":"https://api.github.com/users/rchavik","html_url":"https://github.com/rchavik","followers_url":"https://api.github.com/users/rchavik/followers","following_url":"https://api.github.com/users/rchavik/following{/other_user}","gists_url":"https://api.github.com/users/rchavik/gists{/gist_id}","starred_url":"https://api.github.com/users/rchavik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchavik/subscriptions","organizations_url":"https://api.github.com/users/rchavik/orgs","repos_url":"https://api.github.com/users/rchavik/repos","events_url":"https://api.github.com/users/rchavik/events{/privacy}","received_events_url":"https://api.github.com/users/rchavik/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-02-01T11:48:21Z","updated_at":"2018-10-09T12:37:59Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/croogo/croogo/pulls/853","html_url":"https://github.com/croogo/croogo/pull/853","diff_url":"https://github.com/croogo/croogo/pull/853.diff","patch_url":"https://github.com/croogo/croogo/pull/853.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/croogo/croogo/issues/comments/428175255","html_url":"https://github.com/croogo/croogo/pull/853#issuecomment-428175255","issue_url":"https://api.github.com/repos/croogo/croogo/issues/853","id":428175255,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODE3NTI1NQ==","user":{"login":"rchavik","id":39490,"node_id":"MDQ6VXNlcjM5NDkw","avatar_url":"https://avatars3.githubusercontent.com/u/39490?v=4","gravatar_id":"","url":"https://api.github.com/users/rchavik","html_url":"https://github.com/rchavik","followers_url":"https://api.github.com/users/rchavik/followers","following_url":"https://api.github.com/users/rchavik/following{/other_user}","gists_url":"https://api.github.com/users/rchavik/gists{/gist_id}","starred_url":"https://api.github.com/users/rchavik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchavik/subscriptions","organizations_url":"https://api.github.com/users/rchavik/orgs","repos_url":"https://api.github.com/users/rchavik/repos","events_url":"https://api.github.com/users/rchavik/events{/privacy}","received_events_url":"https://api.github.com/users/rchavik/received_events","type":"User","site_admin":false},"created_at":"2018-10-09T12:37:59Z","updated_at":"2018-10-09T12:37:59Z","author_association":"MEMBER","body":"Hi Mike.  Thanks for looking into this PR.\r\n\r\n> Changed my install process to do the composer step with source, then checked out the 3.1-assets branch, then completed the Croogo.Install install step. This got me going much faster, but I still ran into the same problems with the plugin. Local adapter seems to be missing, even using the Legacy adapter doesn't produce an error, but doesn't seem to actually upload the file either.\r\n\r\nAs you might have found out, this PR currently does not address upgrade path yet.\r\n\r\nTherefore, in order to test, after `composer install`, you will need to start using an empty database and run the installer with the `3.1-asset` branch already checked out. \r\n\r\nI can't recall if the CLI installer works with this PR yet.  Before replying here, I tested with the web installer.\r\n\r\n> I'm a little confused about the proper location for the files, whether they should be in webroot/uploads, webroot/attachments, or webroot/assets.\r\n\r\nI tried to be backward compatible (which might not be wise here).  Maybe we should get rid of the `LegacyLocalAttachment` storage config later (see `FileManager/config/bootstrap.php`).\r\nMoving forward, we should pick one of those 3.\r\n\r\nIn the current state, target upload directory is `webroot/assets`.\r\n"}}
{"actor":{"display_login":"rchavik"}}