{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/232558792","pull_request_review_id":173780055,"id":232558792,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjU1ODc5Mg==","diff_hunk":"@@ -121,8 +121,19 @@ class SILBuilder {\n   /// Reference to the provided SILBuilderContext.\n   SILBuilderContext &C;\n \n+  /// The SILFunction that we are currently inserting into if we have one.\n+  ///\n+  /// If we are building into a block associated with a SILGlobalVariable this\n+  /// will be a nullptr.\n+  ///\n+  /// TODO: This can be made cleaner by using a PointerUnion or the like so we\n+  /// can store the SILGlobalVariable here as well.\n   SILFunction *F;\n \n+  /// If the current block that we are inserting into must assume that\n+  /// the current context we are in has ownership.\n+  bool hasOwnership;","path":"include/swift/SIL/SILBuilder.h","position":15,"original_position":15,"commit_id":"fed6145922e0180cb16b62b0524f792a08e608ce","original_commit_id":"fed6145922e0180cb16b62b0524f792a08e608ce","user":{"login":"atrick","id":2165663,"node_id":"MDQ6VXNlcjIxNjU2NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/2165663?v=4","gravatar_id":"","url":"https://api.github.com/users/atrick","html_url":"https://github.com/atrick","followers_url":"https://api.github.com/users/atrick/followers","following_url":"https://api.github.com/users/atrick/following{/other_user}","gists_url":"https://api.github.com/users/atrick/gists{/gist_id}","starred_url":"https://api.github.com/users/atrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atrick/subscriptions","organizations_url":"https://api.github.com/users/atrick/orgs","repos_url":"https://api.github.com/users/atrick/repos","events_url":"https://api.github.com/users/atrick/events{/privacy}","received_events_url":"https://api.github.com/users/atrick/received_events","type":"User","site_admin":false},"body":"I hope this extra `SILBuilder` flag is temporary.","created_at":"2018-11-12T07:52:42Z","updated_at":"2018-11-12T07:52:43Z","html_url":"https://github.com/apple/swift/pull/20497#discussion_r232558792","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/20497","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/232558792"},"html":{"href":"https://github.com/apple/swift/pull/20497#discussion_r232558792"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/20497"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/20497","id":229913690,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5OTEzNjkw","html_url":"https://github.com/apple/swift/pull/20497","diff_url":"https://github.com/apple/swift/pull/20497.diff","patch_url":"https://github.com/apple/swift/pull/20497.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/20497","number":20497,"state":"closed","locked":false,"title":"[sil] Change all single value instructions with forwarding ownership …","user":{"login":"gottesmm","id":499423,"node_id":"MDQ6VXNlcjQ5OTQyMw==","avatar_url":"https://avatars1.githubusercontent.com/u/499423?v=4","gravatar_id":"","url":"https://api.github.com/users/gottesmm","html_url":"https://github.com/gottesmm","followers_url":"https://api.github.com/users/gottesmm/followers","following_url":"https://api.github.com/users/gottesmm/following{/other_user}","gists_url":"https://api.github.com/users/gottesmm/gists{/gist_id}","starred_url":"https://api.github.com/users/gottesmm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gottesmm/subscriptions","organizations_url":"https://api.github.com/users/gottesmm/orgs","repos_url":"https://api.github.com/users/gottesmm/repos","events_url":"https://api.github.com/users/gottesmm/events{/privacy}","received_events_url":"https://api.github.com/users/gottesmm/received_events","type":"User","site_admin":false},"body":"…to have static ownership.\r\n\r\nPreviously we would always calculate these instructions ownership dynamically\r\nwhen asked and rely on the ownership verifier to catch if we made any\r\nmistakes. Instead with this commit we move to a more static model where the\r\nownership that these instructions can take are frozen on construction. This is a\r\nmore static model that simplifies the ownership model.\r\n","created_at":"2018-11-10T21:12:19Z","updated_at":"2018-11-12T07:52:43Z","closed_at":"2018-11-12T00:28:34Z","merged_at":"2018-11-12T00:28:34Z","merge_commit_sha":"a3fe730a77ef905875952b9e5a61b6f00d13027b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/20497/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/20497/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/20497/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/fed6145922e0180cb16b62b0524f792a08e608ce","head":{"label":"gottesmm:pr-819716530d245f7bd71e18c53006df83e74731f0","ref":"pr-819716530d245f7bd71e18c53006df83e74731f0","sha":"fed6145922e0180cb16b62b0524f792a08e608ce","user":{"login":"gottesmm","id":499423,"node_id":"MDQ6VXNlcjQ5OTQyMw==","avatar_url":"https://avatars1.githubusercontent.com/u/499423?v=4","gravatar_id":"","url":"https://api.github.com/users/gottesmm","html_url":"https://github.com/gottesmm","followers_url":"https://api.github.com/users/gottesmm/followers","following_url":"https://api.github.com/users/gottesmm/following{/other_user}","gists_url":"https://api.github.com/users/gottesmm/gists{/gist_id}","starred_url":"https://api.github.com/users/gottesmm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gottesmm/subscriptions","organizations_url":"https://api.github.com/users/gottesmm/orgs","repos_url":"https://api.github.com/users/gottesmm/repos","events_url":"https://api.github.com/users/gottesmm/events{/privacy}","received_events_url":"https://api.github.com/users/gottesmm/received_events","type":"User","site_admin":false},"repo":{"id":47728072,"node_id":"MDEwOlJlcG9zaXRvcnk0NzcyODA3Mg==","name":"swift","full_name":"gottesmm/swift","private":false,"owner":{"login":"gottesmm","id":499423,"node_id":"MDQ6VXNlcjQ5OTQyMw==","avatar_url":"https://avatars1.githubusercontent.com/u/499423?v=4","gravatar_id":"","url":"https://api.github.com/users/gottesmm","html_url":"https://github.com/gottesmm","followers_url":"https://api.github.com/users/gottesmm/followers","following_url":"https://api.github.com/users/gottesmm/following{/other_user}","gists_url":"https://api.github.com/users/gottesmm/gists{/gist_id}","starred_url":"https://api.github.com/users/gottesmm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gottesmm/subscriptions","organizations_url":"https://api.github.com/users/gottesmm/orgs","repos_url":"https://api.github.com/users/gottesmm/repos","events_url":"https://api.github.com/users/gottesmm/events{/privacy}","received_events_url":"https://api.github.com/users/gottesmm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gottesmm/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/gottesmm/swift","forks_url":"https://api.github.com/repos/gottesmm/swift/forks","keys_url":"https://api.github.com/repos/gottesmm/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gottesmm/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gottesmm/swift/teams","hooks_url":"https://api.github.com/repos/gottesmm/swift/hooks","issue_events_url":"https://api.github.com/repos/gottesmm/swift/issues/events{/number}","events_url":"https://api.github.com/repos/gottesmm/swift/events","assignees_url":"https://api.github.com/repos/gottesmm/swift/assignees{/user}","branches_url":"https://api.github.com/repos/gottesmm/swift/branches{/branch}","tags_url":"https://api.github.com/repos/gottesmm/swift/tags","blobs_url":"https://api.github.com/repos/gottesmm/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gottesmm/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gottesmm/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/gottesmm/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gottesmm/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/gottesmm/swift/languages","stargazers_url":"https://api.github.com/repos/gottesmm/swift/stargazers","contributors_url":"https://api.github.com/repos/gottesmm/swift/contributors","subscribers_url":"https://api.github.com/repos/gottesmm/swift/subscribers","subscription_url":"https://api.github.com/repos/gottesmm/swift/subscription","commits_url":"https://api.github.com/repos/gottesmm/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/gottesmm/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/gottesmm/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/gottesmm/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/gottesmm/swift/contents/{+path}","compare_url":"https://api.github.com/repos/gottesmm/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gottesmm/swift/merges","archive_url":"https://api.github.com/repos/gottesmm/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gottesmm/swift/downloads","issues_url":"https://api.github.com/repos/gottesmm/swift/issues{/number}","pulls_url":"https://api.github.com/repos/gottesmm/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/gottesmm/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/gottesmm/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gottesmm/swift/labels{/name}","releases_url":"https://api.github.com/repos/gottesmm/swift/releases{/id}","deployments_url":"https://api.github.com/repos/gottesmm/swift/deployments","created_at":"2015-12-10T00:36:58Z","updated_at":"2016-12-07T08:17:10Z","pushed_at":"2018-11-12T00:28:37Z","git_url":"git://github.com/gottesmm/swift.git","ssh_url":"git@github.com:gottesmm/swift.git","clone_url":"https://github.com/gottesmm/swift.git","svn_url":"https://github.com/gottesmm/swift","homepage":"","size":337871,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"ce6493b356e21dc5deed4c62748c07ee97fae56f","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"node_id":"MDEwOlJlcG9zaXRvcnk0NDgzODk0OQ==","name":"swift","full_name":"apple/swift","private":false,"owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2018-11-12T07:00:53Z","pushed_at":"2018-11-12T06:53:28Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org","size":361736,"stargazers_count":45732,"watchers_count":45732,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7253,"mirror_url":null,"archived":false,"open_issues_count":435,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7253,"open_issues":435,"watchers":45732,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/20497"},"html":{"href":"https://github.com/apple/swift/pull/20497"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/20497"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/20497/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/20497/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/20497/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/fed6145922e0180cb16b62b0524f792a08e608ce"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"atrick"}}