{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/20404","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/20404/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/20404/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/20404/events","html_url":"https://github.com/openshift/origin/pull/20404","id":343997239,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNDk1OTE2","number":20404,"title":"apps: move controllers and rest of the apps to external versions","user":{"login":"mfojtik","id":44136,"node_id":"MDQ6VXNlcjQ0MTM2","avatar_url":"https://avatars2.githubusercontent.com/u/44136?v=4","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"labels":[{"id":223051294,"node_id":"MDU6TGFiZWwyMjMwNTEyOTQ=","url":"https://api.github.com/repos/openshift/origin/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":640548662,"node_id":"MDU6TGFiZWw2NDA1NDg2NjI=","url":"https://api.github.com/repos/openshift/origin/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-07-24T11:31:21Z","updated_at":"2018-07-27T11:01:27Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/20404","html_url":"https://github.com/openshift/origin/pull/20404","diff_url":"https://github.com/openshift/origin/pull/20404.diff","patch_url":"https://github.com/openshift/origin/pull/20404.patch"},"body":"- https://github.com/openshift/origin/pull/20404/commits/ac52033b59fcd665f6c86e782f17dab1a3bad598 - @deads2k this refactors our informer interfaces to distinguish between internal/external and it removes internal informer for apps, leaving just external\r\n- https://github.com/openshift/origin/pull/20404/commits/6b8250d143a46203cedec9b0e4b57e030679984c - @smarterclayton this moves triggers for deployment configs to external informer/types\r\n\r\nRest of the commits is switching apps controllers to external versions/informers/clients.\r\nAs part of this changes the `pkg/apps/controllers/utils` package is removed (yay!).\r\n\r\n@tnozicka i really did my best to make this cleaner for review, but these kinds of changes are really hard to separate properly :-/"},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/408386235","html_url":"https://github.com/openshift/origin/pull/20404#issuecomment-408386235","issue_url":"https://api.github.com/repos/openshift/origin/issues/20404","id":408386235,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODM4NjIzNQ==","user":{"login":"openshift-ci-robot","id":30189103,"node_id":"MDQ6VXNlcjMwMTg5MTAz","avatar_url":"https://avatars1.githubusercontent.com/u/30189103?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift-ci-robot","html_url":"https://github.com/openshift-ci-robot","followers_url":"https://api.github.com/users/openshift-ci-robot/followers","following_url":"https://api.github.com/users/openshift-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/openshift-ci-robot/orgs","repos_url":"https://api.github.com/users/openshift-ci-robot/repos","events_url":"https://api.github.com/users/openshift-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-07-27T11:01:27Z","updated_at":"2018-07-27T11:01:27Z","author_association":"NONE","body":"@mfojtik: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nci/prow/gcp | 83db6a3ce65b06bbfb3fbe2c5d826aa424e17d5b | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/20404/pull-ci-origin-e2e-gcp/1519/) | `/test gcp`\nci/openshift-jenkins/cmd | 83db6a3ce65b06bbfb3fbe2c5d826aa424e17d5b | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/20404/test_pull_request_origin_cmd/16067/) | `/test cmd`\nci/openshift-jenkins/extended_conformance_install | 83db6a3ce65b06bbfb3fbe2c5d826aa424e17d5b | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/20404/test_pull_request_origin_extended_conformance_install/13790/) | `/test extended_conformance_install`\nci/prow/integration | 08bcd6aedb0b217b09f5c966ac5b5b8dceeb76d0 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/20404/pull-ci-origin-integration/1354/) | `/test integration`\nci/prow/unit | 08bcd6aedb0b217b09f5c966ac5b5b8dceeb76d0 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/20404/pull-ci-origin-unit/1923/) | `/test unit`\nci/openshift-jenkins/extended_clusterup | 08bcd6aedb0b217b09f5c966ac5b5b8dceeb76d0 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/20404/test_pull_request_origin_extended_clusterup/3657/) | `/test extended_clusterup`\nci/openshift-jenkins/end_to_end | 08bcd6aedb0b217b09f5c966ac5b5b8dceeb76d0 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/20404/test_pull_request_origin_end_to_end/15409/) | `/test end_to_end`\nci/openshift-jenkins/extended_image_registry | 9eb0dfd8bf6923de611bdeb88b5802092bce143d | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/20404/test_pull_request_origin_extended_image_registry/804/) | `/test extended_image_registry`\n\n[Full PR test history](https://openshift-gce-devel.appspot.com/pr/20404). [Your PR dashboard](https://openshift-gce-devel.appspot.com/pr/mfojtik). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/openshift/origin/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"openshift-ci-robot"}}