{"action":"created","comment":{"url":"https://api.github.com/repos/istio/istio.github.io/pulls/comments/189085005","pull_request_review_id":121196626,"id":189085005,"diff_hunk":"@@ -9,17 +9,11 @@ redirect_from: /docs/tasks/ingress.html\n {% include home.html %}\n \n In a Kubernetes environment, the [Kubernetes Ingress Resource](https://kubernetes.io/docs/concepts/services-networking/ingress/)\n-allows users to specify services that should be exposed outside the cluster.\n-For traffic entering an Istio service mesh, however, an Istio-aware [ingress controller](https://kubernetes.io/docs/concepts/services-networking/ingress/#ingress-controllers)\n-is needed to allow Istio features, for example, monitoring and route rules, to be applied to traffic entering the cluster.\n+allows specifying services that should be exposed outside the cluster.","path":"_docs/tasks/traffic-management-v1alpha3/ingress.md","position":7,"original_position":7,"commit_id":"99131d21cd471c84d91f0c7e78ba52a1458b5896","original_commit_id":"99131d21cd471c84d91f0c7e78ba52a1458b5896","user":{"login":"frankbu","id":2752495,"avatar_url":"https://avatars2.githubusercontent.com/u/2752495?v=4","gravatar_id":"","url":"https://api.github.com/users/frankbu","html_url":"https://github.com/frankbu","followers_url":"https://api.github.com/users/frankbu/followers","following_url":"https://api.github.com/users/frankbu/following{/other_user}","gists_url":"https://api.github.com/users/frankbu/gists{/gist_id}","starred_url":"https://api.github.com/users/frankbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankbu/subscriptions","organizations_url":"https://api.github.com/users/frankbu/orgs","repos_url":"https://api.github.com/users/frankbu/repos","events_url":"https://api.github.com/users/frankbu/events{/privacy}","received_events_url":"https://api.github.com/users/frankbu/received_events","type":"User","site_admin":false},"body":"is used to specify services ...","created_at":"2018-05-17T20:08:41Z","updated_at":"2018-05-17T20:35:17Z","html_url":"https://github.com/istio/istio.github.io/pull/1286#discussion_r189085005","pull_request_url":"https://api.github.com/repos/istio/istio.github.io/pulls/1286","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/istio/istio.github.io/pulls/comments/189085005"},"html":{"href":"https://github.com/istio/istio.github.io/pull/1286#discussion_r189085005"},"pull_request":{"href":"https://api.github.com/repos/istio/istio.github.io/pulls/1286"}}},"pull_request":{"url":"https://api.github.com/repos/istio/istio.github.io/pulls/1286","id":188420541,"html_url":"https://github.com/istio/istio.github.io/pull/1286","diff_url":"https://github.com/istio/istio.github.io/pull/1286.diff","patch_url":"https://github.com/istio/istio.github.io/pull/1286.patch","issue_url":"https://api.github.com/repos/istio/istio.github.io/issues/1286","number":1286,"state":"open","locked":false,"title":"finalize the ingressgateway instructions","user":{"login":"vadimeisenbergibm","id":16784982,"avatar_url":"https://avatars1.githubusercontent.com/u/16784982?v=4","gravatar_id":"","url":"https://api.github.com/users/vadimeisenbergibm","html_url":"https://github.com/vadimeisenbergibm","followers_url":"https://api.github.com/users/vadimeisenbergibm/followers","following_url":"https://api.github.com/users/vadimeisenbergibm/following{/other_user}","gists_url":"https://api.github.com/users/vadimeisenbergibm/gists{/gist_id}","starred_url":"https://api.github.com/users/vadimeisenbergibm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadimeisenbergibm/subscriptions","organizations_url":"https://api.github.com/users/vadimeisenbergibm/orgs","repos_url":"https://api.github.com/users/vadimeisenbergibm/repos","events_url":"https://api.github.com/users/vadimeisenbergibm/events{/privacy}","received_events_url":"https://api.github.com/users/vadimeisenbergibm/received_events","type":"User","site_admin":false},"body":"use a predefined secret name and a predefined path\r\ndepends on https://github.com/istio/istio/pull/5634","created_at":"2018-05-16T12:46:40Z","updated_at":"2018-05-17T20:35:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8095f0516a9b30f0b84604d670f9902fa8452b21","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sdake","id":755849,"avatar_url":"https://avatars1.githubusercontent.com/u/755849?v=4","gravatar_id":"","url":"https://api.github.com/users/sdake","html_url":"https://github.com/sdake","followers_url":"https://api.github.com/users/sdake/followers","following_url":"https://api.github.com/users/sdake/following{/other_user}","gists_url":"https://api.github.com/users/sdake/gists{/gist_id}","starred_url":"https://api.github.com/users/sdake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdake/subscriptions","organizations_url":"https://api.github.com/users/sdake/orgs","repos_url":"https://api.github.com/users/sdake/repos","events_url":"https://api.github.com/users/sdake/events{/privacy}","received_events_url":"https://api.github.com/users/sdake/received_events","type":"User","site_admin":false},{"login":"linsun","id":1588319,"avatar_url":"https://avatars3.githubusercontent.com/u/1588319?v=4","gravatar_id":"","url":"https://api.github.com/users/linsun","html_url":"https://github.com/linsun","followers_url":"https://api.github.com/users/linsun/followers","following_url":"https://api.github.com/users/linsun/following{/other_user}","gists_url":"https://api.github.com/users/linsun/gists{/gist_id}","starred_url":"https://api.github.com/users/linsun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linsun/subscriptions","organizations_url":"https://api.github.com/users/linsun/orgs","repos_url":"https://api.github.com/users/linsun/repos","events_url":"https://api.github.com/users/linsun/events{/privacy}","received_events_url":"https://api.github.com/users/linsun/received_events","type":"User","site_admin":false},{"login":"geeknoid","id":22780957,"avatar_url":"https://avatars3.githubusercontent.com/u/22780957?v=4","gravatar_id":"","url":"https://api.github.com/users/geeknoid","html_url":"https://github.com/geeknoid","followers_url":"https://api.github.com/users/geeknoid/followers","following_url":"https://api.github.com/users/geeknoid/following{/other_user}","gists_url":"https://api.github.com/users/geeknoid/gists{/gist_id}","starred_url":"https://api.github.com/users/geeknoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geeknoid/subscriptions","organizations_url":"https://api.github.com/users/geeknoid/orgs","repos_url":"https://api.github.com/users/geeknoid/repos","events_url":"https://api.github.com/users/geeknoid/events{/privacy}","received_events_url":"https://api.github.com/users/geeknoid/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":884247475,"url":"https://api.github.com/repos/istio/istio.github.io/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio.github.io/pulls/1286/commits","review_comments_url":"https://api.github.com/repos/istio/istio.github.io/pulls/1286/comments","review_comment_url":"https://api.github.com/repos/istio/istio.github.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio.github.io/issues/1286/comments","statuses_url":"https://api.github.com/repos/istio/istio.github.io/statuses/99131d21cd471c84d91f0c7e78ba52a1458b5896","head":{"label":"vadimeisenbergibm:second_take_finalize_ingress_tls","ref":"second_take_finalize_ingress_tls","sha":"99131d21cd471c84d91f0c7e78ba52a1458b5896","user":{"login":"vadimeisenbergibm","id":16784982,"avatar_url":"https://avatars1.githubusercontent.com/u/16784982?v=4","gravatar_id":"","url":"https://api.github.com/users/vadimeisenbergibm","html_url":"https://github.com/vadimeisenbergibm","followers_url":"https://api.github.com/users/vadimeisenbergibm/followers","following_url":"https://api.github.com/users/vadimeisenbergibm/following{/other_user}","gists_url":"https://api.github.com/users/vadimeisenbergibm/gists{/gist_id}","starred_url":"https://api.github.com/users/vadimeisenbergibm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadimeisenbergibm/subscriptions","organizations_url":"https://api.github.com/users/vadimeisenbergibm/orgs","repos_url":"https://api.github.com/users/vadimeisenbergibm/repos","events_url":"https://api.github.com/users/vadimeisenbergibm/events{/privacy}","received_events_url":"https://api.github.com/users/vadimeisenbergibm/received_events","type":"User","site_admin":false},"repo":{"id":108989395,"name":"vadimeisenbergibm.github.io","full_name":"vadimeisenbergibm/vadimeisenbergibm.github.io","owner":{"login":"vadimeisenbergibm","id":16784982,"avatar_url":"https://avatars1.githubusercontent.com/u/16784982?v=4","gravatar_id":"","url":"https://api.github.com/users/vadimeisenbergibm","html_url":"https://github.com/vadimeisenbergibm","followers_url":"https://api.github.com/users/vadimeisenbergibm/followers","following_url":"https://api.github.com/users/vadimeisenbergibm/following{/other_user}","gists_url":"https://api.github.com/users/vadimeisenbergibm/gists{/gist_id}","starred_url":"https://api.github.com/users/vadimeisenbergibm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadimeisenbergibm/subscriptions","organizations_url":"https://api.github.com/users/vadimeisenbergibm/orgs","repos_url":"https://api.github.com/users/vadimeisenbergibm/repos","events_url":"https://api.github.com/users/vadimeisenbergibm/events{/privacy}","received_events_url":"https://api.github.com/users/vadimeisenbergibm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vadimeisenbergibm/vadimeisenbergibm.github.io","description":"Source for the istio.io site","fork":true,"url":"https://api.github.com/repos/vadimeisenbergibm/vadimeisenbergibm.github.io","forks_url":"https://api.github.com/repos/vadimeisenbergibm/vadimeisenbergibm.github.io/forks","keys_url":"https://api.github.com/repos/vadimeisenbergibm/vadimeisenbergibm.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vadimeisenbergibm/vadimeisenbergibm.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vadimeisenbergibm/vadimeisenbergibm.github.io/teams","hooks_url":"https://api.github.com/repos/vadimeisenbergibm/vadimeisenbergibm.github.io/hooks","issue_events_url":"https://api.github.com/repos/vadimeisenbergibm/vadimeisenbergibm.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/vadimeisenbergibm/vadimeisenbergibm.github.io/events","assignees_url":"https://api.github.com/repos/vadimeisenbergibm/vadimeisenbergibm.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/vadimeisenbergibm/vadimeisenbergibm.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/vadimeisenbergibm/vadimeisenbergibm.github.io/tags","blobs_url":"https://api.github.com/repos/vadimeisenbergibm/vadimeisenbergibm.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vadimeisenbergibm/vadimeisenbergibm.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vadimeisenbergibm/vadimeisenbergibm.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/vadimeisenbergibm/vadimeisenbergibm.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vadimeisenbergibm/vadimeisenbergibm.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/vadimeisenbergibm/vadimeisenbergibm.github.io/languages","stargazers_url":"https://api.github.com/repos/vadimeisenbergibm/vadimeisenbergibm.github.io/stargazers","contributors_url":"https://api.github.com/repos/vadimeisenbergibm/vadimeisenbergibm.github.io/contributors","subscribers_url":"https://api.github.com/repos/vadimeisenbergibm/vadimeisenbergibm.github.io/subscribers","subscription_url":"https://api.github.com/repos/vadimeisenbergibm/vadimeisenbergibm.github.io/subscription","commits_url":"https://api.github.com/repos/vadimeisenbergibm/vadimeisenbergibm.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/vadimeisenbergibm/vadimeisenbergibm.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/vadimeisenbergibm/vadimeisenbergibm.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/vadimeisenbergibm/vadimeisenbergibm.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/vadimeisenbergibm/vadimeisenbergibm.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/vadimeisenbergibm/vadimeisenbergibm.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vadimeisenbergibm/vadimeisenbergibm.github.io/merges","archive_url":"https://api.github.com/repos/vadimeisenbergibm/vadimeisenbergibm.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vadimeisenbergibm/vadimeisenbergibm.github.io/downloads","issues_url":"https://api.github.com/repos/vadimeisenbergibm/vadimeisenbergibm.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/vadimeisenbergibm/vadimeisenbergibm.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/vadimeisenbergibm/vadimeisenbergibm.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/vadimeisenbergibm/vadimeisenbergibm.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vadimeisenbergibm/vadimeisenbergibm.github.io/labels{/name}","releases_url":"https://api.github.com/repos/vadimeisenbergibm/vadimeisenbergibm.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/vadimeisenbergibm/vadimeisenbergibm.github.io/deployments","created_at":"2017-10-31T12:00:29Z","updated_at":"2018-05-15T15:25:27Z","pushed_at":"2018-05-17T16:43:15Z","git_url":"git://github.com/vadimeisenbergibm/vadimeisenbergibm.github.io.git","ssh_url":"git@github.com:vadimeisenbergibm/vadimeisenbergibm.github.io.git","clone_url":"https://github.com/vadimeisenbergibm/vadimeisenbergibm.github.io.git","svn_url":"https://github.com/vadimeisenbergibm/vadimeisenbergibm.github.io","homepage":"https://istio.io/","size":24754,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"add_bookinfo_gateway"}},"base":{"label":"istio:master","ref":"master","sha":"ca98b17ddf640ee03dfca5eb2140f26874e2e90f","user":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":82706976,"name":"istio.github.io","full_name":"istio/istio.github.io","owner":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/istio.github.io","description":"Source for the istio.io site","fork":false,"url":"https://api.github.com/repos/istio/istio.github.io","forks_url":"https://api.github.com/repos/istio/istio.github.io/forks","keys_url":"https://api.github.com/repos/istio/istio.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio.github.io/teams","hooks_url":"https://api.github.com/repos/istio/istio.github.io/hooks","issue_events_url":"https://api.github.com/repos/istio/istio.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio.github.io/events","assignees_url":"https://api.github.com/repos/istio/istio.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio.github.io/tags","blobs_url":"https://api.github.com/repos/istio/istio.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio.github.io/languages","stargazers_url":"https://api.github.com/repos/istio/istio.github.io/stargazers","contributors_url":"https://api.github.com/repos/istio/istio.github.io/contributors","subscribers_url":"https://api.github.com/repos/istio/istio.github.io/subscribers","subscription_url":"https://api.github.com/repos/istio/istio.github.io/subscription","commits_url":"https://api.github.com/repos/istio/istio.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio.github.io/merges","archive_url":"https://api.github.com/repos/istio/istio.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio.github.io/downloads","issues_url":"https://api.github.com/repos/istio/istio.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio.github.io/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio.github.io/deployments","created_at":"2017-02-21T17:19:49Z","updated_at":"2018-05-17T20:14:58Z","pushed_at":"2018-05-17T20:35:06Z","git_url":"git://github.com/istio/istio.github.io.git","ssh_url":"git@github.com:istio/istio.github.io.git","clone_url":"https://github.com/istio/istio.github.io.git","svn_url":"https://github.com/istio/istio.github.io","homepage":"https://istio.io/","size":23538,"stargazers_count":58,"watchers_count":58,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":186,"mirror_url":null,"archived":false,"open_issues_count":68,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":186,"open_issues":68,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio.github.io/pulls/1286"},"html":{"href":"https://github.com/istio/istio.github.io/pull/1286"},"issue":{"href":"https://api.github.com/repos/istio/istio.github.io/issues/1286"},"comments":{"href":"https://api.github.com/repos/istio/istio.github.io/issues/1286/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio.github.io/pulls/1286/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio.github.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio.github.io/pulls/1286/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio.github.io/statuses/99131d21cd471c84d91f0c7e78ba52a1458b5896"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"frankbu"}}