{"action":"created","comment":{"url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/comments/178339434","pull_request_review_id":108390703,"id":178339434,"diff_hunk":"@@ -1,7 +1,9 @@\n FROM tfb/sbt:latest\n \n-COPY ./play2-scala-slick ./\n+ADD ./play2-scala-slick /play_app\n+WORKDIR /play_app\n \n RUN sbt stage\n \n-CMD target/universal/stage/bin/play2-scala-slick -Dplay.server.provider=play.core.server.NettyServerProvider\n+CMD target/universal/stage/bin/play2-scala-slick","path":"frameworks/Scala/play2-scala/play2-scala-slick-netty.dockerfile","position":10,"original_position":10,"commit_id":"db3d1018970687a0a44163c36dba8540aab6ab31","original_commit_id":"db3d1018970687a0a44163c36dba8540aab6ab31","user":{"login":"michaelhixson","id":297150,"avatar_url":"https://avatars3.githubusercontent.com/u/297150?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelhixson","html_url":"https://github.com/michaelhixson","followers_url":"https://api.github.com/users/michaelhixson/followers","following_url":"https://api.github.com/users/michaelhixson/following{/other_user}","gists_url":"https://api.github.com/users/michaelhixson/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelhixson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelhixson/subscriptions","organizations_url":"https://api.github.com/users/michaelhixson/orgs","repos_url":"https://api.github.com/users/michaelhixson/repos","events_url":"https://api.github.com/users/michaelhixson/events{/privacy}","received_events_url":"https://api.github.com/users/michaelhixson/received_events","type":"User","site_admin":false},"body":"Thanks for debugging.  I admit I got impatient and didn't actually run the play2 tests locally.","created_at":"2018-03-30T18:00:36Z","updated_at":"2018-03-30T18:00:37Z","html_url":"https://github.com/TechEmpower/FrameworkBenchmarks/pull/3473#discussion_r178339434","pull_request_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/3473","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/comments/178339434"},"html":{"href":"https://github.com/TechEmpower/FrameworkBenchmarks/pull/3473#discussion_r178339434"},"pull_request":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/3473"}},"in_reply_to_id":178308108},"pull_request":{"url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/3473","id":178200622,"html_url":"https://github.com/TechEmpower/FrameworkBenchmarks/pull/3473","diff_url":"https://github.com/TechEmpower/FrameworkBenchmarks/pull/3473.diff","patch_url":"https://github.com/TechEmpower/FrameworkBenchmarks/pull/3473.patch","issue_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues/3473","number":3473,"state":"open","locked":false,"title":"Misc cleanup and upgrades in Scala frameworks","user":{"login":"michaelhixson","id":297150,"avatar_url":"https://avatars3.githubusercontent.com/u/297150?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelhixson","html_url":"https://github.com/michaelhixson","followers_url":"https://api.github.com/users/michaelhixson/followers","following_url":"https://api.github.com/users/michaelhixson/following{/other_user}","gists_url":"https://api.github.com/users/michaelhixson/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelhixson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelhixson/subscriptions","organizations_url":"https://api.github.com/users/michaelhixson/orgs","repos_url":"https://api.github.com/users/michaelhixson/repos","events_url":"https://api.github.com/users/michaelhixson/events{/privacy}","received_events_url":"https://api.github.com/users/michaelhixson/received_events","type":"User","site_admin":false},"body":"- Upgrade to Scala 2.12.5\r\n- Upgrade to sbt 1.1.2\r\n- Use sbt assembly plugin instead of onejar plugin, since the onejar\r\n  plugin was preventing upgrades to sbt 1.x\r\n- Delete scruffy, whose github project page no longer exists, it was\r\n  probably abandoned\r\n- Explicitly set working directory in scala framework dockerfiles rather\r\n  than inheriting it from the sbt dockerfiles (which were inheriting it\r\n  from java dockerfiles, so all the work was being done in /java?)\r\n- The main Scala website says to use Java 8, so don't bother having an\r\n  alternative sbt(-not-java8) dockerfile.\r\n- Remove spray because according to its GitHub project page, it was\r\n  abandoned and people should use akka instead.\r\n- Remove s-server because it doesn't have a release that's compatible\r\n  with the newest version of Scala, and the framework hasn't been worked\r\n  on in about a year, and it probably never had many users.  We could\r\n  leave it there working with an old Scala version, but what would happen\r\n  is we'd run into this again down the road next time we want to get\r\n  Scala or Java updated.  The upside to including this framework isn't\r\n  enough to justify that use of time.","created_at":"2018-03-29T00:40:45Z","updated_at":"2018-03-30T18:00:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"220621a04c5a479ec5aec172e82a9249592a45e4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":839287897,"url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/labels/PR:%20Docker","name":"PR: Docker","color":"3f85c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/3473/commits","review_comments_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/3473/comments","review_comment_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues/3473/comments","statuses_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/statuses/db3d1018970687a0a44163c36dba8540aab6ab31","head":{"label":"michaelhixson:scala-2.12.5-sbt-1.1.2","ref":"scala-2.12.5-sbt-1.1.2","sha":"db3d1018970687a0a44163c36dba8540aab6ab31","user":{"login":"michaelhixson","id":297150,"avatar_url":"https://avatars3.githubusercontent.com/u/297150?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelhixson","html_url":"https://github.com/michaelhixson","followers_url":"https://api.github.com/users/michaelhixson/followers","following_url":"https://api.github.com/users/michaelhixson/following{/other_user}","gists_url":"https://api.github.com/users/michaelhixson/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelhixson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelhixson/subscriptions","organizations_url":"https://api.github.com/users/michaelhixson/orgs","repos_url":"https://api.github.com/users/michaelhixson/repos","events_url":"https://api.github.com/users/michaelhixson/events{/privacy}","received_events_url":"https://api.github.com/users/michaelhixson/received_events","type":"User","site_admin":false},"repo":{"id":80167535,"name":"FrameworkBenchmarks","full_name":"michaelhixson/FrameworkBenchmarks","owner":{"login":"michaelhixson","id":297150,"avatar_url":"https://avatars3.githubusercontent.com/u/297150?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelhixson","html_url":"https://github.com/michaelhixson","followers_url":"https://api.github.com/users/michaelhixson/followers","following_url":"https://api.github.com/users/michaelhixson/following{/other_user}","gists_url":"https://api.github.com/users/michaelhixson/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelhixson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelhixson/subscriptions","organizations_url":"https://api.github.com/users/michaelhixson/orgs","repos_url":"https://api.github.com/users/michaelhixson/repos","events_url":"https://api.github.com/users/michaelhixson/events{/privacy}","received_events_url":"https://api.github.com/users/michaelhixson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/michaelhixson/FrameworkBenchmarks","description":"Source code for the framework benchmarking project","fork":true,"url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks","forks_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/forks","keys_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/teams","hooks_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/hooks","issue_events_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/issues/events{/number}","events_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/events","assignees_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/assignees{/user}","branches_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/branches{/branch}","tags_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/tags","blobs_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/git/refs{/sha}","trees_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/statuses/{sha}","languages_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/languages","stargazers_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/stargazers","contributors_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/contributors","subscribers_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/subscribers","subscription_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/subscription","commits_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/commits{/sha}","git_commits_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/git/commits{/sha}","comments_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/comments{/number}","issue_comment_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/issues/comments{/number}","contents_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/contents/{+path}","compare_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/merges","archive_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/downloads","issues_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/issues{/number}","pulls_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/pulls{/number}","milestones_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/milestones{/number}","notifications_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/labels{/name}","releases_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/releases{/id}","deployments_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/deployments","created_at":"2017-01-26T23:58:27Z","updated_at":"2018-03-13T19:39:03Z","pushed_at":"2018-03-29T23:12:43Z","git_url":"git://github.com/michaelhixson/FrameworkBenchmarks.git","ssh_url":"git@github.com:michaelhixson/FrameworkBenchmarks.git","clone_url":"https://github.com/michaelhixson/FrameworkBenchmarks.git","svn_url":"https://github.com/michaelhixson/FrameworkBenchmarks","homepage":"http://www.techempower.com/benchmarks/","size":278547,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TechEmpower:docker","ref":"docker","sha":"8aa3831d1aa51dc61cd4318b19307444255f7dd2","user":{"login":"TechEmpower","id":3910062,"avatar_url":"https://avatars2.githubusercontent.com/u/3910062?v=4","gravatar_id":"","url":"https://api.github.com/users/TechEmpower","html_url":"https://github.com/TechEmpower","followers_url":"https://api.github.com/users/TechEmpower/followers","following_url":"https://api.github.com/users/TechEmpower/following{/other_user}","gists_url":"https://api.github.com/users/TechEmpower/gists{/gist_id}","starred_url":"https://api.github.com/users/TechEmpower/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TechEmpower/subscriptions","organizations_url":"https://api.github.com/users/TechEmpower/orgs","repos_url":"https://api.github.com/users/TechEmpower/repos","events_url":"https://api.github.com/users/TechEmpower/events{/privacy}","received_events_url":"https://api.github.com/users/TechEmpower/received_events","type":"Organization","site_admin":false},"repo":{"id":8957264,"name":"FrameworkBenchmarks","full_name":"TechEmpower/FrameworkBenchmarks","owner":{"login":"TechEmpower","id":3910062,"avatar_url":"https://avatars2.githubusercontent.com/u/3910062?v=4","gravatar_id":"","url":"https://api.github.com/users/TechEmpower","html_url":"https://github.com/TechEmpower","followers_url":"https://api.github.com/users/TechEmpower/followers","following_url":"https://api.github.com/users/TechEmpower/following{/other_user}","gists_url":"https://api.github.com/users/TechEmpower/gists{/gist_id}","starred_url":"https://api.github.com/users/TechEmpower/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TechEmpower/subscriptions","organizations_url":"https://api.github.com/users/TechEmpower/orgs","repos_url":"https://api.github.com/users/TechEmpower/repos","events_url":"https://api.github.com/users/TechEmpower/events{/privacy}","received_events_url":"https://api.github.com/users/TechEmpower/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TechEmpower/FrameworkBenchmarks","description":"Source for the TechEmpower Framework Benchmarks project","fork":false,"url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks","forks_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/forks","keys_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/teams","hooks_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/hooks","issue_events_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues/events{/number}","events_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/events","assignees_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/assignees{/user}","branches_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/branches{/branch}","tags_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/tags","blobs_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/git/refs{/sha}","trees_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/statuses/{sha}","languages_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/languages","stargazers_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/stargazers","contributors_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/contributors","subscribers_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/subscribers","subscription_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/subscription","commits_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/commits{/sha}","git_commits_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/git/commits{/sha}","comments_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/comments{/number}","issue_comment_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues/comments{/number}","contents_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/contents/{+path}","compare_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/merges","archive_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/downloads","issues_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues{/number}","pulls_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls{/number}","milestones_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/milestones{/number}","notifications_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/labels{/name}","releases_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/releases{/id}","deployments_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/deployments","created_at":"2013-03-22T17:33:54Z","updated_at":"2018-03-30T10:51:14Z","pushed_at":"2018-03-30T15:33:38Z","git_url":"git://github.com/TechEmpower/FrameworkBenchmarks.git","ssh_url":"git@github.com:TechEmpower/FrameworkBenchmarks.git","clone_url":"https://github.com/TechEmpower/FrameworkBenchmarks.git","svn_url":"https://github.com/TechEmpower/FrameworkBenchmarks","homepage":"https://www.techempower.com/benchmarks/","size":271122,"stargazers_count":3136,"watchers_count":3136,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1028,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":1028,"open_issues":21,"watchers":3136,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/3473"},"html":{"href":"https://github.com/TechEmpower/FrameworkBenchmarks/pull/3473"},"issue":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues/3473"},"comments":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues/3473/comments"},"review_comments":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/3473/comments"},"review_comment":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/3473/commits"},"statuses":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/statuses/db3d1018970687a0a44163c36dba8540aab6ab31"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"michaelhixson"}}