{"action":"created","issue":{"url":"https://api.github.com/repos/systemd/systemd/issues/7264","repository_url":"https://api.github.com/repos/systemd/systemd","labels_url":"https://api.github.com/repos/systemd/systemd/issues/7264/labels{/name}","comments_url":"https://api.github.com/repos/systemd/systemd/issues/7264/comments","events_url":"https://api.github.com/repos/systemd/systemd/issues/7264/events","html_url":"https://github.com/systemd/systemd/pull/7264","id":271528842,"node_id":"MDExOlB1bGxSZXF1ZXN0MTUwODkxODI4","number":7264,"title":"test/test-functions: drop all prefixes","user":{"login":"xnox","id":19779,"node_id":"MDQ6VXNlcjE5Nzc5","avatar_url":"https://avatars1.githubusercontent.com/u/19779?v=4","gravatar_id":"","url":"https://api.github.com/users/xnox","html_url":"https://github.com/xnox","followers_url":"https://api.github.com/users/xnox/followers","following_url":"https://api.github.com/users/xnox/following{/other_user}","gists_url":"https://api.github.com/users/xnox/gists{/gist_id}","starred_url":"https://api.github.com/users/xnox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xnox/subscriptions","organizations_url":"https://api.github.com/users/xnox/orgs","repos_url":"https://api.github.com/users/xnox/repos","events_url":"https://api.github.com/users/xnox/events{/privacy}","received_events_url":"https://api.github.com/users/xnox/received_events","type":"User","site_admin":false},"labels":[{"id":275093828,"node_id":"MDU6TGFiZWwyNzUwOTM4Mjg=","url":"https://api.github.com/repos/systemd/systemd/labels/ci-fails/needs-rework%20%F0%9F%94%A5","name":"ci-fails/needs-rework 🔥","color":"e11d21","default":false},{"id":224437857,"node_id":"MDU6TGFiZWwyMjQ0Mzc4NTc=","url":"https://api.github.com/repos/systemd/systemd/labels/tests","name":"tests","color":"c7def8","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-11-06T16:07:42Z","updated_at":"2018-09-14T13:04:50Z","closed_at":"2018-09-14T13:03:24Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/systemd/systemd/pulls/7264","html_url":"https://github.com/systemd/systemd/pull/7264","diff_url":"https://github.com/systemd/systemd/pull/7264.diff","patch_url":"https://github.com/systemd/systemd/pull/7264.patch"},"body":"When parsing and installing binaries mentioned in Exec*= lines the\r\n5ed0dcf4d552271115d96d8d22b1a25494b85277 commit added parsing logic to drop\r\nprefixes, including handling duplicate exclamation marks. But this did not\r\nhandle arbitrary combination of multiple prefixes, ie. StartExec=+-/bin/sh was\r\nparsed as -/bin/sh which then would fail to install.\r\n\r\nInstead of using egrep and shell replacements, replace both with sed command\r\nthat does it all. This sed script extract a group of characters starting with a\r\n/ up to the first space (if any) after the equals sign. This correctly handles\r\nexisting non-prefixed, prefixed, multiple-prefixed commands.\r\n\r\nAbout half commands seem to repeat themself, thus sort -u cuts the list of\r\nbinaries to install about in half.\r\n\r\nTo validate change of behaviour both old and new functions were modified to\r\necho parsed binaries into separate files, and then diffed. The incorrect\r\n-/bin/sh was missing in the new output.\r\n\r\nWithout this patch tests fail on default Ubuntu installs."},"comment":{"url":"https://api.github.com/repos/systemd/systemd/issues/comments/421351951","html_url":"https://github.com/systemd/systemd/pull/7264#issuecomment-421351951","issue_url":"https://api.github.com/repos/systemd/systemd/issues/7264","id":421351951,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTM1MTk1MQ==","user":{"login":"keszybz","id":349618,"node_id":"MDQ6VXNlcjM0OTYxOA==","avatar_url":"https://avatars1.githubusercontent.com/u/349618?v=4","gravatar_id":"","url":"https://api.github.com/users/keszybz","html_url":"https://github.com/keszybz","followers_url":"https://api.github.com/users/keszybz/followers","following_url":"https://api.github.com/users/keszybz/following{/other_user}","gists_url":"https://api.github.com/users/keszybz/gists{/gist_id}","starred_url":"https://api.github.com/users/keszybz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keszybz/subscriptions","organizations_url":"https://api.github.com/users/keszybz/orgs","repos_url":"https://api.github.com/users/keszybz/repos","events_url":"https://api.github.com/users/keszybz/events{/privacy}","received_events_url":"https://api.github.com/users/keszybz/received_events","type":"User","site_admin":false},"created_at":"2018-09-14T13:04:50Z","updated_at":"2018-09-14T13:04:50Z","author_association":"MEMBER","body":"Hmmm, I tried to re-push to trigger CI, but github closed this automatically and doesn't allow me to push again. I'll just open a new PR. Sorry!"}}
{"actor":{"display_login":"keszybz"}}