{"action":"closed","issue":{"url":"https://api.github.com/repos/ethz-asl/cuckoo_time_translator/issues/53","repository_url":"https://api.github.com/repos/ethz-asl/cuckoo_time_translator","labels_url":"https://api.github.com/repos/ethz-asl/cuckoo_time_translator/issues/53/labels{/name}","comments_url":"https://api.github.com/repos/ethz-asl/cuckoo_time_translator/issues/53/comments","events_url":"https://api.github.com/repos/ethz-asl/cuckoo_time_translator/issues/53/events","html_url":"https://github.com/ethz-asl/cuckoo_time_translator/issues/53","id":386801523,"node_id":"MDU6SXNzdWUzODY4MDE1MjM=","number":53,"title":"error: ‘cuckoo_time_translator::UnwrappedStamp::UnwrappedStamp(uint64_t)’ is private","user":{"login":"rikba","id":11293852,"node_id":"MDQ6VXNlcjExMjkzODUy","avatar_url":"https://avatars2.githubusercontent.com/u/11293852?v=4","gravatar_id":"","url":"https://api.github.com/users/rikba","html_url":"https://github.com/rikba","followers_url":"https://api.github.com/users/rikba/followers","following_url":"https://api.github.com/users/rikba/following{/other_user}","gists_url":"https://api.github.com/users/rikba/gists{/gist_id}","starred_url":"https://api.github.com/users/rikba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rikba/subscriptions","organizations_url":"https://api.github.com/users/rikba/orgs","repos_url":"https://api.github.com/users/rikba/repos","events_url":"https://api.github.com/users/rikba/events{/privacy}","received_events_url":"https://api.github.com/users/rikba/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-12-03T12:44:02Z","updated_at":"2018-12-18T11:55:49Z","closed_at":"2018-12-18T11:55:49Z","author_association":"CONTRIBUTOR","body":"Hi @HannesSommer \r\n\r\nThanks again for your framework!\r\n\r\nWhen calling \r\n```ros::Time stamp = device_time_translator_->translate(msg.stamp);``` \r\nwhere\r\n`msg.stamp` is [std_msgs/Time](http://docs.ros.org/melodic/api/std_msgs/html/msg/Time.html) and\r\n`device_time_translator_` is `std::unique_ptr<cuckoo_time_translator::DefaultDeviceTimeUnwrapperAndTranslator>` \r\nwe get the error:\r\n```\r\nIn file included from /home/rikba/catkin_ws/src/cuckoo_time_translator/cuckoo_time_translator_algorithms/include/cuckoo_time_translator/TimestampUnwrapper.h:6:0,\r\n                 from /home/rikba/catkin_ws/src/cuckoo_time_translator/cuckoo_time_translator/include/cuckoo_time_translator/DeviceTimeTranslator.h:12,\r\n                 from /home/rikba/catkin_ws/src/mav_findmine/libs/fm_time_sync/include/fm_time_sync/relay.h:6,\r\n                 from /home/rikba/catkin_ws/src/mav_findmine/libs/fm_time_sync/src/relay.cc:1:\r\n/home/rikba/catkin_ws/src/cuckoo_time_translator/cuckoo_time_translator_algorithms/include/cuckoo_time_translator/ClockParameters.h: In member function ‘void fm_time_sync::Relay::processULandingMicroCallback(const ULandingMicro&)’:\r\n/home/rikba/catkin_ws/src/cuckoo_time_translator/cuckoo_time_translator_algorithms/include/cuckoo_time_translator/ClockParameters.h:18:3: error: ‘cuckoo_time_translator::UnwrappedStamp::UnwrappedStamp(uint64_t)’ is private\r\n   UnwrappedStamp(uint64_t stamp) : stamp_(stamp){}\r\n   ^\r\n/home/rikba/catkin_ws/src/mav_findmine/libs/fm_time_sync/src/relay.cc:229:51: error: within this context\r\n       device_time_translator_->translate(msg.stamp);\r\n                                                   ^\r\nmake[2]: *** [CMakeFiles/fm_time_sync.dir/src/relay.cc.o] Error 1\r\nmake[1]: *** [CMakeFiles/fm_time_sync.dir/all] Error 2\r\nmake: *** [all] Error 2\r\n```\r\n\r\nNo pressure but whenever you have time we would be happy to get some feedback."}}
{"actor":{"display_login":"rikba"}}