{"action":"created","comment":{"url":"https://api.github.com/repos/ravendb/ravendb/pulls/comments/227352045","pull_request_review_id":167371082,"id":227352045,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzM1MjA0NQ==","diff_hunk":"@@ -885,7 +886,11 @@ protected override int ExecuteCmd(DocumentsOperationContext context)\n                             });\n                             break;\n                         case CommandType.AttachmentCOPY:\n-                            var attachmentCopyResult = Database.DocumentsStorage.AttachmentsStorage.CopyAttachment(context, cmd.Id, cmd.Name, cmd.DestinationId, cmd.DestinationName, cmd.ChangeVector);\n+                            if (cmd.AttachmentType == 0)\n+                            {","path":"src/Raven.Server/Documents/Handlers/BatchHandler.cs","position":14,"original_position":14,"commit_id":"831ee1796d6b07ce786a22379f236ada532ea972","original_commit_id":"831ee1796d6b07ce786a22379f236ada532ea972","user":{"login":"ppekrol","id":446555,"node_id":"MDQ6VXNlcjQ0NjU1NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/446555?v=4","gravatar_id":"","url":"https://api.github.com/users/ppekrol","html_url":"https://github.com/ppekrol","followers_url":"https://api.github.com/users/ppekrol/followers","following_url":"https://api.github.com/users/ppekrol/following{/other_user}","gists_url":"https://api.github.com/users/ppekrol/gists{/gist_id}","starred_url":"https://api.github.com/users/ppekrol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppekrol/subscriptions","organizations_url":"https://api.github.com/users/ppekrol/orgs","repos_url":"https://api.github.com/users/ppekrol/repos","events_url":"https://api.github.com/users/ppekrol/events{/privacy}","received_events_url":"https://api.github.com/users/ppekrol/received_events","type":"User","site_admin":false},"body":"add a note here that when 'AttachmentType' is not send, we need to fallback to default which is 'AttachmentType.Document'","created_at":"2018-10-23T11:46:21Z","updated_at":"2018-10-23T11:46:21Z","html_url":"https://github.com/ravendb/ravendb/pull/7849#discussion_r227352045","pull_request_url":"https://api.github.com/repos/ravendb/ravendb/pulls/7849","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/comments/227352045"},"html":{"href":"https://github.com/ravendb/ravendb/pull/7849#discussion_r227352045"},"pull_request":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/7849"}}},"pull_request":{"url":"https://api.github.com/repos/ravendb/ravendb/pulls/7849","id":225004014,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MDA0MDE0","html_url":"https://github.com/ravendb/ravendb/pull/7849","diff_url":"https://github.com/ravendb/ravendb/pull/7849.diff","patch_url":"https://github.com/ravendb/ravendb/pull/7849.patch","issue_url":"https://api.github.com/repos/ravendb/ravendb/issues/7849","number":7849,"state":"open","locked":false,"title":"Raven db 7018","user":{"login":"ml054","id":1250431,"node_id":"MDQ6VXNlcjEyNTA0MzE=","avatar_url":"https://avatars0.githubusercontent.com/u/1250431?v=4","gravatar_id":"","url":"https://api.github.com/users/ml054","html_url":"https://github.com/ml054","followers_url":"https://api.github.com/users/ml054/followers","following_url":"https://api.github.com/users/ml054/following{/other_user}","gists_url":"https://api.github.com/users/ml054/gists{/gist_id}","starred_url":"https://api.github.com/users/ml054/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ml054/subscriptions","organizations_url":"https://api.github.com/users/ml054/orgs","repos_url":"https://api.github.com/users/ml054/repos","events_url":"https://api.github.com/users/ml054/events{/privacy}","received_events_url":"https://api.github.com/users/ml054/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-23T11:40:55Z","updated_at":"2018-10-23T11:46:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"675317647c77cd2428f82c7dfda8308055880801","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1029659226,"node_id":"MDU6TGFiZWwxMDI5NjU5MjI2","url":"https://api.github.com/repos/ravendb/ravendb/labels/v4.1","name":"v4.1","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ravendb/ravendb/pulls/7849/commits","review_comments_url":"https://api.github.com/repos/ravendb/ravendb/pulls/7849/comments","review_comment_url":"https://api.github.com/repos/ravendb/ravendb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ravendb/ravendb/issues/7849/comments","statuses_url":"https://api.github.com/repos/ravendb/ravendb/statuses/831ee1796d6b07ce786a22379f236ada532ea972","head":{"label":"ml054:RavenDB_7018","ref":"RavenDB_7018","sha":"831ee1796d6b07ce786a22379f236ada532ea972","user":{"login":"ml054","id":1250431,"node_id":"MDQ6VXNlcjEyNTA0MzE=","avatar_url":"https://avatars0.githubusercontent.com/u/1250431?v=4","gravatar_id":"","url":"https://api.github.com/users/ml054","html_url":"https://github.com/ml054","followers_url":"https://api.github.com/users/ml054/followers","following_url":"https://api.github.com/users/ml054/following{/other_user}","gists_url":"https://api.github.com/users/ml054/gists{/gist_id}","starred_url":"https://api.github.com/users/ml054/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ml054/subscriptions","organizations_url":"https://api.github.com/users/ml054/orgs","repos_url":"https://api.github.com/users/ml054/repos","events_url":"https://api.github.com/users/ml054/events{/privacy}","received_events_url":"https://api.github.com/users/ml054/received_events","type":"User","site_admin":false},"repo":{"id":9543836,"node_id":"MDEwOlJlcG9zaXRvcnk5NTQzODM2","name":"ravendb","full_name":"ml054/ravendb","private":false,"owner":{"login":"ml054","id":1250431,"node_id":"MDQ6VXNlcjEyNTA0MzE=","avatar_url":"https://avatars0.githubusercontent.com/u/1250431?v=4","gravatar_id":"","url":"https://api.github.com/users/ml054","html_url":"https://github.com/ml054","followers_url":"https://api.github.com/users/ml054/followers","following_url":"https://api.github.com/users/ml054/following{/other_user}","gists_url":"https://api.github.com/users/ml054/gists{/gist_id}","starred_url":"https://api.github.com/users/ml054/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ml054/subscriptions","organizations_url":"https://api.github.com/users/ml054/orgs","repos_url":"https://api.github.com/users/ml054/repos","events_url":"https://api.github.com/users/ml054/events{/privacy}","received_events_url":"https://api.github.com/users/ml054/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ml054/ravendb","description":"A linq enabled document database for .NET","fork":true,"url":"https://api.github.com/repos/ml054/ravendb","forks_url":"https://api.github.com/repos/ml054/ravendb/forks","keys_url":"https://api.github.com/repos/ml054/ravendb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ml054/ravendb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ml054/ravendb/teams","hooks_url":"https://api.github.com/repos/ml054/ravendb/hooks","issue_events_url":"https://api.github.com/repos/ml054/ravendb/issues/events{/number}","events_url":"https://api.github.com/repos/ml054/ravendb/events","assignees_url":"https://api.github.com/repos/ml054/ravendb/assignees{/user}","branches_url":"https://api.github.com/repos/ml054/ravendb/branches{/branch}","tags_url":"https://api.github.com/repos/ml054/ravendb/tags","blobs_url":"https://api.github.com/repos/ml054/ravendb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ml054/ravendb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ml054/ravendb/git/refs{/sha}","trees_url":"https://api.github.com/repos/ml054/ravendb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ml054/ravendb/statuses/{sha}","languages_url":"https://api.github.com/repos/ml054/ravendb/languages","stargazers_url":"https://api.github.com/repos/ml054/ravendb/stargazers","contributors_url":"https://api.github.com/repos/ml054/ravendb/contributors","subscribers_url":"https://api.github.com/repos/ml054/ravendb/subscribers","subscription_url":"https://api.github.com/repos/ml054/ravendb/subscription","commits_url":"https://api.github.com/repos/ml054/ravendb/commits{/sha}","git_commits_url":"https://api.github.com/repos/ml054/ravendb/git/commits{/sha}","comments_url":"https://api.github.com/repos/ml054/ravendb/comments{/number}","issue_comment_url":"https://api.github.com/repos/ml054/ravendb/issues/comments{/number}","contents_url":"https://api.github.com/repos/ml054/ravendb/contents/{+path}","compare_url":"https://api.github.com/repos/ml054/ravendb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ml054/ravendb/merges","archive_url":"https://api.github.com/repos/ml054/ravendb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ml054/ravendb/downloads","issues_url":"https://api.github.com/repos/ml054/ravendb/issues{/number}","pulls_url":"https://api.github.com/repos/ml054/ravendb/pulls{/number}","milestones_url":"https://api.github.com/repos/ml054/ravendb/milestones{/number}","notifications_url":"https://api.github.com/repos/ml054/ravendb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ml054/ravendb/labels{/name}","releases_url":"https://api.github.com/repos/ml054/ravendb/releases{/id}","deployments_url":"https://api.github.com/repos/ml054/ravendb/deployments","created_at":"2013-04-19T11:17:04Z","updated_at":"2018-09-26T19:40:36Z","pushed_at":"2018-10-23T11:39:06Z","git_url":"git://github.com/ml054/ravendb.git","ssh_url":"git@github.com:ml054/ravendb.git","clone_url":"https://github.com/ml054/ravendb.git","svn_url":"https://github.com/ml054/ravendb","homepage":"http://ayende.com/Blog/","size":450196,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ravendb:v4.1","ref":"v4.1","sha":"7427ef628564cc4956bcb7df68b3c66b51ae3750","user":{"login":"ravendb","id":213792,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMzc5Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/213792?v=4","gravatar_id":"","url":"https://api.github.com/users/ravendb","html_url":"https://github.com/ravendb","followers_url":"https://api.github.com/users/ravendb/followers","following_url":"https://api.github.com/users/ravendb/following{/other_user}","gists_url":"https://api.github.com/users/ravendb/gists{/gist_id}","starred_url":"https://api.github.com/users/ravendb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravendb/subscriptions","organizations_url":"https://api.github.com/users/ravendb/orgs","repos_url":"https://api.github.com/users/ravendb/repos","events_url":"https://api.github.com/users/ravendb/events{/privacy}","received_events_url":"https://api.github.com/users/ravendb/received_events","type":"Organization","site_admin":false},"repo":{"id":542714,"node_id":"MDEwOlJlcG9zaXRvcnk1NDI3MTQ=","name":"ravendb","full_name":"ravendb/ravendb","private":false,"owner":{"login":"ravendb","id":213792,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMzc5Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/213792?v=4","gravatar_id":"","url":"https://api.github.com/users/ravendb","html_url":"https://github.com/ravendb","followers_url":"https://api.github.com/users/ravendb/followers","following_url":"https://api.github.com/users/ravendb/following{/other_user}","gists_url":"https://api.github.com/users/ravendb/gists{/gist_id}","starred_url":"https://api.github.com/users/ravendb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravendb/subscriptions","organizations_url":"https://api.github.com/users/ravendb/orgs","repos_url":"https://api.github.com/users/ravendb/repos","events_url":"https://api.github.com/users/ravendb/events{/privacy}","received_events_url":"https://api.github.com/users/ravendb/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ravendb/ravendb","description":"ACID Document Database","fork":false,"url":"https://api.github.com/repos/ravendb/ravendb","forks_url":"https://api.github.com/repos/ravendb/ravendb/forks","keys_url":"https://api.github.com/repos/ravendb/ravendb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ravendb/ravendb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ravendb/ravendb/teams","hooks_url":"https://api.github.com/repos/ravendb/ravendb/hooks","issue_events_url":"https://api.github.com/repos/ravendb/ravendb/issues/events{/number}","events_url":"https://api.github.com/repos/ravendb/ravendb/events","assignees_url":"https://api.github.com/repos/ravendb/ravendb/assignees{/user}","branches_url":"https://api.github.com/repos/ravendb/ravendb/branches{/branch}","tags_url":"https://api.github.com/repos/ravendb/ravendb/tags","blobs_url":"https://api.github.com/repos/ravendb/ravendb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ravendb/ravendb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ravendb/ravendb/git/refs{/sha}","trees_url":"https://api.github.com/repos/ravendb/ravendb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ravendb/ravendb/statuses/{sha}","languages_url":"https://api.github.com/repos/ravendb/ravendb/languages","stargazers_url":"https://api.github.com/repos/ravendb/ravendb/stargazers","contributors_url":"https://api.github.com/repos/ravendb/ravendb/contributors","subscribers_url":"https://api.github.com/repos/ravendb/ravendb/subscribers","subscription_url":"https://api.github.com/repos/ravendb/ravendb/subscription","commits_url":"https://api.github.com/repos/ravendb/ravendb/commits{/sha}","git_commits_url":"https://api.github.com/repos/ravendb/ravendb/git/commits{/sha}","comments_url":"https://api.github.com/repos/ravendb/ravendb/comments{/number}","issue_comment_url":"https://api.github.com/repos/ravendb/ravendb/issues/comments{/number}","contents_url":"https://api.github.com/repos/ravendb/ravendb/contents/{+path}","compare_url":"https://api.github.com/repos/ravendb/ravendb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ravendb/ravendb/merges","archive_url":"https://api.github.com/repos/ravendb/ravendb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ravendb/ravendb/downloads","issues_url":"https://api.github.com/repos/ravendb/ravendb/issues{/number}","pulls_url":"https://api.github.com/repos/ravendb/ravendb/pulls{/number}","milestones_url":"https://api.github.com/repos/ravendb/ravendb/milestones{/number}","notifications_url":"https://api.github.com/repos/ravendb/ravendb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ravendb/ravendb/labels{/name}","releases_url":"https://api.github.com/repos/ravendb/ravendb/releases{/id}","deployments_url":"https://api.github.com/repos/ravendb/ravendb/deployments","created_at":"2010-03-02T11:05:30Z","updated_at":"2018-10-23T11:10:59Z","pushed_at":"2018-10-23T11:40:56Z","git_url":"git://github.com/ravendb/ravendb.git","ssh_url":"git@github.com:ravendb/ravendb.git","clone_url":"https://github.com/ravendb/ravendb.git","svn_url":"https://github.com/ravendb/ravendb","homepage":"https://ravendb.net","size":452153,"stargazers_count":2033,"watchers_count":2033,"language":"C#","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":701,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":701,"open_issues":8,"watchers":2033,"default_branch":"v4.1"}},"_links":{"self":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/7849"},"html":{"href":"https://github.com/ravendb/ravendb/pull/7849"},"issue":{"href":"https://api.github.com/repos/ravendb/ravendb/issues/7849"},"comments":{"href":"https://api.github.com/repos/ravendb/ravendb/issues/7849/comments"},"review_comments":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/7849/comments"},"review_comment":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/7849/commits"},"statuses":{"href":"https://api.github.com/repos/ravendb/ravendb/statuses/831ee1796d6b07ce786a22379f236ada532ea972"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ppekrol"}}