{"action":"created","comment":{"url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/pulls/comments/188842607","pull_request_review_id":120900320,"id":188842607,"diff_hunk":"@@ -275,27 +275,41 @@ export default {\n \n   fareMapping: {\n     'HSL:hki': 'HSL:hki',\n+    'HSL:hki2': 'HSL:hki',\n     'HSL:esp': 'HSL:esp',\n+    'HSL:esp2': 'HSL:esp',\n     'HSL:van': 'HSL:van',\n+    'HSL:van2': 'HSL:van',\n     'HSL:ker': 'HSL:ker',\n     'HSL:kir': 'HSL:kir',\n     'HSL:seu': 'HSL:seu',\n     'HSL:seu2': 'HSL:seu',\n     'HSL:seu3': 'HSL:seu',\n     'HSL:seu4': 'HSL:seu',\n+    'HSL:seu5': 'HSL:seu',\n     'HSL:lse': 'HSL:lse',\n     'HSL:lse2': 'HSL:lse',\n     'HSL:lse3': 'HSL:lse',\n     'HSL:lse4': 'HSL:lse',\n     'HSL:lse5': 'HSL:lse',\n+    'HSL:lse6': 'HSL:lse',\n     'HSL:kse': 'HSL:kse',\n+    'HSL:kse1': 'HSL:kse',\n     'HSL:kse2': 'HSL:kse',\n     'HSL:kse3': 'HSL:kse',\n     'HSL:kse4': 'HSL:kse',\n     'HSL:kse5': 'HSL:kse',\n     'HSL:kse6': 'HSL:kse',\n     'HSL:kse7': 'HSL:kse',\n     'HSL:kse8': 'HSL:kse',\n+    'HSL:kse9': 'HSL:kse',\n+    'HSL:kse10': 'HSL:kse',\n+    'HSL:kse11': 'HSL:kse',\n+    'HSL:kse12': 'HSL:kse',\n+    'HSL:kse13': 'HSL:kse',\n+    'HSL:kse14': 'HSL:kse',\n+    'HSL:kse15': 'HSL:kse',\n+    'HSL:kse16': 'HSL:kse',\n   },\n ","path":"app/configurations/config.hsl.js","position":40,"original_position":40,"commit_id":"c86fd4b8bacf2e297c661ae3a21aaf1b56bd9bcf","original_commit_id":"c86fd4b8bacf2e297c661ae3a21aaf1b56bd9bcf","user":{"login":"jolkkola","id":2669201,"avatar_url":"https://avatars1.githubusercontent.com/u/2669201?v=4","gravatar_id":"","url":"https://api.github.com/users/jolkkola","html_url":"https://github.com/jolkkola","followers_url":"https://api.github.com/users/jolkkola/followers","following_url":"https://api.github.com/users/jolkkola/following{/other_user}","gists_url":"https://api.github.com/users/jolkkola/gists{/gist_id}","starred_url":"https://api.github.com/users/jolkkola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jolkkola/subscriptions","organizations_url":"https://api.github.com/users/jolkkola/orgs","repos_url":"https://api.github.com/users/jolkkola/repos","events_url":"https://api.github.com/users/jolkkola/events{/privacy}","received_events_url":"https://api.github.com/users/jolkkola/received_events","type":"User","site_admin":false},"body":"Would it be feasible to just drop the numeric part of each identifier (i.e. 'HSL:kse10' -> 'HSL:kse')? Then this fareMapping would not be required to exist at all. Any new numeric extensions in the future would also work right away.\r\n\r\nIt also seems that the value of each pair is used as a key to retrieve the name of the ticket. Perhaps a unit test to check that the name exists for all possibilities would be in order.\r\n\r\nWe can revisit these ideas once the fare zones will be updated for the HSL area.","created_at":"2018-05-17T05:32:57Z","updated_at":"2018-05-17T05:34:42Z","html_url":"https://github.com/HSLdevcom/digitransit-ui/pull/2279#discussion_r188842607","pull_request_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/pulls/2279","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/HSLdevcom/digitransit-ui/pulls/comments/188842607"},"html":{"href":"https://github.com/HSLdevcom/digitransit-ui/pull/2279#discussion_r188842607"},"pull_request":{"href":"https://api.github.com/repos/HSLdevcom/digitransit-ui/pulls/2279"}}},"pull_request":{"url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/pulls/2279","id":188367459,"html_url":"https://github.com/HSLdevcom/digitransit-ui/pull/2279","diff_url":"https://github.com/HSLdevcom/digitransit-ui/pull/2279.diff","patch_url":"https://github.com/HSLdevcom/digitransit-ui/pull/2279.patch","issue_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/issues/2279","number":2279,"state":"open","locked":false,"title":"DT-2551","user":{"login":"vesameskanen","id":13776096,"avatar_url":"https://avatars1.githubusercontent.com/u/13776096?v=4","gravatar_id":"","url":"https://api.github.com/users/vesameskanen","html_url":"https://github.com/vesameskanen","followers_url":"https://api.github.com/users/vesameskanen/followers","following_url":"https://api.github.com/users/vesameskanen/following{/other_user}","gists_url":"https://api.github.com/users/vesameskanen/gists{/gist_id}","starred_url":"https://api.github.com/users/vesameskanen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vesameskanen/subscriptions","organizations_url":"https://api.github.com/users/vesameskanen/orgs","repos_url":"https://api.github.com/users/vesameskanen/repos","events_url":"https://api.github.com/users/vesameskanen/events{/privacy}","received_events_url":"https://api.github.com/users/vesameskanen/received_events","type":"User","site_admin":false},"body":"- Working fare zone config (starts working when GTFS gets updated to our  new specs)\r\n- Restore a temporarily disabled flow test","created_at":"2018-05-16T09:16:41Z","updated_at":"2018-05-17T05:34:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f035d7c6736465d00a92007a76f1be95339ea32b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/pulls/2279/commits","review_comments_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/pulls/2279/comments","review_comment_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/issues/2279/comments","statuses_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/statuses/c86fd4b8bacf2e297c661ae3a21aaf1b56bd9bcf","head":{"label":"HSLdevcom:DT-2551","ref":"DT-2551","sha":"c86fd4b8bacf2e297c661ae3a21aaf1b56bd9bcf","user":{"login":"HSLdevcom","id":2813507,"avatar_url":"https://avatars1.githubusercontent.com/u/2813507?v=4","gravatar_id":"","url":"https://api.github.com/users/HSLdevcom","html_url":"https://github.com/HSLdevcom","followers_url":"https://api.github.com/users/HSLdevcom/followers","following_url":"https://api.github.com/users/HSLdevcom/following{/other_user}","gists_url":"https://api.github.com/users/HSLdevcom/gists{/gist_id}","starred_url":"https://api.github.com/users/HSLdevcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HSLdevcom/subscriptions","organizations_url":"https://api.github.com/users/HSLdevcom/orgs","repos_url":"https://api.github.com/users/HSLdevcom/repos","events_url":"https://api.github.com/users/HSLdevcom/events{/privacy}","received_events_url":"https://api.github.com/users/HSLdevcom/received_events","type":"Organization","site_admin":false},"repo":{"id":32916096,"name":"digitransit-ui","full_name":"HSLdevcom/digitransit-ui","owner":{"login":"HSLdevcom","id":2813507,"avatar_url":"https://avatars1.githubusercontent.com/u/2813507?v=4","gravatar_id":"","url":"https://api.github.com/users/HSLdevcom","html_url":"https://github.com/HSLdevcom","followers_url":"https://api.github.com/users/HSLdevcom/followers","following_url":"https://api.github.com/users/HSLdevcom/following{/other_user}","gists_url":"https://api.github.com/users/HSLdevcom/gists{/gist_id}","starred_url":"https://api.github.com/users/HSLdevcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HSLdevcom/subscriptions","organizations_url":"https://api.github.com/users/HSLdevcom/orgs","repos_url":"https://api.github.com/users/HSLdevcom/repos","events_url":"https://api.github.com/users/HSLdevcom/events{/privacy}","received_events_url":"https://api.github.com/users/HSLdevcom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HSLdevcom/digitransit-ui","description":"Digitransit UI","fork":false,"url":"https://api.github.com/repos/HSLdevcom/digitransit-ui","forks_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/forks","keys_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/teams","hooks_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/hooks","issue_events_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/issues/events{/number}","events_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/events","assignees_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/assignees{/user}","branches_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/branches{/branch}","tags_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/tags","blobs_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/languages","stargazers_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/stargazers","contributors_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/contributors","subscribers_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/subscribers","subscription_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/subscription","commits_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/contents/{+path}","compare_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/merges","archive_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/downloads","issues_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/issues{/number}","pulls_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/labels{/name}","releases_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/releases{/id}","deployments_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/deployments","created_at":"2015-03-26T08:38:16Z","updated_at":"2018-05-16T15:39:49Z","pushed_at":"2018-05-17T03:43:16Z","git_url":"git://github.com/HSLdevcom/digitransit-ui.git","ssh_url":"git@github.com:HSLdevcom/digitransit-ui.git","clone_url":"https://github.com/HSLdevcom/digitransit-ui.git","svn_url":"https://github.com/HSLdevcom/digitransit-ui","homepage":"https://www.digitransit.fi/","size":61660,"stargazers_count":160,"watchers_count":160,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":112,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":52,"open_issues":112,"watchers":160,"default_branch":"master"}},"base":{"label":"HSLdevcom:master","ref":"master","sha":"39ef7ff24b1b8b1a340a28d4031e79a9719ca418","user":{"login":"HSLdevcom","id":2813507,"avatar_url":"https://avatars1.githubusercontent.com/u/2813507?v=4","gravatar_id":"","url":"https://api.github.com/users/HSLdevcom","html_url":"https://github.com/HSLdevcom","followers_url":"https://api.github.com/users/HSLdevcom/followers","following_url":"https://api.github.com/users/HSLdevcom/following{/other_user}","gists_url":"https://api.github.com/users/HSLdevcom/gists{/gist_id}","starred_url":"https://api.github.com/users/HSLdevcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HSLdevcom/subscriptions","organizations_url":"https://api.github.com/users/HSLdevcom/orgs","repos_url":"https://api.github.com/users/HSLdevcom/repos","events_url":"https://api.github.com/users/HSLdevcom/events{/privacy}","received_events_url":"https://api.github.com/users/HSLdevcom/received_events","type":"Organization","site_admin":false},"repo":{"id":32916096,"name":"digitransit-ui","full_name":"HSLdevcom/digitransit-ui","owner":{"login":"HSLdevcom","id":2813507,"avatar_url":"https://avatars1.githubusercontent.com/u/2813507?v=4","gravatar_id":"","url":"https://api.github.com/users/HSLdevcom","html_url":"https://github.com/HSLdevcom","followers_url":"https://api.github.com/users/HSLdevcom/followers","following_url":"https://api.github.com/users/HSLdevcom/following{/other_user}","gists_url":"https://api.github.com/users/HSLdevcom/gists{/gist_id}","starred_url":"https://api.github.com/users/HSLdevcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HSLdevcom/subscriptions","organizations_url":"https://api.github.com/users/HSLdevcom/orgs","repos_url":"https://api.github.com/users/HSLdevcom/repos","events_url":"https://api.github.com/users/HSLdevcom/events{/privacy}","received_events_url":"https://api.github.com/users/HSLdevcom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HSLdevcom/digitransit-ui","description":"Digitransit UI","fork":false,"url":"https://api.github.com/repos/HSLdevcom/digitransit-ui","forks_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/forks","keys_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/teams","hooks_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/hooks","issue_events_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/issues/events{/number}","events_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/events","assignees_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/assignees{/user}","branches_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/branches{/branch}","tags_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/tags","blobs_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/languages","stargazers_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/stargazers","contributors_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/contributors","subscribers_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/subscribers","subscription_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/subscription","commits_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/contents/{+path}","compare_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/merges","archive_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/downloads","issues_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/issues{/number}","pulls_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/labels{/name}","releases_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/releases{/id}","deployments_url":"https://api.github.com/repos/HSLdevcom/digitransit-ui/deployments","created_at":"2015-03-26T08:38:16Z","updated_at":"2018-05-16T15:39:49Z","pushed_at":"2018-05-17T03:43:16Z","git_url":"git://github.com/HSLdevcom/digitransit-ui.git","ssh_url":"git@github.com:HSLdevcom/digitransit-ui.git","clone_url":"https://github.com/HSLdevcom/digitransit-ui.git","svn_url":"https://github.com/HSLdevcom/digitransit-ui","homepage":"https://www.digitransit.fi/","size":61660,"stargazers_count":160,"watchers_count":160,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":112,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":52,"open_issues":112,"watchers":160,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HSLdevcom/digitransit-ui/pulls/2279"},"html":{"href":"https://github.com/HSLdevcom/digitransit-ui/pull/2279"},"issue":{"href":"https://api.github.com/repos/HSLdevcom/digitransit-ui/issues/2279"},"comments":{"href":"https://api.github.com/repos/HSLdevcom/digitransit-ui/issues/2279/comments"},"review_comments":{"href":"https://api.github.com/repos/HSLdevcom/digitransit-ui/pulls/2279/comments"},"review_comment":{"href":"https://api.github.com/repos/HSLdevcom/digitransit-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HSLdevcom/digitransit-ui/pulls/2279/commits"},"statuses":{"href":"https://api.github.com/repos/HSLdevcom/digitransit-ui/statuses/c86fd4b8bacf2e297c661ae3a21aaf1b56bd9bcf"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jolkkola"}}