{"action":"created","issue":{"url":"https://api.github.com/repos/mesonbuild/meson/issues/4584","repository_url":"https://api.github.com/repos/mesonbuild/meson","labels_url":"https://api.github.com/repos/mesonbuild/meson/issues/4584/labels{/name}","comments_url":"https://api.github.com/repos/mesonbuild/meson/issues/4584/comments","events_url":"https://api.github.com/repos/mesonbuild/meson/issues/4584/events","html_url":"https://github.com/mesonbuild/meson/pull/4584","id":386831304,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1NDU3NTE5","number":4584,"title":"pkgconfig: do not generated dependency on itself","user":{"login":"bluca","id":782193,"node_id":"MDQ6VXNlcjc4MjE5Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/782193?v=4","gravatar_id":"","url":"https://api.github.com/users/bluca","html_url":"https://github.com/bluca","followers_url":"https://api.github.com/users/bluca/followers","following_url":"https://api.github.com/users/bluca/following{/other_user}","gists_url":"https://api.github.com/users/bluca/gists{/gist_id}","starred_url":"https://api.github.com/users/bluca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluca/subscriptions","organizations_url":"https://api.github.com/users/bluca/orgs","repos_url":"https://api.github.com/users/bluca/repos","events_url":"https://api.github.com/users/bluca/events{/privacy}","received_events_url":"https://api.github.com/users/bluca/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-03T14:01:55Z","updated_at":"2018-12-03T15:49:17Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/mesonbuild/meson/pulls/4584","html_url":"https://github.com/mesonbuild/meson/pull/4584","diff_url":"https://github.com/mesonbuild/meson/pull/4584.diff","patch_url":"https://github.com/mesonbuild/meson/pull/4584.patch"},"body":"If a project generates a single pc file but multiple shared libraries\r\nwith dependencies on each other, the generated pc name will be used to\r\ngenerate a Requires.private dependency, which means the project will\r\ndepend on itself. This breaks at least some versions of pkg-config\r\n(0.27 in RHEL7) which cannot handle the recursion and error out.\r\n\r\nWhen adding the dependency using the pc name, check that it's not\r\non the project itself.\r\n\r\nFixes #4583"},"comment":{"url":"https://api.github.com/repos/mesonbuild/meson/issues/comments/443757797","html_url":"https://github.com/mesonbuild/meson/pull/4584#issuecomment-443757797","issue_url":"https://api.github.com/repos/mesonbuild/meson/issues/4584","id":443757797,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Mzc1Nzc5Nw==","user":{"login":"xclaesse","id":1379109,"node_id":"MDQ6VXNlcjEzNzkxMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/1379109?v=4","gravatar_id":"","url":"https://api.github.com/users/xclaesse","html_url":"https://github.com/xclaesse","followers_url":"https://api.github.com/users/xclaesse/followers","following_url":"https://api.github.com/users/xclaesse/following{/other_user}","gists_url":"https://api.github.com/users/xclaesse/gists{/gist_id}","starred_url":"https://api.github.com/users/xclaesse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xclaesse/subscriptions","organizations_url":"https://api.github.com/users/xclaesse/orgs","repos_url":"https://api.github.com/users/xclaesse/repos","events_url":"https://api.github.com/users/xclaesse/events{/privacy}","received_events_url":"https://api.github.com/users/xclaesse/received_events","type":"User","site_admin":false},"created_at":"2018-12-03T15:49:17Z","updated_at":"2018-12-03T15:49:17Z","author_association":"MEMBER","body":"There are other places where we use generated_pc that should be checked too, I think.\r\n\r\nI think this should be fixed by PR https://github.com/mesonbuild/meson/pull/4440 by setting `generated_pc` only after it's done generating the current pc file. Since we are reworking how that `generated_pc` works in that PR, I think it's better to keep it there.\r\n\r\nUnless it's too late to get #4440 into 0.49.0 release and we want a minimal fix instead of now? @jpakkane ?"}}
{"actor":{"display_login":"xclaesse"}}