{"action":"created","issue":{"url":"https://api.github.com/repos/jay0lee/GAM/issues/785","repository_url":"https://api.github.com/repos/jay0lee/GAM","labels_url":"https://api.github.com/repos/jay0lee/GAM/issues/785/labels{/name}","comments_url":"https://api.github.com/repos/jay0lee/GAM/issues/785/comments","events_url":"https://api.github.com/repos/jay0lee/GAM/issues/785/events","html_url":"https://github.com/jay0lee/GAM/pull/785","id":354009096,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwOTAwNzUx","number":785,"title":"Remove ability to promote/demote super admins; minor delegate cleanup","user":{"login":"taers232c","id":8731695,"node_id":"MDQ6VXNlcjg3MzE2OTU=","avatar_url":"https://avatars2.githubusercontent.com/u/8731695?v=4","gravatar_id":"","url":"https://api.github.com/users/taers232c","html_url":"https://github.com/taers232c","followers_url":"https://api.github.com/users/taers232c/followers","following_url":"https://api.github.com/users/taers232c/following{/other_user}","gists_url":"https://api.github.com/users/taers232c/gists{/gist_id}","starred_url":"https://api.github.com/users/taers232c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taers232c/subscriptions","organizations_url":"https://api.github.com/users/taers232c/orgs","repos_url":"https://api.github.com/users/taers232c/repos","events_url":"https://api.github.com/users/taers232c/events{/privacy}","received_events_url":"https://api.github.com/users/taers232c/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-25T12:34:09Z","updated_at":"2018-08-27T16:37:14Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/jay0lee/GAM/pulls/785","html_url":"https://github.com/jay0lee/GAM/pull/785","diff_url":"https://github.com/jay0lee/GAM/pull/785.diff","patch_url":"https://github.com/jay0lee/GAM/pull/785.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/jay0lee/GAM/issues/comments/416287114","html_url":"https://github.com/jay0lee/GAM/pull/785#issuecomment-416287114","issue_url":"https://api.github.com/repos/jay0lee/GAM/issues/785","id":416287114,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjI4NzExNA==","user":{"login":"taers232c","id":8731695,"node_id":"MDQ6VXNlcjg3MzE2OTU=","avatar_url":"https://avatars2.githubusercontent.com/u/8731695?v=4","gravatar_id":"","url":"https://api.github.com/users/taers232c","html_url":"https://github.com/taers232c","followers_url":"https://api.github.com/users/taers232c/followers","following_url":"https://api.github.com/users/taers232c/following{/other_user}","gists_url":"https://api.github.com/users/taers232c/gists{/gist_id}","starred_url":"https://api.github.com/users/taers232c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taers232c/subscriptions","organizations_url":"https://api.github.com/users/taers232c/orgs","repos_url":"https://api.github.com/users/taers232c/repos","events_url":"https://api.github.com/users/taers232c/events{/privacy}","received_events_url":"https://api.github.com/users/taers232c/received_events","type":"User","site_admin":false},"created_at":"2018-08-27T16:37:14Z","updated_at":"2018-08-27T16:37:14Z","author_association":"CONTRIBUTOR","body":"The error is handling the following case:\ngam users tom,dikc,harry delegate to bob\n\ndikc should have been dick; the continue let's gam proceed to harry\n\nRoss\n\nOn Mon, Aug 27, 2018 at 8:22 AM Jay Lee <notifications@github.com> wrote:\n\n> *@jay0lee* commented on this pull request.\n> ------------------------------\n>\n> In src/gam.py\n> <https://github.com/jay0lee/GAM/pull/785#discussion_r213013877>:\n>\n> > @@ -1508,6 +1508,8 @@ def addDelegates(users, i):\n>    for delegator in users:\n>      i += 1\n>      delegator, gmail = buildGmailGAPIObject(delegator)\n> +    if not gmail:\n> +      continue\n>\n> Not sure these are necessary. We should be skipping over auth or API call\n> errors on printing delegates because we can safely say that if we get an\n> error, no (working) delegations are in place that we should have reported\n> on. But in the case of creating/deleting delegations, if we get an auth or\n> API call error, we should fail so admin knows about it rather than only\n> getting some of the delegations in place.\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/jay0lee/GAM/pull/785#pullrequestreview-149758858>, or mute\n> the thread\n> <https://github.com/notifications/unsubscribe-auth/AIU8L5HHfNf55aF-9B-lCLoaWnxyp2tIks5uVA6ogaJpZM4WMXkq>\n> .\n>\n\n\n-- \nRoss Scroggs\nross.scroggs@gmail.com\n"}}
{"actor":{"display_login":"taers232c"}}