{"action":"created","comment":{"url":"https://api.github.com/repos/brave/brave-ios/pulls/comments/211715826","pull_request_review_id":148196478,"id":211715826,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTcxNTgyNg==","diff_hunk":"@@ -55,11 +55,8 @@ class TabLocationView: UIView {\n             }\n             updateTextWithURL()\n             pageOptionsButton.isHidden = (url == nil)","path":"Client/Frontend/Browser/TabLocationView.swift","position":3,"original_position":3,"commit_id":"184a2f6ef5a6f177561f8124a9ef3cae5b5d3670","original_commit_id":"184a2f6ef5a6f177561f8124a9ef3cae5b5d3670","user":{"login":"jhreis","id":2781690,"node_id":"MDQ6VXNlcjI3ODE2OTA=","avatar_url":"https://avatars3.githubusercontent.com/u/2781690?v=4","gravatar_id":"","url":"https://api.github.com/users/jhreis","html_url":"https://github.com/jhreis","followers_url":"https://api.github.com/users/jhreis/followers","following_url":"https://api.github.com/users/jhreis/following{/other_user}","gists_url":"https://api.github.com/users/jhreis/gists{/gist_id}","starred_url":"https://api.github.com/users/jhreis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhreis/subscriptions","organizations_url":"https://api.github.com/users/jhreis/orgs","repos_url":"https://api.github.com/users/jhreis/repos","events_url":"https://api.github.com/users/jhreis/events{/privacy}","received_events_url":"https://api.github.com/users/jhreis/received_events","type":"User","site_admin":false},"body":"Since this logic uses same conditional, should be clumped into your statement. Maybe chain if no optionals:\r\n`pageOptionsButton.isHidden = trackingProtectionButton.isHidden = (url == nil)\r\n","created_at":"2018-08-21T18:40:51Z","updated_at":"2018-08-21T18:40:55Z","html_url":"https://github.com/brave/brave-ios/pull/174#discussion_r211715826","pull_request_url":"https://api.github.com/repos/brave/brave-ios/pulls/174","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/brave/brave-ios/pulls/comments/211715826"},"html":{"href":"https://github.com/brave/brave-ios/pull/174#discussion_r211715826"},"pull_request":{"href":"https://api.github.com/repos/brave/brave-ios/pulls/174"}}},"pull_request":{"url":"https://api.github.com/repos/brave/brave-ios/pulls/174","id":209863743,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5ODYzNzQz","html_url":"https://github.com/brave/brave-ios/pull/174","diff_url":"https://github.com/brave/brave-ios/pull/174.diff","patch_url":"https://github.com/brave/brave-ios/pull/174.patch","issue_url":"https://api.github.com/repos/brave/brave-ios/issues/174","number":174,"state":"open","locked":false,"title":"Fix #170: Always show shields menu button even on new tabs","user":{"login":"kylehickinson","id":529104,"node_id":"MDQ6VXNlcjUyOTEwNA==","avatar_url":"https://avatars2.githubusercontent.com/u/529104?v=4","gravatar_id":"","url":"https://api.github.com/users/kylehickinson","html_url":"https://github.com/kylehickinson","followers_url":"https://api.github.com/users/kylehickinson/followers","following_url":"https://api.github.com/users/kylehickinson/following{/other_user}","gists_url":"https://api.github.com/users/kylehickinson/gists{/gist_id}","starred_url":"https://api.github.com/users/kylehickinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylehickinson/subscriptions","organizations_url":"https://api.github.com/users/kylehickinson/orgs","repos_url":"https://api.github.com/users/kylehickinson/repos","events_url":"https://api.github.com/users/kylehickinson/events{/privacy}","received_events_url":"https://api.github.com/users/kylehickinson/received_events","type":"User","site_admin":false},"body":"Displays just the copy when you view on a new tab.\r\n\r\n## Pull Request Checklist\r\n\r\n- [x] My patch has a standard commit message that looks like `Fix #123: This fixes the shattered coffee cup!`\r\n\r\n- [ ] I have updated the *Unit Tests* to cover new or changed functionality\r\n- [ ] I have updated the *UI Tests* to cover new or changed functionality\r\n- [x] I have made sure that localizable strings use `NSLocalizableString()`\r\n\r\n## Screenshots\r\n\r\n| New Tab | Shields On | Shields Off |\r\n| --- | --- | --- |\r\n| ![simulator screen shot - iphone 8 - 2018-08-21 at 11 16 51](https://user-images.githubusercontent.com/529104/44411124-d0cfe200-a533-11e8-8534-79393dde4bd2.png) | ![simulator screen shot - iphone 8 - 2018-08-21 at 11 16 44](https://user-images.githubusercontent.com/529104/44411106-c9a8d400-a533-11e8-8601-636dc23e3d85.png) | ![simulator screen shot - iphone 8 - 2018-08-21 at 11 19 02](https://user-images.githubusercontent.com/529104/44411236-0b397f00-a534-11e8-9963-b8604e64b589.png) |\r\n\r\n## Notes for testing this patch\r\n\r\n_None included_","created_at":"2018-08-21T15:20:01Z","updated_at":"2018-08-21T18:40:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0c7d1062ee134962a4f8fdcbf698b4beb015631","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tmancey","id":1188719,"node_id":"MDQ6VXNlcjExODg3MTk=","avatar_url":"https://avatars2.githubusercontent.com/u/1188719?v=4","gravatar_id":"","url":"https://api.github.com/users/tmancey","html_url":"https://github.com/tmancey","followers_url":"https://api.github.com/users/tmancey/followers","following_url":"https://api.github.com/users/tmancey/following{/other_user}","gists_url":"https://api.github.com/users/tmancey/gists{/gist_id}","starred_url":"https://api.github.com/users/tmancey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmancey/subscriptions","organizations_url":"https://api.github.com/users/tmancey/orgs","repos_url":"https://api.github.com/users/tmancey/repos","events_url":"https://api.github.com/users/tmancey/events{/privacy}","received_events_url":"https://api.github.com/users/tmancey/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/brave/brave-ios/pulls/174/commits","review_comments_url":"https://api.github.com/repos/brave/brave-ios/pulls/174/comments","review_comment_url":"https://api.github.com/repos/brave/brave-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brave/brave-ios/issues/174/comments","statuses_url":"https://api.github.com/repos/brave/brave-ios/statuses/184a2f6ef5a6f177561f8124a9ef3cae5b5d3670","head":{"label":"brave:brave-menu-visibility","ref":"brave-menu-visibility","sha":"184a2f6ef5a6f177561f8124a9ef3cae5b5d3670","user":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"repo":{"id":113486284,"node_id":"MDEwOlJlcG9zaXRvcnkxMTM0ODYyODQ=","name":"brave-ios","full_name":"brave/brave-ios","owner":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brave/brave-ios","description":"Brave iOS Browser","fork":false,"url":"https://api.github.com/repos/brave/brave-ios","forks_url":"https://api.github.com/repos/brave/brave-ios/forks","keys_url":"https://api.github.com/repos/brave/brave-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brave/brave-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brave/brave-ios/teams","hooks_url":"https://api.github.com/repos/brave/brave-ios/hooks","issue_events_url":"https://api.github.com/repos/brave/brave-ios/issues/events{/number}","events_url":"https://api.github.com/repos/brave/brave-ios/events","assignees_url":"https://api.github.com/repos/brave/brave-ios/assignees{/user}","branches_url":"https://api.github.com/repos/brave/brave-ios/branches{/branch}","tags_url":"https://api.github.com/repos/brave/brave-ios/tags","blobs_url":"https://api.github.com/repos/brave/brave-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brave/brave-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brave/brave-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/brave/brave-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brave/brave-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/brave/brave-ios/languages","stargazers_url":"https://api.github.com/repos/brave/brave-ios/stargazers","contributors_url":"https://api.github.com/repos/brave/brave-ios/contributors","subscribers_url":"https://api.github.com/repos/brave/brave-ios/subscribers","subscription_url":"https://api.github.com/repos/brave/brave-ios/subscription","commits_url":"https://api.github.com/repos/brave/brave-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/brave/brave-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/brave/brave-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/brave/brave-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/brave/brave-ios/contents/{+path}","compare_url":"https://api.github.com/repos/brave/brave-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brave/brave-ios/merges","archive_url":"https://api.github.com/repos/brave/brave-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brave/brave-ios/downloads","issues_url":"https://api.github.com/repos/brave/brave-ios/issues{/number}","pulls_url":"https://api.github.com/repos/brave/brave-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/brave/brave-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/brave/brave-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brave/brave-ios/labels{/name}","releases_url":"https://api.github.com/repos/brave/brave-ios/releases{/id}","deployments_url":"https://api.github.com/repos/brave/brave-ios/deployments","created_at":"2017-12-07T18:42:00Z","updated_at":"2018-08-21T18:28:29Z","pushed_at":"2018-08-21T18:29:04Z","git_url":"git://github.com/brave/brave-ios.git","ssh_url":"git@github.com:brave/brave-ios.git","clone_url":"https://github.com/brave/brave-ios.git","svn_url":"https://github.com/brave/brave-ios","homepage":"https://www.brave.com","size":158275,"stargazers_count":11,"watchers_count":11,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":52,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":9,"open_issues":52,"watchers":11,"default_branch":"development"}},"base":{"label":"brave:development","ref":"development","sha":"db1cdeb7f54467755ba7e229617e86b5ac534e6c","user":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"repo":{"id":113486284,"node_id":"MDEwOlJlcG9zaXRvcnkxMTM0ODYyODQ=","name":"brave-ios","full_name":"brave/brave-ios","owner":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brave/brave-ios","description":"Brave iOS Browser","fork":false,"url":"https://api.github.com/repos/brave/brave-ios","forks_url":"https://api.github.com/repos/brave/brave-ios/forks","keys_url":"https://api.github.com/repos/brave/brave-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brave/brave-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brave/brave-ios/teams","hooks_url":"https://api.github.com/repos/brave/brave-ios/hooks","issue_events_url":"https://api.github.com/repos/brave/brave-ios/issues/events{/number}","events_url":"https://api.github.com/repos/brave/brave-ios/events","assignees_url":"https://api.github.com/repos/brave/brave-ios/assignees{/user}","branches_url":"https://api.github.com/repos/brave/brave-ios/branches{/branch}","tags_url":"https://api.github.com/repos/brave/brave-ios/tags","blobs_url":"https://api.github.com/repos/brave/brave-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brave/brave-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brave/brave-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/brave/brave-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brave/brave-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/brave/brave-ios/languages","stargazers_url":"https://api.github.com/repos/brave/brave-ios/stargazers","contributors_url":"https://api.github.com/repos/brave/brave-ios/contributors","subscribers_url":"https://api.github.com/repos/brave/brave-ios/subscribers","subscription_url":"https://api.github.com/repos/brave/brave-ios/subscription","commits_url":"https://api.github.com/repos/brave/brave-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/brave/brave-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/brave/brave-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/brave/brave-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/brave/brave-ios/contents/{+path}","compare_url":"https://api.github.com/repos/brave/brave-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brave/brave-ios/merges","archive_url":"https://api.github.com/repos/brave/brave-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brave/brave-ios/downloads","issues_url":"https://api.github.com/repos/brave/brave-ios/issues{/number}","pulls_url":"https://api.github.com/repos/brave/brave-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/brave/brave-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/brave/brave-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brave/brave-ios/labels{/name}","releases_url":"https://api.github.com/repos/brave/brave-ios/releases{/id}","deployments_url":"https://api.github.com/repos/brave/brave-ios/deployments","created_at":"2017-12-07T18:42:00Z","updated_at":"2018-08-21T18:28:29Z","pushed_at":"2018-08-21T18:29:04Z","git_url":"git://github.com/brave/brave-ios.git","ssh_url":"git@github.com:brave/brave-ios.git","clone_url":"https://github.com/brave/brave-ios.git","svn_url":"https://github.com/brave/brave-ios","homepage":"https://www.brave.com","size":158275,"stargazers_count":11,"watchers_count":11,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":52,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":9,"open_issues":52,"watchers":11,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/brave/brave-ios/pulls/174"},"html":{"href":"https://github.com/brave/brave-ios/pull/174"},"issue":{"href":"https://api.github.com/repos/brave/brave-ios/issues/174"},"comments":{"href":"https://api.github.com/repos/brave/brave-ios/issues/174/comments"},"review_comments":{"href":"https://api.github.com/repos/brave/brave-ios/pulls/174/comments"},"review_comment":{"href":"https://api.github.com/repos/brave/brave-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brave/brave-ios/pulls/174/commits"},"statuses":{"href":"https://api.github.com/repos/brave/brave-ios/statuses/184a2f6ef5a6f177561f8124a9ef3cae5b5d3670"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jhreis"}}