{"action":"created","comment":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/comments/167269499","pull_request_review_id":95470567,"id":167269499,"diff_hunk":"@@ -5340,9 +5429,16 @@ - (void)cameraWillChangeAnimated:(BOOL)animated {\n         }\n     }\n \n-    if ( ! [self isSuppressingChangeDelimiters] && [self.delegate respondsToSelector:@selector(mapView:regionWillChangeAnimated:)])\n+    if ( ! [self isSuppressingChangeDelimiters] )\n     {\n-        [self.delegate mapView:self regionWillChangeAnimated:animated];\n+        if ([self.delegate respondsToSelector:@selector(mapView:regionWillChangeAnimated:reason:)])\n+        {\n+            [self.delegate mapView:self regionWillChangeAnimated:animated reason:self.cameraChangeReason];\n+        }\n+        else if ([self.delegate respondsToSelector:@selector(mapView:regionWillChangeAnimated:)])","path":"platform/ios/src/MGLMapView.mm","position":425,"original_position":425,"commit_id":"b8cd925db1b58a5d46584ebd0bfbb5fc459798e3","original_commit_id":"b8cd925db1b58a5d46584ebd0bfbb5fc459798e3","user":{"login":"julianrex","id":3765757,"avatar_url":"https://avatars0.githubusercontent.com/u/3765757?v=4","gravatar_id":"","url":"https://api.github.com/users/julianrex","html_url":"https://github.com/julianrex","followers_url":"https://api.github.com/users/julianrex/followers","following_url":"https://api.github.com/users/julianrex/following{/other_user}","gists_url":"https://api.github.com/users/julianrex/gists{/gist_id}","starred_url":"https://api.github.com/users/julianrex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianrex/subscriptions","organizations_url":"https://api.github.com/users/julianrex/orgs","repos_url":"https://api.github.com/users/julianrex/repos","events_url":"https://api.github.com/users/julianrex/events{/privacy}","received_events_url":"https://api.github.com/users/julianrex/received_events","type":"User","site_admin":false},"body":"I'm not in favour of calling both, I think it adds some confusion for the developer. I've added some documentation saying that the previous method will be deprecated in future.\r\n\r\nPerhaps it's better to the older methods as deprecated immediately? Thoughts @akitchen ?\r\n\r\nWhat are the conventions for deprecation? Do we comment first, then in a later release add the deprecation attribute, then in a further major release remove them?","created_at":"2018-02-09T16:05:41Z","updated_at":"2018-02-09T16:05:41Z","html_url":"https://github.com/mapbox/mapbox-gl-native/pull/11151#discussion_r167269499","pull_request_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/11151","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/comments/167269499"},"html":{"href":"https://github.com/mapbox/mapbox-gl-native/pull/11151#discussion_r167269499"},"pull_request":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/11151"}},"in_reply_to_id":167128929},"pull_request":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/11151","id":168000175,"html_url":"https://github.com/mapbox/mapbox-gl-native/pull/11151","diff_url":"https://github.com/mapbox/mapbox-gl-native/pull/11151.diff","patch_url":"https://github.com/mapbox/mapbox-gl-native/pull/11151.patch","issue_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/11151","number":11151,"state":"open","locked":false,"title":"Adds reason parameter to camera change delegate methods and add single tap method. ","user":{"login":"julianrex","id":3765757,"avatar_url":"https://avatars0.githubusercontent.com/u/3765757?v=4","gravatar_id":"","url":"https://api.github.com/users/julianrex","html_url":"https://github.com/julianrex","followers_url":"https://api.github.com/users/julianrex/followers","following_url":"https://api.github.com/users/julianrex/following{/other_user}","gists_url":"https://api.github.com/users/julianrex/gists{/gist_id}","starred_url":"https://api.github.com/users/julianrex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianrex/subscriptions","organizations_url":"https://api.github.com/users/julianrex/orgs","repos_url":"https://api.github.com/users/julianrex/repos","events_url":"https://api.github.com/users/julianrex/events{/privacy}","received_events_url":"https://api.github.com/users/julianrex/received_events","type":"User","site_admin":false},"body":"Addresses:\r\n- issues in #10674\r\n- Missing handler for UIApplicationWillResignActiveNotification\r\n\r\nCamera change reasons do not currently match Android's, but closely matches existing the existing MGLEvents. \r\n\r\nWith these changes it is not possible to distinguish programmatic camera changes that were triggered by the developer vs internally. However, the existing completion handler mechanism should be sufficient and we should consider adding handlers to any other public methods that change the camera.\r\n\r\n/cc @akitchen @lilykaiser @1ec5 @boundsj ","created_at":"2018-02-08T15:16:40Z","updated_at":"2018-02-09T16:05:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb35fb91400f932372bbcd9e0c2c4ce4ab87aefc","assignee":null,"assignees":[],"requested_reviewers":[{"login":"boundsj","id":63186,"avatar_url":"https://avatars2.githubusercontent.com/u/63186?v=4","gravatar_id":"","url":"https://api.github.com/users/boundsj","html_url":"https://github.com/boundsj","followers_url":"https://api.github.com/users/boundsj/followers","following_url":"https://api.github.com/users/boundsj/following{/other_user}","gists_url":"https://api.github.com/users/boundsj/gists{/gist_id}","starred_url":"https://api.github.com/users/boundsj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boundsj/subscriptions","organizations_url":"https://api.github.com/users/boundsj/orgs","repos_url":"https://api.github.com/users/boundsj/repos","events_url":"https://api.github.com/users/boundsj/events{/privacy}","received_events_url":"https://api.github.com/users/boundsj/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":77259310,"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels/feature","name":"feature","color":"0052cc","default":false},{"id":92400707,"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels/iOS","name":"iOS","color":"000000","default":false},{"id":214795135,"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels/%E2%9A%A0%EF%B8%8F%20DO%20NOT%20MERGE","name":"⚠️ DO NOT MERGE","color":"b60205","default":false}],"milestone":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/milestones/88","html_url":"https://github.com/mapbox/mapbox-gl-native/milestone/88","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/milestones/88/labels","id":3062254,"number":88,"title":"ios-v3.7.4","description":"","creator":{"login":"fabian-guerra","id":2745166,"avatar_url":"https://avatars2.githubusercontent.com/u/2745166?v=4","gravatar_id":"","url":"https://api.github.com/users/fabian-guerra","html_url":"https://github.com/fabian-guerra","followers_url":"https://api.github.com/users/fabian-guerra/followers","following_url":"https://api.github.com/users/fabian-guerra/following{/other_user}","gists_url":"https://api.github.com/users/fabian-guerra/gists{/gist_id}","starred_url":"https://api.github.com/users/fabian-guerra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabian-guerra/subscriptions","organizations_url":"https://api.github.com/users/fabian-guerra/orgs","repos_url":"https://api.github.com/users/fabian-guerra/repos","events_url":"https://api.github.com/users/fabian-guerra/events{/privacy}","received_events_url":"https://api.github.com/users/fabian-guerra/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":3,"state":"open","created_at":"2018-01-24T21:25:42Z","updated_at":"2018-02-08T16:00:01Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/11151/commits","review_comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/11151/comments","review_comment_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/11151/comments","statuses_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/statuses/b8cd925db1b58a5d46584ebd0bfbb5fc459798e3","head":{"label":"mapbox:jrex-10674","ref":"jrex-10674","sha":"b8cd925db1b58a5d46584ebd0bfbb5fc459798e3","user":{"login":"mapbox","id":600935,"avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":16286131,"name":"mapbox-gl-native","full_name":"mapbox/mapbox-gl-native","owner":{"login":"mapbox","id":600935,"avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/mapbox-gl-native","description":"Interactive, thoroughly customizable maps in native Android, iOS, macOS, Node.js, and Qt applications, powered by vector tiles and OpenGL","fork":false,"url":"https://api.github.com/repos/mapbox/mapbox-gl-native","forks_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/forks","keys_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/teams","hooks_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/hooks","issue_events_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/events","assignees_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/tags","blobs_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/languages","stargazers_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/stargazers","contributors_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/contributors","subscribers_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/subscribers","subscription_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/subscription","commits_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/merges","archive_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/downloads","issues_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/deployments","created_at":"2014-01-27T17:14:48Z","updated_at":"2018-02-09T14:21:39Z","pushed_at":"2018-02-09T15:46:47Z","git_url":"git://github.com/mapbox/mapbox-gl-native.git","ssh_url":"git@github.com:mapbox/mapbox-gl-native.git","clone_url":"https://github.com/mapbox/mapbox-gl-native.git","svn_url":"https://github.com/mapbox/mapbox-gl-native","homepage":"https://mapbox.com/mobile","size":188910,"stargazers_count":2427,"watchers_count":2427,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":756,"mirror_url":null,"archived":false,"open_issues_count":657,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":756,"open_issues":657,"watchers":2427,"default_branch":"master"}},"base":{"label":"mapbox:release-agua","ref":"release-agua","sha":"aeba621573d77e1ce4f72b1e9b39bde92bf174a2","user":{"login":"mapbox","id":600935,"avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":16286131,"name":"mapbox-gl-native","full_name":"mapbox/mapbox-gl-native","owner":{"login":"mapbox","id":600935,"avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/mapbox-gl-native","description":"Interactive, thoroughly customizable maps in native Android, iOS, macOS, Node.js, and Qt applications, powered by vector tiles and OpenGL","fork":false,"url":"https://api.github.com/repos/mapbox/mapbox-gl-native","forks_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/forks","keys_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/teams","hooks_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/hooks","issue_events_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/events","assignees_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/tags","blobs_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/languages","stargazers_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/stargazers","contributors_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/contributors","subscribers_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/subscribers","subscription_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/subscription","commits_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/merges","archive_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/downloads","issues_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/deployments","created_at":"2014-01-27T17:14:48Z","updated_at":"2018-02-09T14:21:39Z","pushed_at":"2018-02-09T15:46:47Z","git_url":"git://github.com/mapbox/mapbox-gl-native.git","ssh_url":"git@github.com:mapbox/mapbox-gl-native.git","clone_url":"https://github.com/mapbox/mapbox-gl-native.git","svn_url":"https://github.com/mapbox/mapbox-gl-native","homepage":"https://mapbox.com/mobile","size":188910,"stargazers_count":2427,"watchers_count":2427,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":756,"mirror_url":null,"archived":false,"open_issues_count":657,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":756,"open_issues":657,"watchers":2427,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/11151"},"html":{"href":"https://github.com/mapbox/mapbox-gl-native/pull/11151"},"issue":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/11151"},"comments":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/11151/comments"},"review_comments":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/11151/comments"},"review_comment":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/11151/commits"},"statuses":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/statuses/b8cd925db1b58a5d46584ebd0bfbb5fc459798e3"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"julianrex"}}