{"action":"created","comment":{"url":"https://api.github.com/repos/ansible/ansible/pulls/comments/237306747","pull_request_review_id":179573022,"id":237306747,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzMwNjc0Nw==","diff_hunk":"@@ -0,0 +1,77 @@\n+# TODO: Our current implementation does not handle SMTP authentication\n+\n+# NOTE: If the system does not support smtpd-tls (python 2.6 and older) we do basic tests\n+- name: Attempt to install smtpd-tls\n+  pip:\n+    name: smtpd-tls\n+    state: present\n+  ignore_errors: yes\n+  register: smtpd_tls","path":"test/integration/targets/mail/tasks/main.yml","position":9,"original_position":9,"commit_id":"56cbbed62e052be2e16890a2f1845bd1c2b7dea2","original_commit_id":"04cd6dd049bf59a4b55fe14a35e3af60bfe3f7f3","user":{"login":"mattclay","id":806360,"node_id":"MDQ6VXNlcjgwNjM2MA==","avatar_url":"https://avatars0.githubusercontent.com/u/806360?v=4","gravatar_id":"","url":"https://api.github.com/users/mattclay","html_url":"https://github.com/mattclay","followers_url":"https://api.github.com/users/mattclay/followers","following_url":"https://api.github.com/users/mattclay/following{/other_user}","gists_url":"https://api.github.com/users/mattclay/gists{/gist_id}","starred_url":"https://api.github.com/users/mattclay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattclay/subscriptions","organizations_url":"https://api.github.com/users/mattclay/orgs","repos_url":"https://api.github.com/users/mattclay/repos","events_url":"https://api.github.com/users/mattclay/events{/privacy}","received_events_url":"https://api.github.com/users/mattclay/received_events","type":"User","site_admin":false},"body":"Yes, having tests for this is a huge improvement. Thanks for putting this together.\r\n\r\nIt's a common theme putting together new tests. They look simple at first and then the corner cases take up 90% of the time required to finish them.","created_at":"2018-11-28T23:50:02Z","updated_at":"2018-11-28T23:50:02Z","html_url":"https://github.com/ansible/ansible/pull/49197#discussion_r237306747","pull_request_url":"https://api.github.com/repos/ansible/ansible/pulls/49197","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments/237306747"},"html":{"href":"https://github.com/ansible/ansible/pull/49197#discussion_r237306747"},"pull_request":{"href":"https://api.github.com/repos/ansible/ansible/pulls/49197"}},"in_reply_to_id":237249093},"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/49197","id":233973568,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzOTczNTY4","html_url":"https://github.com/ansible/ansible/pull/49197","diff_url":"https://github.com/ansible/ansible/pull/49197.diff","patch_url":"https://github.com/ansible/ansible/pull/49197.patch","issue_url":"https://api.github.com/repos/ansible/ansible/issues/49197","number":49197,"state":"open","locked":false,"title":"mail: Fix new breakage on python 2.7","user":{"login":"dagwieers","id":388198,"node_id":"MDQ6VXNlcjM4ODE5OA==","avatar_url":"https://avatars0.githubusercontent.com/u/388198?v=4","gravatar_id":"","url":"https://api.github.com/users/dagwieers","html_url":"https://github.com/dagwieers","followers_url":"https://api.github.com/users/dagwieers/followers","following_url":"https://api.github.com/users/dagwieers/following{/other_user}","gists_url":"https://api.github.com/users/dagwieers/gists{/gist_id}","starred_url":"https://api.github.com/users/dagwieers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagwieers/subscriptions","organizations_url":"https://api.github.com/users/dagwieers/orgs","repos_url":"https://api.github.com/users/dagwieers/repos","events_url":"https://api.github.com/users/dagwieers/events{/privacy}","received_events_url":"https://api.github.com/users/dagwieers/received_events","type":"User","site_admin":false},"body":"##### SUMMARY\r\nOnce again the mail module was broken on python 2.7.\r\nThis fixes the issue and adds an integration test to avoid future regressions.\r\n\r\nDuring testing we found issues using 'localhost' on Ubuntu 1404 containers, so we default to *127.0.0.1* instead of *localhost* now.\r\n\r\nNeeds to be backported to stable-2.7 as well.\r\n\r\nThis fixes #48785\r\n\r\n##### ISSUE TYPE\r\n- Bugfix Pull Request\r\n\r\n##### COMPONENT NAME\r\nmail","created_at":"2018-11-27T16:18:34Z","updated_at":"2018-11-28T23:50:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2ca0b242ab5ca363d117ce6bec5a74e2991b981","assignee":null,"assignees":[],"requested_reviewers":[{"login":"abadger","id":209242,"node_id":"MDQ6VXNlcjIwOTI0Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/209242?v=4","gravatar_id":"","url":"https://api.github.com/users/abadger","html_url":"https://github.com/abadger","followers_url":"https://api.github.com/users/abadger/followers","following_url":"https://api.github.com/users/abadger/following{/other_user}","gists_url":"https://api.github.com/users/abadger/gists{/gist_id}","starred_url":"https://api.github.com/users/abadger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abadger/subscriptions","organizations_url":"https://api.github.com/users/abadger/orgs","repos_url":"https://api.github.com/users/abadger/repos","events_url":"https://api.github.com/users/abadger/events{/privacy}","received_events_url":"https://api.github.com/users/abadger/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1043397454,"node_id":"MDU6TGFiZWwxMDQzMzk3NDU0","url":"https://api.github.com/repos/ansible/ansible/labels/affects_2.8","name":"affects_2.8","color":"ededed","default":false},{"id":785271699,"node_id":"MDU6TGFiZWw3ODUyNzE2OTk=","url":"https://api.github.com/repos/ansible/ansible/labels/bug","name":"bug","color":"fbca04","default":true},{"id":496359346,"node_id":"MDU6TGFiZWw0OTYzNTkzNDY=","url":"https://api.github.com/repos/ansible/ansible/labels/module","name":"module","color":"1d76db","default":false},{"id":61436281,"node_id":"MDU6TGFiZWw2MTQzNjI4MQ==","url":"https://api.github.com/repos/ansible/ansible/labels/needs_revision","name":"needs_revision","color":"eb6450","default":false},{"id":636327968,"node_id":"MDU6TGFiZWw2MzYzMjc5Njg=","url":"https://api.github.com/repos/ansible/ansible/labels/support:community","name":"support:community","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible/pulls/49197/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible/pulls/49197/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/49197/comments","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/56cbbed62e052be2e16890a2f1845bd1c2b7dea2","head":{"label":"dagwieers:mail-py27","ref":"mail-py27","sha":"56cbbed62e052be2e16890a2f1845bd1c2b7dea2","user":{"login":"dagwieers","id":388198,"node_id":"MDQ6VXNlcjM4ODE5OA==","avatar_url":"https://avatars0.githubusercontent.com/u/388198?v=4","gravatar_id":"","url":"https://api.github.com/users/dagwieers","html_url":"https://github.com/dagwieers","followers_url":"https://api.github.com/users/dagwieers/followers","following_url":"https://api.github.com/users/dagwieers/following{/other_user}","gists_url":"https://api.github.com/users/dagwieers/gists{/gist_id}","starred_url":"https://api.github.com/users/dagwieers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagwieers/subscriptions","organizations_url":"https://api.github.com/users/dagwieers/orgs","repos_url":"https://api.github.com/users/dagwieers/repos","events_url":"https://api.github.com/users/dagwieers/events{/privacy}","received_events_url":"https://api.github.com/users/dagwieers/received_events","type":"User","site_admin":false},"repo":{"id":3764960,"node_id":"MDEwOlJlcG9zaXRvcnkzNzY0OTYw","name":"ansible","full_name":"dagwieers/ansible","private":false,"owner":{"login":"dagwieers","id":388198,"node_id":"MDQ6VXNlcjM4ODE5OA==","avatar_url":"https://avatars0.githubusercontent.com/u/388198?v=4","gravatar_id":"","url":"https://api.github.com/users/dagwieers","html_url":"https://github.com/dagwieers","followers_url":"https://api.github.com/users/dagwieers/followers","following_url":"https://api.github.com/users/dagwieers/following{/other_user}","gists_url":"https://api.github.com/users/dagwieers/gists{/gist_id}","starred_url":"https://api.github.com/users/dagwieers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagwieers/subscriptions","organizations_url":"https://api.github.com/users/dagwieers/orgs","repos_url":"https://api.github.com/users/dagwieers/repos","events_url":"https://api.github.com/users/dagwieers/events{/privacy}","received_events_url":"https://api.github.com/users/dagwieers/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dagwieers/ansible","description":"Model-driven configuration management, multi-node deployment, and remote task execution system. Uses SSH by default, so there is no special software has to be installed on the nodes you manage. Ansible can be extended in any language. Note: The default branch is the development branch, if you need a stable version, see the release-XX branches, tags, or downloads.","fork":true,"url":"https://api.github.com/repos/dagwieers/ansible","forks_url":"https://api.github.com/repos/dagwieers/ansible/forks","keys_url":"https://api.github.com/repos/dagwieers/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dagwieers/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dagwieers/ansible/teams","hooks_url":"https://api.github.com/repos/dagwieers/ansible/hooks","issue_events_url":"https://api.github.com/repos/dagwieers/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/dagwieers/ansible/events","assignees_url":"https://api.github.com/repos/dagwieers/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/dagwieers/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/dagwieers/ansible/tags","blobs_url":"https://api.github.com/repos/dagwieers/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dagwieers/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dagwieers/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/dagwieers/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dagwieers/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/dagwieers/ansible/languages","stargazers_url":"https://api.github.com/repos/dagwieers/ansible/stargazers","contributors_url":"https://api.github.com/repos/dagwieers/ansible/contributors","subscribers_url":"https://api.github.com/repos/dagwieers/ansible/subscribers","subscription_url":"https://api.github.com/repos/dagwieers/ansible/subscription","commits_url":"https://api.github.com/repos/dagwieers/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/dagwieers/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/dagwieers/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/dagwieers/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/dagwieers/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/dagwieers/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dagwieers/ansible/merges","archive_url":"https://api.github.com/repos/dagwieers/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dagwieers/ansible/downloads","issues_url":"https://api.github.com/repos/dagwieers/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/dagwieers/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/dagwieers/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/dagwieers/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dagwieers/ansible/labels{/name}","releases_url":"https://api.github.com/repos/dagwieers/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/dagwieers/ansible/deployments","created_at":"2012-03-19T15:04:07Z","updated_at":"2018-10-21T23:43:50Z","pushed_at":"2018-11-28T23:40:14Z","git_url":"git://github.com/dagwieers/ansible.git","ssh_url":"git@github.com:dagwieers/ansible.git","clone_url":"https://github.com/dagwieers/ansible.git","svn_url":"https://github.com/dagwieers/ansible","homepage":"http://ansible.cc","size":131381,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1,"open_issues":0,"watchers":2,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"13a6b4a85645c50571a4192f73b91a93b54abb1d","user":{"login":"ansible","id":1507452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDc0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":3638964,"node_id":"MDEwOlJlcG9zaXRvcnkzNjM4OTY0","name":"ansible","full_name":"ansible/ansible","private":false,"owner":{"login":"ansible","id":1507452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDc0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ansible/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications — automate in a language that approaches plain English, using SSH, with no agents to install on remote systems. https://docs.ansible.com/ansible/","fork":false,"url":"https://api.github.com/repos/ansible/ansible","forks_url":"https://api.github.com/repos/ansible/ansible/forks","keys_url":"https://api.github.com/repos/ansible/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible/teams","hooks_url":"https://api.github.com/repos/ansible/ansible/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible/events","assignees_url":"https://api.github.com/repos/ansible/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible/tags","blobs_url":"https://api.github.com/repos/ansible/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible/subscription","commits_url":"https://api.github.com/repos/ansible/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible/merges","archive_url":"https://api.github.com/repos/ansible/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible/downloads","issues_url":"https://api.github.com/repos/ansible/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/ansible/deployments","created_at":"2012-03-06T14:58:02Z","updated_at":"2018-11-28T22:37:00Z","pushed_at":"2018-11-28T23:40:36Z","git_url":"git://github.com/ansible/ansible.git","ssh_url":"git@github.com:ansible/ansible.git","clone_url":"https://github.com/ansible/ansible.git","svn_url":"https://github.com/ansible/ansible","homepage":"https://www.ansible.com/","size":146140,"stargazers_count":33995,"watchers_count":33995,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13614,"mirror_url":null,"archived":false,"open_issues_count":5616,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":13614,"open_issues":5616,"watchers":33995,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/49197"},"html":{"href":"https://github.com/ansible/ansible/pull/49197"},"issue":{"href":"https://api.github.com/repos/ansible/ansible/issues/49197"},"comments":{"href":"https://api.github.com/repos/ansible/ansible/issues/49197/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible/pulls/49197/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible/pulls/49197/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible/statuses/56cbbed62e052be2e16890a2f1845bd1c2b7dea2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mattclay"}}