{"action":"created","comment":{"url":"https://api.github.com/repos/src-d/engine/pulls/comments/179789040","pull_request_review_id":110101859,"id":179789040,"diff_hunk":"@@ -2,8 +2,10 @@ package tech.sourced.engine.iterator\n \n import org.apache.spark.internal.Logging\n import org.eclipse.jgit.diff.RawText\n+import org.eclipse.jgit.errors.MissingObjectException\n import org.eclipse.jgit.lib.{ObjectId, ObjectReader, Repository}\n import tech.sourced.engine.util.{CompiledFilter, Filters}\n+import scala.collection.JavaConverters.iterableAsScalaIterableConverter","path":"src/main/scala/tech/sourced/engine/iterator/BlobIterator.scala","position":7,"original_position":7,"commit_id":"50f1f94b5c3e4c4345942dceb3888a6e4a3ca9b9","original_commit_id":"50f1f94b5c3e4c4345942dceb3888a6e4a3ca9b9","user":{"login":"bzz","id":5582506,"avatar_url":"https://avatars3.githubusercontent.com/u/5582506?v=4","gravatar_id":"","url":"https://api.github.com/users/bzz","html_url":"https://github.com/bzz","followers_url":"https://api.github.com/users/bzz/followers","following_url":"https://api.github.com/users/bzz/following{/other_user}","gists_url":"https://api.github.com/users/bzz/gists{/gist_id}","starred_url":"https://api.github.com/users/bzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bzz/subscriptions","organizations_url":"https://api.github.com/users/bzz/orgs","repos_url":"https://api.github.com/users/bzz/repos","events_url":"https://api.github.com/users/bzz/events{/privacy}","received_events_url":"https://api.github.com/users/bzz/received_events","type":"User","site_admin":false},"body":"Thanks! Completely forgot about that one.","created_at":"2018-04-06T15:11:35Z","updated_at":"2018-04-06T15:11:35Z","html_url":"https://github.com/src-d/engine/pull/358#discussion_r179789040","pull_request_url":"https://api.github.com/repos/src-d/engine/pulls/358","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/src-d/engine/pulls/comments/179789040"},"html":{"href":"https://github.com/src-d/engine/pull/358#discussion_r179789040"},"pull_request":{"href":"https://api.github.com/repos/src-d/engine/pulls/358"}},"in_reply_to_id":179782269},"pull_request":{"url":"https://api.github.com/repos/src-d/engine/pulls/358","id":179965023,"html_url":"https://github.com/src-d/engine/pull/358","diff_url":"https://github.com/src-d/engine/pull/358.diff","patch_url":"https://github.com/src-d/engine/pull/358.patch","issue_url":"https://api.github.com/repos/src-d/engine/issues/358","number":358,"state":"open","locked":false,"title":"Add catch for MissingObjectException in BlobIterator","user":{"login":"carlosms","id":1469173,"avatar_url":"https://avatars0.githubusercontent.com/u/1469173?v=4","gravatar_id":"","url":"https://api.github.com/users/carlosms","html_url":"https://github.com/carlosms","followers_url":"https://api.github.com/users/carlosms/followers","following_url":"https://api.github.com/users/carlosms/following{/other_user}","gists_url":"https://api.github.com/users/carlosms/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosms/subscriptions","organizations_url":"https://api.github.com/users/carlosms/orgs","repos_url":"https://api.github.com/users/carlosms/repos","events_url":"https://api.github.com/users/carlosms/events{/privacy}","received_events_url":"https://api.github.com/users/carlosms/received_events","type":"User","site_admin":false},"body":"Fixes #357.\r\n\r\nThe code makes `BlobIterator.readFile` return `emptyByteArray` in case of a `MissingObjectException`. `mapColumns` is already storing empty byte arrays for binary Blobs.","created_at":"2018-04-06T14:29:28Z","updated_at":"2018-04-06T15:11:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4d1e3a7a5803a13ea6fbd8658f331e49413501d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/src-d/engine/pulls/358/commits","review_comments_url":"https://api.github.com/repos/src-d/engine/pulls/358/comments","review_comment_url":"https://api.github.com/repos/src-d/engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/src-d/engine/issues/358/comments","statuses_url":"https://api.github.com/repos/src-d/engine/statuses/50f1f94b5c3e4c4345942dceb3888a6e4a3ca9b9","head":{"label":"carlosms:issue-357","ref":"issue-357","sha":"50f1f94b5c3e4c4345942dceb3888a6e4a3ca9b9","user":{"login":"carlosms","id":1469173,"avatar_url":"https://avatars0.githubusercontent.com/u/1469173?v=4","gravatar_id":"","url":"https://api.github.com/users/carlosms","html_url":"https://github.com/carlosms","followers_url":"https://api.github.com/users/carlosms/followers","following_url":"https://api.github.com/users/carlosms/following{/other_user}","gists_url":"https://api.github.com/users/carlosms/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosms/subscriptions","organizations_url":"https://api.github.com/users/carlosms/orgs","repos_url":"https://api.github.com/users/carlosms/repos","events_url":"https://api.github.com/users/carlosms/events{/privacy}","received_events_url":"https://api.github.com/users/carlosms/received_events","type":"User","site_admin":false},"repo":{"id":125389598,"name":"engine","full_name":"carlosms/engine","owner":{"login":"carlosms","id":1469173,"avatar_url":"https://avatars0.githubusercontent.com/u/1469173?v=4","gravatar_id":"","url":"https://api.github.com/users/carlosms","html_url":"https://github.com/carlosms","followers_url":"https://api.github.com/users/carlosms/followers","following_url":"https://api.github.com/users/carlosms/following{/other_user}","gists_url":"https://api.github.com/users/carlosms/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosms/subscriptions","organizations_url":"https://api.github.com/users/carlosms/orgs","repos_url":"https://api.github.com/users/carlosms/repos","events_url":"https://api.github.com/users/carlosms/events{/privacy}","received_events_url":"https://api.github.com/users/carlosms/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/carlosms/engine","description":"engine is a library for running scalable data retrieval pipelines that process any number of Git repositories for source code analysis.","fork":true,"url":"https://api.github.com/repos/carlosms/engine","forks_url":"https://api.github.com/repos/carlosms/engine/forks","keys_url":"https://api.github.com/repos/carlosms/engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carlosms/engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carlosms/engine/teams","hooks_url":"https://api.github.com/repos/carlosms/engine/hooks","issue_events_url":"https://api.github.com/repos/carlosms/engine/issues/events{/number}","events_url":"https://api.github.com/repos/carlosms/engine/events","assignees_url":"https://api.github.com/repos/carlosms/engine/assignees{/user}","branches_url":"https://api.github.com/repos/carlosms/engine/branches{/branch}","tags_url":"https://api.github.com/repos/carlosms/engine/tags","blobs_url":"https://api.github.com/repos/carlosms/engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carlosms/engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carlosms/engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/carlosms/engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carlosms/engine/statuses/{sha}","languages_url":"https://api.github.com/repos/carlosms/engine/languages","stargazers_url":"https://api.github.com/repos/carlosms/engine/stargazers","contributors_url":"https://api.github.com/repos/carlosms/engine/contributors","subscribers_url":"https://api.github.com/repos/carlosms/engine/subscribers","subscription_url":"https://api.github.com/repos/carlosms/engine/subscription","commits_url":"https://api.github.com/repos/carlosms/engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/carlosms/engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/carlosms/engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/carlosms/engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/carlosms/engine/contents/{+path}","compare_url":"https://api.github.com/repos/carlosms/engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carlosms/engine/merges","archive_url":"https://api.github.com/repos/carlosms/engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carlosms/engine/downloads","issues_url":"https://api.github.com/repos/carlosms/engine/issues{/number}","pulls_url":"https://api.github.com/repos/carlosms/engine/pulls{/number}","milestones_url":"https://api.github.com/repos/carlosms/engine/milestones{/number}","notifications_url":"https://api.github.com/repos/carlosms/engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carlosms/engine/labels{/name}","releases_url":"https://api.github.com/repos/carlosms/engine/releases{/id}","deployments_url":"https://api.github.com/repos/carlosms/engine/deployments","created_at":"2018-03-15T15:41:18Z","updated_at":"2018-03-15T15:41:20Z","pushed_at":"2018-04-06T15:02:03Z","git_url":"git://github.com/carlosms/engine.git","ssh_url":"git@github.com:carlosms/engine.git","clone_url":"https://github.com/carlosms/engine.git","svn_url":"https://github.com/carlosms/engine","homepage":"https://engine.sourced.tech/","size":7301,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"src-d:master","ref":"master","sha":"c9815bce0c1f66943ae9b65eccc019a1ef21577e","user":{"login":"src-d","id":15128793,"avatar_url":"https://avatars2.githubusercontent.com/u/15128793?v=4","gravatar_id":"","url":"https://api.github.com/users/src-d","html_url":"https://github.com/src-d","followers_url":"https://api.github.com/users/src-d/followers","following_url":"https://api.github.com/users/src-d/following{/other_user}","gists_url":"https://api.github.com/users/src-d/gists{/gist_id}","starred_url":"https://api.github.com/users/src-d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/src-d/subscriptions","organizations_url":"https://api.github.com/users/src-d/orgs","repos_url":"https://api.github.com/users/src-d/repos","events_url":"https://api.github.com/users/src-d/events{/privacy}","received_events_url":"https://api.github.com/users/src-d/received_events","type":"Organization","site_admin":false},"repo":{"id":99223053,"name":"engine","full_name":"src-d/engine","owner":{"login":"src-d","id":15128793,"avatar_url":"https://avatars2.githubusercontent.com/u/15128793?v=4","gravatar_id":"","url":"https://api.github.com/users/src-d","html_url":"https://github.com/src-d","followers_url":"https://api.github.com/users/src-d/followers","following_url":"https://api.github.com/users/src-d/following{/other_user}","gists_url":"https://api.github.com/users/src-d/gists{/gist_id}","starred_url":"https://api.github.com/users/src-d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/src-d/subscriptions","organizations_url":"https://api.github.com/users/src-d/orgs","repos_url":"https://api.github.com/users/src-d/repos","events_url":"https://api.github.com/users/src-d/events{/privacy}","received_events_url":"https://api.github.com/users/src-d/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/src-d/engine","description":"engine is a library for running scalable data retrieval pipelines that process any number of Git repositories for source code analysis.","fork":false,"url":"https://api.github.com/repos/src-d/engine","forks_url":"https://api.github.com/repos/src-d/engine/forks","keys_url":"https://api.github.com/repos/src-d/engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/src-d/engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/src-d/engine/teams","hooks_url":"https://api.github.com/repos/src-d/engine/hooks","issue_events_url":"https://api.github.com/repos/src-d/engine/issues/events{/number}","events_url":"https://api.github.com/repos/src-d/engine/events","assignees_url":"https://api.github.com/repos/src-d/engine/assignees{/user}","branches_url":"https://api.github.com/repos/src-d/engine/branches{/branch}","tags_url":"https://api.github.com/repos/src-d/engine/tags","blobs_url":"https://api.github.com/repos/src-d/engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/src-d/engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/src-d/engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/src-d/engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/src-d/engine/statuses/{sha}","languages_url":"https://api.github.com/repos/src-d/engine/languages","stargazers_url":"https://api.github.com/repos/src-d/engine/stargazers","contributors_url":"https://api.github.com/repos/src-d/engine/contributors","subscribers_url":"https://api.github.com/repos/src-d/engine/subscribers","subscription_url":"https://api.github.com/repos/src-d/engine/subscription","commits_url":"https://api.github.com/repos/src-d/engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/src-d/engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/src-d/engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/src-d/engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/src-d/engine/contents/{+path}","compare_url":"https://api.github.com/repos/src-d/engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/src-d/engine/merges","archive_url":"https://api.github.com/repos/src-d/engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/src-d/engine/downloads","issues_url":"https://api.github.com/repos/src-d/engine/issues{/number}","pulls_url":"https://api.github.com/repos/src-d/engine/pulls{/number}","milestones_url":"https://api.github.com/repos/src-d/engine/milestones{/number}","notifications_url":"https://api.github.com/repos/src-d/engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/src-d/engine/labels{/name}","releases_url":"https://api.github.com/repos/src-d/engine/releases{/id}","deployments_url":"https://api.github.com/repos/src-d/engine/deployments","created_at":"2017-08-03T10:55:44Z","updated_at":"2018-04-06T02:50:23Z","pushed_at":"2018-04-06T14:48:26Z","git_url":"git://github.com/src-d/engine.git","ssh_url":"git@github.com:src-d/engine.git","clone_url":"https://github.com/src-d/engine.git","svn_url":"https://github.com/src-d/engine","homepage":"https://engine.sourced.tech/","size":7310,"stargazers_count":46,"watchers_count":46,"language":"Scala","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":27,"open_issues":19,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/src-d/engine/pulls/358"},"html":{"href":"https://github.com/src-d/engine/pull/358"},"issue":{"href":"https://api.github.com/repos/src-d/engine/issues/358"},"comments":{"href":"https://api.github.com/repos/src-d/engine/issues/358/comments"},"review_comments":{"href":"https://api.github.com/repos/src-d/engine/pulls/358/comments"},"review_comment":{"href":"https://api.github.com/repos/src-d/engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/src-d/engine/pulls/358/commits"},"statuses":{"href":"https://api.github.com/repos/src-d/engine/statuses/50f1f94b5c3e4c4345942dceb3888a6e4a3ca9b9"}},"author_association":"NONE"}}
{"actor":{"display_login":"bzz"}}