{"action":"created","issue":{"url":"https://api.github.com/repos/ethereum/go-ethereum/issues/17662","repository_url":"https://api.github.com/repos/ethereum/go-ethereum","labels_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/17662/labels{/name}","comments_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/17662/comments","events_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/17662/events","html_url":"https://github.com/ethereum/go-ethereum/pull/17662","id":359657026,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MDk5NTc4","number":17662,"title":"types, rawdb, core, miner: add block location fields to receipt","user":{"login":"bmperrea","id":5274371,"node_id":"MDQ6VXNlcjUyNzQzNzE=","avatar_url":"https://avatars2.githubusercontent.com/u/5274371?v=4","gravatar_id":"","url":"https://api.github.com/users/bmperrea","html_url":"https://github.com/bmperrea","followers_url":"https://api.github.com/users/bmperrea/followers","following_url":"https://api.github.com/users/bmperrea/following{/other_user}","gists_url":"https://api.github.com/users/bmperrea/gists{/gist_id}","starred_url":"https://api.github.com/users/bmperrea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmperrea/subscriptions","organizations_url":"https://api.github.com/users/bmperrea/orgs","repos_url":"https://api.github.com/users/bmperrea/repos","events_url":"https://api.github.com/users/bmperrea/events{/privacy}","received_events_url":"https://api.github.com/users/bmperrea/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-09-12T21:19:55Z","updated_at":"2018-11-17T05:17:10Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/17662","html_url":"https://github.com/ethereum/go-ethereum/pull/17662","diff_url":"https://github.com/ethereum/go-ethereum/pull/17662.diff","patch_url":"https://github.com/ethereum/go-ethereum/pull/17662.patch"},"body":"Solves https://github.com/ethereum/go-ethereum/issues/15210 without changing consensus, in a backwards compatible way, by adding the block location fields from ReadReceipt to the Receipt struct. \r\n\r\nUpdate: In particular this improves consistency between the go client interface and the [json rpc spec](https://github.com/ethereum/wiki/wiki/JSON-RPC#eth_gettransactionreceipt) and allows go clients to use transaction receipts to watch for block confirmations for particular transactions - see #15210."},"comment":{"url":"https://api.github.com/repos/ethereum/go-ethereum/issues/comments/439589318","html_url":"https://github.com/ethereum/go-ethereum/pull/17662#issuecomment-439589318","issue_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/17662","id":439589318,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTU4OTMxOA==","user":{"login":"bmperrea","id":5274371,"node_id":"MDQ6VXNlcjUyNzQzNzE=","avatar_url":"https://avatars2.githubusercontent.com/u/5274371?v=4","gravatar_id":"","url":"https://api.github.com/users/bmperrea","html_url":"https://github.com/bmperrea","followers_url":"https://api.github.com/users/bmperrea/followers","following_url":"https://api.github.com/users/bmperrea/following{/other_user}","gists_url":"https://api.github.com/users/bmperrea/gists{/gist_id}","starred_url":"https://api.github.com/users/bmperrea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmperrea/subscriptions","organizations_url":"https://api.github.com/users/bmperrea/orgs","repos_url":"https://api.github.com/users/bmperrea/repos","events_url":"https://api.github.com/users/bmperrea/events{/privacy}","received_events_url":"https://api.github.com/users/bmperrea/received_events","type":"User","site_admin":false},"created_at":"2018-11-17T05:17:10Z","updated_at":"2018-11-17T05:17:10Z","author_association":"NONE","body":"Great point about mined and downloaded receipts @karalabe . I'm excited to improve the geth go-client interface to make sure we keep consistent with the rpc spec which includes these location fields. I've updated the PR to add code to take care of these cases in `miner/worker.go` and `core/blockchain.go` respectively. These are the same place where location-based fields are added to the log objects within the receipt. \r\n\r\nThis pr makes the receipt object in the go-client interface more consistent with the rpc spec while also keeping consistent with how location fields are set for log entries."}}
{"actor":{"display_login":"bmperrea"}}