{"action":"created","comment":{"url":"https://api.github.com/repos/WQCG/blitzdg/pulls/comments/189419288","pull_request_review_id":121602334,"id":189419288,"diff_hunk":"@@ -14,5 +14,28 @@ namespace blitzdg {\n         index_type* row; /**< Pointer to array of row indices. */\n         index_type* col; /**< Pointer to array of column indices. */\n         real_type* val;  /**< Pointer to array of elements. */\n+\n+        /**\n+         * Constructor.\n+         * Creates a sparse triplet matrix with space for nz_ elements.\n+         * @param nz_ Number of nonzero elements.\n+         * @note If nz_ <= 0, then the empty matrix is created. The number of \n+         * nonzeros is set to zero and the pointers are set to null.\n+         */\n+        explicit SparseTriplet(index_type nz_ = 0)","path":"include/SparseTriplet.hpp","position":12,"original_position":12,"commit_id":"9f385ebd044e897ecaac3777f7a27f992a09692a","original_commit_id":"9f385ebd044e897ecaac3777f7a27f992a09692a","user":{"login":"dsteinmo","id":2772624,"avatar_url":"https://avatars2.githubusercontent.com/u/2772624?v=4","gravatar_id":"","url":"https://api.github.com/users/dsteinmo","html_url":"https://github.com/dsteinmo","followers_url":"https://api.github.com/users/dsteinmo/followers","following_url":"https://api.github.com/users/dsteinmo/following{/other_user}","gists_url":"https://api.github.com/users/dsteinmo/gists{/gist_id}","starred_url":"https://api.github.com/users/dsteinmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsteinmo/subscriptions","organizations_url":"https://api.github.com/users/dsteinmo/orgs","repos_url":"https://api.github.com/users/dsteinmo/repos","events_url":"https://api.github.com/users/dsteinmo/events{/privacy}","received_events_url":"https://api.github.com/users/dsteinmo/received_events","type":"User","site_admin":false},"body":"I think I like having this guy manage his own memory like this. It jives better with the rest of the classes.","created_at":"2018-05-19T00:47:25Z","updated_at":"2018-05-19T00:52:28Z","html_url":"https://github.com/WQCG/blitzdg/pull/21#discussion_r189419288","pull_request_url":"https://api.github.com/repos/WQCG/blitzdg/pulls/21","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/WQCG/blitzdg/pulls/comments/189419288"},"html":{"href":"https://github.com/WQCG/blitzdg/pull/21#discussion_r189419288"},"pull_request":{"href":"https://api.github.com/repos/WQCG/blitzdg/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/WQCG/blitzdg/pulls/21","id":189161448,"html_url":"https://github.com/WQCG/blitzdg/pull/21","diff_url":"https://github.com/WQCG/blitzdg/pull/21.diff","patch_url":"https://github.com/WQCG/blitzdg/pull/21.patch","issue_url":"https://api.github.com/repos/WQCG/blitzdg/issues/21","number":21,"state":"open","locked":false,"title":"Refactored code and general house keeping","user":{"login":"k7miller","id":6431740,"avatar_url":"https://avatars1.githubusercontent.com/u/6431740?v=4","gravatar_id":"","url":"https://api.github.com/users/k7miller","html_url":"https://github.com/k7miller","followers_url":"https://api.github.com/users/k7miller/followers","following_url":"https://api.github.com/users/k7miller/following{/other_user}","gists_url":"https://api.github.com/users/k7miller/gists{/gist_id}","starred_url":"https://api.github.com/users/k7miller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k7miller/subscriptions","organizations_url":"https://api.github.com/users/k7miller/orgs","repos_url":"https://api.github.com/users/k7miller/repos","events_url":"https://api.github.com/users/k7miller/events{/privacy}","received_events_url":"https://api.github.com/users/k7miller/received_events","type":"User","site_admin":false},"body":"I tried to clean up some loose ends and make the code a bit more C++ish. In general, I refactored the codes as follows:\r\n- Removed empty default constructors and destructors.\r\n- Added const to member functions that do not modify class internals.\r\n- Modified constructors to initialize member variables via initialization list.\r\n- Added default and nontrivial constructor to class SparseTriplet as well as a destructor.\r\n- Member functions that do not access or modify class internals were moved out of class.\r\n- Removed DirectSolver, EigenSolver, and SparseMatrixConverter arguments from constructors since these classes do not carry any state.","created_at":"2018-05-19T00:35:09Z","updated_at":"2018-05-19T00:52:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b12807da8bec1c7d05996971b56ae2d93d907a38","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/WQCG/blitzdg/pulls/21/commits","review_comments_url":"https://api.github.com/repos/WQCG/blitzdg/pulls/21/comments","review_comment_url":"https://api.github.com/repos/WQCG/blitzdg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WQCG/blitzdg/issues/21/comments","statuses_url":"https://api.github.com/repos/WQCG/blitzdg/statuses/9f385ebd044e897ecaac3777f7a27f992a09692a","head":{"label":"WQCG:house_cleaning","ref":"house_cleaning","sha":"9f385ebd044e897ecaac3777f7a27f992a09692a","user":{"login":"WQCG","id":36019997,"avatar_url":"https://avatars0.githubusercontent.com/u/36019997?v=4","gravatar_id":"","url":"https://api.github.com/users/WQCG","html_url":"https://github.com/WQCG","followers_url":"https://api.github.com/users/WQCG/followers","following_url":"https://api.github.com/users/WQCG/following{/other_user}","gists_url":"https://api.github.com/users/WQCG/gists{/gist_id}","starred_url":"https://api.github.com/users/WQCG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WQCG/subscriptions","organizations_url":"https://api.github.com/users/WQCG/orgs","repos_url":"https://api.github.com/users/WQCG/repos","events_url":"https://api.github.com/users/WQCG/events{/privacy}","received_events_url":"https://api.github.com/users/WQCG/received_events","type":"Organization","site_admin":false},"repo":{"id":130059847,"name":"blitzdg","full_name":"WQCG/blitzdg","owner":{"login":"WQCG","id":36019997,"avatar_url":"https://avatars0.githubusercontent.com/u/36019997?v=4","gravatar_id":"","url":"https://api.github.com/users/WQCG","html_url":"https://github.com/WQCG","followers_url":"https://api.github.com/users/WQCG/followers","following_url":"https://api.github.com/users/WQCG/following{/other_user}","gists_url":"https://api.github.com/users/WQCG/gists{/gist_id}","starred_url":"https://api.github.com/users/WQCG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WQCG/subscriptions","organizations_url":"https://api.github.com/users/WQCG/orgs","repos_url":"https://api.github.com/users/WQCG/repos","events_url":"https://api.github.com/users/WQCG/events{/privacy}","received_events_url":"https://api.github.com/users/WQCG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WQCG/blitzdg","description":"blitzdg is an open-source project aiming to implement parallel discontinuous Galerkin (dg) solvers for common partial differential equations systems using blitz++ for array and tensor manipulations and MPI for distributed parallelism.","fork":false,"url":"https://api.github.com/repos/WQCG/blitzdg","forks_url":"https://api.github.com/repos/WQCG/blitzdg/forks","keys_url":"https://api.github.com/repos/WQCG/blitzdg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WQCG/blitzdg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WQCG/blitzdg/teams","hooks_url":"https://api.github.com/repos/WQCG/blitzdg/hooks","issue_events_url":"https://api.github.com/repos/WQCG/blitzdg/issues/events{/number}","events_url":"https://api.github.com/repos/WQCG/blitzdg/events","assignees_url":"https://api.github.com/repos/WQCG/blitzdg/assignees{/user}","branches_url":"https://api.github.com/repos/WQCG/blitzdg/branches{/branch}","tags_url":"https://api.github.com/repos/WQCG/blitzdg/tags","blobs_url":"https://api.github.com/repos/WQCG/blitzdg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WQCG/blitzdg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WQCG/blitzdg/git/refs{/sha}","trees_url":"https://api.github.com/repos/WQCG/blitzdg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WQCG/blitzdg/statuses/{sha}","languages_url":"https://api.github.com/repos/WQCG/blitzdg/languages","stargazers_url":"https://api.github.com/repos/WQCG/blitzdg/stargazers","contributors_url":"https://api.github.com/repos/WQCG/blitzdg/contributors","subscribers_url":"https://api.github.com/repos/WQCG/blitzdg/subscribers","subscription_url":"https://api.github.com/repos/WQCG/blitzdg/subscription","commits_url":"https://api.github.com/repos/WQCG/blitzdg/commits{/sha}","git_commits_url":"https://api.github.com/repos/WQCG/blitzdg/git/commits{/sha}","comments_url":"https://api.github.com/repos/WQCG/blitzdg/comments{/number}","issue_comment_url":"https://api.github.com/repos/WQCG/blitzdg/issues/comments{/number}","contents_url":"https://api.github.com/repos/WQCG/blitzdg/contents/{+path}","compare_url":"https://api.github.com/repos/WQCG/blitzdg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WQCG/blitzdg/merges","archive_url":"https://api.github.com/repos/WQCG/blitzdg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WQCG/blitzdg/downloads","issues_url":"https://api.github.com/repos/WQCG/blitzdg/issues{/number}","pulls_url":"https://api.github.com/repos/WQCG/blitzdg/pulls{/number}","milestones_url":"https://api.github.com/repos/WQCG/blitzdg/milestones{/number}","notifications_url":"https://api.github.com/repos/WQCG/blitzdg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WQCG/blitzdg/labels{/name}","releases_url":"https://api.github.com/repos/WQCG/blitzdg/releases{/id}","deployments_url":"https://api.github.com/repos/WQCG/blitzdg/deployments","created_at":"2018-04-18T12:36:35Z","updated_at":"2018-05-18T13:22:47Z","pushed_at":"2018-05-19T00:35:09Z","git_url":"git://github.com/WQCG/blitzdg.git","ssh_url":"git@github.com:WQCG/blitzdg.git","clone_url":"https://github.com/WQCG/blitzdg.git","svn_url":"https://github.com/WQCG/blitzdg","homepage":"https://wqcg.github.io/blitzdg/","size":3505,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"WQCG:master","ref":"master","sha":"2feb7d7a43201558f8ac503718463488187dd01a","user":{"login":"WQCG","id":36019997,"avatar_url":"https://avatars0.githubusercontent.com/u/36019997?v=4","gravatar_id":"","url":"https://api.github.com/users/WQCG","html_url":"https://github.com/WQCG","followers_url":"https://api.github.com/users/WQCG/followers","following_url":"https://api.github.com/users/WQCG/following{/other_user}","gists_url":"https://api.github.com/users/WQCG/gists{/gist_id}","starred_url":"https://api.github.com/users/WQCG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WQCG/subscriptions","organizations_url":"https://api.github.com/users/WQCG/orgs","repos_url":"https://api.github.com/users/WQCG/repos","events_url":"https://api.github.com/users/WQCG/events{/privacy}","received_events_url":"https://api.github.com/users/WQCG/received_events","type":"Organization","site_admin":false},"repo":{"id":130059847,"name":"blitzdg","full_name":"WQCG/blitzdg","owner":{"login":"WQCG","id":36019997,"avatar_url":"https://avatars0.githubusercontent.com/u/36019997?v=4","gravatar_id":"","url":"https://api.github.com/users/WQCG","html_url":"https://github.com/WQCG","followers_url":"https://api.github.com/users/WQCG/followers","following_url":"https://api.github.com/users/WQCG/following{/other_user}","gists_url":"https://api.github.com/users/WQCG/gists{/gist_id}","starred_url":"https://api.github.com/users/WQCG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WQCG/subscriptions","organizations_url":"https://api.github.com/users/WQCG/orgs","repos_url":"https://api.github.com/users/WQCG/repos","events_url":"https://api.github.com/users/WQCG/events{/privacy}","received_events_url":"https://api.github.com/users/WQCG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WQCG/blitzdg","description":"blitzdg is an open-source project aiming to implement parallel discontinuous Galerkin (dg) solvers for common partial differential equations systems using blitz++ for array and tensor manipulations and MPI for distributed parallelism.","fork":false,"url":"https://api.github.com/repos/WQCG/blitzdg","forks_url":"https://api.github.com/repos/WQCG/blitzdg/forks","keys_url":"https://api.github.com/repos/WQCG/blitzdg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WQCG/blitzdg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WQCG/blitzdg/teams","hooks_url":"https://api.github.com/repos/WQCG/blitzdg/hooks","issue_events_url":"https://api.github.com/repos/WQCG/blitzdg/issues/events{/number}","events_url":"https://api.github.com/repos/WQCG/blitzdg/events","assignees_url":"https://api.github.com/repos/WQCG/blitzdg/assignees{/user}","branches_url":"https://api.github.com/repos/WQCG/blitzdg/branches{/branch}","tags_url":"https://api.github.com/repos/WQCG/blitzdg/tags","blobs_url":"https://api.github.com/repos/WQCG/blitzdg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WQCG/blitzdg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WQCG/blitzdg/git/refs{/sha}","trees_url":"https://api.github.com/repos/WQCG/blitzdg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WQCG/blitzdg/statuses/{sha}","languages_url":"https://api.github.com/repos/WQCG/blitzdg/languages","stargazers_url":"https://api.github.com/repos/WQCG/blitzdg/stargazers","contributors_url":"https://api.github.com/repos/WQCG/blitzdg/contributors","subscribers_url":"https://api.github.com/repos/WQCG/blitzdg/subscribers","subscription_url":"https://api.github.com/repos/WQCG/blitzdg/subscription","commits_url":"https://api.github.com/repos/WQCG/blitzdg/commits{/sha}","git_commits_url":"https://api.github.com/repos/WQCG/blitzdg/git/commits{/sha}","comments_url":"https://api.github.com/repos/WQCG/blitzdg/comments{/number}","issue_comment_url":"https://api.github.com/repos/WQCG/blitzdg/issues/comments{/number}","contents_url":"https://api.github.com/repos/WQCG/blitzdg/contents/{+path}","compare_url":"https://api.github.com/repos/WQCG/blitzdg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WQCG/blitzdg/merges","archive_url":"https://api.github.com/repos/WQCG/blitzdg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WQCG/blitzdg/downloads","issues_url":"https://api.github.com/repos/WQCG/blitzdg/issues{/number}","pulls_url":"https://api.github.com/repos/WQCG/blitzdg/pulls{/number}","milestones_url":"https://api.github.com/repos/WQCG/blitzdg/milestones{/number}","notifications_url":"https://api.github.com/repos/WQCG/blitzdg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WQCG/blitzdg/labels{/name}","releases_url":"https://api.github.com/repos/WQCG/blitzdg/releases{/id}","deployments_url":"https://api.github.com/repos/WQCG/blitzdg/deployments","created_at":"2018-04-18T12:36:35Z","updated_at":"2018-05-18T13:22:47Z","pushed_at":"2018-05-19T00:35:09Z","git_url":"git://github.com/WQCG/blitzdg.git","ssh_url":"git@github.com:WQCG/blitzdg.git","clone_url":"https://github.com/WQCG/blitzdg.git","svn_url":"https://github.com/WQCG/blitzdg","homepage":"https://wqcg.github.io/blitzdg/","size":3505,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WQCG/blitzdg/pulls/21"},"html":{"href":"https://github.com/WQCG/blitzdg/pull/21"},"issue":{"href":"https://api.github.com/repos/WQCG/blitzdg/issues/21"},"comments":{"href":"https://api.github.com/repos/WQCG/blitzdg/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/WQCG/blitzdg/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/WQCG/blitzdg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WQCG/blitzdg/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/WQCG/blitzdg/statuses/9f385ebd044e897ecaac3777f7a27f992a09692a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dsteinmo"}}