{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/5846","repository_url":"https://api.github.com/repos/GoogleChrome/lighthouse","labels_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/5846/labels{/name}","comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/5846/comments","events_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/5846/events","html_url":"https://github.com/GoogleChrome/lighthouse/pull/5846","id":351262851,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4OTAzNTcz","number":5846,"title":"[WIP] new-audit(tap-targets): check if all tap targets big enough and don't overlap","user":{"login":"kdzwinel","id":985504,"node_id":"MDQ6VXNlcjk4NTUwNA==","avatar_url":"https://avatars2.githubusercontent.com/u/985504?v=4","gravatar_id":"","url":"https://api.github.com/users/kdzwinel","html_url":"https://github.com/kdzwinel","followers_url":"https://api.github.com/users/kdzwinel/followers","following_url":"https://api.github.com/users/kdzwinel/following{/other_user}","gists_url":"https://api.github.com/users/kdzwinel/gists{/gist_id}","starred_url":"https://api.github.com/users/kdzwinel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kdzwinel/subscriptions","organizations_url":"https://api.github.com/users/kdzwinel/orgs","repos_url":"https://api.github.com/users/kdzwinel/repos","events_url":"https://api.github.com/users/kdzwinel/events{/privacy}","received_events_url":"https://api.github.com/users/kdzwinel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-08-16T15:44:45Z","updated_at":"2018-12-07T15:56:51Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/5846","html_url":"https://github.com/GoogleChrome/lighthouse/pull/5846","diff_url":"https://github.com/GoogleChrome/lighthouse/pull/5846.diff","patch_url":"https://github.com/GoogleChrome/lighthouse/pull/5846.patch"},"body":"**Summary**\r\nThis audit checks if all potential tap targets (see 1) are sized appropriately (see 2) and are far enough from each other to be unambiguous (see 3).\r\n\r\n**Limitations**\r\n1) we take potential tap targets into account (`a, button, input, …`) - this list may not include some tap targets that are made \"tappable\" via JS (e.g. some div used as a button) and may include some tap targets that don't cause any action (e.g. dummy button that does nothing)\r\n2) We define finger size to be 48x48px\r\n3) Implemented algorithm is simpler from what Chrome does (e.g. Chrome is often able to figure out which link was clicked even if tap area covers two links). The algorithm boils down to checking if there is some other tap target located < 32px from the center of the currently audited one.\r\n\r\n**Demo** (note that visual output is *not* part of this audit):\r\n\r\n<img src='https://user-images.githubusercontent.com/985504/44219129-92c16f80-a17b-11e8-89af-1d5acce0b2e2.gif' height=450 />\r\n\r\n**TODO**\r\n- [ ] descriptions\r\n- [x] linting\r\n- [ ] tests\r\n\r\n**Related Issues/PRs**\r\nCloses #4358 \r\n"},"comment":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/comments/445276342","html_url":"https://github.com/GoogleChrome/lighthouse/pull/5846#issuecomment-445276342","issue_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/5846","id":445276342,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTI3NjM0Mg==","user":{"login":"mattzeunert","id":1303660,"node_id":"MDQ6VXNlcjEzMDM2NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/1303660?v=4","gravatar_id":"","url":"https://api.github.com/users/mattzeunert","html_url":"https://github.com/mattzeunert","followers_url":"https://api.github.com/users/mattzeunert/followers","following_url":"https://api.github.com/users/mattzeunert/following{/other_user}","gists_url":"https://api.github.com/users/mattzeunert/gists{/gist_id}","starred_url":"https://api.github.com/users/mattzeunert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattzeunert/subscriptions","organizations_url":"https://api.github.com/users/mattzeunert/orgs","repos_url":"https://api.github.com/users/mattzeunert/repos","events_url":"https://api.github.com/users/mattzeunert/events{/privacy}","received_events_url":"https://api.github.com/users/mattzeunert/received_events","type":"User","site_admin":false},"created_at":"2018-12-07T15:56:51Z","updated_at":"2018-12-07T15:56:51Z","author_association":"COLLABORATOR","body":"> Is the problem that you can't tell which rects are on top of other rects and so there's false overlap from rects underneath?\r\n\r\nYeah.\r\n\r\nThe `visibility: hidden` logic was accidentally solving the problem on some sites, e.g. on Wikipedia the menu is both `z-index: 0` below the main content and `visibility: hidden`."}}
{"actor":{"display_login":"mattzeunert"}}