{"action":"created","comment":{"url":"https://api.github.com/repos/ubccr/xdmod/pulls/comments/220983528","pull_request_review_id":159522999,"id":220983528,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDk4MzUyOA==","diff_hunk":"@@ -35,6 +35,8 @@\n \n try {\n     $rid = $user_to_email->generateRID();\n+    $expireDate = strftime(\"%c %Z\", explode('|', $rid)[1]);\n+    $expiration = $expireDate ? $expireDate : \"Unknown\";","path":"html/controllers/user_auth/pass_reset.php","position":5,"original_position":5,"commit_id":"6fb0d6e2c4cb9e3cb060d57a11c3d3ff92c1a079","original_commit_id":"6fb0d6e2c4cb9e3cb060d57a11c3d3ff92c1a079","user":{"login":"chakrabortyr","id":2617780,"node_id":"MDQ6VXNlcjI2MTc3ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/2617780?v=4","gravatar_id":"","url":"https://api.github.com/users/chakrabortyr","html_url":"https://github.com/chakrabortyr","followers_url":"https://api.github.com/users/chakrabortyr/followers","following_url":"https://api.github.com/users/chakrabortyr/following{/other_user}","gists_url":"https://api.github.com/users/chakrabortyr/gists{/gist_id}","starred_url":"https://api.github.com/users/chakrabortyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chakrabortyr/subscriptions","organizations_url":"https://api.github.com/users/chakrabortyr/orgs","repos_url":"https://api.github.com/users/chakrabortyr/repos","events_url":"https://api.github.com/users/chakrabortyr/events{/privacy}","received_events_url":"https://api.github.com/users/chakrabortyr/received_events","type":"User","site_admin":false},"body":"Sorry, to clarify: it will never not be set, it would be false.`$expireDate` could be false if you set the `email_token_expiration` attribute in the portal settings to empty or some other nonsense value.","created_at":"2018-09-27T16:03:54Z","updated_at":"2018-09-27T16:03:54Z","html_url":"https://github.com/ubccr/xdmod/pull/688#discussion_r220983528","pull_request_url":"https://api.github.com/repos/ubccr/xdmod/pulls/688","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ubccr/xdmod/pulls/comments/220983528"},"html":{"href":"https://github.com/ubccr/xdmod/pull/688#discussion_r220983528"},"pull_request":{"href":"https://api.github.com/repos/ubccr/xdmod/pulls/688"}},"in_reply_to_id":220980520},"pull_request":{"url":"https://api.github.com/repos/ubccr/xdmod/pulls/688","id":218433230,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NDMzMjMw","html_url":"https://github.com/ubccr/xdmod/pull/688","diff_url":"https://github.com/ubccr/xdmod/pull/688.diff","patch_url":"https://github.com/ubccr/xdmod/pull/688.patch","issue_url":"https://api.github.com/repos/ubccr/xdmod/issues/688","number":688,"state":"open","locked":false,"title":"Added Locale Specific Password Expiration Times in Forgot Password Email","user":{"login":"chakrabortyr","id":2617780,"node_id":"MDQ6VXNlcjI2MTc3ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/2617780?v=4","gravatar_id":"","url":"https://api.github.com/users/chakrabortyr","html_url":"https://github.com/chakrabortyr","followers_url":"https://api.github.com/users/chakrabortyr/followers","following_url":"https://api.github.com/users/chakrabortyr/following{/other_user}","gists_url":"https://api.github.com/users/chakrabortyr/gists{/gist_id}","starred_url":"https://api.github.com/users/chakrabortyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chakrabortyr/subscriptions","organizations_url":"https://api.github.com/users/chakrabortyr/orgs","repos_url":"https://api.github.com/users/chakrabortyr/repos","events_url":"https://api.github.com/users/chakrabortyr/events{/privacy}","received_events_url":"https://api.github.com/users/chakrabortyr/received_events","type":"User","site_admin":false},"body":"… template.\r\n\r\n<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\nAddresses one of my gripes in Asana about our forgot password emails not explicitly stating when the reset link expires.\r\n\r\n## Motivation and Context\r\nMinimizes support questions, user friendliness.\r\n\r\n## Tests performed\r\nSent a bunch of emails to myself in Docker\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [X] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [X] My code follows the code style of this project as found in the **CONTRIBUTING** document.\r\n- [ ] I have added tests to cover my changes.\r\n- [X] All new and existing tests passed.\r\n","created_at":"2018-09-26T19:46:19Z","updated_at":"2018-09-27T16:03:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"528c48a4d86f8d128d07fac6fd3e0dd2000d2c84","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":470896633,"node_id":"MDU6TGFiZWw0NzA4OTY2MzM=","url":"https://api.github.com/repos/ubccr/xdmod/labels/bug","name":"bug","color":"ee0701","default":true},{"id":505045307,"node_id":"MDU6TGFiZWw1MDUwNDUzMDc=","url":"https://api.github.com/repos/ubccr/xdmod/labels/release%20prep","name":"release prep","color":"5319e7","default":false}],"milestone":{"url":"https://api.github.com/repos/ubccr/xdmod/milestones/8","html_url":"https://github.com/ubccr/xdmod/milestone/8","labels_url":"https://api.github.com/repos/ubccr/xdmod/milestones/8/labels","id":3075821,"node_id":"MDk6TWlsZXN0b25lMzA3NTgyMQ==","number":8,"title":"8.0.0","description":"","creator":{"login":"smgallo","id":2301909,"node_id":"MDQ6VXNlcjIzMDE5MDk=","avatar_url":"https://avatars1.githubusercontent.com/u/2301909?v=4","gravatar_id":"","url":"https://api.github.com/users/smgallo","html_url":"https://github.com/smgallo","followers_url":"https://api.github.com/users/smgallo/followers","following_url":"https://api.github.com/users/smgallo/following{/other_user}","gists_url":"https://api.github.com/users/smgallo/gists{/gist_id}","starred_url":"https://api.github.com/users/smgallo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smgallo/subscriptions","organizations_url":"https://api.github.com/users/smgallo/orgs","repos_url":"https://api.github.com/users/smgallo/repos","events_url":"https://api.github.com/users/smgallo/events{/privacy}","received_events_url":"https://api.github.com/users/smgallo/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":158,"state":"open","created_at":"2018-01-30T18:52:17Z","updated_at":"2018-09-26T21:27:02Z","due_on":"2018-08-27T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/ubccr/xdmod/pulls/688/commits","review_comments_url":"https://api.github.com/repos/ubccr/xdmod/pulls/688/comments","review_comment_url":"https://api.github.com/repos/ubccr/xdmod/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ubccr/xdmod/issues/688/comments","statuses_url":"https://api.github.com/repos/ubccr/xdmod/statuses/6fb0d6e2c4cb9e3cb060d57a11c3d3ff92c1a079","head":{"label":"chakrabortyr:RC_ExplicitExpire","ref":"RC_ExplicitExpire","sha":"6fb0d6e2c4cb9e3cb060d57a11c3d3ff92c1a079","user":{"login":"chakrabortyr","id":2617780,"node_id":"MDQ6VXNlcjI2MTc3ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/2617780?v=4","gravatar_id":"","url":"https://api.github.com/users/chakrabortyr","html_url":"https://github.com/chakrabortyr","followers_url":"https://api.github.com/users/chakrabortyr/followers","following_url":"https://api.github.com/users/chakrabortyr/following{/other_user}","gists_url":"https://api.github.com/users/chakrabortyr/gists{/gist_id}","starred_url":"https://api.github.com/users/chakrabortyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chakrabortyr/subscriptions","organizations_url":"https://api.github.com/users/chakrabortyr/orgs","repos_url":"https://api.github.com/users/chakrabortyr/repos","events_url":"https://api.github.com/users/chakrabortyr/events{/privacy}","received_events_url":"https://api.github.com/users/chakrabortyr/received_events","type":"User","site_admin":false},"repo":{"id":89559818,"node_id":"MDEwOlJlcG9zaXRvcnk4OTU1OTgxOA==","name":"xdmod","full_name":"chakrabortyr/xdmod","private":false,"owner":{"login":"chakrabortyr","id":2617780,"node_id":"MDQ6VXNlcjI2MTc3ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/2617780?v=4","gravatar_id":"","url":"https://api.github.com/users/chakrabortyr","html_url":"https://github.com/chakrabortyr","followers_url":"https://api.github.com/users/chakrabortyr/followers","following_url":"https://api.github.com/users/chakrabortyr/following{/other_user}","gists_url":"https://api.github.com/users/chakrabortyr/gists{/gist_id}","starred_url":"https://api.github.com/users/chakrabortyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chakrabortyr/subscriptions","organizations_url":"https://api.github.com/users/chakrabortyr/orgs","repos_url":"https://api.github.com/users/chakrabortyr/repos","events_url":"https://api.github.com/users/chakrabortyr/events{/privacy}","received_events_url":"https://api.github.com/users/chakrabortyr/received_events","type":"User","site_admin":false},"html_url":"https://github.com/chakrabortyr/xdmod","description":"An open framework for collecting and analyzing HPC metrics.","fork":true,"url":"https://api.github.com/repos/chakrabortyr/xdmod","forks_url":"https://api.github.com/repos/chakrabortyr/xdmod/forks","keys_url":"https://api.github.com/repos/chakrabortyr/xdmod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chakrabortyr/xdmod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chakrabortyr/xdmod/teams","hooks_url":"https://api.github.com/repos/chakrabortyr/xdmod/hooks","issue_events_url":"https://api.github.com/repos/chakrabortyr/xdmod/issues/events{/number}","events_url":"https://api.github.com/repos/chakrabortyr/xdmod/events","assignees_url":"https://api.github.com/repos/chakrabortyr/xdmod/assignees{/user}","branches_url":"https://api.github.com/repos/chakrabortyr/xdmod/branches{/branch}","tags_url":"https://api.github.com/repos/chakrabortyr/xdmod/tags","blobs_url":"https://api.github.com/repos/chakrabortyr/xdmod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chakrabortyr/xdmod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chakrabortyr/xdmod/git/refs{/sha}","trees_url":"https://api.github.com/repos/chakrabortyr/xdmod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chakrabortyr/xdmod/statuses/{sha}","languages_url":"https://api.github.com/repos/chakrabortyr/xdmod/languages","stargazers_url":"https://api.github.com/repos/chakrabortyr/xdmod/stargazers","contributors_url":"https://api.github.com/repos/chakrabortyr/xdmod/contributors","subscribers_url":"https://api.github.com/repos/chakrabortyr/xdmod/subscribers","subscription_url":"https://api.github.com/repos/chakrabortyr/xdmod/subscription","commits_url":"https://api.github.com/repos/chakrabortyr/xdmod/commits{/sha}","git_commits_url":"https://api.github.com/repos/chakrabortyr/xdmod/git/commits{/sha}","comments_url":"https://api.github.com/repos/chakrabortyr/xdmod/comments{/number}","issue_comment_url":"https://api.github.com/repos/chakrabortyr/xdmod/issues/comments{/number}","contents_url":"https://api.github.com/repos/chakrabortyr/xdmod/contents/{+path}","compare_url":"https://api.github.com/repos/chakrabortyr/xdmod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chakrabortyr/xdmod/merges","archive_url":"https://api.github.com/repos/chakrabortyr/xdmod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chakrabortyr/xdmod/downloads","issues_url":"https://api.github.com/repos/chakrabortyr/xdmod/issues{/number}","pulls_url":"https://api.github.com/repos/chakrabortyr/xdmod/pulls{/number}","milestones_url":"https://api.github.com/repos/chakrabortyr/xdmod/milestones{/number}","notifications_url":"https://api.github.com/repos/chakrabortyr/xdmod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chakrabortyr/xdmod/labels{/name}","releases_url":"https://api.github.com/repos/chakrabortyr/xdmod/releases{/id}","deployments_url":"https://api.github.com/repos/chakrabortyr/xdmod/deployments","created_at":"2017-04-27T05:39:43Z","updated_at":"2017-04-27T05:39:47Z","pushed_at":"2018-09-27T14:40:35Z","git_url":"git://github.com/chakrabortyr/xdmod.git","ssh_url":"git@github.com:chakrabortyr/xdmod.git","clone_url":"https://github.com/chakrabortyr/xdmod.git","svn_url":"https://github.com/chakrabortyr/xdmod","homepage":"http://open.xdmod.org","size":12753,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"xdmod7.0"}},"base":{"label":"ubccr:xdmod8.0","ref":"xdmod8.0","sha":"3c6a1a87946b017c30b9cbc1a525325d215232ca","user":{"login":"ubccr","id":2301947,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDE5NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/2301947?v=4","gravatar_id":"","url":"https://api.github.com/users/ubccr","html_url":"https://github.com/ubccr","followers_url":"https://api.github.com/users/ubccr/followers","following_url":"https://api.github.com/users/ubccr/following{/other_user}","gists_url":"https://api.github.com/users/ubccr/gists{/gist_id}","starred_url":"https://api.github.com/users/ubccr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubccr/subscriptions","organizations_url":"https://api.github.com/users/ubccr/orgs","repos_url":"https://api.github.com/users/ubccr/repos","events_url":"https://api.github.com/users/ubccr/events{/privacy}","received_events_url":"https://api.github.com/users/ubccr/received_events","type":"Organization","site_admin":false},"repo":{"id":72233032,"node_id":"MDEwOlJlcG9zaXRvcnk3MjIzMzAzMg==","name":"xdmod","full_name":"ubccr/xdmod","private":false,"owner":{"login":"ubccr","id":2301947,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDE5NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/2301947?v=4","gravatar_id":"","url":"https://api.github.com/users/ubccr","html_url":"https://github.com/ubccr","followers_url":"https://api.github.com/users/ubccr/followers","following_url":"https://api.github.com/users/ubccr/following{/other_user}","gists_url":"https://api.github.com/users/ubccr/gists{/gist_id}","starred_url":"https://api.github.com/users/ubccr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubccr/subscriptions","organizations_url":"https://api.github.com/users/ubccr/orgs","repos_url":"https://api.github.com/users/ubccr/repos","events_url":"https://api.github.com/users/ubccr/events{/privacy}","received_events_url":"https://api.github.com/users/ubccr/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ubccr/xdmod","description":"An open framework for collecting and analyzing HPC metrics.","fork":false,"url":"https://api.github.com/repos/ubccr/xdmod","forks_url":"https://api.github.com/repos/ubccr/xdmod/forks","keys_url":"https://api.github.com/repos/ubccr/xdmod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ubccr/xdmod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ubccr/xdmod/teams","hooks_url":"https://api.github.com/repos/ubccr/xdmod/hooks","issue_events_url":"https://api.github.com/repos/ubccr/xdmod/issues/events{/number}","events_url":"https://api.github.com/repos/ubccr/xdmod/events","assignees_url":"https://api.github.com/repos/ubccr/xdmod/assignees{/user}","branches_url":"https://api.github.com/repos/ubccr/xdmod/branches{/branch}","tags_url":"https://api.github.com/repos/ubccr/xdmod/tags","blobs_url":"https://api.github.com/repos/ubccr/xdmod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ubccr/xdmod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ubccr/xdmod/git/refs{/sha}","trees_url":"https://api.github.com/repos/ubccr/xdmod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ubccr/xdmod/statuses/{sha}","languages_url":"https://api.github.com/repos/ubccr/xdmod/languages","stargazers_url":"https://api.github.com/repos/ubccr/xdmod/stargazers","contributors_url":"https://api.github.com/repos/ubccr/xdmod/contributors","subscribers_url":"https://api.github.com/repos/ubccr/xdmod/subscribers","subscription_url":"https://api.github.com/repos/ubccr/xdmod/subscription","commits_url":"https://api.github.com/repos/ubccr/xdmod/commits{/sha}","git_commits_url":"https://api.github.com/repos/ubccr/xdmod/git/commits{/sha}","comments_url":"https://api.github.com/repos/ubccr/xdmod/comments{/number}","issue_comment_url":"https://api.github.com/repos/ubccr/xdmod/issues/comments{/number}","contents_url":"https://api.github.com/repos/ubccr/xdmod/contents/{+path}","compare_url":"https://api.github.com/repos/ubccr/xdmod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ubccr/xdmod/merges","archive_url":"https://api.github.com/repos/ubccr/xdmod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ubccr/xdmod/downloads","issues_url":"https://api.github.com/repos/ubccr/xdmod/issues{/number}","pulls_url":"https://api.github.com/repos/ubccr/xdmod/pulls{/number}","milestones_url":"https://api.github.com/repos/ubccr/xdmod/milestones{/number}","notifications_url":"https://api.github.com/repos/ubccr/xdmod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ubccr/xdmod/labels{/name}","releases_url":"https://api.github.com/repos/ubccr/xdmod/releases{/id}","deployments_url":"https://api.github.com/repos/ubccr/xdmod/deployments","created_at":"2016-10-28T18:41:25Z","updated_at":"2018-09-24T15:52:52Z","pushed_at":"2018-09-27T14:58:28Z","git_url":"git://github.com/ubccr/xdmod.git","ssh_url":"git@github.com:ubccr/xdmod.git","clone_url":"https://github.com/ubccr/xdmod.git","svn_url":"https://github.com/ubccr/xdmod","homepage":"https://open.xdmod.org","size":12734,"stargazers_count":27,"watchers_count":27,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":27,"open_issues":8,"watchers":27,"default_branch":"xdmod8.0"}},"_links":{"self":{"href":"https://api.github.com/repos/ubccr/xdmod/pulls/688"},"html":{"href":"https://github.com/ubccr/xdmod/pull/688"},"issue":{"href":"https://api.github.com/repos/ubccr/xdmod/issues/688"},"comments":{"href":"https://api.github.com/repos/ubccr/xdmod/issues/688/comments"},"review_comments":{"href":"https://api.github.com/repos/ubccr/xdmod/pulls/688/comments"},"review_comment":{"href":"https://api.github.com/repos/ubccr/xdmod/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ubccr/xdmod/pulls/688/commits"},"statuses":{"href":"https://api.github.com/repos/ubccr/xdmod/statuses/6fb0d6e2c4cb9e3cb060d57a11c3d3ff92c1a079"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"chakrabortyr"}}