{"action":"created","issue":{"url":"https://api.github.com/repos/electrode-io/electrode-native/issues/606","repository_url":"https://api.github.com/repos/electrode-io/electrode-native","labels_url":"https://api.github.com/repos/electrode-io/electrode-native/issues/606/labels{/name}","comments_url":"https://api.github.com/repos/electrode-io/electrode-native/issues/606/comments","events_url":"https://api.github.com/repos/electrode-io/electrode-native/issues/606/events","html_url":"https://github.com/electrode-io/electrode-native/pull/606","id":298247163,"number":606,"title":"[container-gen] Custom Android permissions configuration for native components","user":{"login":"Igor1201","id":735858,"avatar_url":"https://avatars2.githubusercontent.com/u/735858?v=4","gravatar_id":"","url":"https://api.github.com/users/Igor1201","html_url":"https://github.com/Igor1201","followers_url":"https://api.github.com/users/Igor1201/followers","following_url":"https://api.github.com/users/Igor1201/following{/other_user}","gists_url":"https://api.github.com/users/Igor1201/gists{/gist_id}","starred_url":"https://api.github.com/users/Igor1201/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Igor1201/subscriptions","organizations_url":"https://api.github.com/users/Igor1201/orgs","repos_url":"https://api.github.com/users/Igor1201/repos","events_url":"https://api.github.com/users/Igor1201/events{/privacy}","received_events_url":"https://api.github.com/users/Igor1201/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-19T11:46:20Z","updated_at":"2018-02-20T19:11:36Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/electrode-io/electrode-native/pulls/606","html_url":"https://github.com/electrode-io/electrode-native/pull/606","diff_url":"https://github.com/electrode-io/electrode-native/pull/606.diff","patch_url":"https://github.com/electrode-io/electrode-native/pull/606.patch"},"body":"Some third-party native components should have custom Android permissions (eg. `android.permission.CAMERA`) on the container's AndroidManifest.xml, so it should be configurable.\r\n\r\nAlso, it's good practice to implement react-native's `PermissionAwareActivity` so on newer versions of Android, the user will be prompted to accept it on runtime."},"comment":{"url":"https://api.github.com/repos/electrode-io/electrode-native/issues/comments/367085589","html_url":"https://github.com/electrode-io/electrode-native/pull/606#issuecomment-367085589","issue_url":"https://api.github.com/repos/electrode-io/electrode-native/issues/606","id":367085589,"user":{"login":"krunalsshah","id":6138310,"avatar_url":"https://avatars2.githubusercontent.com/u/6138310?v=4","gravatar_id":"","url":"https://api.github.com/users/krunalsshah","html_url":"https://github.com/krunalsshah","followers_url":"https://api.github.com/users/krunalsshah/followers","following_url":"https://api.github.com/users/krunalsshah/following{/other_user}","gists_url":"https://api.github.com/users/krunalsshah/gists{/gist_id}","starred_url":"https://api.github.com/users/krunalsshah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krunalsshah/subscriptions","organizations_url":"https://api.github.com/users/krunalsshah/orgs","repos_url":"https://api.github.com/users/krunalsshah/repos","events_url":"https://api.github.com/users/krunalsshah/events{/privacy}","received_events_url":"https://api.github.com/users/krunalsshah/received_events","type":"User","site_admin":false},"created_at":"2018-02-20T19:11:36Z","updated_at":"2018-02-20T19:11:36Z","author_association":"CONTRIBUTOR","body":"@Igor1201 thanks for turning the PR, we were planning to implement the `PermissionAwareActivity` for this release , Glad you picked it up 👍 "}}
{"actor":{"display_login":"krunalsshah"}}