{"action":"created","comment":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments/213269647","pull_request_review_id":150069581,"id":213269647,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzI2OTY0Nw==","diff_hunk":"@@ -33,17 +36,35 @@ public class WalletFeePolicy : IWalletFeePolicy\n         /// </summary>\n         private readonly FeeRate minRelayTxFee;\n \n+        /// <summary>Header chain.</summary>\n+        private readonly ConcurrentChain chainState;\n+\n+        /// <summary>Repository containing blocks.</summary>\n+        private readonly IBlockRepository blockRepository;","path":"src/Stratis.Bitcoin.Features.Wallet/WalletFeePolicy.cs","position":18,"original_position":18,"commit_id":"52886783502e29b4bd173f8568653592e157c057","original_commit_id":"52886783502e29b4bd173f8568653592e157c057","user":{"login":"dangershony","id":7487930,"node_id":"MDQ6VXNlcjc0ODc5MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/7487930?v=4","gravatar_id":"","url":"https://api.github.com/users/dangershony","html_url":"https://github.com/dangershony","followers_url":"https://api.github.com/users/dangershony/followers","following_url":"https://api.github.com/users/dangershony/following{/other_user}","gists_url":"https://api.github.com/users/dangershony/gists{/gist_id}","starred_url":"https://api.github.com/users/dangershony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dangershony/subscriptions","organizations_url":"https://api.github.com/users/dangershony/orgs","repos_url":"https://api.github.com/users/dangershony/repos","events_url":"https://api.github.com/users/dangershony/events{/privacy}","received_events_url":"https://api.github.com/users/dangershony/received_events","type":"User","site_admin":false},"body":"Dont use `IBlockRepository` use IBlockStore instead.\r\nAlso I think wallet does not have a dependency on IBlockStore being present so you need to allow it to be null and I guess use `minRelayTxFee` if store is null.","created_at":"2018-08-28T11:04:02Z","updated_at":"2018-08-28T11:04:02Z","html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/2036#discussion_r213269647","pull_request_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/2036","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments/213269647"},"html":{"href":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/2036#discussion_r213269647"},"pull_request":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/2036"}}},"pull_request":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/2036","id":210976022,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwOTc2MDIy","html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/2036","diff_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/2036.diff","patch_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/2036.patch","issue_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/2036","number":2036,"state":"open","locked":false,"title":"Make fee estimate conditional on whether blocks are full","user":{"login":"mikedennis","id":24234359,"node_id":"MDQ6VXNlcjI0MjM0MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/24234359?v=4","gravatar_id":"","url":"https://api.github.com/users/mikedennis","html_url":"https://github.com/mikedennis","followers_url":"https://api.github.com/users/mikedennis/followers","following_url":"https://api.github.com/users/mikedennis/following{/other_user}","gists_url":"https://api.github.com/users/mikedennis/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedennis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedennis/subscriptions","organizations_url":"https://api.github.com/users/mikedennis/orgs","repos_url":"https://api.github.com/users/mikedennis/repos","events_url":"https://api.github.com/users/mikedennis/events{/privacy}","received_events_url":"https://api.github.com/users/mikedennis/received_events","type":"User","site_admin":false},"body":"Fixes #1283 \r\n\r\nWill look at number of transaction in last 3 blocks to determine whether to use minRelayTxFee (0.0001) or fallbackTxFee *0.0006) rate for fee estimation on full node wallet.\r\n\r\nHave tested with FullNodeUI wallet on testnet, with empty blocks.","created_at":"2018-08-26T23:03:30Z","updated_at":"2018-08-28T11:04:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"61355046f372f4cce7795770da59e278da6851fd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":926800905,"node_id":"MDU6TGFiZWw5MjY4MDA5MDU=","url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/labels/pr-review-medium","name":"pr-review-medium","color":"295182","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/2036/commits","review_comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/2036/comments","review_comment_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/2036/comments","statuses_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/52886783502e29b4bd173f8568653592e157c057","head":{"label":"mikedennis:issue-1283","ref":"issue-1283","sha":"52886783502e29b4bd173f8568653592e157c057","user":{"login":"mikedennis","id":24234359,"node_id":"MDQ6VXNlcjI0MjM0MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/24234359?v=4","gravatar_id":"","url":"https://api.github.com/users/mikedennis","html_url":"https://github.com/mikedennis","followers_url":"https://api.github.com/users/mikedennis/followers","following_url":"https://api.github.com/users/mikedennis/following{/other_user}","gists_url":"https://api.github.com/users/mikedennis/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedennis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedennis/subscriptions","organizations_url":"https://api.github.com/users/mikedennis/orgs","repos_url":"https://api.github.com/users/mikedennis/repos","events_url":"https://api.github.com/users/mikedennis/events{/privacy}","received_events_url":"https://api.github.com/users/mikedennis/received_events","type":"User","site_admin":false},"repo":{"id":96908927,"node_id":"MDEwOlJlcG9zaXRvcnk5NjkwODkyNw==","name":"StratisBitcoinFullNode","full_name":"mikedennis/StratisBitcoinFullNode","owner":{"login":"mikedennis","id":24234359,"node_id":"MDQ6VXNlcjI0MjM0MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/24234359?v=4","gravatar_id":"","url":"https://api.github.com/users/mikedennis","html_url":"https://github.com/mikedennis","followers_url":"https://api.github.com/users/mikedennis/followers","following_url":"https://api.github.com/users/mikedennis/following{/other_user}","gists_url":"https://api.github.com/users/mikedennis/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedennis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedennis/subscriptions","organizations_url":"https://api.github.com/users/mikedennis/orgs","repos_url":"https://api.github.com/users/mikedennis/repos","events_url":"https://api.github.com/users/mikedennis/events{/privacy}","received_events_url":"https://api.github.com/users/mikedennis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mikedennis/StratisBitcoinFullNode","description":"Bitcoin full node in C#","fork":true,"url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode","forks_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/forks","keys_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/teams","hooks_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/hooks","issue_events_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/issues/events{/number}","events_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/events","assignees_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/assignees{/user}","branches_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/branches{/branch}","tags_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/tags","blobs_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/statuses/{sha}","languages_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/languages","stargazers_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/stargazers","contributors_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/contributors","subscribers_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/subscribers","subscription_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/subscription","commits_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/contents/{+path}","compare_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/merges","archive_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/downloads","issues_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/issues{/number}","pulls_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/pulls{/number}","milestones_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/milestones{/number}","notifications_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/labels{/name}","releases_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/releases{/id}","deployments_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/deployments","created_at":"2017-07-11T15:32:38Z","updated_at":"2018-08-22T02:54:02Z","pushed_at":"2018-08-27T19:00:32Z","git_url":"git://github.com/mikedennis/StratisBitcoinFullNode.git","ssh_url":"git@github.com:mikedennis/StratisBitcoinFullNode.git","clone_url":"https://github.com/mikedennis/StratisBitcoinFullNode.git","svn_url":"https://github.com/mikedennis/StratisBitcoinFullNode","homepage":"https://stratisplatform.com","size":35890,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stratisproject:master","ref":"master","sha":"2993932daad9e996bef6473235f970d1e3b281ce","user":{"login":"stratisproject","id":15229748,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjI5NzQ4","avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"repo":{"id":67271290,"node_id":"MDEwOlJlcG9zaXRvcnk2NzI3MTI5MA==","name":"StratisBitcoinFullNode","full_name":"stratisproject/StratisBitcoinFullNode","owner":{"login":"stratisproject","id":15229748,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjI5NzQ4","avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stratisproject/StratisBitcoinFullNode","description":"Bitcoin full node in C#","fork":false,"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode","forks_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/forks","keys_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/teams","hooks_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/hooks","issue_events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/events{/number}","events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/events","assignees_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/assignees{/user}","branches_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/branches{/branch}","tags_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/tags","blobs_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/{sha}","languages_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/languages","stargazers_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/stargazers","contributors_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/contributors","subscribers_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/subscribers","subscription_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/subscription","commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/contents/{+path}","compare_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/merges","archive_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/downloads","issues_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues{/number}","pulls_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls{/number}","milestones_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/milestones{/number}","notifications_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/labels{/name}","releases_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/releases{/id}","deployments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/deployments","created_at":"2016-09-03T04:32:51Z","updated_at":"2018-08-28T09:53:42Z","pushed_at":"2018-08-28T10:28:45Z","git_url":"git://github.com/stratisproject/StratisBitcoinFullNode.git","ssh_url":"git@github.com:stratisproject/StratisBitcoinFullNode.git","clone_url":"https://github.com/stratisproject/StratisBitcoinFullNode.git","svn_url":"https://github.com/stratisproject/StratisBitcoinFullNode","homepage":"https://stratisplatform.com","size":33221,"stargazers_count":536,"watchers_count":536,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":243,"mirror_url":null,"archived":false,"open_issues_count":153,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":243,"open_issues":153,"watchers":536,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/2036"},"html":{"href":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/2036"},"issue":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/2036"},"comments":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/2036/comments"},"review_comments":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/2036/comments"},"review_comment":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/2036/commits"},"statuses":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/52886783502e29b4bd173f8568653592e157c057"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dangershony"}}