{"action":"created","issue":{"url":"https://api.github.com/repos/emacs-lsp/lsp-java/issues/34","repository_url":"https://api.github.com/repos/emacs-lsp/lsp-java","labels_url":"https://api.github.com/repos/emacs-lsp/lsp-java/issues/34/labels{/name}","comments_url":"https://api.github.com/repos/emacs-lsp/lsp-java/issues/34/comments","events_url":"https://api.github.com/repos/emacs-lsp/lsp-java/issues/34/events","html_url":"https://github.com/emacs-lsp/lsp-java/issues/34","id":328015413,"node_id":"MDU6SXNzdWUzMjgwMTU0MTM=","number":34,"title":"Support Java 10","user":{"login":"oakad","id":139498,"node_id":"MDQ6VXNlcjEzOTQ5OA==","avatar_url":"https://avatars1.githubusercontent.com/u/139498?v=4","gravatar_id":"","url":"https://api.github.com/users/oakad","html_url":"https://github.com/oakad","followers_url":"https://api.github.com/users/oakad/followers","following_url":"https://api.github.com/users/oakad/following{/other_user}","gists_url":"https://api.github.com/users/oakad/gists{/gist_id}","starred_url":"https://api.github.com/users/oakad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oakad/subscriptions","organizations_url":"https://api.github.com/users/oakad/orgs","repos_url":"https://api.github.com/users/oakad/repos","events_url":"https://api.github.com/users/oakad/events{/privacy}","received_events_url":"https://api.github.com/users/oakad/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"yyoncho","id":13259670,"node_id":"MDQ6VXNlcjEzMjU5Njcw","avatar_url":"https://avatars1.githubusercontent.com/u/13259670?v=4","gravatar_id":"","url":"https://api.github.com/users/yyoncho","html_url":"https://github.com/yyoncho","followers_url":"https://api.github.com/users/yyoncho/followers","following_url":"https://api.github.com/users/yyoncho/following{/other_user}","gists_url":"https://api.github.com/users/yyoncho/gists{/gist_id}","starred_url":"https://api.github.com/users/yyoncho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yyoncho/subscriptions","organizations_url":"https://api.github.com/users/yyoncho/orgs","repos_url":"https://api.github.com/users/yyoncho/repos","events_url":"https://api.github.com/users/yyoncho/events{/privacy}","received_events_url":"https://api.github.com/users/yyoncho/received_events","type":"User","site_admin":false},"assignees":[{"login":"yyoncho","id":13259670,"node_id":"MDQ6VXNlcjEzMjU5Njcw","avatar_url":"https://avatars1.githubusercontent.com/u/13259670?v=4","gravatar_id":"","url":"https://api.github.com/users/yyoncho","html_url":"https://github.com/yyoncho","followers_url":"https://api.github.com/users/yyoncho/followers","following_url":"https://api.github.com/users/yyoncho/following{/other_user}","gists_url":"https://api.github.com/users/yyoncho/gists{/gist_id}","starred_url":"https://api.github.com/users/yyoncho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yyoncho/subscriptions","organizations_url":"https://api.github.com/users/yyoncho/orgs","repos_url":"https://api.github.com/users/yyoncho/repos","events_url":"https://api.github.com/users/yyoncho/events{/privacy}","received_events_url":"https://api.github.com/users/yyoncho/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2018-05-31T06:54:34Z","updated_at":"2018-06-04T01:42:56Z","closed_at":null,"author_association":"NONE","body":"It appears, that to work properly in Java 10 mode, jdt.ls may need more parameters passed in.\r\n\r\nJudging from vscode exception:\r\n```\r\nif (requirements.java_version > 8) {\r\n\t\tparams.push('--add-modules=ALL-SYSTEM',\r\n\t\t\t\t\t'--add-opens',\r\n\t\t\t\t\t'java.base/java.util=ALL-UNNAMED',\r\n\t\t\t\t\t'--add-opens',\r\n\t\t\t\t\t'java.base/java.lang=ALL-UNNAMED');\r\n}\r\n```\r\n\r\nAlso, gradle and maven support should not be blindly forced to \"true\". Jdt.ls is very sensitive to unusual project configurations and the only mode that really can be trusted to work is eclipse .project/.classfile (this is used by default when gradle and maven support are disabled in the config).\r\n"},"comment":{"url":"https://api.github.com/repos/emacs-lsp/lsp-java/issues/comments/394212731","html_url":"https://github.com/emacs-lsp/lsp-java/issues/34#issuecomment-394212731","issue_url":"https://api.github.com/repos/emacs-lsp/lsp-java/issues/34","id":394212731,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDIxMjczMQ==","user":{"login":"oakad","id":139498,"node_id":"MDQ6VXNlcjEzOTQ5OA==","avatar_url":"https://avatars1.githubusercontent.com/u/139498?v=4","gravatar_id":"","url":"https://api.github.com/users/oakad","html_url":"https://github.com/oakad","followers_url":"https://api.github.com/users/oakad/followers","following_url":"https://api.github.com/users/oakad/following{/other_user}","gists_url":"https://api.github.com/users/oakad/gists{/gist_id}","starred_url":"https://api.github.com/users/oakad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oakad/subscriptions","organizations_url":"https://api.github.com/users/oakad/orgs","repos_url":"https://api.github.com/users/oakad/repos","events_url":"https://api.github.com/users/oakad/events{/privacy}","received_events_url":"https://api.github.com/users/oakad/received_events","type":"User","site_admin":false},"created_at":"2018-06-04T01:42:56Z","updated_at":"2018-06-04T01:42:56Z","author_association":"NONE","body":"If we are already at this, what do you think about this thing here: https://github.com/joaotavora/eglot ? Is it really a better option now that Emacs 26 is out?\r\n"}}
{"actor":{"display_login":"oakad"}}