{"action":"created","comment":{"url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/pulls/comments/175140112","pull_request_review_id":104627378,"id":175140112,"diff_hunk":"@@ -60,10 +64,43 @@ class SelectedAnnotation extends React.Component {\n     });\n   }\n \n+  onKeyUp(e) {\n+    const character = Utility.getHebrewChar(e);\n+\n+    if (character !== false) {\n+      this.props.dispatch(pressedKey(null));\n+    }\n+  }\n+\n+  onKeyDown(e) {\n+    const character = Utility.getHebrewChar(e);\n+\n+    if (Utility.getKeyCode(e) === KEY_VALUES.Enter) {\n+      this.saveText();\n+    }\n+\n+    if (character !== false) {\n+      e.preventDefault();\n+      this.setState({\n+        annotationText: this.inputText.value + character.unicode","path":"src/components/SelectedAnnotation.jsx","position":49,"original_position":49,"commit_id":"f9fe2474200442a7c04e006d3b8a2406e6952cc4","original_commit_id":"f9fe2474200442a7c04e006d3b8a2406e6952cc4","user":{"login":"eatyourgreens","id":59547,"avatar_url":"https://avatars3.githubusercontent.com/u/59547?v=4","gravatar_id":"","url":"https://api.github.com/users/eatyourgreens","html_url":"https://github.com/eatyourgreens","followers_url":"https://api.github.com/users/eatyourgreens/followers","following_url":"https://api.github.com/users/eatyourgreens/following{/other_user}","gists_url":"https://api.github.com/users/eatyourgreens/gists{/gist_id}","starred_url":"https://api.github.com/users/eatyourgreens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eatyourgreens/subscriptions","organizations_url":"https://api.github.com/users/eatyourgreens/orgs","repos_url":"https://api.github.com/users/eatyourgreens/repos","events_url":"https://api.github.com/users/eatyourgreens/events{/privacy}","received_events_url":"https://api.github.com/users/eatyourgreens/received_events","type":"User","site_admin":false},"body":"Yes. Sorry for the slow reply. I thought it would maybe avoid having to work with browser text selection APIs if you had the volunteers edit Latin text, from a Latin keyboard, and just translated the alphabet to Hebrew when you display the text. I am not sure how feasible this is, but it is easier to implement than a full text editor in JavaScript.","created_at":"2018-03-16T16:11:07Z","updated_at":"2018-03-16T16:11:07Z","html_url":"https://github.com/zooniverse/scribes-of-the-cairo-geniza/pull/40#discussion_r175140112","pull_request_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/pulls/40","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/pulls/comments/175140112"},"html":{"href":"https://github.com/zooniverse/scribes-of-the-cairo-geniza/pull/40#discussion_r175140112"},"pull_request":{"href":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/pulls/40"}},"in_reply_to_id":174842464},"pull_request":{"url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/pulls/40","id":175065651,"html_url":"https://github.com/zooniverse/scribes-of-the-cairo-geniza/pull/40","diff_url":"https://github.com/zooniverse/scribes-of-the-cairo-geniza/pull/40.diff","patch_url":"https://github.com/zooniverse/scribes-of-the-cairo-geniza/pull/40.patch","issue_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/issues/40","number":40,"state":"open","locked":false,"title":"Allow Hebrew Text from Keyboard","user":{"login":"wgranger","id":14099077,"avatar_url":"https://avatars1.githubusercontent.com/u/14099077?v=4","gravatar_id":"","url":"https://api.github.com/users/wgranger","html_url":"https://github.com/wgranger","followers_url":"https://api.github.com/users/wgranger/followers","following_url":"https://api.github.com/users/wgranger/following{/other_user}","gists_url":"https://api.github.com/users/wgranger/gists{/gist_id}","starred_url":"https://api.github.com/users/wgranger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wgranger/subscriptions","organizations_url":"https://api.github.com/users/wgranger/orgs","repos_url":"https://api.github.com/users/wgranger/repos","events_url":"https://api.github.com/users/wgranger/events{/privacy}","received_events_url":"https://api.github.com/users/wgranger/received_events","type":"User","site_admin":false},"body":"This branch should cover the needed functionality of typing in Hebrew and clicking buttons in the annotation box to insert Hebrew characters. However, I am curious if this PR is sound from an accessibility standpoint since I am somewhat hijacking the keyboard.","created_at":"2018-03-14T19:45:56Z","updated_at":"2018-03-16T16:11:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5d59b5bb1e28116a6d22ded67f505cb7e811cb9","assignee":{"login":"shaunanoordin","id":13952701,"avatar_url":"https://avatars0.githubusercontent.com/u/13952701?v=4","gravatar_id":"","url":"https://api.github.com/users/shaunanoordin","html_url":"https://github.com/shaunanoordin","followers_url":"https://api.github.com/users/shaunanoordin/followers","following_url":"https://api.github.com/users/shaunanoordin/following{/other_user}","gists_url":"https://api.github.com/users/shaunanoordin/gists{/gist_id}","starred_url":"https://api.github.com/users/shaunanoordin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaunanoordin/subscriptions","organizations_url":"https://api.github.com/users/shaunanoordin/orgs","repos_url":"https://api.github.com/users/shaunanoordin/repos","events_url":"https://api.github.com/users/shaunanoordin/events{/privacy}","received_events_url":"https://api.github.com/users/shaunanoordin/received_events","type":"User","site_admin":false},"assignees":[{"login":"shaunanoordin","id":13952701,"avatar_url":"https://avatars0.githubusercontent.com/u/13952701?v=4","gravatar_id":"","url":"https://api.github.com/users/shaunanoordin","html_url":"https://github.com/shaunanoordin","followers_url":"https://api.github.com/users/shaunanoordin/followers","following_url":"https://api.github.com/users/shaunanoordin/following{/other_user}","gists_url":"https://api.github.com/users/shaunanoordin/gists{/gist_id}","starred_url":"https://api.github.com/users/shaunanoordin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaunanoordin/subscriptions","organizations_url":"https://api.github.com/users/shaunanoordin/orgs","repos_url":"https://api.github.com/users/shaunanoordin/repos","events_url":"https://api.github.com/users/shaunanoordin/events{/privacy}","received_events_url":"https://api.github.com/users/shaunanoordin/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/pulls/40/commits","review_comments_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/pulls/40/comments","review_comment_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/issues/40/comments","statuses_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/statuses/f9fe2474200442a7c04e006d3b8a2406e6952cc4","head":{"label":"zooniverse:hebrew-type","ref":"hebrew-type","sha":"f9fe2474200442a7c04e006d3b8a2406e6952cc4","user":{"login":"zooniverse","id":106856,"avatar_url":"https://avatars2.githubusercontent.com/u/106856?v=4","gravatar_id":"","url":"https://api.github.com/users/zooniverse","html_url":"https://github.com/zooniverse","followers_url":"https://api.github.com/users/zooniverse/followers","following_url":"https://api.github.com/users/zooniverse/following{/other_user}","gists_url":"https://api.github.com/users/zooniverse/gists{/gist_id}","starred_url":"https://api.github.com/users/zooniverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zooniverse/subscriptions","organizations_url":"https://api.github.com/users/zooniverse/orgs","repos_url":"https://api.github.com/users/zooniverse/repos","events_url":"https://api.github.com/users/zooniverse/events{/privacy}","received_events_url":"https://api.github.com/users/zooniverse/received_events","type":"Organization","site_admin":false},"repo":{"id":112664965,"name":"scribes-of-the-cairo-geniza","full_name":"zooniverse/scribes-of-the-cairo-geniza","owner":{"login":"zooniverse","id":106856,"avatar_url":"https://avatars2.githubusercontent.com/u/106856?v=4","gravatar_id":"","url":"https://api.github.com/users/zooniverse","html_url":"https://github.com/zooniverse","followers_url":"https://api.github.com/users/zooniverse/followers","following_url":"https://api.github.com/users/zooniverse/following{/other_user}","gists_url":"https://api.github.com/users/zooniverse/gists{/gist_id}","starred_url":"https://api.github.com/users/zooniverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zooniverse/subscriptions","organizations_url":"https://api.github.com/users/zooniverse/orgs","repos_url":"https://api.github.com/users/zooniverse/repos","events_url":"https://api.github.com/users/zooniverse/events{/privacy}","received_events_url":"https://api.github.com/users/zooniverse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zooniverse/scribes-of-the-cairo-geniza","description":null,"fork":false,"url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza","forks_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/forks","keys_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/teams","hooks_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/hooks","issue_events_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/issues/events{/number}","events_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/events","assignees_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/assignees{/user}","branches_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/branches{/branch}","tags_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/tags","blobs_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/git/refs{/sha}","trees_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/statuses/{sha}","languages_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/languages","stargazers_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/stargazers","contributors_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/contributors","subscribers_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/subscribers","subscription_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/subscription","commits_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/commits{/sha}","git_commits_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/git/commits{/sha}","comments_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/comments{/number}","issue_comment_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/issues/comments{/number}","contents_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/contents/{+path}","compare_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/merges","archive_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/downloads","issues_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/issues{/number}","pulls_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/pulls{/number}","milestones_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/milestones{/number}","notifications_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/labels{/name}","releases_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/releases{/id}","deployments_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/deployments","created_at":"2017-11-30T21:59:12Z","updated_at":"2018-03-15T17:45:03Z","pushed_at":"2018-03-15T17:45:01Z","git_url":"git://github.com/zooniverse/scribes-of-the-cairo-geniza.git","ssh_url":"git@github.com:zooniverse/scribes-of-the-cairo-geniza.git","clone_url":"https://github.com/zooniverse/scribes-of-the-cairo-geniza.git","svn_url":"https://github.com/zooniverse/scribes-of-the-cairo-geniza","homepage":null,"size":13805,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":12,"watchers":1,"default_branch":"master"}},"base":{"label":"zooniverse:master","ref":"master","sha":"d99d5b7479f6edbd0962ad41e8f093c367744f89","user":{"login":"zooniverse","id":106856,"avatar_url":"https://avatars2.githubusercontent.com/u/106856?v=4","gravatar_id":"","url":"https://api.github.com/users/zooniverse","html_url":"https://github.com/zooniverse","followers_url":"https://api.github.com/users/zooniverse/followers","following_url":"https://api.github.com/users/zooniverse/following{/other_user}","gists_url":"https://api.github.com/users/zooniverse/gists{/gist_id}","starred_url":"https://api.github.com/users/zooniverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zooniverse/subscriptions","organizations_url":"https://api.github.com/users/zooniverse/orgs","repos_url":"https://api.github.com/users/zooniverse/repos","events_url":"https://api.github.com/users/zooniverse/events{/privacy}","received_events_url":"https://api.github.com/users/zooniverse/received_events","type":"Organization","site_admin":false},"repo":{"id":112664965,"name":"scribes-of-the-cairo-geniza","full_name":"zooniverse/scribes-of-the-cairo-geniza","owner":{"login":"zooniverse","id":106856,"avatar_url":"https://avatars2.githubusercontent.com/u/106856?v=4","gravatar_id":"","url":"https://api.github.com/users/zooniverse","html_url":"https://github.com/zooniverse","followers_url":"https://api.github.com/users/zooniverse/followers","following_url":"https://api.github.com/users/zooniverse/following{/other_user}","gists_url":"https://api.github.com/users/zooniverse/gists{/gist_id}","starred_url":"https://api.github.com/users/zooniverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zooniverse/subscriptions","organizations_url":"https://api.github.com/users/zooniverse/orgs","repos_url":"https://api.github.com/users/zooniverse/repos","events_url":"https://api.github.com/users/zooniverse/events{/privacy}","received_events_url":"https://api.github.com/users/zooniverse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zooniverse/scribes-of-the-cairo-geniza","description":null,"fork":false,"url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza","forks_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/forks","keys_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/teams","hooks_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/hooks","issue_events_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/issues/events{/number}","events_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/events","assignees_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/assignees{/user}","branches_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/branches{/branch}","tags_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/tags","blobs_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/git/refs{/sha}","trees_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/statuses/{sha}","languages_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/languages","stargazers_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/stargazers","contributors_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/contributors","subscribers_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/subscribers","subscription_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/subscription","commits_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/commits{/sha}","git_commits_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/git/commits{/sha}","comments_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/comments{/number}","issue_comment_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/issues/comments{/number}","contents_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/contents/{+path}","compare_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/merges","archive_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/downloads","issues_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/issues{/number}","pulls_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/pulls{/number}","milestones_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/milestones{/number}","notifications_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/labels{/name}","releases_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/releases{/id}","deployments_url":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/deployments","created_at":"2017-11-30T21:59:12Z","updated_at":"2018-03-15T17:45:03Z","pushed_at":"2018-03-15T17:45:01Z","git_url":"git://github.com/zooniverse/scribes-of-the-cairo-geniza.git","ssh_url":"git@github.com:zooniverse/scribes-of-the-cairo-geniza.git","clone_url":"https://github.com/zooniverse/scribes-of-the-cairo-geniza.git","svn_url":"https://github.com/zooniverse/scribes-of-the-cairo-geniza","homepage":null,"size":13805,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":12,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/pulls/40"},"html":{"href":"https://github.com/zooniverse/scribes-of-the-cairo-geniza/pull/40"},"issue":{"href":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/issues/40"},"comments":{"href":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/zooniverse/scribes-of-the-cairo-geniza/statuses/f9fe2474200442a7c04e006d3b8a2406e6952cc4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"eatyourgreens"}}