{"action":"created","issue":{"url":"https://api.github.com/repos/ConsensusJ/consensusj/issues/42","repository_url":"https://api.github.com/repos/ConsensusJ/consensusj","labels_url":"https://api.github.com/repos/ConsensusJ/consensusj/issues/42/labels{/name}","comments_url":"https://api.github.com/repos/ConsensusJ/consensusj/issues/42/comments","events_url":"https://api.github.com/repos/ConsensusJ/consensusj/issues/42/events","html_url":"https://github.com/ConsensusJ/consensusj/issues/42","id":342538318,"node_id":"MDU6SXNzdWUzNDI1MzgzMTg=","number":42,"title":"bitcoinj-server: Replace PeerGroup with WalletAppKit?","user":{"login":"JeremyRand","id":244188,"node_id":"MDQ6VXNlcjI0NDE4OA==","avatar_url":"https://avatars0.githubusercontent.com/u/244188?v=4","gravatar_id":"","url":"https://api.github.com/users/JeremyRand","html_url":"https://github.com/JeremyRand","followers_url":"https://api.github.com/users/JeremyRand/followers","following_url":"https://api.github.com/users/JeremyRand/following{/other_user}","gists_url":"https://api.github.com/users/JeremyRand/gists{/gist_id}","starred_url":"https://api.github.com/users/JeremyRand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeremyRand/subscriptions","organizations_url":"https://api.github.com/users/JeremyRand/orgs","repos_url":"https://api.github.com/users/JeremyRand/repos","events_url":"https://api.github.com/users/JeremyRand/events{/privacy}","received_events_url":"https://api.github.com/users/JeremyRand/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-19T00:36:04Z","updated_at":"2018-07-19T00:54:51Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Right now, `bitcoinj-server` (and, by extension, `bitcoinj-daemon` and `cj-nmc-daemon`) are using a `PeerGroup`.  Namecoin's fork of ConsensusJ is using a `WalletAppKit` instead.  `WalletAppKit` is substantially more secure since it actually does SPV validation rather than blindly trusting whatever a network peer says, but it takes a few minutes for initial sync (whereas a `PeerGroup` can be used instantly).\r\n\r\nWould a PR be accepted that completely replaces `PeerGroup` with `WalletAppKit`, or does ConsensusJ aim to satisfy some use cases where `PeerGroup` is required?"},"comment":{"url":"https://api.github.com/repos/ConsensusJ/consensusj/issues/comments/406119432","html_url":"https://github.com/ConsensusJ/consensusj/issues/42#issuecomment-406119432","issue_url":"https://api.github.com/repos/ConsensusJ/consensusj/issues/42","id":406119432,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjExOTQzMg==","user":{"login":"msgilligan","id":61612,"node_id":"MDQ6VXNlcjYxNjEy","avatar_url":"https://avatars1.githubusercontent.com/u/61612?v=4","gravatar_id":"","url":"https://api.github.com/users/msgilligan","html_url":"https://github.com/msgilligan","followers_url":"https://api.github.com/users/msgilligan/followers","following_url":"https://api.github.com/users/msgilligan/following{/other_user}","gists_url":"https://api.github.com/users/msgilligan/gists{/gist_id}","starred_url":"https://api.github.com/users/msgilligan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msgilligan/subscriptions","organizations_url":"https://api.github.com/users/msgilligan/orgs","repos_url":"https://api.github.com/users/msgilligan/repos","events_url":"https://api.github.com/users/msgilligan/events{/privacy}","received_events_url":"https://api.github.com/users/msgilligan/received_events","type":"User","site_admin":false},"created_at":"2018-07-19T00:54:51Z","updated_at":"2018-07-19T00:54:51Z","author_association":"MEMBER","body":"I think both `PeerGroup` and `WalletAppKit` are potentially useful as DI components. So let's not replace the `PeerGroup` beans. However, I do think that the `bitcoinj-daemon` should probably use `WalletAppKit`.\r\n\r\nIf you want to just make changes in `cj-nmc-daemon` first -- and then we can migrate them later to the Bitcoin daemon, that would be fine with me."}}
{"actor":{"display_login":"msgilligan"}}