{"action":"closed","number":40,"pull_request":{"url":"https://api.github.com/repos/rentpath/style-guides/pulls/40","id":202578838,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNTc4ODM4","html_url":"https://github.com/rentpath/style-guides/pull/40","diff_url":"https://github.com/rentpath/style-guides/pull/40.diff","patch_url":"https://github.com/rentpath/style-guides/pull/40.patch","issue_url":"https://api.github.com/repos/rentpath/style-guides/issues/40","number":40,"state":"closed","locked":false,"title":"Update .credo.exs","user":{"login":"michaelstalker","id":636342,"node_id":"MDQ6VXNlcjYzNjM0Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/636342?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelstalker","html_url":"https://github.com/michaelstalker","followers_url":"https://api.github.com/users/michaelstalker/followers","following_url":"https://api.github.com/users/michaelstalker/following{/other_user}","gists_url":"https://api.github.com/users/michaelstalker/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelstalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelstalker/subscriptions","organizations_url":"https://api.github.com/users/michaelstalker/orgs","repos_url":"https://api.github.com/users/michaelstalker/repos","events_url":"https://api.github.com/users/michaelstalker/events{/privacy}","received_events_url":"https://api.github.com/users/michaelstalker/received_events","type":"User","site_admin":false},"body":"[Card](https://rentpath.leankit.com/card/697057859)\r\n\r\n* Add new Credo checks\r\n* Enable disabled checks that reflect [Christopher Adams's style  guide](https://github.com/christopheradams/elixir_style_guide).\r\n* Set the duplicate code Credo check not to fail a build. It's possible  to DRY code prematurely. Creating an abstraction for code that is  structurally identical, but is not the same for essential reasons,  could leave us with a faulty abstraction.\r\n* Check test files. These are an important part of our codebase, and  should be as clean as our application code.\r\n* Exclude the `node_modules/` directory\r\n* Enforce line length. I think we've been doing it in some cases  already, and this will help our code readability.\r\n* Require `@spec` for functions. We've already been doing this  sometimes, so this check just codifies our current practice. Adding  `@spec` will  help us leverage dialyzer, as well as serve as code documentation.\r\n* Remove `Credo.Check.Warning.NameRedeclarationBy*` checks that no  longer exist in Credo.\r\n* Disable `Credo.Check.Refactor.CondStatements`. A `cond` statement is sometimes more concise than `if/then` code.\r\n\r\nExplanations of checks are in the beginning of each check file. You can find the check files [here](https://github.com/rrrene/credo/tree/master/lib/credo/check).","created_at":"2018-07-19T14:28:53Z","updated_at":"2018-07-19T21:23:11Z","closed_at":"2018-07-19T21:23:11Z","merged_at":"2018-07-19T21:23:11Z","merge_commit_sha":"751e45c3abbe42cd22b222ce8d8bd86d00c54764","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rentpath/style-guides/pulls/40/commits","review_comments_url":"https://api.github.com/repos/rentpath/style-guides/pulls/40/comments","review_comment_url":"https://api.github.com/repos/rentpath/style-guides/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rentpath/style-guides/issues/40/comments","statuses_url":"https://api.github.com/repos/rentpath/style-guides/statuses/e0f92c2035adf2ad767e18accf3354cda8d6df8d","head":{"label":"rentpath:mts/elixir_changes","ref":"mts/elixir_changes","sha":"e0f92c2035adf2ad767e18accf3354cda8d6df8d","user":{"login":"rentpath","id":37622,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NjIy","avatar_url":"https://avatars3.githubusercontent.com/u/37622?v=4","gravatar_id":"","url":"https://api.github.com/users/rentpath","html_url":"https://github.com/rentpath","followers_url":"https://api.github.com/users/rentpath/followers","following_url":"https://api.github.com/users/rentpath/following{/other_user}","gists_url":"https://api.github.com/users/rentpath/gists{/gist_id}","starred_url":"https://api.github.com/users/rentpath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rentpath/subscriptions","organizations_url":"https://api.github.com/users/rentpath/orgs","repos_url":"https://api.github.com/users/rentpath/repos","events_url":"https://api.github.com/users/rentpath/events{/privacy}","received_events_url":"https://api.github.com/users/rentpath/received_events","type":"Organization","site_admin":false},"repo":{"id":43452900,"node_id":"MDEwOlJlcG9zaXRvcnk0MzQ1MjkwMA==","name":"style-guides","full_name":"rentpath/style-guides","owner":{"login":"rentpath","id":37622,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NjIy","avatar_url":"https://avatars3.githubusercontent.com/u/37622?v=4","gravatar_id":"","url":"https://api.github.com/users/rentpath","html_url":"https://github.com/rentpath","followers_url":"https://api.github.com/users/rentpath/followers","following_url":"https://api.github.com/users/rentpath/following{/other_user}","gists_url":"https://api.github.com/users/rentpath/gists{/gist_id}","starred_url":"https://api.github.com/users/rentpath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rentpath/subscriptions","organizations_url":"https://api.github.com/users/rentpath/orgs","repos_url":"https://api.github.com/users/rentpath/repos","events_url":"https://api.github.com/users/rentpath/events{/privacy}","received_events_url":"https://api.github.com/users/rentpath/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rentpath/style-guides","description":"A collection of style guides used at RentPath.","fork":false,"url":"https://api.github.com/repos/rentpath/style-guides","forks_url":"https://api.github.com/repos/rentpath/style-guides/forks","keys_url":"https://api.github.com/repos/rentpath/style-guides/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rentpath/style-guides/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rentpath/style-guides/teams","hooks_url":"https://api.github.com/repos/rentpath/style-guides/hooks","issue_events_url":"https://api.github.com/repos/rentpath/style-guides/issues/events{/number}","events_url":"https://api.github.com/repos/rentpath/style-guides/events","assignees_url":"https://api.github.com/repos/rentpath/style-guides/assignees{/user}","branches_url":"https://api.github.com/repos/rentpath/style-guides/branches{/branch}","tags_url":"https://api.github.com/repos/rentpath/style-guides/tags","blobs_url":"https://api.github.com/repos/rentpath/style-guides/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rentpath/style-guides/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rentpath/style-guides/git/refs{/sha}","trees_url":"https://api.github.com/repos/rentpath/style-guides/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rentpath/style-guides/statuses/{sha}","languages_url":"https://api.github.com/repos/rentpath/style-guides/languages","stargazers_url":"https://api.github.com/repos/rentpath/style-guides/stargazers","contributors_url":"https://api.github.com/repos/rentpath/style-guides/contributors","subscribers_url":"https://api.github.com/repos/rentpath/style-guides/subscribers","subscription_url":"https://api.github.com/repos/rentpath/style-guides/subscription","commits_url":"https://api.github.com/repos/rentpath/style-guides/commits{/sha}","git_commits_url":"https://api.github.com/repos/rentpath/style-guides/git/commits{/sha}","comments_url":"https://api.github.com/repos/rentpath/style-guides/comments{/number}","issue_comment_url":"https://api.github.com/repos/rentpath/style-guides/issues/comments{/number}","contents_url":"https://api.github.com/repos/rentpath/style-guides/contents/{+path}","compare_url":"https://api.github.com/repos/rentpath/style-guides/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rentpath/style-guides/merges","archive_url":"https://api.github.com/repos/rentpath/style-guides/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rentpath/style-guides/downloads","issues_url":"https://api.github.com/repos/rentpath/style-guides/issues{/number}","pulls_url":"https://api.github.com/repos/rentpath/style-guides/pulls{/number}","milestones_url":"https://api.github.com/repos/rentpath/style-guides/milestones{/number}","notifications_url":"https://api.github.com/repos/rentpath/style-guides/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rentpath/style-guides/labels{/name}","releases_url":"https://api.github.com/repos/rentpath/style-guides/releases{/id}","deployments_url":"https://api.github.com/repos/rentpath/style-guides/deployments","created_at":"2015-09-30T19:02:46Z","updated_at":"2016-10-28T15:39:01Z","pushed_at":"2018-07-19T21:23:11Z","git_url":"git://github.com/rentpath/style-guides.git","ssh_url":"git@github.com:rentpath/style-guides.git","clone_url":"https://github.com/rentpath/style-guides.git","svn_url":"https://github.com/rentpath/style-guides","homepage":null,"size":87,"stargazers_count":2,"watchers_count":2,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"rentpath:master","ref":"master","sha":"c0b49a02385d31107982c64981bdfed66963c5d0","user":{"login":"rentpath","id":37622,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NjIy","avatar_url":"https://avatars3.githubusercontent.com/u/37622?v=4","gravatar_id":"","url":"https://api.github.com/users/rentpath","html_url":"https://github.com/rentpath","followers_url":"https://api.github.com/users/rentpath/followers","following_url":"https://api.github.com/users/rentpath/following{/other_user}","gists_url":"https://api.github.com/users/rentpath/gists{/gist_id}","starred_url":"https://api.github.com/users/rentpath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rentpath/subscriptions","organizations_url":"https://api.github.com/users/rentpath/orgs","repos_url":"https://api.github.com/users/rentpath/repos","events_url":"https://api.github.com/users/rentpath/events{/privacy}","received_events_url":"https://api.github.com/users/rentpath/received_events","type":"Organization","site_admin":false},"repo":{"id":43452900,"node_id":"MDEwOlJlcG9zaXRvcnk0MzQ1MjkwMA==","name":"style-guides","full_name":"rentpath/style-guides","owner":{"login":"rentpath","id":37622,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NjIy","avatar_url":"https://avatars3.githubusercontent.com/u/37622?v=4","gravatar_id":"","url":"https://api.github.com/users/rentpath","html_url":"https://github.com/rentpath","followers_url":"https://api.github.com/users/rentpath/followers","following_url":"https://api.github.com/users/rentpath/following{/other_user}","gists_url":"https://api.github.com/users/rentpath/gists{/gist_id}","starred_url":"https://api.github.com/users/rentpath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rentpath/subscriptions","organizations_url":"https://api.github.com/users/rentpath/orgs","repos_url":"https://api.github.com/users/rentpath/repos","events_url":"https://api.github.com/users/rentpath/events{/privacy}","received_events_url":"https://api.github.com/users/rentpath/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rentpath/style-guides","description":"A collection of style guides used at RentPath.","fork":false,"url":"https://api.github.com/repos/rentpath/style-guides","forks_url":"https://api.github.com/repos/rentpath/style-guides/forks","keys_url":"https://api.github.com/repos/rentpath/style-guides/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rentpath/style-guides/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rentpath/style-guides/teams","hooks_url":"https://api.github.com/repos/rentpath/style-guides/hooks","issue_events_url":"https://api.github.com/repos/rentpath/style-guides/issues/events{/number}","events_url":"https://api.github.com/repos/rentpath/style-guides/events","assignees_url":"https://api.github.com/repos/rentpath/style-guides/assignees{/user}","branches_url":"https://api.github.com/repos/rentpath/style-guides/branches{/branch}","tags_url":"https://api.github.com/repos/rentpath/style-guides/tags","blobs_url":"https://api.github.com/repos/rentpath/style-guides/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rentpath/style-guides/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rentpath/style-guides/git/refs{/sha}","trees_url":"https://api.github.com/repos/rentpath/style-guides/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rentpath/style-guides/statuses/{sha}","languages_url":"https://api.github.com/repos/rentpath/style-guides/languages","stargazers_url":"https://api.github.com/repos/rentpath/style-guides/stargazers","contributors_url":"https://api.github.com/repos/rentpath/style-guides/contributors","subscribers_url":"https://api.github.com/repos/rentpath/style-guides/subscribers","subscription_url":"https://api.github.com/repos/rentpath/style-guides/subscription","commits_url":"https://api.github.com/repos/rentpath/style-guides/commits{/sha}","git_commits_url":"https://api.github.com/repos/rentpath/style-guides/git/commits{/sha}","comments_url":"https://api.github.com/repos/rentpath/style-guides/comments{/number}","issue_comment_url":"https://api.github.com/repos/rentpath/style-guides/issues/comments{/number}","contents_url":"https://api.github.com/repos/rentpath/style-guides/contents/{+path}","compare_url":"https://api.github.com/repos/rentpath/style-guides/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rentpath/style-guides/merges","archive_url":"https://api.github.com/repos/rentpath/style-guides/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rentpath/style-guides/downloads","issues_url":"https://api.github.com/repos/rentpath/style-guides/issues{/number}","pulls_url":"https://api.github.com/repos/rentpath/style-guides/pulls{/number}","milestones_url":"https://api.github.com/repos/rentpath/style-guides/milestones{/number}","notifications_url":"https://api.github.com/repos/rentpath/style-guides/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rentpath/style-guides/labels{/name}","releases_url":"https://api.github.com/repos/rentpath/style-guides/releases{/id}","deployments_url":"https://api.github.com/repos/rentpath/style-guides/deployments","created_at":"2015-09-30T19:02:46Z","updated_at":"2016-10-28T15:39:01Z","pushed_at":"2018-07-19T21:23:11Z","git_url":"git://github.com/rentpath/style-guides.git","ssh_url":"git@github.com:rentpath/style-guides.git","clone_url":"https://github.com/rentpath/style-guides.git","svn_url":"https://github.com/rentpath/style-guides","homepage":null,"size":87,"stargazers_count":2,"watchers_count":2,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rentpath/style-guides/pulls/40"},"html":{"href":"https://github.com/rentpath/style-guides/pull/40"},"issue":{"href":"https://api.github.com/repos/rentpath/style-guides/issues/40"},"comments":{"href":"https://api.github.com/repos/rentpath/style-guides/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/rentpath/style-guides/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/rentpath/style-guides/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rentpath/style-guides/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/rentpath/style-guides/statuses/e0f92c2035adf2ad767e18accf3354cda8d6df8d"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"michaelstalker","id":636342,"node_id":"MDQ6VXNlcjYzNjM0Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/636342?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelstalker","html_url":"https://github.com/michaelstalker","followers_url":"https://api.github.com/users/michaelstalker/followers","following_url":"https://api.github.com/users/michaelstalker/following{/other_user}","gists_url":"https://api.github.com/users/michaelstalker/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelstalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelstalker/subscriptions","organizations_url":"https://api.github.com/users/michaelstalker/orgs","repos_url":"https://api.github.com/users/michaelstalker/repos","events_url":"https://api.github.com/users/michaelstalker/events{/privacy}","received_events_url":"https://api.github.com/users/michaelstalker/received_events","type":"User","site_admin":false},"comments":6,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":55,"deletions":21,"changed_files":2}}
{"actor":{"display_login":"michaelstalker"}}