{"action":"closed","number":50,"pull_request":{"url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/pulls/50","id":227101651,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MTAxNjUx","html_url":"https://github.com/segment-integrations/analytics.js-integration-segmentio/pull/50","diff_url":"https://github.com/segment-integrations/analytics.js-integration-segmentio/pull/50.diff","patch_url":"https://github.com/segment-integrations/analytics.js-integration-segmentio/pull/50.patch","issue_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/issues/50","number":50,"state":"closed","locked":false,"title":"Fix testing logic","user":{"login":"f2prateek","id":843979,"node_id":"MDQ6VXNlcjg0Mzk3OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/843979?v=4","gravatar_id":"","url":"https://api.github.com/users/f2prateek","html_url":"https://github.com/f2prateek","followers_url":"https://api.github.com/users/f2prateek/followers","following_url":"https://api.github.com/users/f2prateek/following{/other_user}","gists_url":"https://api.github.com/users/f2prateek/gists{/gist_id}","starred_url":"https://api.github.com/users/f2prateek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/f2prateek/subscriptions","organizations_url":"https://api.github.com/users/f2prateek/orgs","repos_url":"https://api.github.com/users/f2prateek/repos","events_url":"https://api.github.com/users/f2prateek/events{/privacy}","received_events_url":"https://api.github.com/users/f2prateek/received_events","type":"User","site_admin":false},"body":"In a previous change (https://github.com/segment-integrations/analytics.js-integration-segmentio/pull/49), I added table driven tests to ensure our tests pass when retryQueue enabled or disabled. However it unintentionally disabled these tests. Fixing the logic enables them again.","created_at":"2018-10-30T22:25:16Z","updated_at":"2018-10-30T22:35:55Z","closed_at":"2018-10-30T22:35:55Z","merged_at":"2018-10-30T22:35:55Z","merge_commit_sha":"d9cd155f807834bb98352d782dd8c549221145a8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nhi-nguyen","id":2120046,"node_id":"MDQ6VXNlcjIxMjAwNDY=","avatar_url":"https://avatars0.githubusercontent.com/u/2120046?v=4","gravatar_id":"","url":"https://api.github.com/users/nhi-nguyen","html_url":"https://github.com/nhi-nguyen","followers_url":"https://api.github.com/users/nhi-nguyen/followers","following_url":"https://api.github.com/users/nhi-nguyen/following{/other_user}","gists_url":"https://api.github.com/users/nhi-nguyen/gists{/gist_id}","starred_url":"https://api.github.com/users/nhi-nguyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhi-nguyen/subscriptions","organizations_url":"https://api.github.com/users/nhi-nguyen/orgs","repos_url":"https://api.github.com/users/nhi-nguyen/repos","events_url":"https://api.github.com/users/nhi-nguyen/events{/privacy}","received_events_url":"https://api.github.com/users/nhi-nguyen/received_events","type":"User","site_admin":false},{"login":"fathyb","id":5746414,"node_id":"MDQ6VXNlcjU3NDY0MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5746414?v=4","gravatar_id":"","url":"https://api.github.com/users/fathyb","html_url":"https://github.com/fathyb","followers_url":"https://api.github.com/users/fathyb/followers","following_url":"https://api.github.com/users/fathyb/following{/other_user}","gists_url":"https://api.github.com/users/fathyb/gists{/gist_id}","starred_url":"https://api.github.com/users/fathyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fathyb/subscriptions","organizations_url":"https://api.github.com/users/fathyb/orgs","repos_url":"https://api.github.com/users/fathyb/repos","events_url":"https://api.github.com/users/fathyb/events{/privacy}","received_events_url":"https://api.github.com/users/fathyb/received_events","type":"User","site_admin":false},{"login":"Peripheral1994","id":11656461,"node_id":"MDQ6VXNlcjExNjU2NDYx","avatar_url":"https://avatars2.githubusercontent.com/u/11656461?v=4","gravatar_id":"","url":"https://api.github.com/users/Peripheral1994","html_url":"https://github.com/Peripheral1994","followers_url":"https://api.github.com/users/Peripheral1994/followers","following_url":"https://api.github.com/users/Peripheral1994/following{/other_user}","gists_url":"https://api.github.com/users/Peripheral1994/gists{/gist_id}","starred_url":"https://api.github.com/users/Peripheral1994/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Peripheral1994/subscriptions","organizations_url":"https://api.github.com/users/Peripheral1994/orgs","repos_url":"https://api.github.com/users/Peripheral1994/repos","events_url":"https://api.github.com/users/Peripheral1994/events{/privacy}","received_events_url":"https://api.github.com/users/Peripheral1994/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/pulls/50/commits","review_comments_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/pulls/50/comments","review_comment_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/issues/50/comments","statuses_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/statuses/08566150a69f593d84da9c131534f645c6f07282","head":{"label":"segment-integrations:fix-tests","ref":"fix-tests","sha":"08566150a69f593d84da9c131534f645c6f07282","user":{"login":"segment-integrations","id":11207740,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjA3NzQw","avatar_url":"https://avatars3.githubusercontent.com/u/11207740?v=4","gravatar_id":"","url":"https://api.github.com/users/segment-integrations","html_url":"https://github.com/segment-integrations","followers_url":"https://api.github.com/users/segment-integrations/followers","following_url":"https://api.github.com/users/segment-integrations/following{/other_user}","gists_url":"https://api.github.com/users/segment-integrations/gists{/gist_id}","starred_url":"https://api.github.com/users/segment-integrations/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/segment-integrations/subscriptions","organizations_url":"https://api.github.com/users/segment-integrations/orgs","repos_url":"https://api.github.com/users/segment-integrations/repos","events_url":"https://api.github.com/users/segment-integrations/events{/privacy}","received_events_url":"https://api.github.com/users/segment-integrations/received_events","type":"Organization","site_admin":false},"repo":{"id":37163416,"node_id":"MDEwOlJlcG9zaXRvcnkzNzE2MzQxNg==","name":"analytics.js-integration-segmentio","full_name":"segment-integrations/analytics.js-integration-segmentio","private":false,"owner":{"login":"segment-integrations","id":11207740,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjA3NzQw","avatar_url":"https://avatars3.githubusercontent.com/u/11207740?v=4","gravatar_id":"","url":"https://api.github.com/users/segment-integrations","html_url":"https://github.com/segment-integrations","followers_url":"https://api.github.com/users/segment-integrations/followers","following_url":"https://api.github.com/users/segment-integrations/following{/other_user}","gists_url":"https://api.github.com/users/segment-integrations/gists{/gist_id}","starred_url":"https://api.github.com/users/segment-integrations/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/segment-integrations/subscriptions","organizations_url":"https://api.github.com/users/segment-integrations/orgs","repos_url":"https://api.github.com/users/segment-integrations/repos","events_url":"https://api.github.com/users/segment-integrations/events{/privacy}","received_events_url":"https://api.github.com/users/segment-integrations/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/segment-integrations/analytics.js-integration-segmentio","description":"The Segmentio analytics.js integration.","fork":false,"url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio","forks_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/forks","keys_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/teams","hooks_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/hooks","issue_events_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/issues/events{/number}","events_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/events","assignees_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/assignees{/user}","branches_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/branches{/branch}","tags_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/tags","blobs_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/git/refs{/sha}","trees_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/statuses/{sha}","languages_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/languages","stargazers_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/stargazers","contributors_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/contributors","subscribers_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/subscribers","subscription_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/subscription","commits_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/commits{/sha}","git_commits_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/git/commits{/sha}","comments_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/comments{/number}","issue_comment_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/issues/comments{/number}","contents_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/contents/{+path}","compare_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/merges","archive_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/downloads","issues_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/issues{/number}","pulls_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/pulls{/number}","milestones_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/milestones{/number}","notifications_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/labels{/name}","releases_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/releases{/id}","deployments_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/deployments","created_at":"2015-06-09T23:04:42Z","updated_at":"2018-10-05T20:37:12Z","pushed_at":"2018-10-30T22:35:55Z","git_url":"git://github.com/segment-integrations/analytics.js-integration-segmentio.git","ssh_url":"git@github.com:segment-integrations/analytics.js-integration-segmentio.git","clone_url":"https://github.com/segment-integrations/analytics.js-integration-segmentio.git","svn_url":"https://github.com/segment-integrations/analytics.js-integration-segmentio","homepage":"","size":120,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":21,"open_issues":4,"watchers":4,"default_branch":"master"}},"base":{"label":"segment-integrations:master","ref":"master","sha":"abb4ca31ff2c9205cba7688a324ba071faacf132","user":{"login":"segment-integrations","id":11207740,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjA3NzQw","avatar_url":"https://avatars3.githubusercontent.com/u/11207740?v=4","gravatar_id":"","url":"https://api.github.com/users/segment-integrations","html_url":"https://github.com/segment-integrations","followers_url":"https://api.github.com/users/segment-integrations/followers","following_url":"https://api.github.com/users/segment-integrations/following{/other_user}","gists_url":"https://api.github.com/users/segment-integrations/gists{/gist_id}","starred_url":"https://api.github.com/users/segment-integrations/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/segment-integrations/subscriptions","organizations_url":"https://api.github.com/users/segment-integrations/orgs","repos_url":"https://api.github.com/users/segment-integrations/repos","events_url":"https://api.github.com/users/segment-integrations/events{/privacy}","received_events_url":"https://api.github.com/users/segment-integrations/received_events","type":"Organization","site_admin":false},"repo":{"id":37163416,"node_id":"MDEwOlJlcG9zaXRvcnkzNzE2MzQxNg==","name":"analytics.js-integration-segmentio","full_name":"segment-integrations/analytics.js-integration-segmentio","private":false,"owner":{"login":"segment-integrations","id":11207740,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjA3NzQw","avatar_url":"https://avatars3.githubusercontent.com/u/11207740?v=4","gravatar_id":"","url":"https://api.github.com/users/segment-integrations","html_url":"https://github.com/segment-integrations","followers_url":"https://api.github.com/users/segment-integrations/followers","following_url":"https://api.github.com/users/segment-integrations/following{/other_user}","gists_url":"https://api.github.com/users/segment-integrations/gists{/gist_id}","starred_url":"https://api.github.com/users/segment-integrations/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/segment-integrations/subscriptions","organizations_url":"https://api.github.com/users/segment-integrations/orgs","repos_url":"https://api.github.com/users/segment-integrations/repos","events_url":"https://api.github.com/users/segment-integrations/events{/privacy}","received_events_url":"https://api.github.com/users/segment-integrations/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/segment-integrations/analytics.js-integration-segmentio","description":"The Segmentio analytics.js integration.","fork":false,"url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio","forks_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/forks","keys_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/teams","hooks_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/hooks","issue_events_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/issues/events{/number}","events_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/events","assignees_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/assignees{/user}","branches_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/branches{/branch}","tags_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/tags","blobs_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/git/refs{/sha}","trees_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/statuses/{sha}","languages_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/languages","stargazers_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/stargazers","contributors_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/contributors","subscribers_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/subscribers","subscription_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/subscription","commits_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/commits{/sha}","git_commits_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/git/commits{/sha}","comments_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/comments{/number}","issue_comment_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/issues/comments{/number}","contents_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/contents/{+path}","compare_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/merges","archive_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/downloads","issues_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/issues{/number}","pulls_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/pulls{/number}","milestones_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/milestones{/number}","notifications_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/labels{/name}","releases_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/releases{/id}","deployments_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/deployments","created_at":"2015-06-09T23:04:42Z","updated_at":"2018-10-05T20:37:12Z","pushed_at":"2018-10-30T22:35:55Z","git_url":"git://github.com/segment-integrations/analytics.js-integration-segmentio.git","ssh_url":"git@github.com:segment-integrations/analytics.js-integration-segmentio.git","clone_url":"https://github.com/segment-integrations/analytics.js-integration-segmentio.git","svn_url":"https://github.com/segment-integrations/analytics.js-integration-segmentio","homepage":"","size":120,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":21,"open_issues":4,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/pulls/50"},"html":{"href":"https://github.com/segment-integrations/analytics.js-integration-segmentio/pull/50"},"issue":{"href":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/issues/50"},"comments":{"href":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/segment-integrations/analytics.js-integration-segmentio/statuses/08566150a69f593d84da9c131534f645c6f07282"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"f2prateek","id":843979,"node_id":"MDQ6VXNlcjg0Mzk3OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/843979?v=4","gravatar_id":"","url":"https://api.github.com/users/f2prateek","html_url":"https://github.com/f2prateek","followers_url":"https://api.github.com/users/f2prateek/followers","following_url":"https://api.github.com/users/f2prateek/following{/other_user}","gists_url":"https://api.github.com/users/f2prateek/gists{/gist_id}","starred_url":"https://api.github.com/users/f2prateek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/f2prateek/subscriptions","organizations_url":"https://api.github.com/users/f2prateek/orgs","repos_url":"https://api.github.com/users/f2prateek/repos","events_url":"https://api.github.com/users/f2prateek/events{/privacy}","received_events_url":"https://api.github.com/users/f2prateek/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"f2prateek"}}