{"action":"created","comment":{"url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/pulls/comments/208337405","pull_request_review_id":144125682,"id":208337405,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODMzNzQwNQ==","diff_hunk":"@@ -67,13 +75,9 @@ export class GettingStartedService implements OnDestroy {\n   getExtProfile(id: string): Observable<ExtUser> {\n     let url = `${this.usersUrl}/${id}`;\n     return this.http\n-      .get(url, { headers: this.headers })\n-      .map(response => {\n-        return response.json().data as ExtUser;\n-      })\n-      .catch((error) => {\n-        return this.handleError(error);\n-      });\n+      .get<ExtUserResponse>(url, { headers: this.headers })\n+      .map(response => response.data)\n+      .catch((error) => this.handleError(error));","path":"src/app/getting-started/services/getting-started.service.ts","position":58,"original_position":58,"commit_id":"c16d0225dec7e7dec50ffc6c740b06aacb222ad7","original_commit_id":"c16d0225dec7e7dec50ffc6c740b06aacb222ad7","user":{"login":"joshuawilson","id":1184371,"node_id":"MDQ6VXNlcjExODQzNzE=","avatar_url":"https://avatars2.githubusercontent.com/u/1184371?v=4","gravatar_id":"","url":"https://api.github.com/users/joshuawilson","html_url":"https://github.com/joshuawilson","followers_url":"https://api.github.com/users/joshuawilson/followers","following_url":"https://api.github.com/users/joshuawilson/following{/other_user}","gists_url":"https://api.github.com/users/joshuawilson/gists{/gist_id}","starred_url":"https://api.github.com/users/joshuawilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshuawilson/subscriptions","organizations_url":"https://api.github.com/users/joshuawilson/orgs","repos_url":"https://api.github.com/users/joshuawilson/repos","events_url":"https://api.github.com/users/joshuawilson/events{/privacy}","received_events_url":"https://api.github.com/users/joshuawilson/received_events","type":"User","site_admin":false},"body":"please consider adding types for `response` and `error`","created_at":"2018-08-07T18:26:50Z","updated_at":"2018-08-07T18:28:28Z","html_url":"https://github.com/fabric8-ui/fabric8-ui/pull/3221#discussion_r208337405","pull_request_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/pulls/3221","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/fabric8-ui/fabric8-ui/pulls/comments/208337405"},"html":{"href":"https://github.com/fabric8-ui/fabric8-ui/pull/3221#discussion_r208337405"},"pull_request":{"href":"https://api.github.com/repos/fabric8-ui/fabric8-ui/pulls/3221"}}},"pull_request":{"url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/pulls/3221","id":205746178,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NzQ2MTc4","html_url":"https://github.com/fabric8-ui/fabric8-ui/pull/3221","diff_url":"https://github.com/fabric8-ui/fabric8-ui/pull/3221.diff","patch_url":"https://github.com/fabric8-ui/fabric8-ui/pull/3221.patch","issue_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/issues/3221","number":3221,"state":"open","locked":false,"title":"feat(http-client): upgrade GettingStarted and FeatureAcknowledgement …","user":{"login":"andrewazores","id":3787464,"node_id":"MDQ6VXNlcjM3ODc0NjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3787464?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewazores","html_url":"https://github.com/andrewazores","followers_url":"https://api.github.com/users/andrewazores/followers","following_url":"https://api.github.com/users/andrewazores/following{/other_user}","gists_url":"https://api.github.com/users/andrewazores/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewazores/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewazores/subscriptions","organizations_url":"https://api.github.com/users/andrewazores/orgs","repos_url":"https://api.github.com/users/andrewazores/repos","events_url":"https://api.github.com/users/andrewazores/events{/privacy}","received_events_url":"https://api.github.com/users/andrewazores/received_events","type":"User","site_admin":false},"body":"…to HttpClient\r\n\r\nUpgrade GettingStartedService and subclass FeatureAcknowledgementService to use newer HttpClient in\r\nanticipation of Angular upgrade. Tests for components that consume these services while also\r\nproviding them at the component level are also updated, overriding the component-level provides for\r\nthese services, so that the indirect Http/HttpClient module dependencies can be dropped from those tests\r\naltogether.\r\n\r\nrelated to https://openshift.io/openshiftio/Openshift_io/plan/detail/348\r\n\r\n","created_at":"2018-08-02T14:03:26Z","updated_at":"2018-08-07T18:28:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"973819faf0c421d9c03b4e5cd831e2da301a2118","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/pulls/3221/commits","review_comments_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/pulls/3221/comments","review_comment_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/issues/3221/comments","statuses_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/statuses/c16d0225dec7e7dec50ffc6c740b06aacb222ad7","head":{"label":"andrewazores:http-upgrade-feature-flag","ref":"http-upgrade-feature-flag","sha":"c16d0225dec7e7dec50ffc6c740b06aacb222ad7","user":{"login":"andrewazores","id":3787464,"node_id":"MDQ6VXNlcjM3ODc0NjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3787464?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewazores","html_url":"https://github.com/andrewazores","followers_url":"https://api.github.com/users/andrewazores/followers","following_url":"https://api.github.com/users/andrewazores/following{/other_user}","gists_url":"https://api.github.com/users/andrewazores/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewazores/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewazores/subscriptions","organizations_url":"https://api.github.com/users/andrewazores/orgs","repos_url":"https://api.github.com/users/andrewazores/repos","events_url":"https://api.github.com/users/andrewazores/events{/privacy}","received_events_url":"https://api.github.com/users/andrewazores/received_events","type":"User","site_admin":false},"repo":{"id":109168918,"node_id":"MDEwOlJlcG9zaXRvcnkxMDkxNjg5MTg=","name":"fabric8-ui","full_name":"andrewazores/fabric8-ui","owner":{"login":"andrewazores","id":3787464,"node_id":"MDQ6VXNlcjM3ODc0NjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3787464?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewazores","html_url":"https://github.com/andrewazores","followers_url":"https://api.github.com/users/andrewazores/followers","following_url":"https://api.github.com/users/andrewazores/following{/other_user}","gists_url":"https://api.github.com/users/andrewazores/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewazores/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewazores/subscriptions","organizations_url":"https://api.github.com/users/andrewazores/orgs","repos_url":"https://api.github.com/users/andrewazores/repos","events_url":"https://api.github.com/users/andrewazores/events{/privacy}","received_events_url":"https://api.github.com/users/andrewazores/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrewazores/fabric8-ui","description":"The Angular frontend for fabric8 online (OpenShift.IO)","fork":true,"url":"https://api.github.com/repos/andrewazores/fabric8-ui","forks_url":"https://api.github.com/repos/andrewazores/fabric8-ui/forks","keys_url":"https://api.github.com/repos/andrewazores/fabric8-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewazores/fabric8-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewazores/fabric8-ui/teams","hooks_url":"https://api.github.com/repos/andrewazores/fabric8-ui/hooks","issue_events_url":"https://api.github.com/repos/andrewazores/fabric8-ui/issues/events{/number}","events_url":"https://api.github.com/repos/andrewazores/fabric8-ui/events","assignees_url":"https://api.github.com/repos/andrewazores/fabric8-ui/assignees{/user}","branches_url":"https://api.github.com/repos/andrewazores/fabric8-ui/branches{/branch}","tags_url":"https://api.github.com/repos/andrewazores/fabric8-ui/tags","blobs_url":"https://api.github.com/repos/andrewazores/fabric8-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewazores/fabric8-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewazores/fabric8-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewazores/fabric8-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewazores/fabric8-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewazores/fabric8-ui/languages","stargazers_url":"https://api.github.com/repos/andrewazores/fabric8-ui/stargazers","contributors_url":"https://api.github.com/repos/andrewazores/fabric8-ui/contributors","subscribers_url":"https://api.github.com/repos/andrewazores/fabric8-ui/subscribers","subscription_url":"https://api.github.com/repos/andrewazores/fabric8-ui/subscription","commits_url":"https://api.github.com/repos/andrewazores/fabric8-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewazores/fabric8-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewazores/fabric8-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewazores/fabric8-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewazores/fabric8-ui/contents/{+path}","compare_url":"https://api.github.com/repos/andrewazores/fabric8-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewazores/fabric8-ui/merges","archive_url":"https://api.github.com/repos/andrewazores/fabric8-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewazores/fabric8-ui/downloads","issues_url":"https://api.github.com/repos/andrewazores/fabric8-ui/issues{/number}","pulls_url":"https://api.github.com/repos/andrewazores/fabric8-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewazores/fabric8-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewazores/fabric8-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewazores/fabric8-ui/labels{/name}","releases_url":"https://api.github.com/repos/andrewazores/fabric8-ui/releases{/id}","deployments_url":"https://api.github.com/repos/andrewazores/fabric8-ui/deployments","created_at":"2017-11-01T18:38:13Z","updated_at":"2018-08-03T19:24:56Z","pushed_at":"2018-08-07T18:17:15Z","git_url":"git://github.com/andrewazores/fabric8-ui.git","ssh_url":"git@github.com:andrewazores/fabric8-ui.git","clone_url":"https://github.com/andrewazores/fabric8-ui.git","svn_url":"https://github.com/andrewazores/fabric8-ui","homepage":"https://openshift.io/","size":14830,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fabric8-ui:master","ref":"master","sha":"d75afac9ba0ecc5b9d5c449105618bb079e2de33","user":{"login":"fabric8-ui","id":25244298,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MjQ0Mjk4","avatar_url":"https://avatars2.githubusercontent.com/u/25244298?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8-ui","html_url":"https://github.com/fabric8-ui","followers_url":"https://api.github.com/users/fabric8-ui/followers","following_url":"https://api.github.com/users/fabric8-ui/following{/other_user}","gists_url":"https://api.github.com/users/fabric8-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8-ui/subscriptions","organizations_url":"https://api.github.com/users/fabric8-ui/orgs","repos_url":"https://api.github.com/users/fabric8-ui/repos","events_url":"https://api.github.com/users/fabric8-ui/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":73824736,"node_id":"MDEwOlJlcG9zaXRvcnk3MzgyNDczNg==","name":"fabric8-ui","full_name":"fabric8-ui/fabric8-ui","owner":{"login":"fabric8-ui","id":25244298,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MjQ0Mjk4","avatar_url":"https://avatars2.githubusercontent.com/u/25244298?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8-ui","html_url":"https://github.com/fabric8-ui","followers_url":"https://api.github.com/users/fabric8-ui/followers","following_url":"https://api.github.com/users/fabric8-ui/following{/other_user}","gists_url":"https://api.github.com/users/fabric8-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8-ui/subscriptions","organizations_url":"https://api.github.com/users/fabric8-ui/orgs","repos_url":"https://api.github.com/users/fabric8-ui/repos","events_url":"https://api.github.com/users/fabric8-ui/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8-ui/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fabric8-ui/fabric8-ui","description":"The Angular frontend for fabric8 online (OpenShift.IO)","fork":false,"url":"https://api.github.com/repos/fabric8-ui/fabric8-ui","forks_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/forks","keys_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/teams","hooks_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/hooks","issue_events_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/issues/events{/number}","events_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/events","assignees_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/assignees{/user}","branches_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/branches{/branch}","tags_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/tags","blobs_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/languages","stargazers_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/stargazers","contributors_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/contributors","subscribers_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/subscribers","subscription_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/subscription","commits_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/contents/{+path}","compare_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/merges","archive_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/downloads","issues_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/issues{/number}","pulls_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/labels{/name}","releases_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/releases{/id}","deployments_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/deployments","created_at":"2016-11-15T15:04:11Z","updated_at":"2018-08-07T18:16:42Z","pushed_at":"2018-08-07T18:23:17Z","git_url":"git://github.com/fabric8-ui/fabric8-ui.git","ssh_url":"git@github.com:fabric8-ui/fabric8-ui.git","clone_url":"https://github.com/fabric8-ui/fabric8-ui.git","svn_url":"https://github.com/fabric8-ui/fabric8-ui","homepage":"https://openshift.io/","size":14821,"stargazers_count":22,"watchers_count":22,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":84,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":84,"open_issues":22,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fabric8-ui/fabric8-ui/pulls/3221"},"html":{"href":"https://github.com/fabric8-ui/fabric8-ui/pull/3221"},"issue":{"href":"https://api.github.com/repos/fabric8-ui/fabric8-ui/issues/3221"},"comments":{"href":"https://api.github.com/repos/fabric8-ui/fabric8-ui/issues/3221/comments"},"review_comments":{"href":"https://api.github.com/repos/fabric8-ui/fabric8-ui/pulls/3221/comments"},"review_comment":{"href":"https://api.github.com/repos/fabric8-ui/fabric8-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fabric8-ui/fabric8-ui/pulls/3221/commits"},"statuses":{"href":"https://api.github.com/repos/fabric8-ui/fabric8-ui/statuses/c16d0225dec7e7dec50ffc6c740b06aacb222ad7"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"joshuawilson"}}