{"action":"closed","number":100,"pull_request":{"url":"https://api.github.com/repos/github/pages-health-check/pulls/100","id":193586395,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNTg2Mzk1","html_url":"https://github.com/github/pages-health-check/pull/100","diff_url":"https://github.com/github/pages-health-check/pull/100.diff","patch_url":"https://github.com/github/pages-health-check/pull/100.patch","issue_url":"https://api.github.com/repos/github/pages-health-check/issues/100","number":100,"state":"closed","locked":false,"title":"Disable DNS Result Caching","user":{"login":"snh","id":2051768,"node_id":"MDQ6VXNlcjIwNTE3Njg=","avatar_url":"https://avatars1.githubusercontent.com/u/2051768?v=4","gravatar_id":"","url":"https://api.github.com/users/snh","html_url":"https://github.com/snh","followers_url":"https://api.github.com/users/snh/followers","following_url":"https://api.github.com/users/snh/following{/other_user}","gists_url":"https://api.github.com/users/snh/gists{/gist_id}","starred_url":"https://api.github.com/users/snh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snh/subscriptions","organizations_url":"https://api.github.com/users/snh/orgs","repos_url":"https://api.github.com/users/snh/repos","events_url":"https://api.github.com/users/snh/events{/privacy}","received_events_url":"https://api.github.com/users/snh/received_events","type":"User","site_admin":true},"body":"[Dnsruby](https://github.com/alexdalitz/dnsruby) by default appears to cache results internally, which prevents the redundant checking functionality as implemented in https://github.com/github/pages-health-check/pull/90 and https://github.com/github/pages-health-check/pull/98 from performing as expected.\r\n\r\nIn particular, the earlier cached entries from the default nameservers are returned when later trying the authoritative and public nameservers.\r\n\r\nThis PR disables this caching in Dnsruby.\r\n\r\nWhile rudimentary, I was able to test this was effective by performing the following two queries in `script/console`, spaced sufficiently apart to be able to determine by the returned TTLs that they were not sharing a local cached entry:\r\n\r\n```\r\nGitHubPages::HealthCheck::Domain.new(\"pages.github.com\", :nameservers => :default).dns\r\nGitHubPages::HealthCheck::Domain.new(\"pages.github.com\", :nameservers => :public).dns\r\n```\r\n\r\nWithout this fix, it is obvious that they are sharing the same cache entry, as the results from these two queries return TTLs that align perfectly.","created_at":"2018-06-08T11:30:10Z","updated_at":"2018-06-08T14:35:02Z","closed_at":"2018-06-08T14:35:02Z","merged_at":"2018-06-08T14:35:01Z","merge_commit_sha":"bdaa8b5331a9732f5891451145f2d777ab1d8a80","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":116699074,"node_id":"MDU6TGFiZWwxMTY2OTkwNzQ=","url":"https://api.github.com/repos/github/pages-health-check/labels/bug","name":"bug","color":"fc2929","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/github/pages-health-check/pulls/100/commits","review_comments_url":"https://api.github.com/repos/github/pages-health-check/pulls/100/comments","review_comment_url":"https://api.github.com/repos/github/pages-health-check/pulls/comments{/number}","comments_url":"https://api.github.com/repos/github/pages-health-check/issues/100/comments","statuses_url":"https://api.github.com/repos/github/pages-health-check/statuses/f3eb0b63c00c95836132a414f3d276e1fa01a223","head":{"label":"snh:disable-caching","ref":"disable-caching","sha":"f3eb0b63c00c95836132a414f3d276e1fa01a223","user":{"login":"snh","id":2051768,"node_id":"MDQ6VXNlcjIwNTE3Njg=","avatar_url":"https://avatars1.githubusercontent.com/u/2051768?v=4","gravatar_id":"","url":"https://api.github.com/users/snh","html_url":"https://github.com/snh","followers_url":"https://api.github.com/users/snh/followers","following_url":"https://api.github.com/users/snh/following{/other_user}","gists_url":"https://api.github.com/users/snh/gists{/gist_id}","starred_url":"https://api.github.com/users/snh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snh/subscriptions","organizations_url":"https://api.github.com/users/snh/orgs","repos_url":"https://api.github.com/users/snh/repos","events_url":"https://api.github.com/users/snh/events{/privacy}","received_events_url":"https://api.github.com/users/snh/received_events","type":"User","site_admin":true},"repo":{"id":136608691,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY2MDg2OTE=","name":"pages-health-check","full_name":"snh/pages-health-check","owner":{"login":"snh","id":2051768,"node_id":"MDQ6VXNlcjIwNTE3Njg=","avatar_url":"https://avatars1.githubusercontent.com/u/2051768?v=4","gravatar_id":"","url":"https://api.github.com/users/snh","html_url":"https://github.com/snh","followers_url":"https://api.github.com/users/snh/followers","following_url":"https://api.github.com/users/snh/following{/other_user}","gists_url":"https://api.github.com/users/snh/gists{/gist_id}","starred_url":"https://api.github.com/users/snh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snh/subscriptions","organizations_url":"https://api.github.com/users/snh/orgs","repos_url":"https://api.github.com/users/snh/repos","events_url":"https://api.github.com/users/snh/events{/privacy}","received_events_url":"https://api.github.com/users/snh/received_events","type":"User","site_admin":true},"private":false,"html_url":"https://github.com/snh/pages-health-check","description":"Checks your GitHub Pages site for common DNS configuration issues","fork":true,"url":"https://api.github.com/repos/snh/pages-health-check","forks_url":"https://api.github.com/repos/snh/pages-health-check/forks","keys_url":"https://api.github.com/repos/snh/pages-health-check/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snh/pages-health-check/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snh/pages-health-check/teams","hooks_url":"https://api.github.com/repos/snh/pages-health-check/hooks","issue_events_url":"https://api.github.com/repos/snh/pages-health-check/issues/events{/number}","events_url":"https://api.github.com/repos/snh/pages-health-check/events","assignees_url":"https://api.github.com/repos/snh/pages-health-check/assignees{/user}","branches_url":"https://api.github.com/repos/snh/pages-health-check/branches{/branch}","tags_url":"https://api.github.com/repos/snh/pages-health-check/tags","blobs_url":"https://api.github.com/repos/snh/pages-health-check/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snh/pages-health-check/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snh/pages-health-check/git/refs{/sha}","trees_url":"https://api.github.com/repos/snh/pages-health-check/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snh/pages-health-check/statuses/{sha}","languages_url":"https://api.github.com/repos/snh/pages-health-check/languages","stargazers_url":"https://api.github.com/repos/snh/pages-health-check/stargazers","contributors_url":"https://api.github.com/repos/snh/pages-health-check/contributors","subscribers_url":"https://api.github.com/repos/snh/pages-health-check/subscribers","subscription_url":"https://api.github.com/repos/snh/pages-health-check/subscription","commits_url":"https://api.github.com/repos/snh/pages-health-check/commits{/sha}","git_commits_url":"https://api.github.com/repos/snh/pages-health-check/git/commits{/sha}","comments_url":"https://api.github.com/repos/snh/pages-health-check/comments{/number}","issue_comment_url":"https://api.github.com/repos/snh/pages-health-check/issues/comments{/number}","contents_url":"https://api.github.com/repos/snh/pages-health-check/contents/{+path}","compare_url":"https://api.github.com/repos/snh/pages-health-check/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snh/pages-health-check/merges","archive_url":"https://api.github.com/repos/snh/pages-health-check/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snh/pages-health-check/downloads","issues_url":"https://api.github.com/repos/snh/pages-health-check/issues{/number}","pulls_url":"https://api.github.com/repos/snh/pages-health-check/pulls{/number}","milestones_url":"https://api.github.com/repos/snh/pages-health-check/milestones{/number}","notifications_url":"https://api.github.com/repos/snh/pages-health-check/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snh/pages-health-check/labels{/name}","releases_url":"https://api.github.com/repos/snh/pages-health-check/releases{/id}","deployments_url":"https://api.github.com/repos/snh/pages-health-check/deployments","created_at":"2018-06-08T11:12:48Z","updated_at":"2018-06-08T11:12:50Z","pushed_at":"2018-06-08T13:59:02Z","git_url":"git://github.com/snh/pages-health-check.git","ssh_url":"git@github.com:snh/pages-health-check.git","clone_url":"https://github.com/snh/pages-health-check.git","svn_url":"https://github.com/snh/pages-health-check","homepage":"","size":2686,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"github:master","ref":"master","sha":"dc6bcc727f728e64ef57c95d87f5b326a8dad086","user":{"login":"github","id":9919,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/9919?v=4","gravatar_id":"","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"repo":{"id":22222472,"node_id":"MDEwOlJlcG9zaXRvcnkyMjIyMjQ3Mg==","name":"pages-health-check","full_name":"github/pages-health-check","owner":{"login":"github","id":9919,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/9919?v=4","gravatar_id":"","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/github/pages-health-check","description":"Checks your GitHub Pages site for common DNS configuration issues","fork":false,"url":"https://api.github.com/repos/github/pages-health-check","forks_url":"https://api.github.com/repos/github/pages-health-check/forks","keys_url":"https://api.github.com/repos/github/pages-health-check/keys{/key_id}","collaborators_url":"https://api.github.com/repos/github/pages-health-check/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/github/pages-health-check/teams","hooks_url":"https://api.github.com/repos/github/pages-health-check/hooks","issue_events_url":"https://api.github.com/repos/github/pages-health-check/issues/events{/number}","events_url":"https://api.github.com/repos/github/pages-health-check/events","assignees_url":"https://api.github.com/repos/github/pages-health-check/assignees{/user}","branches_url":"https://api.github.com/repos/github/pages-health-check/branches{/branch}","tags_url":"https://api.github.com/repos/github/pages-health-check/tags","blobs_url":"https://api.github.com/repos/github/pages-health-check/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/github/pages-health-check/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/github/pages-health-check/git/refs{/sha}","trees_url":"https://api.github.com/repos/github/pages-health-check/git/trees{/sha}","statuses_url":"https://api.github.com/repos/github/pages-health-check/statuses/{sha}","languages_url":"https://api.github.com/repos/github/pages-health-check/languages","stargazers_url":"https://api.github.com/repos/github/pages-health-check/stargazers","contributors_url":"https://api.github.com/repos/github/pages-health-check/contributors","subscribers_url":"https://api.github.com/repos/github/pages-health-check/subscribers","subscription_url":"https://api.github.com/repos/github/pages-health-check/subscription","commits_url":"https://api.github.com/repos/github/pages-health-check/commits{/sha}","git_commits_url":"https://api.github.com/repos/github/pages-health-check/git/commits{/sha}","comments_url":"https://api.github.com/repos/github/pages-health-check/comments{/number}","issue_comment_url":"https://api.github.com/repos/github/pages-health-check/issues/comments{/number}","contents_url":"https://api.github.com/repos/github/pages-health-check/contents/{+path}","compare_url":"https://api.github.com/repos/github/pages-health-check/compare/{base}...{head}","merges_url":"https://api.github.com/repos/github/pages-health-check/merges","archive_url":"https://api.github.com/repos/github/pages-health-check/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/github/pages-health-check/downloads","issues_url":"https://api.github.com/repos/github/pages-health-check/issues{/number}","pulls_url":"https://api.github.com/repos/github/pages-health-check/pulls{/number}","milestones_url":"https://api.github.com/repos/github/pages-health-check/milestones{/number}","notifications_url":"https://api.github.com/repos/github/pages-health-check/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/github/pages-health-check/labels{/name}","releases_url":"https://api.github.com/repos/github/pages-health-check/releases{/id}","deployments_url":"https://api.github.com/repos/github/pages-health-check/deployments","created_at":"2014-07-24T17:17:54Z","updated_at":"2018-06-08T13:24:01Z","pushed_at":"2018-06-08T14:35:02Z","git_url":"git://github.com/github/pages-health-check.git","ssh_url":"git@github.com:github/pages-health-check.git","clone_url":"https://github.com/github/pages-health-check.git","svn_url":"https://github.com/github/pages-health-check","homepage":"","size":2684,"stargazers_count":55,"watchers_count":55,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":27,"open_issues":2,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/github/pages-health-check/pulls/100"},"html":{"href":"https://github.com/github/pages-health-check/pull/100"},"issue":{"href":"https://api.github.com/repos/github/pages-health-check/issues/100"},"comments":{"href":"https://api.github.com/repos/github/pages-health-check/issues/100/comments"},"review_comments":{"href":"https://api.github.com/repos/github/pages-health-check/pulls/100/comments"},"review_comment":{"href":"https://api.github.com/repos/github/pages-health-check/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/github/pages-health-check/pulls/100/commits"},"statuses":{"href":"https://api.github.com/repos/github/pages-health-check/statuses/f3eb0b63c00c95836132a414f3d276e1fa01a223"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"parkr","id":237985,"node_id":"MDQ6VXNlcjIzNzk4NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/237985?v=4","gravatar_id":"","url":"https://api.github.com/users/parkr","html_url":"https://github.com/parkr","followers_url":"https://api.github.com/users/parkr/followers","following_url":"https://api.github.com/users/parkr/following{/other_user}","gists_url":"https://api.github.com/users/parkr/gists{/gist_id}","starred_url":"https://api.github.com/users/parkr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parkr/subscriptions","organizations_url":"https://api.github.com/users/parkr/orgs","repos_url":"https://api.github.com/users/parkr/repos","events_url":"https://api.github.com/users/parkr/events{/privacy}","received_events_url":"https://api.github.com/users/parkr/received_events","type":"User","site_admin":true},"comments":2,"review_comments":1,"maintainer_can_modify":false,"commits":2,"additions":2,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"parkr"}}