{"action":"created","comment":{"url":"https://api.github.com/repos/helm/charts/pulls/comments/204064607","pull_request_review_id":139082188,"id":204064607,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDA2NDYwNw==","diff_hunk":"@@ -21,12 +31,18 @@ metadata:\n     heritage: {{ $root.Release.Service }}\n     pod: {{ $responsiblePod | quote }}\n spec:\n-  type: NodePort\n+  type: {{ $root.Values.external.type }}\n   ports:\n     - name: external-broker\n+      {{- if eq $root.Values.external.type \"LoadBalancer\" }}","path":"incubator/kafka/templates/service-brokers-external.yaml","position":38,"original_position":38,"commit_id":"7a0d2b2c471fdfbaf2e3886ead78ee8cbbc7188e","original_commit_id":"7a0d2b2c471fdfbaf2e3886ead78ee8cbbc7188e","user":{"login":"benjigoldberg","id":6841489,"node_id":"MDQ6VXNlcjY4NDE0ODk=","avatar_url":"https://avatars1.githubusercontent.com/u/6841489?v=4","gravatar_id":"","url":"https://api.github.com/users/benjigoldberg","html_url":"https://github.com/benjigoldberg","followers_url":"https://api.github.com/users/benjigoldberg/followers","following_url":"https://api.github.com/users/benjigoldberg/following{/other_user}","gists_url":"https://api.github.com/users/benjigoldberg/gists{/gist_id}","starred_url":"https://api.github.com/users/benjigoldberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjigoldberg/subscriptions","organizations_url":"https://api.github.com/users/benjigoldberg/orgs","repos_url":"https://api.github.com/users/benjigoldberg/repos","events_url":"https://api.github.com/users/benjigoldberg/events{/privacy}","received_events_url":"https://api.github.com/users/benjigoldberg/received_events","type":"User","site_admin":false},"body":"make spacing consistent on this block of `if/else/end`","created_at":"2018-07-20T14:33:40Z","updated_at":"2018-07-20T14:36:15Z","html_url":"https://github.com/helm/charts/pull/6740#discussion_r204064607","pull_request_url":"https://api.github.com/repos/helm/charts/pulls/6740","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/helm/charts/pulls/comments/204064607"},"html":{"href":"https://github.com/helm/charts/pull/6740#discussion_r204064607"},"pull_request":{"href":"https://api.github.com/repos/helm/charts/pulls/6740"}}},"pull_request":{"url":"https://api.github.com/repos/helm/charts/pulls/6740","id":202856610,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyODU2NjEw","html_url":"https://github.com/helm/charts/pull/6740","diff_url":"https://github.com/helm/charts/pull/6740.diff","patch_url":"https://github.com/helm/charts/pull/6740.patch","issue_url":"https://api.github.com/repos/helm/charts/issues/6740","number":6740,"state":"open","locked":false,"title":"incubator/kafka support for additional clouds","user":{"login":"drekle","id":1883554,"node_id":"MDQ6VXNlcjE4ODM1NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1883554?v=4","gravatar_id":"","url":"https://api.github.com/users/drekle","html_url":"https://github.com/drekle","followers_url":"https://api.github.com/users/drekle/followers","following_url":"https://api.github.com/users/drekle/following{/other_user}","gists_url":"https://api.github.com/users/drekle/gists{/gist_id}","starred_url":"https://api.github.com/users/drekle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drekle/subscriptions","organizations_url":"https://api.github.com/users/drekle/orgs","repos_url":"https://api.github.com/users/drekle/repos","events_url":"https://api.github.com/users/drekle/events{/privacy}","received_events_url":"https://api.github.com/users/drekle/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\nexternal-service-brokers currently only supports kops deployments in aws\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #\r\nfixes https://github.com/helm/charts/issues/6739\r\n\r\n**Special notes for your reviewer**:\r\nI have added the ability to make the annotation for external-dns distinct for each statefulset service.  This seems required as I am using LoadBalancer, which will create 3 load balancers in for example openstack.  If these shared the same DNS A record external DNS happens to not append and update it only to the last one, which is coupled to a single port in openstack.  Even if it did append load balancers it would happen to round robin between them.  A separate lookup for each loadbalancer allows me to reference the openstack loadbalancer which is coupled to the service port.","created_at":"2018-07-20T13:55:21Z","updated_at":"2018-07-20T14:36:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aee795be3ff83db1658c226a3200e94440961c4e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"prydonius","id":1544861,"node_id":"MDQ6VXNlcjE1NDQ4NjE=","avatar_url":"https://avatars3.githubusercontent.com/u/1544861?v=4","gravatar_id":"","url":"https://api.github.com/users/prydonius","html_url":"https://github.com/prydonius","followers_url":"https://api.github.com/users/prydonius/followers","following_url":"https://api.github.com/users/prydonius/following{/other_user}","gists_url":"https://api.github.com/users/prydonius/gists{/gist_id}","starred_url":"https://api.github.com/users/prydonius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prydonius/subscriptions","organizations_url":"https://api.github.com/users/prydonius/orgs","repos_url":"https://api.github.com/users/prydonius/repos","events_url":"https://api.github.com/users/prydonius/events{/privacy}","received_events_url":"https://api.github.com/users/prydonius/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":582594847,"node_id":"MDU6TGFiZWw1ODI1OTQ4NDc=","url":"https://api.github.com/repos/helm/charts/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/helm/charts/pulls/6740/commits","review_comments_url":"https://api.github.com/repos/helm/charts/pulls/6740/comments","review_comment_url":"https://api.github.com/repos/helm/charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/helm/charts/issues/6740/comments","statuses_url":"https://api.github.com/repos/helm/charts/statuses/7a0d2b2c471fdfbaf2e3886ead78ee8cbbc7188e","head":{"label":"drekle:kafka_openstack_support","ref":"kafka_openstack_support","sha":"7a0d2b2c471fdfbaf2e3886ead78ee8cbbc7188e","user":{"login":"drekle","id":1883554,"node_id":"MDQ6VXNlcjE4ODM1NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1883554?v=4","gravatar_id":"","url":"https://api.github.com/users/drekle","html_url":"https://github.com/drekle","followers_url":"https://api.github.com/users/drekle/followers","following_url":"https://api.github.com/users/drekle/following{/other_user}","gists_url":"https://api.github.com/users/drekle/gists{/gist_id}","starred_url":"https://api.github.com/users/drekle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drekle/subscriptions","organizations_url":"https://api.github.com/users/drekle/orgs","repos_url":"https://api.github.com/users/drekle/repos","events_url":"https://api.github.com/users/drekle/events{/privacy}","received_events_url":"https://api.github.com/users/drekle/received_events","type":"User","site_admin":false},"repo":{"id":141466930,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE0NjY5MzA=","name":"charts","full_name":"drekle/charts","owner":{"login":"drekle","id":1883554,"node_id":"MDQ6VXNlcjE4ODM1NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1883554?v=4","gravatar_id":"","url":"https://api.github.com/users/drekle","html_url":"https://github.com/drekle","followers_url":"https://api.github.com/users/drekle/followers","following_url":"https://api.github.com/users/drekle/following{/other_user}","gists_url":"https://api.github.com/users/drekle/gists{/gist_id}","starred_url":"https://api.github.com/users/drekle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drekle/subscriptions","organizations_url":"https://api.github.com/users/drekle/orgs","repos_url":"https://api.github.com/users/drekle/repos","events_url":"https://api.github.com/users/drekle/events{/privacy}","received_events_url":"https://api.github.com/users/drekle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drekle/charts","description":"Curated applications for Kubernetes","fork":true,"url":"https://api.github.com/repos/drekle/charts","forks_url":"https://api.github.com/repos/drekle/charts/forks","keys_url":"https://api.github.com/repos/drekle/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drekle/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drekle/charts/teams","hooks_url":"https://api.github.com/repos/drekle/charts/hooks","issue_events_url":"https://api.github.com/repos/drekle/charts/issues/events{/number}","events_url":"https://api.github.com/repos/drekle/charts/events","assignees_url":"https://api.github.com/repos/drekle/charts/assignees{/user}","branches_url":"https://api.github.com/repos/drekle/charts/branches{/branch}","tags_url":"https://api.github.com/repos/drekle/charts/tags","blobs_url":"https://api.github.com/repos/drekle/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drekle/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drekle/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/drekle/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drekle/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/drekle/charts/languages","stargazers_url":"https://api.github.com/repos/drekle/charts/stargazers","contributors_url":"https://api.github.com/repos/drekle/charts/contributors","subscribers_url":"https://api.github.com/repos/drekle/charts/subscribers","subscription_url":"https://api.github.com/repos/drekle/charts/subscription","commits_url":"https://api.github.com/repos/drekle/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/drekle/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/drekle/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/drekle/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/drekle/charts/contents/{+path}","compare_url":"https://api.github.com/repos/drekle/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drekle/charts/merges","archive_url":"https://api.github.com/repos/drekle/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drekle/charts/downloads","issues_url":"https://api.github.com/repos/drekle/charts/issues{/number}","pulls_url":"https://api.github.com/repos/drekle/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/drekle/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/drekle/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drekle/charts/labels{/name}","releases_url":"https://api.github.com/repos/drekle/charts/releases{/id}","deployments_url":"https://api.github.com/repos/drekle/charts/deployments","created_at":"2018-07-18T17:18:59Z","updated_at":"2018-07-19T19:52:49Z","pushed_at":"2018-07-20T12:53:03Z","git_url":"git://github.com/drekle/charts.git","ssh_url":"git@github.com:drekle/charts.git","clone_url":"https://github.com/drekle/charts.git","svn_url":"https://github.com/drekle/charts","homepage":"","size":9064,"stargazers_count":0,"watchers_count":0,"language":"Smarty","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"helm:master","ref":"master","sha":"c90a85480c6ead54d2d451c26c67c3aecdeecb7b","user":{"login":"helm","id":15859888,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODU5ODg4","avatar_url":"https://avatars2.githubusercontent.com/u/15859888?v=4","gravatar_id":"","url":"https://api.github.com/users/helm","html_url":"https://github.com/helm","followers_url":"https://api.github.com/users/helm/followers","following_url":"https://api.github.com/users/helm/following{/other_user}","gists_url":"https://api.github.com/users/helm/gists{/gist_id}","starred_url":"https://api.github.com/users/helm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helm/subscriptions","organizations_url":"https://api.github.com/users/helm/orgs","repos_url":"https://api.github.com/users/helm/repos","events_url":"https://api.github.com/users/helm/events{/privacy}","received_events_url":"https://api.github.com/users/helm/received_events","type":"Organization","site_admin":false},"repo":{"id":46806184,"node_id":"MDEwOlJlcG9zaXRvcnk0NjgwNjE4NA==","name":"charts","full_name":"helm/charts","owner":{"login":"helm","id":15859888,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODU5ODg4","avatar_url":"https://avatars2.githubusercontent.com/u/15859888?v=4","gravatar_id":"","url":"https://api.github.com/users/helm","html_url":"https://github.com/helm","followers_url":"https://api.github.com/users/helm/followers","following_url":"https://api.github.com/users/helm/following{/other_user}","gists_url":"https://api.github.com/users/helm/gists{/gist_id}","starred_url":"https://api.github.com/users/helm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helm/subscriptions","organizations_url":"https://api.github.com/users/helm/orgs","repos_url":"https://api.github.com/users/helm/repos","events_url":"https://api.github.com/users/helm/events{/privacy}","received_events_url":"https://api.github.com/users/helm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/helm/charts","description":"Curated applications for Kubernetes","fork":false,"url":"https://api.github.com/repos/helm/charts","forks_url":"https://api.github.com/repos/helm/charts/forks","keys_url":"https://api.github.com/repos/helm/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/helm/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/helm/charts/teams","hooks_url":"https://api.github.com/repos/helm/charts/hooks","issue_events_url":"https://api.github.com/repos/helm/charts/issues/events{/number}","events_url":"https://api.github.com/repos/helm/charts/events","assignees_url":"https://api.github.com/repos/helm/charts/assignees{/user}","branches_url":"https://api.github.com/repos/helm/charts/branches{/branch}","tags_url":"https://api.github.com/repos/helm/charts/tags","blobs_url":"https://api.github.com/repos/helm/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/helm/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/helm/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/helm/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/helm/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/helm/charts/languages","stargazers_url":"https://api.github.com/repos/helm/charts/stargazers","contributors_url":"https://api.github.com/repos/helm/charts/contributors","subscribers_url":"https://api.github.com/repos/helm/charts/subscribers","subscription_url":"https://api.github.com/repos/helm/charts/subscription","commits_url":"https://api.github.com/repos/helm/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/helm/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/helm/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/helm/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/helm/charts/contents/{+path}","compare_url":"https://api.github.com/repos/helm/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/helm/charts/merges","archive_url":"https://api.github.com/repos/helm/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/helm/charts/downloads","issues_url":"https://api.github.com/repos/helm/charts/issues{/number}","pulls_url":"https://api.github.com/repos/helm/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/helm/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/helm/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/helm/charts/labels{/name}","releases_url":"https://api.github.com/repos/helm/charts/releases{/id}","deployments_url":"https://api.github.com/repos/helm/charts/deployments","created_at":"2015-11-24T17:05:28Z","updated_at":"2018-07-20T13:47:30Z","pushed_at":"2018-07-20T14:27:10Z","git_url":"git://github.com/helm/charts.git","ssh_url":"git@github.com:helm/charts.git","clone_url":"https://github.com/helm/charts.git","svn_url":"https://github.com/helm/charts","homepage":"","size":9111,"stargazers_count":3881,"watchers_count":3881,"language":"Smarty","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3414,"mirror_url":null,"archived":false,"open_issues_count":817,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3414,"open_issues":817,"watchers":3881,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/helm/charts/pulls/6740"},"html":{"href":"https://github.com/helm/charts/pull/6740"},"issue":{"href":"https://api.github.com/repos/helm/charts/issues/6740"},"comments":{"href":"https://api.github.com/repos/helm/charts/issues/6740/comments"},"review_comments":{"href":"https://api.github.com/repos/helm/charts/pulls/6740/comments"},"review_comment":{"href":"https://api.github.com/repos/helm/charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/helm/charts/pulls/6740/commits"},"statuses":{"href":"https://api.github.com/repos/helm/charts/statuses/7a0d2b2c471fdfbaf2e3886ead78ee8cbbc7188e"}},"author_association":"NONE"}}
{"actor":{"display_login":"benjigoldberg"}}