{"action":"closed","issue":{"url":"https://api.github.com/repos/LiskHQ/lisk/issues/1752","repository_url":"https://api.github.com/repos/LiskHQ/lisk","labels_url":"https://api.github.com/repos/LiskHQ/lisk/issues/1752/labels{/name}","comments_url":"https://api.github.com/repos/LiskHQ/lisk/issues/1752/comments","events_url":"https://api.github.com/repos/LiskHQ/lisk/issues/1752/events","html_url":"https://github.com/LiskHQ/lisk/issues/1752","id":306379100,"number":1752,"title":"Nonce is not propagated correctly in PeersManager mappings","user":{"login":"MaciejBaj","id":6909553,"avatar_url":"https://avatars1.githubusercontent.com/u/6909553?v=4","gravatar_id":"","url":"https://api.github.com/users/MaciejBaj","html_url":"https://github.com/MaciejBaj","followers_url":"https://api.github.com/users/MaciejBaj/followers","following_url":"https://api.github.com/users/MaciejBaj/following{/other_user}","gists_url":"https://api.github.com/users/MaciejBaj/gists{/gist_id}","starred_url":"https://api.github.com/users/MaciejBaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaciejBaj/subscriptions","organizations_url":"https://api.github.com/users/MaciejBaj/orgs","repos_url":"https://api.github.com/users/MaciejBaj/repos","events_url":"https://api.github.com/users/MaciejBaj/events{/privacy}","received_events_url":"https://api.github.com/users/MaciejBaj/received_events","type":"User","site_admin":false},"labels":[{"id":452738624,"url":"https://api.github.com/repos/LiskHQ/lisk/labels/*medium","name":"*medium","color":"fef2c0","default":false},{"id":320049956,"url":"https://api.github.com/repos/LiskHQ/lisk/labels/bug","name":"bug","color":"fc2929","default":true},{"id":823533465,"url":"https://api.github.com/repos/LiskHQ/lisk/labels/transport","name":"transport","color":"db4ca7","default":false}],"state":"closed","locked":false,"assignee":{"login":"MaciejBaj","id":6909553,"avatar_url":"https://avatars1.githubusercontent.com/u/6909553?v=4","gravatar_id":"","url":"https://api.github.com/users/MaciejBaj","html_url":"https://github.com/MaciejBaj","followers_url":"https://api.github.com/users/MaciejBaj/followers","following_url":"https://api.github.com/users/MaciejBaj/following{/other_user}","gists_url":"https://api.github.com/users/MaciejBaj/gists{/gist_id}","starred_url":"https://api.github.com/users/MaciejBaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaciejBaj/subscriptions","organizations_url":"https://api.github.com/users/MaciejBaj/orgs","repos_url":"https://api.github.com/users/MaciejBaj/repos","events_url":"https://api.github.com/users/MaciejBaj/events{/privacy}","received_events_url":"https://api.github.com/users/MaciejBaj/received_events","type":"User","site_admin":false},"assignees":[{"login":"MaciejBaj","id":6909553,"avatar_url":"https://avatars1.githubusercontent.com/u/6909553?v=4","gravatar_id":"","url":"https://api.github.com/users/MaciejBaj","html_url":"https://github.com/MaciejBaj","followers_url":"https://api.github.com/users/MaciejBaj/followers","following_url":"https://api.github.com/users/MaciejBaj/following{/other_user}","gists_url":"https://api.github.com/users/MaciejBaj/gists{/gist_id}","starred_url":"https://api.github.com/users/MaciejBaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaciejBaj/subscriptions","organizations_url":"https://api.github.com/users/MaciejBaj/orgs","repos_url":"https://api.github.com/users/MaciejBaj/repos","events_url":"https://api.github.com/users/MaciejBaj/events{/privacy}","received_events_url":"https://api.github.com/users/MaciejBaj/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/LiskHQ/lisk/milestones/12","html_url":"https://github.com/LiskHQ/lisk/milestone/12","labels_url":"https://api.github.com/repos/LiskHQ/lisk/milestones/12/labels","id":3203019,"number":12,"title":"Version 1.0.0-alpha.2","description":"","creator":{"login":"MaciejBaj","id":6909553,"avatar_url":"https://avatars1.githubusercontent.com/u/6909553?v=4","gravatar_id":"","url":"https://api.github.com/users/MaciejBaj","html_url":"https://github.com/MaciejBaj","followers_url":"https://api.github.com/users/MaciejBaj/followers","following_url":"https://api.github.com/users/MaciejBaj/following{/other_user}","gists_url":"https://api.github.com/users/MaciejBaj/gists{/gist_id}","starred_url":"https://api.github.com/users/MaciejBaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaciejBaj/subscriptions","organizations_url":"https://api.github.com/users/MaciejBaj/orgs","repos_url":"https://api.github.com/users/MaciejBaj/repos","events_url":"https://api.github.com/users/MaciejBaj/events{/privacy}","received_events_url":"https://api.github.com/users/MaciejBaj/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":3,"state":"open","created_at":"2018-03-20T12:59:41Z","updated_at":"2018-03-22T14:40:32Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-03-19T09:02:01Z","updated_at":"2018-03-22T14:40:32Z","closed_at":"2018-03-22T14:40:32Z","author_association":"MEMBER","body":"### Expected behavior\r\nWhile adding a node's data (`PeersManager.add`) a peer's nonce is always reflected in mappings - `addressToNonceMap`, `nonceToAddressMap`.\r\n### Actual behavior\r\nWhile adding a node's data (`PeersManager.add`) a peer can get added with `undefined` nonce, which results with `INVALID_PEER` error while updating its data.\r\n### Steps to reproduce\r\nRun integration tests to see `INVALID_PEER` error popping out occasionally.\r\n### Which version(s) does this affect? (Environment, OS, etc...)\r\n1.0.0"}}
{"actor":{"display_login":"MaciejBaj"}}