{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/171509748","pull_request_review_id":100371342,"id":171509748,"diff_hunk":"@@ -0,0 +1,356 @@\n+#include \"mbedtls/md2.h\"","path":"features/mbedtls/targets/hash_wrappers.c","position":1,"original_position":1,"commit_id":"6370a3500d5fa09245ce1c823a236b7acce4ead3","original_commit_id":"9d5d60b62e1dd8f7086223a4d9ac528627bc93f4","user":{"login":"LiyouZhou","id":2660805,"avatar_url":"https://avatars0.githubusercontent.com/u/2660805?v=4","gravatar_id":"","url":"https://api.github.com/users/LiyouZhou","html_url":"https://github.com/LiyouZhou","followers_url":"https://api.github.com/users/LiyouZhou/followers","following_url":"https://api.github.com/users/LiyouZhou/following{/other_user}","gists_url":"https://api.github.com/users/LiyouZhou/gists{/gist_id}","starred_url":"https://api.github.com/users/LiyouZhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiyouZhou/subscriptions","organizations_url":"https://api.github.com/users/LiyouZhou/orgs","repos_url":"https://api.github.com/users/LiyouZhou/repos","events_url":"https://api.github.com/users/LiyouZhou/events{/privacy}","received_events_url":"https://api.github.com/users/LiyouZhou/received_events","type":"User","site_admin":false},"body":"So in my case the problem is when customer do their own implementation they only port the new API but not the old. That mean all old API will be broken on that particular platform. I think it is a requirement the old API not be broken all of a sudden.","created_at":"2018-03-01T09:58:46Z","updated_at":"2018-03-01T09:58:46Z","html_url":"https://github.com/ARMmbed/mbed-os/pull/6210#discussion_r171509748","pull_request_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6210","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/171509748"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/6210#discussion_r171509748"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6210"}},"in_reply_to_id":171249294},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6210","id":171362105,"html_url":"https://github.com/ARMmbed/mbed-os/pull/6210","diff_url":"https://github.com/ARMmbed/mbed-os/pull/6210.diff","patch_url":"https://github.com/ARMmbed/mbed-os/pull/6210.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/6210","number":6210,"state":"open","locked":false,"title":"Update Mbed TLS to version 2.7.1","user":{"login":"k-stachowiak","id":2103379,"avatar_url":"https://avatars3.githubusercontent.com/u/2103379?v=4","gravatar_id":"","url":"https://api.github.com/users/k-stachowiak","html_url":"https://github.com/k-stachowiak","followers_url":"https://api.github.com/users/k-stachowiak/followers","following_url":"https://api.github.com/users/k-stachowiak/following{/other_user}","gists_url":"https://api.github.com/users/k-stachowiak/gists{/gist_id}","starred_url":"https://api.github.com/users/k-stachowiak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k-stachowiak/subscriptions","organizations_url":"https://api.github.com/users/k-stachowiak/orgs","repos_url":"https://api.github.com/users/k-stachowiak/repos","events_url":"https://api.github.com/users/k-stachowiak/events{/privacy}","received_events_url":"https://api.github.com/users/k-stachowiak/received_events","type":"User","site_admin":false},"body":"Test PR to verify (using CI) the MD API/ABI issues have been resolved. Unlike #6183 this PR is based on the Mbed TLS tree tagged as 2.7.1 rather than on a hot fix.","created_at":"2018-02-26T12:33:48Z","updated_at":"2018-03-01T09:58:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b668463ce51f9de90392c8b8a3e4fc30ed5632d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":147112891,"url":"https://api.github.com/repos/ARMmbed/mbed-os/labels/needs:%20review","name":"needs: review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6210/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6210/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/6210/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/6370a3500d5fa09245ce1c823a236b7acce4ead3","head":{"label":"k-stachowiak:mbed-tls-2.7.1-update","ref":"mbed-tls-2.7.1-update","sha":"6370a3500d5fa09245ce1c823a236b7acce4ead3","user":{"login":"k-stachowiak","id":2103379,"avatar_url":"https://avatars3.githubusercontent.com/u/2103379?v=4","gravatar_id":"","url":"https://api.github.com/users/k-stachowiak","html_url":"https://github.com/k-stachowiak","followers_url":"https://api.github.com/users/k-stachowiak/followers","following_url":"https://api.github.com/users/k-stachowiak/following{/other_user}","gists_url":"https://api.github.com/users/k-stachowiak/gists{/gist_id}","starred_url":"https://api.github.com/users/k-stachowiak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k-stachowiak/subscriptions","organizations_url":"https://api.github.com/users/k-stachowiak/orgs","repos_url":"https://api.github.com/users/k-stachowiak/repos","events_url":"https://api.github.com/users/k-stachowiak/events{/privacy}","received_events_url":"https://api.github.com/users/k-stachowiak/received_events","type":"User","site_admin":false},"repo":{"id":105033640,"name":"mbed-os","full_name":"k-stachowiak/mbed-os","owner":{"login":"k-stachowiak","id":2103379,"avatar_url":"https://avatars3.githubusercontent.com/u/2103379?v=4","gravatar_id":"","url":"https://api.github.com/users/k-stachowiak","html_url":"https://github.com/k-stachowiak","followers_url":"https://api.github.com/users/k-stachowiak/followers","following_url":"https://api.github.com/users/k-stachowiak/following{/other_user}","gists_url":"https://api.github.com/users/k-stachowiak/gists{/gist_id}","starred_url":"https://api.github.com/users/k-stachowiak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k-stachowiak/subscriptions","organizations_url":"https://api.github.com/users/k-stachowiak/orgs","repos_url":"https://api.github.com/users/k-stachowiak/repos","events_url":"https://api.github.com/users/k-stachowiak/events{/privacy}","received_events_url":"https://api.github.com/users/k-stachowiak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/k-stachowiak/mbed-os","description":"ARM mbed OS is a platform operating system designed for the internet of things","fork":true,"url":"https://api.github.com/repos/k-stachowiak/mbed-os","forks_url":"https://api.github.com/repos/k-stachowiak/mbed-os/forks","keys_url":"https://api.github.com/repos/k-stachowiak/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/k-stachowiak/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/k-stachowiak/mbed-os/teams","hooks_url":"https://api.github.com/repos/k-stachowiak/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/k-stachowiak/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/k-stachowiak/mbed-os/events","assignees_url":"https://api.github.com/repos/k-stachowiak/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/k-stachowiak/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/k-stachowiak/mbed-os/tags","blobs_url":"https://api.github.com/repos/k-stachowiak/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/k-stachowiak/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/k-stachowiak/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/k-stachowiak/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/k-stachowiak/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/k-stachowiak/mbed-os/languages","stargazers_url":"https://api.github.com/repos/k-stachowiak/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/k-stachowiak/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/k-stachowiak/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/k-stachowiak/mbed-os/subscription","commits_url":"https://api.github.com/repos/k-stachowiak/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/k-stachowiak/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/k-stachowiak/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/k-stachowiak/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/k-stachowiak/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/k-stachowiak/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/k-stachowiak/mbed-os/merges","archive_url":"https://api.github.com/repos/k-stachowiak/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/k-stachowiak/mbed-os/downloads","issues_url":"https://api.github.com/repos/k-stachowiak/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/k-stachowiak/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/k-stachowiak/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/k-stachowiak/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/k-stachowiak/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/k-stachowiak/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/k-stachowiak/mbed-os/deployments","created_at":"2017-09-27T15:10:18Z","updated_at":"2017-09-27T15:13:24Z","pushed_at":"2018-02-28T16:03:54Z","git_url":"git://github.com/k-stachowiak/mbed-os.git","ssh_url":"git@github.com:k-stachowiak/mbed-os.git","clone_url":"https://github.com/k-stachowiak/mbed-os.git","svn_url":"https://github.com/k-stachowiak/mbed-os","homepage":"https://mbed.com","size":193794,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARMmbed:master","ref":"master","sha":"8b6a7aacc5d2b90ba40d89c8eeb680ebee81ea18","user":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":8270972,"name":"mbed-os","full_name":"ARMmbed/mbed-os","owner":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/mbed-os","description":"ARM Mbed OS is a platform operating system designed for the internet of things","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbed-os","forks_url":"https://api.github.com/repos/ARMmbed/mbed-os/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbed-os/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbed-os/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbed-os/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbed-os/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbed-os/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbed-os/deployments","created_at":"2013-02-18T15:23:11Z","updated_at":"2018-03-01T01:29:20Z","pushed_at":"2018-03-01T07:59:12Z","git_url":"git://github.com/ARMmbed/mbed-os.git","ssh_url":"git@github.com:ARMmbed/mbed-os.git","clone_url":"https://github.com/ARMmbed/mbed-os.git","svn_url":"https://github.com/ARMmbed/mbed-os","homepage":"https://mbed.com","size":196216,"stargazers_count":1516,"watchers_count":1516,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1345,"mirror_url":null,"archived":false,"open_issues_count":390,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1345,"open_issues":390,"watchers":1516,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6210"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/6210"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/6210"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/6210/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6210/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6210/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/6370a3500d5fa09245ce1c823a236b7acce4ead3"}},"author_association":"NONE"}}
{"actor":{"display_login":"LiyouZhou"}}