{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/docs/issues/9201","repository_url":"https://api.github.com/repos/dotnet/docs","labels_url":"https://api.github.com/repos/dotnet/docs/issues/9201/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/docs/issues/9201/comments","events_url":"https://api.github.com/repos/dotnet/docs/issues/9201/events","html_url":"https://github.com/dotnet/docs/issues/9201","id":383925307,"node_id":"MDU6SXNzdWUzODM5MjUzMDc=","number":9201,"title":"Ordinal String Operations vs Current Culture","user":{"login":"mikernet","id":1700111,"node_id":"MDQ6VXNlcjE3MDAxMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1700111?v=4","gravatar_id":"","url":"https://api.github.com/users/mikernet","html_url":"https://github.com/mikernet","followers_url":"https://api.github.com/users/mikernet/followers","following_url":"https://api.github.com/users/mikernet/following{/other_user}","gists_url":"https://api.github.com/users/mikernet/gists{/gist_id}","starred_url":"https://api.github.com/users/mikernet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikernet/subscriptions","organizations_url":"https://api.github.com/users/mikernet/orgs","repos_url":"https://api.github.com/users/mikernet/repos","events_url":"https://api.github.com/users/mikernet/events{/privacy}","received_events_url":"https://api.github.com/users/mikernet/received_events","type":"User","site_admin":false},"labels":[{"id":429768030,"node_id":"MDU6TGFiZWw0Mjk3NjgwMzA=","url":"https://api.github.com/repos/dotnet/docs/labels/:books:%20Area%20-%20C%23%20Guide","name":":books: Area - C# Guide","color":"3d5c8e","default":false},{"id":1062818885,"node_id":"MDU6TGFiZWwxMDYyODE4ODg1","url":"https://api.github.com/repos/dotnet/docs/labels/:watch:%20Not%20Triaged","name":":watch: Not Triaged","color":"f78fb2","default":false},{"id":918775588,"node_id":"MDU6TGFiZWw5MTg3NzU1ODg=","url":"https://api.github.com/repos/dotnet/docs/labels/Source%20-%20Docs.ms","name":"Source - Docs.ms","color":"77f966","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-23T20:55:35Z","updated_at":"2018-12-04T22:05:18Z","closed_at":null,"author_association":"NONE","body":"The section titled \"Default ordinal comparisons\" makes no sense - it states:\r\n\r\n> The most common operations, String.CompareTo and String.Equals or String.Equality use an ordinal comparison, a case-sensitive comparison, and use the current culture. \r\n\r\nIf it is using an ordinal comparison then by definition it can't be using the current culture. Ordinal comparisons are binary sort order comparisons that do not factor in culture, so which is it? The section continues on to state:\r\n\r\n> The most important point about these default comparison methods is that because they use the current culture, the results depend on the locale and language settings of the machine where they run. These comparisons are unsuitable for comparisons where order should be consistent across machines or locations.\r\n\r\n...which would need to be fixed as well.\r\n\r\n---\r\n#### Document Details\r\n\r\n<span class=\"emoji-outer emoji-sizer\"><span class=\"emoji-inner\" style=\"background: url(chrome-extension://immhpnclomdloikkpcefncmfgjbkojmh/emoji-data/sheet_apple_32.png);background-position:95.94594594594594% 75.96944770857814%;background-size:5418.75% 5418.75%\" data-codepoints=\"26a0-fe0f\"></span></span> *Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.*\r\n\r\n* ID: 11ecfc18-477b-f792-4136-2feb46bbc5d3\r\n* Version Independent ID: 82f53ae8-a9d4-dea9-5acd-6d9202a40882\r\n* Content: [How to: Compare strings - C# Guide](https://docs.microsoft.com/en-us/dotnet/csharp/how-to/compare-strings)\r\n* Content Source: [docs/csharp/how-to/compare-strings.md](https://github.com/dotnet/docs/blob/master/docs/csharp/how-to/compare-strings.md)\r\n* Product: **dotnet-csharp**\r\n* GitHub Login: @BillWagner\r\n* Microsoft Alias: **wiwagn**"},"comment":{"url":"https://api.github.com/repos/dotnet/docs/issues/comments/444276791","html_url":"https://github.com/dotnet/docs/issues/9201#issuecomment-444276791","issue_url":"https://api.github.com/repos/dotnet/docs/issues/9201","id":444276791,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NDI3Njc5MQ==","user":{"login":"rpetrusha","id":10886961,"node_id":"MDQ6VXNlcjEwODg2OTYx","avatar_url":"https://avatars2.githubusercontent.com/u/10886961?v=4","gravatar_id":"","url":"https://api.github.com/users/rpetrusha","html_url":"https://github.com/rpetrusha","followers_url":"https://api.github.com/users/rpetrusha/followers","following_url":"https://api.github.com/users/rpetrusha/following{/other_user}","gists_url":"https://api.github.com/users/rpetrusha/gists{/gist_id}","starred_url":"https://api.github.com/users/rpetrusha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpetrusha/subscriptions","organizations_url":"https://api.github.com/users/rpetrusha/orgs","repos_url":"https://api.github.com/users/rpetrusha/repos","events_url":"https://api.github.com/users/rpetrusha/events{/privacy}","received_events_url":"https://api.github.com/users/rpetrusha/received_events","type":"User","site_admin":false},"created_at":"2018-12-04T22:05:18Z","updated_at":"2018-12-04T22:05:18Z","author_association":"CONTRIBUTOR","body":"Sorry, Bill. I just got to this after being out yesterday.\r\n\r\nI think that what the article is trying to say is that there’s inconsistency between the methods; CompareTo performs a culture-sensitive, case-sensitive comparison, while the equality methods are ordinal.\r\n\r\nI’ll assign the issue to myself and address it this sprint (hopefully), since this is confusing and seems like an important issue to address. This is a high page-view topic.\r\n\r\n--Ron\r\n\r\n\r\n\r\nFrom: Bill Wagner <notifications@github.com>\r\nSent: Monday, December 3, 2018 6:25 PM\r\nTo: dotnet/docs <docs@noreply.github.com>\r\nCc: Ron Petrusha <ronpet@microsoft.com>; Mention <mention@noreply.github.com>\r\nSubject: Re: [dotnet/docs] Ordinal String Operations vs Current Culture (#9201)\r\n\r\n\r\n@rpetrusha<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Frpetrusha&data=02%7C01%7Cronpet%40microsoft.com%7C8afce8e0ef214c45ecb508d6598fbc52%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636794871210965617&sdata=qP92iJczqWD1gfV9UUTN8O6bx07KFXBqh35levSTa6c%3D&reserved=0> you are more knowledgeable on this than I am. Do you have thoughts on this issue?\r\n\r\n—\r\nYou are receiving this because you were mentioned.\r\nReply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2Fdocs%2Fissues%2F9201%23issuecomment-443946131&data=02%7C01%7Cronpet%40microsoft.com%7C8afce8e0ef214c45ecb508d6598fbc52%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636794871210975626&sdata=2Sq5ioMCaN%2FPEhGEFdAUNaHW3mvwkdp1P%2Bn1DjkAbNk%3D&reserved=0>, or mute the thread<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKYfMdB4gOiILHnejQ3klOfk4BtHGUG5ks5u1d0OgaJpZM4YxHRm&data=02%7C01%7Cronpet%40microsoft.com%7C8afce8e0ef214c45ecb508d6598fbc52%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636794871210985635&sdata=sEZ6PTOEM99f62G580Iz%2B1Y22%2B5A2jpsXaMICT%2BeEfo%3D&reserved=0>.\r\n"}}
{"actor":{"display_login":"rpetrusha"}}