{"action":"created","issue":{"url":"https://api.github.com/repos/MozillaReality/FirefoxReality/issues/76","repository_url":"https://api.github.com/repos/MozillaReality/FirefoxReality","labels_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/issues/76/labels{/name}","comments_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/issues/76/comments","events_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/issues/76/events","html_url":"https://github.com/MozillaReality/FirefoxReality/pull/76","id":335791885,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NDAxODY4","number":76,"title":"Implement Focus mode, full screen mode and widget resizing","user":{"login":"MortimerGoro","id":1070794,"node_id":"MDQ6VXNlcjEwNzA3OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1070794?v=4","gravatar_id":"","url":"https://api.github.com/users/MortimerGoro","html_url":"https://github.com/MortimerGoro","followers_url":"https://api.github.com/users/MortimerGoro/followers","following_url":"https://api.github.com/users/MortimerGoro/following{/other_user}","gists_url":"https://api.github.com/users/MortimerGoro/gists{/gist_id}","starred_url":"https://api.github.com/users/MortimerGoro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MortimerGoro/subscriptions","organizations_url":"https://api.github.com/users/MortimerGoro/orgs","repos_url":"https://api.github.com/users/MortimerGoro/repos","events_url":"https://api.github.com/users/MortimerGoro/events{/privacy}","received_events_url":"https://api.github.com/users/MortimerGoro/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-06-26T12:17:38Z","updated_at":"2018-06-26T19:42:45Z","closed_at":"2018-06-26T16:38:11Z","author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/MozillaReality/FirefoxReality/pulls/76","html_url":"https://github.com/MozillaReality/FirefoxReality/pull/76","diff_url":"https://github.com/MozillaReality/FirefoxReality/pull/76.diff","patch_url":"https://github.com/MozillaReality/FirefoxReality/pull/76.patch"},"body":"- Implement Focus mode, full screen mode and widget resizing \r\n- Implement reusable Quad node which adds supports different scale modes (Quad is used by Widget nodes now)\r\n- Implement world Fade Out/In API and blitter\r\n- Implement WidgetResizer utility node\r\n\r\nFixes #51,  #55 and #65"},"comment":{"url":"https://api.github.com/repos/MozillaReality/FirefoxReality/issues/comments/400438211","html_url":"https://github.com/MozillaReality/FirefoxReality/pull/76#issuecomment-400438211","issue_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/issues/76","id":400438211,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDQzODIxMQ==","user":{"login":"MortimerGoro","id":1070794,"node_id":"MDQ6VXNlcjEwNzA3OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1070794?v=4","gravatar_id":"","url":"https://api.github.com/users/MortimerGoro","html_url":"https://github.com/MortimerGoro","followers_url":"https://api.github.com/users/MortimerGoro/followers","following_url":"https://api.github.com/users/MortimerGoro/following{/other_user}","gists_url":"https://api.github.com/users/MortimerGoro/gists{/gist_id}","starred_url":"https://api.github.com/users/MortimerGoro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MortimerGoro/subscriptions","organizations_url":"https://api.github.com/users/MortimerGoro/orgs","repos_url":"https://api.github.com/users/MortimerGoro/repos","events_url":"https://api.github.com/users/MortimerGoro/events{/privacy}","received_events_url":"https://api.github.com/users/MortimerGoro/received_events","type":"User","site_admin":false},"created_at":"2018-06-26T19:42:45Z","updated_at":"2018-06-26T19:42:45Z","author_association":"COLLABORATOR","body":"> On a large code change like this, if two people are requested for the review, I would prefer if both review it before it is landed. There are some things I have comments about. I'm going to go ahead and make the comments on the code and we can follow up in a later PR if needed.\r\n\r\nYep, he asked if it was possible to merge earlier because he was blocked by some APIs added on this PR but forgot to mention here that we'll handle your comments/reviews as follow-ups.\r\n\r\n> I'm a little concerned about the fade blitter adding an entire frame buffer worth of fill. It seems to perform okay right now, but there isn't a lot of geometry in the scene currently. Is it possible to handle this with a lighting effect?\r\n\r\nI thought today about adding something like a tintColor to the RenderState which allows to multiply the resulting v_color in the vertex shader with the fixed value. This would be easier to handle because we don't have to deal with the hierarchy of lights, save/restore lights, etc. We are also going to require it for fade transitions to private browsing session in the browser widget itself. What do you think?\r\n\r\n> I found that if you are watching a video in full screen mode and go back. The UI doesn't go back to normal with URL bar and buttons. I didn't see any code added to check if in full screen mode onBack so that might be the issue.\r\n\r\nI added this code to handle a similar scenario but forgot to add it to back handler too. Will test and add it:\r\n```\r\nif (mFocusDueToFullScreen) {\r\n     mFocusDueToFullScreen = false;\r\n      exitFocusMode();\r\n}\r\n```\r\n\r\n> I think there is also a bug in GeckoView where when going out of fullscreen mode, you can't scroll any more and need to reload the page to get scrolling to work. I see that that gets filed, I think it is affect Focus/Klar browser also.\r\n\r\nI didn't notice that with the youtube tests. Is that bug already filled to bugzilla?\r\n\r\n\r\n\r\n"}}
{"actor":{"display_login":"MortimerGoro"}}