{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls/comments/181896157","pull_request_review_id":112601670,"id":181896157,"diff_hunk":"@@ -131,48 +211,58 @@ export class RuleNew extends LinkedComponent {\n                 <Section.Container key={this.state.conditions[idx].key}>\n                   <Section.Header>{t(`rulesFlyout.condition.condition`)} {idx + 1}</Section.Header>\n                   <Section.Content>\n-                    {\n-                      conditionLinks.length > 1 &&\n-                      <Btn svg={svgs.trash} onClick={this.deleteCondition(idx)}>Delete</Btn>\n-                    }\n                     <FormGroup>\n                       <FormLabel isRequired=\"true\">{t(`rulesFlyout.condition.field`)}</FormLabel>\n                       <FormControl\n                         type=\"select\"\n                         className=\"long\"\n                         placeholder={t(`rulesFlyout.condition.fieldPlaceholder`)}\n-                        link={condition.field} />\n+                        link={condition.fieldLink}\n+                        options={this.state.fieldOptions}\n+                        clearable={false}\n+                        searchable={true} />\n                     </FormGroup>\n                     <FormGroup>\n                       <FormLabel isRequired=\"true\">{t(`rulesFlyout.condition.calculation`)}</FormLabel>\n                       <FormControl\n                         type=\"select\"\n                         className=\"long\"\n                         placeholder={t(`rulesFlyout.condition.calculationPlaceholder`)}\n-                        link={condition.calculation} />\n+                        link={condition.calculationLink}\n+                        options={this.state.calculationOptions}\n+                        clearable={false}\n+                        searchable={false} />\n                     </FormGroup>\n                     <FormGroup>\n                       <FormLabel isRequired=\"true\">{t(`rulesFlyout.condition.timePeriod`)}</FormLabel>\n                       <FormControl\n                         type=\"duration\"\n                         className=\"long\"\n-                        link={condition.timePeriod} />\n+                        link={condition.durationLink} />\n                     </FormGroup>\n                     <FormGroup>\n                       <FormLabel isRequired=\"true\">{t(`rulesFlyout.condition.operator`)}</FormLabel>\n                       <FormControl\n                         type=\"select\"\n                         className=\"short\"\n                         placeholder={t(`rulesFlyout.condition.operatorPlaceholder`)}\n-                        link={condition.operator} />\n+                        link={condition.operatorLink}\n+                        options={this.state.operatorOptions}\n+                        value={this.state.operatorOptions[0].value}\n+                        clearable={false}\n+                        searchable={false} />\n                     </FormGroup>\n                     <FormGroup>\n                       <FormLabel isRequired=\"true\">{t(`rulesFlyout.condition.value`)}</FormLabel>\n                       <FormControl\n                         type=\"text\"\n                         placeholder={t(`rulesFlyout.condition.valuePlaceholder`)}\n-                        link={condition.value} />\n+                        link={condition.valueLink} />\n                     </FormGroup>\n+                    {\n+                      conditionLinks.length > 1 &&","path":"src/components/pages/rules/flyouts/ruleNew/ruleNew.js","position":null,"original_position":242,"commit_id":"3e1d55171c79bbf452f5b3e965bdb2282d0dd8ef","original_commit_id":"992abc92b42baa920f79e6ce1bfdd7b24f1ae302","user":{"login":"isaac73","id":22013837,"avatar_url":"https://avatars3.githubusercontent.com/u/22013837?v=4","gravatar_id":"","url":"https://api.github.com/users/isaac73","html_url":"https://github.com/isaac73","followers_url":"https://api.github.com/users/isaac73/followers","following_url":"https://api.github.com/users/isaac73/following{/other_user}","gists_url":"https://api.github.com/users/isaac73/gists{/gist_id}","starred_url":"https://api.github.com/users/isaac73/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaac73/subscriptions","organizations_url":"https://api.github.com/users/isaac73/orgs","repos_url":"https://api.github.com/users/isaac73/repos","events_url":"https://api.github.com/users/isaac73/events{/privacy}","received_events_url":"https://api.github.com/users/isaac73/received_events","type":"User","site_admin":false},"body":"fixed","created_at":"2018-04-16T21:48:31Z","updated_at":"2018-04-16T21:48:32Z","html_url":"https://github.com/Azure/pcs-remote-monitoring-webui/pull/924#discussion_r181896157","pull_request_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls/924","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls/comments/181896157"},"html":{"href":"https://github.com/Azure/pcs-remote-monitoring-webui/pull/924#discussion_r181896157"},"pull_request":{"href":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls/924"}},"in_reply_to_id":181534347},"pull_request":{"url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls/924","id":181618775,"html_url":"https://github.com/Azure/pcs-remote-monitoring-webui/pull/924","diff_url":"https://github.com/Azure/pcs-remote-monitoring-webui/pull/924.diff","patch_url":"https://github.com/Azure/pcs-remote-monitoring-webui/pull/924.patch","issue_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/issues/924","number":924,"state":"open","locked":false,"title":"Rules flyout second check in","user":{"login":"isaac73","id":22013837,"avatar_url":"https://avatars3.githubusercontent.com/u/22013837?v=4","gravatar_id":"","url":"https://api.github.com/users/isaac73","html_url":"https://github.com/isaac73","followers_url":"https://api.github.com/users/isaac73/followers","following_url":"https://api.github.com/users/isaac73/following{/other_user}","gists_url":"https://api.github.com/users/isaac73/gists{/gist_id}","starred_url":"https://api.github.com/users/isaac73/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaac73/subscriptions","organizations_url":"https://api.github.com/users/isaac73/orgs","repos_url":"https://api.github.com/users/isaac73/repos","events_url":"https://api.github.com/users/isaac73/events{/privacy}","received_events_url":"https://api.github.com/users/isaac73/received_events","type":"User","site_admin":false},"body":"# Type of change? <!-- [x] all the boxes that apply -->\r\n\r\n- [ ] Bug fix\r\n- [ ] New feature\r\n- [x] Enhancement\r\n- [ ] Breaking change (breaks backward compatibility)\r\n\r\n# Description, Context, Motivation <!-- Please help us reviewing your PR -->\r\n\r\nFilled out all dropdown in rules flout\r\n...\r\n\r\n**Checklist:**\r\n\r\n- [x] All tests passed\r\n- [ ] The code follows the code style and conventions of this project\r\n- [ ] The change requires a change to the documentation\r\n- [ ] I have updated the documentation accordingly\r\n","created_at":"2018-04-14T00:01:54Z","updated_at":"2018-04-16T21:48:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0b17c7ae9b5b7d531efd0e11a2643ee1a81d7593","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls/924/commits","review_comments_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls/924/comments","review_comment_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/issues/924/comments","statuses_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/statuses/3e1d55171c79bbf452f5b3e965bdb2282d0dd8ef","head":{"label":"Azure:isaac-rulesASA","ref":"isaac-rulesASA","sha":"3e1d55171c79bbf452f5b3e965bdb2282d0dd8ef","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":89969457,"name":"pcs-remote-monitoring-webui","full_name":"Azure/pcs-remote-monitoring-webui","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/pcs-remote-monitoring-webui","description":"Azure IoT PCS Remote Monitoring Web UI","fork":false,"url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui","forks_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/forks","keys_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/teams","hooks_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/hooks","issue_events_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/events","assignees_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/tags","blobs_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/languages","stargazers_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/stargazers","contributors_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/contributors","subscribers_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/subscribers","subscription_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/subscription","commits_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/merges","archive_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/downloads","issues_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/labels{/name}","releases_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/deployments","created_at":"2017-05-01T22:47:49Z","updated_at":"2018-04-16T18:54:59Z","pushed_at":"2018-04-16T21:45:51Z","git_url":"git://github.com/Azure/pcs-remote-monitoring-webui.git","ssh_url":"git@github.com:Azure/pcs-remote-monitoring-webui.git","clone_url":"https://github.com/Azure/pcs-remote-monitoring-webui.git","svn_url":"https://github.com/Azure/pcs-remote-monitoring-webui","homepage":null,"size":2530,"stargazers_count":24,"watchers_count":24,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":125,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":18,"open_issues":125,"watchers":24,"default_branch":"master"}},"base":{"label":"Azure:archMigration","ref":"archMigration","sha":"09839f42733a8bb78808af2963c83cbb707d7519","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":89969457,"name":"pcs-remote-monitoring-webui","full_name":"Azure/pcs-remote-monitoring-webui","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/pcs-remote-monitoring-webui","description":"Azure IoT PCS Remote Monitoring Web UI","fork":false,"url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui","forks_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/forks","keys_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/teams","hooks_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/hooks","issue_events_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/events","assignees_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/tags","blobs_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/languages","stargazers_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/stargazers","contributors_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/contributors","subscribers_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/subscribers","subscription_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/subscription","commits_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/merges","archive_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/downloads","issues_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/labels{/name}","releases_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/deployments","created_at":"2017-05-01T22:47:49Z","updated_at":"2018-04-16T18:54:59Z","pushed_at":"2018-04-16T21:45:51Z","git_url":"git://github.com/Azure/pcs-remote-monitoring-webui.git","ssh_url":"git@github.com:Azure/pcs-remote-monitoring-webui.git","clone_url":"https://github.com/Azure/pcs-remote-monitoring-webui.git","svn_url":"https://github.com/Azure/pcs-remote-monitoring-webui","homepage":null,"size":2530,"stargazers_count":24,"watchers_count":24,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":125,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":18,"open_issues":125,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls/924"},"html":{"href":"https://github.com/Azure/pcs-remote-monitoring-webui/pull/924"},"issue":{"href":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/issues/924"},"comments":{"href":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/issues/924/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls/924/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls/924/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/statuses/3e1d55171c79bbf452f5b3e965bdb2282d0dd8ef"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"isaac73"}}