{"action":"opened","issue":{"url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6516","repository_url":"https://api.github.com/repos/NREL/EnergyPlus","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6516/labels{/name}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6516/comments","events_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6516/events","html_url":"https://github.com/NREL/EnergyPlus/issues/6516","id":303649414,"number":6516,"title":"Underflow in CalcFluidHeatExchanger","user":{"login":"mjwitte","id":4991075,"avatar_url":"https://avatars2.githubusercontent.com/u/4991075?v=4","gravatar_id":"","url":"https://api.github.com/users/mjwitte","html_url":"https://github.com/mjwitte","followers_url":"https://api.github.com/users/mjwitte/followers","following_url":"https://api.github.com/users/mjwitte/following{/other_user}","gists_url":"https://api.github.com/users/mjwitte/gists{/gist_id}","starred_url":"https://api.github.com/users/mjwitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjwitte/subscriptions","organizations_url":"https://api.github.com/users/mjwitte/orgs","repos_url":"https://api.github.com/users/mjwitte/repos","events_url":"https://api.github.com/users/mjwitte/events{/privacy}","received_events_url":"https://api.github.com/users/mjwitte/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-08T22:05:14Z","updated_at":"2018-03-08T22:05:14Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Issue overview\r\n--------------\r\nWhile debugging other issues with 5ZoneCoolBeam stumbled into floating point underflow [here in CalcFluidHeatExchanger](https://github.com/NREL/EnergyPlus/blob/537dda002df3d9f23cbbf6e34fc90359dcb925c3/src/EnergyPlus/PlantHeatExchangerFluidToFluid.cc#L1498). `NTU` = 7594 which makes `-NTU < EXP_LowerLimit` which is -20. Need more logic here to test if `ExpCheckValue2` is safe before evaluating this if statement.\r\n\r\nNeed to compile with fp/strict and special line uncommented in main.cc - see [debugging tips](https://github.com/NREL/EnergyPlus/wiki/Debugging-Tips).\r\n\r\n### Details\r\nSome additional details for this issue (if relevant):\r\n - Platform Win64\r\n - Version of EnergyPlus 8.9.0 0660657580\r\n - Found while working on #6338.\r\n\r\n### Checklist\r\nAdd to this list or remove from it as applicable.  This is a simple templated set of guidelines.\r\n - [ ] Defect file added (list location of defect file here)\r\n - [ ] Ticket added to Pivotal for defect (development team task)\r\n - [ ] Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)\r\n\r\n"}}
{"actor":{"display_login":"mjwitte"}}