{"action":"created","comment":{"url":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments/224315367","pull_request_review_id":163650165,"id":224315367,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDMxNTM2Nw==","diff_hunk":"@@ -543,12 +543,10 @@ set_target_properties(torrent-rasterbar\n \t\tSOVERSION ${SOVERSION}\n )\n \n-if (cxx_std_14 IN_LIST CMAKE_CXX_COMPILE_FEATURES)\n-\ttarget_compile_features(torrent-rasterbar PUBLIC cxx_std_14)\n-\tmessage(STATUS \"Building in C++14 mode\")\n-else()\n-\ttarget_compile_features(torrent-rasterbar PUBLIC cxx_std_11)\n-\tmessage(STATUS \"Building in C++11 mode\")\n+if (NOT \"${CXX_STANDARD}\" STREQUAL \"\")","path":"CMakeLists.txt","position":null,"original_position":10,"commit_id":"00d828e0211a38bf2a23ab9c3e4fd032e986d96c","original_commit_id":"8717ac47c48e81edee5ead1bca8cb46495740e55","user":{"login":"arvidn","id":661450,"node_id":"MDQ6VXNlcjY2MTQ1MA==","avatar_url":"https://avatars0.githubusercontent.com/u/661450?v=4","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"body":"> For a property that can have default value you set it via variable named CMAKE_<property name>; CMake copies values from such variables into properties when creating a target.\r\n\r\nmakes sense. so my understanding then is to never set any `CMAKE_` variables inside a CMakeList.txt, but only set them at the top level `cmake` invocation, otherwise you risk different targets to have different properties.\r\n\r\nI'll simplify the check.","created_at":"2018-10-11T05:03:16Z","updated_at":"2018-10-11T05:03:17Z","html_url":"https://github.com/arvidn/libtorrent/pull/3339#discussion_r224315367","pull_request_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/3339","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments/224315367"},"html":{"href":"https://github.com/arvidn/libtorrent/pull/3339#discussion_r224315367"},"pull_request":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/3339"}},"in_reply_to_id":224115691},"pull_request":{"url":"https://api.github.com/repos/arvidn/libtorrent/pulls/3339","id":221126078,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMTI2MDc4","html_url":"https://github.com/arvidn/libtorrent/pull/3339","diff_url":"https://github.com/arvidn/libtorrent/pull/3339.diff","patch_url":"https://github.com/arvidn/libtorrent/pull/3339.patch","issue_url":"https://api.github.com/repos/arvidn/libtorrent/issues/3339","number":3339,"state":"open","locked":false,"title":"fix missing cmake-related files in tarball","user":{"login":"arvidn","id":661450,"node_id":"MDQ6VXNlcjY2MTQ1MA==","avatar_url":"https://avatars0.githubusercontent.com/u/661450?v=4","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"body":"a bunch of cmake fixes. specifically to enable building with cmake out of a tarball generated with automake.\r\n\r\n@zeule would you mind taking a look?","created_at":"2018-10-08T13:54:05Z","updated_at":"2018-10-11T05:03:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7628f5c0852bd43baf2d4de229668df7e06b9272","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/3339/commits","review_comments_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/3339/comments","review_comment_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/arvidn/libtorrent/issues/3339/comments","statuses_url":"https://api.github.com/repos/arvidn/libtorrent/statuses/00d828e0211a38bf2a23ab9c3e4fd032e986d96c","head":{"label":"arvidn:fix-tarball-cmake","ref":"fix-tarball-cmake","sha":"00d828e0211a38bf2a23ab9c3e4fd032e986d96c","user":{"login":"arvidn","id":661450,"node_id":"MDQ6VXNlcjY2MTQ1MA==","avatar_url":"https://avatars0.githubusercontent.com/u/661450?v=4","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"repo":{"id":36781769,"node_id":"MDEwOlJlcG9zaXRvcnkzNjc4MTc2OQ==","name":"libtorrent","full_name":"arvidn/libtorrent","private":false,"owner":{"login":"arvidn","id":661450,"node_id":"MDQ6VXNlcjY2MTQ1MA==","avatar_url":"https://avatars0.githubusercontent.com/u/661450?v=4","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"html_url":"https://github.com/arvidn/libtorrent","description":"an efficient feature complete C++ bittorrent implementation","fork":false,"url":"https://api.github.com/repos/arvidn/libtorrent","forks_url":"https://api.github.com/repos/arvidn/libtorrent/forks","keys_url":"https://api.github.com/repos/arvidn/libtorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arvidn/libtorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arvidn/libtorrent/teams","hooks_url":"https://api.github.com/repos/arvidn/libtorrent/hooks","issue_events_url":"https://api.github.com/repos/arvidn/libtorrent/issues/events{/number}","events_url":"https://api.github.com/repos/arvidn/libtorrent/events","assignees_url":"https://api.github.com/repos/arvidn/libtorrent/assignees{/user}","branches_url":"https://api.github.com/repos/arvidn/libtorrent/branches{/branch}","tags_url":"https://api.github.com/repos/arvidn/libtorrent/tags","blobs_url":"https://api.github.com/repos/arvidn/libtorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arvidn/libtorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arvidn/libtorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/arvidn/libtorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arvidn/libtorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/arvidn/libtorrent/languages","stargazers_url":"https://api.github.com/repos/arvidn/libtorrent/stargazers","contributors_url":"https://api.github.com/repos/arvidn/libtorrent/contributors","subscribers_url":"https://api.github.com/repos/arvidn/libtorrent/subscribers","subscription_url":"https://api.github.com/repos/arvidn/libtorrent/subscription","commits_url":"https://api.github.com/repos/arvidn/libtorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/arvidn/libtorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/arvidn/libtorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/arvidn/libtorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/arvidn/libtorrent/contents/{+path}","compare_url":"https://api.github.com/repos/arvidn/libtorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arvidn/libtorrent/merges","archive_url":"https://api.github.com/repos/arvidn/libtorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arvidn/libtorrent/downloads","issues_url":"https://api.github.com/repos/arvidn/libtorrent/issues{/number}","pulls_url":"https://api.github.com/repos/arvidn/libtorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/arvidn/libtorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/arvidn/libtorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arvidn/libtorrent/labels{/name}","releases_url":"https://api.github.com/repos/arvidn/libtorrent/releases{/id}","deployments_url":"https://api.github.com/repos/arvidn/libtorrent/deployments","created_at":"2015-06-03T05:22:03Z","updated_at":"2018-10-11T00:02:18Z","pushed_at":"2018-10-11T05:03:15Z","git_url":"git://github.com/arvidn/libtorrent.git","ssh_url":"git@github.com:arvidn/libtorrent.git","clone_url":"https://github.com/arvidn/libtorrent.git","svn_url":"https://github.com/arvidn/libtorrent","homepage":"http://libtorrent.org","size":77815,"stargazers_count":1489,"watchers_count":1489,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":412,"mirror_url":null,"archived":false,"open_issues_count":236,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":412,"open_issues":236,"watchers":1489,"default_branch":"master"}},"base":{"label":"arvidn:master","ref":"master","sha":"7ff692690b112aac4b67314f5d9d370671d71325","user":{"login":"arvidn","id":661450,"node_id":"MDQ6VXNlcjY2MTQ1MA==","avatar_url":"https://avatars0.githubusercontent.com/u/661450?v=4","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"repo":{"id":36781769,"node_id":"MDEwOlJlcG9zaXRvcnkzNjc4MTc2OQ==","name":"libtorrent","full_name":"arvidn/libtorrent","private":false,"owner":{"login":"arvidn","id":661450,"node_id":"MDQ6VXNlcjY2MTQ1MA==","avatar_url":"https://avatars0.githubusercontent.com/u/661450?v=4","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"html_url":"https://github.com/arvidn/libtorrent","description":"an efficient feature complete C++ bittorrent implementation","fork":false,"url":"https://api.github.com/repos/arvidn/libtorrent","forks_url":"https://api.github.com/repos/arvidn/libtorrent/forks","keys_url":"https://api.github.com/repos/arvidn/libtorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arvidn/libtorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arvidn/libtorrent/teams","hooks_url":"https://api.github.com/repos/arvidn/libtorrent/hooks","issue_events_url":"https://api.github.com/repos/arvidn/libtorrent/issues/events{/number}","events_url":"https://api.github.com/repos/arvidn/libtorrent/events","assignees_url":"https://api.github.com/repos/arvidn/libtorrent/assignees{/user}","branches_url":"https://api.github.com/repos/arvidn/libtorrent/branches{/branch}","tags_url":"https://api.github.com/repos/arvidn/libtorrent/tags","blobs_url":"https://api.github.com/repos/arvidn/libtorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arvidn/libtorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arvidn/libtorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/arvidn/libtorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arvidn/libtorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/arvidn/libtorrent/languages","stargazers_url":"https://api.github.com/repos/arvidn/libtorrent/stargazers","contributors_url":"https://api.github.com/repos/arvidn/libtorrent/contributors","subscribers_url":"https://api.github.com/repos/arvidn/libtorrent/subscribers","subscription_url":"https://api.github.com/repos/arvidn/libtorrent/subscription","commits_url":"https://api.github.com/repos/arvidn/libtorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/arvidn/libtorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/arvidn/libtorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/arvidn/libtorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/arvidn/libtorrent/contents/{+path}","compare_url":"https://api.github.com/repos/arvidn/libtorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arvidn/libtorrent/merges","archive_url":"https://api.github.com/repos/arvidn/libtorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arvidn/libtorrent/downloads","issues_url":"https://api.github.com/repos/arvidn/libtorrent/issues{/number}","pulls_url":"https://api.github.com/repos/arvidn/libtorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/arvidn/libtorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/arvidn/libtorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arvidn/libtorrent/labels{/name}","releases_url":"https://api.github.com/repos/arvidn/libtorrent/releases{/id}","deployments_url":"https://api.github.com/repos/arvidn/libtorrent/deployments","created_at":"2015-06-03T05:22:03Z","updated_at":"2018-10-11T00:02:18Z","pushed_at":"2018-10-11T05:03:15Z","git_url":"git://github.com/arvidn/libtorrent.git","ssh_url":"git@github.com:arvidn/libtorrent.git","clone_url":"https://github.com/arvidn/libtorrent.git","svn_url":"https://github.com/arvidn/libtorrent","homepage":"http://libtorrent.org","size":77815,"stargazers_count":1489,"watchers_count":1489,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":412,"mirror_url":null,"archived":false,"open_issues_count":236,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":412,"open_issues":236,"watchers":1489,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/3339"},"html":{"href":"https://github.com/arvidn/libtorrent/pull/3339"},"issue":{"href":"https://api.github.com/repos/arvidn/libtorrent/issues/3339"},"comments":{"href":"https://api.github.com/repos/arvidn/libtorrent/issues/3339/comments"},"review_comments":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/3339/comments"},"review_comment":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/3339/commits"},"statuses":{"href":"https://api.github.com/repos/arvidn/libtorrent/statuses/00d828e0211a38bf2a23ab9c3e4fd032e986d96c"}},"author_association":"OWNER"}}
{"actor":{"display_login":"arvidn"}}