{"action":"created","comment":{"url":"https://api.github.com/repos/gradle/gradle/pulls/comments/226878282","pull_request_review_id":166800629,"id":226878282,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjg3ODI4Mg==","diff_hunk":"@@ -103,6 +105,35 @@ class PerformanceTestPlugin : Plugin<Project> {\n         tasks.register(\"performanceReport\")\n     }\n \n+    private\n+    fun Project.registerForkPointDistributionTask() {\n+        val determineForkPoint = tasks.register(\"determineForkPoint\", DetermineForkPoint::class)\n+        val buildForkPointDistribution = tasks.register(\"buildForkPointDistribution\", BuildForkPointDistribution::class) {\n+            dependsOn(determineForkPoint)\n+        }\n+\n+        buildForkPointDistribution.get().forkPointDistributionVersion.set(determineForkPoint.get().forkPointDistributionVersion)\n+\n+        tasks.register(\"configurePerformanceTestBaseline\") {\n+            dependsOn(buildForkPointDistribution)\n+            doLast {\n+                val commitBaseline = determineForkPoint.get().forkPointDistributionVersion.get()\n+                project.tasks.withType(DistributedPerformanceTest::class) {\n+                    if (baselines?.isEmpty() == true || baselines == \"defaults\") {","path":"buildSrc/subprojects/plugins/src/main/kotlin/org/gradle/plugins/performance/PerformanceTestPlugin.kt","position":27,"original_position":27,"commit_id":"7c90e1f6fcecee4641b4ce07cc3bc655607fab20","original_commit_id":"7c90e1f6fcecee4641b4ce07cc3bc655607fab20","user":{"login":"wolfs","id":423186,"node_id":"MDQ6VXNlcjQyMzE4Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/423186?v=4","gravatar_id":"","url":"https://api.github.com/users/wolfs","html_url":"https://github.com/wolfs","followers_url":"https://api.github.com/users/wolfs/followers","following_url":"https://api.github.com/users/wolfs/following{/other_user}","gists_url":"https://api.github.com/users/wolfs/gists{/gist_id}","starred_url":"https://api.github.com/users/wolfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolfs/subscriptions","organizations_url":"https://api.github.com/users/wolfs/orgs","repos_url":"https://api.github.com/users/wolfs/repos","events_url":"https://api.github.com/users/wolfs/events{/privacy}","received_events_url":"https://api.github.com/users/wolfs/received_events","type":"User","site_admin":false},"body":"Why don't you use this:\r\n```\r\n                    if (baselines.isNullOrEmpty() || baselines == \"defaults\") {\r\n                        baselines = commitBaseline\r\n                    }\r\n```\r\n\r\n`baselines` is of type `String?`, and `isNullOrEmpty` works on `String?` and yields a `Boolean` (non-null).","created_at":"2018-10-21T21:11:36Z","updated_at":"2018-10-21T21:12:25Z","html_url":"https://github.com/gradle/gradle/pull/7337#discussion_r226878282","pull_request_url":"https://api.github.com/repos/gradle/gradle/pulls/7337","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/gradle/gradle/pulls/comments/226878282"},"html":{"href":"https://github.com/gradle/gradle/pull/7337#discussion_r226878282"},"pull_request":{"href":"https://api.github.com/repos/gradle/gradle/pulls/7337"}}},"pull_request":{"url":"https://api.github.com/repos/gradle/gradle/pulls/7337","id":222030778,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMDMwNzc4","html_url":"https://github.com/gradle/gradle/pull/7337","diff_url":"https://github.com/gradle/gradle/pull/7337.diff","patch_url":"https://github.com/gradle/gradle/pull/7337.patch","issue_url":"https://api.github.com/repos/gradle/gradle/issues/7337","number":7337,"state":"open","locked":false,"title":"Run performance test against fork point commit","user":{"login":"blindpirate","id":12689835,"node_id":"MDQ6VXNlcjEyNjg5ODM1","avatar_url":"https://avatars3.githubusercontent.com/u/12689835?v=4","gravatar_id":"","url":"https://api.github.com/users/blindpirate","html_url":"https://github.com/blindpirate","followers_url":"https://api.github.com/users/blindpirate/followers","following_url":"https://api.github.com/users/blindpirate/following{/other_user}","gists_url":"https://api.github.com/users/blindpirate/gists{/gist_id}","starred_url":"https://api.github.com/users/blindpirate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blindpirate/subscriptions","organizations_url":"https://api.github.com/users/blindpirate/orgs","repos_url":"https://api.github.com/users/blindpirate/repos","events_url":"https://api.github.com/users/blindpirate/events{/privacy}","received_events_url":"https://api.github.com/users/blindpirate/received_events","type":"User","site_admin":false},"body":"### Context\r\n\r\nThis closes https://github.com/gradle/gradle-private/issues/1526\r\n\r\nBasically, the idea is, we should run feature branch performance tests against the distribution which is built from the \"fork point commit\". This can reduce the effects of performance regression which is not introduced by the feature branch.\r\n\r\nTwo tasks are added into the build and depended by performance task:\r\n\r\n- `determineForkPoint`, run `git` command to determine the fork point commit. It's done during the execution phase, then it sets the commit for `buildForkPointDistribution` task.\r\n- `buildForkPointDistribution`, try to build a distribution from the fork point commit. \r\n\r\n`buildForkPointDistribution` is cachable so it only needs to run once. Its input is the fork point commit, output is two files: a binary distribution and a tooling api jar. The generated binary distribution is used to run individual worker tests.\r\n\r\nIt looks like this in performance report:\r\n\r\n![image](https://user-images.githubusercontent.com/12689835/46787007-2624b480-cd69-11e8-9020-8788f32059b3.png)\r\n","created_at":"2018-10-11T07:20:30Z","updated_at":"2018-10-21T21:12:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"720eedffd272ef99b08fec62810f62518023fb67","assignee":{"login":"blindpirate","id":12689835,"node_id":"MDQ6VXNlcjEyNjg5ODM1","avatar_url":"https://avatars3.githubusercontent.com/u/12689835?v=4","gravatar_id":"","url":"https://api.github.com/users/blindpirate","html_url":"https://github.com/blindpirate","followers_url":"https://api.github.com/users/blindpirate/followers","following_url":"https://api.github.com/users/blindpirate/following{/other_user}","gists_url":"https://api.github.com/users/blindpirate/gists{/gist_id}","starred_url":"https://api.github.com/users/blindpirate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blindpirate/subscriptions","organizations_url":"https://api.github.com/users/blindpirate/orgs","repos_url":"https://api.github.com/users/blindpirate/repos","events_url":"https://api.github.com/users/blindpirate/events{/privacy}","received_events_url":"https://api.github.com/users/blindpirate/received_events","type":"User","site_admin":false},"assignees":[{"login":"blindpirate","id":12689835,"node_id":"MDQ6VXNlcjEyNjg5ODM1","avatar_url":"https://avatars3.githubusercontent.com/u/12689835?v=4","gravatar_id":"","url":"https://api.github.com/users/blindpirate","html_url":"https://github.com/blindpirate","followers_url":"https://api.github.com/users/blindpirate/followers","following_url":"https://api.github.com/users/blindpirate/following{/other_user}","gists_url":"https://api.github.com/users/blindpirate/gists{/gist_id}","starred_url":"https://api.github.com/users/blindpirate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blindpirate/subscriptions","organizations_url":"https://api.github.com/users/blindpirate/orgs","repos_url":"https://api.github.com/users/blindpirate/repos","events_url":"https://api.github.com/users/blindpirate/events{/privacy}","received_events_url":"https://api.github.com/users/blindpirate/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":460356696,"node_id":"MDU6TGFiZWw0NjAzNTY2OTY=","url":"https://api.github.com/repos/gradle/gradle/labels/a:chore","name":"a:chore","color":"1d76db","default":false},{"id":999583020,"node_id":"MDU6TGFiZWw5OTk1ODMwMjA=","url":"https://api.github.com/repos/gradle/gradle/labels/dev-productivity","name":"dev-productivity","color":"f9d0c4","default":false},{"id":289469033,"node_id":"MDU6TGFiZWwyODk0NjkwMzM=","url":"https://api.github.com/repos/gradle/gradle/labels/from:member","name":"from:member","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/gradle/gradle/pulls/7337/commits","review_comments_url":"https://api.github.com/repos/gradle/gradle/pulls/7337/comments","review_comment_url":"https://api.github.com/repos/gradle/gradle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gradle/gradle/issues/7337/comments","statuses_url":"https://api.github.com/repos/gradle/gradle/statuses/7c90e1f6fcecee4641b4ce07cc3bc655607fab20","head":{"label":"gradle:blindpirate/fork-point","ref":"blindpirate/fork-point","sha":"7c90e1f6fcecee4641b4ce07cc3bc655607fab20","user":{"login":"gradle","id":124156,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDE1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/124156?v=4","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"repo":{"id":302322,"node_id":"MDEwOlJlcG9zaXRvcnkzMDIzMjI=","name":"gradle","full_name":"gradle/gradle","private":false,"owner":{"login":"gradle","id":124156,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDE1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/124156?v=4","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gradle/gradle","description":"Adaptable, fast automation for all","fork":false,"url":"https://api.github.com/repos/gradle/gradle","forks_url":"https://api.github.com/repos/gradle/gradle/forks","keys_url":"https://api.github.com/repos/gradle/gradle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gradle/gradle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gradle/gradle/teams","hooks_url":"https://api.github.com/repos/gradle/gradle/hooks","issue_events_url":"https://api.github.com/repos/gradle/gradle/issues/events{/number}","events_url":"https://api.github.com/repos/gradle/gradle/events","assignees_url":"https://api.github.com/repos/gradle/gradle/assignees{/user}","branches_url":"https://api.github.com/repos/gradle/gradle/branches{/branch}","tags_url":"https://api.github.com/repos/gradle/gradle/tags","blobs_url":"https://api.github.com/repos/gradle/gradle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gradle/gradle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gradle/gradle/git/refs{/sha}","trees_url":"https://api.github.com/repos/gradle/gradle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gradle/gradle/statuses/{sha}","languages_url":"https://api.github.com/repos/gradle/gradle/languages","stargazers_url":"https://api.github.com/repos/gradle/gradle/stargazers","contributors_url":"https://api.github.com/repos/gradle/gradle/contributors","subscribers_url":"https://api.github.com/repos/gradle/gradle/subscribers","subscription_url":"https://api.github.com/repos/gradle/gradle/subscription","commits_url":"https://api.github.com/repos/gradle/gradle/commits{/sha}","git_commits_url":"https://api.github.com/repos/gradle/gradle/git/commits{/sha}","comments_url":"https://api.github.com/repos/gradle/gradle/comments{/number}","issue_comment_url":"https://api.github.com/repos/gradle/gradle/issues/comments{/number}","contents_url":"https://api.github.com/repos/gradle/gradle/contents/{+path}","compare_url":"https://api.github.com/repos/gradle/gradle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gradle/gradle/merges","archive_url":"https://api.github.com/repos/gradle/gradle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gradle/gradle/downloads","issues_url":"https://api.github.com/repos/gradle/gradle/issues{/number}","pulls_url":"https://api.github.com/repos/gradle/gradle/pulls{/number}","milestones_url":"https://api.github.com/repos/gradle/gradle/milestones{/number}","notifications_url":"https://api.github.com/repos/gradle/gradle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gradle/gradle/labels{/name}","releases_url":"https://api.github.com/repos/gradle/gradle/releases{/id}","deployments_url":"https://api.github.com/repos/gradle/gradle/deployments","created_at":"2009-09-09T18:27:19Z","updated_at":"2018-10-21T16:32:31Z","pushed_at":"2018-10-21T20:28:06Z","git_url":"git://github.com/gradle/gradle.git","ssh_url":"git@github.com:gradle/gradle.git","clone_url":"https://github.com/gradle/gradle.git","svn_url":"https://github.com/gradle/gradle","homepage":"https://gradle.org","size":236313,"stargazers_count":7722,"watchers_count":7722,"language":"Groovy","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":2348,"mirror_url":null,"archived":false,"open_issues_count":1281,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2348,"open_issues":1281,"watchers":7722,"default_branch":"master"}},"base":{"label":"gradle:master","ref":"master","sha":"05563186811e22dea0f01bad24281ead6a273ce6","user":{"login":"gradle","id":124156,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDE1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/124156?v=4","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"repo":{"id":302322,"node_id":"MDEwOlJlcG9zaXRvcnkzMDIzMjI=","name":"gradle","full_name":"gradle/gradle","private":false,"owner":{"login":"gradle","id":124156,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDE1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/124156?v=4","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gradle/gradle","description":"Adaptable, fast automation for all","fork":false,"url":"https://api.github.com/repos/gradle/gradle","forks_url":"https://api.github.com/repos/gradle/gradle/forks","keys_url":"https://api.github.com/repos/gradle/gradle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gradle/gradle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gradle/gradle/teams","hooks_url":"https://api.github.com/repos/gradle/gradle/hooks","issue_events_url":"https://api.github.com/repos/gradle/gradle/issues/events{/number}","events_url":"https://api.github.com/repos/gradle/gradle/events","assignees_url":"https://api.github.com/repos/gradle/gradle/assignees{/user}","branches_url":"https://api.github.com/repos/gradle/gradle/branches{/branch}","tags_url":"https://api.github.com/repos/gradle/gradle/tags","blobs_url":"https://api.github.com/repos/gradle/gradle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gradle/gradle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gradle/gradle/git/refs{/sha}","trees_url":"https://api.github.com/repos/gradle/gradle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gradle/gradle/statuses/{sha}","languages_url":"https://api.github.com/repos/gradle/gradle/languages","stargazers_url":"https://api.github.com/repos/gradle/gradle/stargazers","contributors_url":"https://api.github.com/repos/gradle/gradle/contributors","subscribers_url":"https://api.github.com/repos/gradle/gradle/subscribers","subscription_url":"https://api.github.com/repos/gradle/gradle/subscription","commits_url":"https://api.github.com/repos/gradle/gradle/commits{/sha}","git_commits_url":"https://api.github.com/repos/gradle/gradle/git/commits{/sha}","comments_url":"https://api.github.com/repos/gradle/gradle/comments{/number}","issue_comment_url":"https://api.github.com/repos/gradle/gradle/issues/comments{/number}","contents_url":"https://api.github.com/repos/gradle/gradle/contents/{+path}","compare_url":"https://api.github.com/repos/gradle/gradle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gradle/gradle/merges","archive_url":"https://api.github.com/repos/gradle/gradle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gradle/gradle/downloads","issues_url":"https://api.github.com/repos/gradle/gradle/issues{/number}","pulls_url":"https://api.github.com/repos/gradle/gradle/pulls{/number}","milestones_url":"https://api.github.com/repos/gradle/gradle/milestones{/number}","notifications_url":"https://api.github.com/repos/gradle/gradle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gradle/gradle/labels{/name}","releases_url":"https://api.github.com/repos/gradle/gradle/releases{/id}","deployments_url":"https://api.github.com/repos/gradle/gradle/deployments","created_at":"2009-09-09T18:27:19Z","updated_at":"2018-10-21T16:32:31Z","pushed_at":"2018-10-21T20:28:06Z","git_url":"git://github.com/gradle/gradle.git","ssh_url":"git@github.com:gradle/gradle.git","clone_url":"https://github.com/gradle/gradle.git","svn_url":"https://github.com/gradle/gradle","homepage":"https://gradle.org","size":236313,"stargazers_count":7722,"watchers_count":7722,"language":"Groovy","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":2348,"mirror_url":null,"archived":false,"open_issues_count":1281,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2348,"open_issues":1281,"watchers":7722,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gradle/gradle/pulls/7337"},"html":{"href":"https://github.com/gradle/gradle/pull/7337"},"issue":{"href":"https://api.github.com/repos/gradle/gradle/issues/7337"},"comments":{"href":"https://api.github.com/repos/gradle/gradle/issues/7337/comments"},"review_comments":{"href":"https://api.github.com/repos/gradle/gradle/pulls/7337/comments"},"review_comment":{"href":"https://api.github.com/repos/gradle/gradle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gradle/gradle/pulls/7337/commits"},"statuses":{"href":"https://api.github.com/repos/gradle/gradle/statuses/7c90e1f6fcecee4641b4ce07cc3bc655607fab20"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"wolfs"}}