{"action":"created","issue":{"url":"https://api.github.com/repos/civicrm/civicrm-core/issues/13013","repository_url":"https://api.github.com/repos/civicrm/civicrm-core","labels_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/13013/labels{/name}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/13013/comments","events_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/13013/events","html_url":"https://github.com/civicrm/civicrm-core/pull/13013","id":374161926,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1OTI3Mjkw","number":13013,"title":"Prototype for metadata based fields on search screens.","user":{"login":"eileenmcnaughton","id":336308,"node_id":"MDQ6VXNlcjMzNjMwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/336308?v=4","gravatar_id":"","url":"https://api.github.com/users/eileenmcnaughton","html_url":"https://github.com/eileenmcnaughton","followers_url":"https://api.github.com/users/eileenmcnaughton/followers","following_url":"https://api.github.com/users/eileenmcnaughton/following{/other_user}","gists_url":"https://api.github.com/users/eileenmcnaughton/gists{/gist_id}","starred_url":"https://api.github.com/users/eileenmcnaughton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eileenmcnaughton/subscriptions","organizations_url":"https://api.github.com/users/eileenmcnaughton/orgs","repos_url":"https://api.github.com/users/eileenmcnaughton/repos","events_url":"https://api.github.com/users/eileenmcnaughton/events{/privacy}","received_events_url":"https://api.github.com/users/eileenmcnaughton/received_events","type":"User","site_admin":false},"labels":[{"id":246037889,"node_id":"MDU6TGFiZWwyNDYwMzc4ODk=","url":"https://api.github.com/repos/civicrm/civicrm-core/labels/master","name":"master","color":"0052cc","default":false},{"id":275096971,"node_id":"MDU6TGFiZWwyNzUwOTY5NzE=","url":"https://api.github.com/repos/civicrm/civicrm-core/labels/merge%20on%20pass","name":"merge on pass","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-10-25T22:45:07Z","updated_at":"2018-12-04T03:53:20Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/13013","html_url":"https://github.com/civicrm/civicrm-core/pull/13013","diff_url":"https://github.com/civicrm/civicrm-core/pull/13013.diff","patch_url":"https://github.com/civicrm/civicrm-core/pull/13013.patch"},"body":"Overview\r\n----------------------------------------\r\nIntroduces methodology to clean up search forms.\r\n\r\nBefore\r\n----------------------------------------\r\nNo clear plan for where to go with search forms\r\n\r\nAfter\r\n----------------------------------------\r\nEntity-form type approach intiated. Also activity search can take activity_type_id (as the only converted field) in the url to set defaults :-)\r\n\r\nTechnical Details\r\n----------------------------------------\r\nThis is a first step towards making search screens more metadata driven. It switches the activity_type_id field to being metadata-added and adds support for activity_type_id=1 via the url.\r\n\r\nThe setting of defaults is more like 'normal' forms where they are loaded & can be changed in the UI\r\nrather than 'search methods' where they only work in conjunction with 'force'\r\n(which also still works).\r\n\r\nThis comes out of my concern that\r\na) we already have url defaults added badly on this form &\r\nb) we have had more than one PR to add more defaults - eg. https://github.com/civicrm/civicrm-core/pull/12455\r\n\r\nSo I think we should define how we really want entity data to be used with search forms & move towards it.\r\n\r\nNote also that the tpls for Contribution Search and one of the contact search panes have been amended to\r\nbe metadata driven. I haven't tried to align with that in this step but it should be down the track\r\n\r\nComments\r\n----------------------------------------\r\nping @mattwire @colemanw @jitendrapurohit @monishdeb @seamuslee001 \r\n"},"comment":{"url":"https://api.github.com/repos/civicrm/civicrm-core/issues/comments/443961499","html_url":"https://github.com/civicrm/civicrm-core/pull/13013#issuecomment-443961499","issue_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/13013","id":443961499,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Mzk2MTQ5OQ==","user":{"login":"seamuslee001","id":6799125,"node_id":"MDQ6VXNlcjY3OTkxMjU=","avatar_url":"https://avatars2.githubusercontent.com/u/6799125?v=4","gravatar_id":"","url":"https://api.github.com/users/seamuslee001","html_url":"https://github.com/seamuslee001","followers_url":"https://api.github.com/users/seamuslee001/followers","following_url":"https://api.github.com/users/seamuslee001/following{/other_user}","gists_url":"https://api.github.com/users/seamuslee001/gists{/gist_id}","starred_url":"https://api.github.com/users/seamuslee001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seamuslee001/subscriptions","organizations_url":"https://api.github.com/users/seamuslee001/orgs","repos_url":"https://api.github.com/users/seamuslee001/repos","events_url":"https://api.github.com/users/seamuslee001/events{/privacy}","received_events_url":"https://api.github.com/users/seamuslee001/received_events","type":"User","site_admin":false},"created_at":"2018-12-04T03:53:20Z","updated_at":"2018-12-04T03:53:20Z","author_association":"CONTRIBUTOR","body":"Merging as per the tag"}}
{"actor":{"display_login":"seamuslee001"}}