{"action":"created","issue":{"url":"https://api.github.com/repos/WordImpress/Give/issues/2936","repository_url":"https://api.github.com/repos/WordImpress/Give","labels_url":"https://api.github.com/repos/WordImpress/Give/issues/2936/labels{/name}","comments_url":"https://api.github.com/repos/WordImpress/Give/issues/2936/comments","events_url":"https://api.github.com/repos/WordImpress/Give/issues/2936/events","html_url":"https://github.com/WordImpress/Give/pull/2936","id":307237891,"number":2936,"title":"feat: enable sequential ordering #244","user":{"login":"ravinderk","id":1784821,"avatar_url":"https://avatars0.githubusercontent.com/u/1784821?v=4","gravatar_id":"","url":"https://api.github.com/users/ravinderk","html_url":"https://github.com/ravinderk","followers_url":"https://api.github.com/users/ravinderk/followers","following_url":"https://api.github.com/users/ravinderk/following{/other_user}","gists_url":"https://api.github.com/users/ravinderk/gists{/gist_id}","starred_url":"https://api.github.com/users/ravinderk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravinderk/subscriptions","organizations_url":"https://api.github.com/users/ravinderk/orgs","repos_url":"https://api.github.com/users/ravinderk/repos","events_url":"https://api.github.com/users/ravinderk/events{/privacy}","received_events_url":"https://api.github.com/users/ravinderk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-03-21T13:10:17Z","updated_at":"2018-03-23T05:38:40Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/WordImpress/Give/pulls/2936","html_url":"https://github.com/WordImpress/Give/pull/2936","diff_url":"https://github.com/WordImpress/Give/pull/2936.diff","patch_url":"https://github.com/WordImpress/Give/pull/2936.patch"},"body":"## Description\r\nThis PR will close #244 \r\n\r\n## How Has This Been Tested?\r\n- [x] Test with manually creating donations\r\n- [x] Test donation detail page\r\n- [x] Test Log setting page\r\n- [x] Test table give_sequential_ordering  table\r\n- [x]  Test Page title (serial code) on donations\r\n- [x] Test receipt\r\n- [x] Test history page\r\n- [x] Test sequential ordering setting page\r\n- [x] Test with Stripe and Razorpay\r\n- [x] Test with pdf receipt addon https://github.com/WordImpress/Give-PDF-Receipts/tree/give210/sequential-donation-compatibility\r\n- [x] Test PHPUnit\r\n\r\n## Screenshots (jpeg or gifs if applicable):\r\n![2a2ta2zi9e](https://user-images.githubusercontent.com/1784821/37770411-55c971ee-2dfa-11e8-80a1-383f1a8067e5.gif)\r\n![screen shot 2018-03-22 at 6 03 02 pm](https://user-images.githubusercontent.com/1784821/37771057-6a068cc6-2dfc-11e8-8056-a2fccf836928.png)\r\n![image](https://user-images.githubusercontent.com/1784821/37770422-5f956df4-2dfa-11e8-96b4-0dd1146f68a2.png)\r\n![image](https://user-images.githubusercontent.com/1784821/37770433-69364f0e-2dfa-11e8-95e4-bbb0bf01fb17.png)\r\n![image](https://user-images.githubusercontent.com/1784821/37770462-7ee46ea8-2dfa-11e8-9056-69287e488ac5.png)\r\n![image](https://user-images.githubusercontent.com/1784821/37770662-2306c8b4-2dfb-11e8-861c-0642f4f361f3.png)\r\n\r\n## Types of changes\r\nNew feature (the non-breaking change which adds functionality)\r\n\r\n## Noticeable changes\r\n- Some unused deprecated function removed:\r\n  - `give_format_payment_number `\r\n  - `give_get_next_payment_number `\r\n  - `give_remove_payment_prefix_postfix `\r\n- Remove following unused setting keys:\r\n  - `enable_sequential `\r\n  - `sequential_prefix`\r\n  - `sequential_postfix `\r\n  - `give_last_payment_number`\r\n- Sinve we are storingdonation number in `post_title` then ther are no need of custom serch logic: https://github.com/WordImpress/Give/pull/2936/files#diff-b594a31ba846d2a8e7d09d6c474364c0L597\r\n- New table introduce `give_sequential_ordering` whic has two column `id` and `payment_id`\r\n- Added new attribute `serial_number ` to `give_reciept` **(reverted. we are using `donation_id`)**\r\n- Added new email tag `serial_number` **(reverted. we are using `payment_id`)**\r\n- Updated PHPUnit test: https://github.com/WordImpress/Give/pull/2936/files#diff-31df4240052ebcab80a7d5491a2de60c\r\n- Added function to decode time tags: `give_time_do_tags`\r\n- `Give_Payment:number` will be set to serial number\r\n- Add confrim before edit feature to `radio` and `text|number|email|password` type setting field\r\n-  Donation history export will contain `Payment Number` column if feature enabled\r\n## Checklist:\r\n- [x] My code is tested.\r\n- [x] My code follows the WordPress code style.\r\n- [x] My code follows has proper inline documentation."},"comment":{"url":"https://api.github.com/repos/WordImpress/Give/issues/comments/375550783","html_url":"https://github.com/WordImpress/Give/pull/2936#issuecomment-375550783","issue_url":"https://api.github.com/repos/WordImpress/Give/issues/2936","id":375550783,"user":{"login":"ravinderk","id":1784821,"avatar_url":"https://avatars0.githubusercontent.com/u/1784821?v=4","gravatar_id":"","url":"https://api.github.com/users/ravinderk","html_url":"https://github.com/ravinderk","followers_url":"https://api.github.com/users/ravinderk/followers","following_url":"https://api.github.com/users/ravinderk/following{/other_user}","gists_url":"https://api.github.com/users/ravinderk/gists{/gist_id}","starred_url":"https://api.github.com/users/ravinderk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravinderk/subscriptions","organizations_url":"https://api.github.com/users/ravinderk/orgs","repos_url":"https://api.github.com/users/ravinderk/repos","events_url":"https://api.github.com/users/ravinderk/events{/privacy}","received_events_url":"https://api.github.com/users/ravinderk/received_events","type":"User","site_admin":false},"created_at":"2018-03-23T05:38:40Z","updated_at":"2018-03-23T05:38:40Z","author_association":"COLLABORATOR","body":"@DevinWalker Fixed."}}
{"actor":{"display_login":"ravinderk"}}