{"action":"created","issue":{"url":"https://api.github.com/repos/lm-sensors/lm-sensors/issues/148","repository_url":"https://api.github.com/repos/lm-sensors/lm-sensors","labels_url":"https://api.github.com/repos/lm-sensors/lm-sensors/issues/148/labels{/name}","comments_url":"https://api.github.com/repos/lm-sensors/lm-sensors/issues/148/comments","events_url":"https://api.github.com/repos/lm-sensors/lm-sensors/issues/148/events","html_url":"https://github.com/lm-sensors/lm-sensors/issues/148","id":386576425,"node_id":"MDU6SXNzdWUzODY1NzY0MjU=","number":148,"title":"SENSORS_API_VERSION is not useful anymore after 3.5.0 + unwanted LIBMAINVER bump","user":{"login":"rpv-tomsk","id":13328211,"node_id":"MDQ6VXNlcjEzMzI4MjEx","avatar_url":"https://avatars2.githubusercontent.com/u/13328211?v=4","gravatar_id":"","url":"https://api.github.com/users/rpv-tomsk","html_url":"https://github.com/rpv-tomsk","followers_url":"https://api.github.com/users/rpv-tomsk/followers","following_url":"https://api.github.com/users/rpv-tomsk/following{/other_user}","gists_url":"https://api.github.com/users/rpv-tomsk/gists{/gist_id}","starred_url":"https://api.github.com/users/rpv-tomsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpv-tomsk/subscriptions","organizations_url":"https://api.github.com/users/rpv-tomsk/orgs","repos_url":"https://api.github.com/users/rpv-tomsk/repos","events_url":"https://api.github.com/users/rpv-tomsk/events{/privacy}","received_events_url":"https://api.github.com/users/rpv-tomsk/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-12-02T16:41:41Z","updated_at":"2018-12-03T11:23:26Z","closed_at":"2018-12-03T09:33:28Z","author_association":"NONE","body":"1)  Commit e8afbda10fba571c816abddcb5c8180afc435bba, SENSORS_API_VERSION\r\n\r\nBy your such decision and release you break all idea of SENSORS_API_VERSION.\r\n\r\nFirst digit was intended to change only when API changed and code have to be _rewritten_ to work properly with new lm_sensors release.\r\n\r\n2)  Commit e8afbda10fba571c816abddcb5c8180afc435bba, LIBMAINVER\r\n\r\nAs stated in `lib/Module.mk`:\r\n\r\n```\r\n# The library soname (major number) must be changed if and only if the interface is\r\n# changed in a backward incompatible way.  The interface is defined by\t\r\n# the public header files - in this case they are error.h and sensors.h.\t\r\n```\r\n\r\n@olysonek, Ondřej,  can you  please point me, where you have find \"interface is changed in a backward incompatible way\", so you decided to bump major version?\r\n\r\nI think many people and package maintainers will say thanks to you, as existing packages will stop working after upgrade to 3.5.0 due to missing libsensors.so.4 library. While that have not to happen.\r\n\r\n3) Commits, which only adds new enums or flags have to not break ABI.\r\n\r\nAnd dcf23676cc264927ad58ae7960f518689372741a is wrong about this rule.\r\nYou haven't break ABI only to keep lists of subfeatures \"sorted\".\r\n\r\nUPD: After some looking into that change, I think there ever was no ABI change.\r\n\r\nThat change is really minor change and only last, third digit really have to be changed.\r\nOk, maybe second digit, but not first!\r\n\r\nPeople have forgotten how to think ahead.\r\nPeople have forgotten how to think.\r\n\r\nUnfortunately, there are no other people on this planet."},"comment":{"url":"https://api.github.com/repos/lm-sensors/lm-sensors/issues/comments/443676997","html_url":"https://github.com/lm-sensors/lm-sensors/issues/148#issuecomment-443676997","issue_url":"https://api.github.com/repos/lm-sensors/lm-sensors/issues/148","id":443676997,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzY3Njk5Nw==","user":{"login":"rpv-tomsk","id":13328211,"node_id":"MDQ6VXNlcjEzMzI4MjEx","avatar_url":"https://avatars2.githubusercontent.com/u/13328211?v=4","gravatar_id":"","url":"https://api.github.com/users/rpv-tomsk","html_url":"https://github.com/rpv-tomsk","followers_url":"https://api.github.com/users/rpv-tomsk/followers","following_url":"https://api.github.com/users/rpv-tomsk/following{/other_user}","gists_url":"https://api.github.com/users/rpv-tomsk/gists{/gist_id}","starred_url":"https://api.github.com/users/rpv-tomsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpv-tomsk/subscriptions","organizations_url":"https://api.github.com/users/rpv-tomsk/orgs","repos_url":"https://api.github.com/users/rpv-tomsk/repos","events_url":"https://api.github.com/users/rpv-tomsk/events{/privacy}","received_events_url":"https://api.github.com/users/rpv-tomsk/received_events","type":"User","site_admin":false},"created_at":"2018-12-03T11:23:26Z","updated_at":"2018-12-03T11:23:26Z","author_association":"NONE","body":">So keep calm, rebuild dependent packages and carry on.\r\n\r\nYou forget to recommend to \"Update your code, which checks SENSORS_API_VERSION, then ...\"."}}
{"actor":{"display_login":"rpv-tomsk"}}