{"action":"created","comment":{"url":"https://api.github.com/repos/minio/minio/pulls/comments/167385358","pull_request_review_id":95608689,"id":167385358,"diff_hunk":"@@ -54,37 +49,27 @@ export class Login extends React.Component {\n         history.push(minioBrowserPrefix)\n       })\n       .catch(e => {\n-        dispatch(\n-          actionsAlert.set({\n-            type: \"danger\",\n-            message: e.message\n-          })\n-        )\n+        showAlert(\"danger\", e.message)\n       })\n   }\n \n   componentWillMount() {\n-    const { dispatch } = this.props\n+    const { clearAlert } = this.props\n     // Clear out any stale message in the alert of previous page\n-    dispatch(actionsAlert.clear())\n+    clearAlert()\n     document.body.classList.add(\"is-guest\")\n   }\n \n   componentWillUnmount() {\n     document.body.classList.remove(\"is-guest\")\n   }\n \n-  clearAlert() {\n-    const { dispatch } = this.props\n-    dispatch(actionsAlert.clear())\n-  }\n-\n   render() {\n-    const { alert } = this.props\n+    const { clearAlert, alert } = this.props\n     if (web.LoggedIn()) {\n       return <Redirect to={minioBrowserPrefix} />\n     }\n-    let alertBox = <Alert {...alert} onDismiss={this.clearAlert.bind(this)} />\n+    let alertBox = <Alert {...alert} onDismiss={clearAlert.bind(this)} />","path":"browser/app/js/components/Login.js","position":null,"original_position":65,"commit_id":"d79ad30e55eaaaf0a22f77317063c760b19f4732","original_commit_id":"a4787e1f011ce29fdddd0a247a1dcdc1837e576b","user":{"login":"kmkanagaraj","id":1701932,"avatar_url":"https://avatars1.githubusercontent.com/u/1701932?v=4","gravatar_id":"","url":"https://api.github.com/users/kmkanagaraj","html_url":"https://github.com/kmkanagaraj","followers_url":"https://api.github.com/users/kmkanagaraj/followers","following_url":"https://api.github.com/users/kmkanagaraj/following{/other_user}","gists_url":"https://api.github.com/users/kmkanagaraj/gists{/gist_id}","starred_url":"https://api.github.com/users/kmkanagaraj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmkanagaraj/subscriptions","organizations_url":"https://api.github.com/users/kmkanagaraj/orgs","repos_url":"https://api.github.com/users/kmkanagaraj/repos","events_url":"https://api.github.com/users/kmkanagaraj/events{/privacy}","received_events_url":"https://api.github.com/users/kmkanagaraj/received_events","type":"User","site_admin":false},"body":"@kaankabalak yes, while rebasing this PR you revert those files.","created_at":"2018-02-10T02:13:06Z","updated_at":"2018-02-10T02:13:06Z","html_url":"https://github.com/minio/minio/pull/5505#discussion_r167385358","pull_request_url":"https://api.github.com/repos/minio/minio/pulls/5505","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/minio/minio/pulls/comments/167385358"},"html":{"href":"https://github.com/minio/minio/pull/5505#discussion_r167385358"},"pull_request":{"href":"https://api.github.com/repos/minio/minio/pulls/5505"}},"in_reply_to_id":167146476},"pull_request":{"url":"https://api.github.com/repos/minio/minio/pulls/5505","id":168121819,"html_url":"https://github.com/minio/minio/pull/5505","diff_url":"https://github.com/minio/minio/pull/5505.diff","patch_url":"https://github.com/minio/minio/pull/5505.patch","issue_url":"https://api.github.com/repos/minio/minio/issues/5505","number":5505,"state":"open","locked":false,"title":"Add missing unit tests to JavaScript and React components","user":{"login":"kaankabalak","id":27314853,"avatar_url":"https://avatars2.githubusercontent.com/u/27314853?v=4","gravatar_id":"","url":"https://api.github.com/users/kaankabalak","html_url":"https://github.com/kaankabalak","followers_url":"https://api.github.com/users/kaankabalak/followers","following_url":"https://api.github.com/users/kaankabalak/following{/other_user}","gists_url":"https://api.github.com/users/kaankabalak/gists{/gist_id}","starred_url":"https://api.github.com/users/kaankabalak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaankabalak/subscriptions","organizations_url":"https://api.github.com/users/kaankabalak/orgs","repos_url":"https://api.github.com/users/kaankabalak/repos","events_url":"https://api.github.com/users/kaankabalak/events{/privacy}","received_events_url":"https://api.github.com/users/kaankabalak/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\nThis commit adds the missing unit tests from the first PR (#5444) that provides\r\nlogin, bucket listing, and bucket searching functionalities. Small\r\nadjustments were also made to the Login component to make testing\r\neasier.\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\nPart of #5410\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\nManually for the Login component by logging in with correct credentials and trying to log in with incorrect credentials. The unit tests were checked by running them to see if there were any problems.\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I have added unit tests to cover my changes.\r\n- [ ] I have added/updated functional tests in [mint](https://github.com/minio/mint). (If yes, add `mint` PR # here: )\r\n- [x] All new and existing tests passed.","created_at":"2018-02-09T00:09:04Z","updated_at":"2018-02-10T02:13:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"794bd17c5f4d6c90616acea162f16445207b9c91","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/minio/minio/pulls/5505/commits","review_comments_url":"https://api.github.com/repos/minio/minio/pulls/5505/comments","review_comment_url":"https://api.github.com/repos/minio/minio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minio/minio/issues/5505/comments","statuses_url":"https://api.github.com/repos/minio/minio/statuses/d79ad30e55eaaaf0a22f77317063c760b19f4732","head":{"label":"kaankabalak:unit-tests","ref":"unit-tests","sha":"d79ad30e55eaaaf0a22f77317063c760b19f4732","user":{"login":"kaankabalak","id":27314853,"avatar_url":"https://avatars2.githubusercontent.com/u/27314853?v=4","gravatar_id":"","url":"https://api.github.com/users/kaankabalak","html_url":"https://github.com/kaankabalak","followers_url":"https://api.github.com/users/kaankabalak/followers","following_url":"https://api.github.com/users/kaankabalak/following{/other_user}","gists_url":"https://api.github.com/users/kaankabalak/gists{/gist_id}","starred_url":"https://api.github.com/users/kaankabalak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaankabalak/subscriptions","organizations_url":"https://api.github.com/users/kaankabalak/orgs","repos_url":"https://api.github.com/users/kaankabalak/repos","events_url":"https://api.github.com/users/kaankabalak/events{/privacy}","received_events_url":"https://api.github.com/users/kaankabalak/received_events","type":"User","site_admin":false},"repo":{"id":112784351,"name":"minio","full_name":"kaankabalak/minio","owner":{"login":"kaankabalak","id":27314853,"avatar_url":"https://avatars2.githubusercontent.com/u/27314853?v=4","gravatar_id":"","url":"https://api.github.com/users/kaankabalak","html_url":"https://github.com/kaankabalak","followers_url":"https://api.github.com/users/kaankabalak/followers","following_url":"https://api.github.com/users/kaankabalak/following{/other_user}","gists_url":"https://api.github.com/users/kaankabalak/gists{/gist_id}","starred_url":"https://api.github.com/users/kaankabalak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaankabalak/subscriptions","organizations_url":"https://api.github.com/users/kaankabalak/orgs","repos_url":"https://api.github.com/users/kaankabalak/repos","events_url":"https://api.github.com/users/kaankabalak/events{/privacy}","received_events_url":"https://api.github.com/users/kaankabalak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kaankabalak/minio","description":"Minio is an open source object storage server compatible with Amazon S3 APIs","fork":true,"url":"https://api.github.com/repos/kaankabalak/minio","forks_url":"https://api.github.com/repos/kaankabalak/minio/forks","keys_url":"https://api.github.com/repos/kaankabalak/minio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaankabalak/minio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaankabalak/minio/teams","hooks_url":"https://api.github.com/repos/kaankabalak/minio/hooks","issue_events_url":"https://api.github.com/repos/kaankabalak/minio/issues/events{/number}","events_url":"https://api.github.com/repos/kaankabalak/minio/events","assignees_url":"https://api.github.com/repos/kaankabalak/minio/assignees{/user}","branches_url":"https://api.github.com/repos/kaankabalak/minio/branches{/branch}","tags_url":"https://api.github.com/repos/kaankabalak/minio/tags","blobs_url":"https://api.github.com/repos/kaankabalak/minio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaankabalak/minio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaankabalak/minio/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaankabalak/minio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaankabalak/minio/statuses/{sha}","languages_url":"https://api.github.com/repos/kaankabalak/minio/languages","stargazers_url":"https://api.github.com/repos/kaankabalak/minio/stargazers","contributors_url":"https://api.github.com/repos/kaankabalak/minio/contributors","subscribers_url":"https://api.github.com/repos/kaankabalak/minio/subscribers","subscription_url":"https://api.github.com/repos/kaankabalak/minio/subscription","commits_url":"https://api.github.com/repos/kaankabalak/minio/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaankabalak/minio/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaankabalak/minio/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaankabalak/minio/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaankabalak/minio/contents/{+path}","compare_url":"https://api.github.com/repos/kaankabalak/minio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaankabalak/minio/merges","archive_url":"https://api.github.com/repos/kaankabalak/minio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaankabalak/minio/downloads","issues_url":"https://api.github.com/repos/kaankabalak/minio/issues{/number}","pulls_url":"https://api.github.com/repos/kaankabalak/minio/pulls{/number}","milestones_url":"https://api.github.com/repos/kaankabalak/minio/milestones{/number}","notifications_url":"https://api.github.com/repos/kaankabalak/minio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaankabalak/minio/labels{/name}","releases_url":"https://api.github.com/repos/kaankabalak/minio/releases{/id}","deployments_url":"https://api.github.com/repos/kaankabalak/minio/deployments","created_at":"2017-12-01T20:36:41Z","updated_at":"2017-12-01T20:36:45Z","pushed_at":"2018-02-09T18:45:53Z","git_url":"git://github.com/kaankabalak/minio.git","ssh_url":"git@github.com:kaankabalak/minio.git","clone_url":"https://github.com/kaankabalak/minio.git","svn_url":"https://github.com/kaankabalak/minio","homepage":"https://minio.io/downloads.html#download-server","size":31706,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minio:newux","ref":"newux","sha":"767c586a35f95e5ef8cc698974e057fd8edc8866","user":{"login":"minio","id":695951,"avatar_url":"https://avatars3.githubusercontent.com/u/695951?v=4","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"repo":{"id":29261473,"name":"minio","full_name":"minio/minio","owner":{"login":"minio","id":695951,"avatar_url":"https://avatars3.githubusercontent.com/u/695951?v=4","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minio/minio","description":"Minio is an open source object storage server compatible with Amazon S3 APIs","fork":false,"url":"https://api.github.com/repos/minio/minio","forks_url":"https://api.github.com/repos/minio/minio/forks","keys_url":"https://api.github.com/repos/minio/minio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minio/minio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minio/minio/teams","hooks_url":"https://api.github.com/repos/minio/minio/hooks","issue_events_url":"https://api.github.com/repos/minio/minio/issues/events{/number}","events_url":"https://api.github.com/repos/minio/minio/events","assignees_url":"https://api.github.com/repos/minio/minio/assignees{/user}","branches_url":"https://api.github.com/repos/minio/minio/branches{/branch}","tags_url":"https://api.github.com/repos/minio/minio/tags","blobs_url":"https://api.github.com/repos/minio/minio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minio/minio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minio/minio/git/refs{/sha}","trees_url":"https://api.github.com/repos/minio/minio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minio/minio/statuses/{sha}","languages_url":"https://api.github.com/repos/minio/minio/languages","stargazers_url":"https://api.github.com/repos/minio/minio/stargazers","contributors_url":"https://api.github.com/repos/minio/minio/contributors","subscribers_url":"https://api.github.com/repos/minio/minio/subscribers","subscription_url":"https://api.github.com/repos/minio/minio/subscription","commits_url":"https://api.github.com/repos/minio/minio/commits{/sha}","git_commits_url":"https://api.github.com/repos/minio/minio/git/commits{/sha}","comments_url":"https://api.github.com/repos/minio/minio/comments{/number}","issue_comment_url":"https://api.github.com/repos/minio/minio/issues/comments{/number}","contents_url":"https://api.github.com/repos/minio/minio/contents/{+path}","compare_url":"https://api.github.com/repos/minio/minio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minio/minio/merges","archive_url":"https://api.github.com/repos/minio/minio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minio/minio/downloads","issues_url":"https://api.github.com/repos/minio/minio/issues{/number}","pulls_url":"https://api.github.com/repos/minio/minio/pulls{/number}","milestones_url":"https://api.github.com/repos/minio/minio/milestones{/number}","notifications_url":"https://api.github.com/repos/minio/minio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minio/minio/labels{/name}","releases_url":"https://api.github.com/repos/minio/minio/releases{/id}","deployments_url":"https://api.github.com/repos/minio/minio/deployments","created_at":"2015-01-14T19:23:58Z","updated_at":"2018-02-09T23:35:10Z","pushed_at":"2018-02-10T01:30:42Z","git_url":"git://github.com/minio/minio.git","ssh_url":"git@github.com:minio/minio.git","clone_url":"https://github.com/minio/minio.git","svn_url":"https://github.com/minio/minio","homepage":"https://minio.io/downloads.html#download-server","size":31257,"stargazers_count":10026,"watchers_count":10026,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":836,"mirror_url":null,"archived":false,"open_issues_count":113,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":836,"open_issues":113,"watchers":10026,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minio/minio/pulls/5505"},"html":{"href":"https://github.com/minio/minio/pull/5505"},"issue":{"href":"https://api.github.com/repos/minio/minio/issues/5505"},"comments":{"href":"https://api.github.com/repos/minio/minio/issues/5505/comments"},"review_comments":{"href":"https://api.github.com/repos/minio/minio/pulls/5505/comments"},"review_comment":{"href":"https://api.github.com/repos/minio/minio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minio/minio/pulls/5505/commits"},"statuses":{"href":"https://api.github.com/repos/minio/minio/statuses/d79ad30e55eaaaf0a22f77317063c760b19f4732"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"kmkanagaraj"}}