{"action":"created","issue":{"url":"https://api.github.com/repos/hezmondo/Jinn/issues/127","repository_url":"https://api.github.com/repos/hezmondo/Jinn","labels_url":"https://api.github.com/repos/hezmondo/Jinn/issues/127/labels{/name}","comments_url":"https://api.github.com/repos/hezmondo/Jinn/issues/127/comments","events_url":"https://api.github.com/repos/hezmondo/Jinn/issues/127/events","html_url":"https://github.com/hezmondo/Jinn/issues/127","id":374307329,"node_id":"MDU6SXNzdWUzNzQzMDczMjk=","number":127,"title":"Allow \"Restore Jinn files\" to overwrite destination directory contents","user":{"login":"jnbarchan","id":16286415,"node_id":"MDQ6VXNlcjE2Mjg2NDE1","avatar_url":"https://avatars0.githubusercontent.com/u/16286415?v=4","gravatar_id":"","url":"https://api.github.com/users/jnbarchan","html_url":"https://github.com/jnbarchan","followers_url":"https://api.github.com/users/jnbarchan/followers","following_url":"https://api.github.com/users/jnbarchan/following{/other_user}","gists_url":"https://api.github.com/users/jnbarchan/gists{/gist_id}","starred_url":"https://api.github.com/users/jnbarchan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnbarchan/subscriptions","organizations_url":"https://api.github.com/users/jnbarchan/orgs","repos_url":"https://api.github.com/users/jnbarchan/repos","events_url":"https://api.github.com/users/jnbarchan/events{/privacy}","received_events_url":"https://api.github.com/users/jnbarchan/received_events","type":"User","site_admin":false},"labels":[{"id":644043610,"node_id":"MDU6TGFiZWw2NDQwNDM2MTA=","url":"https://api.github.com/repos/hezmondo/Jinn/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":{"login":"jnbarchan","id":16286415,"node_id":"MDQ6VXNlcjE2Mjg2NDE1","avatar_url":"https://avatars0.githubusercontent.com/u/16286415?v=4","gravatar_id":"","url":"https://api.github.com/users/jnbarchan","html_url":"https://github.com/jnbarchan","followers_url":"https://api.github.com/users/jnbarchan/followers","following_url":"https://api.github.com/users/jnbarchan/following{/other_user}","gists_url":"https://api.github.com/users/jnbarchan/gists{/gist_id}","starred_url":"https://api.github.com/users/jnbarchan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnbarchan/subscriptions","organizations_url":"https://api.github.com/users/jnbarchan/orgs","repos_url":"https://api.github.com/users/jnbarchan/repos","events_url":"https://api.github.com/users/jnbarchan/events{/privacy}","received_events_url":"https://api.github.com/users/jnbarchan/received_events","type":"User","site_admin":false},"assignees":[{"login":"jnbarchan","id":16286415,"node_id":"MDQ6VXNlcjE2Mjg2NDE1","avatar_url":"https://avatars0.githubusercontent.com/u/16286415?v=4","gravatar_id":"","url":"https://api.github.com/users/jnbarchan","html_url":"https://github.com/jnbarchan","followers_url":"https://api.github.com/users/jnbarchan/followers","following_url":"https://api.github.com/users/jnbarchan/following{/other_user}","gists_url":"https://api.github.com/users/jnbarchan/gists{/gist_id}","starred_url":"https://api.github.com/users/jnbarchan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnbarchan/subscriptions","organizations_url":"https://api.github.com/users/jnbarchan/orgs","repos_url":"https://api.github.com/users/jnbarchan/repos","events_url":"https://api.github.com/users/jnbarchan/events{/privacy}","received_events_url":"https://api.github.com/users/jnbarchan/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-10-26T09:46:54Z","updated_at":"2018-11-09T15:05:36Z","closed_at":null,"author_association":"COLLABORATOR","body":"When doing a **Restore Jinn files**, the restore command uses \"merge\" rather than \"overwrite/replace\".  This means that any existing files in the destination but not in the source backup are preserved, not deleted.\r\n\r\nWhen I originally wrote the script command it did overwrite/replace, as I felt that was what should be wanted.  However, H. felt that was too \"dangerous\", so I changed to merge/preserve.\r\n\r\nNow R. deletes unwanted output Rent directories etc. when he backs up on one machine.  Then when he restores on another machine those directories do not get removed.  And if he then backs up and restores back to original backup machine, the directories get re-created there too.  Which he does not want.\r\n\r\nWe should add a checkbox option for mirror instead of merge (defaulting to merge for safety).  This affects both Backup & Restore.\r\n\r\nAs a further element of safety, to prevent the inevitable catastrophic Restore with overwrite to completely the wrong place which will then blat everything there and we will get blamed, I suggest: if the destination already exists, check that our `Backups/ZLastBackupDate` file exists and warn if not --- the best we can do to make sure it's not somewhere stupid."},"comment":{"url":"https://api.github.com/repos/hezmondo/Jinn/issues/comments/437386733","html_url":"https://github.com/hezmondo/Jinn/issues/127#issuecomment-437386733","issue_url":"https://api.github.com/repos/hezmondo/Jinn/issues/127","id":437386733,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzM4NjczMw==","user":{"login":"jnbarchan","id":16286415,"node_id":"MDQ6VXNlcjE2Mjg2NDE1","avatar_url":"https://avatars0.githubusercontent.com/u/16286415?v=4","gravatar_id":"","url":"https://api.github.com/users/jnbarchan","html_url":"https://github.com/jnbarchan","followers_url":"https://api.github.com/users/jnbarchan/followers","following_url":"https://api.github.com/users/jnbarchan/following{/other_user}","gists_url":"https://api.github.com/users/jnbarchan/gists{/gist_id}","starred_url":"https://api.github.com/users/jnbarchan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnbarchan/subscriptions","organizations_url":"https://api.github.com/users/jnbarchan/orgs","repos_url":"https://api.github.com/users/jnbarchan/repos","events_url":"https://api.github.com/users/jnbarchan/events{/privacy}","received_events_url":"https://api.github.com/users/jnbarchan/received_events","type":"User","site_admin":false},"created_at":"2018-11-09T15:05:36Z","updated_at":"2018-11-09T15:05:36Z","author_association":"COLLABORATOR","body":"* Introduced a dialog and added the **Merge**/**Mirror** options to **Backup/Restore Jinn files**.\r\n\r\n* Changed caller to pass this onto scripts.\r\n\r\n* Changed scripts to obey **mirror** if specified.\r\n  - Windows scripts need testing.\r\n"}}
{"actor":{"display_login":"jnbarchan"}}