{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/comments/230468272","pull_request_review_id":171218534,"id":230468272,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDQ2ODI3Mg==","diff_hunk":"@@ -225,6 +226,14 @@ func (c *Controller) startController(tc *corev1a1.FederatedTypeConfig) error {\n \t\treturn fmt.Errorf(\"Error starting sync controller for %q: %v\", kind, err)\n \t}\n \tglog.Infof(\"Started sync controller for %q\", kind)\n+\tif tc.GetEnableStatus() {","path":"pkg/controller/federatedtypeconfig/controller.go","position":12,"original_position":12,"commit_id":"4a225c3fb37d8812c70ce2e9d33357c4bed24ba0","original_commit_id":"4a225c3fb37d8812c70ce2e9d33357c4bed24ba0","user":{"login":"marun","id":451477,"node_id":"MDQ6VXNlcjQ1MTQ3Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/451477?v=4","gravatar_id":"","url":"https://api.github.com/users/marun","html_url":"https://github.com/marun","followers_url":"https://api.github.com/users/marun/followers","following_url":"https://api.github.com/users/marun/following{/other_user}","gists_url":"https://api.github.com/users/marun/gists{/gist_id}","starred_url":"https://api.github.com/users/marun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marun/subscriptions","organizations_url":"https://api.github.com/users/marun/orgs","repos_url":"https://api.github.com/users/marun/repos","events_url":"https://api.github.com/users/marun/events{/privacy}","received_events_url":"https://api.github.com/users/marun/received_events","type":"User","site_admin":false},"body":"Should it be possible to stop a status controller without restarting the controller manager, as is possible for sync controllers?\r\n\r\nGiven that this is now the 3rd (sync and #366 being 1 and 2) controller whose state depends on `FederatedTypeConfig`, it probably makes sense for future work to target either a more extensible controller or a framework that simplifies creating new ones.  \r\n\r\ncc: @irfanurrehman ","created_at":"2018-11-02T18:29:51Z","updated_at":"2018-11-02T18:55:02Z","html_url":"https://github.com/kubernetes-sigs/federation-v2/pull/291#discussion_r230468272","pull_request_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/291","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/comments/230468272"},"html":{"href":"https://github.com/kubernetes-sigs/federation-v2/pull/291#discussion_r230468272"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/291"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/291","id":218370354,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MzcwMzU0","html_url":"https://github.com/kubernetes-sigs/federation-v2/pull/291","diff_url":"https://github.com/kubernetes-sigs/federation-v2/pull/291.diff","patch_url":"https://github.com/kubernetes-sigs/federation-v2/pull/291.patch","issue_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/issues/291","number":291,"state":"open","locked":false,"title":"Generic status for federated types","user":{"login":"shashidharatd","id":8734900,"node_id":"MDQ6VXNlcjg3MzQ5MDA=","avatar_url":"https://avatars3.githubusercontent.com/u/8734900?v=4","gravatar_id":"","url":"https://api.github.com/users/shashidharatd","html_url":"https://github.com/shashidharatd","followers_url":"https://api.github.com/users/shashidharatd/followers","following_url":"https://api.github.com/users/shashidharatd/following{/other_user}","gists_url":"https://api.github.com/users/shashidharatd/gists{/gist_id}","starred_url":"https://api.github.com/users/shashidharatd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shashidharatd/subscriptions","organizations_url":"https://api.github.com/users/shashidharatd/orgs","repos_url":"https://api.github.com/users/shashidharatd/repos","events_url":"https://api.github.com/users/shashidharatd/events{/privacy}","received_events_url":"https://api.github.com/users/shashidharatd/received_events","type":"User","site_admin":false},"body":"This is the rework of https://github.com/kubernetes-sigs/federation-v2/pull/247. As discussed in community meeting the status function should work independent of sync controller and status should be a separate api object.\r\n\r\ntests are still pending. i am raising this pr to get general consensus on the direction for this pr.\r\n\r\n/cc @pmorie @marun @kubernetes-sigs/federation-wg","created_at":"2018-09-26T15:56:12Z","updated_at":"2018-11-02T18:55:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"085dfd717cfbbbef6e26c1bd060ecd3ea7c1a451","assignee":null,"assignees":[],"requested_reviewers":[{"login":"pmorie","id":366488,"node_id":"MDQ6VXNlcjM2NjQ4OA==","avatar_url":"https://avatars2.githubusercontent.com/u/366488?v=4","gravatar_id":"","url":"https://api.github.com/users/pmorie","html_url":"https://github.com/pmorie","followers_url":"https://api.github.com/users/pmorie/followers","following_url":"https://api.github.com/users/pmorie/following{/other_user}","gists_url":"https://api.github.com/users/pmorie/gists{/gist_id}","starred_url":"https://api.github.com/users/pmorie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmorie/subscriptions","organizations_url":"https://api.github.com/users/pmorie/orgs","repos_url":"https://api.github.com/users/pmorie/repos","events_url":"https://api.github.com/users/pmorie/events{/privacy}","received_events_url":"https://api.github.com/users/pmorie/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":909764227,"node_id":"MDU6TGFiZWw5MDk3NjQyMjc=","url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":888036019,"node_id":"MDU6TGFiZWw4ODgwMzYwMTk=","url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":888036092,"node_id":"MDU6TGFiZWw4ODgwMzYwOTI=","url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/291/commits","review_comments_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/291/comments","review_comment_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/issues/291/comments","statuses_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/statuses/4a225c3fb37d8812c70ce2e9d33357c4bed24ba0","head":{"label":"shashidharatd:fed-status","ref":"fed-status","sha":"4a225c3fb37d8812c70ce2e9d33357c4bed24ba0","user":{"login":"shashidharatd","id":8734900,"node_id":"MDQ6VXNlcjg3MzQ5MDA=","avatar_url":"https://avatars3.githubusercontent.com/u/8734900?v=4","gravatar_id":"","url":"https://api.github.com/users/shashidharatd","html_url":"https://github.com/shashidharatd","followers_url":"https://api.github.com/users/shashidharatd/followers","following_url":"https://api.github.com/users/shashidharatd/following{/other_user}","gists_url":"https://api.github.com/users/shashidharatd/gists{/gist_id}","starred_url":"https://api.github.com/users/shashidharatd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shashidharatd/subscriptions","organizations_url":"https://api.github.com/users/shashidharatd/orgs","repos_url":"https://api.github.com/users/shashidharatd/repos","events_url":"https://api.github.com/users/shashidharatd/events{/privacy}","received_events_url":"https://api.github.com/users/shashidharatd/received_events","type":"User","site_admin":false},"repo":{"id":124896381,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ4OTYzODE=","name":"federation-v2","full_name":"shashidharatd/federation-v2","private":false,"owner":{"login":"shashidharatd","id":8734900,"node_id":"MDQ6VXNlcjg3MzQ5MDA=","avatar_url":"https://avatars3.githubusercontent.com/u/8734900?v=4","gravatar_id":"","url":"https://api.github.com/users/shashidharatd","html_url":"https://github.com/shashidharatd","followers_url":"https://api.github.com/users/shashidharatd/followers","following_url":"https://api.github.com/users/shashidharatd/following{/other_user}","gists_url":"https://api.github.com/users/shashidharatd/gists{/gist_id}","starred_url":"https://api.github.com/users/shashidharatd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shashidharatd/subscriptions","organizations_url":"https://api.github.com/users/shashidharatd/orgs","repos_url":"https://api.github.com/users/shashidharatd/repos","events_url":"https://api.github.com/users/shashidharatd/events{/privacy}","received_events_url":"https://api.github.com/users/shashidharatd/received_events","type":"User","site_admin":false},"html_url":"https://github.com/shashidharatd/federation-v2","description":"Kubernetes Federation v2 Prototype","fork":true,"url":"https://api.github.com/repos/shashidharatd/federation-v2","forks_url":"https://api.github.com/repos/shashidharatd/federation-v2/forks","keys_url":"https://api.github.com/repos/shashidharatd/federation-v2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shashidharatd/federation-v2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shashidharatd/federation-v2/teams","hooks_url":"https://api.github.com/repos/shashidharatd/federation-v2/hooks","issue_events_url":"https://api.github.com/repos/shashidharatd/federation-v2/issues/events{/number}","events_url":"https://api.github.com/repos/shashidharatd/federation-v2/events","assignees_url":"https://api.github.com/repos/shashidharatd/federation-v2/assignees{/user}","branches_url":"https://api.github.com/repos/shashidharatd/federation-v2/branches{/branch}","tags_url":"https://api.github.com/repos/shashidharatd/federation-v2/tags","blobs_url":"https://api.github.com/repos/shashidharatd/federation-v2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shashidharatd/federation-v2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shashidharatd/federation-v2/git/refs{/sha}","trees_url":"https://api.github.com/repos/shashidharatd/federation-v2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shashidharatd/federation-v2/statuses/{sha}","languages_url":"https://api.github.com/repos/shashidharatd/federation-v2/languages","stargazers_url":"https://api.github.com/repos/shashidharatd/federation-v2/stargazers","contributors_url":"https://api.github.com/repos/shashidharatd/federation-v2/contributors","subscribers_url":"https://api.github.com/repos/shashidharatd/federation-v2/subscribers","subscription_url":"https://api.github.com/repos/shashidharatd/federation-v2/subscription","commits_url":"https://api.github.com/repos/shashidharatd/federation-v2/commits{/sha}","git_commits_url":"https://api.github.com/repos/shashidharatd/federation-v2/git/commits{/sha}","comments_url":"https://api.github.com/repos/shashidharatd/federation-v2/comments{/number}","issue_comment_url":"https://api.github.com/repos/shashidharatd/federation-v2/issues/comments{/number}","contents_url":"https://api.github.com/repos/shashidharatd/federation-v2/contents/{+path}","compare_url":"https://api.github.com/repos/shashidharatd/federation-v2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shashidharatd/federation-v2/merges","archive_url":"https://api.github.com/repos/shashidharatd/federation-v2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shashidharatd/federation-v2/downloads","issues_url":"https://api.github.com/repos/shashidharatd/federation-v2/issues{/number}","pulls_url":"https://api.github.com/repos/shashidharatd/federation-v2/pulls{/number}","milestones_url":"https://api.github.com/repos/shashidharatd/federation-v2/milestones{/number}","notifications_url":"https://api.github.com/repos/shashidharatd/federation-v2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shashidharatd/federation-v2/labels{/name}","releases_url":"https://api.github.com/repos/shashidharatd/federation-v2/releases{/id}","deployments_url":"https://api.github.com/repos/shashidharatd/federation-v2/deployments","created_at":"2018-03-12T13:50:37Z","updated_at":"2018-10-03T04:19:23Z","pushed_at":"2018-11-02T06:48:15Z","git_url":"git://github.com/shashidharatd/federation-v2.git","ssh_url":"git@github.com:shashidharatd/federation-v2.git","clone_url":"https://github.com/shashidharatd/federation-v2.git","svn_url":"https://github.com/shashidharatd/federation-v2","homepage":"","size":63524,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-sigs:master","ref":"master","sha":"9e5babaddb708f9f9bf46c08275b8d146b1f82b4","user":{"login":"kubernetes-sigs","id":36015203,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDE1MjAz","avatar_url":"https://avatars1.githubusercontent.com/u/36015203?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-sigs","html_url":"https://github.com/kubernetes-sigs","followers_url":"https://api.github.com/users/kubernetes-sigs/followers","following_url":"https://api.github.com/users/kubernetes-sigs/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-sigs/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-sigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-sigs/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-sigs/orgs","repos_url":"https://api.github.com/users/kubernetes-sigs/repos","events_url":"https://api.github.com/users/kubernetes-sigs/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-sigs/received_events","type":"Organization","site_admin":false},"repo":{"id":116825580,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY4MjU1ODA=","name":"federation-v2","full_name":"kubernetes-sigs/federation-v2","private":false,"owner":{"login":"kubernetes-sigs","id":36015203,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDE1MjAz","avatar_url":"https://avatars1.githubusercontent.com/u/36015203?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-sigs","html_url":"https://github.com/kubernetes-sigs","followers_url":"https://api.github.com/users/kubernetes-sigs/followers","following_url":"https://api.github.com/users/kubernetes-sigs/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-sigs/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-sigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-sigs/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-sigs/orgs","repos_url":"https://api.github.com/users/kubernetes-sigs/repos","events_url":"https://api.github.com/users/kubernetes-sigs/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-sigs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes-sigs/federation-v2","description":"Kubernetes Federation v2 Prototype","fork":false,"url":"https://api.github.com/repos/kubernetes-sigs/federation-v2","forks_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/forks","keys_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/teams","hooks_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/events","assignees_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/tags","blobs_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/languages","stargazers_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/subscription","commits_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/merges","archive_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/downloads","issues_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/deployments","created_at":"2018-01-09T14:21:03Z","updated_at":"2018-11-02T17:26:17Z","pushed_at":"2018-11-02T17:26:11Z","git_url":"git://github.com/kubernetes-sigs/federation-v2.git","ssh_url":"git@github.com:kubernetes-sigs/federation-v2.git","clone_url":"https://github.com/kubernetes-sigs/federation-v2.git","svn_url":"https://github.com/kubernetes-sigs/federation-v2","homepage":"","size":63542,"stargazers_count":91,"watchers_count":91,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"archived":false,"open_issues_count":90,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":42,"open_issues":90,"watchers":91,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/291"},"html":{"href":"https://github.com/kubernetes-sigs/federation-v2/pull/291"},"issue":{"href":"https://api.github.com/repos/kubernetes-sigs/federation-v2/issues/291"},"comments":{"href":"https://api.github.com/repos/kubernetes-sigs/federation-v2/issues/291/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/291/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/291/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-sigs/federation-v2/statuses/4a225c3fb37d8812c70ce2e9d33357c4bed24ba0"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"marun"}}