{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/183230105","pull_request_review_id":114194363,"id":183230105,"diff_hunk":"@@ -0,0 +1,25 @@\n+<?php\n+\n+/*\n+ * This file is part of the Symfony package.\n+ *\n+ * (c) Fabien Potencier <fabien@symfony.com>\n+ *\n+ * For the full copyright and license information, please view the LICENSE\n+ * file that was distributed with this source code.\n+ */\n+\n+namespace Symfony\\Component\\PropertyInfo;\n+\n+/**\n+ * Guesses if the property can be initialized through the constructor.\n+ *\n+ * @author Kévin Dunglas <dunglas@gmail.com>\n+ */\n+interface PropertyInitializableExtractorInterface\n+{\n+    /**\n+     * Is the property initializable?\n+     */\n+    public function isInitializable(string $class, string $property, array $context = array()): ?bool;","path":"src/Symfony/Component/PropertyInfo/PropertyInitializableExtractorInterface.php","position":24,"original_position":24,"commit_id":"fdf5cf04809beaa5f95eb1f819c3540e77265deb","original_commit_id":"fdf5cf04809beaa5f95eb1f819c3540e77265deb","user":{"login":"dunglas","id":57224,"avatar_url":"https://avatars2.githubusercontent.com/u/57224?v=4","gravatar_id":"","url":"https://api.github.com/users/dunglas","html_url":"https://github.com/dunglas","followers_url":"https://api.github.com/users/dunglas/followers","following_url":"https://api.github.com/users/dunglas/following{/other_user}","gists_url":"https://api.github.com/users/dunglas/gists{/gist_id}","starred_url":"https://api.github.com/users/dunglas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dunglas/subscriptions","organizations_url":"https://api.github.com/users/dunglas/orgs","repos_url":"https://api.github.com/users/dunglas/repos","events_url":"https://api.github.com/users/dunglas/events{/privacy}","received_events_url":"https://api.github.com/users/dunglas/received_events","type":"User","site_admin":false},"body":"@teohhanhui is right. It means \"this extractor cannot guess\", try the next registered in the chain. It's mandatory to keep this behavior for consistency with existing interfaces and to provide an extension point.","created_at":"2018-04-22T09:04:40Z","updated_at":"2018-04-22T09:04:40Z","html_url":"https://github.com/symfony/symfony/pull/26997#discussion_r183230105","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/26997","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/183230105"},"html":{"href":"https://github.com/symfony/symfony/pull/26997#discussion_r183230105"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/26997"}},"in_reply_to_id":183210969},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/26997","id":183216721,"html_url":"https://github.com/symfony/symfony/pull/26997","diff_url":"https://github.com/symfony/symfony/pull/26997.diff","patch_url":"https://github.com/symfony/symfony/pull/26997.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/26997","number":26997,"state":"open","locked":false,"title":"[PropertyInfo] Add an extractor to guess if a property is initializable","user":{"login":"dunglas","id":57224,"avatar_url":"https://avatars2.githubusercontent.com/u/57224?v=4","gravatar_id":"","url":"https://api.github.com/users/dunglas","html_url":"https://github.com/dunglas","followers_url":"https://api.github.com/users/dunglas/followers","following_url":"https://api.github.com/users/dunglas/following{/other_user}","gists_url":"https://api.github.com/users/dunglas/gists{/gist_id}","starred_url":"https://api.github.com/users/dunglas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dunglas/subscriptions","organizations_url":"https://api.github.com/users/dunglas/orgs","repos_url":"https://api.github.com/users/dunglas/repos","events_url":"https://api.github.com/users/dunglas/events{/privacy}","received_events_url":"https://api.github.com/users/dunglas/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | master\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | no     <!-- see https://symfony.com/bc -->\r\n| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->\r\n| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->\r\n| Fixed tickets | n/a   <!-- #-prefixed issue number(s), if any -->\r\n| License       | MIT\r\n| Doc PR        | todo\r\n\r\nWhen dealing with value objects, being able to detect if a property can be initialized using the constructor is a very valuable information. It's mandatory to add a proper value object support in API Platform and in the Serializer component.\r\n\r\nSee api-platform/core#1749 and api-platform/core#1843 for the related discussions, extended use cases and proof of concepts.\r\n\r\nThis PR adds a new interface to guess if a property can be initialized through the constructor, and an implementation using the reflection (in `ReflectionExtractor`).","created_at":"2018-04-21T10:20:21Z","updated_at":"2018-04-22T09:04:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9997538f2006f0b4ab7bd5f26312a890b71743a5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lyrixx","id":408368,"avatar_url":"https://avatars1.githubusercontent.com/u/408368?v=4","gravatar_id":"","url":"https://api.github.com/users/lyrixx","html_url":"https://github.com/lyrixx","followers_url":"https://api.github.com/users/lyrixx/followers","following_url":"https://api.github.com/users/lyrixx/following{/other_user}","gists_url":"https://api.github.com/users/lyrixx/gists{/gist_id}","starred_url":"https://api.github.com/users/lyrixx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyrixx/subscriptions","organizations_url":"https://api.github.com/users/lyrixx/orgs","repos_url":"https://api.github.com/users/lyrixx/repos","events_url":"https://api.github.com/users/lyrixx/events{/privacy}","received_events_url":"https://api.github.com/users/lyrixx/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":100378,"url":"https://api.github.com/repos/symfony/symfony/labels/Feature","name":"Feature","color":"02e10c","default":false},{"id":297305416,"url":"https://api.github.com/repos/symfony/symfony/labels/PropertyInfo","name":"PropertyInfo","color":"dddddd","default":false},{"id":237003792,"url":"https://api.github.com/repos/symfony/symfony/labels/Status:%20Needs%20Review","name":"Status: Needs Review","color":"ededed","default":false}],"milestone":{"url":"https://api.github.com/repos/symfony/symfony/milestones/18","html_url":"https://github.com/symfony/symfony/milestone/18","labels_url":"https://api.github.com/repos/symfony/symfony/milestones/18/labels","id":3234645,"number":18,"title":"next","description":"https://symfony.com/roadmap?version=4.2#checker","creator":{"login":"nicolas-grekas","id":243674,"avatar_url":"https://avatars3.githubusercontent.com/u/243674?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"open_issues":98,"closed_issues":1,"state":"open","created_at":"2018-04-02T12:03:21Z","updated_at":"2018-04-22T06:42:49Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/26997/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/26997/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/26997/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/fdf5cf04809beaa5f95eb1f819c3540e77265deb","head":{"label":"dunglas:propertyinfo-constructor","ref":"propertyinfo-constructor","sha":"fdf5cf04809beaa5f95eb1f819c3540e77265deb","user":{"login":"dunglas","id":57224,"avatar_url":"https://avatars2.githubusercontent.com/u/57224?v=4","gravatar_id":"","url":"https://api.github.com/users/dunglas","html_url":"https://github.com/dunglas","followers_url":"https://api.github.com/users/dunglas/followers","following_url":"https://api.github.com/users/dunglas/following{/other_user}","gists_url":"https://api.github.com/users/dunglas/gists{/gist_id}","starred_url":"https://api.github.com/users/dunglas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dunglas/subscriptions","organizations_url":"https://api.github.com/users/dunglas/orgs","repos_url":"https://api.github.com/users/dunglas/repos","events_url":"https://api.github.com/users/dunglas/events{/privacy}","received_events_url":"https://api.github.com/users/dunglas/received_events","type":"User","site_admin":false},"repo":{"id":1124839,"name":"symfony","full_name":"dunglas/symfony","owner":{"login":"dunglas","id":57224,"avatar_url":"https://avatars2.githubusercontent.com/u/57224?v=4","gravatar_id":"","url":"https://api.github.com/users/dunglas","html_url":"https://github.com/dunglas","followers_url":"https://api.github.com/users/dunglas/followers","following_url":"https://api.github.com/users/dunglas/following{/other_user}","gists_url":"https://api.github.com/users/dunglas/gists{/gist_id}","starred_url":"https://api.github.com/users/dunglas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dunglas/subscriptions","organizations_url":"https://api.github.com/users/dunglas/orgs","repos_url":"https://api.github.com/users/dunglas/repos","events_url":"https://api.github.com/users/dunglas/events{/privacy}","received_events_url":"https://api.github.com/users/dunglas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dunglas/symfony","description":"The Symfony2 PHP framework (PHP 5.3 only -- not yet stable) -- documentation for master is at http://docs.symfony-reloaded.org/master/","fork":true,"url":"https://api.github.com/repos/dunglas/symfony","forks_url":"https://api.github.com/repos/dunglas/symfony/forks","keys_url":"https://api.github.com/repos/dunglas/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dunglas/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dunglas/symfony/teams","hooks_url":"https://api.github.com/repos/dunglas/symfony/hooks","issue_events_url":"https://api.github.com/repos/dunglas/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/dunglas/symfony/events","assignees_url":"https://api.github.com/repos/dunglas/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/dunglas/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/dunglas/symfony/tags","blobs_url":"https://api.github.com/repos/dunglas/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dunglas/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dunglas/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/dunglas/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dunglas/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/dunglas/symfony/languages","stargazers_url":"https://api.github.com/repos/dunglas/symfony/stargazers","contributors_url":"https://api.github.com/repos/dunglas/symfony/contributors","subscribers_url":"https://api.github.com/repos/dunglas/symfony/subscribers","subscription_url":"https://api.github.com/repos/dunglas/symfony/subscription","commits_url":"https://api.github.com/repos/dunglas/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/dunglas/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/dunglas/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/dunglas/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/dunglas/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/dunglas/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dunglas/symfony/merges","archive_url":"https://api.github.com/repos/dunglas/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dunglas/symfony/downloads","issues_url":"https://api.github.com/repos/dunglas/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/dunglas/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/dunglas/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/dunglas/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dunglas/symfony/labels{/name}","releases_url":"https://api.github.com/repos/dunglas/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/dunglas/symfony/deployments","created_at":"2010-11-30T08:18:04Z","updated_at":"2016-01-28T23:52:00Z","pushed_at":"2018-04-21T10:55:53Z","git_url":"git://github.com/dunglas/symfony.git","ssh_url":"git@github.com:dunglas/symfony.git","clone_url":"https://github.com/dunglas/symfony.git","svn_url":"https://github.com/dunglas/symfony","homepage":"http://www.symfony-project.org/","size":112151,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"833909bd68b99c3276518412afcaf6e32e8fb2f9","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2018-04-22T08:53:17Z","pushed_at":"2018-04-22T07:52:11Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"https://symfony.com","size":116396,"stargazers_count":17343,"watchers_count":17343,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":6173,"mirror_url":null,"archived":false,"open_issues_count":798,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":6173,"open_issues":798,"watchers":17343,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/26997"},"html":{"href":"https://github.com/symfony/symfony/pull/26997"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/26997"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/26997/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/26997/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/26997/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/fdf5cf04809beaa5f95eb1f819c3540e77265deb"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"dunglas"}}