{"action":"created","comment":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/186094379","pull_request_review_id":117619687,"id":186094379,"diff_hunk":"@@ -0,0 +1,70 @@\n+.. _operations_traffic_capture:\n+\n+Traffic capture","path":"docs/root/operations/traffic_capture.rst","position":3,"original_position":3,"commit_id":"cf6949faa1838605fe004735a171007618e4158e","original_commit_id":"cf6949faa1838605fe004735a171007618e4158e","user":{"login":"dnoe","id":1183641,"avatar_url":"https://avatars2.githubusercontent.com/u/1183641?v=4","gravatar_id":"","url":"https://api.github.com/users/dnoe","html_url":"https://github.com/dnoe","followers_url":"https://api.github.com/users/dnoe/followers","following_url":"https://api.github.com/users/dnoe/following{/other_user}","gists_url":"https://api.github.com/users/dnoe/gists{/gist_id}","starred_url":"https://api.github.com/users/dnoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnoe/subscriptions","organizations_url":"https://api.github.com/users/dnoe/orgs","repos_url":"https://api.github.com/users/dnoe/repos","events_url":"https://api.github.com/users/dnoe/events{/privacy}","received_events_url":"https://api.github.com/users/dnoe/received_events","type":"User","site_admin":false},"body":"Good point :) The recently announced twitter issue where cleartext passwords were accidentally stored (presumably through logging feature of some sort, because I really don't think they were intentionally storing cleartext passwords) was fresh on my mind when I was thinking about this.","created_at":"2018-05-04T14:10:53Z","updated_at":"2018-05-04T14:10:53Z","html_url":"https://github.com/envoyproxy/envoy/pull/3244#discussion_r186094379","pull_request_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/3244","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/186094379"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/3244#discussion_r186094379"},"pull_request":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/3244"}},"in_reply_to_id":186079534},"pull_request":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/3244","id":184715948,"html_url":"https://github.com/envoyproxy/envoy/pull/3244","diff_url":"https://github.com/envoyproxy/envoy/pull/3244.diff","patch_url":"https://github.com/envoyproxy/envoy/pull/3244.patch","issue_url":"https://api.github.com/repos/envoyproxy/envoy/issues/3244","number":3244,"state":"open","locked":false,"title":"tap/fuzz: transport socket extension for traffic capture.","user":{"login":"htuch","id":10914751,"avatar_url":"https://avatars1.githubusercontent.com/u/10914751?v=4","gravatar_id":"","url":"https://api.github.com/users/htuch","html_url":"https://github.com/htuch","followers_url":"https://api.github.com/users/htuch/followers","following_url":"https://api.github.com/users/htuch/following{/other_user}","gists_url":"https://api.github.com/users/htuch/gists{/gist_id}","starred_url":"https://api.github.com/users/htuch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htuch/subscriptions","organizations_url":"https://api.github.com/users/htuch/orgs","repos_url":"https://api.github.com/users/htuch/repos","events_url":"https://api.github.com/users/htuch/events{/privacy}","received_events_url":"https://api.github.com/users/htuch/received_events","type":"User","site_admin":false},"body":"This PR introduces a transport socket extension that wraps a given transport socket, interposes on its\r\nplain text traffic and records it into a proto trace file on the filesystem. This can be used for a\r\nnumber of purposes:\r\n1. As a corpus for fuzzing the data plane.\r\n2. Converted to PCAP using a capture2pcap utility, allowing existing tools such as Wireshark\r\n   to be used to decode L4/L7 protocol history in the trace. Essentially this lets us take advantage\r\n   of the PCAP ecosystem.\r\n\r\nRelates to #1413 and #508.\r\n\r\nRisk Level: Low (opt-in).\r\nTesting: New SSL integration tests, demonstrating plain text intercept.\r\n\r\nSigned-off-by: Harvey Tuch <htuch@google.com>","created_at":"2018-04-27T20:07:08Z","updated_at":"2018-05-04T14:10:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9febbd27c99bdd4b3315ea7371f61947a5709e34","assignee":{"login":"mattklein123","id":6305260,"avatar_url":"https://avatars3.githubusercontent.com/u/6305260?v=4","gravatar_id":"","url":"https://api.github.com/users/mattklein123","html_url":"https://github.com/mattklein123","followers_url":"https://api.github.com/users/mattklein123/followers","following_url":"https://api.github.com/users/mattklein123/following{/other_user}","gists_url":"https://api.github.com/users/mattklein123/gists{/gist_id}","starred_url":"https://api.github.com/users/mattklein123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattklein123/subscriptions","organizations_url":"https://api.github.com/users/mattklein123/orgs","repos_url":"https://api.github.com/users/mattklein123/repos","events_url":"https://api.github.com/users/mattklein123/events{/privacy}","received_events_url":"https://api.github.com/users/mattklein123/received_events","type":"User","site_admin":false},"assignees":[{"login":"mattklein123","id":6305260,"avatar_url":"https://avatars3.githubusercontent.com/u/6305260?v=4","gravatar_id":"","url":"https://api.github.com/users/mattklein123","html_url":"https://github.com/mattklein123","followers_url":"https://api.github.com/users/mattklein123/followers","following_url":"https://api.github.com/users/mattklein123/following{/other_user}","gists_url":"https://api.github.com/users/mattklein123/gists{/gist_id}","starred_url":"https://api.github.com/users/mattklein123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattklein123/subscriptions","organizations_url":"https://api.github.com/users/mattklein123/orgs","repos_url":"https://api.github.com/users/mattklein123/repos","events_url":"https://api.github.com/users/mattklein123/events{/privacy}","received_events_url":"https://api.github.com/users/mattklein123/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/3244/commits","review_comments_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/3244/comments","review_comment_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/issues/3244/comments","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/cf6949faa1838605fe004735a171007618e4158e","head":{"label":"htuch:transport-intercept","ref":"transport-intercept","sha":"cf6949faa1838605fe004735a171007618e4158e","user":{"login":"htuch","id":10914751,"avatar_url":"https://avatars1.githubusercontent.com/u/10914751?v=4","gravatar_id":"","url":"https://api.github.com/users/htuch","html_url":"https://github.com/htuch","followers_url":"https://api.github.com/users/htuch/followers","following_url":"https://api.github.com/users/htuch/following{/other_user}","gists_url":"https://api.github.com/users/htuch/gists{/gist_id}","starred_url":"https://api.github.com/users/htuch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htuch/subscriptions","organizations_url":"https://api.github.com/users/htuch/orgs","repos_url":"https://api.github.com/users/htuch/repos","events_url":"https://api.github.com/users/htuch/events{/privacy}","received_events_url":"https://api.github.com/users/htuch/received_events","type":"User","site_admin":false},"repo":{"id":80469193,"name":"envoy","full_name":"htuch/envoy","owner":{"login":"htuch","id":10914751,"avatar_url":"https://avatars1.githubusercontent.com/u/10914751?v=4","gravatar_id":"","url":"https://api.github.com/users/htuch","html_url":"https://github.com/htuch","followers_url":"https://api.github.com/users/htuch/followers","following_url":"https://api.github.com/users/htuch/following{/other_user}","gists_url":"https://api.github.com/users/htuch/gists{/gist_id}","starred_url":"https://api.github.com/users/htuch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htuch/subscriptions","organizations_url":"https://api.github.com/users/htuch/orgs","repos_url":"https://api.github.com/users/htuch/repos","events_url":"https://api.github.com/users/htuch/events{/privacy}","received_events_url":"https://api.github.com/users/htuch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/htuch/envoy","description":"C++ front/service proxy","fork":true,"url":"https://api.github.com/repos/htuch/envoy","forks_url":"https://api.github.com/repos/htuch/envoy/forks","keys_url":"https://api.github.com/repos/htuch/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htuch/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htuch/envoy/teams","hooks_url":"https://api.github.com/repos/htuch/envoy/hooks","issue_events_url":"https://api.github.com/repos/htuch/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/htuch/envoy/events","assignees_url":"https://api.github.com/repos/htuch/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/htuch/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/htuch/envoy/tags","blobs_url":"https://api.github.com/repos/htuch/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htuch/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htuch/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/htuch/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htuch/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/htuch/envoy/languages","stargazers_url":"https://api.github.com/repos/htuch/envoy/stargazers","contributors_url":"https://api.github.com/repos/htuch/envoy/contributors","subscribers_url":"https://api.github.com/repos/htuch/envoy/subscribers","subscription_url":"https://api.github.com/repos/htuch/envoy/subscription","commits_url":"https://api.github.com/repos/htuch/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/htuch/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/htuch/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/htuch/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/htuch/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/htuch/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htuch/envoy/merges","archive_url":"https://api.github.com/repos/htuch/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htuch/envoy/downloads","issues_url":"https://api.github.com/repos/htuch/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/htuch/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/htuch/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/htuch/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htuch/envoy/labels{/name}","releases_url":"https://api.github.com/repos/htuch/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/htuch/envoy/deployments","created_at":"2017-01-30T22:15:11Z","updated_at":"2018-02-22T15:20:07Z","pushed_at":"2018-05-04T00:08:39Z","git_url":"git://github.com/htuch/envoy.git","ssh_url":"git@github.com:htuch/envoy.git","clone_url":"https://github.com/htuch/envoy.git","svn_url":"https://github.com/htuch/envoy","homepage":"https://lyft.github.io/envoy","size":15261,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"envoyproxy:master","ref":"master","sha":"872728d4ad50acececaeae389da59cb72846cf89","user":{"login":"envoyproxy","id":30125649,"avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":65214191,"name":"envoy","full_name":"envoyproxy/envoy","owner":{"login":"envoyproxy","id":30125649,"avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/envoyproxy/envoy","description":"C++ front/service proxy","fork":false,"url":"https://api.github.com/repos/envoyproxy/envoy","forks_url":"https://api.github.com/repos/envoyproxy/envoy/forks","keys_url":"https://api.github.com/repos/envoyproxy/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/envoyproxy/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/envoyproxy/envoy/teams","hooks_url":"https://api.github.com/repos/envoyproxy/envoy/hooks","issue_events_url":"https://api.github.com/repos/envoyproxy/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/envoyproxy/envoy/events","assignees_url":"https://api.github.com/repos/envoyproxy/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/envoyproxy/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/envoyproxy/envoy/tags","blobs_url":"https://api.github.com/repos/envoyproxy/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/envoyproxy/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/envoyproxy/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/envoyproxy/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/envoyproxy/envoy/languages","stargazers_url":"https://api.github.com/repos/envoyproxy/envoy/stargazers","contributors_url":"https://api.github.com/repos/envoyproxy/envoy/contributors","subscribers_url":"https://api.github.com/repos/envoyproxy/envoy/subscribers","subscription_url":"https://api.github.com/repos/envoyproxy/envoy/subscription","commits_url":"https://api.github.com/repos/envoyproxy/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/envoyproxy/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/envoyproxy/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/envoyproxy/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/envoyproxy/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/envoyproxy/envoy/merges","archive_url":"https://api.github.com/repos/envoyproxy/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/envoyproxy/envoy/downloads","issues_url":"https://api.github.com/repos/envoyproxy/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/envoyproxy/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/envoyproxy/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/envoyproxy/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/envoyproxy/envoy/labels{/name}","releases_url":"https://api.github.com/repos/envoyproxy/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/envoyproxy/envoy/deployments","created_at":"2016-08-08T15:07:24Z","updated_at":"2018-05-04T10:53:46Z","pushed_at":"2018-05-04T13:30:41Z","git_url":"git://github.com/envoyproxy/envoy.git","ssh_url":"git@github.com:envoyproxy/envoy.git","clone_url":"https://github.com/envoyproxy/envoy.git","svn_url":"https://github.com/envoyproxy/envoy","homepage":"https://www.envoyproxy.io","size":15027,"stargazers_count":4746,"watchers_count":4746,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":604,"mirror_url":null,"archived":false,"open_issues_count":318,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":604,"open_issues":318,"watchers":4746,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/3244"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/3244"},"issue":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/3244"},"comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/3244/comments"},"review_comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/3244/comments"},"review_comment":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/3244/commits"},"statuses":{"href":"https://api.github.com/repos/envoyproxy/envoy/statuses/cf6949faa1838605fe004735a171007618e4158e"}},"author_association":"OWNER"}}
{"actor":{"display_login":"dnoe"}}