{"action":"created","comment":{"url":"https://api.github.com/repos/diffblue/cbmc/pulls/comments/199447051","pull_request_review_id":133565722,"id":199447051,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTQ0NzA1MQ==","diff_hunk":"@@ -1640,6 +1640,48 @@ void java_bytecode_parsert::rclass_attribute(classt &parsed_class)\n     parsed_class.attribute_bootstrapmethods_read = true;\n     read_bootstrapmethods_entry(parsed_class);\n   }\n+  else if(attribute_name == \"InnerClasses\")\n+  {\n+    u2 number_of_classes = read_u2();","path":"jbmc/src/java_bytecode/java_bytecode_parser.cpp","position":6,"original_position":6,"commit_id":"d78c44078406f871122d6ce3b0cd45ce5a20fd62","original_commit_id":"12e5c598f67fec40718dc28ef7a804eb58be6564","user":{"login":"jeannielynnmoulton","id":5637147,"node_id":"MDQ6VXNlcjU2MzcxNDc=","avatar_url":"https://avatars0.githubusercontent.com/u/5637147?v=4","gravatar_id":"","url":"https://api.github.com/users/jeannielynnmoulton","html_url":"https://github.com/jeannielynnmoulton","followers_url":"https://api.github.com/users/jeannielynnmoulton/followers","following_url":"https://api.github.com/users/jeannielynnmoulton/following{/other_user}","gists_url":"https://api.github.com/users/jeannielynnmoulton/gists{/gist_id}","starred_url":"https://api.github.com/users/jeannielynnmoulton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeannielynnmoulton/subscriptions","organizations_url":"https://api.github.com/users/jeannielynnmoulton/orgs","repos_url":"https://api.github.com/users/jeannielynnmoulton/repos","events_url":"https://api.github.com/users/jeannielynnmoulton/events{/privacy}","received_events_url":"https://api.github.com/users/jeannielynnmoulton/received_events","type":"User","site_admin":false},"body":"The spec is not great, agreed.","created_at":"2018-07-02T10:08:35Z","updated_at":"2018-07-02T10:08:35Z","html_url":"https://github.com/diffblue/cbmc/pull/2493#discussion_r199447051","pull_request_url":"https://api.github.com/repos/diffblue/cbmc/pulls/2493","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/comments/199447051"},"html":{"href":"https://github.com/diffblue/cbmc/pull/2493#discussion_r199447051"},"pull_request":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/2493"}},"in_reply_to_id":199098098},"pull_request":{"url":"https://api.github.com/repos/diffblue/cbmc/pulls/2493","id":198103791,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MTAzNzkx","html_url":"https://github.com/diffblue/cbmc/pull/2493","diff_url":"https://github.com/diffblue/cbmc/pull/2493.diff","patch_url":"https://github.com/diffblue/cbmc/pull/2493.patch","issue_url":"https://api.github.com/repos/diffblue/cbmc/issues/2493","number":2493,"state":"open","locked":false,"title":"[TG-3694] Parse and store inner class information","user":{"login":"jeannielynnmoulton","id":5637147,"node_id":"MDQ6VXNlcjU2MzcxNDc=","avatar_url":"https://avatars0.githubusercontent.com/u/5637147?v=4","gravatar_id":"","url":"https://api.github.com/users/jeannielynnmoulton","html_url":"https://github.com/jeannielynnmoulton","followers_url":"https://api.github.com/users/jeannielynnmoulton/followers","following_url":"https://api.github.com/users/jeannielynnmoulton/following{/other_user}","gists_url":"https://api.github.com/users/jeannielynnmoulton/gists{/gist_id}","starred_url":"https://api.github.com/users/jeannielynnmoulton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeannielynnmoulton/subscriptions","organizations_url":"https://api.github.com/users/jeannielynnmoulton/orgs","repos_url":"https://api.github.com/users/jeannielynnmoulton/repos","events_url":"https://api.github.com/users/jeannielynnmoulton/events{/privacy}","received_events_url":"https://api.github.com/users/jeannielynnmoulton/received_events","type":"User","site_admin":false},"body":"IN PROGRESS\r\n\r\nThis parses the InnerClasses attribute of the java bytecode with the intention of determining\r\n- If an parsed class is an inner class\r\n- The accessibility information for inner classes\r\n\r\nIf the parsed class is an inner class, then the original accessibility is overwritten by the information from the InnerClasses attribute.\r\n\r\nWhether the class is an inner class is then stored in java_class_typet.\r\n\r\n...\r\n\r\n@thk123 @thomasspriggs Currently there is one test failing in test gen with the changes that will require some investigation, but I am on AL Friday and wanted to get some preliminary reviews so with some luck, this might be finished the sprint. Thanks.\r\n\r\n@thk123 Could you please add an in progress label or equivalent. I have no privileges.\r\n","created_at":"2018-06-28T17:43:48Z","updated_at":"2018-07-02T10:08:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da9c459cbe5b28c5b6c399221bf261bfe5915fde","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cesaro","id":143977,"node_id":"MDQ6VXNlcjE0Mzk3Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/143977?v=4","gravatar_id":"","url":"https://api.github.com/users/cesaro","html_url":"https://github.com/cesaro","followers_url":"https://api.github.com/users/cesaro/followers","following_url":"https://api.github.com/users/cesaro/following{/other_user}","gists_url":"https://api.github.com/users/cesaro/gists{/gist_id}","starred_url":"https://api.github.com/users/cesaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cesaro/subscriptions","organizations_url":"https://api.github.com/users/cesaro/orgs","repos_url":"https://api.github.com/users/cesaro/repos","events_url":"https://api.github.com/users/cesaro/events{/privacy}","received_events_url":"https://api.github.com/users/cesaro/received_events","type":"User","site_admin":false},{"login":"smowton","id":283483,"node_id":"MDQ6VXNlcjI4MzQ4Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/283483?v=4","gravatar_id":"","url":"https://api.github.com/users/smowton","html_url":"https://github.com/smowton","followers_url":"https://api.github.com/users/smowton/followers","following_url":"https://api.github.com/users/smowton/following{/other_user}","gists_url":"https://api.github.com/users/smowton/gists{/gist_id}","starred_url":"https://api.github.com/users/smowton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smowton/subscriptions","organizations_url":"https://api.github.com/users/smowton/orgs","repos_url":"https://api.github.com/users/smowton/repos","events_url":"https://api.github.com/users/smowton/events{/privacy}","received_events_url":"https://api.github.com/users/smowton/received_events","type":"User","site_admin":false},{"login":"mgudemann","id":2590540,"node_id":"MDQ6VXNlcjI1OTA1NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/2590540?v=4","gravatar_id":"","url":"https://api.github.com/users/mgudemann","html_url":"https://github.com/mgudemann","followers_url":"https://api.github.com/users/mgudemann/followers","following_url":"https://api.github.com/users/mgudemann/following{/other_user}","gists_url":"https://api.github.com/users/mgudemann/gists{/gist_id}","starred_url":"https://api.github.com/users/mgudemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgudemann/subscriptions","organizations_url":"https://api.github.com/users/mgudemann/orgs","repos_url":"https://api.github.com/users/mgudemann/repos","events_url":"https://api.github.com/users/mgudemann/events{/privacy}","received_events_url":"https://api.github.com/users/mgudemann/received_events","type":"User","site_admin":false},{"login":"peterschrammel","id":4222448,"node_id":"MDQ6VXNlcjQyMjI0NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/4222448?v=4","gravatar_id":"","url":"https://api.github.com/users/peterschrammel","html_url":"https://github.com/peterschrammel","followers_url":"https://api.github.com/users/peterschrammel/followers","following_url":"https://api.github.com/users/peterschrammel/following{/other_user}","gists_url":"https://api.github.com/users/peterschrammel/gists{/gist_id}","starred_url":"https://api.github.com/users/peterschrammel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterschrammel/subscriptions","organizations_url":"https://api.github.com/users/peterschrammel/orgs","repos_url":"https://api.github.com/users/peterschrammel/repos","events_url":"https://api.github.com/users/peterschrammel/events{/privacy}","received_events_url":"https://api.github.com/users/peterschrammel/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":857694925,"node_id":"MDU6TGFiZWw4NTc2OTQ5MjU=","url":"https://api.github.com/repos/diffblue/cbmc/labels/In%20progress","name":"In progress","color":"ba2a25","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/diffblue/cbmc/pulls/2493/commits","review_comments_url":"https://api.github.com/repos/diffblue/cbmc/pulls/2493/comments","review_comment_url":"https://api.github.com/repos/diffblue/cbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/diffblue/cbmc/issues/2493/comments","statuses_url":"https://api.github.com/repos/diffblue/cbmc/statuses/d78c44078406f871122d6ce3b0cd45ce5a20fd62","head":{"label":"jeannielynnmoulton:jeannie/InnerClasses","ref":"jeannie/InnerClasses","sha":"d78c44078406f871122d6ce3b0cd45ce5a20fd62","user":{"login":"jeannielynnmoulton","id":5637147,"node_id":"MDQ6VXNlcjU2MzcxNDc=","avatar_url":"https://avatars0.githubusercontent.com/u/5637147?v=4","gravatar_id":"","url":"https://api.github.com/users/jeannielynnmoulton","html_url":"https://github.com/jeannielynnmoulton","followers_url":"https://api.github.com/users/jeannielynnmoulton/followers","following_url":"https://api.github.com/users/jeannielynnmoulton/following{/other_user}","gists_url":"https://api.github.com/users/jeannielynnmoulton/gists{/gist_id}","starred_url":"https://api.github.com/users/jeannielynnmoulton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeannielynnmoulton/subscriptions","organizations_url":"https://api.github.com/users/jeannielynnmoulton/orgs","repos_url":"https://api.github.com/users/jeannielynnmoulton/repos","events_url":"https://api.github.com/users/jeannielynnmoulton/events{/privacy}","received_events_url":"https://api.github.com/users/jeannielynnmoulton/received_events","type":"User","site_admin":false},"repo":{"id":118236465,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgyMzY0NjU=","name":"cbmc","full_name":"jeannielynnmoulton/cbmc","owner":{"login":"jeannielynnmoulton","id":5637147,"node_id":"MDQ6VXNlcjU2MzcxNDc=","avatar_url":"https://avatars0.githubusercontent.com/u/5637147?v=4","gravatar_id":"","url":"https://api.github.com/users/jeannielynnmoulton","html_url":"https://github.com/jeannielynnmoulton","followers_url":"https://api.github.com/users/jeannielynnmoulton/followers","following_url":"https://api.github.com/users/jeannielynnmoulton/following{/other_user}","gists_url":"https://api.github.com/users/jeannielynnmoulton/gists{/gist_id}","starred_url":"https://api.github.com/users/jeannielynnmoulton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeannielynnmoulton/subscriptions","organizations_url":"https://api.github.com/users/jeannielynnmoulton/orgs","repos_url":"https://api.github.com/users/jeannielynnmoulton/repos","events_url":"https://api.github.com/users/jeannielynnmoulton/events{/privacy}","received_events_url":"https://api.github.com/users/jeannielynnmoulton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeannielynnmoulton/cbmc","description":"C Bounded Model Checker","fork":true,"url":"https://api.github.com/repos/jeannielynnmoulton/cbmc","forks_url":"https://api.github.com/repos/jeannielynnmoulton/cbmc/forks","keys_url":"https://api.github.com/repos/jeannielynnmoulton/cbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeannielynnmoulton/cbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeannielynnmoulton/cbmc/teams","hooks_url":"https://api.github.com/repos/jeannielynnmoulton/cbmc/hooks","issue_events_url":"https://api.github.com/repos/jeannielynnmoulton/cbmc/issues/events{/number}","events_url":"https://api.github.com/repos/jeannielynnmoulton/cbmc/events","assignees_url":"https://api.github.com/repos/jeannielynnmoulton/cbmc/assignees{/user}","branches_url":"https://api.github.com/repos/jeannielynnmoulton/cbmc/branches{/branch}","tags_url":"https://api.github.com/repos/jeannielynnmoulton/cbmc/tags","blobs_url":"https://api.github.com/repos/jeannielynnmoulton/cbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeannielynnmoulton/cbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeannielynnmoulton/cbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeannielynnmoulton/cbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeannielynnmoulton/cbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/jeannielynnmoulton/cbmc/languages","stargazers_url":"https://api.github.com/repos/jeannielynnmoulton/cbmc/stargazers","contributors_url":"https://api.github.com/repos/jeannielynnmoulton/cbmc/contributors","subscribers_url":"https://api.github.com/repos/jeannielynnmoulton/cbmc/subscribers","subscription_url":"https://api.github.com/repos/jeannielynnmoulton/cbmc/subscription","commits_url":"https://api.github.com/repos/jeannielynnmoulton/cbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeannielynnmoulton/cbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeannielynnmoulton/cbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeannielynnmoulton/cbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeannielynnmoulton/cbmc/contents/{+path}","compare_url":"https://api.github.com/repos/jeannielynnmoulton/cbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeannielynnmoulton/cbmc/merges","archive_url":"https://api.github.com/repos/jeannielynnmoulton/cbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeannielynnmoulton/cbmc/downloads","issues_url":"https://api.github.com/repos/jeannielynnmoulton/cbmc/issues{/number}","pulls_url":"https://api.github.com/repos/jeannielynnmoulton/cbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/jeannielynnmoulton/cbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/jeannielynnmoulton/cbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeannielynnmoulton/cbmc/labels{/name}","releases_url":"https://api.github.com/repos/jeannielynnmoulton/cbmc/releases{/id}","deployments_url":"https://api.github.com/repos/jeannielynnmoulton/cbmc/deployments","created_at":"2018-01-20T11:25:29Z","updated_at":"2018-01-20T11:25:39Z","pushed_at":"2018-06-28T18:49:07Z","git_url":"git://github.com/jeannielynnmoulton/cbmc.git","ssh_url":"git@github.com:jeannielynnmoulton/cbmc.git","clone_url":"https://github.com/jeannielynnmoulton/cbmc.git","svn_url":"https://github.com/jeannielynnmoulton/cbmc","homepage":"http://www.cprover.org/cbmc","size":33022,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"diffblue:develop","ref":"develop","sha":"6fd77f4ad20ae03ed3073cfb5766e0092fb31067","user":{"login":"diffblue","id":17216098,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MjE2MDk4","avatar_url":"https://avatars0.githubusercontent.com/u/17216098?v=4","gravatar_id":"","url":"https://api.github.com/users/diffblue","html_url":"https://github.com/diffblue","followers_url":"https://api.github.com/users/diffblue/followers","following_url":"https://api.github.com/users/diffblue/following{/other_user}","gists_url":"https://api.github.com/users/diffblue/gists{/gist_id}","starred_url":"https://api.github.com/users/diffblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diffblue/subscriptions","organizations_url":"https://api.github.com/users/diffblue/orgs","repos_url":"https://api.github.com/users/diffblue/repos","events_url":"https://api.github.com/users/diffblue/events{/privacy}","received_events_url":"https://api.github.com/users/diffblue/received_events","type":"Organization","site_admin":false},"repo":{"id":51877056,"node_id":"MDEwOlJlcG9zaXRvcnk1MTg3NzA1Ng==","name":"cbmc","full_name":"diffblue/cbmc","owner":{"login":"diffblue","id":17216098,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MjE2MDk4","avatar_url":"https://avatars0.githubusercontent.com/u/17216098?v=4","gravatar_id":"","url":"https://api.github.com/users/diffblue","html_url":"https://github.com/diffblue","followers_url":"https://api.github.com/users/diffblue/followers","following_url":"https://api.github.com/users/diffblue/following{/other_user}","gists_url":"https://api.github.com/users/diffblue/gists{/gist_id}","starred_url":"https://api.github.com/users/diffblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diffblue/subscriptions","organizations_url":"https://api.github.com/users/diffblue/orgs","repos_url":"https://api.github.com/users/diffblue/repos","events_url":"https://api.github.com/users/diffblue/events{/privacy}","received_events_url":"https://api.github.com/users/diffblue/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/diffblue/cbmc","description":"C Bounded Model Checker","fork":false,"url":"https://api.github.com/repos/diffblue/cbmc","forks_url":"https://api.github.com/repos/diffblue/cbmc/forks","keys_url":"https://api.github.com/repos/diffblue/cbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diffblue/cbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diffblue/cbmc/teams","hooks_url":"https://api.github.com/repos/diffblue/cbmc/hooks","issue_events_url":"https://api.github.com/repos/diffblue/cbmc/issues/events{/number}","events_url":"https://api.github.com/repos/diffblue/cbmc/events","assignees_url":"https://api.github.com/repos/diffblue/cbmc/assignees{/user}","branches_url":"https://api.github.com/repos/diffblue/cbmc/branches{/branch}","tags_url":"https://api.github.com/repos/diffblue/cbmc/tags","blobs_url":"https://api.github.com/repos/diffblue/cbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diffblue/cbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diffblue/cbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/diffblue/cbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diffblue/cbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/diffblue/cbmc/languages","stargazers_url":"https://api.github.com/repos/diffblue/cbmc/stargazers","contributors_url":"https://api.github.com/repos/diffblue/cbmc/contributors","subscribers_url":"https://api.github.com/repos/diffblue/cbmc/subscribers","subscription_url":"https://api.github.com/repos/diffblue/cbmc/subscription","commits_url":"https://api.github.com/repos/diffblue/cbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/diffblue/cbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/diffblue/cbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/diffblue/cbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/diffblue/cbmc/contents/{+path}","compare_url":"https://api.github.com/repos/diffblue/cbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diffblue/cbmc/merges","archive_url":"https://api.github.com/repos/diffblue/cbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diffblue/cbmc/downloads","issues_url":"https://api.github.com/repos/diffblue/cbmc/issues{/number}","pulls_url":"https://api.github.com/repos/diffblue/cbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/diffblue/cbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/diffblue/cbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diffblue/cbmc/labels{/name}","releases_url":"https://api.github.com/repos/diffblue/cbmc/releases{/id}","deployments_url":"https://api.github.com/repos/diffblue/cbmc/deployments","created_at":"2016-02-16T23:03:52Z","updated_at":"2018-07-02T07:59:45Z","pushed_at":"2018-07-02T09:49:29Z","git_url":"git://github.com/diffblue/cbmc.git","ssh_url":"git@github.com:diffblue/cbmc.git","clone_url":"https://github.com/diffblue/cbmc.git","svn_url":"https://github.com/diffblue/cbmc","homepage":"http://www.cprover.org/cbmc","size":33135,"stargazers_count":120,"watchers_count":120,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":96,"mirror_url":null,"archived":false,"open_issues_count":403,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":96,"open_issues":403,"watchers":120,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/2493"},"html":{"href":"https://github.com/diffblue/cbmc/pull/2493"},"issue":{"href":"https://api.github.com/repos/diffblue/cbmc/issues/2493"},"comments":{"href":"https://api.github.com/repos/diffblue/cbmc/issues/2493/comments"},"review_comments":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/2493/comments"},"review_comment":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/2493/commits"},"statuses":{"href":"https://api.github.com/repos/diffblue/cbmc/statuses/d78c44078406f871122d6ce3b0cd45ce5a20fd62"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jeannielynnmoulton"}}