{"action":"created","comment":{"url":"https://api.github.com/repos/apache/drill/pulls/comments/240975519","pull_request_review_id":184128388,"id":240975519,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDk3NTUxOQ==","diff_hunk":"@@ -73,6 +73,10 @@ public ProfileWrapper(final QueryProfile profile, DrillConfig drillConfig) {\n     final List<MajorFragmentProfile> majors = new ArrayList<>(profile.getFragmentProfileList());\n     Collections.sort(majors, Comparators.majorId);\n \n+    //Setting warning thresholds for performance-degrading queries (DRILL-6879)","path":"exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileWrapper.java","position":18,"original_position":18,"commit_id":"07e34b928e704b47d97e017c16614bedfe7d284c","original_commit_id":"07e34b928e704b47d97e017c16614bedfe7d284c","user":{"login":"arina-ielchiieva","id":15086720,"node_id":"MDQ6VXNlcjE1MDg2NzIw","avatar_url":"https://avatars3.githubusercontent.com/u/15086720?v=4","gravatar_id":"","url":"https://api.github.com/users/arina-ielchiieva","html_url":"https://github.com/arina-ielchiieva","followers_url":"https://api.github.com/users/arina-ielchiieva/followers","following_url":"https://api.github.com/users/arina-ielchiieva/following{/other_user}","gists_url":"https://api.github.com/users/arina-ielchiieva/gists{/gist_id}","starred_url":"https://api.github.com/users/arina-ielchiieva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arina-ielchiieva/subscriptions","organizations_url":"https://api.github.com/users/arina-ielchiieva/orgs","repos_url":"https://api.github.com/users/arina-ielchiieva/repos","events_url":"https://api.github.com/users/arina-ielchiieva/events{/privacy}","received_events_url":"https://api.github.com/users/arina-ielchiieva/received_events","type":"User","site_admin":false},"body":"Do not use static methods, just pass drillConfig in the constructor for each of there classes and set warning threshold value during instance creation.","created_at":"2018-12-12T11:22:36Z","updated_at":"2018-12-12T11:22:36Z","html_url":"https://github.com/apache/drill/pull/1572#discussion_r240975519","pull_request_url":"https://api.github.com/repos/apache/drill/pulls/1572","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/drill/pulls/comments/240975519"},"html":{"href":"https://github.com/apache/drill/pull/1572#discussion_r240975519"},"pull_request":{"href":"https://api.github.com/repos/apache/drill/pulls/1572"}}},"pull_request":{"url":"https://api.github.com/repos/apache/drill/pulls/1572","id":237852810,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3ODUyODEw","html_url":"https://github.com/apache/drill/pull/1572","diff_url":"https://github.com/apache/drill/pull/1572.diff","patch_url":"https://github.com/apache/drill/pull/1572.patch","issue_url":"https://api.github.com/repos/apache/drill/issues/1572","number":1572,"state":"open","locked":false,"title":"DRILL-6879: Show warnings for potential performance issues","user":{"login":"kkhatua","id":4335237,"node_id":"MDQ6VXNlcjQzMzUyMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/4335237?v=4","gravatar_id":"","url":"https://api.github.com/users/kkhatua","html_url":"https://github.com/kkhatua","followers_url":"https://api.github.com/users/kkhatua/followers","following_url":"https://api.github.com/users/kkhatua/following{/other_user}","gists_url":"https://api.github.com/users/kkhatua/gists{/gist_id}","starred_url":"https://api.github.com/users/kkhatua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkhatua/subscriptions","organizations_url":"https://api.github.com/users/kkhatua/orgs","repos_url":"https://api.github.com/users/kkhatua/repos","events_url":"https://api.github.com/users/kkhatua/events{/privacy}","received_events_url":"https://api.github.com/users/kkhatua/received_events","type":"User","site_admin":false},"body":"1. Introduced warning for non-progressive fragments. Based on a threshold (`drill.exec.http.profile.warning.progress.threshold`), if all fragments have not made progress within that time, a warning is issued. The default is 5 minutes (300sec)\r\n\r\n2. Introduced a warning if any of the buffered operators spill to disk.\r\n\r\n3. Introduced a warning for operators where the longest running fragment runs beyond a minimum threshold (`drill.exec.http.profile.warning.time.skew.min`), and runs atleast 2 times longer than the average (`drill.exec.http.profile.warning.time.skew.ratio.process`). The _clock_ symbol with a tooltip indicates the extent of the skew. A similar comparison is made for the wait time of a fragment, but with a max wait time exceeding the average by a separate ratio (`drill.exec.http.profile.warning.time.skew.ratio.wait`)\r\n\r\n4. Introduced a warning for operators where the average wait time of a scan operator exceeds its processing time, for a minimum threshold (`drill.exec.http.profile.warning.scan.wait.min`). The _turtle_ symbol with a tooltip indicates which scan operator spent more time waiting than processing.\r\n\r\n5. `TableBuilder` class refactored\r\n a. Using attribute map instead of String arguments, eg. for 'title'\r\n b. Removed APIs that pass a hyperlink since that is never used.","created_at":"2018-12-11T22:43:00Z","updated_at":"2018-12-12T11:22:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a1ed49952613d60b6cfa4ecc6d518ee2d8151a4","assignee":{"login":"kkhatua","id":4335237,"node_id":"MDQ6VXNlcjQzMzUyMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/4335237?v=4","gravatar_id":"","url":"https://api.github.com/users/kkhatua","html_url":"https://github.com/kkhatua","followers_url":"https://api.github.com/users/kkhatua/followers","following_url":"https://api.github.com/users/kkhatua/following{/other_user}","gists_url":"https://api.github.com/users/kkhatua/gists{/gist_id}","starred_url":"https://api.github.com/users/kkhatua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkhatua/subscriptions","organizations_url":"https://api.github.com/users/kkhatua/orgs","repos_url":"https://api.github.com/users/kkhatua/repos","events_url":"https://api.github.com/users/kkhatua/events{/privacy}","received_events_url":"https://api.github.com/users/kkhatua/received_events","type":"User","site_admin":false},"assignees":[{"login":"kkhatua","id":4335237,"node_id":"MDQ6VXNlcjQzMzUyMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/4335237?v=4","gravatar_id":"","url":"https://api.github.com/users/kkhatua","html_url":"https://github.com/kkhatua","followers_url":"https://api.github.com/users/kkhatua/followers","following_url":"https://api.github.com/users/kkhatua/following{/other_user}","gists_url":"https://api.github.com/users/kkhatua/gists{/gist_id}","starred_url":"https://api.github.com/users/kkhatua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkhatua/subscriptions","organizations_url":"https://api.github.com/users/kkhatua/orgs","repos_url":"https://api.github.com/users/kkhatua/repos","events_url":"https://api.github.com/users/kkhatua/events{/privacy}","received_events_url":"https://api.github.com/users/kkhatua/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"vdiravka","id":11904420,"node_id":"MDQ6VXNlcjExOTA0NDIw","avatar_url":"https://avatars3.githubusercontent.com/u/11904420?v=4","gravatar_id":"","url":"https://api.github.com/users/vdiravka","html_url":"https://github.com/vdiravka","followers_url":"https://api.github.com/users/vdiravka/followers","following_url":"https://api.github.com/users/vdiravka/following{/other_user}","gists_url":"https://api.github.com/users/vdiravka/gists{/gist_id}","starred_url":"https://api.github.com/users/vdiravka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdiravka/subscriptions","organizations_url":"https://api.github.com/users/vdiravka/orgs","repos_url":"https://api.github.com/users/vdiravka/repos","events_url":"https://api.github.com/users/vdiravka/events{/privacy}","received_events_url":"https://api.github.com/users/vdiravka/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/drill/pulls/1572/commits","review_comments_url":"https://api.github.com/repos/apache/drill/pulls/1572/comments","review_comment_url":"https://api.github.com/repos/apache/drill/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/drill/issues/1572/comments","statuses_url":"https://api.github.com/repos/apache/drill/statuses/07e34b928e704b47d97e017c16614bedfe7d284c","head":{"label":"kkhatua:DRILL-6879","ref":"DRILL-6879","sha":"07e34b928e704b47d97e017c16614bedfe7d284c","user":{"login":"kkhatua","id":4335237,"node_id":"MDQ6VXNlcjQzMzUyMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/4335237?v=4","gravatar_id":"","url":"https://api.github.com/users/kkhatua","html_url":"https://github.com/kkhatua","followers_url":"https://api.github.com/users/kkhatua/followers","following_url":"https://api.github.com/users/kkhatua/following{/other_user}","gists_url":"https://api.github.com/users/kkhatua/gists{/gist_id}","starred_url":"https://api.github.com/users/kkhatua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkhatua/subscriptions","organizations_url":"https://api.github.com/users/kkhatua/orgs","repos_url":"https://api.github.com/users/kkhatua/repos","events_url":"https://api.github.com/users/kkhatua/events{/privacy}","received_events_url":"https://api.github.com/users/kkhatua/received_events","type":"User","site_admin":false},"repo":{"id":78692639,"node_id":"MDEwOlJlcG9zaXRvcnk3ODY5MjYzOQ==","name":"drill","full_name":"kkhatua/drill","private":false,"owner":{"login":"kkhatua","id":4335237,"node_id":"MDQ6VXNlcjQzMzUyMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/4335237?v=4","gravatar_id":"","url":"https://api.github.com/users/kkhatua","html_url":"https://github.com/kkhatua","followers_url":"https://api.github.com/users/kkhatua/followers","following_url":"https://api.github.com/users/kkhatua/following{/other_user}","gists_url":"https://api.github.com/users/kkhatua/gists{/gist_id}","starred_url":"https://api.github.com/users/kkhatua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkhatua/subscriptions","organizations_url":"https://api.github.com/users/kkhatua/orgs","repos_url":"https://api.github.com/users/kkhatua/repos","events_url":"https://api.github.com/users/kkhatua/events{/privacy}","received_events_url":"https://api.github.com/users/kkhatua/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kkhatua/drill","description":"Mirror of Apache Drill","fork":true,"url":"https://api.github.com/repos/kkhatua/drill","forks_url":"https://api.github.com/repos/kkhatua/drill/forks","keys_url":"https://api.github.com/repos/kkhatua/drill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kkhatua/drill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kkhatua/drill/teams","hooks_url":"https://api.github.com/repos/kkhatua/drill/hooks","issue_events_url":"https://api.github.com/repos/kkhatua/drill/issues/events{/number}","events_url":"https://api.github.com/repos/kkhatua/drill/events","assignees_url":"https://api.github.com/repos/kkhatua/drill/assignees{/user}","branches_url":"https://api.github.com/repos/kkhatua/drill/branches{/branch}","tags_url":"https://api.github.com/repos/kkhatua/drill/tags","blobs_url":"https://api.github.com/repos/kkhatua/drill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kkhatua/drill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kkhatua/drill/git/refs{/sha}","trees_url":"https://api.github.com/repos/kkhatua/drill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kkhatua/drill/statuses/{sha}","languages_url":"https://api.github.com/repos/kkhatua/drill/languages","stargazers_url":"https://api.github.com/repos/kkhatua/drill/stargazers","contributors_url":"https://api.github.com/repos/kkhatua/drill/contributors","subscribers_url":"https://api.github.com/repos/kkhatua/drill/subscribers","subscription_url":"https://api.github.com/repos/kkhatua/drill/subscription","commits_url":"https://api.github.com/repos/kkhatua/drill/commits{/sha}","git_commits_url":"https://api.github.com/repos/kkhatua/drill/git/commits{/sha}","comments_url":"https://api.github.com/repos/kkhatua/drill/comments{/number}","issue_comment_url":"https://api.github.com/repos/kkhatua/drill/issues/comments{/number}","contents_url":"https://api.github.com/repos/kkhatua/drill/contents/{+path}","compare_url":"https://api.github.com/repos/kkhatua/drill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kkhatua/drill/merges","archive_url":"https://api.github.com/repos/kkhatua/drill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kkhatua/drill/downloads","issues_url":"https://api.github.com/repos/kkhatua/drill/issues{/number}","pulls_url":"https://api.github.com/repos/kkhatua/drill/pulls{/number}","milestones_url":"https://api.github.com/repos/kkhatua/drill/milestones{/number}","notifications_url":"https://api.github.com/repos/kkhatua/drill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kkhatua/drill/labels{/name}","releases_url":"https://api.github.com/repos/kkhatua/drill/releases{/id}","deployments_url":"https://api.github.com/repos/kkhatua/drill/deployments","created_at":"2017-01-12T00:27:42Z","updated_at":"2018-12-11T00:52:02Z","pushed_at":"2018-12-11T23:15:38Z","git_url":"git://github.com/kkhatua/drill.git","ssh_url":"git@github.com:kkhatua/drill.git","clone_url":"https://github.com/kkhatua/drill.git","svn_url":"https://github.com/kkhatua/drill","homepage":"","size":65999,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"e67ac2d1f7111a8e3932e2ff69a531b64882e162","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":5683653,"node_id":"MDEwOlJlcG9zaXRvcnk1NjgzNjUz","name":"drill","full_name":"apache/drill","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/drill","description":"Apache Drill","fork":false,"url":"https://api.github.com/repos/apache/drill","forks_url":"https://api.github.com/repos/apache/drill/forks","keys_url":"https://api.github.com/repos/apache/drill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/drill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/drill/teams","hooks_url":"https://api.github.com/repos/apache/drill/hooks","issue_events_url":"https://api.github.com/repos/apache/drill/issues/events{/number}","events_url":"https://api.github.com/repos/apache/drill/events","assignees_url":"https://api.github.com/repos/apache/drill/assignees{/user}","branches_url":"https://api.github.com/repos/apache/drill/branches{/branch}","tags_url":"https://api.github.com/repos/apache/drill/tags","blobs_url":"https://api.github.com/repos/apache/drill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/drill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/drill/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/drill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/drill/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/drill/languages","stargazers_url":"https://api.github.com/repos/apache/drill/stargazers","contributors_url":"https://api.github.com/repos/apache/drill/contributors","subscribers_url":"https://api.github.com/repos/apache/drill/subscribers","subscription_url":"https://api.github.com/repos/apache/drill/subscription","commits_url":"https://api.github.com/repos/apache/drill/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/drill/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/drill/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/drill/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/drill/contents/{+path}","compare_url":"https://api.github.com/repos/apache/drill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/drill/merges","archive_url":"https://api.github.com/repos/apache/drill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/drill/downloads","issues_url":"https://api.github.com/repos/apache/drill/issues{/number}","pulls_url":"https://api.github.com/repos/apache/drill/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/drill/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/drill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/drill/labels{/name}","releases_url":"https://api.github.com/repos/apache/drill/releases{/id}","deployments_url":"https://api.github.com/repos/apache/drill/deployments","created_at":"2012-09-05T07:00:26Z","updated_at":"2018-12-11T23:17:58Z","pushed_at":"2018-12-12T00:47:46Z","git_url":"git://github.com/apache/drill.git","ssh_url":"git@github.com:apache/drill.git","clone_url":"https://github.com/apache/drill.git","svn_url":"https://github.com/apache/drill","homepage":"","size":71141,"stargazers_count":1070,"watchers_count":1070,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":706,"mirror_url":null,"archived":false,"open_issues_count":82,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":706,"open_issues":82,"watchers":1070,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/drill/pulls/1572"},"html":{"href":"https://github.com/apache/drill/pull/1572"},"issue":{"href":"https://api.github.com/repos/apache/drill/issues/1572"},"comments":{"href":"https://api.github.com/repos/apache/drill/issues/1572/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/drill/pulls/1572/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/drill/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/drill/pulls/1572/commits"},"statuses":{"href":"https://api.github.com/repos/apache/drill/statuses/07e34b928e704b47d97e017c16614bedfe7d284c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"arina-ielchiieva"}}