{"action":"created","issue":{"url":"https://api.github.com/repos/Azure/azure-powershell/issues/7555","repository_url":"https://api.github.com/repos/Azure/azure-powershell","labels_url":"https://api.github.com/repos/Azure/azure-powershell/issues/7555/labels{/name}","comments_url":"https://api.github.com/repos/Azure/azure-powershell/issues/7555/comments","events_url":"https://api.github.com/repos/Azure/azure-powershell/issues/7555/events","html_url":"https://github.com/Azure/azure-powershell/pull/7555","id":369906839,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNzE4Njgx","number":7555,"title":"Made Name parameter as optional.","user":{"login":"tanveery","id":1931313,"node_id":"MDQ6VXNlcjE5MzEzMTM=","avatar_url":"https://avatars2.githubusercontent.com/u/1931313?v=4","gravatar_id":"","url":"https://api.github.com/users/tanveery","html_url":"https://github.com/tanveery","followers_url":"https://api.github.com/users/tanveery/followers","following_url":"https://api.github.com/users/tanveery/following{/other_user}","gists_url":"https://api.github.com/users/tanveery/gists{/gist_id}","starred_url":"https://api.github.com/users/tanveery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tanveery/subscriptions","organizations_url":"https://api.github.com/users/tanveery/orgs","repos_url":"https://api.github.com/users/tanveery/repos","events_url":"https://api.github.com/users/tanveery/events{/privacy}","received_events_url":"https://api.github.com/users/tanveery/received_events","type":"User","site_admin":false},"labels":[{"id":1056158818,"node_id":"MDU6TGFiZWwxMDU2MTU4ODE4","url":"https://api.github.com/repos/Azure/azure-powershell/labels/needs-review","name":"needs-review","color":"fbcfff","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-14T14:21:27Z","updated_at":"2018-10-15T16:56:37Z","closed_at":"2018-10-15T16:56:37Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Azure/azure-powershell/pulls/7555","html_url":"https://github.com/Azure/azure-powershell/pull/7555","diff_url":"https://github.com/Azure/azure-powershell/pull/7555.diff","patch_url":"https://github.com/Azure/azure-powershell/pull/7555.patch"},"body":"The Name parameter was specified as required which is not true. For this command, the Name parameter is optional.\r\n\r\n<!-- DO NOT DELETE THIS TEMPLATE -->\r\n\r\n## Description\r\n\r\n<!-- Please add a brief description of the changes made in this PR -->\r\n\r\n## Checklist\r\n\r\n- [ ] I have read the [_Submitting Changes_](https://github.com/Azure/azure-powershell/blob/preview/CONTRIBUTING.md#submitting-changes) section of [`CONTRIBUTING.md`](https://github.com/Azure/azure-powershell/blob/preview/CONTRIBUTING.md)\r\n- [ ] The title of the PR is clear and informative\r\n- [ ] The appropriate [change log has been updated](https://github.com/Azure/azure-powershell/blob/preview/CONTRIBUTING.md#updating-the-change-log)\r\n- [ ] The PR does not introduce [breaking changes](https://github.com/Azure/azure-powershell/blob/preview/documentation/breaking-changes/breaking-changes-definition.md)\r\n- [ ] If applicable, the changes made in the PR have proper test coverage\r\n- [ ] For public API changes to cmdlets:\r\n    - [ ] the changes have gone through a [cmdlet design review](https://github.com/Azure/azure-powershell-cmdlet-review-pr) (Microsoft internal partners only)\r\n    - [ ] the cmdlet markdown files were [generated using the `platyPS` module](https://github.com/Azure/azure-powershell/blob/preview/documentation/development-docs/help-generation.md)\r\n"},"comment":{"url":"https://api.github.com/repos/Azure/azure-powershell/issues/comments/429931749","html_url":"https://github.com/Azure/azure-powershell/pull/7555#issuecomment-429931749","issue_url":"https://api.github.com/repos/Azure/azure-powershell/issues/7555","id":429931749,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTkzMTc0OQ==","user":{"login":"cormacpayne","id":4462409,"node_id":"MDQ6VXNlcjQ0NjI0MDk=","avatar_url":"https://avatars2.githubusercontent.com/u/4462409?v=4","gravatar_id":"","url":"https://api.github.com/users/cormacpayne","html_url":"https://github.com/cormacpayne","followers_url":"https://api.github.com/users/cormacpayne/followers","following_url":"https://api.github.com/users/cormacpayne/following{/other_user}","gists_url":"https://api.github.com/users/cormacpayne/gists{/gist_id}","starred_url":"https://api.github.com/users/cormacpayne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cormacpayne/subscriptions","organizations_url":"https://api.github.com/users/cormacpayne/orgs","repos_url":"https://api.github.com/users/cormacpayne/repos","events_url":"https://api.github.com/users/cormacpayne/events{/privacy}","received_events_url":"https://api.github.com/users/cormacpayne/received_events","type":"User","site_admin":false},"created_at":"2018-10-15T16:56:37Z","updated_at":"2018-10-15T16:56:37Z","author_association":"MEMBER","body":"@tanveery Hey Tanveer, there are two parameter sets for the `Get-AzureRmStorageAccount` cmdlet:\r\n\r\n(1) The default parameter set where `-ResourceGroupName` is optional -- this allows the user to provide either no parameters (returns all storage accounts in the current context) or a value for `-ResourceGroupName` (returns all storage accounts in the provided resource group)\r\n\r\n(2) The other parameter set where `-ResourceGroupName` and `-Name` are required -- this allows the user to provide a value for both of these parameters and get back a specific storage account matching the criteria provided\r\n\r\nIn the case for parameter set (2), if the user provides a value for the `-Name` parameter, but not for the `-ResourceGroupName` parameter, PowerShell will prompt the user to provide a value since it has determined the user is in set (2) and needs a value for all required parameters.\r\n\r\nThe markdown file you are editing specifies that the `-Name` parameter is available in only one parameter set and that it is required, which are both true. As a result, the requested change should not be made.\r\n\r\nPlease let me know if you have any questions 😁 "}}
{"actor":{"display_login":"cormacpayne"}}