{"action":"opened","number":523,"pull_request":{"url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/pulls/523","id":238326898,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MzI2ODk4","html_url":"https://github.com/KnpLabs/KnpPaginatorBundle/pull/523","diff_url":"https://github.com/KnpLabs/KnpPaginatorBundle/pull/523.diff","patch_url":"https://github.com/KnpLabs/KnpPaginatorBundle/pull/523.patch","issue_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/issues/523","number":523,"state":"open","locked":false,"title":"Require symfony/translation explicitly","user":{"login":"franmomu","id":720690,"node_id":"MDQ6VXNlcjcyMDY5MA==","avatar_url":"https://avatars2.githubusercontent.com/u/720690?v=4","gravatar_id":"","url":"https://api.github.com/users/franmomu","html_url":"https://github.com/franmomu","followers_url":"https://api.github.com/users/franmomu/followers","following_url":"https://api.github.com/users/franmomu/following{/other_user}","gists_url":"https://api.github.com/users/franmomu/gists{/gist_id}","starred_url":"https://api.github.com/users/franmomu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franmomu/subscriptions","organizations_url":"https://api.github.com/users/franmomu/orgs","repos_url":"https://api.github.com/users/franmomu/repos","events_url":"https://api.github.com/users/franmomu/events{/privacy}","received_events_url":"https://api.github.com/users/franmomu/received_events","type":"User","site_admin":false},"body":"I submitted [a PR to add the bundle to the recipes-contrib](https://github.com/symfony/recipes-contrib/pull/588) and it failed because of the `translator` service. \r\n\r\nhttps://github.com/KnpLabs/KnpPaginatorBundle/issues/479 is about this too, so I've just added the dependency explicitly, the question is whether the dependency is required explicitly or make it optional.","created_at":"2018-12-13T09:55:09Z","updated_at":"2018-12-13T09:55:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/pulls/523/commits","review_comments_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/pulls/523/comments","review_comment_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/issues/523/comments","statuses_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/statuses/5d496249722426f9671d73044374234dbe3fc0c7","head":{"label":"franmomu:add_symfony_translation_dependency","ref":"add_symfony_translation_dependency","sha":"5d496249722426f9671d73044374234dbe3fc0c7","user":{"login":"franmomu","id":720690,"node_id":"MDQ6VXNlcjcyMDY5MA==","avatar_url":"https://avatars2.githubusercontent.com/u/720690?v=4","gravatar_id":"","url":"https://api.github.com/users/franmomu","html_url":"https://github.com/franmomu","followers_url":"https://api.github.com/users/franmomu/followers","following_url":"https://api.github.com/users/franmomu/following{/other_user}","gists_url":"https://api.github.com/users/franmomu/gists{/gist_id}","starred_url":"https://api.github.com/users/franmomu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franmomu/subscriptions","organizations_url":"https://api.github.com/users/franmomu/orgs","repos_url":"https://api.github.com/users/franmomu/repos","events_url":"https://api.github.com/users/franmomu/events{/privacy}","received_events_url":"https://api.github.com/users/franmomu/received_events","type":"User","site_admin":false},"repo":{"id":161612058,"node_id":"MDEwOlJlcG9zaXRvcnkxNjE2MTIwNTg=","name":"KnpPaginatorBundle","full_name":"franmomu/KnpPaginatorBundle","private":false,"owner":{"login":"franmomu","id":720690,"node_id":"MDQ6VXNlcjcyMDY5MA==","avatar_url":"https://avatars2.githubusercontent.com/u/720690?v=4","gravatar_id":"","url":"https://api.github.com/users/franmomu","html_url":"https://github.com/franmomu","followers_url":"https://api.github.com/users/franmomu/followers","following_url":"https://api.github.com/users/franmomu/following{/other_user}","gists_url":"https://api.github.com/users/franmomu/gists{/gist_id}","starred_url":"https://api.github.com/users/franmomu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franmomu/subscriptions","organizations_url":"https://api.github.com/users/franmomu/orgs","repos_url":"https://api.github.com/users/franmomu/repos","events_url":"https://api.github.com/users/franmomu/events{/privacy}","received_events_url":"https://api.github.com/users/franmomu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/franmomu/KnpPaginatorBundle","description":"SEO friendly Symfony paginator to sort and paginate","fork":true,"url":"https://api.github.com/repos/franmomu/KnpPaginatorBundle","forks_url":"https://api.github.com/repos/franmomu/KnpPaginatorBundle/forks","keys_url":"https://api.github.com/repos/franmomu/KnpPaginatorBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/franmomu/KnpPaginatorBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/franmomu/KnpPaginatorBundle/teams","hooks_url":"https://api.github.com/repos/franmomu/KnpPaginatorBundle/hooks","issue_events_url":"https://api.github.com/repos/franmomu/KnpPaginatorBundle/issues/events{/number}","events_url":"https://api.github.com/repos/franmomu/KnpPaginatorBundle/events","assignees_url":"https://api.github.com/repos/franmomu/KnpPaginatorBundle/assignees{/user}","branches_url":"https://api.github.com/repos/franmomu/KnpPaginatorBundle/branches{/branch}","tags_url":"https://api.github.com/repos/franmomu/KnpPaginatorBundle/tags","blobs_url":"https://api.github.com/repos/franmomu/KnpPaginatorBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/franmomu/KnpPaginatorBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/franmomu/KnpPaginatorBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/franmomu/KnpPaginatorBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/franmomu/KnpPaginatorBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/franmomu/KnpPaginatorBundle/languages","stargazers_url":"https://api.github.com/repos/franmomu/KnpPaginatorBundle/stargazers","contributors_url":"https://api.github.com/repos/franmomu/KnpPaginatorBundle/contributors","subscribers_url":"https://api.github.com/repos/franmomu/KnpPaginatorBundle/subscribers","subscription_url":"https://api.github.com/repos/franmomu/KnpPaginatorBundle/subscription","commits_url":"https://api.github.com/repos/franmomu/KnpPaginatorBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/franmomu/KnpPaginatorBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/franmomu/KnpPaginatorBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/franmomu/KnpPaginatorBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/franmomu/KnpPaginatorBundle/contents/{+path}","compare_url":"https://api.github.com/repos/franmomu/KnpPaginatorBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/franmomu/KnpPaginatorBundle/merges","archive_url":"https://api.github.com/repos/franmomu/KnpPaginatorBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/franmomu/KnpPaginatorBundle/downloads","issues_url":"https://api.github.com/repos/franmomu/KnpPaginatorBundle/issues{/number}","pulls_url":"https://api.github.com/repos/franmomu/KnpPaginatorBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/franmomu/KnpPaginatorBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/franmomu/KnpPaginatorBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/franmomu/KnpPaginatorBundle/labels{/name}","releases_url":"https://api.github.com/repos/franmomu/KnpPaginatorBundle/releases{/id}","deployments_url":"https://api.github.com/repos/franmomu/KnpPaginatorBundle/deployments","created_at":"2018-12-13T09:04:53Z","updated_at":"2018-12-13T09:04:56Z","pushed_at":"2018-12-13T09:39:26Z","git_url":"git://github.com/franmomu/KnpPaginatorBundle.git","ssh_url":"git@github.com:franmomu/KnpPaginatorBundle.git","clone_url":"https://github.com/franmomu/KnpPaginatorBundle.git","svn_url":"https://github.com/franmomu/KnpPaginatorBundle","homepage":"http://knplabs.com/en/blog/knp-paginator-reborn","size":451,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KnpLabs:master","ref":"master","sha":"e94acc11c4f592e20d219da025d1152f87536338","user":{"login":"KnpLabs","id":202732,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMjczMg==","avatar_url":"https://avatars3.githubusercontent.com/u/202732?v=4","gravatar_id":"","url":"https://api.github.com/users/KnpLabs","html_url":"https://github.com/KnpLabs","followers_url":"https://api.github.com/users/KnpLabs/followers","following_url":"https://api.github.com/users/KnpLabs/following{/other_user}","gists_url":"https://api.github.com/users/KnpLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/KnpLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KnpLabs/subscriptions","organizations_url":"https://api.github.com/users/KnpLabs/orgs","repos_url":"https://api.github.com/users/KnpLabs/repos","events_url":"https://api.github.com/users/KnpLabs/events{/privacy}","received_events_url":"https://api.github.com/users/KnpLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":859126,"node_id":"MDEwOlJlcG9zaXRvcnk4NTkxMjY=","name":"KnpPaginatorBundle","full_name":"KnpLabs/KnpPaginatorBundle","private":false,"owner":{"login":"KnpLabs","id":202732,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMjczMg==","avatar_url":"https://avatars3.githubusercontent.com/u/202732?v=4","gravatar_id":"","url":"https://api.github.com/users/KnpLabs","html_url":"https://github.com/KnpLabs","followers_url":"https://api.github.com/users/KnpLabs/followers","following_url":"https://api.github.com/users/KnpLabs/following{/other_user}","gists_url":"https://api.github.com/users/KnpLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/KnpLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KnpLabs/subscriptions","organizations_url":"https://api.github.com/users/KnpLabs/orgs","repos_url":"https://api.github.com/users/KnpLabs/repos","events_url":"https://api.github.com/users/KnpLabs/events{/privacy}","received_events_url":"https://api.github.com/users/KnpLabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/KnpLabs/KnpPaginatorBundle","description":"SEO friendly Symfony paginator to sort and paginate","fork":false,"url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle","forks_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/forks","keys_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/teams","hooks_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/hooks","issue_events_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/issues/events{/number}","events_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/events","assignees_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/assignees{/user}","branches_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/branches{/branch}","tags_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/tags","blobs_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/languages","stargazers_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/stargazers","contributors_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/contributors","subscribers_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/subscribers","subscription_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/subscription","commits_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/contents/{+path}","compare_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/merges","archive_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/downloads","issues_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/issues{/number}","pulls_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/labels{/name}","releases_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/releases{/id}","deployments_url":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/deployments","created_at":"2010-08-24T13:51:40Z","updated_at":"2018-12-11T12:34:54Z","pushed_at":"2018-12-11T12:34:52Z","git_url":"git://github.com/KnpLabs/KnpPaginatorBundle.git","ssh_url":"git@github.com:KnpLabs/KnpPaginatorBundle.git","clone_url":"https://github.com/KnpLabs/KnpPaginatorBundle.git","svn_url":"https://github.com/KnpLabs/KnpPaginatorBundle","homepage":"http://knplabs.com/en/blog/knp-paginator-reborn","size":451,"stargazers_count":934,"watchers_count":934,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":281,"mirror_url":null,"archived":false,"open_issues_count":40,"license":null,"forks":281,"open_issues":40,"watchers":934,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/pulls/523"},"html":{"href":"https://github.com/KnpLabs/KnpPaginatorBundle/pull/523"},"issue":{"href":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/issues/523"},"comments":{"href":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/issues/523/comments"},"review_comments":{"href":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/pulls/523/comments"},"review_comment":{"href":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/pulls/523/commits"},"statuses":{"href":"https://api.github.com/repos/KnpLabs/KnpPaginatorBundle/statuses/5d496249722426f9671d73044374234dbe3fc0c7"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"franmomu"}}