{"action":"created","comment":{"url":"https://api.github.com/repos/mitodl/salt-ops/pulls/comments/204404694","pull_request_review_id":139477505,"id":204404694,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDQwNDY5NA==","diff_hunk":"@@ -0,0 +1,46 @@\n+{% set env_settings = salt.cp.get_file_str(\"salt://environment_settings.yml\")|load_yaml %}\n+{% set ttl = '8760h' %}","path":"pillar/vault/roles/pki.sls","position":2,"original_position":2,"commit_id":"4b9c9f73eca880046d126763be91e3b79e93cd42","original_commit_id":"4b9c9f73eca880046d126763be91e3b79e93cd42","user":{"login":"shaidar","id":1447295,"node_id":"MDQ6VXNlcjE0NDcyOTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1447295?v=4","gravatar_id":"","url":"https://api.github.com/users/shaidar","html_url":"https://github.com/shaidar","followers_url":"https://api.github.com/users/shaidar/followers","following_url":"https://api.github.com/users/shaidar/following{/other_user}","gists_url":"https://api.github.com/users/shaidar/gists{/gist_id}","starred_url":"https://api.github.com/users/shaidar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaidar/subscriptions","organizations_url":"https://api.github.com/users/shaidar/orgs","repos_url":"https://api.github.com/users/shaidar/repos","events_url":"https://api.github.com/users/shaidar/events{/privacy}","received_events_url":"https://api.github.com/users/shaidar/received_events","type":"User","site_admin":false},"body":"Doesn't that defeat the purpose since then if/when you want to change the variable you'd have to change it everywhere you've used it?","created_at":"2018-07-23T13:42:31Z","updated_at":"2018-07-23T13:42:31Z","html_url":"https://github.com/mitodl/salt-ops/pull/663#discussion_r204404694","pull_request_url":"https://api.github.com/repos/mitodl/salt-ops/pulls/663","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mitodl/salt-ops/pulls/comments/204404694"},"html":{"href":"https://github.com/mitodl/salt-ops/pull/663#discussion_r204404694"},"pull_request":{"href":"https://api.github.com/repos/mitodl/salt-ops/pulls/663"}},"in_reply_to_id":203840119},"pull_request":{"url":"https://api.github.com/repos/mitodl/salt-ops/pulls/663","id":202634588,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNjM0NTg4","html_url":"https://github.com/mitodl/salt-ops/pull/663","diff_url":"https://github.com/mitodl/salt-ops/pull/663.diff","patch_url":"https://github.com/mitodl/salt-ops/pull/663.patch","issue_url":"https://api.github.com/repos/mitodl/salt-ops/issues/663","number":663,"state":"open","locked":false,"title":"Setup vault pki backends and roles to use those backends","user":{"login":"shaidar","id":1447295,"node_id":"MDQ6VXNlcjE0NDcyOTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1447295?v=4","gravatar_id":"","url":"https://api.github.com/users/shaidar","html_url":"https://github.com/shaidar","followers_url":"https://api.github.com/users/shaidar/followers","following_url":"https://api.github.com/users/shaidar/following{/other_user}","gists_url":"https://api.github.com/users/shaidar/gists{/gist_id}","starred_url":"https://api.github.com/users/shaidar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaidar/subscriptions","organizations_url":"https://api.github.com/users/shaidar/orgs","repos_url":"https://api.github.com/users/shaidar/repos","events_url":"https://api.github.com/users/shaidar/events{/privacy}","received_events_url":"https://api.github.com/users/shaidar/received_events","type":"User","site_admin":false},"body":"#### What are the relevant tickets?\r\n[Issue#20](https://github.com/mitodl/salt-ops/issues/20)\r\n\r\n#### What's this PR do?\r\nSetup vault pki backends and roles to use those backends. Also added new variables to env_settings that specifies what services each environment needs. The roles file needs extra scrutiny as I'm a bit unsure about how the server/client flags will work.\r\n","created_at":"2018-07-19T17:42:31Z","updated_at":"2018-07-23T13:42:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd894dc5e735b06e6dfcf7328a9234a92c98bcf6","assignee":{"login":"blarghmatey","id":479088,"node_id":"MDQ6VXNlcjQ3OTA4OA==","avatar_url":"https://avatars3.githubusercontent.com/u/479088?v=4","gravatar_id":"","url":"https://api.github.com/users/blarghmatey","html_url":"https://github.com/blarghmatey","followers_url":"https://api.github.com/users/blarghmatey/followers","following_url":"https://api.github.com/users/blarghmatey/following{/other_user}","gists_url":"https://api.github.com/users/blarghmatey/gists{/gist_id}","starred_url":"https://api.github.com/users/blarghmatey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blarghmatey/subscriptions","organizations_url":"https://api.github.com/users/blarghmatey/orgs","repos_url":"https://api.github.com/users/blarghmatey/repos","events_url":"https://api.github.com/users/blarghmatey/events{/privacy}","received_events_url":"https://api.github.com/users/blarghmatey/received_events","type":"User","site_admin":false},"assignees":[{"login":"blarghmatey","id":479088,"node_id":"MDQ6VXNlcjQ3OTA4OA==","avatar_url":"https://avatars3.githubusercontent.com/u/479088?v=4","gravatar_id":"","url":"https://api.github.com/users/blarghmatey","html_url":"https://github.com/blarghmatey","followers_url":"https://api.github.com/users/blarghmatey/followers","following_url":"https://api.github.com/users/blarghmatey/following{/other_user}","gists_url":"https://api.github.com/users/blarghmatey/gists{/gist_id}","starred_url":"https://api.github.com/users/blarghmatey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blarghmatey/subscriptions","organizations_url":"https://api.github.com/users/blarghmatey/orgs","repos_url":"https://api.github.com/users/blarghmatey/repos","events_url":"https://api.github.com/users/blarghmatey/events{/privacy}","received_events_url":"https://api.github.com/users/blarghmatey/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":334576104,"node_id":"MDU6TGFiZWwzMzQ1NzYxMDQ=","url":"https://api.github.com/repos/mitodl/salt-ops/labels/DevOps","name":"DevOps","color":"EB6420","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mitodl/salt-ops/pulls/663/commits","review_comments_url":"https://api.github.com/repos/mitodl/salt-ops/pulls/663/comments","review_comment_url":"https://api.github.com/repos/mitodl/salt-ops/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mitodl/salt-ops/issues/663/comments","statuses_url":"https://api.github.com/repos/mitodl/salt-ops/statuses/4b9c9f73eca880046d126763be91e3b79e93cd42","head":{"label":"mitodl:sar/vault_pki","ref":"sar/vault_pki","sha":"4b9c9f73eca880046d126763be91e3b79e93cd42","user":{"login":"mitodl","id":7918516,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MTg1MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/7918516?v=4","gravatar_id":"","url":"https://api.github.com/users/mitodl","html_url":"https://github.com/mitodl","followers_url":"https://api.github.com/users/mitodl/followers","following_url":"https://api.github.com/users/mitodl/following{/other_user}","gists_url":"https://api.github.com/users/mitodl/gists{/gist_id}","starred_url":"https://api.github.com/users/mitodl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitodl/subscriptions","organizations_url":"https://api.github.com/users/mitodl/orgs","repos_url":"https://api.github.com/users/mitodl/repos","events_url":"https://api.github.com/users/mitodl/events{/privacy}","received_events_url":"https://api.github.com/users/mitodl/received_events","type":"Organization","site_admin":false},"repo":{"id":52479140,"node_id":"MDEwOlJlcG9zaXRvcnk1MjQ3OTE0MA==","name":"salt-ops","full_name":"mitodl/salt-ops","owner":{"login":"mitodl","id":7918516,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MTg1MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/7918516?v=4","gravatar_id":"","url":"https://api.github.com/users/mitodl","html_url":"https://github.com/mitodl","followers_url":"https://api.github.com/users/mitodl/followers","following_url":"https://api.github.com/users/mitodl/following{/other_user}","gists_url":"https://api.github.com/users/mitodl/gists{/gist_id}","starred_url":"https://api.github.com/users/mitodl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitodl/subscriptions","organizations_url":"https://api.github.com/users/mitodl/orgs","repos_url":"https://api.github.com/users/mitodl/repos","events_url":"https://api.github.com/users/mitodl/events{/privacy}","received_events_url":"https://api.github.com/users/mitodl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mitodl/salt-ops","description":"Repository for building, managing and deploying salt-based infrastructure","fork":false,"url":"https://api.github.com/repos/mitodl/salt-ops","forks_url":"https://api.github.com/repos/mitodl/salt-ops/forks","keys_url":"https://api.github.com/repos/mitodl/salt-ops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mitodl/salt-ops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mitodl/salt-ops/teams","hooks_url":"https://api.github.com/repos/mitodl/salt-ops/hooks","issue_events_url":"https://api.github.com/repos/mitodl/salt-ops/issues/events{/number}","events_url":"https://api.github.com/repos/mitodl/salt-ops/events","assignees_url":"https://api.github.com/repos/mitodl/salt-ops/assignees{/user}","branches_url":"https://api.github.com/repos/mitodl/salt-ops/branches{/branch}","tags_url":"https://api.github.com/repos/mitodl/salt-ops/tags","blobs_url":"https://api.github.com/repos/mitodl/salt-ops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mitodl/salt-ops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mitodl/salt-ops/git/refs{/sha}","trees_url":"https://api.github.com/repos/mitodl/salt-ops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mitodl/salt-ops/statuses/{sha}","languages_url":"https://api.github.com/repos/mitodl/salt-ops/languages","stargazers_url":"https://api.github.com/repos/mitodl/salt-ops/stargazers","contributors_url":"https://api.github.com/repos/mitodl/salt-ops/contributors","subscribers_url":"https://api.github.com/repos/mitodl/salt-ops/subscribers","subscription_url":"https://api.github.com/repos/mitodl/salt-ops/subscription","commits_url":"https://api.github.com/repos/mitodl/salt-ops/commits{/sha}","git_commits_url":"https://api.github.com/repos/mitodl/salt-ops/git/commits{/sha}","comments_url":"https://api.github.com/repos/mitodl/salt-ops/comments{/number}","issue_comment_url":"https://api.github.com/repos/mitodl/salt-ops/issues/comments{/number}","contents_url":"https://api.github.com/repos/mitodl/salt-ops/contents/{+path}","compare_url":"https://api.github.com/repos/mitodl/salt-ops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mitodl/salt-ops/merges","archive_url":"https://api.github.com/repos/mitodl/salt-ops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mitodl/salt-ops/downloads","issues_url":"https://api.github.com/repos/mitodl/salt-ops/issues{/number}","pulls_url":"https://api.github.com/repos/mitodl/salt-ops/pulls{/number}","milestones_url":"https://api.github.com/repos/mitodl/salt-ops/milestones{/number}","notifications_url":"https://api.github.com/repos/mitodl/salt-ops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mitodl/salt-ops/labels{/name}","releases_url":"https://api.github.com/repos/mitodl/salt-ops/releases{/id}","deployments_url":"https://api.github.com/repos/mitodl/salt-ops/deployments","created_at":"2016-02-24T22:30:34Z","updated_at":"2018-07-20T11:55:19Z","pushed_at":"2018-07-20T11:55:21Z","git_url":"git://github.com/mitodl/salt-ops.git","ssh_url":"git@github.com:mitodl/salt-ops.git","clone_url":"https://github.com/mitodl/salt-ops.git","svn_url":"https://github.com/mitodl/salt-ops","homepage":null,"size":18594,"stargazers_count":23,"watchers_count":23,"language":"SaltStack","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":3,"open_issues":55,"watchers":23,"default_branch":"master"}},"base":{"label":"mitodl:master","ref":"master","sha":"6400951bfe44912a7dd3b8db77b36234a621bdab","user":{"login":"mitodl","id":7918516,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MTg1MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/7918516?v=4","gravatar_id":"","url":"https://api.github.com/users/mitodl","html_url":"https://github.com/mitodl","followers_url":"https://api.github.com/users/mitodl/followers","following_url":"https://api.github.com/users/mitodl/following{/other_user}","gists_url":"https://api.github.com/users/mitodl/gists{/gist_id}","starred_url":"https://api.github.com/users/mitodl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitodl/subscriptions","organizations_url":"https://api.github.com/users/mitodl/orgs","repos_url":"https://api.github.com/users/mitodl/repos","events_url":"https://api.github.com/users/mitodl/events{/privacy}","received_events_url":"https://api.github.com/users/mitodl/received_events","type":"Organization","site_admin":false},"repo":{"id":52479140,"node_id":"MDEwOlJlcG9zaXRvcnk1MjQ3OTE0MA==","name":"salt-ops","full_name":"mitodl/salt-ops","owner":{"login":"mitodl","id":7918516,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MTg1MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/7918516?v=4","gravatar_id":"","url":"https://api.github.com/users/mitodl","html_url":"https://github.com/mitodl","followers_url":"https://api.github.com/users/mitodl/followers","following_url":"https://api.github.com/users/mitodl/following{/other_user}","gists_url":"https://api.github.com/users/mitodl/gists{/gist_id}","starred_url":"https://api.github.com/users/mitodl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitodl/subscriptions","organizations_url":"https://api.github.com/users/mitodl/orgs","repos_url":"https://api.github.com/users/mitodl/repos","events_url":"https://api.github.com/users/mitodl/events{/privacy}","received_events_url":"https://api.github.com/users/mitodl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mitodl/salt-ops","description":"Repository for building, managing and deploying salt-based infrastructure","fork":false,"url":"https://api.github.com/repos/mitodl/salt-ops","forks_url":"https://api.github.com/repos/mitodl/salt-ops/forks","keys_url":"https://api.github.com/repos/mitodl/salt-ops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mitodl/salt-ops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mitodl/salt-ops/teams","hooks_url":"https://api.github.com/repos/mitodl/salt-ops/hooks","issue_events_url":"https://api.github.com/repos/mitodl/salt-ops/issues/events{/number}","events_url":"https://api.github.com/repos/mitodl/salt-ops/events","assignees_url":"https://api.github.com/repos/mitodl/salt-ops/assignees{/user}","branches_url":"https://api.github.com/repos/mitodl/salt-ops/branches{/branch}","tags_url":"https://api.github.com/repos/mitodl/salt-ops/tags","blobs_url":"https://api.github.com/repos/mitodl/salt-ops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mitodl/salt-ops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mitodl/salt-ops/git/refs{/sha}","trees_url":"https://api.github.com/repos/mitodl/salt-ops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mitodl/salt-ops/statuses/{sha}","languages_url":"https://api.github.com/repos/mitodl/salt-ops/languages","stargazers_url":"https://api.github.com/repos/mitodl/salt-ops/stargazers","contributors_url":"https://api.github.com/repos/mitodl/salt-ops/contributors","subscribers_url":"https://api.github.com/repos/mitodl/salt-ops/subscribers","subscription_url":"https://api.github.com/repos/mitodl/salt-ops/subscription","commits_url":"https://api.github.com/repos/mitodl/salt-ops/commits{/sha}","git_commits_url":"https://api.github.com/repos/mitodl/salt-ops/git/commits{/sha}","comments_url":"https://api.github.com/repos/mitodl/salt-ops/comments{/number}","issue_comment_url":"https://api.github.com/repos/mitodl/salt-ops/issues/comments{/number}","contents_url":"https://api.github.com/repos/mitodl/salt-ops/contents/{+path}","compare_url":"https://api.github.com/repos/mitodl/salt-ops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mitodl/salt-ops/merges","archive_url":"https://api.github.com/repos/mitodl/salt-ops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mitodl/salt-ops/downloads","issues_url":"https://api.github.com/repos/mitodl/salt-ops/issues{/number}","pulls_url":"https://api.github.com/repos/mitodl/salt-ops/pulls{/number}","milestones_url":"https://api.github.com/repos/mitodl/salt-ops/milestones{/number}","notifications_url":"https://api.github.com/repos/mitodl/salt-ops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mitodl/salt-ops/labels{/name}","releases_url":"https://api.github.com/repos/mitodl/salt-ops/releases{/id}","deployments_url":"https://api.github.com/repos/mitodl/salt-ops/deployments","created_at":"2016-02-24T22:30:34Z","updated_at":"2018-07-20T11:55:19Z","pushed_at":"2018-07-20T11:55:21Z","git_url":"git://github.com/mitodl/salt-ops.git","ssh_url":"git@github.com:mitodl/salt-ops.git","clone_url":"https://github.com/mitodl/salt-ops.git","svn_url":"https://github.com/mitodl/salt-ops","homepage":null,"size":18594,"stargazers_count":23,"watchers_count":23,"language":"SaltStack","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":3,"open_issues":55,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mitodl/salt-ops/pulls/663"},"html":{"href":"https://github.com/mitodl/salt-ops/pull/663"},"issue":{"href":"https://api.github.com/repos/mitodl/salt-ops/issues/663"},"comments":{"href":"https://api.github.com/repos/mitodl/salt-ops/issues/663/comments"},"review_comments":{"href":"https://api.github.com/repos/mitodl/salt-ops/pulls/663/comments"},"review_comment":{"href":"https://api.github.com/repos/mitodl/salt-ops/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mitodl/salt-ops/pulls/663/commits"},"statuses":{"href":"https://api.github.com/repos/mitodl/salt-ops/statuses/4b9c9f73eca880046d126763be91e3b79e93cd42"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"shaidar"}}