{"action":"opened","number":3,"pull_request":{"url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/pulls/3","id":191684237,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNjg0MjM3","html_url":"https://github.com/PrekshaNema25/StructuredData_To_Descriptions/pull/3","diff_url":"https://github.com/PrekshaNema25/StructuredData_To_Descriptions/pull/3.diff","patch_url":"https://github.com/PrekshaNema25/StructuredData_To_Descriptions/pull/3.patch","issue_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/issues/3","number":3,"state":"open","locked":false,"title":"Python 2 to 3 and tf 0.x to 1.x","user":{"login":"mattilyra","id":1055719,"node_id":"MDQ6VXNlcjEwNTU3MTk=","avatar_url":"https://avatars2.githubusercontent.com/u/1055719?v=4","gravatar_id":"","url":"https://api.github.com/users/mattilyra","html_url":"https://github.com/mattilyra","followers_url":"https://api.github.com/users/mattilyra/followers","following_url":"https://api.github.com/users/mattilyra/following{/other_user}","gists_url":"https://api.github.com/users/mattilyra/gists{/gist_id}","starred_url":"https://api.github.com/users/mattilyra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattilyra/subscriptions","organizations_url":"https://api.github.com/users/mattilyra/orgs","repos_url":"https://api.github.com/users/mattilyra/repos","events_url":"https://api.github.com/users/mattilyra/events{/privacy}","received_events_url":"https://api.github.com/users/mattilyra/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nI did a little bit of cleaning work on the code to fix mixed indentation, ported the code to python 3 and to use the 1.8 tf API instead of 0.x. All of the ported tf files are in `code_tf1X` directory.\r\n\r\nI've checked that the code runs but I haven't verified that it produces that same results as the `tf 0.12` version.\r\n\r\nI used the `tf_upgrade.py` tool from this repo (https://github.com/tensorflow/tensorflow/tree/master/tensorflow/tools/compatibility) to port most of the tf API calls and manually fixed the ones the tool does not handle. These were all related to variable ordering in the API calls, this page gives a pretty good overview of all changes (https://www.tensorflow.org/install/migration).\r\n\r\nThe function calls that needed to be changed were `array_ops.split` and `array_ops.concat`, as I said above the only change is the order of the arguments. Additionally a call to `nn_ops.sparse_softmax_cross_entropy_with_logits` in `vad.py:93` should be a keyword argument only call.\r\n\r\nI would highly appreciate if you have the time to verify that the code still produces the correct output with these changes.\r\n\r\nMy environment is:\r\n\r\n- python 3.6\r\n- tensorflow 1.8.0","created_at":"2018-05-31T08:49:11Z","updated_at":"2018-05-31T08:49:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/pulls/3/commits","review_comments_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/pulls/3/comments","review_comment_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/issues/3/comments","statuses_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/statuses/2e01b9fb6309cad0796b3367930789bc620b85e0","head":{"label":"mattilyra:code_fixing","ref":"code_fixing","sha":"2e01b9fb6309cad0796b3367930789bc620b85e0","user":{"login":"mattilyra","id":1055719,"node_id":"MDQ6VXNlcjEwNTU3MTk=","avatar_url":"https://avatars2.githubusercontent.com/u/1055719?v=4","gravatar_id":"","url":"https://api.github.com/users/mattilyra","html_url":"https://github.com/mattilyra","followers_url":"https://api.github.com/users/mattilyra/followers","following_url":"https://api.github.com/users/mattilyra/following{/other_user}","gists_url":"https://api.github.com/users/mattilyra/gists{/gist_id}","starred_url":"https://api.github.com/users/mattilyra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattilyra/subscriptions","organizations_url":"https://api.github.com/users/mattilyra/orgs","repos_url":"https://api.github.com/users/mattilyra/repos","events_url":"https://api.github.com/users/mattilyra/events{/privacy}","received_events_url":"https://api.github.com/users/mattilyra/received_events","type":"User","site_admin":false},"repo":{"id":135544464,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU1NDQ0NjQ=","name":"StructuredData_To_Descriptions","full_name":"mattilyra/StructuredData_To_Descriptions","owner":{"login":"mattilyra","id":1055719,"node_id":"MDQ6VXNlcjEwNTU3MTk=","avatar_url":"https://avatars2.githubusercontent.com/u/1055719?v=4","gravatar_id":"","url":"https://api.github.com/users/mattilyra","html_url":"https://github.com/mattilyra","followers_url":"https://api.github.com/users/mattilyra/followers","following_url":"https://api.github.com/users/mattilyra/following{/other_user}","gists_url":"https://api.github.com/users/mattilyra/gists{/gist_id}","starred_url":"https://api.github.com/users/mattilyra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattilyra/subscriptions","organizations_url":"https://api.github.com/users/mattilyra/orgs","repos_url":"https://api.github.com/users/mattilyra/repos","events_url":"https://api.github.com/users/mattilyra/events{/privacy}","received_events_url":"https://api.github.com/users/mattilyra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mattilyra/StructuredData_To_Descriptions","description":null,"fork":true,"url":"https://api.github.com/repos/mattilyra/StructuredData_To_Descriptions","forks_url":"https://api.github.com/repos/mattilyra/StructuredData_To_Descriptions/forks","keys_url":"https://api.github.com/repos/mattilyra/StructuredData_To_Descriptions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattilyra/StructuredData_To_Descriptions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattilyra/StructuredData_To_Descriptions/teams","hooks_url":"https://api.github.com/repos/mattilyra/StructuredData_To_Descriptions/hooks","issue_events_url":"https://api.github.com/repos/mattilyra/StructuredData_To_Descriptions/issues/events{/number}","events_url":"https://api.github.com/repos/mattilyra/StructuredData_To_Descriptions/events","assignees_url":"https://api.github.com/repos/mattilyra/StructuredData_To_Descriptions/assignees{/user}","branches_url":"https://api.github.com/repos/mattilyra/StructuredData_To_Descriptions/branches{/branch}","tags_url":"https://api.github.com/repos/mattilyra/StructuredData_To_Descriptions/tags","blobs_url":"https://api.github.com/repos/mattilyra/StructuredData_To_Descriptions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattilyra/StructuredData_To_Descriptions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattilyra/StructuredData_To_Descriptions/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattilyra/StructuredData_To_Descriptions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattilyra/StructuredData_To_Descriptions/statuses/{sha}","languages_url":"https://api.github.com/repos/mattilyra/StructuredData_To_Descriptions/languages","stargazers_url":"https://api.github.com/repos/mattilyra/StructuredData_To_Descriptions/stargazers","contributors_url":"https://api.github.com/repos/mattilyra/StructuredData_To_Descriptions/contributors","subscribers_url":"https://api.github.com/repos/mattilyra/StructuredData_To_Descriptions/subscribers","subscription_url":"https://api.github.com/repos/mattilyra/StructuredData_To_Descriptions/subscription","commits_url":"https://api.github.com/repos/mattilyra/StructuredData_To_Descriptions/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattilyra/StructuredData_To_Descriptions/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattilyra/StructuredData_To_Descriptions/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattilyra/StructuredData_To_Descriptions/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattilyra/StructuredData_To_Descriptions/contents/{+path}","compare_url":"https://api.github.com/repos/mattilyra/StructuredData_To_Descriptions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattilyra/StructuredData_To_Descriptions/merges","archive_url":"https://api.github.com/repos/mattilyra/StructuredData_To_Descriptions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattilyra/StructuredData_To_Descriptions/downloads","issues_url":"https://api.github.com/repos/mattilyra/StructuredData_To_Descriptions/issues{/number}","pulls_url":"https://api.github.com/repos/mattilyra/StructuredData_To_Descriptions/pulls{/number}","milestones_url":"https://api.github.com/repos/mattilyra/StructuredData_To_Descriptions/milestones{/number}","notifications_url":"https://api.github.com/repos/mattilyra/StructuredData_To_Descriptions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattilyra/StructuredData_To_Descriptions/labels{/name}","releases_url":"https://api.github.com/repos/mattilyra/StructuredData_To_Descriptions/releases{/id}","deployments_url":"https://api.github.com/repos/mattilyra/StructuredData_To_Descriptions/deployments","created_at":"2018-05-31T06:54:22Z","updated_at":"2018-05-31T06:54:27Z","pushed_at":"2018-05-31T08:40:29Z","git_url":"git://github.com/mattilyra/StructuredData_To_Descriptions.git","ssh_url":"git@github.com:mattilyra/StructuredData_To_Descriptions.git","clone_url":"https://github.com/mattilyra/StructuredData_To_Descriptions.git","svn_url":"https://github.com/mattilyra/StructuredData_To_Descriptions","homepage":null,"size":37268,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PrekshaNema25:master","ref":"master","sha":"0777033c05298d565b2947104fca15fe34f6c74c","user":{"login":"PrekshaNema25","id":28468329,"node_id":"MDQ6VXNlcjI4NDY4MzI5","avatar_url":"https://avatars0.githubusercontent.com/u/28468329?v=4","gravatar_id":"","url":"https://api.github.com/users/PrekshaNema25","html_url":"https://github.com/PrekshaNema25","followers_url":"https://api.github.com/users/PrekshaNema25/followers","following_url":"https://api.github.com/users/PrekshaNema25/following{/other_user}","gists_url":"https://api.github.com/users/PrekshaNema25/gists{/gist_id}","starred_url":"https://api.github.com/users/PrekshaNema25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrekshaNema25/subscriptions","organizations_url":"https://api.github.com/users/PrekshaNema25/orgs","repos_url":"https://api.github.com/users/PrekshaNema25/repos","events_url":"https://api.github.com/users/PrekshaNema25/events{/privacy}","received_events_url":"https://api.github.com/users/PrekshaNema25/received_events","type":"User","site_admin":false},"repo":{"id":128368045,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgzNjgwNDU=","name":"StructuredData_To_Descriptions","full_name":"PrekshaNema25/StructuredData_To_Descriptions","owner":{"login":"PrekshaNema25","id":28468329,"node_id":"MDQ6VXNlcjI4NDY4MzI5","avatar_url":"https://avatars0.githubusercontent.com/u/28468329?v=4","gravatar_id":"","url":"https://api.github.com/users/PrekshaNema25","html_url":"https://github.com/PrekshaNema25","followers_url":"https://api.github.com/users/PrekshaNema25/followers","following_url":"https://api.github.com/users/PrekshaNema25/following{/other_user}","gists_url":"https://api.github.com/users/PrekshaNema25/gists{/gist_id}","starred_url":"https://api.github.com/users/PrekshaNema25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrekshaNema25/subscriptions","organizations_url":"https://api.github.com/users/PrekshaNema25/orgs","repos_url":"https://api.github.com/users/PrekshaNema25/repos","events_url":"https://api.github.com/users/PrekshaNema25/events{/privacy}","received_events_url":"https://api.github.com/users/PrekshaNema25/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PrekshaNema25/StructuredData_To_Descriptions","description":null,"fork":false,"url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions","forks_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/forks","keys_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/teams","hooks_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/hooks","issue_events_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/issues/events{/number}","events_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/events","assignees_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/assignees{/user}","branches_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/branches{/branch}","tags_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/tags","blobs_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/git/refs{/sha}","trees_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/statuses/{sha}","languages_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/languages","stargazers_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/stargazers","contributors_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/contributors","subscribers_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/subscribers","subscription_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/subscription","commits_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/commits{/sha}","git_commits_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/git/commits{/sha}","comments_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/comments{/number}","issue_comment_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/issues/comments{/number}","contents_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/contents/{+path}","compare_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/merges","archive_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/downloads","issues_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/issues{/number}","pulls_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/pulls{/number}","milestones_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/milestones{/number}","notifications_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/labels{/name}","releases_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/releases{/id}","deployments_url":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/deployments","created_at":"2018-04-06T08:15:21Z","updated_at":"2018-05-31T07:56:55Z","pushed_at":"2018-04-15T14:31:18Z","git_url":"git://github.com/PrekshaNema25/StructuredData_To_Descriptions.git","ssh_url":"git@github.com:PrekshaNema25/StructuredData_To_Descriptions.git","clone_url":"https://github.com/PrekshaNema25/StructuredData_To_Descriptions.git","svn_url":"https://github.com/PrekshaNema25/StructuredData_To_Descriptions","homepage":null,"size":37261,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":2,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/pulls/3"},"html":{"href":"https://github.com/PrekshaNema25/StructuredData_To_Descriptions/pull/3"},"issue":{"href":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/issues/3"},"comments":{"href":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/PrekshaNema25/StructuredData_To_Descriptions/statuses/2e01b9fb6309cad0796b3367930789bc620b85e0"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":5,"additions":10282,"deletions":1742,"changed_files":68}}
{"actor":{"display_login":"mattilyra"}}