{"action":"opened","number":1593,"pull_request":{"url":"https://api.github.com/repos/jasmine/jasmine/pulls/1593","id":209371030,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MzcxMDMw","html_url":"https://github.com/jasmine/jasmine/pull/1593","diff_url":"https://github.com/jasmine/jasmine/pull/1593.diff","patch_url":"https://github.com/jasmine/jasmine/pull/1593.patch","issue_url":"https://api.github.com/repos/jasmine/jasmine/issues/1593","number":1593,"state":"open","locked":false,"title":"[WIP] Fix context cloning proccess","user":{"login":"darthjee","id":3843066,"node_id":"MDQ6VXNlcjM4NDMwNjY=","avatar_url":"https://avatars0.githubusercontent.com/u/3843066?v=4","gravatar_id":"","url":"https://api.github.com/users/darthjee","html_url":"https://github.com/darthjee","followers_url":"https://api.github.com/users/darthjee/followers","following_url":"https://api.github.com/users/darthjee/following{/other_user}","gists_url":"https://api.github.com/users/darthjee/gists{/gist_id}","starred_url":"https://api.github.com/users/darthjee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darthjee/subscriptions","organizations_url":"https://api.github.com/users/darthjee/orgs","repos_url":"https://api.github.com/users/darthjee/repos","events_url":"https://api.github.com/users/darthjee/events{/privacy}","received_events_url":"https://api.github.com/users/darthjee/received_events","type":"User","site_admin":false},"body":"whenever a new context is generated (through the use of `UserContext.fromExisting`, if a property is also an Object, properties may leak between examples)\r\n\r\nThis PR tries to fix this issue\r\n\r\n## Description\r\nThis PR will try to, anytime the context is being created from an existing one, once a property is an object, this will be also duplicated\r\n\r\n### Problems\r\n  an object might be an instance of a simple structure or might be something else with a different constructor which might pose a problem for clonning ... I am still thinking about the best way to solve it\r\n\r\n## Motivation and Context\r\nsometimes the object stored is being modified by specs and this is being shared between specs, when it should not\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [ ] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [ ] I have read the **CONTRIBUTING** document.\r\n- [ ] I have added tests to cover my changes.\r\n- [ ] All new and existing tests passed.\r\n\r\n","created_at":"2018-08-19T17:39:28Z","updated_at":"2018-08-19T17:39:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jasmine/jasmine/pulls/1593/commits","review_comments_url":"https://api.github.com/repos/jasmine/jasmine/pulls/1593/comments","review_comment_url":"https://api.github.com/repos/jasmine/jasmine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jasmine/jasmine/issues/1593/comments","statuses_url":"https://api.github.com/repos/jasmine/jasmine/statuses/637d53a881d9266a99a2aeda0ed5e9849c7fa43f","head":{"label":"darthjee:context-fix","ref":"context-fix","sha":"637d53a881d9266a99a2aeda0ed5e9849c7fa43f","user":{"login":"darthjee","id":3843066,"node_id":"MDQ6VXNlcjM4NDMwNjY=","avatar_url":"https://avatars0.githubusercontent.com/u/3843066?v=4","gravatar_id":"","url":"https://api.github.com/users/darthjee","html_url":"https://github.com/darthjee","followers_url":"https://api.github.com/users/darthjee/followers","following_url":"https://api.github.com/users/darthjee/following{/other_user}","gists_url":"https://api.github.com/users/darthjee/gists{/gist_id}","starred_url":"https://api.github.com/users/darthjee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darthjee/subscriptions","organizations_url":"https://api.github.com/users/darthjee/orgs","repos_url":"https://api.github.com/users/darthjee/repos","events_url":"https://api.github.com/users/darthjee/events{/privacy}","received_events_url":"https://api.github.com/users/darthjee/received_events","type":"User","site_admin":false},"repo":{"id":144577307,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ1NzczMDc=","name":"jasmine","full_name":"darthjee/jasmine","owner":{"login":"darthjee","id":3843066,"node_id":"MDQ6VXNlcjM4NDMwNjY=","avatar_url":"https://avatars0.githubusercontent.com/u/3843066?v=4","gravatar_id":"","url":"https://api.github.com/users/darthjee","html_url":"https://github.com/darthjee","followers_url":"https://api.github.com/users/darthjee/followers","following_url":"https://api.github.com/users/darthjee/following{/other_user}","gists_url":"https://api.github.com/users/darthjee/gists{/gist_id}","starred_url":"https://api.github.com/users/darthjee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darthjee/subscriptions","organizations_url":"https://api.github.com/users/darthjee/orgs","repos_url":"https://api.github.com/users/darthjee/repos","events_url":"https://api.github.com/users/darthjee/events{/privacy}","received_events_url":"https://api.github.com/users/darthjee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/darthjee/jasmine","description":"Simple JavaScript testing framework for browsers and node.js","fork":true,"url":"https://api.github.com/repos/darthjee/jasmine","forks_url":"https://api.github.com/repos/darthjee/jasmine/forks","keys_url":"https://api.github.com/repos/darthjee/jasmine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/darthjee/jasmine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/darthjee/jasmine/teams","hooks_url":"https://api.github.com/repos/darthjee/jasmine/hooks","issue_events_url":"https://api.github.com/repos/darthjee/jasmine/issues/events{/number}","events_url":"https://api.github.com/repos/darthjee/jasmine/events","assignees_url":"https://api.github.com/repos/darthjee/jasmine/assignees{/user}","branches_url":"https://api.github.com/repos/darthjee/jasmine/branches{/branch}","tags_url":"https://api.github.com/repos/darthjee/jasmine/tags","blobs_url":"https://api.github.com/repos/darthjee/jasmine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/darthjee/jasmine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/darthjee/jasmine/git/refs{/sha}","trees_url":"https://api.github.com/repos/darthjee/jasmine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/darthjee/jasmine/statuses/{sha}","languages_url":"https://api.github.com/repos/darthjee/jasmine/languages","stargazers_url":"https://api.github.com/repos/darthjee/jasmine/stargazers","contributors_url":"https://api.github.com/repos/darthjee/jasmine/contributors","subscribers_url":"https://api.github.com/repos/darthjee/jasmine/subscribers","subscription_url":"https://api.github.com/repos/darthjee/jasmine/subscription","commits_url":"https://api.github.com/repos/darthjee/jasmine/commits{/sha}","git_commits_url":"https://api.github.com/repos/darthjee/jasmine/git/commits{/sha}","comments_url":"https://api.github.com/repos/darthjee/jasmine/comments{/number}","issue_comment_url":"https://api.github.com/repos/darthjee/jasmine/issues/comments{/number}","contents_url":"https://api.github.com/repos/darthjee/jasmine/contents/{+path}","compare_url":"https://api.github.com/repos/darthjee/jasmine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/darthjee/jasmine/merges","archive_url":"https://api.github.com/repos/darthjee/jasmine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/darthjee/jasmine/downloads","issues_url":"https://api.github.com/repos/darthjee/jasmine/issues{/number}","pulls_url":"https://api.github.com/repos/darthjee/jasmine/pulls{/number}","milestones_url":"https://api.github.com/repos/darthjee/jasmine/milestones{/number}","notifications_url":"https://api.github.com/repos/darthjee/jasmine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/darthjee/jasmine/labels{/name}","releases_url":"https://api.github.com/repos/darthjee/jasmine/releases{/id}","deployments_url":"https://api.github.com/repos/darthjee/jasmine/deployments","created_at":"2018-08-13T12:33:43Z","updated_at":"2018-08-13T12:33:47Z","pushed_at":"2018-08-19T17:28:26Z","git_url":"git://github.com/darthjee/jasmine.git","ssh_url":"git@github.com:darthjee/jasmine.git","clone_url":"https://github.com/darthjee/jasmine.git","svn_url":"https://github.com/darthjee/jasmine","homepage":"http://jasmine.github.io/","size":8442,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jasmine:master","ref":"master","sha":"12f56fdb7de6680a1d4c6fb0a53ca9bc42b083fc","user":{"login":"jasmine","id":4624349,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MjQzNDk=","avatar_url":"https://avatars0.githubusercontent.com/u/4624349?v=4","gravatar_id":"","url":"https://api.github.com/users/jasmine","html_url":"https://github.com/jasmine","followers_url":"https://api.github.com/users/jasmine/followers","following_url":"https://api.github.com/users/jasmine/following{/other_user}","gists_url":"https://api.github.com/users/jasmine/gists{/gist_id}","starred_url":"https://api.github.com/users/jasmine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasmine/subscriptions","organizations_url":"https://api.github.com/users/jasmine/orgs","repos_url":"https://api.github.com/users/jasmine/repos","events_url":"https://api.github.com/users/jasmine/events{/privacy}","received_events_url":"https://api.github.com/users/jasmine/received_events","type":"Organization","site_admin":false},"repo":{"id":84009,"node_id":"MDEwOlJlcG9zaXRvcnk4NDAwOQ==","name":"jasmine","full_name":"jasmine/jasmine","owner":{"login":"jasmine","id":4624349,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MjQzNDk=","avatar_url":"https://avatars0.githubusercontent.com/u/4624349?v=4","gravatar_id":"","url":"https://api.github.com/users/jasmine","html_url":"https://github.com/jasmine","followers_url":"https://api.github.com/users/jasmine/followers","following_url":"https://api.github.com/users/jasmine/following{/other_user}","gists_url":"https://api.github.com/users/jasmine/gists{/gist_id}","starred_url":"https://api.github.com/users/jasmine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasmine/subscriptions","organizations_url":"https://api.github.com/users/jasmine/orgs","repos_url":"https://api.github.com/users/jasmine/repos","events_url":"https://api.github.com/users/jasmine/events{/privacy}","received_events_url":"https://api.github.com/users/jasmine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jasmine/jasmine","description":"Simple JavaScript testing framework for browsers and node.js","fork":false,"url":"https://api.github.com/repos/jasmine/jasmine","forks_url":"https://api.github.com/repos/jasmine/jasmine/forks","keys_url":"https://api.github.com/repos/jasmine/jasmine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jasmine/jasmine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jasmine/jasmine/teams","hooks_url":"https://api.github.com/repos/jasmine/jasmine/hooks","issue_events_url":"https://api.github.com/repos/jasmine/jasmine/issues/events{/number}","events_url":"https://api.github.com/repos/jasmine/jasmine/events","assignees_url":"https://api.github.com/repos/jasmine/jasmine/assignees{/user}","branches_url":"https://api.github.com/repos/jasmine/jasmine/branches{/branch}","tags_url":"https://api.github.com/repos/jasmine/jasmine/tags","blobs_url":"https://api.github.com/repos/jasmine/jasmine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jasmine/jasmine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jasmine/jasmine/git/refs{/sha}","trees_url":"https://api.github.com/repos/jasmine/jasmine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jasmine/jasmine/statuses/{sha}","languages_url":"https://api.github.com/repos/jasmine/jasmine/languages","stargazers_url":"https://api.github.com/repos/jasmine/jasmine/stargazers","contributors_url":"https://api.github.com/repos/jasmine/jasmine/contributors","subscribers_url":"https://api.github.com/repos/jasmine/jasmine/subscribers","subscription_url":"https://api.github.com/repos/jasmine/jasmine/subscription","commits_url":"https://api.github.com/repos/jasmine/jasmine/commits{/sha}","git_commits_url":"https://api.github.com/repos/jasmine/jasmine/git/commits{/sha}","comments_url":"https://api.github.com/repos/jasmine/jasmine/comments{/number}","issue_comment_url":"https://api.github.com/repos/jasmine/jasmine/issues/comments{/number}","contents_url":"https://api.github.com/repos/jasmine/jasmine/contents/{+path}","compare_url":"https://api.github.com/repos/jasmine/jasmine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jasmine/jasmine/merges","archive_url":"https://api.github.com/repos/jasmine/jasmine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jasmine/jasmine/downloads","issues_url":"https://api.github.com/repos/jasmine/jasmine/issues{/number}","pulls_url":"https://api.github.com/repos/jasmine/jasmine/pulls{/number}","milestones_url":"https://api.github.com/repos/jasmine/jasmine/milestones{/number}","notifications_url":"https://api.github.com/repos/jasmine/jasmine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jasmine/jasmine/labels{/name}","releases_url":"https://api.github.com/repos/jasmine/jasmine/releases{/id}","deployments_url":"https://api.github.com/repos/jasmine/jasmine/deployments","created_at":"2008-12-02T23:46:37Z","updated_at":"2018-08-19T17:13:30Z","pushed_at":"2018-08-15T00:26:22Z","git_url":"git://github.com/jasmine/jasmine.git","ssh_url":"git@github.com:jasmine/jasmine.git","clone_url":"https://github.com/jasmine/jasmine.git","svn_url":"https://github.com/jasmine/jasmine","homepage":"http://jasmine.github.io/","size":8502,"stargazers_count":13773,"watchers_count":13773,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2047,"mirror_url":null,"archived":false,"open_issues_count":37,"license":null,"forks":2047,"open_issues":37,"watchers":13773,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jasmine/jasmine/pulls/1593"},"html":{"href":"https://github.com/jasmine/jasmine/pull/1593"},"issue":{"href":"https://api.github.com/repos/jasmine/jasmine/issues/1593"},"comments":{"href":"https://api.github.com/repos/jasmine/jasmine/issues/1593/comments"},"review_comments":{"href":"https://api.github.com/repos/jasmine/jasmine/pulls/1593/comments"},"review_comment":{"href":"https://api.github.com/repos/jasmine/jasmine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jasmine/jasmine/pulls/1593/commits"},"statuses":{"href":"https://api.github.com/repos/jasmine/jasmine/statuses/637d53a881d9266a99a2aeda0ed5e9849c7fa43f"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":81,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"darthjee"}}