{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/tectonic-config/pulls/comments/189208898","pull_request_review_id":121344354,"id":189208898,"diff_hunk":"@@ -20,10 +20,12 @@ const (\n type ControllerConfig struct {\n \tmetav1.TypeMeta     `json:\",inline\"`\n \tClusterDNSIP        string `json:\"clusterDNSIP\"`\n-\tCloudProvider       string `json:\"cloudProvider\"`\n \tCloudProviderConfig string `json:\"cloudProviderConfig\"`\n \tClusterName         string `json:\"clusterName\"`\n \n+\t// The \"platform\", e.g. \"aws\" or \"libvirt\"\n+\tInstallerPlatform string `json:\"installerPlatform\"`","path":"config/tectonic-node-controller/config.go","position":9,"original_position":9,"commit_id":"4db30fbe6591a0ad7b4fe4fcd838c0d2f31d3748","original_commit_id":"4db30fbe6591a0ad7b4fe4fcd838c0d2f31d3748","user":{"login":"squeed","id":551378,"avatar_url":"https://avatars2.githubusercontent.com/u/551378?v=4","gravatar_id":"","url":"https://api.github.com/users/squeed","html_url":"https://github.com/squeed","followers_url":"https://api.github.com/users/squeed/followers","following_url":"https://api.github.com/users/squeed/following{/other_user}","gists_url":"https://api.github.com/users/squeed/gists{/gist_id}","starred_url":"https://api.github.com/users/squeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squeed/subscriptions","organizations_url":"https://api.github.com/users/squeed/orgs","repos_url":"https://api.github.com/users/squeed/repos","events_url":"https://api.github.com/users/squeed/events{/privacy}","received_events_url":"https://api.github.com/users/squeed/received_events","type":"User","site_admin":false},"body":"*shrug* Just duplicating what the other objects (utility, ingress) use. Diego chose it, you'll have to ask him :-)","created_at":"2018-05-18T09:14:29Z","updated_at":"2018-05-18T09:14:29Z","html_url":"https://github.com/coreos/tectonic-config/pull/18#discussion_r189208898","pull_request_url":"https://api.github.com/repos/coreos/tectonic-config/pulls/18","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/coreos/tectonic-config/pulls/comments/189208898"},"html":{"href":"https://github.com/coreos/tectonic-config/pull/18#discussion_r189208898"},"pull_request":{"href":"https://api.github.com/repos/coreos/tectonic-config/pulls/18"}},"in_reply_to_id":189132913},"pull_request":{"url":"https://api.github.com/repos/coreos/tectonic-config/pulls/18","id":188118131,"html_url":"https://github.com/coreos/tectonic-config/pull/18","diff_url":"https://github.com/coreos/tectonic-config/pull/18.diff","patch_url":"https://github.com/coreos/tectonic-config/pull/18.patch","issue_url":"https://api.github.com/repos/coreos/tectonic-config/issues/18","number":18,"state":"open","locked":false,"title":"tectonic-node-controller: add platform","user":{"login":"squeed","id":551378,"avatar_url":"https://avatars2.githubusercontent.com/u/551378?v=4","gravatar_id":"","url":"https://api.github.com/users/squeed","html_url":"https://github.com/squeed","followers_url":"https://api.github.com/users/squeed/followers","following_url":"https://api.github.com/users/squeed/following{/other_user}","gists_url":"https://api.github.com/users/squeed/gists{/gist_id}","starred_url":"https://api.github.com/users/squeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squeed/subscriptions","organizations_url":"https://api.github.com/users/squeed/orgs","repos_url":"https://api.github.com/users/squeed/repos","events_url":"https://api.github.com/users/squeed/events{/privacy}","received_events_url":"https://api.github.com/users/squeed/received_events","type":"User","site_admin":false},"body":"Platform is distinct from cloud provider, so we need to be able to branch on both of these.","created_at":"2018-05-15T12:53:45Z","updated_at":"2018-05-18T09:14:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1476e49c364d19c943e4b07bad63979db69a10e3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/coreos/tectonic-config/pulls/18/commits","review_comments_url":"https://api.github.com/repos/coreos/tectonic-config/pulls/18/comments","review_comment_url":"https://api.github.com/repos/coreos/tectonic-config/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/tectonic-config/issues/18/comments","statuses_url":"https://api.github.com/repos/coreos/tectonic-config/statuses/4db30fbe6591a0ad7b4fe4fcd838c0d2f31d3748","head":{"label":"squeed:tnc-platform","ref":"tnc-platform","sha":"4db30fbe6591a0ad7b4fe4fcd838c0d2f31d3748","user":{"login":"squeed","id":551378,"avatar_url":"https://avatars2.githubusercontent.com/u/551378?v=4","gravatar_id":"","url":"https://api.github.com/users/squeed","html_url":"https://github.com/squeed","followers_url":"https://api.github.com/users/squeed/followers","following_url":"https://api.github.com/users/squeed/following{/other_user}","gists_url":"https://api.github.com/users/squeed/gists{/gist_id}","starred_url":"https://api.github.com/users/squeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squeed/subscriptions","organizations_url":"https://api.github.com/users/squeed/orgs","repos_url":"https://api.github.com/users/squeed/repos","events_url":"https://api.github.com/users/squeed/events{/privacy}","received_events_url":"https://api.github.com/users/squeed/received_events","type":"User","site_admin":false},"repo":{"id":119409548,"name":"tectonic-config","full_name":"squeed/tectonic-config","owner":{"login":"squeed","id":551378,"avatar_url":"https://avatars2.githubusercontent.com/u/551378?v=4","gravatar_id":"","url":"https://api.github.com/users/squeed","html_url":"https://github.com/squeed","followers_url":"https://api.github.com/users/squeed/followers","following_url":"https://api.github.com/users/squeed/following{/other_user}","gists_url":"https://api.github.com/users/squeed/gists{/gist_id}","starred_url":"https://api.github.com/users/squeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squeed/subscriptions","organizations_url":"https://api.github.com/users/squeed/orgs","repos_url":"https://api.github.com/users/squeed/repos","events_url":"https://api.github.com/users/squeed/events{/privacy}","received_events_url":"https://api.github.com/users/squeed/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/squeed/tectonic-config","description":"Shared configuration definitions and utilities used by the Tectonic Installer and Operators","fork":true,"url":"https://api.github.com/repos/squeed/tectonic-config","forks_url":"https://api.github.com/repos/squeed/tectonic-config/forks","keys_url":"https://api.github.com/repos/squeed/tectonic-config/keys{/key_id}","collaborators_url":"https://api.github.com/repos/squeed/tectonic-config/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/squeed/tectonic-config/teams","hooks_url":"https://api.github.com/repos/squeed/tectonic-config/hooks","issue_events_url":"https://api.github.com/repos/squeed/tectonic-config/issues/events{/number}","events_url":"https://api.github.com/repos/squeed/tectonic-config/events","assignees_url":"https://api.github.com/repos/squeed/tectonic-config/assignees{/user}","branches_url":"https://api.github.com/repos/squeed/tectonic-config/branches{/branch}","tags_url":"https://api.github.com/repos/squeed/tectonic-config/tags","blobs_url":"https://api.github.com/repos/squeed/tectonic-config/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/squeed/tectonic-config/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/squeed/tectonic-config/git/refs{/sha}","trees_url":"https://api.github.com/repos/squeed/tectonic-config/git/trees{/sha}","statuses_url":"https://api.github.com/repos/squeed/tectonic-config/statuses/{sha}","languages_url":"https://api.github.com/repos/squeed/tectonic-config/languages","stargazers_url":"https://api.github.com/repos/squeed/tectonic-config/stargazers","contributors_url":"https://api.github.com/repos/squeed/tectonic-config/contributors","subscribers_url":"https://api.github.com/repos/squeed/tectonic-config/subscribers","subscription_url":"https://api.github.com/repos/squeed/tectonic-config/subscription","commits_url":"https://api.github.com/repos/squeed/tectonic-config/commits{/sha}","git_commits_url":"https://api.github.com/repos/squeed/tectonic-config/git/commits{/sha}","comments_url":"https://api.github.com/repos/squeed/tectonic-config/comments{/number}","issue_comment_url":"https://api.github.com/repos/squeed/tectonic-config/issues/comments{/number}","contents_url":"https://api.github.com/repos/squeed/tectonic-config/contents/{+path}","compare_url":"https://api.github.com/repos/squeed/tectonic-config/compare/{base}...{head}","merges_url":"https://api.github.com/repos/squeed/tectonic-config/merges","archive_url":"https://api.github.com/repos/squeed/tectonic-config/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/squeed/tectonic-config/downloads","issues_url":"https://api.github.com/repos/squeed/tectonic-config/issues{/number}","pulls_url":"https://api.github.com/repos/squeed/tectonic-config/pulls{/number}","milestones_url":"https://api.github.com/repos/squeed/tectonic-config/milestones{/number}","notifications_url":"https://api.github.com/repos/squeed/tectonic-config/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/squeed/tectonic-config/labels{/name}","releases_url":"https://api.github.com/repos/squeed/tectonic-config/releases{/id}","deployments_url":"https://api.github.com/repos/squeed/tectonic-config/deployments","created_at":"2018-01-29T16:34:19Z","updated_at":"2018-01-29T16:34:20Z","pushed_at":"2018-05-17T09:29:51Z","git_url":"git://github.com/squeed/tectonic-config.git","ssh_url":"git@github.com:squeed/tectonic-config.git","clone_url":"https://github.com/squeed/tectonic-config.git","svn_url":"https://github.com/squeed/tectonic-config","homepage":null,"size":31,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"22c2fde25b6bd804166bb9dea5e62c16ef2e4900","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars3.githubusercontent.com/u/3730757?v=4","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":117676025,"name":"tectonic-config","full_name":"coreos/tectonic-config","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars3.githubusercontent.com/u/3730757?v=4","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/tectonic-config","description":"Shared configuration definitions and utilities used by the Tectonic Installer and Operators","fork":false,"url":"https://api.github.com/repos/coreos/tectonic-config","forks_url":"https://api.github.com/repos/coreos/tectonic-config/forks","keys_url":"https://api.github.com/repos/coreos/tectonic-config/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/tectonic-config/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/tectonic-config/teams","hooks_url":"https://api.github.com/repos/coreos/tectonic-config/hooks","issue_events_url":"https://api.github.com/repos/coreos/tectonic-config/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/tectonic-config/events","assignees_url":"https://api.github.com/repos/coreos/tectonic-config/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/tectonic-config/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/tectonic-config/tags","blobs_url":"https://api.github.com/repos/coreos/tectonic-config/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/tectonic-config/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/tectonic-config/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/tectonic-config/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/tectonic-config/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/tectonic-config/languages","stargazers_url":"https://api.github.com/repos/coreos/tectonic-config/stargazers","contributors_url":"https://api.github.com/repos/coreos/tectonic-config/contributors","subscribers_url":"https://api.github.com/repos/coreos/tectonic-config/subscribers","subscription_url":"https://api.github.com/repos/coreos/tectonic-config/subscription","commits_url":"https://api.github.com/repos/coreos/tectonic-config/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/tectonic-config/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/tectonic-config/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/tectonic-config/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/tectonic-config/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/tectonic-config/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/tectonic-config/merges","archive_url":"https://api.github.com/repos/coreos/tectonic-config/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/tectonic-config/downloads","issues_url":"https://api.github.com/repos/coreos/tectonic-config/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/tectonic-config/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/tectonic-config/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/tectonic-config/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/tectonic-config/labels{/name}","releases_url":"https://api.github.com/repos/coreos/tectonic-config/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/tectonic-config/deployments","created_at":"2018-01-16T11:38:30Z","updated_at":"2018-05-17T21:48:31Z","pushed_at":"2018-05-17T09:29:52Z","git_url":"git://github.com/coreos/tectonic-config.git","ssh_url":"git@github.com:coreos/tectonic-config.git","clone_url":"https://github.com/coreos/tectonic-config.git","svn_url":"https://github.com/coreos/tectonic-config","homepage":null,"size":34,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":5,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/tectonic-config/pulls/18"},"html":{"href":"https://github.com/coreos/tectonic-config/pull/18"},"issue":{"href":"https://api.github.com/repos/coreos/tectonic-config/issues/18"},"comments":{"href":"https://api.github.com/repos/coreos/tectonic-config/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/tectonic-config/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/tectonic-config/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/tectonic-config/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/tectonic-config/statuses/4db30fbe6591a0ad7b4fe4fcd838c0d2f31d3748"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"squeed"}}