{"action":"created","issue":{"url":"https://api.github.com/repos/web3j/web3j/issues/584","repository_url":"https://api.github.com/repos/web3j/web3j","labels_url":"https://api.github.com/repos/web3j/web3j/issues/584/labels{/name}","comments_url":"https://api.github.com/repos/web3j/web3j/issues/584/comments","events_url":"https://api.github.com/repos/web3j/web3j/issues/584/events","html_url":"https://github.com/web3j/web3j/pull/584","id":330582114,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNTU1MDE3","number":584,"title":"Trustless tx hash computation","user":{"login":"yuriymyronovych","id":9765301,"node_id":"MDQ6VXNlcjk3NjUzMDE=","avatar_url":"https://avatars0.githubusercontent.com/u/9765301?v=4","gravatar_id":"","url":"https://api.github.com/users/yuriymyronovych","html_url":"https://github.com/yuriymyronovych","followers_url":"https://api.github.com/users/yuriymyronovych/followers","following_url":"https://api.github.com/users/yuriymyronovych/following{/other_user}","gists_url":"https://api.github.com/users/yuriymyronovych/gists{/gist_id}","starred_url":"https://api.github.com/users/yuriymyronovych/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuriymyronovych/subscriptions","organizations_url":"https://api.github.com/users/yuriymyronovych/orgs","repos_url":"https://api.github.com/users/yuriymyronovych/repos","events_url":"https://api.github.com/users/yuriymyronovych/events{/privacy}","received_events_url":"https://api.github.com/users/yuriymyronovych/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-06-08T09:18:47Z","updated_at":"2018-09-20T09:40:16Z","closed_at":"2018-07-25T09:35:55Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/web3j/web3j/pulls/584","html_url":"https://github.com/web3j/web3j/pull/584","diff_url":"https://github.com/web3j/web3j/pull/584.diff","patch_url":"https://github.com/web3j/web3j/pull/584.patch"},"body":"Addressing a philosophical issue rather than technical here.\r\n\r\nProblem: when we use infura or similar service to execute our transactions we rely on txHash returned and trust third party to give us correct value. Ideally we would want to follow blockchain concepts of 'client in control' and 'trustless execution'. Therefore, proposed change is to calculate txHash locally before submitting it to node and verify that returned hash matches the one we expect.\r\n\r\nNote: at Argent we did have rare issues with infura not returning txHash or returning empty results. I think this change would be highly desirable  by anyone using web3j in production especially for fintech products."},"comment":{"url":"https://api.github.com/repos/web3j/web3j/issues/comments/423114990","html_url":"https://github.com/web3j/web3j/pull/584#issuecomment-423114990","issue_url":"https://api.github.com/repos/web3j/web3j/issues/584","id":423114990,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMzExNDk5MA==","user":{"login":"yuriymyronovych","id":9765301,"node_id":"MDQ6VXNlcjk3NjUzMDE=","avatar_url":"https://avatars0.githubusercontent.com/u/9765301?v=4","gravatar_id":"","url":"https://api.github.com/users/yuriymyronovych","html_url":"https://github.com/yuriymyronovych","followers_url":"https://api.github.com/users/yuriymyronovych/followers","following_url":"https://api.github.com/users/yuriymyronovych/following{/other_user}","gists_url":"https://api.github.com/users/yuriymyronovych/gists{/gist_id}","starred_url":"https://api.github.com/users/yuriymyronovych/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuriymyronovych/subscriptions","organizations_url":"https://api.github.com/users/yuriymyronovych/orgs","repos_url":"https://api.github.com/users/yuriymyronovych/repos","events_url":"https://api.github.com/users/yuriymyronovych/events{/privacy}","received_events_url":"https://api.github.com/users/yuriymyronovych/received_events","type":"User","site_admin":false},"created_at":"2018-09-20T09:40:16Z","updated_at":"2018-09-20T09:40:16Z","author_association":"NONE","body":"@amitOodles It should always be the same."}}
{"actor":{"display_login":"yuriymyronovych"}}