{"action":"created","comment":{"url":"https://api.github.com/repos/JabRef/jabref/pulls/comments/195389284","pull_request_review_id":128747788,"id":195389284,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTM4OTI4NA==","diff_hunk":"@@ -276,11 +277,13 @@ private void applyChanges() {\n                 if (biblatexMode) {\n                     Set<String> oldPrimaryOptionalFieldsLists = oldType.get().getPrimaryOptionalFields();\n                     Set<String> oldSecondaryOptionalFieldsList = oldType.get().getSecondaryOptionalFields();\n-                    if (oldRequiredFieldsList.equals(requiredFieldsList) && oldPrimaryOptionalFieldsLists.equals(optionalFieldsList) &&\n-                            oldSecondaryOptionalFieldsList.equals(secondaryOptionalFieldsLists)) {\n+                    if (Arrays.equals(oldRequiredFieldsList.toArray(), requiredFieldsList.toArray())","path":"src/main/java/org/jabref/gui/customentrytypes/EntryTypeCustomizationDialog.java","position":37,"original_position":37,"commit_id":"2f18ad5645c660e5ab7bdd95db0be2ed137c63a2","original_commit_id":"2f18ad5645c660e5ab7bdd95db0be2ed137c63a2","user":{"login":"stefan-kolb","id":2141507,"node_id":"MDQ6VXNlcjIxNDE1MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/2141507?v=4","gravatar_id":"","url":"https://api.github.com/users/stefan-kolb","html_url":"https://github.com/stefan-kolb","followers_url":"https://api.github.com/users/stefan-kolb/followers","following_url":"https://api.github.com/users/stefan-kolb/following{/other_user}","gists_url":"https://api.github.com/users/stefan-kolb/gists{/gist_id}","starred_url":"https://api.github.com/users/stefan-kolb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefan-kolb/subscriptions","organizations_url":"https://api.github.com/users/stefan-kolb/orgs","repos_url":"https://api.github.com/users/stefan-kolb/repos","events_url":"https://api.github.com/users/stefan-kolb/events{/privacy}","received_events_url":"https://api.github.com/users/stefan-kolb/received_events","type":"User","site_admin":false},"body":"Is the reason for the bug that array.equals != list.equals?","created_at":"2018-06-14T11:36:09Z","updated_at":"2018-06-14T11:36:09Z","html_url":"https://github.com/JabRef/jabref/pull/4127#discussion_r195389284","pull_request_url":"https://api.github.com/repos/JabRef/jabref/pulls/4127","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/comments/195389284"},"html":{"href":"https://github.com/JabRef/jabref/pull/4127#discussion_r195389284"},"pull_request":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/4127"}}},"pull_request":{"url":"https://api.github.com/repos/JabRef/jabref/pulls/4127","id":194733184,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NzMzMTg0","html_url":"https://github.com/JabRef/jabref/pull/4127","diff_url":"https://github.com/JabRef/jabref/pull/4127.diff","patch_url":"https://github.com/JabRef/jabref/pull/4127.patch","issue_url":"https://api.github.com/repos/JabRef/jabref/issues/4127","number":4127,"state":"open","locked":false,"title":" Fix #4033: order of fields in customized entry types is saved correctly ","user":{"login":"tobiasdiez","id":5037600,"node_id":"MDQ6VXNlcjUwMzc2MDA=","avatar_url":"https://avatars3.githubusercontent.com/u/5037600?v=4","gravatar_id":"","url":"https://api.github.com/users/tobiasdiez","html_url":"https://github.com/tobiasdiez","followers_url":"https://api.github.com/users/tobiasdiez/followers","following_url":"https://api.github.com/users/tobiasdiez/following{/other_user}","gists_url":"https://api.github.com/users/tobiasdiez/gists{/gist_id}","starred_url":"https://api.github.com/users/tobiasdiez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobiasdiez/subscriptions","organizations_url":"https://api.github.com/users/tobiasdiez/orgs","repos_url":"https://api.github.com/users/tobiasdiez/repos","events_url":"https://api.github.com/users/tobiasdiez/events{/privacy}","received_events_url":"https://api.github.com/users/tobiasdiez/received_events","type":"User","site_admin":false},"body":"<!-- describe the changes you have made here: what, why, ... \r\n     Link issues by using the following pattern: [#333](https://github.com/JabRef/jabref/issues/333) or [koppor#49](https://github.com/koppor/jabref/issues/47).\r\n     The title of the PR must not reference an issue, because GitHub does not support autolinking there. -->\r\n\r\n\r\n----\r\n\r\n- [ ] Change in CHANGELOG.md described\r\n- [ ] Tests created for changes\r\n- [ ] Manually tested changed features in running JabRef\r\n- [ ] Screenshots added in PR description (for bigger UI changes)\r\n- [ ] Ensured that [the git commit message is a good one](https://github.com/joelparkerhenderson/git_commit_message)\r\n- [ ] Check documentation status (Issue created for outdated help page at [help.jabref.org](https://github.com/JabRef/help.jabref.org/issues)?)\r\n","created_at":"2018-06-13T22:30:03Z","updated_at":"2018-06-14T11:36:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1bccee66c628d692af41f66f94eb6176fad5ad6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":297433180,"node_id":"MDU6TGFiZWwyOTc0MzMxODA=","url":"https://api.github.com/repos/JabRef/jabref/labels/ready-for-review","name":"ready-for-review","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/JabRef/jabref/pulls/4127/commits","review_comments_url":"https://api.github.com/repos/JabRef/jabref/pulls/4127/comments","review_comment_url":"https://api.github.com/repos/JabRef/jabref/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JabRef/jabref/issues/4127/comments","statuses_url":"https://api.github.com/repos/JabRef/jabref/statuses/2f18ad5645c660e5ab7bdd95db0be2ed137c63a2","head":{"label":"JabRef:fix4033","ref":"fix4033","sha":"2f18ad5645c660e5ab7bdd95db0be2ed137c63a2","user":{"login":"JabRef","id":3914421,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTQ0MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/3914421?v=4","gravatar_id":"","url":"https://api.github.com/users/JabRef","html_url":"https://github.com/JabRef","followers_url":"https://api.github.com/users/JabRef/followers","following_url":"https://api.github.com/users/JabRef/following{/other_user}","gists_url":"https://api.github.com/users/JabRef/gists{/gist_id}","starred_url":"https://api.github.com/users/JabRef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JabRef/subscriptions","organizations_url":"https://api.github.com/users/JabRef/orgs","repos_url":"https://api.github.com/users/JabRef/repos","events_url":"https://api.github.com/users/JabRef/events{/privacy}","received_events_url":"https://api.github.com/users/JabRef/received_events","type":"Organization","site_admin":false},"repo":{"id":17634071,"node_id":"MDEwOlJlcG9zaXRvcnkxNzYzNDA3MQ==","name":"jabref","full_name":"JabRef/jabref","owner":{"login":"JabRef","id":3914421,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTQ0MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/3914421?v=4","gravatar_id":"","url":"https://api.github.com/users/JabRef","html_url":"https://github.com/JabRef","followers_url":"https://api.github.com/users/JabRef/followers","following_url":"https://api.github.com/users/JabRef/following{/other_user}","gists_url":"https://api.github.com/users/JabRef/gists{/gist_id}","starred_url":"https://api.github.com/users/JabRef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JabRef/subscriptions","organizations_url":"https://api.github.com/users/JabRef/orgs","repos_url":"https://api.github.com/users/JabRef/repos","events_url":"https://api.github.com/users/JabRef/events{/privacy}","received_events_url":"https://api.github.com/users/JabRef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JabRef/jabref","description":"Graphical Java application for managing BibTeX and biblatex (.bib) databases","fork":false,"url":"https://api.github.com/repos/JabRef/jabref","forks_url":"https://api.github.com/repos/JabRef/jabref/forks","keys_url":"https://api.github.com/repos/JabRef/jabref/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JabRef/jabref/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JabRef/jabref/teams","hooks_url":"https://api.github.com/repos/JabRef/jabref/hooks","issue_events_url":"https://api.github.com/repos/JabRef/jabref/issues/events{/number}","events_url":"https://api.github.com/repos/JabRef/jabref/events","assignees_url":"https://api.github.com/repos/JabRef/jabref/assignees{/user}","branches_url":"https://api.github.com/repos/JabRef/jabref/branches{/branch}","tags_url":"https://api.github.com/repos/JabRef/jabref/tags","blobs_url":"https://api.github.com/repos/JabRef/jabref/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JabRef/jabref/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JabRef/jabref/git/refs{/sha}","trees_url":"https://api.github.com/repos/JabRef/jabref/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JabRef/jabref/statuses/{sha}","languages_url":"https://api.github.com/repos/JabRef/jabref/languages","stargazers_url":"https://api.github.com/repos/JabRef/jabref/stargazers","contributors_url":"https://api.github.com/repos/JabRef/jabref/contributors","subscribers_url":"https://api.github.com/repos/JabRef/jabref/subscribers","subscription_url":"https://api.github.com/repos/JabRef/jabref/subscription","commits_url":"https://api.github.com/repos/JabRef/jabref/commits{/sha}","git_commits_url":"https://api.github.com/repos/JabRef/jabref/git/commits{/sha}","comments_url":"https://api.github.com/repos/JabRef/jabref/comments{/number}","issue_comment_url":"https://api.github.com/repos/JabRef/jabref/issues/comments{/number}","contents_url":"https://api.github.com/repos/JabRef/jabref/contents/{+path}","compare_url":"https://api.github.com/repos/JabRef/jabref/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JabRef/jabref/merges","archive_url":"https://api.github.com/repos/JabRef/jabref/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JabRef/jabref/downloads","issues_url":"https://api.github.com/repos/JabRef/jabref/issues{/number}","pulls_url":"https://api.github.com/repos/JabRef/jabref/pulls{/number}","milestones_url":"https://api.github.com/repos/JabRef/jabref/milestones{/number}","notifications_url":"https://api.github.com/repos/JabRef/jabref/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JabRef/jabref/labels{/name}","releases_url":"https://api.github.com/repos/JabRef/jabref/releases{/id}","deployments_url":"https://api.github.com/repos/JabRef/jabref/deployments","created_at":"2014-03-11T14:48:42Z","updated_at":"2018-06-14T10:16:58Z","pushed_at":"2018-06-14T10:16:52Z","git_url":"git://github.com/JabRef/jabref.git","ssh_url":"git@github.com:JabRef/jabref.git","clone_url":"https://github.com/JabRef/jabref.git","svn_url":"https://github.com/JabRef/jabref","homepage":"https://www.jabref.org","size":105542,"stargazers_count":956,"watchers_count":956,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":665,"mirror_url":null,"archived":false,"open_issues_count":185,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":665,"open_issues":185,"watchers":956,"default_branch":"master"}},"base":{"label":"JabRef:master","ref":"master","sha":"09ceea00ae53cc9c362fffbd6b917ab61c7cc538","user":{"login":"JabRef","id":3914421,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTQ0MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/3914421?v=4","gravatar_id":"","url":"https://api.github.com/users/JabRef","html_url":"https://github.com/JabRef","followers_url":"https://api.github.com/users/JabRef/followers","following_url":"https://api.github.com/users/JabRef/following{/other_user}","gists_url":"https://api.github.com/users/JabRef/gists{/gist_id}","starred_url":"https://api.github.com/users/JabRef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JabRef/subscriptions","organizations_url":"https://api.github.com/users/JabRef/orgs","repos_url":"https://api.github.com/users/JabRef/repos","events_url":"https://api.github.com/users/JabRef/events{/privacy}","received_events_url":"https://api.github.com/users/JabRef/received_events","type":"Organization","site_admin":false},"repo":{"id":17634071,"node_id":"MDEwOlJlcG9zaXRvcnkxNzYzNDA3MQ==","name":"jabref","full_name":"JabRef/jabref","owner":{"login":"JabRef","id":3914421,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTQ0MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/3914421?v=4","gravatar_id":"","url":"https://api.github.com/users/JabRef","html_url":"https://github.com/JabRef","followers_url":"https://api.github.com/users/JabRef/followers","following_url":"https://api.github.com/users/JabRef/following{/other_user}","gists_url":"https://api.github.com/users/JabRef/gists{/gist_id}","starred_url":"https://api.github.com/users/JabRef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JabRef/subscriptions","organizations_url":"https://api.github.com/users/JabRef/orgs","repos_url":"https://api.github.com/users/JabRef/repos","events_url":"https://api.github.com/users/JabRef/events{/privacy}","received_events_url":"https://api.github.com/users/JabRef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JabRef/jabref","description":"Graphical Java application for managing BibTeX and biblatex (.bib) databases","fork":false,"url":"https://api.github.com/repos/JabRef/jabref","forks_url":"https://api.github.com/repos/JabRef/jabref/forks","keys_url":"https://api.github.com/repos/JabRef/jabref/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JabRef/jabref/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JabRef/jabref/teams","hooks_url":"https://api.github.com/repos/JabRef/jabref/hooks","issue_events_url":"https://api.github.com/repos/JabRef/jabref/issues/events{/number}","events_url":"https://api.github.com/repos/JabRef/jabref/events","assignees_url":"https://api.github.com/repos/JabRef/jabref/assignees{/user}","branches_url":"https://api.github.com/repos/JabRef/jabref/branches{/branch}","tags_url":"https://api.github.com/repos/JabRef/jabref/tags","blobs_url":"https://api.github.com/repos/JabRef/jabref/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JabRef/jabref/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JabRef/jabref/git/refs{/sha}","trees_url":"https://api.github.com/repos/JabRef/jabref/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JabRef/jabref/statuses/{sha}","languages_url":"https://api.github.com/repos/JabRef/jabref/languages","stargazers_url":"https://api.github.com/repos/JabRef/jabref/stargazers","contributors_url":"https://api.github.com/repos/JabRef/jabref/contributors","subscribers_url":"https://api.github.com/repos/JabRef/jabref/subscribers","subscription_url":"https://api.github.com/repos/JabRef/jabref/subscription","commits_url":"https://api.github.com/repos/JabRef/jabref/commits{/sha}","git_commits_url":"https://api.github.com/repos/JabRef/jabref/git/commits{/sha}","comments_url":"https://api.github.com/repos/JabRef/jabref/comments{/number}","issue_comment_url":"https://api.github.com/repos/JabRef/jabref/issues/comments{/number}","contents_url":"https://api.github.com/repos/JabRef/jabref/contents/{+path}","compare_url":"https://api.github.com/repos/JabRef/jabref/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JabRef/jabref/merges","archive_url":"https://api.github.com/repos/JabRef/jabref/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JabRef/jabref/downloads","issues_url":"https://api.github.com/repos/JabRef/jabref/issues{/number}","pulls_url":"https://api.github.com/repos/JabRef/jabref/pulls{/number}","milestones_url":"https://api.github.com/repos/JabRef/jabref/milestones{/number}","notifications_url":"https://api.github.com/repos/JabRef/jabref/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JabRef/jabref/labels{/name}","releases_url":"https://api.github.com/repos/JabRef/jabref/releases{/id}","deployments_url":"https://api.github.com/repos/JabRef/jabref/deployments","created_at":"2014-03-11T14:48:42Z","updated_at":"2018-06-14T10:16:58Z","pushed_at":"2018-06-14T10:16:52Z","git_url":"git://github.com/JabRef/jabref.git","ssh_url":"git@github.com:JabRef/jabref.git","clone_url":"https://github.com/JabRef/jabref.git","svn_url":"https://github.com/JabRef/jabref","homepage":"https://www.jabref.org","size":105542,"stargazers_count":956,"watchers_count":956,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":665,"mirror_url":null,"archived":false,"open_issues_count":185,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":665,"open_issues":185,"watchers":956,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/4127"},"html":{"href":"https://github.com/JabRef/jabref/pull/4127"},"issue":{"href":"https://api.github.com/repos/JabRef/jabref/issues/4127"},"comments":{"href":"https://api.github.com/repos/JabRef/jabref/issues/4127/comments"},"review_comments":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/4127/comments"},"review_comment":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/4127/commits"},"statuses":{"href":"https://api.github.com/repos/JabRef/jabref/statuses/2f18ad5645c660e5ab7bdd95db0be2ed137c63a2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"stefan-kolb"}}