{"action":"created","comment":{"url":"https://api.github.com/repos/betagouv/pass-culture-api/pulls/comments/225960022","pull_request_review_id":165669158,"id":225960022,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTk2MDAyMg==","diff_hunk":"@@ -80,6 +81,30 @@ def test_offerer_cannot_update_a_second_venue_to_be_virtual(app):\n         PcObject.check_and_save(new_venue)\n \n \n+@clean_database\n+@pytest.mark.standalone\n+def test_venue_cannot_be_virtual_and_have_a_siret(app):\n+    # given\n+    offerer = create_offerer()\n+    venue = create_venue(offerer, is_virtual=True, siret='12345678912345')\n+\n+    # when\n+    with pytest.raises(ApiErrors):\n+        PcObject.check_and_save(venue)\n+\n+\n+@clean_database\n+@pytest.mark.standalone\n+def test_venue_cannot_have_no_siret_without_comment(app):","path":"tests/models_venue_test.py","position":null,"original_position":55,"commit_id":"0286af970e122cc61c7d7b84befb28e41add050b","original_commit_id":"a1107bb0cc2341d4edfbb2be64188876f610a69d","user":{"login":"abel-andre","id":29952086,"node_id":"MDQ6VXNlcjI5OTUyMDg2","avatar_url":"https://avatars3.githubusercontent.com/u/29952086?v=4","gravatar_id":"","url":"https://api.github.com/users/abel-andre","html_url":"https://github.com/abel-andre","followers_url":"https://api.github.com/users/abel-andre/followers","following_url":"https://api.github.com/users/abel-andre/following{/other_user}","gists_url":"https://api.github.com/users/abel-andre/gists{/gist_id}","starred_url":"https://api.github.com/users/abel-andre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abel-andre/subscriptions","organizations_url":"https://api.github.com/users/abel-andre/orgs","repos_url":"https://api.github.com/users/abel-andre/repos","events_url":"https://api.github.com/users/abel-andre/events{/privacy}","received_events_url":"https://api.github.com/users/abel-andre/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-10-17T14:42:05Z","updated_at":"2018-10-17T14:42:06Z","html_url":"https://github.com/betagouv/pass-culture-api/pull/257#discussion_r225960022","pull_request_url":"https://api.github.com/repos/betagouv/pass-culture-api/pulls/257","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/betagouv/pass-culture-api/pulls/comments/225960022"},"html":{"href":"https://github.com/betagouv/pass-culture-api/pull/257#discussion_r225960022"},"pull_request":{"href":"https://api.github.com/repos/betagouv/pass-culture-api/pulls/257"}},"in_reply_to_id":225951734},"pull_request":{"url":"https://api.github.com/repos/betagouv/pass-culture-api/pulls/257","id":223603664,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNjAzNjY0","html_url":"https://github.com/betagouv/pass-culture-api/pull/257","diff_url":"https://github.com/betagouv/pass-culture-api/pull/257.diff","patch_url":"https://github.com/betagouv/pass-culture-api/pull/257.patch","issue_url":"https://api.github.com/repos/betagouv/pass-culture-api/issues/257","number":257,"state":"open","locked":false,"title":"819 a venue has one the three : isVirtual=True, comment, siret.","user":{"login":"abel-andre","id":29952086,"node_id":"MDQ6VXNlcjI5OTUyMDg2","avatar_url":"https://avatars3.githubusercontent.com/u/29952086?v=4","gravatar_id":"","url":"https://api.github.com/users/abel-andre","html_url":"https://github.com/abel-andre","followers_url":"https://api.github.com/users/abel-andre/followers","following_url":"https://api.github.com/users/abel-andre/following{/other_user}","gists_url":"https://api.github.com/users/abel-andre/gists{/gist_id}","starred_url":"https://api.github.com/users/abel-andre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abel-andre/subscriptions","organizations_url":"https://api.github.com/users/abel-andre/orgs","repos_url":"https://api.github.com/users/abel-andre/repos","events_url":"https://api.github.com/users/abel-andre/events{/privacy}","received_events_url":"https://api.github.com/users/abel-andre/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-17T13:28:21Z","updated_at":"2018-10-17T14:42:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b81c29be952ba811a3663379446c073a1df1b71","assignee":null,"assignees":[],"requested_reviewers":[{"login":"arnoo","id":185428,"node_id":"MDQ6VXNlcjE4NTQyOA==","avatar_url":"https://avatars0.githubusercontent.com/u/185428?v=4","gravatar_id":"","url":"https://api.github.com/users/arnoo","html_url":"https://github.com/arnoo","followers_url":"https://api.github.com/users/arnoo/followers","following_url":"https://api.github.com/users/arnoo/following{/other_user}","gists_url":"https://api.github.com/users/arnoo/gists{/gist_id}","starred_url":"https://api.github.com/users/arnoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnoo/subscriptions","organizations_url":"https://api.github.com/users/arnoo/orgs","repos_url":"https://api.github.com/users/arnoo/repos","events_url":"https://api.github.com/users/arnoo/events{/privacy}","received_events_url":"https://api.github.com/users/arnoo/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/betagouv/pass-culture-api/pulls/257/commits","review_comments_url":"https://api.github.com/repos/betagouv/pass-culture-api/pulls/257/comments","review_comment_url":"https://api.github.com/repos/betagouv/pass-culture-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/betagouv/pass-culture-api/issues/257/comments","statuses_url":"https://api.github.com/repos/betagouv/pass-culture-api/statuses/0286af970e122cc61c7d7b84befb28e41add050b","head":{"label":"betagouv:819_comments_on_venue","ref":"819_comments_on_venue","sha":"0286af970e122cc61c7d7b84befb28e41add050b","user":{"login":"betagouv","id":7874148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4NzQxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/7874148?v=4","gravatar_id":"","url":"https://api.github.com/users/betagouv","html_url":"https://github.com/betagouv","followers_url":"https://api.github.com/users/betagouv/followers","following_url":"https://api.github.com/users/betagouv/following{/other_user}","gists_url":"https://api.github.com/users/betagouv/gists{/gist_id}","starred_url":"https://api.github.com/users/betagouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betagouv/subscriptions","organizations_url":"https://api.github.com/users/betagouv/orgs","repos_url":"https://api.github.com/users/betagouv/repos","events_url":"https://api.github.com/users/betagouv/events{/privacy}","received_events_url":"https://api.github.com/users/betagouv/received_events","type":"Organization","site_admin":false},"repo":{"id":124255953,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQyNTU5NTM=","name":"pass-culture-api","full_name":"betagouv/pass-culture-api","private":false,"owner":{"login":"betagouv","id":7874148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4NzQxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/7874148?v=4","gravatar_id":"","url":"https://api.github.com/users/betagouv","html_url":"https://github.com/betagouv","followers_url":"https://api.github.com/users/betagouv/followers","following_url":"https://api.github.com/users/betagouv/following{/other_user}","gists_url":"https://api.github.com/users/betagouv/gists{/gist_id}","starred_url":"https://api.github.com/users/betagouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betagouv/subscriptions","organizations_url":"https://api.github.com/users/betagouv/orgs","repos_url":"https://api.github.com/users/betagouv/repos","events_url":"https://api.github.com/users/betagouv/events{/privacy}","received_events_url":"https://api.github.com/users/betagouv/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/betagouv/pass-culture-api","description":"API pour l'application Pass Culture","fork":false,"url":"https://api.github.com/repos/betagouv/pass-culture-api","forks_url":"https://api.github.com/repos/betagouv/pass-culture-api/forks","keys_url":"https://api.github.com/repos/betagouv/pass-culture-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/betagouv/pass-culture-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/betagouv/pass-culture-api/teams","hooks_url":"https://api.github.com/repos/betagouv/pass-culture-api/hooks","issue_events_url":"https://api.github.com/repos/betagouv/pass-culture-api/issues/events{/number}","events_url":"https://api.github.com/repos/betagouv/pass-culture-api/events","assignees_url":"https://api.github.com/repos/betagouv/pass-culture-api/assignees{/user}","branches_url":"https://api.github.com/repos/betagouv/pass-culture-api/branches{/branch}","tags_url":"https://api.github.com/repos/betagouv/pass-culture-api/tags","blobs_url":"https://api.github.com/repos/betagouv/pass-culture-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/betagouv/pass-culture-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/betagouv/pass-culture-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/betagouv/pass-culture-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/betagouv/pass-culture-api/statuses/{sha}","languages_url":"https://api.github.com/repos/betagouv/pass-culture-api/languages","stargazers_url":"https://api.github.com/repos/betagouv/pass-culture-api/stargazers","contributors_url":"https://api.github.com/repos/betagouv/pass-culture-api/contributors","subscribers_url":"https://api.github.com/repos/betagouv/pass-culture-api/subscribers","subscription_url":"https://api.github.com/repos/betagouv/pass-culture-api/subscription","commits_url":"https://api.github.com/repos/betagouv/pass-culture-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/betagouv/pass-culture-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/betagouv/pass-culture-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/betagouv/pass-culture-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/betagouv/pass-culture-api/contents/{+path}","compare_url":"https://api.github.com/repos/betagouv/pass-culture-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/betagouv/pass-culture-api/merges","archive_url":"https://api.github.com/repos/betagouv/pass-culture-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/betagouv/pass-culture-api/downloads","issues_url":"https://api.github.com/repos/betagouv/pass-culture-api/issues{/number}","pulls_url":"https://api.github.com/repos/betagouv/pass-culture-api/pulls{/number}","milestones_url":"https://api.github.com/repos/betagouv/pass-culture-api/milestones{/number}","notifications_url":"https://api.github.com/repos/betagouv/pass-culture-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/betagouv/pass-culture-api/labels{/name}","releases_url":"https://api.github.com/repos/betagouv/pass-culture-api/releases{/id}","deployments_url":"https://api.github.com/repos/betagouv/pass-culture-api/deployments","created_at":"2018-03-07T15:30:02Z","updated_at":"2018-10-16T13:17:22Z","pushed_at":"2018-10-17T14:41:50Z","git_url":"git://github.com/betagouv/pass-culture-api.git","ssh_url":"git@github.com:betagouv/pass-culture-api.git","clone_url":"https://github.com/betagouv/pass-culture-api.git","svn_url":"https://github.com/betagouv/pass-culture-api","homepage":null,"size":35389,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":21,"license":null,"forks":1,"open_issues":21,"watchers":1,"default_branch":"master"}},"base":{"label":"betagouv:master","ref":"master","sha":"b74ae6592cb1ce34282370d3d146f11578302ba5","user":{"login":"betagouv","id":7874148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4NzQxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/7874148?v=4","gravatar_id":"","url":"https://api.github.com/users/betagouv","html_url":"https://github.com/betagouv","followers_url":"https://api.github.com/users/betagouv/followers","following_url":"https://api.github.com/users/betagouv/following{/other_user}","gists_url":"https://api.github.com/users/betagouv/gists{/gist_id}","starred_url":"https://api.github.com/users/betagouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betagouv/subscriptions","organizations_url":"https://api.github.com/users/betagouv/orgs","repos_url":"https://api.github.com/users/betagouv/repos","events_url":"https://api.github.com/users/betagouv/events{/privacy}","received_events_url":"https://api.github.com/users/betagouv/received_events","type":"Organization","site_admin":false},"repo":{"id":124255953,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQyNTU5NTM=","name":"pass-culture-api","full_name":"betagouv/pass-culture-api","private":false,"owner":{"login":"betagouv","id":7874148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4NzQxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/7874148?v=4","gravatar_id":"","url":"https://api.github.com/users/betagouv","html_url":"https://github.com/betagouv","followers_url":"https://api.github.com/users/betagouv/followers","following_url":"https://api.github.com/users/betagouv/following{/other_user}","gists_url":"https://api.github.com/users/betagouv/gists{/gist_id}","starred_url":"https://api.github.com/users/betagouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betagouv/subscriptions","organizations_url":"https://api.github.com/users/betagouv/orgs","repos_url":"https://api.github.com/users/betagouv/repos","events_url":"https://api.github.com/users/betagouv/events{/privacy}","received_events_url":"https://api.github.com/users/betagouv/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/betagouv/pass-culture-api","description":"API pour l'application Pass Culture","fork":false,"url":"https://api.github.com/repos/betagouv/pass-culture-api","forks_url":"https://api.github.com/repos/betagouv/pass-culture-api/forks","keys_url":"https://api.github.com/repos/betagouv/pass-culture-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/betagouv/pass-culture-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/betagouv/pass-culture-api/teams","hooks_url":"https://api.github.com/repos/betagouv/pass-culture-api/hooks","issue_events_url":"https://api.github.com/repos/betagouv/pass-culture-api/issues/events{/number}","events_url":"https://api.github.com/repos/betagouv/pass-culture-api/events","assignees_url":"https://api.github.com/repos/betagouv/pass-culture-api/assignees{/user}","branches_url":"https://api.github.com/repos/betagouv/pass-culture-api/branches{/branch}","tags_url":"https://api.github.com/repos/betagouv/pass-culture-api/tags","blobs_url":"https://api.github.com/repos/betagouv/pass-culture-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/betagouv/pass-culture-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/betagouv/pass-culture-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/betagouv/pass-culture-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/betagouv/pass-culture-api/statuses/{sha}","languages_url":"https://api.github.com/repos/betagouv/pass-culture-api/languages","stargazers_url":"https://api.github.com/repos/betagouv/pass-culture-api/stargazers","contributors_url":"https://api.github.com/repos/betagouv/pass-culture-api/contributors","subscribers_url":"https://api.github.com/repos/betagouv/pass-culture-api/subscribers","subscription_url":"https://api.github.com/repos/betagouv/pass-culture-api/subscription","commits_url":"https://api.github.com/repos/betagouv/pass-culture-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/betagouv/pass-culture-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/betagouv/pass-culture-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/betagouv/pass-culture-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/betagouv/pass-culture-api/contents/{+path}","compare_url":"https://api.github.com/repos/betagouv/pass-culture-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/betagouv/pass-culture-api/merges","archive_url":"https://api.github.com/repos/betagouv/pass-culture-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/betagouv/pass-culture-api/downloads","issues_url":"https://api.github.com/repos/betagouv/pass-culture-api/issues{/number}","pulls_url":"https://api.github.com/repos/betagouv/pass-culture-api/pulls{/number}","milestones_url":"https://api.github.com/repos/betagouv/pass-culture-api/milestones{/number}","notifications_url":"https://api.github.com/repos/betagouv/pass-culture-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/betagouv/pass-culture-api/labels{/name}","releases_url":"https://api.github.com/repos/betagouv/pass-culture-api/releases{/id}","deployments_url":"https://api.github.com/repos/betagouv/pass-culture-api/deployments","created_at":"2018-03-07T15:30:02Z","updated_at":"2018-10-16T13:17:22Z","pushed_at":"2018-10-17T14:41:50Z","git_url":"git://github.com/betagouv/pass-culture-api.git","ssh_url":"git@github.com:betagouv/pass-culture-api.git","clone_url":"https://github.com/betagouv/pass-culture-api.git","svn_url":"https://github.com/betagouv/pass-culture-api","homepage":null,"size":35389,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":21,"license":null,"forks":1,"open_issues":21,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/betagouv/pass-culture-api/pulls/257"},"html":{"href":"https://github.com/betagouv/pass-culture-api/pull/257"},"issue":{"href":"https://api.github.com/repos/betagouv/pass-culture-api/issues/257"},"comments":{"href":"https://api.github.com/repos/betagouv/pass-culture-api/issues/257/comments"},"review_comments":{"href":"https://api.github.com/repos/betagouv/pass-culture-api/pulls/257/comments"},"review_comment":{"href":"https://api.github.com/repos/betagouv/pass-culture-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/betagouv/pass-culture-api/pulls/257/commits"},"statuses":{"href":"https://api.github.com/repos/betagouv/pass-culture-api/statuses/0286af970e122cc61c7d7b84befb28e41add050b"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"abel-andre"}}