{"action":"created","comment":{"url":"https://api.github.com/repos/Exiv2/exiv2/pulls/comments/191110513","pull_request_review_id":123621530,"id":191110513,"diff_hunk":"@@ -16,16 +16,15 @@ def check_no_ASAN_UBSAN_errors(self, i, command, got_stderr, expected_stderr):\n         Here we want to also check that the two last lines of got_stderr have the expected_stderr\n         \"\"\"\n \n-        system_tests.check_no_ASAN_UBSAN_errors(self, i, command, got_stderr, expected_stderr)\n+        check_no_ASAN_UBSAN_errors(self, i, command, got_stderr, expected_stderr)\n         self.assertListEqual(expected_stderr.splitlines(), got_stderr.splitlines()[-2:])\n \n-    filename = os.path.join(\"$data_path\", \"pocIssue283.jpg\")\n+    filename = p(\"$data_path/pocIssue283.jpg\")","path":"tests/bugfixes/github/test_issue_283.py","position":22,"original_position":22,"commit_id":"f9f62483170fadb085a4e2c67338b57a603f000b","original_commit_id":"f9f62483170fadb085a4e2c67338b57a603f000b","user":{"login":"piponazo","id":102645,"avatar_url":"https://avatars0.githubusercontent.com/u/102645?v=4","gravatar_id":"","url":"https://api.github.com/users/piponazo","html_url":"https://github.com/piponazo","followers_url":"https://api.github.com/users/piponazo/followers","following_url":"https://api.github.com/users/piponazo/following{/other_user}","gists_url":"https://api.github.com/users/piponazo/gists{/gist_id}","starred_url":"https://api.github.com/users/piponazo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piponazo/subscriptions","organizations_url":"https://api.github.com/users/piponazo/orgs","repos_url":"https://api.github.com/users/piponazo/repos","events_url":"https://api.github.com/users/piponazo/events{/privacy}","received_events_url":"https://api.github.com/users/piponazo/received_events","type":"User","site_admin":false},"body":"Please change the name of the function `p` to something more meaningful like: platformPath, uniformPath, convertPath, etc. Anything you come up will be better than simply `p` :wink: ","created_at":"2018-05-28T04:48:27Z","updated_at":"2018-05-28T04:59:36Z","html_url":"https://github.com/Exiv2/exiv2/pull/329#discussion_r191110513","pull_request_url":"https://api.github.com/repos/Exiv2/exiv2/pulls/329","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Exiv2/exiv2/pulls/comments/191110513"},"html":{"href":"https://github.com/Exiv2/exiv2/pull/329#discussion_r191110513"},"pull_request":{"href":"https://api.github.com/repos/Exiv2/exiv2/pulls/329"}}},"pull_request":{"url":"https://api.github.com/repos/Exiv2/exiv2/pulls/329","id":190810471,"html_url":"https://github.com/Exiv2/exiv2/pull/329","diff_url":"https://github.com/Exiv2/exiv2/pull/329.diff","patch_url":"https://github.com/Exiv2/exiv2/pull/329.patch","issue_url":"https://api.github.com/repos/Exiv2/exiv2/issues/329","number":329,"state":"open","locked":false,"title":"[WIP] Test suite improvements","user":{"login":"D4N","id":786021,"avatar_url":"https://avatars2.githubusercontent.com/u/786021?v=4","gravatar_id":"","url":"https://api.github.com/users/D4N","html_url":"https://github.com/D4N","followers_url":"https://api.github.com/users/D4N/followers","following_url":"https://api.github.com/users/D4N/following{/other_user}","gists_url":"https://api.github.com/users/D4N/gists{/gist_id}","starred_url":"https://api.github.com/users/D4N/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D4N/subscriptions","organizations_url":"https://api.github.com/users/D4N/orgs","repos_url":"https://api.github.com/users/D4N/repos","events_url":"https://api.github.com/users/D4N/events{/privacy}","received_events_url":"https://api.github.com/users/D4N/received_events","type":"User","site_admin":false},"body":"I have (hopefully) improved some parts of the test suite that were inconvenient before.\r\n\r\n1. The variables defined in the config file are now accessible inside the `system_tests` namespace.\r\n2. A new function `p` was added, that converts unix paths to Windows paths on Windows.","created_at":"2018-05-27T22:41:47Z","updated_at":"2018-05-28T04:59:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8f1d9ae830f35912b7857e326a2c2b421b9a3a1f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Exiv2/exiv2/pulls/329/commits","review_comments_url":"https://api.github.com/repos/Exiv2/exiv2/pulls/329/comments","review_comment_url":"https://api.github.com/repos/Exiv2/exiv2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Exiv2/exiv2/issues/329/comments","statuses_url":"https://api.github.com/repos/Exiv2/exiv2/statuses/f9f62483170fadb085a4e2c67338b57a603f000b","head":{"label":"Exiv2:test_suite_improvements","ref":"test_suite_improvements","sha":"f9f62483170fadb085a4e2c67338b57a603f000b","user":{"login":"Exiv2","id":23559442,"avatar_url":"https://avatars3.githubusercontent.com/u/23559442?v=4","gravatar_id":"","url":"https://api.github.com/users/Exiv2","html_url":"https://github.com/Exiv2","followers_url":"https://api.github.com/users/Exiv2/followers","following_url":"https://api.github.com/users/Exiv2/following{/other_user}","gists_url":"https://api.github.com/users/Exiv2/gists{/gist_id}","starred_url":"https://api.github.com/users/Exiv2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Exiv2/subscriptions","organizations_url":"https://api.github.com/users/Exiv2/orgs","repos_url":"https://api.github.com/users/Exiv2/repos","events_url":"https://api.github.com/users/Exiv2/events{/privacy}","received_events_url":"https://api.github.com/users/Exiv2/received_events","type":"Organization","site_admin":false},"repo":{"id":89623031,"name":"exiv2","full_name":"Exiv2/exiv2","owner":{"login":"Exiv2","id":23559442,"avatar_url":"https://avatars3.githubusercontent.com/u/23559442?v=4","gravatar_id":"","url":"https://api.github.com/users/Exiv2","html_url":"https://github.com/Exiv2","followers_url":"https://api.github.com/users/Exiv2/followers","following_url":"https://api.github.com/users/Exiv2/following{/other_user}","gists_url":"https://api.github.com/users/Exiv2/gists{/gist_id}","starred_url":"https://api.github.com/users/Exiv2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Exiv2/subscriptions","organizations_url":"https://api.github.com/users/Exiv2/orgs","repos_url":"https://api.github.com/users/Exiv2/repos","events_url":"https://api.github.com/users/Exiv2/events{/privacy}","received_events_url":"https://api.github.com/users/Exiv2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Exiv2/exiv2","description":"Image metadata library and tools","fork":false,"url":"https://api.github.com/repos/Exiv2/exiv2","forks_url":"https://api.github.com/repos/Exiv2/exiv2/forks","keys_url":"https://api.github.com/repos/Exiv2/exiv2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Exiv2/exiv2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Exiv2/exiv2/teams","hooks_url":"https://api.github.com/repos/Exiv2/exiv2/hooks","issue_events_url":"https://api.github.com/repos/Exiv2/exiv2/issues/events{/number}","events_url":"https://api.github.com/repos/Exiv2/exiv2/events","assignees_url":"https://api.github.com/repos/Exiv2/exiv2/assignees{/user}","branches_url":"https://api.github.com/repos/Exiv2/exiv2/branches{/branch}","tags_url":"https://api.github.com/repos/Exiv2/exiv2/tags","blobs_url":"https://api.github.com/repos/Exiv2/exiv2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Exiv2/exiv2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Exiv2/exiv2/git/refs{/sha}","trees_url":"https://api.github.com/repos/Exiv2/exiv2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Exiv2/exiv2/statuses/{sha}","languages_url":"https://api.github.com/repos/Exiv2/exiv2/languages","stargazers_url":"https://api.github.com/repos/Exiv2/exiv2/stargazers","contributors_url":"https://api.github.com/repos/Exiv2/exiv2/contributors","subscribers_url":"https://api.github.com/repos/Exiv2/exiv2/subscribers","subscription_url":"https://api.github.com/repos/Exiv2/exiv2/subscription","commits_url":"https://api.github.com/repos/Exiv2/exiv2/commits{/sha}","git_commits_url":"https://api.github.com/repos/Exiv2/exiv2/git/commits{/sha}","comments_url":"https://api.github.com/repos/Exiv2/exiv2/comments{/number}","issue_comment_url":"https://api.github.com/repos/Exiv2/exiv2/issues/comments{/number}","contents_url":"https://api.github.com/repos/Exiv2/exiv2/contents/{+path}","compare_url":"https://api.github.com/repos/Exiv2/exiv2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Exiv2/exiv2/merges","archive_url":"https://api.github.com/repos/Exiv2/exiv2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Exiv2/exiv2/downloads","issues_url":"https://api.github.com/repos/Exiv2/exiv2/issues{/number}","pulls_url":"https://api.github.com/repos/Exiv2/exiv2/pulls{/number}","milestones_url":"https://api.github.com/repos/Exiv2/exiv2/milestones{/number}","notifications_url":"https://api.github.com/repos/Exiv2/exiv2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Exiv2/exiv2/labels{/name}","releases_url":"https://api.github.com/repos/Exiv2/exiv2/releases{/id}","deployments_url":"https://api.github.com/repos/Exiv2/exiv2/deployments","created_at":"2017-04-27T17:25:13Z","updated_at":"2018-05-27T11:26:01Z","pushed_at":"2018-05-27T23:01:02Z","git_url":"git://github.com/Exiv2/exiv2.git","ssh_url":"git@github.com:Exiv2/exiv2.git","clone_url":"https://github.com/Exiv2/exiv2.git","svn_url":"https://github.com/Exiv2/exiv2","homepage":"http://www.exiv2.org/","size":87029,"stargazers_count":77,"watchers_count":77,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":43,"open_issues":44,"watchers":77,"default_branch":"master"}},"base":{"label":"Exiv2:master","ref":"master","sha":"e483856a61111968a27cefb2946cf52c8d7ccd26","user":{"login":"Exiv2","id":23559442,"avatar_url":"https://avatars3.githubusercontent.com/u/23559442?v=4","gravatar_id":"","url":"https://api.github.com/users/Exiv2","html_url":"https://github.com/Exiv2","followers_url":"https://api.github.com/users/Exiv2/followers","following_url":"https://api.github.com/users/Exiv2/following{/other_user}","gists_url":"https://api.github.com/users/Exiv2/gists{/gist_id}","starred_url":"https://api.github.com/users/Exiv2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Exiv2/subscriptions","organizations_url":"https://api.github.com/users/Exiv2/orgs","repos_url":"https://api.github.com/users/Exiv2/repos","events_url":"https://api.github.com/users/Exiv2/events{/privacy}","received_events_url":"https://api.github.com/users/Exiv2/received_events","type":"Organization","site_admin":false},"repo":{"id":89623031,"name":"exiv2","full_name":"Exiv2/exiv2","owner":{"login":"Exiv2","id":23559442,"avatar_url":"https://avatars3.githubusercontent.com/u/23559442?v=4","gravatar_id":"","url":"https://api.github.com/users/Exiv2","html_url":"https://github.com/Exiv2","followers_url":"https://api.github.com/users/Exiv2/followers","following_url":"https://api.github.com/users/Exiv2/following{/other_user}","gists_url":"https://api.github.com/users/Exiv2/gists{/gist_id}","starred_url":"https://api.github.com/users/Exiv2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Exiv2/subscriptions","organizations_url":"https://api.github.com/users/Exiv2/orgs","repos_url":"https://api.github.com/users/Exiv2/repos","events_url":"https://api.github.com/users/Exiv2/events{/privacy}","received_events_url":"https://api.github.com/users/Exiv2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Exiv2/exiv2","description":"Image metadata library and tools","fork":false,"url":"https://api.github.com/repos/Exiv2/exiv2","forks_url":"https://api.github.com/repos/Exiv2/exiv2/forks","keys_url":"https://api.github.com/repos/Exiv2/exiv2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Exiv2/exiv2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Exiv2/exiv2/teams","hooks_url":"https://api.github.com/repos/Exiv2/exiv2/hooks","issue_events_url":"https://api.github.com/repos/Exiv2/exiv2/issues/events{/number}","events_url":"https://api.github.com/repos/Exiv2/exiv2/events","assignees_url":"https://api.github.com/repos/Exiv2/exiv2/assignees{/user}","branches_url":"https://api.github.com/repos/Exiv2/exiv2/branches{/branch}","tags_url":"https://api.github.com/repos/Exiv2/exiv2/tags","blobs_url":"https://api.github.com/repos/Exiv2/exiv2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Exiv2/exiv2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Exiv2/exiv2/git/refs{/sha}","trees_url":"https://api.github.com/repos/Exiv2/exiv2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Exiv2/exiv2/statuses/{sha}","languages_url":"https://api.github.com/repos/Exiv2/exiv2/languages","stargazers_url":"https://api.github.com/repos/Exiv2/exiv2/stargazers","contributors_url":"https://api.github.com/repos/Exiv2/exiv2/contributors","subscribers_url":"https://api.github.com/repos/Exiv2/exiv2/subscribers","subscription_url":"https://api.github.com/repos/Exiv2/exiv2/subscription","commits_url":"https://api.github.com/repos/Exiv2/exiv2/commits{/sha}","git_commits_url":"https://api.github.com/repos/Exiv2/exiv2/git/commits{/sha}","comments_url":"https://api.github.com/repos/Exiv2/exiv2/comments{/number}","issue_comment_url":"https://api.github.com/repos/Exiv2/exiv2/issues/comments{/number}","contents_url":"https://api.github.com/repos/Exiv2/exiv2/contents/{+path}","compare_url":"https://api.github.com/repos/Exiv2/exiv2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Exiv2/exiv2/merges","archive_url":"https://api.github.com/repos/Exiv2/exiv2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Exiv2/exiv2/downloads","issues_url":"https://api.github.com/repos/Exiv2/exiv2/issues{/number}","pulls_url":"https://api.github.com/repos/Exiv2/exiv2/pulls{/number}","milestones_url":"https://api.github.com/repos/Exiv2/exiv2/milestones{/number}","notifications_url":"https://api.github.com/repos/Exiv2/exiv2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Exiv2/exiv2/labels{/name}","releases_url":"https://api.github.com/repos/Exiv2/exiv2/releases{/id}","deployments_url":"https://api.github.com/repos/Exiv2/exiv2/deployments","created_at":"2017-04-27T17:25:13Z","updated_at":"2018-05-27T11:26:01Z","pushed_at":"2018-05-27T23:01:02Z","git_url":"git://github.com/Exiv2/exiv2.git","ssh_url":"git@github.com:Exiv2/exiv2.git","clone_url":"https://github.com/Exiv2/exiv2.git","svn_url":"https://github.com/Exiv2/exiv2","homepage":"http://www.exiv2.org/","size":87029,"stargazers_count":77,"watchers_count":77,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":43,"open_issues":44,"watchers":77,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Exiv2/exiv2/pulls/329"},"html":{"href":"https://github.com/Exiv2/exiv2/pull/329"},"issue":{"href":"https://api.github.com/repos/Exiv2/exiv2/issues/329"},"comments":{"href":"https://api.github.com/repos/Exiv2/exiv2/issues/329/comments"},"review_comments":{"href":"https://api.github.com/repos/Exiv2/exiv2/pulls/329/comments"},"review_comment":{"href":"https://api.github.com/repos/Exiv2/exiv2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Exiv2/exiv2/pulls/329/commits"},"statuses":{"href":"https://api.github.com/repos/Exiv2/exiv2/statuses/f9f62483170fadb085a4e2c67338b57a603f000b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"piponazo"}}