{"action":"created","comment":{"url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/pulls/comments/203785317","pull_request_review_id":138745007,"id":203785317,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzc4NTMxNw==","diff_hunk":"@@ -450,8 +450,9 @@ def disable_asserts(input_string):\n         output_string = output_string.replace(input_string[start:p_end + 1], \"\")\n     return output_string\n \n+","path":"tools/amd_build/pyHIPIFY/hipify-python.py","position":4,"original_position":4,"commit_id":"cd3f36734a26b8c449676e39a7caf0912fb5052b","original_commit_id":"cd3f36734a26b8c449676e39a7caf0912fb5052b","user":{"login":"Jorghi12","id":8586039,"node_id":"MDQ6VXNlcjg1ODYwMzk=","avatar_url":"https://avatars2.githubusercontent.com/u/8586039?v=4","gravatar_id":"","url":"https://api.github.com/users/Jorghi12","html_url":"https://github.com/Jorghi12","followers_url":"https://api.github.com/users/Jorghi12/followers","following_url":"https://api.github.com/users/Jorghi12/following{/other_user}","gists_url":"https://api.github.com/users/Jorghi12/gists{/gist_id}","starred_url":"https://api.github.com/users/Jorghi12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jorghi12/subscriptions","organizations_url":"https://api.github.com/users/Jorghi12/orgs","repos_url":"https://api.github.com/users/Jorghi12/repos","events_url":"https://api.github.com/users/Jorghi12/events{/privacy}","received_events_url":"https://api.github.com/users/Jorghi12/received_events","type":"User","site_admin":false},"body":"#PEP8","created_at":"2018-07-19T16:06:43Z","updated_at":"2018-07-19T16:06:43Z","html_url":"https://github.com/ROCmSoftwarePlatform/pytorch/pull/53#discussion_r203785317","pull_request_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/pulls/53","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/pulls/comments/203785317"},"html":{"href":"https://github.com/ROCmSoftwarePlatform/pytorch/pull/53#discussion_r203785317"},"pull_request":{"href":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/pulls/53"}},"in_reply_to_id":203760074},"pull_request":{"url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/pulls/53","id":202493405,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNDkzNDA1","html_url":"https://github.com/ROCmSoftwarePlatform/pytorch/pull/53","diff_url":"https://github.com/ROCmSoftwarePlatform/pytorch/pull/53.diff","patch_url":"https://github.com/ROCmSoftwarePlatform/pytorch/pull/53.patch","issue_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/issues/53","number":53,"state":"open","locked":false,"title":"Improving the ROCm build process.","user":{"login":"Jorghi12","id":8586039,"node_id":"MDQ6VXNlcjg1ODYwMzk=","avatar_url":"https://avatars2.githubusercontent.com/u/8586039?v=4","gravatar_id":"","url":"https://api.github.com/users/Jorghi12","html_url":"https://github.com/Jorghi12","followers_url":"https://api.github.com/users/Jorghi12/followers","following_url":"https://api.github.com/users/Jorghi12/following{/other_user}","gists_url":"https://api.github.com/users/Jorghi12/gists{/gist_id}","starred_url":"https://api.github.com/users/Jorghi12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jorghi12/subscriptions","organizations_url":"https://api.github.com/users/Jorghi12/orgs","repos_url":"https://api.github.com/users/Jorghi12/repos","events_url":"https://api.github.com/users/Jorghi12/events{/privacy}","received_events_url":"https://api.github.com/users/Jorghi12/received_events","type":"User","site_admin":false},"body":"**### Fix 1)**\r\nThe NVCC compiler automatically pre includes CUDA-specific header files when handling code in cu/cuh files (e.g. --preinclude \"cuda_runtime.h\"). The HCC compiler didn't do this automatically for us, so we need to add this logic into the transpilation script.\r\n\r\nSource: http://www.cs.cmu.edu/afs/cs/academic/class/15668-s11/www/cuda-doc/nvcc.pdf\r\n\r\n**### Fix 2)**\r\nAlso, I amended the transpiler with a fix for dynamic shared memory allocation when kernels are launched from the host side. These warnings will no longer show up on the console anymore. \r\nhttps://github.com/ROCm-Developer-Tools/HIP/blob/master/docs/markdown/hip_kernel_language.md#__shared__\r\n\r\n**### Fix 3)**\r\nWe need to include the SHARED flag when calling hip_add_library. There is logic in FindHIP.CMake such that if this flag is missing, then the -fPIC flag will not be passed into HCC while linking.  \r\nhttps://github.com/ROCm-Developer-Tools/HIP/blob/master/cmake/FindHIP.cmake#L398\r\n\r\n**### Fix 4)**\r\nCompile Definitions that were set in the CMakeLists directory were being dropped when building with the FindHIP.CMake toolchain. I've added the workaround logic in order to handle this issue.","created_at":"2018-07-19T09:12:16Z","updated_at":"2018-07-19T16:06:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"50c57bbb3a02f0990e2aa8b1e84e9b9e779507f2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ezyang","id":13564,"node_id":"MDQ6VXNlcjEzNTY0","avatar_url":"https://avatars0.githubusercontent.com/u/13564?v=4","gravatar_id":"","url":"https://api.github.com/users/ezyang","html_url":"https://github.com/ezyang","followers_url":"https://api.github.com/users/ezyang/followers","following_url":"https://api.github.com/users/ezyang/following{/other_user}","gists_url":"https://api.github.com/users/ezyang/gists{/gist_id}","starred_url":"https://api.github.com/users/ezyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezyang/subscriptions","organizations_url":"https://api.github.com/users/ezyang/orgs","repos_url":"https://api.github.com/users/ezyang/repos","events_url":"https://api.github.com/users/ezyang/events{/privacy}","received_events_url":"https://api.github.com/users/ezyang/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/pulls/53/commits","review_comments_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/pulls/53/comments","review_comment_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/issues/53/comments","statuses_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/statuses/cd3f36734a26b8c449676e39a7caf0912fb5052b","head":{"label":"Jorghi12:fix_hipify","ref":"fix_hipify","sha":"cd3f36734a26b8c449676e39a7caf0912fb5052b","user":{"login":"Jorghi12","id":8586039,"node_id":"MDQ6VXNlcjg1ODYwMzk=","avatar_url":"https://avatars2.githubusercontent.com/u/8586039?v=4","gravatar_id":"","url":"https://api.github.com/users/Jorghi12","html_url":"https://github.com/Jorghi12","followers_url":"https://api.github.com/users/Jorghi12/followers","following_url":"https://api.github.com/users/Jorghi12/following{/other_user}","gists_url":"https://api.github.com/users/Jorghi12/gists{/gist_id}","starred_url":"https://api.github.com/users/Jorghi12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jorghi12/subscriptions","organizations_url":"https://api.github.com/users/Jorghi12/orgs","repos_url":"https://api.github.com/users/Jorghi12/repos","events_url":"https://api.github.com/users/Jorghi12/events{/privacy}","received_events_url":"https://api.github.com/users/Jorghi12/received_events","type":"User","site_admin":false},"repo":{"id":119436592,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk0MzY1OTI=","name":"pytorch","full_name":"Jorghi12/pytorch","owner":{"login":"Jorghi12","id":8586039,"node_id":"MDQ6VXNlcjg1ODYwMzk=","avatar_url":"https://avatars2.githubusercontent.com/u/8586039?v=4","gravatar_id":"","url":"https://api.github.com/users/Jorghi12","html_url":"https://github.com/Jorghi12","followers_url":"https://api.github.com/users/Jorghi12/followers","following_url":"https://api.github.com/users/Jorghi12/following{/other_user}","gists_url":"https://api.github.com/users/Jorghi12/gists{/gist_id}","starred_url":"https://api.github.com/users/Jorghi12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jorghi12/subscriptions","organizations_url":"https://api.github.com/users/Jorghi12/orgs","repos_url":"https://api.github.com/users/Jorghi12/repos","events_url":"https://api.github.com/users/Jorghi12/events{/privacy}","received_events_url":"https://api.github.com/users/Jorghi12/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Jorghi12/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":true,"url":"https://api.github.com/repos/Jorghi12/pytorch","forks_url":"https://api.github.com/repos/Jorghi12/pytorch/forks","keys_url":"https://api.github.com/repos/Jorghi12/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jorghi12/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jorghi12/pytorch/teams","hooks_url":"https://api.github.com/repos/Jorghi12/pytorch/hooks","issue_events_url":"https://api.github.com/repos/Jorghi12/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/Jorghi12/pytorch/events","assignees_url":"https://api.github.com/repos/Jorghi12/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/Jorghi12/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/Jorghi12/pytorch/tags","blobs_url":"https://api.github.com/repos/Jorghi12/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jorghi12/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jorghi12/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jorghi12/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jorghi12/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/Jorghi12/pytorch/languages","stargazers_url":"https://api.github.com/repos/Jorghi12/pytorch/stargazers","contributors_url":"https://api.github.com/repos/Jorghi12/pytorch/contributors","subscribers_url":"https://api.github.com/repos/Jorghi12/pytorch/subscribers","subscription_url":"https://api.github.com/repos/Jorghi12/pytorch/subscription","commits_url":"https://api.github.com/repos/Jorghi12/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jorghi12/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jorghi12/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jorghi12/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jorghi12/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/Jorghi12/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jorghi12/pytorch/merges","archive_url":"https://api.github.com/repos/Jorghi12/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jorghi12/pytorch/downloads","issues_url":"https://api.github.com/repos/Jorghi12/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/Jorghi12/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/Jorghi12/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/Jorghi12/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jorghi12/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/Jorghi12/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/Jorghi12/pytorch/deployments","created_at":"2018-01-29T20:22:36Z","updated_at":"2018-01-29T20:22:44Z","pushed_at":"2018-07-19T03:40:17Z","git_url":"git://github.com/Jorghi12/pytorch.git","ssh_url":"git@github.com:Jorghi12/pytorch.git","clone_url":"https://github.com/Jorghi12/pytorch.git","svn_url":"https://github.com/Jorghi12/pytorch","homepage":"http://pytorch.org","size":62928,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ROCmSoftwarePlatform:master","ref":"master","sha":"62465266178b31da84f884d5df482a17874016c1","user":{"login":"ROCmSoftwarePlatform","id":16900697,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTAwNjk3","avatar_url":"https://avatars0.githubusercontent.com/u/16900697?v=4","gravatar_id":"","url":"https://api.github.com/users/ROCmSoftwarePlatform","html_url":"https://github.com/ROCmSoftwarePlatform","followers_url":"https://api.github.com/users/ROCmSoftwarePlatform/followers","following_url":"https://api.github.com/users/ROCmSoftwarePlatform/following{/other_user}","gists_url":"https://api.github.com/users/ROCmSoftwarePlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/ROCmSoftwarePlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ROCmSoftwarePlatform/subscriptions","organizations_url":"https://api.github.com/users/ROCmSoftwarePlatform/orgs","repos_url":"https://api.github.com/users/ROCmSoftwarePlatform/repos","events_url":"https://api.github.com/users/ROCmSoftwarePlatform/events{/privacy}","received_events_url":"https://api.github.com/users/ROCmSoftwarePlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":128132891,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgxMzI4OTE=","name":"pytorch","full_name":"ROCmSoftwarePlatform/pytorch","owner":{"login":"ROCmSoftwarePlatform","id":16900697,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTAwNjk3","avatar_url":"https://avatars0.githubusercontent.com/u/16900697?v=4","gravatar_id":"","url":"https://api.github.com/users/ROCmSoftwarePlatform","html_url":"https://github.com/ROCmSoftwarePlatform","followers_url":"https://api.github.com/users/ROCmSoftwarePlatform/followers","following_url":"https://api.github.com/users/ROCmSoftwarePlatform/following{/other_user}","gists_url":"https://api.github.com/users/ROCmSoftwarePlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/ROCmSoftwarePlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ROCmSoftwarePlatform/subscriptions","organizations_url":"https://api.github.com/users/ROCmSoftwarePlatform/orgs","repos_url":"https://api.github.com/users/ROCmSoftwarePlatform/repos","events_url":"https://api.github.com/users/ROCmSoftwarePlatform/events{/privacy}","received_events_url":"https://api.github.com/users/ROCmSoftwarePlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ROCmSoftwarePlatform/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":true,"url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch","forks_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/forks","keys_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/teams","hooks_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/hooks","issue_events_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/events","assignees_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/tags","blobs_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/languages","stargazers_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/stargazers","contributors_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/contributors","subscribers_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/subscribers","subscription_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/subscription","commits_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/merges","archive_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/downloads","issues_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/deployments","created_at":"2018-04-04T23:08:21Z","updated_at":"2018-07-19T14:56:32Z","pushed_at":"2018-07-19T14:56:29Z","git_url":"git://github.com/ROCmSoftwarePlatform/pytorch.git","ssh_url":"git@github.com:ROCmSoftwarePlatform/pytorch.git","clone_url":"https://github.com/ROCmSoftwarePlatform/pytorch.git","svn_url":"https://github.com/ROCmSoftwarePlatform/pytorch","homepage":"http://pytorch.org","size":63339,"stargazers_count":7,"watchers_count":7,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":16,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/pulls/53"},"html":{"href":"https://github.com/ROCmSoftwarePlatform/pytorch/pull/53"},"issue":{"href":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/issues/53"},"comments":{"href":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/statuses/cd3f36734a26b8c449676e39a7caf0912fb5052b"}},"author_association":"NONE"}}
{"actor":{"display_login":"Jorghi12"}}