{"action":"created","comment":{"url":"https://api.github.com/repos/FacilityApi/Facility/pulls/comments/167405958","pull_request_review_id":95628707,"id":167405958,"diff_hunk":"@@ -20,8 +21,13 @@ public ServiceAttributeInfo(string name, IEnumerable<ServiceAttributeParameterIn\n \t\t\tParameters = parameters.ToReadOnlyList();\n \t\t\tPosition = position;\n \n-\t\t\tServiceDefinitionUtility.ValidateName(Name, Position);\n-\t\t\tServiceDefinitionUtility.ValidateNoDuplicateNames(Parameters, \"attribute parameter\");\n+\t\t\tthis.Validate(validationMode);\n+\t\t}\n+\n+\t\tIEnumerable<ServiceDefinitionError> IValidatable.Validate()","path":"src/Facility.Definition/ServiceAttributeInfo.cs","position":30,"original_position":30,"commit_id":"182d3b3785f24c57f85e9bb88d8706ea48a1523b","original_commit_id":"182d3b3785f24c57f85e9bb88d8706ea48a1523b","user":{"login":"ejball","id":197797,"avatar_url":"https://avatars1.githubusercontent.com/u/197797?v=4","gravatar_id":"","url":"https://api.github.com/users/ejball","html_url":"https://github.com/ejball","followers_url":"https://api.github.com/users/ejball/followers","following_url":"https://api.github.com/users/ejball/following{/other_user}","gists_url":"https://api.github.com/users/ejball/gists{/gist_id}","starred_url":"https://api.github.com/users/ejball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejball/subscriptions","organizations_url":"https://api.github.com/users/ejball/orgs","repos_url":"https://api.github.com/users/ejball/repos","events_url":"https://api.github.com/users/ejball/events{/privacy}","received_events_url":"https://api.github.com/users/ejball/received_events","type":"User","site_admin":false},"body":"Why implicit?","created_at":"2018-02-10T17:53:12Z","updated_at":"2018-02-10T17:53:12Z","html_url":"https://github.com/FacilityApi/Facility/pull/5#discussion_r167405958","pull_request_url":"https://api.github.com/repos/FacilityApi/Facility/pulls/5","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/FacilityApi/Facility/pulls/comments/167405958"},"html":{"href":"https://github.com/FacilityApi/Facility/pull/5#discussion_r167405958"},"pull_request":{"href":"https://api.github.com/repos/FacilityApi/Facility/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/FacilityApi/Facility/pulls/5","id":167626879,"html_url":"https://github.com/FacilityApi/Facility/pull/5","diff_url":"https://github.com/FacilityApi/Facility/pull/5.diff","patch_url":"https://github.com/FacilityApi/Facility/pull/5.patch","issue_url":"https://api.github.com/repos/FacilityApi/Facility/issues/5","number":5,"state":"open","locked":false,"title":"Optionally return all parse errors.","user":{"login":"ddunkin","id":264744,"avatar_url":"https://avatars2.githubusercontent.com/u/264744?v=4","gravatar_id":"","url":"https://api.github.com/users/ddunkin","html_url":"https://github.com/ddunkin","followers_url":"https://api.github.com/users/ddunkin/followers","following_url":"https://api.github.com/users/ddunkin/following{/other_user}","gists_url":"https://api.github.com/users/ddunkin/gists{/gist_id}","starred_url":"https://api.github.com/users/ddunkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddunkin/subscriptions","organizations_url":"https://api.github.com/users/ddunkin/orgs","repos_url":"https://api.github.com/users/ddunkin/repos","events_url":"https://api.github.com/users/ddunkin/events{/privacy}","received_events_url":"https://api.github.com/users/ddunkin/received_events","type":"User","site_admin":false},"body":"There could be multiple errors in a service definition. Ideally the language server would report all errors, not just the first one. Syntactic errors may be hard to parse through, but semantic errors should be relatively easy to collect.\r\n\r\nThis work-in-progress PR explores making validation while parsing optional internally, allowing an invalid service to be constructed, but returning all semantic errors. A semantically invalid service is still useful in cases like a language server handling a completion request.","created_at":"2018-02-07T08:33:41Z","updated_at":"2018-02-10T17:53:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6c2b9338d5da5736d6e589723a35c8874e6ed22","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/FacilityApi/Facility/pulls/5/commits","review_comments_url":"https://api.github.com/repos/FacilityApi/Facility/pulls/5/comments","review_comment_url":"https://api.github.com/repos/FacilityApi/Facility/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FacilityApi/Facility/issues/5/comments","statuses_url":"https://api.github.com/repos/FacilityApi/Facility/statuses/182d3b3785f24c57f85e9bb88d8706ea48a1523b","head":{"label":"ddunkin:return-parse-errors","ref":"return-parse-errors","sha":"182d3b3785f24c57f85e9bb88d8706ea48a1523b","user":{"login":"ddunkin","id":264744,"avatar_url":"https://avatars2.githubusercontent.com/u/264744?v=4","gravatar_id":"","url":"https://api.github.com/users/ddunkin","html_url":"https://github.com/ddunkin","followers_url":"https://api.github.com/users/ddunkin/followers","following_url":"https://api.github.com/users/ddunkin/following{/other_user}","gists_url":"https://api.github.com/users/ddunkin/gists{/gist_id}","starred_url":"https://api.github.com/users/ddunkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddunkin/subscriptions","organizations_url":"https://api.github.com/users/ddunkin/orgs","repos_url":"https://api.github.com/users/ddunkin/repos","events_url":"https://api.github.com/users/ddunkin/events{/privacy}","received_events_url":"https://api.github.com/users/ddunkin/received_events","type":"User","site_admin":false},"repo":{"id":120576710,"name":"Facility","full_name":"ddunkin/Facility","owner":{"login":"ddunkin","id":264744,"avatar_url":"https://avatars2.githubusercontent.com/u/264744?v=4","gravatar_id":"","url":"https://api.github.com/users/ddunkin","html_url":"https://github.com/ddunkin","followers_url":"https://api.github.com/users/ddunkin/followers","following_url":"https://api.github.com/users/ddunkin/following{/other_user}","gists_url":"https://api.github.com/users/ddunkin/gists{/gist_id}","starred_url":"https://api.github.com/users/ddunkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddunkin/subscriptions","organizations_url":"https://api.github.com/users/ddunkin/orgs","repos_url":"https://api.github.com/users/ddunkin/repos","events_url":"https://api.github.com/users/ddunkin/events{/privacy}","received_events_url":"https://api.github.com/users/ddunkin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ddunkin/Facility","description":"Tools and libraries for working with the Facility API Framework.","fork":true,"url":"https://api.github.com/repos/ddunkin/Facility","forks_url":"https://api.github.com/repos/ddunkin/Facility/forks","keys_url":"https://api.github.com/repos/ddunkin/Facility/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ddunkin/Facility/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ddunkin/Facility/teams","hooks_url":"https://api.github.com/repos/ddunkin/Facility/hooks","issue_events_url":"https://api.github.com/repos/ddunkin/Facility/issues/events{/number}","events_url":"https://api.github.com/repos/ddunkin/Facility/events","assignees_url":"https://api.github.com/repos/ddunkin/Facility/assignees{/user}","branches_url":"https://api.github.com/repos/ddunkin/Facility/branches{/branch}","tags_url":"https://api.github.com/repos/ddunkin/Facility/tags","blobs_url":"https://api.github.com/repos/ddunkin/Facility/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ddunkin/Facility/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ddunkin/Facility/git/refs{/sha}","trees_url":"https://api.github.com/repos/ddunkin/Facility/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ddunkin/Facility/statuses/{sha}","languages_url":"https://api.github.com/repos/ddunkin/Facility/languages","stargazers_url":"https://api.github.com/repos/ddunkin/Facility/stargazers","contributors_url":"https://api.github.com/repos/ddunkin/Facility/contributors","subscribers_url":"https://api.github.com/repos/ddunkin/Facility/subscribers","subscription_url":"https://api.github.com/repos/ddunkin/Facility/subscription","commits_url":"https://api.github.com/repos/ddunkin/Facility/commits{/sha}","git_commits_url":"https://api.github.com/repos/ddunkin/Facility/git/commits{/sha}","comments_url":"https://api.github.com/repos/ddunkin/Facility/comments{/number}","issue_comment_url":"https://api.github.com/repos/ddunkin/Facility/issues/comments{/number}","contents_url":"https://api.github.com/repos/ddunkin/Facility/contents/{+path}","compare_url":"https://api.github.com/repos/ddunkin/Facility/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ddunkin/Facility/merges","archive_url":"https://api.github.com/repos/ddunkin/Facility/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ddunkin/Facility/downloads","issues_url":"https://api.github.com/repos/ddunkin/Facility/issues{/number}","pulls_url":"https://api.github.com/repos/ddunkin/Facility/pulls{/number}","milestones_url":"https://api.github.com/repos/ddunkin/Facility/milestones{/number}","notifications_url":"https://api.github.com/repos/ddunkin/Facility/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ddunkin/Facility/labels{/name}","releases_url":"https://api.github.com/repos/ddunkin/Facility/releases{/id}","deployments_url":"https://api.github.com/repos/ddunkin/Facility/deployments","created_at":"2018-02-07T07:03:12Z","updated_at":"2018-02-07T07:03:15Z","pushed_at":"2018-02-10T03:54:52Z","git_url":"git://github.com/ddunkin/Facility.git","ssh_url":"git@github.com:ddunkin/Facility.git","clone_url":"https://github.com/ddunkin/Facility.git","svn_url":"https://github.com/ddunkin/Facility","homepage":"https://facilityapi.github.io/","size":294,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FacilityApi:master","ref":"master","sha":"d18fac177b066d817cf75c66fd8babbd865b8f8c","user":{"login":"FacilityApi","id":22828021,"avatar_url":"https://avatars2.githubusercontent.com/u/22828021?v=4","gravatar_id":"","url":"https://api.github.com/users/FacilityApi","html_url":"https://github.com/FacilityApi","followers_url":"https://api.github.com/users/FacilityApi/followers","following_url":"https://api.github.com/users/FacilityApi/following{/other_user}","gists_url":"https://api.github.com/users/FacilityApi/gists{/gist_id}","starred_url":"https://api.github.com/users/FacilityApi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FacilityApi/subscriptions","organizations_url":"https://api.github.com/users/FacilityApi/orgs","repos_url":"https://api.github.com/users/FacilityApi/repos","events_url":"https://api.github.com/users/FacilityApi/events{/privacy}","received_events_url":"https://api.github.com/users/FacilityApi/received_events","type":"Organization","site_admin":false},"repo":{"id":70863535,"name":"Facility","full_name":"FacilityApi/Facility","owner":{"login":"FacilityApi","id":22828021,"avatar_url":"https://avatars2.githubusercontent.com/u/22828021?v=4","gravatar_id":"","url":"https://api.github.com/users/FacilityApi","html_url":"https://github.com/FacilityApi","followers_url":"https://api.github.com/users/FacilityApi/followers","following_url":"https://api.github.com/users/FacilityApi/following{/other_user}","gists_url":"https://api.github.com/users/FacilityApi/gists{/gist_id}","starred_url":"https://api.github.com/users/FacilityApi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FacilityApi/subscriptions","organizations_url":"https://api.github.com/users/FacilityApi/orgs","repos_url":"https://api.github.com/users/FacilityApi/repos","events_url":"https://api.github.com/users/FacilityApi/events{/privacy}","received_events_url":"https://api.github.com/users/FacilityApi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FacilityApi/Facility","description":"Tools and libraries for working with the Facility API Framework.","fork":false,"url":"https://api.github.com/repos/FacilityApi/Facility","forks_url":"https://api.github.com/repos/FacilityApi/Facility/forks","keys_url":"https://api.github.com/repos/FacilityApi/Facility/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FacilityApi/Facility/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FacilityApi/Facility/teams","hooks_url":"https://api.github.com/repos/FacilityApi/Facility/hooks","issue_events_url":"https://api.github.com/repos/FacilityApi/Facility/issues/events{/number}","events_url":"https://api.github.com/repos/FacilityApi/Facility/events","assignees_url":"https://api.github.com/repos/FacilityApi/Facility/assignees{/user}","branches_url":"https://api.github.com/repos/FacilityApi/Facility/branches{/branch}","tags_url":"https://api.github.com/repos/FacilityApi/Facility/tags","blobs_url":"https://api.github.com/repos/FacilityApi/Facility/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FacilityApi/Facility/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FacilityApi/Facility/git/refs{/sha}","trees_url":"https://api.github.com/repos/FacilityApi/Facility/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FacilityApi/Facility/statuses/{sha}","languages_url":"https://api.github.com/repos/FacilityApi/Facility/languages","stargazers_url":"https://api.github.com/repos/FacilityApi/Facility/stargazers","contributors_url":"https://api.github.com/repos/FacilityApi/Facility/contributors","subscribers_url":"https://api.github.com/repos/FacilityApi/Facility/subscribers","subscription_url":"https://api.github.com/repos/FacilityApi/Facility/subscription","commits_url":"https://api.github.com/repos/FacilityApi/Facility/commits{/sha}","git_commits_url":"https://api.github.com/repos/FacilityApi/Facility/git/commits{/sha}","comments_url":"https://api.github.com/repos/FacilityApi/Facility/comments{/number}","issue_comment_url":"https://api.github.com/repos/FacilityApi/Facility/issues/comments{/number}","contents_url":"https://api.github.com/repos/FacilityApi/Facility/contents/{+path}","compare_url":"https://api.github.com/repos/FacilityApi/Facility/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FacilityApi/Facility/merges","archive_url":"https://api.github.com/repos/FacilityApi/Facility/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FacilityApi/Facility/downloads","issues_url":"https://api.github.com/repos/FacilityApi/Facility/issues{/number}","pulls_url":"https://api.github.com/repos/FacilityApi/Facility/pulls{/number}","milestones_url":"https://api.github.com/repos/FacilityApi/Facility/milestones{/number}","notifications_url":"https://api.github.com/repos/FacilityApi/Facility/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FacilityApi/Facility/labels{/name}","releases_url":"https://api.github.com/repos/FacilityApi/Facility/releases{/id}","deployments_url":"https://api.github.com/repos/FacilityApi/Facility/deployments","created_at":"2016-10-14T01:42:32Z","updated_at":"2017-10-23T23:16:51Z","pushed_at":"2018-02-10T03:54:52Z","git_url":"git://github.com/FacilityApi/Facility.git","ssh_url":"git@github.com:FacilityApi/Facility.git","clone_url":"https://github.com/FacilityApi/Facility.git","svn_url":"https://github.com/FacilityApi/Facility","homepage":"https://facilityapi.github.io/","size":268,"stargazers_count":2,"watchers_count":2,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":4,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FacilityApi/Facility/pulls/5"},"html":{"href":"https://github.com/FacilityApi/Facility/pull/5"},"issue":{"href":"https://api.github.com/repos/FacilityApi/Facility/issues/5"},"comments":{"href":"https://api.github.com/repos/FacilityApi/Facility/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/FacilityApi/Facility/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/FacilityApi/Facility/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FacilityApi/Facility/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/FacilityApi/Facility/statuses/182d3b3785f24c57f85e9bb88d8706ea48a1523b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ejball"}}