{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/1336","repository_url":"https://api.github.com/repos/kubernetes-incubator/cri-o","labels_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/1336/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/1336/comments","events_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/1336/events","html_url":"https://github.com/kubernetes-incubator/cri-o/pull/1336","id":297206450,"number":1336,"title":"Add extra info to verbose requests to PodSandboxStatus","user":{"login":"agonzalezro","id":205176,"avatar_url":"https://avatars2.githubusercontent.com/u/205176?v=4","gravatar_id":"","url":"https://api.github.com/users/agonzalezro","html_url":"https://github.com/agonzalezro","followers_url":"https://api.github.com/users/agonzalezro/followers","following_url":"https://api.github.com/users/agonzalezro/following{/other_user}","gists_url":"https://api.github.com/users/agonzalezro/gists{/gist_id}","starred_url":"https://api.github.com/users/agonzalezro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agonzalezro/subscriptions","organizations_url":"https://api.github.com/users/agonzalezro/orgs","repos_url":"https://api.github.com/users/agonzalezro/repos","events_url":"https://api.github.com/users/agonzalezro/events{/privacy}","received_events_url":"https://api.github.com/users/agonzalezro/received_events","type":"User","site_admin":false},"labels":[{"id":484626496,"url":"https://api.github.com/repos/kubernetes-incubator/cri-o/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"ededed","default":false},{"id":676478956,"url":"https://api.github.com/repos/kubernetes-incubator/cri-o/labels/size/L","name":"size/L","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":19,"created_at":"2018-02-14T18:54:42Z","updated_at":"2018-03-08T12:34:16Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/1336","html_url":"https://github.com/kubernetes-incubator/cri-o/pull/1336","diff_url":"https://github.com/kubernetes-incubator/cri-o/pull/1336.diff","patch_url":"https://github.com/kubernetes-incubator/cri-o/pull/1336.patch"},"body":"**What I did**\r\n- I added version info in a JSON object to [this response](https://github.com/kubernetes/kubernetes/blob/c6ddc749e85f4281628f366d65cf924c22d6cd99/pkg/kubelet/apis/cri/v1alpha1/runtime/api.proto#L391) when [verbose is set to true here](https://github.com/kubernetes/kubernetes/blob/c6ddc749e85f4281628f366d65cf924c22d6cd99/pkg/kubelet/apis/cri/v1alpha1/runtime/api.proto#L335).\r\n\r\n**How I did it**\r\n- I added some tests to cover the functionality before changing it, these tests include some fixture that maybe could be good to move to some other place.\r\n\r\n**How to verify it**\r\n- The tests should be enough, but if that grpc endpoing can be easilly called it should return the version info in a JSON object.\r\nIf PodSandboxStatusRequest.Verbose is true now we are returning the cri-o\r\nversion in a JSON object for debug purposes. In the future extra information\r\n(to be defined) should be added to the response\r\n\r\n**Description for the changelog**\r\n- Add extra info to verbose requests to PodSandboxStatus\r\n\r\n**Extra notes**\r\n- We should probably add more info to that endpoint, but I don't know what should be shown there.\r\n- I know that adding an extra vendored dependency could be painful in a big project, but I strongly recommend this: https://github.com/stretchr/testify to don't duplicate asserts logic.\r\n- As I previously mentioned, some of the fixtures I added could be helpful in some other place (or maybe there are already there and I didn't know it)."},"comment":{"url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/comments/371474430","html_url":"https://github.com/kubernetes-incubator/cri-o/pull/1336#issuecomment-371474430","issue_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/1336","id":371474430,"user":{"login":"rhatdan","id":2000835,"avatar_url":"https://avatars3.githubusercontent.com/u/2000835?v=4","gravatar_id":"","url":"https://api.github.com/users/rhatdan","html_url":"https://github.com/rhatdan","followers_url":"https://api.github.com/users/rhatdan/followers","following_url":"https://api.github.com/users/rhatdan/following{/other_user}","gists_url":"https://api.github.com/users/rhatdan/gists{/gist_id}","starred_url":"https://api.github.com/users/rhatdan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhatdan/subscriptions","organizations_url":"https://api.github.com/users/rhatdan/orgs","repos_url":"https://api.github.com/users/rhatdan/repos","events_url":"https://api.github.com/users/rhatdan/events{/privacy}","received_events_url":"https://api.github.com/users/rhatdan/received_events","type":"User","site_admin":false},"created_at":"2018-03-08T12:34:16Z","updated_at":"2018-03-08T12:34:16Z","author_association":"CONTRIBUTOR","body":"Most likely the same issue we have been seeing on RHEL,  There seems to be a race condition bug in the kernel.  There is an issue talking about it.\r\n\r\n/test integration_rhel"}}
{"actor":{"display_login":"rhatdan"}}