{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/TypeScript/issues/24829","repository_url":"https://api.github.com/repos/Microsoft/TypeScript","labels_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/24829/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/24829/comments","events_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/24829/events","html_url":"https://github.com/Microsoft/TypeScript/issues/24829","id":330899157,"node_id":"MDU6SXNzdWUzMzA4OTkxNTc=","number":24829,"title":"TypeScript 2.9.x incorrectly emits relative imports for symbolically linked dependencies (lerna)","user":{"login":"raymondfeng","id":540892,"node_id":"MDQ6VXNlcjU0MDg5Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/540892?v=4","gravatar_id":"","url":"https://api.github.com/users/raymondfeng","html_url":"https://github.com/raymondfeng","followers_url":"https://api.github.com/users/raymondfeng/followers","following_url":"https://api.github.com/users/raymondfeng/following{/other_user}","gists_url":"https://api.github.com/users/raymondfeng/gists{/gist_id}","starred_url":"https://api.github.com/users/raymondfeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raymondfeng/subscriptions","organizations_url":"https://api.github.com/users/raymondfeng/orgs","repos_url":"https://api.github.com/users/raymondfeng/repos","events_url":"https://api.github.com/users/raymondfeng/events{/privacy}","received_events_url":"https://api.github.com/users/raymondfeng/received_events","type":"User","site_admin":false},"labels":[{"id":113970366,"node_id":"MDU6TGFiZWwxMTM5NzAzNjY=","url":"https://api.github.com/repos/Microsoft/TypeScript/labels/Bug","name":"Bug","color":"e11d21","default":false},{"id":670961382,"node_id":"MDU6TGFiZWw2NzA5NjEzODI=","url":"https://api.github.com/repos/Microsoft/TypeScript/labels/Domain:%20Declaration%20Emit","name":"Domain: Declaration Emit","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":{"login":"weswigham","id":2932786,"node_id":"MDQ6VXNlcjI5MzI3ODY=","avatar_url":"https://avatars3.githubusercontent.com/u/2932786?v=4","gravatar_id":"","url":"https://api.github.com/users/weswigham","html_url":"https://github.com/weswigham","followers_url":"https://api.github.com/users/weswigham/followers","following_url":"https://api.github.com/users/weswigham/following{/other_user}","gists_url":"https://api.github.com/users/weswigham/gists{/gist_id}","starred_url":"https://api.github.com/users/weswigham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weswigham/subscriptions","organizations_url":"https://api.github.com/users/weswigham/orgs","repos_url":"https://api.github.com/users/weswigham/repos","events_url":"https://api.github.com/users/weswigham/events{/privacy}","received_events_url":"https://api.github.com/users/weswigham/received_events","type":"User","site_admin":false},"assignees":[{"login":"weswigham","id":2932786,"node_id":"MDQ6VXNlcjI5MzI3ODY=","avatar_url":"https://avatars3.githubusercontent.com/u/2932786?v=4","gravatar_id":"","url":"https://api.github.com/users/weswigham","html_url":"https://github.com/weswigham","followers_url":"https://api.github.com/users/weswigham/followers","following_url":"https://api.github.com/users/weswigham/following{/other_user}","gists_url":"https://api.github.com/users/weswigham/gists{/gist_id}","starred_url":"https://api.github.com/users/weswigham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weswigham/subscriptions","organizations_url":"https://api.github.com/users/weswigham/orgs","repos_url":"https://api.github.com/users/weswigham/repos","events_url":"https://api.github.com/users/weswigham/events{/privacy}","received_events_url":"https://api.github.com/users/weswigham/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Microsoft/TypeScript/milestones/73","html_url":"https://github.com/Microsoft/TypeScript/milestone/73","labels_url":"https://api.github.com/repos/Microsoft/TypeScript/milestones/73/labels","id":3358918,"node_id":"MDk6TWlsZXN0b25lMzM1ODkxOA==","number":73,"title":"TypeScript 2.9.2","description":"","creator":{"login":"mhegazy","id":8000722,"node_id":"MDQ6VXNlcjgwMDA3MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/8000722?v=4","gravatar_id":"","url":"https://api.github.com/users/mhegazy","html_url":"https://github.com/mhegazy","followers_url":"https://api.github.com/users/mhegazy/followers","following_url":"https://api.github.com/users/mhegazy/following{/other_user}","gists_url":"https://api.github.com/users/mhegazy/gists{/gist_id}","starred_url":"https://api.github.com/users/mhegazy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhegazy/subscriptions","organizations_url":"https://api.github.com/users/mhegazy/orgs","repos_url":"https://api.github.com/users/mhegazy/repos","events_url":"https://api.github.com/users/mhegazy/events{/privacy}","received_events_url":"https://api.github.com/users/mhegazy/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":36,"state":"open","created_at":"2018-05-19T19:28:59Z","updated_at":"2018-06-11T17:33:45Z","due_on":"2018-06-13T07:00:00Z","closed_at":null},"comments":1,"created_at":"2018-06-09T16:08:47Z","updated_at":"2018-06-11T17:33:58Z","closed_at":null,"author_association":"NONE","body":"<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨\r\n\r\nHalf of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common \"Bugs\" That Aren't Bugs section!\r\n\r\nPlease help us by doing the following steps before logging an issue:\r\n  * Search: https://github.com/Microsoft/TypeScript/search?type=Issues\r\n  * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ\r\n\r\nPlease fill in the *entire* template below.\r\n-->\r\n\r\n<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->\r\n**TypeScript Version:**  2.9.x\r\n\r\n2.8.x works fine. It starts to break with TypeScript 2.9.x. It's not fixed by the latest build (typescript@next).\r\n\r\n<!-- Search terms you tried before logging this (so others can find this issue more easily) -->\r\n**Search Terms:** \r\n\r\nimport symbolic link lerna\r\n\r\n**Code**\r\n\r\nhttps://github.com/strongloop/loopback-next/blob/master/packages/core/src/keys.ts\r\n\r\n**keys.ts**\r\n```ts\r\nimport {Application, ControllerClass} from './application';\r\n\r\nexport const CONTROLLER_CLASS = BindingKey.create<ControllerClass>(\r\n    'controller.current.ctor',\r\n  );\r\n```\r\nPlease note the `ControllerClass` is a type alias re-exported from another module `@loopback/next` which is symbolically linked to `@loopback/core` by `lerna`.\r\n\r\n**application.ts**\r\n```ts\r\nimport {Context, Binding, BindingScope, Constructor} from '@loopback/context';\r\nexport type ControllerClass = Constructor<any>;\r\n```\r\n\r\n**Expected behavior:**\r\n\r\nTypeScript 2.8.x style:\r\n**keys.d.ts** (emitted by tsc)\r\n```ts\r\nconst CONTROLLER_CLASS: BindingKey<new (...args: any[]) => any>;\r\n```\r\nOr\r\n\r\n```ts\r\nimport {Constructor} from '@loopback/context';\r\n\r\nconst CONTROLLER_CLASS: BindingKey<Constructor<any>>;\r\n```\r\n\r\n**Actual behavior:**\r\n\r\n```ts\r\nconst CONTROLLER_CLASS: BindingKey<import(\"../../context/src/value-promise\").Constructor<any>>;\r\n```\r\n\r\nPlease note the relative link is only valid at development time. Once it's published as a npm module, the `import` cannot be resolved.\r\n\r\n**Playground Link:** <!-- A link to a TypeScript Playground \"Share\" link which demonstrates this behavior --> \r\n\r\n**Related Issues:** <!-- Did you find other bugs that looked similar? -->\r\n\r\nhttps://github.com/strongloop/loopback-next/issues/1405"},"comment":{"url":"https://api.github.com/repos/Microsoft/TypeScript/issues/comments/396323052","html_url":"https://github.com/Microsoft/TypeScript/issues/24829#issuecomment-396323052","issue_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/24829","id":396323052,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjMyMzA1Mg==","user":{"login":"mhegazy","id":8000722,"node_id":"MDQ6VXNlcjgwMDA3MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/8000722?v=4","gravatar_id":"","url":"https://api.github.com/users/mhegazy","html_url":"https://github.com/mhegazy","followers_url":"https://api.github.com/users/mhegazy/followers","following_url":"https://api.github.com/users/mhegazy/following{/other_user}","gists_url":"https://api.github.com/users/mhegazy/gists{/gist_id}","starred_url":"https://api.github.com/users/mhegazy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhegazy/subscriptions","organizations_url":"https://api.github.com/users/mhegazy/orgs","repos_url":"https://api.github.com/users/mhegazy/repos","events_url":"https://api.github.com/users/mhegazy/events{/privacy}","received_events_url":"https://api.github.com/users/mhegazy/received_events","type":"User","site_admin":false},"created_at":"2018-06-11T17:33:58Z","updated_at":"2018-06-11T17:33:58Z","author_association":"CONTRIBUTOR","body":"@weswigham can you take a look"}}
{"actor":{"display_login":"mhegazy"}}