{"action":"created","issue":{"url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/6196","repository_url":"https://api.github.com/repos/SatelliteQE/robottelo","labels_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/6196/labels{/name}","comments_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/6196/comments","events_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/6196/events","html_url":"https://github.com/SatelliteQE/robottelo/pull/6196","id":350707250,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NDg3NTc2","number":6196,"title":"[6.4] UI tests for some host actions and create with parameters","user":{"login":"ldjebran","id":131553,"node_id":"MDQ6VXNlcjEzMTU1Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/131553?v=4","gravatar_id":"","url":"https://api.github.com/users/ldjebran","html_url":"https://github.com/ldjebran","followers_url":"https://api.github.com/users/ldjebran/followers","following_url":"https://api.github.com/users/ldjebran/following{/other_user}","gists_url":"https://api.github.com/users/ldjebran/gists{/gist_id}","starred_url":"https://api.github.com/users/ldjebran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldjebran/subscriptions","organizations_url":"https://api.github.com/users/ldjebran/orgs","repos_url":"https://api.github.com/users/ldjebran/repos","events_url":"https://api.github.com/users/ldjebran/events{/privacy}","received_events_url":"https://api.github.com/users/ldjebran/received_events","type":"User","site_admin":false},"labels":[{"id":882222241,"node_id":"MDU6TGFiZWw4ODIyMjIyNDE=","url":"https://api.github.com/repos/SatelliteQE/robottelo/labels/6.4","name":"6.4","color":"efd3aa","default":false},{"id":67639907,"node_id":"MDU6TGFiZWw2NzYzOTkwNw==","url":"https://api.github.com/repos/SatelliteQE/robottelo/labels/UI","name":"UI","color":"0052cc","default":false},{"id":404622871,"node_id":"MDU6TGFiZWw0MDQ2MjI4NzE=","url":"https://api.github.com/repos/SatelliteQE/robottelo/labels/review","name":"review","color":"00ff00","default":false}],"state":"open","locked":false,"assignee":{"login":"ldjebran","id":131553,"node_id":"MDQ6VXNlcjEzMTU1Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/131553?v=4","gravatar_id":"","url":"https://api.github.com/users/ldjebran","html_url":"https://github.com/ldjebran","followers_url":"https://api.github.com/users/ldjebran/followers","following_url":"https://api.github.com/users/ldjebran/following{/other_user}","gists_url":"https://api.github.com/users/ldjebran/gists{/gist_id}","starred_url":"https://api.github.com/users/ldjebran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldjebran/subscriptions","organizations_url":"https://api.github.com/users/ldjebran/orgs","repos_url":"https://api.github.com/users/ldjebran/repos","events_url":"https://api.github.com/users/ldjebran/events{/privacy}","received_events_url":"https://api.github.com/users/ldjebran/received_events","type":"User","site_admin":false},"assignees":[{"login":"ldjebran","id":131553,"node_id":"MDQ6VXNlcjEzMTU1Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/131553?v=4","gravatar_id":"","url":"https://api.github.com/users/ldjebran","html_url":"https://github.com/ldjebran","followers_url":"https://api.github.com/users/ldjebran/followers","following_url":"https://api.github.com/users/ldjebran/following{/other_user}","gists_url":"https://api.github.com/users/ldjebran/gists{/gist_id}","starred_url":"https://api.github.com/users/ldjebran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldjebran/subscriptions","organizations_url":"https://api.github.com/users/ldjebran/orgs","repos_url":"https://api.github.com/users/ldjebran/repos","events_url":"https://api.github.com/users/ldjebran/events{/privacy}","received_events_url":"https://api.github.com/users/ldjebran/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2018-08-15T07:04:34Z","updated_at":"2018-09-04T08:44:45Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/6196","html_url":"https://github.com/SatelliteQE/robottelo/pull/6196","diff_url":"https://github.com/SatelliteQE/robottelo/pull/6196.diff","patch_url":"https://github.com/SatelliteQE/robottelo/pull/6196.patch"},"body":"Depend on https://github.com/SatelliteQE/airgun/pull/179\r\n\r\n```bash\r\n(robottelo) dlezz@dlezz:~/projects/robottelo-fork$ pytest -v tests/foreman/ui_airgun/test_host.py\r\n============================================ test session starts =============================================\r\nplatform linux -- Python 3.6.6, pytest-3.6.1, py-1.5.4, pluggy-0.6.0 -- /home/dlezz/.pyenv/versions/3.6.6/envs/robottelo/bin/python\r\ncachedir: .pytest_cache\r\nshared_function enabled - ON - scope: ffff - storage: file\r\nrootdir: /home/dlezz/projects/robottelo-fork, inifile:\r\nplugins: wait-for-1.0.9, xdist-1.22.5, services-1.2.1, mock-1.6.3, forked-0.2, cov-2.5.1\r\ncollecting 9 items                                                                                           2018-08-15 09:41:43 - conftest - DEBUG - BZ deselect is disabled in settings\r\n\r\ncollected 9 items                                                                                            \r\n\r\ntests/foreman/ui_airgun/test_host.py::test_positive_create PASSED                                      [ 11%]\r\ntests/foreman/ui_airgun/test_host.py::test_positive_read_from_details_page PASSED                      [ 22%]\r\ntests/foreman/ui_airgun/test_host.py::test_positive_read_from_edit_page PASSED                         [ 33%]\r\ntests/foreman/ui_airgun/test_host.py::test_positive_delete PASSED                                      [ 44%]\r\ntests/foreman/ui_airgun/test_host.py::test_positive_inherit_puppet_env_from_host_group_when_action PASSED [ 55%]\r\ntests/foreman/ui_airgun/test_host.py::test_positive_create_host_with_parameters PASSED                 [ 66%]\r\ntests/foreman/ui_airgun/test_host.py::test_positive_assign_organization PASSED                         [ 77%]\r\ntests/foreman/ui_airgun/test_host.py::test_positive_assign_location PASSED                             [ 88%]\r\ntests/foreman/ui_airgun/test_host.py::test_positive_assign_compliance_policy PASSED                    [100%]\r\n\r\n========================================= 9 passed in 546.75 seconds =========================================\r\n```"},"comment":{"url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/comments/418289261","html_url":"https://github.com/SatelliteQE/robottelo/pull/6196#issuecomment-418289261","issue_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/6196","id":418289261,"node_id":"MDEyOklzc3VlQ29tbWVudDQxODI4OTI2MQ==","user":{"login":"rplevka","id":11773362,"node_id":"MDQ6VXNlcjExNzczMzYy","avatar_url":"https://avatars0.githubusercontent.com/u/11773362?v=4","gravatar_id":"","url":"https://api.github.com/users/rplevka","html_url":"https://github.com/rplevka","followers_url":"https://api.github.com/users/rplevka/followers","following_url":"https://api.github.com/users/rplevka/following{/other_user}","gists_url":"https://api.github.com/users/rplevka/gists{/gist_id}","starred_url":"https://api.github.com/users/rplevka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rplevka/subscriptions","organizations_url":"https://api.github.com/users/rplevka/orgs","repos_url":"https://api.github.com/users/rplevka/repos","events_url":"https://api.github.com/users/rplevka/events{/privacy}","received_events_url":"https://api.github.com/users/rplevka/received_events","type":"User","site_admin":false},"created_at":"2018-09-04T08:44:45Z","updated_at":"2018-09-04T08:44:45Z","author_association":"MEMBER","body":"is it really worth spending 15 minutes on these 9 tests?\r\nDon't take me wrong, the code looks good and everything,...but :)\r\n\r\nlet's take these two:\r\n`tests/foreman/ui_airgun/test_host.py::test_positive_assign_organization`\r\n`tests/foreman/ui_airgun/test_host.py::test_positive_assign_location`\r\n\r\ndoes it really add so much value by treating these as individual tests? We create everything from a scratch for them and run separate new UI session for each.\r\nWhy not merge them together, call it let's say `test_positive_assign_taxonomies`\r\nand do both assignments in a single go?\r\nThe test will fail if assigning loc assignment fails but org passes? - so what? Even if it fails, one still need to go in there and see what is going on, and it takes him like 2 seconds to figure out what works and what does not.\r\n\r\nMy point here is - why spend too much resources just to test the nitpicks?"}}
{"actor":{"display_login":"rplevka"}}