{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/177152188","pull_request_review_id":106976006,"id":177152188,"diff_hunk":"@@ -2,23 +2,20 @@\n <Project ToolsVersion=\"14.0\" DefaultTargets=\"Build\" xmlns=\"http://schemas.microsoft.com/developer/msbuild/2003\">\n   <Import Project=\"$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.props))\\dir.props\" />\n   <ItemGroup>\n+    <HarvestIncludePath Include=\"ref\\netstandard1.1;ref\\netstandard2.0\">\n+      <SupportedFramework>netcore45;netcoreapp1.0;wpa81;$(AllXamarinFrameworks)</SupportedFramework>\n+    </HarvestIncludePath>\n     <ProjectReference Include=\"..\\ref\\System.Buffers.csproj\">\n-      <SupportedFramework>net45;netcore45;netcoreapp1.0;wpa81;$(AllXamarinFrameworks)</SupportedFramework>\n+      <SupportedFramework>net45</SupportedFramework>\n     </ProjectReference>\n     <ProjectReference Include=\"..\\src\\System.Buffers.csproj\" />\n \n     <!-- this package is part of the implementation closure of NETStandard.Library\n          therefore it cannot reference NETStandard.Library -->\n     <SuppressMetaPackage Include=\"NETStandard.Library\" />\n \n-    <!-- Since UAP and .NETCoreApp are package based we still want to enable\n-         OOBing libraries that happen to overlap with their framework package.\n-         This avoids us having to lock the API in our NuGet packages just \n-         to match what shipped inbox: since we can provide a new library \n-         we can update it to add API without raising the netstandard version. -->\n-    <ValidatePackageSuppression Include=\"TreatAsOutOfBox\">\n-      <Value>.NETCoreApp;UAP</Value>\n-    </ValidatePackageSuppression>\n+    <InboxOnTargetFramework Include=\"netcoreapp2.0\" />","path":"src/System.Buffers/pkg/System.Buffers.pkgproj","position":25,"original_position":25,"commit_id":"b3338dd433860a06780042b603be1339bcf2685e","original_commit_id":"b3338dd433860a06780042b603be1339bcf2685e","user":{"login":"joperezr","id":13854455,"avatar_url":"https://avatars3.githubusercontent.com/u/13854455?v=4","gravatar_id":"","url":"https://api.github.com/users/joperezr","html_url":"https://github.com/joperezr","followers_url":"https://api.github.com/users/joperezr/followers","following_url":"https://api.github.com/users/joperezr/following{/other_user}","gists_url":"https://api.github.com/users/joperezr/gists{/gist_id}","starred_url":"https://api.github.com/users/joperezr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joperezr/subscriptions","organizations_url":"https://api.github.com/users/joperezr/orgs","repos_url":"https://api.github.com/users/joperezr/repos","events_url":"https://api.github.com/users/joperezr/events{/privacy}","received_events_url":"https://api.github.com/users/joperezr/received_events","type":"User","site_admin":false},"body":"Why did we suddenly decided to freeze the API? I recently chatted with @ericstj about this and we intentionally still wanted to keep this particular one OOB. What changed?","created_at":"2018-03-26T16:21:14Z","updated_at":"2018-03-26T16:21:14Z","html_url":"https://github.com/dotnet/corefx/pull/28428#discussion_r177152188","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/28428","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/177152188"},"html":{"href":"https://github.com/dotnet/corefx/pull/28428#discussion_r177152188"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/28428"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/28428","id":177177925,"html_url":"https://github.com/dotnet/corefx/pull/28428","diff_url":"https://github.com/dotnet/corefx/pull/28428.diff","patch_url":"https://github.com/dotnet/corefx/pull/28428.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/28428","number":28428,"state":"open","locked":false,"title":"Fix compat pack dependencies to be live pre-release and harvest System.Buffers ref to previously shipped version","user":{"login":"safern","id":22899328,"avatar_url":"https://avatars1.githubusercontent.com/u/22899328?v=4","gravatar_id":"","url":"https://api.github.com/users/safern","html_url":"https://github.com/safern","followers_url":"https://api.github.com/users/safern/followers","following_url":"https://api.github.com/users/safern/following{/other_user}","gists_url":"https://api.github.com/users/safern/gists{/gist_id}","starred_url":"https://api.github.com/users/safern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/safern/subscriptions","organizations_url":"https://api.github.com/users/safern/orgs","repos_url":"https://api.github.com/users/safern/repos","events_url":"https://api.github.com/users/safern/events{/privacy}","received_events_url":"https://api.github.com/users/safern/received_events","type":"User","site_admin":false},"body":"Fixes: https://github.com/dotnet/corefx/issues/28326\r\n\r\nSystem.Security.Cryptography.Cng pre-release needs to be included in the compat pack since System.Security.Cryptography.Xml is now taking a dependency on it and we haven't shipped it stable, so if we depend on the Cng stable version it will fail because there will be a downgrade on that dependency.\r\n\r\nAlso this freezes the implementation for netstandard2.0 for System.Buffers to not take a reference to System.Private.CoreLib in an OOB package.\r\n\r\nAlso I'm updating the compat pack publish script to be able to generate the netcoreapp2.1 ApiCatalog layout from the live everyday build.\r\n\r\ncc: @ericstj @weshaggard @danmosemsft @joperezr @terrajobst ","created_at":"2018-03-23T20:35:09Z","updated_at":"2018-03-26T16:21:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a4dbc6f17e953ddf66b755633db52ec47611ae7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/28428/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/28428/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/28428/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/b3338dd433860a06780042b603be1339bcf2685e","head":{"label":"safern:FixCompatPackDependencies","ref":"FixCompatPackDependencies","sha":"b3338dd433860a06780042b603be1339bcf2685e","user":{"login":"safern","id":22899328,"avatar_url":"https://avatars1.githubusercontent.com/u/22899328?v=4","gravatar_id":"","url":"https://api.github.com/users/safern","html_url":"https://github.com/safern","followers_url":"https://api.github.com/users/safern/followers","following_url":"https://api.github.com/users/safern/following{/other_user}","gists_url":"https://api.github.com/users/safern/gists{/gist_id}","starred_url":"https://api.github.com/users/safern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/safern/subscriptions","organizations_url":"https://api.github.com/users/safern/orgs","repos_url":"https://api.github.com/users/safern/repos","events_url":"https://api.github.com/users/safern/events{/privacy}","received_events_url":"https://api.github.com/users/safern/received_events","type":"User","site_admin":false},"repo":{"id":71193251,"name":"corefx","full_name":"safern/corefx","owner":{"login":"safern","id":22899328,"avatar_url":"https://avatars1.githubusercontent.com/u/22899328?v=4","gravatar_id":"","url":"https://api.github.com/users/safern","html_url":"https://github.com/safern","followers_url":"https://api.github.com/users/safern/followers","following_url":"https://api.github.com/users/safern/following{/other_user}","gists_url":"https://api.github.com/users/safern/gists{/gist_id}","starred_url":"https://api.github.com/users/safern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/safern/subscriptions","organizations_url":"https://api.github.com/users/safern/orgs","repos_url":"https://api.github.com/users/safern/repos","events_url":"https://api.github.com/users/safern/events{/privacy}","received_events_url":"https://api.github.com/users/safern/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/safern/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/safern/corefx","forks_url":"https://api.github.com/repos/safern/corefx/forks","keys_url":"https://api.github.com/repos/safern/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/safern/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/safern/corefx/teams","hooks_url":"https://api.github.com/repos/safern/corefx/hooks","issue_events_url":"https://api.github.com/repos/safern/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/safern/corefx/events","assignees_url":"https://api.github.com/repos/safern/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/safern/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/safern/corefx/tags","blobs_url":"https://api.github.com/repos/safern/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/safern/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/safern/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/safern/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/safern/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/safern/corefx/languages","stargazers_url":"https://api.github.com/repos/safern/corefx/stargazers","contributors_url":"https://api.github.com/repos/safern/corefx/contributors","subscribers_url":"https://api.github.com/repos/safern/corefx/subscribers","subscription_url":"https://api.github.com/repos/safern/corefx/subscription","commits_url":"https://api.github.com/repos/safern/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/safern/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/safern/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/safern/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/safern/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/safern/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/safern/corefx/merges","archive_url":"https://api.github.com/repos/safern/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/safern/corefx/downloads","issues_url":"https://api.github.com/repos/safern/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/safern/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/safern/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/safern/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/safern/corefx/labels{/name}","releases_url":"https://api.github.com/repos/safern/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/safern/corefx/deployments","created_at":"2016-10-18T00:37:15Z","updated_at":"2016-10-18T00:37:45Z","pushed_at":"2018-03-23T20:05:40Z","git_url":"git://github.com/safern/corefx.git","ssh_url":"git@github.com:safern/corefx.git","clone_url":"https://github.com/safern/corefx.git","svn_url":"https://github.com/safern/corefx","homepage":"https://docs.microsoft.com/dotnet/","size":172838,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"6f85d0d5010cc0666d16cd483229be18301967d2","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2018-03-26T15:19:38Z","pushed_at":"2018-03-26T16:04:36Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://github.com/dotnet/core","size":175467,"stargazers_count":13616,"watchers_count":13616,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3887,"mirror_url":null,"archived":false,"open_issues_count":2213,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3887,"open_issues":2213,"watchers":13616,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/28428"},"html":{"href":"https://github.com/dotnet/corefx/pull/28428"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/28428"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/28428/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/28428/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/28428/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/b3338dd433860a06780042b603be1339bcf2685e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"joperezr"}}