{"action":"created","issue":{"url":"https://api.github.com/repos/Siderus/Orion/issues/74","repository_url":"https://api.github.com/repos/Siderus/Orion","labels_url":"https://api.github.com/repos/Siderus/Orion/issues/74/labels{/name}","comments_url":"https://api.github.com/repos/Siderus/Orion/issues/74/comments","events_url":"https://api.github.com/repos/Siderus/Orion/issues/74/events","html_url":"https://github.com/Siderus/Orion/pull/74","id":310325356,"number":74,"title":"Add download-ipfs-binary script","user":{"login":"0x6431346e","id":26041347,"avatar_url":"https://avatars1.githubusercontent.com/u/26041347?v=4","gravatar_id":"","url":"https://api.github.com/users/0x6431346e","html_url":"https://github.com/0x6431346e","followers_url":"https://api.github.com/users/0x6431346e/followers","following_url":"https://api.github.com/users/0x6431346e/following{/other_user}","gists_url":"https://api.github.com/users/0x6431346e/gists{/gist_id}","starred_url":"https://api.github.com/users/0x6431346e/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0x6431346e/subscriptions","organizations_url":"https://api.github.com/users/0x6431346e/orgs","repos_url":"https://api.github.com/users/0x6431346e/repos","events_url":"https://api.github.com/users/0x6431346e/events{/privacy}","received_events_url":"https://api.github.com/users/0x6431346e/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-04-01T13:55:22Z","updated_at":"2018-04-03T09:31:11Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Siderus/Orion/pulls/74","html_url":"https://github.com/Siderus/Orion/pull/74","diff_url":"https://github.com/Siderus/Orion/pull/74.diff","patch_url":"https://github.com/Siderus/Orion/pull/74.patch"},"body":"Not ready to be merged, needs to be tested on windows, but please review/comment"},"comment":{"url":"https://api.github.com/repos/Siderus/Orion/issues/comments/378188494","html_url":"https://github.com/Siderus/Orion/pull/74#issuecomment-378188494","issue_url":"https://api.github.com/repos/Siderus/Orion/issues/74","id":378188494,"user":{"login":"koalalorenzo","id":33528,"avatar_url":"https://avatars1.githubusercontent.com/u/33528?v=4","gravatar_id":"","url":"https://api.github.com/users/koalalorenzo","html_url":"https://github.com/koalalorenzo","followers_url":"https://api.github.com/users/koalalorenzo/followers","following_url":"https://api.github.com/users/koalalorenzo/following{/other_user}","gists_url":"https://api.github.com/users/koalalorenzo/gists{/gist_id}","starred_url":"https://api.github.com/users/koalalorenzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koalalorenzo/subscriptions","organizations_url":"https://api.github.com/users/koalalorenzo/orgs","repos_url":"https://api.github.com/users/koalalorenzo/repos","events_url":"https://api.github.com/users/koalalorenzo/events{/privacy}","received_events_url":"https://api.github.com/users/koalalorenzo/received_events","type":"User","site_admin":false},"created_at":"2018-04-03T09:31:11Z","updated_at":"2018-04-03T09:31:11Z","author_association":"OWNER","body":"To me it seems that we have to figure out the correct binary path. The only setup that was correctly unpacking the binary from asar was:\r\n\r\n```\r\n  \"build\": {\r\n    \"asarUnpack\": [\r\n      \"go-ipfs/ipfs\"\r\n    ],\r\n}\r\n```\r\n\r\nBut the binary path may change for win, linux and macOS.\r\nI would suggest to disable temporary asar. It works!\r\n\r\n```\r\n  \"build\": {\r\n    \"asar\": false,\r\n}\r\n```\r\n\r\nThat is correctly packing the app (at least for macOS) with the binary path as the one specified. This will allow to merge the project.\r\n\r\nIn any case the IPFS binary adds 35MB to the final packed app (at least for macOS), raising it to ~216MB."}}
{"actor":{"display_login":"koalalorenzo"}}