{"action":"created","issue":{"url":"https://api.github.com/repos/oasis-open/cti-python-stix2/issues/113","repository_url":"https://api.github.com/repos/oasis-open/cti-python-stix2","labels_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/issues/113/labels{/name}","comments_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/issues/113/comments","events_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/issues/113/events","html_url":"https://github.com/oasis-open/cti-python-stix2/issues/113","id":275402287,"number":113,"title":"TAXIICollectionSource should capture HTTP errors","user":{"login":"gtback","id":1045796,"avatar_url":"https://avatars1.githubusercontent.com/u/1045796?v=4","gravatar_id":"","url":"https://api.github.com/users/gtback","html_url":"https://github.com/gtback","followers_url":"https://api.github.com/users/gtback/followers","following_url":"https://api.github.com/users/gtback/following{/other_user}","gists_url":"https://api.github.com/users/gtback/gists{/gist_id}","starred_url":"https://api.github.com/users/gtback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtback/subscriptions","organizations_url":"https://api.github.com/users/gtback/orgs","repos_url":"https://api.github.com/users/gtback/repos","events_url":"https://api.github.com/users/gtback/events{/privacy}","received_events_url":"https://api.github.com/users/gtback/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"mbastian1135","id":7109639,"avatar_url":"https://avatars0.githubusercontent.com/u/7109639?v=4","gravatar_id":"","url":"https://api.github.com/users/mbastian1135","html_url":"https://github.com/mbastian1135","followers_url":"https://api.github.com/users/mbastian1135/followers","following_url":"https://api.github.com/users/mbastian1135/following{/other_user}","gists_url":"https://api.github.com/users/mbastian1135/gists{/gist_id}","starred_url":"https://api.github.com/users/mbastian1135/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbastian1135/subscriptions","organizations_url":"https://api.github.com/users/mbastian1135/orgs","repos_url":"https://api.github.com/users/mbastian1135/repos","events_url":"https://api.github.com/users/mbastian1135/events{/privacy}","received_events_url":"https://api.github.com/users/mbastian1135/received_events","type":"User","site_admin":false},"assignees":[{"login":"mbastian1135","id":7109639,"avatar_url":"https://avatars0.githubusercontent.com/u/7109639?v=4","gravatar_id":"","url":"https://api.github.com/users/mbastian1135","html_url":"https://github.com/mbastian1135","followers_url":"https://api.github.com/users/mbastian1135/followers","following_url":"https://api.github.com/users/mbastian1135/following{/other_user}","gists_url":"https://api.github.com/users/mbastian1135/gists{/gist_id}","starred_url":"https://api.github.com/users/mbastian1135/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbastian1135/subscriptions","organizations_url":"https://api.github.com/users/mbastian1135/orgs","repos_url":"https://api.github.com/users/mbastian1135/repos","events_url":"https://api.github.com/users/mbastian1135/events{/privacy}","received_events_url":"https://api.github.com/users/mbastian1135/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2017-11-20T15:49:23Z","updated_at":"2018-05-08T18:30:29Z","closed_at":null,"author_association":"MEMBER","body":"Wrap calls to `get_object` and `get_objects`, catch an HTTP 404 or other errors, and return `None` or an empty list as appropriate."},"comment":{"url":"https://api.github.com/repos/oasis-open/cti-python-stix2/issues/comments/387498565","html_url":"https://github.com/oasis-open/cti-python-stix2/issues/113#issuecomment-387498565","issue_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/issues/113","id":387498565,"user":{"login":"mbastian1135","id":7109639,"avatar_url":"https://avatars0.githubusercontent.com/u/7109639?v=4","gravatar_id":"","url":"https://api.github.com/users/mbastian1135","html_url":"https://github.com/mbastian1135","followers_url":"https://api.github.com/users/mbastian1135/followers","following_url":"https://api.github.com/users/mbastian1135/following{/other_user}","gists_url":"https://api.github.com/users/mbastian1135/gists{/gist_id}","starred_url":"https://api.github.com/users/mbastian1135/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbastian1135/subscriptions","organizations_url":"https://api.github.com/users/mbastian1135/orgs","repos_url":"https://api.github.com/users/mbastian1135/repos","events_url":"https://api.github.com/users/mbastian1135/events{/privacy}","received_events_url":"https://api.github.com/users/mbastian1135/received_events","type":"User","site_admin":false},"created_at":"2018-05-08T18:30:29Z","updated_at":"2018-05-08T18:30:29Z","author_association":"CONTRIBUTOR","body":"So, summarizing:\r\n - get() | get_object() | /objects/<guid> -> return None on 404 bc either way user cannot get object\r\n - query()/all_version() | get_objects() | /objects -> return errors as exceptions, return [] if no results\r\n\r\n- @Greg, youre proposing to check the supplied collection instance to see if its valid? Shouldnt that be an initialization (or lazy) check within the TAXII Client, not in the DataSource.  If not, would calling Collection.refresh() (https://github.com/oasis-open/cti-taxii-client/blob/master/taxii2client/__init__.py#L432) suffice?\r\n "}}
{"actor":{"display_login":"mbastian1135"}}