{"action":"created","issue":{"url":"https://api.github.com/repos/macports/macports-ports/issues/2374","repository_url":"https://api.github.com/repos/macports/macports-ports","labels_url":"https://api.github.com/repos/macports/macports-ports/issues/2374/labels{/name}","comments_url":"https://api.github.com/repos/macports/macports-ports/issues/2374/comments","events_url":"https://api.github.com/repos/macports/macports-ports/issues/2374/events","html_url":"https://github.com/macports/macports-ports/pull/2374","id":349470525,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NTc2OTAx","number":2374,"title":"libvpx: Don't force use of clang-3.9","user":{"login":"ryandesign","id":429209,"node_id":"MDQ6VXNlcjQyOTIwOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/429209?v=4","gravatar_id":"","url":"https://api.github.com/users/ryandesign","html_url":"https://github.com/ryandesign","followers_url":"https://api.github.com/users/ryandesign/followers","following_url":"https://api.github.com/users/ryandesign/following{/other_user}","gists_url":"https://api.github.com/users/ryandesign/gists{/gist_id}","starred_url":"https://api.github.com/users/ryandesign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryandesign/subscriptions","organizations_url":"https://api.github.com/users/ryandesign/orgs","repos_url":"https://api.github.com/users/ryandesign/repos","events_url":"https://api.github.com/users/ryandesign/events{/privacy}","received_events_url":"https://api.github.com/users/ryandesign/received_events","type":"User","site_admin":false},"labels":[{"id":656296790,"node_id":"MDU6TGFiZWw2NTYyOTY3OTA=","url":"https://api.github.com/repos/macports/macports-ports/labels/by:%20member","name":"by: member","color":"c5def5","default":false},{"id":615645858,"node_id":"MDU6TGFiZWw2MTU2NDU4NTg=","url":"https://api.github.com/repos/macports/macports-ports/labels/maintainer:%20open","name":"maintainer: open","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":{"login":"dbevans","id":8901526,"node_id":"MDQ6VXNlcjg5MDE1MjY=","avatar_url":"https://avatars2.githubusercontent.com/u/8901526?v=4","gravatar_id":"","url":"https://api.github.com/users/dbevans","html_url":"https://github.com/dbevans","followers_url":"https://api.github.com/users/dbevans/followers","following_url":"https://api.github.com/users/dbevans/following{/other_user}","gists_url":"https://api.github.com/users/dbevans/gists{/gist_id}","starred_url":"https://api.github.com/users/dbevans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbevans/subscriptions","organizations_url":"https://api.github.com/users/dbevans/orgs","repos_url":"https://api.github.com/users/dbevans/repos","events_url":"https://api.github.com/users/dbevans/events{/privacy}","received_events_url":"https://api.github.com/users/dbevans/received_events","type":"User","site_admin":false},"assignees":[{"login":"dbevans","id":8901526,"node_id":"MDQ6VXNlcjg5MDE1MjY=","avatar_url":"https://avatars2.githubusercontent.com/u/8901526?v=4","gravatar_id":"","url":"https://api.github.com/users/dbevans","html_url":"https://github.com/dbevans","followers_url":"https://api.github.com/users/dbevans/followers","following_url":"https://api.github.com/users/dbevans/following{/other_user}","gists_url":"https://api.github.com/users/dbevans/gists{/gist_id}","starred_url":"https://api.github.com/users/dbevans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbevans/subscriptions","organizations_url":"https://api.github.com/users/dbevans/orgs","repos_url":"https://api.github.com/users/dbevans/repos","events_url":"https://api.github.com/users/dbevans/events{/privacy}","received_events_url":"https://api.github.com/users/dbevans/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-08-10T10:55:07Z","updated_at":"2018-08-11T07:15:27Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/macports/macports-ports/pulls/2374","html_url":"https://github.com/macports/macports-ports/pull/2374","diff_url":"https://github.com/macports/macports-ports/pull/2374.diff","patch_url":"https://github.com/macports/macports-ports/pull/2374.patch"},"body":"#### Description\r\n\r\nlibvpx: Don't force use of clang-3.9\r\n\r\n###### Type(s)\r\n<!-- update (title contains \": U(u)pdate to\"), submission (new Portfile) and CVE Identifiers are auto-detected, replace [ ] with [x] to select -->\r\n\r\n- [ ] bugfix\r\n- [X] enhancement\r\n- [ ] security fix\r\n\r\n###### Tested on\r\nmacOS 10.13.6 17G65\r\nXcode 9.4.1 9F2000 \r\n\r\n###### Verification <!-- (delete not applicable items) -->\r\nHave you\r\n\r\n- [X] followed our [Commit Message Guidelines](https://trac.macports.org/wiki/CommitMessages)?\r\n- [X] squashed and [minimized your commits](https://guide.macports.org/#project.github)?\r\n- [X] checked that there aren't other open [pull requests](https://github.com/macports/macports-ports/pulls) for the same change?\r\n- [X] referenced existing tickets on [Trac](https://trac.macports.org/wiki/Tickets) with full URL?\r\n<!-- Please don't open a new Trac ticket if you are submitting a pull request. -->\r\n- [X] checked your Portfile with `port lint`?\r\n- [ ] tried existing tests with `sudo port test`?\r\n- [X] tried a full install with `sudo port -vst install`?\r\n- [ ] tested basic functionality of all binary files?\r\n\r\n<!-- Use \"skip notification\" (surrounded with []) to avoid notifying maintainers -->"},"comment":{"url":"https://api.github.com/repos/macports/macports-ports/issues/comments/412257016","html_url":"https://github.com/macports/macports-ports/pull/2374#issuecomment-412257016","issue_url":"https://api.github.com/repos/macports/macports-ports/issues/2374","id":412257016,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjI1NzAxNg==","user":{"login":"ryandesign","id":429209,"node_id":"MDQ6VXNlcjQyOTIwOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/429209?v=4","gravatar_id":"","url":"https://api.github.com/users/ryandesign","html_url":"https://github.com/ryandesign","followers_url":"https://api.github.com/users/ryandesign/followers","following_url":"https://api.github.com/users/ryandesign/following{/other_user}","gists_url":"https://api.github.com/users/ryandesign/gists{/gist_id}","starred_url":"https://api.github.com/users/ryandesign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryandesign/subscriptions","organizations_url":"https://api.github.com/users/ryandesign/orgs","repos_url":"https://api.github.com/users/ryandesign/repos","events_url":"https://api.github.com/users/ryandesign/events{/privacy}","received_events_url":"https://api.github.com/users/ryandesign/received_events","type":"User","site_admin":false},"created_at":"2018-08-11T07:15:27Z","updated_at":"2018-08-11T07:15:27Z","author_association":"CONTRIBUTOR","body":"What's supposed to happen is: MacPorts base sets `compiler.fallback` to the list of all compilers that work on this system (based on OS version, Xcode version, C++ stdlib), in order of preference. An individual port can set `compiler.blacklist` to the set of all compilers that are known to be unable to build this port. MacPorts then chooses the first non-blacklisted compiler in the fallback list.\r\n\r\nIf *all* compilers are blacklisted, that means *no* compiler can compile this software, and the port is effectively incompatible with this system. MacPorts prints a warning, tries to compile the port anyway, using the first compiler in the fallback list, and the build is expected to fail.\r\n\r\nIf a new compiler has come into existence since the last release of MacPorts base, and a port is only compatible with that new compiler and not any of the compilers MacPorts base would otherwise choose, then it is reasonable to add that new compiler to the fallback list, until such a time as MacPorts base can be updated to include that new compiler. As I understand it, that is the situation that applies for libvpx. This port did not build with clang 3.8 or older, and clang 3.9 was so new that it was not yet in the base fallback list, so the port added it.\r\n\r\nThe problem is that the port *prepended* clang 3.9 to the list, meaning that as time went on, and as new compilers got added to the base fallback list, the libvpx port still prefered the aging and now quite old clang 3.9 over newer versions that would work fine. Contrary to the original intention of using a bleeding-edge compiler, the port now uses an outdated compiler that is known to be incompatible with the High Sierra SDK and later. If the port *appended* clang 3.9 to the fallback list, rather than prepending it, these problems would be avoided.\r\n\r\nIn the mean time, clang 3.9 and newer versions were added to MacPorts base, so there should no longer be a need for the port to add it, hence this PR.\r\n\r\nKen claims clang 3.9 works fine with libstdc++. This is contrary to the statements made in the code committed to base and the clang ports by @jeremyhu (\"`# clang-3.5+ require libc++`\"), so he will have to comment. If clang 3.5+ works with libc++, base should be changed. Until such a time as a new version of base is released containing that change, the port can do whatever it needs to add the compilers that are missing.\r\n\r\nNote that extensive work on reworking the compiler selection of base has already been done in https://github.com/macports/macports-base/pull/88. I don't know whether it already makes the needed changes. If not, consider the impact that unrelated changes to base would have on that PR, or consider adding the needed changes to that PR."}}
{"actor":{"display_login":"ryandesign"}}