{"action":"created","comment":{"url":"https://api.github.com/repos/magento-engcom/msi/pulls/comments/194876349","pull_request_review_id":128127943,"id":194876349,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDg3NjM0OQ==","diff_hunk":"@@ -98,8 +98,8 @@ public function execute(SourceDeductionRequestInterface $sourceDeductionRequest)\n                 $stockId\n             );\n \n-            if ($stockItemConfiguration === null || !$stockItemConfiguration->isManageStock()) {\n-                //Product not assigned to Given Stock or we No need to Manage Stock\n+            if (!$stockItemConfiguration->isManageStock()) {","path":"app/code/Magento/InventoryShipping/Model/SourceDeduction/SourceDeductionService.php","position":6,"original_position":6,"commit_id":"3c9892b640b8a5bc9fbc01b5c3e5b95b165d630f","original_commit_id":"3c9892b640b8a5bc9fbc01b5c3e5b95b165d630f","user":{"login":"maghamed","id":1928215,"node_id":"MDQ6VXNlcjE5MjgyMTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1928215?v=4","gravatar_id":"","url":"https://api.github.com/users/maghamed","html_url":"https://github.com/maghamed","followers_url":"https://api.github.com/users/maghamed/followers","following_url":"https://api.github.com/users/maghamed/following{/other_user}","gists_url":"https://api.github.com/users/maghamed/gists{/gist_id}","starred_url":"https://api.github.com/users/maghamed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maghamed/subscriptions","organizations_url":"https://api.github.com/users/maghamed/orgs","repos_url":"https://api.github.com/users/maghamed/repos","events_url":"https://api.github.com/users/maghamed/events{/privacy}","received_events_url":"https://api.github.com/users/maghamed/received_events","type":"User","site_admin":false},"body":"same as above ","created_at":"2018-06-12T20:23:48Z","updated_at":"2018-06-12T20:24:20Z","html_url":"https://github.com/magento-engcom/msi/pull/1353#discussion_r194876349","pull_request_url":"https://api.github.com/repos/magento-engcom/msi/pulls/1353","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/magento-engcom/msi/pulls/comments/194876349"},"html":{"href":"https://github.com/magento-engcom/msi/pull/1353#discussion_r194876349"},"pull_request":{"href":"https://api.github.com/repos/magento-engcom/msi/pulls/1353"}}},"pull_request":{"url":"https://api.github.com/repos/magento-engcom/msi/pulls/1353","id":193900011,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzOTAwMDEx","html_url":"https://github.com/magento-engcom/msi/pull/1353","diff_url":"https://github.com/magento-engcom/msi/pull/1353.diff","patch_url":"https://github.com/magento-engcom/msi/pull/1353.patch","issue_url":"https://api.github.com/repos/magento-engcom/msi/issues/1353","number":1353,"state":"open","locked":false,"title":"fix stock item configuration","user":{"login":"seruymt","id":10884688,"node_id":"MDQ6VXNlcjEwODg0Njg4","avatar_url":"https://avatars3.githubusercontent.com/u/10884688?v=4","gravatar_id":"","url":"https://api.github.com/users/seruymt","html_url":"https://github.com/seruymt","followers_url":"https://api.github.com/users/seruymt/followers","following_url":"https://api.github.com/users/seruymt/following{/other_user}","gists_url":"https://api.github.com/users/seruymt/gists{/gist_id}","starred_url":"https://api.github.com/users/seruymt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seruymt/subscriptions","organizations_url":"https://api.github.com/users/seruymt/orgs","repos_url":"https://api.github.com/users/seruymt/repos","events_url":"https://api.github.com/users/seruymt/events{/privacy}","received_events_url":"https://api.github.com/users/seruymt/received_events","type":"User","site_admin":false},"body":"depends on https://github.com/magento-engcom/msi/issues/1236","created_at":"2018-06-11T07:55:05Z","updated_at":"2018-06-12T20:24:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c78330ba8bad23d24dd8348e0ac1c87952fc0a7","assignee":{"login":"seruymt","id":10884688,"node_id":"MDQ6VXNlcjEwODg0Njg4","avatar_url":"https://avatars3.githubusercontent.com/u/10884688?v=4","gravatar_id":"","url":"https://api.github.com/users/seruymt","html_url":"https://github.com/seruymt","followers_url":"https://api.github.com/users/seruymt/followers","following_url":"https://api.github.com/users/seruymt/following{/other_user}","gists_url":"https://api.github.com/users/seruymt/gists{/gist_id}","starred_url":"https://api.github.com/users/seruymt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seruymt/subscriptions","organizations_url":"https://api.github.com/users/seruymt/orgs","repos_url":"https://api.github.com/users/seruymt/repos","events_url":"https://api.github.com/users/seruymt/events{/privacy}","received_events_url":"https://api.github.com/users/seruymt/received_events","type":"User","site_admin":false},"assignees":[{"login":"seruymt","id":10884688,"node_id":"MDQ6VXNlcjEwODg0Njg4","avatar_url":"https://avatars3.githubusercontent.com/u/10884688?v=4","gravatar_id":"","url":"https://api.github.com/users/seruymt","html_url":"https://github.com/seruymt","followers_url":"https://api.github.com/users/seruymt/followers","following_url":"https://api.github.com/users/seruymt/following{/other_user}","gists_url":"https://api.github.com/users/seruymt/gists{/gist_id}","starred_url":"https://api.github.com/users/seruymt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seruymt/subscriptions","organizations_url":"https://api.github.com/users/seruymt/orgs","repos_url":"https://api.github.com/users/seruymt/repos","events_url":"https://api.github.com/users/seruymt/events{/privacy}","received_events_url":"https://api.github.com/users/seruymt/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":712304680,"node_id":"MDU6TGFiZWw3MTIzMDQ2ODA=","url":"https://api.github.com/repos/magento-engcom/msi/labels/WIP","name":"WIP","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/magento-engcom/msi/milestones/1","html_url":"https://github.com/magento-engcom/msi/milestone/1","labels_url":"https://api.github.com/repos/magento-engcom/msi/milestones/1/labels","id":2527850,"node_id":"MDk6TWlsZXN0b25lMjUyNzg1MA==","number":1,"title":"MSI Part I","description":"","creator":{"login":"okorshenko","id":7325075,"node_id":"MDQ6VXNlcjczMjUwNzU=","avatar_url":"https://avatars1.githubusercontent.com/u/7325075?v=4","gravatar_id":"","url":"https://api.github.com/users/okorshenko","html_url":"https://github.com/okorshenko","followers_url":"https://api.github.com/users/okorshenko/followers","following_url":"https://api.github.com/users/okorshenko/following{/other_user}","gists_url":"https://api.github.com/users/okorshenko/gists{/gist_id}","starred_url":"https://api.github.com/users/okorshenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okorshenko/subscriptions","organizations_url":"https://api.github.com/users/okorshenko/orgs","repos_url":"https://api.github.com/users/okorshenko/repos","events_url":"https://api.github.com/users/okorshenko/events{/privacy}","received_events_url":"https://api.github.com/users/okorshenko/received_events","type":"User","site_admin":false},"open_issues":40,"closed_issues":332,"state":"open","created_at":"2017-05-17T20:30:12Z","updated_at":"2018-06-12T19:32:06Z","due_on":"2018-06-18T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/magento-engcom/msi/pulls/1353/commits","review_comments_url":"https://api.github.com/repos/magento-engcom/msi/pulls/1353/comments","review_comment_url":"https://api.github.com/repos/magento-engcom/msi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/magento-engcom/msi/issues/1353/comments","statuses_url":"https://api.github.com/repos/magento-engcom/msi/statuses/3c9892b640b8a5bc9fbc01b5c3e5b95b165d630f","head":{"label":"magento-engcom:fix-stock-item-configuration","ref":"fix-stock-item-configuration","sha":"3c9892b640b8a5bc9fbc01b5c3e5b95b165d630f","user":{"login":"magento-engcom","id":25439648,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NDM5NjQ4","avatar_url":"https://avatars0.githubusercontent.com/u/25439648?v=4","gravatar_id":"","url":"https://api.github.com/users/magento-engcom","html_url":"https://github.com/magento-engcom","followers_url":"https://api.github.com/users/magento-engcom/followers","following_url":"https://api.github.com/users/magento-engcom/following{/other_user}","gists_url":"https://api.github.com/users/magento-engcom/gists{/gist_id}","starred_url":"https://api.github.com/users/magento-engcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento-engcom/subscriptions","organizations_url":"https://api.github.com/users/magento-engcom/orgs","repos_url":"https://api.github.com/users/magento-engcom/repos","events_url":"https://api.github.com/users/magento-engcom/events{/privacy}","received_events_url":"https://api.github.com/users/magento-engcom/received_events","type":"Organization","site_admin":false},"repo":{"id":91593797,"node_id":"MDEwOlJlcG9zaXRvcnk5MTU5Mzc5Nw==","name":"msi","full_name":"magento-engcom/msi","owner":{"login":"magento-engcom","id":25439648,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NDM5NjQ4","avatar_url":"https://avatars0.githubusercontent.com/u/25439648?v=4","gravatar_id":"","url":"https://api.github.com/users/magento-engcom","html_url":"https://github.com/magento-engcom","followers_url":"https://api.github.com/users/magento-engcom/followers","following_url":"https://api.github.com/users/magento-engcom/following{/other_user}","gists_url":"https://api.github.com/users/magento-engcom/gists{/gist_id}","starred_url":"https://api.github.com/users/magento-engcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento-engcom/subscriptions","organizations_url":"https://api.github.com/users/magento-engcom/orgs","repos_url":"https://api.github.com/users/magento-engcom/repos","events_url":"https://api.github.com/users/magento-engcom/events{/privacy}","received_events_url":"https://api.github.com/users/magento-engcom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/magento-engcom/msi","description":"Development of the MSI Project. See updated list of issues on the ZenHub board","fork":true,"url":"https://api.github.com/repos/magento-engcom/msi","forks_url":"https://api.github.com/repos/magento-engcom/msi/forks","keys_url":"https://api.github.com/repos/magento-engcom/msi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magento-engcom/msi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magento-engcom/msi/teams","hooks_url":"https://api.github.com/repos/magento-engcom/msi/hooks","issue_events_url":"https://api.github.com/repos/magento-engcom/msi/issues/events{/number}","events_url":"https://api.github.com/repos/magento-engcom/msi/events","assignees_url":"https://api.github.com/repos/magento-engcom/msi/assignees{/user}","branches_url":"https://api.github.com/repos/magento-engcom/msi/branches{/branch}","tags_url":"https://api.github.com/repos/magento-engcom/msi/tags","blobs_url":"https://api.github.com/repos/magento-engcom/msi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magento-engcom/msi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magento-engcom/msi/git/refs{/sha}","trees_url":"https://api.github.com/repos/magento-engcom/msi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magento-engcom/msi/statuses/{sha}","languages_url":"https://api.github.com/repos/magento-engcom/msi/languages","stargazers_url":"https://api.github.com/repos/magento-engcom/msi/stargazers","contributors_url":"https://api.github.com/repos/magento-engcom/msi/contributors","subscribers_url":"https://api.github.com/repos/magento-engcom/msi/subscribers","subscription_url":"https://api.github.com/repos/magento-engcom/msi/subscription","commits_url":"https://api.github.com/repos/magento-engcom/msi/commits{/sha}","git_commits_url":"https://api.github.com/repos/magento-engcom/msi/git/commits{/sha}","comments_url":"https://api.github.com/repos/magento-engcom/msi/comments{/number}","issue_comment_url":"https://api.github.com/repos/magento-engcom/msi/issues/comments{/number}","contents_url":"https://api.github.com/repos/magento-engcom/msi/contents/{+path}","compare_url":"https://api.github.com/repos/magento-engcom/msi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magento-engcom/msi/merges","archive_url":"https://api.github.com/repos/magento-engcom/msi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magento-engcom/msi/downloads","issues_url":"https://api.github.com/repos/magento-engcom/msi/issues{/number}","pulls_url":"https://api.github.com/repos/magento-engcom/msi/pulls{/number}","milestones_url":"https://api.github.com/repos/magento-engcom/msi/milestones{/number}","notifications_url":"https://api.github.com/repos/magento-engcom/msi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magento-engcom/msi/labels{/name}","releases_url":"https://api.github.com/repos/magento-engcom/msi/releases{/id}","deployments_url":"https://api.github.com/repos/magento-engcom/msi/deployments","created_at":"2017-05-17T15:47:14Z","updated_at":"2018-06-12T19:32:15Z","pushed_at":"2018-06-12T19:31:55Z","git_url":"git://github.com/magento-engcom/msi.git","ssh_url":"git@github.com:magento-engcom/msi.git","clone_url":"https://github.com/magento-engcom/msi.git","svn_url":"https://github.com/magento-engcom/msi","homepage":"https://app.zenhub.com/workspace/o/magento-engcom/msi/boards?repos=91593797","size":444059,"stargazers_count":101,"watchers_count":101,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":210,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":40,"open_issues":210,"watchers":101,"default_branch":"2.3-develop"}},"base":{"label":"magento-engcom:2.3-develop","ref":"2.3-develop","sha":"f4e202ebdd2bbeb3bbcfbba225523b908200f864","user":{"login":"magento-engcom","id":25439648,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NDM5NjQ4","avatar_url":"https://avatars0.githubusercontent.com/u/25439648?v=4","gravatar_id":"","url":"https://api.github.com/users/magento-engcom","html_url":"https://github.com/magento-engcom","followers_url":"https://api.github.com/users/magento-engcom/followers","following_url":"https://api.github.com/users/magento-engcom/following{/other_user}","gists_url":"https://api.github.com/users/magento-engcom/gists{/gist_id}","starred_url":"https://api.github.com/users/magento-engcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento-engcom/subscriptions","organizations_url":"https://api.github.com/users/magento-engcom/orgs","repos_url":"https://api.github.com/users/magento-engcom/repos","events_url":"https://api.github.com/users/magento-engcom/events{/privacy}","received_events_url":"https://api.github.com/users/magento-engcom/received_events","type":"Organization","site_admin":false},"repo":{"id":91593797,"node_id":"MDEwOlJlcG9zaXRvcnk5MTU5Mzc5Nw==","name":"msi","full_name":"magento-engcom/msi","owner":{"login":"magento-engcom","id":25439648,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NDM5NjQ4","avatar_url":"https://avatars0.githubusercontent.com/u/25439648?v=4","gravatar_id":"","url":"https://api.github.com/users/magento-engcom","html_url":"https://github.com/magento-engcom","followers_url":"https://api.github.com/users/magento-engcom/followers","following_url":"https://api.github.com/users/magento-engcom/following{/other_user}","gists_url":"https://api.github.com/users/magento-engcom/gists{/gist_id}","starred_url":"https://api.github.com/users/magento-engcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento-engcom/subscriptions","organizations_url":"https://api.github.com/users/magento-engcom/orgs","repos_url":"https://api.github.com/users/magento-engcom/repos","events_url":"https://api.github.com/users/magento-engcom/events{/privacy}","received_events_url":"https://api.github.com/users/magento-engcom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/magento-engcom/msi","description":"Development of the MSI Project. See updated list of issues on the ZenHub board","fork":true,"url":"https://api.github.com/repos/magento-engcom/msi","forks_url":"https://api.github.com/repos/magento-engcom/msi/forks","keys_url":"https://api.github.com/repos/magento-engcom/msi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magento-engcom/msi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magento-engcom/msi/teams","hooks_url":"https://api.github.com/repos/magento-engcom/msi/hooks","issue_events_url":"https://api.github.com/repos/magento-engcom/msi/issues/events{/number}","events_url":"https://api.github.com/repos/magento-engcom/msi/events","assignees_url":"https://api.github.com/repos/magento-engcom/msi/assignees{/user}","branches_url":"https://api.github.com/repos/magento-engcom/msi/branches{/branch}","tags_url":"https://api.github.com/repos/magento-engcom/msi/tags","blobs_url":"https://api.github.com/repos/magento-engcom/msi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magento-engcom/msi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magento-engcom/msi/git/refs{/sha}","trees_url":"https://api.github.com/repos/magento-engcom/msi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magento-engcom/msi/statuses/{sha}","languages_url":"https://api.github.com/repos/magento-engcom/msi/languages","stargazers_url":"https://api.github.com/repos/magento-engcom/msi/stargazers","contributors_url":"https://api.github.com/repos/magento-engcom/msi/contributors","subscribers_url":"https://api.github.com/repos/magento-engcom/msi/subscribers","subscription_url":"https://api.github.com/repos/magento-engcom/msi/subscription","commits_url":"https://api.github.com/repos/magento-engcom/msi/commits{/sha}","git_commits_url":"https://api.github.com/repos/magento-engcom/msi/git/commits{/sha}","comments_url":"https://api.github.com/repos/magento-engcom/msi/comments{/number}","issue_comment_url":"https://api.github.com/repos/magento-engcom/msi/issues/comments{/number}","contents_url":"https://api.github.com/repos/magento-engcom/msi/contents/{+path}","compare_url":"https://api.github.com/repos/magento-engcom/msi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magento-engcom/msi/merges","archive_url":"https://api.github.com/repos/magento-engcom/msi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magento-engcom/msi/downloads","issues_url":"https://api.github.com/repos/magento-engcom/msi/issues{/number}","pulls_url":"https://api.github.com/repos/magento-engcom/msi/pulls{/number}","milestones_url":"https://api.github.com/repos/magento-engcom/msi/milestones{/number}","notifications_url":"https://api.github.com/repos/magento-engcom/msi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magento-engcom/msi/labels{/name}","releases_url":"https://api.github.com/repos/magento-engcom/msi/releases{/id}","deployments_url":"https://api.github.com/repos/magento-engcom/msi/deployments","created_at":"2017-05-17T15:47:14Z","updated_at":"2018-06-12T19:32:15Z","pushed_at":"2018-06-12T19:31:55Z","git_url":"git://github.com/magento-engcom/msi.git","ssh_url":"git@github.com:magento-engcom/msi.git","clone_url":"https://github.com/magento-engcom/msi.git","svn_url":"https://github.com/magento-engcom/msi","homepage":"https://app.zenhub.com/workspace/o/magento-engcom/msi/boards?repos=91593797","size":444059,"stargazers_count":101,"watchers_count":101,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":210,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":40,"open_issues":210,"watchers":101,"default_branch":"2.3-develop"}},"_links":{"self":{"href":"https://api.github.com/repos/magento-engcom/msi/pulls/1353"},"html":{"href":"https://github.com/magento-engcom/msi/pull/1353"},"issue":{"href":"https://api.github.com/repos/magento-engcom/msi/issues/1353"},"comments":{"href":"https://api.github.com/repos/magento-engcom/msi/issues/1353/comments"},"review_comments":{"href":"https://api.github.com/repos/magento-engcom/msi/pulls/1353/comments"},"review_comment":{"href":"https://api.github.com/repos/magento-engcom/msi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/magento-engcom/msi/pulls/1353/commits"},"statuses":{"href":"https://api.github.com/repos/magento-engcom/msi/statuses/3c9892b640b8a5bc9fbc01b5c3e5b95b165d630f"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"maghamed"}}