{"action":"opened","number":10499,"pull_request":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/10499","id":208147996,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MTQ3OTk2","html_url":"https://github.com/pytorch/pytorch/pull/10499","diff_url":"https://github.com/pytorch/pytorch/pull/10499.diff","patch_url":"https://github.com/pytorch/pytorch/pull/10499.patch","issue_url":"https://api.github.com/repos/pytorch/pytorch/issues/10499","number":10499,"state":"open","locked":false,"title":"stop allowing extra positional args in arg parser","user":{"login":"li-roy","id":8813817,"node_id":"MDQ6VXNlcjg4MTM4MTc=","avatar_url":"https://avatars0.githubusercontent.com/u/8813817?v=4","gravatar_id":"","url":"https://api.github.com/users/li-roy","html_url":"https://github.com/li-roy","followers_url":"https://api.github.com/users/li-roy/followers","following_url":"https://api.github.com/users/li-roy/following{/other_user}","gists_url":"https://api.github.com/users/li-roy/gists{/gist_id}","starred_url":"https://api.github.com/users/li-roy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/li-roy/subscriptions","organizations_url":"https://api.github.com/users/li-roy/orgs","repos_url":"https://api.github.com/users/li-roy/repos","events_url":"https://api.github.com/users/li-roy/events{/privacy}","received_events_url":"https://api.github.com/users/li-roy/received_events","type":"User","site_admin":false},"body":"Arg parser allowed additional positional args to be parsed into keyword-only params. \r\n\r\nFixes a couple cases:\r\n- The positional argument happens to be of the right type, and it just works silently. Now, we fail as expected.\r\n- The positional argument fails later down the line. Now, we fail at the appropriate time and get a better error message.\r\n\r\nPre-fix:\r\n```\r\n>>> torch.cuda.LongTensor((6, 0), 1, 1, 0)\r\ntensor([6, 0], device='cuda:1')\r\n```\r\nPost-fix:\r\n```\r\n>>> torch.cuda.LongTensor((6, 0), 1, 1, 0)\r\nTraceback (most recent call last):\r\n  File \"<stdin>\", line 1, in <module>\r\nTypeError: new() received an invalid combination of arguments - got (tuple, int, int, int), but expected one of:\r\n * (torch.device device)\r\n * (torch.Storage storage)\r\n * (Tensor other)\r\n * (tuple of ints size, torch.device device)\r\n * (object data, torch.device device)```\r\n\r\nPre-fix:\r\n```\r\n>>> a = torch.tensor(5)\r\n>>> a.new_zeros((5,5), 0)\r\nTraceback (most recent call last):\r\n  File \"<stdin>\", line 1, in <module>\r\nTypeError: new_zeros(): argument 'dtype' (position 2) must be torch.dtype, not int\r\n```\r\n\r\nPost-fix:\r\n```\r\n>>> a = torch.tensor(5)\r\n>>> a.new_zeros((5,5), 0)\r\nTraceback (most recent call last):\r\n  File \"<stdin>\", line 1, in <module>\r\nTypeError: new_zeros() takes 1 positional argument but 2 were given\r\n```\r\n\r\nfixes #8351","created_at":"2018-08-14T01:45:07Z","updated_at":"2018-08-14T01:45:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pytorch/pytorch/pulls/10499/commits","review_comments_url":"https://api.github.com/repos/pytorch/pytorch/pulls/10499/comments","review_comment_url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytorch/pytorch/issues/10499/comments","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/8fa0b3b7b7a9ad2fca651b9f7bc341b100168fdd","head":{"label":"li-roy:argparseposarg","ref":"argparseposarg","sha":"8fa0b3b7b7a9ad2fca651b9f7bc341b100168fdd","user":{"login":"li-roy","id":8813817,"node_id":"MDQ6VXNlcjg4MTM4MTc=","avatar_url":"https://avatars0.githubusercontent.com/u/8813817?v=4","gravatar_id":"","url":"https://api.github.com/users/li-roy","html_url":"https://github.com/li-roy","followers_url":"https://api.github.com/users/li-roy/followers","following_url":"https://api.github.com/users/li-roy/following{/other_user}","gists_url":"https://api.github.com/users/li-roy/gists{/gist_id}","starred_url":"https://api.github.com/users/li-roy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/li-roy/subscriptions","organizations_url":"https://api.github.com/users/li-roy/orgs","repos_url":"https://api.github.com/users/li-roy/repos","events_url":"https://api.github.com/users/li-roy/events{/privacy}","received_events_url":"https://api.github.com/users/li-roy/received_events","type":"User","site_admin":false},"repo":{"id":119106720,"node_id":"MDEwOlJlcG9zaXRvcnkxMTkxMDY3MjA=","name":"pytorch","full_name":"li-roy/pytorch","owner":{"login":"li-roy","id":8813817,"node_id":"MDQ6VXNlcjg4MTM4MTc=","avatar_url":"https://avatars0.githubusercontent.com/u/8813817?v=4","gravatar_id":"","url":"https://api.github.com/users/li-roy","html_url":"https://github.com/li-roy","followers_url":"https://api.github.com/users/li-roy/followers","following_url":"https://api.github.com/users/li-roy/following{/other_user}","gists_url":"https://api.github.com/users/li-roy/gists{/gist_id}","starred_url":"https://api.github.com/users/li-roy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/li-roy/subscriptions","organizations_url":"https://api.github.com/users/li-roy/orgs","repos_url":"https://api.github.com/users/li-roy/repos","events_url":"https://api.github.com/users/li-roy/events{/privacy}","received_events_url":"https://api.github.com/users/li-roy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/li-roy/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":true,"url":"https://api.github.com/repos/li-roy/pytorch","forks_url":"https://api.github.com/repos/li-roy/pytorch/forks","keys_url":"https://api.github.com/repos/li-roy/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/li-roy/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/li-roy/pytorch/teams","hooks_url":"https://api.github.com/repos/li-roy/pytorch/hooks","issue_events_url":"https://api.github.com/repos/li-roy/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/li-roy/pytorch/events","assignees_url":"https://api.github.com/repos/li-roy/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/li-roy/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/li-roy/pytorch/tags","blobs_url":"https://api.github.com/repos/li-roy/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/li-roy/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/li-roy/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/li-roy/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/li-roy/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/li-roy/pytorch/languages","stargazers_url":"https://api.github.com/repos/li-roy/pytorch/stargazers","contributors_url":"https://api.github.com/repos/li-roy/pytorch/contributors","subscribers_url":"https://api.github.com/repos/li-roy/pytorch/subscribers","subscription_url":"https://api.github.com/repos/li-roy/pytorch/subscription","commits_url":"https://api.github.com/repos/li-roy/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/li-roy/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/li-roy/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/li-roy/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/li-roy/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/li-roy/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/li-roy/pytorch/merges","archive_url":"https://api.github.com/repos/li-roy/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/li-roy/pytorch/downloads","issues_url":"https://api.github.com/repos/li-roy/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/li-roy/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/li-roy/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/li-roy/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/li-roy/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/li-roy/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/li-roy/pytorch/deployments","created_at":"2018-01-26T21:46:02Z","updated_at":"2018-01-26T21:46:07Z","pushed_at":"2018-08-14T01:45:02Z","git_url":"git://github.com/li-roy/pytorch.git","ssh_url":"git@github.com:li-roy/pytorch.git","clone_url":"https://github.com/li-roy/pytorch.git","svn_url":"https://github.com/li-roy/pytorch","homepage":"http://pytorch.org","size":67365,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pytorch:master","ref":"master","sha":"f6eb966fd2ae22d1a96678f595b11cffa06e7fd0","user":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"repo":{"id":65600975,"node_id":"MDEwOlJlcG9zaXRvcnk2NTYwMDk3NQ==","name":"pytorch","full_name":"pytorch/pytorch","owner":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pytorch/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":false,"url":"https://api.github.com/repos/pytorch/pytorch","forks_url":"https://api.github.com/repos/pytorch/pytorch/forks","keys_url":"https://api.github.com/repos/pytorch/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytorch/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytorch/pytorch/teams","hooks_url":"https://api.github.com/repos/pytorch/pytorch/hooks","issue_events_url":"https://api.github.com/repos/pytorch/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/pytorch/pytorch/events","assignees_url":"https://api.github.com/repos/pytorch/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/pytorch/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/pytorch/pytorch/tags","blobs_url":"https://api.github.com/repos/pytorch/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytorch/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytorch/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytorch/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/pytorch/pytorch/languages","stargazers_url":"https://api.github.com/repos/pytorch/pytorch/stargazers","contributors_url":"https://api.github.com/repos/pytorch/pytorch/contributors","subscribers_url":"https://api.github.com/repos/pytorch/pytorch/subscribers","subscription_url":"https://api.github.com/repos/pytorch/pytorch/subscription","commits_url":"https://api.github.com/repos/pytorch/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytorch/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytorch/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytorch/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytorch/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/pytorch/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytorch/pytorch/merges","archive_url":"https://api.github.com/repos/pytorch/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytorch/pytorch/downloads","issues_url":"https://api.github.com/repos/pytorch/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/pytorch/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/pytorch/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/pytorch/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytorch/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/pytorch/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/pytorch/pytorch/deployments","created_at":"2016-08-13T05:26:41Z","updated_at":"2018-08-14T01:31:29Z","pushed_at":"2018-08-14T01:14:40Z","git_url":"git://github.com/pytorch/pytorch.git","ssh_url":"git@github.com:pytorch/pytorch.git","clone_url":"https://github.com/pytorch/pytorch.git","svn_url":"https://github.com/pytorch/pytorch","homepage":"http://pytorch.org","size":67790,"stargazers_count":17837,"watchers_count":17837,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4209,"mirror_url":null,"archived":false,"open_issues_count":1626,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4209,"open_issues":1626,"watchers":17837,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/10499"},"html":{"href":"https://github.com/pytorch/pytorch/pull/10499"},"issue":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/10499"},"comments":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/10499/comments"},"review_comments":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/10499/comments"},"review_comment":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/10499/commits"},"statuses":{"href":"https://api.github.com/repos/pytorch/pytorch/statuses/8fa0b3b7b7a9ad2fca651b9f7bc341b100168fdd"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":7,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"li-roy"}}