{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/60851","repository_url":"https://api.github.com/repos/Microsoft/vscode","labels_url":"https://api.github.com/repos/Microsoft/vscode/issues/60851/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode/issues/60851/comments","events_url":"https://api.github.com/repos/Microsoft/vscode/issues/60851/events","html_url":"https://github.com/Microsoft/vscode/issues/60851","id":369834512,"node_id":"MDU6SXNzdWUzNjk4MzQ1MTI=","number":60851,"title":"Open next build error file+line based on regex parsing of build output.","user":{"login":"safield","id":12876404,"node_id":"MDQ6VXNlcjEyODc2NDA0","avatar_url":"https://avatars3.githubusercontent.com/u/12876404?v=4","gravatar_id":"","url":"https://api.github.com/users/safield","html_url":"https://github.com/safield","followers_url":"https://api.github.com/users/safield/followers","following_url":"https://api.github.com/users/safield/following{/other_user}","gists_url":"https://api.github.com/users/safield/gists{/gist_id}","starred_url":"https://api.github.com/users/safield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/safield/subscriptions","organizations_url":"https://api.github.com/users/safield/orgs","repos_url":"https://api.github.com/users/safield/repos","events_url":"https://api.github.com/users/safield/events{/privacy}","received_events_url":"https://api.github.com/users/safield/received_events","type":"User","site_admin":false},"labels":[{"id":272689392,"node_id":"MDU6TGFiZWwyNzI2ODkzOTI=","url":"https://api.github.com/repos/Microsoft/vscode/labels/feature-request","name":"feature-request","color":"dcdcdc","default":false},{"id":292032114,"node_id":"MDU6TGFiZWwyOTIwMzIxMTQ=","url":"https://api.github.com/repos/Microsoft/vscode/labels/tasks","name":"tasks","color":"1d76db","default":false}],"state":"open","locked":false,"assignee":{"login":"dbaeumer","id":1931590,"node_id":"MDQ6VXNlcjE5MzE1OTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1931590?v=4","gravatar_id":"","url":"https://api.github.com/users/dbaeumer","html_url":"https://github.com/dbaeumer","followers_url":"https://api.github.com/users/dbaeumer/followers","following_url":"https://api.github.com/users/dbaeumer/following{/other_user}","gists_url":"https://api.github.com/users/dbaeumer/gists{/gist_id}","starred_url":"https://api.github.com/users/dbaeumer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbaeumer/subscriptions","organizations_url":"https://api.github.com/users/dbaeumer/orgs","repos_url":"https://api.github.com/users/dbaeumer/repos","events_url":"https://api.github.com/users/dbaeumer/events{/privacy}","received_events_url":"https://api.github.com/users/dbaeumer/received_events","type":"User","site_admin":false},"assignees":[{"login":"dbaeumer","id":1931590,"node_id":"MDQ6VXNlcjE5MzE1OTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1931590?v=4","gravatar_id":"","url":"https://api.github.com/users/dbaeumer","html_url":"https://github.com/dbaeumer","followers_url":"https://api.github.com/users/dbaeumer/followers","following_url":"https://api.github.com/users/dbaeumer/following{/other_user}","gists_url":"https://api.github.com/users/dbaeumer/gists{/gist_id}","starred_url":"https://api.github.com/users/dbaeumer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbaeumer/subscriptions","organizations_url":"https://api.github.com/users/dbaeumer/orgs","repos_url":"https://api.github.com/users/dbaeumer/repos","events_url":"https://api.github.com/users/dbaeumer/events{/privacy}","received_events_url":"https://api.github.com/users/dbaeumer/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Microsoft/vscode/milestones/8","html_url":"https://github.com/Microsoft/vscode/milestone/8","labels_url":"https://api.github.com/repos/Microsoft/vscode/milestones/8/labels","id":1412124,"node_id":"MDk6TWlsZXN0b25lMTQxMjEyNA==","number":8,"title":"Backlog","description":"Work not yet planned for a specific release.","creator":{"login":"chrisdias","id":1487073,"node_id":"MDQ6VXNlcjE0ODcwNzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1487073?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisdias","html_url":"https://github.com/chrisdias","followers_url":"https://api.github.com/users/chrisdias/followers","following_url":"https://api.github.com/users/chrisdias/following{/other_user}","gists_url":"https://api.github.com/users/chrisdias/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisdias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisdias/subscriptions","organizations_url":"https://api.github.com/users/chrisdias/orgs","repos_url":"https://api.github.com/users/chrisdias/repos","events_url":"https://api.github.com/users/chrisdias/events{/privacy}","received_events_url":"https://api.github.com/users/chrisdias/received_events","type":"User","site_admin":false},"open_issues":1741,"closed_issues":4530,"state":"open","created_at":"2015-11-15T10:30:19Z","updated_at":"2019-01-04T16:06:17Z","due_on":null,"closed_at":null},"comments":13,"created_at":"2018-10-13T19:41:36Z","updated_at":"2019-01-04T16:34:05Z","closed_at":null,"author_association":"NONE","body":"Edit: The proposed ability to jump to first/next build error should not be part of the \"Problems\" explorer system, since this requires code analysis. **The command should be based solely on regex parsing of the build output, and should work in absence of any language support aka extensions.** I shouldn't have to run 300mb and jvm in the background just to jump to build errors.\r\n\r\nWhen I run a build task to compile my code, I would like a keyboard shortcut that will open the location of the first/next compile error by opening the file and jumping to the line.\r\n\r\nThis command should ignore non build related errors and warning (from linters / intellisense). I am not interested in general VSCode problem noise, I just want to be able to quickly and easily address compile errors. \r\n\r\nIt should start at the first compile error in the terminal, and cycle from there. Basically, just go see how all other editors in the world jump to build errors with a shortcut.....do that.\r\n\r\nIts a pretty basic and necessary feature.\r\n\r\n1. Hit build.\r\n2. Jump to error....\r\n\r\nThe problems view is not adequate.\r\n\r\n**1. It requires the language support plugin to be installed.** This is totally unnecessary, as regex parsing of the build output is simpler, lighter, and tried tested and true.  \r\n\r\n**2 It is more than a single hotkey press.** In sublime when I build, I press a single shortcut to jump to error, then I fix error, I press a single shortcut to jump to next error....rinse and repeat.\r\n\r\nIn VSCode I...\r\n-press a shortcut to focus problems\r\n-I press down to highlight error\r\n-I press ENTER to focus editor and the fix error\r\n-I press shortcut to focus problems view again\r\n\r\nIts so much more work! \r\n\r\n**3. It does not cycle problems in order.** This is important, as when compiling, often the first build error is also causing the subsequent errors.\r\n\r\n**4. It contains \"problems\" and not build errors.** Its cute that VSCode has this concept of \"problems\", and that it is telling me what is wrong with my code...but I don't care about that noise. Either its a compiler error, or I don't care. I just want the compiler errors, and I want them in order.\r\n\r\nVSCode has somehow made this way too complicated.\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/comments/451495231","html_url":"https://github.com/Microsoft/vscode/issues/60851#issuecomment-451495231","issue_url":"https://api.github.com/repos/Microsoft/vscode/issues/60851","id":451495231,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MTQ5NTIzMQ==","user":{"login":"safield","id":12876404,"node_id":"MDQ6VXNlcjEyODc2NDA0","avatar_url":"https://avatars3.githubusercontent.com/u/12876404?v=4","gravatar_id":"","url":"https://api.github.com/users/safield","html_url":"https://github.com/safield","followers_url":"https://api.github.com/users/safield/followers","following_url":"https://api.github.com/users/safield/following{/other_user}","gists_url":"https://api.github.com/users/safield/gists{/gist_id}","starred_url":"https://api.github.com/users/safield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/safield/subscriptions","organizations_url":"https://api.github.com/users/safield/orgs","repos_url":"https://api.github.com/users/safield/repos","events_url":"https://api.github.com/users/safield/events{/privacy}","received_events_url":"https://api.github.com/users/safield/received_events","type":"User","site_admin":false},"created_at":"2019-01-04T16:34:05Z","updated_at":"2019-01-04T16:34:05Z","author_association":"NONE","body":"No, not really.\r\n\r\nI would recommend setting up a build system in Sublime and observing how it parses and jumps to errors in absence of any sort of plugin or dynamic code analysis.\r\n\r\nBut to go into details. (some of this behaviour is already present in some capacity in VSCode).\r\n\r\n1. In tasks.json I can specify a task which runs a specific command.\r\n2. In tasks.json, for previously mentioned task, I can specify a regex that will be used on the associated commands output, which will identify build errors.\r\n3. Two new commands should be added that can be mapped to keyboard shortcuts (nextError and prevError).\r\n4. When these commands are used to navigate to a build error, two things happen. First, the file of the build error is opened in editor, and is jumped to line column. Second, the terminal window also jumps to the error message line in the output of the build command.\r\n\r\nSome of this functionality is sort of implemented, but I have some concerns.\r\n\r\nYou can specify a regex already for a task using problemMatcher. In addition, the terminal already underlines and creates clickable links for build errors. But I have noticed that the identification of the build errors is not using my regex specified in problemsMatcher (if I specify and incorrect one, it still highlights the build errors). Allowing the user to specify the regex used for identifying build errors is important.  So to get the desired behaviour, I think the regex matching also needs to be looked at (and potentially broken out into a separate issue).\r\n\r\nThe advantage of this approach, is that it provides convenient jumping to errors, in absence of any language server extension, and dynamic code analysis."}}
{"actor":{"display_login":"safield"}}