{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/186631071","pull_request_review_id":118244618,"id":186631071,"diff_hunk":"@@ -0,0 +1,57 @@\n+{ config, lib, pkgs, ... }:\n+\n+with lib;\n+\n+let\n+  cfg = config.services.telnet;\n+\n+in\n+{\n+\n+  options.services.telnet = {\n+\n+    enable = mkOption {\n+      default = false;\n+      type = types.bool;\n+      description = ''\n+        Enable telnetd.\n+      '';\n+    };\n+\n+    port = mkOption {\n+      default = 12345;\n+      type = types.int;\n+      description = ''\n+        Port on which to listen.\n+      '';\n+    };\n+\n+  };\n+\n+  config = mkIf config.services.telnet.enable {\n+\n+    networking.firewall.allowedUDPPorts =  [ cfg.port ];","path":"nixos/modules/services/web-servers/telnet.nix","position":33,"original_position":33,"commit_id":"7e3cd9302f8b88eec4d7ddf23be676592fb4e2e2","original_commit_id":"7e3cd9302f8b88eec4d7ddf23be676592fb4e2e2","user":{"login":"teto","id":886074,"avatar_url":"https://avatars0.githubusercontent.com/u/886074?v=4","gravatar_id":"","url":"https://api.github.com/users/teto","html_url":"https://github.com/teto","followers_url":"https://api.github.com/users/teto/followers","following_url":"https://api.github.com/users/teto/following{/other_user}","gists_url":"https://api.github.com/users/teto/gists{/gist_id}","starred_url":"https://api.github.com/users/teto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teto/subscriptions","organizations_url":"https://api.github.com/users/teto/orgs","repos_url":"https://api.github.com/users/teto/repos","events_url":"https://api.github.com/users/teto/events{/privacy}","received_events_url":"https://api.github.com/users/teto/received_events","type":"User","site_admin":false},"body":"ok I fixed it","created_at":"2018-05-08T06:49:35Z","updated_at":"2018-05-08T06:49:35Z","html_url":"https://github.com/NixOS/nixpkgs/pull/40160#discussion_r186631071","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/40160","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/186631071"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/40160#discussion_r186631071"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/40160"}},"in_reply_to_id":186626850},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/40160","id":186511518,"html_url":"https://github.com/NixOS/nixpkgs/pull/40160","diff_url":"https://github.com/NixOS/nixpkgs/pull/40160.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/40160.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/40160","number":40160,"state":"open","locked":false,"title":"telnetd: init module","user":{"login":"teto","id":886074,"avatar_url":"https://avatars0.githubusercontent.com/u/886074?v=4","gravatar_id":"","url":"https://api.github.com/users/teto","html_url":"https://github.com/teto","followers_url":"https://api.github.com/users/teto/followers","following_url":"https://api.github.com/users/teto/following{/other_user}","gists_url":"https://api.github.com/users/teto/gists{/gist_id}","starred_url":"https://api.github.com/users/teto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teto/subscriptions","organizations_url":"https://api.github.com/users/teto/orgs","repos_url":"https://api.github.com/users/teto/repos","events_url":"https://api.github.com/users/teto/events{/privacy}","received_events_url":"https://api.github.com/users/teto/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\nI am trying to package mininet, which I believe rely on mininet.\r\nEitherway it doesn't hurt to have a telnet module.\r\n\r\nIt doesn't seem to work though, I can't connect to it via `telnet 127.0.0.1`. `journalctl -b ` doesn't show any error. I wonder if that's firewall related\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [ ] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2018-05-08T02:30:19Z","updated_at":"2018-05-08T06:49:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"392a5f00154e92e0b7cf2ae94e3db1f2ce8a3f8d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":737642262,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":737642408,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%200","name":"10.rebuild-linux: 0","color":"eeffee","default":false},{"id":60265212,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20nixos","name":"6.topic: nixos","color":"fef2c0","default":false},{"id":290122884,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20module%20(update)","name":"8.has: module (update)","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/40160/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/40160/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/40160/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/7e3cd9302f8b88eec4d7ddf23be676592fb4e2e2","head":{"label":"teto:telnet","ref":"telnet","sha":"7e3cd9302f8b88eec4d7ddf23be676592fb4e2e2","user":{"login":"teto","id":886074,"avatar_url":"https://avatars0.githubusercontent.com/u/886074?v=4","gravatar_id":"","url":"https://api.github.com/users/teto","html_url":"https://github.com/teto","followers_url":"https://api.github.com/users/teto/followers","following_url":"https://api.github.com/users/teto/following{/other_user}","gists_url":"https://api.github.com/users/teto/gists{/gist_id}","starred_url":"https://api.github.com/users/teto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teto/subscriptions","organizations_url":"https://api.github.com/users/teto/orgs","repos_url":"https://api.github.com/users/teto/repos","events_url":"https://api.github.com/users/teto/events{/privacy}","received_events_url":"https://api.github.com/users/teto/received_events","type":"User","site_admin":false},"repo":{"id":61347607,"name":"nixpkgs","full_name":"teto/nixpkgs","owner":{"login":"teto","id":886074,"avatar_url":"https://avatars0.githubusercontent.com/u/886074?v=4","gravatar_id":"","url":"https://api.github.com/users/teto","html_url":"https://github.com/teto","followers_url":"https://api.github.com/users/teto/followers","following_url":"https://api.github.com/users/teto/following{/other_user}","gists_url":"https://api.github.com/users/teto/gists{/gist_id}","starred_url":"https://api.github.com/users/teto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teto/subscriptions","organizations_url":"https://api.github.com/users/teto/orgs","repos_url":"https://api.github.com/users/teto/repos","events_url":"https://api.github.com/users/teto/events{/privacy}","received_events_url":"https://api.github.com/users/teto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/teto/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/teto/nixpkgs","forks_url":"https://api.github.com/repos/teto/nixpkgs/forks","keys_url":"https://api.github.com/repos/teto/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teto/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teto/nixpkgs/teams","hooks_url":"https://api.github.com/repos/teto/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/teto/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/teto/nixpkgs/events","assignees_url":"https://api.github.com/repos/teto/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/teto/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/teto/nixpkgs/tags","blobs_url":"https://api.github.com/repos/teto/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teto/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teto/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/teto/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teto/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/teto/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/teto/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/teto/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/teto/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/teto/nixpkgs/subscription","commits_url":"https://api.github.com/repos/teto/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/teto/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/teto/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/teto/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/teto/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/teto/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teto/nixpkgs/merges","archive_url":"https://api.github.com/repos/teto/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teto/nixpkgs/downloads","issues_url":"https://api.github.com/repos/teto/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/teto/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/teto/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/teto/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teto/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/teto/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/teto/nixpkgs/deployments","created_at":"2016-06-17T05:22:26Z","updated_at":"2018-05-07T05:52:25Z","pushed_at":"2018-05-08T02:21:23Z","git_url":"git://github.com/teto/nixpkgs.git","ssh_url":"git@github.com:teto/nixpkgs.git","clone_url":"https://github.com/teto/nixpkgs.git","svn_url":"https://github.com/teto/nixpkgs","homepage":null,"size":678029,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"78b4b90d6c9a3310b8a8ba3ac450240d03199bf0","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-05-08T06:47:11Z","pushed_at":"2018-05-08T06:43:41Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":784786,"stargazers_count":2414,"watchers_count":2414,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2753,"mirror_url":null,"archived":false,"open_issues_count":3073,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2753,"open_issues":3073,"watchers":2414,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/40160"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/40160"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/40160"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/40160/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/40160/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/40160/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/7e3cd9302f8b88eec4d7ddf23be676592fb4e2e2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"teto"}}