{"action":"created","issue":{"url":"https://api.github.com/repos/diasurgical/devilution/issues/409","repository_url":"https://api.github.com/repos/diasurgical/devilution","labels_url":"https://api.github.com/repos/diasurgical/devilution/issues/409/labels{/name}","comments_url":"https://api.github.com/repos/diasurgical/devilution/issues/409/comments","events_url":"https://api.github.com/repos/diasurgical/devilution/issues/409/events","html_url":"https://github.com/diasurgical/devilution/pull/409","id":369589695,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNDk1OTE5","number":409,"title":"msgcmd.cpp rewrite","user":{"login":"squidcc","id":7574530,"node_id":"MDQ6VXNlcjc1NzQ1MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/7574530?v=4","gravatar_id":"","url":"https://api.github.com/users/squidcc","html_url":"https://github.com/squidcc","followers_url":"https://api.github.com/users/squidcc/followers","following_url":"https://api.github.com/users/squidcc/following{/other_user}","gists_url":"https://api.github.com/users/squidcc/gists{/gist_id}","starred_url":"https://api.github.com/users/squidcc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squidcc/subscriptions","organizations_url":"https://api.github.com/users/squidcc/orgs","repos_url":"https://api.github.com/users/squidcc/repos","events_url":"https://api.github.com/users/squidcc/events{/privacy}","received_events_url":"https://api.github.com/users/squidcc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-12T15:01:06Z","updated_at":"2018-10-12T16:34:49Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/diasurgical/devilution/pulls/409","html_url":"https://github.com/diasurgical/devilution/pull/409","diff_url":"https://github.com/diasurgical/devilution/pull/409.diff","patch_url":"https://github.com/diasurgical/devilution/pull/409.patch"},"body":"use original double-linked list implementation in msgcmd.cpp\r\nVC6: disable C++ exception handling, disable precompiled header, enable identical COMDAT folding. This merges identical functions, so calls to empty \"do nothing\" functions should all end up calling MI_Dummy().\r\nmingw: use static libstdc++\r\n\r\nI think this code is all bin-exact but can't use the comparer to confirm. Here are the new function names and the corresponding locations in the retail build:\r\n```\r\nmsgcmd_cmd_cleanup - 0x43F88D\r\nmsgcmd_send_chat - 0x43F897\r\nmsgcmd_add_server_cmd_W - 0x43F8D4\r\nmsgcmd_add_server_cmd - 0x43F8E5\r\nEXTERNMESSAGE::scalar_destruct - 0x43F9E5\r\nTLink<EXTERNMESSAGE>::Unlink - 0x43FA98\r\nTList<EXTERNMESSAGE>::TList<EXTERNMESSAGE> - 0x43F920\r\nTList<EXTERNMESSAGE>::DeleteAll - 0x43F936\r\nTList<EXTERNMESSAGE>::Remove - 0x43F95E\r\nTList<EXTERNMESSAGE>::Create - 0x43F999\r\nTList<EXTERNMESSAGE>::UnlinkAll - 0x43FA85\r\nTList<EXTERNMESSAGE>::Insert - 0x43FA14\r\n```"},"comment":{"url":"https://api.github.com/repos/diasurgical/devilution/issues/comments/429385543","html_url":"https://github.com/diasurgical/devilution/pull/409#issuecomment-429385543","issue_url":"https://api.github.com/repos/diasurgical/devilution/issues/409","id":429385543,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTM4NTU0Mw==","user":{"login":"squidcc","id":7574530,"node_id":"MDQ6VXNlcjc1NzQ1MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/7574530?v=4","gravatar_id":"","url":"https://api.github.com/users/squidcc","html_url":"https://github.com/squidcc","followers_url":"https://api.github.com/users/squidcc/followers","following_url":"https://api.github.com/users/squidcc/following{/other_user}","gists_url":"https://api.github.com/users/squidcc/gists{/gist_id}","starred_url":"https://api.github.com/users/squidcc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squidcc/subscriptions","organizations_url":"https://api.github.com/users/squidcc/orgs","repos_url":"https://api.github.com/users/squidcc/repos","events_url":"https://api.github.com/users/squidcc/events{/privacy}","received_events_url":"https://api.github.com/users/squidcc/received_events","type":"User","site_admin":false},"created_at":"2018-10-12T16:34:49Z","updated_at":"2018-10-12T16:34:49Z","author_association":"CONTRIBUTOR","body":"Apparently travis is pulling the \"stable\" docker image which isn't the one with the extra headers included."}}
{"actor":{"display_login":"squidcc"}}