{"action":"created","issue":{"url":"https://api.github.com/repos/trezor/hd-wallet/issues/25","repository_url":"https://api.github.com/repos/trezor/hd-wallet","labels_url":"https://api.github.com/repos/trezor/hd-wallet/issues/25/labels{/name}","comments_url":"https://api.github.com/repos/trezor/hd-wallet/issues/25/comments","events_url":"https://api.github.com/repos/trezor/hd-wallet/issues/25/events","html_url":"https://github.com/trezor/hd-wallet/pull/25","id":351067569,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NzU0MTg0","number":25,"title":"Bitcoinjs trezor + new flow","user":{"login":"karel-3d","id":104945,"node_id":"MDQ6VXNlcjEwNDk0NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/104945?v=4","gravatar_id":"","url":"https://api.github.com/users/karel-3d","html_url":"https://github.com/karel-3d","followers_url":"https://api.github.com/users/karel-3d/followers","following_url":"https://api.github.com/users/karel-3d/following{/other_user}","gists_url":"https://api.github.com/users/karel-3d/gists{/gist_id}","starred_url":"https://api.github.com/users/karel-3d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karel-3d/subscriptions","organizations_url":"https://api.github.com/users/karel-3d/orgs","repos_url":"https://api.github.com/users/karel-3d/repos","events_url":"https://api.github.com/users/karel-3d/events{/privacy}","received_events_url":"https://api.github.com/users/karel-3d/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-16T06:08:57Z","updated_at":"2018-12-18T16:03:37Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/trezor/hd-wallet/pulls/25","html_url":"https://github.com/trezor/hd-wallet/pull/25","diff_url":"https://github.com/trezor/hd-wallet/pull/25.diff","patch_url":"https://github.com/trezor/hd-wallet/pull/25.patch"},"body":"Use correctly changes here\r\n\r\nhttps://github.com/trezor/bitcoinjs-trezor/pull/1\r\n\r\nand  add new flow\r\n\r\nI have added new Flow because I checked the API changes with Flow, and old Flow showed some errors\r\n\r\nI have moved the flowconfig to root, since using it from src/ always caused some issues\r\n\r\nNote that the version string in package.json will need to be changed after the bitcoinjs-trezor is in npm"},"comment":{"url":"https://api.github.com/repos/trezor/hd-wallet/issues/comments/448272584","html_url":"https://github.com/trezor/hd-wallet/pull/25#issuecomment-448272584","issue_url":"https://api.github.com/repos/trezor/hd-wallet/issues/25","id":448272584,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0ODI3MjU4NA==","user":{"login":"karel-3d","id":104945,"node_id":"MDQ6VXNlcjEwNDk0NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/104945?v=4","gravatar_id":"","url":"https://api.github.com/users/karel-3d","html_url":"https://github.com/karel-3d","followers_url":"https://api.github.com/users/karel-3d/followers","following_url":"https://api.github.com/users/karel-3d/following{/other_user}","gists_url":"https://api.github.com/users/karel-3d/gists{/gist_id}","starred_url":"https://api.github.com/users/karel-3d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karel-3d/subscriptions","organizations_url":"https://api.github.com/users/karel-3d/orgs","repos_url":"https://api.github.com/users/karel-3d/repos","events_url":"https://api.github.com/users/karel-3d/events{/privacy}","received_events_url":"https://api.github.com/users/karel-3d/received_events","type":"User","site_admin":false},"created_at":"2018-12-18T16:03:37Z","updated_at":"2018-12-18T16:03:37Z","author_association":"MEMBER","body":"I have updated this branch to be with all the new tests and all the new eslint.\r\n\r\nIt seems the new bitcoinjs-trezor is working! Hurray!\r\n\r\n(I have published the current version of bitcoinjs-trezor to bitcoinjs-trezor-alpha to npm)\r\n\r\nTheoretically it can actually be merged now, because hd-wallet does not actually expose bitcoinjs objects in its API, I have realized\r\n\r\nBUT that would mean we would have two versions of bitcoinjs-lib in mytrezor and connect, which would not break anything! But it would be ugly\r\n\r\nBut good to know that it works and builds and all tests (95 coverage both branch and lines) work. So we can safely update"}}
{"actor":{"display_login":"karel-3d"}}