{"action":"created","comment":{"url":"https://api.github.com/repos/rancher/rancher/pulls/comments/170416471","pull_request_review_id":99107751,"id":170416471,"diff_hunk":"@@ -154,13 +172,13 @@ func (w *NodeWatcher) checkNodeCPUUsage(node *corev1.Node, alert *v3.ClusterAler\n \t}\n }\n \n-func (w *NodeWatcher) checkNodeReady(node *corev1.Node, alert *v3.ClusterAlert) {\n+func (w *NodeWatcher) checkNodeReady(alert *v3.ClusterAlert, machine *v3.Node) {\n \talertID := alert.Namespace + \"-\" + alert.Name\n-\tfor _, cond := range node.Status.Conditions {\n+\tfor _, cond := range machine.Status.InternalNodeStatus.Conditions {\n \t\tif cond.Type == corev1.NodeReady {\n \t\t\tif cond.Status == corev1.ConditionFalse {\n \n-\t\t\t\ttitle := fmt.Sprintf(\"The kubelet on the node %s is not healthy\", node.Name)\n+\t\t\t\ttitle := fmt.Sprintf(\"The kubelet on the node %s is not healthy\", getNodeName(machine))\n \t\t\t\tdesc := fmt.Sprintf(\"*Alert Name*: %s\\n*Cluster Name*: %s\\n*Logs*: %s\", alert.Spec.DisplayName, w.clusterName, cond.Message)\n \n \t\t\t\tif err := w.alertManager.SendAlert(alertID, desc, title, alert.Spec.Severity); err != nil {","path":"pkg/controllers/user/alert/watcher/node.go","position":125,"original_position":125,"commit_id":"cc7d39ccca259b9f0bb16de522138eba27bd6789","original_commit_id":"cc7d39ccca259b9f0bb16de522138eba27bd6789","user":{"login":"aiwantaozi","id":5936271,"avatar_url":"https://avatars0.githubusercontent.com/u/5936271?v=4","gravatar_id":"","url":"https://api.github.com/users/aiwantaozi","html_url":"https://github.com/aiwantaozi","followers_url":"https://api.github.com/users/aiwantaozi/followers","following_url":"https://api.github.com/users/aiwantaozi/following{/other_user}","gists_url":"https://api.github.com/users/aiwantaozi/gists{/gist_id}","starred_url":"https://api.github.com/users/aiwantaozi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aiwantaozi/subscriptions","organizations_url":"https://api.github.com/users/aiwantaozi/orgs","repos_url":"https://api.github.com/users/aiwantaozi/repos","events_url":"https://api.github.com/users/aiwantaozi/events{/privacy}","received_events_url":"https://api.github.com/users/aiwantaozi/received_events","type":"User","site_admin":false},"body":"is that ok we only use debug log？","created_at":"2018-02-24T09:10:57Z","updated_at":"2018-02-24T09:10:57Z","html_url":"https://github.com/rancher/rancher/pull/11616#discussion_r170416471","pull_request_url":"https://api.github.com/repos/rancher/rancher/pulls/11616","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rancher/rancher/pulls/comments/170416471"},"html":{"href":"https://github.com/rancher/rancher/pull/11616#discussion_r170416471"},"pull_request":{"href":"https://api.github.com/repos/rancher/rancher/pulls/11616"}}},"pull_request":{"url":"https://api.github.com/repos/rancher/rancher/pulls/11616","id":171167312,"html_url":"https://github.com/rancher/rancher/pull/11616","diff_url":"https://github.com/rancher/rancher/pull/11616.diff","patch_url":"https://github.com/rancher/rancher/pull/11616.patch","issue_url":"https://api.github.com/repos/rancher/rancher/issues/11616","number":11616,"state":"open","locked":false,"title":"Fix bugs in node watcher and add comments to controllers","user":{"login":"zionwu","id":1213386,"avatar_url":"https://avatars2.githubusercontent.com/u/1213386?v=4","gravatar_id":"","url":"https://api.github.com/users/zionwu","html_url":"https://github.com/zionwu","followers_url":"https://api.github.com/users/zionwu/followers","following_url":"https://api.github.com/users/zionwu/following{/other_user}","gists_url":"https://api.github.com/users/zionwu/gists{/gist_id}","starred_url":"https://api.github.com/users/zionwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zionwu/subscriptions","organizations_url":"https://api.github.com/users/zionwu/orgs","repos_url":"https://api.github.com/users/zionwu/repos","events_url":"https://api.github.com/users/zionwu/events{/privacy}","received_events_url":"https://api.github.com/users/zionwu/received_events","type":"User","site_admin":false},"body":"1. fix issue https://github.com/rancher/rancher/issues/11608\r\n2. add comments to controller.","created_at":"2018-02-24T07:52:38Z","updated_at":"2018-02-24T09:10:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"397d6837e5a9055f4c4234a9e9b79c643d136b31","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rancher/rancher/pulls/11616/commits","review_comments_url":"https://api.github.com/repos/rancher/rancher/pulls/11616/comments","review_comment_url":"https://api.github.com/repos/rancher/rancher/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rancher/rancher/issues/11616/comments","statuses_url":"https://api.github.com/repos/rancher/rancher/statuses/cc7d39ccca259b9f0bb16de522138eba27bd6789","head":{"label":"zionwu:fixemail","ref":"fixemail","sha":"cc7d39ccca259b9f0bb16de522138eba27bd6789","user":{"login":"zionwu","id":1213386,"avatar_url":"https://avatars2.githubusercontent.com/u/1213386?v=4","gravatar_id":"","url":"https://api.github.com/users/zionwu","html_url":"https://github.com/zionwu","followers_url":"https://api.github.com/users/zionwu/followers","following_url":"https://api.github.com/users/zionwu/following{/other_user}","gists_url":"https://api.github.com/users/zionwu/gists{/gist_id}","starred_url":"https://api.github.com/users/zionwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zionwu/subscriptions","organizations_url":"https://api.github.com/users/zionwu/orgs","repos_url":"https://api.github.com/users/zionwu/repos","events_url":"https://api.github.com/users/zionwu/events{/privacy}","received_events_url":"https://api.github.com/users/zionwu/received_events","type":"User","site_admin":false},"repo":{"id":119182193,"name":"rancher","full_name":"zionwu/rancher","owner":{"login":"zionwu","id":1213386,"avatar_url":"https://avatars2.githubusercontent.com/u/1213386?v=4","gravatar_id":"","url":"https://api.github.com/users/zionwu","html_url":"https://github.com/zionwu","followers_url":"https://api.github.com/users/zionwu/followers","following_url":"https://api.github.com/users/zionwu/following{/other_user}","gists_url":"https://api.github.com/users/zionwu/gists{/gist_id}","starred_url":"https://api.github.com/users/zionwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zionwu/subscriptions","organizations_url":"https://api.github.com/users/zionwu/orgs","repos_url":"https://api.github.com/users/zionwu/repos","events_url":"https://api.github.com/users/zionwu/events{/privacy}","received_events_url":"https://api.github.com/users/zionwu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zionwu/rancher","description":"Complete container management platform","fork":true,"url":"https://api.github.com/repos/zionwu/rancher","forks_url":"https://api.github.com/repos/zionwu/rancher/forks","keys_url":"https://api.github.com/repos/zionwu/rancher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zionwu/rancher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zionwu/rancher/teams","hooks_url":"https://api.github.com/repos/zionwu/rancher/hooks","issue_events_url":"https://api.github.com/repos/zionwu/rancher/issues/events{/number}","events_url":"https://api.github.com/repos/zionwu/rancher/events","assignees_url":"https://api.github.com/repos/zionwu/rancher/assignees{/user}","branches_url":"https://api.github.com/repos/zionwu/rancher/branches{/branch}","tags_url":"https://api.github.com/repos/zionwu/rancher/tags","blobs_url":"https://api.github.com/repos/zionwu/rancher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zionwu/rancher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zionwu/rancher/git/refs{/sha}","trees_url":"https://api.github.com/repos/zionwu/rancher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zionwu/rancher/statuses/{sha}","languages_url":"https://api.github.com/repos/zionwu/rancher/languages","stargazers_url":"https://api.github.com/repos/zionwu/rancher/stargazers","contributors_url":"https://api.github.com/repos/zionwu/rancher/contributors","subscribers_url":"https://api.github.com/repos/zionwu/rancher/subscribers","subscription_url":"https://api.github.com/repos/zionwu/rancher/subscription","commits_url":"https://api.github.com/repos/zionwu/rancher/commits{/sha}","git_commits_url":"https://api.github.com/repos/zionwu/rancher/git/commits{/sha}","comments_url":"https://api.github.com/repos/zionwu/rancher/comments{/number}","issue_comment_url":"https://api.github.com/repos/zionwu/rancher/issues/comments{/number}","contents_url":"https://api.github.com/repos/zionwu/rancher/contents/{+path}","compare_url":"https://api.github.com/repos/zionwu/rancher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zionwu/rancher/merges","archive_url":"https://api.github.com/repos/zionwu/rancher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zionwu/rancher/downloads","issues_url":"https://api.github.com/repos/zionwu/rancher/issues{/number}","pulls_url":"https://api.github.com/repos/zionwu/rancher/pulls{/number}","milestones_url":"https://api.github.com/repos/zionwu/rancher/milestones{/number}","notifications_url":"https://api.github.com/repos/zionwu/rancher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zionwu/rancher/labels{/name}","releases_url":"https://api.github.com/repos/zionwu/rancher/releases{/id}","deployments_url":"https://api.github.com/repos/zionwu/rancher/deployments","created_at":"2018-01-27T16:41:36Z","updated_at":"2018-01-27T16:41:40Z","pushed_at":"2018-02-24T08:44:56Z","git_url":"git://github.com/zionwu/rancher.git","ssh_url":"git@github.com:zionwu/rancher.git","clone_url":"https://github.com/zionwu/rancher.git","svn_url":"https://github.com/zionwu/rancher","homepage":"http://rancher.com","size":39800,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rancher:master","ref":"master","sha":"ca49d96e2c0817e31739a71d5074ee95edbe0964","user":{"login":"rancher","id":9343010,"avatar_url":"https://avatars3.githubusercontent.com/u/9343010?v=4","gravatar_id":"","url":"https://api.github.com/users/rancher","html_url":"https://github.com/rancher","followers_url":"https://api.github.com/users/rancher/followers","following_url":"https://api.github.com/users/rancher/following{/other_user}","gists_url":"https://api.github.com/users/rancher/gists{/gist_id}","starred_url":"https://api.github.com/users/rancher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rancher/subscriptions","organizations_url":"https://api.github.com/users/rancher/orgs","repos_url":"https://api.github.com/users/rancher/repos","events_url":"https://api.github.com/users/rancher/events{/privacy}","received_events_url":"https://api.github.com/users/rancher/received_events","type":"Organization","site_admin":false},"repo":{"id":26337322,"name":"rancher","full_name":"rancher/rancher","owner":{"login":"rancher","id":9343010,"avatar_url":"https://avatars3.githubusercontent.com/u/9343010?v=4","gravatar_id":"","url":"https://api.github.com/users/rancher","html_url":"https://github.com/rancher","followers_url":"https://api.github.com/users/rancher/followers","following_url":"https://api.github.com/users/rancher/following{/other_user}","gists_url":"https://api.github.com/users/rancher/gists{/gist_id}","starred_url":"https://api.github.com/users/rancher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rancher/subscriptions","organizations_url":"https://api.github.com/users/rancher/orgs","repos_url":"https://api.github.com/users/rancher/repos","events_url":"https://api.github.com/users/rancher/events{/privacy}","received_events_url":"https://api.github.com/users/rancher/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rancher/rancher","description":"Complete container management platform","fork":false,"url":"https://api.github.com/repos/rancher/rancher","forks_url":"https://api.github.com/repos/rancher/rancher/forks","keys_url":"https://api.github.com/repos/rancher/rancher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rancher/rancher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rancher/rancher/teams","hooks_url":"https://api.github.com/repos/rancher/rancher/hooks","issue_events_url":"https://api.github.com/repos/rancher/rancher/issues/events{/number}","events_url":"https://api.github.com/repos/rancher/rancher/events","assignees_url":"https://api.github.com/repos/rancher/rancher/assignees{/user}","branches_url":"https://api.github.com/repos/rancher/rancher/branches{/branch}","tags_url":"https://api.github.com/repos/rancher/rancher/tags","blobs_url":"https://api.github.com/repos/rancher/rancher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rancher/rancher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rancher/rancher/git/refs{/sha}","trees_url":"https://api.github.com/repos/rancher/rancher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rancher/rancher/statuses/{sha}","languages_url":"https://api.github.com/repos/rancher/rancher/languages","stargazers_url":"https://api.github.com/repos/rancher/rancher/stargazers","contributors_url":"https://api.github.com/repos/rancher/rancher/contributors","subscribers_url":"https://api.github.com/repos/rancher/rancher/subscribers","subscription_url":"https://api.github.com/repos/rancher/rancher/subscription","commits_url":"https://api.github.com/repos/rancher/rancher/commits{/sha}","git_commits_url":"https://api.github.com/repos/rancher/rancher/git/commits{/sha}","comments_url":"https://api.github.com/repos/rancher/rancher/comments{/number}","issue_comment_url":"https://api.github.com/repos/rancher/rancher/issues/comments{/number}","contents_url":"https://api.github.com/repos/rancher/rancher/contents/{+path}","compare_url":"https://api.github.com/repos/rancher/rancher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rancher/rancher/merges","archive_url":"https://api.github.com/repos/rancher/rancher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rancher/rancher/downloads","issues_url":"https://api.github.com/repos/rancher/rancher/issues{/number}","pulls_url":"https://api.github.com/repos/rancher/rancher/pulls{/number}","milestones_url":"https://api.github.com/repos/rancher/rancher/milestones{/number}","notifications_url":"https://api.github.com/repos/rancher/rancher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rancher/rancher/labels{/name}","releases_url":"https://api.github.com/repos/rancher/rancher/releases{/id}","deployments_url":"https://api.github.com/repos/rancher/rancher/deployments","created_at":"2014-11-07T20:49:31Z","updated_at":"2018-02-24T07:19:12Z","pushed_at":"2018-02-24T08:44:58Z","git_url":"git://github.com/rancher/rancher.git","ssh_url":"git@github.com:rancher/rancher.git","clone_url":"https://github.com/rancher/rancher.git","svn_url":"https://github.com/rancher/rancher","homepage":"http://rancher.com","size":25728,"stargazers_count":7767,"watchers_count":7767,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":755,"mirror_url":null,"archived":false,"open_issues_count":1868,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":755,"open_issues":1868,"watchers":7767,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rancher/rancher/pulls/11616"},"html":{"href":"https://github.com/rancher/rancher/pull/11616"},"issue":{"href":"https://api.github.com/repos/rancher/rancher/issues/11616"},"comments":{"href":"https://api.github.com/repos/rancher/rancher/issues/11616/comments"},"review_comments":{"href":"https://api.github.com/repos/rancher/rancher/pulls/11616/comments"},"review_comment":{"href":"https://api.github.com/repos/rancher/rancher/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rancher/rancher/pulls/11616/commits"},"statuses":{"href":"https://api.github.com/repos/rancher/rancher/statuses/cc7d39ccca259b9f0bb16de522138eba27bd6789"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"aiwantaozi"}}