{"comment":{"url":"https://api.github.com/repos/synicalsyntax/zulip/comments/29891006","html_url":"https://github.com/synicalsyntax/zulip/commit/e5730c3114b37fa063e527a90bb8555ab7e84dcf#commitcomment-29891006","id":29891006,"node_id":"MDEzOkNvbW1pdENvbW1lbnQyOTg5MTAwNg==","user":{"login":"showell","id":142908,"node_id":"MDQ6VXNlcjE0MjkwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/142908?v=4","gravatar_id":"","url":"https://api.github.com/users/showell","html_url":"https://github.com/showell","followers_url":"https://api.github.com/users/showell/followers","following_url":"https://api.github.com/users/showell/following{/other_user}","gists_url":"https://api.github.com/users/showell/gists{/gist_id}","starred_url":"https://api.github.com/users/showell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/showell/subscriptions","organizations_url":"https://api.github.com/users/showell/orgs","repos_url":"https://api.github.com/users/showell/repos","events_url":"https://api.github.com/users/showell/events{/privacy}","received_events_url":"https://api.github.com/users/showell/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":null,"commit_id":"e5730c3114b37fa063e527a90bb8555ab7e84dcf","created_at":"2018-07-30T17:38:06Z","updated_at":"2018-07-30T17:38:06Z","author_association":"NONE","body":"This seems reasonable to me.  Ideally we'd just support all four commands on the server, but then we'd still need to change the client code the way things are currently set up.  If you make a PR for this, I'll merge it, but we might revisit the code a bit when we start supporting autocomplete and start making this work for non-web clients like mobile.\r\n\r\nIf you do go with a server-side fix, then the client code can just have something like this:\r\n\r\n~~~ js\r\nvar simple_commands = ['/day', '/light', '/dark', '/night'];\r\nif (simple_commands.indexOf(content) >= 0) {\r\n    update_setting(content)\r\n    return true;\r\n}"}}
{"actor":{"display_login":"showell"}}