{"action":"created","issue":{"url":"https://api.github.com/repos/tendermint/signatory/issues/30","repository_url":"https://api.github.com/repos/tendermint/signatory","labels_url":"https://api.github.com/repos/tendermint/signatory/issues/30/labels{/name}","comments_url":"https://api.github.com/repos/tendermint/signatory/issues/30/comments","events_url":"https://api.github.com/repos/tendermint/signatory/issues/30/events","html_url":"https://github.com/tendermint/signatory/pull/30","id":323186805,"number":30,"title":"Fix benchmarks","user":{"login":"tarcieri","id":797,"avatar_url":"https://avatars2.githubusercontent.com/u/797?v=4","gravatar_id":"","url":"https://api.github.com/users/tarcieri","html_url":"https://github.com/tarcieri","followers_url":"https://api.github.com/users/tarcieri/followers","following_url":"https://api.github.com/users/tarcieri/following{/other_user}","gists_url":"https://api.github.com/users/tarcieri/gists{/gist_id}","starred_url":"https://api.github.com/users/tarcieri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarcieri/subscriptions","organizations_url":"https://api.github.com/users/tarcieri/orgs","repos_url":"https://api.github.com/users/tarcieri/repos","events_url":"https://api.github.com/users/tarcieri/events{/privacy}","received_events_url":"https://api.github.com/users/tarcieri/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-15T12:01:04Z","updated_at":"2018-05-15T16:58:59Z","closed_at":"2018-05-15T12:10:12Z","author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/tendermint/signatory/pulls/30","html_url":"https://github.com/tendermint/signatory/pull/30","diff_url":"https://github.com/tendermint/signatory/pull/30.diff","patch_url":"https://github.com/tendermint/signatory/pull/30.patch"},"body":"Benchmarks were not previously covered by CI, and broke due to API changes.\r\n\r\nThis updates the benchmarks to use the new API, and adds them to CI to ensure they aren't broken by future API changes.\r\n\r\nIdeally we'd just ensure the benchmarks compile as opposed to actually running them in CI, but I can't figure out exactly how to do that with criterion."},"comment":{"url":"https://api.github.com/repos/tendermint/signatory/issues/comments/389239455","html_url":"https://github.com/tendermint/signatory/pull/30#issuecomment-389239455","issue_url":"https://api.github.com/repos/tendermint/signatory/issues/30","id":389239455,"user":{"login":"tarcieri","id":797,"avatar_url":"https://avatars2.githubusercontent.com/u/797?v=4","gravatar_id":"","url":"https://api.github.com/users/tarcieri","html_url":"https://github.com/tarcieri","followers_url":"https://api.github.com/users/tarcieri/followers","following_url":"https://api.github.com/users/tarcieri/following{/other_user}","gists_url":"https://api.github.com/users/tarcieri/gists{/gist_id}","starred_url":"https://api.github.com/users/tarcieri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarcieri/subscriptions","organizations_url":"https://api.github.com/users/tarcieri/orgs","repos_url":"https://api.github.com/users/tarcieri/repos","events_url":"https://api.github.com/users/tarcieri/events{/privacy}","received_events_url":"https://api.github.com/users/tarcieri/received_events","type":"User","site_admin":false},"created_at":"2018-05-15T16:58:59Z","updated_at":"2018-05-15T16:58:59Z","author_association":"COLLABORATOR","body":"@hdevalence got this to build but not run the benchmarks already in #31 "}}
{"actor":{"display_login":"tarcieri"}}