{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/240020009","pull_request_review_id":182960848,"id":240020009,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDAyMDAwOQ==","diff_hunk":"@@ -1,15 +1,15 @@\n // RUN: %empty-directory(%t)\n \n-// RUN: %target-build-swift-dylib(%t/libresilient_struct.%target-dylib-extension) -Xfrontend -enable-resilience -Xfrontend -enable-class-resilience %S/../../Inputs/resilient_struct.swift -emit-module -emit-module-path %t/resilient_struct.swiftmodule -module-name resilient_struct\n-// RUN: %target-codesign %t/libresilient_struct.%target-dylib-extension\n+// RUN: %target-build-swift-dylib(%t/%{target-shared-library-prefix}resilient_struct%{target-shared-library-suffix}) -Xfrontend -enable-resilience -Xfrontend -enable-class-resilience %S/../../Inputs/resilient_struct.swift -emit-module -emit-module-path %t/resilient_struct.swiftmodule -module-name resilient_struct","path":"test/Interpreter/SDK/objc_getClass.swift","position":5,"original_position":5,"commit_id":"093484d4be160085988a816981b10d9e419b880b","original_commit_id":"093484d4be160085988a816981b10d9e419b880b","user":{"login":"jrose-apple","id":15097531,"node_id":"MDQ6VXNlcjE1MDk3NTMx","avatar_url":"https://avatars2.githubusercontent.com/u/15097531?v=4","gravatar_id":"","url":"https://api.github.com/users/jrose-apple","html_url":"https://github.com/jrose-apple","followers_url":"https://api.github.com/users/jrose-apple/followers","following_url":"https://api.github.com/users/jrose-apple/following{/other_user}","gists_url":"https://api.github.com/users/jrose-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/jrose-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrose-apple/subscriptions","organizations_url":"https://api.github.com/users/jrose-apple/orgs","repos_url":"https://api.github.com/users/jrose-apple/repos","events_url":"https://api.github.com/users/jrose-apple/events{/privacy}","received_events_url":"https://api.github.com/users/jrose-apple/received_events","type":"User","site_admin":false},"body":"This pattern is very verbose. Maybe we should make it another regex-based substitution? `%target-shared-library(resilient_struct)`.","created_at":"2018-12-09T00:00:03Z","updated_at":"2018-12-09T00:00:03Z","html_url":"https://github.com/apple/swift/pull/21152#discussion_r240020009","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/21152","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/240020009"},"html":{"href":"https://github.com/apple/swift/pull/21152#discussion_r240020009"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/21152"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/21152","id":237097376,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MDk3Mzc2","html_url":"https://github.com/apple/swift/pull/21152","diff_url":"https://github.com/apple/swift/pull/21152.diff","patch_url":"https://github.com/apple/swift/pull/21152.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/21152","number":21152,"state":"open","locked":false,"title":"test: add and use prefix substitutions for libraries","user":{"login":"compnerd","id":63311,"node_id":"MDQ6VXNlcjYzMzEx","avatar_url":"https://avatars3.githubusercontent.com/u/63311?v=4","gravatar_id":"","url":"https://api.github.com/users/compnerd","html_url":"https://github.com/compnerd","followers_url":"https://api.github.com/users/compnerd/followers","following_url":"https://api.github.com/users/compnerd/following{/other_user}","gists_url":"https://api.github.com/users/compnerd/gists{/gist_id}","starred_url":"https://api.github.com/users/compnerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compnerd/subscriptions","organizations_url":"https://api.github.com/users/compnerd/orgs","repos_url":"https://api.github.com/users/compnerd/repos","events_url":"https://api.github.com/users/compnerd/events{/privacy}","received_events_url":"https://api.github.com/users/compnerd/received_events","type":"User","site_admin":false},"body":"The naming convention is different on Windows than on Unix-like\r\nenvironments.  In order to follow the convention we need to substitute\r\nthe prefix and the suffix.  Take the opportunity to rename the\r\n`target-dylib-extension` to the CMake-like variable\r\n`target-shared-library-suffix` and introduce\r\n`target-shared-library-prefix`.  This helps linking the test suite\r\nbinaries on Windows.\r\n\r\n<!-- What's in this pull request? -->\r\nReplace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.\r\n\r\n<!-- If this pull request resolves any bugs in the Swift bug tracker, provide a link: -->\r\nResolves [SR-NNNN](https://bugs.swift.org/browse/SR-NNNN).\r\n\r\n<!--\r\nBefore merging this pull request, you must run the Swift continuous integration tests.\r\nFor information about triggering CI builds via @swift-ci, see:\r\nhttps://github.com/apple/swift/blob/master/docs/ContinuousIntegration.md#swift-ci\r\n\r\nThank you for your contribution to Swift!\r\n-->\r\n","created_at":"2018-12-08T23:21:48Z","updated_at":"2018-12-09T00:00:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ad2135a9ed31738dc608a8d29f6f9c560ac0686","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/21152/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/21152/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/21152/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/093484d4be160085988a816981b10d9e419b880b","head":{"label":"compnerd:library-prefix-suffix","ref":"library-prefix-suffix","sha":"093484d4be160085988a816981b10d9e419b880b","user":{"login":"compnerd","id":63311,"node_id":"MDQ6VXNlcjYzMzEx","avatar_url":"https://avatars3.githubusercontent.com/u/63311?v=4","gravatar_id":"","url":"https://api.github.com/users/compnerd","html_url":"https://github.com/compnerd","followers_url":"https://api.github.com/users/compnerd/followers","following_url":"https://api.github.com/users/compnerd/following{/other_user}","gists_url":"https://api.github.com/users/compnerd/gists{/gist_id}","starred_url":"https://api.github.com/users/compnerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compnerd/subscriptions","organizations_url":"https://api.github.com/users/compnerd/orgs","repos_url":"https://api.github.com/users/compnerd/repos","events_url":"https://api.github.com/users/compnerd/events{/privacy}","received_events_url":"https://api.github.com/users/compnerd/received_events","type":"User","site_admin":false},"repo":{"id":47945459,"node_id":"MDEwOlJlcG9zaXRvcnk0Nzk0NTQ1OQ==","name":"apple-swift","full_name":"compnerd/apple-swift","private":false,"owner":{"login":"compnerd","id":63311,"node_id":"MDQ6VXNlcjYzMzEx","avatar_url":"https://avatars3.githubusercontent.com/u/63311?v=4","gravatar_id":"","url":"https://api.github.com/users/compnerd","html_url":"https://github.com/compnerd","followers_url":"https://api.github.com/users/compnerd/followers","following_url":"https://api.github.com/users/compnerd/following{/other_user}","gists_url":"https://api.github.com/users/compnerd/gists{/gist_id}","starred_url":"https://api.github.com/users/compnerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compnerd/subscriptions","organizations_url":"https://api.github.com/users/compnerd/orgs","repos_url":"https://api.github.com/users/compnerd/repos","events_url":"https://api.github.com/users/compnerd/events{/privacy}","received_events_url":"https://api.github.com/users/compnerd/received_events","type":"User","site_admin":false},"html_url":"https://github.com/compnerd/apple-swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/compnerd/apple-swift","forks_url":"https://api.github.com/repos/compnerd/apple-swift/forks","keys_url":"https://api.github.com/repos/compnerd/apple-swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/compnerd/apple-swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/compnerd/apple-swift/teams","hooks_url":"https://api.github.com/repos/compnerd/apple-swift/hooks","issue_events_url":"https://api.github.com/repos/compnerd/apple-swift/issues/events{/number}","events_url":"https://api.github.com/repos/compnerd/apple-swift/events","assignees_url":"https://api.github.com/repos/compnerd/apple-swift/assignees{/user}","branches_url":"https://api.github.com/repos/compnerd/apple-swift/branches{/branch}","tags_url":"https://api.github.com/repos/compnerd/apple-swift/tags","blobs_url":"https://api.github.com/repos/compnerd/apple-swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/compnerd/apple-swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/compnerd/apple-swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/compnerd/apple-swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/compnerd/apple-swift/statuses/{sha}","languages_url":"https://api.github.com/repos/compnerd/apple-swift/languages","stargazers_url":"https://api.github.com/repos/compnerd/apple-swift/stargazers","contributors_url":"https://api.github.com/repos/compnerd/apple-swift/contributors","subscribers_url":"https://api.github.com/repos/compnerd/apple-swift/subscribers","subscription_url":"https://api.github.com/repos/compnerd/apple-swift/subscription","commits_url":"https://api.github.com/repos/compnerd/apple-swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/compnerd/apple-swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/compnerd/apple-swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/compnerd/apple-swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/compnerd/apple-swift/contents/{+path}","compare_url":"https://api.github.com/repos/compnerd/apple-swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/compnerd/apple-swift/merges","archive_url":"https://api.github.com/repos/compnerd/apple-swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/compnerd/apple-swift/downloads","issues_url":"https://api.github.com/repos/compnerd/apple-swift/issues{/number}","pulls_url":"https://api.github.com/repos/compnerd/apple-swift/pulls{/number}","milestones_url":"https://api.github.com/repos/compnerd/apple-swift/milestones{/number}","notifications_url":"https://api.github.com/repos/compnerd/apple-swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/compnerd/apple-swift/labels{/name}","releases_url":"https://api.github.com/repos/compnerd/apple-swift/releases{/id}","deployments_url":"https://api.github.com/repos/compnerd/apple-swift/deployments","created_at":"2015-12-14T01:38:31Z","updated_at":"2018-06-13T19:07:30Z","pushed_at":"2018-12-08T23:21:23Z","git_url":"git://github.com/compnerd/apple-swift.git","ssh_url":"git@github.com:compnerd/apple-swift.git","clone_url":"https://github.com/compnerd/apple-swift.git","svn_url":"https://github.com/compnerd/apple-swift","homepage":"https://swift.org/","size":332460,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"29e4c67a72b2ce58235ed5752ab2ce3c515f4ecb","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"node_id":"MDEwOlJlcG9zaXRvcnk0NDgzODk0OQ==","name":"swift","full_name":"apple/swift","private":false,"owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2018-12-08T22:12:46Z","pushed_at":"2018-12-08T23:21:49Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org","size":371819,"stargazers_count":45983,"watchers_count":45983,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7307,"mirror_url":null,"archived":false,"open_issues_count":436,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7307,"open_issues":436,"watchers":45983,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/21152"},"html":{"href":"https://github.com/apple/swift/pull/21152"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/21152"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/21152/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/21152/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/21152/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/093484d4be160085988a816981b10d9e419b880b"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jrose-apple"}}