{"action":"created","issue":{"url":"https://api.github.com/repos/brunorijsman/rift-python/issues/10","repository_url":"https://api.github.com/repos/brunorijsman/rift-python","labels_url":"https://api.github.com/repos/brunorijsman/rift-python/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/brunorijsman/rift-python/issues/10/comments","events_url":"https://api.github.com/repos/brunorijsman/rift-python/issues/10/events","html_url":"https://github.com/brunorijsman/rift-python/pull/10","id":358729356,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0Mzk0Njk3","number":10,"title":"Character a a time mode","user":{"login":"don57hpe","id":16888905,"node_id":"MDQ6VXNlcjE2ODg4OTA1","avatar_url":"https://avatars2.githubusercontent.com/u/16888905?v=4","gravatar_id":"","url":"https://api.github.com/users/don57hpe","html_url":"https://github.com/don57hpe","followers_url":"https://api.github.com/users/don57hpe/followers","following_url":"https://api.github.com/users/don57hpe/following{/other_user}","gists_url":"https://api.github.com/users/don57hpe/gists{/gist_id}","starred_url":"https://api.github.com/users/don57hpe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/don57hpe/subscriptions","organizations_url":"https://api.github.com/users/don57hpe/orgs","repos_url":"https://api.github.com/users/don57hpe/repos","events_url":"https://api.github.com/users/don57hpe/events{/privacy}","received_events_url":"https://api.github.com/users/don57hpe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-09-10T17:56:15Z","updated_at":"2018-09-11T15:40:25Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/brunorijsman/rift-python/pulls/10","html_url":"https://github.com/brunorijsman/rift-python/pull/10","diff_url":"https://github.com/brunorijsman/rift-python/pull/10.diff","patch_url":"https://github.com/brunorijsman/rift-python/pull/10.patch"},"body":"Hi Bruno \r\n\r\nLet me know if this pull request works. "},"comment":{"url":"https://api.github.com/repos/brunorijsman/rift-python/issues/comments/420319213","html_url":"https://github.com/brunorijsman/rift-python/pull/10#issuecomment-420319213","issue_url":"https://api.github.com/repos/brunorijsman/rift-python/issues/10","id":420319213,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDMxOTIxMw==","user":{"login":"don57hpe","id":16888905,"node_id":"MDQ6VXNlcjE2ODg4OTA1","avatar_url":"https://avatars2.githubusercontent.com/u/16888905?v=4","gravatar_id":"","url":"https://api.github.com/users/don57hpe","html_url":"https://github.com/don57hpe","followers_url":"https://api.github.com/users/don57hpe/followers","following_url":"https://api.github.com/users/don57hpe/following{/other_user}","gists_url":"https://api.github.com/users/don57hpe/gists{/gist_id}","starred_url":"https://api.github.com/users/don57hpe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/don57hpe/subscriptions","organizations_url":"https://api.github.com/users/don57hpe/orgs","repos_url":"https://api.github.com/users/don57hpe/repos","events_url":"https://api.github.com/users/don57hpe/events{/privacy}","received_events_url":"https://api.github.com/users/don57hpe/received_events","type":"User","site_admin":false},"created_at":"2018-09-11T15:40:25Z","updated_at":"2018-09-11T15:40:25Z","author_association":"CONTRIBUTOR","body":"OK is this successful now?  \r\nNot sure how you would do code coverage.  I was my intent originally that if you sent a full command just as with line at a time it would work but it would echo each character and terminate with \\r\\n.   (The code could be simplified to have all commands return \\r\\n if the tests were flexible in this aspect. I originally had it that way but the tests failed.  In other words as far as I could tell telnet line at a time treats \\r\\n the same as \\n.  But character mode needs an explicit \\r\\n.  Line at a time must generate a \\r for every line of output terminated with \\n. "}}
{"actor":{"display_login":"don57hpe"}}