{"action":"created","issue":{"url":"https://api.github.com/repos/swapagarwal/swag-for-dev/issues/159","repository_url":"https://api.github.com/repos/swapagarwal/swag-for-dev","labels_url":"https://api.github.com/repos/swapagarwal/swag-for-dev/issues/159/labels{/name}","comments_url":"https://api.github.com/repos/swapagarwal/swag-for-dev/issues/159/comments","events_url":"https://api.github.com/repos/swapagarwal/swag-for-dev/issues/159/events","html_url":"https://github.com/swapagarwal/swag-for-dev/pull/159","id":379566202,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5OTgwMDky","number":159,"title":"Create `expired` tag to mark expired promotions","user":{"login":"itaisteinherz","id":22768990,"node_id":"MDQ6VXNlcjIyNzY4OTkw","avatar_url":"https://avatars3.githubusercontent.com/u/22768990?v=4","gravatar_id":"","url":"https://api.github.com/users/itaisteinherz","html_url":"https://github.com/itaisteinherz","followers_url":"https://api.github.com/users/itaisteinherz/followers","following_url":"https://api.github.com/users/itaisteinherz/following{/other_user}","gists_url":"https://api.github.com/users/itaisteinherz/gists{/gist_id}","starred_url":"https://api.github.com/users/itaisteinherz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itaisteinherz/subscriptions","organizations_url":"https://api.github.com/users/itaisteinherz/orgs","repos_url":"https://api.github.com/users/itaisteinherz/repos","events_url":"https://api.github.com/users/itaisteinherz/events{/privacy}","received_events_url":"https://api.github.com/users/itaisteinherz/received_events","type":"User","site_admin":false},"labels":[{"id":840500352,"node_id":"MDU6TGFiZWw4NDA1MDAzNTI=","url":"https://api.github.com/repos/swapagarwal/swag-for-dev/labels/enhancement","name":"enhancement","color":"a2eeef","default":true},{"id":1154906768,"node_id":"MDU6TGFiZWwxMTU0OTA2NzY4","url":"https://api.github.com/repos/swapagarwal/swag-for-dev/labels/%F0%9F%8E%A8%20PR:%20UI/X%20Testing","name":"🎨 PR: UI/X Testing","color":"43f2b5","default":false}],"state":"open","locked":false,"assignee":{"login":"itaisteinherz","id":22768990,"node_id":"MDQ6VXNlcjIyNzY4OTkw","avatar_url":"https://avatars3.githubusercontent.com/u/22768990?v=4","gravatar_id":"","url":"https://api.github.com/users/itaisteinherz","html_url":"https://github.com/itaisteinherz","followers_url":"https://api.github.com/users/itaisteinherz/followers","following_url":"https://api.github.com/users/itaisteinherz/following{/other_user}","gists_url":"https://api.github.com/users/itaisteinherz/gists{/gist_id}","starred_url":"https://api.github.com/users/itaisteinherz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itaisteinherz/subscriptions","organizations_url":"https://api.github.com/users/itaisteinherz/orgs","repos_url":"https://api.github.com/users/itaisteinherz/repos","events_url":"https://api.github.com/users/itaisteinherz/events{/privacy}","received_events_url":"https://api.github.com/users/itaisteinherz/received_events","type":"User","site_admin":false},"assignees":[{"login":"itaisteinherz","id":22768990,"node_id":"MDQ6VXNlcjIyNzY4OTkw","avatar_url":"https://avatars3.githubusercontent.com/u/22768990?v=4","gravatar_id":"","url":"https://api.github.com/users/itaisteinherz","html_url":"https://github.com/itaisteinherz","followers_url":"https://api.github.com/users/itaisteinherz/followers","following_url":"https://api.github.com/users/itaisteinherz/following{/other_user}","gists_url":"https://api.github.com/users/itaisteinherz/gists{/gist_id}","starred_url":"https://api.github.com/users/itaisteinherz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itaisteinherz/subscriptions","organizations_url":"https://api.github.com/users/itaisteinherz/orgs","repos_url":"https://api.github.com/users/itaisteinherz/repos","events_url":"https://api.github.com/users/itaisteinherz/events{/privacy}","received_events_url":"https://api.github.com/users/itaisteinherz/received_events","type":"User","site_admin":false}],"milestone":null,"comments":50,"created_at":"2018-11-11T21:39:59Z","updated_at":"2018-12-27T19:02:24Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/swapagarwal/swag-for-dev/pulls/159","html_url":"https://github.com/swapagarwal/swag-for-dev/pull/159","diff_url":"https://github.com/swapagarwal/swag-for-dev/pull/159.diff","patch_url":"https://github.com/swapagarwal/swag-for-dev/pull/159.patch"},"body":"- [x] I've checked that this isn't a duplicate pull request.\r\n\r\nThis PR is similar to #134 and #153, but the concept is a bit different.\r\nContinuing the discussion at #88, it seems to me like a good option for now would be to mark expired promotions with the `expired` tag, and then filter those out.\r\nThat is what this PR adds.\r\n\r\nWe could also use a `expiration` property to set the date and time of expiration of a promo, similarly to what was suggested in https://github.com/swapagarwal/swag-for-dev/issues/88#issuecomment-431614021 and https://github.com/swapagarwal/swag-for-dev/issues/88#issuecomment-431579004.\r\n\r\nFixes #88\r\nFixes #158\r\nCloses #134\r\nCloses #153\r\nCloses #154\r\n\r\n// cc @vikaspotluri123"},"comment":{"url":"https://api.github.com/repos/swapagarwal/swag-for-dev/issues/comments/450211050","html_url":"https://github.com/swapagarwal/swag-for-dev/pull/159#issuecomment-450211050","issue_url":"https://api.github.com/repos/swapagarwal/swag-for-dev/issues/159","id":450211050,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDIxMTA1MA==","user":{"login":"aslafy-z","id":8191198,"node_id":"MDQ6VXNlcjgxOTExOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/8191198?v=4","gravatar_id":"","url":"https://api.github.com/users/aslafy-z","html_url":"https://github.com/aslafy-z","followers_url":"https://api.github.com/users/aslafy-z/followers","following_url":"https://api.github.com/users/aslafy-z/following{/other_user}","gists_url":"https://api.github.com/users/aslafy-z/gists{/gist_id}","starred_url":"https://api.github.com/users/aslafy-z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aslafy-z/subscriptions","organizations_url":"https://api.github.com/users/aslafy-z/orgs","repos_url":"https://api.github.com/users/aslafy-z/repos","events_url":"https://api.github.com/users/aslafy-z/events{/privacy}","received_events_url":"https://api.github.com/users/aslafy-z/received_events","type":"User","site_admin":false},"created_at":"2018-12-27T19:02:24Z","updated_at":"2018-12-27T19:02:24Z","author_association":"COLLABORATOR","body":"Here's a diff snippet to inline controls on mobile\r\n\r\n```diff\r\ndiff --git a/src/styl/index.styl b/src/styl/index.styl\r\nindex ca71131..a9a9695 100644\r\n--- a/src/styl/index.styl\r\n+++ b/src/styl/index.styl\r\n@@ -46,11 +46,16 @@ section.main\r\n                        width 100%\r\n                        justify-content flex-start\r\n \r\n+               @media screen and (max-width: 450px)\r\n+                       .item, .select-wrapper, select\r\n+                               width 100%\r\n+\r\n                .item\r\n                        padding 5px\r\n \r\n                .select-wrapper\r\n                        position relative\r\n+                       margin 0 5px\r\n \r\n                .select-wrapper:before\r\n                        content '▼'\r\n@@ -68,7 +73,6 @@ section.main\r\n                        margin-right 6px\r\n \r\n                select\r\n-                       margin 0 5px\r\n                        background #fff\r\n                        border none\r\n                        border-bottom 2px solid #bbb\r\n```\r\n\r\nHere's a screenshot of how it renders:\r\n![](https://i.imgur.com/besulQe.png?1)"}}
{"actor":{"display_login":"aslafy-z"}}