{"push_id":2419332471,"size":129,"distinct_size":129,"ref":"refs/heads/v9-backports","head":"cc189e76e546d4cde316bacb1686e8587a0bba4e","before":"99d51e11fe86da2acff138a3d2cd830c2b6c9d0f","commits":[{"sha":"5a78c6c0a60a7cb34bff8ee983712e7847010840","author":{"name":"Ruben Bridgewater","email":"3007646e4b7d9a024ee9b5ca232e6faee5ed366f@bridgewater.de"},"message":"doc: improve assert documentation\n\n1) Separate all loose and strict functions.\n2) Stronger outline the used comparison rules in (not)deepStrictEqual\n3) Fix SameValue comparison info\n\nBackport-PR-URL: https://github.com/nodejs/node/pull/19230\nPR-URL: https://github.com/nodejs/node/pull/17002\nReviewed-By: Refael Ackermann <refack@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>\nReviewed-By: Anna Henningsen <anna@addaleax.net>","distinct":true,"url":"https://api.github.com/repos/BridgeAR/node/commits/5a78c6c0a60a7cb34bff8ee983712e7847010840"},{"sha":"bae5de1949b8fed3b6f0653e7c1e9d860666e5af","author":{"name":"Ruben Bridgewater","email":"3007646e4b7d9a024ee9b5ca232e6faee5ed366f@bridgewater.de"},"message":"assert: add strict functionality export\n\nRequireing the strict version will allow to use `assert.equal`,\n`assert.deepEqual` and there negated counterparts to be used with\nstrict comparison instead of using e.g. `assert.strictEqual`.\n\nThe API is identical to the regular assert export and only differs\nin the way that all functions use strict compairson.\n\nBackport-PR-URL: https://github.com/nodejs/node/pull/19230\nPR-URL: https://github.com/nodejs/node/pull/17002\nReviewed-By: Refael Ackermann <refack@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>\nReviewed-By: Anna Henningsen <anna@addaleax.net>","distinct":true,"url":"https://api.github.com/repos/BridgeAR/node/commits/bae5de1949b8fed3b6f0653e7c1e9d860666e5af"},{"sha":"db73d1c13bd65ceb1293353e4fb733d0f3f81460","author":{"name":"Ruben Bridgewater","email":"3007646e4b7d9a024ee9b5ca232e6faee5ed366f@bridgewater.de"},"message":"assert: use object argument in innerFail\n\nRight now it is difficult to know what argument stands for what\nproperty. By refactoring the arguments into a object it is clear\nwhat stands for what.\n\nBackport-PR-URL: https://github.com/nodejs/node/pull/19230\nPR-URL: https://github.com/nodejs/node/pull/17582\nReviewed-By: Anna Henningsen <anna@addaleax.net>\nReviewed-By: Jon Moss <me@jonathanmoss.me>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Anatoli Papirovski <apapirovski@mac.com>","distinct":true,"url":"https://api.github.com/repos/BridgeAR/node/commits/db73d1c13bd65ceb1293353e4fb733d0f3f81460"},{"sha":"24aeca7dd5e1a1236001098922927d00e74a5211","author":{"name":"Ruben Bridgewater","email":"3007646e4b7d9a024ee9b5ca232e6faee5ed366f@bridgewater.de"},"message":"assert: fix throws and doesNotThrow stack frames\n\nThe stack frames from .throws and .doesNotThrow got included\neven though that was not intended.\n\nBackport-PR-URL: https://github.com/nodejs/node/pull/19230\nPR-URL: https://github.com/nodejs/node/pull/17703\nReviewed-By: Timothy Gu <timothygu99@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>","distinct":true,"url":"https://api.github.com/repos/BridgeAR/node/commits/24aeca7dd5e1a1236001098922927d00e74a5211"},{"sha":"1e5c7e3e4732bde06a471f4b4d775467f9d39e24","author":{"name":"Ruben Bridgewater","email":"3007646e4b7d9a024ee9b5ca232e6faee5ed366f@bridgewater.de"},"message":"test: refactor common.expectsError\n\nA combination of try catch and common.expectsError is not necessary\nas the latter already does everything on its own.\n\nBackport-PR-URL: https://github.com/nodejs/node/pull/19230\nPR-URL: https://github.com/nodejs/node/pull/17703\nReviewed-By: Timothy Gu <timothygu99@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>","distinct":true,"url":"https://api.github.com/repos/BridgeAR/node/commits/1e5c7e3e4732bde06a471f4b4d775467f9d39e24"},{"sha":"612ba1a3f02160e784a0753080b6e10f8b5b78fe","author":{"name":"Ruben Bridgewater","email":"3007646e4b7d9a024ee9b5ca232e6faee5ed366f@bridgewater.de"},"message":"assert: improve assert.throws\n\nThrow a TypeError in case a error message is provided in the second\nargument and a third argument is present as well.\nThis is clearly a mistake and should not be done.\n\nBackport-PR-URL: https://github.com/nodejs/node/pull/19230\nPR-URL: https://github.com/nodejs/node/pull/17585\nReviewed-By: Rich Trott <rtrott@gmail.com>\nReviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>\nReviewed-By: Matteo Collina <matteo.collina@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>\nReviewed-By: Evan Lucas <evanlucas@me.com>","distinct":true,"url":"https://api.github.com/repos/BridgeAR/node/commits/612ba1a3f02160e784a0753080b6e10f8b5b78fe"},{"sha":"745709396c04d1d12bfc1c2a1c3e7b21bab8911d","author":{"name":"Ruben Bridgewater","email":"3007646e4b7d9a024ee9b5ca232e6faee5ed366f@bridgewater.de"},"message":"doc: improve .throws RegExp info\n\nIt was not clear why the error name is actually also tested for when\nusing a regular expression. This is now clarified.\n\nBackport-PR-URL: https://github.com/nodejs/node/pull/19230\nPR-URL: https://github.com/nodejs/node/pull/17585\nReviewed-By: Rich Trott <rtrott@gmail.com>\nReviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>\nReviewed-By: Matteo Collina <matteo.collina@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>\nReviewed-By: Evan Lucas <evanlucas@me.com>","distinct":true,"url":"https://api.github.com/repos/BridgeAR/node/commits/745709396c04d1d12bfc1c2a1c3e7b21bab8911d"},{"sha":"ebd60fa505c5c4b5606064fa25dd17c687095bc5","author":{"name":"Ruben Bridgewater","email":"3007646e4b7d9a024ee9b5ca232e6faee5ed366f@bridgewater.de"},"message":"assert: .throws accept objects\n\nFrom now on it is possible to use a validation object in throws\ninstead of the other possibilites.\n\nBackport-PR-URL: https://github.com/nodejs/node/pull/19230\nPR-URL: https://github.com/nodejs/node/pull/17584\nRefs: https://github.com/nodejs/node/pull/17557\nReviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Matteo Collina <matteo.collina@gmail.com>\nReviewed-By: Ron Korving <ron@ronkorving.nl>\nReviewed-By: Yuta Hiroto <hello@about-hiroppy.com>","distinct":true,"url":"https://api.github.com/repos/BridgeAR/node/commits/ebd60fa505c5c4b5606064fa25dd17c687095bc5"},{"sha":"f96ea47cf50ffdad50dbc70d7d4302f2e2cd8df1","author":{"name":"Ruben Bridgewater","email":"3007646e4b7d9a024ee9b5ca232e6faee5ed366f@bridgewater.de"},"message":"assert: fix strict regression\n\nUsing `assert()` or `assert.ok()` resulted in a error since a\nrefactoring.\n\nRefs: https://github.com/nodejs/node/pull/17582\n\nBackport-PR-URL: https://github.com/nodejs/node/pull/19230\nPR-URL: https://github.com/nodejs/node/pull/17903\nRefs: https://github.com/nodejs/node/pull/17582\nReviewed-By: Anatoli Papirovski <apapirovski@mac.com>\nReviewed-By: Tobias Nießen <tniessen@tnie.de>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>","distinct":true,"url":"https://api.github.com/repos/BridgeAR/node/commits/f96ea47cf50ffdad50dbc70d7d4302f2e2cd8df1"},{"sha":"b35eabb83771aab59dc9fdff33df8a06d98598c3","author":{"name":"Ben Noordhuis","email":"616e881177e53541ea47e5917a60deb2554e079d@bnoordhuis.nl"},"message":"lib: handle `throw undefined` in assert.throws()\n\nAnd make `assert.doesNotThrow()` handle it as well.\n\nBackport-PR-URL: https://github.com/nodejs/node/pull/19230\nPR-URL: https://github.com/nodejs/node/pull/18029\nFixes: https://github.com/nodejs/node/issues/18027\nReviewed-By: Anna Henningsen <anna@addaleax.net>\nReviewed-By: Ruben Bridgewater <ruben@bridgewater.de>\nReviewed-By: Khaidi Chu <i@2333.moe>\nReviewed-By: Tiancheng \"Timothy\" Gu <timothygu99@gmail.com>\nReviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>","distinct":true,"url":"https://api.github.com/repos/BridgeAR/node/commits/b35eabb83771aab59dc9fdff33df8a06d98598c3"},{"sha":"fd4c05ab56fb40f4f855b76dca66f5c488207c68","author":{"name":"Ruben Bridgewater","email":"3007646e4b7d9a024ee9b5ca232e6faee5ed366f@bridgewater.de"},"message":"util: fix custom inspect description\n\nUsing a custom inspect function on the inspected object is\ndeprecated. Remove the reference from the option description\nto make sure the user will read about the deprecation in the\nmore detailed description.\n\nBackport-PR-URL: https://github.com/nodejs/node/pull/19230\nPR-URL: https://github.com/nodejs/node/pull/17576\nReviewed-By: Anna Henningsen <anna@addaleax.net>","distinct":true,"url":"https://api.github.com/repos/BridgeAR/node/commits/fd4c05ab56fb40f4f855b76dca66f5c488207c68"},{"sha":"ce3a5af69f81893d53cf68a465eea7e6e19efcf9","author":{"name":"Ruben Bridgewater","email":"3007646e4b7d9a024ee9b5ca232e6faee5ed366f@bridgewater.de"},"message":"util: rename util.inspect argument\n\nutil.inspect can actually receive any property and the description\nwas wrong so far. This fixes it by renaming the argument to\nvalue and also updating the description.\n\nBackport-PR-URL: https://github.com/nodejs/node/pull/19230\nPR-URL: https://github.com/nodejs/node/pull/17576\nReviewed-By: Anna Henningsen <anna@addaleax.net>","distinct":true,"url":"https://api.github.com/repos/BridgeAR/node/commits/ce3a5af69f81893d53cf68a465eea7e6e19efcf9"},{"sha":"c18ac52970b116b7d17ab7ff842e9ab5f60881f5","author":{"name":"Ruben Bridgewater","email":"3007646e4b7d9a024ee9b5ca232e6faee5ed366f@bridgewater.de"},"message":"util: add util.inspect compact option\n\nThe current default formatting is not ideal and this improves\nthe situation by formatting the output more intuitiv.\n\n1) All object keys are now indented by 2 characters instead of\n   sometimes 2 and sometimes 3 characters.\n2) Each object key will now use an individual line instead of\n   sharing a line potentially with multiple object keys.\n3) Long strings will now be split into multiple lines in case\n   they exceed the \"lineBreak\" option length (including the\n   current indentation).\n4) Opening braces are now directly behind a object property\n   instead of using a new line.\n5) Switch inspect \"base\" order. In case the compact option is set\n   to `false`, inspect will now print\n     \"[Function: foo] {\\n  property: 'data'\\n}\"\n   instead of\n     \"{ [Function: foo]\\n  property: 'data'\\n}\".\n\nBackport-PR-URL: https://github.com/nodejs/node/pull/19230\nPR-URL: https://github.com/nodejs/node/pull/17576\nReviewed-By: Anna Henningsen <anna@addaleax.net>","distinct":true,"url":"https://api.github.com/repos/BridgeAR/node/commits/c18ac52970b116b7d17ab7ff842e9ab5f60881f5"},{"sha":"5aa3a2d172efb5cdca07ba6f0f2b8b054ced97ea","author":{"name":"Ruben Bridgewater","email":"3007646e4b7d9a024ee9b5ca232e6faee5ed366f@bridgewater.de"},"message":"assert: improve error messages\n\nFrom now on all error messages produced by `assert` in strict mode\nwill produce a error diff.\n\nBackport-PR-URL: https://github.com/nodejs/node/pull/19230\nPR-URL: https://github.com/nodejs/node/pull/17615\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Matteo Collina <matteo.collina@gmail.com>","distinct":true,"url":"https://api.github.com/repos/BridgeAR/node/commits/5aa3a2d172efb5cdca07ba6f0f2b8b054ced97ea"},{"sha":"ead727c274a5545af70bbca6b1b887c7055660fe","author":{"name":"Ruben Bridgewater","email":"3007646e4b7d9a024ee9b5ca232e6faee5ed366f@bridgewater.de"},"message":"tty: add getColorDepth function\n\nRight now it is very difficult to determine if a terminal supports\ncolors or not. This function adds this functionality by detecting\nenvironment variables and checking process.\n\nBackport-PR-URL: https://github.com/nodejs/node/pull/19230\nPR-URL: https://github.com/nodejs/node/pull/17615\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Matteo Collina <matteo.collina@gmail.com>","distinct":true,"url":"https://api.github.com/repos/BridgeAR/node/commits/ead727c274a5545af70bbca6b1b887c7055660fe"},{"sha":"74f0d1aa6059fe019e382affa50f7ae409758d1a","author":{"name":"Ruben Bridgewater","email":"3007646e4b7d9a024ee9b5ca232e6faee5ed366f@bridgewater.de"},"message":"tty: refactor to es6\n\nBackport-PR-URL: https://github.com/nodejs/node/pull/19230\nPR-URL: https://github.com/nodejs/node/pull/17615\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Matteo Collina <matteo.collina@gmail.com>","distinct":true,"url":"https://api.github.com/repos/BridgeAR/node/commits/74f0d1aa6059fe019e382affa50f7ae409758d1a"},{"sha":"d3c2534bbeb12b813cecdd543e9da04dc9fb70d9","author":{"name":"Ruben Bridgewater","email":"3007646e4b7d9a024ee9b5ca232e6faee5ed366f@bridgewater.de"},"message":"assert: use destructuring for errors\n\nDestructure the necessary Error classes from internal/errors.\nThis improves the readability of the error creation.\n\nBackport-PR-URL: https://github.com/nodejs/node/pull/19230\nPR-URL: https://github.com/nodejs/node/pull/18247\nReviewed-By: Matteo Collina <matteo.collina@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>","distinct":true,"url":"https://api.github.com/repos/BridgeAR/node/commits/d3c2534bbeb12b813cecdd543e9da04dc9fb70d9"},{"sha":"e9ac468146a997f8a0d00fd1042d6de52e4afa42","author":{"name":"Ruben Bridgewater","email":"3007646e4b7d9a024ee9b5ca232e6faee5ed366f@bridgewater.de"},"message":"assert: fix throws trace\n\nThe current stack trace thrown in case `assert.throws(fn, object)`\nis used did not filter the stack trace. This fixes it.\n\nBackport-PR-URL: https://github.com/nodejs/node/pull/19230\nPR-URL: https://github.com/nodejs/node/pull/18595\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Anatoli Papirovski <apapirovski@mac.com>","distinct":true,"url":"https://api.github.com/repos/BridgeAR/node/commits/e9ac468146a997f8a0d00fd1042d6de52e4afa42"},{"sha":"968b867bf2357d214ee0bbd43911564955228056","author":{"name":"Ruben Bridgewater","email":"3007646e4b7d9a024ee9b5ca232e6faee5ed366f@bridgewater.de"},"message":"doc: document asserts Weak(Map|Set) behavior\n\nRight now it is not documentated that WeakMap entries are not\ncompared. This might result in some confusion. This adds a note\nabout the behavior in `assert.deepStrictEqual`. This documentation\nis also references in `util.isDeepStrictEqual`, so we do not have\nto document it again for that function as the underlying algorithm\nis the same.\n\nBackport-PR-URL: https://github.com/nodejs/node/pull/19230\nPR-URL: https://github.com/nodejs/node/pull/18248\nFixes: https://github.com/nodejs/node/issues/18228\nRefs: https://github.com/nodejs/node/pull/18228\nReviewed-By: Joyee Cheung <joyeec9h3@gmail.com>\nReviewed-By: Anna Henningsen <anna@addaleax.net>","distinct":true,"url":"https://api.github.com/repos/BridgeAR/node/commits/968b867bf2357d214ee0bbd43911564955228056"},{"sha":"9abbb6b857d4f85a291342a9ae088105fca85782","author":{"name":"Ruben Bridgewater","email":"3007646e4b7d9a024ee9b5ca232e6faee5ed366f@bridgewater.de"},"message":"assert: fix infinite loop\n\nIn rare cirumstances it is possible to get a identical error diff.\nIn such a case the advances diffing runs into a infinite loop.\nThis fixes it by properly checking for extra entries.\n\nBackport-PR-URL: https://github.com/nodejs/node/pull/19230\nPR-URL: https://github.com/nodejs/node/pull/18611\nReviewed-By: Joyee Cheung <joyeec9h3@gmail.com>\nReviewed-By: Matteo Collina <matteo.collina@gmail.com>\nReviewed-By: Anna Henningsen <anna@addaleax.net>","distinct":true,"url":"https://api.github.com/repos/BridgeAR/node/commits/9abbb6b857d4f85a291342a9ae088105fca85782"}]}
{"actor":{"display_login":"BridgeAR"}}