{"action":"created","issue":{"url":"https://api.github.com/repos/liblouis/liblouis/issues/568","repository_url":"https://api.github.com/repos/liblouis/liblouis","labels_url":"https://api.github.com/repos/liblouis/liblouis/issues/568/labels{/name}","comments_url":"https://api.github.com/repos/liblouis/liblouis/issues/568/comments","events_url":"https://api.github.com/repos/liblouis/liblouis/issues/568/events","html_url":"https://github.com/liblouis/liblouis/pull/568","id":322810744,"number":568,"title":"tables - fix the russian table","user":{"login":"zstanecic","id":11149715,"avatar_url":"https://avatars1.githubusercontent.com/u/11149715?v=4","gravatar_id":"","url":"https://api.github.com/users/zstanecic","html_url":"https://github.com/zstanecic","followers_url":"https://api.github.com/users/zstanecic/followers","following_url":"https://api.github.com/users/zstanecic/following{/other_user}","gists_url":"https://api.github.com/users/zstanecic/gists{/gist_id}","starred_url":"https://api.github.com/users/zstanecic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zstanecic/subscriptions","organizations_url":"https://api.github.com/users/zstanecic/orgs","repos_url":"https://api.github.com/users/zstanecic/repos","events_url":"https://api.github.com/users/zstanecic/events{/privacy}","received_events_url":"https://api.github.com/users/zstanecic/received_events","type":"User","site_admin":false},"labels":[{"id":587912399,"url":"https://api.github.com/repos/liblouis/liblouis/labels/tables","name":"tables","color":"feaa0b","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-14T13:12:55Z","updated_at":"2018-05-24T10:03:17Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/liblouis/liblouis/pulls/568","html_url":"https://github.com/liblouis/liblouis/pull/568","diff_url":"https://github.com/liblouis/liblouis/pull/568.diff","patch_url":"https://github.com/liblouis/liblouis/pull/568.patch"},"body":"it is an 8-dots corrected table. In the past, we had 8 dots russian table, wich is in fact the six dots table. , Now this pull request fixes this issue. Table provided by Pavel Kaplan"},"comment":{"url":"https://api.github.com/repos/liblouis/liblouis/issues/comments/391659976","html_url":"https://github.com/liblouis/liblouis/pull/568#issuecomment-391659976","issue_url":"https://api.github.com/repos/liblouis/liblouis/issues/568","id":391659976,"user":{"login":"zstanecic","id":11149715,"avatar_url":"https://avatars1.githubusercontent.com/u/11149715?v=4","gravatar_id":"","url":"https://api.github.com/users/zstanecic","html_url":"https://github.com/zstanecic","followers_url":"https://api.github.com/users/zstanecic/followers","following_url":"https://api.github.com/users/zstanecic/following{/other_user}","gists_url":"https://api.github.com/users/zstanecic/gists{/gist_id}","starred_url":"https://api.github.com/users/zstanecic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zstanecic/subscriptions","organizations_url":"https://api.github.com/users/zstanecic/orgs","repos_url":"https://api.github.com/users/zstanecic/repos","events_url":"https://api.github.com/users/zstanecic/events{/privacy}","received_events_url":"https://api.github.com/users/zstanecic/received_events","type":"User","site_admin":false},"created_at":"2018-05-24T10:03:16Z","updated_at":"2018-05-24T10:03:16Z","author_association":"NONE","body":"Ok,\n\nhere we go:\n\nthe old 8'dots table was not the 8'dots table, it is the six dots table.\n\nit is the completely new table right, with the proper russian standard.\n\nThis table fixes imput in the russian language,\n\nallows display of the russian accented text,\n\nthe old table is not solid, licence is not the argument.\n\nYou are not a russian speaker, and you don't understand the word of russian.\n\nthis table modifies the following: a) the definitions are 8-dots, as \nthese should be,\n\nb) in the NVDA screen reader, the table with this file name is displayed \nas 8-dots, so i am making it consistent,\n\nThis table allows multi-language reading, without conflicts to russian \nand latin.\n\nthe old table uses multi-cell definition, and we have double grade 2 \ntables. table named ru-compbrl.ctb is a grade 1 table along with \nru-ru-g1.utb.\n\nso we have double tables.\n\nread the header, that the russian table with this name is only the \nliterary table instead of 8-dots.\n\nthis is the fix which makes it 8-dots\n\n\nW dniu 24.05.2018 o 11:54, Christian Egli pisze:\n>\n> *@egli* requested changes on this pull request.\n>\n> @zstanecic <https://github.com/zstanecic> I don't quite understand. \n> What is this about? You replace a table with a complete new one. Why \n> is this better?\n>\n> The old table looks solid to me. It has a proper header with copyright \n> and license information. It has comments. It puts common definition \n> into external files and includes those.\n>\n> I need more convincing that your table is better than the old one.\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub \n> <https://github.com/liblouis/liblouis/pull/568#pullrequestreview-122921277>, \n> or mute the thread \n> <https://github.com/notifications/unsubscribe-auth/AKohk4Nn14hzL2068AMNpMGZ4sHyY7gBks5t1oM5gaJpZM4T9xH->.\n>\n\n"}}
{"actor":{"display_login":"zstanecic"}}