{"action":"closed","number":15977,"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/15977","id":194154170,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MTU0MTcw","html_url":"https://github.com/ampproject/amphtml/pull/15977","diff_url":"https://github.com/ampproject/amphtml/pull/15977.diff","patch_url":"https://github.com/ampproject/amphtml/pull/15977.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/15977","number":15977,"state":"closed","locked":false,"title":"🏗 Require JSDoc comments for all classes, methods, and functions in AMP code","user":{"login":"rsimha","id":26553114,"node_id":"MDQ6VXNlcjI2NTUzMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/26553114?v=4","gravatar_id":"","url":"https://api.github.com/users/rsimha","html_url":"https://github.com/rsimha","followers_url":"https://api.github.com/users/rsimha/followers","following_url":"https://api.github.com/users/rsimha/following{/other_user}","gists_url":"https://api.github.com/users/rsimha/gists{/gist_id}","starred_url":"https://api.github.com/users/rsimha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsimha/subscriptions","organizations_url":"https://api.github.com/users/rsimha/orgs","repos_url":"https://api.github.com/users/rsimha/repos","events_url":"https://api.github.com/users/rsimha/events{/privacy}","received_events_url":"https://api.github.com/users/rsimha/received_events","type":"User","site_admin":false},"body":"Until now, `gulp lint` used to check existing JSDoc comments for correctness, but it didn't complain if they were missing.\r\n\r\nWith this PR, we require JSDoc comments for all classes, methods, and functions in the AMP codebase. This is critical to our ability to speed up the compilation of the AMP runtime using closure compiler.\r\n\r\nSince there are numerous instances of missing JSDoc comments, this rule will be run in warning mode for push builds on `master`, while it will run in error mode on files touched by a PR (large refactors are exempted).","created_at":"2018-06-12T03:01:05Z","updated_at":"2018-06-12T17:31:16Z","closed_at":"2018-06-12T17:31:16Z","merged_at":"2018-06-12T17:31:16Z","merge_commit_sha":"71b3ba3a24924784a4270c826ff1f301a9e799e0","assignee":{"login":"rsimha","id":26553114,"node_id":"MDQ6VXNlcjI2NTUzMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/26553114?v=4","gravatar_id":"","url":"https://api.github.com/users/rsimha","html_url":"https://github.com/rsimha","followers_url":"https://api.github.com/users/rsimha/followers","following_url":"https://api.github.com/users/rsimha/following{/other_user}","gists_url":"https://api.github.com/users/rsimha/gists{/gist_id}","starred_url":"https://api.github.com/users/rsimha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsimha/subscriptions","organizations_url":"https://api.github.com/users/rsimha/orgs","repos_url":"https://api.github.com/users/rsimha/repos","events_url":"https://api.github.com/users/rsimha/events{/privacy}","received_events_url":"https://api.github.com/users/rsimha/received_events","type":"User","site_admin":false},"assignees":[{"login":"rsimha","id":26553114,"node_id":"MDQ6VXNlcjI2NTUzMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/26553114?v=4","gravatar_id":"","url":"https://api.github.com/users/rsimha","html_url":"https://github.com/rsimha","followers_url":"https://api.github.com/users/rsimha/followers","following_url":"https://api.github.com/users/rsimha/following{/other_user}","gists_url":"https://api.github.com/users/rsimha/gists{/gist_id}","starred_url":"https://api.github.com/users/rsimha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsimha/subscriptions","organizations_url":"https://api.github.com/users/rsimha/orgs","repos_url":"https://api.github.com/users/rsimha/repos","events_url":"https://api.github.com/users/rsimha/events{/privacy}","received_events_url":"https://api.github.com/users/rsimha/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"erwinmombay","id":354746,"node_id":"MDQ6VXNlcjM1NDc0Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/354746?v=4","gravatar_id":"","url":"https://api.github.com/users/erwinmombay","html_url":"https://github.com/erwinmombay","followers_url":"https://api.github.com/users/erwinmombay/followers","following_url":"https://api.github.com/users/erwinmombay/following{/other_user}","gists_url":"https://api.github.com/users/erwinmombay/gists{/gist_id}","starred_url":"https://api.github.com/users/erwinmombay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erwinmombay/subscriptions","organizations_url":"https://api.github.com/users/erwinmombay/orgs","repos_url":"https://api.github.com/users/erwinmombay/repos","events_url":"https://api.github.com/users/erwinmombay/events{/privacy}","received_events_url":"https://api.github.com/users/erwinmombay/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":284925157,"node_id":"MDU6TGFiZWwyODQ5MjUxNTc=","url":"https://api.github.com/repos/ampproject/amphtml/labels/Category:%20Tooling","name":"Category: Tooling","color":"1d76db","default":false},{"id":596633554,"node_id":"MDU6TGFiZWw1OTY2MzM1NTQ=","url":"https://api.github.com/repos/ampproject/amphtml/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/15977/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/15977/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/15977/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/8032677e796ae1de335ae930a0a7afca1e40a573","head":{"label":"rsimha:2018-06-11-JsDoc","ref":"2018-06-11-JsDoc","sha":"8032677e796ae1de335ae930a0a7afca1e40a573","user":{"login":"rsimha","id":26553114,"node_id":"MDQ6VXNlcjI2NTUzMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/26553114?v=4","gravatar_id":"","url":"https://api.github.com/users/rsimha","html_url":"https://github.com/rsimha","followers_url":"https://api.github.com/users/rsimha/followers","following_url":"https://api.github.com/users/rsimha/following{/other_user}","gists_url":"https://api.github.com/users/rsimha/gists{/gist_id}","starred_url":"https://api.github.com/users/rsimha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsimha/subscriptions","organizations_url":"https://api.github.com/users/rsimha/orgs","repos_url":"https://api.github.com/users/rsimha/repos","events_url":"https://api.github.com/users/rsimha/events{/privacy}","received_events_url":"https://api.github.com/users/rsimha/received_events","type":"User","site_admin":false},"repo":{"id":85631456,"node_id":"MDEwOlJlcG9zaXRvcnk4NTYzMTQ1Ng==","name":"amphtml","full_name":"rsimha/amphtml","owner":{"login":"rsimha","id":26553114,"node_id":"MDQ6VXNlcjI2NTUzMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/26553114?v=4","gravatar_id":"","url":"https://api.github.com/users/rsimha","html_url":"https://github.com/rsimha","followers_url":"https://api.github.com/users/rsimha/followers","following_url":"https://api.github.com/users/rsimha/following{/other_user}","gists_url":"https://api.github.com/users/rsimha/gists{/gist_id}","starred_url":"https://api.github.com/users/rsimha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsimha/subscriptions","organizations_url":"https://api.github.com/users/rsimha/orgs","repos_url":"https://api.github.com/users/rsimha/repos","events_url":"https://api.github.com/users/rsimha/events{/privacy}","received_events_url":"https://api.github.com/users/rsimha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rsimha/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/rsimha/amphtml","forks_url":"https://api.github.com/repos/rsimha/amphtml/forks","keys_url":"https://api.github.com/repos/rsimha/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rsimha/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rsimha/amphtml/teams","hooks_url":"https://api.github.com/repos/rsimha/amphtml/hooks","issue_events_url":"https://api.github.com/repos/rsimha/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/rsimha/amphtml/events","assignees_url":"https://api.github.com/repos/rsimha/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/rsimha/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/rsimha/amphtml/tags","blobs_url":"https://api.github.com/repos/rsimha/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rsimha/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rsimha/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/rsimha/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rsimha/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/rsimha/amphtml/languages","stargazers_url":"https://api.github.com/repos/rsimha/amphtml/stargazers","contributors_url":"https://api.github.com/repos/rsimha/amphtml/contributors","subscribers_url":"https://api.github.com/repos/rsimha/amphtml/subscribers","subscription_url":"https://api.github.com/repos/rsimha/amphtml/subscription","commits_url":"https://api.github.com/repos/rsimha/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/rsimha/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/rsimha/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/rsimha/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/rsimha/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/rsimha/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rsimha/amphtml/merges","archive_url":"https://api.github.com/repos/rsimha/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rsimha/amphtml/downloads","issues_url":"https://api.github.com/repos/rsimha/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/rsimha/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/rsimha/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/rsimha/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rsimha/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/rsimha/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/rsimha/amphtml/deployments","created_at":"2017-03-20T21:59:46Z","updated_at":"2018-06-11T22:18:41Z","pushed_at":"2018-06-12T03:46:47Z","git_url":"git://github.com/rsimha/amphtml.git","ssh_url":"git@github.com:rsimha/amphtml.git","clone_url":"https://github.com/rsimha/amphtml.git","svn_url":"https://github.com/rsimha/amphtml","homepage":"https://www.ampproject.org","size":458481,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"5d0457dcfd300af7b81a5d5d1ce5db7d6a2aaee2","user":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"node_id":"MDEwOlJlcG9zaXRvcnk0MTc2NjAwMg==","name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2018-06-12T16:59:32Z","pushed_at":"2018-06-12T17:31:16Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://www.ampproject.org","size":459807,"stargazers_count":11671,"watchers_count":11671,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2440,"mirror_url":null,"archived":false,"open_issues_count":1270,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2440,"open_issues":1270,"watchers":11671,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/15977"},"html":{"href":"https://github.com/ampproject/amphtml/pull/15977"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/15977"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/15977/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/15977/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/15977/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/8032677e796ae1de335ae930a0a7afca1e40a573"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"rsimha","id":26553114,"node_id":"MDQ6VXNlcjI2NTUzMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/26553114?v=4","gravatar_id":"","url":"https://api.github.com/users/rsimha","html_url":"https://github.com/rsimha","followers_url":"https://api.github.com/users/rsimha/followers","following_url":"https://api.github.com/users/rsimha/following{/other_user}","gists_url":"https://api.github.com/users/rsimha/gists{/gist_id}","starred_url":"https://api.github.com/users/rsimha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsimha/subscriptions","organizations_url":"https://api.github.com/users/rsimha/orgs","repos_url":"https://api.github.com/users/rsimha/repos","events_url":"https://api.github.com/users/rsimha/events{/privacy}","received_events_url":"https://api.github.com/users/rsimha/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":21,"deletions":2,"changed_files":3}}
{"actor":{"display_login":"rsimha"}}