{"action":"created","comment":{"url":"https://api.github.com/repos/monero-project/monero-gui/pulls/comments/243259944","pull_request_review_id":186980946,"id":243259944,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzI1OTk0NA==","diff_hunk":"@@ -45,7 +45,7 @@ Rectangle {\n     /* main layout */\n     ColumnLayout {\n         id: mainLayout\n-        anchors.margins: 40 * scaleRatio\n+        anchors.margins: (isMobile)? 17 : 20","path":"pages/TxKey.qml","position":5,"original_position":5,"commit_id":"28ae10b3ec1c7bc1c544735c4e90295b523c632b","original_commit_id":"28ae10b3ec1c7bc1c544735c4e90295b523c632b","user":{"login":"xiphon","id":26060097,"node_id":"MDQ6VXNlcjI2MDYwMDk3","avatar_url":"https://avatars2.githubusercontent.com/u/26060097?v=4","gravatar_id":"","url":"https://api.github.com/users/xiphon","html_url":"https://github.com/xiphon","followers_url":"https://api.github.com/users/xiphon/followers","following_url":"https://api.github.com/users/xiphon/following{/other_user}","gists_url":"https://api.github.com/users/xiphon/gists{/gist_id}","starred_url":"https://api.github.com/users/xiphon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiphon/subscriptions","organizations_url":"https://api.github.com/users/xiphon/orgs","repos_url":"https://api.github.com/users/xiphon/repos","events_url":"https://api.github.com/users/xiphon/events{/privacy}","received_events_url":"https://api.github.com/users/xiphon/received_events","type":"User","site_admin":false},"body":"scaleRatio","created_at":"2018-12-20T12:50:55Z","updated_at":"2018-12-20T12:50:56Z","html_url":"https://github.com/monero-project/monero-gui/pull/1793#discussion_r243259944","pull_request_url":"https://api.github.com/repos/monero-project/monero-gui/pulls/1793","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/monero-project/monero-gui/pulls/comments/243259944"},"html":{"href":"https://github.com/monero-project/monero-gui/pull/1793#discussion_r243259944"},"pull_request":{"href":"https://api.github.com/repos/monero-project/monero-gui/pulls/1793"}}},"pull_request":{"url":"https://api.github.com/repos/monero-project/monero-gui/pulls/1793","id":237130801,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MTMwODAx","html_url":"https://github.com/monero-project/monero-gui/pull/1793","diff_url":"https://github.com/monero-project/monero-gui/pull/1793.diff","patch_url":"https://github.com/monero-project/monero-gui/pull/1793.patch","issue_url":"https://api.github.com/repos/monero-project/monero-gui/issues/1793","number":1793,"state":"open","locked":false,"title":"Merchant page","user":{"login":"xmrdsc","id":1478325,"node_id":"MDQ6VXNlcjE0NzgzMjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1478325?v=4","gravatar_id":"","url":"https://api.github.com/users/xmrdsc","html_url":"https://github.com/xmrdsc","followers_url":"https://api.github.com/users/xmrdsc/followers","following_url":"https://api.github.com/users/xmrdsc/following{/other_user}","gists_url":"https://api.github.com/users/xmrdsc/gists{/gist_id}","starred_url":"https://api.github.com/users/xmrdsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xmrdsc/subscriptions","organizations_url":"https://api.github.com/users/xmrdsc/orgs","repos_url":"https://api.github.com/users/xmrdsc/repos","events_url":"https://api.github.com/users/xmrdsc/events{/privacy}","received_events_url":"https://api.github.com/users/xmrdsc/received_events","type":"User","site_admin":false},"body":"This PR introduces a dedicated merchant page. Current iteration of the merchant features present on the receive page are inadequate to be used as a point of sales system.\r\n\r\nThe changes in this PR will make it easier for merchants to accept Monero. Run the application in full-screen mode, set the amount to be received and customers scan the QR code.\r\n\r\nAlternatively you can provide a payment URL.\r\n\r\nSome notes:\r\n\r\n- Introduces a menu under Receive called Merchant.\r\n- Optimized for running in full-screen.\r\n- Transaction history shows a 'X time ago' indication. i.e: \"the transaction happened 5 minutes ago\"\r\n- Incoming transactions are monitored via tx pool.\r\n- For now, clicking on transactions takes you to the History page.\r\n- In the future merchants could optionally specify their to received amount in USD when #1714 is accepted & merged.\r\n\r\n![https://i.imgur.com/wjdKQLz.png](https://i.imgur.com/wjdKQLz.png)\r\n\r\n![https://i.imgur.com/h1BMDYL.png](https://i.imgur.com/h1BMDYL.png)\r\n\r\n[Video](https://i.imgur.com/xk2dlEA.mp4)","created_at":"2018-12-09T13:25:23Z","updated_at":"2018-12-20T12:50:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aad2d731e2f6a62816a62e245f4691a86ec8b018","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/monero-project/monero-gui/pulls/1793/commits","review_comments_url":"https://api.github.com/repos/monero-project/monero-gui/pulls/1793/comments","review_comment_url":"https://api.github.com/repos/monero-project/monero-gui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/monero-project/monero-gui/issues/1793/comments","statuses_url":"https://api.github.com/repos/monero-project/monero-gui/statuses/28ae10b3ec1c7bc1c544735c4e90295b523c632b","head":{"label":"xmrdsc:receive-merchant","ref":"receive-merchant","sha":"28ae10b3ec1c7bc1c544735c4e90295b523c632b","user":{"login":"xmrdsc","id":1478325,"node_id":"MDQ6VXNlcjE0NzgzMjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1478325?v=4","gravatar_id":"","url":"https://api.github.com/users/xmrdsc","html_url":"https://github.com/xmrdsc","followers_url":"https://api.github.com/users/xmrdsc/followers","following_url":"https://api.github.com/users/xmrdsc/following{/other_user}","gists_url":"https://api.github.com/users/xmrdsc/gists{/gist_id}","starred_url":"https://api.github.com/users/xmrdsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xmrdsc/subscriptions","organizations_url":"https://api.github.com/users/xmrdsc/orgs","repos_url":"https://api.github.com/users/xmrdsc/repos","events_url":"https://api.github.com/users/xmrdsc/events{/privacy}","received_events_url":"https://api.github.com/users/xmrdsc/received_events","type":"User","site_admin":false},"repo":{"id":110373663,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAzNzM2NjM=","name":"monero-core","full_name":"xmrdsc/monero-core","private":false,"owner":{"login":"xmrdsc","id":1478325,"node_id":"MDQ6VXNlcjE0NzgzMjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1478325?v=4","gravatar_id":"","url":"https://api.github.com/users/xmrdsc","html_url":"https://github.com/xmrdsc","followers_url":"https://api.github.com/users/xmrdsc/followers","following_url":"https://api.github.com/users/xmrdsc/following{/other_user}","gists_url":"https://api.github.com/users/xmrdsc/gists{/gist_id}","starred_url":"https://api.github.com/users/xmrdsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xmrdsc/subscriptions","organizations_url":"https://api.github.com/users/xmrdsc/orgs","repos_url":"https://api.github.com/users/xmrdsc/repos","events_url":"https://api.github.com/users/xmrdsc/events{/privacy}","received_events_url":"https://api.github.com/users/xmrdsc/received_events","type":"User","site_admin":false},"html_url":"https://github.com/xmrdsc/monero-core","description":"Monero: the secure, private, untraceable cryptocurrency","fork":true,"url":"https://api.github.com/repos/xmrdsc/monero-core","forks_url":"https://api.github.com/repos/xmrdsc/monero-core/forks","keys_url":"https://api.github.com/repos/xmrdsc/monero-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xmrdsc/monero-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xmrdsc/monero-core/teams","hooks_url":"https://api.github.com/repos/xmrdsc/monero-core/hooks","issue_events_url":"https://api.github.com/repos/xmrdsc/monero-core/issues/events{/number}","events_url":"https://api.github.com/repos/xmrdsc/monero-core/events","assignees_url":"https://api.github.com/repos/xmrdsc/monero-core/assignees{/user}","branches_url":"https://api.github.com/repos/xmrdsc/monero-core/branches{/branch}","tags_url":"https://api.github.com/repos/xmrdsc/monero-core/tags","blobs_url":"https://api.github.com/repos/xmrdsc/monero-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xmrdsc/monero-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xmrdsc/monero-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/xmrdsc/monero-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xmrdsc/monero-core/statuses/{sha}","languages_url":"https://api.github.com/repos/xmrdsc/monero-core/languages","stargazers_url":"https://api.github.com/repos/xmrdsc/monero-core/stargazers","contributors_url":"https://api.github.com/repos/xmrdsc/monero-core/contributors","subscribers_url":"https://api.github.com/repos/xmrdsc/monero-core/subscribers","subscription_url":"https://api.github.com/repos/xmrdsc/monero-core/subscription","commits_url":"https://api.github.com/repos/xmrdsc/monero-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/xmrdsc/monero-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/xmrdsc/monero-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/xmrdsc/monero-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/xmrdsc/monero-core/contents/{+path}","compare_url":"https://api.github.com/repos/xmrdsc/monero-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xmrdsc/monero-core/merges","archive_url":"https://api.github.com/repos/xmrdsc/monero-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xmrdsc/monero-core/downloads","issues_url":"https://api.github.com/repos/xmrdsc/monero-core/issues{/number}","pulls_url":"https://api.github.com/repos/xmrdsc/monero-core/pulls{/number}","milestones_url":"https://api.github.com/repos/xmrdsc/monero-core/milestones{/number}","notifications_url":"https://api.github.com/repos/xmrdsc/monero-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xmrdsc/monero-core/labels{/name}","releases_url":"https://api.github.com/repos/xmrdsc/monero-core/releases{/id}","deployments_url":"https://api.github.com/repos/xmrdsc/monero-core/deployments","created_at":"2017-11-11T19:27:58Z","updated_at":"2018-12-19T09:15:26Z","pushed_at":"2018-12-20T09:57:16Z","git_url":"git://github.com/xmrdsc/monero-core.git","ssh_url":"git@github.com:xmrdsc/monero-core.git","clone_url":"https://github.com/xmrdsc/monero-core.git","svn_url":"https://github.com/xmrdsc/monero-core","homepage":null,"size":10209,"stargazers_count":1,"watchers_count":1,"language":"QML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"monero-project:master","ref":"master","sha":"bac833c1dd95666e159406f290ad334decee2810","user":{"login":"monero-project","id":7450663,"node_id":"MDQ6VXNlcjc0NTA2NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/7450663?v=4","gravatar_id":"","url":"https://api.github.com/users/monero-project","html_url":"https://github.com/monero-project","followers_url":"https://api.github.com/users/monero-project/followers","following_url":"https://api.github.com/users/monero-project/following{/other_user}","gists_url":"https://api.github.com/users/monero-project/gists{/gist_id}","starred_url":"https://api.github.com/users/monero-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monero-project/subscriptions","organizations_url":"https://api.github.com/users/monero-project/orgs","repos_url":"https://api.github.com/users/monero-project/repos","events_url":"https://api.github.com/users/monero-project/events{/privacy}","received_events_url":"https://api.github.com/users/monero-project/received_events","type":"User","site_admin":false},"repo":{"id":33237663,"node_id":"MDEwOlJlcG9zaXRvcnkzMzIzNzY2Mw==","name":"monero-gui","full_name":"monero-project/monero-gui","private":false,"owner":{"login":"monero-project","id":7450663,"node_id":"MDQ6VXNlcjc0NTA2NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/7450663?v=4","gravatar_id":"","url":"https://api.github.com/users/monero-project","html_url":"https://github.com/monero-project","followers_url":"https://api.github.com/users/monero-project/followers","following_url":"https://api.github.com/users/monero-project/following{/other_user}","gists_url":"https://api.github.com/users/monero-project/gists{/gist_id}","starred_url":"https://api.github.com/users/monero-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monero-project/subscriptions","organizations_url":"https://api.github.com/users/monero-project/orgs","repos_url":"https://api.github.com/users/monero-project/repos","events_url":"https://api.github.com/users/monero-project/events{/privacy}","received_events_url":"https://api.github.com/users/monero-project/received_events","type":"User","site_admin":false},"html_url":"https://github.com/monero-project/monero-gui","description":"Monero: the secure, private, untraceable cryptocurrency","fork":false,"url":"https://api.github.com/repos/monero-project/monero-gui","forks_url":"https://api.github.com/repos/monero-project/monero-gui/forks","keys_url":"https://api.github.com/repos/monero-project/monero-gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/monero-project/monero-gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/monero-project/monero-gui/teams","hooks_url":"https://api.github.com/repos/monero-project/monero-gui/hooks","issue_events_url":"https://api.github.com/repos/monero-project/monero-gui/issues/events{/number}","events_url":"https://api.github.com/repos/monero-project/monero-gui/events","assignees_url":"https://api.github.com/repos/monero-project/monero-gui/assignees{/user}","branches_url":"https://api.github.com/repos/monero-project/monero-gui/branches{/branch}","tags_url":"https://api.github.com/repos/monero-project/monero-gui/tags","blobs_url":"https://api.github.com/repos/monero-project/monero-gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/monero-project/monero-gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/monero-project/monero-gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/monero-project/monero-gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/monero-project/monero-gui/statuses/{sha}","languages_url":"https://api.github.com/repos/monero-project/monero-gui/languages","stargazers_url":"https://api.github.com/repos/monero-project/monero-gui/stargazers","contributors_url":"https://api.github.com/repos/monero-project/monero-gui/contributors","subscribers_url":"https://api.github.com/repos/monero-project/monero-gui/subscribers","subscription_url":"https://api.github.com/repos/monero-project/monero-gui/subscription","commits_url":"https://api.github.com/repos/monero-project/monero-gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/monero-project/monero-gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/monero-project/monero-gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/monero-project/monero-gui/issues/comments{/number}","contents_url":"https://api.github.com/repos/monero-project/monero-gui/contents/{+path}","compare_url":"https://api.github.com/repos/monero-project/monero-gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/monero-project/monero-gui/merges","archive_url":"https://api.github.com/repos/monero-project/monero-gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/monero-project/monero-gui/downloads","issues_url":"https://api.github.com/repos/monero-project/monero-gui/issues{/number}","pulls_url":"https://api.github.com/repos/monero-project/monero-gui/pulls{/number}","milestones_url":"https://api.github.com/repos/monero-project/monero-gui/milestones{/number}","notifications_url":"https://api.github.com/repos/monero-project/monero-gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/monero-project/monero-gui/labels{/name}","releases_url":"https://api.github.com/repos/monero-project/monero-gui/releases{/id}","deployments_url":"https://api.github.com/repos/monero-project/monero-gui/deployments","created_at":"2015-04-01T09:08:42Z","updated_at":"2018-12-18T19:32:06Z","pushed_at":"2018-12-20T09:57:17Z","git_url":"git://github.com/monero-project/monero-gui.git","ssh_url":"git@github.com:monero-project/monero-gui.git","clone_url":"https://github.com/monero-project/monero-gui.git","svn_url":"https://github.com/monero-project/monero-gui","homepage":null,"size":9909,"stargazers_count":377,"watchers_count":377,"language":"QML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":490,"mirror_url":null,"archived":false,"open_issues_count":182,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":490,"open_issues":182,"watchers":377,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/monero-project/monero-gui/pulls/1793"},"html":{"href":"https://github.com/monero-project/monero-gui/pull/1793"},"issue":{"href":"https://api.github.com/repos/monero-project/monero-gui/issues/1793"},"comments":{"href":"https://api.github.com/repos/monero-project/monero-gui/issues/1793/comments"},"review_comments":{"href":"https://api.github.com/repos/monero-project/monero-gui/pulls/1793/comments"},"review_comment":{"href":"https://api.github.com/repos/monero-project/monero-gui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/monero-project/monero-gui/pulls/1793/commits"},"statuses":{"href":"https://api.github.com/repos/monero-project/monero-gui/statuses/28ae10b3ec1c7bc1c544735c4e90295b523c632b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"xiphon"}}