{"action":"created","issue":{"url":"https://api.github.com/repos/root-project/root/issues/2902","repository_url":"https://api.github.com/repos/root-project/root","labels_url":"https://api.github.com/repos/root-project/root/issues/2902/labels{/name}","comments_url":"https://api.github.com/repos/root-project/root/issues/2902/comments","events_url":"https://api.github.com/repos/root-project/root/issues/2902/events","html_url":"https://github.com/root-project/root/pull/2902","id":376521635,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NzIwOTk3","number":2902,"title":"[WIP] Moving ROOT to use generic compression algorithm/level/settings","user":{"login":"oshadura","id":7012420,"node_id":"MDQ6VXNlcjcwMTI0MjA=","avatar_url":"https://avatars2.githubusercontent.com/u/7012420?v=4","gravatar_id":"","url":"https://api.github.com/users/oshadura","html_url":"https://github.com/oshadura","followers_url":"https://api.github.com/users/oshadura/followers","following_url":"https://api.github.com/users/oshadura/following{/other_user}","gists_url":"https://api.github.com/users/oshadura/gists{/gist_id}","starred_url":"https://api.github.com/users/oshadura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oshadura/subscriptions","organizations_url":"https://api.github.com/users/oshadura/orgs","repos_url":"https://api.github.com/users/oshadura/repos","events_url":"https://api.github.com/users/oshadura/events{/privacy}","received_events_url":"https://api.github.com/users/oshadura/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":51,"created_at":"2018-11-01T18:49:02Z","updated_at":"2018-11-03T11:02:34Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/root-project/root/pulls/2902","html_url":"https://github.com/root-project/root/pull/2902","diff_url":"https://github.com/root-project/root/pull/2902.diff","patch_url":"https://github.com/root-project/root/pull/2902.patch"},"body":"It is a first step to move to generic settings for compression algorithms. I managed to clean all places where was not properly used \"magic numbers\".\r\nNext step will be to introduce a new class CompressionSetting that will provide more general switch for compression algorithms. ( preview concept https://github.com/bbockelm/root/commit/4c856f9408d9184cfaf4dc4727b7e32e5e4e3433 )\r\n\r\nIn this PR we already using ZLIB as default (for test correctness we need to land https://github.com/root-project/root/pull/2889 and  https://github.com/root-project/roottest/pull/247 before this pr).\r\n```\r\n$ root hsimple.root \r\n   --------------------------------------------------------------------\r\n  | Welcome to ROOT 6.15/01                          https://root.cern |\r\n  |                                       (c) 1995-2018, The ROOT Team |\r\n  | Built for linuxx8664gcc on Nov 01 2018, 17:35:38                   |\r\n  | From heads/default-compression-switcher@v6-13-04-1973-gb4ccd4f330  |\r\n  | Try '.help', '.demo', '.license', '.credits', '.quit'/'.q'         |\r\n   --------------------------------------------------------------------\r\n\r\nroot [0] \r\nAttaching file hsimple.root as _file0...\r\n(TFile *) 0x55f79b0e6360\r\nroot [1] _file0->GetCompressionAlgorithm()\r\n(int) 1\r\nroot [2] _file0->GetCompressionLevel()\r\n(int) 1\r\nroot [3] _file0->GetCompressionSettings()\r\n(int) 101\r\nroot [4]\r\n```"},"comment":{"url":"https://api.github.com/repos/root-project/root/issues/comments/435578996","html_url":"https://github.com/root-project/root/pull/2902#issuecomment-435578996","issue_url":"https://api.github.com/repos/root-project/root/issues/2902","id":435578996,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTU3ODk5Ng==","user":{"login":"phsft-bot","id":25639015,"node_id":"MDQ6VXNlcjI1NjM5MDE1","avatar_url":"https://avatars1.githubusercontent.com/u/25639015?v=4","gravatar_id":"","url":"https://api.github.com/users/phsft-bot","html_url":"https://github.com/phsft-bot","followers_url":"https://api.github.com/users/phsft-bot/followers","following_url":"https://api.github.com/users/phsft-bot/following{/other_user}","gists_url":"https://api.github.com/users/phsft-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/phsft-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phsft-bot/subscriptions","organizations_url":"https://api.github.com/users/phsft-bot/orgs","repos_url":"https://api.github.com/users/phsft-bot/repos","events_url":"https://api.github.com/users/phsft-bot/events{/privacy}","received_events_url":"https://api.github.com/users/phsft-bot/received_events","type":"User","site_admin":false},"created_at":"2018-11-03T11:02:34Z","updated_at":"2018-11-03T11:02:34Z","author_association":"COLLABORATOR","body":"Build failed on slc6/gcc48.\n[See console output](https://epsft-jenkins.cern.ch/job/root-pullrequests-build/46950/console).\n### Failing tests:\n- [projectroot.roottest.root.io.treeForeign.roottest_root_io_treeForeign_testForeignDraw](https://epsft-jenkins.cern.ch/job/root-pullrequests-build/46950/testReport/projectroot.roottest.root.io/treeForeign/roottest_root_io_treeForeign_testForeignDraw/)\n"}}
{"actor":{"display_login":"phsft-bot"}}