{"action":"created","issue":{"url":"https://api.github.com/repos/stan-dev/math/issues/789","repository_url":"https://api.github.com/repos/stan-dev/math","labels_url":"https://api.github.com/repos/stan-dev/math/issues/789/labels{/name}","comments_url":"https://api.github.com/repos/stan-dev/math/issues/789/comments","events_url":"https://api.github.com/repos/stan-dev/math/issues/789/events","html_url":"https://github.com/stan-dev/math/pull/789","id":303244961,"number":789,"title":"Feature/issue 123 complex numbers with vars","user":{"login":"ChrisChiasson","id":11857915,"avatar_url":"https://avatars3.githubusercontent.com/u/11857915?v=4","gravatar_id":"","url":"https://api.github.com/users/ChrisChiasson","html_url":"https://github.com/ChrisChiasson","followers_url":"https://api.github.com/users/ChrisChiasson/followers","following_url":"https://api.github.com/users/ChrisChiasson/following{/other_user}","gists_url":"https://api.github.com/users/ChrisChiasson/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisChiasson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisChiasson/subscriptions","organizations_url":"https://api.github.com/users/ChrisChiasson/orgs","repos_url":"https://api.github.com/users/ChrisChiasson/repos","events_url":"https://api.github.com/users/ChrisChiasson/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisChiasson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":44,"created_at":"2018-03-07T20:18:42Z","updated_at":"2018-05-20T16:42:28Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/stan-dev/math/pulls/789","html_url":"https://github.com/stan-dev/math/pull/789","diff_url":"https://github.com/stan-dev/math/pull/789.diff","patch_url":"https://github.com/stan-dev/math/pull/789.patch"},"body":"Discourse use cases and spec discussion: http://discourse.mc-stan.org/t/complex-number-support-in-math-library-autodiff/3511\r\n\r\n#### Submission Checklist\r\n\r\n- [ MinGW GCC 7.2 fails on one of the unit tests due to a compiler bug that I can't work around inside this set of patch commits, so no] Run unit tests: `./runTests.py test/unit`\r\n- [ $ make cpplint\r\nmake: execvp: python: Argument list too long\r\nmake: *** [make/cpplint:5: cpplint] Error 127\r\n] Run cpplint: `make cpplint`\r\n- [X] Declare copyright holder and open-source license: see below\r\n\r\n#### Summary:\r\nInitial attempt at adding complex number support to var, as referenced in issue #123 \r\n\r\n#### Intended Effect:\r\nComplex numbers work\r\n\r\n#### How to Verify:\r\nRun unit test\r\n\r\n#### Side Effects:\r\nI am sure there are many that I haven't thought of. One I can think of is that the interface of the complex class in stan math has a more flexible interface than normal std::complex. This is because the binary operators use unconstrained templates. This could have \"interesting\" interactions.\r\n\r\n#### Documentation:\r\nI added some inline documentation using doxygen syntax.\r\n\r\n#### Copyright and Licensing\r\n\r\nPlease list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Oil States\r\n\r\nBy submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:\r\n- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)\r\n- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)\r\n"},"comment":{"url":"https://api.github.com/repos/stan-dev/math/issues/comments/390494989","html_url":"https://github.com/stan-dev/math/pull/789#issuecomment-390494989","issue_url":"https://api.github.com/repos/stan-dev/math/issues/789","id":390494989,"user":{"login":"seantalts","id":805356,"avatar_url":"https://avatars1.githubusercontent.com/u/805356?v=4","gravatar_id":"","url":"https://api.github.com/users/seantalts","html_url":"https://github.com/seantalts","followers_url":"https://api.github.com/users/seantalts/followers","following_url":"https://api.github.com/users/seantalts/following{/other_user}","gists_url":"https://api.github.com/users/seantalts/gists{/gist_id}","starred_url":"https://api.github.com/users/seantalts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seantalts/subscriptions","organizations_url":"https://api.github.com/users/seantalts/orgs","repos_url":"https://api.github.com/users/seantalts/repos","events_url":"https://api.github.com/users/seantalts/events{/privacy}","received_events_url":"https://api.github.com/users/seantalts/received_events","type":"User","site_admin":false},"created_at":"2018-05-20T16:42:28Z","updated_at":"2018-05-20T16:42:28Z","author_association":"MEMBER","body":"For Jenkins, you are getting cpplint errors - check out the `make` target for cpplint and see if you can run a similar command on your modified files, or just use the Jenkins output at the link (it should tell you which files are problematic and how to fix the issues).\r\n\r\nFor Travis, I'm not sure where you're seeing what you're seeing, but the errors I see immediately at the Travis job link are that you're using C++17 stuff?\r\n```\r\n./stan/math/cplx/complex.hpp:29:1: warning: inline variables are a C++17 extension [-Wc++17-extensions]\r\ninline constexpr bool is_cplx_v = is_cplx<T>::value;\r\n```"}}
{"actor":{"display_login":"seantalts"}}