{"action":"opened","number":93,"pull_request":{"url":"https://api.github.com/repos/zeit/ncc/pulls/93","id":235518041,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1NTE4MDQx","html_url":"https://github.com/zeit/ncc/pull/93","diff_url":"https://github.com/zeit/ncc/pull/93.diff","patch_url":"https://github.com/zeit/ncc/pull/93.patch","issue_url":"https://api.github.com/repos/zeit/ncc/issues/93","number":93,"state":"open","locked":false,"title":"Binary relocations","user":{"login":"guybedford","id":598730,"node_id":"MDQ6VXNlcjU5ODczMA==","avatar_url":"https://avatars1.githubusercontent.com/u/598730?v=4","gravatar_id":"","url":"https://api.github.com/users/guybedford","html_url":"https://github.com/guybedford","followers_url":"https://api.github.com/users/guybedford/followers","following_url":"https://api.github.com/users/guybedford/following{/other_user}","gists_url":"https://api.github.com/users/guybedford/gists{/gist_id}","starred_url":"https://api.github.com/users/guybedford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guybedford/subscriptions","organizations_url":"https://api.github.com/users/guybedford/orgs","repos_url":"https://api.github.com/users/guybedford/repos","events_url":"https://api.github.com/users/guybedford/events{/privacy}","received_events_url":"https://api.github.com/users/guybedford/received_events","type":"User","site_admin":false},"body":"Implements https://github.com/zeit/ncc/issues/57 in statically analyzing `require('bindings')` and `require('node-pre-gyp').find` loads and handling them as asset relocations.\r\n\r\nCases supported:\r\n\r\n* `import binary from 'node-pre-gyp'; binary.find(__dirname + 'package.json')`  (plus `import *` variant)\r\n* `require('bindings')('asdf')`\r\n* `var bindings = require('bindings'); bindings('asdf')`\r\n\r\nThis should be merged with the other PRs, so will rebase depending on what order the merges happen.\r\n\r\nBecause of the issue with architecture matching, I originally wanted to enable this specifically behind a \"binary\" flag, but since the default case is then effectively for binaries just not to work, I've left this out for now.","created_at":"2018-12-03T16:51:47Z","updated_at":"2018-12-03T16:51:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zeit/ncc/pulls/93/commits","review_comments_url":"https://api.github.com/repos/zeit/ncc/pulls/93/comments","review_comment_url":"https://api.github.com/repos/zeit/ncc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zeit/ncc/issues/93/comments","statuses_url":"https://api.github.com/repos/zeit/ncc/statuses/b22169604d7e785789f724526efb4a9533e01828","head":{"label":"zeit:binary-relocations","ref":"binary-relocations","sha":"b22169604d7e785789f724526efb4a9533e01828","user":{"login":"zeit","id":14985020,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTg1MDIw","avatar_url":"https://avatars0.githubusercontent.com/u/14985020?v=4","gravatar_id":"","url":"https://api.github.com/users/zeit","html_url":"https://github.com/zeit","followers_url":"https://api.github.com/users/zeit/followers","following_url":"https://api.github.com/users/zeit/following{/other_user}","gists_url":"https://api.github.com/users/zeit/gists{/gist_id}","starred_url":"https://api.github.com/users/zeit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeit/subscriptions","organizations_url":"https://api.github.com/users/zeit/orgs","repos_url":"https://api.github.com/users/zeit/repos","events_url":"https://api.github.com/users/zeit/events{/privacy}","received_events_url":"https://api.github.com/users/zeit/received_events","type":"Organization","site_admin":false},"repo":{"id":157318000,"node_id":"MDEwOlJlcG9zaXRvcnkxNTczMTgwMDA=","name":"ncc","full_name":"zeit/ncc","private":false,"owner":{"login":"zeit","id":14985020,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTg1MDIw","avatar_url":"https://avatars0.githubusercontent.com/u/14985020?v=4","gravatar_id":"","url":"https://api.github.com/users/zeit","html_url":"https://github.com/zeit","followers_url":"https://api.github.com/users/zeit/followers","following_url":"https://api.github.com/users/zeit/following{/other_user}","gists_url":"https://api.github.com/users/zeit/gists{/gist_id}","starred_url":"https://api.github.com/users/zeit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeit/subscriptions","organizations_url":"https://api.github.com/users/zeit/orgs","repos_url":"https://api.github.com/users/zeit/repos","events_url":"https://api.github.com/users/zeit/events{/privacy}","received_events_url":"https://api.github.com/users/zeit/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/zeit/ncc","description":"Node.js Compiler Collection","fork":false,"url":"https://api.github.com/repos/zeit/ncc","forks_url":"https://api.github.com/repos/zeit/ncc/forks","keys_url":"https://api.github.com/repos/zeit/ncc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zeit/ncc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zeit/ncc/teams","hooks_url":"https://api.github.com/repos/zeit/ncc/hooks","issue_events_url":"https://api.github.com/repos/zeit/ncc/issues/events{/number}","events_url":"https://api.github.com/repos/zeit/ncc/events","assignees_url":"https://api.github.com/repos/zeit/ncc/assignees{/user}","branches_url":"https://api.github.com/repos/zeit/ncc/branches{/branch}","tags_url":"https://api.github.com/repos/zeit/ncc/tags","blobs_url":"https://api.github.com/repos/zeit/ncc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zeit/ncc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zeit/ncc/git/refs{/sha}","trees_url":"https://api.github.com/repos/zeit/ncc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zeit/ncc/statuses/{sha}","languages_url":"https://api.github.com/repos/zeit/ncc/languages","stargazers_url":"https://api.github.com/repos/zeit/ncc/stargazers","contributors_url":"https://api.github.com/repos/zeit/ncc/contributors","subscribers_url":"https://api.github.com/repos/zeit/ncc/subscribers","subscription_url":"https://api.github.com/repos/zeit/ncc/subscription","commits_url":"https://api.github.com/repos/zeit/ncc/commits{/sha}","git_commits_url":"https://api.github.com/repos/zeit/ncc/git/commits{/sha}","comments_url":"https://api.github.com/repos/zeit/ncc/comments{/number}","issue_comment_url":"https://api.github.com/repos/zeit/ncc/issues/comments{/number}","contents_url":"https://api.github.com/repos/zeit/ncc/contents/{+path}","compare_url":"https://api.github.com/repos/zeit/ncc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zeit/ncc/merges","archive_url":"https://api.github.com/repos/zeit/ncc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zeit/ncc/downloads","issues_url":"https://api.github.com/repos/zeit/ncc/issues{/number}","pulls_url":"https://api.github.com/repos/zeit/ncc/pulls{/number}","milestones_url":"https://api.github.com/repos/zeit/ncc/milestones{/number}","notifications_url":"https://api.github.com/repos/zeit/ncc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zeit/ncc/labels{/name}","releases_url":"https://api.github.com/repos/zeit/ncc/releases{/id}","deployments_url":"https://api.github.com/repos/zeit/ncc/deployments","created_at":"2018-11-13T04:00:21Z","updated_at":"2018-12-03T16:10:55Z","pushed_at":"2018-12-03T16:45:43Z","git_url":"git://github.com/zeit/ncc.git","ssh_url":"git@github.com:zeit/ncc.git","clone_url":"https://github.com/zeit/ncc.git","svn_url":"https://github.com/zeit/ncc","homepage":"","size":5093,"stargazers_count":1318,"watchers_count":1318,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":24,"license":null,"forks":27,"open_issues":24,"watchers":1318,"default_branch":"master"}},"base":{"label":"zeit:master","ref":"master","sha":"290b4a0dfcc327af1c2a6f75fc9554791cf7eafa","user":{"login":"zeit","id":14985020,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTg1MDIw","avatar_url":"https://avatars0.githubusercontent.com/u/14985020?v=4","gravatar_id":"","url":"https://api.github.com/users/zeit","html_url":"https://github.com/zeit","followers_url":"https://api.github.com/users/zeit/followers","following_url":"https://api.github.com/users/zeit/following{/other_user}","gists_url":"https://api.github.com/users/zeit/gists{/gist_id}","starred_url":"https://api.github.com/users/zeit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeit/subscriptions","organizations_url":"https://api.github.com/users/zeit/orgs","repos_url":"https://api.github.com/users/zeit/repos","events_url":"https://api.github.com/users/zeit/events{/privacy}","received_events_url":"https://api.github.com/users/zeit/received_events","type":"Organization","site_admin":false},"repo":{"id":157318000,"node_id":"MDEwOlJlcG9zaXRvcnkxNTczMTgwMDA=","name":"ncc","full_name":"zeit/ncc","private":false,"owner":{"login":"zeit","id":14985020,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTg1MDIw","avatar_url":"https://avatars0.githubusercontent.com/u/14985020?v=4","gravatar_id":"","url":"https://api.github.com/users/zeit","html_url":"https://github.com/zeit","followers_url":"https://api.github.com/users/zeit/followers","following_url":"https://api.github.com/users/zeit/following{/other_user}","gists_url":"https://api.github.com/users/zeit/gists{/gist_id}","starred_url":"https://api.github.com/users/zeit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeit/subscriptions","organizations_url":"https://api.github.com/users/zeit/orgs","repos_url":"https://api.github.com/users/zeit/repos","events_url":"https://api.github.com/users/zeit/events{/privacy}","received_events_url":"https://api.github.com/users/zeit/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/zeit/ncc","description":"Node.js Compiler Collection","fork":false,"url":"https://api.github.com/repos/zeit/ncc","forks_url":"https://api.github.com/repos/zeit/ncc/forks","keys_url":"https://api.github.com/repos/zeit/ncc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zeit/ncc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zeit/ncc/teams","hooks_url":"https://api.github.com/repos/zeit/ncc/hooks","issue_events_url":"https://api.github.com/repos/zeit/ncc/issues/events{/number}","events_url":"https://api.github.com/repos/zeit/ncc/events","assignees_url":"https://api.github.com/repos/zeit/ncc/assignees{/user}","branches_url":"https://api.github.com/repos/zeit/ncc/branches{/branch}","tags_url":"https://api.github.com/repos/zeit/ncc/tags","blobs_url":"https://api.github.com/repos/zeit/ncc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zeit/ncc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zeit/ncc/git/refs{/sha}","trees_url":"https://api.github.com/repos/zeit/ncc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zeit/ncc/statuses/{sha}","languages_url":"https://api.github.com/repos/zeit/ncc/languages","stargazers_url":"https://api.github.com/repos/zeit/ncc/stargazers","contributors_url":"https://api.github.com/repos/zeit/ncc/contributors","subscribers_url":"https://api.github.com/repos/zeit/ncc/subscribers","subscription_url":"https://api.github.com/repos/zeit/ncc/subscription","commits_url":"https://api.github.com/repos/zeit/ncc/commits{/sha}","git_commits_url":"https://api.github.com/repos/zeit/ncc/git/commits{/sha}","comments_url":"https://api.github.com/repos/zeit/ncc/comments{/number}","issue_comment_url":"https://api.github.com/repos/zeit/ncc/issues/comments{/number}","contents_url":"https://api.github.com/repos/zeit/ncc/contents/{+path}","compare_url":"https://api.github.com/repos/zeit/ncc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zeit/ncc/merges","archive_url":"https://api.github.com/repos/zeit/ncc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zeit/ncc/downloads","issues_url":"https://api.github.com/repos/zeit/ncc/issues{/number}","pulls_url":"https://api.github.com/repos/zeit/ncc/pulls{/number}","milestones_url":"https://api.github.com/repos/zeit/ncc/milestones{/number}","notifications_url":"https://api.github.com/repos/zeit/ncc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zeit/ncc/labels{/name}","releases_url":"https://api.github.com/repos/zeit/ncc/releases{/id}","deployments_url":"https://api.github.com/repos/zeit/ncc/deployments","created_at":"2018-11-13T04:00:21Z","updated_at":"2018-12-03T16:10:55Z","pushed_at":"2018-12-03T16:45:43Z","git_url":"git://github.com/zeit/ncc.git","ssh_url":"git@github.com:zeit/ncc.git","clone_url":"https://github.com/zeit/ncc.git","svn_url":"https://github.com/zeit/ncc","homepage":"","size":5093,"stargazers_count":1318,"watchers_count":1318,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":24,"license":null,"forks":27,"open_issues":24,"watchers":1318,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zeit/ncc/pulls/93"},"html":{"href":"https://github.com/zeit/ncc/pull/93"},"issue":{"href":"https://api.github.com/repos/zeit/ncc/issues/93"},"comments":{"href":"https://api.github.com/repos/zeit/ncc/issues/93/comments"},"review_comments":{"href":"https://api.github.com/repos/zeit/ncc/pulls/93/comments"},"review_comment":{"href":"https://api.github.com/repos/zeit/ncc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zeit/ncc/pulls/93/commits"},"statuses":{"href":"https://api.github.com/repos/zeit/ncc/statuses/b22169604d7e785789f724526efb4a9533e01828"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":137,"deletions":20,"changed_files":4}}
{"actor":{"display_login":"guybedford"}}