{"action":"created","comment":{"url":"https://api.github.com/repos/girleffect/core-general/pulls/comments/181711748","pull_request_review_id":112386303,"id":181711748,"diff_hunk":"@@ -168,9 +168,11 @@ services:\n       context: ../core-management-portal/\n     command: yarn start\n     environment:\n-      - OIDC_RP_CLIENT_ID=client_id_2\n+      - REACT_APP_AUTHORIZATION_ENDPOINT=http://core-authentication-service:8000/login/?next=/openid/authorize/\n+      - REACT_APP_CLIENT_ID=management_portal\n+      - REACT_APP_LOGIN_CALLBACK=http://core-management-portal:3000/#/oidc/callback?\n+      - REACT_APP_MANAGEMENT_LAYER=http://core-management-layer:8000\n       - OIDC_RP_CLIENT_SECRET=super_client_secret_2\n-      - OIDC_OP_AUTHORIZATION_ENDPOINT=http://core-authentication-service:8000/openid/authorize/","path":"docker-compose.yml","position":10,"original_position":10,"commit_id":"7ba0e970df9351f7f908f494708cc64322d29e85","original_commit_id":"7ba0e970df9351f7f908f494708cc64322d29e85","user":{"login":"cobusc","id":574390,"avatar_url":"https://avatars1.githubusercontent.com/u/574390?v=4","gravatar_id":"","url":"https://api.github.com/users/cobusc","html_url":"https://github.com/cobusc","followers_url":"https://api.github.com/users/cobusc/followers","following_url":"https://api.github.com/users/cobusc/following{/other_user}","gists_url":"https://api.github.com/users/cobusc/gists{/gist_id}","starred_url":"https://api.github.com/users/cobusc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cobusc/subscriptions","organizations_url":"https://api.github.com/users/cobusc/orgs","repos_url":"https://api.github.com/users/cobusc/repos","events_url":"https://api.github.com/users/cobusc/events{/privacy}","received_events_url":"https://api.github.com/users/cobusc/received_events","type":"User","site_admin":false},"body":"Remove please.","created_at":"2018-04-16T12:11:41Z","updated_at":"2018-04-16T12:11:41Z","html_url":"https://github.com/girleffect/core-general/pull/18#discussion_r181711748","pull_request_url":"https://api.github.com/repos/girleffect/core-general/pulls/18","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/girleffect/core-general/pulls/comments/181711748"},"html":{"href":"https://github.com/girleffect/core-general/pull/18#discussion_r181711748"},"pull_request":{"href":"https://api.github.com/repos/girleffect/core-general/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/girleffect/core-general/pulls/18","id":181831834,"html_url":"https://github.com/girleffect/core-general/pull/18","diff_url":"https://github.com/girleffect/core-general/pull/18.diff","patch_url":"https://github.com/girleffect/core-general/pull/18.patch","issue_url":"https://api.github.com/repos/girleffect/core-general/issues/18","number":18,"state":"open","locked":false,"title":"Added REACT_APP env variable to docker compose file for portal server.","user":{"login":"DavidOberholzer","id":20847795,"avatar_url":"https://avatars0.githubusercontent.com/u/20847795?v=4","gravatar_id":"","url":"https://api.github.com/users/DavidOberholzer","html_url":"https://github.com/DavidOberholzer","followers_url":"https://api.github.com/users/DavidOberholzer/followers","following_url":"https://api.github.com/users/DavidOberholzer/following{/other_user}","gists_url":"https://api.github.com/users/DavidOberholzer/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidOberholzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidOberholzer/subscriptions","organizations_url":"https://api.github.com/users/DavidOberholzer/orgs","repos_url":"https://api.github.com/users/DavidOberholzer/repos","events_url":"https://api.github.com/users/DavidOberholzer/events{/privacy}","received_events_url":"https://api.github.com/users/DavidOberholzer/received_events","type":"User","site_admin":false},"body":"Added a REACT_APP_MANAGEMENT_LAYER env variable for the GMP.\r\n\r\n*NODE_ENV* is always `development` using `npm start or yarn start` and cannot be overwritten as per the `create-react-app` docs. *NODE_ENV* is `production` when a `npm build` has been run and that build is in use. All environment variables prefixed with `REACT_APP_` are available in the JS app, hence my addition to the compose file below. Please advise if this is suitable or not the way desired.","created_at":"2018-04-16T11:33:43Z","updated_at":"2018-04-16T12:11:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"593b75d6764524a35197dac55e09cf18c108bda8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/girleffect/core-general/pulls/18/commits","review_comments_url":"https://api.github.com/repos/girleffect/core-general/pulls/18/comments","review_comment_url":"https://api.github.com/repos/girleffect/core-general/pulls/comments{/number}","comments_url":"https://api.github.com/repos/girleffect/core-general/issues/18/comments","statuses_url":"https://api.github.com/repos/girleffect/core-general/statuses/7ba0e970df9351f7f908f494708cc64322d29e85","head":{"label":"girleffect:feature/PortalEnvVariable","ref":"feature/PortalEnvVariable","sha":"7ba0e970df9351f7f908f494708cc64322d29e85","user":{"login":"girleffect","id":33266906,"avatar_url":"https://avatars2.githubusercontent.com/u/33266906?v=4","gravatar_id":"","url":"https://api.github.com/users/girleffect","html_url":"https://github.com/girleffect","followers_url":"https://api.github.com/users/girleffect/followers","following_url":"https://api.github.com/users/girleffect/following{/other_user}","gists_url":"https://api.github.com/users/girleffect/gists{/gist_id}","starred_url":"https://api.github.com/users/girleffect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/girleffect/subscriptions","organizations_url":"https://api.github.com/users/girleffect/orgs","repos_url":"https://api.github.com/users/girleffect/repos","events_url":"https://api.github.com/users/girleffect/events{/privacy}","received_events_url":"https://api.github.com/users/girleffect/received_events","type":"Organization","site_admin":false},"repo":{"id":112725011,"name":"core-general","full_name":"girleffect/core-general","owner":{"login":"girleffect","id":33266906,"avatar_url":"https://avatars2.githubusercontent.com/u/33266906?v=4","gravatar_id":"","url":"https://api.github.com/users/girleffect","html_url":"https://github.com/girleffect","followers_url":"https://api.github.com/users/girleffect/followers","following_url":"https://api.github.com/users/girleffect/following{/other_user}","gists_url":"https://api.github.com/users/girleffect/gists{/gist_id}","starred_url":"https://api.github.com/users/girleffect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/girleffect/subscriptions","organizations_url":"https://api.github.com/users/girleffect/orgs","repos_url":"https://api.github.com/users/girleffect/repos","events_url":"https://api.github.com/users/girleffect/events{/privacy}","received_events_url":"https://api.github.com/users/girleffect/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/girleffect/core-general","description":null,"fork":false,"url":"https://api.github.com/repos/girleffect/core-general","forks_url":"https://api.github.com/repos/girleffect/core-general/forks","keys_url":"https://api.github.com/repos/girleffect/core-general/keys{/key_id}","collaborators_url":"https://api.github.com/repos/girleffect/core-general/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/girleffect/core-general/teams","hooks_url":"https://api.github.com/repos/girleffect/core-general/hooks","issue_events_url":"https://api.github.com/repos/girleffect/core-general/issues/events{/number}","events_url":"https://api.github.com/repos/girleffect/core-general/events","assignees_url":"https://api.github.com/repos/girleffect/core-general/assignees{/user}","branches_url":"https://api.github.com/repos/girleffect/core-general/branches{/branch}","tags_url":"https://api.github.com/repos/girleffect/core-general/tags","blobs_url":"https://api.github.com/repos/girleffect/core-general/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/girleffect/core-general/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/girleffect/core-general/git/refs{/sha}","trees_url":"https://api.github.com/repos/girleffect/core-general/git/trees{/sha}","statuses_url":"https://api.github.com/repos/girleffect/core-general/statuses/{sha}","languages_url":"https://api.github.com/repos/girleffect/core-general/languages","stargazers_url":"https://api.github.com/repos/girleffect/core-general/stargazers","contributors_url":"https://api.github.com/repos/girleffect/core-general/contributors","subscribers_url":"https://api.github.com/repos/girleffect/core-general/subscribers","subscription_url":"https://api.github.com/repos/girleffect/core-general/subscription","commits_url":"https://api.github.com/repos/girleffect/core-general/commits{/sha}","git_commits_url":"https://api.github.com/repos/girleffect/core-general/git/commits{/sha}","comments_url":"https://api.github.com/repos/girleffect/core-general/comments{/number}","issue_comment_url":"https://api.github.com/repos/girleffect/core-general/issues/comments{/number}","contents_url":"https://api.github.com/repos/girleffect/core-general/contents/{+path}","compare_url":"https://api.github.com/repos/girleffect/core-general/compare/{base}...{head}","merges_url":"https://api.github.com/repos/girleffect/core-general/merges","archive_url":"https://api.github.com/repos/girleffect/core-general/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/girleffect/core-general/downloads","issues_url":"https://api.github.com/repos/girleffect/core-general/issues{/number}","pulls_url":"https://api.github.com/repos/girleffect/core-general/pulls{/number}","milestones_url":"https://api.github.com/repos/girleffect/core-general/milestones{/number}","notifications_url":"https://api.github.com/repos/girleffect/core-general/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/girleffect/core-general/labels{/name}","releases_url":"https://api.github.com/repos/girleffect/core-general/releases{/id}","deployments_url":"https://api.github.com/repos/girleffect/core-general/deployments","created_at":"2017-12-01T10:05:39Z","updated_at":"2018-04-12T15:41:35Z","pushed_at":"2018-04-16T11:57:27Z","git_url":"git://github.com/girleffect/core-general.git","ssh_url":"git@github.com:girleffect/core-general.git","clone_url":"https://github.com/girleffect/core-general.git","svn_url":"https://github.com/girleffect/core-general","homepage":null,"size":527,"stargazers_count":0,"watchers_count":0,"language":"Makefile","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"girleffect:develop","ref":"develop","sha":"50eefadcf1502ffebed80772a3eccdf80a22dc71","user":{"login":"girleffect","id":33266906,"avatar_url":"https://avatars2.githubusercontent.com/u/33266906?v=4","gravatar_id":"","url":"https://api.github.com/users/girleffect","html_url":"https://github.com/girleffect","followers_url":"https://api.github.com/users/girleffect/followers","following_url":"https://api.github.com/users/girleffect/following{/other_user}","gists_url":"https://api.github.com/users/girleffect/gists{/gist_id}","starred_url":"https://api.github.com/users/girleffect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/girleffect/subscriptions","organizations_url":"https://api.github.com/users/girleffect/orgs","repos_url":"https://api.github.com/users/girleffect/repos","events_url":"https://api.github.com/users/girleffect/events{/privacy}","received_events_url":"https://api.github.com/users/girleffect/received_events","type":"Organization","site_admin":false},"repo":{"id":112725011,"name":"core-general","full_name":"girleffect/core-general","owner":{"login":"girleffect","id":33266906,"avatar_url":"https://avatars2.githubusercontent.com/u/33266906?v=4","gravatar_id":"","url":"https://api.github.com/users/girleffect","html_url":"https://github.com/girleffect","followers_url":"https://api.github.com/users/girleffect/followers","following_url":"https://api.github.com/users/girleffect/following{/other_user}","gists_url":"https://api.github.com/users/girleffect/gists{/gist_id}","starred_url":"https://api.github.com/users/girleffect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/girleffect/subscriptions","organizations_url":"https://api.github.com/users/girleffect/orgs","repos_url":"https://api.github.com/users/girleffect/repos","events_url":"https://api.github.com/users/girleffect/events{/privacy}","received_events_url":"https://api.github.com/users/girleffect/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/girleffect/core-general","description":null,"fork":false,"url":"https://api.github.com/repos/girleffect/core-general","forks_url":"https://api.github.com/repos/girleffect/core-general/forks","keys_url":"https://api.github.com/repos/girleffect/core-general/keys{/key_id}","collaborators_url":"https://api.github.com/repos/girleffect/core-general/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/girleffect/core-general/teams","hooks_url":"https://api.github.com/repos/girleffect/core-general/hooks","issue_events_url":"https://api.github.com/repos/girleffect/core-general/issues/events{/number}","events_url":"https://api.github.com/repos/girleffect/core-general/events","assignees_url":"https://api.github.com/repos/girleffect/core-general/assignees{/user}","branches_url":"https://api.github.com/repos/girleffect/core-general/branches{/branch}","tags_url":"https://api.github.com/repos/girleffect/core-general/tags","blobs_url":"https://api.github.com/repos/girleffect/core-general/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/girleffect/core-general/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/girleffect/core-general/git/refs{/sha}","trees_url":"https://api.github.com/repos/girleffect/core-general/git/trees{/sha}","statuses_url":"https://api.github.com/repos/girleffect/core-general/statuses/{sha}","languages_url":"https://api.github.com/repos/girleffect/core-general/languages","stargazers_url":"https://api.github.com/repos/girleffect/core-general/stargazers","contributors_url":"https://api.github.com/repos/girleffect/core-general/contributors","subscribers_url":"https://api.github.com/repos/girleffect/core-general/subscribers","subscription_url":"https://api.github.com/repos/girleffect/core-general/subscription","commits_url":"https://api.github.com/repos/girleffect/core-general/commits{/sha}","git_commits_url":"https://api.github.com/repos/girleffect/core-general/git/commits{/sha}","comments_url":"https://api.github.com/repos/girleffect/core-general/comments{/number}","issue_comment_url":"https://api.github.com/repos/girleffect/core-general/issues/comments{/number}","contents_url":"https://api.github.com/repos/girleffect/core-general/contents/{+path}","compare_url":"https://api.github.com/repos/girleffect/core-general/compare/{base}...{head}","merges_url":"https://api.github.com/repos/girleffect/core-general/merges","archive_url":"https://api.github.com/repos/girleffect/core-general/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/girleffect/core-general/downloads","issues_url":"https://api.github.com/repos/girleffect/core-general/issues{/number}","pulls_url":"https://api.github.com/repos/girleffect/core-general/pulls{/number}","milestones_url":"https://api.github.com/repos/girleffect/core-general/milestones{/number}","notifications_url":"https://api.github.com/repos/girleffect/core-general/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/girleffect/core-general/labels{/name}","releases_url":"https://api.github.com/repos/girleffect/core-general/releases{/id}","deployments_url":"https://api.github.com/repos/girleffect/core-general/deployments","created_at":"2017-12-01T10:05:39Z","updated_at":"2018-04-12T15:41:35Z","pushed_at":"2018-04-16T11:57:27Z","git_url":"git://github.com/girleffect/core-general.git","ssh_url":"git@github.com:girleffect/core-general.git","clone_url":"https://github.com/girleffect/core-general.git","svn_url":"https://github.com/girleffect/core-general","homepage":null,"size":527,"stargazers_count":0,"watchers_count":0,"language":"Makefile","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/girleffect/core-general/pulls/18"},"html":{"href":"https://github.com/girleffect/core-general/pull/18"},"issue":{"href":"https://api.github.com/repos/girleffect/core-general/issues/18"},"comments":{"href":"https://api.github.com/repos/girleffect/core-general/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/girleffect/core-general/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/girleffect/core-general/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/girleffect/core-general/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/girleffect/core-general/statuses/7ba0e970df9351f7f908f494708cc64322d29e85"}},"author_association":"NONE"}}
{"actor":{"display_login":"cobusc"}}