{"action":"created","issue":{"url":"https://api.github.com/repos/sugarlabs/activity-abacus/issues/9","repository_url":"https://api.github.com/repos/sugarlabs/activity-abacus","labels_url":"https://api.github.com/repos/sugarlabs/activity-abacus/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/sugarlabs/activity-abacus/issues/9/comments","events_url":"https://api.github.com/repos/sugarlabs/activity-abacus/issues/9/events","html_url":"https://github.com/sugarlabs/activity-abacus/pull/9","id":293593174,"number":9,"title":"fixed toolbar icon(binary)","user":{"login":"Gr33nMayhem","id":30264970,"avatar_url":"https://avatars2.githubusercontent.com/u/30264970?v=4","gravatar_id":"","url":"https://api.github.com/users/Gr33nMayhem","html_url":"https://github.com/Gr33nMayhem","followers_url":"https://api.github.com/users/Gr33nMayhem/followers","following_url":"https://api.github.com/users/Gr33nMayhem/following{/other_user}","gists_url":"https://api.github.com/users/Gr33nMayhem/gists{/gist_id}","starred_url":"https://api.github.com/users/Gr33nMayhem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gr33nMayhem/subscriptions","organizations_url":"https://api.github.com/users/Gr33nMayhem/orgs","repos_url":"https://api.github.com/users/Gr33nMayhem/repos","events_url":"https://api.github.com/users/Gr33nMayhem/events{/privacy}","received_events_url":"https://api.github.com/users/Gr33nMayhem/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-01T16:22:21Z","updated_at":"2018-02-01T17:13:15Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/sugarlabs/activity-abacus/pulls/9","html_url":"https://github.com/sugarlabs/activity-abacus/pull/9","diff_url":"https://github.com/sugarlabs/activity-abacus/pull/9.diff","patch_url":"https://github.com/sugarlabs/activity-abacus/pull/9.patch"},"body":"The icon of the binary abacus was not being shown on the tool bar. The 'binary' was being read as a key word and that is why the icon was not being shown. I changed the binary.svg to binary1.svg and also made the icon appear in the center rather than against the bottom margin. Now the binary icon is visible on the tool bar."},"comment":{"url":"https://api.github.com/repos/sugarlabs/activity-abacus/issues/comments/362336310","html_url":"https://github.com/sugarlabs/activity-abacus/pull/9#issuecomment-362336310","issue_url":"https://api.github.com/repos/sugarlabs/activity-abacus/issues/9","id":362336310,"user":{"login":"Gr33nMayhem","id":30264970,"avatar_url":"https://avatars2.githubusercontent.com/u/30264970?v=4","gravatar_id":"","url":"https://api.github.com/users/Gr33nMayhem","html_url":"https://github.com/Gr33nMayhem","followers_url":"https://api.github.com/users/Gr33nMayhem/followers","following_url":"https://api.github.com/users/Gr33nMayhem/following{/other_user}","gists_url":"https://api.github.com/users/Gr33nMayhem/gists{/gist_id}","starred_url":"https://api.github.com/users/Gr33nMayhem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gr33nMayhem/subscriptions","organizations_url":"https://api.github.com/users/Gr33nMayhem/orgs","repos_url":"https://api.github.com/users/Gr33nMayhem/repos","events_url":"https://api.github.com/users/Gr33nMayhem/events{/privacy}","received_events_url":"https://api.github.com/users/Gr33nMayhem/received_events","type":"User","site_admin":false},"created_at":"2018-02-01T17:13:14Z","updated_at":"2018-02-01T17:13:14Z","author_association":"NONE","body":"When I was going through the abacus activity to understand the working of\ngtk in depth I noticed that in the toolbar where all the icons of different\ntypes of abacus are located didn't show the icon of the binary abacus. I\ntried replacing the binary icon with the caacupe icons and others to see\nwhere the issue was.To check If it were in the code or the format of the\nicon.\n\nEventually I noticed that I could solve the issue by simply changing the\nbinary.svg to any other name.\n\nI am using Sucrose desktop installed on my Ubuntu to run the various\nactivity and to edit them directly in the /usr/share/sugar/activities\ndirectory.\n\nIt could be possible that the issue is simply under the environment I am\nusing if the icons are already working well for you.\n\nApologies for the caacupe icon. It wasn't intended to be changed.\n\nIf you like I can attach the screenshots or the images of before and after\nthe change.\n\nRegards\nAzhar Ali Khaked\n\nOn Feb 1, 2018 10:02 PM, \"Walter Bender\" <notifications@github.com> wrote:\n\n> I am not experiencing the issue you are trying to address. Can you explain\n> how you are testing?\n> Also, why is there a change to the Caacupe icon in your patch?\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/sugarlabs/activity-abacus/pull/9#issuecomment-362322115>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/Ac3OipShwGJBNURG1r3jHDdy4hsqA8Qfks5tQecYgaJpZM4R14m3>\n> .\n>\n"}}
{"actor":{"display_login":"Gr33nMayhem"}}