{"action":"closed","issue":{"url":"https://api.github.com/repos/pawelgrzybek/siema/issues/141","repository_url":"https://api.github.com/repos/pawelgrzybek/siema","labels_url":"https://api.github.com/repos/pawelgrzybek/siema/issues/141/labels{/name}","comments_url":"https://api.github.com/repos/pawelgrzybek/siema/issues/141/comments","events_url":"https://api.github.com/repos/pawelgrzybek/siema/issues/141/events","html_url":"https://github.com/pawelgrzybek/siema/issues/141","id":303778916,"number":141,"title":"Add resizeHandler to public API documentation","user":{"login":"adiulici","id":2994684,"avatar_url":"https://avatars2.githubusercontent.com/u/2994684?v=4","gravatar_id":"","url":"https://api.github.com/users/adiulici","html_url":"https://github.com/adiulici","followers_url":"https://api.github.com/users/adiulici/followers","following_url":"https://api.github.com/users/adiulici/following{/other_user}","gists_url":"https://api.github.com/users/adiulici/gists{/gist_id}","starred_url":"https://api.github.com/users/adiulici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adiulici/subscriptions","organizations_url":"https://api.github.com/users/adiulici/orgs","repos_url":"https://api.github.com/users/adiulici/repos","events_url":"https://api.github.com/users/adiulici/events{/privacy}","received_events_url":"https://api.github.com/users/adiulici/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-09T09:37:54Z","updated_at":"2018-03-09T10:03:52Z","closed_at":"2018-03-09T10:03:52Z","author_association":"NONE","body":"I ran into a common problem for which, I just noticed, you have a codepen: \"update size on container size change\". I needed to reset Siema when the container size updated.\r\n\r\nSince this is a pretty common use case, I think the `resetHandler` method should be added to the public API from the documentation. I have two reasons to say this:\r\n1. Since I did not found it in the documentation, I had to dig into the code a bit and see if there something like this available. It was easy and I found it, there was no problem, but for such a common use case it would be nice if we could find this directly in the documentation.\r\n2. Even though I found the solution in the code, since it's not in the public API documentation you wrote, I was a bit hesitant to use it. Since it's not in the public API, you could change it anytime I thought, and I could run into problems. \r\n\r\nI noticed later your codepen where you are using it, so I guess you probably won't change the name, but I still think it would come easier to just add it to the documentation. Also, I guess if you do decide to add it to the documentation `resizeHandler` isn't really an appropriate name. Maybe something like `reset`?\r\n\r\nIf you agree with what I said but don't have time to add it, let me know and if it's ok with you I can submit a PR with the change.\r\n\r\nHave a great day,\r\nAdi Ulici"}}
{"actor":{"display_login":"pawelgrzybek"}}