{"action":"closed","number":274,"pull_request":{"url":"https://api.github.com/repos/wizaplace/starterkit/pulls/274","id":173186716,"html_url":"https://github.com/wizaplace/starterkit/pull/274","diff_url":"https://github.com/wizaplace/starterkit/pull/274.diff","patch_url":"https://github.com/wizaplace/starterkit/pull/274.patch","issue_url":"https://api.github.com/repos/wizaplace/starterkit/issues/274","number":274,"state":"closed","locked":false,"title":"remove momentJs and the vue method that used it","user":{"login":"ngdo-pro","id":22030946,"avatar_url":"https://avatars2.githubusercontent.com/u/22030946?v=4","gravatar_id":"","url":"https://api.github.com/users/ngdo-pro","html_url":"https://github.com/ngdo-pro","followers_url":"https://api.github.com/users/ngdo-pro/followers","following_url":"https://api.github.com/users/ngdo-pro/following{/other_user}","gists_url":"https://api.github.com/users/ngdo-pro/gists{/gist_id}","starred_url":"https://api.github.com/users/ngdo-pro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngdo-pro/subscriptions","organizations_url":"https://api.github.com/users/ngdo-pro/orgs","repos_url":"https://api.github.com/users/ngdo-pro/repos","events_url":"https://api.github.com/users/ngdo-pro/events{/privacy}","received_events_url":"https://api.github.com/users/ngdo-pro/received_events","type":"User","site_admin":false},"body":"MomentJs n'était utilisé qu'à un endroit, et la méthode `isNew` n'était pas utilisée dans le template afférent. \r\n\r\nLa majorité des clients définissent les nouveautés avec un attribut, plutôt que via un délai. \r\nOn va donc partir sur de la documentation et ne pas remplacer cela dans le starterKit (puisque les ids d'attributs changent)\r\n\r\nfix #273 ","created_at":"2018-03-06T15:11:49Z","updated_at":"2018-03-06T15:36:47Z","closed_at":"2018-03-06T15:36:47Z","merged_at":"2018-03-06T15:36:47Z","merge_commit_sha":"95063c7410cfde79eeff203131357d1205ae4cc8","assignee":{"login":"ngdo-pro","id":22030946,"avatar_url":"https://avatars2.githubusercontent.com/u/22030946?v=4","gravatar_id":"","url":"https://api.github.com/users/ngdo-pro","html_url":"https://github.com/ngdo-pro","followers_url":"https://api.github.com/users/ngdo-pro/followers","following_url":"https://api.github.com/users/ngdo-pro/following{/other_user}","gists_url":"https://api.github.com/users/ngdo-pro/gists{/gist_id}","starred_url":"https://api.github.com/users/ngdo-pro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngdo-pro/subscriptions","organizations_url":"https://api.github.com/users/ngdo-pro/orgs","repos_url":"https://api.github.com/users/ngdo-pro/repos","events_url":"https://api.github.com/users/ngdo-pro/events{/privacy}","received_events_url":"https://api.github.com/users/ngdo-pro/received_events","type":"User","site_admin":false},"assignees":[{"login":"ngdo-pro","id":22030946,"avatar_url":"https://avatars2.githubusercontent.com/u/22030946?v=4","gravatar_id":"","url":"https://api.github.com/users/ngdo-pro","html_url":"https://github.com/ngdo-pro","followers_url":"https://api.github.com/users/ngdo-pro/followers","following_url":"https://api.github.com/users/ngdo-pro/following{/other_user}","gists_url":"https://api.github.com/users/ngdo-pro/gists{/gist_id}","starred_url":"https://api.github.com/users/ngdo-pro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngdo-pro/subscriptions","organizations_url":"https://api.github.com/users/ngdo-pro/orgs","repos_url":"https://api.github.com/users/ngdo-pro/repos","events_url":"https://api.github.com/users/ngdo-pro/events{/privacy}","received_events_url":"https://api.github.com/users/ngdo-pro/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"DavidFyon","id":1822420,"avatar_url":"https://avatars0.githubusercontent.com/u/1822420?v=4","gravatar_id":"","url":"https://api.github.com/users/DavidFyon","html_url":"https://github.com/DavidFyon","followers_url":"https://api.github.com/users/DavidFyon/followers","following_url":"https://api.github.com/users/DavidFyon/following{/other_user}","gists_url":"https://api.github.com/users/DavidFyon/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidFyon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidFyon/subscriptions","organizations_url":"https://api.github.com/users/DavidFyon/orgs","repos_url":"https://api.github.com/users/DavidFyon/repos","events_url":"https://api.github.com/users/DavidFyon/events{/privacy}","received_events_url":"https://api.github.com/users/DavidFyon/received_events","type":"User","site_admin":false},{"login":"sergemazille","id":7364168,"avatar_url":"https://avatars3.githubusercontent.com/u/7364168?v=4","gravatar_id":"","url":"https://api.github.com/users/sergemazille","html_url":"https://github.com/sergemazille","followers_url":"https://api.github.com/users/sergemazille/followers","following_url":"https://api.github.com/users/sergemazille/following{/other_user}","gists_url":"https://api.github.com/users/sergemazille/gists{/gist_id}","starred_url":"https://api.github.com/users/sergemazille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergemazille/subscriptions","organizations_url":"https://api.github.com/users/sergemazille/orgs","repos_url":"https://api.github.com/users/sergemazille/repos","events_url":"https://api.github.com/users/sergemazille/events{/privacy}","received_events_url":"https://api.github.com/users/sergemazille/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wizaplace/starterkit/pulls/274/commits","review_comments_url":"https://api.github.com/repos/wizaplace/starterkit/pulls/274/comments","review_comment_url":"https://api.github.com/repos/wizaplace/starterkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wizaplace/starterkit/issues/274/comments","statuses_url":"https://api.github.com/repos/wizaplace/starterkit/statuses/dfa19400a127978b3e7aa3bf6ead26c348462cb9","head":{"label":"wizaplace:remove_momentjs","ref":"remove_momentjs","sha":"dfa19400a127978b3e7aa3bf6ead26c348462cb9","user":{"login":"wizaplace","id":23238091,"avatar_url":"https://avatars3.githubusercontent.com/u/23238091?v=4","gravatar_id":"","url":"https://api.github.com/users/wizaplace","html_url":"https://github.com/wizaplace","followers_url":"https://api.github.com/users/wizaplace/followers","following_url":"https://api.github.com/users/wizaplace/following{/other_user}","gists_url":"https://api.github.com/users/wizaplace/gists{/gist_id}","starred_url":"https://api.github.com/users/wizaplace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wizaplace/subscriptions","organizations_url":"https://api.github.com/users/wizaplace/orgs","repos_url":"https://api.github.com/users/wizaplace/repos","events_url":"https://api.github.com/users/wizaplace/events{/privacy}","received_events_url":"https://api.github.com/users/wizaplace/received_events","type":"Organization","site_admin":false},"repo":{"id":92949123,"name":"starterkit","full_name":"wizaplace/starterkit","owner":{"login":"wizaplace","id":23238091,"avatar_url":"https://avatars3.githubusercontent.com/u/23238091?v=4","gravatar_id":"","url":"https://api.github.com/users/wizaplace","html_url":"https://github.com/wizaplace","followers_url":"https://api.github.com/users/wizaplace/followers","following_url":"https://api.github.com/users/wizaplace/following{/other_user}","gists_url":"https://api.github.com/users/wizaplace/gists{/gist_id}","starred_url":"https://api.github.com/users/wizaplace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wizaplace/subscriptions","organizations_url":"https://api.github.com/users/wizaplace/orgs","repos_url":"https://api.github.com/users/wizaplace/repos","events_url":"https://api.github.com/users/wizaplace/events{/privacy}","received_events_url":"https://api.github.com/users/wizaplace/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wizaplace/starterkit","description":"Front-office Starter Kit","fork":false,"url":"https://api.github.com/repos/wizaplace/starterkit","forks_url":"https://api.github.com/repos/wizaplace/starterkit/forks","keys_url":"https://api.github.com/repos/wizaplace/starterkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wizaplace/starterkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wizaplace/starterkit/teams","hooks_url":"https://api.github.com/repos/wizaplace/starterkit/hooks","issue_events_url":"https://api.github.com/repos/wizaplace/starterkit/issues/events{/number}","events_url":"https://api.github.com/repos/wizaplace/starterkit/events","assignees_url":"https://api.github.com/repos/wizaplace/starterkit/assignees{/user}","branches_url":"https://api.github.com/repos/wizaplace/starterkit/branches{/branch}","tags_url":"https://api.github.com/repos/wizaplace/starterkit/tags","blobs_url":"https://api.github.com/repos/wizaplace/starterkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wizaplace/starterkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wizaplace/starterkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/wizaplace/starterkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wizaplace/starterkit/statuses/{sha}","languages_url":"https://api.github.com/repos/wizaplace/starterkit/languages","stargazers_url":"https://api.github.com/repos/wizaplace/starterkit/stargazers","contributors_url":"https://api.github.com/repos/wizaplace/starterkit/contributors","subscribers_url":"https://api.github.com/repos/wizaplace/starterkit/subscribers","subscription_url":"https://api.github.com/repos/wizaplace/starterkit/subscription","commits_url":"https://api.github.com/repos/wizaplace/starterkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/wizaplace/starterkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/wizaplace/starterkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/wizaplace/starterkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/wizaplace/starterkit/contents/{+path}","compare_url":"https://api.github.com/repos/wizaplace/starterkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wizaplace/starterkit/merges","archive_url":"https://api.github.com/repos/wizaplace/starterkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wizaplace/starterkit/downloads","issues_url":"https://api.github.com/repos/wizaplace/starterkit/issues{/number}","pulls_url":"https://api.github.com/repos/wizaplace/starterkit/pulls{/number}","milestones_url":"https://api.github.com/repos/wizaplace/starterkit/milestones{/number}","notifications_url":"https://api.github.com/repos/wizaplace/starterkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wizaplace/starterkit/labels{/name}","releases_url":"https://api.github.com/repos/wizaplace/starterkit/releases{/id}","deployments_url":"https://api.github.com/repos/wizaplace/starterkit/deployments","created_at":"2017-05-31T13:35:13Z","updated_at":"2018-01-10T09:53:57Z","pushed_at":"2018-03-06T15:36:47Z","git_url":"git://github.com/wizaplace/starterkit.git","ssh_url":"git@github.com:wizaplace/starterkit.git","clone_url":"https://github.com/wizaplace/starterkit.git","svn_url":"https://github.com/wizaplace/starterkit","homepage":"https://master-7rqtwti-wbh66nf3eg4jo.eu.platform.sh/","size":2162,"stargazers_count":3,"watchers_count":3,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":24,"license":null,"forks":2,"open_issues":24,"watchers":3,"default_branch":"master"}},"base":{"label":"wizaplace:master","ref":"master","sha":"a8436f96209a82d98f553f964d0080521030b257","user":{"login":"wizaplace","id":23238091,"avatar_url":"https://avatars3.githubusercontent.com/u/23238091?v=4","gravatar_id":"","url":"https://api.github.com/users/wizaplace","html_url":"https://github.com/wizaplace","followers_url":"https://api.github.com/users/wizaplace/followers","following_url":"https://api.github.com/users/wizaplace/following{/other_user}","gists_url":"https://api.github.com/users/wizaplace/gists{/gist_id}","starred_url":"https://api.github.com/users/wizaplace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wizaplace/subscriptions","organizations_url":"https://api.github.com/users/wizaplace/orgs","repos_url":"https://api.github.com/users/wizaplace/repos","events_url":"https://api.github.com/users/wizaplace/events{/privacy}","received_events_url":"https://api.github.com/users/wizaplace/received_events","type":"Organization","site_admin":false},"repo":{"id":92949123,"name":"starterkit","full_name":"wizaplace/starterkit","owner":{"login":"wizaplace","id":23238091,"avatar_url":"https://avatars3.githubusercontent.com/u/23238091?v=4","gravatar_id":"","url":"https://api.github.com/users/wizaplace","html_url":"https://github.com/wizaplace","followers_url":"https://api.github.com/users/wizaplace/followers","following_url":"https://api.github.com/users/wizaplace/following{/other_user}","gists_url":"https://api.github.com/users/wizaplace/gists{/gist_id}","starred_url":"https://api.github.com/users/wizaplace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wizaplace/subscriptions","organizations_url":"https://api.github.com/users/wizaplace/orgs","repos_url":"https://api.github.com/users/wizaplace/repos","events_url":"https://api.github.com/users/wizaplace/events{/privacy}","received_events_url":"https://api.github.com/users/wizaplace/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wizaplace/starterkit","description":"Front-office Starter Kit","fork":false,"url":"https://api.github.com/repos/wizaplace/starterkit","forks_url":"https://api.github.com/repos/wizaplace/starterkit/forks","keys_url":"https://api.github.com/repos/wizaplace/starterkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wizaplace/starterkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wizaplace/starterkit/teams","hooks_url":"https://api.github.com/repos/wizaplace/starterkit/hooks","issue_events_url":"https://api.github.com/repos/wizaplace/starterkit/issues/events{/number}","events_url":"https://api.github.com/repos/wizaplace/starterkit/events","assignees_url":"https://api.github.com/repos/wizaplace/starterkit/assignees{/user}","branches_url":"https://api.github.com/repos/wizaplace/starterkit/branches{/branch}","tags_url":"https://api.github.com/repos/wizaplace/starterkit/tags","blobs_url":"https://api.github.com/repos/wizaplace/starterkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wizaplace/starterkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wizaplace/starterkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/wizaplace/starterkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wizaplace/starterkit/statuses/{sha}","languages_url":"https://api.github.com/repos/wizaplace/starterkit/languages","stargazers_url":"https://api.github.com/repos/wizaplace/starterkit/stargazers","contributors_url":"https://api.github.com/repos/wizaplace/starterkit/contributors","subscribers_url":"https://api.github.com/repos/wizaplace/starterkit/subscribers","subscription_url":"https://api.github.com/repos/wizaplace/starterkit/subscription","commits_url":"https://api.github.com/repos/wizaplace/starterkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/wizaplace/starterkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/wizaplace/starterkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/wizaplace/starterkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/wizaplace/starterkit/contents/{+path}","compare_url":"https://api.github.com/repos/wizaplace/starterkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wizaplace/starterkit/merges","archive_url":"https://api.github.com/repos/wizaplace/starterkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wizaplace/starterkit/downloads","issues_url":"https://api.github.com/repos/wizaplace/starterkit/issues{/number}","pulls_url":"https://api.github.com/repos/wizaplace/starterkit/pulls{/number}","milestones_url":"https://api.github.com/repos/wizaplace/starterkit/milestones{/number}","notifications_url":"https://api.github.com/repos/wizaplace/starterkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wizaplace/starterkit/labels{/name}","releases_url":"https://api.github.com/repos/wizaplace/starterkit/releases{/id}","deployments_url":"https://api.github.com/repos/wizaplace/starterkit/deployments","created_at":"2017-05-31T13:35:13Z","updated_at":"2018-01-10T09:53:57Z","pushed_at":"2018-03-06T15:36:47Z","git_url":"git://github.com/wizaplace/starterkit.git","ssh_url":"git@github.com:wizaplace/starterkit.git","clone_url":"https://github.com/wizaplace/starterkit.git","svn_url":"https://github.com/wizaplace/starterkit","homepage":"https://master-7rqtwti-wbh66nf3eg4jo.eu.platform.sh/","size":2162,"stargazers_count":3,"watchers_count":3,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":24,"license":null,"forks":2,"open_issues":24,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wizaplace/starterkit/pulls/274"},"html":{"href":"https://github.com/wizaplace/starterkit/pull/274"},"issue":{"href":"https://api.github.com/repos/wizaplace/starterkit/issues/274"},"comments":{"href":"https://api.github.com/repos/wizaplace/starterkit/issues/274/comments"},"review_comments":{"href":"https://api.github.com/repos/wizaplace/starterkit/pulls/274/comments"},"review_comment":{"href":"https://api.github.com/repos/wizaplace/starterkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wizaplace/starterkit/pulls/274/commits"},"statuses":{"href":"https://api.github.com/repos/wizaplace/starterkit/statuses/dfa19400a127978b3e7aa3bf6ead26c348462cb9"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ngdo-pro","id":22030946,"avatar_url":"https://avatars2.githubusercontent.com/u/22030946?v=4","gravatar_id":"","url":"https://api.github.com/users/ngdo-pro","html_url":"https://github.com/ngdo-pro","followers_url":"https://api.github.com/users/ngdo-pro/followers","following_url":"https://api.github.com/users/ngdo-pro/following{/other_user}","gists_url":"https://api.github.com/users/ngdo-pro/gists{/gist_id}","starred_url":"https://api.github.com/users/ngdo-pro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngdo-pro/subscriptions","organizations_url":"https://api.github.com/users/ngdo-pro/orgs","repos_url":"https://api.github.com/users/ngdo-pro/repos","events_url":"https://api.github.com/users/ngdo-pro/events{/privacy}","received_events_url":"https://api.github.com/users/ngdo-pro/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1953,"deletions":2973,"changed_files":3}}
{"actor":{"display_login":"ngdo-pro"}}