{"action":"created","comment":{"url":"https://api.github.com/repos/lampepfl/dotty/pulls/comments/230584273","pull_request_review_id":171357999,"id":230584273,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDU4NDI3Mw==","diff_hunk":"@@ -585,8 +585,9 @@ object Trees {\n \n   /** A tree representing inlined code.\n    *\n-   *  @param  call      Info about the original call that was inlined.\n-   *                    Only a reference to the toplevel class from which the call was inlined.\n+   *  @param  call      Info about the original call that was inlined\n+   *                    Until PostTyper, this is the full call, afterwards only\n+   *                    a reference to the toplevel class from which the call was inlined.","path":"compiler/src/dotty/tools/dotc/ast/Trees.scala","position":8,"original_position":8,"commit_id":"4f67e612ec8bf7185dfbeac2b0065ad39c2e7325","original_commit_id":"4f67e612ec8bf7185dfbeac2b0065ad39c2e7325","user":{"login":"odersky","id":795990,"node_id":"MDQ6VXNlcjc5NTk5MA==","avatar_url":"https://avatars2.githubusercontent.com/u/795990?v=4","gravatar_id":"","url":"https://api.github.com/users/odersky","html_url":"https://github.com/odersky","followers_url":"https://api.github.com/users/odersky/followers","following_url":"https://api.github.com/users/odersky/following{/other_user}","gists_url":"https://api.github.com/users/odersky/gists{/gist_id}","starred_url":"https://api.github.com/users/odersky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odersky/subscriptions","organizations_url":"https://api.github.com/users/odersky/orgs","repos_url":"https://api.github.com/users/odersky/repos","events_url":"https://api.github.com/users/odersky/events{/privacy}","received_events_url":"https://api.github.com/users/odersky/received_events","type":"User","site_admin":false},"body":"Regarding bytecode size: if we have several nested trace-like calls the blowup could be exponential. You can see this sometimes when you print at phase frontend without -Yshow-no-inlines.\r\n","created_at":"2018-11-04T11:09:51Z","updated_at":"2018-11-04T11:09:51Z","html_url":"https://github.com/lampepfl/dotty/pull/5382#discussion_r230584273","pull_request_url":"https://api.github.com/repos/lampepfl/dotty/pulls/5382","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/lampepfl/dotty/pulls/comments/230584273"},"html":{"href":"https://github.com/lampepfl/dotty/pull/5382#discussion_r230584273"},"pull_request":{"href":"https://api.github.com/repos/lampepfl/dotty/pulls/5382"}},"in_reply_to_id":230583860},"pull_request":{"url":"https://api.github.com/repos/lampepfl/dotty/pulls/5382","id":228169178,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MTY5MTc4","html_url":"https://github.com/lampepfl/dotty/pull/5382","diff_url":"https://github.com/lampepfl/dotty/pull/5382.diff","patch_url":"https://github.com/lampepfl/dotty/pull/5382.patch","issue_url":"https://api.github.com/repos/lampepfl/dotty/issues/5382","number":5382,"state":"open","locked":false,"title":"Go back to inlining during typing","user":{"login":"odersky","id":795990,"node_id":"MDQ6VXNlcjc5NTk5MA==","avatar_url":"https://avatars2.githubusercontent.com/u/795990?v=4","gravatar_id":"","url":"https://api.github.com/users/odersky","html_url":"https://github.com/odersky","followers_url":"https://api.github.com/users/odersky/followers","following_url":"https://api.github.com/users/odersky/following{/other_user}","gists_url":"https://api.github.com/users/odersky/gists{/gist_id}","starred_url":"https://api.github.com/users/odersky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odersky/subscriptions","organizations_url":"https://api.github.com/users/odersky/orgs","repos_url":"https://api.github.com/users/odersky/repos","events_url":"https://api.github.com/users/odersky/events{/privacy}","received_events_url":"https://api.github.com/users/odersky/received_events","type":"User","site_admin":false},"body":"This is a tentative PR to move inlining back to typer. This will be needed if we want to address #5381.\r\n\r\nReverts the following commits:\r\n\r\nJoin containsQuotesOrSplices and containsInlineCalls (reverted from commit 8cf1385fc956a8d4ca12e14527301e3272c96d41)\r\nMake InlineCalls an object (reverted from commit ad26554411b9c5b340e96f99c33beb299a7170fa)\r\nRemove Inlined and InlineProxy from TASTy (reverted from commit 976e095fd79e7811132b6d85066bbe6253d33bad)\r\nMove inlining inside Reify quotes\r\n\r\nSplit some neg tests as now only the first error is emitted. (reverted from commit 21e65f1e4256ae4eb097e84a668ae5ab94cd0744)\r\nErase rhs of erased non inlined val/def in PostTyper (reverted from commit c12e8753f3dccc6b0bc3b84f19e8160434c340c8)\r\nAdd isInlineCall to TreeInfo (reverted from commit 954c25b3ae85c2f6c68eb4ae209b616f0f987e67)\r\nUpdate doc (reverted from commit 0832e027208830d61e1efba0ca82dfcdad608114)\r\nOnly run InlineCalls if the tree contains an inline call (reverted from commit f28e2e1ee566bbc5a8a77c1a6345e6b779b311f3)\r\nCheck if unpickled tree has inline nodes (reverted from commit 927ae4e60c58318336d493b4c4ecc29ec88242e4)\r\nAdd a bit of documentation (reverted from commit da0c2493cbedf82081ca071363f2713aa5928e89)\r\nFix constant folding during inlining (reverted from commit 32c8798153276a428bd4a1bc7b3e4f924e1f0489)\r\nMove inline β-reduction after Pickler (reverted from commit c68dc1f5ace7486339af1d55884677459d0e85fd)\r\nNormalize call at Inlined node creation (reverted from commit 746fdd7831a588066f2cfc1c64a000df79d40b63)\r\nMove inline β-reduction after post typer (reverted from commit 432eb0a8e2a320e72517cf68c622f0300d221f12)\r\nMove inline β-reduction out of typer (reverted from commit 6acaf31eafca43fb14d566b3eef85c5132005b02)","created_at":"2018-11-04T10:42:07Z","updated_at":"2018-11-04T11:09:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9e6e47781f7f253cc9f12296e9c5c2027337f76","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lampepfl/dotty/pulls/5382/commits","review_comments_url":"https://api.github.com/repos/lampepfl/dotty/pulls/5382/comments","review_comment_url":"https://api.github.com/repos/lampepfl/dotty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lampepfl/dotty/issues/5382/comments","statuses_url":"https://api.github.com/repos/lampepfl/dotty/statuses/4f67e612ec8bf7185dfbeac2b0065ad39c2e7325","head":{"label":"dotty-staging:revert-late-inline","ref":"revert-late-inline","sha":"4f67e612ec8bf7185dfbeac2b0065ad39c2e7325","user":{"login":"dotty-staging","id":6998674,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5OTg2NzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/6998674?v=4","gravatar_id":"","url":"https://api.github.com/users/dotty-staging","html_url":"https://github.com/dotty-staging","followers_url":"https://api.github.com/users/dotty-staging/followers","following_url":"https://api.github.com/users/dotty-staging/following{/other_user}","gists_url":"https://api.github.com/users/dotty-staging/gists{/gist_id}","starred_url":"https://api.github.com/users/dotty-staging/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotty-staging/subscriptions","organizations_url":"https://api.github.com/users/dotty-staging/orgs","repos_url":"https://api.github.com/users/dotty-staging/repos","events_url":"https://api.github.com/users/dotty-staging/events{/privacy}","received_events_url":"https://api.github.com/users/dotty-staging/received_events","type":"Organization","site_admin":false},"repo":{"id":17904384,"node_id":"MDEwOlJlcG9zaXRvcnkxNzkwNDM4NA==","name":"dotty","full_name":"dotty-staging/dotty","private":false,"owner":{"login":"dotty-staging","id":6998674,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5OTg2NzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/6998674?v=4","gravatar_id":"","url":"https://api.github.com/users/dotty-staging","html_url":"https://github.com/dotty-staging","followers_url":"https://api.github.com/users/dotty-staging/followers","following_url":"https://api.github.com/users/dotty-staging/following{/other_user}","gists_url":"https://api.github.com/users/dotty-staging/gists{/gist_id}","starred_url":"https://api.github.com/users/dotty-staging/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotty-staging/subscriptions","organizations_url":"https://api.github.com/users/dotty-staging/orgs","repos_url":"https://api.github.com/users/dotty-staging/repos","events_url":"https://api.github.com/users/dotty-staging/events{/privacy}","received_events_url":"https://api.github.com/users/dotty-staging/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotty-staging/dotty","description":"Research platform for new language concepts and compiler technologies for Scala.","fork":true,"url":"https://api.github.com/repos/dotty-staging/dotty","forks_url":"https://api.github.com/repos/dotty-staging/dotty/forks","keys_url":"https://api.github.com/repos/dotty-staging/dotty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotty-staging/dotty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotty-staging/dotty/teams","hooks_url":"https://api.github.com/repos/dotty-staging/dotty/hooks","issue_events_url":"https://api.github.com/repos/dotty-staging/dotty/issues/events{/number}","events_url":"https://api.github.com/repos/dotty-staging/dotty/events","assignees_url":"https://api.github.com/repos/dotty-staging/dotty/assignees{/user}","branches_url":"https://api.github.com/repos/dotty-staging/dotty/branches{/branch}","tags_url":"https://api.github.com/repos/dotty-staging/dotty/tags","blobs_url":"https://api.github.com/repos/dotty-staging/dotty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotty-staging/dotty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotty-staging/dotty/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotty-staging/dotty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotty-staging/dotty/statuses/{sha}","languages_url":"https://api.github.com/repos/dotty-staging/dotty/languages","stargazers_url":"https://api.github.com/repos/dotty-staging/dotty/stargazers","contributors_url":"https://api.github.com/repos/dotty-staging/dotty/contributors","subscribers_url":"https://api.github.com/repos/dotty-staging/dotty/subscribers","subscription_url":"https://api.github.com/repos/dotty-staging/dotty/subscription","commits_url":"https://api.github.com/repos/dotty-staging/dotty/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotty-staging/dotty/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotty-staging/dotty/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotty-staging/dotty/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotty-staging/dotty/contents/{+path}","compare_url":"https://api.github.com/repos/dotty-staging/dotty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotty-staging/dotty/merges","archive_url":"https://api.github.com/repos/dotty-staging/dotty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotty-staging/dotty/downloads","issues_url":"https://api.github.com/repos/dotty-staging/dotty/issues{/number}","pulls_url":"https://api.github.com/repos/dotty-staging/dotty/pulls{/number}","milestones_url":"https://api.github.com/repos/dotty-staging/dotty/milestones{/number}","notifications_url":"https://api.github.com/repos/dotty-staging/dotty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotty-staging/dotty/labels{/name}","releases_url":"https://api.github.com/repos/dotty-staging/dotty/releases{/id}","deployments_url":"https://api.github.com/repos/dotty-staging/dotty/deployments","created_at":"2014-03-19T13:06:15Z","updated_at":"2018-10-25T09:03:56Z","pushed_at":"2018-11-04T10:40:41Z","git_url":"git://github.com/dotty-staging/dotty.git","ssh_url":"git@github.com:dotty-staging/dotty.git","clone_url":"https://github.com/dotty-staging/dotty.git","svn_url":"https://github.com/dotty-staging/dotty","homepage":"","size":58609,"stargazers_count":68,"watchers_count":68,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":10,"open_issues":0,"watchers":68,"default_branch":"master"}},"base":{"label":"lampepfl:master","ref":"master","sha":"f5b9572f94772a7a5bea3c960f95d7ed974f4ef1","user":{"login":"lampepfl","id":2684793,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODQ3OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/2684793?v=4","gravatar_id":"","url":"https://api.github.com/users/lampepfl","html_url":"https://github.com/lampepfl","followers_url":"https://api.github.com/users/lampepfl/followers","following_url":"https://api.github.com/users/lampepfl/following{/other_user}","gists_url":"https://api.github.com/users/lampepfl/gists{/gist_id}","starred_url":"https://api.github.com/users/lampepfl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lampepfl/subscriptions","organizations_url":"https://api.github.com/users/lampepfl/orgs","repos_url":"https://api.github.com/users/lampepfl/repos","events_url":"https://api.github.com/users/lampepfl/events{/privacy}","received_events_url":"https://api.github.com/users/lampepfl/received_events","type":"Organization","site_admin":false},"repo":{"id":7035651,"node_id":"MDEwOlJlcG9zaXRvcnk3MDM1NjUx","name":"dotty","full_name":"lampepfl/dotty","private":false,"owner":{"login":"lampepfl","id":2684793,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODQ3OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/2684793?v=4","gravatar_id":"","url":"https://api.github.com/users/lampepfl","html_url":"https://github.com/lampepfl","followers_url":"https://api.github.com/users/lampepfl/followers","following_url":"https://api.github.com/users/lampepfl/following{/other_user}","gists_url":"https://api.github.com/users/lampepfl/gists{/gist_id}","starred_url":"https://api.github.com/users/lampepfl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lampepfl/subscriptions","organizations_url":"https://api.github.com/users/lampepfl/orgs","repos_url":"https://api.github.com/users/lampepfl/repos","events_url":"https://api.github.com/users/lampepfl/events{/privacy}","received_events_url":"https://api.github.com/users/lampepfl/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lampepfl/dotty","description":"Research compiler that will become Scala 3","fork":false,"url":"https://api.github.com/repos/lampepfl/dotty","forks_url":"https://api.github.com/repos/lampepfl/dotty/forks","keys_url":"https://api.github.com/repos/lampepfl/dotty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lampepfl/dotty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lampepfl/dotty/teams","hooks_url":"https://api.github.com/repos/lampepfl/dotty/hooks","issue_events_url":"https://api.github.com/repos/lampepfl/dotty/issues/events{/number}","events_url":"https://api.github.com/repos/lampepfl/dotty/events","assignees_url":"https://api.github.com/repos/lampepfl/dotty/assignees{/user}","branches_url":"https://api.github.com/repos/lampepfl/dotty/branches{/branch}","tags_url":"https://api.github.com/repos/lampepfl/dotty/tags","blobs_url":"https://api.github.com/repos/lampepfl/dotty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lampepfl/dotty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lampepfl/dotty/git/refs{/sha}","trees_url":"https://api.github.com/repos/lampepfl/dotty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lampepfl/dotty/statuses/{sha}","languages_url":"https://api.github.com/repos/lampepfl/dotty/languages","stargazers_url":"https://api.github.com/repos/lampepfl/dotty/stargazers","contributors_url":"https://api.github.com/repos/lampepfl/dotty/contributors","subscribers_url":"https://api.github.com/repos/lampepfl/dotty/subscribers","subscription_url":"https://api.github.com/repos/lampepfl/dotty/subscription","commits_url":"https://api.github.com/repos/lampepfl/dotty/commits{/sha}","git_commits_url":"https://api.github.com/repos/lampepfl/dotty/git/commits{/sha}","comments_url":"https://api.github.com/repos/lampepfl/dotty/comments{/number}","issue_comment_url":"https://api.github.com/repos/lampepfl/dotty/issues/comments{/number}","contents_url":"https://api.github.com/repos/lampepfl/dotty/contents/{+path}","compare_url":"https://api.github.com/repos/lampepfl/dotty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lampepfl/dotty/merges","archive_url":"https://api.github.com/repos/lampepfl/dotty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lampepfl/dotty/downloads","issues_url":"https://api.github.com/repos/lampepfl/dotty/issues{/number}","pulls_url":"https://api.github.com/repos/lampepfl/dotty/pulls{/number}","milestones_url":"https://api.github.com/repos/lampepfl/dotty/milestones{/number}","notifications_url":"https://api.github.com/repos/lampepfl/dotty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lampepfl/dotty/labels{/name}","releases_url":"https://api.github.com/repos/lampepfl/dotty/releases{/id}","deployments_url":"https://api.github.com/repos/lampepfl/dotty/deployments","created_at":"2012-12-06T12:57:33Z","updated_at":"2018-11-04T10:43:03Z","pushed_at":"2018-11-04T10:42:48Z","git_url":"git://github.com/lampepfl/dotty.git","ssh_url":"git@github.com:lampepfl/dotty.git","clone_url":"https://github.com/lampepfl/dotty.git","svn_url":"https://github.com/lampepfl/dotty","homepage":"http://dotty.epfl.ch","size":47731,"stargazers_count":2990,"watchers_count":2990,"language":"Scala","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":425,"mirror_url":null,"archived":false,"open_issues_count":493,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":425,"open_issues":493,"watchers":2990,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lampepfl/dotty/pulls/5382"},"html":{"href":"https://github.com/lampepfl/dotty/pull/5382"},"issue":{"href":"https://api.github.com/repos/lampepfl/dotty/issues/5382"},"comments":{"href":"https://api.github.com/repos/lampepfl/dotty/issues/5382/comments"},"review_comments":{"href":"https://api.github.com/repos/lampepfl/dotty/pulls/5382/comments"},"review_comment":{"href":"https://api.github.com/repos/lampepfl/dotty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lampepfl/dotty/pulls/5382/commits"},"statuses":{"href":"https://api.github.com/repos/lampepfl/dotty/statuses/4f67e612ec8bf7185dfbeac2b0065ad39c2e7325"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"odersky"}}