{"action":"closed","number":104,"pull_request":{"url":"https://api.github.com/repos/pelias/config/pulls/104","id":228044516,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MDQ0NTE2","html_url":"https://github.com/pelias/config/pull/104","diff_url":"https://github.com/pelias/config/pull/104.diff","patch_url":"https://github.com/pelias/config/pull/104.patch","issue_url":"https://api.github.com/repos/pelias/config/issues/104","number":104,"state":"closed","locked":false,"title":"feat(generate): Add custom and default config helper functions","user":{"login":"orangejulius","id":111716,"node_id":"MDQ6VXNlcjExMTcxNg==","avatar_url":"https://avatars3.githubusercontent.com/u/111716?v=4","gravatar_id":"","url":"https://api.github.com/users/orangejulius","html_url":"https://github.com/orangejulius","followers_url":"https://api.github.com/users/orangejulius/followers","following_url":"https://api.github.com/users/orangejulius/following{/other_user}","gists_url":"https://api.github.com/users/orangejulius/gists{/gist_id}","starred_url":"https://api.github.com/users/orangejulius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orangejulius/subscriptions","organizations_url":"https://api.github.com/users/orangejulius/orgs","repos_url":"https://api.github.com/users/orangejulius/repos","events_url":"https://api.github.com/users/orangejulius/events{/privacy}","received_events_url":"https://api.github.com/users/orangejulius/received_events","type":"User","site_admin":false},"body":"This adds two new functions to the `pelias-config` module:\r\n\r\n### `generateDefault`\r\nAlways returns the default config, with the `get` function added. While we currently expose a `defaults` object in the module, this won't have the very useful get function added in https://github.com/pelias/config/pull/101\r\n\r\n### `generateCustom`\r\nReturns a config object with custom changes applied. It takes two parameters: `custom_config`, which is an object just like what might be found in a users `pelias.json`, and `deep`, which determines if a deep or shallow merge is performed.\r\n\r\nLike, `generate`, deep defaults to true. And like `generateDefault`, a proper `get` function is added to all returned objects.\r\n\r\nBoth of these functions can be very useful in unit tests. Without them, it's a lot of work to create valid `pelias-config` objects.","created_at":"2018-11-02T20:00:35Z","updated_at":"2018-11-02T20:32:48Z","closed_at":"2018-11-02T20:32:48Z","merged_at":"2018-11-02T20:32:48Z","merge_commit_sha":"c7b42c5cfe685a21d3ada39f9b944448d18f86ee","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pelias/config/pulls/104/commits","review_comments_url":"https://api.github.com/repos/pelias/config/pulls/104/comments","review_comment_url":"https://api.github.com/repos/pelias/config/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pelias/config/issues/104/comments","statuses_url":"https://api.github.com/repos/pelias/config/statuses/11b5d3292f081645b62d5e69abcb74b9a105cc2b","head":{"label":"pelias:test-helper-methods","ref":"test-helper-methods","sha":"11b5d3292f081645b62d5e69abcb74b9a105cc2b","user":{"login":"pelias","id":8240367,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNDAzNjc=","avatar_url":"https://avatars3.githubusercontent.com/u/8240367?v=4","gravatar_id":"","url":"https://api.github.com/users/pelias","html_url":"https://github.com/pelias","followers_url":"https://api.github.com/users/pelias/followers","following_url":"https://api.github.com/users/pelias/following{/other_user}","gists_url":"https://api.github.com/users/pelias/gists{/gist_id}","starred_url":"https://api.github.com/users/pelias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelias/subscriptions","organizations_url":"https://api.github.com/users/pelias/orgs","repos_url":"https://api.github.com/users/pelias/repos","events_url":"https://api.github.com/users/pelias/events{/privacy}","received_events_url":"https://api.github.com/users/pelias/received_events","type":"Organization","site_admin":false},"repo":{"id":22260828,"node_id":"MDEwOlJlcG9zaXRvcnkyMjI2MDgyOA==","name":"config","full_name":"pelias/config","private":false,"owner":{"login":"pelias","id":8240367,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNDAzNjc=","avatar_url":"https://avatars3.githubusercontent.com/u/8240367?v=4","gravatar_id":"","url":"https://api.github.com/users/pelias","html_url":"https://github.com/pelias","followers_url":"https://api.github.com/users/pelias/followers","following_url":"https://api.github.com/users/pelias/following{/other_user}","gists_url":"https://api.github.com/users/pelias/gists{/gist_id}","starred_url":"https://api.github.com/users/pelias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelias/subscriptions","organizations_url":"https://api.github.com/users/pelias/orgs","repos_url":"https://api.github.com/users/pelias/repos","events_url":"https://api.github.com/users/pelias/events{/privacy}","received_events_url":"https://api.github.com/users/pelias/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pelias/config","description":"Configuration file for Pelias","fork":false,"url":"https://api.github.com/repos/pelias/config","forks_url":"https://api.github.com/repos/pelias/config/forks","keys_url":"https://api.github.com/repos/pelias/config/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pelias/config/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pelias/config/teams","hooks_url":"https://api.github.com/repos/pelias/config/hooks","issue_events_url":"https://api.github.com/repos/pelias/config/issues/events{/number}","events_url":"https://api.github.com/repos/pelias/config/events","assignees_url":"https://api.github.com/repos/pelias/config/assignees{/user}","branches_url":"https://api.github.com/repos/pelias/config/branches{/branch}","tags_url":"https://api.github.com/repos/pelias/config/tags","blobs_url":"https://api.github.com/repos/pelias/config/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pelias/config/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pelias/config/git/refs{/sha}","trees_url":"https://api.github.com/repos/pelias/config/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pelias/config/statuses/{sha}","languages_url":"https://api.github.com/repos/pelias/config/languages","stargazers_url":"https://api.github.com/repos/pelias/config/stargazers","contributors_url":"https://api.github.com/repos/pelias/config/contributors","subscribers_url":"https://api.github.com/repos/pelias/config/subscribers","subscription_url":"https://api.github.com/repos/pelias/config/subscription","commits_url":"https://api.github.com/repos/pelias/config/commits{/sha}","git_commits_url":"https://api.github.com/repos/pelias/config/git/commits{/sha}","comments_url":"https://api.github.com/repos/pelias/config/comments{/number}","issue_comment_url":"https://api.github.com/repos/pelias/config/issues/comments{/number}","contents_url":"https://api.github.com/repos/pelias/config/contents/{+path}","compare_url":"https://api.github.com/repos/pelias/config/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pelias/config/merges","archive_url":"https://api.github.com/repos/pelias/config/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pelias/config/downloads","issues_url":"https://api.github.com/repos/pelias/config/issues{/number}","pulls_url":"https://api.github.com/repos/pelias/config/pulls{/number}","milestones_url":"https://api.github.com/repos/pelias/config/milestones{/number}","notifications_url":"https://api.github.com/repos/pelias/config/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pelias/config/labels{/name}","releases_url":"https://api.github.com/repos/pelias/config/releases{/id}","deployments_url":"https://api.github.com/repos/pelias/config/deployments","created_at":"2014-07-25T15:03:50Z","updated_at":"2018-10-30T14:27:38Z","pushed_at":"2018-11-02T20:32:48Z","git_url":"git://github.com/pelias/config.git","ssh_url":"git@github.com:pelias/config.git","clone_url":"https://github.com/pelias/config.git","svn_url":"https://github.com/pelias/config","homepage":null,"size":155,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":18,"open_issues":5,"watchers":6,"default_branch":"master"}},"base":{"label":"pelias:master","ref":"master","sha":"182007cfd60da6b3b0c127e91378021136da3acc","user":{"login":"pelias","id":8240367,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNDAzNjc=","avatar_url":"https://avatars3.githubusercontent.com/u/8240367?v=4","gravatar_id":"","url":"https://api.github.com/users/pelias","html_url":"https://github.com/pelias","followers_url":"https://api.github.com/users/pelias/followers","following_url":"https://api.github.com/users/pelias/following{/other_user}","gists_url":"https://api.github.com/users/pelias/gists{/gist_id}","starred_url":"https://api.github.com/users/pelias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelias/subscriptions","organizations_url":"https://api.github.com/users/pelias/orgs","repos_url":"https://api.github.com/users/pelias/repos","events_url":"https://api.github.com/users/pelias/events{/privacy}","received_events_url":"https://api.github.com/users/pelias/received_events","type":"Organization","site_admin":false},"repo":{"id":22260828,"node_id":"MDEwOlJlcG9zaXRvcnkyMjI2MDgyOA==","name":"config","full_name":"pelias/config","private":false,"owner":{"login":"pelias","id":8240367,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNDAzNjc=","avatar_url":"https://avatars3.githubusercontent.com/u/8240367?v=4","gravatar_id":"","url":"https://api.github.com/users/pelias","html_url":"https://github.com/pelias","followers_url":"https://api.github.com/users/pelias/followers","following_url":"https://api.github.com/users/pelias/following{/other_user}","gists_url":"https://api.github.com/users/pelias/gists{/gist_id}","starred_url":"https://api.github.com/users/pelias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelias/subscriptions","organizations_url":"https://api.github.com/users/pelias/orgs","repos_url":"https://api.github.com/users/pelias/repos","events_url":"https://api.github.com/users/pelias/events{/privacy}","received_events_url":"https://api.github.com/users/pelias/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pelias/config","description":"Configuration file for Pelias","fork":false,"url":"https://api.github.com/repos/pelias/config","forks_url":"https://api.github.com/repos/pelias/config/forks","keys_url":"https://api.github.com/repos/pelias/config/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pelias/config/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pelias/config/teams","hooks_url":"https://api.github.com/repos/pelias/config/hooks","issue_events_url":"https://api.github.com/repos/pelias/config/issues/events{/number}","events_url":"https://api.github.com/repos/pelias/config/events","assignees_url":"https://api.github.com/repos/pelias/config/assignees{/user}","branches_url":"https://api.github.com/repos/pelias/config/branches{/branch}","tags_url":"https://api.github.com/repos/pelias/config/tags","blobs_url":"https://api.github.com/repos/pelias/config/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pelias/config/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pelias/config/git/refs{/sha}","trees_url":"https://api.github.com/repos/pelias/config/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pelias/config/statuses/{sha}","languages_url":"https://api.github.com/repos/pelias/config/languages","stargazers_url":"https://api.github.com/repos/pelias/config/stargazers","contributors_url":"https://api.github.com/repos/pelias/config/contributors","subscribers_url":"https://api.github.com/repos/pelias/config/subscribers","subscription_url":"https://api.github.com/repos/pelias/config/subscription","commits_url":"https://api.github.com/repos/pelias/config/commits{/sha}","git_commits_url":"https://api.github.com/repos/pelias/config/git/commits{/sha}","comments_url":"https://api.github.com/repos/pelias/config/comments{/number}","issue_comment_url":"https://api.github.com/repos/pelias/config/issues/comments{/number}","contents_url":"https://api.github.com/repos/pelias/config/contents/{+path}","compare_url":"https://api.github.com/repos/pelias/config/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pelias/config/merges","archive_url":"https://api.github.com/repos/pelias/config/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pelias/config/downloads","issues_url":"https://api.github.com/repos/pelias/config/issues{/number}","pulls_url":"https://api.github.com/repos/pelias/config/pulls{/number}","milestones_url":"https://api.github.com/repos/pelias/config/milestones{/number}","notifications_url":"https://api.github.com/repos/pelias/config/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pelias/config/labels{/name}","releases_url":"https://api.github.com/repos/pelias/config/releases{/id}","deployments_url":"https://api.github.com/repos/pelias/config/deployments","created_at":"2014-07-25T15:03:50Z","updated_at":"2018-10-30T14:27:38Z","pushed_at":"2018-11-02T20:32:48Z","git_url":"git://github.com/pelias/config.git","ssh_url":"git@github.com:pelias/config.git","clone_url":"https://github.com/pelias/config.git","svn_url":"https://github.com/pelias/config","homepage":null,"size":155,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":18,"open_issues":5,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pelias/config/pulls/104"},"html":{"href":"https://github.com/pelias/config/pull/104"},"issue":{"href":"https://api.github.com/repos/pelias/config/issues/104"},"comments":{"href":"https://api.github.com/repos/pelias/config/issues/104/comments"},"review_comments":{"href":"https://api.github.com/repos/pelias/config/pulls/104/comments"},"review_comment":{"href":"https://api.github.com/repos/pelias/config/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pelias/config/pulls/104/commits"},"statuses":{"href":"https://api.github.com/repos/pelias/config/statuses/11b5d3292f081645b62d5e69abcb74b9a105cc2b"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"orangejulius","id":111716,"node_id":"MDQ6VXNlcjExMTcxNg==","avatar_url":"https://avatars3.githubusercontent.com/u/111716?v=4","gravatar_id":"","url":"https://api.github.com/users/orangejulius","html_url":"https://github.com/orangejulius","followers_url":"https://api.github.com/users/orangejulius/followers","following_url":"https://api.github.com/users/orangejulius/following{/other_user}","gists_url":"https://api.github.com/users/orangejulius/gists{/gist_id}","starred_url":"https://api.github.com/users/orangejulius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orangejulius/subscriptions","organizations_url":"https://api.github.com/users/orangejulius/orgs","repos_url":"https://api.github.com/users/orangejulius/repos","events_url":"https://api.github.com/users/orangejulius/events{/privacy}","received_events_url":"https://api.github.com/users/orangejulius/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":70,"deletions":15,"changed_files":2}}
{"actor":{"display_login":"orangejulius"}}