{"action":"closed","issue":{"url":"https://api.github.com/repos/restic/restic/issues/389","repository_url":"https://api.github.com/repos/restic/restic","labels_url":"https://api.github.com/repos/restic/restic/issues/389/labels{/name}","comments_url":"https://api.github.com/repos/restic/restic/issues/389/comments","events_url":"https://api.github.com/repos/restic/restic/issues/389/events","html_url":"https://github.com/restic/restic/issues/389","id":126982250,"node_id":"MDU6SXNzdWUxMjY5ODIyNTA=","number":389,"title":"local backend consistency","user":{"login":"perillo","id":6217088,"node_id":"MDQ6VXNlcjYyMTcwODg=","avatar_url":"https://avatars3.githubusercontent.com/u/6217088?v=4","gravatar_id":"","url":"https://api.github.com/users/perillo","html_url":"https://github.com/perillo","followers_url":"https://api.github.com/users/perillo/followers","following_url":"https://api.github.com/users/perillo/following{/other_user}","gists_url":"https://api.github.com/users/perillo/gists{/gist_id}","starred_url":"https://api.github.com/users/perillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perillo/subscriptions","organizations_url":"https://api.github.com/users/perillo/orgs","repos_url":"https://api.github.com/users/perillo/repos","events_url":"https://api.github.com/users/perillo/events{/privacy}","received_events_url":"https://api.github.com/users/perillo/received_events","type":"User","site_admin":false},"labels":[{"id":330189921,"node_id":"MDU6TGFiZWwzMzAxODk5MjE=","url":"https://api.github.com/repos/restic/restic/labels/backend:local","name":"backend:local","color":"c7def8","default":false},{"id":95485887,"node_id":"MDU6TGFiZWw5NTQ4NTg4Nw==","url":"https://api.github.com/repos/restic/restic/labels/enhancement","name":"enhancement","color":"bfe5bf","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-01-15T23:54:48Z","updated_at":"2018-10-03T10:36:20Z","closed_at":"2018-10-03T10:36:20Z","author_association":"NONE","body":"One of the primary features of a backup system is data safety, however in the documentation this aspect is not discussed.\nI studied the source code and I find a possible bug in\nhttps://github.com/restic/restic/blob/master/backend/local/local.go#L115\n\nClose is not guaranteed to sync data to disc. I have not read the full code, however it seems that File.Sync is never called. Is this ok?\n\nHere is an interesting reading about how hard is to ensure file consistency, with some patterns that may be useful for restic:\nhttp://danluu.com/file-consistency/\n"}}
{"actor":{"display_login":"fd0"}}