{"action":"created","issue":{"url":"https://api.github.com/repos/ivandavidov/minimal/issues/170","repository_url":"https://api.github.com/repos/ivandavidov/minimal","labels_url":"https://api.github.com/repos/ivandavidov/minimal/issues/170/labels{/name}","comments_url":"https://api.github.com/repos/ivandavidov/minimal/issues/170/comments","events_url":"https://api.github.com/repos/ivandavidov/minimal/issues/170/events","html_url":"https://github.com/ivandavidov/minimal/issues/170","id":334497044,"node_id":"MDU6SXNzdWUzMzQ0OTcwNDQ=","number":170,"title":"FIRMWARE_TYPE=uefi doesn't build","user":{"login":"ohmtech-rdi","id":11056842,"node_id":"MDQ6VXNlcjExMDU2ODQy","avatar_url":"https://avatars2.githubusercontent.com/u/11056842?v=4","gravatar_id":"","url":"https://api.github.com/users/ohmtech-rdi","html_url":"https://github.com/ohmtech-rdi","followers_url":"https://api.github.com/users/ohmtech-rdi/followers","following_url":"https://api.github.com/users/ohmtech-rdi/following{/other_user}","gists_url":"https://api.github.com/users/ohmtech-rdi/gists{/gist_id}","starred_url":"https://api.github.com/users/ohmtech-rdi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ohmtech-rdi/subscriptions","organizations_url":"https://api.github.com/users/ohmtech-rdi/orgs","repos_url":"https://api.github.com/users/ohmtech-rdi/repos","events_url":"https://api.github.com/users/ohmtech-rdi/events{/privacy}","received_events_url":"https://api.github.com/users/ohmtech-rdi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-06-21T13:35:27Z","updated_at":"2018-06-25T12:22:42Z","closed_at":null,"author_association":"NONE","body":"Hi,\r\n\r\nMinimal Linux Live doesn't build with `FIRMWARE_TYPE=uefi`.\r\n\r\n```\r\nExecuting script '12_get_syslinux.sh'.\r\n*** GET SYSLINUX BEGIN ***\r\nFirmware type is 'uefi'.\r\nSyslinux download has been skipped.\r\n[...]\r\nExecuting script '13_prepare_iso.sh'.\r\nls: cannot access '/home/raf/minimal/src/work/syslinux/syslinux-*': No such file or directory\r\n```\r\n\r\nIf I got it right, [`syslinux` download is skipped](https://github.com/ivandavidov/minimal/blob/master/src/12_get_syslinux.sh#L38), which is to be normal since `uefi` doesn't rely on it, but then [evaluation of `WORK_SYSLINUX_DIR`](https://github.com/ivandavidov/minimal/blob/master/src/13_prepare_iso.sh#L9) will fail. I guess `WORK_SYSLINUX_DIR` should be evaluated in [`prepare_boot_bios`](https://github.com/ivandavidov/minimal/blob/master/src/13_prepare_iso.sh#L45).\r\n\r\nThanks!"},"comment":{"url":"https://api.github.com/repos/ivandavidov/minimal/issues/comments/399932659","html_url":"https://github.com/ivandavidov/minimal/issues/170#issuecomment-399932659","issue_url":"https://api.github.com/repos/ivandavidov/minimal/issues/170","id":399932659,"node_id":"MDEyOklzc3VlQ29tbWVudDM5OTkzMjY1OQ==","user":{"login":"ohmtech-rdi","id":11056842,"node_id":"MDQ6VXNlcjExMDU2ODQy","avatar_url":"https://avatars2.githubusercontent.com/u/11056842?v=4","gravatar_id":"","url":"https://api.github.com/users/ohmtech-rdi","html_url":"https://github.com/ohmtech-rdi","followers_url":"https://api.github.com/users/ohmtech-rdi/followers","following_url":"https://api.github.com/users/ohmtech-rdi/following{/other_user}","gists_url":"https://api.github.com/users/ohmtech-rdi/gists{/gist_id}","starred_url":"https://api.github.com/users/ohmtech-rdi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ohmtech-rdi/subscriptions","organizations_url":"https://api.github.com/users/ohmtech-rdi/orgs","repos_url":"https://api.github.com/users/ohmtech-rdi/repos","events_url":"https://api.github.com/users/ohmtech-rdi/events{/privacy}","received_events_url":"https://api.github.com/users/ohmtech-rdi/received_events","type":"User","site_admin":false},"created_at":"2018-06-25T12:22:42Z","updated_at":"2018-06-25T12:22:42Z","author_association":"NONE","body":"So I downloaded the latest master and I got that:\r\n\r\n```\r\n*** GET SYSTEMD-BOOT BEGIN ***\r\nFirmware type is 'uefi'.\r\nDownloading source file from 'https://github.com/ivandavidov/systemd-boot/releases/download/systemd-boot_26-May-2018/systemd-boot_26-May-2018.tar.xz'.\r\nSaving source file in '/home/raf/minimal-master/src/source/systemd-boot_26-May-2018.tar.xz'.\r\n--2018-06-25 14:14:48--  https://github.com/ivandavidov/systemd-boot/releases/download/systemd-boot_26-May-2018/systemd-boot_26-May-2018.tar.xz\r\nResolving github.com (github.com)... 192.30.253.112, 192.30.253.113\r\nConnecting to github.com (github.com)|192.30.253.112|:443... connected.\r\nHTTP request sent, awaiting response... 302 Found\r\nLocation: https://github-production-release-asset-2e65be.s3.amazonaws.com/113753125/653967a4-613c-11e8-8163-fd50548703cd?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20180625%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20180625T121449Z&X-Amz-Expires=300&X-Amz-Signature=47ee2ade39e3c72a497571e800ccd6db1d9cfc0e417b23adc75218107be4cc26&X-Amz-SignedHeaders=host&actor_id=0&response-content-disposition=attachment%3B%20filename%3Dsystemd-boot_26-May-2018.tar.xz&response-content-type=application%2Foctet-stream [following]\r\n--2018-06-25 14:14:49--  https://github-production-release-asset-2e65be.s3.amazonaws.com/113753125/653967a4-613c-11e8-8163-fd50548703cd?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20180625%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20180625T121449Z&X-Amz-Expires=300&X-Amz-Signature=47ee2ade39e3c72a497571e800ccd6db1d9cfc0e417b23adc75218107be4cc26&X-Amz-SignedHeaders=host&actor_id=0&response-content-disposition=attachment%3B%20filename%3Dsystemd-boot_26-May-2018.tar.xz&response-content-type=application%2Foctet-stream\r\nResolving github-production-release-asset-2e65be.s3.amazonaws.com (github-production-release-asset-2e65be.s3.amazonaws.com)... 52.216.99.3\r\nConnecting to github-production-release-asset-2e65be.s3.amazonaws.com (github-production-release-asset-2e65be.s3.amazonaws.com)|52.216.99.3|:443... connected.\r\nHTTP request sent, awaiting response... 416 Requested Range Not Satisfiable\r\n\r\n    The file is already fully retrieved; nothing to do.\r\n\r\nRemoving 'systemd-boot' work area. This may take a while.\r\nsystemd-boot_26-May-2018/\r\nsystemd-boot_26-May-2018/uefi_root/\r\nsystemd-boot_26-May-2018/uefi_root/EFI/\r\nsystemd-boot_26-May-2018/uefi_root/EFI/BOOT/\r\nsystemd-boot_26-May-2018/uefi_root/EFI/BOOT/BOOTIA32.EFI\r\nsystemd-boot_26-May-2018/uefi_root/EFI/BOOT/BOOTx64.EFI\r\nsystemd-boot_26-May-2018/uefi_root/loader/\r\nsystemd-boot_26-May-2018/uefi_root/loader/loader.conf\r\nsystemd-boot_26-May-2018/uefi_root/loader/entries/\r\nsystemd-boot_26-May-2018/uefi_root/loader/entries/mll-x86.conf\r\nsystemd-boot_26-May-2018/uefi_root/loader/entries/mll-x86_64.conf\r\n*** GET SYSTEMD-BOOT END ***\r\nExecuting script '13_prepare_iso.sh'.\r\n*** PREPARE ISO BEGIN ***\r\nFirmware type is 'uefi'.\r\nRemoving old ISO image work area. This may take a while.\r\nPreparing new ISO image work area.\r\nCreating UEFI boot image file '/home/raf/minimal-master/src/work/uefi.img'.\r\nAttaching hard disk image file to loop device.\r\nlosetup: /home/raf/minimal-master/src/work/uefi.img: Warning: file does not fit into a 512-byte sector; the end of the file will be ignored.\r\nFormatting hard disk image with FAT filesystem.\r\nmkfs.fat 4.1 (2017-01-24)\r\nPreparing 'uefi' work area.\r\nPreparing kernel and rootfs.\r\nPreparing 'systemd-boot' UEFI boot loader.\r\nPreparing 'systemd-boot' configuration.\r\nSetting the default UEFI boot entry.\r\nUnmounting UEFI boot image file.\r\nThe ISO image will have overlay structure.\r\n*** PREPARE ISO END ***\r\nExecuting script '14_generate_iso.sh'.\r\n*** GENERATE ISO BEGIN ***\r\nFirmware type is 'uefi'.\r\nxorriso 1.4.8 : RockRidge filesystem manipulator, libburnia project.\r\n\r\nDrive current: -outdev 'stdio:/home/raf/minimal-master/src/minimal_linux_live.iso'\r\nMedia current: stdio file, overwriteable\r\nMedia status : is blank\r\nMedia summary: 0 sessions, 0 data blocks, 0 data, 45.7g free\r\nAdded to ISO image: directory '/'='/home/raf/minimal-master/src/work/isoimage'\r\nxorriso : UPDATE : 321 files added in 1 seconds\r\nxorriso : FAILURE : Given path does not exist on disk: -boot_image system_area='/home/raf/minimal-master/src/work/syslinux/syslinux-*/bios/mbr/isohdpfx.bin'\r\nxorriso : UPDATE : 321 files added in 1 seconds\r\nxorriso : aborting : -abort_on 'FAILURE' encountered 'FAILURE'\r\n```\r\n\r\nApparently there are still references of `syslinux` in the `uefi` build."}}
{"actor":{"display_login":"ohmtech-rdi"}}