{"action":"created","issue":{"url":"https://api.github.com/repos/mhvk/baseband/issues/210","repository_url":"https://api.github.com/repos/mhvk/baseband","labels_url":"https://api.github.com/repos/mhvk/baseband/issues/210/labels{/name}","comments_url":"https://api.github.com/repos/mhvk/baseband/issues/210/comments","events_url":"https://api.github.com/repos/mhvk/baseband/issues/210/events","html_url":"https://github.com/mhvk/baseband/issues/210","id":313384244,"node_id":"MDU6SXNzdWUzMTMzODQyNDQ=","number":210,"title":"Inconsistent use of rounding?","user":{"login":"cczhu","id":442891,"node_id":"MDQ6VXNlcjQ0Mjg5MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/442891?v=4","gravatar_id":"","url":"https://api.github.com/users/cczhu","html_url":"https://github.com/cczhu","followers_url":"https://api.github.com/users/cczhu/followers","following_url":"https://api.github.com/users/cczhu/following{/other_user}","gists_url":"https://api.github.com/users/cczhu/gists{/gist_id}","starred_url":"https://api.github.com/users/cczhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cczhu/subscriptions","organizations_url":"https://api.github.com/users/cczhu/orgs","repos_url":"https://api.github.com/users/cczhu/repos","events_url":"https://api.github.com/users/cczhu/events{/privacy}","received_events_url":"https://api.github.com/users/cczhu/received_events","type":"User","site_admin":false},"labels":[{"id":273065470,"node_id":"MDU6TGFiZWwyNzMwNjU0NzA=","url":"https://api.github.com/repos/mhvk/baseband/labels/bug","name":"bug","color":"eb6420","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-04-11T15:50:38Z","updated_at":"2018-07-26T18:17:07Z","closed_at":"2018-07-26T18:17:07Z","author_association":"COLLABORATOR","body":"For certain routines, `np.round()` (or `<myarray>.round()`) is used to round values, while for others Python's built-in `round` is used.  For Python 2, Numpy rounds to the nearest even integer, while the built-in round always rounds 0.5 down to 0.  For Python 3, they both use convergent rounding.\r\n\r\nHappily there aren't too many situations where we round exactly 0.5, but it would be reasonable to standardize everything to `np.round`, even if that routine is slightly slower than built-in."},"comment":{"url":"https://api.github.com/repos/mhvk/baseband/issues/comments/408188115","html_url":"https://github.com/mhvk/baseband/issues/210#issuecomment-408188115","issue_url":"https://api.github.com/repos/mhvk/baseband/issues/210","id":408188115,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODE4ODExNQ==","user":{"login":"mhvk","id":2789820,"node_id":"MDQ6VXNlcjI3ODk4MjA=","avatar_url":"https://avatars0.githubusercontent.com/u/2789820?v=4","gravatar_id":"","url":"https://api.github.com/users/mhvk","html_url":"https://github.com/mhvk","followers_url":"https://api.github.com/users/mhvk/followers","following_url":"https://api.github.com/users/mhvk/following{/other_user}","gists_url":"https://api.github.com/users/mhvk/gists{/gist_id}","starred_url":"https://api.github.com/users/mhvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhvk/subscriptions","organizations_url":"https://api.github.com/users/mhvk/orgs","repos_url":"https://api.github.com/users/mhvk/repos","events_url":"https://api.github.com/users/mhvk/events{/privacy}","received_events_url":"https://api.github.com/users/mhvk/received_events","type":"User","site_admin":false},"created_at":"2018-07-26T18:17:07Z","updated_at":"2018-07-26T18:17:07Z","author_association":"OWNER","body":"closing since worry about inconsistent rounding seems theoretical."}}
{"actor":{"display_login":"mhvk"}}