{"action":"created","comment":{"url":"https://api.github.com/repos/StackVista/stackstate-agent/pulls/comments/230349273","pull_request_review_id":171069866,"id":230349273,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDM0OTI3Mw==","diff_hunk":"@@ -94,9 +94,9 @@\n   end\n   parameters({\n     'InstallDir' => install_dir,\n-    'InstallFiles' => \"#{Omnibus::Config.source_dir()}/datadog-agent/dd-agent/packaging/datadog-agent/win32/install_files\",\n-    'BinFiles' => \"#{Omnibus::Config.source_dir()}/datadog-agent/src/github.com/StackVista/stackstate-agent/bin/agent\",\n-    'EtcFiles' => \"#{Omnibus::Config.source_dir()}\\\\etc\\\\datadog-agent\",\n+    'InstallFiles' => \"#{Omnibus::Config.source_dir()}/stackstate-agent/sts-agent/packaging/stackstate-agent/win32/install_files\",","path":"omnibus/config/projects/agent.rb","position":79,"original_position":79,"commit_id":"7dfe8e95a554abb2ab28781adb2d64edbec1c895","original_commit_id":"7dfe8e95a554abb2ab28781adb2d64edbec1c895","user":{"login":"craffit","id":10679,"node_id":"MDQ6VXNlcjEwNjc5","avatar_url":"https://avatars2.githubusercontent.com/u/10679?v=4","gravatar_id":"","url":"https://api.github.com/users/craffit","html_url":"https://github.com/craffit","followers_url":"https://api.github.com/users/craffit/followers","following_url":"https://api.github.com/users/craffit/following{/other_user}","gists_url":"https://api.github.com/users/craffit/gists{/gist_id}","starred_url":"https://api.github.com/users/craffit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craffit/subscriptions","organizations_url":"https://api.github.com/users/craffit/orgs","repos_url":"https://api.github.com/users/craffit/repos","events_url":"https://api.github.com/users/craffit/events{/privacy}","received_events_url":"https://api.github.com/users/craffit/received_events","type":"User","site_admin":false},"body":"we can, but that brings ltittle value, because this will not end up in the agent. I would suggest rounding off the windows renaming when we actually go for windows packaging","created_at":"2018-11-02T11:54:46Z","updated_at":"2018-11-02T11:54:46Z","html_url":"https://github.com/StackVista/stackstate-agent/pull/24#discussion_r230349273","pull_request_url":"https://api.github.com/repos/StackVista/stackstate-agent/pulls/24","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/StackVista/stackstate-agent/pulls/comments/230349273"},"html":{"href":"https://github.com/StackVista/stackstate-agent/pull/24#discussion_r230349273"},"pull_request":{"href":"https://api.github.com/repos/StackVista/stackstate-agent/pulls/24"}},"in_reply_to_id":230342058},"pull_request":{"url":"https://api.github.com/repos/StackVista/stackstate-agent/pulls/24","id":227202033,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MjAyMDMz","html_url":"https://github.com/StackVista/stackstate-agent/pull/24","diff_url":"https://github.com/StackVista/stackstate-agent/pull/24.diff","patch_url":"https://github.com/StackVista/stackstate-agent/pull/24.patch","issue_url":"https://api.github.com/repos/StackVista/stackstate-agent/issues/24","number":24,"state":"open","locked":false,"title":"Agent constants refactoring","user":{"login":"craffit","id":10679,"node_id":"MDQ6VXNlcjEwNjc5","avatar_url":"https://avatars2.githubusercontent.com/u/10679?v=4","gravatar_id":"","url":"https://api.github.com/users/craffit","html_url":"https://github.com/craffit","followers_url":"https://api.github.com/users/craffit/followers","following_url":"https://api.github.com/users/craffit/following{/other_user}","gists_url":"https://api.github.com/users/craffit/gists{/gist_id}","starred_url":"https://api.github.com/users/craffit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craffit/subscriptions","organizations_url":"https://api.github.com/users/craffit/orgs","repos_url":"https://api.github.com/users/craffit/repos","events_url":"https://api.github.com/users/craffit/events{/privacy}","received_events_url":"https://api.github.com/users/craffit/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\n\r\n- Do renaming of configs, files and directories\r\n\r\n### Motivation\r\n\r\nWhat inspired you to submit this pull request?\r\n\r\n### Additional Notes\r\n\r\nAnything else we should know when reviewing?\r\n","created_at":"2018-10-31T08:48:45Z","updated_at":"2018-11-02T11:54:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a99e23f0169356a1b75105ec74d3cf0ae59ba986","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/StackVista/stackstate-agent/pulls/24/commits","review_comments_url":"https://api.github.com/repos/StackVista/stackstate-agent/pulls/24/comments","review_comment_url":"https://api.github.com/repos/StackVista/stackstate-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/StackVista/stackstate-agent/issues/24/comments","statuses_url":"https://api.github.com/repos/StackVista/stackstate-agent/statuses/7dfe8e95a554abb2ab28781adb2d64edbec1c895","head":{"label":"StackVista:agent-constants-refactoring","ref":"agent-constants-refactoring","sha":"7dfe8e95a554abb2ab28781adb2d64edbec1c895","user":{"login":"StackVista","id":10511829,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTExODI5","avatar_url":"https://avatars3.githubusercontent.com/u/10511829?v=4","gravatar_id":"","url":"https://api.github.com/users/StackVista","html_url":"https://github.com/StackVista","followers_url":"https://api.github.com/users/StackVista/followers","following_url":"https://api.github.com/users/StackVista/following{/other_user}","gists_url":"https://api.github.com/users/StackVista/gists{/gist_id}","starred_url":"https://api.github.com/users/StackVista/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StackVista/subscriptions","organizations_url":"https://api.github.com/users/StackVista/orgs","repos_url":"https://api.github.com/users/StackVista/repos","events_url":"https://api.github.com/users/StackVista/events{/privacy}","received_events_url":"https://api.github.com/users/StackVista/received_events","type":"Organization","site_admin":false},"repo":{"id":142173690,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIxNzM2OTA=","name":"stackstate-agent","full_name":"StackVista/stackstate-agent","private":false,"owner":{"login":"StackVista","id":10511829,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTExODI5","avatar_url":"https://avatars3.githubusercontent.com/u/10511829?v=4","gravatar_id":"","url":"https://api.github.com/users/StackVista","html_url":"https://github.com/StackVista","followers_url":"https://api.github.com/users/StackVista/followers","following_url":"https://api.github.com/users/StackVista/following{/other_user}","gists_url":"https://api.github.com/users/StackVista/gists{/gist_id}","starred_url":"https://api.github.com/users/StackVista/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StackVista/subscriptions","organizations_url":"https://api.github.com/users/StackVista/orgs","repos_url":"https://api.github.com/users/StackVista/repos","events_url":"https://api.github.com/users/StackVista/events{/privacy}","received_events_url":"https://api.github.com/users/StackVista/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/StackVista/stackstate-agent","description":"The StackState agent gathers telemetry and topology for StackState. ","fork":true,"url":"https://api.github.com/repos/StackVista/stackstate-agent","forks_url":"https://api.github.com/repos/StackVista/stackstate-agent/forks","keys_url":"https://api.github.com/repos/StackVista/stackstate-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StackVista/stackstate-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StackVista/stackstate-agent/teams","hooks_url":"https://api.github.com/repos/StackVista/stackstate-agent/hooks","issue_events_url":"https://api.github.com/repos/StackVista/stackstate-agent/issues/events{/number}","events_url":"https://api.github.com/repos/StackVista/stackstate-agent/events","assignees_url":"https://api.github.com/repos/StackVista/stackstate-agent/assignees{/user}","branches_url":"https://api.github.com/repos/StackVista/stackstate-agent/branches{/branch}","tags_url":"https://api.github.com/repos/StackVista/stackstate-agent/tags","blobs_url":"https://api.github.com/repos/StackVista/stackstate-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StackVista/stackstate-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StackVista/stackstate-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/StackVista/stackstate-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StackVista/stackstate-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/StackVista/stackstate-agent/languages","stargazers_url":"https://api.github.com/repos/StackVista/stackstate-agent/stargazers","contributors_url":"https://api.github.com/repos/StackVista/stackstate-agent/contributors","subscribers_url":"https://api.github.com/repos/StackVista/stackstate-agent/subscribers","subscription_url":"https://api.github.com/repos/StackVista/stackstate-agent/subscription","commits_url":"https://api.github.com/repos/StackVista/stackstate-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/StackVista/stackstate-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/StackVista/stackstate-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/StackVista/stackstate-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/StackVista/stackstate-agent/contents/{+path}","compare_url":"https://api.github.com/repos/StackVista/stackstate-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StackVista/stackstate-agent/merges","archive_url":"https://api.github.com/repos/StackVista/stackstate-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StackVista/stackstate-agent/downloads","issues_url":"https://api.github.com/repos/StackVista/stackstate-agent/issues{/number}","pulls_url":"https://api.github.com/repos/StackVista/stackstate-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/StackVista/stackstate-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/StackVista/stackstate-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StackVista/stackstate-agent/labels{/name}","releases_url":"https://api.github.com/repos/StackVista/stackstate-agent/releases{/id}","deployments_url":"https://api.github.com/repos/StackVista/stackstate-agent/deployments","created_at":"2018-07-24T14:54:50Z","updated_at":"2018-10-31T15:40:49Z","pushed_at":"2018-11-01T14:20:12Z","git_url":"git://github.com/StackVista/stackstate-agent.git","ssh_url":"git@github.com:StackVista/stackstate-agent.git","clone_url":"https://github.com/StackVista/stackstate-agent.git","svn_url":"https://github.com/StackVista/stackstate-agent","homepage":"http://docs.stackstate.com/","size":28061,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"StackVista:master","ref":"master","sha":"32b965faa9a6c99843b2ef93509e9ea812533296","user":{"login":"StackVista","id":10511829,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTExODI5","avatar_url":"https://avatars3.githubusercontent.com/u/10511829?v=4","gravatar_id":"","url":"https://api.github.com/users/StackVista","html_url":"https://github.com/StackVista","followers_url":"https://api.github.com/users/StackVista/followers","following_url":"https://api.github.com/users/StackVista/following{/other_user}","gists_url":"https://api.github.com/users/StackVista/gists{/gist_id}","starred_url":"https://api.github.com/users/StackVista/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StackVista/subscriptions","organizations_url":"https://api.github.com/users/StackVista/orgs","repos_url":"https://api.github.com/users/StackVista/repos","events_url":"https://api.github.com/users/StackVista/events{/privacy}","received_events_url":"https://api.github.com/users/StackVista/received_events","type":"Organization","site_admin":false},"repo":{"id":142173690,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIxNzM2OTA=","name":"stackstate-agent","full_name":"StackVista/stackstate-agent","private":false,"owner":{"login":"StackVista","id":10511829,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTExODI5","avatar_url":"https://avatars3.githubusercontent.com/u/10511829?v=4","gravatar_id":"","url":"https://api.github.com/users/StackVista","html_url":"https://github.com/StackVista","followers_url":"https://api.github.com/users/StackVista/followers","following_url":"https://api.github.com/users/StackVista/following{/other_user}","gists_url":"https://api.github.com/users/StackVista/gists{/gist_id}","starred_url":"https://api.github.com/users/StackVista/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StackVista/subscriptions","organizations_url":"https://api.github.com/users/StackVista/orgs","repos_url":"https://api.github.com/users/StackVista/repos","events_url":"https://api.github.com/users/StackVista/events{/privacy}","received_events_url":"https://api.github.com/users/StackVista/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/StackVista/stackstate-agent","description":"The StackState agent gathers telemetry and topology for StackState. ","fork":true,"url":"https://api.github.com/repos/StackVista/stackstate-agent","forks_url":"https://api.github.com/repos/StackVista/stackstate-agent/forks","keys_url":"https://api.github.com/repos/StackVista/stackstate-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StackVista/stackstate-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StackVista/stackstate-agent/teams","hooks_url":"https://api.github.com/repos/StackVista/stackstate-agent/hooks","issue_events_url":"https://api.github.com/repos/StackVista/stackstate-agent/issues/events{/number}","events_url":"https://api.github.com/repos/StackVista/stackstate-agent/events","assignees_url":"https://api.github.com/repos/StackVista/stackstate-agent/assignees{/user}","branches_url":"https://api.github.com/repos/StackVista/stackstate-agent/branches{/branch}","tags_url":"https://api.github.com/repos/StackVista/stackstate-agent/tags","blobs_url":"https://api.github.com/repos/StackVista/stackstate-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StackVista/stackstate-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StackVista/stackstate-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/StackVista/stackstate-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StackVista/stackstate-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/StackVista/stackstate-agent/languages","stargazers_url":"https://api.github.com/repos/StackVista/stackstate-agent/stargazers","contributors_url":"https://api.github.com/repos/StackVista/stackstate-agent/contributors","subscribers_url":"https://api.github.com/repos/StackVista/stackstate-agent/subscribers","subscription_url":"https://api.github.com/repos/StackVista/stackstate-agent/subscription","commits_url":"https://api.github.com/repos/StackVista/stackstate-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/StackVista/stackstate-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/StackVista/stackstate-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/StackVista/stackstate-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/StackVista/stackstate-agent/contents/{+path}","compare_url":"https://api.github.com/repos/StackVista/stackstate-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StackVista/stackstate-agent/merges","archive_url":"https://api.github.com/repos/StackVista/stackstate-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StackVista/stackstate-agent/downloads","issues_url":"https://api.github.com/repos/StackVista/stackstate-agent/issues{/number}","pulls_url":"https://api.github.com/repos/StackVista/stackstate-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/StackVista/stackstate-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/StackVista/stackstate-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StackVista/stackstate-agent/labels{/name}","releases_url":"https://api.github.com/repos/StackVista/stackstate-agent/releases{/id}","deployments_url":"https://api.github.com/repos/StackVista/stackstate-agent/deployments","created_at":"2018-07-24T14:54:50Z","updated_at":"2018-10-31T15:40:49Z","pushed_at":"2018-11-01T14:20:12Z","git_url":"git://github.com/StackVista/stackstate-agent.git","ssh_url":"git@github.com:StackVista/stackstate-agent.git","clone_url":"https://github.com/StackVista/stackstate-agent.git","svn_url":"https://github.com/StackVista/stackstate-agent","homepage":"http://docs.stackstate.com/","size":28061,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/StackVista/stackstate-agent/pulls/24"},"html":{"href":"https://github.com/StackVista/stackstate-agent/pull/24"},"issue":{"href":"https://api.github.com/repos/StackVista/stackstate-agent/issues/24"},"comments":{"href":"https://api.github.com/repos/StackVista/stackstate-agent/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/StackVista/stackstate-agent/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/StackVista/stackstate-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/StackVista/stackstate-agent/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/StackVista/stackstate-agent/statuses/7dfe8e95a554abb2ab28781adb2d64edbec1c895"}},"author_association":"NONE"}}
{"actor":{"display_login":"craffit"}}