{"action":"created","comment":{"url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/pulls/comments/226236553","pull_request_review_id":166006587,"id":226236553,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjIzNjU1Mw==","diff_hunk":"@@ -1616,40 +1614,49 @@ For success responses, the following fields are defined:\n }\n ```\n \n-## Orphans\n+## Orphan Mitigation\n \n The Platform is the source of truth for Service Instances and Service Bindings.\n Service Brokers are expected to have successfully provisioned all of the Service\n Instances and Service Bindings that the Platform knows about, and none that it\n doesn't.\n \n-Orphans can result if the Service Broker does not return a response before a\n-request from the Platform times out (typically 60 seconds). For example, if a\n-Service Broker does not return a response to a provision request before the\n-request times out, the Service Broker might eventually succeed in provisioning\n-a Service Instance after the Platform considers the request a failure. This\n-results in an orphan Service Instance on the Service Broker's side.\n+Orphaned Service Instances and Service Bindings  MAY be created by in any of the\n+following scenarios:\n+* The Service Broker does not return a response before a request from the\n+Platform times out (typically 60 seconds). The Service Broker might eventually\n+succeed in creating a resource, however the Platform MAY have already considered\n+the request a failure.\n+* A synchronous [Provisioning](#provisioning) request fails.\n+* A call to the\n+[Polling Last Operation for Service Instances](#polling-last-operation-for-service-instances)\n+endpoint returns `\"state\": \"failed\"` for an asynchronous provisioning request\n+* A synchronous [Binding](#binding]) request fails\n+* A call to the\n+[Polling Last Operation for Service Bindings](#polling-last-operation-for-service-bindings)\n+endpoint returns `\"state\": \"failed\"` for an asynchronous binding request\n+* The Platform encounters an internal error creating a Service Instance or\n+Service Binding (for example, saving to the database fails).\n \n-To mitigate orphan Service Instances and Service Bindings, the Platform SHOULD\n+To mitigate orphaned Service Instances and Service Bindings, the Platform SHOULD\n attempt to delete resources it cannot be sure were successfully created, and\n SHOULD keep trying to delete them until the Service Broker responds with a\n-success.\n+success. Service Brokers MAY automatically delete any resources they believe to\n+be orphaned on their own. Note that the Platform MAY allow end users to\n+determine when orphan mitigation occurs, in order to allow end users to","path":"spec.md","position":141,"original_position":141,"commit_id":"78ba1c6d99938bf2618814a5696f5cfd6b00cb91","original_commit_id":"78ba1c6d99938bf2618814a5696f5cfd6b00cb91","user":{"login":"mattmcneeney","id":7263436,"node_id":"MDQ6VXNlcjcyNjM0MzY=","avatar_url":"https://avatars1.githubusercontent.com/u/7263436?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmcneeney","html_url":"https://github.com/mattmcneeney","followers_url":"https://api.github.com/users/mattmcneeney/followers","following_url":"https://api.github.com/users/mattmcneeney/following{/other_user}","gists_url":"https://api.github.com/users/mattmcneeney/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmcneeney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmcneeney/subscriptions","organizations_url":"https://api.github.com/users/mattmcneeney/orgs","repos_url":"https://api.github.com/users/mattmcneeney/repos","events_url":"https://api.github.com/users/mattmcneeney/events{/privacy}","received_events_url":"https://api.github.com/users/mattmcneeney/received_events","type":"User","site_admin":false},"body":"I don't think we want to allow orphan mitigation to be skipped. We just want to allow it to be triggered by a user (so it may not happen immediately).","created_at":"2018-10-18T09:37:39Z","updated_at":"2018-10-18T09:37:39Z","html_url":"https://github.com/openservicebrokerapi/servicebroker/pull/598#discussion_r226236553","pull_request_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/pulls/598","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openservicebrokerapi/servicebroker/pulls/comments/226236553"},"html":{"href":"https://github.com/openservicebrokerapi/servicebroker/pull/598#discussion_r226236553"},"pull_request":{"href":"https://api.github.com/repos/openservicebrokerapi/servicebroker/pulls/598"}},"in_reply_to_id":226192909},"pull_request":{"url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/pulls/598","id":213037241,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMDM3MjQx","html_url":"https://github.com/openservicebrokerapi/servicebroker/pull/598","diff_url":"https://github.com/openservicebrokerapi/servicebroker/pull/598.diff","patch_url":"https://github.com/openservicebrokerapi/servicebroker/pull/598.patch","issue_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/issues/598","number":598,"state":"open","locked":false,"title":"Orphan mitigation could be initiated by end users","user":{"login":"mattmcneeney","id":7263436,"node_id":"MDQ6VXNlcjcyNjM0MzY=","avatar_url":"https://avatars1.githubusercontent.com/u/7263436?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmcneeney","html_url":"https://github.com/mattmcneeney","followers_url":"https://api.github.com/users/mattmcneeney/followers","following_url":"https://api.github.com/users/mattmcneeney/following{/other_user}","gists_url":"https://api.github.com/users/mattmcneeney/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmcneeney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmcneeney/subscriptions","organizations_url":"https://api.github.com/users/mattmcneeney/orgs","repos_url":"https://api.github.com/users/mattmcneeney/repos","events_url":"https://api.github.com/users/mattmcneeney/events{/privacy}","received_events_url":"https://api.github.com/users/mattmcneeney/received_events","type":"User","site_admin":false},"body":"Attempt to fix #573 ","created_at":"2018-09-04T16:36:26Z","updated_at":"2018-10-18T09:37:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f0fe054cdc8430a2c02291dddee5e684974290d5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/pulls/598/commits","review_comments_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/pulls/598/comments","review_comment_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/issues/598/comments","statuses_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/statuses/78ba1c6d99938bf2618814a5696f5cfd6b00cb91","head":{"label":"mattmcneeney:orphan-mitigation-could-be-end-user-controlled","ref":"orphan-mitigation-could-be-end-user-controlled","sha":"78ba1c6d99938bf2618814a5696f5cfd6b00cb91","user":{"login":"mattmcneeney","id":7263436,"node_id":"MDQ6VXNlcjcyNjM0MzY=","avatar_url":"https://avatars1.githubusercontent.com/u/7263436?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmcneeney","html_url":"https://github.com/mattmcneeney","followers_url":"https://api.github.com/users/mattmcneeney/followers","following_url":"https://api.github.com/users/mattmcneeney/following{/other_user}","gists_url":"https://api.github.com/users/mattmcneeney/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmcneeney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmcneeney/subscriptions","organizations_url":"https://api.github.com/users/mattmcneeney/orgs","repos_url":"https://api.github.com/users/mattmcneeney/repos","events_url":"https://api.github.com/users/mattmcneeney/events{/privacy}","received_events_url":"https://api.github.com/users/mattmcneeney/received_events","type":"User","site_admin":false},"repo":{"id":87411156,"node_id":"MDEwOlJlcG9zaXRvcnk4NzQxMTE1Ng==","name":"servicebroker","full_name":"mattmcneeney/servicebroker","private":false,"owner":{"login":"mattmcneeney","id":7263436,"node_id":"MDQ6VXNlcjcyNjM0MzY=","avatar_url":"https://avatars1.githubusercontent.com/u/7263436?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmcneeney","html_url":"https://github.com/mattmcneeney","followers_url":"https://api.github.com/users/mattmcneeney/followers","following_url":"https://api.github.com/users/mattmcneeney/following{/other_user}","gists_url":"https://api.github.com/users/mattmcneeney/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmcneeney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmcneeney/subscriptions","organizations_url":"https://api.github.com/users/mattmcneeney/orgs","repos_url":"https://api.github.com/users/mattmcneeney/repos","events_url":"https://api.github.com/users/mattmcneeney/events{/privacy}","received_events_url":"https://api.github.com/users/mattmcneeney/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mattmcneeney/servicebroker","description":"Open Service Broker API Specification","fork":true,"url":"https://api.github.com/repos/mattmcneeney/servicebroker","forks_url":"https://api.github.com/repos/mattmcneeney/servicebroker/forks","keys_url":"https://api.github.com/repos/mattmcneeney/servicebroker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattmcneeney/servicebroker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattmcneeney/servicebroker/teams","hooks_url":"https://api.github.com/repos/mattmcneeney/servicebroker/hooks","issue_events_url":"https://api.github.com/repos/mattmcneeney/servicebroker/issues/events{/number}","events_url":"https://api.github.com/repos/mattmcneeney/servicebroker/events","assignees_url":"https://api.github.com/repos/mattmcneeney/servicebroker/assignees{/user}","branches_url":"https://api.github.com/repos/mattmcneeney/servicebroker/branches{/branch}","tags_url":"https://api.github.com/repos/mattmcneeney/servicebroker/tags","blobs_url":"https://api.github.com/repos/mattmcneeney/servicebroker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattmcneeney/servicebroker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattmcneeney/servicebroker/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattmcneeney/servicebroker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattmcneeney/servicebroker/statuses/{sha}","languages_url":"https://api.github.com/repos/mattmcneeney/servicebroker/languages","stargazers_url":"https://api.github.com/repos/mattmcneeney/servicebroker/stargazers","contributors_url":"https://api.github.com/repos/mattmcneeney/servicebroker/contributors","subscribers_url":"https://api.github.com/repos/mattmcneeney/servicebroker/subscribers","subscription_url":"https://api.github.com/repos/mattmcneeney/servicebroker/subscription","commits_url":"https://api.github.com/repos/mattmcneeney/servicebroker/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattmcneeney/servicebroker/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattmcneeney/servicebroker/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattmcneeney/servicebroker/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattmcneeney/servicebroker/contents/{+path}","compare_url":"https://api.github.com/repos/mattmcneeney/servicebroker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattmcneeney/servicebroker/merges","archive_url":"https://api.github.com/repos/mattmcneeney/servicebroker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattmcneeney/servicebroker/downloads","issues_url":"https://api.github.com/repos/mattmcneeney/servicebroker/issues{/number}","pulls_url":"https://api.github.com/repos/mattmcneeney/servicebroker/pulls{/number}","milestones_url":"https://api.github.com/repos/mattmcneeney/servicebroker/milestones{/number}","notifications_url":"https://api.github.com/repos/mattmcneeney/servicebroker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattmcneeney/servicebroker/labels{/name}","releases_url":"https://api.github.com/repos/mattmcneeney/servicebroker/releases{/id}","deployments_url":"https://api.github.com/repos/mattmcneeney/servicebroker/deployments","created_at":"2017-04-06T09:25:14Z","updated_at":"2018-07-12T21:10:15Z","pushed_at":"2018-10-17T11:21:15Z","git_url":"git://github.com/mattmcneeney/servicebroker.git","ssh_url":"git@github.com:mattmcneeney/servicebroker.git","clone_url":"https://github.com/mattmcneeney/servicebroker.git","svn_url":"https://github.com/mattmcneeney/servicebroker","homepage":"","size":7426,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openservicebrokerapi:master","ref":"master","sha":"18cdf15700ac488c4fc587620e8d23034e672d6a","user":{"login":"openservicebrokerapi","id":19862012,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5ODYyMDEy","avatar_url":"https://avatars0.githubusercontent.com/u/19862012?v=4","gravatar_id":"","url":"https://api.github.com/users/openservicebrokerapi","html_url":"https://github.com/openservicebrokerapi","followers_url":"https://api.github.com/users/openservicebrokerapi/followers","following_url":"https://api.github.com/users/openservicebrokerapi/following{/other_user}","gists_url":"https://api.github.com/users/openservicebrokerapi/gists{/gist_id}","starred_url":"https://api.github.com/users/openservicebrokerapi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openservicebrokerapi/subscriptions","organizations_url":"https://api.github.com/users/openservicebrokerapi/orgs","repos_url":"https://api.github.com/users/openservicebrokerapi/repos","events_url":"https://api.github.com/users/openservicebrokerapi/events{/privacy}","received_events_url":"https://api.github.com/users/openservicebrokerapi/received_events","type":"Organization","site_admin":false},"repo":{"id":62855546,"node_id":"MDEwOlJlcG9zaXRvcnk2Mjg1NTU0Ng==","name":"servicebroker","full_name":"openservicebrokerapi/servicebroker","private":false,"owner":{"login":"openservicebrokerapi","id":19862012,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5ODYyMDEy","avatar_url":"https://avatars0.githubusercontent.com/u/19862012?v=4","gravatar_id":"","url":"https://api.github.com/users/openservicebrokerapi","html_url":"https://github.com/openservicebrokerapi","followers_url":"https://api.github.com/users/openservicebrokerapi/followers","following_url":"https://api.github.com/users/openservicebrokerapi/following{/other_user}","gists_url":"https://api.github.com/users/openservicebrokerapi/gists{/gist_id}","starred_url":"https://api.github.com/users/openservicebrokerapi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openservicebrokerapi/subscriptions","organizations_url":"https://api.github.com/users/openservicebrokerapi/orgs","repos_url":"https://api.github.com/users/openservicebrokerapi/repos","events_url":"https://api.github.com/users/openservicebrokerapi/events{/privacy}","received_events_url":"https://api.github.com/users/openservicebrokerapi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openservicebrokerapi/servicebroker","description":"Open Service Broker API Specification","fork":false,"url":"https://api.github.com/repos/openservicebrokerapi/servicebroker","forks_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/forks","keys_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/teams","hooks_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/hooks","issue_events_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/issues/events{/number}","events_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/events","assignees_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/assignees{/user}","branches_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/branches{/branch}","tags_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/tags","blobs_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/git/refs{/sha}","trees_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/statuses/{sha}","languages_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/languages","stargazers_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/stargazers","contributors_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/contributors","subscribers_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/subscribers","subscription_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/subscription","commits_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/commits{/sha}","git_commits_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/git/commits{/sha}","comments_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/comments{/number}","issue_comment_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/issues/comments{/number}","contents_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/contents/{+path}","compare_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/merges","archive_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/downloads","issues_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/issues{/number}","pulls_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/pulls{/number}","milestones_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/milestones{/number}","notifications_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/labels{/name}","releases_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/releases{/id}","deployments_url":"https://api.github.com/repos/openservicebrokerapi/servicebroker/deployments","created_at":"2016-07-08T03:22:26Z","updated_at":"2018-10-17T13:52:28Z","pushed_at":"2018-10-17T11:21:17Z","git_url":"git://github.com/openservicebrokerapi/servicebroker.git","ssh_url":"git@github.com:openservicebrokerapi/servicebroker.git","clone_url":"https://github.com/openservicebrokerapi/servicebroker.git","svn_url":"https://github.com/openservicebrokerapi/servicebroker","homepage":"https://openservicebrokerapi.org/","size":7433,"stargazers_count":592,"watchers_count":592,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":156,"mirror_url":null,"archived":false,"open_issues_count":102,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":156,"open_issues":102,"watchers":592,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openservicebrokerapi/servicebroker/pulls/598"},"html":{"href":"https://github.com/openservicebrokerapi/servicebroker/pull/598"},"issue":{"href":"https://api.github.com/repos/openservicebrokerapi/servicebroker/issues/598"},"comments":{"href":"https://api.github.com/repos/openservicebrokerapi/servicebroker/issues/598/comments"},"review_comments":{"href":"https://api.github.com/repos/openservicebrokerapi/servicebroker/pulls/598/comments"},"review_comment":{"href":"https://api.github.com/repos/openservicebrokerapi/servicebroker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openservicebrokerapi/servicebroker/pulls/598/commits"},"statuses":{"href":"https://api.github.com/repos/openservicebrokerapi/servicebroker/statuses/78ba1c6d99938bf2618814a5696f5cfd6b00cb91"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mattmcneeney"}}