{"action":"closed","number":90,"pull_request":{"url":"https://api.github.com/repos/leanprover/vscode-lean/pulls/90","id":215797305,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1Nzk3MzA1","html_url":"https://github.com/leanprover/vscode-lean/pull/90","diff_url":"https://github.com/leanprover/vscode-lean/pull/90.diff","patch_url":"https://github.com/leanprover/vscode-lean/pull/90.patch","issue_url":"https://api.github.com/repos/leanprover/vscode-lean/issues/90","number":90,"state":"closed","locked":false,"title":"[WIP] TM scopes for brackets","user":{"login":"bryangingechen","id":5209952,"node_id":"MDQ6VXNlcjUyMDk5NTI=","avatar_url":"https://avatars3.githubusercontent.com/u/5209952?v=4","gravatar_id":"","url":"https://api.github.com/users/bryangingechen","html_url":"https://github.com/bryangingechen","followers_url":"https://api.github.com/users/bryangingechen/followers","following_url":"https://api.github.com/users/bryangingechen/following{/other_user}","gists_url":"https://api.github.com/users/bryangingechen/gists{/gist_id}","starred_url":"https://api.github.com/users/bryangingechen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryangingechen/subscriptions","organizations_url":"https://api.github.com/users/bryangingechen/orgs","repos_url":"https://api.github.com/users/bryangingechen/repos","events_url":"https://api.github.com/users/bryangingechen/events{/privacy}","received_events_url":"https://api.github.com/users/bryangingechen/received_events","type":"User","site_admin":false},"body":"This branch adds TM scopes for open / close brackets of a few types (round, square, curly, \"white curly\" i.e. `⦃⦄`, angle, and French). This makes it possible to use the [Bracket Pair Colorizer extension v2](https://github.com/CoenraadS/Bracket-Pair-Colorizer-2/blob/develop/LANGUAGE_SUPPORT.md) with lean. V1 (mentioned in this repository's README) currently depends on PrismJS which doesn't support Lean.\r\n\r\nI also combined the two `keyword.other.lean` fields into one.\r\n\r\nThis is WIP because I intend to test this a bit more and I also wanted to get some feedback on e.g. the set of bracket characters included.\r\n\r\nTo use the bracket colorizer v2, I added the following to `\"bracket-pair-colorizer-2.languages\":` in my settings.json:\r\n```\r\n        {\r\n            \"language\": \"lean\",\r\n            \"scopes\": [\r\n                {\r\n                    \"open\": \"meta.brace.round.begin\",\r\n                    \"close\": \"meta.brace.round.end\"\r\n                },\r\n                {\r\n                    \"open\": \"meta.brace.square.begin\",\r\n                    \"close\": \"meta.brace.square.end\"\r\n                },\r\n                {\r\n                    \"open\": \"meta.brace.curly.begin\",\r\n                    \"close\": \"meta.brace.curly.end\"\r\n                },\r\n                {\r\n                    \"open\": \"meta.brace.whitecurly.begin\",\r\n                    \"close\": \"meta.brace.whitecurly.end\"\r\n                },\r\n                {\r\n                    \"open\": \"meta.brace.angle.begin\",\r\n                    \"close\": \"meta.brace.angle.end\"\r\n                },\r\n                {\r\n                    \"open\": \"meta.brace.french.begin\",\r\n                    \"close\": \"meta.brace.french.end\"\r\n                }\r\n            ]\r\n        },\r\n```","created_at":"2018-09-16T01:15:04Z","updated_at":"2018-09-28T15:41:12Z","closed_at":"2018-09-28T15:41:11Z","merged_at":null,"merge_commit_sha":"dfd2d252bdbe8ec8b81c529473bc02cc08c6761c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/leanprover/vscode-lean/pulls/90/commits","review_comments_url":"https://api.github.com/repos/leanprover/vscode-lean/pulls/90/comments","review_comment_url":"https://api.github.com/repos/leanprover/vscode-lean/pulls/comments{/number}","comments_url":"https://api.github.com/repos/leanprover/vscode-lean/issues/90/comments","statuses_url":"https://api.github.com/repos/leanprover/vscode-lean/statuses/009ebf1e251c371bb1d54d5311ba5805bede37e2","head":{"label":"bryangingechen:brackets","ref":"brackets","sha":"009ebf1e251c371bb1d54d5311ba5805bede37e2","user":{"login":"bryangingechen","id":5209952,"node_id":"MDQ6VXNlcjUyMDk5NTI=","avatar_url":"https://avatars3.githubusercontent.com/u/5209952?v=4","gravatar_id":"","url":"https://api.github.com/users/bryangingechen","html_url":"https://github.com/bryangingechen","followers_url":"https://api.github.com/users/bryangingechen/followers","following_url":"https://api.github.com/users/bryangingechen/following{/other_user}","gists_url":"https://api.github.com/users/bryangingechen/gists{/gist_id}","starred_url":"https://api.github.com/users/bryangingechen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryangingechen/subscriptions","organizations_url":"https://api.github.com/users/bryangingechen/orgs","repos_url":"https://api.github.com/users/bryangingechen/repos","events_url":"https://api.github.com/users/bryangingechen/events{/privacy}","received_events_url":"https://api.github.com/users/bryangingechen/received_events","type":"User","site_admin":false},"repo":{"id":147352207,"node_id":"MDEwOlJlcG9zaXRvcnkxNDczNTIyMDc=","name":"vscode-lean","full_name":"bryangingechen/vscode-lean","private":false,"owner":{"login":"bryangingechen","id":5209952,"node_id":"MDQ6VXNlcjUyMDk5NTI=","avatar_url":"https://avatars3.githubusercontent.com/u/5209952?v=4","gravatar_id":"","url":"https://api.github.com/users/bryangingechen","html_url":"https://github.com/bryangingechen","followers_url":"https://api.github.com/users/bryangingechen/followers","following_url":"https://api.github.com/users/bryangingechen/following{/other_user}","gists_url":"https://api.github.com/users/bryangingechen/gists{/gist_id}","starred_url":"https://api.github.com/users/bryangingechen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryangingechen/subscriptions","organizations_url":"https://api.github.com/users/bryangingechen/orgs","repos_url":"https://api.github.com/users/bryangingechen/repos","events_url":"https://api.github.com/users/bryangingechen/events{/privacy}","received_events_url":"https://api.github.com/users/bryangingechen/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bryangingechen/vscode-lean","description":"An extension for VS Code which provides support for the Lean language.","fork":true,"url":"https://api.github.com/repos/bryangingechen/vscode-lean","forks_url":"https://api.github.com/repos/bryangingechen/vscode-lean/forks","keys_url":"https://api.github.com/repos/bryangingechen/vscode-lean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bryangingechen/vscode-lean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bryangingechen/vscode-lean/teams","hooks_url":"https://api.github.com/repos/bryangingechen/vscode-lean/hooks","issue_events_url":"https://api.github.com/repos/bryangingechen/vscode-lean/issues/events{/number}","events_url":"https://api.github.com/repos/bryangingechen/vscode-lean/events","assignees_url":"https://api.github.com/repos/bryangingechen/vscode-lean/assignees{/user}","branches_url":"https://api.github.com/repos/bryangingechen/vscode-lean/branches{/branch}","tags_url":"https://api.github.com/repos/bryangingechen/vscode-lean/tags","blobs_url":"https://api.github.com/repos/bryangingechen/vscode-lean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bryangingechen/vscode-lean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bryangingechen/vscode-lean/git/refs{/sha}","trees_url":"https://api.github.com/repos/bryangingechen/vscode-lean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bryangingechen/vscode-lean/statuses/{sha}","languages_url":"https://api.github.com/repos/bryangingechen/vscode-lean/languages","stargazers_url":"https://api.github.com/repos/bryangingechen/vscode-lean/stargazers","contributors_url":"https://api.github.com/repos/bryangingechen/vscode-lean/contributors","subscribers_url":"https://api.github.com/repos/bryangingechen/vscode-lean/subscribers","subscription_url":"https://api.github.com/repos/bryangingechen/vscode-lean/subscription","commits_url":"https://api.github.com/repos/bryangingechen/vscode-lean/commits{/sha}","git_commits_url":"https://api.github.com/repos/bryangingechen/vscode-lean/git/commits{/sha}","comments_url":"https://api.github.com/repos/bryangingechen/vscode-lean/comments{/number}","issue_comment_url":"https://api.github.com/repos/bryangingechen/vscode-lean/issues/comments{/number}","contents_url":"https://api.github.com/repos/bryangingechen/vscode-lean/contents/{+path}","compare_url":"https://api.github.com/repos/bryangingechen/vscode-lean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bryangingechen/vscode-lean/merges","archive_url":"https://api.github.com/repos/bryangingechen/vscode-lean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bryangingechen/vscode-lean/downloads","issues_url":"https://api.github.com/repos/bryangingechen/vscode-lean/issues{/number}","pulls_url":"https://api.github.com/repos/bryangingechen/vscode-lean/pulls{/number}","milestones_url":"https://api.github.com/repos/bryangingechen/vscode-lean/milestones{/number}","notifications_url":"https://api.github.com/repos/bryangingechen/vscode-lean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bryangingechen/vscode-lean/labels{/name}","releases_url":"https://api.github.com/repos/bryangingechen/vscode-lean/releases{/id}","deployments_url":"https://api.github.com/repos/bryangingechen/vscode-lean/deployments","created_at":"2018-09-04T13:39:39Z","updated_at":"2018-09-12T14:12:56Z","pushed_at":"2018-09-22T21:55:48Z","git_url":"git://github.com/bryangingechen/vscode-lean.git","ssh_url":"git@github.com:bryangingechen/vscode-lean.git","clone_url":"https://github.com/bryangingechen/vscode-lean.git","svn_url":"https://github.com/bryangingechen/vscode-lean","homepage":null,"size":336,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"leanprover:master","ref":"master","sha":"7660322198a527e97ff5cc5900815b0fe460e628","user":{"login":"leanprover","id":7233018,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyMzMwMTg=","avatar_url":"https://avatars3.githubusercontent.com/u/7233018?v=4","gravatar_id":"","url":"https://api.github.com/users/leanprover","html_url":"https://github.com/leanprover","followers_url":"https://api.github.com/users/leanprover/followers","following_url":"https://api.github.com/users/leanprover/following{/other_user}","gists_url":"https://api.github.com/users/leanprover/gists{/gist_id}","starred_url":"https://api.github.com/users/leanprover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leanprover/subscriptions","organizations_url":"https://api.github.com/users/leanprover/orgs","repos_url":"https://api.github.com/users/leanprover/repos","events_url":"https://api.github.com/users/leanprover/events{/privacy}","received_events_url":"https://api.github.com/users/leanprover/received_events","type":"Organization","site_admin":false},"repo":{"id":76894394,"node_id":"MDEwOlJlcG9zaXRvcnk3Njg5NDM5NA==","name":"vscode-lean","full_name":"leanprover/vscode-lean","private":false,"owner":{"login":"leanprover","id":7233018,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyMzMwMTg=","avatar_url":"https://avatars3.githubusercontent.com/u/7233018?v=4","gravatar_id":"","url":"https://api.github.com/users/leanprover","html_url":"https://github.com/leanprover","followers_url":"https://api.github.com/users/leanprover/followers","following_url":"https://api.github.com/users/leanprover/following{/other_user}","gists_url":"https://api.github.com/users/leanprover/gists{/gist_id}","starred_url":"https://api.github.com/users/leanprover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leanprover/subscriptions","organizations_url":"https://api.github.com/users/leanprover/orgs","repos_url":"https://api.github.com/users/leanprover/repos","events_url":"https://api.github.com/users/leanprover/events{/privacy}","received_events_url":"https://api.github.com/users/leanprover/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/leanprover/vscode-lean","description":"An extension for VS Code which provides support for the Lean language.","fork":false,"url":"https://api.github.com/repos/leanprover/vscode-lean","forks_url":"https://api.github.com/repos/leanprover/vscode-lean/forks","keys_url":"https://api.github.com/repos/leanprover/vscode-lean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leanprover/vscode-lean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leanprover/vscode-lean/teams","hooks_url":"https://api.github.com/repos/leanprover/vscode-lean/hooks","issue_events_url":"https://api.github.com/repos/leanprover/vscode-lean/issues/events{/number}","events_url":"https://api.github.com/repos/leanprover/vscode-lean/events","assignees_url":"https://api.github.com/repos/leanprover/vscode-lean/assignees{/user}","branches_url":"https://api.github.com/repos/leanprover/vscode-lean/branches{/branch}","tags_url":"https://api.github.com/repos/leanprover/vscode-lean/tags","blobs_url":"https://api.github.com/repos/leanprover/vscode-lean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leanprover/vscode-lean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leanprover/vscode-lean/git/refs{/sha}","trees_url":"https://api.github.com/repos/leanprover/vscode-lean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leanprover/vscode-lean/statuses/{sha}","languages_url":"https://api.github.com/repos/leanprover/vscode-lean/languages","stargazers_url":"https://api.github.com/repos/leanprover/vscode-lean/stargazers","contributors_url":"https://api.github.com/repos/leanprover/vscode-lean/contributors","subscribers_url":"https://api.github.com/repos/leanprover/vscode-lean/subscribers","subscription_url":"https://api.github.com/repos/leanprover/vscode-lean/subscription","commits_url":"https://api.github.com/repos/leanprover/vscode-lean/commits{/sha}","git_commits_url":"https://api.github.com/repos/leanprover/vscode-lean/git/commits{/sha}","comments_url":"https://api.github.com/repos/leanprover/vscode-lean/comments{/number}","issue_comment_url":"https://api.github.com/repos/leanprover/vscode-lean/issues/comments{/number}","contents_url":"https://api.github.com/repos/leanprover/vscode-lean/contents/{+path}","compare_url":"https://api.github.com/repos/leanprover/vscode-lean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leanprover/vscode-lean/merges","archive_url":"https://api.github.com/repos/leanprover/vscode-lean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leanprover/vscode-lean/downloads","issues_url":"https://api.github.com/repos/leanprover/vscode-lean/issues{/number}","pulls_url":"https://api.github.com/repos/leanprover/vscode-lean/pulls{/number}","milestones_url":"https://api.github.com/repos/leanprover/vscode-lean/milestones{/number}","notifications_url":"https://api.github.com/repos/leanprover/vscode-lean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leanprover/vscode-lean/labels{/name}","releases_url":"https://api.github.com/repos/leanprover/vscode-lean/releases{/id}","deployments_url":"https://api.github.com/repos/leanprover/vscode-lean/deployments","created_at":"2016-12-19T20:21:34Z","updated_at":"2018-09-14T13:36:29Z","pushed_at":"2018-09-26T22:42:19Z","git_url":"git://github.com/leanprover/vscode-lean.git","ssh_url":"git@github.com:leanprover/vscode-lean.git","clone_url":"https://github.com/leanprover/vscode-lean.git","svn_url":"https://github.com/leanprover/vscode-lean","homepage":null,"size":336,"stargazers_count":27,"watchers_count":27,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":15,"license":null,"forks":11,"open_issues":15,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/leanprover/vscode-lean/pulls/90"},"html":{"href":"https://github.com/leanprover/vscode-lean/pull/90"},"issue":{"href":"https://api.github.com/repos/leanprover/vscode-lean/issues/90"},"comments":{"href":"https://api.github.com/repos/leanprover/vscode-lean/issues/90/comments"},"review_comments":{"href":"https://api.github.com/repos/leanprover/vscode-lean/pulls/90/comments"},"review_comment":{"href":"https://api.github.com/repos/leanprover/vscode-lean/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/leanprover/vscode-lean/pulls/90/commits"},"statuses":{"href":"https://api.github.com/repos/leanprover/vscode-lean/statuses/009ebf1e251c371bb1d54d5311ba5805bede37e2"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":151,"deletions":49,"changed_files":1}}
{"actor":{"display_login":"bryangingechen"}}