{"action":"created","comment":{"url":"https://api.github.com/repos/coq/coq/pulls/comments/171202044","pull_request_review_id":100011904,"id":171202044,"diff_hunk":"@@ -352,7 +373,7 @@ and nf_cofix env sigma cf =\n   mkCoFix (init,(name,cft,cfb))\n \n let cbv_vm env sigma c t  =\n-  if Termops.occur_meta_or_existential sigma c then\n+  if Termops.occur_meta sigma c then\n     CErrors.user_err Pp.(str \"vm_compute does not support existential variables.\");","path":"pretyping/vnorm.ml","position":43,"original_position":43,"commit_id":"ffb8e3dd554463dad2fda4a77e6c249db98aaa39","original_commit_id":"ffb8e3dd554463dad2fda4a77e6c249db98aaa39","user":{"login":"herbelin","id":460771,"avatar_url":"https://avatars1.githubusercontent.com/u/460771?v=4","gravatar_id":"","url":"https://api.github.com/users/herbelin","html_url":"https://github.com/herbelin","followers_url":"https://api.github.com/users/herbelin/followers","following_url":"https://api.github.com/users/herbelin/following{/other_user}","gists_url":"https://api.github.com/users/herbelin/gists{/gist_id}","starred_url":"https://api.github.com/users/herbelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/herbelin/subscriptions","organizations_url":"https://api.github.com/users/herbelin/orgs","repos_url":"https://api.github.com/users/herbelin/repos","events_url":"https://api.github.com/users/herbelin/events{/privacy}","received_events_url":"https://api.github.com/users/herbelin/received_events","type":"User","site_admin":false},"body":"...this reminds me that the reference manual would probably be clearer if it could make up its mind between the terminology metavariable vs existential variables (or at least once for all say somewhere that they are essentially synonym).","created_at":"2018-02-28T10:34:35Z","updated_at":"2018-02-28T10:34:35Z","html_url":"https://github.com/coq/coq/pull/935#discussion_r171202044","pull_request_url":"https://api.github.com/repos/coq/coq/pulls/935","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/coq/coq/pulls/comments/171202044"},"html":{"href":"https://github.com/coq/coq/pull/935#discussion_r171202044"},"pull_request":{"href":"https://api.github.com/repos/coq/coq/pulls/935"}},"in_reply_to_id":171197124},"pull_request":{"url":"https://api.github.com/repos/coq/coq/pulls/935","id":133135465,"html_url":"https://github.com/coq/coq/pull/935","diff_url":"https://github.com/coq/coq/pull/935.diff","patch_url":"https://github.com/coq/coq/pull/935.patch","issue_url":"https://api.github.com/repos/coq/coq/issues/935","number":935,"state":"open","locked":false,"title":"Handling evars in the VM","user":{"login":"ppedrot","id":1202327,"avatar_url":"https://avatars1.githubusercontent.com/u/1202327?v=4","gravatar_id":"","url":"https://api.github.com/users/ppedrot","html_url":"https://github.com/ppedrot","followers_url":"https://api.github.com/users/ppedrot/followers","following_url":"https://api.github.com/users/ppedrot/following{/other_user}","gists_url":"https://api.github.com/users/ppedrot/gists{/gist_id}","starred_url":"https://api.github.com/users/ppedrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppedrot/subscriptions","organizations_url":"https://api.github.com/users/ppedrot/orgs","repos_url":"https://api.github.com/users/ppedrot/repos","events_url":"https://api.github.com/users/ppedrot/events{/privacy}","received_events_url":"https://api.github.com/users/ppedrot/received_events","type":"User","site_admin":false},"body":"This is actually pretty straightforward. We simply treat them as as an application of an atom to its instance,\r\nand in the decompilation phase we reconstruct the instance from the arguments.\r\n\r\nThis closes #5659.\r\n\r\nNote that we could probably do the same in native compilation for the sake of uniformity, but this is left to another PR.","created_at":"2017-07-30T17:02:44Z","updated_at":"2018-02-28T10:34:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d88977b446d603bcd96bae2e85f05f571bd05a20","assignee":null,"assignees":[],"requested_reviewers":[{"login":"bgregoir","id":661996,"avatar_url":"https://avatars3.githubusercontent.com/u/661996?v=4","gravatar_id":"","url":"https://api.github.com/users/bgregoir","html_url":"https://github.com/bgregoir","followers_url":"https://api.github.com/users/bgregoir/followers","following_url":"https://api.github.com/users/bgregoir/following{/other_user}","gists_url":"https://api.github.com/users/bgregoir/gists{/gist_id}","starred_url":"https://api.github.com/users/bgregoir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgregoir/subscriptions","organizations_url":"https://api.github.com/users/bgregoir/orgs","repos_url":"https://api.github.com/users/bgregoir/repos","events_url":"https://api.github.com/users/bgregoir/events{/privacy}","received_events_url":"https://api.github.com/users/bgregoir/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":485986179,"url":"https://api.github.com/repos/coq/coq/labels/kind:%20feature","name":"kind: feature","color":"0e8a16","default":false},{"id":572296906,"url":"https://api.github.com/repos/coq/coq/labels/needs:%20discussion","name":"needs: discussion","color":"bfd4f2","default":false},{"id":614883102,"url":"https://api.github.com/repos/coq/coq/labels/needs:%20rebase","name":"needs: rebase","color":"d4c5f9","default":false}],"milestone":{"url":"https://api.github.com/repos/coq/coq/milestones/5","html_url":"https://github.com/coq/coq/milestone/5","labels_url":"https://api.github.com/repos/coq/coq/milestones/5/labels","id":2550427,"number":5,"title":"8.8+beta1","description":"","creator":{"login":"maximedenes","id":647105,"avatar_url":"https://avatars1.githubusercontent.com/u/647105?v=4","gravatar_id":"","url":"https://api.github.com/users/maximedenes","html_url":"https://github.com/maximedenes","followers_url":"https://api.github.com/users/maximedenes/followers","following_url":"https://api.github.com/users/maximedenes/following{/other_user}","gists_url":"https://api.github.com/users/maximedenes/gists{/gist_id}","starred_url":"https://api.github.com/users/maximedenes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximedenes/subscriptions","organizations_url":"https://api.github.com/users/maximedenes/orgs","repos_url":"https://api.github.com/users/maximedenes/repos","events_url":"https://api.github.com/users/maximedenes/events{/privacy}","received_events_url":"https://api.github.com/users/maximedenes/received_events","type":"User","site_admin":false},"open_issues":148,"closed_issues":389,"state":"open","created_at":"2017-05-30T13:02:47Z","updated_at":"2018-02-28T10:08:46Z","due_on":"2018-03-15T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/coq/coq/pulls/935/commits","review_comments_url":"https://api.github.com/repos/coq/coq/pulls/935/comments","review_comment_url":"https://api.github.com/repos/coq/coq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coq/coq/issues/935/comments","statuses_url":"https://api.github.com/repos/coq/coq/statuses/ffb8e3dd554463dad2fda4a77e6c249db98aaa39","head":{"label":"ppedrot:vm-evars","ref":"vm-evars","sha":"ffb8e3dd554463dad2fda4a77e6c249db98aaa39","user":{"login":"ppedrot","id":1202327,"avatar_url":"https://avatars1.githubusercontent.com/u/1202327?v=4","gravatar_id":"","url":"https://api.github.com/users/ppedrot","html_url":"https://github.com/ppedrot","followers_url":"https://api.github.com/users/ppedrot/followers","following_url":"https://api.github.com/users/ppedrot/following{/other_user}","gists_url":"https://api.github.com/users/ppedrot/gists{/gist_id}","starred_url":"https://api.github.com/users/ppedrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppedrot/subscriptions","organizations_url":"https://api.github.com/users/ppedrot/orgs","repos_url":"https://api.github.com/users/ppedrot/repos","events_url":"https://api.github.com/users/ppedrot/events{/privacy}","received_events_url":"https://api.github.com/users/ppedrot/received_events","type":"User","site_admin":false},"repo":{"id":10340342,"name":"coq","full_name":"ppedrot/coq","owner":{"login":"ppedrot","id":1202327,"avatar_url":"https://avatars1.githubusercontent.com/u/1202327?v=4","gravatar_id":"","url":"https://api.github.com/users/ppedrot","html_url":"https://github.com/ppedrot","followers_url":"https://api.github.com/users/ppedrot/followers","following_url":"https://api.github.com/users/ppedrot/following{/other_user}","gists_url":"https://api.github.com/users/ppedrot/gists{/gist_id}","starred_url":"https://api.github.com/users/ppedrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppedrot/subscriptions","organizations_url":"https://api.github.com/users/ppedrot/orgs","repos_url":"https://api.github.com/users/ppedrot/repos","events_url":"https://api.github.com/users/ppedrot/events{/privacy}","received_events_url":"https://api.github.com/users/ppedrot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ppedrot/coq","description":"Coq is a formal proof management system. It provides a formal language to write mathematical definitions, executable algorithms and theorems together with an environment for semi-interactive development of machine-checked proofs. ","fork":true,"url":"https://api.github.com/repos/ppedrot/coq","forks_url":"https://api.github.com/repos/ppedrot/coq/forks","keys_url":"https://api.github.com/repos/ppedrot/coq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ppedrot/coq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ppedrot/coq/teams","hooks_url":"https://api.github.com/repos/ppedrot/coq/hooks","issue_events_url":"https://api.github.com/repos/ppedrot/coq/issues/events{/number}","events_url":"https://api.github.com/repos/ppedrot/coq/events","assignees_url":"https://api.github.com/repos/ppedrot/coq/assignees{/user}","branches_url":"https://api.github.com/repos/ppedrot/coq/branches{/branch}","tags_url":"https://api.github.com/repos/ppedrot/coq/tags","blobs_url":"https://api.github.com/repos/ppedrot/coq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ppedrot/coq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ppedrot/coq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ppedrot/coq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ppedrot/coq/statuses/{sha}","languages_url":"https://api.github.com/repos/ppedrot/coq/languages","stargazers_url":"https://api.github.com/repos/ppedrot/coq/stargazers","contributors_url":"https://api.github.com/repos/ppedrot/coq/contributors","subscribers_url":"https://api.github.com/repos/ppedrot/coq/subscribers","subscription_url":"https://api.github.com/repos/ppedrot/coq/subscription","commits_url":"https://api.github.com/repos/ppedrot/coq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ppedrot/coq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ppedrot/coq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ppedrot/coq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ppedrot/coq/contents/{+path}","compare_url":"https://api.github.com/repos/ppedrot/coq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ppedrot/coq/merges","archive_url":"https://api.github.com/repos/ppedrot/coq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ppedrot/coq/downloads","issues_url":"https://api.github.com/repos/ppedrot/coq/issues{/number}","pulls_url":"https://api.github.com/repos/ppedrot/coq/pulls{/number}","milestones_url":"https://api.github.com/repos/ppedrot/coq/milestones{/number}","notifications_url":"https://api.github.com/repos/ppedrot/coq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ppedrot/coq/labels{/name}","releases_url":"https://api.github.com/repos/ppedrot/coq/releases{/id}","deployments_url":"https://api.github.com/repos/ppedrot/coq/deployments","created_at":"2013-05-28T16:46:07Z","updated_at":"2017-03-30T19:08:42Z","pushed_at":"2018-02-27T14:33:37Z","git_url":"git://github.com/ppedrot/coq.git","ssh_url":"git@github.com:ppedrot/coq.git","clone_url":"https://github.com/ppedrot/coq.git","svn_url":"https://github.com/ppedrot/coq","homepage":"http://coq.inria.fr/","size":86741,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coq:master","ref":"master","sha":"2f349829c125ed0e2d55548935e7b90e7719f12e","user":{"login":"coq","id":621198,"avatar_url":"https://avatars1.githubusercontent.com/u/621198?v=4","gravatar_id":"","url":"https://api.github.com/users/coq","html_url":"https://github.com/coq","followers_url":"https://api.github.com/users/coq/followers","following_url":"https://api.github.com/users/coq/following{/other_user}","gists_url":"https://api.github.com/users/coq/gists{/gist_id}","starred_url":"https://api.github.com/users/coq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coq/subscriptions","organizations_url":"https://api.github.com/users/coq/orgs","repos_url":"https://api.github.com/users/coq/repos","events_url":"https://api.github.com/users/coq/events{/privacy}","received_events_url":"https://api.github.com/users/coq/received_events","type":"Organization","site_admin":false},"repo":{"id":1377159,"name":"coq","full_name":"coq/coq","owner":{"login":"coq","id":621198,"avatar_url":"https://avatars1.githubusercontent.com/u/621198?v=4","gravatar_id":"","url":"https://api.github.com/users/coq","html_url":"https://github.com/coq","followers_url":"https://api.github.com/users/coq/followers","following_url":"https://api.github.com/users/coq/following{/other_user}","gists_url":"https://api.github.com/users/coq/gists{/gist_id}","starred_url":"https://api.github.com/users/coq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coq/subscriptions","organizations_url":"https://api.github.com/users/coq/orgs","repos_url":"https://api.github.com/users/coq/repos","events_url":"https://api.github.com/users/coq/events{/privacy}","received_events_url":"https://api.github.com/users/coq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coq/coq","description":"Coq is a formal proof management system. It provides a formal language to write mathematical definitions, executable algorithms and theorems together with an environment for semi-interactive development of machine-checked proofs. ","fork":false,"url":"https://api.github.com/repos/coq/coq","forks_url":"https://api.github.com/repos/coq/coq/forks","keys_url":"https://api.github.com/repos/coq/coq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coq/coq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coq/coq/teams","hooks_url":"https://api.github.com/repos/coq/coq/hooks","issue_events_url":"https://api.github.com/repos/coq/coq/issues/events{/number}","events_url":"https://api.github.com/repos/coq/coq/events","assignees_url":"https://api.github.com/repos/coq/coq/assignees{/user}","branches_url":"https://api.github.com/repos/coq/coq/branches{/branch}","tags_url":"https://api.github.com/repos/coq/coq/tags","blobs_url":"https://api.github.com/repos/coq/coq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coq/coq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coq/coq/git/refs{/sha}","trees_url":"https://api.github.com/repos/coq/coq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coq/coq/statuses/{sha}","languages_url":"https://api.github.com/repos/coq/coq/languages","stargazers_url":"https://api.github.com/repos/coq/coq/stargazers","contributors_url":"https://api.github.com/repos/coq/coq/contributors","subscribers_url":"https://api.github.com/repos/coq/coq/subscribers","subscription_url":"https://api.github.com/repos/coq/coq/subscription","commits_url":"https://api.github.com/repos/coq/coq/commits{/sha}","git_commits_url":"https://api.github.com/repos/coq/coq/git/commits{/sha}","comments_url":"https://api.github.com/repos/coq/coq/comments{/number}","issue_comment_url":"https://api.github.com/repos/coq/coq/issues/comments{/number}","contents_url":"https://api.github.com/repos/coq/coq/contents/{+path}","compare_url":"https://api.github.com/repos/coq/coq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coq/coq/merges","archive_url":"https://api.github.com/repos/coq/coq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coq/coq/downloads","issues_url":"https://api.github.com/repos/coq/coq/issues{/number}","pulls_url":"https://api.github.com/repos/coq/coq/pulls{/number}","milestones_url":"https://api.github.com/repos/coq/coq/milestones{/number}","notifications_url":"https://api.github.com/repos/coq/coq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coq/coq/labels{/name}","releases_url":"https://api.github.com/repos/coq/coq/releases{/id}","deployments_url":"https://api.github.com/repos/coq/coq/deployments","created_at":"2011-02-17T05:49:37Z","updated_at":"2018-02-28T10:17:55Z","pushed_at":"2018-02-28T10:27:13Z","git_url":"git://github.com/coq/coq.git","ssh_url":"git@github.com:coq/coq.git","clone_url":"https://github.com/coq/coq.git","svn_url":"https://github.com/coq/coq","homepage":"https://coq.inria.fr/","size":104938,"stargazers_count":1033,"watchers_count":1033,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":227,"mirror_url":null,"archived":false,"open_issues_count":1445,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":227,"open_issues":1445,"watchers":1033,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coq/coq/pulls/935"},"html":{"href":"https://github.com/coq/coq/pull/935"},"issue":{"href":"https://api.github.com/repos/coq/coq/issues/935"},"comments":{"href":"https://api.github.com/repos/coq/coq/issues/935/comments"},"review_comments":{"href":"https://api.github.com/repos/coq/coq/pulls/935/comments"},"review_comment":{"href":"https://api.github.com/repos/coq/coq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coq/coq/pulls/935/commits"},"statuses":{"href":"https://api.github.com/repos/coq/coq/statuses/ffb8e3dd554463dad2fda4a77e6c249db98aaa39"}},"author_association":"OWNER"}}
{"actor":{"display_login":"herbelin"}}