{"action":"created","comment":{"url":"https://api.github.com/repos/pybee/toga/pulls/comments/191636040","pull_request_review_id":124242412,"id":191636040,"diff_hunk":"@@ -35,8 +39,17 @@ def rehint(self):\n         self.interface.intrinsic.height = self.native.PreferredSize.Height\n \n     def set_on_change(self, handler):\n-        self.native.TextChanged += self.on_text_change\n+        self.native.TextChanged += self.winforms_onTextChanged","path":"src/winforms/toga_winforms/widgets/textinput.py","position":24,"original_position":24,"commit_id":"8ef157c039b451cdf549f2050cd7fe52adde8fc2","original_commit_id":"8ef157c039b451cdf549f2050cd7fe52adde8fc2","user":{"login":"freakboy3742","id":37345,"avatar_url":"https://avatars1.githubusercontent.com/u/37345?v=4","gravatar_id":"","url":"https://api.github.com/users/freakboy3742","html_url":"https://github.com/freakboy3742","followers_url":"https://api.github.com/users/freakboy3742/followers","following_url":"https://api.github.com/users/freakboy3742/following{/other_user}","gists_url":"https://api.github.com/users/freakboy3742/gists{/gist_id}","starred_url":"https://api.github.com/users/freakboy3742/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freakboy3742/subscriptions","organizations_url":"https://api.github.com/users/freakboy3742/orgs","repos_url":"https://api.github.com/users/freakboy3742/repos","events_url":"https://api.github.com/users/freakboy3742/events{/privacy}","received_events_url":"https://api.github.com/users/freakboy3742/received_events","type":"User","site_admin":false},"body":"Is this right? Shouldn't this be in the create() method, setting up the Winforms handler?","created_at":"2018-05-30T03:51:52Z","updated_at":"2018-05-30T04:00:23Z","html_url":"https://github.com/pybee/toga/pull/527#discussion_r191636040","pull_request_url":"https://api.github.com/repos/pybee/toga/pulls/527","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pybee/toga/pulls/comments/191636040"},"html":{"href":"https://github.com/pybee/toga/pull/527#discussion_r191636040"},"pull_request":{"href":"https://api.github.com/repos/pybee/toga/pulls/527"}}},"pull_request":{"url":"https://api.github.com/repos/pybee/toga/pulls/527","id":190797421,"html_url":"https://github.com/pybee/toga/pull/527","diff_url":"https://github.com/pybee/toga/pull/527.diff","patch_url":"https://github.com/pybee/toga/pull/527.patch","issue_url":"https://api.github.com/repos/pybee/toga/issues/527","number":527,"state":"open","locked":false,"title":"Added textInput placeholder in winforms","user":{"login":"obulat","id":15233243,"avatar_url":"https://avatars1.githubusercontent.com/u/15233243?v=4","gravatar_id":"","url":"https://api.github.com/users/obulat","html_url":"https://github.com/obulat","followers_url":"https://api.github.com/users/obulat/followers","following_url":"https://api.github.com/users/obulat/following{/other_user}","gists_url":"https://api.github.com/users/obulat/gists{/gist_id}","starred_url":"https://api.github.com/users/obulat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obulat/subscriptions","organizations_url":"https://api.github.com/users/obulat/orgs","repos_url":"https://api.github.com/users/obulat/repos","events_url":"https://api.github.com/users/obulat/events{/privacy}","received_events_url":"https://api.github.com/users/obulat/received_events","type":"User","site_admin":false},"body":"Added placeholder implementation to textInput in winforms. The code could be extracted to winforms.libs so that it could be reused on multilineTextInput, but I couldn't get it to work.\r\n\r\nAlso changed winforms specific handler name to winforms_ prefixed name.\r\n\r\n<!--- Describe your changes in detail -->\r\n<!--- What problem does this change solve? -->\r\n<!--- If this PR relates to an issue, include Refs #XXX or Fixes #XXX -->\r\n\r\n## PR Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n- [x] All new features have been tested\r\n- [ ] All new features have been documented\r\n- [x] I have read the **CONTRIBUTING.md** file\r\n- [x] I will abide by the code of conduct\r\n","created_at":"2018-05-27T17:09:31Z","updated_at":"2018-05-30T04:00:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80c9f83a5b4595331b51039ae82e8178e3eb0fad","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pybee/toga/pulls/527/commits","review_comments_url":"https://api.github.com/repos/pybee/toga/pulls/527/comments","review_comment_url":"https://api.github.com/repos/pybee/toga/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pybee/toga/issues/527/comments","statuses_url":"https://api.github.com/repos/pybee/toga/statuses/8ef157c039b451cdf549f2050cd7fe52adde8fc2","head":{"label":"pybee:placeholder","ref":"placeholder","sha":"8ef157c039b451cdf549f2050cd7fe52adde8fc2","user":{"login":"pybee","id":5001767,"avatar_url":"https://avatars0.githubusercontent.com/u/5001767?v=4","gravatar_id":"","url":"https://api.github.com/users/pybee","html_url":"https://github.com/pybee","followers_url":"https://api.github.com/users/pybee/followers","following_url":"https://api.github.com/users/pybee/following{/other_user}","gists_url":"https://api.github.com/users/pybee/gists{/gist_id}","starred_url":"https://api.github.com/users/pybee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pybee/subscriptions","organizations_url":"https://api.github.com/users/pybee/orgs","repos_url":"https://api.github.com/users/pybee/repos","events_url":"https://api.github.com/users/pybee/events{/privacy}","received_events_url":"https://api.github.com/users/pybee/received_events","type":"Organization","site_admin":false},"repo":{"id":22529973,"name":"toga","full_name":"pybee/toga","owner":{"login":"pybee","id":5001767,"avatar_url":"https://avatars0.githubusercontent.com/u/5001767?v=4","gravatar_id":"","url":"https://api.github.com/users/pybee","html_url":"https://github.com/pybee","followers_url":"https://api.github.com/users/pybee/followers","following_url":"https://api.github.com/users/pybee/following{/other_user}","gists_url":"https://api.github.com/users/pybee/gists{/gist_id}","starred_url":"https://api.github.com/users/pybee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pybee/subscriptions","organizations_url":"https://api.github.com/users/pybee/orgs","repos_url":"https://api.github.com/users/pybee/repos","events_url":"https://api.github.com/users/pybee/events{/privacy}","received_events_url":"https://api.github.com/users/pybee/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pybee/toga","description":"A Python native, OS native GUI toolkit.","fork":false,"url":"https://api.github.com/repos/pybee/toga","forks_url":"https://api.github.com/repos/pybee/toga/forks","keys_url":"https://api.github.com/repos/pybee/toga/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pybee/toga/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pybee/toga/teams","hooks_url":"https://api.github.com/repos/pybee/toga/hooks","issue_events_url":"https://api.github.com/repos/pybee/toga/issues/events{/number}","events_url":"https://api.github.com/repos/pybee/toga/events","assignees_url":"https://api.github.com/repos/pybee/toga/assignees{/user}","branches_url":"https://api.github.com/repos/pybee/toga/branches{/branch}","tags_url":"https://api.github.com/repos/pybee/toga/tags","blobs_url":"https://api.github.com/repos/pybee/toga/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pybee/toga/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pybee/toga/git/refs{/sha}","trees_url":"https://api.github.com/repos/pybee/toga/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pybee/toga/statuses/{sha}","languages_url":"https://api.github.com/repos/pybee/toga/languages","stargazers_url":"https://api.github.com/repos/pybee/toga/stargazers","contributors_url":"https://api.github.com/repos/pybee/toga/contributors","subscribers_url":"https://api.github.com/repos/pybee/toga/subscribers","subscription_url":"https://api.github.com/repos/pybee/toga/subscription","commits_url":"https://api.github.com/repos/pybee/toga/commits{/sha}","git_commits_url":"https://api.github.com/repos/pybee/toga/git/commits{/sha}","comments_url":"https://api.github.com/repos/pybee/toga/comments{/number}","issue_comment_url":"https://api.github.com/repos/pybee/toga/issues/comments{/number}","contents_url":"https://api.github.com/repos/pybee/toga/contents/{+path}","compare_url":"https://api.github.com/repos/pybee/toga/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pybee/toga/merges","archive_url":"https://api.github.com/repos/pybee/toga/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pybee/toga/downloads","issues_url":"https://api.github.com/repos/pybee/toga/issues{/number}","pulls_url":"https://api.github.com/repos/pybee/toga/pulls{/number}","milestones_url":"https://api.github.com/repos/pybee/toga/milestones{/number}","notifications_url":"https://api.github.com/repos/pybee/toga/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pybee/toga/labels{/name}","releases_url":"https://api.github.com/repos/pybee/toga/releases{/id}","deployments_url":"https://api.github.com/repos/pybee/toga/deployments","created_at":"2014-08-01T21:44:10Z","updated_at":"2018-05-30T03:46:03Z","pushed_at":"2018-05-30T03:45:58Z","git_url":"git://github.com/pybee/toga.git","ssh_url":"git@github.com:pybee/toga.git","clone_url":"https://github.com/pybee/toga.git","svn_url":"https://github.com/pybee/toga","homepage":"https://toga.readthedocs.io/en/latest/","size":5318,"stargazers_count":1617,"watchers_count":1617,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":244,"mirror_url":null,"archived":false,"open_issues_count":75,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":244,"open_issues":75,"watchers":1617,"default_branch":"master"}},"base":{"label":"pybee:master","ref":"master","sha":"cd403d6e6c5ba2928e6e4ef5a8316cdbdb3840a5","user":{"login":"pybee","id":5001767,"avatar_url":"https://avatars0.githubusercontent.com/u/5001767?v=4","gravatar_id":"","url":"https://api.github.com/users/pybee","html_url":"https://github.com/pybee","followers_url":"https://api.github.com/users/pybee/followers","following_url":"https://api.github.com/users/pybee/following{/other_user}","gists_url":"https://api.github.com/users/pybee/gists{/gist_id}","starred_url":"https://api.github.com/users/pybee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pybee/subscriptions","organizations_url":"https://api.github.com/users/pybee/orgs","repos_url":"https://api.github.com/users/pybee/repos","events_url":"https://api.github.com/users/pybee/events{/privacy}","received_events_url":"https://api.github.com/users/pybee/received_events","type":"Organization","site_admin":false},"repo":{"id":22529973,"name":"toga","full_name":"pybee/toga","owner":{"login":"pybee","id":5001767,"avatar_url":"https://avatars0.githubusercontent.com/u/5001767?v=4","gravatar_id":"","url":"https://api.github.com/users/pybee","html_url":"https://github.com/pybee","followers_url":"https://api.github.com/users/pybee/followers","following_url":"https://api.github.com/users/pybee/following{/other_user}","gists_url":"https://api.github.com/users/pybee/gists{/gist_id}","starred_url":"https://api.github.com/users/pybee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pybee/subscriptions","organizations_url":"https://api.github.com/users/pybee/orgs","repos_url":"https://api.github.com/users/pybee/repos","events_url":"https://api.github.com/users/pybee/events{/privacy}","received_events_url":"https://api.github.com/users/pybee/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pybee/toga","description":"A Python native, OS native GUI toolkit.","fork":false,"url":"https://api.github.com/repos/pybee/toga","forks_url":"https://api.github.com/repos/pybee/toga/forks","keys_url":"https://api.github.com/repos/pybee/toga/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pybee/toga/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pybee/toga/teams","hooks_url":"https://api.github.com/repos/pybee/toga/hooks","issue_events_url":"https://api.github.com/repos/pybee/toga/issues/events{/number}","events_url":"https://api.github.com/repos/pybee/toga/events","assignees_url":"https://api.github.com/repos/pybee/toga/assignees{/user}","branches_url":"https://api.github.com/repos/pybee/toga/branches{/branch}","tags_url":"https://api.github.com/repos/pybee/toga/tags","blobs_url":"https://api.github.com/repos/pybee/toga/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pybee/toga/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pybee/toga/git/refs{/sha}","trees_url":"https://api.github.com/repos/pybee/toga/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pybee/toga/statuses/{sha}","languages_url":"https://api.github.com/repos/pybee/toga/languages","stargazers_url":"https://api.github.com/repos/pybee/toga/stargazers","contributors_url":"https://api.github.com/repos/pybee/toga/contributors","subscribers_url":"https://api.github.com/repos/pybee/toga/subscribers","subscription_url":"https://api.github.com/repos/pybee/toga/subscription","commits_url":"https://api.github.com/repos/pybee/toga/commits{/sha}","git_commits_url":"https://api.github.com/repos/pybee/toga/git/commits{/sha}","comments_url":"https://api.github.com/repos/pybee/toga/comments{/number}","issue_comment_url":"https://api.github.com/repos/pybee/toga/issues/comments{/number}","contents_url":"https://api.github.com/repos/pybee/toga/contents/{+path}","compare_url":"https://api.github.com/repos/pybee/toga/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pybee/toga/merges","archive_url":"https://api.github.com/repos/pybee/toga/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pybee/toga/downloads","issues_url":"https://api.github.com/repos/pybee/toga/issues{/number}","pulls_url":"https://api.github.com/repos/pybee/toga/pulls{/number}","milestones_url":"https://api.github.com/repos/pybee/toga/milestones{/number}","notifications_url":"https://api.github.com/repos/pybee/toga/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pybee/toga/labels{/name}","releases_url":"https://api.github.com/repos/pybee/toga/releases{/id}","deployments_url":"https://api.github.com/repos/pybee/toga/deployments","created_at":"2014-08-01T21:44:10Z","updated_at":"2018-05-30T03:46:03Z","pushed_at":"2018-05-30T03:45:58Z","git_url":"git://github.com/pybee/toga.git","ssh_url":"git@github.com:pybee/toga.git","clone_url":"https://github.com/pybee/toga.git","svn_url":"https://github.com/pybee/toga","homepage":"https://toga.readthedocs.io/en/latest/","size":5318,"stargazers_count":1617,"watchers_count":1617,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":244,"mirror_url":null,"archived":false,"open_issues_count":75,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":244,"open_issues":75,"watchers":1617,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pybee/toga/pulls/527"},"html":{"href":"https://github.com/pybee/toga/pull/527"},"issue":{"href":"https://api.github.com/repos/pybee/toga/issues/527"},"comments":{"href":"https://api.github.com/repos/pybee/toga/issues/527/comments"},"review_comments":{"href":"https://api.github.com/repos/pybee/toga/pulls/527/comments"},"review_comment":{"href":"https://api.github.com/repos/pybee/toga/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pybee/toga/pulls/527/commits"},"statuses":{"href":"https://api.github.com/repos/pybee/toga/statuses/8ef157c039b451cdf549f2050cd7fe52adde8fc2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"freakboy3742"}}