{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/corefx/issues/30851","repository_url":"https://api.github.com/repos/dotnet/corefx","labels_url":"https://api.github.com/repos/dotnet/corefx/issues/30851/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/30851/comments","events_url":"https://api.github.com/repos/dotnet/corefx/issues/30851/events","html_url":"https://github.com/dotnet/corefx/pull/30851","id":338718909,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NTgxODMy","number":30851,"title":"Fixed getmntinfo() call on FreeBSD","user":{"login":"mateusrodrigues","id":6340196,"node_id":"MDQ6VXNlcjYzNDAxOTY=","avatar_url":"https://avatars3.githubusercontent.com/u/6340196?v=4","gravatar_id":"","url":"https://api.github.com/users/mateusrodrigues","html_url":"https://github.com/mateusrodrigues","followers_url":"https://api.github.com/users/mateusrodrigues/followers","following_url":"https://api.github.com/users/mateusrodrigues/following{/other_user}","gists_url":"https://api.github.com/users/mateusrodrigues/gists{/gist_id}","starred_url":"https://api.github.com/users/mateusrodrigues/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mateusrodrigues/subscriptions","organizations_url":"https://api.github.com/users/mateusrodrigues/orgs","repos_url":"https://api.github.com/users/mateusrodrigues/repos","events_url":"https://api.github.com/users/mateusrodrigues/events{/privacy}","received_events_url":"https://api.github.com/users/mateusrodrigues/received_events","type":"User","site_admin":false},"labels":[{"id":145399955,"node_id":"MDU6TGFiZWwxNDUzOTk5NTU=","url":"https://api.github.com/repos/dotnet/corefx/labels/bug","name":"bug","color":"207de5","default":true},{"id":205613987,"node_id":"MDU6TGFiZWwyMDU2MTM5ODc=","url":"https://api.github.com/repos/dotnet/corefx/labels/os-freebsd","name":"os-freebsd","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":{"login":"mateusrodrigues","id":6340196,"node_id":"MDQ6VXNlcjYzNDAxOTY=","avatar_url":"https://avatars3.githubusercontent.com/u/6340196?v=4","gravatar_id":"","url":"https://api.github.com/users/mateusrodrigues","html_url":"https://github.com/mateusrodrigues","followers_url":"https://api.github.com/users/mateusrodrigues/followers","following_url":"https://api.github.com/users/mateusrodrigues/following{/other_user}","gists_url":"https://api.github.com/users/mateusrodrigues/gists{/gist_id}","starred_url":"https://api.github.com/users/mateusrodrigues/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mateusrodrigues/subscriptions","organizations_url":"https://api.github.com/users/mateusrodrigues/orgs","repos_url":"https://api.github.com/users/mateusrodrigues/repos","events_url":"https://api.github.com/users/mateusrodrigues/events{/privacy}","received_events_url":"https://api.github.com/users/mateusrodrigues/received_events","type":"User","site_admin":false},"assignees":[{"login":"mateusrodrigues","id":6340196,"node_id":"MDQ6VXNlcjYzNDAxOTY=","avatar_url":"https://avatars3.githubusercontent.com/u/6340196?v=4","gravatar_id":"","url":"https://api.github.com/users/mateusrodrigues","html_url":"https://github.com/mateusrodrigues","followers_url":"https://api.github.com/users/mateusrodrigues/followers","following_url":"https://api.github.com/users/mateusrodrigues/following{/other_user}","gists_url":"https://api.github.com/users/mateusrodrigues/gists{/gist_id}","starred_url":"https://api.github.com/users/mateusrodrigues/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mateusrodrigues/subscriptions","organizations_url":"https://api.github.com/users/mateusrodrigues/orgs","repos_url":"https://api.github.com/users/mateusrodrigues/repos","events_url":"https://api.github.com/users/mateusrodrigues/events{/privacy}","received_events_url":"https://api.github.com/users/mateusrodrigues/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-07-05T20:41:05Z","updated_at":"2018-07-05T21:57:49Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/30851","html_url":"https://github.com/dotnet/corefx/pull/30851","diff_url":"https://github.com/dotnet/corefx/pull/30851.diff","patch_url":"https://github.com/dotnet/corefx/pull/30851.patch"},"body":"This change was necessary because the original way the `getmntinfo()` function was being called did not complete successfully on FreeBSD. According to documentation, the second parameter `int mode` only accepts `MNT_WAIT` (1) or `MNT_NOWAIT` (2) as valid inputs and, as 0 was being passed in, the function returned zero mount points and set an `errno` of `EINVAL`.\r\n\r\nReferences: [getmntinfo(3)](https://www.freebsd.org/cgi/man.cgi?query=getmntinfo) and [getfsstat(2)](https://www.freebsd.org/cgi/man.cgi?query=getfsstat&sektion=2&apropos=0&manpath=FreeBSD+11.2-RELEASE+and+Ports)\r\n\r\nRelated [coreclr/#18067](https://github.com/dotnet/coreclr/issues/18067)"},"comment":{"url":"https://api.github.com/repos/dotnet/corefx/issues/comments/402864912","html_url":"https://github.com/dotnet/corefx/pull/30851#issuecomment-402864912","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/30851","id":402864912,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjg2NDkxMg==","user":{"login":"mateusrodrigues","id":6340196,"node_id":"MDQ6VXNlcjYzNDAxOTY=","avatar_url":"https://avatars3.githubusercontent.com/u/6340196?v=4","gravatar_id":"","url":"https://api.github.com/users/mateusrodrigues","html_url":"https://github.com/mateusrodrigues","followers_url":"https://api.github.com/users/mateusrodrigues/followers","following_url":"https://api.github.com/users/mateusrodrigues/following{/other_user}","gists_url":"https://api.github.com/users/mateusrodrigues/gists{/gist_id}","starred_url":"https://api.github.com/users/mateusrodrigues/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mateusrodrigues/subscriptions","organizations_url":"https://api.github.com/users/mateusrodrigues/orgs","repos_url":"https://api.github.com/users/mateusrodrigues/repos","events_url":"https://api.github.com/users/mateusrodrigues/events{/privacy}","received_events_url":"https://api.github.com/users/mateusrodrigues/received_events","type":"User","site_admin":false},"created_at":"2018-07-05T21:57:49Z","updated_at":"2018-07-05T21:57:49Z","author_association":"NONE","body":"I'm going one-by-one to see which failing tests are related to this, but so far, this change fixed:\r\n- `System.Tests.EnvironmentTests.GetLogicalDrives_Unix_AtLeastOneIsRoot`\r\n- `System.IO.FileSystem.DriveInfoTests.DriveInfoUnixTests.TestGetDrives`\r\n- `System.IO.Tests.Directory_GetLogicalDrives.GetsValidDriveStrings_Unix`\r\n\r\nSome other failing tests are linux-specific and somehow, `[PlatformSpecific(TestPlatforms.Linux)]` is still running on FreeBSD.\r\n\r\nI'll update my list, get it into a readable format and put it out."}}
{"actor":{"display_login":"mateusrodrigues"}}