{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/20588","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/20588/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/20588/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/20588/events","html_url":"https://github.com/nodejs/node/pull/20588","id":321015424,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg2NTA3MzU3","number":20588,"title":"fs: improve fchmod{Sync} validation","user":{"login":"cjihrig","id":2512748,"node_id":"MDQ6VXNlcjI1MTI3NDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2512748?v=4","gravatar_id":"","url":"https://api.github.com/users/cjihrig","html_url":"https://github.com/cjihrig","followers_url":"https://api.github.com/users/cjihrig/followers","following_url":"https://api.github.com/users/cjihrig/following{/other_user}","gists_url":"https://api.github.com/users/cjihrig/gists{/gist_id}","starred_url":"https://api.github.com/users/cjihrig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjihrig/subscriptions","organizations_url":"https://api.github.com/users/cjihrig/orgs","repos_url":"https://api.github.com/users/cjihrig/repos","events_url":"https://api.github.com/users/cjihrig/events{/privacy}","received_events_url":"https://api.github.com/users/cjihrig/received_events","type":"User","site_admin":false},"labels":[{"id":922899907,"node_id":"MDU6TGFiZWw5MjI4OTk5MDc=","url":"https://api.github.com/repos/nodejs/node/labels/backport-requested-v10.x","name":"backport-requested-v10.x","color":"4213c4","default":false},{"id":155435785,"node_id":"MDU6TGFiZWwxNTU0MzU3ODU=","url":"https://api.github.com/repos/nodejs/node/labels/fs","name":"fs","color":"0052cc","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-05-08T01:51:14Z","updated_at":"2018-05-30T17:52:40Z","closed_at":"2018-05-20T02:26:16Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/20588","html_url":"https://github.com/nodejs/node/pull/20588","diff_url":"https://github.com/nodejs/node/pull/20588.diff","patch_url":"https://github.com/nodejs/node/pull/20588.patch"},"body":"This commit removes the check for `mode > 0o777`. It also validates the inputs as int32s instead of uint32s, because they are ints in the binding layer. Range validation is also added to the internal validators.\r\n\r\nFixes: https://github.com/nodejs/node/issues/20498\r\n\r\n##### Checklist\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/393256978","html_url":"https://github.com/nodejs/node/pull/20588#issuecomment-393256978","issue_url":"https://api.github.com/repos/nodejs/node/issues/20588","id":393256978,"node_id":"MDEyOklzc3VlQ29tbWVudDM5MzI1Njk3OA==","user":{"login":"Fedeorlandau","id":10283686,"node_id":"MDQ6VXNlcjEwMjgzNjg2","avatar_url":"https://avatars2.githubusercontent.com/u/10283686?v=4","gravatar_id":"","url":"https://api.github.com/users/Fedeorlandau","html_url":"https://github.com/Fedeorlandau","followers_url":"https://api.github.com/users/Fedeorlandau/followers","following_url":"https://api.github.com/users/Fedeorlandau/following{/other_user}","gists_url":"https://api.github.com/users/Fedeorlandau/gists{/gist_id}","starred_url":"https://api.github.com/users/Fedeorlandau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fedeorlandau/subscriptions","organizations_url":"https://api.github.com/users/Fedeorlandau/orgs","repos_url":"https://api.github.com/users/Fedeorlandau/repos","events_url":"https://api.github.com/users/Fedeorlandau/events{/privacy}","received_events_url":"https://api.github.com/users/Fedeorlandau/received_events","type":"User","site_admin":false},"created_at":"2018-05-30T17:52:40Z","updated_at":"2018-05-30T17:52:40Z","author_association":"NONE","body":"Hi! Do you know when is going to be published? It's causing several fails on Travis CI\r\n\r\nThank you!!!!! ❤️ "}}
{"actor":{"display_login":"Fedeorlandau"}}