{"action":"created","comment":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/comments/182516420","pull_request_review_id":113327657,"id":182516420,"diff_hunk":"@@ -0,0 +1,82 @@\n+require 'rails_helper'","path":"core/spec/lib/spree/events/processors/mail_processor_spec.rb","position":1,"original_position":1,"commit_id":"cbc9c6d46a43f23ab022515b95f3f6ded4a14d30","original_commit_id":"cbc9c6d46a43f23ab022515b95f3f6ded4a14d30","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.","created_at":"2018-04-18T17:57:21Z","updated_at":"2018-04-18T17:57:24Z","html_url":"https://github.com/solidusio/solidus/pull/2431#discussion_r182516420","pull_request_url":"https://api.github.com/repos/solidusio/solidus/pulls/2431","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/comments/182516420"},"html":{"href":"https://github.com/solidusio/solidus/pull/2431#discussion_r182516420"},"pull_request":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/2431"}}},"pull_request":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/2431","id":156885896,"html_url":"https://github.com/solidusio/solidus/pull/2431","diff_url":"https://github.com/solidusio/solidus/pull/2431.diff","patch_url":"https://github.com/solidusio/solidus/pull/2431.patch","issue_url":"https://api.github.com/repos/solidusio/solidus/issues/2431","number":2431,"state":"open","locked":false,"title":"Add event bus","user":{"login":"swcraig","id":11495200,"avatar_url":"https://avatars3.githubusercontent.com/u/11495200?v=4","gravatar_id":"","url":"https://api.github.com/users/swcraig","html_url":"https://github.com/swcraig","followers_url":"https://api.github.com/users/swcraig/followers","following_url":"https://api.github.com/users/swcraig/following{/other_user}","gists_url":"https://api.github.com/users/swcraig/gists{/gist_id}","starred_url":"https://api.github.com/users/swcraig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swcraig/subscriptions","organizations_url":"https://api.github.com/users/swcraig/orgs","repos_url":"https://api.github.com/users/swcraig/repos","events_url":"https://api.github.com/users/swcraig/events{/privacy}","received_events_url":"https://api.github.com/users/swcraig/received_events","type":"User","site_admin":false},"body":"Related to #2430, this is an \"event bus\" implementation that @derrickp and I have been working on.\r\n\r\n`Spree::MailProcessor` subscribes to `Spree::EventBus` which publishes events.\r\n\r\n`Spree::MailProcessor` can be used as a template for how to create new processors (and how to subscribe to events). The processor implements a `#register!` method defining its subscriptions. This class will presumably be ripped out into its own extension after this PR is merged.\r\n\r\nThis PR does **not** handle hierarchical events or asynchronous/distributed processing.","created_at":"2017-12-07T01:52:42Z","updated_at":"2018-04-18T17:57:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f315b8010b988dce2298d0a1b0e260bc15ddf046","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/solidusio/solidus/pulls/2431/commits","review_comments_url":"https://api.github.com/repos/solidusio/solidus/pulls/2431/comments","review_comment_url":"https://api.github.com/repos/solidusio/solidus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/solidusio/solidus/issues/2431/comments","statuses_url":"https://api.github.com/repos/solidusio/solidus/statuses/cbc9c6d46a43f23ab022515b95f3f6ded4a14d30","head":{"label":"swcraig:add-simple-event-bus","ref":"add-simple-event-bus","sha":"cbc9c6d46a43f23ab022515b95f3f6ded4a14d30","user":{"login":"swcraig","id":11495200,"avatar_url":"https://avatars3.githubusercontent.com/u/11495200?v=4","gravatar_id":"","url":"https://api.github.com/users/swcraig","html_url":"https://github.com/swcraig","followers_url":"https://api.github.com/users/swcraig/followers","following_url":"https://api.github.com/users/swcraig/following{/other_user}","gists_url":"https://api.github.com/users/swcraig/gists{/gist_id}","starred_url":"https://api.github.com/users/swcraig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swcraig/subscriptions","organizations_url":"https://api.github.com/users/swcraig/orgs","repos_url":"https://api.github.com/users/swcraig/repos","events_url":"https://api.github.com/users/swcraig/events{/privacy}","received_events_url":"https://api.github.com/users/swcraig/received_events","type":"User","site_admin":false},"repo":{"id":94935976,"name":"solidus","full_name":"swcraig/solidus","owner":{"login":"swcraig","id":11495200,"avatar_url":"https://avatars3.githubusercontent.com/u/11495200?v=4","gravatar_id":"","url":"https://api.github.com/users/swcraig","html_url":"https://github.com/swcraig","followers_url":"https://api.github.com/users/swcraig/followers","following_url":"https://api.github.com/users/swcraig/following{/other_user}","gists_url":"https://api.github.com/users/swcraig/gists{/gist_id}","starred_url":"https://api.github.com/users/swcraig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swcraig/subscriptions","organizations_url":"https://api.github.com/users/swcraig/orgs","repos_url":"https://api.github.com/users/swcraig/repos","events_url":"https://api.github.com/users/swcraig/events{/privacy}","received_events_url":"https://api.github.com/users/swcraig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/swcraig/solidus","description":"Solidus, Rails eCommerce System","fork":true,"url":"https://api.github.com/repos/swcraig/solidus","forks_url":"https://api.github.com/repos/swcraig/solidus/forks","keys_url":"https://api.github.com/repos/swcraig/solidus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swcraig/solidus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swcraig/solidus/teams","hooks_url":"https://api.github.com/repos/swcraig/solidus/hooks","issue_events_url":"https://api.github.com/repos/swcraig/solidus/issues/events{/number}","events_url":"https://api.github.com/repos/swcraig/solidus/events","assignees_url":"https://api.github.com/repos/swcraig/solidus/assignees{/user}","branches_url":"https://api.github.com/repos/swcraig/solidus/branches{/branch}","tags_url":"https://api.github.com/repos/swcraig/solidus/tags","blobs_url":"https://api.github.com/repos/swcraig/solidus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swcraig/solidus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swcraig/solidus/git/refs{/sha}","trees_url":"https://api.github.com/repos/swcraig/solidus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swcraig/solidus/statuses/{sha}","languages_url":"https://api.github.com/repos/swcraig/solidus/languages","stargazers_url":"https://api.github.com/repos/swcraig/solidus/stargazers","contributors_url":"https://api.github.com/repos/swcraig/solidus/contributors","subscribers_url":"https://api.github.com/repos/swcraig/solidus/subscribers","subscription_url":"https://api.github.com/repos/swcraig/solidus/subscription","commits_url":"https://api.github.com/repos/swcraig/solidus/commits{/sha}","git_commits_url":"https://api.github.com/repos/swcraig/solidus/git/commits{/sha}","comments_url":"https://api.github.com/repos/swcraig/solidus/comments{/number}","issue_comment_url":"https://api.github.com/repos/swcraig/solidus/issues/comments{/number}","contents_url":"https://api.github.com/repos/swcraig/solidus/contents/{+path}","compare_url":"https://api.github.com/repos/swcraig/solidus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swcraig/solidus/merges","archive_url":"https://api.github.com/repos/swcraig/solidus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swcraig/solidus/downloads","issues_url":"https://api.github.com/repos/swcraig/solidus/issues{/number}","pulls_url":"https://api.github.com/repos/swcraig/solidus/pulls{/number}","milestones_url":"https://api.github.com/repos/swcraig/solidus/milestones{/number}","notifications_url":"https://api.github.com/repos/swcraig/solidus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swcraig/solidus/labels{/name}","releases_url":"https://api.github.com/repos/swcraig/solidus/releases{/id}","deployments_url":"https://api.github.com/repos/swcraig/solidus/deployments","created_at":"2017-06-20T21:19:47Z","updated_at":"2018-03-20T16:14:43Z","pushed_at":"2018-04-18T17:57:01Z","git_url":"git://github.com/swcraig/solidus.git","ssh_url":"git@github.com:swcraig/solidus.git","clone_url":"https://github.com/swcraig/solidus.git","svn_url":"https://github.com/swcraig/solidus","homepage":"https://solidus.io/","size":69867,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"solidusio:master","ref":"master","sha":"af30800223d298442c2bd38d969651d114f9c202","user":{"login":"solidusio","id":11045486,"avatar_url":"https://avatars1.githubusercontent.com/u/11045486?v=4","gravatar_id":"","url":"https://api.github.com/users/solidusio","html_url":"https://github.com/solidusio","followers_url":"https://api.github.com/users/solidusio/followers","following_url":"https://api.github.com/users/solidusio/following{/other_user}","gists_url":"https://api.github.com/users/solidusio/gists{/gist_id}","starred_url":"https://api.github.com/users/solidusio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solidusio/subscriptions","organizations_url":"https://api.github.com/users/solidusio/orgs","repos_url":"https://api.github.com/users/solidusio/repos","events_url":"https://api.github.com/users/solidusio/events{/privacy}","received_events_url":"https://api.github.com/users/solidusio/received_events","type":"Organization","site_admin":false},"repo":{"id":30985840,"name":"solidus","full_name":"solidusio/solidus","owner":{"login":"solidusio","id":11045486,"avatar_url":"https://avatars1.githubusercontent.com/u/11045486?v=4","gravatar_id":"","url":"https://api.github.com/users/solidusio","html_url":"https://github.com/solidusio","followers_url":"https://api.github.com/users/solidusio/followers","following_url":"https://api.github.com/users/solidusio/following{/other_user}","gists_url":"https://api.github.com/users/solidusio/gists{/gist_id}","starred_url":"https://api.github.com/users/solidusio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solidusio/subscriptions","organizations_url":"https://api.github.com/users/solidusio/orgs","repos_url":"https://api.github.com/users/solidusio/repos","events_url":"https://api.github.com/users/solidusio/events{/privacy}","received_events_url":"https://api.github.com/users/solidusio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/solidusio/solidus","description":"Solidus, Rails eCommerce System","fork":false,"url":"https://api.github.com/repos/solidusio/solidus","forks_url":"https://api.github.com/repos/solidusio/solidus/forks","keys_url":"https://api.github.com/repos/solidusio/solidus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/solidusio/solidus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/solidusio/solidus/teams","hooks_url":"https://api.github.com/repos/solidusio/solidus/hooks","issue_events_url":"https://api.github.com/repos/solidusio/solidus/issues/events{/number}","events_url":"https://api.github.com/repos/solidusio/solidus/events","assignees_url":"https://api.github.com/repos/solidusio/solidus/assignees{/user}","branches_url":"https://api.github.com/repos/solidusio/solidus/branches{/branch}","tags_url":"https://api.github.com/repos/solidusio/solidus/tags","blobs_url":"https://api.github.com/repos/solidusio/solidus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/solidusio/solidus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/solidusio/solidus/git/refs{/sha}","trees_url":"https://api.github.com/repos/solidusio/solidus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/solidusio/solidus/statuses/{sha}","languages_url":"https://api.github.com/repos/solidusio/solidus/languages","stargazers_url":"https://api.github.com/repos/solidusio/solidus/stargazers","contributors_url":"https://api.github.com/repos/solidusio/solidus/contributors","subscribers_url":"https://api.github.com/repos/solidusio/solidus/subscribers","subscription_url":"https://api.github.com/repos/solidusio/solidus/subscription","commits_url":"https://api.github.com/repos/solidusio/solidus/commits{/sha}","git_commits_url":"https://api.github.com/repos/solidusio/solidus/git/commits{/sha}","comments_url":"https://api.github.com/repos/solidusio/solidus/comments{/number}","issue_comment_url":"https://api.github.com/repos/solidusio/solidus/issues/comments{/number}","contents_url":"https://api.github.com/repos/solidusio/solidus/contents/{+path}","compare_url":"https://api.github.com/repos/solidusio/solidus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/solidusio/solidus/merges","archive_url":"https://api.github.com/repos/solidusio/solidus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/solidusio/solidus/downloads","issues_url":"https://api.github.com/repos/solidusio/solidus/issues{/number}","pulls_url":"https://api.github.com/repos/solidusio/solidus/pulls{/number}","milestones_url":"https://api.github.com/repos/solidusio/solidus/milestones{/number}","notifications_url":"https://api.github.com/repos/solidusio/solidus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/solidusio/solidus/labels{/name}","releases_url":"https://api.github.com/repos/solidusio/solidus/releases{/id}","deployments_url":"https://api.github.com/repos/solidusio/solidus/deployments","created_at":"2015-02-18T20:41:58Z","updated_at":"2018-04-18T16:35:18Z","pushed_at":"2018-04-18T17:57:02Z","git_url":"git://github.com/solidusio/solidus.git","ssh_url":"git@github.com:solidusio/solidus.git","clone_url":"https://github.com/solidusio/solidus.git","svn_url":"https://github.com/solidusio/solidus","homepage":"https://solidus.io/","size":69598,"stargazers_count":1766,"watchers_count":1766,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":576,"mirror_url":null,"archived":false,"open_issues_count":168,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":576,"open_issues":168,"watchers":1766,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/2431"},"html":{"href":"https://github.com/solidusio/solidus/pull/2431"},"issue":{"href":"https://api.github.com/repos/solidusio/solidus/issues/2431"},"comments":{"href":"https://api.github.com/repos/solidusio/solidus/issues/2431/comments"},"review_comments":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/2431/comments"},"review_comment":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/2431/commits"},"statuses":{"href":"https://api.github.com/repos/solidusio/solidus/statuses/cbc9c6d46a43f23ab022515b95f3f6ded4a14d30"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"houndci-bot"}}