{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/22926","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/22926/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/22926/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/22926/events","html_url":"https://github.com/joomla/joomla-cms/pull/22926","id":376976574,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MDY2MDE0","number":22926,"title":"[3.9] Move confirm consent to use the bs modal vs mootools","user":{"login":"zero-24","id":2596554,"node_id":"MDQ6VXNlcjI1OTY1NTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2596554?v=4","gravatar_id":"","url":"https://api.github.com/users/zero-24","html_url":"https://github.com/zero-24","followers_url":"https://api.github.com/users/zero-24/followers","following_url":"https://api.github.com/users/zero-24/following{/other_user}","gists_url":"https://api.github.com/users/zero-24/gists{/gist_id}","starred_url":"https://api.github.com/users/zero-24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zero-24/subscriptions","organizations_url":"https://api.github.com/users/zero-24/orgs","repos_url":"https://api.github.com/users/zero-24/repos","events_url":"https://api.github.com/users/zero-24/events{/privacy}","received_events_url":"https://api.github.com/users/zero-24/received_events","type":"User","site_admin":false},"labels":[{"id":60721348,"node_id":"MDU6TGFiZWw2MDcyMTM0OA==","url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-11-02T21:41:07Z","updated_at":"2018-11-13T20:31:40Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/22926","html_url":"https://github.com/joomla/joomla-cms/pull/22926","diff_url":"https://github.com/joomla/joomla-cms/pull/22926.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/22926.patch"},"body":"Partial Pull Request for Issue #22908\r\n\r\n### Summary of Changes\r\n\r\nThis replaces the Mootools modal vs a bootstrap modal\r\n\r\n### Testing Instructions\r\n\r\n- Install 3.9.0\r\n- enable the `Content - ConfirmConsent` Plugin\r\n- configure this plugin to point to a article\r\n- open a contact page on the website\r\n- make sure the title is clickable and opens an modal\r\n- apply this patch\r\n- make sure it is still opening a modal this time it should be a bs modal\r\n\r\n### Expected result\r\n\r\nbs modal\r\n\r\n### Actual result\r\n\r\nmootools modal\r\n\r\n### Documentation Changes Required\r\n\r\nnone.\r\n\r\n### Additional Information\r\n\r\nWhen this here gets approved & tested I can apply similar code to the other places where we use the old mootools modal:\r\n- TOS Field: https://github.com/joomla/joomla-cms/blob/90078118c3d262d4e21dcd1dbe5ad290297ee5ee/plugins/user/profile/field/tos.php#L83\r\n- Privacy Field: https://github.com/joomla/joomla-cms/blob/40dcca879db47fd28dadf25ee09df3b37f0c4e85/plugins/system/privacyconsent/field/privacy.php#L101\r\n- Terms Field: https://github.com/joomla/joomla-cms/blob/40dcca879db47fd28dadf25ee09df3b37f0c4e85/plugins/user/terms/field/terms.php#L101\r\n\r\ncc @brianteeman as he is the original author of the modal things in this plugin touched here."},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/438425789","html_url":"https://github.com/joomla/joomla-cms/pull/22926#issuecomment-438425789","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/22926","id":438425789,"node_id":"MDEyOklzc3VlQ29tbWVudDQzODQyNTc4OQ==","user":{"login":"drmenzelit","id":9153168,"node_id":"MDQ6VXNlcjkxNTMxNjg=","avatar_url":"https://avatars0.githubusercontent.com/u/9153168?v=4","gravatar_id":"","url":"https://api.github.com/users/drmenzelit","html_url":"https://github.com/drmenzelit","followers_url":"https://api.github.com/users/drmenzelit/followers","following_url":"https://api.github.com/users/drmenzelit/following{/other_user}","gists_url":"https://api.github.com/users/drmenzelit/gists{/gist_id}","starred_url":"https://api.github.com/users/drmenzelit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drmenzelit/subscriptions","organizations_url":"https://api.github.com/users/drmenzelit/orgs","repos_url":"https://api.github.com/users/drmenzelit/repos","events_url":"https://api.github.com/users/drmenzelit/events{/privacy}","received_events_url":"https://api.github.com/users/drmenzelit/received_events","type":"User","site_admin":false},"created_at":"2018-11-13T20:31:40Z","updated_at":"2018-11-13T20:31:40Z","author_association":"CONTRIBUTOR","body":"I have tested this item :white_check_mark: successfully on c7ac385d9a0f48ca4afb1f0ca5ce34d176d5e8f8<hr /><sub>This comment was created with the <a href=\"https://github.com/joomla/jissues\">J!Tracker Application</a> at <a href=\"https://issues.joomla.org/tracker/joomla-cms/22926\">issues.joomla.org/tracker/joomla-cms/22926</a>.</sub>"}}
{"actor":{"display_login":"drmenzelit"}}