{"action":"created","issue":{"url":"https://api.github.com/repos/ReactionMechanismGenerator/RMG-Py/issues/1412","repository_url":"https://api.github.com/repos/ReactionMechanismGenerator/RMG-Py","labels_url":"https://api.github.com/repos/ReactionMechanismGenerator/RMG-Py/issues/1412/labels{/name}","comments_url":"https://api.github.com/repos/ReactionMechanismGenerator/RMG-Py/issues/1412/comments","events_url":"https://api.github.com/repos/ReactionMechanismGenerator/RMG-Py/issues/1412/events","html_url":"https://github.com/ReactionMechanismGenerator/RMG-Py/pull/1412","id":336683599,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MDc4Mzgx","number":1412,"title":"Add deprecation warnings before v2.2","user":{"login":"goldmanm","id":10929950,"node_id":"MDQ6VXNlcjEwOTI5OTUw","avatar_url":"https://avatars0.githubusercontent.com/u/10929950?v=4","gravatar_id":"","url":"https://api.github.com/users/goldmanm","html_url":"https://github.com/goldmanm","followers_url":"https://api.github.com/users/goldmanm/followers","following_url":"https://api.github.com/users/goldmanm/following{/other_user}","gists_url":"https://api.github.com/users/goldmanm/gists{/gist_id}","starred_url":"https://api.github.com/users/goldmanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goldmanm/subscriptions","organizations_url":"https://api.github.com/users/goldmanm/orgs","repos_url":"https://api.github.com/users/goldmanm/repos","events_url":"https://api.github.com/users/goldmanm/events{/privacy}","received_events_url":"https://api.github.com/users/goldmanm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-28T16:01:25Z","updated_at":"2018-06-28T16:55:52Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ReactionMechanismGenerator/RMG-Py/pulls/1412","html_url":"https://github.com/ReactionMechanismGenerator/RMG-Py/pull/1412","diff_url":"https://github.com/ReactionMechanismGenerator/RMG-Py/pull/1412.diff","patch_url":"https://github.com/ReactionMechanismGenerator/RMG-Py/pull/1412.patch"},"body":"\r\n### Motivation or Problem\r\nmethods missing deprecation messages\r\n\r\n### Description of Changes\r\nadded deprecation messages to:\r\n\r\n* save restart period\r\n* RMG-Java reading/writing\r\n* old adjacency lists \r\n* group additivity\r\n* rxn.label\r\n\r\nremoved method with 8 month old deprecation warning, `filter_reactions`.\r\n\r\n### Testing\r\nI have not tested this branch yet. Will see what travis tests say.\r\n\r\n### Reviewer Tips\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/ReactionMechanismGenerator/RMG-Py/issues/comments/401102899","html_url":"https://github.com/ReactionMechanismGenerator/RMG-Py/pull/1412#issuecomment-401102899","issue_url":"https://api.github.com/repos/ReactionMechanismGenerator/RMG-Py/issues/1412","id":401102899,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTEwMjg5OQ==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-06-28T16:55:52Z","updated_at":"2018-06-28T16:55:52Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/ReactionMechanismGenerator/RMG-Py/pull/1412?src=pr&el=h1) Report\n> Merging [#1412](https://codecov.io/gh/ReactionMechanismGenerator/RMG-Py/pull/1412?src=pr&el=desc) into [master](https://codecov.io/gh/ReactionMechanismGenerator/RMG-Py/commit/71573c56ddf7ccfc070971a85950eac51a3d44a8?src=pr&el=desc) will **decrease** coverage by `0.06%`.\n> The diff coverage is `32.35%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/ReactionMechanismGenerator/RMG-Py/pull/1412/graphs/tree.svg?width=650&height=150&src=pr&token=46tMSOgPOU)](https://codecov.io/gh/ReactionMechanismGenerator/RMG-Py/pull/1412?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master    #1412      +/-   ##\n==========================================\n- Coverage   41.47%   41.41%   -0.07%     \n==========================================\n  Files         178      178              \n  Lines       30224    30222       -2     \n  Branches     6085     6073      -12     \n==========================================\n- Hits        12536    12517      -19     \n- Misses      16829    16847      +18     \n+ Partials      859      858       -1\n```\n\n\n| [Impacted Files](https://codecov.io/gh/ReactionMechanismGenerator/RMG-Py/pull/1412?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [rmgpy/data/kinetics/common.py](https://codecov.io/gh/ReactionMechanismGenerator/RMG-Py/pull/1412/diff?src=pr&el=tree#diff-cm1ncHkvZGF0YS9raW5ldGljcy9jb21tb24ucHk=) | `68.89% <ø> (-4.47%)` | :arrow_down: |\n| [rmgpy/molecule/inchi.py](https://codecov.io/gh/ReactionMechanismGenerator/RMG-Py/pull/1412/diff?src=pr&el=tree#diff-cm1ncHkvbW9sZWN1bGUvaW5jaGkucHk=) | `0% <0%> (ø)` | :arrow_up: |\n| [rmgpy/reaction.py](https://codecov.io/gh/ReactionMechanismGenerator/RMG-Py/pull/1412/diff?src=pr&el=tree#diff-cm1ncHkvcmVhY3Rpb24ucHk=) | `0% <0%> (ø)` | :arrow_up: |\n| [rmgpy/molecule/adjlist.py](https://codecov.io/gh/ReactionMechanismGenerator/RMG-Py/pull/1412/diff?src=pr&el=tree#diff-cm1ncHkvbW9sZWN1bGUvYWRqbGlzdC5weQ==) | `75.57% <100%> (+0.07%)` | :arrow_up: |\n| [rmgpy/restart.py](https://codecov.io/gh/ReactionMechanismGenerator/RMG-Py/pull/1412/diff?src=pr&el=tree#diff-cm1ncHkvcmVzdGFydC5weQ==) | `65.62% <100%> (+2.29%)` | :arrow_up: |\n| [rmgpy/data/kinetics/family.py](https://codecov.io/gh/ReactionMechanismGenerator/RMG-Py/pull/1412/diff?src=pr&el=tree#diff-cm1ncHkvZGF0YS9raW5ldGljcy9mYW1pbHkucHk=) | `62.39% <16.66%> (+0.14%)` | :arrow_up: |\n| [rmgpy/data/kinetics/rules.py](https://codecov.io/gh/ReactionMechanismGenerator/RMG-Py/pull/1412/diff?src=pr&el=tree#diff-cm1ncHkvZGF0YS9raW5ldGljcy9ydWxlcy5weQ==) | `53.45% <20%> (-0.46%)` | :arrow_down: |\n| [rmgpy/rmg/main.py](https://codecov.io/gh/ReactionMechanismGenerator/RMG-Py/pull/1412/diff?src=pr&el=tree#diff-cm1ncHkvcm1nL21haW4ucHk=) | `22.43% <25%> (ø)` | :arrow_up: |\n| [rmgpy/tools/fluxdiagram.py](https://codecov.io/gh/ReactionMechanismGenerator/RMG-Py/pull/1412/diff?src=pr&el=tree#diff-cm1ncHkvdG9vbHMvZmx1eGRpYWdyYW0ucHk=) | `9.67% <33.33%> (+0.2%)` | :arrow_up: |\n| [rmgpy/data/kinetics/groups.py](https://codecov.io/gh/ReactionMechanismGenerator/RMG-Py/pull/1412/diff?src=pr&el=tree#diff-cm1ncHkvZGF0YS9raW5ldGljcy9ncm91cHMucHk=) | `19.36% <33.33%> (+0.13%)` | :arrow_up: |\n| ... and [3 more](https://codecov.io/gh/ReactionMechanismGenerator/RMG-Py/pull/1412/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/ReactionMechanismGenerator/RMG-Py/pull/1412?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/ReactionMechanismGenerator/RMG-Py/pull/1412?src=pr&el=footer). Last update [71573c5...f7a31e8](https://codecov.io/gh/ReactionMechanismGenerator/RMG-Py/pull/1412?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}