{"action":"created","issue":{"url":"https://api.github.com/repos/tendermint/tendermint/issues/2791","repository_url":"https://api.github.com/repos/tendermint/tendermint","labels_url":"https://api.github.com/repos/tendermint/tendermint/issues/2791/labels{/name}","comments_url":"https://api.github.com/repos/tendermint/tendermint/issues/2791/comments","events_url":"https://api.github.com/repos/tendermint/tendermint/issues/2791/events","html_url":"https://github.com/tendermint/tendermint/pull/2791","id":379170760,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NzAwNzY0","number":2791,"title":"Decouple StartHTTP{,AndTLS}Server from Listen()","user":{"login":"alessio","id":229356,"node_id":"MDQ6VXNlcjIyOTM1Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/229356?v=4","gravatar_id":"","url":"https://api.github.com/users/alessio","html_url":"https://github.com/alessio","followers_url":"https://api.github.com/users/alessio/followers","following_url":"https://api.github.com/users/alessio/following{/other_user}","gists_url":"https://api.github.com/users/alessio/gists{/gist_id}","starred_url":"https://api.github.com/users/alessio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alessio/subscriptions","organizations_url":"https://api.github.com/users/alessio/orgs","repos_url":"https://api.github.com/users/alessio/repos","events_url":"https://api.github.com/users/alessio/events{/privacy}","received_events_url":"https://api.github.com/users/alessio/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-11-09T13:54:30Z","updated_at":"2018-11-12T14:14:40Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/tendermint/tendermint/pulls/2791","html_url":"https://github.com/tendermint/tendermint/pull/2791","diff_url":"https://github.com/tendermint/tendermint/pull/2791.diff","patch_url":"https://github.com/tendermint/tendermint/pull/2791.patch"},"body":"This should help solve cosmos/cosmos-sdk#2715\r\n\r\n* [ ] Updated all relevant documentation in docs\r\n* [ ] Updated all code comments where relevant\r\n* [ ] Wrote tests\r\n* [ ] Updated CHANGELOG_PENDING.md\r\n"},"comment":{"url":"https://api.github.com/repos/tendermint/tendermint/issues/comments/437896127","html_url":"https://github.com/tendermint/tendermint/pull/2791#issuecomment-437896127","issue_url":"https://api.github.com/repos/tendermint/tendermint/issues/2791","id":437896127,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzg5NjEyNw==","user":{"login":"ebuchman","id":2300911,"node_id":"MDQ6VXNlcjIzMDA5MTE=","avatar_url":"https://avatars3.githubusercontent.com/u/2300911?v=4","gravatar_id":"","url":"https://api.github.com/users/ebuchman","html_url":"https://github.com/ebuchman","followers_url":"https://api.github.com/users/ebuchman/followers","following_url":"https://api.github.com/users/ebuchman/following{/other_user}","gists_url":"https://api.github.com/users/ebuchman/gists{/gist_id}","starred_url":"https://api.github.com/users/ebuchman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebuchman/subscriptions","organizations_url":"https://api.github.com/users/ebuchman/orgs","repos_url":"https://api.github.com/users/ebuchman/repos","events_url":"https://api.github.com/users/ebuchman/events{/privacy}","received_events_url":"https://api.github.com/users/ebuchman/received_events","type":"User","site_admin":false},"created_at":"2018-11-12T14:14:40Z","updated_at":"2018-11-12T14:14:40Z","author_association":"CONTRIBUTOR","body":"> we should have an error channel IMO\r\n\r\nSounds right, but we can't just block on it. I guess it should be part of the shut-down sequence to catch that error. Only question is, if the error is from the startup phase, how do we catch it? \r\n\r\nMaybe we should open a new issue for this"}}
{"actor":{"display_login":"ebuchman"}}