{"action":"created","issue":{"url":"https://api.github.com/repos/OP-TEE/optee_os/issues/1885","repository_url":"https://api.github.com/repos/OP-TEE/optee_os","labels_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/1885/labels{/name}","comments_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/1885/comments","events_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/1885/events","html_url":"https://github.com/OP-TEE/optee_os/pull/1885","id":265972440,"number":1885,"title":"[RFC] Support mbedTLS crypto library","user":{"login":"edison-ai","id":27393575,"avatar_url":"https://avatars0.githubusercontent.com/u/27393575?v=4","gravatar_id":"","url":"https://api.github.com/users/edison-ai","html_url":"https://github.com/edison-ai","followers_url":"https://api.github.com/users/edison-ai/followers","following_url":"https://api.github.com/users/edison-ai/following{/other_user}","gists_url":"https://api.github.com/users/edison-ai/gists{/gist_id}","starred_url":"https://api.github.com/users/edison-ai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edison-ai/subscriptions","organizations_url":"https://api.github.com/users/edison-ai/orgs","repos_url":"https://api.github.com/users/edison-ai/repos","events_url":"https://api.github.com/users/edison-ai/events{/privacy}","received_events_url":"https://api.github.com/users/edison-ai/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":36,"created_at":"2017-10-17T02:25:43Z","updated_at":"2018-05-03T05:33:22Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/1885","html_url":"https://github.com/OP-TEE/optee_os/pull/1885","diff_url":"https://github.com/OP-TEE/optee_os/pull/1885.diff","patch_url":"https://github.com/OP-TEE/optee_os/pull/1885.patch"},"body":"Support mbedTLS crypto library:\r\n1. Add new flag to support multiple cryptolibs.\r\n2. Support mbedTLS hash algo.\r\n\r\nFor all algos except for hash are set to NULL, so optee cannot bring up until the MAC is implemented. "},"comment":{"url":"https://api.github.com/repos/OP-TEE/optee_os/issues/comments/386195325","html_url":"https://github.com/OP-TEE/optee_os/pull/1885#issuecomment-386195325","issue_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/1885","id":386195325,"user":{"login":"edison-ai","id":27393575,"avatar_url":"https://avatars0.githubusercontent.com/u/27393575?v=4","gravatar_id":"","url":"https://api.github.com/users/edison-ai","html_url":"https://github.com/edison-ai","followers_url":"https://api.github.com/users/edison-ai/followers","following_url":"https://api.github.com/users/edison-ai/following{/other_user}","gists_url":"https://api.github.com/users/edison-ai/gists{/gist_id}","starred_url":"https://api.github.com/users/edison-ai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edison-ai/subscriptions","organizations_url":"https://api.github.com/users/edison-ai/orgs","repos_url":"https://api.github.com/users/edison-ai/repos","events_url":"https://api.github.com/users/edison-ai/events{/privacy}","received_events_url":"https://api.github.com/users/edison-ai/received_events","type":"User","site_admin":false},"created_at":"2018-05-03T05:33:22Z","updated_at":"2018-05-03T05:33:22Z","author_association":"NONE","body":"`adding a CFG_CORE_MBEDTLS to override the default values in CFG_CRYPTOLIB_NAME and CFG_CRYPTOLIB_DIR`\r\nIt may be some complex if we support more than 3 crypto libraries. We need add macro such as `CFG_CORE_XXX` for each crypto library. And we need to check if some of the crypto are enabled at same time in makefile.\r\nSo I think it will be better to use a configure macro like `CFG_CRYPTOLIB_TYPE`(`WITH_CRYPTO` in my patch), the `type` could be tomcrypt, mbedtls, crytocell or others. If you think the `CFG_CRYPTOLIB_NAME` and `CFG_CRYPTOLIB_DIR` are useful, I can use them too. What do you think?\r\n\r\nI will clean up all patches as far as possible. \r\n"}}
{"actor":{"display_login":"edison-ai"}}