{"action":"created","comment":{"url":"https://api.github.com/repos/arangodb/arangodb/pulls/comments/199409478","pull_request_review_id":133521284,"id":199409478,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTQwOTQ3OA==","diff_hunk":"@@ -153,3 +153,14 @@ std::string const StaticStrings::MimeTypeText(\"text/plain; charset=utf-8\");\n std::string const StaticStrings::MimeTypeVPack(\"application/x-velocypack\");\n std::string const StaticStrings::MultiPartContentType(\"multipart/form-data\");\n \n+// graph attribute names\n+std::string const StaticStrings::GraphCollection(\"_graphs\");\n+std::string const StaticStrings::GraphIsSmart(\"isSmart\");\n+std::string const StaticStrings::GraphFrom(\"from\");\n+std::string const StaticStrings::GraphTo(\"to\");\n+std::string const StaticStrings::GraphSmartGraphAttribute(\"smartGraphAttribute\");\n+std::string const StaticStrings::GraphNumberOfShards(\"numberOfShards\");\n+std::string const StaticStrings::GraphReplicationFactor(\"replicationFactor\");","path":"lib/Basics/StaticStrings.cpp","position":11,"original_position":11,"commit_id":"436dafb842bcaab6eab913668babcc7fcaf5d2af","original_commit_id":"436dafb842bcaab6eab913668babcc7fcaf5d2af","user":{"login":"jsteemann","id":1423118,"node_id":"MDQ6VXNlcjE0MjMxMTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1423118?v=4","gravatar_id":"","url":"https://api.github.com/users/jsteemann","html_url":"https://github.com/jsteemann","followers_url":"https://api.github.com/users/jsteemann/followers","following_url":"https://api.github.com/users/jsteemann/following{/other_user}","gists_url":"https://api.github.com/users/jsteemann/gists{/gist_id}","starred_url":"https://api.github.com/users/jsteemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsteemann/subscriptions","organizations_url":"https://api.github.com/users/jsteemann/orgs","repos_url":"https://api.github.com/users/jsteemann/repos","events_url":"https://api.github.com/users/jsteemann/events{/privacy}","received_events_url":"https://api.github.com/users/jsteemann/received_events","type":"User","site_admin":false},"body":"Please do not prefix these strings with \"Graph...\" because they are also used outside the graph business.\r\nAffects at least \"replicationFactor\" and \"numberOfShards\".","created_at":"2018-07-02T07:48:43Z","updated_at":"2018-07-02T08:04:18Z","html_url":"https://github.com/arangodb/arangodb/pull/5631#discussion_r199409478","pull_request_url":"https://api.github.com/repos/arangodb/arangodb/pulls/5631","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/arangodb/arangodb/pulls/comments/199409478"},"html":{"href":"https://github.com/arangodb/arangodb/pull/5631#discussion_r199409478"},"pull_request":{"href":"https://api.github.com/repos/arangodb/arangodb/pulls/5631"}}},"pull_request":{"url":"https://api.github.com/repos/arangodb/arangodb/pulls/5631","id":195813083,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1ODEzMDgz","html_url":"https://github.com/arangodb/arangodb/pull/5631","diff_url":"https://github.com/arangodb/arangodb/pull/5631.diff","patch_url":"https://github.com/arangodb/arangodb/pull/5631.patch","issue_url":"https://api.github.com/repos/arangodb/arangodb/issues/5631","number":5631,"state":"open","locked":false,"title":"Gharial rewrite in C++","user":{"login":"goedderz","id":11504143,"node_id":"MDQ6VXNlcjExNTA0MTQz","avatar_url":"https://avatars3.githubusercontent.com/u/11504143?v=4","gravatar_id":"","url":"https://api.github.com/users/goedderz","html_url":"https://github.com/goedderz","followers_url":"https://api.github.com/users/goedderz/followers","following_url":"https://api.github.com/users/goedderz/following{/other_user}","gists_url":"https://api.github.com/users/goedderz/gists{/gist_id}","starred_url":"https://api.github.com/users/goedderz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goedderz/subscriptions","organizations_url":"https://api.github.com/users/goedderz/orgs","repos_url":"https://api.github.com/users/goedderz/repos","events_url":"https://api.github.com/users/goedderz/events{/privacy}","received_events_url":"https://api.github.com/users/goedderz/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-19T12:39:39Z","updated_at":"2018-07-02T08:04:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"253334e1f7a1149da37a063c103ee2cf50723ecc","assignee":{"login":"hkernbach","id":1244163,"node_id":"MDQ6VXNlcjEyNDQxNjM=","avatar_url":"https://avatars1.githubusercontent.com/u/1244163?v=4","gravatar_id":"","url":"https://api.github.com/users/hkernbach","html_url":"https://github.com/hkernbach","followers_url":"https://api.github.com/users/hkernbach/followers","following_url":"https://api.github.com/users/hkernbach/following{/other_user}","gists_url":"https://api.github.com/users/hkernbach/gists{/gist_id}","starred_url":"https://api.github.com/users/hkernbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkernbach/subscriptions","organizations_url":"https://api.github.com/users/hkernbach/orgs","repos_url":"https://api.github.com/users/hkernbach/repos","events_url":"https://api.github.com/users/hkernbach/events{/privacy}","received_events_url":"https://api.github.com/users/hkernbach/received_events","type":"User","site_admin":false},"assignees":[{"login":"hkernbach","id":1244163,"node_id":"MDQ6VXNlcjEyNDQxNjM=","avatar_url":"https://avatars1.githubusercontent.com/u/1244163?v=4","gravatar_id":"","url":"https://api.github.com/users/hkernbach","html_url":"https://github.com/hkernbach","followers_url":"https://api.github.com/users/hkernbach/followers","following_url":"https://api.github.com/users/hkernbach/following{/other_user}","gists_url":"https://api.github.com/users/hkernbach/gists{/gist_id}","starred_url":"https://api.github.com/users/hkernbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkernbach/subscriptions","organizations_url":"https://api.github.com/users/hkernbach/orgs","repos_url":"https://api.github.com/users/hkernbach/repos","events_url":"https://api.github.com/users/hkernbach/events{/privacy}","received_events_url":"https://api.github.com/users/hkernbach/received_events","type":"User","site_admin":false},{"login":"goedderz","id":11504143,"node_id":"MDQ6VXNlcjExNTA0MTQz","avatar_url":"https://avatars3.githubusercontent.com/u/11504143?v=4","gravatar_id":"","url":"https://api.github.com/users/goedderz","html_url":"https://github.com/goedderz","followers_url":"https://api.github.com/users/goedderz/followers","following_url":"https://api.github.com/users/goedderz/following{/other_user}","gists_url":"https://api.github.com/users/goedderz/gists{/gist_id}","starred_url":"https://api.github.com/users/goedderz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goedderz/subscriptions","organizations_url":"https://api.github.com/users/goedderz/orgs","repos_url":"https://api.github.com/users/goedderz/repos","events_url":"https://api.github.com/users/goedderz/events{/privacy}","received_events_url":"https://api.github.com/users/goedderz/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":4539382,"node_id":"MDU6TGFiZWw0NTM5Mzgy","url":"https://api.github.com/repos/arangodb/arangodb/labels/1%20Feature","name":"1 Feature","color":"02e10c","default":false},{"id":961091834,"node_id":"MDU6TGFiZWw5NjEwOTE4MzQ=","url":"https://api.github.com/repos/arangodb/arangodb/labels/2%20-%20Working","name":"2 - Working","color":"CCCCCC","default":false},{"id":27652234,"node_id":"MDU6TGFiZWwyNzY1MjIzNA==","url":"https://api.github.com/repos/arangodb/arangodb/labels/3%20Graph","name":"3 Graph","color":"f9d0c4","default":false},{"id":628825640,"node_id":"MDU6TGFiZWw2Mjg4MjU2NDA=","url":"https://api.github.com/repos/arangodb/arangodb/labels/9%20WIP","name":"9 WIP","color":"1d76db","default":false}],"milestone":{"url":"https://api.github.com/repos/arangodb/arangodb/milestones/82","html_url":"https://github.com/arangodb/arangodb/milestone/82","labels_url":"https://api.github.com/repos/arangodb/arangodb/milestones/82/labels","id":2963125,"node_id":"MDk6TWlsZXN0b25lMjk2MzEyNQ==","number":82,"title":"devel","description":null,"creator":{"login":"fceller","id":392005,"node_id":"MDQ6VXNlcjM5MjAwNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/392005?v=4","gravatar_id":"","url":"https://api.github.com/users/fceller","html_url":"https://github.com/fceller","followers_url":"https://api.github.com/users/fceller/followers","following_url":"https://api.github.com/users/fceller/following{/other_user}","gists_url":"https://api.github.com/users/fceller/gists{/gist_id}","starred_url":"https://api.github.com/users/fceller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fceller/subscriptions","organizations_url":"https://api.github.com/users/fceller/orgs","repos_url":"https://api.github.com/users/fceller/repos","events_url":"https://api.github.com/users/fceller/events{/privacy}","received_events_url":"https://api.github.com/users/fceller/received_events","type":"User","site_admin":false},"open_issues":46,"closed_issues":502,"state":"open","created_at":"2017-12-06T23:27:12Z","updated_at":"2018-06-30T09:11:57Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/arangodb/arangodb/pulls/5631/commits","review_comments_url":"https://api.github.com/repos/arangodb/arangodb/pulls/5631/comments","review_comment_url":"https://api.github.com/repos/arangodb/arangodb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/arangodb/arangodb/issues/5631/comments","statuses_url":"https://api.github.com/repos/arangodb/arangodb/statuses/436dafb842bcaab6eab913668babcc7fcaf5d2af","head":{"label":"arangodb:feature/graph-cpp","ref":"feature/graph-cpp","sha":"436dafb842bcaab6eab913668babcc7fcaf5d2af","user":{"login":"arangodb","id":5547849,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1NDc4NDk=","avatar_url":"https://avatars0.githubusercontent.com/u/5547849?v=4","gravatar_id":"","url":"https://api.github.com/users/arangodb","html_url":"https://github.com/arangodb","followers_url":"https://api.github.com/users/arangodb/followers","following_url":"https://api.github.com/users/arangodb/following{/other_user}","gists_url":"https://api.github.com/users/arangodb/gists{/gist_id}","starred_url":"https://api.github.com/users/arangodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arangodb/subscriptions","organizations_url":"https://api.github.com/users/arangodb/orgs","repos_url":"https://api.github.com/users/arangodb/repos","events_url":"https://api.github.com/users/arangodb/events{/privacy}","received_events_url":"https://api.github.com/users/arangodb/received_events","type":"Organization","site_admin":false},"repo":{"id":2649214,"node_id":"MDEwOlJlcG9zaXRvcnkyNjQ5MjE0","name":"arangodb","full_name":"arangodb/arangodb","owner":{"login":"arangodb","id":5547849,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1NDc4NDk=","avatar_url":"https://avatars0.githubusercontent.com/u/5547849?v=4","gravatar_id":"","url":"https://api.github.com/users/arangodb","html_url":"https://github.com/arangodb","followers_url":"https://api.github.com/users/arangodb/followers","following_url":"https://api.github.com/users/arangodb/following{/other_user}","gists_url":"https://api.github.com/users/arangodb/gists{/gist_id}","starred_url":"https://api.github.com/users/arangodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arangodb/subscriptions","organizations_url":"https://api.github.com/users/arangodb/orgs","repos_url":"https://api.github.com/users/arangodb/repos","events_url":"https://api.github.com/users/arangodb/events{/privacy}","received_events_url":"https://api.github.com/users/arangodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/arangodb/arangodb","description":"🥑 ArangoDB is a native multi-model database with flexible data models for documents, graphs, and key-values. Build high performance applications using a convenient SQL-like query language or JavaScript extensions.","fork":false,"url":"https://api.github.com/repos/arangodb/arangodb","forks_url":"https://api.github.com/repos/arangodb/arangodb/forks","keys_url":"https://api.github.com/repos/arangodb/arangodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arangodb/arangodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arangodb/arangodb/teams","hooks_url":"https://api.github.com/repos/arangodb/arangodb/hooks","issue_events_url":"https://api.github.com/repos/arangodb/arangodb/issues/events{/number}","events_url":"https://api.github.com/repos/arangodb/arangodb/events","assignees_url":"https://api.github.com/repos/arangodb/arangodb/assignees{/user}","branches_url":"https://api.github.com/repos/arangodb/arangodb/branches{/branch}","tags_url":"https://api.github.com/repos/arangodb/arangodb/tags","blobs_url":"https://api.github.com/repos/arangodb/arangodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arangodb/arangodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arangodb/arangodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/arangodb/arangodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arangodb/arangodb/statuses/{sha}","languages_url":"https://api.github.com/repos/arangodb/arangodb/languages","stargazers_url":"https://api.github.com/repos/arangodb/arangodb/stargazers","contributors_url":"https://api.github.com/repos/arangodb/arangodb/contributors","subscribers_url":"https://api.github.com/repos/arangodb/arangodb/subscribers","subscription_url":"https://api.github.com/repos/arangodb/arangodb/subscription","commits_url":"https://api.github.com/repos/arangodb/arangodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/arangodb/arangodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/arangodb/arangodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/arangodb/arangodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/arangodb/arangodb/contents/{+path}","compare_url":"https://api.github.com/repos/arangodb/arangodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arangodb/arangodb/merges","archive_url":"https://api.github.com/repos/arangodb/arangodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arangodb/arangodb/downloads","issues_url":"https://api.github.com/repos/arangodb/arangodb/issues{/number}","pulls_url":"https://api.github.com/repos/arangodb/arangodb/pulls{/number}","milestones_url":"https://api.github.com/repos/arangodb/arangodb/milestones{/number}","notifications_url":"https://api.github.com/repos/arangodb/arangodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arangodb/arangodb/labels{/name}","releases_url":"https://api.github.com/repos/arangodb/arangodb/releases{/id}","deployments_url":"https://api.github.com/repos/arangodb/arangodb/deployments","created_at":"2011-10-26T06:42:00Z","updated_at":"2018-07-02T07:57:40Z","pushed_at":"2018-06-30T11:23:03Z","git_url":"git://github.com/arangodb/arangodb.git","ssh_url":"git@github.com:arangodb/arangodb.git","clone_url":"https://github.com/arangodb/arangodb.git","svn_url":"https://github.com/arangodb/arangodb","homepage":"https://www.arangodb.com","size":802858,"stargazers_count":5856,"watchers_count":5856,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":433,"mirror_url":null,"archived":false,"open_issues_count":440,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":433,"open_issues":440,"watchers":5856,"default_branch":"devel"}},"base":{"label":"arangodb:devel","ref":"devel","sha":"ef6a70255b2ee95690746035965ee021e348e94c","user":{"login":"arangodb","id":5547849,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1NDc4NDk=","avatar_url":"https://avatars0.githubusercontent.com/u/5547849?v=4","gravatar_id":"","url":"https://api.github.com/users/arangodb","html_url":"https://github.com/arangodb","followers_url":"https://api.github.com/users/arangodb/followers","following_url":"https://api.github.com/users/arangodb/following{/other_user}","gists_url":"https://api.github.com/users/arangodb/gists{/gist_id}","starred_url":"https://api.github.com/users/arangodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arangodb/subscriptions","organizations_url":"https://api.github.com/users/arangodb/orgs","repos_url":"https://api.github.com/users/arangodb/repos","events_url":"https://api.github.com/users/arangodb/events{/privacy}","received_events_url":"https://api.github.com/users/arangodb/received_events","type":"Organization","site_admin":false},"repo":{"id":2649214,"node_id":"MDEwOlJlcG9zaXRvcnkyNjQ5MjE0","name":"arangodb","full_name":"arangodb/arangodb","owner":{"login":"arangodb","id":5547849,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1NDc4NDk=","avatar_url":"https://avatars0.githubusercontent.com/u/5547849?v=4","gravatar_id":"","url":"https://api.github.com/users/arangodb","html_url":"https://github.com/arangodb","followers_url":"https://api.github.com/users/arangodb/followers","following_url":"https://api.github.com/users/arangodb/following{/other_user}","gists_url":"https://api.github.com/users/arangodb/gists{/gist_id}","starred_url":"https://api.github.com/users/arangodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arangodb/subscriptions","organizations_url":"https://api.github.com/users/arangodb/orgs","repos_url":"https://api.github.com/users/arangodb/repos","events_url":"https://api.github.com/users/arangodb/events{/privacy}","received_events_url":"https://api.github.com/users/arangodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/arangodb/arangodb","description":"🥑 ArangoDB is a native multi-model database with flexible data models for documents, graphs, and key-values. Build high performance applications using a convenient SQL-like query language or JavaScript extensions.","fork":false,"url":"https://api.github.com/repos/arangodb/arangodb","forks_url":"https://api.github.com/repos/arangodb/arangodb/forks","keys_url":"https://api.github.com/repos/arangodb/arangodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arangodb/arangodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arangodb/arangodb/teams","hooks_url":"https://api.github.com/repos/arangodb/arangodb/hooks","issue_events_url":"https://api.github.com/repos/arangodb/arangodb/issues/events{/number}","events_url":"https://api.github.com/repos/arangodb/arangodb/events","assignees_url":"https://api.github.com/repos/arangodb/arangodb/assignees{/user}","branches_url":"https://api.github.com/repos/arangodb/arangodb/branches{/branch}","tags_url":"https://api.github.com/repos/arangodb/arangodb/tags","blobs_url":"https://api.github.com/repos/arangodb/arangodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arangodb/arangodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arangodb/arangodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/arangodb/arangodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arangodb/arangodb/statuses/{sha}","languages_url":"https://api.github.com/repos/arangodb/arangodb/languages","stargazers_url":"https://api.github.com/repos/arangodb/arangodb/stargazers","contributors_url":"https://api.github.com/repos/arangodb/arangodb/contributors","subscribers_url":"https://api.github.com/repos/arangodb/arangodb/subscribers","subscription_url":"https://api.github.com/repos/arangodb/arangodb/subscription","commits_url":"https://api.github.com/repos/arangodb/arangodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/arangodb/arangodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/arangodb/arangodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/arangodb/arangodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/arangodb/arangodb/contents/{+path}","compare_url":"https://api.github.com/repos/arangodb/arangodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arangodb/arangodb/merges","archive_url":"https://api.github.com/repos/arangodb/arangodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arangodb/arangodb/downloads","issues_url":"https://api.github.com/repos/arangodb/arangodb/issues{/number}","pulls_url":"https://api.github.com/repos/arangodb/arangodb/pulls{/number}","milestones_url":"https://api.github.com/repos/arangodb/arangodb/milestones{/number}","notifications_url":"https://api.github.com/repos/arangodb/arangodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arangodb/arangodb/labels{/name}","releases_url":"https://api.github.com/repos/arangodb/arangodb/releases{/id}","deployments_url":"https://api.github.com/repos/arangodb/arangodb/deployments","created_at":"2011-10-26T06:42:00Z","updated_at":"2018-07-02T07:57:40Z","pushed_at":"2018-06-30T11:23:03Z","git_url":"git://github.com/arangodb/arangodb.git","ssh_url":"git@github.com:arangodb/arangodb.git","clone_url":"https://github.com/arangodb/arangodb.git","svn_url":"https://github.com/arangodb/arangodb","homepage":"https://www.arangodb.com","size":802858,"stargazers_count":5856,"watchers_count":5856,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":433,"mirror_url":null,"archived":false,"open_issues_count":440,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":433,"open_issues":440,"watchers":5856,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/arangodb/arangodb/pulls/5631"},"html":{"href":"https://github.com/arangodb/arangodb/pull/5631"},"issue":{"href":"https://api.github.com/repos/arangodb/arangodb/issues/5631"},"comments":{"href":"https://api.github.com/repos/arangodb/arangodb/issues/5631/comments"},"review_comments":{"href":"https://api.github.com/repos/arangodb/arangodb/pulls/5631/comments"},"review_comment":{"href":"https://api.github.com/repos/arangodb/arangodb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/arangodb/arangodb/pulls/5631/commits"},"statuses":{"href":"https://api.github.com/repos/arangodb/arangodb/statuses/436dafb842bcaab6eab913668babcc7fcaf5d2af"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jsteemann"}}