{"action":"opened","number":1261,"pull_request":{"url":"https://api.github.com/repos/Tencent/rapidjson/pulls/1261","id":188306677,"html_url":"https://github.com/Tencent/rapidjson/pull/1261","diff_url":"https://github.com/Tencent/rapidjson/pull/1261.diff","patch_url":"https://github.com/Tencent/rapidjson/pull/1261.patch","issue_url":"https://api.github.com/repos/Tencent/rapidjson/issues/1261","number":1261,"state":"open","locked":false,"title":"Prevent int underflow when parsing exponents","user":{"login":"fmalita","id":237449,"avatar_url":"https://avatars2.githubusercontent.com/u/237449?v=4","gravatar_id":"","url":"https://api.github.com/users/fmalita","html_url":"https://github.com/fmalita","followers_url":"https://api.github.com/users/fmalita/followers","following_url":"https://api.github.com/users/fmalita/following{/other_user}","gists_url":"https://api.github.com/users/fmalita/gists{/gist_id}","starred_url":"https://api.github.com/users/fmalita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmalita/subscriptions","organizations_url":"https://api.github.com/users/fmalita/orgs","repos_url":"https://api.github.com/users/fmalita/repos","events_url":"https://api.github.com/users/fmalita/events{/privacy}","received_events_url":"https://api.github.com/users/fmalita/received_events","type":"User","site_admin":false},"body":"When parsing negative exponents, the current implementation takes\r\nprecautions for |exp| to not underflow int.\r\n\r\nBut that is not sufficient: later on [1], |exp + expFrac| is also\r\nstored to an int - so we must ensure that the sum stays within int\r\nrepresentable values.\r\n\r\nUpdate the exp clamping logic to take expFrac into account.\r\n\r\n[1] https://github.com/Tencent/rapidjson/blob/master/include/rapidjson/reader.h#L1690","created_at":"2018-05-16T02:58:56Z","updated_at":"2018-05-16T02:58:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Tencent/rapidjson/pulls/1261/commits","review_comments_url":"https://api.github.com/repos/Tencent/rapidjson/pulls/1261/comments","review_comment_url":"https://api.github.com/repos/Tencent/rapidjson/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Tencent/rapidjson/issues/1261/comments","statuses_url":"https://api.github.com/repos/Tencent/rapidjson/statuses/8269bc2bc289e9d343bae51cdf6d23ef0950e001","head":{"label":"fmalita:exponent-underflow","ref":"exponent-underflow","sha":"8269bc2bc289e9d343bae51cdf6d23ef0950e001","user":{"login":"fmalita","id":237449,"avatar_url":"https://avatars2.githubusercontent.com/u/237449?v=4","gravatar_id":"","url":"https://api.github.com/users/fmalita","html_url":"https://github.com/fmalita","followers_url":"https://api.github.com/users/fmalita/followers","following_url":"https://api.github.com/users/fmalita/following{/other_user}","gists_url":"https://api.github.com/users/fmalita/gists{/gist_id}","starred_url":"https://api.github.com/users/fmalita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmalita/subscriptions","organizations_url":"https://api.github.com/users/fmalita/orgs","repos_url":"https://api.github.com/users/fmalita/repos","events_url":"https://api.github.com/users/fmalita/events{/privacy}","received_events_url":"https://api.github.com/users/fmalita/received_events","type":"User","site_admin":false},"repo":{"id":133522971,"name":"rapidjson","full_name":"fmalita/rapidjson","owner":{"login":"fmalita","id":237449,"avatar_url":"https://avatars2.githubusercontent.com/u/237449?v=4","gravatar_id":"","url":"https://api.github.com/users/fmalita","html_url":"https://github.com/fmalita","followers_url":"https://api.github.com/users/fmalita/followers","following_url":"https://api.github.com/users/fmalita/following{/other_user}","gists_url":"https://api.github.com/users/fmalita/gists{/gist_id}","starred_url":"https://api.github.com/users/fmalita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmalita/subscriptions","organizations_url":"https://api.github.com/users/fmalita/orgs","repos_url":"https://api.github.com/users/fmalita/repos","events_url":"https://api.github.com/users/fmalita/events{/privacy}","received_events_url":"https://api.github.com/users/fmalita/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fmalita/rapidjson","description":"A fast JSON parser/generator for C++ with both SAX/DOM style API","fork":true,"url":"https://api.github.com/repos/fmalita/rapidjson","forks_url":"https://api.github.com/repos/fmalita/rapidjson/forks","keys_url":"https://api.github.com/repos/fmalita/rapidjson/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fmalita/rapidjson/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fmalita/rapidjson/teams","hooks_url":"https://api.github.com/repos/fmalita/rapidjson/hooks","issue_events_url":"https://api.github.com/repos/fmalita/rapidjson/issues/events{/number}","events_url":"https://api.github.com/repos/fmalita/rapidjson/events","assignees_url":"https://api.github.com/repos/fmalita/rapidjson/assignees{/user}","branches_url":"https://api.github.com/repos/fmalita/rapidjson/branches{/branch}","tags_url":"https://api.github.com/repos/fmalita/rapidjson/tags","blobs_url":"https://api.github.com/repos/fmalita/rapidjson/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fmalita/rapidjson/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fmalita/rapidjson/git/refs{/sha}","trees_url":"https://api.github.com/repos/fmalita/rapidjson/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fmalita/rapidjson/statuses/{sha}","languages_url":"https://api.github.com/repos/fmalita/rapidjson/languages","stargazers_url":"https://api.github.com/repos/fmalita/rapidjson/stargazers","contributors_url":"https://api.github.com/repos/fmalita/rapidjson/contributors","subscribers_url":"https://api.github.com/repos/fmalita/rapidjson/subscribers","subscription_url":"https://api.github.com/repos/fmalita/rapidjson/subscription","commits_url":"https://api.github.com/repos/fmalita/rapidjson/commits{/sha}","git_commits_url":"https://api.github.com/repos/fmalita/rapidjson/git/commits{/sha}","comments_url":"https://api.github.com/repos/fmalita/rapidjson/comments{/number}","issue_comment_url":"https://api.github.com/repos/fmalita/rapidjson/issues/comments{/number}","contents_url":"https://api.github.com/repos/fmalita/rapidjson/contents/{+path}","compare_url":"https://api.github.com/repos/fmalita/rapidjson/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fmalita/rapidjson/merges","archive_url":"https://api.github.com/repos/fmalita/rapidjson/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fmalita/rapidjson/downloads","issues_url":"https://api.github.com/repos/fmalita/rapidjson/issues{/number}","pulls_url":"https://api.github.com/repos/fmalita/rapidjson/pulls{/number}","milestones_url":"https://api.github.com/repos/fmalita/rapidjson/milestones{/number}","notifications_url":"https://api.github.com/repos/fmalita/rapidjson/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fmalita/rapidjson/labels{/name}","releases_url":"https://api.github.com/repos/fmalita/rapidjson/releases{/id}","deployments_url":"https://api.github.com/repos/fmalita/rapidjson/deployments","created_at":"2018-05-15T13:48:46Z","updated_at":"2018-05-15T13:48:49Z","pushed_at":"2018-05-16T02:55:49Z","git_url":"git://github.com/fmalita/rapidjson.git","ssh_url":"git@github.com:fmalita/rapidjson.git","clone_url":"https://github.com/fmalita/rapidjson.git","svn_url":"https://github.com/fmalita/rapidjson","homepage":"http://rapidjson.org/","size":23858,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Tencent:master","ref":"master","sha":"a0910358467432b9b3dee5ad57fe05075fe49b8f","user":{"login":"Tencent","id":18461506,"avatar_url":"https://avatars3.githubusercontent.com/u/18461506?v=4","gravatar_id":"","url":"https://api.github.com/users/Tencent","html_url":"https://github.com/Tencent","followers_url":"https://api.github.com/users/Tencent/followers","following_url":"https://api.github.com/users/Tencent/following{/other_user}","gists_url":"https://api.github.com/users/Tencent/gists{/gist_id}","starred_url":"https://api.github.com/users/Tencent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tencent/subscriptions","organizations_url":"https://api.github.com/users/Tencent/orgs","repos_url":"https://api.github.com/users/Tencent/repos","events_url":"https://api.github.com/users/Tencent/events{/privacy}","received_events_url":"https://api.github.com/users/Tencent/received_events","type":"Organization","site_admin":false},"repo":{"id":17391973,"name":"rapidjson","full_name":"Tencent/rapidjson","owner":{"login":"Tencent","id":18461506,"avatar_url":"https://avatars3.githubusercontent.com/u/18461506?v=4","gravatar_id":"","url":"https://api.github.com/users/Tencent","html_url":"https://github.com/Tencent","followers_url":"https://api.github.com/users/Tencent/followers","following_url":"https://api.github.com/users/Tencent/following{/other_user}","gists_url":"https://api.github.com/users/Tencent/gists{/gist_id}","starred_url":"https://api.github.com/users/Tencent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tencent/subscriptions","organizations_url":"https://api.github.com/users/Tencent/orgs","repos_url":"https://api.github.com/users/Tencent/repos","events_url":"https://api.github.com/users/Tencent/events{/privacy}","received_events_url":"https://api.github.com/users/Tencent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Tencent/rapidjson","description":"A fast JSON parser/generator for C++ with both SAX/DOM style API","fork":false,"url":"https://api.github.com/repos/Tencent/rapidjson","forks_url":"https://api.github.com/repos/Tencent/rapidjson/forks","keys_url":"https://api.github.com/repos/Tencent/rapidjson/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tencent/rapidjson/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tencent/rapidjson/teams","hooks_url":"https://api.github.com/repos/Tencent/rapidjson/hooks","issue_events_url":"https://api.github.com/repos/Tencent/rapidjson/issues/events{/number}","events_url":"https://api.github.com/repos/Tencent/rapidjson/events","assignees_url":"https://api.github.com/repos/Tencent/rapidjson/assignees{/user}","branches_url":"https://api.github.com/repos/Tencent/rapidjson/branches{/branch}","tags_url":"https://api.github.com/repos/Tencent/rapidjson/tags","blobs_url":"https://api.github.com/repos/Tencent/rapidjson/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tencent/rapidjson/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tencent/rapidjson/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tencent/rapidjson/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tencent/rapidjson/statuses/{sha}","languages_url":"https://api.github.com/repos/Tencent/rapidjson/languages","stargazers_url":"https://api.github.com/repos/Tencent/rapidjson/stargazers","contributors_url":"https://api.github.com/repos/Tencent/rapidjson/contributors","subscribers_url":"https://api.github.com/repos/Tencent/rapidjson/subscribers","subscription_url":"https://api.github.com/repos/Tencent/rapidjson/subscription","commits_url":"https://api.github.com/repos/Tencent/rapidjson/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tencent/rapidjson/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tencent/rapidjson/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tencent/rapidjson/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tencent/rapidjson/contents/{+path}","compare_url":"https://api.github.com/repos/Tencent/rapidjson/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tencent/rapidjson/merges","archive_url":"https://api.github.com/repos/Tencent/rapidjson/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tencent/rapidjson/downloads","issues_url":"https://api.github.com/repos/Tencent/rapidjson/issues{/number}","pulls_url":"https://api.github.com/repos/Tencent/rapidjson/pulls{/number}","milestones_url":"https://api.github.com/repos/Tencent/rapidjson/milestones{/number}","notifications_url":"https://api.github.com/repos/Tencent/rapidjson/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tencent/rapidjson/labels{/name}","releases_url":"https://api.github.com/repos/Tencent/rapidjson/releases{/id}","deployments_url":"https://api.github.com/repos/Tencent/rapidjson/deployments","created_at":"2014-03-04T05:53:37Z","updated_at":"2018-05-15T21:17:13Z","pushed_at":"2018-05-15T22:00:22Z","git_url":"git://github.com/Tencent/rapidjson.git","ssh_url":"git@github.com:Tencent/rapidjson.git","clone_url":"https://github.com/Tencent/rapidjson.git","svn_url":"https://github.com/Tencent/rapidjson","homepage":"http://rapidjson.org/","size":23858,"stargazers_count":6012,"watchers_count":6012,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1764,"mirror_url":null,"archived":false,"open_issues_count":256,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1764,"open_issues":256,"watchers":6012,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Tencent/rapidjson/pulls/1261"},"html":{"href":"https://github.com/Tencent/rapidjson/pull/1261"},"issue":{"href":"https://api.github.com/repos/Tencent/rapidjson/issues/1261"},"comments":{"href":"https://api.github.com/repos/Tencent/rapidjson/issues/1261/comments"},"review_comments":{"href":"https://api.github.com/repos/Tencent/rapidjson/pulls/1261/comments"},"review_comment":{"href":"https://api.github.com/repos/Tencent/rapidjson/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Tencent/rapidjson/pulls/1261/commits"},"statuses":{"href":"https://api.github.com/repos/Tencent/rapidjson/statuses/8269bc2bc289e9d343bae51cdf6d23ef0950e001"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":11,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"fmalita"}}