{"action":"closed","issue":{"url":"https://api.github.com/repos/aowen87/BAR/issues/769","repository_url":"https://api.github.com/repos/aowen87/BAR","labels_url":"https://api.github.com/repos/aowen87/BAR/issues/769/labels{/name}","comments_url":"https://api.github.com/repos/aowen87/BAR/issues/769/comments","events_url":"https://api.github.com/repos/aowen87/BAR/issues/769/events","html_url":"https://github.com/aowen87/BAR/issues/769","id":390854126,"node_id":"MDU6SXNzdWUzOTA4NTQxMjY=","number":769,"title":"povray export shouldn't use sprintf for colortables due to locale","user":{"login":"aowen87","id":11658578,"node_id":"MDQ6VXNlcjExNjU4NTc4","avatar_url":"https://avatars0.githubusercontent.com/u/11658578?v=4","gravatar_id":"","url":"https://api.github.com/users/aowen87","html_url":"https://github.com/aowen87","followers_url":"https://api.github.com/users/aowen87/followers","following_url":"https://api.github.com/users/aowen87/following{/other_user}","gists_url":"https://api.github.com/users/aowen87/gists{/gist_id}","starred_url":"https://api.github.com/users/aowen87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aowen87/subscriptions","organizations_url":"https://api.github.com/users/aowen87/orgs","repos_url":"https://api.github.com/users/aowen87/repos","events_url":"https://api.github.com/users/aowen87/events{/privacy}","received_events_url":"https://api.github.com/users/aowen87/received_events","type":"User","site_admin":false},"labels":[{"id":1160597620,"node_id":"MDU6TGFiZWwxMTYwNTk3NjIw","url":"https://api.github.com/repos/aowen87/BAR/labels/bug","name":"bug","color":"d73a4a","default":true},{"id":1160598351,"node_id":"MDU6TGFiZWwxMTYwNTk4MzUx","url":"https://api.github.com/repos/aowen87/BAR/labels/likelihood%20medium","name":"likelihood medium","color":"003152","default":false},{"id":1160598119,"node_id":"MDU6TGFiZWwxMTYwNTk4MTE5","url":"https://api.github.com/repos/aowen87/BAR/labels/reviewed","name":"reviewed","color":"008ECC","default":false},{"id":1160598556,"node_id":"MDU6TGFiZWwxMTYwNTk4NTU2","url":"https://api.github.com/repos/aowen87/BAR/labels/severity%20low","name":"severity low","color":"0F52BA","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/aowen87/BAR/milestones/16","html_url":"https://github.com/aowen87/BAR/milestone/16","labels_url":"https://api.github.com/repos/aowen87/BAR/milestones/16/labels","id":3897359,"node_id":"MDk6TWlsZXN0b25lMzg5NzM1OQ==","number":16,"title":"2.4","description":null,"creator":{"login":"aowen87","id":11658578,"node_id":"MDQ6VXNlcjExNjU4NTc4","avatar_url":"https://avatars0.githubusercontent.com/u/11658578?v=4","gravatar_id":"","url":"https://api.github.com/users/aowen87","html_url":"https://github.com/aowen87","followers_url":"https://api.github.com/users/aowen87/followers","following_url":"https://api.github.com/users/aowen87/following{/other_user}","gists_url":"https://api.github.com/users/aowen87/gists{/gist_id}","starred_url":"https://api.github.com/users/aowen87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aowen87/subscriptions","organizations_url":"https://api.github.com/users/aowen87/orgs","repos_url":"https://api.github.com/users/aowen87/repos","events_url":"https://api.github.com/users/aowen87/events{/privacy}","received_events_url":"https://api.github.com/users/aowen87/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":28,"state":"open","created_at":"2018-12-13T17:27:10Z","updated_at":"2018-12-13T20:49:50Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-12-13T20:49:46Z","updated_at":"2018-12-13T20:49:50Z","closed_at":"2018-12-13T20:49:50Z","author_association":"OWNER","body":"original report follows:Hi, I'm toying around with the POVRay export of VisIt. I noticed that onmy system with a German locale (LANG=de_DE.UTF8) POVRay would fail toparse \"colortables.inc\" because the floats are rendered by VisIt witha \",\" as the decimal point (an ugly German quirk). The issue lies within avtDatasetFileWriter::WritePOVRayFamily(). Herethe color table gets rendered using sprintf, which takes the localeinto account. A fix would be to use for instance C' float rendering,as in the attached patch.\n\n\n\n\n\n-----------------------REDMINE MIGRATION-----------------------\nThis ticket was migrated from Redmine. As such, not all \ninformation was able to be captured in the transition. Below is\na complete record of the original redmine ticket.\n\nTicket number: 856\nStatus: Resolved\nProject: VisIt\nTracker: Bug\nPriority: Normal\nSubject: povray export shouldn't use sprintf for colortables due to locale\nAssigned to: Jeremy Meredith\nCategory: -\nTarget version: 2.4\nAuthor: Jeremy Meredith\nStart: 09/23/2011\nDue date: \n% Done: 0%\nEstimated time: \nCreated: 09/23/2011 10:39 am\nUpdated: 10/25/2011 01:24 pm\nLikelihood: 3 - Occasional\nSeverity: 2 - Minor Irritation\nFound in version: 2.3.0\nImpact: \nExpected Use: \nOS: All\nSupport Group: Any\nDescription:\n original report follows:Hi, I'm toying around with the POVRay export of VisIt. I noticed that onmy system with a German locale (LANG=de_DE.UTF8) POVRay would fail toparse \"colortables.inc\" because the floats are rendered by VisIt witha \",\" as the decimal point (an ugly German quirk). The issue lies within avtDatasetFileWriter::WritePOVRayFamily(). Herethe color table gets rendered using sprintf, which takes the localeinto account. A fix would be to use for instance C' float rendering,as in the attached patch.\n\nComments:\nI applied a change similar to what the user provided; i.e. remove the sprintf's.\n"}}
{"actor":{"display_login":"aowen87"}}