{"action":"created","issue":{"url":"https://api.github.com/repos/istio/istio/issues/6688","repository_url":"https://api.github.com/repos/istio/istio","labels_url":"https://api.github.com/repos/istio/istio/issues/6688/labels{/name}","comments_url":"https://api.github.com/repos/istio/istio/issues/6688/comments","events_url":"https://api.github.com/repos/istio/istio/issues/6688/events","html_url":"https://github.com/istio/istio/pull/6688","id":336429857,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3ODg1NDg3","number":6688,"title":"[WIP] Refactor Istio Metrics to match service->workload transition","user":{"login":"douglas-reid","id":21148125,"node_id":"MDQ6VXNlcjIxMTQ4MTI1","avatar_url":"https://avatars3.githubusercontent.com/u/21148125?v=4","gravatar_id":"","url":"https://api.github.com/users/douglas-reid","html_url":"https://github.com/douglas-reid","followers_url":"https://api.github.com/users/douglas-reid/followers","following_url":"https://api.github.com/users/douglas-reid/following{/other_user}","gists_url":"https://api.github.com/users/douglas-reid/gists{/gist_id}","starred_url":"https://api.github.com/users/douglas-reid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/douglas-reid/subscriptions","organizations_url":"https://api.github.com/users/douglas-reid/orgs","repos_url":"https://api.github.com/users/douglas-reid/repos","events_url":"https://api.github.com/users/douglas-reid/events{/privacy}","received_events_url":"https://api.github.com/users/douglas-reid/received_events","type":"User","site_admin":false},"labels":[{"id":659652351,"node_id":"MDU6TGFiZWw2NTk2NTIzNTE=","url":"https://api.github.com/repos/istio/istio/labels/approved","name":"approved","color":"bfdadc","default":false},{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false},{"id":780123031,"node_id":"MDU6TGFiZWw3ODAxMjMwMzE=","url":"https://api.github.com/repos/istio/istio/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"bfdadc","default":false},{"id":957605109,"node_id":"MDU6TGFiZWw5NTc2MDUxMDk=","url":"https://api.github.com/repos/istio/istio/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-06-28T00:10:04Z","updated_at":"2018-06-28T04:04:56Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/6688","html_url":"https://github.com/istio/istio/pull/6688","diff_url":"https://github.com/istio/istio/pull/6688.diff","patch_url":"https://github.com/istio/istio/pull/6688.patch"},"body":"/hold\r\n\r\nThis PR is a major overhaul of the default configuration for Mixer-generated Istio telemetry. It was created to address the shift away from `(source|destination).service` attributes to the workload attributes reflecting the newly-available information.\r\n\r\nIn so doing, it primarily adds the following labels to metrics:\r\n- source_name\r\n- source_namespace\r\n- source_workload\r\n- source_workload_namespace\r\n- source_principal\r\n- source_app\r\n- destination_name\r\n- destination_namespace\r\n- destination_workload\r\n- destination_workload_namespace\r\n- destination_principal\r\n- destination_app\r\n- destination_service_name\r\n- destination_service_namespace\r\n- request_protocol\r\n\r\nThis PR also removes the `source_service` label from metrics and alters the `destination_service` expression to use `destination.service.host` attribute.\r\n\r\nAs part of this cleanup, this PR also renames the default metrics according to the [Prometheus naming conventions](https://prometheus.io/docs/practices/naming/). This means a shift from `istio_request_count` to `istio_requests_total` and `istio_tcp_bytes_sent` to `istio_tcp_sent_bytes_total` for example. The renaming was done in this PR to minimize the number of PRs that affect metrics shape/schema.\r\n\r\nA number of accompanying changes must also be made in tandem with metrics changes. They include: servicegraph queries, grafana dashboards, and e2e test updates. Those changes are also included in this PR.\r\n\r\nFinally, as part of this PR, I've cleaned the config elements from `mixer/testdata/config` to enable running a local `mixs` with a bare minimum of noise and complaints about missing backends, etc. This mostly involved deleting a stale dir and moving configs back to adapter-specific directories.\r\n\r\nReviewers: once this is passing all e2e tests, I'll post screenshots of impacted user-facing components.\r\n\r\ncc: @Stono \r\n\r\n/hold"},"comment":{"url":"https://api.github.com/repos/istio/istio/issues/comments/400904297","html_url":"https://github.com/istio/istio/pull/6688#issuecomment-400904297","issue_url":"https://api.github.com/repos/istio/istio/issues/6688","id":400904297,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDkwNDI5Nw==","user":{"login":"istio-testing","id":25311884,"node_id":"MDQ6VXNlcjI1MzExODg0","avatar_url":"https://avatars1.githubusercontent.com/u/25311884?v=4","gravatar_id":"","url":"https://api.github.com/users/istio-testing","html_url":"https://github.com/istio-testing","followers_url":"https://api.github.com/users/istio-testing/followers","following_url":"https://api.github.com/users/istio-testing/following{/other_user}","gists_url":"https://api.github.com/users/istio-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/istio-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio-testing/subscriptions","organizations_url":"https://api.github.com/users/istio-testing/orgs","repos_url":"https://api.github.com/users/istio-testing/repos","events_url":"https://api.github.com/users/istio-testing/events{/privacy}","received_events_url":"https://api.github.com/users/istio-testing/received_events","type":"User","site_admin":false},"created_at":"2018-06-28T04:04:56Z","updated_at":"2018-06-28T04:04:56Z","author_association":"COLLABORATOR","body":"@douglas-reid: The following test **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nprow/istio-presubmit.sh | cc063f2295371d6340f3230c187afc79ccb7cc3d | [link](https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio_istio/6688/istio-presubmit/13676/) | `/test istio-presubmit`\n\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"istio-testing"}}