{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments/211269654","pull_request_review_id":147653926,"id":211269654,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTI2OTY1NA==","diff_hunk":"@@ -25,14 +25,19 @@ import (\n \n // DeregisterCmd contains the info needed to delete a broker\n type DeregisterCmd struct {\n+\t*command.Namespaced","path":"cmd/svcat/broker/deregister_cmd.go","position":4,"original_position":4,"commit_id":"b52dc765cac252e1dc36e67359ae32fcb04ab8d8","original_commit_id":"b52dc765cac252e1dc36e67359ae32fcb04ab8d8","user":{"login":"carolynvs","id":1368985,"node_id":"MDQ6VXNlcjEzNjg5ODU=","avatar_url":"https://avatars1.githubusercontent.com/u/1368985?v=4","gravatar_id":"","url":"https://api.github.com/users/carolynvs","html_url":"https://github.com/carolynvs","followers_url":"https://api.github.com/users/carolynvs/followers","following_url":"https://api.github.com/users/carolynvs/following{/other_user}","gists_url":"https://api.github.com/users/carolynvs/gists{/gist_id}","starred_url":"https://api.github.com/users/carolynvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carolynvs/subscriptions","organizations_url":"https://api.github.com/users/carolynvs/orgs","repos_url":"https://api.github.com/users/carolynvs/repos","events_url":"https://api.github.com/users/carolynvs/events{/privacy}","received_events_url":"https://api.github.com/users/carolynvs/received_events","type":"User","site_admin":false},"body":"Since `Namespaced` has a context on it, and you are embedding the field here, you can now safely remove lines 32 and 38, then change the call from `c.Context.App` to just `c.App`. Here's an example of how that looks with an existing command: \r\n\r\nhttps://github.com/kubernetes-incubator/service-catalog/blob/97f79ce9088b55cfe153328d171b7239f5464a58/cmd/svcat/instance/get_cmd.go#L91\r\n\r\n","created_at":"2018-08-20T13:54:05Z","updated_at":"2018-08-20T13:56:24Z","html_url":"https://github.com/kubernetes-incubator/service-catalog/pull/2284#discussion_r211269654","pull_request_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/2284","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments/211269654"},"html":{"href":"https://github.com/kubernetes-incubator/service-catalog/pull/2284#discussion_r211269654"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/2284"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/2284","id":208980087,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4OTgwMDg3","html_url":"https://github.com/kubernetes-incubator/service-catalog/pull/2284","diff_url":"https://github.com/kubernetes-incubator/service-catalog/pull/2284.diff","patch_url":"https://github.com/kubernetes-incubator/service-catalog/pull/2284.patch","issue_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/2284","number":2284,"state":"open","locked":false,"title":"Add flags to `svcat deregister`","user":{"login":"jberkhahn","id":5873242,"node_id":"MDQ6VXNlcjU4NzMyNDI=","avatar_url":"https://avatars0.githubusercontent.com/u/5873242?v=4","gravatar_id":"","url":"https://api.github.com/users/jberkhahn","html_url":"https://github.com/jberkhahn","followers_url":"https://api.github.com/users/jberkhahn/followers","following_url":"https://api.github.com/users/jberkhahn/following{/other_user}","gists_url":"https://api.github.com/users/jberkhahn/gists{/gist_id}","starred_url":"https://api.github.com/users/jberkhahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jberkhahn/subscriptions","organizations_url":"https://api.github.com/users/jberkhahn/orgs","repos_url":"https://api.github.com/users/jberkhahn/repos","events_url":"https://api.github.com/users/jberkhahn/events{/privacy}","received_events_url":"https://api.github.com/users/jberkhahn/received_events","type":"User","site_admin":false},"body":"This one's a lot simpler, just making it waitable and namespaced.","created_at":"2018-08-16T20:48:00Z","updated_at":"2018-08-20T13:56:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a174a02b9482b666440ed0ec85e6a075bcd7b7e6","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kikisdeliveryservice","id":6187843,"node_id":"MDQ6VXNlcjYxODc4NDM=","avatar_url":"https://avatars2.githubusercontent.com/u/6187843?v=4","gravatar_id":"","url":"https://api.github.com/users/kikisdeliveryservice","html_url":"https://github.com/kikisdeliveryservice","followers_url":"https://api.github.com/users/kikisdeliveryservice/followers","following_url":"https://api.github.com/users/kikisdeliveryservice/following{/other_user}","gists_url":"https://api.github.com/users/kikisdeliveryservice/gists{/gist_id}","starred_url":"https://api.github.com/users/kikisdeliveryservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kikisdeliveryservice/subscriptions","organizations_url":"https://api.github.com/users/kikisdeliveryservice/orgs","repos_url":"https://api.github.com/users/kikisdeliveryservice/repos","events_url":"https://api.github.com/users/kikisdeliveryservice/events{/privacy}","received_events_url":"https://api.github.com/users/kikisdeliveryservice/received_events","type":"User","site_admin":false},{"login":"n3wscott","id":32305648,"node_id":"MDQ6VXNlcjMyMzA1NjQ4","avatar_url":"https://avatars3.githubusercontent.com/u/32305648?v=4","gravatar_id":"","url":"https://api.github.com/users/n3wscott","html_url":"https://github.com/n3wscott","followers_url":"https://api.github.com/users/n3wscott/followers","following_url":"https://api.github.com/users/n3wscott/following{/other_user}","gists_url":"https://api.github.com/users/n3wscott/gists{/gist_id}","starred_url":"https://api.github.com/users/n3wscott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n3wscott/subscriptions","organizations_url":"https://api.github.com/users/n3wscott/orgs","repos_url":"https://api.github.com/users/n3wscott/repos","events_url":"https://api.github.com/users/n3wscott/events{/privacy}","received_events_url":"https://api.github.com/users/n3wscott/received_events","type":"User","site_admin":false},{"login":"jeremyrickard","id":33884483,"node_id":"MDQ6VXNlcjMzODg0NDgz","avatar_url":"https://avatars1.githubusercontent.com/u/33884483?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremyrickard","html_url":"https://github.com/jeremyrickard","followers_url":"https://api.github.com/users/jeremyrickard/followers","following_url":"https://api.github.com/users/jeremyrickard/following{/other_user}","gists_url":"https://api.github.com/users/jeremyrickard/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremyrickard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremyrickard/subscriptions","organizations_url":"https://api.github.com/users/jeremyrickard/orgs","repos_url":"https://api.github.com/users/jeremyrickard/repos","events_url":"https://api.github.com/users/jeremyrickard/events{/privacy}","received_events_url":"https://api.github.com/users/jeremyrickard/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":485046198,"node_id":"MDU6TGFiZWw0ODUwNDYxOTg=","url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"c2e0c6","default":false},{"id":676207277,"node_id":"MDU6TGFiZWw2NzYyMDcyNzc=","url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/labels/size/S","name":"size/S","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/2284/commits","review_comments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/2284/comments","review_comment_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/2284/comments","statuses_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/statuses/b52dc765cac252e1dc36e67359ae32fcb04ab8d8","head":{"label":"jberkhahn:svcat_deregister_flags_2","ref":"svcat_deregister_flags_2","sha":"b52dc765cac252e1dc36e67359ae32fcb04ab8d8","user":{"login":"jberkhahn","id":5873242,"node_id":"MDQ6VXNlcjU4NzMyNDI=","avatar_url":"https://avatars0.githubusercontent.com/u/5873242?v=4","gravatar_id":"","url":"https://api.github.com/users/jberkhahn","html_url":"https://github.com/jberkhahn","followers_url":"https://api.github.com/users/jberkhahn/followers","following_url":"https://api.github.com/users/jberkhahn/following{/other_user}","gists_url":"https://api.github.com/users/jberkhahn/gists{/gist_id}","starred_url":"https://api.github.com/users/jberkhahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jberkhahn/subscriptions","organizations_url":"https://api.github.com/users/jberkhahn/orgs","repos_url":"https://api.github.com/users/jberkhahn/repos","events_url":"https://api.github.com/users/jberkhahn/events{/privacy}","received_events_url":"https://api.github.com/users/jberkhahn/received_events","type":"User","site_admin":false},"repo":{"id":108435822,"node_id":"MDEwOlJlcG9zaXRvcnkxMDg0MzU4MjI=","name":"service-catalog","full_name":"jberkhahn/service-catalog","owner":{"login":"jberkhahn","id":5873242,"node_id":"MDQ6VXNlcjU4NzMyNDI=","avatar_url":"https://avatars0.githubusercontent.com/u/5873242?v=4","gravatar_id":"","url":"https://api.github.com/users/jberkhahn","html_url":"https://github.com/jberkhahn","followers_url":"https://api.github.com/users/jberkhahn/followers","following_url":"https://api.github.com/users/jberkhahn/following{/other_user}","gists_url":"https://api.github.com/users/jberkhahn/gists{/gist_id}","starred_url":"https://api.github.com/users/jberkhahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jberkhahn/subscriptions","organizations_url":"https://api.github.com/users/jberkhahn/orgs","repos_url":"https://api.github.com/users/jberkhahn/repos","events_url":"https://api.github.com/users/jberkhahn/events{/privacy}","received_events_url":"https://api.github.com/users/jberkhahn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jberkhahn/service-catalog","description":"Consume services in Kubernetes using the Open Service Broker API","fork":true,"url":"https://api.github.com/repos/jberkhahn/service-catalog","forks_url":"https://api.github.com/repos/jberkhahn/service-catalog/forks","keys_url":"https://api.github.com/repos/jberkhahn/service-catalog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jberkhahn/service-catalog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jberkhahn/service-catalog/teams","hooks_url":"https://api.github.com/repos/jberkhahn/service-catalog/hooks","issue_events_url":"https://api.github.com/repos/jberkhahn/service-catalog/issues/events{/number}","events_url":"https://api.github.com/repos/jberkhahn/service-catalog/events","assignees_url":"https://api.github.com/repos/jberkhahn/service-catalog/assignees{/user}","branches_url":"https://api.github.com/repos/jberkhahn/service-catalog/branches{/branch}","tags_url":"https://api.github.com/repos/jberkhahn/service-catalog/tags","blobs_url":"https://api.github.com/repos/jberkhahn/service-catalog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jberkhahn/service-catalog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jberkhahn/service-catalog/git/refs{/sha}","trees_url":"https://api.github.com/repos/jberkhahn/service-catalog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jberkhahn/service-catalog/statuses/{sha}","languages_url":"https://api.github.com/repos/jberkhahn/service-catalog/languages","stargazers_url":"https://api.github.com/repos/jberkhahn/service-catalog/stargazers","contributors_url":"https://api.github.com/repos/jberkhahn/service-catalog/contributors","subscribers_url":"https://api.github.com/repos/jberkhahn/service-catalog/subscribers","subscription_url":"https://api.github.com/repos/jberkhahn/service-catalog/subscription","commits_url":"https://api.github.com/repos/jberkhahn/service-catalog/commits{/sha}","git_commits_url":"https://api.github.com/repos/jberkhahn/service-catalog/git/commits{/sha}","comments_url":"https://api.github.com/repos/jberkhahn/service-catalog/comments{/number}","issue_comment_url":"https://api.github.com/repos/jberkhahn/service-catalog/issues/comments{/number}","contents_url":"https://api.github.com/repos/jberkhahn/service-catalog/contents/{+path}","compare_url":"https://api.github.com/repos/jberkhahn/service-catalog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jberkhahn/service-catalog/merges","archive_url":"https://api.github.com/repos/jberkhahn/service-catalog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jberkhahn/service-catalog/downloads","issues_url":"https://api.github.com/repos/jberkhahn/service-catalog/issues{/number}","pulls_url":"https://api.github.com/repos/jberkhahn/service-catalog/pulls{/number}","milestones_url":"https://api.github.com/repos/jberkhahn/service-catalog/milestones{/number}","notifications_url":"https://api.github.com/repos/jberkhahn/service-catalog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jberkhahn/service-catalog/labels{/name}","releases_url":"https://api.github.com/repos/jberkhahn/service-catalog/releases{/id}","deployments_url":"https://api.github.com/repos/jberkhahn/service-catalog/deployments","created_at":"2017-10-26T16:16:46Z","updated_at":"2018-08-16T20:08:57Z","pushed_at":"2018-08-16T20:46:57Z","git_url":"git://github.com/jberkhahn/service-catalog.git","ssh_url":"git@github.com:jberkhahn/service-catalog.git","clone_url":"https://github.com/jberkhahn/service-catalog.git","svn_url":"https://github.com/jberkhahn/service-catalog","homepage":"","size":103928,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-incubator:master","ref":"master","sha":"393414e082bdf91344b44a2ac9363ddf9321e281","user":{"login":"kubernetes-incubator","id":20862812,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODYyODEy","avatar_url":"https://avatars2.githubusercontent.com/u/20862812?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":68024288,"node_id":"MDEwOlJlcG9zaXRvcnk2ODAyNDI4OA==","name":"service-catalog","full_name":"kubernetes-incubator/service-catalog","owner":{"login":"kubernetes-incubator","id":20862812,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODYyODEy","avatar_url":"https://avatars2.githubusercontent.com/u/20862812?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes-incubator/service-catalog","description":"Consume services in Kubernetes using the Open Service Broker API","fork":false,"url":"https://api.github.com/repos/kubernetes-incubator/service-catalog","forks_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/forks","keys_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/teams","hooks_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/events","assignees_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/tags","blobs_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/languages","stargazers_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/subscription","commits_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/merges","archive_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/downloads","issues_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/deployments","created_at":"2016-09-12T15:58:39Z","updated_at":"2018-08-20T00:20:46Z","pushed_at":"2018-08-18T06:17:50Z","git_url":"git://github.com/kubernetes-incubator/service-catalog.git","ssh_url":"git@github.com:kubernetes-incubator/service-catalog.git","clone_url":"https://github.com/kubernetes-incubator/service-catalog.git","svn_url":"https://github.com/kubernetes-incubator/service-catalog","homepage":"","size":103786,"stargazers_count":583,"watchers_count":583,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":211,"mirror_url":null,"archived":false,"open_issues_count":233,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":211,"open_issues":233,"watchers":583,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/2284"},"html":{"href":"https://github.com/kubernetes-incubator/service-catalog/pull/2284"},"issue":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/2284"},"comments":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/2284/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/2284/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/2284/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/statuses/b52dc765cac252e1dc36e67359ae32fcb04ab8d8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"carolynvs"}}