{"action":"closed","number":26063,"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/26063","id":220533947,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNTMzOTQ3","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/26063","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/26063.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/26063.patch","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/26063","number":26063,"state":"closed","locked":false,"title":"faction missions: display all faction missions","user":{"login":"mlangsdorf","id":8007405,"node_id":"MDQ6VXNlcjgwMDc0MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/8007405?v=4","gravatar_id":"","url":"https://api.github.com/users/mlangsdorf","html_url":"https://github.com/mlangsdorf","followers_url":"https://api.github.com/users/mlangsdorf/followers","following_url":"https://api.github.com/users/mlangsdorf/following{/other_user}","gists_url":"https://api.github.com/users/mlangsdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/mlangsdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlangsdorf/subscriptions","organizations_url":"https://api.github.com/users/mlangsdorf/orgs","repos_url":"https://api.github.com/users/mlangsdorf/repos","events_url":"https://api.github.com/users/mlangsdorf/events{/privacy}","received_events_url":"https://api.github.com/users/mlangsdorf/received_events","type":"User","site_admin":false},"body":"#### Summary\r\n```SUMMARY: Interface \"faction missions: display all faction missions\"```\r\n\r\n#### Purpose of change\r\nThe camp overseer has dialogue options that the player can select, and can see the requirements for, but the player can't see the actual option.  This is most noticeable after creating a kitchen expansion: the individual recipes can be selected, but the player can't actually see the recipe text and can only guess the final result from the ingredients.  That is stupid and annoying and needs to be fixed.\r\n\r\n#### Describe the solution\r\nA lot of faction missions, for some reason, don't submit a string for the mission title display.  The faction camp overseer will let the player select the mission, but the player can't see what the mission is.\r\n\r\nAs a quick fix, use the mission's ID string as the display name if the display name is an empty string.\r\n\r\n#### Describe alternatives you've considered\r\nAll missions should have a properly translatable display name.  Adding that would be a lot of work; this is a quick fix to make the game more playable until I have time to go back and fix it properly.\r\n\r\n### Additional Content\r\n![faction_mission_display](https://user-images.githubusercontent.com/8007405/46506790-0b978c00-c7fb-11e8-9003-9f7305ee0dcb.png)\r\nLook, there are recipes!","created_at":"2018-10-04T22:16:28Z","updated_at":"2018-10-05T12:43:29Z","closed_at":"2018-10-05T12:43:29Z","merged_at":"2018-10-05T12:43:29Z","merge_commit_sha":"da888249c21f09bcf2df69e207bc41a981633096","assignee":{"login":"ZhilkinSerg","id":16213433,"node_id":"MDQ6VXNlcjE2MjEzNDMz","avatar_url":"https://avatars0.githubusercontent.com/u/16213433?v=4","gravatar_id":"","url":"https://api.github.com/users/ZhilkinSerg","html_url":"https://github.com/ZhilkinSerg","followers_url":"https://api.github.com/users/ZhilkinSerg/followers","following_url":"https://api.github.com/users/ZhilkinSerg/following{/other_user}","gists_url":"https://api.github.com/users/ZhilkinSerg/gists{/gist_id}","starred_url":"https://api.github.com/users/ZhilkinSerg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZhilkinSerg/subscriptions","organizations_url":"https://api.github.com/users/ZhilkinSerg/orgs","repos_url":"https://api.github.com/users/ZhilkinSerg/repos","events_url":"https://api.github.com/users/ZhilkinSerg/events{/privacy}","received_events_url":"https://api.github.com/users/ZhilkinSerg/received_events","type":"User","site_admin":false},"assignees":[{"login":"ZhilkinSerg","id":16213433,"node_id":"MDQ6VXNlcjE2MjEzNDMz","avatar_url":"https://avatars0.githubusercontent.com/u/16213433?v=4","gravatar_id":"","url":"https://api.github.com/users/ZhilkinSerg","html_url":"https://github.com/ZhilkinSerg","followers_url":"https://api.github.com/users/ZhilkinSerg/followers","following_url":"https://api.github.com/users/ZhilkinSerg/following{/other_user}","gists_url":"https://api.github.com/users/ZhilkinSerg/gists{/gist_id}","starred_url":"https://api.github.com/users/ZhilkinSerg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZhilkinSerg/subscriptions","organizations_url":"https://api.github.com/users/ZhilkinSerg/orgs","repos_url":"https://api.github.com/users/ZhilkinSerg/repos","events_url":"https://api.github.com/users/ZhilkinSerg/events{/privacy}","received_events_url":"https://api.github.com/users/ZhilkinSerg/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/26063/commits","review_comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/26063/comments","review_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/26063/comments","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/b458c1da0901bdf757e6db3159ba94a43efe9f9c","head":{"label":"mlangsdorf:faction_mission_display","ref":"faction_mission_display","sha":"b458c1da0901bdf757e6db3159ba94a43efe9f9c","user":{"login":"mlangsdorf","id":8007405,"node_id":"MDQ6VXNlcjgwMDc0MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/8007405?v=4","gravatar_id":"","url":"https://api.github.com/users/mlangsdorf","html_url":"https://github.com/mlangsdorf","followers_url":"https://api.github.com/users/mlangsdorf/followers","following_url":"https://api.github.com/users/mlangsdorf/following{/other_user}","gists_url":"https://api.github.com/users/mlangsdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/mlangsdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlangsdorf/subscriptions","organizations_url":"https://api.github.com/users/mlangsdorf/orgs","repos_url":"https://api.github.com/users/mlangsdorf/repos","events_url":"https://api.github.com/users/mlangsdorf/events{/privacy}","received_events_url":"https://api.github.com/users/mlangsdorf/received_events","type":"User","site_admin":false},"repo":{"id":60530185,"node_id":"MDEwOlJlcG9zaXRvcnk2MDUzMDE4NQ==","name":"Cataclysm-DDA","full_name":"mlangsdorf/Cataclysm-DDA","private":false,"owner":{"login":"mlangsdorf","id":8007405,"node_id":"MDQ6VXNlcjgwMDc0MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/8007405?v=4","gravatar_id":"","url":"https://api.github.com/users/mlangsdorf","html_url":"https://github.com/mlangsdorf","followers_url":"https://api.github.com/users/mlangsdorf/followers","following_url":"https://api.github.com/users/mlangsdorf/following{/other_user}","gists_url":"https://api.github.com/users/mlangsdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/mlangsdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlangsdorf/subscriptions","organizations_url":"https://api.github.com/users/mlangsdorf/orgs","repos_url":"https://api.github.com/users/mlangsdorf/repos","events_url":"https://api.github.com/users/mlangsdorf/events{/privacy}","received_events_url":"https://api.github.com/users/mlangsdorf/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mlangsdorf/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":true,"url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA","forks_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/releases{/id}","deployments_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/deployments","created_at":"2016-06-06T13:30:49Z","updated_at":"2018-10-05T11:26:02Z","pushed_at":"2018-10-05T11:25:58Z","git_url":"git://github.com/mlangsdorf/Cataclysm-DDA.git","ssh_url":"git@github.com:mlangsdorf/Cataclysm-DDA.git","clone_url":"https://github.com/mlangsdorf/Cataclysm-DDA.git","svn_url":"https://github.com/mlangsdorf/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":1336811,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":22,"watchers":0,"default_branch":"master"}},"base":{"label":"CleverRaven:master","ref":"master","sha":"2d18192b5de68fc66b99059f827b393b1569439c","user":{"login":"CleverRaven","id":4367009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNjcwMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/4367009?v=4","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"repo":{"id":5973855,"node_id":"MDEwOlJlcG9zaXRvcnk1OTczODU1","name":"Cataclysm-DDA","full_name":"CleverRaven/Cataclysm-DDA","private":false,"owner":{"login":"CleverRaven","id":4367009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNjcwMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/4367009?v=4","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CleverRaven/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.","fork":false,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","forks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/releases{/id}","deployments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/deployments","created_at":"2012-09-26T22:57:43Z","updated_at":"2018-10-05T12:43:25Z","pushed_at":"2018-10-05T12:43:29Z","git_url":"git://github.com/CleverRaven/Cataclysm-DDA.git","ssh_url":"git@github.com:CleverRaven/Cataclysm-DDA.git","clone_url":"https://github.com/CleverRaven/Cataclysm-DDA.git","svn_url":"https://github.com/CleverRaven/Cataclysm-DDA","homepage":"http://cataclysmdda.org","size":1338559,"stargazers_count":2151,"watchers_count":2151,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1439,"mirror_url":null,"archived":false,"open_issues_count":1057,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1439,"open_issues":1057,"watchers":2151,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/26063"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/26063"},"issue":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/26063"},"comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/26063/comments"},"review_comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/26063/comments"},"review_comment":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/26063/commits"},"statuses":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/b458c1da0901bdf757e6db3159ba94a43efe9f9c"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ZhilkinSerg","id":16213433,"node_id":"MDQ6VXNlcjE2MjEzNDMz","avatar_url":"https://avatars0.githubusercontent.com/u/16213433?v=4","gravatar_id":"","url":"https://api.github.com/users/ZhilkinSerg","html_url":"https://github.com/ZhilkinSerg","followers_url":"https://api.github.com/users/ZhilkinSerg/followers","following_url":"https://api.github.com/users/ZhilkinSerg/following{/other_user}","gists_url":"https://api.github.com/users/ZhilkinSerg/gists{/gist_id}","starred_url":"https://api.github.com/users/ZhilkinSerg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZhilkinSerg/subscriptions","organizations_url":"https://api.github.com/users/ZhilkinSerg/orgs","repos_url":"https://api.github.com/users/ZhilkinSerg/repos","events_url":"https://api.github.com/users/ZhilkinSerg/events{/privacy}","received_events_url":"https://api.github.com/users/ZhilkinSerg/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":5,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"ZhilkinSerg"}}