{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments/234949319","pull_request_review_id":176692388,"id":234949319,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDk0OTMxOQ==","diff_hunk":"@@ -0,0 +1,149 @@\n+// Copyright 2018 The go-ethereum Authors\n+// This file is part of the go-ethereum library.\n+//\n+// The go-ethereum library is free software: you can redistribute it and/or modify\n+// it under the terms of the GNU Lesser General Public License as published by\n+// the Free Software Foundation, either version 3 of the License, or\n+// (at your option) any later version.\n+//\n+// The go-ethereum library is distributed in the hope that it will be useful,\n+// but WITHOUT ANY WARRANTY; without even the implied warranty of\n+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n+// GNU Lesser General Public License for more details.\n+//\n+// You should have received a copy of the GNU Lesser General Public License\n+// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.\n+\n+package protocols\n+\n+import (\n+\t\"encoding/binary\"\n+\t\"time\"\n+\n+\t\"github.com/ethereum/go-ethereum/log\"\n+\t\"github.com/ethereum/go-ethereum/metrics\"\n+\n+\t\"github.com/syndtr/goleveldb/leveldb\"\n+)\n+\n+//AccountMetrics abstracts away the metrics DB and\n+//the reporter to persist metrics\n+type AccountingMetrics struct {\n+\tmetricsStore *leveldb.DB\n+\treporter     *reporter\n+}\n+\n+//Close will be called when the node is being shutdown\n+//for a graceful cleanup\n+func (am *AccountingMetrics) Close() {\n+\tam.reporter.quit <- struct{}{}\n+\tam.metricsStore.Close()\n+}\n+\n+//reporter is an internal structure used to write p2p accounting related\n+//metrics to a LevelDB. It will periodically write the accrued metrics to the DB.\n+type reporter struct {\n+\treg      metrics.Registry //the registry for these metrics (independent of other metrics)\n+\tinterval time.Duration    //duration at which the reporter will persist metrics\n+\tdb       *leveldb.DB      //the actual DB\n+\tquit     chan struct{}    //quit the reporter loop\n+}\n+\n+//NewMetricsDB creates a new LevelDB instance used to persist metrics defined\n+//inside p2p/protocols/accounting.go\n+func NewAccountingMetrics(r metrics.Registry, d time.Duration, path string) *AccountingMetrics {\n+\tvar val = make([]byte, 8)\n+\tvar err error\n+\n+\t//Create the LevelDB\n+\tdb, err := leveldb.OpenFile(path, nil)\n+\tif err != nil {\n+\t\tlog.Error(err.Error())\n+\t\treturn nil\n+\t}\n+\n+\t//Check for all defined metrics that there is a value in the DB\n+\t//If there is, assign it to the metric. This means that the node\n+\t//has been running before and that metrics have been persisted.\n+\tmetricsMap := map[string]metrics.Counter{\n+\t\t\"account.balance.credit\": mBalanceCredit,\n+\t\t\"account.balance.debit\":  mBalanceDebit,\n+\t\t\"account.bytes.credit\":   mBytesCredit,\n+\t\t\"account.bytes.debit\":    mBytesDebit,\n+\t\t\"account.msg.credit\":     mMsgCredit,\n+\t\t\"account.msg.debit\":      mMsgDebit,\n+\t\t\"account.peerdrops\":      mPeerDrops,\n+\t\t\"account.selfdrops\":      mSelfDrops,\n+\t}\n+\t//iterate the map and get the values\n+\tfor key, metric := range metricsMap {\n+\t\tval, err = db.Get([]byte(key), nil)\n+\t\t//until the first time a value is being written,\n+\t\t//this will return an error.\n+\t\t//it could be beneficial though to log errors later,\n+\t\t//but that would require a different logic\n+\t\tif err == nil {\n+\t\t\tmetric.Inc(int64(binary.BigEndian.Uint64(val)))\n+\t\t}\n+\t}\n+\n+\t//create the reporter\n+\trep := &reporter{\n+\t\treg:      r,\n+\t\tinterval: d,\n+\t\tdb:       db,\n+\t\tquit:     make(chan struct{}),\n+\t}\n+\n+\t//run the go routine\n+\tgo rep.run()\n+\n+\tm := &AccountingMetrics{\n+\t\tmetricsStore: db,\n+\t\treporter:     rep,\n+\t}\n+\n+\treturn m\n+}\n+\n+//run is the go routine which periodically sends the metrics to the configued LevelDB\n+func (r *reporter) run() {\n+\tintervalTicker := time.NewTicker(r.interval)\n+\n+\tfor {\n+\t\tselect {\n+\t\tcase <-intervalTicker.C:\n+\t\t\t//at each tick send the metrics\n+\t\t\tif err := r.send(); err != nil {\n+\t\t\t\tlog.Error(\"unable to send metrics to LevelDB\", \"err\", err)\n+\t\t\t\t//If there is an error in writing, exit the routine; we assume here that the error is\n+\t\t\t\t//severe and don't attempt to write again.\n+\t\t\t\t//Also, this should prevent leaking when the node is stopped\n+\t\t\t\treturn\n+\t\t\t}\n+\t\tcase <-r.quit:\n+\t\t\t//graceful shutdown\n+\t\t\treturn\n+\t\t}\n+\t}\n+}\n+\n+//send the metrics to the DB\n+func (r *reporter) send() error {\n+\tvar err error\n+\t//for each metric in the registry (which is independent)...\n+\tr.reg.Each(func(name string, i interface{}) {\n+\t\tswitch metric := i.(type) {\n+\t\t//assuming every metric here to be a Counter (separate registry)\n+\t\tcase metrics.Counter:\n+\t\t\t//...create a snapshot...\n+\t\t\tms := metric.Snapshot()\n+\t\t\tbyteVal := make([]byte, 8)\n+\t\t\tbinary.BigEndian.PutUint64(byteVal, uint64(ms.Count()))\n+\t\t\t//...and save the value to the DB\n+\t\t\terr = r.db.Put([]byte(name), byteVal, nil)","path":"p2p/protocols/reporter.go","position":144,"original_position":144,"commit_id":"998028b287fe0e7bb324e4d29b6345de7fb8e4d1","original_commit_id":"998028b287fe0e7bb324e4d29b6345de7fb8e4d1","user":{"login":"janos","id":78134,"node_id":"MDQ6VXNlcjc4MTM0","avatar_url":"https://avatars0.githubusercontent.com/u/78134?v=4","gravatar_id":"","url":"https://api.github.com/users/janos","html_url":"https://github.com/janos","followers_url":"https://api.github.com/users/janos/followers","following_url":"https://api.github.com/users/janos/following{/other_user}","gists_url":"https://api.github.com/users/janos/gists{/gist_id}","starred_url":"https://api.github.com/users/janos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janos/subscriptions","organizations_url":"https://api.github.com/users/janos/orgs","repos_url":"https://api.github.com/users/janos/repos","events_url":"https://api.github.com/users/janos/events{/privacy}","received_events_url":"https://api.github.com/users/janos/received_events","type":"User","site_admin":false},"body":"Could this be more effective with a batch write?","created_at":"2018-11-20T10:36:22Z","updated_at":"2018-11-20T10:42:26Z","html_url":"https://github.com/ethereum/go-ethereum/pull/18136#discussion_r234949319","pull_request_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/18136","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments/234949319"},"html":{"href":"https://github.com/ethereum/go-ethereum/pull/18136#discussion_r234949319"},"pull_request":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/18136"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/18136","id":232019983,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMDE5OTgz","html_url":"https://github.com/ethereum/go-ethereum/pull/18136","diff_url":"https://github.com/ethereum/go-ethereum/pull/18136.diff","patch_url":"https://github.com/ethereum/go-ethereum/pull/18136.patch","issue_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/18136","number":18136,"state":"open","locked":false,"title":"Accounting metrics reporter","user":{"login":"holisticode","id":88287,"node_id":"MDQ6VXNlcjg4Mjg3","avatar_url":"https://avatars3.githubusercontent.com/u/88287?v=4","gravatar_id":"","url":"https://api.github.com/users/holisticode","html_url":"https://github.com/holisticode","followers_url":"https://api.github.com/users/holisticode/followers","following_url":"https://api.github.com/users/holisticode/following{/other_user}","gists_url":"https://api.github.com/users/holisticode/gists{/gist_id}","starred_url":"https://api.github.com/users/holisticode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holisticode/subscriptions","organizations_url":"https://api.github.com/users/holisticode/orgs","repos_url":"https://api.github.com/users/holisticode/repos","events_url":"https://api.github.com/users/holisticode/events{/privacy}","received_events_url":"https://api.github.com/users/holisticode/received_events","type":"User","site_admin":false},"body":"The first p2p accounting PR https://github.com/ethereum/go-ethereum/pull/17951 introduced a couple of metrics for the accounting (accounted bytes sent/received, accounted messages sent/received, etc.).\r\n\r\nThose metrics though were not persisted, and would be reset after every node restart.\r\n\r\nThese are metrics of interest to the end user, and represent (crypto-)economic indicators, which may give her insights to how her node is performing in terms of profitability.\r\n\r\nThis PR introduces functionality to persist these metrics to a DB.\r\nThe set of metrics can be extended later if required.","created_at":"2018-11-19T15:46:39Z","updated_at":"2018-11-20T10:42:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6487a3ad7164e12e75a8b05f77cfcba434997916","assignee":{"login":"holisticode","id":88287,"node_id":"MDQ6VXNlcjg4Mjg3","avatar_url":"https://avatars3.githubusercontent.com/u/88287?v=4","gravatar_id":"","url":"https://api.github.com/users/holisticode","html_url":"https://github.com/holisticode","followers_url":"https://api.github.com/users/holisticode/followers","following_url":"https://api.github.com/users/holisticode/following{/other_user}","gists_url":"https://api.github.com/users/holisticode/gists{/gist_id}","starred_url":"https://api.github.com/users/holisticode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holisticode/subscriptions","organizations_url":"https://api.github.com/users/holisticode/orgs","repos_url":"https://api.github.com/users/holisticode/repos","events_url":"https://api.github.com/users/holisticode/events{/privacy}","received_events_url":"https://api.github.com/users/holisticode/received_events","type":"User","site_admin":false},"assignees":[{"login":"holisticode","id":88287,"node_id":"MDQ6VXNlcjg4Mjg3","avatar_url":"https://avatars3.githubusercontent.com/u/88287?v=4","gravatar_id":"","url":"https://api.github.com/users/holisticode","html_url":"https://github.com/holisticode","followers_url":"https://api.github.com/users/holisticode/followers","following_url":"https://api.github.com/users/holisticode/following{/other_user}","gists_url":"https://api.github.com/users/holisticode/gists{/gist_id}","starred_url":"https://api.github.com/users/holisticode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holisticode/subscriptions","organizations_url":"https://api.github.com/users/holisticode/orgs","repos_url":"https://api.github.com/users/holisticode/repos","events_url":"https://api.github.com/users/holisticode/events{/privacy}","received_events_url":"https://api.github.com/users/holisticode/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"nolash","id":9886925,"node_id":"MDQ6VXNlcjk4ODY5MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/9886925?v=4","gravatar_id":"","url":"https://api.github.com/users/nolash","html_url":"https://github.com/nolash","followers_url":"https://api.github.com/users/nolash/followers","following_url":"https://api.github.com/users/nolash/following{/other_user}","gists_url":"https://api.github.com/users/nolash/gists{/gist_id}","starred_url":"https://api.github.com/users/nolash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nolash/subscriptions","organizations_url":"https://api.github.com/users/nolash/orgs","repos_url":"https://api.github.com/users/nolash/repos","events_url":"https://api.github.com/users/nolash/events{/privacy}","received_events_url":"https://api.github.com/users/nolash/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":72233652,"node_id":"MDU6TGFiZWw3MjIzMzY1Mg==","url":"https://api.github.com/repos/ethereum/go-ethereum/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":163665008,"node_id":"MDU6TGFiZWwxNjM2NjUwMDg=","url":"https://api.github.com/repos/ethereum/go-ethereum/labels/please%20review","name":"please review","color":"fad8c7","default":false},{"id":295303566,"node_id":"MDU6TGFiZWwyOTUzMDM1NjY=","url":"https://api.github.com/repos/ethereum/go-ethereum/labels/swarm","name":"swarm","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/18136/commits","review_comments_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/18136/comments","review_comment_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/18136/comments","statuses_url":"https://api.github.com/repos/ethereum/go-ethereum/statuses/998028b287fe0e7bb324e4d29b6345de7fb8e4d1","head":{"label":"ethersphere:swap-metrics-reporter","ref":"swap-metrics-reporter","sha":"998028b287fe0e7bb324e4d29b6345de7fb8e4d1","user":{"login":"ethersphere","id":6946989,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NDY5ODk=","avatar_url":"https://avatars2.githubusercontent.com/u/6946989?v=4","gravatar_id":"","url":"https://api.github.com/users/ethersphere","html_url":"https://github.com/ethersphere","followers_url":"https://api.github.com/users/ethersphere/followers","following_url":"https://api.github.com/users/ethersphere/following{/other_user}","gists_url":"https://api.github.com/users/ethersphere/gists{/gist_id}","starred_url":"https://api.github.com/users/ethersphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethersphere/subscriptions","organizations_url":"https://api.github.com/users/ethersphere/orgs","repos_url":"https://api.github.com/users/ethersphere/repos","events_url":"https://api.github.com/users/ethersphere/events{/privacy}","received_events_url":"https://api.github.com/users/ethersphere/received_events","type":"Organization","site_admin":false},"repo":{"id":17790136,"node_id":"MDEwOlJlcG9zaXRvcnkxNzc5MDEzNg==","name":"go-ethereum","full_name":"ethersphere/go-ethereum","private":false,"owner":{"login":"ethersphere","id":6946989,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NDY5ODk=","avatar_url":"https://avatars2.githubusercontent.com/u/6946989?v=4","gravatar_id":"","url":"https://api.github.com/users/ethersphere","html_url":"https://github.com/ethersphere","followers_url":"https://api.github.com/users/ethersphere/followers","following_url":"https://api.github.com/users/ethersphere/following{/other_user}","gists_url":"https://api.github.com/users/ethersphere/gists{/gist_id}","starred_url":"https://api.github.com/users/ethersphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethersphere/subscriptions","organizations_url":"https://api.github.com/users/ethersphere/orgs","repos_url":"https://api.github.com/users/ethersphere/repos","events_url":"https://api.github.com/users/ethersphere/events{/privacy}","received_events_url":"https://api.github.com/users/ethersphere/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ethersphere/go-ethereum","description":"Ethereum Go","fork":true,"url":"https://api.github.com/repos/ethersphere/go-ethereum","forks_url":"https://api.github.com/repos/ethersphere/go-ethereum/forks","keys_url":"https://api.github.com/repos/ethersphere/go-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethersphere/go-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethersphere/go-ethereum/teams","hooks_url":"https://api.github.com/repos/ethersphere/go-ethereum/hooks","issue_events_url":"https://api.github.com/repos/ethersphere/go-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/ethersphere/go-ethereum/events","assignees_url":"https://api.github.com/repos/ethersphere/go-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/ethersphere/go-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/ethersphere/go-ethereum/tags","blobs_url":"https://api.github.com/repos/ethersphere/go-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethersphere/go-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethersphere/go-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethersphere/go-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethersphere/go-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/ethersphere/go-ethereum/languages","stargazers_url":"https://api.github.com/repos/ethersphere/go-ethereum/stargazers","contributors_url":"https://api.github.com/repos/ethersphere/go-ethereum/contributors","subscribers_url":"https://api.github.com/repos/ethersphere/go-ethereum/subscribers","subscription_url":"https://api.github.com/repos/ethersphere/go-ethereum/subscription","commits_url":"https://api.github.com/repos/ethersphere/go-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethersphere/go-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethersphere/go-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethersphere/go-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethersphere/go-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/ethersphere/go-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethersphere/go-ethereum/merges","archive_url":"https://api.github.com/repos/ethersphere/go-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethersphere/go-ethereum/downloads","issues_url":"https://api.github.com/repos/ethersphere/go-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/ethersphere/go-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/ethersphere/go-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/ethersphere/go-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethersphere/go-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/ethersphere/go-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/ethersphere/go-ethereum/deployments","created_at":"2014-03-16T02:06:34Z","updated_at":"2018-11-20T09:43:15Z","pushed_at":"2018-11-20T10:33:12Z","git_url":"git://github.com/ethersphere/go-ethereum.git","ssh_url":"git@github.com:ethersphere/go-ethereum.git","clone_url":"https://github.com/ethersphere/go-ethereum.git","svn_url":"https://github.com/ethersphere/go-ethereum","homepage":"","size":109727,"stargazers_count":117,"watchers_count":117,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":178,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":37,"open_issues":178,"watchers":117,"default_branch":"master"}},"base":{"label":"ethereum:master","ref":"master","sha":"d31f1f4fdb905acb3d7c766683e584bb17f8df0d","user":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":15452919,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ1MjkxOQ==","name":"go-ethereum","full_name":"ethereum/go-ethereum","private":false,"owner":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ethereum/go-ethereum","description":"Official Go implementation of the Ethereum protocol","fork":false,"url":"https://api.github.com/repos/ethereum/go-ethereum","forks_url":"https://api.github.com/repos/ethereum/go-ethereum/forks","keys_url":"https://api.github.com/repos/ethereum/go-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/go-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/go-ethereum/teams","hooks_url":"https://api.github.com/repos/ethereum/go-ethereum/hooks","issue_events_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/go-ethereum/events","assignees_url":"https://api.github.com/repos/ethereum/go-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/go-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/go-ethereum/tags","blobs_url":"https://api.github.com/repos/ethereum/go-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/go-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/go-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/go-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/go-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/go-ethereum/languages","stargazers_url":"https://api.github.com/repos/ethereum/go-ethereum/stargazers","contributors_url":"https://api.github.com/repos/ethereum/go-ethereum/contributors","subscribers_url":"https://api.github.com/repos/ethereum/go-ethereum/subscribers","subscription_url":"https://api.github.com/repos/ethereum/go-ethereum/subscription","commits_url":"https://api.github.com/repos/ethereum/go-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/go-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/go-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/go-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/go-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/go-ethereum/merges","archive_url":"https://api.github.com/repos/ethereum/go-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/go-ethereum/downloads","issues_url":"https://api.github.com/repos/ethereum/go-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/go-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/go-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/go-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/go-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/go-ethereum/deployments","created_at":"2013-12-26T13:05:46Z","updated_at":"2018-11-20T10:24:34Z","pushed_at":"2018-11-20T10:32:49Z","git_url":"git://github.com/ethereum/go-ethereum.git","ssh_url":"git@github.com:ethereum/go-ethereum.git","clone_url":"https://github.com/ethereum/go-ethereum.git","svn_url":"https://github.com/ethereum/go-ethereum","homepage":"https://geth.ethereum.org","size":107388,"stargazers_count":21760,"watchers_count":21760,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7586,"mirror_url":null,"archived":false,"open_issues_count":915,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":7586,"open_issues":915,"watchers":21760,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/18136"},"html":{"href":"https://github.com/ethereum/go-ethereum/pull/18136"},"issue":{"href":"https://api.github.com/repos/ethereum/go-ethereum/issues/18136"},"comments":{"href":"https://api.github.com/repos/ethereum/go-ethereum/issues/18136/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/18136/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/18136/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/go-ethereum/statuses/998028b287fe0e7bb324e4d29b6345de7fb8e4d1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"janos"}}