{"action":"closed","number":4161,"pull_request":{"url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/4161","id":236725158,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2NzI1MTU4","html_url":"https://github.com/apache/incubator-openwhisk/pull/4161","diff_url":"https://github.com/apache/incubator-openwhisk/pull/4161.diff","patch_url":"https://github.com/apache/incubator-openwhisk/pull/4161.patch","issue_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/4161","number":4161,"state":"closed","locked":false,"title":"Revert \"Proposing Lean OpenWhisk (#3886)\"","user":{"login":"rabbah","id":4959922,"node_id":"MDQ6VXNlcjQ5NTk5MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/4959922?v=4","gravatar_id":"","url":"https://api.github.com/users/rabbah","html_url":"https://github.com/rabbah","followers_url":"https://api.github.com/users/rabbah/followers","following_url":"https://api.github.com/users/rabbah/following{/other_user}","gists_url":"https://api.github.com/users/rabbah/gists{/gist_id}","starred_url":"https://api.github.com/users/rabbah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rabbah/subscriptions","organizations_url":"https://api.github.com/users/rabbah/orgs","repos_url":"https://api.github.com/users/rabbah/repos","events_url":"https://api.github.com/users/rabbah/events{/privacy}","received_events_url":"https://api.github.com/users/rabbah/received_events","type":"User","site_admin":false},"body":"This reverts commit d4a190c62f0aa1cd0bbecc62ad6b9885c70e9f6b.\r\nThe reason I'm reverting the commit is because while I can do a local path to mirror some of the changes in the main (fat?) loadbalancer, there is already a fair bit of divergence in the two load balancers because the lean version clones and owns the code and so it's prone to such slippage.\r\n\r\nThere is a cleaner organization which allows a common LB class which implements much of the logic that is shared between the two implementations. I started to do this on this branch https://github.com/apache/incubator-openwhisk/compare/master...rabbah:patch?expand=1 but it's clear it will take me a bit more time and we shouldn't break all the repos in the meantime.\r\n\r\nI further suggest in the refactoring that the lean LB actually implements identity actors for the invoker pool health and feeds so that there's less reason to diverge or special case some of the code. It's best to have one version of this code because it's functionally critical.\r\n\r\n@kpavel Sorry that I didn't get to review the code again more recently before it was merged, but I'm happy to help re-introduce this contribution with an improved organization as suggested here if you're agreeable.\r\n\r\n","created_at":"2018-12-07T01:13:45Z","updated_at":"2018-12-07T01:53:06Z","closed_at":"2018-12-07T01:53:05Z","merged_at":"2018-12-07T01:53:05Z","merge_commit_sha":"d1ca290656ab2750c31e7a8b159d6124dddf531a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/4161/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/4161/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/4161/comments","statuses_url":"https://api.github.com/repos/apache/incubator-openwhisk/statuses/bf0435dbcdb1a22bf4e4f7e7d22c4e00c72d2ce4","head":{"label":"rabbah:lean","ref":"lean","sha":"bf0435dbcdb1a22bf4e4f7e7d22c4e00c72d2ce4","user":{"login":"rabbah","id":4959922,"node_id":"MDQ6VXNlcjQ5NTk5MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/4959922?v=4","gravatar_id":"","url":"https://api.github.com/users/rabbah","html_url":"https://github.com/rabbah","followers_url":"https://api.github.com/users/rabbah/followers","following_url":"https://api.github.com/users/rabbah/following{/other_user}","gists_url":"https://api.github.com/users/rabbah/gists{/gist_id}","starred_url":"https://api.github.com/users/rabbah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rabbah/subscriptions","organizations_url":"https://api.github.com/users/rabbah/orgs","repos_url":"https://api.github.com/users/rabbah/repos","events_url":"https://api.github.com/users/rabbah/events{/privacy}","received_events_url":"https://api.github.com/users/rabbah/received_events","type":"User","site_admin":false},"repo":{"id":52371720,"node_id":"MDEwOlJlcG9zaXRvcnk1MjM3MTcyMA==","name":"openwhisk","full_name":"rabbah/openwhisk","private":false,"owner":{"login":"rabbah","id":4959922,"node_id":"MDQ6VXNlcjQ5NTk5MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/4959922?v=4","gravatar_id":"","url":"https://api.github.com/users/rabbah","html_url":"https://github.com/rabbah","followers_url":"https://api.github.com/users/rabbah/followers","following_url":"https://api.github.com/users/rabbah/following{/other_user}","gists_url":"https://api.github.com/users/rabbah/gists{/gist_id}","starred_url":"https://api.github.com/users/rabbah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rabbah/subscriptions","organizations_url":"https://api.github.com/users/rabbah/orgs","repos_url":"https://api.github.com/users/rabbah/repos","events_url":"https://api.github.com/users/rabbah/events{/privacy}","received_events_url":"https://api.github.com/users/rabbah/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rabbah/openwhisk","description":"OpenWhisk is a cloud-first distributed event-based programming service.","fork":true,"url":"https://api.github.com/repos/rabbah/openwhisk","forks_url":"https://api.github.com/repos/rabbah/openwhisk/forks","keys_url":"https://api.github.com/repos/rabbah/openwhisk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rabbah/openwhisk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rabbah/openwhisk/teams","hooks_url":"https://api.github.com/repos/rabbah/openwhisk/hooks","issue_events_url":"https://api.github.com/repos/rabbah/openwhisk/issues/events{/number}","events_url":"https://api.github.com/repos/rabbah/openwhisk/events","assignees_url":"https://api.github.com/repos/rabbah/openwhisk/assignees{/user}","branches_url":"https://api.github.com/repos/rabbah/openwhisk/branches{/branch}","tags_url":"https://api.github.com/repos/rabbah/openwhisk/tags","blobs_url":"https://api.github.com/repos/rabbah/openwhisk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rabbah/openwhisk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rabbah/openwhisk/git/refs{/sha}","trees_url":"https://api.github.com/repos/rabbah/openwhisk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rabbah/openwhisk/statuses/{sha}","languages_url":"https://api.github.com/repos/rabbah/openwhisk/languages","stargazers_url":"https://api.github.com/repos/rabbah/openwhisk/stargazers","contributors_url":"https://api.github.com/repos/rabbah/openwhisk/contributors","subscribers_url":"https://api.github.com/repos/rabbah/openwhisk/subscribers","subscription_url":"https://api.github.com/repos/rabbah/openwhisk/subscription","commits_url":"https://api.github.com/repos/rabbah/openwhisk/commits{/sha}","git_commits_url":"https://api.github.com/repos/rabbah/openwhisk/git/commits{/sha}","comments_url":"https://api.github.com/repos/rabbah/openwhisk/comments{/number}","issue_comment_url":"https://api.github.com/repos/rabbah/openwhisk/issues/comments{/number}","contents_url":"https://api.github.com/repos/rabbah/openwhisk/contents/{+path}","compare_url":"https://api.github.com/repos/rabbah/openwhisk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rabbah/openwhisk/merges","archive_url":"https://api.github.com/repos/rabbah/openwhisk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rabbah/openwhisk/downloads","issues_url":"https://api.github.com/repos/rabbah/openwhisk/issues{/number}","pulls_url":"https://api.github.com/repos/rabbah/openwhisk/pulls{/number}","milestones_url":"https://api.github.com/repos/rabbah/openwhisk/milestones{/number}","notifications_url":"https://api.github.com/repos/rabbah/openwhisk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rabbah/openwhisk/labels{/name}","releases_url":"https://api.github.com/repos/rabbah/openwhisk/releases{/id}","deployments_url":"https://api.github.com/repos/rabbah/openwhisk/deployments","created_at":"2016-02-23T16:03:01Z","updated_at":"2018-07-29T13:39:43Z","pushed_at":"2018-12-07T01:09:39Z","git_url":"git://github.com/rabbah/openwhisk.git","ssh_url":"git@github.com:rabbah/openwhisk.git","clone_url":"https://github.com/rabbah/openwhisk.git","svn_url":"https://github.com/rabbah/openwhisk","homepage":"","size":63785,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"d4a190c62f0aa1cd0bbecc62ad6b9885c70e9f6b","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":52039373,"node_id":"MDEwOlJlcG9zaXRvcnk1MjAzOTM3Mw==","name":"incubator-openwhisk","full_name":"apache/incubator-openwhisk","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/incubator-openwhisk","description":"Apache OpenWhisk is a serverless event-based programming service and an Apache Incubator project.","fork":false,"url":"https://api.github.com/repos/apache/incubator-openwhisk","forks_url":"https://api.github.com/repos/apache/incubator-openwhisk/forks","keys_url":"https://api.github.com/repos/apache/incubator-openwhisk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-openwhisk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-openwhisk/teams","hooks_url":"https://api.github.com/repos/apache/incubator-openwhisk/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-openwhisk/events","assignees_url":"https://api.github.com/repos/apache/incubator-openwhisk/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-openwhisk/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-openwhisk/tags","blobs_url":"https://api.github.com/repos/apache/incubator-openwhisk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-openwhisk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-openwhisk/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-openwhisk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-openwhisk/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-openwhisk/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-openwhisk/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-openwhisk/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-openwhisk/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-openwhisk/subscription","commits_url":"https://api.github.com/repos/apache/incubator-openwhisk/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-openwhisk/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-openwhisk/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-openwhisk/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-openwhisk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-openwhisk/merges","archive_url":"https://api.github.com/repos/apache/incubator-openwhisk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-openwhisk/downloads","issues_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-openwhisk/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-openwhisk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-openwhisk/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-openwhisk/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-openwhisk/deployments","created_at":"2016-02-18T21:16:19Z","updated_at":"2018-12-06T23:08:32Z","pushed_at":"2018-12-07T01:53:05Z","git_url":"git://github.com/apache/incubator-openwhisk.git","ssh_url":"git@github.com:apache/incubator-openwhisk.git","clone_url":"https://github.com/apache/incubator-openwhisk.git","svn_url":"https://github.com/apache/incubator-openwhisk","homepage":"https://openwhisk.apache.org/ ","size":63470,"stargazers_count":3665,"watchers_count":3665,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":697,"mirror_url":null,"archived":false,"open_issues_count":425,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":697,"open_issues":425,"watchers":3665,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/4161"},"html":{"href":"https://github.com/apache/incubator-openwhisk/pull/4161"},"issue":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/issues/4161"},"comments":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/issues/4161/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/4161/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/4161/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/statuses/bf0435dbcdb1a22bf4e4f7e7d22c4e00c72d2ce4"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"dgrove-oss","id":5099100,"node_id":"MDQ6VXNlcjUwOTkxMDA=","avatar_url":"https://avatars1.githubusercontent.com/u/5099100?v=4","gravatar_id":"","url":"https://api.github.com/users/dgrove-oss","html_url":"https://github.com/dgrove-oss","followers_url":"https://api.github.com/users/dgrove-oss/followers","following_url":"https://api.github.com/users/dgrove-oss/following{/other_user}","gists_url":"https://api.github.com/users/dgrove-oss/gists{/gist_id}","starred_url":"https://api.github.com/users/dgrove-oss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgrove-oss/subscriptions","organizations_url":"https://api.github.com/users/dgrove-oss/orgs","repos_url":"https://api.github.com/users/dgrove-oss/repos","events_url":"https://api.github.com/users/dgrove-oss/events{/privacy}","received_events_url":"https://api.github.com/users/dgrove-oss/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":32,"deletions":884,"changed_files":24}}
{"actor":{"display_login":"dgrove-oss"}}