{"action":"created","comment":{"url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/pulls/comments/215814187","pull_request_review_id":153166140,"id":215814187,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTgxNDE4Nw==","diff_hunk":"@@ -7,19 +7,61 @@\n //\n \n import Foundation\n+import RxSwift\n \n class ExchangeCreateInteractor {\n+    var disposable: Disposable?\n     weak var output: ExchangeCreateOutput?\n     fileprivate let inputs: ExchangeInputsAPI\n-    fileprivate let markets: ExchangeMarketsAPI\n+    fileprivate var markets: ExchangeMarketsAPI\n+    private var model: MarketsModel? {\n+        didSet {","path":"Blockchain/Homebrew/Exchange/Interactors/ExchangeCreateInteractor.swift","position":13,"original_position":13,"commit_id":"fb166058fb62eda36d9c7d49324d31451d359ffa","original_commit_id":"fb166058fb62eda36d9c7d49324d31451d359ffa","user":{"login":"bchrisarriola","id":38220701,"node_id":"MDQ6VXNlcjM4MjIwNzAx","avatar_url":"https://avatars0.githubusercontent.com/u/38220701?v=4","gravatar_id":"","url":"https://api.github.com/users/bchrisarriola","html_url":"https://github.com/bchrisarriola","followers_url":"https://api.github.com/users/bchrisarriola/followers","following_url":"https://api.github.com/users/bchrisarriola/following{/other_user}","gists_url":"https://api.github.com/users/bchrisarriola/gists{/gist_id}","starred_url":"https://api.github.com/users/bchrisarriola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bchrisarriola/subscriptions","organizations_url":"https://api.github.com/users/bchrisarriola/orgs","repos_url":"https://api.github.com/users/bchrisarriola/repos","events_url":"https://api.github.com/users/bchrisarriola/events{/privacy}","received_events_url":"https://api.github.com/users/bchrisarriola/received_events","type":"User","site_admin":false},"body":"👌 ","created_at":"2018-09-07T00:14:59Z","updated_at":"2018-09-07T00:31:17Z","html_url":"https://github.com/blockchain/My-Wallet-V3-iOS/pull/462#discussion_r215814187","pull_request_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/pulls/462","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/pulls/comments/215814187"},"html":{"href":"https://github.com/blockchain/My-Wallet-V3-iOS/pull/462#discussion_r215814187"},"pull_request":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/pulls/462"}}},"pull_request":{"url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/pulls/462","id":213740917,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNzQwOTE3","html_url":"https://github.com/blockchain/My-Wallet-V3-iOS/pull/462","diff_url":"https://github.com/blockchain/My-Wallet-V3-iOS/pull/462.diff","patch_url":"https://github.com/blockchain/My-Wallet-V3-iOS/pull/462.patch","issue_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/issues/462","number":462,"state":"open","locked":false,"title":"feat(Homebrew-Exchange): authenticate with socket and attempt subscribing to conversion advice","user":{"login":"woudini","id":10579422,"node_id":"MDQ6VXNlcjEwNTc5NDIy","avatar_url":"https://avatars1.githubusercontent.com/u/10579422?v=4","gravatar_id":"","url":"https://api.github.com/users/woudini","html_url":"https://github.com/woudini","followers_url":"https://api.github.com/users/woudini/followers","following_url":"https://api.github.com/users/woudini/following{/other_user}","gists_url":"https://api.github.com/users/woudini/gists{/gist_id}","starred_url":"https://api.github.com/users/woudini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woudini/subscriptions","organizations_url":"https://api.github.com/users/woudini/orgs","repos_url":"https://api.github.com/users/woudini/repos","events_url":"https://api.github.com/users/woudini/events{/privacy}","received_events_url":"https://api.github.com/users/woudini/received_events","type":"User","site_admin":false},"body":"## Objective\r\n\r\nProgress on Homebrew Exchange websocket implementation.\r\n\r\n## Description\r\n\r\n- Added new config entry `RETAIL_CORE_SOCKET_URL`, please update in the project and Pod config files.\r\n- Added socket message model for subscribing and conversion\r\n- Added some loading logic `ExchangeCreatePresenter`: `onLoaded()` -> `ExchangeCreateInteractor`: `load()`\r\n- Added a model `MarketsModel` to be injected into `ExchangeCreateInteractor` - could use some suggestions on renaming\r\n- Added a new enum `Fix` which is a string that determines fiat vs crypto and whether the base or counter is designated - maybe not the best name but it's the one used in the API\r\n\r\n## How to Test\r\n\r\nNot worth testing at the moment IMO but you can revert eeff9420fb95d213625b20407ff60fac40b83e9c and e692da5d982c46a22b60699cbdb5ae99502c1581 to try it out. Remember to add a new entry for `RETAIL_CORE_SOCKET_URL` and in `Blockchain-Info.plist`\r\n\r\n## Screenshot/Design assessment\r\n\r\nN/A\r\n\r\n## Merge Checklist\r\n\r\n- [x] The PR uses a title supported by [.changelogrc](https://github.com/blockchain/My-Wallet-V3-iOS/blob/dev/.changelogrc#L6...L69).\r\n- [ ] Areas of technical debt are marked with a `// TICKET:` comment that includes a ticket number.\r\n- [x] All unit tests pass.\r\n- [ ] You have added unit tests.\r\n- [x] New files added are within the correct directory. (e.g. if a file is required for unit tests to compile, be sure it is added to the tests target.)\r\n","created_at":"2018-09-06T20:30:13Z","updated_at":"2018-09-07T00:31:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d763aee6d77fde88114b76356474717e7af7810","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/pulls/462/commits","review_comments_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/pulls/462/comments","review_comment_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/issues/462/comments","statuses_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/statuses/fb166058fb62eda36d9c7d49324d31451d359ffa","head":{"label":"blockchain:kevin/IOS-1176/web_socket","ref":"kevin/IOS-1176/web_socket","sha":"fb166058fb62eda36d9c7d49324d31451d359ffa","user":{"login":"blockchain","id":1777722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Nzc3MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1777722?v=4","gravatar_id":"","url":"https://api.github.com/users/blockchain","html_url":"https://github.com/blockchain","followers_url":"https://api.github.com/users/blockchain/followers","following_url":"https://api.github.com/users/blockchain/following{/other_user}","gists_url":"https://api.github.com/users/blockchain/gists{/gist_id}","starred_url":"https://api.github.com/users/blockchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blockchain/subscriptions","organizations_url":"https://api.github.com/users/blockchain/orgs","repos_url":"https://api.github.com/users/blockchain/repos","events_url":"https://api.github.com/users/blockchain/events{/privacy}","received_events_url":"https://api.github.com/users/blockchain/received_events","type":"Organization","site_admin":false},"repo":{"id":26277947,"node_id":"MDEwOlJlcG9zaXRvcnkyNjI3Nzk0Nw==","name":"My-Wallet-V3-iOS","full_name":"blockchain/My-Wallet-V3-iOS","owner":{"login":"blockchain","id":1777722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Nzc3MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1777722?v=4","gravatar_id":"","url":"https://api.github.com/users/blockchain","html_url":"https://github.com/blockchain","followers_url":"https://api.github.com/users/blockchain/followers","following_url":"https://api.github.com/users/blockchain/following{/other_user}","gists_url":"https://api.github.com/users/blockchain/gists{/gist_id}","starred_url":"https://api.github.com/users/blockchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blockchain/subscriptions","organizations_url":"https://api.github.com/users/blockchain/orgs","repos_url":"https://api.github.com/users/blockchain/repos","events_url":"https://api.github.com/users/blockchain/events{/privacy}","received_events_url":"https://api.github.com/users/blockchain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/blockchain/My-Wallet-V3-iOS","description":"Blockchain iOS Wallet","fork":false,"url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS","forks_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/forks","keys_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/teams","hooks_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/hooks","issue_events_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/events","assignees_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/tags","blobs_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/languages","stargazers_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/stargazers","contributors_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/contributors","subscribers_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/subscribers","subscription_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/subscription","commits_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/merges","archive_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/downloads","issues_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/labels{/name}","releases_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/deployments","created_at":"2014-11-06T16:07:58Z","updated_at":"2018-09-06T19:13:31Z","pushed_at":"2018-09-06T23:32:51Z","git_url":"git://github.com/blockchain/My-Wallet-V3-iOS.git","ssh_url":"git@github.com:blockchain/My-Wallet-V3-iOS.git","clone_url":"https://github.com/blockchain/My-Wallet-V3-iOS.git","svn_url":"https://github.com/blockchain/My-Wallet-V3-iOS","homepage":"https://itunes.apple.com/us/app/blockchain-bitcoin-wallet/id493253309","size":90769,"stargazers_count":97,"watchers_count":97,"language":"Assembly","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":63,"open_issues":9,"watchers":97,"default_branch":"dev"}},"base":{"label":"blockchain:dev","ref":"dev","sha":"431750163c7d48df7251d64d46129b4e6a8936b2","user":{"login":"blockchain","id":1777722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Nzc3MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1777722?v=4","gravatar_id":"","url":"https://api.github.com/users/blockchain","html_url":"https://github.com/blockchain","followers_url":"https://api.github.com/users/blockchain/followers","following_url":"https://api.github.com/users/blockchain/following{/other_user}","gists_url":"https://api.github.com/users/blockchain/gists{/gist_id}","starred_url":"https://api.github.com/users/blockchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blockchain/subscriptions","organizations_url":"https://api.github.com/users/blockchain/orgs","repos_url":"https://api.github.com/users/blockchain/repos","events_url":"https://api.github.com/users/blockchain/events{/privacy}","received_events_url":"https://api.github.com/users/blockchain/received_events","type":"Organization","site_admin":false},"repo":{"id":26277947,"node_id":"MDEwOlJlcG9zaXRvcnkyNjI3Nzk0Nw==","name":"My-Wallet-V3-iOS","full_name":"blockchain/My-Wallet-V3-iOS","owner":{"login":"blockchain","id":1777722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Nzc3MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1777722?v=4","gravatar_id":"","url":"https://api.github.com/users/blockchain","html_url":"https://github.com/blockchain","followers_url":"https://api.github.com/users/blockchain/followers","following_url":"https://api.github.com/users/blockchain/following{/other_user}","gists_url":"https://api.github.com/users/blockchain/gists{/gist_id}","starred_url":"https://api.github.com/users/blockchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blockchain/subscriptions","organizations_url":"https://api.github.com/users/blockchain/orgs","repos_url":"https://api.github.com/users/blockchain/repos","events_url":"https://api.github.com/users/blockchain/events{/privacy}","received_events_url":"https://api.github.com/users/blockchain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/blockchain/My-Wallet-V3-iOS","description":"Blockchain iOS Wallet","fork":false,"url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS","forks_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/forks","keys_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/teams","hooks_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/hooks","issue_events_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/events","assignees_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/tags","blobs_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/languages","stargazers_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/stargazers","contributors_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/contributors","subscribers_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/subscribers","subscription_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/subscription","commits_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/merges","archive_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/downloads","issues_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/labels{/name}","releases_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/deployments","created_at":"2014-11-06T16:07:58Z","updated_at":"2018-09-06T19:13:31Z","pushed_at":"2018-09-06T23:32:51Z","git_url":"git://github.com/blockchain/My-Wallet-V3-iOS.git","ssh_url":"git@github.com:blockchain/My-Wallet-V3-iOS.git","clone_url":"https://github.com/blockchain/My-Wallet-V3-iOS.git","svn_url":"https://github.com/blockchain/My-Wallet-V3-iOS","homepage":"https://itunes.apple.com/us/app/blockchain-bitcoin-wallet/id493253309","size":90769,"stargazers_count":97,"watchers_count":97,"language":"Assembly","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":63,"open_issues":9,"watchers":97,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/pulls/462"},"html":{"href":"https://github.com/blockchain/My-Wallet-V3-iOS/pull/462"},"issue":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/issues/462"},"comments":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/issues/462/comments"},"review_comments":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/pulls/462/comments"},"review_comment":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/pulls/462/commits"},"statuses":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/statuses/fb166058fb62eda36d9c7d49324d31451d359ffa"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bchrisarriola"}}