{"action":"created","comment":{"url":"https://api.github.com/repos/Talend/ui/pulls/comments/170524055","pull_request_review_id":99219191,"id":170524055,"diff_hunk":"@@ -301,8 +322,14 @@ form {\n \n \t\t.error-detail {\n \t\t\tpadding-left: 0;\n+\t\t\tmargin-top: -10px;\n+\t\t\tmargin-bottom: 0;\n \n \t\t\t.text-danger {\n+\t\t\t\tline-height: 15px;","path":"packages/theme/src/theme/_forms.scss","position":177,"original_position":95,"commit_id":"8ad8c7e7de4a07f7c8d3511234f3bb4d141fd0b6","original_commit_id":"c5be61b8531716981fcdb128d848619116020b92","user":{"login":"talend-glorieux","id":19686241,"avatar_url":"https://avatars1.githubusercontent.com/u/19686241?v=4","gravatar_id":"","url":"https://api.github.com/users/talend-glorieux","html_url":"https://github.com/talend-glorieux","followers_url":"https://api.github.com/users/talend-glorieux/followers","following_url":"https://api.github.com/users/talend-glorieux/following{/other_user}","gists_url":"https://api.github.com/users/talend-glorieux/gists{/gist_id}","starred_url":"https://api.github.com/users/talend-glorieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talend-glorieux/subscriptions","organizations_url":"https://api.github.com/users/talend-glorieux/orgs","repos_url":"https://api.github.com/users/talend-glorieux/repos","events_url":"https://api.github.com/users/talend-glorieux/events{/privacy}","received_events_url":"https://api.github.com/users/talend-glorieux/received_events","type":"User","site_admin":false},"body":"OK. Could you make sure it's reflected on the guidelines?","created_at":"2018-02-26T08:47:19Z","updated_at":"2018-02-26T08:47:19Z","html_url":"https://github.com/Talend/ui/pull/1094#discussion_r170524055","pull_request_url":"https://api.github.com/repos/Talend/ui/pulls/1094","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Talend/ui/pulls/comments/170524055"},"html":{"href":"https://github.com/Talend/ui/pull/1094#discussion_r170524055"},"pull_request":{"href":"https://api.github.com/repos/Talend/ui/pulls/1094"}},"in_reply_to_id":170024754},"pull_request":{"url":"https://api.github.com/repos/Talend/ui/pulls/1094","id":170797900,"html_url":"https://github.com/Talend/ui/pull/1094","diff_url":"https://github.com/Talend/ui/pull/1094.diff","patch_url":"https://github.com/Talend/ui/pull/1094.patch","issue_url":"https://api.github.com/repos/Talend/ui/issues/1094","number":1094,"state":"open","locked":false,"title":"fix(theme): fix form fields styling issues according to the UI guidel…","user":{"login":"ybaskaran","id":34709414,"avatar_url":"https://avatars2.githubusercontent.com/u/34709414?v=4","gravatar_id":"","url":"https://api.github.com/users/ybaskaran","html_url":"https://github.com/ybaskaran","followers_url":"https://api.github.com/users/ybaskaran/followers","following_url":"https://api.github.com/users/ybaskaran/following{/other_user}","gists_url":"https://api.github.com/users/ybaskaran/gists{/gist_id}","starred_url":"https://api.github.com/users/ybaskaran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ybaskaran/subscriptions","organizations_url":"https://api.github.com/users/ybaskaran/orgs","repos_url":"https://api.github.com/users/ybaskaran/repos","events_url":"https://api.github.com/users/ybaskaran/events{/privacy}","received_events_url":"https://api.github.com/users/ybaskaran/received_events","type":"User","site_admin":false},"body":"…ines\r\n\r\n**What is the problem this PR is trying to solve?**\r\nSome of the form input fields styling doesn't follow UI guidelines http://guidelines.talend.com/document/92132#/ui-controls/input-field\r\n\r\n**What is the chosen solution to this problem?**\r\nFixes styling for all the form input fields\r\n\r\n**Please check if the PR fulfills these requirements**\r\n- [ ] The PR commit message follows our [guidelines](https://github.com/talend/tools/blob/master/tools-root-github/CONTRIBUTING.md)\r\n- [ ] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Docs have been added / updated (for bug fixes / features)\r\n- [ ] Related design / discussions / pages (not in jira), if any, are all linked or available in the PR\r\n\r\n<!-- You can add more checkboxes here -->\r\n\r\n**[ ] This PR introduces a breaking change**\r\n\r\n<!-- **Original Template** -->\r\n<!-- https://github.com/Talend/tools/blob/master/tools-root-github/.github/PULL_REQUEST_TEMPLATE.md -->\r\n\r\n","created_at":"2018-02-22T16:22:33Z","updated_at":"2018-02-26T08:47:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4adb060f72b3209180b6175f976632bfcaf3e1d9","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jsomsanith","id":10761073,"avatar_url":"https://avatars2.githubusercontent.com/u/10761073?v=4","gravatar_id":"","url":"https://api.github.com/users/jsomsanith","html_url":"https://github.com/jsomsanith","followers_url":"https://api.github.com/users/jsomsanith/followers","following_url":"https://api.github.com/users/jsomsanith/following{/other_user}","gists_url":"https://api.github.com/users/jsomsanith/gists{/gist_id}","starred_url":"https://api.github.com/users/jsomsanith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsomsanith/subscriptions","organizations_url":"https://api.github.com/users/jsomsanith/orgs","repos_url":"https://api.github.com/users/jsomsanith/repos","events_url":"https://api.github.com/users/jsomsanith/events{/privacy}","received_events_url":"https://api.github.com/users/jsomsanith/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":521021722,"url":"https://api.github.com/repos/Talend/ui/labels/need%20review","name":"need review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Talend/ui/pulls/1094/commits","review_comments_url":"https://api.github.com/repos/Talend/ui/pulls/1094/comments","review_comment_url":"https://api.github.com/repos/Talend/ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Talend/ui/issues/1094/comments","statuses_url":"https://api.github.com/repos/Talend/ui/statuses/8ad8c7e7de4a07f7c8d3511234f3bb4d141fd0b6","head":{"label":"Talend:yatheesh/fix/theme/TUI-87_form_fields_style_issues","ref":"yatheesh/fix/theme/TUI-87_form_fields_style_issues","sha":"8ad8c7e7de4a07f7c8d3511234f3bb4d141fd0b6","user":{"login":"Talend","id":459687,"avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":79343946,"name":"ui","full_name":"Talend/ui","owner":{"login":"Talend","id":459687,"avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Talend/ui","description":"Talend's unified web UI repository.","fork":false,"url":"https://api.github.com/repos/Talend/ui","forks_url":"https://api.github.com/repos/Talend/ui/forks","keys_url":"https://api.github.com/repos/Talend/ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/ui/teams","hooks_url":"https://api.github.com/repos/Talend/ui/hooks","issue_events_url":"https://api.github.com/repos/Talend/ui/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/ui/events","assignees_url":"https://api.github.com/repos/Talend/ui/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/ui/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/ui/tags","blobs_url":"https://api.github.com/repos/Talend/ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/ui/languages","stargazers_url":"https://api.github.com/repos/Talend/ui/stargazers","contributors_url":"https://api.github.com/repos/Talend/ui/contributors","subscribers_url":"https://api.github.com/repos/Talend/ui/subscribers","subscription_url":"https://api.github.com/repos/Talend/ui/subscription","commits_url":"https://api.github.com/repos/Talend/ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/ui/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/ui/merges","archive_url":"https://api.github.com/repos/Talend/ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/ui/downloads","issues_url":"https://api.github.com/repos/Talend/ui/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/ui/labels{/name}","releases_url":"https://api.github.com/repos/Talend/ui/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/ui/deployments","created_at":"2017-01-18T13:45:58Z","updated_at":"2018-02-21T16:13:53Z","pushed_at":"2018-02-26T07:19:35Z","git_url":"git://github.com/Talend/ui.git","ssh_url":"git@github.com:Talend/ui.git","clone_url":"https://github.com/Talend/ui.git","svn_url":"https://github.com/Talend/ui","homepage":"http://talend.surge.sh","size":23958,"stargazers_count":40,"watchers_count":40,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":18,"open_issues":43,"watchers":40,"default_branch":"master"}},"base":{"label":"Talend:master","ref":"master","sha":"8ba2ed3a255cf0847ce5928810015450ca989c95","user":{"login":"Talend","id":459687,"avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":79343946,"name":"ui","full_name":"Talend/ui","owner":{"login":"Talend","id":459687,"avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Talend/ui","description":"Talend's unified web UI repository.","fork":false,"url":"https://api.github.com/repos/Talend/ui","forks_url":"https://api.github.com/repos/Talend/ui/forks","keys_url":"https://api.github.com/repos/Talend/ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/ui/teams","hooks_url":"https://api.github.com/repos/Talend/ui/hooks","issue_events_url":"https://api.github.com/repos/Talend/ui/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/ui/events","assignees_url":"https://api.github.com/repos/Talend/ui/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/ui/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/ui/tags","blobs_url":"https://api.github.com/repos/Talend/ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/ui/languages","stargazers_url":"https://api.github.com/repos/Talend/ui/stargazers","contributors_url":"https://api.github.com/repos/Talend/ui/contributors","subscribers_url":"https://api.github.com/repos/Talend/ui/subscribers","subscription_url":"https://api.github.com/repos/Talend/ui/subscription","commits_url":"https://api.github.com/repos/Talend/ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/ui/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/ui/merges","archive_url":"https://api.github.com/repos/Talend/ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/ui/downloads","issues_url":"https://api.github.com/repos/Talend/ui/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/ui/labels{/name}","releases_url":"https://api.github.com/repos/Talend/ui/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/ui/deployments","created_at":"2017-01-18T13:45:58Z","updated_at":"2018-02-21T16:13:53Z","pushed_at":"2018-02-26T07:19:35Z","git_url":"git://github.com/Talend/ui.git","ssh_url":"git@github.com:Talend/ui.git","clone_url":"https://github.com/Talend/ui.git","svn_url":"https://github.com/Talend/ui","homepage":"http://talend.surge.sh","size":23958,"stargazers_count":40,"watchers_count":40,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":18,"open_issues":43,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Talend/ui/pulls/1094"},"html":{"href":"https://github.com/Talend/ui/pull/1094"},"issue":{"href":"https://api.github.com/repos/Talend/ui/issues/1094"},"comments":{"href":"https://api.github.com/repos/Talend/ui/issues/1094/comments"},"review_comments":{"href":"https://api.github.com/repos/Talend/ui/pulls/1094/comments"},"review_comment":{"href":"https://api.github.com/repos/Talend/ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Talend/ui/pulls/1094/commits"},"statuses":{"href":"https://api.github.com/repos/Talend/ui/statuses/8ad8c7e7de4a07f7c8d3511234f3bb4d141fd0b6"}},"author_association":"NONE"}}
{"actor":{"display_login":"talend-glorieux"}}