{"action":"created","comment":{"url":"https://api.github.com/repos/material-components/material-components-web/pulls/comments/238556341","pull_request_review_id":181124738,"id":238556341,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODU1NjM0MQ==","diff_hunk":"@@ -207,6 +162,16 @@ class MDCListFoundation extends MDCFoundation {\n     if (listItemIndex >= 0) {\n       this.adapter_.setTabIndexForListItemChildren(listItemIndex, -1);\n     }\n+\n+    /**\n+     * Between Focusout & Focusin some browsers do not have focus on any element. Setting a delay to wait till the focus\n+     * is moved to next element.\n+     */\n+    setTimeout(() => {","path":"packages/mdc-list/foundation.js","position":171,"original_position":154,"commit_id":"626d98a3708d5a02ddb9a16267fff98bd67f8cae","original_commit_id":"ab83f8f74a30136461cda24e5710b5308633b5fc","user":{"login":"abhiomkar","id":47312,"node_id":"MDQ6VXNlcjQ3MzEy","avatar_url":"https://avatars3.githubusercontent.com/u/47312?v=4","gravatar_id":"","url":"https://api.github.com/users/abhiomkar","html_url":"https://github.com/abhiomkar","followers_url":"https://api.github.com/users/abhiomkar/followers","following_url":"https://api.github.com/users/abhiomkar/following{/other_user}","gists_url":"https://api.github.com/users/abhiomkar/gists{/gist_id}","starred_url":"https://api.github.com/users/abhiomkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhiomkar/subscriptions","organizations_url":"https://api.github.com/users/abhiomkar/orgs","repos_url":"https://api.github.com/users/abhiomkar/repos","events_url":"https://api.github.com/users/abhiomkar/events{/privacy}","received_events_url":"https://api.github.com/users/abhiomkar/received_events","type":"User","site_admin":false},"body":"I found a bug where checkbox based list end up having multiple tab stops.\r\n\r\nSteps to reproduce:\r\n\r\n1. Add `tabindex=0` to selected checkbox item.\r\n2. programmatically set selected index. (Shouldn't change the tabindex state)\r\n3. Check other list items. Since there is no trace of list item that had `tabindex=0` during render, it ends up adding second tab stop on last selected / checked list item.","created_at":"2018-12-04T07:54:06Z","updated_at":"2018-12-04T07:54:07Z","html_url":"https://github.com/material-components/material-components-web/pull/4124#discussion_r238556341","pull_request_url":"https://api.github.com/repos/material-components/material-components-web/pulls/4124","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/comments/238556341"},"html":{"href":"https://github.com/material-components/material-components-web/pull/4124#discussion_r238556341"},"pull_request":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/4124"}},"in_reply_to_id":238467300},"pull_request":{"url":"https://api.github.com/repos/material-components/material-components-web/pulls/4124","id":234459662,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NDU5NjYy","html_url":"https://github.com/material-components/material-components-web/pull/4124","diff_url":"https://github.com/material-components/material-components-web/pull/4124.diff","patch_url":"https://github.com/material-components/material-components-web/pull/4124.patch","issue_url":"https://api.github.com/repos/material-components/material-components-web/issues/4124","number":4124,"state":"open","locked":false,"title":"fix(list): Accept array of index for selectedIndex API","user":{"login":"abhiomkar","id":47312,"node_id":"MDQ6VXNlcjQ3MzEy","avatar_url":"https://avatars3.githubusercontent.com/u/47312?v=4","gravatar_id":"","url":"https://api.github.com/users/abhiomkar","html_url":"https://github.com/abhiomkar","followers_url":"https://api.github.com/users/abhiomkar/followers","following_url":"https://api.github.com/users/abhiomkar/following{/other_user}","gists_url":"https://api.github.com/users/abhiomkar/gists{/gist_id}","starred_url":"https://api.github.com/users/abhiomkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhiomkar/subscriptions","organizations_url":"https://api.github.com/users/abhiomkar/orgs","repos_url":"https://api.github.com/users/abhiomkar/repos","events_url":"https://api.github.com/users/abhiomkar/events{/privacy}","received_events_url":"https://api.github.com/users/abhiomkar/received_events","type":"User","site_admin":false},"body":"Before this implementation `selectedIndex` component API (that proxies foundation's `setSelectedIndex`) use to accept only single number index. This change adds support for multiple indexes that sets the state of checkboxes.\r\n\r\n**New behaviour for checkbox based list**\r\n\r\n```\r\n[ ] option 1\r\n[ ] option 2\r\n[ ] option 3\r\n[ ] option 4\r\n\r\nselectedIndex = [1, 3];\r\n\r\n[ ] option 1\r\n[x] option 2\r\n[ ] option 3\r\n[x] option 4\r\n\r\nselectedIndex = [2, 3];\r\n\r\n[ ] option 1\r\n[ ] option 2\r\n[x] option 3\r\n[x] option 4\r\n\r\nselectedIndex = [];\r\n\r\n[ ] option 1\r\n[ ] option 2\r\n[ ] option 3\r\n[ ] option 4\r\n\r\nselectedIndex = 2;\r\n\r\n// Throws error\r\n\r\n```\r\n\r\n**Other changes:**\r\n\r\n- getter API for `selectedIndex` that returns the current state of selection for all variants.\r\n- Tabindex is set to `0` for currently focused element and will be reverted to first selected element on focus out of list root.\r\n- new adapter method `isFocusInsideList`.\r\n\r\nFixes #4122","created_at":"2018-11-28T23:30:07Z","updated_at":"2018-12-04T07:54:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18a24d0831d51ee99569643070bac4183b27742d","assignee":{"login":"abhiomkar","id":47312,"node_id":"MDQ6VXNlcjQ3MzEy","avatar_url":"https://avatars3.githubusercontent.com/u/47312?v=4","gravatar_id":"","url":"https://api.github.com/users/abhiomkar","html_url":"https://github.com/abhiomkar","followers_url":"https://api.github.com/users/abhiomkar/followers","following_url":"https://api.github.com/users/abhiomkar/following{/other_user}","gists_url":"https://api.github.com/users/abhiomkar/gists{/gist_id}","starred_url":"https://api.github.com/users/abhiomkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhiomkar/subscriptions","organizations_url":"https://api.github.com/users/abhiomkar/orgs","repos_url":"https://api.github.com/users/abhiomkar/repos","events_url":"https://api.github.com/users/abhiomkar/events{/privacy}","received_events_url":"https://api.github.com/users/abhiomkar/received_events","type":"User","site_admin":false},"assignees":[{"login":"abhiomkar","id":47312,"node_id":"MDQ6VXNlcjQ3MzEy","avatar_url":"https://avatars3.githubusercontent.com/u/47312?v=4","gravatar_id":"","url":"https://api.github.com/users/abhiomkar","html_url":"https://github.com/abhiomkar","followers_url":"https://api.github.com/users/abhiomkar/followers","following_url":"https://api.github.com/users/abhiomkar/following{/other_user}","gists_url":"https://api.github.com/users/abhiomkar/gists{/gist_id}","starred_url":"https://api.github.com/users/abhiomkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhiomkar/subscriptions","organizations_url":"https://api.github.com/users/abhiomkar/orgs","repos_url":"https://api.github.com/users/abhiomkar/repos","events_url":"https://api.github.com/users/abhiomkar/events{/privacy}","received_events_url":"https://api.github.com/users/abhiomkar/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1036895551,"node_id":"MDU6TGFiZWwxMDM2ODk1NTUx","url":"https://api.github.com/repos/material-components/material-components-web/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/material-components/material-components-web/pulls/4124/commits","review_comments_url":"https://api.github.com/repos/material-components/material-components-web/pulls/4124/comments","review_comment_url":"https://api.github.com/repos/material-components/material-components-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/material-components/material-components-web/issues/4124/comments","statuses_url":"https://api.github.com/repos/material-components/material-components-web/statuses/626d98a3708d5a02ddb9a16267fff98bd67f8cae","head":{"label":"material-components:fix/list_checkbox_selectedindex","ref":"fix/list_checkbox_selectedindex","sha":"626d98a3708d5a02ddb9a16267fff98bd67f8cae","user":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"repo":{"id":75642389,"node_id":"MDEwOlJlcG9zaXRvcnk3NTY0MjM4OQ==","name":"material-components-web","full_name":"material-components/material-components-web","private":false,"owner":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/material-components/material-components-web","description":"Modular and customizable Material Design UI components for the web","fork":false,"url":"https://api.github.com/repos/material-components/material-components-web","forks_url":"https://api.github.com/repos/material-components/material-components-web/forks","keys_url":"https://api.github.com/repos/material-components/material-components-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/material-components/material-components-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/material-components/material-components-web/teams","hooks_url":"https://api.github.com/repos/material-components/material-components-web/hooks","issue_events_url":"https://api.github.com/repos/material-components/material-components-web/issues/events{/number}","events_url":"https://api.github.com/repos/material-components/material-components-web/events","assignees_url":"https://api.github.com/repos/material-components/material-components-web/assignees{/user}","branches_url":"https://api.github.com/repos/material-components/material-components-web/branches{/branch}","tags_url":"https://api.github.com/repos/material-components/material-components-web/tags","blobs_url":"https://api.github.com/repos/material-components/material-components-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/material-components/material-components-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/material-components/material-components-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/material-components/material-components-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/material-components/material-components-web/statuses/{sha}","languages_url":"https://api.github.com/repos/material-components/material-components-web/languages","stargazers_url":"https://api.github.com/repos/material-components/material-components-web/stargazers","contributors_url":"https://api.github.com/repos/material-components/material-components-web/contributors","subscribers_url":"https://api.github.com/repos/material-components/material-components-web/subscribers","subscription_url":"https://api.github.com/repos/material-components/material-components-web/subscription","commits_url":"https://api.github.com/repos/material-components/material-components-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/material-components/material-components-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/material-components/material-components-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/material-components/material-components-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/material-components/material-components-web/contents/{+path}","compare_url":"https://api.github.com/repos/material-components/material-components-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/material-components/material-components-web/merges","archive_url":"https://api.github.com/repos/material-components/material-components-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/material-components/material-components-web/downloads","issues_url":"https://api.github.com/repos/material-components/material-components-web/issues{/number}","pulls_url":"https://api.github.com/repos/material-components/material-components-web/pulls{/number}","milestones_url":"https://api.github.com/repos/material-components/material-components-web/milestones{/number}","notifications_url":"https://api.github.com/repos/material-components/material-components-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/material-components/material-components-web/labels{/name}","releases_url":"https://api.github.com/repos/material-components/material-components-web/releases{/id}","deployments_url":"https://api.github.com/repos/material-components/material-components-web/deployments","created_at":"2016-12-05T16:04:09Z","updated_at":"2018-12-04T05:54:02Z","pushed_at":"2018-12-04T07:53:31Z","git_url":"git://github.com/material-components/material-components-web.git","ssh_url":"git@github.com:material-components/material-components-web.git","clone_url":"https://github.com/material-components/material-components-web.git","svn_url":"https://github.com/material-components/material-components-web","homepage":"https://material.io/develop/","size":72846,"stargazers_count":10969,"watchers_count":10969,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1350,"mirror_url":null,"archived":false,"open_issues_count":336,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1350,"open_issues":336,"watchers":10969,"default_branch":"master"}},"base":{"label":"material-components:master","ref":"master","sha":"32b53f93254c93cede0f77be45a15ddd24ca8932","user":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"repo":{"id":75642389,"node_id":"MDEwOlJlcG9zaXRvcnk3NTY0MjM4OQ==","name":"material-components-web","full_name":"material-components/material-components-web","private":false,"owner":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/material-components/material-components-web","description":"Modular and customizable Material Design UI components for the web","fork":false,"url":"https://api.github.com/repos/material-components/material-components-web","forks_url":"https://api.github.com/repos/material-components/material-components-web/forks","keys_url":"https://api.github.com/repos/material-components/material-components-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/material-components/material-components-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/material-components/material-components-web/teams","hooks_url":"https://api.github.com/repos/material-components/material-components-web/hooks","issue_events_url":"https://api.github.com/repos/material-components/material-components-web/issues/events{/number}","events_url":"https://api.github.com/repos/material-components/material-components-web/events","assignees_url":"https://api.github.com/repos/material-components/material-components-web/assignees{/user}","branches_url":"https://api.github.com/repos/material-components/material-components-web/branches{/branch}","tags_url":"https://api.github.com/repos/material-components/material-components-web/tags","blobs_url":"https://api.github.com/repos/material-components/material-components-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/material-components/material-components-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/material-components/material-components-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/material-components/material-components-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/material-components/material-components-web/statuses/{sha}","languages_url":"https://api.github.com/repos/material-components/material-components-web/languages","stargazers_url":"https://api.github.com/repos/material-components/material-components-web/stargazers","contributors_url":"https://api.github.com/repos/material-components/material-components-web/contributors","subscribers_url":"https://api.github.com/repos/material-components/material-components-web/subscribers","subscription_url":"https://api.github.com/repos/material-components/material-components-web/subscription","commits_url":"https://api.github.com/repos/material-components/material-components-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/material-components/material-components-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/material-components/material-components-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/material-components/material-components-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/material-components/material-components-web/contents/{+path}","compare_url":"https://api.github.com/repos/material-components/material-components-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/material-components/material-components-web/merges","archive_url":"https://api.github.com/repos/material-components/material-components-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/material-components/material-components-web/downloads","issues_url":"https://api.github.com/repos/material-components/material-components-web/issues{/number}","pulls_url":"https://api.github.com/repos/material-components/material-components-web/pulls{/number}","milestones_url":"https://api.github.com/repos/material-components/material-components-web/milestones{/number}","notifications_url":"https://api.github.com/repos/material-components/material-components-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/material-components/material-components-web/labels{/name}","releases_url":"https://api.github.com/repos/material-components/material-components-web/releases{/id}","deployments_url":"https://api.github.com/repos/material-components/material-components-web/deployments","created_at":"2016-12-05T16:04:09Z","updated_at":"2018-12-04T05:54:02Z","pushed_at":"2018-12-04T07:53:31Z","git_url":"git://github.com/material-components/material-components-web.git","ssh_url":"git@github.com:material-components/material-components-web.git","clone_url":"https://github.com/material-components/material-components-web.git","svn_url":"https://github.com/material-components/material-components-web","homepage":"https://material.io/develop/","size":72846,"stargazers_count":10969,"watchers_count":10969,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1350,"mirror_url":null,"archived":false,"open_issues_count":336,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1350,"open_issues":336,"watchers":10969,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/4124"},"html":{"href":"https://github.com/material-components/material-components-web/pull/4124"},"issue":{"href":"https://api.github.com/repos/material-components/material-components-web/issues/4124"},"comments":{"href":"https://api.github.com/repos/material-components/material-components-web/issues/4124/comments"},"review_comments":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/4124/comments"},"review_comment":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/4124/commits"},"statuses":{"href":"https://api.github.com/repos/material-components/material-components-web/statuses/626d98a3708d5a02ddb9a16267fff98bd67f8cae"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"abhiomkar"}}