{"action":"created","issue":{"url":"https://api.github.com/repos/krvajal/vscode-fortran-support/issues/76","repository_url":"https://api.github.com/repos/krvajal/vscode-fortran-support","labels_url":"https://api.github.com/repos/krvajal/vscode-fortran-support/issues/76/labels{/name}","comments_url":"https://api.github.com/repos/krvajal/vscode-fortran-support/issues/76/comments","events_url":"https://api.github.com/repos/krvajal/vscode-fortran-support/issues/76/events","html_url":"https://github.com/krvajal/vscode-fortran-support/pull/76","id":333094943,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1Mzk2NDkz","number":76,"title":"Subroutine arguments highlight improvement.","user":{"login":"pedro-ricardo","id":15893711,"node_id":"MDQ6VXNlcjE1ODkzNzEx","avatar_url":"https://avatars2.githubusercontent.com/u/15893711?v=4","gravatar_id":"","url":"https://api.github.com/users/pedro-ricardo","html_url":"https://github.com/pedro-ricardo","followers_url":"https://api.github.com/users/pedro-ricardo/followers","following_url":"https://api.github.com/users/pedro-ricardo/following{/other_user}","gists_url":"https://api.github.com/users/pedro-ricardo/gists{/gist_id}","starred_url":"https://api.github.com/users/pedro-ricardo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedro-ricardo/subscriptions","organizations_url":"https://api.github.com/users/pedro-ricardo/orgs","repos_url":"https://api.github.com/users/pedro-ricardo/repos","events_url":"https://api.github.com/users/pedro-ricardo/events{/privacy}","received_events_url":"https://api.github.com/users/pedro-ricardo/received_events","type":"User","site_admin":false},"labels":[{"id":863653525,"node_id":"MDU6TGFiZWw4NjM2NTM1MjU=","url":"https://api.github.com/repos/krvajal/vscode-fortran-support/labels/syntax-highlight","name":"syntax-highlight","color":"55e04e","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-06-17T21:39:02Z","updated_at":"2018-06-27T01:37:54Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/krvajal/vscode-fortran-support/pulls/76","html_url":"https://github.com/krvajal/vscode-fortran-support/pull/76","diff_url":"https://github.com/krvajal/vscode-fortran-support/pull/76.diff","patch_url":"https://github.com/krvajal/vscode-fortran-support/pull/76.patch"},"body":"Stop ending the subroutine `dummy-variable-list` at line break and look for the next `)` to end it.\r\nThis fixes issue #70.\r\n\r\nIt is important to notice that this fix suffers from the same problem as the string markers `'` and `\"\"`.\r\nNow the argument list starts once `(` is typed **in subroutine header** and only ends when the `)` is found.\r\n\r\nSo, just like the string ones, if you leave the braket open it will keep highlighting. But since Fortran does not allow an open braket on a subroutine I don't believe this is an issue.\r\n\r\n### Fix checklist\r\n- [x] Highlight multiple lines in `dummy-variable-list`\r\n- [x] Modify rule to look for `&` character"},"comment":{"url":"https://api.github.com/repos/krvajal/vscode-fortran-support/issues/comments/400515154","html_url":"https://github.com/krvajal/vscode-fortran-support/pull/76#issuecomment-400515154","issue_url":"https://api.github.com/repos/krvajal/vscode-fortran-support/issues/76","id":400515154,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDUxNTE1NA==","user":{"login":"pedro-ricardo","id":15893711,"node_id":"MDQ6VXNlcjE1ODkzNzEx","avatar_url":"https://avatars2.githubusercontent.com/u/15893711?v=4","gravatar_id":"","url":"https://api.github.com/users/pedro-ricardo","html_url":"https://github.com/pedro-ricardo","followers_url":"https://api.github.com/users/pedro-ricardo/followers","following_url":"https://api.github.com/users/pedro-ricardo/following{/other_user}","gists_url":"https://api.github.com/users/pedro-ricardo/gists{/gist_id}","starred_url":"https://api.github.com/users/pedro-ricardo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedro-ricardo/subscriptions","organizations_url":"https://api.github.com/users/pedro-ricardo/orgs","repos_url":"https://api.github.com/users/pedro-ricardo/repos","events_url":"https://api.github.com/users/pedro-ricardo/events{/privacy}","received_events_url":"https://api.github.com/users/pedro-ricardo/received_events","type":"User","site_admin":false},"created_at":"2018-06-27T01:37:54Z","updated_at":"2018-06-27T01:37:54Z","author_association":"COLLABORATOR","body":"Latest commit:\r\n* Added back the `\\n` as an possible end of the `dummy-variable-list` to avoid the keep highlighting issue\r\n* Added the `line-continuation-operator` to identify `&` and extend `dummy-variable-list`\r\n\r\nNow it will only highlight the second line if the first ends with `&` followed by possible blank spaces:\r\n![high](https://user-images.githubusercontent.com/15893711/41947993-1bb0ba84-7991-11e8-8df3-356b8f63a13b.png)\r\nI think that's it"}}
{"actor":{"display_login":"pedro-ricardo"}}