{"action":"created","comment":{"url":"https://api.github.com/repos/endlessm/gnome-shell/pulls/comments/208236928","pull_request_review_id":143987758,"id":208236928,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODIzNjkyOA==","diff_hunk":"@@ -769,6 +843,21 @@ var EndSessionDialog = new Lang.Class({\n                 this._type = DialogType.UPGRADE_RESTART;\n         }\n \n+        this._syncUpdateStatus();\n+\n+        /* If this._parameters has already saved parameters, it means that we have shown\n+         * warning dialog(UPDATES_SCHEDULED DialogType) to the user. So, now skip it and\n+         * show regular shutdown dialog.\n+         */","path":"js/ui/endSessionDialog.js","position":170,"original_position":170,"commit_id":"d45e529acb7e751a0cc377fc2a9a05c31f1dda8d","original_commit_id":"d45e529acb7e751a0cc377fc2a9a05c31f1dda8d","user":{"login":"GeorgesStavracas","id":3518204,"node_id":"MDQ6VXNlcjM1MTgyMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3518204?v=4","gravatar_id":"","url":"https://api.github.com/users/GeorgesStavracas","html_url":"https://github.com/GeorgesStavracas","followers_url":"https://api.github.com/users/GeorgesStavracas/followers","following_url":"https://api.github.com/users/GeorgesStavracas/following{/other_user}","gists_url":"https://api.github.com/users/GeorgesStavracas/gists{/gist_id}","starred_url":"https://api.github.com/users/GeorgesStavracas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeorgesStavracas/subscriptions","organizations_url":"https://api.github.com/users/GeorgesStavracas/orgs","repos_url":"https://api.github.com/users/GeorgesStavracas/repos","events_url":"https://api.github.com/users/GeorgesStavracas/events{/privacy}","received_events_url":"https://api.github.com/users/GeorgesStavracas/received_events","type":"User","site_admin":false},"body":"Either rework this comment to be more descriptive and shorter, or remove it whatsoever. It doesn't really add to the codebase.","created_at":"2018-08-07T13:49:02Z","updated_at":"2018-08-07T13:53:51Z","html_url":"https://github.com/endlessm/gnome-shell/pull/279#discussion_r208236928","pull_request_url":"https://api.github.com/repos/endlessm/gnome-shell/pulls/279","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/endlessm/gnome-shell/pulls/comments/208236928"},"html":{"href":"https://github.com/endlessm/gnome-shell/pull/279#discussion_r208236928"},"pull_request":{"href":"https://api.github.com/repos/endlessm/gnome-shell/pulls/279"}}},"pull_request":{"url":"https://api.github.com/repos/endlessm/gnome-shell/pulls/279","id":205102469,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MTAyNDY5","html_url":"https://github.com/endlessm/gnome-shell/pull/279","diff_url":"https://github.com/endlessm/gnome-shell/pull/279.diff","patch_url":"https://github.com/endlessm/gnome-shell/pull/279.patch","issue_url":"https://api.github.com/repos/endlessm/gnome-shell/issues/279","number":279,"state":"open","locked":false,"title":"Implement scheduled updates warning dialog","user":{"login":"uajain","id":8775041,"node_id":"MDQ6VXNlcjg3NzUwNDE=","avatar_url":"https://avatars0.githubusercontent.com/u/8775041?v=4","gravatar_id":"","url":"https://api.github.com/users/uajain","html_url":"https://github.com/uajain","followers_url":"https://api.github.com/users/uajain/followers","following_url":"https://api.github.com/users/uajain/following{/other_user}","gists_url":"https://api.github.com/users/uajain/gists{/gist_id}","starred_url":"https://api.github.com/users/uajain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uajain/subscriptions","organizations_url":"https://api.github.com/users/uajain/orgs","repos_url":"https://api.github.com/users/uajain/repos","events_url":"https://api.github.com/users/uajain/events{/privacy}","received_events_url":"https://api.github.com/users/uajain/received_events","type":"User","site_admin":false},"body":"Currently, if you try to test this PR, it will open up warning's dialog no matter what. I am stuck to resolve that problem (mentioned below in  PR comment) and need help with that.\r\n\r\nAlso TODO:\r\n* Icons\r\n* More rigorous DevQA \r\n\r\nhttps://phabricator.endlessm.com/T22888","created_at":"2018-07-31T12:54:19Z","updated_at":"2018-08-07T13:53:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4cd4c22a868bb615c434a4368ff8c73b2bdbdc89","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/endlessm/gnome-shell/pulls/279/commits","review_comments_url":"https://api.github.com/repos/endlessm/gnome-shell/pulls/279/comments","review_comment_url":"https://api.github.com/repos/endlessm/gnome-shell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/endlessm/gnome-shell/issues/279/comments","statuses_url":"https://api.github.com/repos/endlessm/gnome-shell/statuses/d45e529acb7e751a0cc377fc2a9a05c31f1dda8d","head":{"label":"uajain:scheduled-updates-dialog-2","ref":"scheduled-updates-dialog-2","sha":"d45e529acb7e751a0cc377fc2a9a05c31f1dda8d","user":{"login":"uajain","id":8775041,"node_id":"MDQ6VXNlcjg3NzUwNDE=","avatar_url":"https://avatars0.githubusercontent.com/u/8775041?v=4","gravatar_id":"","url":"https://api.github.com/users/uajain","html_url":"https://github.com/uajain","followers_url":"https://api.github.com/users/uajain/followers","following_url":"https://api.github.com/users/uajain/following{/other_user}","gists_url":"https://api.github.com/users/uajain/gists{/gist_id}","starred_url":"https://api.github.com/users/uajain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uajain/subscriptions","organizations_url":"https://api.github.com/users/uajain/orgs","repos_url":"https://api.github.com/users/uajain/repos","events_url":"https://api.github.com/users/uajain/events{/privacy}","received_events_url":"https://api.github.com/users/uajain/received_events","type":"User","site_admin":false},"repo":{"id":141428786,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE0Mjg3ODY=","name":"gnome-shell","full_name":"uajain/gnome-shell","owner":{"login":"uajain","id":8775041,"node_id":"MDQ6VXNlcjg3NzUwNDE=","avatar_url":"https://avatars0.githubusercontent.com/u/8775041?v=4","gravatar_id":"","url":"https://api.github.com/users/uajain","html_url":"https://github.com/uajain","followers_url":"https://api.github.com/users/uajain/followers","following_url":"https://api.github.com/users/uajain/following{/other_user}","gists_url":"https://api.github.com/users/uajain/gists{/gist_id}","starred_url":"https://api.github.com/users/uajain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uajain/subscriptions","organizations_url":"https://api.github.com/users/uajain/orgs","repos_url":"https://api.github.com/users/uajain/repos","events_url":"https://api.github.com/users/uajain/events{/privacy}","received_events_url":"https://api.github.com/users/uajain/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/uajain/gnome-shell","description":"Fork of https://git.gnome.org/browse/gnome-shell","fork":true,"url":"https://api.github.com/repos/uajain/gnome-shell","forks_url":"https://api.github.com/repos/uajain/gnome-shell/forks","keys_url":"https://api.github.com/repos/uajain/gnome-shell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uajain/gnome-shell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uajain/gnome-shell/teams","hooks_url":"https://api.github.com/repos/uajain/gnome-shell/hooks","issue_events_url":"https://api.github.com/repos/uajain/gnome-shell/issues/events{/number}","events_url":"https://api.github.com/repos/uajain/gnome-shell/events","assignees_url":"https://api.github.com/repos/uajain/gnome-shell/assignees{/user}","branches_url":"https://api.github.com/repos/uajain/gnome-shell/branches{/branch}","tags_url":"https://api.github.com/repos/uajain/gnome-shell/tags","blobs_url":"https://api.github.com/repos/uajain/gnome-shell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uajain/gnome-shell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uajain/gnome-shell/git/refs{/sha}","trees_url":"https://api.github.com/repos/uajain/gnome-shell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uajain/gnome-shell/statuses/{sha}","languages_url":"https://api.github.com/repos/uajain/gnome-shell/languages","stargazers_url":"https://api.github.com/repos/uajain/gnome-shell/stargazers","contributors_url":"https://api.github.com/repos/uajain/gnome-shell/contributors","subscribers_url":"https://api.github.com/repos/uajain/gnome-shell/subscribers","subscription_url":"https://api.github.com/repos/uajain/gnome-shell/subscription","commits_url":"https://api.github.com/repos/uajain/gnome-shell/commits{/sha}","git_commits_url":"https://api.github.com/repos/uajain/gnome-shell/git/commits{/sha}","comments_url":"https://api.github.com/repos/uajain/gnome-shell/comments{/number}","issue_comment_url":"https://api.github.com/repos/uajain/gnome-shell/issues/comments{/number}","contents_url":"https://api.github.com/repos/uajain/gnome-shell/contents/{+path}","compare_url":"https://api.github.com/repos/uajain/gnome-shell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uajain/gnome-shell/merges","archive_url":"https://api.github.com/repos/uajain/gnome-shell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uajain/gnome-shell/downloads","issues_url":"https://api.github.com/repos/uajain/gnome-shell/issues{/number}","pulls_url":"https://api.github.com/repos/uajain/gnome-shell/pulls{/number}","milestones_url":"https://api.github.com/repos/uajain/gnome-shell/milestones{/number}","notifications_url":"https://api.github.com/repos/uajain/gnome-shell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uajain/gnome-shell/labels{/name}","releases_url":"https://api.github.com/repos/uajain/gnome-shell/releases{/id}","deployments_url":"https://api.github.com/repos/uajain/gnome-shell/deployments","created_at":"2018-07-18T11:59:36Z","updated_at":"2018-07-18T11:59:40Z","pushed_at":"2018-08-07T10:22:47Z","git_url":"git://github.com/uajain/gnome-shell.git","ssh_url":"git@github.com:uajain/gnome-shell.git","clone_url":"https://github.com/uajain/gnome-shell.git","svn_url":"https://github.com/uajain/gnome-shell","homepage":null,"size":26879,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"endlessm:master","ref":"master","sha":"e3630f37faeb05af1fe365473be9316cfc177204","user":{"login":"endlessm","id":1930958,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MzA5NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1930958?v=4","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":84589501,"node_id":"MDEwOlJlcG9zaXRvcnk4NDU4OTUwMQ==","name":"gnome-shell","full_name":"endlessm/gnome-shell","owner":{"login":"endlessm","id":1930958,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MzA5NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1930958?v=4","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endlessm/gnome-shell","description":"Fork of https://git.gnome.org/browse/gnome-shell","fork":false,"url":"https://api.github.com/repos/endlessm/gnome-shell","forks_url":"https://api.github.com/repos/endlessm/gnome-shell/forks","keys_url":"https://api.github.com/repos/endlessm/gnome-shell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/gnome-shell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/gnome-shell/teams","hooks_url":"https://api.github.com/repos/endlessm/gnome-shell/hooks","issue_events_url":"https://api.github.com/repos/endlessm/gnome-shell/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/gnome-shell/events","assignees_url":"https://api.github.com/repos/endlessm/gnome-shell/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/gnome-shell/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/gnome-shell/tags","blobs_url":"https://api.github.com/repos/endlessm/gnome-shell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/gnome-shell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/gnome-shell/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/gnome-shell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/gnome-shell/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/gnome-shell/languages","stargazers_url":"https://api.github.com/repos/endlessm/gnome-shell/stargazers","contributors_url":"https://api.github.com/repos/endlessm/gnome-shell/contributors","subscribers_url":"https://api.github.com/repos/endlessm/gnome-shell/subscribers","subscription_url":"https://api.github.com/repos/endlessm/gnome-shell/subscription","commits_url":"https://api.github.com/repos/endlessm/gnome-shell/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/gnome-shell/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/gnome-shell/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/gnome-shell/issues/comments{/number}","contents_url":"https://api.github.com/repos/endlessm/gnome-shell/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/gnome-shell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/gnome-shell/merges","archive_url":"https://api.github.com/repos/endlessm/gnome-shell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/gnome-shell/downloads","issues_url":"https://api.github.com/repos/endlessm/gnome-shell/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/gnome-shell/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/gnome-shell/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/gnome-shell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/gnome-shell/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/gnome-shell/releases{/id}","deployments_url":"https://api.github.com/repos/endlessm/gnome-shell/deployments","created_at":"2017-03-10T18:30:50Z","updated_at":"2018-08-07T13:11:33Z","pushed_at":"2018-08-07T13:11:36Z","git_url":"git://github.com/endlessm/gnome-shell.git","ssh_url":"git@github.com:endlessm/gnome-shell.git","clone_url":"https://github.com/endlessm/gnome-shell.git","svn_url":"https://github.com/endlessm/gnome-shell","homepage":null,"size":26899,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":4,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/endlessm/gnome-shell/pulls/279"},"html":{"href":"https://github.com/endlessm/gnome-shell/pull/279"},"issue":{"href":"https://api.github.com/repos/endlessm/gnome-shell/issues/279"},"comments":{"href":"https://api.github.com/repos/endlessm/gnome-shell/issues/279/comments"},"review_comments":{"href":"https://api.github.com/repos/endlessm/gnome-shell/pulls/279/comments"},"review_comment":{"href":"https://api.github.com/repos/endlessm/gnome-shell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/endlessm/gnome-shell/pulls/279/commits"},"statuses":{"href":"https://api.github.com/repos/endlessm/gnome-shell/statuses/d45e529acb7e751a0cc377fc2a9a05c31f1dda8d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"GeorgesStavracas"}}