{"action":"created","issue":{"url":"https://api.github.com/repos/cta-observatory/cta-lstchain/issues/30","repository_url":"https://api.github.com/repos/cta-observatory/cta-lstchain","labels_url":"https://api.github.com/repos/cta-observatory/cta-lstchain/issues/30/labels{/name}","comments_url":"https://api.github.com/repos/cta-observatory/cta-lstchain/issues/30/comments","events_url":"https://api.github.com/repos/cta-observatory/cta-lstchain/issues/30/events","html_url":"https://github.com/cta-observatory/cta-lstchain/pull/30","id":381225740,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMjQ1MzM4","number":30,"title":"adding new io container for DL1 mono reconstruction and example notebook on how to use it","user":{"login":"vuillaut","id":4263646,"node_id":"MDQ6VXNlcjQyNjM2NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/4263646?v=4","gravatar_id":"","url":"https://api.github.com/users/vuillaut","html_url":"https://github.com/vuillaut","followers_url":"https://api.github.com/users/vuillaut/followers","following_url":"https://api.github.com/users/vuillaut/following{/other_user}","gists_url":"https://api.github.com/users/vuillaut/gists{/gist_id}","starred_url":"https://api.github.com/users/vuillaut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuillaut/subscriptions","organizations_url":"https://api.github.com/users/vuillaut/orgs","repos_url":"https://api.github.com/users/vuillaut/repos","events_url":"https://api.github.com/users/vuillaut/events{/privacy}","received_events_url":"https://api.github.com/users/vuillaut/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-11-15T15:56:57Z","updated_at":"2018-11-16T08:18:27Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/cta-observatory/cta-lstchain/pulls/30","html_url":"https://github.com/cta-observatory/cta-lstchain/pull/30","diff_url":"https://github.com/cta-observatory/cta-lstchain/pull/30.diff","patch_url":"https://github.com/cta-observatory/cta-lstchain/pull/30.patch"},"body":"Changes:\r\n- add a new io container for DL1 mono reconstruction\r\n- example notebook to show how to use it\r\n- add `utils.get_event_pos_in_camera` function to get the position of the source in camera using ctapipe coordinates procedures\r\n- add `utils.disp` function to compute disp (in meters) using `get_event_pos_in_camera` and straight out of ctapipe containers\r\n\r\nThis PR is to show how I propose to solve issues #10 and #11.\r\nThe advantages of using a custom ctapipe container are:\r\n- fix the names of variables for the rest of the chain\r\n- be able to add custom variables such as disp or mc_core_distance\r\n- handle units correctly\r\n- use ctapipe containers writing and reading procedures\r\n\r\n\r\nIf that looks ok with you, let me know but don't merge it right away, I'll use the same PR to make the actual changes in the scripts."},"comment":{"url":"https://api.github.com/repos/cta-observatory/cta-lstchain/issues/comments/439316023","html_url":"https://github.com/cta-observatory/cta-lstchain/pull/30#issuecomment-439316023","issue_url":"https://api.github.com/repos/cta-observatory/cta-lstchain/issues/30","id":439316023,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTMxNjAyMw==","user":{"login":"misabelber","id":38687749,"node_id":"MDQ6VXNlcjM4Njg3NzQ5","avatar_url":"https://avatars2.githubusercontent.com/u/38687749?v=4","gravatar_id":"","url":"https://api.github.com/users/misabelber","html_url":"https://github.com/misabelber","followers_url":"https://api.github.com/users/misabelber/followers","following_url":"https://api.github.com/users/misabelber/following{/other_user}","gists_url":"https://api.github.com/users/misabelber/gists{/gist_id}","starred_url":"https://api.github.com/users/misabelber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misabelber/subscriptions","organizations_url":"https://api.github.com/users/misabelber/orgs","repos_url":"https://api.github.com/users/misabelber/repos","events_url":"https://api.github.com/users/misabelber/events{/privacy}","received_events_url":"https://api.github.com/users/misabelber/received_events","type":"User","site_admin":false},"created_at":"2018-11-16T08:18:27Z","updated_at":"2018-11-16T08:18:27Z","author_association":"COLLABORATOR","body":"@vuillaut Ahh no problem then!\r\n@rlopezcoto Of course, I can test everything when the changes are implemented. "}}
{"actor":{"display_login":"misabelber"}}