{"action":"created","issue":{"url":"https://api.github.com/repos/sandflow/regxmllib/issues/124","repository_url":"https://api.github.com/repos/sandflow/regxmllib","labels_url":"https://api.github.com/repos/sandflow/regxmllib/issues/124/labels{/name}","comments_url":"https://api.github.com/repos/sandflow/regxmllib/issues/124/comments","events_url":"https://api.github.com/repos/sandflow/regxmllib/issues/124/events","html_url":"https://github.com/sandflow/regxmllib/issues/124","id":325507688,"node_id":"MDU6SXNzdWUzMjU1MDc2ODg=","number":124,"title":"Remove `using namespace` directives from header files","user":{"login":"CausticYarn","id":3424005,"node_id":"MDQ6VXNlcjM0MjQwMDU=","avatar_url":"https://avatars0.githubusercontent.com/u/3424005?v=4","gravatar_id":"","url":"https://api.github.com/users/CausticYarn","html_url":"https://github.com/CausticYarn","followers_url":"https://api.github.com/users/CausticYarn/followers","following_url":"https://api.github.com/users/CausticYarn/following{/other_user}","gists_url":"https://api.github.com/users/CausticYarn/gists{/gist_id}","starred_url":"https://api.github.com/users/CausticYarn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CausticYarn/subscriptions","organizations_url":"https://api.github.com/users/CausticYarn/orgs","repos_url":"https://api.github.com/users/CausticYarn/repos","events_url":"https://api.github.com/users/CausticYarn/events{/privacy}","received_events_url":"https://api.github.com/users/CausticYarn/received_events","type":"User","site_admin":false},"labels":[{"id":452591002,"node_id":"MDU6TGFiZWw0NTI1OTEwMDI=","url":"https://api.github.com/repos/sandflow/regxmllib/labels/ready%20to%20test","name":"ready to test","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":{"login":"palemieux","id":4871350,"node_id":"MDQ6VXNlcjQ4NzEzNTA=","avatar_url":"https://avatars0.githubusercontent.com/u/4871350?v=4","gravatar_id":"","url":"https://api.github.com/users/palemieux","html_url":"https://github.com/palemieux","followers_url":"https://api.github.com/users/palemieux/followers","following_url":"https://api.github.com/users/palemieux/following{/other_user}","gists_url":"https://api.github.com/users/palemieux/gists{/gist_id}","starred_url":"https://api.github.com/users/palemieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palemieux/subscriptions","organizations_url":"https://api.github.com/users/palemieux/orgs","repos_url":"https://api.github.com/users/palemieux/repos","events_url":"https://api.github.com/users/palemieux/events{/privacy}","received_events_url":"https://api.github.com/users/palemieux/received_events","type":"User","site_admin":false},"assignees":[{"login":"palemieux","id":4871350,"node_id":"MDQ6VXNlcjQ4NzEzNTA=","avatar_url":"https://avatars0.githubusercontent.com/u/4871350?v=4","gravatar_id":"","url":"https://api.github.com/users/palemieux","html_url":"https://github.com/palemieux","followers_url":"https://api.github.com/users/palemieux/followers","following_url":"https://api.github.com/users/palemieux/following{/other_user}","gists_url":"https://api.github.com/users/palemieux/gists{/gist_id}","starred_url":"https://api.github.com/users/palemieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palemieux/subscriptions","organizations_url":"https://api.github.com/users/palemieux/orgs","repos_url":"https://api.github.com/users/palemieux/repos","events_url":"https://api.github.com/users/palemieux/events{/privacy}","received_events_url":"https://api.github.com/users/palemieux/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/sandflow/regxmllib/milestones/6","html_url":"https://github.com/sandflow/regxmllib/milestone/6","labels_url":"https://api.github.com/repos/sandflow/regxmllib/milestones/6/labels","id":2200154,"node_id":"MDk6TWlsZXN0b25lMjIwMDE1NA==","number":6,"title":"Release 1.1.2","description":"","creator":{"login":"palemieux","id":4871350,"node_id":"MDQ6VXNlcjQ4NzEzNTA=","avatar_url":"https://avatars0.githubusercontent.com/u/4871350?v=4","gravatar_id":"","url":"https://api.github.com/users/palemieux","html_url":"https://github.com/palemieux","followers_url":"https://api.github.com/users/palemieux/followers","following_url":"https://api.github.com/users/palemieux/following{/other_user}","gists_url":"https://api.github.com/users/palemieux/gists{/gist_id}","starred_url":"https://api.github.com/users/palemieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palemieux/subscriptions","organizations_url":"https://api.github.com/users/palemieux/orgs","repos_url":"https://api.github.com/users/palemieux/repos","events_url":"https://api.github.com/users/palemieux/events{/privacy}","received_events_url":"https://api.github.com/users/palemieux/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":11,"state":"open","created_at":"2016-12-16T06:21:36Z","updated_at":"2018-06-20T18:18:34Z","due_on":"2017-06-01T07:00:00Z","closed_at":null},"comments":3,"created_at":"2018-05-23T00:26:19Z","updated_at":"2018-06-21T13:17:47Z","closed_at":null,"author_association":"NONE","body":"Several header files declare XERCES_CPP_NAMESPACE_USE, which is equivalent to `using namespace xercesc`.  This is considered bad practice because it forces the consumer of the library to pollute the global namespace (e.g. https://stackoverflow.com/questions/4872373/why-is-including-using-namespace-into-a-header-file-a-bad-idea-in-c) which can easily cause name clashes in a medium or large scale project.  Using declarations in .cpp files is not an issue (as long as they are _after_ any includes).\r\n\r\nAttached is a patch which uses fully qualified names for the header files and moves the using directive to the .cpp files.\r\n\r\n[xerces_namespace.patch.txt](https://github.com/sandflow/regxmllib/files/2029038/xerces_namespace.patch.txt)\r\n"},"comment":{"url":"https://api.github.com/repos/sandflow/regxmllib/issues/comments/399100225","html_url":"https://github.com/sandflow/regxmllib/issues/124#issuecomment-399100225","issue_url":"https://api.github.com/repos/sandflow/regxmllib/issues/124","id":399100225,"node_id":"MDEyOklzc3VlQ29tbWVudDM5OTEwMDIyNQ==","user":{"login":"palemieux","id":4871350,"node_id":"MDQ6VXNlcjQ4NzEzNTA=","avatar_url":"https://avatars0.githubusercontent.com/u/4871350?v=4","gravatar_id":"","url":"https://api.github.com/users/palemieux","html_url":"https://github.com/palemieux","followers_url":"https://api.github.com/users/palemieux/followers","following_url":"https://api.github.com/users/palemieux/following{/other_user}","gists_url":"https://api.github.com/users/palemieux/gists{/gist_id}","starred_url":"https://api.github.com/users/palemieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palemieux/subscriptions","organizations_url":"https://api.github.com/users/palemieux/orgs","repos_url":"https://api.github.com/users/palemieux/repos","events_url":"https://api.github.com/users/palemieux/events{/privacy}","received_events_url":"https://api.github.com/users/palemieux/received_events","type":"User","site_admin":false},"created_at":"2018-06-21T13:17:47Z","updated_at":"2018-06-21T13:17:47Z","author_association":"CONTRIBUTOR","body":"@CausticYarn Can you review PR #127 when you have a chance?"}}
{"actor":{"display_login":"palemieux"}}