{"action":"created","comment":{"url":"https://api.github.com/repos/geodynamics/aspect/pulls/comments/170477337","pull_request_review_id":99166017,"id":170477337,"diff_hunk":"@@ -212,7 +215,10 @@ namespace aspect\n                            * 0.5 * ((1/stress_exponent)-1) * std::pow(2,2) * out.viscosities[i] * (1/(edot_ii*edot_ii)) * deviator(in.strain_rate[i]),\n                            * but we can (and do) simply it as:\n                            */\n-                          composition_viscosities_derivatives[c] = 2.0 * (stress_exponent_inv-1) * composition_viscosities[c] * (1.0/(edot_ii*edot_ii)) * deviator(in.strain_rate[i]);\n+                          composition_viscosities_derivatives[c] = 2.0 * (stress_exponent_inv-1) * composition_viscosities[c] * (1.0/(edot_ii*edot_ii)) * deviator_strain_rate;\n+\n+                          if (use_deviator_of_strain_rate == true)\n+                            composition_viscosities_derivatives[c]*deviator_tensor<dim>();","path":"benchmarks/nonlinear_channel_flow/simple_nonlinear.cc","position":27,"original_position":27,"commit_id":"1c19ebc46cd44e1ed8cba2581778f2ad6245e79a","original_commit_id":"1c19ebc46cd44e1ed8cba2581778f2ad6245e79a","user":{"login":"bangerth","id":7504421,"avatar_url":"https://avatars2.githubusercontent.com/u/7504421?v=4","gravatar_id":"","url":"https://api.github.com/users/bangerth","html_url":"https://github.com/bangerth","followers_url":"https://api.github.com/users/bangerth/followers","following_url":"https://api.github.com/users/bangerth/following{/other_user}","gists_url":"https://api.github.com/users/bangerth/gists{/gist_id}","starred_url":"https://api.github.com/users/bangerth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bangerth/subscriptions","organizations_url":"https://api.github.com/users/bangerth/orgs","repos_url":"https://api.github.com/users/bangerth/repos","events_url":"https://api.github.com/users/bangerth/events{/privacy}","received_events_url":"https://api.github.com/users/bangerth/received_events","type":"User","site_admin":false},"body":"This statement has no effect: you are computing the product of two things, but not assigning the result to anything. Can you explain what you wanted to do here?","created_at":"2018-02-26T01:10:40Z","updated_at":"2018-02-26T01:11:31Z","html_url":"https://github.com/geodynamics/aspect/pull/2112#discussion_r170477337","pull_request_url":"https://api.github.com/repos/geodynamics/aspect/pulls/2112","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/comments/170477337"},"html":{"href":"https://github.com/geodynamics/aspect/pull/2112#discussion_r170477337"},"pull_request":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/2112"}}},"pull_request":{"url":"https://api.github.com/repos/geodynamics/aspect/pulls/2112","id":171256691,"html_url":"https://github.com/geodynamics/aspect/pull/2112","diff_url":"https://github.com/geodynamics/aspect/pull/2112.diff","patch_url":"https://github.com/geodynamics/aspect/pull/2112.patch","issue_url":"https://api.github.com/repos/geodynamics/aspect/issues/2112","number":2112,"state":"open","locked":false,"title":"allow simple nonlinear material model without the deviator","user":{"login":"MFraters","id":7631629,"avatar_url":"https://avatars0.githubusercontent.com/u/7631629?v=4","gravatar_id":"","url":"https://api.github.com/users/MFraters","html_url":"https://github.com/MFraters","followers_url":"https://api.github.com/users/MFraters/followers","following_url":"https://api.github.com/users/MFraters/following{/other_user}","gists_url":"https://api.github.com/users/MFraters/gists{/gist_id}","starred_url":"https://api.github.com/users/MFraters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MFraters/subscriptions","organizations_url":"https://api.github.com/users/MFraters/orgs","repos_url":"https://api.github.com/users/MFraters/repos","events_url":"https://api.github.com/users/MFraters/events{/privacy}","received_events_url":"https://api.github.com/users/MFraters/received_events","type":"User","site_admin":false},"body":"allow simple nonlinear material model to be computed without the deviator. I noticed this may give slightly different behaviour for the Picard iteration, but a large difference in behaviour for the Newton solver.","created_at":"2018-02-25T22:53:32Z","updated_at":"2018-02-26T01:11:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ee74db0f1c7c1dcf6d136d95d42da0e636106372","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/geodynamics/aspect/pulls/2112/commits","review_comments_url":"https://api.github.com/repos/geodynamics/aspect/pulls/2112/comments","review_comment_url":"https://api.github.com/repos/geodynamics/aspect/pulls/comments{/number}","comments_url":"https://api.github.com/repos/geodynamics/aspect/issues/2112/comments","statuses_url":"https://api.github.com/repos/geodynamics/aspect/statuses/1c19ebc46cd44e1ed8cba2581778f2ad6245e79a","head":{"label":"MFraters:allow_simple_nonlinear_without_deviator","ref":"allow_simple_nonlinear_without_deviator","sha":"1c19ebc46cd44e1ed8cba2581778f2ad6245e79a","user":{"login":"MFraters","id":7631629,"avatar_url":"https://avatars0.githubusercontent.com/u/7631629?v=4","gravatar_id":"","url":"https://api.github.com/users/MFraters","html_url":"https://github.com/MFraters","followers_url":"https://api.github.com/users/MFraters/followers","following_url":"https://api.github.com/users/MFraters/following{/other_user}","gists_url":"https://api.github.com/users/MFraters/gists{/gist_id}","starred_url":"https://api.github.com/users/MFraters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MFraters/subscriptions","organizations_url":"https://api.github.com/users/MFraters/orgs","repos_url":"https://api.github.com/users/MFraters/repos","events_url":"https://api.github.com/users/MFraters/events{/privacy}","received_events_url":"https://api.github.com/users/MFraters/received_events","type":"User","site_admin":false},"repo":{"id":19946391,"name":"aspect","full_name":"MFraters/aspect","owner":{"login":"MFraters","id":7631629,"avatar_url":"https://avatars0.githubusercontent.com/u/7631629?v=4","gravatar_id":"","url":"https://api.github.com/users/MFraters","html_url":"https://github.com/MFraters","followers_url":"https://api.github.com/users/MFraters/followers","following_url":"https://api.github.com/users/MFraters/following{/other_user}","gists_url":"https://api.github.com/users/MFraters/gists{/gist_id}","starred_url":"https://api.github.com/users/MFraters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MFraters/subscriptions","organizations_url":"https://api.github.com/users/MFraters/orgs","repos_url":"https://api.github.com/users/MFraters/repos","events_url":"https://api.github.com/users/MFraters/events{/privacy}","received_events_url":"https://api.github.com/users/MFraters/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MFraters/aspect","description":"Finite element parallel code to simulate problems in thermal convection in both 2D and 3D models.","fork":true,"url":"https://api.github.com/repos/MFraters/aspect","forks_url":"https://api.github.com/repos/MFraters/aspect/forks","keys_url":"https://api.github.com/repos/MFraters/aspect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MFraters/aspect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MFraters/aspect/teams","hooks_url":"https://api.github.com/repos/MFraters/aspect/hooks","issue_events_url":"https://api.github.com/repos/MFraters/aspect/issues/events{/number}","events_url":"https://api.github.com/repos/MFraters/aspect/events","assignees_url":"https://api.github.com/repos/MFraters/aspect/assignees{/user}","branches_url":"https://api.github.com/repos/MFraters/aspect/branches{/branch}","tags_url":"https://api.github.com/repos/MFraters/aspect/tags","blobs_url":"https://api.github.com/repos/MFraters/aspect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MFraters/aspect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MFraters/aspect/git/refs{/sha}","trees_url":"https://api.github.com/repos/MFraters/aspect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MFraters/aspect/statuses/{sha}","languages_url":"https://api.github.com/repos/MFraters/aspect/languages","stargazers_url":"https://api.github.com/repos/MFraters/aspect/stargazers","contributors_url":"https://api.github.com/repos/MFraters/aspect/contributors","subscribers_url":"https://api.github.com/repos/MFraters/aspect/subscribers","subscription_url":"https://api.github.com/repos/MFraters/aspect/subscription","commits_url":"https://api.github.com/repos/MFraters/aspect/commits{/sha}","git_commits_url":"https://api.github.com/repos/MFraters/aspect/git/commits{/sha}","comments_url":"https://api.github.com/repos/MFraters/aspect/comments{/number}","issue_comment_url":"https://api.github.com/repos/MFraters/aspect/issues/comments{/number}","contents_url":"https://api.github.com/repos/MFraters/aspect/contents/{+path}","compare_url":"https://api.github.com/repos/MFraters/aspect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MFraters/aspect/merges","archive_url":"https://api.github.com/repos/MFraters/aspect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MFraters/aspect/downloads","issues_url":"https://api.github.com/repos/MFraters/aspect/issues{/number}","pulls_url":"https://api.github.com/repos/MFraters/aspect/pulls{/number}","milestones_url":"https://api.github.com/repos/MFraters/aspect/milestones{/number}","notifications_url":"https://api.github.com/repos/MFraters/aspect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MFraters/aspect/labels{/name}","releases_url":"https://api.github.com/repos/MFraters/aspect/releases{/id}","deployments_url":"https://api.github.com/repos/MFraters/aspect/deployments","created_at":"2014-05-19T15:08:19Z","updated_at":"2016-01-13T15:59:16Z","pushed_at":"2018-02-25T22:50:15Z","git_url":"git://github.com/MFraters/aspect.git","ssh_url":"git@github.com:MFraters/aspect.git","clone_url":"https://github.com/MFraters/aspect.git","svn_url":"https://github.com/MFraters/aspect","homepage":null,"size":165342,"stargazers_count":0,"watchers_count":0,"language":"Gnuplot","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"geodynamics:master","ref":"master","sha":"4b5ef6786ede6e69f7a09778111cdd5d6152027f","user":{"login":"geodynamics","id":4052461,"avatar_url":"https://avatars1.githubusercontent.com/u/4052461?v=4","gravatar_id":"","url":"https://api.github.com/users/geodynamics","html_url":"https://github.com/geodynamics","followers_url":"https://api.github.com/users/geodynamics/followers","following_url":"https://api.github.com/users/geodynamics/following{/other_user}","gists_url":"https://api.github.com/users/geodynamics/gists{/gist_id}","starred_url":"https://api.github.com/users/geodynamics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geodynamics/subscriptions","organizations_url":"https://api.github.com/users/geodynamics/orgs","repos_url":"https://api.github.com/users/geodynamics/repos","events_url":"https://api.github.com/users/geodynamics/events{/privacy}","received_events_url":"https://api.github.com/users/geodynamics/received_events","type":"Organization","site_admin":false},"repo":{"id":19502452,"name":"aspect","full_name":"geodynamics/aspect","owner":{"login":"geodynamics","id":4052461,"avatar_url":"https://avatars1.githubusercontent.com/u/4052461?v=4","gravatar_id":"","url":"https://api.github.com/users/geodynamics","html_url":"https://github.com/geodynamics","followers_url":"https://api.github.com/users/geodynamics/followers","following_url":"https://api.github.com/users/geodynamics/following{/other_user}","gists_url":"https://api.github.com/users/geodynamics/gists{/gist_id}","starred_url":"https://api.github.com/users/geodynamics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geodynamics/subscriptions","organizations_url":"https://api.github.com/users/geodynamics/orgs","repos_url":"https://api.github.com/users/geodynamics/repos","events_url":"https://api.github.com/users/geodynamics/events{/privacy}","received_events_url":"https://api.github.com/users/geodynamics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geodynamics/aspect","description":"A parallel, extendible finite element code to simulate thermal convection in both 2D and 3D models.","fork":false,"url":"https://api.github.com/repos/geodynamics/aspect","forks_url":"https://api.github.com/repos/geodynamics/aspect/forks","keys_url":"https://api.github.com/repos/geodynamics/aspect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geodynamics/aspect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geodynamics/aspect/teams","hooks_url":"https://api.github.com/repos/geodynamics/aspect/hooks","issue_events_url":"https://api.github.com/repos/geodynamics/aspect/issues/events{/number}","events_url":"https://api.github.com/repos/geodynamics/aspect/events","assignees_url":"https://api.github.com/repos/geodynamics/aspect/assignees{/user}","branches_url":"https://api.github.com/repos/geodynamics/aspect/branches{/branch}","tags_url":"https://api.github.com/repos/geodynamics/aspect/tags","blobs_url":"https://api.github.com/repos/geodynamics/aspect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geodynamics/aspect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geodynamics/aspect/git/refs{/sha}","trees_url":"https://api.github.com/repos/geodynamics/aspect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geodynamics/aspect/statuses/{sha}","languages_url":"https://api.github.com/repos/geodynamics/aspect/languages","stargazers_url":"https://api.github.com/repos/geodynamics/aspect/stargazers","contributors_url":"https://api.github.com/repos/geodynamics/aspect/contributors","subscribers_url":"https://api.github.com/repos/geodynamics/aspect/subscribers","subscription_url":"https://api.github.com/repos/geodynamics/aspect/subscription","commits_url":"https://api.github.com/repos/geodynamics/aspect/commits{/sha}","git_commits_url":"https://api.github.com/repos/geodynamics/aspect/git/commits{/sha}","comments_url":"https://api.github.com/repos/geodynamics/aspect/comments{/number}","issue_comment_url":"https://api.github.com/repos/geodynamics/aspect/issues/comments{/number}","contents_url":"https://api.github.com/repos/geodynamics/aspect/contents/{+path}","compare_url":"https://api.github.com/repos/geodynamics/aspect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geodynamics/aspect/merges","archive_url":"https://api.github.com/repos/geodynamics/aspect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geodynamics/aspect/downloads","issues_url":"https://api.github.com/repos/geodynamics/aspect/issues{/number}","pulls_url":"https://api.github.com/repos/geodynamics/aspect/pulls{/number}","milestones_url":"https://api.github.com/repos/geodynamics/aspect/milestones{/number}","notifications_url":"https://api.github.com/repos/geodynamics/aspect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geodynamics/aspect/labels{/name}","releases_url":"https://api.github.com/repos/geodynamics/aspect/releases{/id}","deployments_url":"https://api.github.com/repos/geodynamics/aspect/deployments","created_at":"2014-05-06T16:47:18Z","updated_at":"2018-02-19T12:00:59Z","pushed_at":"2018-02-25T23:26:10Z","git_url":"git://github.com/geodynamics/aspect.git","ssh_url":"git@github.com:geodynamics/aspect.git","clone_url":"https://github.com/geodynamics/aspect.git","svn_url":"https://github.com/geodynamics/aspect","homepage":"https://aspect.geodynamics.org/","size":170148,"stargazers_count":49,"watchers_count":49,"language":"Gnuplot","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":85,"mirror_url":null,"archived":false,"open_issues_count":170,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":85,"open_issues":170,"watchers":49,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/2112"},"html":{"href":"https://github.com/geodynamics/aspect/pull/2112"},"issue":{"href":"https://api.github.com/repos/geodynamics/aspect/issues/2112"},"comments":{"href":"https://api.github.com/repos/geodynamics/aspect/issues/2112/comments"},"review_comments":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/2112/comments"},"review_comment":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/2112/commits"},"statuses":{"href":"https://api.github.com/repos/geodynamics/aspect/statuses/1c19ebc46cd44e1ed8cba2581778f2ad6245e79a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bangerth"}}