{"action":"created","comment":{"url":"https://api.github.com/repos/ogrisel/pygbm/pulls/comments/230407634","pull_request_review_id":171144012,"id":230407634,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDQwNzYzNA==","diff_hunk":"@@ -362,26 +368,29 @@ def _find_histogram_split_subtraction(context, feature_idx,\n         sibling_histograms[feature_idx])\n \n     return _find_best_bin_to_split_helper(\n-        context, feature_idx, histogram, sum_gradients, sum_hessians)\n+        context, feature_idx, histogram, sum_gradients, sum_hessians,\n+        n_samples)\n \n \n-@njit(locals={'gradient_left': float32, 'hessian_left': float32},\n+@njit(locals={'gradient_left': float32, 'hessian_left': float32,\n+              'n_samples_left': uint32},\n       fastmath=True)\n def _find_best_bin_to_split_helper(context, feature_idx, histogram,\n-                                   sum_gradients, sum_hessians):\n+                                   sum_gradients, sum_hessians, n_samples):","path":"pygbm/splitting.py","position":122,"original_position":122,"commit_id":"1c6e62b7c40ca202370133613c05fc6f1a9cb4f5","original_commit_id":"1c6e62b7c40ca202370133613c05fc6f1a9cb4f5","user":{"login":"NicolasHug","id":1190450,"node_id":"MDQ6VXNlcjExOTA0NTA=","avatar_url":"https://avatars2.githubusercontent.com/u/1190450?v=4","gravatar_id":"","url":"https://api.github.com/users/NicolasHug","html_url":"https://github.com/NicolasHug","followers_url":"https://api.github.com/users/NicolasHug/followers","following_url":"https://api.github.com/users/NicolasHug/following{/other_user}","gists_url":"https://api.github.com/users/NicolasHug/gists{/gist_id}","starred_url":"https://api.github.com/users/NicolasHug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicolasHug/subscriptions","organizations_url":"https://api.github.com/users/NicolasHug/orgs","repos_url":"https://api.github.com/users/NicolasHug/repos","events_url":"https://api.github.com/users/NicolasHug/events{/privacy}","received_events_url":"https://api.github.com/users/NicolasHug/received_events","type":"User","site_admin":false},"body":"I don't think it's in the context, I thought about it but all the arrays are of size `n_samples` which is the size of the whole training set","created_at":"2018-11-02T15:09:23Z","updated_at":"2018-11-02T15:09:23Z","html_url":"https://github.com/ogrisel/pygbm/pull/35#discussion_r230407634","pull_request_url":"https://api.github.com/repos/ogrisel/pygbm/pulls/35","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ogrisel/pygbm/pulls/comments/230407634"},"html":{"href":"https://github.com/ogrisel/pygbm/pull/35#discussion_r230407634"},"pull_request":{"href":"https://api.github.com/repos/ogrisel/pygbm/pulls/35"}},"in_reply_to_id":230393392},"pull_request":{"url":"https://api.github.com/repos/ogrisel/pygbm/pulls/35","id":227912071,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3OTEyMDcx","html_url":"https://github.com/ogrisel/pygbm/pull/35","diff_url":"https://github.com/ogrisel/pygbm/pull/35.diff","patch_url":"https://github.com/ogrisel/pygbm/pull/35.patch","issue_url":"https://api.github.com/repos/ogrisel/pygbm/issues/35","number":35,"state":"open","locked":false,"title":"Fix handling of the min_samples_leaf hyperparameter","user":{"login":"ogrisel","id":89061,"node_id":"MDQ6VXNlcjg5MDYx","avatar_url":"https://avatars0.githubusercontent.com/u/89061?v=4","gravatar_id":"","url":"https://api.github.com/users/ogrisel","html_url":"https://github.com/ogrisel","followers_url":"https://api.github.com/users/ogrisel/followers","following_url":"https://api.github.com/users/ogrisel/following{/other_user}","gists_url":"https://api.github.com/users/ogrisel/gists{/gist_id}","starred_url":"https://api.github.com/users/ogrisel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogrisel/subscriptions","organizations_url":"https://api.github.com/users/ogrisel/orgs","repos_url":"https://api.github.com/users/ogrisel/repos","events_url":"https://api.github.com/users/ogrisel/events{/privacy}","received_events_url":"https://api.github.com/users/ogrisel/received_events","type":"User","site_admin":false},"body":"This is a tentative fix for #34.\r\n\r\nHowever the test in `test_compare_lightgbm` fails if I change the value of min_samples_leaf to something different than 1.\r\n\r\nIn retrospect, I believe this is because we reject too many splits by doing the filtering at the grower level while we should probably do it also inside the `find_node_split*` calls.","created_at":"2018-11-02T11:46:06Z","updated_at":"2018-11-02T15:09:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2fa18325a824ce4bfd9959e7c6a8656b99b24f7e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ogrisel/pygbm/pulls/35/commits","review_comments_url":"https://api.github.com/repos/ogrisel/pygbm/pulls/35/comments","review_comment_url":"https://api.github.com/repos/ogrisel/pygbm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ogrisel/pygbm/issues/35/comments","statuses_url":"https://api.github.com/repos/ogrisel/pygbm/statuses/1c6e62b7c40ca202370133613c05fc6f1a9cb4f5","head":{"label":"ogrisel:fix-min_samples_leaf","ref":"fix-min_samples_leaf","sha":"1c6e62b7c40ca202370133613c05fc6f1a9cb4f5","user":{"login":"ogrisel","id":89061,"node_id":"MDQ6VXNlcjg5MDYx","avatar_url":"https://avatars0.githubusercontent.com/u/89061?v=4","gravatar_id":"","url":"https://api.github.com/users/ogrisel","html_url":"https://github.com/ogrisel","followers_url":"https://api.github.com/users/ogrisel/followers","following_url":"https://api.github.com/users/ogrisel/following{/other_user}","gists_url":"https://api.github.com/users/ogrisel/gists{/gist_id}","starred_url":"https://api.github.com/users/ogrisel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogrisel/subscriptions","organizations_url":"https://api.github.com/users/ogrisel/orgs","repos_url":"https://api.github.com/users/ogrisel/repos","events_url":"https://api.github.com/users/ogrisel/events{/privacy}","received_events_url":"https://api.github.com/users/ogrisel/received_events","type":"User","site_admin":false},"repo":{"id":143539809,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM1Mzk4MDk=","name":"pygbm","full_name":"ogrisel/pygbm","private":false,"owner":{"login":"ogrisel","id":89061,"node_id":"MDQ6VXNlcjg5MDYx","avatar_url":"https://avatars0.githubusercontent.com/u/89061?v=4","gravatar_id":"","url":"https://api.github.com/users/ogrisel","html_url":"https://github.com/ogrisel","followers_url":"https://api.github.com/users/ogrisel/followers","following_url":"https://api.github.com/users/ogrisel/following{/other_user}","gists_url":"https://api.github.com/users/ogrisel/gists{/gist_id}","starred_url":"https://api.github.com/users/ogrisel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogrisel/subscriptions","organizations_url":"https://api.github.com/users/ogrisel/orgs","repos_url":"https://api.github.com/users/ogrisel/repos","events_url":"https://api.github.com/users/ogrisel/events{/privacy}","received_events_url":"https://api.github.com/users/ogrisel/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ogrisel/pygbm","description":"Experimental Gradient Boosting Machines in Python with numba.","fork":false,"url":"https://api.github.com/repos/ogrisel/pygbm","forks_url":"https://api.github.com/repos/ogrisel/pygbm/forks","keys_url":"https://api.github.com/repos/ogrisel/pygbm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ogrisel/pygbm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ogrisel/pygbm/teams","hooks_url":"https://api.github.com/repos/ogrisel/pygbm/hooks","issue_events_url":"https://api.github.com/repos/ogrisel/pygbm/issues/events{/number}","events_url":"https://api.github.com/repos/ogrisel/pygbm/events","assignees_url":"https://api.github.com/repos/ogrisel/pygbm/assignees{/user}","branches_url":"https://api.github.com/repos/ogrisel/pygbm/branches{/branch}","tags_url":"https://api.github.com/repos/ogrisel/pygbm/tags","blobs_url":"https://api.github.com/repos/ogrisel/pygbm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ogrisel/pygbm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ogrisel/pygbm/git/refs{/sha}","trees_url":"https://api.github.com/repos/ogrisel/pygbm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ogrisel/pygbm/statuses/{sha}","languages_url":"https://api.github.com/repos/ogrisel/pygbm/languages","stargazers_url":"https://api.github.com/repos/ogrisel/pygbm/stargazers","contributors_url":"https://api.github.com/repos/ogrisel/pygbm/contributors","subscribers_url":"https://api.github.com/repos/ogrisel/pygbm/subscribers","subscription_url":"https://api.github.com/repos/ogrisel/pygbm/subscription","commits_url":"https://api.github.com/repos/ogrisel/pygbm/commits{/sha}","git_commits_url":"https://api.github.com/repos/ogrisel/pygbm/git/commits{/sha}","comments_url":"https://api.github.com/repos/ogrisel/pygbm/comments{/number}","issue_comment_url":"https://api.github.com/repos/ogrisel/pygbm/issues/comments{/number}","contents_url":"https://api.github.com/repos/ogrisel/pygbm/contents/{+path}","compare_url":"https://api.github.com/repos/ogrisel/pygbm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ogrisel/pygbm/merges","archive_url":"https://api.github.com/repos/ogrisel/pygbm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ogrisel/pygbm/downloads","issues_url":"https://api.github.com/repos/ogrisel/pygbm/issues{/number}","pulls_url":"https://api.github.com/repos/ogrisel/pygbm/pulls{/number}","milestones_url":"https://api.github.com/repos/ogrisel/pygbm/milestones{/number}","notifications_url":"https://api.github.com/repos/ogrisel/pygbm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ogrisel/pygbm/labels{/name}","releases_url":"https://api.github.com/repos/ogrisel/pygbm/releases{/id}","deployments_url":"https://api.github.com/repos/ogrisel/pygbm/deployments","created_at":"2018-08-04T15:17:24Z","updated_at":"2018-11-02T14:21:32Z","pushed_at":"2018-11-02T13:48:30Z","git_url":"git://github.com/ogrisel/pygbm.git","ssh_url":"git@github.com:ogrisel/pygbm.git","clone_url":"https://github.com/ogrisel/pygbm.git","svn_url":"https://github.com/ogrisel/pygbm","homepage":"","size":159,"stargazers_count":36,"watchers_count":36,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":11,"watchers":36,"default_branch":"master"}},"base":{"label":"ogrisel:master","ref":"master","sha":"ad96f9d6f6f4f4ce023f3bd780ce913f7d7b1386","user":{"login":"ogrisel","id":89061,"node_id":"MDQ6VXNlcjg5MDYx","avatar_url":"https://avatars0.githubusercontent.com/u/89061?v=4","gravatar_id":"","url":"https://api.github.com/users/ogrisel","html_url":"https://github.com/ogrisel","followers_url":"https://api.github.com/users/ogrisel/followers","following_url":"https://api.github.com/users/ogrisel/following{/other_user}","gists_url":"https://api.github.com/users/ogrisel/gists{/gist_id}","starred_url":"https://api.github.com/users/ogrisel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogrisel/subscriptions","organizations_url":"https://api.github.com/users/ogrisel/orgs","repos_url":"https://api.github.com/users/ogrisel/repos","events_url":"https://api.github.com/users/ogrisel/events{/privacy}","received_events_url":"https://api.github.com/users/ogrisel/received_events","type":"User","site_admin":false},"repo":{"id":143539809,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM1Mzk4MDk=","name":"pygbm","full_name":"ogrisel/pygbm","private":false,"owner":{"login":"ogrisel","id":89061,"node_id":"MDQ6VXNlcjg5MDYx","avatar_url":"https://avatars0.githubusercontent.com/u/89061?v=4","gravatar_id":"","url":"https://api.github.com/users/ogrisel","html_url":"https://github.com/ogrisel","followers_url":"https://api.github.com/users/ogrisel/followers","following_url":"https://api.github.com/users/ogrisel/following{/other_user}","gists_url":"https://api.github.com/users/ogrisel/gists{/gist_id}","starred_url":"https://api.github.com/users/ogrisel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogrisel/subscriptions","organizations_url":"https://api.github.com/users/ogrisel/orgs","repos_url":"https://api.github.com/users/ogrisel/repos","events_url":"https://api.github.com/users/ogrisel/events{/privacy}","received_events_url":"https://api.github.com/users/ogrisel/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ogrisel/pygbm","description":"Experimental Gradient Boosting Machines in Python with numba.","fork":false,"url":"https://api.github.com/repos/ogrisel/pygbm","forks_url":"https://api.github.com/repos/ogrisel/pygbm/forks","keys_url":"https://api.github.com/repos/ogrisel/pygbm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ogrisel/pygbm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ogrisel/pygbm/teams","hooks_url":"https://api.github.com/repos/ogrisel/pygbm/hooks","issue_events_url":"https://api.github.com/repos/ogrisel/pygbm/issues/events{/number}","events_url":"https://api.github.com/repos/ogrisel/pygbm/events","assignees_url":"https://api.github.com/repos/ogrisel/pygbm/assignees{/user}","branches_url":"https://api.github.com/repos/ogrisel/pygbm/branches{/branch}","tags_url":"https://api.github.com/repos/ogrisel/pygbm/tags","blobs_url":"https://api.github.com/repos/ogrisel/pygbm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ogrisel/pygbm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ogrisel/pygbm/git/refs{/sha}","trees_url":"https://api.github.com/repos/ogrisel/pygbm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ogrisel/pygbm/statuses/{sha}","languages_url":"https://api.github.com/repos/ogrisel/pygbm/languages","stargazers_url":"https://api.github.com/repos/ogrisel/pygbm/stargazers","contributors_url":"https://api.github.com/repos/ogrisel/pygbm/contributors","subscribers_url":"https://api.github.com/repos/ogrisel/pygbm/subscribers","subscription_url":"https://api.github.com/repos/ogrisel/pygbm/subscription","commits_url":"https://api.github.com/repos/ogrisel/pygbm/commits{/sha}","git_commits_url":"https://api.github.com/repos/ogrisel/pygbm/git/commits{/sha}","comments_url":"https://api.github.com/repos/ogrisel/pygbm/comments{/number}","issue_comment_url":"https://api.github.com/repos/ogrisel/pygbm/issues/comments{/number}","contents_url":"https://api.github.com/repos/ogrisel/pygbm/contents/{+path}","compare_url":"https://api.github.com/repos/ogrisel/pygbm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ogrisel/pygbm/merges","archive_url":"https://api.github.com/repos/ogrisel/pygbm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ogrisel/pygbm/downloads","issues_url":"https://api.github.com/repos/ogrisel/pygbm/issues{/number}","pulls_url":"https://api.github.com/repos/ogrisel/pygbm/pulls{/number}","milestones_url":"https://api.github.com/repos/ogrisel/pygbm/milestones{/number}","notifications_url":"https://api.github.com/repos/ogrisel/pygbm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ogrisel/pygbm/labels{/name}","releases_url":"https://api.github.com/repos/ogrisel/pygbm/releases{/id}","deployments_url":"https://api.github.com/repos/ogrisel/pygbm/deployments","created_at":"2018-08-04T15:17:24Z","updated_at":"2018-11-02T14:21:32Z","pushed_at":"2018-11-02T13:48:30Z","git_url":"git://github.com/ogrisel/pygbm.git","ssh_url":"git@github.com:ogrisel/pygbm.git","clone_url":"https://github.com/ogrisel/pygbm.git","svn_url":"https://github.com/ogrisel/pygbm","homepage":"","size":159,"stargazers_count":36,"watchers_count":36,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":11,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ogrisel/pygbm/pulls/35"},"html":{"href":"https://github.com/ogrisel/pygbm/pull/35"},"issue":{"href":"https://api.github.com/repos/ogrisel/pygbm/issues/35"},"comments":{"href":"https://api.github.com/repos/ogrisel/pygbm/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/ogrisel/pygbm/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/ogrisel/pygbm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ogrisel/pygbm/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/ogrisel/pygbm/statuses/1c6e62b7c40ca202370133613c05fc6f1a9cb4f5"}},"author_association":"OWNER"}}
{"actor":{"display_login":"NicolasHug"}}