{"action":"closed","number":27682,"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/27682","id":238814206,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4ODE0MjA2","html_url":"https://github.com/angular/angular/pull/27682","diff_url":"https://github.com/angular/angular/pull/27682.diff","patch_url":"https://github.com/angular/angular/pull/27682.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/27682","number":27682,"state":"closed","locked":false,"title":"feat(router): add predicate function  mode for runGuardsAndResolvers","user":{"login":"jasonaden","id":516168,"node_id":"MDQ6VXNlcjUxNjE2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/516168?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonaden","html_url":"https://github.com/jasonaden","followers_url":"https://api.github.com/users/jasonaden/followers","following_url":"https://api.github.com/users/jasonaden/following{/other_user}","gists_url":"https://api.github.com/users/jasonaden/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonaden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonaden/subscriptions","organizations_url":"https://api.github.com/users/jasonaden/orgs","repos_url":"https://api.github.com/users/jasonaden/repos","events_url":"https://api.github.com/users/jasonaden/events{/privacy}","received_events_url":"https://api.github.com/users/jasonaden/received_events","type":"User","site_admin":false},"body":"This option means guards and resolvers will ignore changes when a provided predicate function returns `false`. This supports use cases where an application needs to ignore some param updates but not others. For example, changing a sort param in the URL might need to be ignored, whereas changing the a `project` param might require re-run of guards and resolvers.\r\n\r\nRelated to #26861 #18253 #27464\r\n","created_at":"2018-12-14T19:05:49Z","updated_at":"2018-12-18T21:56:15Z","closed_at":"2018-12-18T21:56:15Z","merged_at":null,"merge_commit_sha":"933264fdc823e31a3826b2811a3c5d7a3299b8bc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":133556520,"node_id":"MDU6TGFiZWwxMzM1NTY1MjA=","url":"https://api.github.com/repos/angular/angular/labels/PR%20action:%20merge","name":"PR action: merge","color":"99ff66","default":false},{"id":770639208,"node_id":"MDU6TGFiZWw3NzA2MzkyMDg=","url":"https://api.github.com/repos/angular/angular/labels/PR%20action:%20merge-assistance","name":"PR action: merge-assistance","color":"eabbf9","default":false},{"id":660621334,"node_id":"MDU6TGFiZWw2NjA2MjEzMzQ=","url":"https://api.github.com/repos/angular/angular/labels/PR%20target:%20master-only","name":"PR target: master-only","color":"5319e7","default":false},{"id":149476251,"node_id":"MDU6TGFiZWwxNDk0NzYyNTE=","url":"https://api.github.com/repos/angular/angular/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false},{"id":375500771,"node_id":"MDU6TGFiZWwzNzU1MDA3NzE=","url":"https://api.github.com/repos/angular/angular/labels/comp:%20router","name":"comp: router","color":"c7def8","default":false}],"milestone":{"url":"https://api.github.com/repos/angular/angular/milestones/83","html_url":"https://github.com/angular/angular/milestone/83","labels_url":"https://api.github.com/repos/angular/angular/milestones/83/labels","id":3143880,"node_id":"MDk6TWlsZXN0b25lMzE0Mzg4MA==","number":83,"title":"needsTriage","description":"Milestone for all issues that haven't been triaged yet","creator":{"login":"ocombe","id":265378,"node_id":"MDQ6VXNlcjI2NTM3OA==","avatar_url":"https://avatars0.githubusercontent.com/u/265378?v=4","gravatar_id":"","url":"https://api.github.com/users/ocombe","html_url":"https://github.com/ocombe","followers_url":"https://api.github.com/users/ocombe/followers","following_url":"https://api.github.com/users/ocombe/following{/other_user}","gists_url":"https://api.github.com/users/ocombe/gists{/gist_id}","starred_url":"https://api.github.com/users/ocombe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocombe/subscriptions","organizations_url":"https://api.github.com/users/ocombe/orgs","repos_url":"https://api.github.com/users/ocombe/repos","events_url":"https://api.github.com/users/ocombe/events{/privacy}","received_events_url":"https://api.github.com/users/ocombe/received_events","type":"User","site_admin":false},"open_issues":192,"closed_issues":1131,"state":"open","created_at":"2018-02-26T14:22:18Z","updated_at":"2018-12-18T21:56:15Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/angular/angular/pulls/27682/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/27682/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/27682/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/c00119055fa7cc80006a92ab50f08da3f97fe2cb","head":{"label":"jasonaden:FW-824_predicate_shouldRunGuardsAndResolvers","ref":"FW-824_predicate_shouldRunGuardsAndResolvers","sha":"c00119055fa7cc80006a92ab50f08da3f97fe2cb","user":{"login":"jasonaden","id":516168,"node_id":"MDQ6VXNlcjUxNjE2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/516168?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonaden","html_url":"https://github.com/jasonaden","followers_url":"https://api.github.com/users/jasonaden/followers","following_url":"https://api.github.com/users/jasonaden/following{/other_user}","gists_url":"https://api.github.com/users/jasonaden/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonaden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonaden/subscriptions","organizations_url":"https://api.github.com/users/jasonaden/orgs","repos_url":"https://api.github.com/users/jasonaden/repos","events_url":"https://api.github.com/users/jasonaden/events{/privacy}","received_events_url":"https://api.github.com/users/jasonaden/received_events","type":"User","site_admin":false},"repo":{"id":79865337,"node_id":"MDEwOlJlcG9zaXRvcnk3OTg2NTMzNw==","name":"angular","full_name":"jasonaden/angular","private":false,"owner":{"login":"jasonaden","id":516168,"node_id":"MDQ6VXNlcjUxNjE2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/516168?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonaden","html_url":"https://github.com/jasonaden","followers_url":"https://api.github.com/users/jasonaden/followers","following_url":"https://api.github.com/users/jasonaden/following{/other_user}","gists_url":"https://api.github.com/users/jasonaden/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonaden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonaden/subscriptions","organizations_url":"https://api.github.com/users/jasonaden/orgs","repos_url":"https://api.github.com/users/jasonaden/repos","events_url":"https://api.github.com/users/jasonaden/events{/privacy}","received_events_url":"https://api.github.com/users/jasonaden/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jasonaden/angular","description":"One framework. Mobile & desktop.","fork":true,"url":"https://api.github.com/repos/jasonaden/angular","forks_url":"https://api.github.com/repos/jasonaden/angular/forks","keys_url":"https://api.github.com/repos/jasonaden/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jasonaden/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jasonaden/angular/teams","hooks_url":"https://api.github.com/repos/jasonaden/angular/hooks","issue_events_url":"https://api.github.com/repos/jasonaden/angular/issues/events{/number}","events_url":"https://api.github.com/repos/jasonaden/angular/events","assignees_url":"https://api.github.com/repos/jasonaden/angular/assignees{/user}","branches_url":"https://api.github.com/repos/jasonaden/angular/branches{/branch}","tags_url":"https://api.github.com/repos/jasonaden/angular/tags","blobs_url":"https://api.github.com/repos/jasonaden/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jasonaden/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jasonaden/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/jasonaden/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jasonaden/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/jasonaden/angular/languages","stargazers_url":"https://api.github.com/repos/jasonaden/angular/stargazers","contributors_url":"https://api.github.com/repos/jasonaden/angular/contributors","subscribers_url":"https://api.github.com/repos/jasonaden/angular/subscribers","subscription_url":"https://api.github.com/repos/jasonaden/angular/subscription","commits_url":"https://api.github.com/repos/jasonaden/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/jasonaden/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/jasonaden/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/jasonaden/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/jasonaden/angular/contents/{+path}","compare_url":"https://api.github.com/repos/jasonaden/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jasonaden/angular/merges","archive_url":"https://api.github.com/repos/jasonaden/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jasonaden/angular/downloads","issues_url":"https://api.github.com/repos/jasonaden/angular/issues{/number}","pulls_url":"https://api.github.com/repos/jasonaden/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/jasonaden/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/jasonaden/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jasonaden/angular/labels{/name}","releases_url":"https://api.github.com/repos/jasonaden/angular/releases{/id}","deployments_url":"https://api.github.com/repos/jasonaden/angular/deployments","created_at":"2017-01-24T01:01:10Z","updated_at":"2018-12-14T18:11:27Z","pushed_at":"2018-12-17T15:41:47Z","git_url":"git://github.com/jasonaden/angular.git","ssh_url":"git@github.com:jasonaden/angular.git","clone_url":"https://github.com/jasonaden/angular.git","svn_url":"https://github.com/jasonaden/angular","homepage":"https://angular.io","size":104698,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"f8096d499324cf0961f092944bbaedd05364eea1","user":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"node_id":"MDEwOlJlcG9zaXRvcnkyNDE5NTMzOQ==","name":"angular","full_name":"angular/angular","private":false,"owner":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/angular/angular","description":"One framework. Mobile & desktop.","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2018-12-18T21:24:29Z","pushed_at":"2018-12-18T21:55:15Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":96374,"stargazers_count":43611,"watchers_count":43611,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11208,"mirror_url":null,"archived":false,"open_issues_count":2606,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11208,"open_issues":2606,"watchers":43611,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/27682"},"html":{"href":"https://github.com/angular/angular/pull/27682"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/27682"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/27682/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/27682/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/27682/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/c00119055fa7cc80006a92ab50f08da3f97fe2cb"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":5,"review_comments":4,"maintainer_can_modify":false,"commits":1,"additions":50,"deletions":2,"changed_files":4}}
{"actor":{"display_login":"mhevery"}}