{"action":"created","issue":{"url":"https://api.github.com/repos/transloadit/uppy/issues/793","repository_url":"https://api.github.com/repos/transloadit/uppy","labels_url":"https://api.github.com/repos/transloadit/uppy/issues/793/labels{/name}","comments_url":"https://api.github.com/repos/transloadit/uppy/issues/793/comments","events_url":"https://api.github.com/repos/transloadit/uppy/issues/793/events","html_url":"https://github.com/transloadit/uppy/pull/793","id":318842542,"number":793,"title":"core: Remove .run().","user":{"login":"goto-bus-stop","id":1006268,"avatar_url":"https://avatars1.githubusercontent.com/u/1006268?v=4","gravatar_id":"","url":"https://api.github.com/users/goto-bus-stop","html_url":"https://github.com/goto-bus-stop","followers_url":"https://api.github.com/users/goto-bus-stop/followers","following_url":"https://api.github.com/users/goto-bus-stop/following{/other_user}","gists_url":"https://api.github.com/users/goto-bus-stop/gists{/gist_id}","starred_url":"https://api.github.com/users/goto-bus-stop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goto-bus-stop/subscriptions","organizations_url":"https://api.github.com/users/goto-bus-stop/orgs","repos_url":"https://api.github.com/users/goto-bus-stop/repos","events_url":"https://api.github.com/users/goto-bus-stop/events{/privacy}","received_events_url":"https://api.github.com/users/goto-bus-stop/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-04-30T10:13:16Z","updated_at":"2018-05-08T07:40:44Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/transloadit/uppy/pulls/793","html_url":"https://github.com/transloadit/uppy/pull/793","diff_url":"https://github.com/transloadit/uppy/pull/793.diff","patch_url":"https://github.com/transloadit/uppy/pull/793.patch"},"body":"This removes the need for calling `.run()` manually.\r\n\r\nWill wait for Artur to be back before going ahead with this tho :v:"},"comment":{"url":"https://api.github.com/repos/transloadit/uppy/issues/comments/387313998","html_url":"https://github.com/transloadit/uppy/pull/793#issuecomment-387313998","issue_url":"https://api.github.com/repos/transloadit/uppy/issues/793","id":387313998,"user":{"login":"tim-kos","id":15005,"avatar_url":"https://avatars1.githubusercontent.com/u/15005?v=4","gravatar_id":"","url":"https://api.github.com/users/tim-kos","html_url":"https://github.com/tim-kos","followers_url":"https://api.github.com/users/tim-kos/followers","following_url":"https://api.github.com/users/tim-kos/following{/other_user}","gists_url":"https://api.github.com/users/tim-kos/gists{/gist_id}","starred_url":"https://api.github.com/users/tim-kos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tim-kos/subscriptions","organizations_url":"https://api.github.com/users/tim-kos/orgs","repos_url":"https://api.github.com/users/tim-kos/repos","events_url":"https://api.github.com/users/tim-kos/events{/privacy}","received_events_url":"https://api.github.com/users/tim-kos/received_events","type":"User","site_admin":false},"created_at":"2018-05-08T07:40:44Z","updated_at":"2018-05-08T07:40:44Z","author_association":"OWNER","body":"I see a few PROs and CONs for removing .run:\r\n\r\nPROs\r\nP.1 Less code to write for the end user.\r\n\r\nP.2 Less possible things to forget for the end user, which then would only create support tickets.\r\n\r\n\r\nCONs\r\nC.1 A clear initialisation phase with .use, where order does not matter.\r\n\r\nC.2 Complete freedom to set things up inside without having to consider\r\nthat some parts might already have been .install()'ed or are run()ning already.\r\n\r\n\r\nWithout knowing super much about the inner workings of Uppy at this time, I have the feeling, that\r\n.use() and .install() should more or less mean the same thing. The English words mean more or less the same thing\r\nin the context of uploads I think.\r\n\r\nWhat would speak against treating them as such? .use() sets up things, and nothing really visible happens before .run() is called.\r\nSo that for example, when somebody clicks \"Browse files\", it wouldn't even open the file browser in case .run() was not called.\r\nThat would be the most obvious thing. Then also maybe show a string in the console that if the page was fully loaded, but .run() then was not called within 2 seconds or whatever.\r\n\r\nAlso maybe we could make it super explicit in the docs and on a screen before posting a GitHub issue that people should check if .run() was called.\r\nSort of like we always demand an Assembly ID before people post a support ticket for Transloadit."}}
{"actor":{"display_login":"tim-kos"}}