{"action":"created","comment":{"url":"https://api.github.com/repos/levelkdev/tidbit/pulls/comments/226162803","pull_request_review_id":165917881,"id":226162803,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjE2MjgwMw==","diff_hunk":"@@ -15,7 +16,7 @@ contract BasicOracle is OracleBase {\n    *  @dev BasicOracle constructor\n    *  @param _dataSource The address that is able to set the result\n    */\n-  constructor(address _dataSource) public {\n+  function initialize(address _dataSource) public isInitializer(\"BasicOracle\", \"0.0.0\") {","path":"contracts/Oracles/BasicOracle.sol","position":20,"original_position":20,"commit_id":"e2bf066afe6f58dbb791981105848dad550255a5","original_commit_id":"e2bf066afe6f58dbb791981105848dad550255a5","user":{"login":"monoidz","id":3450369,"node_id":"MDQ6VXNlcjM0NTAzNjk=","avatar_url":"https://avatars2.githubusercontent.com/u/3450369?v=4","gravatar_id":"","url":"https://api.github.com/users/monoidz","html_url":"https://github.com/monoidz","followers_url":"https://api.github.com/users/monoidz/followers","following_url":"https://api.github.com/users/monoidz/following{/other_user}","gists_url":"https://api.github.com/users/monoidz/gists{/gist_id}","starred_url":"https://api.github.com/users/monoidz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monoidz/subscriptions","organizations_url":"https://api.github.com/users/monoidz/orgs","repos_url":"https://api.github.com/users/monoidz/repos","events_url":"https://api.github.com/users/monoidz/events{/privacy}","received_events_url":"https://api.github.com/users/monoidz/received_events","type":"User","site_admin":false},"body":"https://github.com/zeppelinos/zos/blob/618b3772054b665e725322ef04773b434926bd8d/packages/docs/docs/website/versioned_docs/version-1.0.0/building.md\r\nThe example listed here is using the patten like:\r\n` function initialize(address _dataSource) isInitializer(\"BasicOracle\", \"0.0.0\") public`\r\nThey should behave the same. Just some style suggestion.","created_at":"2018-10-18T04:03:15Z","updated_at":"2018-10-18T04:03:15Z","html_url":"https://github.com/levelkdev/tidbit/pull/11#discussion_r226162803","pull_request_url":"https://api.github.com/repos/levelkdev/tidbit/pulls/11","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/levelkdev/tidbit/pulls/comments/226162803"},"html":{"href":"https://github.com/levelkdev/tidbit/pull/11#discussion_r226162803"},"pull_request":{"href":"https://api.github.com/repos/levelkdev/tidbit/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/levelkdev/tidbit/pulls/11","id":223655377,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNjU1Mzc3","html_url":"https://github.com/levelkdev/tidbit/pull/11","diff_url":"https://github.com/levelkdev/tidbit/pull/11.diff","patch_url":"https://github.com/levelkdev/tidbit/pull/11.patch","issue_url":"https://api.github.com/repos/levelkdev/tidbit/issues/11","number":11,"state":"open","locked":false,"title":"make single source oracles zos compatible","user":{"login":"jpkcambridge","id":874683,"node_id":"MDQ6VXNlcjg3NDY4Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/874683?v=4","gravatar_id":"","url":"https://api.github.com/users/jpkcambridge","html_url":"https://github.com/jpkcambridge","followers_url":"https://api.github.com/users/jpkcambridge/followers","following_url":"https://api.github.com/users/jpkcambridge/following{/other_user}","gists_url":"https://api.github.com/users/jpkcambridge/gists{/gist_id}","starred_url":"https://api.github.com/users/jpkcambridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpkcambridge/subscriptions","organizations_url":"https://api.github.com/users/jpkcambridge/orgs","repos_url":"https://api.github.com/users/jpkcambridge/repos","events_url":"https://api.github.com/users/jpkcambridge/events{/privacy}","received_events_url":"https://api.github.com/users/jpkcambridge/received_events","type":"User","site_admin":false},"body":"DO NOT MERGE\r\n\r\nProgress towards setting up a separate repo for the ZOS EVM package.  Please do not merge.  Just want some preliminary review before using this branch to establish a new repo.  Cc @monoidz ","created_at":"2018-10-17T15:40:27Z","updated_at":"2018-10-18T04:03:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05041df74927207d9dcb8ae5f9f1dfe770a08ad2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/levelkdev/tidbit/pulls/11/commits","review_comments_url":"https://api.github.com/repos/levelkdev/tidbit/pulls/11/comments","review_comment_url":"https://api.github.com/repos/levelkdev/tidbit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/levelkdev/tidbit/issues/11/comments","statuses_url":"https://api.github.com/repos/levelkdev/tidbit/statuses/e2bf066afe6f58dbb791981105848dad550255a5","head":{"label":"levelkdev:jpk-zos","ref":"jpk-zos","sha":"e2bf066afe6f58dbb791981105848dad550255a5","user":{"login":"levelkdev","id":29405139,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDA1MTM5","avatar_url":"https://avatars3.githubusercontent.com/u/29405139?v=4","gravatar_id":"","url":"https://api.github.com/users/levelkdev","html_url":"https://github.com/levelkdev","followers_url":"https://api.github.com/users/levelkdev/followers","following_url":"https://api.github.com/users/levelkdev/following{/other_user}","gists_url":"https://api.github.com/users/levelkdev/gists{/gist_id}","starred_url":"https://api.github.com/users/levelkdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levelkdev/subscriptions","organizations_url":"https://api.github.com/users/levelkdev/orgs","repos_url":"https://api.github.com/users/levelkdev/repos","events_url":"https://api.github.com/users/levelkdev/events{/privacy}","received_events_url":"https://api.github.com/users/levelkdev/received_events","type":"Organization","site_admin":false},"repo":{"id":142600076,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI2MDAwNzY=","name":"tidbit","full_name":"levelkdev/tidbit","private":false,"owner":{"login":"levelkdev","id":29405139,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDA1MTM5","avatar_url":"https://avatars3.githubusercontent.com/u/29405139?v=4","gravatar_id":"","url":"https://api.github.com/users/levelkdev","html_url":"https://github.com/levelkdev","followers_url":"https://api.github.com/users/levelkdev/followers","following_url":"https://api.github.com/users/levelkdev/following{/other_user}","gists_url":"https://api.github.com/users/levelkdev/gists{/gist_id}","starred_url":"https://api.github.com/users/levelkdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levelkdev/subscriptions","organizations_url":"https://api.github.com/users/levelkdev/orgs","repos_url":"https://api.github.com/users/levelkdev/repos","events_url":"https://api.github.com/users/levelkdev/events{/privacy}","received_events_url":"https://api.github.com/users/levelkdev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/levelkdev/tidbit","description":"A library for oracles on Ethereum","fork":false,"url":"https://api.github.com/repos/levelkdev/tidbit","forks_url":"https://api.github.com/repos/levelkdev/tidbit/forks","keys_url":"https://api.github.com/repos/levelkdev/tidbit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/levelkdev/tidbit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/levelkdev/tidbit/teams","hooks_url":"https://api.github.com/repos/levelkdev/tidbit/hooks","issue_events_url":"https://api.github.com/repos/levelkdev/tidbit/issues/events{/number}","events_url":"https://api.github.com/repos/levelkdev/tidbit/events","assignees_url":"https://api.github.com/repos/levelkdev/tidbit/assignees{/user}","branches_url":"https://api.github.com/repos/levelkdev/tidbit/branches{/branch}","tags_url":"https://api.github.com/repos/levelkdev/tidbit/tags","blobs_url":"https://api.github.com/repos/levelkdev/tidbit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/levelkdev/tidbit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/levelkdev/tidbit/git/refs{/sha}","trees_url":"https://api.github.com/repos/levelkdev/tidbit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/levelkdev/tidbit/statuses/{sha}","languages_url":"https://api.github.com/repos/levelkdev/tidbit/languages","stargazers_url":"https://api.github.com/repos/levelkdev/tidbit/stargazers","contributors_url":"https://api.github.com/repos/levelkdev/tidbit/contributors","subscribers_url":"https://api.github.com/repos/levelkdev/tidbit/subscribers","subscription_url":"https://api.github.com/repos/levelkdev/tidbit/subscription","commits_url":"https://api.github.com/repos/levelkdev/tidbit/commits{/sha}","git_commits_url":"https://api.github.com/repos/levelkdev/tidbit/git/commits{/sha}","comments_url":"https://api.github.com/repos/levelkdev/tidbit/comments{/number}","issue_comment_url":"https://api.github.com/repos/levelkdev/tidbit/issues/comments{/number}","contents_url":"https://api.github.com/repos/levelkdev/tidbit/contents/{+path}","compare_url":"https://api.github.com/repos/levelkdev/tidbit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/levelkdev/tidbit/merges","archive_url":"https://api.github.com/repos/levelkdev/tidbit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/levelkdev/tidbit/downloads","issues_url":"https://api.github.com/repos/levelkdev/tidbit/issues{/number}","pulls_url":"https://api.github.com/repos/levelkdev/tidbit/pulls{/number}","milestones_url":"https://api.github.com/repos/levelkdev/tidbit/milestones{/number}","notifications_url":"https://api.github.com/repos/levelkdev/tidbit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/levelkdev/tidbit/labels{/name}","releases_url":"https://api.github.com/repos/levelkdev/tidbit/releases{/id}","deployments_url":"https://api.github.com/repos/levelkdev/tidbit/deployments","created_at":"2018-07-27T16:26:01Z","updated_at":"2018-10-17T03:29:49Z","pushed_at":"2018-10-17T15:40:28Z","git_url":"git://github.com/levelkdev/tidbit.git","ssh_url":"git@github.com:levelkdev/tidbit.git","clone_url":"https://github.com/levelkdev/tidbit.git","svn_url":"https://github.com/levelkdev/tidbit","homepage":null,"size":452,"stargazers_count":14,"watchers_count":14,"language":"Solidity","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":2,"open_issues":1,"watchers":14,"default_branch":"master"}},"base":{"label":"levelkdev:master","ref":"master","sha":"0f1370355f67d8ad8d73c6654bd6bfbbca78a7ea","user":{"login":"levelkdev","id":29405139,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDA1MTM5","avatar_url":"https://avatars3.githubusercontent.com/u/29405139?v=4","gravatar_id":"","url":"https://api.github.com/users/levelkdev","html_url":"https://github.com/levelkdev","followers_url":"https://api.github.com/users/levelkdev/followers","following_url":"https://api.github.com/users/levelkdev/following{/other_user}","gists_url":"https://api.github.com/users/levelkdev/gists{/gist_id}","starred_url":"https://api.github.com/users/levelkdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levelkdev/subscriptions","organizations_url":"https://api.github.com/users/levelkdev/orgs","repos_url":"https://api.github.com/users/levelkdev/repos","events_url":"https://api.github.com/users/levelkdev/events{/privacy}","received_events_url":"https://api.github.com/users/levelkdev/received_events","type":"Organization","site_admin":false},"repo":{"id":142600076,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI2MDAwNzY=","name":"tidbit","full_name":"levelkdev/tidbit","private":false,"owner":{"login":"levelkdev","id":29405139,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDA1MTM5","avatar_url":"https://avatars3.githubusercontent.com/u/29405139?v=4","gravatar_id":"","url":"https://api.github.com/users/levelkdev","html_url":"https://github.com/levelkdev","followers_url":"https://api.github.com/users/levelkdev/followers","following_url":"https://api.github.com/users/levelkdev/following{/other_user}","gists_url":"https://api.github.com/users/levelkdev/gists{/gist_id}","starred_url":"https://api.github.com/users/levelkdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levelkdev/subscriptions","organizations_url":"https://api.github.com/users/levelkdev/orgs","repos_url":"https://api.github.com/users/levelkdev/repos","events_url":"https://api.github.com/users/levelkdev/events{/privacy}","received_events_url":"https://api.github.com/users/levelkdev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/levelkdev/tidbit","description":"A library for oracles on Ethereum","fork":false,"url":"https://api.github.com/repos/levelkdev/tidbit","forks_url":"https://api.github.com/repos/levelkdev/tidbit/forks","keys_url":"https://api.github.com/repos/levelkdev/tidbit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/levelkdev/tidbit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/levelkdev/tidbit/teams","hooks_url":"https://api.github.com/repos/levelkdev/tidbit/hooks","issue_events_url":"https://api.github.com/repos/levelkdev/tidbit/issues/events{/number}","events_url":"https://api.github.com/repos/levelkdev/tidbit/events","assignees_url":"https://api.github.com/repos/levelkdev/tidbit/assignees{/user}","branches_url":"https://api.github.com/repos/levelkdev/tidbit/branches{/branch}","tags_url":"https://api.github.com/repos/levelkdev/tidbit/tags","blobs_url":"https://api.github.com/repos/levelkdev/tidbit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/levelkdev/tidbit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/levelkdev/tidbit/git/refs{/sha}","trees_url":"https://api.github.com/repos/levelkdev/tidbit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/levelkdev/tidbit/statuses/{sha}","languages_url":"https://api.github.com/repos/levelkdev/tidbit/languages","stargazers_url":"https://api.github.com/repos/levelkdev/tidbit/stargazers","contributors_url":"https://api.github.com/repos/levelkdev/tidbit/contributors","subscribers_url":"https://api.github.com/repos/levelkdev/tidbit/subscribers","subscription_url":"https://api.github.com/repos/levelkdev/tidbit/subscription","commits_url":"https://api.github.com/repos/levelkdev/tidbit/commits{/sha}","git_commits_url":"https://api.github.com/repos/levelkdev/tidbit/git/commits{/sha}","comments_url":"https://api.github.com/repos/levelkdev/tidbit/comments{/number}","issue_comment_url":"https://api.github.com/repos/levelkdev/tidbit/issues/comments{/number}","contents_url":"https://api.github.com/repos/levelkdev/tidbit/contents/{+path}","compare_url":"https://api.github.com/repos/levelkdev/tidbit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/levelkdev/tidbit/merges","archive_url":"https://api.github.com/repos/levelkdev/tidbit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/levelkdev/tidbit/downloads","issues_url":"https://api.github.com/repos/levelkdev/tidbit/issues{/number}","pulls_url":"https://api.github.com/repos/levelkdev/tidbit/pulls{/number}","milestones_url":"https://api.github.com/repos/levelkdev/tidbit/milestones{/number}","notifications_url":"https://api.github.com/repos/levelkdev/tidbit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/levelkdev/tidbit/labels{/name}","releases_url":"https://api.github.com/repos/levelkdev/tidbit/releases{/id}","deployments_url":"https://api.github.com/repos/levelkdev/tidbit/deployments","created_at":"2018-07-27T16:26:01Z","updated_at":"2018-10-17T03:29:49Z","pushed_at":"2018-10-17T15:40:28Z","git_url":"git://github.com/levelkdev/tidbit.git","ssh_url":"git@github.com:levelkdev/tidbit.git","clone_url":"https://github.com/levelkdev/tidbit.git","svn_url":"https://github.com/levelkdev/tidbit","homepage":null,"size":452,"stargazers_count":14,"watchers_count":14,"language":"Solidity","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":2,"open_issues":1,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/levelkdev/tidbit/pulls/11"},"html":{"href":"https://github.com/levelkdev/tidbit/pull/11"},"issue":{"href":"https://api.github.com/repos/levelkdev/tidbit/issues/11"},"comments":{"href":"https://api.github.com/repos/levelkdev/tidbit/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/levelkdev/tidbit/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/levelkdev/tidbit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/levelkdev/tidbit/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/levelkdev/tidbit/statuses/e2bf066afe6f58dbb791981105848dad550255a5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"monoidz"}}