{"action":"created","comment":{"url":"https://api.github.com/repos/graphql/graphql-js/pulls/comments/197993680","pull_request_review_id":131843431,"id":197993680,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Nzk5MzY4MA==","diff_hunk":"@@ -1330,18 +889,19 @@ describe('findBreakingChanges', () => {\n   });\n \n   it('should detect if a directive was explicitly removed', () => {\n-    const oldSchema = new GraphQLSchema({\n-      directives: [GraphQLSkipDirective, GraphQLIncludeDirective],\n-    });\n+    const oldSchema = buildSchema(`\n+      directive @DirectiveThatIsRemoved on FIELD_DEFINITION\n+      directive @DirectiveThatStays on FIELD_DEFINITION\n+    `);\n \n-    const newSchema = new GraphQLSchema({\n-      directives: [GraphQLSkipDirective],\n-    });\n+    const newSchema = buildSchema(`\n+      directive @DirectiveThatStays on FIELD_DEFINITION\n+    `);\n \n     expect(findRemovedDirectives(oldSchema, newSchema)).to.eql([\n       {\n         type: BreakingChangeType.DIRECTIVE_REMOVED,\n-        description: `${GraphQLIncludeDirective.name} was removed`,\n+        description: `DirectiveThatIsRemoved was removed`,","path":"src/utilities/__tests__/findBreakingChanges-test.js","position":1562,"original_position":1562,"commit_id":"d6ddffd4b0de172d18adb74db24116019a38cafb","original_commit_id":"d6ddffd4b0de172d18adb74db24116019a38cafb","user":{"login":"JCMais","id":1041647,"node_id":"MDQ6VXNlcjEwNDE2NDc=","avatar_url":"https://avatars1.githubusercontent.com/u/1041647?v=4","gravatar_id":"","url":"https://api.github.com/users/JCMais","html_url":"https://github.com/JCMais","followers_url":"https://api.github.com/users/JCMais/followers","following_url":"https://api.github.com/users/JCMais/following{/other_user}","gists_url":"https://api.github.com/users/JCMais/gists{/gist_id}","starred_url":"https://api.github.com/users/JCMais/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JCMais/subscriptions","organizations_url":"https://api.github.com/users/JCMais/orgs","repos_url":"https://api.github.com/users/JCMais/repos","events_url":"https://api.github.com/users/JCMais/events{/privacy}","received_events_url":"https://api.github.com/users/JCMais/received_events","type":"User","site_admin":false},"body":"Change made for the same motive than above, `printSchema` does not print GraphQL default directives","created_at":"2018-06-26T02:05:40Z","updated_at":"2018-06-26T02:05:40Z","html_url":"https://github.com/graphql/graphql-js/pull/1406#discussion_r197993680","pull_request_url":"https://api.github.com/repos/graphql/graphql-js/pulls/1406","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/graphql/graphql-js/pulls/comments/197993680"},"html":{"href":"https://github.com/graphql/graphql-js/pull/1406#discussion_r197993680"},"pull_request":{"href":"https://api.github.com/repos/graphql/graphql-js/pulls/1406"}}},"pull_request":{"url":"https://api.github.com/repos/graphql/graphql-js/pulls/1406","id":197281657,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MjgxNjU3","html_url":"https://github.com/graphql/graphql-js/pull/1406","diff_url":"https://github.com/graphql/graphql-js/pull/1406.diff","patch_url":"https://github.com/graphql/graphql-js/pull/1406.patch","issue_url":"https://api.github.com/repos/graphql/graphql-js/issues/1406","number":1406,"state":"open","locked":false,"title":"findBreakingChanges tests: use buildSchema when possible","user":{"login":"JCMais","id":1041647,"node_id":"MDQ6VXNlcjEwNDE2NDc=","avatar_url":"https://avatars1.githubusercontent.com/u/1041647?v=4","gravatar_id":"","url":"https://api.github.com/users/JCMais","html_url":"https://github.com/JCMais","followers_url":"https://api.github.com/users/JCMais/followers","following_url":"https://api.github.com/users/JCMais/following{/other_user}","gists_url":"https://api.github.com/users/JCMais/gists{/gist_id}","starred_url":"https://api.github.com/users/JCMais/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JCMais/subscriptions","organizations_url":"https://api.github.com/users/JCMais/orgs","repos_url":"https://api.github.com/users/JCMais/repos","events_url":"https://api.github.com/users/JCMais/events{/privacy}","received_events_url":"https://api.github.com/users/JCMais/received_events","type":"User","site_admin":false},"body":"Instead of generating the schema by using the type constructors, this changes the tests to use `buildSchema` with the correct SDL for each test.\r\n\r\nRelated to https://github.com/graphql/graphql-js/issues/1341\r\n\r\nSDL was generated using the following code:\r\n```js\r\nimport { printSchema } from './index';\r\n\r\nconsole.log(\r\n  '    const oldSchema = buildSchema(`\\n' +\r\n  printSchema(oldSchema).split('\\n').map(s => s.padStart(s.length + 6)).slice(0, -1).join('\\n') +\r\n  '\\n    `);',\r\n);\r\nconsole.log('---');\r\nconsole.log(\r\n  '    const newSchema = buildSchema(`\\n' +\r\n  printSchema(newSchema).split('\\n').map(s => s.padStart(s.length + 6)).slice(0, -1).join('\\n') +\r\n  '\\n    `);',\r\n);\r\n```","created_at":"2018-06-26T02:01:34Z","updated_at":"2018-06-26T02:05:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e778222d34570105318b4aec36a0cffb672470e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":231582573,"node_id":"MDU6TGFiZWwyMzE1ODI1NzM=","url":"https://api.github.com/repos/graphql/graphql-js/labels/CLA%20Signed","name":"CLA Signed","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/graphql/graphql-js/pulls/1406/commits","review_comments_url":"https://api.github.com/repos/graphql/graphql-js/pulls/1406/comments","review_comment_url":"https://api.github.com/repos/graphql/graphql-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/graphql/graphql-js/issues/1406/comments","statuses_url":"https://api.github.com/repos/graphql/graphql-js/statuses/d6ddffd4b0de172d18adb74db24116019a38cafb","head":{"label":"JCMais:feat/improve-findBreakingChange-tests","ref":"feat/improve-findBreakingChange-tests","sha":"d6ddffd4b0de172d18adb74db24116019a38cafb","user":{"login":"JCMais","id":1041647,"node_id":"MDQ6VXNlcjEwNDE2NDc=","avatar_url":"https://avatars1.githubusercontent.com/u/1041647?v=4","gravatar_id":"","url":"https://api.github.com/users/JCMais","html_url":"https://github.com/JCMais","followers_url":"https://api.github.com/users/JCMais/followers","following_url":"https://api.github.com/users/JCMais/following{/other_user}","gists_url":"https://api.github.com/users/JCMais/gists{/gist_id}","starred_url":"https://api.github.com/users/JCMais/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JCMais/subscriptions","organizations_url":"https://api.github.com/users/JCMais/orgs","repos_url":"https://api.github.com/users/JCMais/repos","events_url":"https://api.github.com/users/JCMais/events{/privacy}","received_events_url":"https://api.github.com/users/JCMais/received_events","type":"User","site_admin":false},"repo":{"id":138234108,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgyMzQxMDg=","name":"graphql-js","full_name":"JCMais/graphql-js","owner":{"login":"JCMais","id":1041647,"node_id":"MDQ6VXNlcjEwNDE2NDc=","avatar_url":"https://avatars1.githubusercontent.com/u/1041647?v=4","gravatar_id":"","url":"https://api.github.com/users/JCMais","html_url":"https://github.com/JCMais","followers_url":"https://api.github.com/users/JCMais/followers","following_url":"https://api.github.com/users/JCMais/following{/other_user}","gists_url":"https://api.github.com/users/JCMais/gists{/gist_id}","starred_url":"https://api.github.com/users/JCMais/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JCMais/subscriptions","organizations_url":"https://api.github.com/users/JCMais/orgs","repos_url":"https://api.github.com/users/JCMais/repos","events_url":"https://api.github.com/users/JCMais/events{/privacy}","received_events_url":"https://api.github.com/users/JCMais/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JCMais/graphql-js","description":"A reference implementation of GraphQL for JavaScript","fork":true,"url":"https://api.github.com/repos/JCMais/graphql-js","forks_url":"https://api.github.com/repos/JCMais/graphql-js/forks","keys_url":"https://api.github.com/repos/JCMais/graphql-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JCMais/graphql-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JCMais/graphql-js/teams","hooks_url":"https://api.github.com/repos/JCMais/graphql-js/hooks","issue_events_url":"https://api.github.com/repos/JCMais/graphql-js/issues/events{/number}","events_url":"https://api.github.com/repos/JCMais/graphql-js/events","assignees_url":"https://api.github.com/repos/JCMais/graphql-js/assignees{/user}","branches_url":"https://api.github.com/repos/JCMais/graphql-js/branches{/branch}","tags_url":"https://api.github.com/repos/JCMais/graphql-js/tags","blobs_url":"https://api.github.com/repos/JCMais/graphql-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JCMais/graphql-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JCMais/graphql-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/JCMais/graphql-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JCMais/graphql-js/statuses/{sha}","languages_url":"https://api.github.com/repos/JCMais/graphql-js/languages","stargazers_url":"https://api.github.com/repos/JCMais/graphql-js/stargazers","contributors_url":"https://api.github.com/repos/JCMais/graphql-js/contributors","subscribers_url":"https://api.github.com/repos/JCMais/graphql-js/subscribers","subscription_url":"https://api.github.com/repos/JCMais/graphql-js/subscription","commits_url":"https://api.github.com/repos/JCMais/graphql-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/JCMais/graphql-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/JCMais/graphql-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/JCMais/graphql-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/JCMais/graphql-js/contents/{+path}","compare_url":"https://api.github.com/repos/JCMais/graphql-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JCMais/graphql-js/merges","archive_url":"https://api.github.com/repos/JCMais/graphql-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JCMais/graphql-js/downloads","issues_url":"https://api.github.com/repos/JCMais/graphql-js/issues{/number}","pulls_url":"https://api.github.com/repos/JCMais/graphql-js/pulls{/number}","milestones_url":"https://api.github.com/repos/JCMais/graphql-js/milestones{/number}","notifications_url":"https://api.github.com/repos/JCMais/graphql-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JCMais/graphql-js/labels{/name}","releases_url":"https://api.github.com/repos/JCMais/graphql-js/releases{/id}","deployments_url":"https://api.github.com/repos/JCMais/graphql-js/deployments","created_at":"2018-06-22T00:05:06Z","updated_at":"2018-06-22T00:05:09Z","pushed_at":"2018-06-26T01:59:26Z","git_url":"git://github.com/JCMais/graphql-js.git","ssh_url":"git@github.com:JCMais/graphql-js.git","clone_url":"https://github.com/JCMais/graphql-js.git","svn_url":"https://github.com/JCMais/graphql-js","homepage":"http://graphql.org/graphql-js/","size":4293,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"graphql:master","ref":"master","sha":"4f92f55a74477fde3b00eb99f9a37f1ff2d1bd0d","user":{"login":"graphql","id":12972006,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTcyMDA2","avatar_url":"https://avatars0.githubusercontent.com/u/12972006?v=4","gravatar_id":"","url":"https://api.github.com/users/graphql","html_url":"https://github.com/graphql","followers_url":"https://api.github.com/users/graphql/followers","following_url":"https://api.github.com/users/graphql/following{/other_user}","gists_url":"https://api.github.com/users/graphql/gists{/gist_id}","starred_url":"https://api.github.com/users/graphql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graphql/subscriptions","organizations_url":"https://api.github.com/users/graphql/orgs","repos_url":"https://api.github.com/users/graphql/repos","events_url":"https://api.github.com/users/graphql/events{/privacy}","received_events_url":"https://api.github.com/users/graphql/received_events","type":"Organization","site_admin":false},"repo":{"id":38307428,"node_id":"MDEwOlJlcG9zaXRvcnkzODMwNzQyOA==","name":"graphql-js","full_name":"graphql/graphql-js","owner":{"login":"graphql","id":12972006,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTcyMDA2","avatar_url":"https://avatars0.githubusercontent.com/u/12972006?v=4","gravatar_id":"","url":"https://api.github.com/users/graphql","html_url":"https://github.com/graphql","followers_url":"https://api.github.com/users/graphql/followers","following_url":"https://api.github.com/users/graphql/following{/other_user}","gists_url":"https://api.github.com/users/graphql/gists{/gist_id}","starred_url":"https://api.github.com/users/graphql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graphql/subscriptions","organizations_url":"https://api.github.com/users/graphql/orgs","repos_url":"https://api.github.com/users/graphql/repos","events_url":"https://api.github.com/users/graphql/events{/privacy}","received_events_url":"https://api.github.com/users/graphql/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/graphql/graphql-js","description":"A reference implementation of GraphQL for JavaScript","fork":false,"url":"https://api.github.com/repos/graphql/graphql-js","forks_url":"https://api.github.com/repos/graphql/graphql-js/forks","keys_url":"https://api.github.com/repos/graphql/graphql-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graphql/graphql-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graphql/graphql-js/teams","hooks_url":"https://api.github.com/repos/graphql/graphql-js/hooks","issue_events_url":"https://api.github.com/repos/graphql/graphql-js/issues/events{/number}","events_url":"https://api.github.com/repos/graphql/graphql-js/events","assignees_url":"https://api.github.com/repos/graphql/graphql-js/assignees{/user}","branches_url":"https://api.github.com/repos/graphql/graphql-js/branches{/branch}","tags_url":"https://api.github.com/repos/graphql/graphql-js/tags","blobs_url":"https://api.github.com/repos/graphql/graphql-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graphql/graphql-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graphql/graphql-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/graphql/graphql-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graphql/graphql-js/statuses/{sha}","languages_url":"https://api.github.com/repos/graphql/graphql-js/languages","stargazers_url":"https://api.github.com/repos/graphql/graphql-js/stargazers","contributors_url":"https://api.github.com/repos/graphql/graphql-js/contributors","subscribers_url":"https://api.github.com/repos/graphql/graphql-js/subscribers","subscription_url":"https://api.github.com/repos/graphql/graphql-js/subscription","commits_url":"https://api.github.com/repos/graphql/graphql-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/graphql/graphql-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/graphql/graphql-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/graphql/graphql-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/graphql/graphql-js/contents/{+path}","compare_url":"https://api.github.com/repos/graphql/graphql-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graphql/graphql-js/merges","archive_url":"https://api.github.com/repos/graphql/graphql-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graphql/graphql-js/downloads","issues_url":"https://api.github.com/repos/graphql/graphql-js/issues{/number}","pulls_url":"https://api.github.com/repos/graphql/graphql-js/pulls{/number}","milestones_url":"https://api.github.com/repos/graphql/graphql-js/milestones{/number}","notifications_url":"https://api.github.com/repos/graphql/graphql-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graphql/graphql-js/labels{/name}","releases_url":"https://api.github.com/repos/graphql/graphql-js/releases{/id}","deployments_url":"https://api.github.com/repos/graphql/graphql-js/deployments","created_at":"2015-06-30T12:16:50Z","updated_at":"2018-06-26T01:37:55Z","pushed_at":"2018-06-26T02:01:35Z","git_url":"git://github.com/graphql/graphql-js.git","ssh_url":"git@github.com:graphql/graphql-js.git","clone_url":"https://github.com/graphql/graphql-js.git","svn_url":"https://github.com/graphql/graphql-js","homepage":"http://graphql.org/graphql-js/","size":4293,"stargazers_count":10840,"watchers_count":10840,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":879,"mirror_url":null,"archived":false,"open_issues_count":88,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":879,"open_issues":88,"watchers":10840,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/graphql/graphql-js/pulls/1406"},"html":{"href":"https://github.com/graphql/graphql-js/pull/1406"},"issue":{"href":"https://api.github.com/repos/graphql/graphql-js/issues/1406"},"comments":{"href":"https://api.github.com/repos/graphql/graphql-js/issues/1406/comments"},"review_comments":{"href":"https://api.github.com/repos/graphql/graphql-js/pulls/1406/comments"},"review_comment":{"href":"https://api.github.com/repos/graphql/graphql-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/graphql/graphql-js/pulls/1406/commits"},"statuses":{"href":"https://api.github.com/repos/graphql/graphql-js/statuses/d6ddffd4b0de172d18adb74db24116019a38cafb"}},"author_association":"NONE"}}
{"actor":{"display_login":"JCMais"}}