{"action":"closed","number":18,"pull_request":{"url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/pulls/18","id":205647866,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NjQ3ODY2","html_url":"https://github.com/vaadin/bookstore-starter-flow/pull/18","diff_url":"https://github.com/vaadin/bookstore-starter-flow/pull/18.diff","patch_url":"https://github.com/vaadin/bookstore-starter-flow/pull/18.patch","issue_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/issues/18","number":18,"state":"closed","locked":false,"title":"Step four: migrating the products grid screen","user":{"login":"mehdi-vaadin","id":32511762,"node_id":"MDQ6VXNlcjMyNTExNzYy","avatar_url":"https://avatars3.githubusercontent.com/u/32511762?v=4","gravatar_id":"","url":"https://api.github.com/users/mehdi-vaadin","html_url":"https://github.com/mehdi-vaadin","followers_url":"https://api.github.com/users/mehdi-vaadin/followers","following_url":"https://api.github.com/users/mehdi-vaadin/following{/other_user}","gists_url":"https://api.github.com/users/mehdi-vaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/mehdi-vaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mehdi-vaadin/subscriptions","organizations_url":"https://api.github.com/users/mehdi-vaadin/orgs","repos_url":"https://api.github.com/users/mehdi-vaadin/repos","events_url":"https://api.github.com/users/mehdi-vaadin/events{/privacy}","received_events_url":"https://api.github.com/users/mehdi-vaadin/received_events","type":"User","site_admin":false},"body":"- Root routing is moved from `AboutView` to `SampleCrudView`\r\n- Required changes in `DataProvider`\r\n- Changes in `ProductGrid` and `SampleCrudView`\r\n- `ProductForm` is migrated in next step, the code related to it is commented for now\r\n\r\nFixes #11\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/vaadin/bookstore-starter-flow/18)\n<!-- Reviewable:end -->\n","created_at":"2018-08-02T07:54:40Z","updated_at":"2018-08-03T06:05:17Z","closed_at":"2018-08-03T06:05:17Z","merged_at":"2018-08-03T06:05:16Z","merge_commit_sha":"d628f29b81df8a94dacec72556a19f2d7f0ff019","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/pulls/18/commits","review_comments_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/pulls/18/comments","review_comment_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/issues/18/comments","statuses_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/statuses/308778a175a6d8c61c1c2babf3369797173bb3c3","head":{"label":"vaadin:migrating-product-grid","ref":"migrating-product-grid","sha":"308778a175a6d8c61c1c2babf3369797173bb3c3","user":{"login":"vaadin","id":1171922,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzE5MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1171922?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin","html_url":"https://github.com/vaadin","followers_url":"https://api.github.com/users/vaadin/followers","following_url":"https://api.github.com/users/vaadin/following{/other_user}","gists_url":"https://api.github.com/users/vaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin/subscriptions","organizations_url":"https://api.github.com/users/vaadin/orgs","repos_url":"https://api.github.com/users/vaadin/repos","events_url":"https://api.github.com/users/vaadin/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin/received_events","type":"Organization","site_admin":false},"repo":{"id":137178358,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcxNzgzNTg=","name":"bookstore-starter-flow","full_name":"vaadin/bookstore-starter-flow","owner":{"login":"vaadin","id":1171922,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzE5MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1171922?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin","html_url":"https://github.com/vaadin","followers_url":"https://api.github.com/users/vaadin/followers","following_url":"https://api.github.com/users/vaadin/following{/other_user}","gists_url":"https://api.github.com/users/vaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin/subscriptions","organizations_url":"https://api.github.com/users/vaadin/orgs","repos_url":"https://api.github.com/users/vaadin/repos","events_url":"https://api.github.com/users/vaadin/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vaadin/bookstore-starter-flow","description":null,"fork":false,"url":"https://api.github.com/repos/vaadin/bookstore-starter-flow","forks_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/forks","keys_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/teams","hooks_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/hooks","issue_events_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/issues/events{/number}","events_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/events","assignees_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/assignees{/user}","branches_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/branches{/branch}","tags_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/tags","blobs_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/git/refs{/sha}","trees_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/statuses/{sha}","languages_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/languages","stargazers_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/stargazers","contributors_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/contributors","subscribers_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/subscribers","subscription_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/subscription","commits_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/commits{/sha}","git_commits_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/git/commits{/sha}","comments_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/comments{/number}","issue_comment_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/issues/comments{/number}","contents_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/contents/{+path}","compare_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/merges","archive_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/downloads","issues_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/issues{/number}","pulls_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/pulls{/number}","milestones_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/milestones{/number}","notifications_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/labels{/name}","releases_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/releases{/id}","deployments_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/deployments","created_at":"2018-06-13T07:23:30Z","updated_at":"2018-08-01T06:39:03Z","pushed_at":"2018-08-03T06:05:16Z","git_url":"git://github.com/vaadin/bookstore-starter-flow.git","ssh_url":"git@github.com:vaadin/bookstore-starter-flow.git","clone_url":"https://github.com/vaadin/bookstore-starter-flow.git","svn_url":"https://github.com/vaadin/bookstore-starter-flow","homepage":null,"size":243,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":1,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"vaadin:master","ref":"master","sha":"f017602f668527d26f02f1cd2ef862f474ba033b","user":{"login":"vaadin","id":1171922,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzE5MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1171922?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin","html_url":"https://github.com/vaadin","followers_url":"https://api.github.com/users/vaadin/followers","following_url":"https://api.github.com/users/vaadin/following{/other_user}","gists_url":"https://api.github.com/users/vaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin/subscriptions","organizations_url":"https://api.github.com/users/vaadin/orgs","repos_url":"https://api.github.com/users/vaadin/repos","events_url":"https://api.github.com/users/vaadin/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin/received_events","type":"Organization","site_admin":false},"repo":{"id":137178358,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcxNzgzNTg=","name":"bookstore-starter-flow","full_name":"vaadin/bookstore-starter-flow","owner":{"login":"vaadin","id":1171922,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzE5MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1171922?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin","html_url":"https://github.com/vaadin","followers_url":"https://api.github.com/users/vaadin/followers","following_url":"https://api.github.com/users/vaadin/following{/other_user}","gists_url":"https://api.github.com/users/vaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin/subscriptions","organizations_url":"https://api.github.com/users/vaadin/orgs","repos_url":"https://api.github.com/users/vaadin/repos","events_url":"https://api.github.com/users/vaadin/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vaadin/bookstore-starter-flow","description":null,"fork":false,"url":"https://api.github.com/repos/vaadin/bookstore-starter-flow","forks_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/forks","keys_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/teams","hooks_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/hooks","issue_events_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/issues/events{/number}","events_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/events","assignees_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/assignees{/user}","branches_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/branches{/branch}","tags_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/tags","blobs_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/git/refs{/sha}","trees_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/statuses/{sha}","languages_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/languages","stargazers_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/stargazers","contributors_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/contributors","subscribers_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/subscribers","subscription_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/subscription","commits_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/commits{/sha}","git_commits_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/git/commits{/sha}","comments_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/comments{/number}","issue_comment_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/issues/comments{/number}","contents_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/contents/{+path}","compare_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/merges","archive_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/downloads","issues_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/issues{/number}","pulls_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/pulls{/number}","milestones_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/milestones{/number}","notifications_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/labels{/name}","releases_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/releases{/id}","deployments_url":"https://api.github.com/repos/vaadin/bookstore-starter-flow/deployments","created_at":"2018-06-13T07:23:30Z","updated_at":"2018-08-01T06:39:03Z","pushed_at":"2018-08-03T06:05:16Z","git_url":"git://github.com/vaadin/bookstore-starter-flow.git","ssh_url":"git@github.com:vaadin/bookstore-starter-flow.git","clone_url":"https://github.com/vaadin/bookstore-starter-flow.git","svn_url":"https://github.com/vaadin/bookstore-starter-flow","homepage":null,"size":243,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":1,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vaadin/bookstore-starter-flow/pulls/18"},"html":{"href":"https://github.com/vaadin/bookstore-starter-flow/pull/18"},"issue":{"href":"https://api.github.com/repos/vaadin/bookstore-starter-flow/issues/18"},"comments":{"href":"https://api.github.com/repos/vaadin/bookstore-starter-flow/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/vaadin/bookstore-starter-flow/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/vaadin/bookstore-starter-flow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vaadin/bookstore-starter-flow/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/vaadin/bookstore-starter-flow/statuses/308778a175a6d8c61c1c2babf3369797173bb3c3"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"denis-anisimov","id":11425472,"node_id":"MDQ6VXNlcjExNDI1NDcy","avatar_url":"https://avatars0.githubusercontent.com/u/11425472?v=4","gravatar_id":"","url":"https://api.github.com/users/denis-anisimov","html_url":"https://github.com/denis-anisimov","followers_url":"https://api.github.com/users/denis-anisimov/followers","following_url":"https://api.github.com/users/denis-anisimov/following{/other_user}","gists_url":"https://api.github.com/users/denis-anisimov/gists{/gist_id}","starred_url":"https://api.github.com/users/denis-anisimov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denis-anisimov/subscriptions","organizations_url":"https://api.github.com/users/denis-anisimov/orgs","repos_url":"https://api.github.com/users/denis-anisimov/repos","events_url":"https://api.github.com/users/denis-anisimov/events{/privacy}","received_events_url":"https://api.github.com/users/denis-anisimov/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":119,"deletions":135,"changed_files":4}}
{"actor":{"display_login":"denis-anisimov"}}