{"action":"closed","number":693,"pull_request":{"url":"https://api.github.com/repos/miekg/dns/pulls/693","id":192555036,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNTU1MDM2","html_url":"https://github.com/miekg/dns/pull/693","diff_url":"https://github.com/miekg/dns/pull/693.diff","patch_url":"https://github.com/miekg/dns/pull/693.patch","issue_url":"https://api.github.com/repos/miekg/dns/issues/693","number":693,"state":"closed","locked":false,"title":"Harden RSA public key unpacking","user":{"login":"andrewtj","id":21676,"node_id":"MDQ6VXNlcjIxNjc2","avatar_url":"https://avatars0.githubusercontent.com/u/21676?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewtj","html_url":"https://github.com/andrewtj","followers_url":"https://api.github.com/users/andrewtj/followers","following_url":"https://api.github.com/users/andrewtj/following{/other_user}","gists_url":"https://api.github.com/users/andrewtj/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewtj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewtj/subscriptions","organizations_url":"https://api.github.com/users/andrewtj/orgs","repos_url":"https://api.github.com/users/andrewtj/repos","events_url":"https://api.github.com/users/andrewtj/events{/privacy}","received_events_url":"https://api.github.com/users/andrewtj/received_events","type":"User","site_admin":false},"body":"RFC 2537 (RSA/MD5) and RFC 3110 (RSA/SHA1) disallow leading zero octets.\r\nRFC 5702 (RSA/SHA256 and RSA/SHA512) isn't specific but defers to these\r\nearlier RFCs in other places.\r\n\r\nThere is an upper limit of 4096 bits for both the modulus and exponent.\r\nThe modulus must be at least 512 bits. No minimum is specified for the\r\nexponent but a quick search suggests single byte exponents are viable.\r\n\r\nExponents larger than 32 bits are already disallowed. This commit adds\r\nchecks for the other requirements, general bounds checks, and defers\r\ninitialisation of the big num till the other checks have passed.","created_at":"2018-06-04T23:34:15Z","updated_at":"2018-06-05T06:18:11Z","closed_at":"2018-06-05T06:18:11Z","merged_at":"2018-06-05T06:18:11Z","merge_commit_sha":"0a83f30697946bfe5806581642457c2b829abb2c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/miekg/dns/pulls/693/commits","review_comments_url":"https://api.github.com/repos/miekg/dns/pulls/693/comments","review_comment_url":"https://api.github.com/repos/miekg/dns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/miekg/dns/issues/693/comments","statuses_url":"https://api.github.com/repos/miekg/dns/statuses/3c5959c314131dd2443ba4f435acc55134042f9b","head":{"label":"andrewtj:atj-checkrsa","ref":"atj-checkrsa","sha":"3c5959c314131dd2443ba4f435acc55134042f9b","user":{"login":"andrewtj","id":21676,"node_id":"MDQ6VXNlcjIxNjc2","avatar_url":"https://avatars0.githubusercontent.com/u/21676?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewtj","html_url":"https://github.com/andrewtj","followers_url":"https://api.github.com/users/andrewtj/followers","following_url":"https://api.github.com/users/andrewtj/following{/other_user}","gists_url":"https://api.github.com/users/andrewtj/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewtj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewtj/subscriptions","organizations_url":"https://api.github.com/users/andrewtj/orgs","repos_url":"https://api.github.com/users/andrewtj/repos","events_url":"https://api.github.com/users/andrewtj/events{/privacy}","received_events_url":"https://api.github.com/users/andrewtj/received_events","type":"User","site_admin":false},"repo":{"id":15176994,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE3Njk5NA==","name":"dns","full_name":"andrewtj/dns","owner":{"login":"andrewtj","id":21676,"node_id":"MDQ6VXNlcjIxNjc2","avatar_url":"https://avatars0.githubusercontent.com/u/21676?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewtj","html_url":"https://github.com/andrewtj","followers_url":"https://api.github.com/users/andrewtj/followers","following_url":"https://api.github.com/users/andrewtj/following{/other_user}","gists_url":"https://api.github.com/users/andrewtj/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewtj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewtj/subscriptions","organizations_url":"https://api.github.com/users/andrewtj/orgs","repos_url":"https://api.github.com/users/andrewtj/repos","events_url":"https://api.github.com/users/andrewtj/events{/privacy}","received_events_url":"https://api.github.com/users/andrewtj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrewtj/dns","description":"DNS library in Go","fork":true,"url":"https://api.github.com/repos/andrewtj/dns","forks_url":"https://api.github.com/repos/andrewtj/dns/forks","keys_url":"https://api.github.com/repos/andrewtj/dns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewtj/dns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewtj/dns/teams","hooks_url":"https://api.github.com/repos/andrewtj/dns/hooks","issue_events_url":"https://api.github.com/repos/andrewtj/dns/issues/events{/number}","events_url":"https://api.github.com/repos/andrewtj/dns/events","assignees_url":"https://api.github.com/repos/andrewtj/dns/assignees{/user}","branches_url":"https://api.github.com/repos/andrewtj/dns/branches{/branch}","tags_url":"https://api.github.com/repos/andrewtj/dns/tags","blobs_url":"https://api.github.com/repos/andrewtj/dns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewtj/dns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewtj/dns/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewtj/dns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewtj/dns/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewtj/dns/languages","stargazers_url":"https://api.github.com/repos/andrewtj/dns/stargazers","contributors_url":"https://api.github.com/repos/andrewtj/dns/contributors","subscribers_url":"https://api.github.com/repos/andrewtj/dns/subscribers","subscription_url":"https://api.github.com/repos/andrewtj/dns/subscription","commits_url":"https://api.github.com/repos/andrewtj/dns/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewtj/dns/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewtj/dns/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewtj/dns/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewtj/dns/contents/{+path}","compare_url":"https://api.github.com/repos/andrewtj/dns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewtj/dns/merges","archive_url":"https://api.github.com/repos/andrewtj/dns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewtj/dns/downloads","issues_url":"https://api.github.com/repos/andrewtj/dns/issues{/number}","pulls_url":"https://api.github.com/repos/andrewtj/dns/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewtj/dns/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewtj/dns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewtj/dns/labels{/name}","releases_url":"https://api.github.com/repos/andrewtj/dns/releases{/id}","deployments_url":"https://api.github.com/repos/andrewtj/dns/deployments","created_at":"2013-12-14T00:02:57Z","updated_at":"2018-05-24T09:04:38Z","pushed_at":"2018-06-04T23:31:09Z","git_url":"git://github.com/andrewtj/dns.git","ssh_url":"git@github.com:andrewtj/dns.git","clone_url":"https://github.com/andrewtj/dns.git","svn_url":"https://github.com/andrewtj/dns","homepage":"miek.nl/projects/godns","size":13519,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"miekg:master","ref":"master","sha":"5a2b9fab83ff0f8bfc99684bd5f43a37abe560f1","user":{"login":"miekg","id":353371,"node_id":"MDQ6VXNlcjM1MzM3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/353371?v=4","gravatar_id":"","url":"https://api.github.com/users/miekg","html_url":"https://github.com/miekg","followers_url":"https://api.github.com/users/miekg/followers","following_url":"https://api.github.com/users/miekg/following{/other_user}","gists_url":"https://api.github.com/users/miekg/gists{/gist_id}","starred_url":"https://api.github.com/users/miekg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miekg/subscriptions","organizations_url":"https://api.github.com/users/miekg/orgs","repos_url":"https://api.github.com/users/miekg/repos","events_url":"https://api.github.com/users/miekg/events{/privacy}","received_events_url":"https://api.github.com/users/miekg/received_events","type":"User","site_admin":false},"repo":{"id":815644,"node_id":"MDEwOlJlcG9zaXRvcnk4MTU2NDQ=","name":"dns","full_name":"miekg/dns","owner":{"login":"miekg","id":353371,"node_id":"MDQ6VXNlcjM1MzM3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/353371?v=4","gravatar_id":"","url":"https://api.github.com/users/miekg","html_url":"https://github.com/miekg","followers_url":"https://api.github.com/users/miekg/followers","following_url":"https://api.github.com/users/miekg/following{/other_user}","gists_url":"https://api.github.com/users/miekg/gists{/gist_id}","starred_url":"https://api.github.com/users/miekg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miekg/subscriptions","organizations_url":"https://api.github.com/users/miekg/orgs","repos_url":"https://api.github.com/users/miekg/repos","events_url":"https://api.github.com/users/miekg/events{/privacy}","received_events_url":"https://api.github.com/users/miekg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/miekg/dns","description":"DNS library in Go","fork":false,"url":"https://api.github.com/repos/miekg/dns","forks_url":"https://api.github.com/repos/miekg/dns/forks","keys_url":"https://api.github.com/repos/miekg/dns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/miekg/dns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/miekg/dns/teams","hooks_url":"https://api.github.com/repos/miekg/dns/hooks","issue_events_url":"https://api.github.com/repos/miekg/dns/issues/events{/number}","events_url":"https://api.github.com/repos/miekg/dns/events","assignees_url":"https://api.github.com/repos/miekg/dns/assignees{/user}","branches_url":"https://api.github.com/repos/miekg/dns/branches{/branch}","tags_url":"https://api.github.com/repos/miekg/dns/tags","blobs_url":"https://api.github.com/repos/miekg/dns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/miekg/dns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/miekg/dns/git/refs{/sha}","trees_url":"https://api.github.com/repos/miekg/dns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/miekg/dns/statuses/{sha}","languages_url":"https://api.github.com/repos/miekg/dns/languages","stargazers_url":"https://api.github.com/repos/miekg/dns/stargazers","contributors_url":"https://api.github.com/repos/miekg/dns/contributors","subscribers_url":"https://api.github.com/repos/miekg/dns/subscribers","subscription_url":"https://api.github.com/repos/miekg/dns/subscription","commits_url":"https://api.github.com/repos/miekg/dns/commits{/sha}","git_commits_url":"https://api.github.com/repos/miekg/dns/git/commits{/sha}","comments_url":"https://api.github.com/repos/miekg/dns/comments{/number}","issue_comment_url":"https://api.github.com/repos/miekg/dns/issues/comments{/number}","contents_url":"https://api.github.com/repos/miekg/dns/contents/{+path}","compare_url":"https://api.github.com/repos/miekg/dns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/miekg/dns/merges","archive_url":"https://api.github.com/repos/miekg/dns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/miekg/dns/downloads","issues_url":"https://api.github.com/repos/miekg/dns/issues{/number}","pulls_url":"https://api.github.com/repos/miekg/dns/pulls{/number}","milestones_url":"https://api.github.com/repos/miekg/dns/milestones{/number}","notifications_url":"https://api.github.com/repos/miekg/dns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/miekg/dns/labels{/name}","releases_url":"https://api.github.com/repos/miekg/dns/releases{/id}","deployments_url":"https://api.github.com/repos/miekg/dns/deployments","created_at":"2010-08-03T21:56:23Z","updated_at":"2018-06-05T01:17:29Z","pushed_at":"2018-06-05T06:18:11Z","git_url":"git://github.com/miekg/dns.git","ssh_url":"git@github.com:miekg/dns.git","clone_url":"https://github.com/miekg/dns.git","svn_url":"https://github.com/miekg/dns","homepage":"https://miek.nl/2014/august/16/go-dns-package","size":13234,"stargazers_count":2853,"watchers_count":2853,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":511,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":511,"open_issues":33,"watchers":2853,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/miekg/dns/pulls/693"},"html":{"href":"https://github.com/miekg/dns/pull/693"},"issue":{"href":"https://api.github.com/repos/miekg/dns/issues/693"},"comments":{"href":"https://api.github.com/repos/miekg/dns/issues/693/comments"},"review_comments":{"href":"https://api.github.com/repos/miekg/dns/pulls/693/comments"},"review_comment":{"href":"https://api.github.com/repos/miekg/dns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/miekg/dns/pulls/693/commits"},"statuses":{"href":"https://api.github.com/repos/miekg/dns/statuses/3c5959c314131dd2443ba4f435acc55134042f9b"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"miekg","id":353371,"node_id":"MDQ6VXNlcjM1MzM3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/353371?v=4","gravatar_id":"","url":"https://api.github.com/users/miekg","html_url":"https://github.com/miekg","followers_url":"https://api.github.com/users/miekg/followers","following_url":"https://api.github.com/users/miekg/following{/other_user}","gists_url":"https://api.github.com/users/miekg/gists{/gist_id}","starred_url":"https://api.github.com/users/miekg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miekg/subscriptions","organizations_url":"https://api.github.com/users/miekg/orgs","repos_url":"https://api.github.com/users/miekg/repos","events_url":"https://api.github.com/users/miekg/events{/privacy}","received_events_url":"https://api.github.com/users/miekg/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":20,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"miekg"}}