{"action":"created","issue":{"url":"https://api.github.com/repos/ethresearch/sharding-p2p-poc/issues/95","repository_url":"https://api.github.com/repos/ethresearch/sharding-p2p-poc","labels_url":"https://api.github.com/repos/ethresearch/sharding-p2p-poc/issues/95/labels{/name}","comments_url":"https://api.github.com/repos/ethresearch/sharding-p2p-poc/issues/95/comments","events_url":"https://api.github.com/repos/ethresearch/sharding-p2p-poc/issues/95/events","html_url":"https://github.com/ethresearch/sharding-p2p-poc/pull/95","id":374732680,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MzUyNzg4","number":95,"title":"Fix nil event notifier","user":{"login":"NIC619","id":17670147,"node_id":"MDQ6VXNlcjE3NjcwMTQ3","avatar_url":"https://avatars0.githubusercontent.com/u/17670147?v=4","gravatar_id":"","url":"https://api.github.com/users/NIC619","html_url":"https://github.com/NIC619","followers_url":"https://api.github.com/users/NIC619/followers","following_url":"https://api.github.com/users/NIC619/following{/other_user}","gists_url":"https://api.github.com/users/NIC619/gists{/gist_id}","starred_url":"https://api.github.com/users/NIC619/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NIC619/subscriptions","organizations_url":"https://api.github.com/users/NIC619/orgs","repos_url":"https://api.github.com/users/NIC619/repos","events_url":"https://api.github.com/users/NIC619/events{/privacy}","received_events_url":"https://api.github.com/users/NIC619/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-28T09:05:06Z","updated_at":"2018-10-28T14:44:12Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/ethresearch/sharding-p2p-poc/pulls/95","html_url":"https://github.com/ethresearch/sharding-p2p-poc/pull/95","diff_url":"https://github.com/ethresearch/sharding-p2p-poc/pull/95.diff","patch_url":"https://github.com/ethresearch/sharding-p2p-poc/pull/95.patch"},"body":"### What was wrong?\r\n`eventnotifier` was set to `nil` if there was no event notifier server. However it was an interface with its value being `nil`, not a `nil` interface. So the comparison `n.eventnotifier != nil` will always return `true`.\r\n\r\n\r\n### How was it fixed?\r\nCompare `n.eventnotifier` against typed `nil`\r\n\r\n\r\n#### Cute Animal Picture\r\n\r\n![](https://www.maxpixel.net/static/photo/2x/Cat-Kitty-Cute-Pets-1796843.jpg)\r\npic credit: [maxpixel](https://www.maxpixel.net/Cute-Kitty-Pets-Cat-1796843)"},"comment":{"url":"https://api.github.com/repos/ethresearch/sharding-p2p-poc/issues/comments/433711791","html_url":"https://github.com/ethresearch/sharding-p2p-poc/pull/95#issuecomment-433711791","issue_url":"https://api.github.com/repos/ethresearch/sharding-p2p-poc/issues/95","id":433711791,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzcxMTc5MQ==","user":{"login":"mhchia","id":8223657,"node_id":"MDQ6VXNlcjgyMjM2NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8223657?v=4","gravatar_id":"","url":"https://api.github.com/users/mhchia","html_url":"https://github.com/mhchia","followers_url":"https://api.github.com/users/mhchia/followers","following_url":"https://api.github.com/users/mhchia/following{/other_user}","gists_url":"https://api.github.com/users/mhchia/gists{/gist_id}","starred_url":"https://api.github.com/users/mhchia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhchia/subscriptions","organizations_url":"https://api.github.com/users/mhchia/orgs","repos_url":"https://api.github.com/users/mhchia/repos","events_url":"https://api.github.com/users/mhchia/events{/privacy}","received_events_url":"https://api.github.com/users/mhchia/received_events","type":"User","site_admin":false},"created_at":"2018-10-28T14:44:12Z","updated_at":"2018-10-28T14:44:12Z","author_association":"MEMBER","body":"Thanks a lot for discovering and solving this issue\r\nAdd the reference to the discussion: https://groups.google.com/forum/#!topic/golang-nuts/wnH302gBa4I/discussion"}}
{"actor":{"display_login":"mhchia"}}