{"push_id":2896104878,"size":1000,"distinct_size":3,"ref":"refs/heads/implement-windowagg-distinct","head":"9ecd882877215e36ed15c3122c0cef8a547e548d","before":"fe08b4168960da2a39681521185a2593d54d1f2e","commits":[{"sha":"c90dcd6d2c76402ce307b0d44958c6ca274f2c39","author":{"name":"Bruce Momjian","email":"9ae9c44b775ee9b29f4f502415e02e61a9b1a6a0@momjian.us"},"message":"In pg_upgrade docs, mention using base backup as part of rsync for\nlogical replication upgrades.\n\nBackpatch to 9.2.","distinct":false,"url":"https://api.github.com/repos/hlinnaka/gpdb/commits/c90dcd6d2c76402ce307b0d44958c6ca274f2c39"},{"sha":"4ee5c40b06f098910ed0fc5fd72fb2744776ccbb","author":{"name":"Alvaro Herrera","email":"3c84f0de6f8a0f296d36cdd9f57fa166641c96b1@alvh.no-ip.org"},"message":"Don't try to use a unopened relation\n\nCommit 4c9d0901 mistakenly introduced a call to\nTransferPredicateLocksToHeapRelation() on an index relation that had\nbeen closed a few lines above.  Moving up an index_open() call that's\nbelow is enough to fix the problem.\n\nDiscovered by me while testing an unrelated patch.","distinct":false,"url":"https://api.github.com/repos/hlinnaka/gpdb/commits/4ee5c40b06f098910ed0fc5fd72fb2744776ccbb"},{"sha":"aa69670e4296321b51251d34e9bd2c4bc17aab75","author":{"name":"Bruce Momjian","email":"9ae9c44b775ee9b29f4f502415e02e61a9b1a6a0@momjian.us"},"message":"Add URLs to document why DLLIMPORT is needed on Windows.\n\nPer email from Craig Ringer","distinct":false,"url":"https://api.github.com/repos/hlinnaka/gpdb/commits/aa69670e4296321b51251d34e9bd2c4bc17aab75"},{"sha":"9e45e03886c75dd049bcc1b063e0bf34e46a3a62","author":{"name":"Tom Lane","email":"ffeaa947aef224da9ba99b6a18bdd74288df0e3e@sss.pgh.pa.us"},"message":"Fix missing inclusions.\n\nSome platforms require including <netinet/in.h> and/or <arpa/inet.h> to\nuse htonl() and ntohl().  Per build failure locally.","distinct":false,"url":"https://api.github.com/repos/hlinnaka/gpdb/commits/9e45e03886c75dd049bcc1b063e0bf34e46a3a62"},{"sha":"a9dad56441e4bc5d20c34bd56daf8e72df1b22d3","author":{"name":"Heikki Linnakangas","email":"ac1e0af1ee8efe15f889b38482e897ff7d0f0432@iki.fi"},"message":"Teach pg_basebackup and pg_receivexlog to reply to server keepalives.\n\nWithout this, the connection will be killed after timeout if\nwal_sender_timeout is set in the server.\n\nOriginal patch by Amit Kapila, modified by me to fit recent changes in the\ncode.","distinct":false,"url":"https://api.github.com/repos/hlinnaka/gpdb/commits/a9dad56441e4bc5d20c34bd56daf8e72df1b22d3"},{"sha":"75af5ae9c017d70531bd49178adfd3103cd40a76","author":{"name":"Tom Lane","email":"ffeaa947aef224da9ba99b6a18bdd74288df0e3e@sss.pgh.pa.us"},"message":"Don't trash input list structure in does_not_exist_skipping().\n\nThe trigger and rule cases need to split up the input name list, but\nthey mustn't corrupt the passed-in data structure, since it could be part\nof a cached utility-statement parsetree.  Per bug #7641.","distinct":false,"url":"https://api.github.com/repos/hlinnaka/gpdb/commits/75af5ae9c017d70531bd49178adfd3103cd40a76"},{"sha":"dcc55dd21aa2ba18b28ba9fa441885ef9c99d3c6","author":{"name":"Tom Lane","email":"ffeaa947aef224da9ba99b6a18bdd74288df0e3e@sss.pgh.pa.us"},"message":"Rename ResolveNew() to ReplaceVarsFromTargetList(), and tweak its API.\n\nThis function currently lacks the option to throw error if the provided\ntargetlist doesn't have any matching entry for a Var to be replaced.\nTwo of the four existing call sites would be better off with an error,\nas would the usage in the pending auto-updatable-views patch, so it seems\npast time to extend the API to support that.  To do so, replace the \"event\"\nparameter (historically of type CmdType, though it was declared plain int)\nwith a special-purpose enum type.\n\nIt's unclear whether this function might be called by third-party code.\nSince many C compilers wouldn't warn about a call site continuing to use\nthe old calling convention, rename the function to forcibly break any\nsuch code that hasn't been updated.  The old name was none too well chosen\nanyhow.","distinct":false,"url":"https://api.github.com/repos/hlinnaka/gpdb/commits/dcc55dd21aa2ba18b28ba9fa441885ef9c99d3c6"},{"sha":"3e7fdcffd6f77187b72b0496d61d782932973af6","author":{"name":"Tom Lane","email":"ffeaa947aef224da9ba99b6a18bdd74288df0e3e@sss.pgh.pa.us"},"message":"Fix WaitLatch() to return promptly when the requested timeout expires.\n\nIf the sleep is interrupted by a signal, we must recompute the remaining\ntime to wait; otherwise, a steady stream of non-wait-terminating interrupts\ncould delay return from WaitLatch indefinitely.  This has been shown to be\na problem for the autovacuum launcher, and there may well be other places\nnow or in the future with similar issues.  So we'd better make the function\nrobust, even though this'll add at least one gettimeofday call per wait.\n\nBack-patch to 9.2.  We might eventually need to fix 9.1 as well, but the\ncode is quite different there, and the usage of WaitLatch in 9.1 is so\nlimited that it's not clearly important to do so.\n\nReported and diagnosed by Jeff Janes, though I rewrote his patch rather\nheavily.","distinct":false,"url":"https://api.github.com/repos/hlinnaka/gpdb/commits/3e7fdcffd6f77187b72b0496d61d782932973af6"},{"sha":"732740e7d440baac832fbce9a000193a55a35d43","author":{"name":"Peter Eisentraut","email":"c50e6bf7013fce877ffb25104d778a36de31e297@gmx.net"},"message":"XSLT stylesheet: Add slash to directory name\n\nSome versions of the XSLT stylesheets don't handle the missing slash\ncorrectly (they concatenate directory and file name without the slash).\nThis might never have worked correctly.","distinct":false,"url":"https://api.github.com/repos/hlinnaka/gpdb/commits/732740e7d440baac832fbce9a000193a55a35d43"},{"sha":"fa12cb7f0241c767a072c980d75780c9ec036e01","author":{"name":"Alvaro Herrera","email":"3c84f0de6f8a0f296d36cdd9f57fa166641c96b1@alvh.no-ip.org"},"message":"Remove leftover LWLockRelease() call\n\nThis code was refactored in d5497b95 but an extra LWLockRelease call was\nleft behind.\n\nPer report from Erik Rijkers","distinct":false,"url":"https://api.github.com/repos/hlinnaka/gpdb/commits/fa12cb7f0241c767a072c980d75780c9ec036e01"},{"sha":"34f3b396a6554903007031b0541781b7ecdd6e4d","author":{"name":"Tom Lane","email":"ffeaa947aef224da9ba99b6a18bdd74288df0e3e@sss.pgh.pa.us"},"message":"Check for stack overflow in transformSetOperationTree().\n\nSince transformSetOperationTree() recurses, it can be driven to stack\noverflow with enough UNION/INTERSECT/EXCEPT clauses in a query.  Add a\ncheck to ensure it fails cleanly instead of crashing.  Per report from\nMatthew Gerber (though it's not clear whether this is the only thing\ngoing wrong for him).\n\nHistorical note: I think the reasoning behind not putting a check here in\nthe beginning was that the check in transformExpr() ought to be sufficient\nto guard the whole parser.  However, because transformSetOperationTree()\nrecurses all the way to the bottom of the set-operation tree before doing\nany analysis of the statement's expressions, that check doesn't save it.","distinct":false,"url":"https://api.github.com/repos/hlinnaka/gpdb/commits/34f3b396a6554903007031b0541781b7ecdd6e4d"},{"sha":"42218f29af41c430b94e0d074f404816de4ba278","author":{"name":"Peter Eisentraut","email":"c50e6bf7013fce877ffb25104d778a36de31e297@gmx.net"},"message":"doc: \"only relevant\" -> \"relevant only\"\n\nKarl O. Pinc","distinct":false,"url":"https://api.github.com/repos/hlinnaka/gpdb/commits/42218f29af41c430b94e0d074f404816de4ba278"},{"sha":"c9d44a75d48ed8a9b9275b95be1fadaa562f3826","author":{"name":"Heikki Linnakangas","email":"ac1e0af1ee8efe15f889b38482e897ff7d0f0432@iki.fi"},"message":"Silence \"expression result unused\" warnings in AssertVariableIsOfTypeMacro\n\nAt least clang 3.1 generates those warnings. Prepend (void) to avoid them,\nlike we have in AssertMacro.","distinct":false,"url":"https://api.github.com/repos/hlinnaka/gpdb/commits/c9d44a75d48ed8a9b9275b95be1fadaa562f3826"},{"sha":"dbdf9679d7d61b03a3bf73af9b095831b7010eb5","author":{"name":"Heikki Linnakangas","email":"ac1e0af1ee8efe15f889b38482e897ff7d0f0432@iki.fi"},"message":"Use correct text domain for translating errcontext() messages.\n\nerrcontext() is typically used in an error context callback function, not\nwithin an ereport() invocation like e.g errmsg and errdetail are. That means\nthat the message domain that the TEXTDOMAIN magic in ereport() determines\nis not the right one for the errcontext() calls. The message domain needs to\nbe determined by the C file containing the errcontext() call, not the file\ncontaining the ereport() call.\n\nFix by turning errcontext() into a macro that passes the TEXTDOMAIN to use\nfor the errcontext message. \"errcontext\" was used in a few places as a\nvariable or struct field name, I had to rename those out of the way, now\nthat errcontext is a macro.\n\nWe've had this problem all along, but this isn't doesn't seem worth\nbackporting. It's a fairly minor issue, and turning errcontext from a\nfunction to a macro requires at least a recompile of any external code that\ncalls errcontext().","distinct":false,"url":"https://api.github.com/repos/hlinnaka/gpdb/commits/dbdf9679d7d61b03a3bf73af9b095831b7010eb5"},{"sha":"d092d116ed047ebb923ada112235a8866571731c","author":{"name":"Heikki Linnakangas","email":"ac1e0af1ee8efe15f889b38482e897ff7d0f0432@iki.fi"},"message":"Oops, have to rename local variables called 'errcontext' in contrib, too.\n\nAs pointed out by Alvaro.","distinct":false,"url":"https://api.github.com/repos/hlinnaka/gpdb/commits/d092d116ed047ebb923ada112235a8866571731c"},{"sha":"9b3ac49e5afb54c222095dcaf6a73b634ab2c072","author":{"name":"Peter Eisentraut","email":"c50e6bf7013fce877ffb25104d778a36de31e297@gmx.net"},"message":"Use a stamp file for the XSLT HTML doc build\n\nThis way it works more like the DSSSL build, and dependencies are\ntracked better by make.\n\nAlso copy the CSS stylesheet to the html directory.  This was forgotten\nwhen the output directory was changed.","distinct":false,"url":"https://api.github.com/repos/hlinnaka/gpdb/commits/9b3ac49e5afb54c222095dcaf6a73b634ab2c072"},{"sha":"3bbf668de9f1bc172371681e80a4e769b6d014c8","author":{"name":"Tom Lane","email":"ffeaa947aef224da9ba99b6a18bdd74288df0e3e@sss.pgh.pa.us"},"message":"Fix multiple problems in WAL replay.\n\nMost of the replay functions for WAL record types that modify more than\none page failed to ensure that those pages were locked correctly to ensure\nthat concurrent queries could not see inconsistent page states.  This is\na hangover from coding decisions made long before Hot Standby was added,\nwhen it was hardly necessary to acquire buffer locks during WAL replay\nat all, let alone hold them for carefully-chosen periods.\n\nThe key problem was that RestoreBkpBlocks was written to hold lock on each\npage restored from a full-page image for only as long as it took to update\nthat page.  This was guaranteed to break any WAL replay function in which\nthere was any update-ordering constraint between pages, because even if the\nnominal order of the pages is the right one, any mixture of full-page and\nnon-full-page updates in the same record would result in out-of-order\nupdates.  Moreover, it wouldn't work for situations where there's a\nrequirement to maintain lock on one page while updating another.  Failure\nto honor an update ordering constraint in this way is thought to be the\ncause of bug #7648 from Daniel Farina: what seems to have happened there\nis that a btree page being split was rewritten from a full-page image\nbefore the new right sibling page was written, and because lock on the\noriginal page was not maintained it was possible for hot standby queries to\ntry to traverse the page's right-link to the not-yet-existing sibling page.\n\nTo fix, get rid of RestoreBkpBlocks as such, and instead create a new\nfunction RestoreBackupBlock that restores just one full-page image at a\ntime.  This function can be invoked by WAL replay functions at the points\nwhere they would otherwise perform non-full-page updates; in this way, the\nphysical order of page updates remains the same no matter which pages are\nreplaced by full-page images.  We can then further adjust the logic in\nindividual replay functions if it is necessary to hold buffer locks\nfor overlapping periods.  A side benefit is that we can simplify the\nhandling of concurrency conflict resolution by moving that code into the\nrecord-type-specfic functions; there's no more need to contort the code\nlayout to keep conflict resolution in front of the RestoreBkpBlocks call.\n\nIn connection with that, standardize on zero-based numbering rather than\none-based numbering for referencing the full-page images.  In HEAD, I\nremoved the macros XLR_BKP_BLOCK_1 through XLR_BKP_BLOCK_4.  They are\nstill there in the header files in previous branches, but are no longer\nused by the code.\n\nIn addition, fix some other bugs identified in the course of making these\nchanges:\n\nspgRedoAddNode could fail to update the parent downlink at all, if the\nparent tuple is in the same page as either the old or new split tuple and\nwe're not doing a full-page image: it would get fooled by the LSN having\nbeen advanced already.  This would result in permanent index corruption,\nnot just transient failure of concurrent queries.\n\nAlso, ginHeapTupleFastInsert's \"merge lists\" case failed to mark the old\ntail page as a candidate for a full-page image; in the worst case this\ncould result in torn-page corruption.\n\nheap_xlog_freeze() was inconsistent about using a cleanup lock or plain\nexclusive lock: it did the former in the normal path but the latter for a\nfull-page image.  A plain exclusive lock seems sufficient, so change to\nthat.\n\nAlso, remove gistRedoPageDeleteRecord(), which has been dead code since\nVACUUM FULL was rewritten.\n\nBack-patch to 9.0, where hot standby was introduced.  Note however that 9.0\nhad a significantly different WAL-logging scheme for GIST index updates,\nand it doesn't appear possible to make that scheme safe for concurrent hot\nstandby queries, because it can leave inconsistent states in the index even\nbetween WAL records.  Given the lack of complaints from the field, we won't\nwork too hard on fixing that branch.","distinct":false,"url":"https://api.github.com/repos/hlinnaka/gpdb/commits/3bbf668de9f1bc172371681e80a4e769b6d014c8"},{"sha":"8f40ad1f4e75d3def4e86b665c8048a4c9676427","author":{"name":"Peter Eisentraut","email":"c50e6bf7013fce877ffb25104d778a36de31e297@gmx.net"},"message":"doc: Add link to CREATE TABLE AS on CREATE TABLE reference page\n\nKarl O. Pinc","distinct":false,"url":"https://api.github.com/repos/hlinnaka/gpdb/commits/8f40ad1f4e75d3def4e86b665c8048a4c9676427"},{"sha":"68f7fe140bebc2b9bd2953934539cedb603fd01b","author":{"name":"Simon Riggs","email":"088e16a1019277b15d58faf0541e11910eb756f6@2ndQuadrant.com"},"message":"Clarify docs on hot standby lock release\n\nAndres Freund and Simon Riggs","distinct":false,"url":"https://api.github.com/repos/hlinnaka/gpdb/commits/68f7fe140bebc2b9bd2953934539cedb603fd01b"},{"sha":"d9fad1076da4f3686b16e7c9f137118a3156a43a","author":{"name":"Simon Riggs","email":"088e16a1019277b15d58faf0541e11910eb756f6@2ndQuadrant.com"},"message":"Skip searching for subxact locks at commit.\nAt commit all standby locks are released\nfor the top-level transaction, so searching\nfor locks for each subtransaction is both\npointless and costly (N^2) in the presence\nof many AccessExclusiveLocks.","distinct":false,"url":"https://api.github.com/repos/hlinnaka/gpdb/commits/d9fad1076da4f3686b16e7c9f137118a3156a43a"}]}
{"actor":{"display_login":"hlinnaka"}}