{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/cluster-operator/pulls/comments/189866739","pull_request_review_id":122126213,"id":189866739,"diff_hunk":"@@ -144,7 +157,6 @@ func (a *Actuator) CreateMachine(cluster *clusterv1.Cluster, machine *clusterv1.\n \tif err != nil {\n \t\treturn nil, fmt.Errorf(\"error describing AMI %s: %v\", amiName, err)\n \t}\n-\ta.logger.Debugf(\"Describe AMI result:\\n%s\", describeAMIResult)","path":"pkg/clusterapi/aws/actuator.go","position":106,"original_position":106,"commit_id":"3e0727d2233654b0f6e476c4b87168ae562429f1","original_commit_id":"3e0727d2233654b0f6e476c4b87168ae562429f1","user":{"login":"dgoodwin","id":51265,"avatar_url":"https://avatars3.githubusercontent.com/u/51265?v=4","gravatar_id":"","url":"https://api.github.com/users/dgoodwin","html_url":"https://github.com/dgoodwin","followers_url":"https://api.github.com/users/dgoodwin/followers","following_url":"https://api.github.com/users/dgoodwin/following{/other_user}","gists_url":"https://api.github.com/users/dgoodwin/gists{/gist_id}","starred_url":"https://api.github.com/users/dgoodwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgoodwin/subscriptions","organizations_url":"https://api.github.com/users/dgoodwin/orgs","repos_url":"https://api.github.com/users/dgoodwin/repos","events_url":"https://api.github.com/users/dgoodwin/events{/privacy}","received_events_url":"https://api.github.com/users/dgoodwin/received_events","type":"User","site_admin":false},"body":"Those are not added just switched to a contextual logger, the ones I removed were quite large dumps of data that looked quite badly formatted IIRC as well. If useful we can def re-add though.","created_at":"2018-05-22T11:31:38Z","updated_at":"2018-05-22T11:31:38Z","html_url":"https://github.com/openshift/cluster-operator/pull/225#discussion_r189866739","pull_request_url":"https://api.github.com/repos/openshift/cluster-operator/pulls/225","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openshift/cluster-operator/pulls/comments/189866739"},"html":{"href":"https://github.com/openshift/cluster-operator/pull/225#discussion_r189866739"},"pull_request":{"href":"https://api.github.com/repos/openshift/cluster-operator/pulls/225"}},"in_reply_to_id":189665950},"pull_request":{"url":"https://api.github.com/repos/openshift/cluster-operator/pulls/225","id":188822294,"html_url":"https://github.com/openshift/cluster-operator/pull/225","diff_url":"https://github.com/openshift/cluster-operator/pull/225.diff","patch_url":"https://github.com/openshift/cluster-operator/pull/225.patch","issue_url":"https://api.github.com/repos/openshift/cluster-operator/issues/225","number":225,"state":"open","locked":false,"title":"Use AWS credentials for actuator EC2 client when defined.","user":{"login":"dgoodwin","id":51265,"avatar_url":"https://avatars3.githubusercontent.com/u/51265?v=4","gravatar_id":"","url":"https://api.github.com/users/dgoodwin","html_url":"https://github.com/dgoodwin","followers_url":"https://api.github.com/users/dgoodwin/followers","following_url":"https://api.github.com/users/dgoodwin/following{/other_user}","gists_url":"https://api.github.com/users/dgoodwin/gists{/gist_id}","starred_url":"https://api.github.com/users/dgoodwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgoodwin/subscriptions","organizations_url":"https://api.github.com/users/dgoodwin/orgs","repos_url":"https://api.github.com/users/dgoodwin/repos","events_url":"https://api.github.com/users/dgoodwin/events{/privacy}","received_events_url":"https://api.github.com/users/dgoodwin/received_events","type":"User","site_admin":false},"body":"With this change the control plane masters will now be created for a new\r\ncluster API. Their machineset will need to manually be deleted for time\r\nbeing.\r\n\r\nFixes an error in logs where we were double deleting the finalizer now\r\nthat upstream implemented it as well.","created_at":"2018-05-17T18:24:36Z","updated_at":"2018-05-22T11:31:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e79e8d3b9e04af96f429a932444439b056ea084a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":770572148,"url":"https://api.github.com/repos/openshift/cluster-operator/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/cluster-operator/pulls/225/commits","review_comments_url":"https://api.github.com/repos/openshift/cluster-operator/pulls/225/comments","review_comment_url":"https://api.github.com/repos/openshift/cluster-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/cluster-operator/issues/225/comments","statuses_url":"https://api.github.com/repos/openshift/cluster-operator/statuses/3e0727d2233654b0f6e476c4b87168ae562429f1","head":{"label":"dgoodwin:aws-creds","ref":"aws-creds","sha":"3e0727d2233654b0f6e476c4b87168ae562429f1","user":{"login":"dgoodwin","id":51265,"avatar_url":"https://avatars3.githubusercontent.com/u/51265?v=4","gravatar_id":"","url":"https://api.github.com/users/dgoodwin","html_url":"https://github.com/dgoodwin","followers_url":"https://api.github.com/users/dgoodwin/followers","following_url":"https://api.github.com/users/dgoodwin/following{/other_user}","gists_url":"https://api.github.com/users/dgoodwin/gists{/gist_id}","starred_url":"https://api.github.com/users/dgoodwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgoodwin/subscriptions","organizations_url":"https://api.github.com/users/dgoodwin/orgs","repos_url":"https://api.github.com/users/dgoodwin/repos","events_url":"https://api.github.com/users/dgoodwin/events{/privacy}","received_events_url":"https://api.github.com/users/dgoodwin/received_events","type":"User","site_admin":false},"repo":{"id":113201123,"name":"cluster-operator","full_name":"dgoodwin/cluster-operator","owner":{"login":"dgoodwin","id":51265,"avatar_url":"https://avatars3.githubusercontent.com/u/51265?v=4","gravatar_id":"","url":"https://api.github.com/users/dgoodwin","html_url":"https://github.com/dgoodwin","followers_url":"https://api.github.com/users/dgoodwin/followers","following_url":"https://api.github.com/users/dgoodwin/following{/other_user}","gists_url":"https://api.github.com/users/dgoodwin/gists{/gist_id}","starred_url":"https://api.github.com/users/dgoodwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgoodwin/subscriptions","organizations_url":"https://api.github.com/users/dgoodwin/orgs","repos_url":"https://api.github.com/users/dgoodwin/repos","events_url":"https://api.github.com/users/dgoodwin/events{/privacy}","received_events_url":"https://api.github.com/users/dgoodwin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dgoodwin/cluster-operator","description":null,"fork":true,"url":"https://api.github.com/repos/dgoodwin/cluster-operator","forks_url":"https://api.github.com/repos/dgoodwin/cluster-operator/forks","keys_url":"https://api.github.com/repos/dgoodwin/cluster-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dgoodwin/cluster-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dgoodwin/cluster-operator/teams","hooks_url":"https://api.github.com/repos/dgoodwin/cluster-operator/hooks","issue_events_url":"https://api.github.com/repos/dgoodwin/cluster-operator/issues/events{/number}","events_url":"https://api.github.com/repos/dgoodwin/cluster-operator/events","assignees_url":"https://api.github.com/repos/dgoodwin/cluster-operator/assignees{/user}","branches_url":"https://api.github.com/repos/dgoodwin/cluster-operator/branches{/branch}","tags_url":"https://api.github.com/repos/dgoodwin/cluster-operator/tags","blobs_url":"https://api.github.com/repos/dgoodwin/cluster-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dgoodwin/cluster-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dgoodwin/cluster-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/dgoodwin/cluster-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dgoodwin/cluster-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/dgoodwin/cluster-operator/languages","stargazers_url":"https://api.github.com/repos/dgoodwin/cluster-operator/stargazers","contributors_url":"https://api.github.com/repos/dgoodwin/cluster-operator/contributors","subscribers_url":"https://api.github.com/repos/dgoodwin/cluster-operator/subscribers","subscription_url":"https://api.github.com/repos/dgoodwin/cluster-operator/subscription","commits_url":"https://api.github.com/repos/dgoodwin/cluster-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/dgoodwin/cluster-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/dgoodwin/cluster-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/dgoodwin/cluster-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/dgoodwin/cluster-operator/contents/{+path}","compare_url":"https://api.github.com/repos/dgoodwin/cluster-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dgoodwin/cluster-operator/merges","archive_url":"https://api.github.com/repos/dgoodwin/cluster-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dgoodwin/cluster-operator/downloads","issues_url":"https://api.github.com/repos/dgoodwin/cluster-operator/issues{/number}","pulls_url":"https://api.github.com/repos/dgoodwin/cluster-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/dgoodwin/cluster-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/dgoodwin/cluster-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dgoodwin/cluster-operator/labels{/name}","releases_url":"https://api.github.com/repos/dgoodwin/cluster-operator/releases{/id}","deployments_url":"https://api.github.com/repos/dgoodwin/cluster-operator/deployments","created_at":"2017-12-05T15:44:11Z","updated_at":"2018-04-18T12:08:21Z","pushed_at":"2018-05-18T20:19:01Z","git_url":"git://github.com/dgoodwin/cluster-operator.git","ssh_url":"git@github.com:dgoodwin/cluster-operator.git","clone_url":"https://github.com/dgoodwin/cluster-operator.git","svn_url":"https://github.com/dgoodwin/cluster-operator","homepage":null,"size":94991,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"1d8612326880b51296b3fee44537c3d78abde5e6","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":113197161,"name":"cluster-operator","full_name":"openshift/cluster-operator","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/cluster-operator","description":null,"fork":false,"url":"https://api.github.com/repos/openshift/cluster-operator","forks_url":"https://api.github.com/repos/openshift/cluster-operator/forks","keys_url":"https://api.github.com/repos/openshift/cluster-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/cluster-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/cluster-operator/teams","hooks_url":"https://api.github.com/repos/openshift/cluster-operator/hooks","issue_events_url":"https://api.github.com/repos/openshift/cluster-operator/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/cluster-operator/events","assignees_url":"https://api.github.com/repos/openshift/cluster-operator/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/cluster-operator/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/cluster-operator/tags","blobs_url":"https://api.github.com/repos/openshift/cluster-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/cluster-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/cluster-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/cluster-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/cluster-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/cluster-operator/languages","stargazers_url":"https://api.github.com/repos/openshift/cluster-operator/stargazers","contributors_url":"https://api.github.com/repos/openshift/cluster-operator/contributors","subscribers_url":"https://api.github.com/repos/openshift/cluster-operator/subscribers","subscription_url":"https://api.github.com/repos/openshift/cluster-operator/subscription","commits_url":"https://api.github.com/repos/openshift/cluster-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/cluster-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/cluster-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/cluster-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/cluster-operator/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/cluster-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/cluster-operator/merges","archive_url":"https://api.github.com/repos/openshift/cluster-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/cluster-operator/downloads","issues_url":"https://api.github.com/repos/openshift/cluster-operator/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/cluster-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/cluster-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/cluster-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/cluster-operator/labels{/name}","releases_url":"https://api.github.com/repos/openshift/cluster-operator/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/cluster-operator/deployments","created_at":"2017-12-05T15:09:17Z","updated_at":"2018-05-21T21:15:24Z","pushed_at":"2018-05-21T21:15:21Z","git_url":"git://github.com/openshift/cluster-operator.git","ssh_url":"git@github.com:openshift/cluster-operator.git","clone_url":"https://github.com/openshift/cluster-operator.git","svn_url":"https://github.com/openshift/cluster-operator","homepage":null,"size":90223,"stargazers_count":22,"watchers_count":22,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":20,"license":null,"forks":18,"open_issues":20,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/cluster-operator/pulls/225"},"html":{"href":"https://github.com/openshift/cluster-operator/pull/225"},"issue":{"href":"https://api.github.com/repos/openshift/cluster-operator/issues/225"},"comments":{"href":"https://api.github.com/repos/openshift/cluster-operator/issues/225/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/cluster-operator/pulls/225/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/cluster-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/cluster-operator/pulls/225/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/cluster-operator/statuses/3e0727d2233654b0f6e476c4b87168ae562429f1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dgoodwin"}}