{"action":"created","comment":{"url":"https://api.github.com/repos/istio/api/pulls/comments/193883302","pull_request_review_id":126949327,"id":193883302,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Mzg4MzMwMg==","diff_hunk":"@@ -108,12 +108,28 @@ package istio.rbac.v1alpha1;\n \n option go_package=\"istio.io/api/rbac/v1alpha1\";\n \n+// RBAC config enforcement mode, used to verify new ServiceRole/ServiceBinding configs\n+// work as expected before rolling to prod. RBAC engine only logs results from\n+// ServiceRole/ServiceBinding configs in dark launch mode, and discards the result\n+// before return to the user.\n+enum EnforcementMode {\n+  ENFORCED = 0;","path":"rbac/v1alpha1/rbac.proto","position":null,"original_position":9,"commit_id":"5a5c1a5225caa9a3054e234c8d35dac8b135946b","original_commit_id":"244a67dc6c47b3fa1014a8c07e985de252636867","user":{"login":"quanjielin","id":32855694,"node_id":"MDQ6VXNlcjMyODU1Njk0","avatar_url":"https://avatars0.githubusercontent.com/u/32855694?v=4","gravatar_id":"","url":"https://api.github.com/users/quanjielin","html_url":"https://github.com/quanjielin","followers_url":"https://api.github.com/users/quanjielin/followers","following_url":"https://api.github.com/users/quanjielin/following{/other_user}","gists_url":"https://api.github.com/users/quanjielin/gists{/gist_id}","starred_url":"https://api.github.com/users/quanjielin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quanjielin/subscriptions","organizations_url":"https://api.github.com/users/quanjielin/orgs","repos_url":"https://api.github.com/users/quanjielin/repos","events_url":"https://api.github.com/users/quanjielin/events{/privacy}","received_events_url":"https://api.github.com/users/quanjielin/received_events","type":"User","site_admin":false},"body":"added","created_at":"2018-06-07T20:43:46Z","updated_at":"2018-06-07T20:43:46Z","html_url":"https://github.com/istio/api/pull/513#discussion_r193883302","pull_request_url":"https://api.github.com/repos/istio/api/pulls/513","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/istio/api/pulls/comments/193883302"},"html":{"href":"https://github.com/istio/api/pull/513#discussion_r193883302"},"pull_request":{"href":"https://api.github.com/repos/istio/api/pulls/513"}},"in_reply_to_id":193861894},"pull_request":{"url":"https://api.github.com/repos/istio/api/pulls/513","id":193081582,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMDgxNTgy","html_url":"https://github.com/istio/api/pull/513","diff_url":"https://github.com/istio/api/pull/513.diff","patch_url":"https://github.com/istio/api/pull/513.patch","issue_url":"https://api.github.com/repos/istio/api/issues/513","number":513,"state":"open","locked":false,"title":"Add EnforcementMode to RBAC ServiceRole/ServiceBinding config","user":{"login":"quanjielin","id":32855694,"node_id":"MDQ6VXNlcjMyODU1Njk0","avatar_url":"https://avatars0.githubusercontent.com/u/32855694?v=4","gravatar_id":"","url":"https://api.github.com/users/quanjielin","html_url":"https://github.com/quanjielin","followers_url":"https://api.github.com/users/quanjielin/followers","following_url":"https://api.github.com/users/quanjielin/following{/other_user}","gists_url":"https://api.github.com/users/quanjielin/gists{/gist_id}","starred_url":"https://api.github.com/users/quanjielin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quanjielin/subscriptions","organizations_url":"https://api.github.com/users/quanjielin/orgs","repos_url":"https://api.github.com/users/quanjielin/repos","events_url":"https://api.github.com/users/quanjielin/events{/privacy}","received_events_url":"https://api.github.com/users/quanjielin/received_events","type":"User","site_admin":false},"body":"https://github.com/istio/istio/issues/5345\r\n\r\nI think it's OK to add enforcement_mode on both ServiceRole and ServiceBinding configs, pilot is going handle the conversion to envoy config. ","created_at":"2018-06-06T17:08:14Z","updated_at":"2018-06-07T20:43:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3adf77ee669fdbb65ce2407d8a21783b51884811","assignee":null,"assignees":[],"requested_reviewers":[{"login":"yangminzhu","id":2189160,"node_id":"MDQ6VXNlcjIxODkxNjA=","avatar_url":"https://avatars2.githubusercontent.com/u/2189160?v=4","gravatar_id":"","url":"https://api.github.com/users/yangminzhu","html_url":"https://github.com/yangminzhu","followers_url":"https://api.github.com/users/yangminzhu/followers","following_url":"https://api.github.com/users/yangminzhu/following{/other_user}","gists_url":"https://api.github.com/users/yangminzhu/gists{/gist_id}","starred_url":"https://api.github.com/users/yangminzhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yangminzhu/subscriptions","organizations_url":"https://api.github.com/users/yangminzhu/orgs","repos_url":"https://api.github.com/users/yangminzhu/repos","events_url":"https://api.github.com/users/yangminzhu/events{/privacy}","received_events_url":"https://api.github.com/users/yangminzhu/received_events","type":"User","site_admin":false},{"login":"liminw","id":20001914,"node_id":"MDQ6VXNlcjIwMDAxOTE0","avatar_url":"https://avatars3.githubusercontent.com/u/20001914?v=4","gravatar_id":"","url":"https://api.github.com/users/liminw","html_url":"https://github.com/liminw","followers_url":"https://api.github.com/users/liminw/followers","following_url":"https://api.github.com/users/liminw/following{/other_user}","gists_url":"https://api.github.com/users/liminw/gists{/gist_id}","starred_url":"https://api.github.com/users/liminw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liminw/subscriptions","organizations_url":"https://api.github.com/users/liminw/orgs","repos_url":"https://api.github.com/users/liminw/repos","events_url":"https://api.github.com/users/liminw/events{/privacy}","received_events_url":"https://api.github.com/users/liminw/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":717060039,"node_id":"MDU6TGFiZWw3MTcwNjAwMzk=","url":"https://api.github.com/repos/istio/api/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/api/pulls/513/commits","review_comments_url":"https://api.github.com/repos/istio/api/pulls/513/comments","review_comment_url":"https://api.github.com/repos/istio/api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/api/issues/513/comments","statuses_url":"https://api.github.com/repos/istio/api/statuses/5a5c1a5225caa9a3054e234c8d35dac8b135946b","head":{"label":"quanjielin:quanlinmode1","ref":"quanlinmode1","sha":"5a5c1a5225caa9a3054e234c8d35dac8b135946b","user":{"login":"quanjielin","id":32855694,"node_id":"MDQ6VXNlcjMyODU1Njk0","avatar_url":"https://avatars0.githubusercontent.com/u/32855694?v=4","gravatar_id":"","url":"https://api.github.com/users/quanjielin","html_url":"https://github.com/quanjielin","followers_url":"https://api.github.com/users/quanjielin/followers","following_url":"https://api.github.com/users/quanjielin/following{/other_user}","gists_url":"https://api.github.com/users/quanjielin/gists{/gist_id}","starred_url":"https://api.github.com/users/quanjielin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quanjielin/subscriptions","organizations_url":"https://api.github.com/users/quanjielin/orgs","repos_url":"https://api.github.com/users/quanjielin/repos","events_url":"https://api.github.com/users/quanjielin/events{/privacy}","received_events_url":"https://api.github.com/users/quanjielin/received_events","type":"User","site_admin":false},"repo":{"id":136357846,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYzNTc4NDY=","name":"api","full_name":"quanjielin/api","owner":{"login":"quanjielin","id":32855694,"node_id":"MDQ6VXNlcjMyODU1Njk0","avatar_url":"https://avatars0.githubusercontent.com/u/32855694?v=4","gravatar_id":"","url":"https://api.github.com/users/quanjielin","html_url":"https://github.com/quanjielin","followers_url":"https://api.github.com/users/quanjielin/followers","following_url":"https://api.github.com/users/quanjielin/following{/other_user}","gists_url":"https://api.github.com/users/quanjielin/gists{/gist_id}","starred_url":"https://api.github.com/users/quanjielin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quanjielin/subscriptions","organizations_url":"https://api.github.com/users/quanjielin/orgs","repos_url":"https://api.github.com/users/quanjielin/repos","events_url":"https://api.github.com/users/quanjielin/events{/privacy}","received_events_url":"https://api.github.com/users/quanjielin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/quanjielin/api","description":"API, config and standard vocabulary definitions for the Istio project","fork":true,"url":"https://api.github.com/repos/quanjielin/api","forks_url":"https://api.github.com/repos/quanjielin/api/forks","keys_url":"https://api.github.com/repos/quanjielin/api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quanjielin/api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quanjielin/api/teams","hooks_url":"https://api.github.com/repos/quanjielin/api/hooks","issue_events_url":"https://api.github.com/repos/quanjielin/api/issues/events{/number}","events_url":"https://api.github.com/repos/quanjielin/api/events","assignees_url":"https://api.github.com/repos/quanjielin/api/assignees{/user}","branches_url":"https://api.github.com/repos/quanjielin/api/branches{/branch}","tags_url":"https://api.github.com/repos/quanjielin/api/tags","blobs_url":"https://api.github.com/repos/quanjielin/api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quanjielin/api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quanjielin/api/git/refs{/sha}","trees_url":"https://api.github.com/repos/quanjielin/api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quanjielin/api/statuses/{sha}","languages_url":"https://api.github.com/repos/quanjielin/api/languages","stargazers_url":"https://api.github.com/repos/quanjielin/api/stargazers","contributors_url":"https://api.github.com/repos/quanjielin/api/contributors","subscribers_url":"https://api.github.com/repos/quanjielin/api/subscribers","subscription_url":"https://api.github.com/repos/quanjielin/api/subscription","commits_url":"https://api.github.com/repos/quanjielin/api/commits{/sha}","git_commits_url":"https://api.github.com/repos/quanjielin/api/git/commits{/sha}","comments_url":"https://api.github.com/repos/quanjielin/api/comments{/number}","issue_comment_url":"https://api.github.com/repos/quanjielin/api/issues/comments{/number}","contents_url":"https://api.github.com/repos/quanjielin/api/contents/{+path}","compare_url":"https://api.github.com/repos/quanjielin/api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quanjielin/api/merges","archive_url":"https://api.github.com/repos/quanjielin/api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quanjielin/api/downloads","issues_url":"https://api.github.com/repos/quanjielin/api/issues{/number}","pulls_url":"https://api.github.com/repos/quanjielin/api/pulls{/number}","milestones_url":"https://api.github.com/repos/quanjielin/api/milestones{/number}","notifications_url":"https://api.github.com/repos/quanjielin/api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quanjielin/api/labels{/name}","releases_url":"https://api.github.com/repos/quanjielin/api/releases{/id}","deployments_url":"https://api.github.com/repos/quanjielin/api/deployments","created_at":"2018-06-06T16:40:54Z","updated_at":"2018-06-06T16:40:56Z","pushed_at":"2018-06-07T20:42:02Z","git_url":"git://github.com/quanjielin/api.git","ssh_url":"git@github.com:quanjielin/api.git","clone_url":"https://github.com/quanjielin/api.git","svn_url":"https://github.com/quanjielin/api","homepage":"","size":2308,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"b7531fa0786086cad9b3df0ae48297486180ccbd","user":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":76586412,"node_id":"MDEwOlJlcG9zaXRvcnk3NjU4NjQxMg==","name":"api","full_name":"istio/api","owner":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/api","description":"API, config and standard vocabulary definitions for the Istio project","fork":false,"url":"https://api.github.com/repos/istio/api","forks_url":"https://api.github.com/repos/istio/api/forks","keys_url":"https://api.github.com/repos/istio/api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/api/teams","hooks_url":"https://api.github.com/repos/istio/api/hooks","issue_events_url":"https://api.github.com/repos/istio/api/issues/events{/number}","events_url":"https://api.github.com/repos/istio/api/events","assignees_url":"https://api.github.com/repos/istio/api/assignees{/user}","branches_url":"https://api.github.com/repos/istio/api/branches{/branch}","tags_url":"https://api.github.com/repos/istio/api/tags","blobs_url":"https://api.github.com/repos/istio/api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/api/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/api/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/api/languages","stargazers_url":"https://api.github.com/repos/istio/api/stargazers","contributors_url":"https://api.github.com/repos/istio/api/contributors","subscribers_url":"https://api.github.com/repos/istio/api/subscribers","subscription_url":"https://api.github.com/repos/istio/api/subscription","commits_url":"https://api.github.com/repos/istio/api/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/api/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/api/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/api/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/api/contents/{+path}","compare_url":"https://api.github.com/repos/istio/api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/api/merges","archive_url":"https://api.github.com/repos/istio/api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/api/downloads","issues_url":"https://api.github.com/repos/istio/api/issues{/number}","pulls_url":"https://api.github.com/repos/istio/api/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/api/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/api/labels{/name}","releases_url":"https://api.github.com/repos/istio/api/releases{/id}","deployments_url":"https://api.github.com/repos/istio/api/deployments","created_at":"2016-12-15T18:47:13Z","updated_at":"2018-06-07T18:22:02Z","pushed_at":"2018-06-07T20:42:04Z","git_url":"git://github.com/istio/api.git","ssh_url":"git@github.com:istio/api.git","clone_url":"https://github.com/istio/api.git","svn_url":"https://github.com/istio/api","homepage":"","size":2322,"stargazers_count":64,"watchers_count":64,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":91,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":91,"open_issues":37,"watchers":64,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/api/pulls/513"},"html":{"href":"https://github.com/istio/api/pull/513"},"issue":{"href":"https://api.github.com/repos/istio/api/issues/513"},"comments":{"href":"https://api.github.com/repos/istio/api/issues/513/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/api/pulls/513/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/api/pulls/513/commits"},"statuses":{"href":"https://api.github.com/repos/istio/api/statuses/5a5c1a5225caa9a3054e234c8d35dac8b135946b"}},"author_association":"NONE"}}
{"actor":{"display_login":"quanjielin"}}