{"action":"created","issue":{"url":"https://api.github.com/repos/HealthCatalyst/healthcareai-r/issues/1091","repository_url":"https://api.github.com/repos/HealthCatalyst/healthcareai-r","labels_url":"https://api.github.com/repos/HealthCatalyst/healthcareai-r/issues/1091/labels{/name}","comments_url":"https://api.github.com/repos/HealthCatalyst/healthcareai-r/issues/1091/comments","events_url":"https://api.github.com/repos/HealthCatalyst/healthcareai-r/issues/1091/events","html_url":"https://github.com/HealthCatalyst/healthcareai-r/pull/1091","id":318460711,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg0NjYwODY0","number":1091,"title":"Mikem 1081 telemetry.","user":{"login":"mmastand","id":15145347,"node_id":"MDQ6VXNlcjE1MTQ1MzQ3","avatar_url":"https://avatars0.githubusercontent.com/u/15145347?v=4","gravatar_id":"","url":"https://api.github.com/users/mmastand","html_url":"https://github.com/mmastand","followers_url":"https://api.github.com/users/mmastand/followers","following_url":"https://api.github.com/users/mmastand/following{/other_user}","gists_url":"https://api.github.com/users/mmastand/gists{/gist_id}","starred_url":"https://api.github.com/users/mmastand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmastand/subscriptions","organizations_url":"https://api.github.com/users/mmastand/orgs","repos_url":"https://api.github.com/users/mmastand/repos","events_url":"https://api.github.com/users/mmastand/events{/privacy}","received_events_url":"https://api.github.com/users/mmastand/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"michaellevy","id":4422055,"node_id":"MDQ6VXNlcjQ0MjIwNTU=","avatar_url":"https://avatars3.githubusercontent.com/u/4422055?v=4","gravatar_id":"","url":"https://api.github.com/users/michaellevy","html_url":"https://github.com/michaellevy","followers_url":"https://api.github.com/users/michaellevy/followers","following_url":"https://api.github.com/users/michaellevy/following{/other_user}","gists_url":"https://api.github.com/users/michaellevy/gists{/gist_id}","starred_url":"https://api.github.com/users/michaellevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaellevy/subscriptions","organizations_url":"https://api.github.com/users/michaellevy/orgs","repos_url":"https://api.github.com/users/michaellevy/repos","events_url":"https://api.github.com/users/michaellevy/events{/privacy}","received_events_url":"https://api.github.com/users/michaellevy/received_events","type":"User","site_admin":false},"assignees":[{"login":"michaellevy","id":4422055,"node_id":"MDQ6VXNlcjQ0MjIwNTU=","avatar_url":"https://avatars3.githubusercontent.com/u/4422055?v=4","gravatar_id":"","url":"https://api.github.com/users/michaellevy","html_url":"https://github.com/michaellevy","followers_url":"https://api.github.com/users/michaellevy/followers","following_url":"https://api.github.com/users/michaellevy/following{/other_user}","gists_url":"https://api.github.com/users/michaellevy/gists{/gist_id}","starred_url":"https://api.github.com/users/michaellevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaellevy/subscriptions","organizations_url":"https://api.github.com/users/michaellevy/orgs","repos_url":"https://api.github.com/users/michaellevy/repos","events_url":"https://api.github.com/users/michaellevy/events{/privacy}","received_events_url":"https://api.github.com/users/michaellevy/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/HealthCatalyst/healthcareai-r/milestones/46","html_url":"https://github.com/HealthCatalyst/healthcareai-r/milestone/46","labels_url":"https://api.github.com/repos/HealthCatalyst/healthcareai-r/milestones/46/labels","id":3271173,"node_id":"MDk6TWlsZXN0b25lMzI3MTE3Mw==","number":46,"title":"Sprint 48","description":"","creator":{"login":"levithatcher","id":2396979,"node_id":"MDQ6VXNlcjIzOTY5Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/2396979?v=4","gravatar_id":"","url":"https://api.github.com/users/levithatcher","html_url":"https://github.com/levithatcher","followers_url":"https://api.github.com/users/levithatcher/followers","following_url":"https://api.github.com/users/levithatcher/following{/other_user}","gists_url":"https://api.github.com/users/levithatcher/gists{/gist_id}","starred_url":"https://api.github.com/users/levithatcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levithatcher/subscriptions","organizations_url":"https://api.github.com/users/levithatcher/orgs","repos_url":"https://api.github.com/users/levithatcher/repos","events_url":"https://api.github.com/users/levithatcher/events{/privacy}","received_events_url":"https://api.github.com/users/levithatcher/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":0,"state":"open","created_at":"2018-04-16T15:49:28Z","updated_at":"2018-06-06T18:35:43Z","due_on":"2018-06-10T07:00:00Z","closed_at":null},"comments":3,"created_at":"2018-04-27T15:50:19Z","updated_at":"2018-06-08T16:16:52Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/HealthCatalyst/healthcareai-r/pulls/1091","html_url":"https://github.com/HealthCatalyst/healthcareai-r/pull/1091","diff_url":"https://github.com/HealthCatalyst/healthcareai-r/pull/1091.diff","patch_url":"https://github.com/HealthCatalyst/healthcareai-r/pull/1091.patch"},"body":"This required what looks like a large refactor to work in a tidy way (no sinks, files to read/write, or `on.exit`s). That all fell apart on travis/app and I think they just pointed out how fragile it was. Plus, it wasn't possible to return a value on error. If write log is TRUE, predict will now return telemetry data with success or failure and write the log.\r\n\r\nBig Changes:\r\n- Added model name param to `machine learn`, `tune`, and `flash`. Defaults to the name of the outcome column.\r\n- All code from `predict.model_list` was moved to `predict_model_list_main`. Predict.model_list handles 4 use cases by calling a `safe_predict_model_list_main` and handling the outputs:\r\n    - no log, no errors: returns predictions as before\r\n    - no log, with errors: errors out as before\r\n    - log, no errors: returns predictions as before, writes log file. telemetry tibble is attached as a attribute to predictions.\r\n    - log, errors: returns a telemetry tibble with info on failures. Writes failures into log file. Issues a warning that predict failed (with the error message).\r\n\r\nMinor Changes:\r\n- Added more info to the log file.\r\n- Log file returns telemetry dataframe as an attribute to `newdata`\r\n- If loaded from `load_models`, RDS filename will be saved. Otherwise, `loaded_from` is set to `trained_in_memory`.\r\n- `print.model_list` method prints model name.\r\n\r\nAdded tests for model name, logging, and print.\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/HealthCatalyst/healthcareai-r/issues/comments/395811858","html_url":"https://github.com/HealthCatalyst/healthcareai-r/pull/1091#issuecomment-395811858","issue_url":"https://api.github.com/repos/HealthCatalyst/healthcareai-r/issues/1091","id":395811858,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTgxMTg1OA==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-06-08T16:16:52Z","updated_at":"2018-06-08T16:16:52Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/HealthCatalyst/healthcareai-r/pull/1091?src=pr&el=h1) Report\n> Merging [#1091](https://codecov.io/gh/HealthCatalyst/healthcareai-r/pull/1091?src=pr&el=desc) into [master](https://codecov.io/gh/HealthCatalyst/healthcareai-r/commit/9fdd9eb97eb19ad5ecffa1efc03eb9de1b4df624?src=pr&el=desc) will **increase** coverage by `1.1%`.\n> The diff coverage is `100%`.\n\n\n```diff\n@@           Coverage Diff            @@\n##           master   #1091     +/-   ##\n========================================\n+ Coverage    89.2%   90.3%   +1.1%     \n========================================\n  Files          34      33      -1     \n  Lines        1896    1952     +56     \n========================================\n+ Hits         1692    1764     +72     \n+ Misses        204     188     -16\n```\n"}}
{"actor":{"display_login":"codecov"}}