{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/pulls/comments/199331111","pull_request_review_id":133435048,"id":199331111,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTMzMTExMQ==","diff_hunk":"@@ -61,8 +61,14 @@ internal static CpuInfo ParseOutput([CanBeNull] string content)\n         private static double ParseFrequencyFromBrandString(string brandString)","path":"src/BenchmarkDotNet/Portability/Cpu/ProcCpuInfoParser.cs","position":null,"original_position":10,"commit_id":"e6caf627fcade23a5a3ba2c74a98bb9ceec62ba7","original_commit_id":"a34472ff73913fe0785a61d79eccfb2227bd5ceb","user":{"login":"Rizzen","id":23218891,"node_id":"MDQ6VXNlcjIzMjE4ODkx","avatar_url":"https://avatars2.githubusercontent.com/u/23218891?v=4","gravatar_id":"","url":"https://api.github.com/users/Rizzen","html_url":"https://github.com/Rizzen","followers_url":"https://api.github.com/users/Rizzen/followers","following_url":"https://api.github.com/users/Rizzen/following{/other_user}","gists_url":"https://api.github.com/users/Rizzen/gists{/gist_id}","starred_url":"https://api.github.com/users/Rizzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rizzen/subscriptions","organizations_url":"https://api.github.com/users/Rizzen/orgs","repos_url":"https://api.github.com/users/Rizzen/repos","events_url":"https://api.github.com/users/Rizzen/events{/privacy}","received_events_url":"https://api.github.com/users/Rizzen/received_events","type":"User","site_admin":false},"body":"So should CpuInfo ctor has nominalFrequency, minFrequency and maxFrequency arguments of type Frequency?","created_at":"2018-06-30T20:02:57Z","updated_at":"2018-06-30T20:02:57Z","html_url":"https://github.com/dotnet/BenchmarkDotNet/pull/799#discussion_r199331111","pull_request_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/pulls/799","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/BenchmarkDotNet/pulls/comments/199331111"},"html":{"href":"https://github.com/dotnet/BenchmarkDotNet/pull/799#discussion_r199331111"},"pull_request":{"href":"https://api.github.com/repos/dotnet/BenchmarkDotNet/pulls/799"}},"in_reply_to_id":199330858},"pull_request":{"url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/pulls/799","id":195384179,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1Mzg0MTc5","html_url":"https://github.com/dotnet/BenchmarkDotNet/pull/799","diff_url":"https://github.com/dotnet/BenchmarkDotNet/pull/799.diff","patch_url":"https://github.com/dotnet/BenchmarkDotNet/pull/799.patch","issue_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/issues/799","number":799,"state":"open","locked":false,"title":"[WIP] Cpu info improvement","user":{"login":"Rizzen","id":23218891,"node_id":"MDQ6VXNlcjIzMjE4ODkx","avatar_url":"https://avatars2.githubusercontent.com/u/23218891?v=4","gravatar_id":"","url":"https://api.github.com/users/Rizzen","html_url":"https://github.com/Rizzen","followers_url":"https://api.github.com/users/Rizzen/followers","following_url":"https://api.github.com/users/Rizzen/following{/other_user}","gists_url":"https://api.github.com/users/Rizzen/gists{/gist_id}","starred_url":"https://api.github.com/users/Rizzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rizzen/subscriptions","organizations_url":"https://api.github.com/users/Rizzen/orgs","repos_url":"https://api.github.com/users/Rizzen/repos","events_url":"https://api.github.com/users/Rizzen/events{/privacy}","received_events_url":"https://api.github.com/users/Rizzen/received_events","type":"User","site_admin":false},"body":"In order to improve BDN with constant folding analyzer we need to detect CPU speed.\r\nSo, I guess we can improve CpuInfo class to do it. For now it is PoC for Windows and Linux (cause I haven't Mac atm).\r\n\r\n- On Windows still easy to use ```wmic``` but with additional ```CurrentClockSpeed``` parameter\r\n\r\n- On Linux it's a bit difficult - ```cat /proc/cpuinfo``` output contains only current CPU Frequency. We can use ```lscpu | grep MHz``` that returns three parameters of CPU - min, max and current CPU Frequency. So i thought that we can measure actual CPU speed with something like dummy method, that loads CPU and  runs ```lscpu | grep MHz``` during dummy work ([example](https://gist.github.com/Rizzen/1255ceb685702f29a25c11388ba96b0b)). But values of that measure have a huge distribution (i had from 1300 to 3100 MHz). Thus I guess we can use ```lscpu | grep max MHz```.\r\n\r\n- On Mac I hope we can use ```sysctl hw.cpufrequency``` but it has to be checked.\r\n\r\n@AndreyAkinshin what do you think?","created_at":"2018-06-17T16:14:49Z","updated_at":"2018-06-30T20:02:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa1ca57d3ece01d2414bae55fe2669dcb9146b59","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/pulls/799/commits","review_comments_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/pulls/799/comments","review_comment_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/issues/799/comments","statuses_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/statuses/e6caf627fcade23a5a3ba2c74a98bb9ceec62ba7","head":{"label":"Rizzen:cpu_info_improvement","ref":"cpu_info_improvement","sha":"e6caf627fcade23a5a3ba2c74a98bb9ceec62ba7","user":{"login":"Rizzen","id":23218891,"node_id":"MDQ6VXNlcjIzMjE4ODkx","avatar_url":"https://avatars2.githubusercontent.com/u/23218891?v=4","gravatar_id":"","url":"https://api.github.com/users/Rizzen","html_url":"https://github.com/Rizzen","followers_url":"https://api.github.com/users/Rizzen/followers","following_url":"https://api.github.com/users/Rizzen/following{/other_user}","gists_url":"https://api.github.com/users/Rizzen/gists{/gist_id}","starred_url":"https://api.github.com/users/Rizzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rizzen/subscriptions","organizations_url":"https://api.github.com/users/Rizzen/orgs","repos_url":"https://api.github.com/users/Rizzen/repos","events_url":"https://api.github.com/users/Rizzen/events{/privacy}","received_events_url":"https://api.github.com/users/Rizzen/received_events","type":"User","site_admin":false},"repo":{"id":130343052,"node_id":"MDEwOlJlcG9zaXRvcnkxMzAzNDMwNTI=","name":"BenchmarkDotNet","full_name":"Rizzen/BenchmarkDotNet","owner":{"login":"Rizzen","id":23218891,"node_id":"MDQ6VXNlcjIzMjE4ODkx","avatar_url":"https://avatars2.githubusercontent.com/u/23218891?v=4","gravatar_id":"","url":"https://api.github.com/users/Rizzen","html_url":"https://github.com/Rizzen","followers_url":"https://api.github.com/users/Rizzen/followers","following_url":"https://api.github.com/users/Rizzen/following{/other_user}","gists_url":"https://api.github.com/users/Rizzen/gists{/gist_id}","starred_url":"https://api.github.com/users/Rizzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rizzen/subscriptions","organizations_url":"https://api.github.com/users/Rizzen/orgs","repos_url":"https://api.github.com/users/Rizzen/repos","events_url":"https://api.github.com/users/Rizzen/events{/privacy}","received_events_url":"https://api.github.com/users/Rizzen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Rizzen/BenchmarkDotNet","description":"Powerful .NET library for benchmarking","fork":true,"url":"https://api.github.com/repos/Rizzen/BenchmarkDotNet","forks_url":"https://api.github.com/repos/Rizzen/BenchmarkDotNet/forks","keys_url":"https://api.github.com/repos/Rizzen/BenchmarkDotNet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rizzen/BenchmarkDotNet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rizzen/BenchmarkDotNet/teams","hooks_url":"https://api.github.com/repos/Rizzen/BenchmarkDotNet/hooks","issue_events_url":"https://api.github.com/repos/Rizzen/BenchmarkDotNet/issues/events{/number}","events_url":"https://api.github.com/repos/Rizzen/BenchmarkDotNet/events","assignees_url":"https://api.github.com/repos/Rizzen/BenchmarkDotNet/assignees{/user}","branches_url":"https://api.github.com/repos/Rizzen/BenchmarkDotNet/branches{/branch}","tags_url":"https://api.github.com/repos/Rizzen/BenchmarkDotNet/tags","blobs_url":"https://api.github.com/repos/Rizzen/BenchmarkDotNet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rizzen/BenchmarkDotNet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rizzen/BenchmarkDotNet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rizzen/BenchmarkDotNet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rizzen/BenchmarkDotNet/statuses/{sha}","languages_url":"https://api.github.com/repos/Rizzen/BenchmarkDotNet/languages","stargazers_url":"https://api.github.com/repos/Rizzen/BenchmarkDotNet/stargazers","contributors_url":"https://api.github.com/repos/Rizzen/BenchmarkDotNet/contributors","subscribers_url":"https://api.github.com/repos/Rizzen/BenchmarkDotNet/subscribers","subscription_url":"https://api.github.com/repos/Rizzen/BenchmarkDotNet/subscription","commits_url":"https://api.github.com/repos/Rizzen/BenchmarkDotNet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rizzen/BenchmarkDotNet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rizzen/BenchmarkDotNet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rizzen/BenchmarkDotNet/issues/comments{/number}","contents_url":"https://api.github.com/repos/Rizzen/BenchmarkDotNet/contents/{+path}","compare_url":"https://api.github.com/repos/Rizzen/BenchmarkDotNet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rizzen/BenchmarkDotNet/merges","archive_url":"https://api.github.com/repos/Rizzen/BenchmarkDotNet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rizzen/BenchmarkDotNet/downloads","issues_url":"https://api.github.com/repos/Rizzen/BenchmarkDotNet/issues{/number}","pulls_url":"https://api.github.com/repos/Rizzen/BenchmarkDotNet/pulls{/number}","milestones_url":"https://api.github.com/repos/Rizzen/BenchmarkDotNet/milestones{/number}","notifications_url":"https://api.github.com/repos/Rizzen/BenchmarkDotNet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rizzen/BenchmarkDotNet/labels{/name}","releases_url":"https://api.github.com/repos/Rizzen/BenchmarkDotNet/releases{/id}","deployments_url":"https://api.github.com/repos/Rizzen/BenchmarkDotNet/deployments","created_at":"2018-04-20T09:47:53Z","updated_at":"2018-06-28T19:53:06Z","pushed_at":"2018-06-30T19:47:47Z","git_url":"git://github.com/Rizzen/BenchmarkDotNet.git","ssh_url":"git@github.com:Rizzen/BenchmarkDotNet.git","clone_url":"https://github.com/Rizzen/BenchmarkDotNet.git","svn_url":"https://github.com/Rizzen/BenchmarkDotNet","homepage":"http://benchmarkdotnet.org/","size":16165,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"9a9648c0be7830e2ad0d312bde85a9ef0a685753","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":12191244,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE5MTI0NA==","name":"BenchmarkDotNet","full_name":"dotnet/BenchmarkDotNet","owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/BenchmarkDotNet","description":"Powerful .NET library for benchmarking","fork":false,"url":"https://api.github.com/repos/dotnet/BenchmarkDotNet","forks_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/forks","keys_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/teams","hooks_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/hooks","issue_events_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/events","assignees_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/tags","blobs_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/languages","stargazers_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/stargazers","contributors_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/contributors","subscribers_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/subscribers","subscription_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/subscription","commits_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/merges","archive_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/downloads","issues_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/deployments","created_at":"2013-08-18T06:17:48Z","updated_at":"2018-06-29T05:56:46Z","pushed_at":"2018-06-30T19:47:48Z","git_url":"git://github.com/dotnet/BenchmarkDotNet.git","ssh_url":"git@github.com:dotnet/BenchmarkDotNet.git","clone_url":"https://github.com/dotnet/BenchmarkDotNet.git","svn_url":"https://github.com/dotnet/BenchmarkDotNet","homepage":"https://benchmarkdotnet.org/","size":15975,"stargazers_count":3022,"watchers_count":3022,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":316,"mirror_url":null,"archived":false,"open_issues_count":91,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":316,"open_issues":91,"watchers":3022,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/BenchmarkDotNet/pulls/799"},"html":{"href":"https://github.com/dotnet/BenchmarkDotNet/pull/799"},"issue":{"href":"https://api.github.com/repos/dotnet/BenchmarkDotNet/issues/799"},"comments":{"href":"https://api.github.com/repos/dotnet/BenchmarkDotNet/issues/799/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/BenchmarkDotNet/pulls/799/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/BenchmarkDotNet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/BenchmarkDotNet/pulls/799/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/BenchmarkDotNet/statuses/e6caf627fcade23a5a3ba2c74a98bb9ceec62ba7"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Rizzen"}}