{"action":"created","comment":{"url":"https://api.github.com/repos/LCOGT/banzai/pulls/comments/206587897","pull_request_review_id":142028165,"id":206587897,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjU4Nzg5Nw==","diff_hunk":"@@ -292,25 +297,41 @@ class TelescopeMissingException(Exception):\n     pass\n \n \n-def get_telescope_id(site, instrument, db_address=_DEFAULT_DB):\n-    # TODO:  This dies if the telescope is not in the telescopes table. Maybe ping the configdb?\n+def get_telescope_id(header, db_address=_DEFAULT_DB):\n     db_session = get_session(db_address=db_address)\n     criteria = (Telescope.site == site) & (Telescope.instrument == instrument)","path":"banzai/dbs.py","position":33,"original_position":33,"commit_id":"98f092ed048a35cd7ffe8560f01e31a4c552b0bf","original_commit_id":"4982d4be785d987c798c59ab0e0de19914195abc","user":{"login":"gmbrandt","id":38594712,"node_id":"MDQ6VXNlcjM4NTk0NzEy","avatar_url":"https://avatars3.githubusercontent.com/u/38594712?v=4","gravatar_id":"","url":"https://api.github.com/users/gmbrandt","html_url":"https://github.com/gmbrandt","followers_url":"https://api.github.com/users/gmbrandt/followers","following_url":"https://api.github.com/users/gmbrandt/following{/other_user}","gists_url":"https://api.github.com/users/gmbrandt/gists{/gist_id}","starred_url":"https://api.github.com/users/gmbrandt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmbrandt/subscriptions","organizations_url":"https://api.github.com/users/gmbrandt/orgs","repos_url":"https://api.github.com/users/gmbrandt/repos","events_url":"https://api.github.com/users/gmbrandt/events{/privacy}","received_events_url":"https://api.github.com/users/gmbrandt/received_events","type":"User","site_admin":false},"body":"yes, why did this not throw an error? This function just needs lines 327 and 328 from get_telescope below.","created_at":"2018-07-31T16:01:46Z","updated_at":"2018-07-31T16:01:46Z","html_url":"https://github.com/LCOGT/banzai/pull/120#discussion_r206587897","pull_request_url":"https://api.github.com/repos/LCOGT/banzai/pulls/120","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/LCOGT/banzai/pulls/comments/206587897"},"html":{"href":"https://github.com/LCOGT/banzai/pull/120#discussion_r206587897"},"pull_request":{"href":"https://api.github.com/repos/LCOGT/banzai/pulls/120"}},"in_reply_to_id":206346036},"pull_request":{"url":"https://api.github.com/repos/LCOGT/banzai/pulls/120","id":204898296,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0ODk4Mjk2","html_url":"https://github.com/LCOGT/banzai/pull/120","diff_url":"https://github.com/LCOGT/banzai/pull/120.diff","patch_url":"https://github.com/LCOGT/banzai/pull/120.patch","issue_url":"https://api.github.com/repos/LCOGT/banzai/issues/120","number":120,"state":"open","locked":false,"title":"Added override to bad pixel mask requirement.","user":{"login":"cmccully","id":5331996,"node_id":"MDQ6VXNlcjUzMzE5OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/5331996?v=4","gravatar_id":"","url":"https://api.github.com/users/cmccully","html_url":"https://github.com/cmccully","followers_url":"https://api.github.com/users/cmccully/followers","following_url":"https://api.github.com/users/cmccully/following{/other_user}","gists_url":"https://api.github.com/users/cmccully/gists{/gist_id}","starred_url":"https://api.github.com/users/cmccully/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmccully/subscriptions","organizations_url":"https://api.github.com/users/cmccully/orgs","repos_url":"https://api.github.com/users/cmccully/repos","events_url":"https://api.github.com/users/cmccully/events{/privacy}","received_events_url":"https://api.github.com/users/cmccully/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-30T18:57:30Z","updated_at":"2018-07-31T16:01:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4da416f60ec913ac0f2b29dc22e1b2b6a2b6fa0c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gmbrandt","id":38594712,"node_id":"MDQ6VXNlcjM4NTk0NzEy","avatar_url":"https://avatars3.githubusercontent.com/u/38594712?v=4","gravatar_id":"","url":"https://api.github.com/users/gmbrandt","html_url":"https://github.com/gmbrandt","followers_url":"https://api.github.com/users/gmbrandt/followers","following_url":"https://api.github.com/users/gmbrandt/following{/other_user}","gists_url":"https://api.github.com/users/gmbrandt/gists{/gist_id}","starred_url":"https://api.github.com/users/gmbrandt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmbrandt/subscriptions","organizations_url":"https://api.github.com/users/gmbrandt/orgs","repos_url":"https://api.github.com/users/gmbrandt/repos","events_url":"https://api.github.com/users/gmbrandt/events{/privacy}","received_events_url":"https://api.github.com/users/gmbrandt/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/LCOGT/banzai/pulls/120/commits","review_comments_url":"https://api.github.com/repos/LCOGT/banzai/pulls/120/comments","review_comment_url":"https://api.github.com/repos/LCOGT/banzai/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LCOGT/banzai/issues/120/comments","statuses_url":"https://api.github.com/repos/LCOGT/banzai/statuses/98f092ed048a35cd7ffe8560f01e31a4c552b0bf","head":{"label":"LCOGT:feature/bpm_requirements","ref":"feature/bpm_requirements","sha":"98f092ed048a35cd7ffe8560f01e31a4c552b0bf","user":{"login":"LCOGT","id":3358238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNTgyMzg=","avatar_url":"https://avatars1.githubusercontent.com/u/3358238?v=4","gravatar_id":"","url":"https://api.github.com/users/LCOGT","html_url":"https://github.com/LCOGT","followers_url":"https://api.github.com/users/LCOGT/followers","following_url":"https://api.github.com/users/LCOGT/following{/other_user}","gists_url":"https://api.github.com/users/LCOGT/gists{/gist_id}","starred_url":"https://api.github.com/users/LCOGT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LCOGT/subscriptions","organizations_url":"https://api.github.com/users/LCOGT/orgs","repos_url":"https://api.github.com/users/LCOGT/repos","events_url":"https://api.github.com/users/LCOGT/events{/privacy}","received_events_url":"https://api.github.com/users/LCOGT/received_events","type":"Organization","site_admin":false},"repo":{"id":26836413,"node_id":"MDEwOlJlcG9zaXRvcnkyNjgzNjQxMw==","name":"banzai","full_name":"LCOGT/banzai","owner":{"login":"LCOGT","id":3358238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNTgyMzg=","avatar_url":"https://avatars1.githubusercontent.com/u/3358238?v=4","gravatar_id":"","url":"https://api.github.com/users/LCOGT","html_url":"https://github.com/LCOGT","followers_url":"https://api.github.com/users/LCOGT/followers","following_url":"https://api.github.com/users/LCOGT/following{/other_user}","gists_url":"https://api.github.com/users/LCOGT/gists{/gist_id}","starred_url":"https://api.github.com/users/LCOGT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LCOGT/subscriptions","organizations_url":"https://api.github.com/users/LCOGT/orgs","repos_url":"https://api.github.com/users/LCOGT/repos","events_url":"https://api.github.com/users/LCOGT/events{/privacy}","received_events_url":"https://api.github.com/users/LCOGT/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LCOGT/banzai","description":"Beautiful Algorithms to Normalize Zillions of Astronomical Images","fork":false,"url":"https://api.github.com/repos/LCOGT/banzai","forks_url":"https://api.github.com/repos/LCOGT/banzai/forks","keys_url":"https://api.github.com/repos/LCOGT/banzai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LCOGT/banzai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LCOGT/banzai/teams","hooks_url":"https://api.github.com/repos/LCOGT/banzai/hooks","issue_events_url":"https://api.github.com/repos/LCOGT/banzai/issues/events{/number}","events_url":"https://api.github.com/repos/LCOGT/banzai/events","assignees_url":"https://api.github.com/repos/LCOGT/banzai/assignees{/user}","branches_url":"https://api.github.com/repos/LCOGT/banzai/branches{/branch}","tags_url":"https://api.github.com/repos/LCOGT/banzai/tags","blobs_url":"https://api.github.com/repos/LCOGT/banzai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LCOGT/banzai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LCOGT/banzai/git/refs{/sha}","trees_url":"https://api.github.com/repos/LCOGT/banzai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LCOGT/banzai/statuses/{sha}","languages_url":"https://api.github.com/repos/LCOGT/banzai/languages","stargazers_url":"https://api.github.com/repos/LCOGT/banzai/stargazers","contributors_url":"https://api.github.com/repos/LCOGT/banzai/contributors","subscribers_url":"https://api.github.com/repos/LCOGT/banzai/subscribers","subscription_url":"https://api.github.com/repos/LCOGT/banzai/subscription","commits_url":"https://api.github.com/repos/LCOGT/banzai/commits{/sha}","git_commits_url":"https://api.github.com/repos/LCOGT/banzai/git/commits{/sha}","comments_url":"https://api.github.com/repos/LCOGT/banzai/comments{/number}","issue_comment_url":"https://api.github.com/repos/LCOGT/banzai/issues/comments{/number}","contents_url":"https://api.github.com/repos/LCOGT/banzai/contents/{+path}","compare_url":"https://api.github.com/repos/LCOGT/banzai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LCOGT/banzai/merges","archive_url":"https://api.github.com/repos/LCOGT/banzai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LCOGT/banzai/downloads","issues_url":"https://api.github.com/repos/LCOGT/banzai/issues{/number}","pulls_url":"https://api.github.com/repos/LCOGT/banzai/pulls{/number}","milestones_url":"https://api.github.com/repos/LCOGT/banzai/milestones{/number}","notifications_url":"https://api.github.com/repos/LCOGT/banzai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LCOGT/banzai/labels{/name}","releases_url":"https://api.github.com/repos/LCOGT/banzai/releases{/id}","deployments_url":"https://api.github.com/repos/LCOGT/banzai/deployments","created_at":"2014-11-19T00:11:47Z","updated_at":"2018-07-25T20:48:21Z","pushed_at":"2018-07-30T23:03:31Z","git_url":"git://github.com/LCOGT/banzai.git","ssh_url":"git@github.com:LCOGT/banzai.git","clone_url":"https://github.com/LCOGT/banzai.git","svn_url":"https://github.com/LCOGT/banzai","homepage":"","size":14375,"stargazers_count":12,"watchers_count":12,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":14,"open_issues":6,"watchers":12,"default_branch":"master"}},"base":{"label":"LCOGT:master","ref":"master","sha":"fee1cb73c7aeb998e40f3cbabeda0d17d2280913","user":{"login":"LCOGT","id":3358238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNTgyMzg=","avatar_url":"https://avatars1.githubusercontent.com/u/3358238?v=4","gravatar_id":"","url":"https://api.github.com/users/LCOGT","html_url":"https://github.com/LCOGT","followers_url":"https://api.github.com/users/LCOGT/followers","following_url":"https://api.github.com/users/LCOGT/following{/other_user}","gists_url":"https://api.github.com/users/LCOGT/gists{/gist_id}","starred_url":"https://api.github.com/users/LCOGT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LCOGT/subscriptions","organizations_url":"https://api.github.com/users/LCOGT/orgs","repos_url":"https://api.github.com/users/LCOGT/repos","events_url":"https://api.github.com/users/LCOGT/events{/privacy}","received_events_url":"https://api.github.com/users/LCOGT/received_events","type":"Organization","site_admin":false},"repo":{"id":26836413,"node_id":"MDEwOlJlcG9zaXRvcnkyNjgzNjQxMw==","name":"banzai","full_name":"LCOGT/banzai","owner":{"login":"LCOGT","id":3358238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNTgyMzg=","avatar_url":"https://avatars1.githubusercontent.com/u/3358238?v=4","gravatar_id":"","url":"https://api.github.com/users/LCOGT","html_url":"https://github.com/LCOGT","followers_url":"https://api.github.com/users/LCOGT/followers","following_url":"https://api.github.com/users/LCOGT/following{/other_user}","gists_url":"https://api.github.com/users/LCOGT/gists{/gist_id}","starred_url":"https://api.github.com/users/LCOGT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LCOGT/subscriptions","organizations_url":"https://api.github.com/users/LCOGT/orgs","repos_url":"https://api.github.com/users/LCOGT/repos","events_url":"https://api.github.com/users/LCOGT/events{/privacy}","received_events_url":"https://api.github.com/users/LCOGT/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LCOGT/banzai","description":"Beautiful Algorithms to Normalize Zillions of Astronomical Images","fork":false,"url":"https://api.github.com/repos/LCOGT/banzai","forks_url":"https://api.github.com/repos/LCOGT/banzai/forks","keys_url":"https://api.github.com/repos/LCOGT/banzai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LCOGT/banzai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LCOGT/banzai/teams","hooks_url":"https://api.github.com/repos/LCOGT/banzai/hooks","issue_events_url":"https://api.github.com/repos/LCOGT/banzai/issues/events{/number}","events_url":"https://api.github.com/repos/LCOGT/banzai/events","assignees_url":"https://api.github.com/repos/LCOGT/banzai/assignees{/user}","branches_url":"https://api.github.com/repos/LCOGT/banzai/branches{/branch}","tags_url":"https://api.github.com/repos/LCOGT/banzai/tags","blobs_url":"https://api.github.com/repos/LCOGT/banzai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LCOGT/banzai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LCOGT/banzai/git/refs{/sha}","trees_url":"https://api.github.com/repos/LCOGT/banzai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LCOGT/banzai/statuses/{sha}","languages_url":"https://api.github.com/repos/LCOGT/banzai/languages","stargazers_url":"https://api.github.com/repos/LCOGT/banzai/stargazers","contributors_url":"https://api.github.com/repos/LCOGT/banzai/contributors","subscribers_url":"https://api.github.com/repos/LCOGT/banzai/subscribers","subscription_url":"https://api.github.com/repos/LCOGT/banzai/subscription","commits_url":"https://api.github.com/repos/LCOGT/banzai/commits{/sha}","git_commits_url":"https://api.github.com/repos/LCOGT/banzai/git/commits{/sha}","comments_url":"https://api.github.com/repos/LCOGT/banzai/comments{/number}","issue_comment_url":"https://api.github.com/repos/LCOGT/banzai/issues/comments{/number}","contents_url":"https://api.github.com/repos/LCOGT/banzai/contents/{+path}","compare_url":"https://api.github.com/repos/LCOGT/banzai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LCOGT/banzai/merges","archive_url":"https://api.github.com/repos/LCOGT/banzai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LCOGT/banzai/downloads","issues_url":"https://api.github.com/repos/LCOGT/banzai/issues{/number}","pulls_url":"https://api.github.com/repos/LCOGT/banzai/pulls{/number}","milestones_url":"https://api.github.com/repos/LCOGT/banzai/milestones{/number}","notifications_url":"https://api.github.com/repos/LCOGT/banzai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LCOGT/banzai/labels{/name}","releases_url":"https://api.github.com/repos/LCOGT/banzai/releases{/id}","deployments_url":"https://api.github.com/repos/LCOGT/banzai/deployments","created_at":"2014-11-19T00:11:47Z","updated_at":"2018-07-25T20:48:21Z","pushed_at":"2018-07-30T23:03:31Z","git_url":"git://github.com/LCOGT/banzai.git","ssh_url":"git@github.com:LCOGT/banzai.git","clone_url":"https://github.com/LCOGT/banzai.git","svn_url":"https://github.com/LCOGT/banzai","homepage":"","size":14375,"stargazers_count":12,"watchers_count":12,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":14,"open_issues":6,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LCOGT/banzai/pulls/120"},"html":{"href":"https://github.com/LCOGT/banzai/pull/120"},"issue":{"href":"https://api.github.com/repos/LCOGT/banzai/issues/120"},"comments":{"href":"https://api.github.com/repos/LCOGT/banzai/issues/120/comments"},"review_comments":{"href":"https://api.github.com/repos/LCOGT/banzai/pulls/120/comments"},"review_comment":{"href":"https://api.github.com/repos/LCOGT/banzai/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LCOGT/banzai/pulls/120/commits"},"statuses":{"href":"https://api.github.com/repos/LCOGT/banzai/statuses/98f092ed048a35cd7ffe8560f01e31a4c552b0bf"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"gmbrandt"}}