{"action":"created","comment":{"url":"https://api.github.com/repos/ad-freiburg/QLever/pulls/comments/195924850","pull_request_review_id":129385365,"id":195924850,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTkyNDg1MA==","diff_hunk":"@@ -48,6 +49,9 @@ inline string convertFloatToIndexWord(const string& value,\n //! Converts like this: \"PP0*2E0*1234 to \"12.34 and M-0*1E9*876 to -0.123\".\n inline string convertIndexWordToFloat(const string& indexWord);\n \n+//! Converts like this: \"PP0*2E0*1234 to \"12.34 and M-0*1E9*876 to -0.123\".\n+inline float convertIndexWordToFloatValue(const string& indexWord);","path":"src/util/Conversions.h","position":13,"original_position":13,"commit_id":"f6bf9749fecb3f985d47f79d1b421f7de79e9eb5","original_commit_id":"f6bf9749fecb3f985d47f79d1b421f7de79e9eb5","user":{"login":"floriankramer","id":15377755,"node_id":"MDQ6VXNlcjE1Mzc3NzU1","avatar_url":"https://avatars3.githubusercontent.com/u/15377755?v=4","gravatar_id":"","url":"https://api.github.com/users/floriankramer","html_url":"https://github.com/floriankramer","followers_url":"https://api.github.com/users/floriankramer/followers","following_url":"https://api.github.com/users/floriankramer/following{/other_user}","gists_url":"https://api.github.com/users/floriankramer/gists{/gist_id}","starred_url":"https://api.github.com/users/floriankramer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floriankramer/subscriptions","organizations_url":"https://api.github.com/users/floriankramer/orgs","repos_url":"https://api.github.com/users/floriankramer/repos","events_url":"https://api.github.com/users/floriankramer/events{/privacy}","received_events_url":"https://api.github.com/users/floriankramer/received_events","type":"User","site_admin":false},"body":"Originaly there was only the one converting the index word to float, which is used when generating the json output. As SUM and AVG need to interpret floats I added the convert to float value version. I renamed them to convertIndexWordToFloatString and convertIndexWordToFloat.","created_at":"2018-06-17T10:31:30Z","updated_at":"2018-06-17T10:31:30Z","html_url":"https://github.com/ad-freiburg/QLever/pull/63#discussion_r195924850","pull_request_url":"https://api.github.com/repos/ad-freiburg/QLever/pulls/63","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ad-freiburg/QLever/pulls/comments/195924850"},"html":{"href":"https://github.com/ad-freiburg/QLever/pull/63#discussion_r195924850"},"pull_request":{"href":"https://api.github.com/repos/ad-freiburg/QLever/pulls/63"}},"in_reply_to_id":195682542},"pull_request":{"url":"https://api.github.com/repos/ad-freiburg/QLever/pulls/63","id":194638361,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NjM4MzYx","html_url":"https://github.com/ad-freiburg/QLever/pull/63","diff_url":"https://github.com/ad-freiburg/QLever/pull/63.diff","patch_url":"https://github.com/ad-freiburg/QLever/pull/63.patch","issue_url":"https://api.github.com/repos/ad-freiburg/QLever/issues/63","number":63,"state":"open","locked":false,"title":"Grouping","user":{"login":"floriankramer","id":15377755,"node_id":"MDQ6VXNlcjE1Mzc3NzU1","avatar_url":"https://avatars3.githubusercontent.com/u/15377755?v=4","gravatar_id":"","url":"https://api.github.com/users/floriankramer","html_url":"https://github.com/floriankramer","followers_url":"https://api.github.com/users/floriankramer/followers","following_url":"https://api.github.com/users/floriankramer/following{/other_user}","gists_url":"https://api.github.com/users/floriankramer/gists{/gist_id}","starred_url":"https://api.github.com/users/floriankramer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floriankramer/subscriptions","organizations_url":"https://api.github.com/users/floriankramer/orgs","repos_url":"https://api.github.com/users/floriankramer/repos","events_url":"https://api.github.com/users/floriankramer/events{/privacy}","received_events_url":"https://api.github.com/users/floriankramer/received_events","type":"User","site_admin":false},"body":"Added support for GroupBy statements and aggregate aliases.","created_at":"2018-06-13T16:04:12Z","updated_at":"2018-06-17T10:31:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a11662ee33c771381f0cccf27a5a4595cdb4be3","assignee":{"login":"niklas88","id":264873,"node_id":"MDQ6VXNlcjI2NDg3Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/264873?v=4","gravatar_id":"","url":"https://api.github.com/users/niklas88","html_url":"https://github.com/niklas88","followers_url":"https://api.github.com/users/niklas88/followers","following_url":"https://api.github.com/users/niklas88/following{/other_user}","gists_url":"https://api.github.com/users/niklas88/gists{/gist_id}","starred_url":"https://api.github.com/users/niklas88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niklas88/subscriptions","organizations_url":"https://api.github.com/users/niklas88/orgs","repos_url":"https://api.github.com/users/niklas88/repos","events_url":"https://api.github.com/users/niklas88/events{/privacy}","received_events_url":"https://api.github.com/users/niklas88/received_events","type":"User","site_admin":false},"assignees":[{"login":"niklas88","id":264873,"node_id":"MDQ6VXNlcjI2NDg3Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/264873?v=4","gravatar_id":"","url":"https://api.github.com/users/niklas88","html_url":"https://github.com/niklas88","followers_url":"https://api.github.com/users/niklas88/followers","following_url":"https://api.github.com/users/niklas88/following{/other_user}","gists_url":"https://api.github.com/users/niklas88/gists{/gist_id}","starred_url":"https://api.github.com/users/niklas88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niklas88/subscriptions","organizations_url":"https://api.github.com/users/niklas88/orgs","repos_url":"https://api.github.com/users/niklas88/repos","events_url":"https://api.github.com/users/niklas88/events{/privacy}","received_events_url":"https://api.github.com/users/niklas88/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ad-freiburg/QLever/pulls/63/commits","review_comments_url":"https://api.github.com/repos/ad-freiburg/QLever/pulls/63/comments","review_comment_url":"https://api.github.com/repos/ad-freiburg/QLever/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ad-freiburg/QLever/issues/63/comments","statuses_url":"https://api.github.com/repos/ad-freiburg/QLever/statuses/f6bf9749fecb3f985d47f79d1b421f7de79e9eb5","head":{"label":"floriankramer:grouping","ref":"grouping","sha":"f6bf9749fecb3f985d47f79d1b421f7de79e9eb5","user":{"login":"floriankramer","id":15377755,"node_id":"MDQ6VXNlcjE1Mzc3NzU1","avatar_url":"https://avatars3.githubusercontent.com/u/15377755?v=4","gravatar_id":"","url":"https://api.github.com/users/floriankramer","html_url":"https://github.com/floriankramer","followers_url":"https://api.github.com/users/floriankramer/followers","following_url":"https://api.github.com/users/floriankramer/following{/other_user}","gists_url":"https://api.github.com/users/floriankramer/gists{/gist_id}","starred_url":"https://api.github.com/users/floriankramer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floriankramer/subscriptions","organizations_url":"https://api.github.com/users/floriankramer/orgs","repos_url":"https://api.github.com/users/floriankramer/repos","events_url":"https://api.github.com/users/floriankramer/events{/privacy}","received_events_url":"https://api.github.com/users/floriankramer/received_events","type":"User","site_admin":false},"repo":{"id":116241367,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYyNDEzNjc=","name":"QLever","full_name":"floriankramer/QLever","owner":{"login":"floriankramer","id":15377755,"node_id":"MDQ6VXNlcjE1Mzc3NzU1","avatar_url":"https://avatars3.githubusercontent.com/u/15377755?v=4","gravatar_id":"","url":"https://api.github.com/users/floriankramer","html_url":"https://github.com/floriankramer","followers_url":"https://api.github.com/users/floriankramer/followers","following_url":"https://api.github.com/users/floriankramer/following{/other_user}","gists_url":"https://api.github.com/users/floriankramer/gists{/gist_id}","starred_url":"https://api.github.com/users/floriankramer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floriankramer/subscriptions","organizations_url":"https://api.github.com/users/floriankramer/orgs","repos_url":"https://api.github.com/users/floriankramer/repos","events_url":"https://api.github.com/users/floriankramer/events{/privacy}","received_events_url":"https://api.github.com/users/floriankramer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/floriankramer/QLever","description":"Highly efficient query engine for SPARQL+Text","fork":true,"url":"https://api.github.com/repos/floriankramer/QLever","forks_url":"https://api.github.com/repos/floriankramer/QLever/forks","keys_url":"https://api.github.com/repos/floriankramer/QLever/keys{/key_id}","collaborators_url":"https://api.github.com/repos/floriankramer/QLever/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/floriankramer/QLever/teams","hooks_url":"https://api.github.com/repos/floriankramer/QLever/hooks","issue_events_url":"https://api.github.com/repos/floriankramer/QLever/issues/events{/number}","events_url":"https://api.github.com/repos/floriankramer/QLever/events","assignees_url":"https://api.github.com/repos/floriankramer/QLever/assignees{/user}","branches_url":"https://api.github.com/repos/floriankramer/QLever/branches{/branch}","tags_url":"https://api.github.com/repos/floriankramer/QLever/tags","blobs_url":"https://api.github.com/repos/floriankramer/QLever/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/floriankramer/QLever/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/floriankramer/QLever/git/refs{/sha}","trees_url":"https://api.github.com/repos/floriankramer/QLever/git/trees{/sha}","statuses_url":"https://api.github.com/repos/floriankramer/QLever/statuses/{sha}","languages_url":"https://api.github.com/repos/floriankramer/QLever/languages","stargazers_url":"https://api.github.com/repos/floriankramer/QLever/stargazers","contributors_url":"https://api.github.com/repos/floriankramer/QLever/contributors","subscribers_url":"https://api.github.com/repos/floriankramer/QLever/subscribers","subscription_url":"https://api.github.com/repos/floriankramer/QLever/subscription","commits_url":"https://api.github.com/repos/floriankramer/QLever/commits{/sha}","git_commits_url":"https://api.github.com/repos/floriankramer/QLever/git/commits{/sha}","comments_url":"https://api.github.com/repos/floriankramer/QLever/comments{/number}","issue_comment_url":"https://api.github.com/repos/floriankramer/QLever/issues/comments{/number}","contents_url":"https://api.github.com/repos/floriankramer/QLever/contents/{+path}","compare_url":"https://api.github.com/repos/floriankramer/QLever/compare/{base}...{head}","merges_url":"https://api.github.com/repos/floriankramer/QLever/merges","archive_url":"https://api.github.com/repos/floriankramer/QLever/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/floriankramer/QLever/downloads","issues_url":"https://api.github.com/repos/floriankramer/QLever/issues{/number}","pulls_url":"https://api.github.com/repos/floriankramer/QLever/pulls{/number}","milestones_url":"https://api.github.com/repos/floriankramer/QLever/milestones{/number}","notifications_url":"https://api.github.com/repos/floriankramer/QLever/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/floriankramer/QLever/labels{/name}","releases_url":"https://api.github.com/repos/floriankramer/QLever/releases{/id}","deployments_url":"https://api.github.com/repos/floriankramer/QLever/deployments","created_at":"2018-01-04T09:32:04Z","updated_at":"2018-05-06T10:25:24Z","pushed_at":"2018-06-15T09:15:55Z","git_url":"git://github.com/floriankramer/QLever.git","ssh_url":"git@github.com:floriankramer/QLever.git","clone_url":"https://github.com/floriankramer/QLever.git","svn_url":"https://github.com/floriankramer/QLever","homepage":"","size":17878,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ad-freiburg:master","ref":"master","sha":"01ae143200832d9f24c502abb1d77d9b1bf88559","user":{"login":"ad-freiburg","id":37116589,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MTE2NTg5","avatar_url":"https://avatars2.githubusercontent.com/u/37116589?v=4","gravatar_id":"","url":"https://api.github.com/users/ad-freiburg","html_url":"https://github.com/ad-freiburg","followers_url":"https://api.github.com/users/ad-freiburg/followers","following_url":"https://api.github.com/users/ad-freiburg/following{/other_user}","gists_url":"https://api.github.com/users/ad-freiburg/gists{/gist_id}","starred_url":"https://api.github.com/users/ad-freiburg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ad-freiburg/subscriptions","organizations_url":"https://api.github.com/users/ad-freiburg/orgs","repos_url":"https://api.github.com/users/ad-freiburg/repos","events_url":"https://api.github.com/users/ad-freiburg/events{/privacy}","received_events_url":"https://api.github.com/users/ad-freiburg/received_events","type":"Organization","site_admin":false},"repo":{"id":27594187,"node_id":"MDEwOlJlcG9zaXRvcnkyNzU5NDE4Nw==","name":"QLever","full_name":"ad-freiburg/QLever","owner":{"login":"ad-freiburg","id":37116589,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MTE2NTg5","avatar_url":"https://avatars2.githubusercontent.com/u/37116589?v=4","gravatar_id":"","url":"https://api.github.com/users/ad-freiburg","html_url":"https://github.com/ad-freiburg","followers_url":"https://api.github.com/users/ad-freiburg/followers","following_url":"https://api.github.com/users/ad-freiburg/following{/other_user}","gists_url":"https://api.github.com/users/ad-freiburg/gists{/gist_id}","starred_url":"https://api.github.com/users/ad-freiburg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ad-freiburg/subscriptions","organizations_url":"https://api.github.com/users/ad-freiburg/orgs","repos_url":"https://api.github.com/users/ad-freiburg/repos","events_url":"https://api.github.com/users/ad-freiburg/events{/privacy}","received_events_url":"https://api.github.com/users/ad-freiburg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ad-freiburg/QLever","description":"Highly efficient query engine for SPARQL+Text","fork":false,"url":"https://api.github.com/repos/ad-freiburg/QLever","forks_url":"https://api.github.com/repos/ad-freiburg/QLever/forks","keys_url":"https://api.github.com/repos/ad-freiburg/QLever/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ad-freiburg/QLever/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ad-freiburg/QLever/teams","hooks_url":"https://api.github.com/repos/ad-freiburg/QLever/hooks","issue_events_url":"https://api.github.com/repos/ad-freiburg/QLever/issues/events{/number}","events_url":"https://api.github.com/repos/ad-freiburg/QLever/events","assignees_url":"https://api.github.com/repos/ad-freiburg/QLever/assignees{/user}","branches_url":"https://api.github.com/repos/ad-freiburg/QLever/branches{/branch}","tags_url":"https://api.github.com/repos/ad-freiburg/QLever/tags","blobs_url":"https://api.github.com/repos/ad-freiburg/QLever/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ad-freiburg/QLever/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ad-freiburg/QLever/git/refs{/sha}","trees_url":"https://api.github.com/repos/ad-freiburg/QLever/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ad-freiburg/QLever/statuses/{sha}","languages_url":"https://api.github.com/repos/ad-freiburg/QLever/languages","stargazers_url":"https://api.github.com/repos/ad-freiburg/QLever/stargazers","contributors_url":"https://api.github.com/repos/ad-freiburg/QLever/contributors","subscribers_url":"https://api.github.com/repos/ad-freiburg/QLever/subscribers","subscription_url":"https://api.github.com/repos/ad-freiburg/QLever/subscription","commits_url":"https://api.github.com/repos/ad-freiburg/QLever/commits{/sha}","git_commits_url":"https://api.github.com/repos/ad-freiburg/QLever/git/commits{/sha}","comments_url":"https://api.github.com/repos/ad-freiburg/QLever/comments{/number}","issue_comment_url":"https://api.github.com/repos/ad-freiburg/QLever/issues/comments{/number}","contents_url":"https://api.github.com/repos/ad-freiburg/QLever/contents/{+path}","compare_url":"https://api.github.com/repos/ad-freiburg/QLever/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ad-freiburg/QLever/merges","archive_url":"https://api.github.com/repos/ad-freiburg/QLever/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ad-freiburg/QLever/downloads","issues_url":"https://api.github.com/repos/ad-freiburg/QLever/issues{/number}","pulls_url":"https://api.github.com/repos/ad-freiburg/QLever/pulls{/number}","milestones_url":"https://api.github.com/repos/ad-freiburg/QLever/milestones{/number}","notifications_url":"https://api.github.com/repos/ad-freiburg/QLever/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ad-freiburg/QLever/labels{/name}","releases_url":"https://api.github.com/repos/ad-freiburg/QLever/releases{/id}","deployments_url":"https://api.github.com/repos/ad-freiburg/QLever/deployments","created_at":"2014-12-05T14:09:19Z","updated_at":"2018-06-15T10:53:53Z","pushed_at":"2018-06-15T13:40:50Z","git_url":"git://github.com/ad-freiburg/QLever.git","ssh_url":"git@github.com:ad-freiburg/QLever.git","clone_url":"https://github.com/ad-freiburg/QLever.git","svn_url":"https://github.com/ad-freiburg/QLever","homepage":"","size":17854,"stargazers_count":15,"watchers_count":15,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7,"open_issues":12,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ad-freiburg/QLever/pulls/63"},"html":{"href":"https://github.com/ad-freiburg/QLever/pull/63"},"issue":{"href":"https://api.github.com/repos/ad-freiburg/QLever/issues/63"},"comments":{"href":"https://api.github.com/repos/ad-freiburg/QLever/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/ad-freiburg/QLever/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/ad-freiburg/QLever/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ad-freiburg/QLever/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/ad-freiburg/QLever/statuses/f6bf9749fecb3f985d47f79d1b421f7de79e9eb5"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"floriankramer"}}