{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/openshift-ansible/issues/9801","repository_url":"https://api.github.com/repos/openshift/openshift-ansible","labels_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/9801/labels{/name}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/9801/comments","events_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/9801/events","html_url":"https://github.com/openshift/openshift-ansible/pull/9801","id":354805136,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNDgwNTIw","number":9801,"title":"Control plane static pods (apiserver, etcd, controller-manager) must be assigned highest priority class system-node-critical. ","user":{"login":"aveshagarwal","id":3596412,"node_id":"MDQ6VXNlcjM1OTY0MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/3596412?v=4","gravatar_id":"","url":"https://api.github.com/users/aveshagarwal","html_url":"https://github.com/aveshagarwal","followers_url":"https://api.github.com/users/aveshagarwal/followers","following_url":"https://api.github.com/users/aveshagarwal/following{/other_user}","gists_url":"https://api.github.com/users/aveshagarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/aveshagarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aveshagarwal/subscriptions","organizations_url":"https://api.github.com/users/aveshagarwal/orgs","repos_url":"https://api.github.com/users/aveshagarwal/repos","events_url":"https://api.github.com/users/aveshagarwal/events{/privacy}","received_events_url":"https://api.github.com/users/aveshagarwal/received_events","type":"User","site_admin":false},"labels":[{"id":681664198,"node_id":"MDU6TGFiZWw2ODE2NjQxOTg=","url":"https://api.github.com/repos/openshift/openshift-ansible/labels/size/XS","name":"size/XS","color":"009900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-28T16:18:42Z","updated_at":"2018-08-28T16:18:55Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/9801","html_url":"https://github.com/openshift/openshift-ansible/pull/9801","diff_url":"https://github.com/openshift/openshift-ansible/pull/9801.diff","patch_url":"https://github.com/openshift/openshift-ansible/pull/9801.patch"},"body":"Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1622439\r\n\r\nThe issue is happening as priority admission plugin incorrectly assigns system-cluster-critical to pods with critical pod annotations if no priority class is assigned. This PR now explicitly assigns  system-node-critical priority class to most critical pods like (apiserver, etcd, controller-manager).\r\n\r\nOn a related note, since the behavior with critical pod annotation is that any pod with critical pod annotation is never evicted by kubelet, so after upgrade to maintain the same behavior, if no priority class is class is assigned, only system-node-critical can provide this guarantee. I have sent a PR to upstream to address this: https://github.com/kubernetes/kubernetes/pull/67958 .\r\n\r\n@sjenning @ravisantoshgudimetla @sdodson @michaelgugino "},"comment":{"url":"https://api.github.com/repos/openshift/openshift-ansible/issues/comments/416649018","html_url":"https://github.com/openshift/openshift-ansible/pull/9801#issuecomment-416649018","issue_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/9801","id":416649018,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjY0OTAxOA==","user":{"login":"openshift-ci-robot","id":30189103,"node_id":"MDQ6VXNlcjMwMTg5MTAz","avatar_url":"https://avatars1.githubusercontent.com/u/30189103?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift-ci-robot","html_url":"https://github.com/openshift-ci-robot","followers_url":"https://api.github.com/users/openshift-ci-robot/followers","following_url":"https://api.github.com/users/openshift-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/openshift-ci-robot/orgs","repos_url":"https://api.github.com/users/openshift-ci-robot/repos","events_url":"https://api.github.com/users/openshift-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-08-28T16:18:55Z","updated_at":"2018-08-28T16:18:55Z","author_association":"NONE","body":"[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/openshift/openshift-ansible/pull/9801#\" title=\"Author self-approved\">aveshagarwal</a>*\nTo fully approve this pull request, please assign additional approvers.\nWe suggest the following additional approver: **vrutkovs**\n\nIf they are not already assigned, you can assign the PR to them by writing `/assign @vrutkovs` in a comment when ready.\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[OWNERS](https://github.com/openshift/openshift-ansible/blob/master/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"vrutkovs\"]} -->"}}
{"actor":{"display_login":"openshift-ci-robot"}}