{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/comments/232127405","pull_request_review_id":173255509,"id":232127405,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjEyNzQwNQ==","diff_hunk":"@@ -323,112 +322,109 @@ namespace ts.formatting {\n             return false;\r\n         }\r\n \r\n+        function getListIfVisualStartEndIsInListRange(list: NodeArray<Node> | undefined, start: number, end: number, node: Node) {\r","path":"src/services/formatting/smartIndenter.ts","position":null,"original_position":68,"commit_id":"7995f9153aa79334d3809bf19f6b1c8bfdf6c4c5","original_commit_id":"8ed21a8a6af88522e70361e47e0a6e754b348f87","user":{"login":"saschanaz","id":3396686,"node_id":"MDQ6VXNlcjMzOTY2ODY=","avatar_url":"https://avatars2.githubusercontent.com/u/3396686?v=4","gravatar_id":"","url":"https://api.github.com/users/saschanaz","html_url":"https://github.com/saschanaz","followers_url":"https://api.github.com/users/saschanaz/followers","following_url":"https://api.github.com/users/saschanaz/following{/other_user}","gists_url":"https://api.github.com/users/saschanaz/gists{/gist_id}","starred_url":"https://api.github.com/users/saschanaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saschanaz/subscriptions","organizations_url":"https://api.github.com/users/saschanaz/orgs","repos_url":"https://api.github.com/users/saschanaz/repos","events_url":"https://api.github.com/users/saschanaz/events{/privacy}","received_events_url":"https://api.github.com/users/saschanaz/received_events","type":"User","site_admin":false},"body":"NodeArray starts at the previous token's end positions and ends at the last list item's end position. So think about the following code:\r\n\r\n```ts\r\nfunc(\r\n  // visually the list starts at line 0 and ends in line 2, but actually it ends at line 0\r\n);\r\n\r\nfunc(\r\n  1,\r\n  // visually the list starts at line 0 and ends in line 3, but actually it ends at line 1\r\n  // which means the position of these comments does not belong to the list range.\r\n);\r\n```","created_at":"2018-11-09T02:33:14Z","updated_at":"2018-11-09T02:33:14Z","html_url":"https://github.com/Microsoft/TypeScript/pull/28340#discussion_r232127405","pull_request_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/28340","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/comments/232127405"},"html":{"href":"https://github.com/Microsoft/TypeScript/pull/28340#discussion_r232127405"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/28340"}},"in_reply_to_id":231990639},"pull_request":{"url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/28340","id":228346335,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MzQ2MzM1","html_url":"https://github.com/Microsoft/TypeScript/pull/28340","diff_url":"https://github.com/Microsoft/TypeScript/pull/28340.diff","patch_url":"https://github.com/Microsoft/TypeScript/pull/28340.patch","issue_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/28340","number":28340,"state":"open","locked":false,"title":"List position based formatting","user":{"login":"saschanaz","id":3396686,"node_id":"MDQ6VXNlcjMzOTY2ODY=","avatar_url":"https://avatars2.githubusercontent.com/u/3396686?v=4","gravatar_id":"","url":"https://api.github.com/users/saschanaz","html_url":"https://github.com/saschanaz","followers_url":"https://api.github.com/users/saschanaz/followers","following_url":"https://api.github.com/users/saschanaz/following{/other_user}","gists_url":"https://api.github.com/users/saschanaz/gists{/gist_id}","starred_url":"https://api.github.com/users/saschanaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saschanaz/subscriptions","organizations_url":"https://api.github.com/users/saschanaz/orgs","repos_url":"https://api.github.com/users/saschanaz/repos","events_url":"https://api.github.com/users/saschanaz/events{/privacy}","received_events_url":"https://api.github.com/users/saschanaz/received_events","type":"User","site_admin":false},"body":"Revives #13574\r\n\r\nFixes #5830, fixes #5890, fixes #6252, fixes #6320, fixes #6451, fixes #10681, fixes #26906 \r\n","created_at":"2018-11-05T13:07:56Z","updated_at":"2018-11-09T02:33:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cefc24fdbfedf5b58c4b9b3fabe6d64ba87fda8d","assignee":{"login":"sheetalkamat","id":8052792,"node_id":"MDQ6VXNlcjgwNTI3OTI=","avatar_url":"https://avatars2.githubusercontent.com/u/8052792?v=4","gravatar_id":"","url":"https://api.github.com/users/sheetalkamat","html_url":"https://github.com/sheetalkamat","followers_url":"https://api.github.com/users/sheetalkamat/followers","following_url":"https://api.github.com/users/sheetalkamat/following{/other_user}","gists_url":"https://api.github.com/users/sheetalkamat/gists{/gist_id}","starred_url":"https://api.github.com/users/sheetalkamat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sheetalkamat/subscriptions","organizations_url":"https://api.github.com/users/sheetalkamat/orgs","repos_url":"https://api.github.com/users/sheetalkamat/repos","events_url":"https://api.github.com/users/sheetalkamat/events{/privacy}","received_events_url":"https://api.github.com/users/sheetalkamat/received_events","type":"User","site_admin":false},"assignees":[{"login":"sheetalkamat","id":8052792,"node_id":"MDQ6VXNlcjgwNTI3OTI=","avatar_url":"https://avatars2.githubusercontent.com/u/8052792?v=4","gravatar_id":"","url":"https://api.github.com/users/sheetalkamat","html_url":"https://github.com/sheetalkamat","followers_url":"https://api.github.com/users/sheetalkamat/followers","following_url":"https://api.github.com/users/sheetalkamat/following{/other_user}","gists_url":"https://api.github.com/users/sheetalkamat/gists{/gist_id}","starred_url":"https://api.github.com/users/sheetalkamat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sheetalkamat/subscriptions","organizations_url":"https://api.github.com/users/sheetalkamat/orgs","repos_url":"https://api.github.com/users/sheetalkamat/repos","events_url":"https://api.github.com/users/sheetalkamat/events{/privacy}","received_events_url":"https://api.github.com/users/sheetalkamat/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"sheetalkamat","id":8052792,"node_id":"MDQ6VXNlcjgwNTI3OTI=","avatar_url":"https://avatars2.githubusercontent.com/u/8052792?v=4","gravatar_id":"","url":"https://api.github.com/users/sheetalkamat","html_url":"https://github.com/sheetalkamat","followers_url":"https://api.github.com/users/sheetalkamat/followers","following_url":"https://api.github.com/users/sheetalkamat/following{/other_user}","gists_url":"https://api.github.com/users/sheetalkamat/gists{/gist_id}","starred_url":"https://api.github.com/users/sheetalkamat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sheetalkamat/subscriptions","organizations_url":"https://api.github.com/users/sheetalkamat/orgs","repos_url":"https://api.github.com/users/sheetalkamat/repos","events_url":"https://api.github.com/users/sheetalkamat/events{/privacy}","received_events_url":"https://api.github.com/users/sheetalkamat/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/28340/commits","review_comments_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/28340/comments","review_comment_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/28340/comments","statuses_url":"https://api.github.com/repos/Microsoft/TypeScript/statuses/7995f9153aa79334d3809bf19f6b1c8bfdf6c4c5","head":{"label":"saschanaz:listindent-revive","ref":"listindent-revive","sha":"7995f9153aa79334d3809bf19f6b1c8bfdf6c4c5","user":{"login":"saschanaz","id":3396686,"node_id":"MDQ6VXNlcjMzOTY2ODY=","avatar_url":"https://avatars2.githubusercontent.com/u/3396686?v=4","gravatar_id":"","url":"https://api.github.com/users/saschanaz","html_url":"https://github.com/saschanaz","followers_url":"https://api.github.com/users/saschanaz/followers","following_url":"https://api.github.com/users/saschanaz/following{/other_user}","gists_url":"https://api.github.com/users/saschanaz/gists{/gist_id}","starred_url":"https://api.github.com/users/saschanaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saschanaz/subscriptions","organizations_url":"https://api.github.com/users/saschanaz/orgs","repos_url":"https://api.github.com/users/saschanaz/repos","events_url":"https://api.github.com/users/saschanaz/events{/privacy}","received_events_url":"https://api.github.com/users/saschanaz/received_events","type":"User","site_admin":false},"repo":{"id":33726939,"node_id":"MDEwOlJlcG9zaXRvcnkzMzcyNjkzOQ==","name":"TypeScript","full_name":"saschanaz/TypeScript","private":false,"owner":{"login":"saschanaz","id":3396686,"node_id":"MDQ6VXNlcjMzOTY2ODY=","avatar_url":"https://avatars2.githubusercontent.com/u/3396686?v=4","gravatar_id":"","url":"https://api.github.com/users/saschanaz","html_url":"https://github.com/saschanaz","followers_url":"https://api.github.com/users/saschanaz/followers","following_url":"https://api.github.com/users/saschanaz/following{/other_user}","gists_url":"https://api.github.com/users/saschanaz/gists{/gist_id}","starred_url":"https://api.github.com/users/saschanaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saschanaz/subscriptions","organizations_url":"https://api.github.com/users/saschanaz/orgs","repos_url":"https://api.github.com/users/saschanaz/repos","events_url":"https://api.github.com/users/saschanaz/events{/privacy}","received_events_url":"https://api.github.com/users/saschanaz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/saschanaz/TypeScript","description":"TypeScript is a superset of JavaScript that compiles to clean JavaScript output.","fork":true,"url":"https://api.github.com/repos/saschanaz/TypeScript","forks_url":"https://api.github.com/repos/saschanaz/TypeScript/forks","keys_url":"https://api.github.com/repos/saschanaz/TypeScript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saschanaz/TypeScript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saschanaz/TypeScript/teams","hooks_url":"https://api.github.com/repos/saschanaz/TypeScript/hooks","issue_events_url":"https://api.github.com/repos/saschanaz/TypeScript/issues/events{/number}","events_url":"https://api.github.com/repos/saschanaz/TypeScript/events","assignees_url":"https://api.github.com/repos/saschanaz/TypeScript/assignees{/user}","branches_url":"https://api.github.com/repos/saschanaz/TypeScript/branches{/branch}","tags_url":"https://api.github.com/repos/saschanaz/TypeScript/tags","blobs_url":"https://api.github.com/repos/saschanaz/TypeScript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saschanaz/TypeScript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saschanaz/TypeScript/git/refs{/sha}","trees_url":"https://api.github.com/repos/saschanaz/TypeScript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saschanaz/TypeScript/statuses/{sha}","languages_url":"https://api.github.com/repos/saschanaz/TypeScript/languages","stargazers_url":"https://api.github.com/repos/saschanaz/TypeScript/stargazers","contributors_url":"https://api.github.com/repos/saschanaz/TypeScript/contributors","subscribers_url":"https://api.github.com/repos/saschanaz/TypeScript/subscribers","subscription_url":"https://api.github.com/repos/saschanaz/TypeScript/subscription","commits_url":"https://api.github.com/repos/saschanaz/TypeScript/commits{/sha}","git_commits_url":"https://api.github.com/repos/saschanaz/TypeScript/git/commits{/sha}","comments_url":"https://api.github.com/repos/saschanaz/TypeScript/comments{/number}","issue_comment_url":"https://api.github.com/repos/saschanaz/TypeScript/issues/comments{/number}","contents_url":"https://api.github.com/repos/saschanaz/TypeScript/contents/{+path}","compare_url":"https://api.github.com/repos/saschanaz/TypeScript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saschanaz/TypeScript/merges","archive_url":"https://api.github.com/repos/saschanaz/TypeScript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saschanaz/TypeScript/downloads","issues_url":"https://api.github.com/repos/saschanaz/TypeScript/issues{/number}","pulls_url":"https://api.github.com/repos/saschanaz/TypeScript/pulls{/number}","milestones_url":"https://api.github.com/repos/saschanaz/TypeScript/milestones{/number}","notifications_url":"https://api.github.com/repos/saschanaz/TypeScript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saschanaz/TypeScript/labels{/name}","releases_url":"https://api.github.com/repos/saschanaz/TypeScript/releases{/id}","deployments_url":"https://api.github.com/repos/saschanaz/TypeScript/deployments","created_at":"2015-04-10T12:18:24Z","updated_at":"2018-11-05T13:28:56Z","pushed_at":"2018-11-09T02:27:18Z","git_url":"git://github.com/saschanaz/TypeScript.git","ssh_url":"git@github.com:saschanaz/TypeScript.git","clone_url":"https://github.com/saschanaz/TypeScript.git","svn_url":"https://github.com/saschanaz/TypeScript","homepage":"http://www.typescriptlang.org","size":734181,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"eba83f4ea76112fa66d036f09038e868cda760ba","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":20929025,"node_id":"MDEwOlJlcG9zaXRvcnkyMDkyOTAyNQ==","name":"TypeScript","full_name":"Microsoft/TypeScript","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/TypeScript","description":"TypeScript is a superset of JavaScript that compiles to clean JavaScript output.","fork":false,"url":"https://api.github.com/repos/Microsoft/TypeScript","forks_url":"https://api.github.com/repos/Microsoft/TypeScript/forks","keys_url":"https://api.github.com/repos/Microsoft/TypeScript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/TypeScript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/TypeScript/teams","hooks_url":"https://api.github.com/repos/Microsoft/TypeScript/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/TypeScript/events","assignees_url":"https://api.github.com/repos/Microsoft/TypeScript/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/TypeScript/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/TypeScript/tags","blobs_url":"https://api.github.com/repos/Microsoft/TypeScript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/TypeScript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/TypeScript/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/TypeScript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/TypeScript/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/TypeScript/languages","stargazers_url":"https://api.github.com/repos/Microsoft/TypeScript/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/TypeScript/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/TypeScript/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/TypeScript/subscription","commits_url":"https://api.github.com/repos/Microsoft/TypeScript/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/TypeScript/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/TypeScript/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/TypeScript/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/TypeScript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/TypeScript/merges","archive_url":"https://api.github.com/repos/Microsoft/TypeScript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/TypeScript/downloads","issues_url":"https://api.github.com/repos/Microsoft/TypeScript/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/TypeScript/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/TypeScript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/TypeScript/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/TypeScript/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/TypeScript/deployments","created_at":"2014-06-17T15:28:39Z","updated_at":"2018-11-09T02:08:17Z","pushed_at":"2018-11-09T02:27:27Z","git_url":"git://github.com/Microsoft/TypeScript.git","ssh_url":"git@github.com:Microsoft/TypeScript.git","clone_url":"https://github.com/Microsoft/TypeScript.git","svn_url":"https://github.com/Microsoft/TypeScript","homepage":"http://www.typescriptlang.org","size":910622,"stargazers_count":41110,"watchers_count":41110,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5905,"mirror_url":null,"archived":false,"open_issues_count":3276,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5905,"open_issues":3276,"watchers":41110,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/28340"},"html":{"href":"https://github.com/Microsoft/TypeScript/pull/28340"},"issue":{"href":"https://api.github.com/repos/Microsoft/TypeScript/issues/28340"},"comments":{"href":"https://api.github.com/repos/Microsoft/TypeScript/issues/28340/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/28340/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/28340/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/TypeScript/statuses/7995f9153aa79334d3809bf19f6b1c8bfdf6c4c5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"saschanaz"}}