{"action":"closed","number":408,"pull_request":{"url":"https://api.github.com/repos/cerner/terra-clinical/pulls/408","id":224761956,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NzYxOTU2","html_url":"https://github.com/cerner/terra-clinical/pull/408","diff_url":"https://github.com/cerner/terra-clinical/pull/408.diff","patch_url":"https://github.com/cerner/terra-clinical/pull/408.patch","issue_url":"https://api.github.com/repos/cerner/terra-clinical/issues/408","number":408,"state":"closed","locked":false,"title":"DataGrid Improvements","user":{"login":"tbiethman","id":1711637,"node_id":"MDQ6VXNlcjE3MTE2Mzc=","avatar_url":"https://avatars3.githubusercontent.com/u/1711637?v=4","gravatar_id":"","url":"https://api.github.com/users/tbiethman","html_url":"https://github.com/tbiethman","followers_url":"https://api.github.com/users/tbiethman/followers","following_url":"https://api.github.com/users/tbiethman/following{/other_user}","gists_url":"https://api.github.com/users/tbiethman/gists{/gist_id}","starred_url":"https://api.github.com/users/tbiethman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbiethman/subscriptions","organizations_url":"https://api.github.com/users/tbiethman/orgs","repos_url":"https://api.github.com/users/tbiethman/repos","events_url":"https://api.github.com/users/tbiethman/events{/privacy}","received_events_url":"https://api.github.com/users/tbiethman/received_events","type":"User","site_admin":false},"body":"### Summary\r\nA couple things changed here:\r\n\r\n* When the 'fill' prop is not set, the horizontal scroll synchronization and custom horizontal scrollbar are unnecessary. I've updated the markup in that case to remove those elements and make things more efficient.\r\n* The row striping was using an nth-child selector, which could be influenced by the presence of a section header. I've made the row striping API explicit and implemented it on a per-section basis, so rows should be more visually consistent.\r\n* A few event handlers were being set when they didn't need to be. I added checks around them to make sure only only the necessary handlers are being executed.\r\n* In some circumstances, the header cells were rendering with a 2px offset (due to the presence of the bottom border on their container). I moved the border styles around to ensure proper alignment.\r\n\r\nNot much has changed functionally, but the wdio screenshots got hit pretty hard due to the row striping and header cell offset changes.","created_at":"2018-10-22T18:00:13Z","updated_at":"2018-11-15T21:12:04Z","closed_at":"2018-11-15T21:12:04Z","merged_at":"2018-11-15T21:12:04Z","merge_commit_sha":"7c21c9577c2f19f88d11a8191ba595e8d28aa46e","assignee":{"login":"tbiethman","id":1711637,"node_id":"MDQ6VXNlcjE3MTE2Mzc=","avatar_url":"https://avatars3.githubusercontent.com/u/1711637?v=4","gravatar_id":"","url":"https://api.github.com/users/tbiethman","html_url":"https://github.com/tbiethman","followers_url":"https://api.github.com/users/tbiethman/followers","following_url":"https://api.github.com/users/tbiethman/following{/other_user}","gists_url":"https://api.github.com/users/tbiethman/gists{/gist_id}","starred_url":"https://api.github.com/users/tbiethman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbiethman/subscriptions","organizations_url":"https://api.github.com/users/tbiethman/orgs","repos_url":"https://api.github.com/users/tbiethman/repos","events_url":"https://api.github.com/users/tbiethman/events{/privacy}","received_events_url":"https://api.github.com/users/tbiethman/received_events","type":"User","site_admin":false},"assignees":[{"login":"tbiethman","id":1711637,"node_id":"MDQ6VXNlcjE3MTE2Mzc=","avatar_url":"https://avatars3.githubusercontent.com/u/1711637?v=4","gravatar_id":"","url":"https://api.github.com/users/tbiethman","html_url":"https://github.com/tbiethman","followers_url":"https://api.github.com/users/tbiethman/followers","following_url":"https://api.github.com/users/tbiethman/following{/other_user}","gists_url":"https://api.github.com/users/tbiethman/gists{/gist_id}","starred_url":"https://api.github.com/users/tbiethman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbiethman/subscriptions","organizations_url":"https://api.github.com/users/tbiethman/orgs","repos_url":"https://api.github.com/users/tbiethman/repos","events_url":"https://api.github.com/users/tbiethman/events{/privacy}","received_events_url":"https://api.github.com/users/tbiethman/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"ryanthemanuel","id":4873279,"node_id":"MDQ6VXNlcjQ4NzMyNzk=","avatar_url":"https://avatars3.githubusercontent.com/u/4873279?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanthemanuel","html_url":"https://github.com/ryanthemanuel","followers_url":"https://api.github.com/users/ryanthemanuel/followers","following_url":"https://api.github.com/users/ryanthemanuel/following{/other_user}","gists_url":"https://api.github.com/users/ryanthemanuel/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanthemanuel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanthemanuel/subscriptions","organizations_url":"https://api.github.com/users/ryanthemanuel/orgs","repos_url":"https://api.github.com/users/ryanthemanuel/repos","events_url":"https://api.github.com/users/ryanthemanuel/events{/privacy}","received_events_url":"https://api.github.com/users/ryanthemanuel/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":911373322,"node_id":"MDU6TGFiZWw5MTEzNzMzMjI=","url":"https://api.github.com/repos/cerner/terra-clinical/labels/data-grid","name":"data-grid","color":"ca94e8","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cerner/terra-clinical/pulls/408/commits","review_comments_url":"https://api.github.com/repos/cerner/terra-clinical/pulls/408/comments","review_comment_url":"https://api.github.com/repos/cerner/terra-clinical/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cerner/terra-clinical/issues/408/comments","statuses_url":"https://api.github.com/repos/cerner/terra-clinical/statuses/31c687d97bf2ad94c5543f720bd6c7cbea568791","head":{"label":"cerner:data-grid-performance","ref":"data-grid-performance","sha":"31c687d97bf2ad94c5543f720bd6c7cbea568791","user":{"login":"cerner","id":1873208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzMyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1873208?v=4","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"repo":{"id":87335325,"node_id":"MDEwOlJlcG9zaXRvcnk4NzMzNTMyNQ==","name":"terra-clinical","full_name":"cerner/terra-clinical","private":false,"owner":{"login":"cerner","id":1873208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzMyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1873208?v=4","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cerner/terra-clinical","description":"Terra Clinical is a repository for terra react components used only in a clinical setting.","fork":false,"url":"https://api.github.com/repos/cerner/terra-clinical","forks_url":"https://api.github.com/repos/cerner/terra-clinical/forks","keys_url":"https://api.github.com/repos/cerner/terra-clinical/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cerner/terra-clinical/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cerner/terra-clinical/teams","hooks_url":"https://api.github.com/repos/cerner/terra-clinical/hooks","issue_events_url":"https://api.github.com/repos/cerner/terra-clinical/issues/events{/number}","events_url":"https://api.github.com/repos/cerner/terra-clinical/events","assignees_url":"https://api.github.com/repos/cerner/terra-clinical/assignees{/user}","branches_url":"https://api.github.com/repos/cerner/terra-clinical/branches{/branch}","tags_url":"https://api.github.com/repos/cerner/terra-clinical/tags","blobs_url":"https://api.github.com/repos/cerner/terra-clinical/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cerner/terra-clinical/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cerner/terra-clinical/git/refs{/sha}","trees_url":"https://api.github.com/repos/cerner/terra-clinical/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cerner/terra-clinical/statuses/{sha}","languages_url":"https://api.github.com/repos/cerner/terra-clinical/languages","stargazers_url":"https://api.github.com/repos/cerner/terra-clinical/stargazers","contributors_url":"https://api.github.com/repos/cerner/terra-clinical/contributors","subscribers_url":"https://api.github.com/repos/cerner/terra-clinical/subscribers","subscription_url":"https://api.github.com/repos/cerner/terra-clinical/subscription","commits_url":"https://api.github.com/repos/cerner/terra-clinical/commits{/sha}","git_commits_url":"https://api.github.com/repos/cerner/terra-clinical/git/commits{/sha}","comments_url":"https://api.github.com/repos/cerner/terra-clinical/comments{/number}","issue_comment_url":"https://api.github.com/repos/cerner/terra-clinical/issues/comments{/number}","contents_url":"https://api.github.com/repos/cerner/terra-clinical/contents/{+path}","compare_url":"https://api.github.com/repos/cerner/terra-clinical/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cerner/terra-clinical/merges","archive_url":"https://api.github.com/repos/cerner/terra-clinical/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cerner/terra-clinical/downloads","issues_url":"https://api.github.com/repos/cerner/terra-clinical/issues{/number}","pulls_url":"https://api.github.com/repos/cerner/terra-clinical/pulls{/number}","milestones_url":"https://api.github.com/repos/cerner/terra-clinical/milestones{/number}","notifications_url":"https://api.github.com/repos/cerner/terra-clinical/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cerner/terra-clinical/labels{/name}","releases_url":"https://api.github.com/repos/cerner/terra-clinical/releases{/id}","deployments_url":"https://api.github.com/repos/cerner/terra-clinical/deployments","created_at":"2017-04-05T17:02:58Z","updated_at":"2018-11-14T22:09:32Z","pushed_at":"2018-11-15T21:12:04Z","git_url":"git://github.com/cerner/terra-clinical.git","ssh_url":"git@github.com:cerner/terra-clinical.git","clone_url":"https://github.com/cerner/terra-clinical.git","svn_url":"https://github.com/cerner/terra-clinical","homepage":"http://terra-ui.com","size":51841,"stargazers_count":35,"watchers_count":35,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":21,"open_issues":28,"watchers":35,"default_branch":"master"}},"base":{"label":"cerner:master","ref":"master","sha":"939b23648c22d436462efa18b10a8970919d086e","user":{"login":"cerner","id":1873208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzMyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1873208?v=4","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"repo":{"id":87335325,"node_id":"MDEwOlJlcG9zaXRvcnk4NzMzNTMyNQ==","name":"terra-clinical","full_name":"cerner/terra-clinical","private":false,"owner":{"login":"cerner","id":1873208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzMyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1873208?v=4","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cerner/terra-clinical","description":"Terra Clinical is a repository for terra react components used only in a clinical setting.","fork":false,"url":"https://api.github.com/repos/cerner/terra-clinical","forks_url":"https://api.github.com/repos/cerner/terra-clinical/forks","keys_url":"https://api.github.com/repos/cerner/terra-clinical/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cerner/terra-clinical/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cerner/terra-clinical/teams","hooks_url":"https://api.github.com/repos/cerner/terra-clinical/hooks","issue_events_url":"https://api.github.com/repos/cerner/terra-clinical/issues/events{/number}","events_url":"https://api.github.com/repos/cerner/terra-clinical/events","assignees_url":"https://api.github.com/repos/cerner/terra-clinical/assignees{/user}","branches_url":"https://api.github.com/repos/cerner/terra-clinical/branches{/branch}","tags_url":"https://api.github.com/repos/cerner/terra-clinical/tags","blobs_url":"https://api.github.com/repos/cerner/terra-clinical/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cerner/terra-clinical/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cerner/terra-clinical/git/refs{/sha}","trees_url":"https://api.github.com/repos/cerner/terra-clinical/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cerner/terra-clinical/statuses/{sha}","languages_url":"https://api.github.com/repos/cerner/terra-clinical/languages","stargazers_url":"https://api.github.com/repos/cerner/terra-clinical/stargazers","contributors_url":"https://api.github.com/repos/cerner/terra-clinical/contributors","subscribers_url":"https://api.github.com/repos/cerner/terra-clinical/subscribers","subscription_url":"https://api.github.com/repos/cerner/terra-clinical/subscription","commits_url":"https://api.github.com/repos/cerner/terra-clinical/commits{/sha}","git_commits_url":"https://api.github.com/repos/cerner/terra-clinical/git/commits{/sha}","comments_url":"https://api.github.com/repos/cerner/terra-clinical/comments{/number}","issue_comment_url":"https://api.github.com/repos/cerner/terra-clinical/issues/comments{/number}","contents_url":"https://api.github.com/repos/cerner/terra-clinical/contents/{+path}","compare_url":"https://api.github.com/repos/cerner/terra-clinical/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cerner/terra-clinical/merges","archive_url":"https://api.github.com/repos/cerner/terra-clinical/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cerner/terra-clinical/downloads","issues_url":"https://api.github.com/repos/cerner/terra-clinical/issues{/number}","pulls_url":"https://api.github.com/repos/cerner/terra-clinical/pulls{/number}","milestones_url":"https://api.github.com/repos/cerner/terra-clinical/milestones{/number}","notifications_url":"https://api.github.com/repos/cerner/terra-clinical/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cerner/terra-clinical/labels{/name}","releases_url":"https://api.github.com/repos/cerner/terra-clinical/releases{/id}","deployments_url":"https://api.github.com/repos/cerner/terra-clinical/deployments","created_at":"2017-04-05T17:02:58Z","updated_at":"2018-11-14T22:09:32Z","pushed_at":"2018-11-15T21:12:04Z","git_url":"git://github.com/cerner/terra-clinical.git","ssh_url":"git@github.com:cerner/terra-clinical.git","clone_url":"https://github.com/cerner/terra-clinical.git","svn_url":"https://github.com/cerner/terra-clinical","homepage":"http://terra-ui.com","size":51841,"stargazers_count":35,"watchers_count":35,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":21,"open_issues":28,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cerner/terra-clinical/pulls/408"},"html":{"href":"https://github.com/cerner/terra-clinical/pull/408"},"issue":{"href":"https://api.github.com/repos/cerner/terra-clinical/issues/408"},"comments":{"href":"https://api.github.com/repos/cerner/terra-clinical/issues/408/comments"},"review_comments":{"href":"https://api.github.com/repos/cerner/terra-clinical/pulls/408/comments"},"review_comment":{"href":"https://api.github.com/repos/cerner/terra-clinical/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cerner/terra-clinical/pulls/408/commits"},"statuses":{"href":"https://api.github.com/repos/cerner/terra-clinical/statuses/31c687d97bf2ad94c5543f720bd6c7cbea568791"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"tbiethman","id":1711637,"node_id":"MDQ6VXNlcjE3MTE2Mzc=","avatar_url":"https://avatars3.githubusercontent.com/u/1711637?v=4","gravatar_id":"","url":"https://api.github.com/users/tbiethman","html_url":"https://github.com/tbiethman","followers_url":"https://api.github.com/users/tbiethman/followers","following_url":"https://api.github.com/users/tbiethman/following{/other_user}","gists_url":"https://api.github.com/users/tbiethman/gists{/gist_id}","starred_url":"https://api.github.com/users/tbiethman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbiethman/subscriptions","organizations_url":"https://api.github.com/users/tbiethman/orgs","repos_url":"https://api.github.com/users/tbiethman/repos","events_url":"https://api.github.com/users/tbiethman/events{/privacy}","received_events_url":"https://api.github.com/users/tbiethman/received_events","type":"User","site_admin":false},"comments":2,"review_comments":6,"maintainer_can_modify":false,"commits":12,"additions":2318,"deletions":561,"changed_files":91}}
{"actor":{"display_login":"tbiethman"}}