{"action":"closed","number":20727,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/20727","id":187938224,"html_url":"https://github.com/nodejs/node/pull/20727","diff_url":"https://github.com/nodejs/node/pull/20727.diff","patch_url":"https://github.com/nodejs/node/pull/20727.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/20727","number":20727,"state":"closed","locked":false,"title":"deps: V8: cherry-pick b49206d fom upstream","user":{"login":"ofrobots","id":79017,"avatar_url":"https://avatars1.githubusercontent.com/u/79017?v=4","gravatar_id":"","url":"https://api.github.com/users/ofrobots","html_url":"https://github.com/ofrobots","followers_url":"https://api.github.com/users/ofrobots/followers","following_url":"https://api.github.com/users/ofrobots/following{/other_user}","gists_url":"https://api.github.com/users/ofrobots/gists{/gist_id}","starred_url":"https://api.github.com/users/ofrobots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofrobots/subscriptions","organizations_url":"https://api.github.com/users/ofrobots/orgs","repos_url":"https://api.github.com/users/ofrobots/repos","events_url":"https://api.github.com/users/ofrobots/events{/privacy}","received_events_url":"https://api.github.com/users/ofrobots/received_events","type":"User","site_admin":false},"body":"Ref: https://github.com/nodejs/node/issues/20083\r\n\r\nOriginal commit message:\r\n>   ThreadDataTable: Change global linked list to per-Isolate hash map.\r\n> \r\n>   For use cases with a large number of threads or a large number of isolates (or\r\n>   both), ThreadDataTable can be a major performance bottleneck due to O(n)\r\n>   lookup time of the linked list. Switching to a hash map reduces this to O(1).\r\n> \r\n>   Example 1: Sandstorm.io, a Node.js app that utilizes \"fibers\", was observed\r\n>   spending the majority of CPU time iterating over the ThreadDataTable.\r\n>   See: https://sandstorm.io/news/2016-09-30-fiber-bomb-debugging-story\r\n> \r\n>   Example 2: Cloudflare's Workers engine, a high-multi-tenancy web server\r\n>   framework built on V8 (but not Node), creates large numbers of threads and\r\n>   isolates per-process. It saw a 34x improvement in throughput when we applied\r\n>   this patch.\r\n> \r\n>   Cloudflare has been using a patch in production since the Workers launch which\r\n>   replaces the linked list with a hash map -- but still global.\r\n> \r\n>   This commit builds on that but goes further and creates a separate hash map\r\n>   and mutex for each isolate, with the table being a member of the Isolate\r\n>   class. This avoids any globals and should reduce lock contention.\r\n> \r\n>   Bug: v8:5338\r\n>   Change-Id: If0d11509afb2e043b888c376e36d3463db931b47\r\n>   Reviewed-on: https://chromium-review.googlesource.com/1014407\r\n>   Reviewed-by: Yang Guo <yangguo@chromium.org>\r\n>   Commit-Queue: Yang Guo <yangguo@chromium.org>\r\n>   Cr-Commit-Position: refs/heads/master@{#52753}\r\n\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [X] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [X] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n\r\nCI: https://ci.nodejs.org/job/node-test-pull-request/14871/\r\nV8-CI: https://ci.nodejs.org/view/All/job/node-test-commit-v8-linux/1368/","created_at":"2018-05-14T20:15:36Z","updated_at":"2018-05-17T18:25:38Z","closed_at":"2018-05-17T18:25:38Z","merged_at":null,"merge_commit_sha":"b1bcdcaa9069df9da59d254621f9b10b04e85060","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":176191361,"url":"https://api.github.com/repos/nodejs/node/labels/V8%20Engine","name":"V8 Engine","color":"0052cc","default":false},{"id":754449534,"url":"https://api.github.com/repos/nodejs/node/labels/author%20ready","name":"author ready","color":"1eca26","default":false},{"id":171787391,"url":"https://api.github.com/repos/nodejs/node/labels/build","name":"build","color":"eb6420","default":false},{"id":904071494,"url":"https://api.github.com/repos/nodejs/node/labels/v10.x","name":"v10.x","color":"4213c4","default":false},{"id":364835500,"url":"https://api.github.com/repos/nodejs/node/labels/v6.x","name":"v6.x","color":"c2e0c6","default":false},{"id":582285981,"url":"https://api.github.com/repos/nodejs/node/labels/v8.x","name":"v8.x","color":"1d76db","default":false},{"id":651415590,"url":"https://api.github.com/repos/nodejs/node/labels/v9.x","name":"v9.x","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/20727/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/20727/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/20727/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/183d26375010350194c79a9b36547f35fb9353fa","head":{"label":"ofrobots:backport-v8-5338","ref":"backport-v8-5338","sha":"183d26375010350194c79a9b36547f35fb9353fa","user":{"login":"ofrobots","id":79017,"avatar_url":"https://avatars1.githubusercontent.com/u/79017?v=4","gravatar_id":"","url":"https://api.github.com/users/ofrobots","html_url":"https://github.com/ofrobots","followers_url":"https://api.github.com/users/ofrobots/followers","following_url":"https://api.github.com/users/ofrobots/following{/other_user}","gists_url":"https://api.github.com/users/ofrobots/gists{/gist_id}","starred_url":"https://api.github.com/users/ofrobots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofrobots/subscriptions","organizations_url":"https://api.github.com/users/ofrobots/orgs","repos_url":"https://api.github.com/users/ofrobots/repos","events_url":"https://api.github.com/users/ofrobots/events{/privacy}","received_events_url":"https://api.github.com/users/ofrobots/received_events","type":"User","site_admin":false},"repo":{"id":30940664,"name":"node","full_name":"ofrobots/node","owner":{"login":"ofrobots","id":79017,"avatar_url":"https://avatars1.githubusercontent.com/u/79017?v=4","gravatar_id":"","url":"https://api.github.com/users/ofrobots","html_url":"https://github.com/ofrobots","followers_url":"https://api.github.com/users/ofrobots/followers","following_url":"https://api.github.com/users/ofrobots/following{/other_user}","gists_url":"https://api.github.com/users/ofrobots/gists{/gist_id}","starred_url":"https://api.github.com/users/ofrobots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofrobots/subscriptions","organizations_url":"https://api.github.com/users/ofrobots/orgs","repos_url":"https://api.github.com/users/ofrobots/repos","events_url":"https://api.github.com/users/ofrobots/events{/privacy}","received_events_url":"https://api.github.com/users/ofrobots/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ofrobots/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles: https://nodejs.org","fork":true,"url":"https://api.github.com/repos/ofrobots/node","forks_url":"https://api.github.com/repos/ofrobots/node/forks","keys_url":"https://api.github.com/repos/ofrobots/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ofrobots/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ofrobots/node/teams","hooks_url":"https://api.github.com/repos/ofrobots/node/hooks","issue_events_url":"https://api.github.com/repos/ofrobots/node/issues/events{/number}","events_url":"https://api.github.com/repos/ofrobots/node/events","assignees_url":"https://api.github.com/repos/ofrobots/node/assignees{/user}","branches_url":"https://api.github.com/repos/ofrobots/node/branches{/branch}","tags_url":"https://api.github.com/repos/ofrobots/node/tags","blobs_url":"https://api.github.com/repos/ofrobots/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ofrobots/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ofrobots/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/ofrobots/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ofrobots/node/statuses/{sha}","languages_url":"https://api.github.com/repos/ofrobots/node/languages","stargazers_url":"https://api.github.com/repos/ofrobots/node/stargazers","contributors_url":"https://api.github.com/repos/ofrobots/node/contributors","subscribers_url":"https://api.github.com/repos/ofrobots/node/subscribers","subscription_url":"https://api.github.com/repos/ofrobots/node/subscription","commits_url":"https://api.github.com/repos/ofrobots/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/ofrobots/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/ofrobots/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/ofrobots/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/ofrobots/node/contents/{+path}","compare_url":"https://api.github.com/repos/ofrobots/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ofrobots/node/merges","archive_url":"https://api.github.com/repos/ofrobots/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ofrobots/node/downloads","issues_url":"https://api.github.com/repos/ofrobots/node/issues{/number}","pulls_url":"https://api.github.com/repos/ofrobots/node/pulls{/number}","milestones_url":"https://api.github.com/repos/ofrobots/node/milestones{/number}","notifications_url":"https://api.github.com/repos/ofrobots/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ofrobots/node/labels{/name}","releases_url":"https://api.github.com/repos/ofrobots/node/releases{/id}","deployments_url":"https://api.github.com/repos/ofrobots/node/deployments","created_at":"2015-02-17T22:14:04Z","updated_at":"2017-05-23T00:22:07Z","pushed_at":"2018-05-15T23:04:28Z","git_url":"git://github.com/ofrobots/node.git","ssh_url":"git@github.com:ofrobots/node.git","clone_url":"https://github.com/ofrobots/node.git","svn_url":"https://github.com/ofrobots/node","homepage":"https://nodejs.org","size":368785,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"4b00c4fafaa2ae8c41c1f78823c0feb810ae4723","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-05-17T18:15:29Z","pushed_at":"2018-05-17T18:25:32Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":377257,"stargazers_count":48898,"watchers_count":48898,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10310,"mirror_url":null,"archived":false,"open_issues_count":778,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":10310,"open_issues":778,"watchers":48898,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/20727"},"html":{"href":"https://github.com/nodejs/node/pull/20727"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/20727"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/20727/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/20727/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/20727/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/183d26375010350194c79a9b36547f35fb9353fa"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":44,"deletions":68,"changed_files":4}}
{"actor":{"display_login":"ofrobots"}}