{"action":"created","comment":{"url":"https://api.github.com/repos/ravendb/ravendb/pulls/comments/204252087","pull_request_review_id":139298614,"id":204252087,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDI1MjA4Nw==","diff_hunk":"@@ -467,6 +467,33 @@ private void NegotiateWithLeader(TransactionOperationContext context, LogLengthN\n \n                 context.Transaction.Commit();\n             }\n+\n+            _engine.Timeout.Defer(_connection.Source);\n+            _debugRecorder.Record(\"Invoking StateMachine.SnapshotInstalled\");\n+\n+            // notify the state machine, we do this in an async manner, and start\n+            // the operator in a separate thread to avoid timeouts while this is\n+            // going on\n+\n+            var task = Task.Run(() => _engine.SnapshotInstalledAsync(snapshot.LastIncludedIndex));","path":"src/Raven.Server/Rachis/Follower.cs","position":12,"original_position":12,"commit_id":"ff241ab492b9617ce014827e4be35cb6d0347212","original_commit_id":"ff241ab492b9617ce014827e4be35cb6d0347212","user":{"login":"ayende","id":116915,"node_id":"MDQ6VXNlcjExNjkxNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/116915?v=4","gravatar_id":"","url":"https://api.github.com/users/ayende","html_url":"https://github.com/ayende","followers_url":"https://api.github.com/users/ayende/followers","following_url":"https://api.github.com/users/ayende/following{/other_user}","gists_url":"https://api.github.com/users/ayende/gists{/gist_id}","starred_url":"https://api.github.com/users/ayende/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayende/subscriptions","organizations_url":"https://api.github.com/users/ayende/orgs","repos_url":"https://api.github.com/users/ayende/repos","events_url":"https://api.github.com/users/ayende/events{/privacy}","received_events_url":"https://api.github.com/users/ayende/received_events","type":"User","site_admin":false},"body":"Just checked it, and there doesn't seem to be anything there that uses a cancellation token that we can pass, so don't think it will work","created_at":"2018-07-22T19:40:12Z","updated_at":"2018-07-22T19:40:12Z","html_url":"https://github.com/ravendb/ravendb/pull/7131#discussion_r204252087","pull_request_url":"https://api.github.com/repos/ravendb/ravendb/pulls/7131","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/comments/204252087"},"html":{"href":"https://github.com/ravendb/ravendb/pull/7131#discussion_r204252087"},"pull_request":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/7131"}},"in_reply_to_id":204237484},"pull_request":{"url":"https://api.github.com/repos/ravendb/ravendb/pulls/7131","id":202938926,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyOTM4OTI2","html_url":"https://github.com/ravendb/ravendb/pull/7131","diff_url":"https://github.com/ravendb/ravendb/pull/7131.diff","patch_url":"https://github.com/ravendb/ravendb/pull/7131.patch","issue_url":"https://api.github.com/repos/ravendb/ravendb/issues/7131","number":7131,"state":"open","locked":false,"title":"Fixing a race conditions when moving from Passive state to Follower s…","user":{"login":"ayende","id":116915,"node_id":"MDQ6VXNlcjExNjkxNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/116915?v=4","gravatar_id":"","url":"https://api.github.com/users/ayende","html_url":"https://github.com/ayende","followers_url":"https://api.github.com/users/ayende/followers","following_url":"https://api.github.com/users/ayende/following{/other_user}","gists_url":"https://api.github.com/users/ayende/gists{/gist_id}","starred_url":"https://api.github.com/users/ayende/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayende/subscriptions","organizations_url":"https://api.github.com/users/ayende/orgs","repos_url":"https://api.github.com/users/ayende/repos","events_url":"https://api.github.com/users/ayende/events{/privacy}","received_events_url":"https://api.github.com/users/ayende/received_events","type":"User","site_admin":false},"body":"…tate when adding new node to the cluster\r\n\r\nWe'll not start the timer clock until _after_ the leader pushed the snapshot to us if we are already passive.","created_at":"2018-07-20T19:40:00Z","updated_at":"2018-07-22T19:40:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf439ec3b4787457cf9aabfc6c33b8b02d1bcef7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"RavenDB Core","id":2164612,"node_id":"MDQ6VGVhbTIxNjQ2MTI=","slug":"ravendb-core","description":"Core RavenDB Team","privacy":"closed","url":"https://api.github.com/teams/2164612","members_url":"https://api.github.com/teams/2164612/members{/member}","repositories_url":"https://api.github.com/teams/2164612/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ravendb/ravendb/pulls/7131/commits","review_comments_url":"https://api.github.com/repos/ravendb/ravendb/pulls/7131/comments","review_comment_url":"https://api.github.com/repos/ravendb/ravendb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ravendb/ravendb/issues/7131/comments","statuses_url":"https://api.github.com/repos/ravendb/ravendb/statuses/ff241ab492b9617ce014827e4be35cb6d0347212","head":{"label":"ayende:timeout-fix","ref":"timeout-fix","sha":"ff241ab492b9617ce014827e4be35cb6d0347212","user":{"login":"ayende","id":116915,"node_id":"MDQ6VXNlcjExNjkxNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/116915?v=4","gravatar_id":"","url":"https://api.github.com/users/ayende","html_url":"https://github.com/ayende","followers_url":"https://api.github.com/users/ayende/followers","following_url":"https://api.github.com/users/ayende/following{/other_user}","gists_url":"https://api.github.com/users/ayende/gists{/gist_id}","starred_url":"https://api.github.com/users/ayende/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayende/subscriptions","organizations_url":"https://api.github.com/users/ayende/orgs","repos_url":"https://api.github.com/users/ayende/repos","events_url":"https://api.github.com/users/ayende/events{/privacy}","received_events_url":"https://api.github.com/users/ayende/received_events","type":"User","site_admin":false},"repo":{"id":904641,"node_id":"MDEwOlJlcG9zaXRvcnk5MDQ2NDE=","name":"ravendb","full_name":"ayende/ravendb","owner":{"login":"ayende","id":116915,"node_id":"MDQ6VXNlcjExNjkxNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/116915?v=4","gravatar_id":"","url":"https://api.github.com/users/ayende","html_url":"https://github.com/ayende","followers_url":"https://api.github.com/users/ayende/followers","following_url":"https://api.github.com/users/ayende/following{/other_user}","gists_url":"https://api.github.com/users/ayende/gists{/gist_id}","starred_url":"https://api.github.com/users/ayende/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayende/subscriptions","organizations_url":"https://api.github.com/users/ayende/orgs","repos_url":"https://api.github.com/users/ayende/repos","events_url":"https://api.github.com/users/ayende/events{/privacy}","received_events_url":"https://api.github.com/users/ayende/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ayende/ravendb","description":"A linq enabled document database for .NET","fork":true,"url":"https://api.github.com/repos/ayende/ravendb","forks_url":"https://api.github.com/repos/ayende/ravendb/forks","keys_url":"https://api.github.com/repos/ayende/ravendb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ayende/ravendb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ayende/ravendb/teams","hooks_url":"https://api.github.com/repos/ayende/ravendb/hooks","issue_events_url":"https://api.github.com/repos/ayende/ravendb/issues/events{/number}","events_url":"https://api.github.com/repos/ayende/ravendb/events","assignees_url":"https://api.github.com/repos/ayende/ravendb/assignees{/user}","branches_url":"https://api.github.com/repos/ayende/ravendb/branches{/branch}","tags_url":"https://api.github.com/repos/ayende/ravendb/tags","blobs_url":"https://api.github.com/repos/ayende/ravendb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ayende/ravendb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ayende/ravendb/git/refs{/sha}","trees_url":"https://api.github.com/repos/ayende/ravendb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ayende/ravendb/statuses/{sha}","languages_url":"https://api.github.com/repos/ayende/ravendb/languages","stargazers_url":"https://api.github.com/repos/ayende/ravendb/stargazers","contributors_url":"https://api.github.com/repos/ayende/ravendb/contributors","subscribers_url":"https://api.github.com/repos/ayende/ravendb/subscribers","subscription_url":"https://api.github.com/repos/ayende/ravendb/subscription","commits_url":"https://api.github.com/repos/ayende/ravendb/commits{/sha}","git_commits_url":"https://api.github.com/repos/ayende/ravendb/git/commits{/sha}","comments_url":"https://api.github.com/repos/ayende/ravendb/comments{/number}","issue_comment_url":"https://api.github.com/repos/ayende/ravendb/issues/comments{/number}","contents_url":"https://api.github.com/repos/ayende/ravendb/contents/{+path}","compare_url":"https://api.github.com/repos/ayende/ravendb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ayende/ravendb/merges","archive_url":"https://api.github.com/repos/ayende/ravendb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ayende/ravendb/downloads","issues_url":"https://api.github.com/repos/ayende/ravendb/issues{/number}","pulls_url":"https://api.github.com/repos/ayende/ravendb/pulls{/number}","milestones_url":"https://api.github.com/repos/ayende/ravendb/milestones{/number}","notifications_url":"https://api.github.com/repos/ayende/ravendb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ayende/ravendb/labels{/name}","releases_url":"https://api.github.com/repos/ayende/ravendb/releases{/id}","deployments_url":"https://api.github.com/repos/ayende/ravendb/deployments","created_at":"2010-09-12T05:30:13Z","updated_at":"2018-06-14T18:36:44Z","pushed_at":"2018-07-22T10:39:06Z","git_url":"git://github.com/ayende/ravendb.git","ssh_url":"git@github.com:ayende/ravendb.git","clone_url":"https://github.com/ayende/ravendb.git","svn_url":"https://github.com/ayende/ravendb","homepage":"https://ravendb.net","size":441546,"stargazers_count":286,"watchers_count":286,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3,"open_issues":0,"watchers":286,"default_branch":"v4.0"}},"base":{"label":"ravendb:v4.0","ref":"v4.0","sha":"b2c8826590cc88fce3a755276f167ffafcac15fc","user":{"login":"ravendb","id":213792,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMzc5Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/213792?v=4","gravatar_id":"","url":"https://api.github.com/users/ravendb","html_url":"https://github.com/ravendb","followers_url":"https://api.github.com/users/ravendb/followers","following_url":"https://api.github.com/users/ravendb/following{/other_user}","gists_url":"https://api.github.com/users/ravendb/gists{/gist_id}","starred_url":"https://api.github.com/users/ravendb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravendb/subscriptions","organizations_url":"https://api.github.com/users/ravendb/orgs","repos_url":"https://api.github.com/users/ravendb/repos","events_url":"https://api.github.com/users/ravendb/events{/privacy}","received_events_url":"https://api.github.com/users/ravendb/received_events","type":"Organization","site_admin":false},"repo":{"id":542714,"node_id":"MDEwOlJlcG9zaXRvcnk1NDI3MTQ=","name":"ravendb","full_name":"ravendb/ravendb","owner":{"login":"ravendb","id":213792,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMzc5Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/213792?v=4","gravatar_id":"","url":"https://api.github.com/users/ravendb","html_url":"https://github.com/ravendb","followers_url":"https://api.github.com/users/ravendb/followers","following_url":"https://api.github.com/users/ravendb/following{/other_user}","gists_url":"https://api.github.com/users/ravendb/gists{/gist_id}","starred_url":"https://api.github.com/users/ravendb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravendb/subscriptions","organizations_url":"https://api.github.com/users/ravendb/orgs","repos_url":"https://api.github.com/users/ravendb/repos","events_url":"https://api.github.com/users/ravendb/events{/privacy}","received_events_url":"https://api.github.com/users/ravendb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ravendb/ravendb","description":"ACID Document Database","fork":false,"url":"https://api.github.com/repos/ravendb/ravendb","forks_url":"https://api.github.com/repos/ravendb/ravendb/forks","keys_url":"https://api.github.com/repos/ravendb/ravendb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ravendb/ravendb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ravendb/ravendb/teams","hooks_url":"https://api.github.com/repos/ravendb/ravendb/hooks","issue_events_url":"https://api.github.com/repos/ravendb/ravendb/issues/events{/number}","events_url":"https://api.github.com/repos/ravendb/ravendb/events","assignees_url":"https://api.github.com/repos/ravendb/ravendb/assignees{/user}","branches_url":"https://api.github.com/repos/ravendb/ravendb/branches{/branch}","tags_url":"https://api.github.com/repos/ravendb/ravendb/tags","blobs_url":"https://api.github.com/repos/ravendb/ravendb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ravendb/ravendb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ravendb/ravendb/git/refs{/sha}","trees_url":"https://api.github.com/repos/ravendb/ravendb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ravendb/ravendb/statuses/{sha}","languages_url":"https://api.github.com/repos/ravendb/ravendb/languages","stargazers_url":"https://api.github.com/repos/ravendb/ravendb/stargazers","contributors_url":"https://api.github.com/repos/ravendb/ravendb/contributors","subscribers_url":"https://api.github.com/repos/ravendb/ravendb/subscribers","subscription_url":"https://api.github.com/repos/ravendb/ravendb/subscription","commits_url":"https://api.github.com/repos/ravendb/ravendb/commits{/sha}","git_commits_url":"https://api.github.com/repos/ravendb/ravendb/git/commits{/sha}","comments_url":"https://api.github.com/repos/ravendb/ravendb/comments{/number}","issue_comment_url":"https://api.github.com/repos/ravendb/ravendb/issues/comments{/number}","contents_url":"https://api.github.com/repos/ravendb/ravendb/contents/{+path}","compare_url":"https://api.github.com/repos/ravendb/ravendb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ravendb/ravendb/merges","archive_url":"https://api.github.com/repos/ravendb/ravendb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ravendb/ravendb/downloads","issues_url":"https://api.github.com/repos/ravendb/ravendb/issues{/number}","pulls_url":"https://api.github.com/repos/ravendb/ravendb/pulls{/number}","milestones_url":"https://api.github.com/repos/ravendb/ravendb/milestones{/number}","notifications_url":"https://api.github.com/repos/ravendb/ravendb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ravendb/ravendb/labels{/name}","releases_url":"https://api.github.com/repos/ravendb/ravendb/releases{/id}","deployments_url":"https://api.github.com/repos/ravendb/ravendb/deployments","created_at":"2010-03-02T11:05:30Z","updated_at":"2018-07-20T23:20:14Z","pushed_at":"2018-07-22T13:52:01Z","git_url":"git://github.com/ravendb/ravendb.git","ssh_url":"git@github.com:ravendb/ravendb.git","clone_url":"https://github.com/ravendb/ravendb.git","svn_url":"https://github.com/ravendb/ravendb","homepage":"https://ravendb.net","size":445038,"stargazers_count":1970,"watchers_count":1970,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":685,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":685,"open_issues":15,"watchers":1970,"default_branch":"v4.0"}},"_links":{"self":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/7131"},"html":{"href":"https://github.com/ravendb/ravendb/pull/7131"},"issue":{"href":"https://api.github.com/repos/ravendb/ravendb/issues/7131"},"comments":{"href":"https://api.github.com/repos/ravendb/ravendb/issues/7131/comments"},"review_comments":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/7131/comments"},"review_comment":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/7131/commits"},"statuses":{"href":"https://api.github.com/repos/ravendb/ravendb/statuses/ff241ab492b9617ce014827e4be35cb6d0347212"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ayende"}}