{"action":"closed","number":737,"pull_request":{"url":"https://api.github.com/repos/beancount/fava/pulls/737","id":179514388,"html_url":"https://github.com/beancount/fava/pull/737","diff_url":"https://github.com/beancount/fava/pull/737.diff","patch_url":"https://github.com/beancount/fava/pull/737.patch","issue_url":"https://api.github.com/repos/beancount/fava/issues/737","number":737,"state":"closed","locked":false,"title":"handle user budget period formatting error","user":{"login":"elohmeier","id":2536303,"avatar_url":"https://avatars1.githubusercontent.com/u/2536303?v=4","gravatar_id":"","url":"https://api.github.com/users/elohmeier","html_url":"https://github.com/elohmeier","followers_url":"https://api.github.com/users/elohmeier/followers","following_url":"https://api.github.com/users/elohmeier/following{/other_user}","gists_url":"https://api.github.com/users/elohmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/elohmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elohmeier/subscriptions","organizations_url":"https://api.github.com/users/elohmeier/orgs","repos_url":"https://api.github.com/users/elohmeier/repos","events_url":"https://api.github.com/users/elohmeier/events{/privacy}","received_events_url":"https://api.github.com/users/elohmeier/received_events","type":"User","site_admin":false},"body":"If the user enters a wrong period for a budget, e.g.\r\n`2018-01-01 custom \"budget\" Expenses:Food \"M\" 300 EUR`\r\ninstead of \r\n`2018-01-01 custom \"budget\" Expenses:Food \"monthly\" 300 EUR`\r\nfava returns a HTTP 500 and shows a NotImplementedError on the console, originating in fava/util/date.py\", line 220, in number_of_days_in_period.\r\n\r\nThis PR adds a check in the budget parser to check for a valid period name and creates a Error object which assists the user with correcting the issue.\r\n","created_at":"2018-04-04T21:13:56Z","updated_at":"2018-04-12T18:15:54Z","closed_at":"2018-04-12T18:15:54Z","merged_at":null,"merge_commit_sha":"04cd273d75e1ec7f57928bcce562c28d71134db4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/beancount/fava/pulls/737/commits","review_comments_url":"https://api.github.com/repos/beancount/fava/pulls/737/comments","review_comment_url":"https://api.github.com/repos/beancount/fava/pulls/comments{/number}","comments_url":"https://api.github.com/repos/beancount/fava/issues/737/comments","statuses_url":"https://api.github.com/repos/beancount/fava/statuses/f6e2183645ce74d4d78a172bf711107ccaca7ebc","head":{"label":"elohmeier:patch-1","ref":"patch-1","sha":"f6e2183645ce74d4d78a172bf711107ccaca7ebc","user":{"login":"elohmeier","id":2536303,"avatar_url":"https://avatars1.githubusercontent.com/u/2536303?v=4","gravatar_id":"","url":"https://api.github.com/users/elohmeier","html_url":"https://github.com/elohmeier","followers_url":"https://api.github.com/users/elohmeier/followers","following_url":"https://api.github.com/users/elohmeier/following{/other_user}","gists_url":"https://api.github.com/users/elohmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/elohmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elohmeier/subscriptions","organizations_url":"https://api.github.com/users/elohmeier/orgs","repos_url":"https://api.github.com/users/elohmeier/repos","events_url":"https://api.github.com/users/elohmeier/events{/privacy}","received_events_url":"https://api.github.com/users/elohmeier/received_events","type":"User","site_admin":false},"repo":{"id":128122311,"name":"fava","full_name":"elohmeier/fava","owner":{"login":"elohmeier","id":2536303,"avatar_url":"https://avatars1.githubusercontent.com/u/2536303?v=4","gravatar_id":"","url":"https://api.github.com/users/elohmeier","html_url":"https://github.com/elohmeier","followers_url":"https://api.github.com/users/elohmeier/followers","following_url":"https://api.github.com/users/elohmeier/following{/other_user}","gists_url":"https://api.github.com/users/elohmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/elohmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elohmeier/subscriptions","organizations_url":"https://api.github.com/users/elohmeier/orgs","repos_url":"https://api.github.com/users/elohmeier/repos","events_url":"https://api.github.com/users/elohmeier/events{/privacy}","received_events_url":"https://api.github.com/users/elohmeier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/elohmeier/fava","description":"Fava - web interface for Beancount","fork":true,"url":"https://api.github.com/repos/elohmeier/fava","forks_url":"https://api.github.com/repos/elohmeier/fava/forks","keys_url":"https://api.github.com/repos/elohmeier/fava/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elohmeier/fava/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elohmeier/fava/teams","hooks_url":"https://api.github.com/repos/elohmeier/fava/hooks","issue_events_url":"https://api.github.com/repos/elohmeier/fava/issues/events{/number}","events_url":"https://api.github.com/repos/elohmeier/fava/events","assignees_url":"https://api.github.com/repos/elohmeier/fava/assignees{/user}","branches_url":"https://api.github.com/repos/elohmeier/fava/branches{/branch}","tags_url":"https://api.github.com/repos/elohmeier/fava/tags","blobs_url":"https://api.github.com/repos/elohmeier/fava/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elohmeier/fava/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elohmeier/fava/git/refs{/sha}","trees_url":"https://api.github.com/repos/elohmeier/fava/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elohmeier/fava/statuses/{sha}","languages_url":"https://api.github.com/repos/elohmeier/fava/languages","stargazers_url":"https://api.github.com/repos/elohmeier/fava/stargazers","contributors_url":"https://api.github.com/repos/elohmeier/fava/contributors","subscribers_url":"https://api.github.com/repos/elohmeier/fava/subscribers","subscription_url":"https://api.github.com/repos/elohmeier/fava/subscription","commits_url":"https://api.github.com/repos/elohmeier/fava/commits{/sha}","git_commits_url":"https://api.github.com/repos/elohmeier/fava/git/commits{/sha}","comments_url":"https://api.github.com/repos/elohmeier/fava/comments{/number}","issue_comment_url":"https://api.github.com/repos/elohmeier/fava/issues/comments{/number}","contents_url":"https://api.github.com/repos/elohmeier/fava/contents/{+path}","compare_url":"https://api.github.com/repos/elohmeier/fava/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elohmeier/fava/merges","archive_url":"https://api.github.com/repos/elohmeier/fava/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elohmeier/fava/downloads","issues_url":"https://api.github.com/repos/elohmeier/fava/issues{/number}","pulls_url":"https://api.github.com/repos/elohmeier/fava/pulls{/number}","milestones_url":"https://api.github.com/repos/elohmeier/fava/milestones{/number}","notifications_url":"https://api.github.com/repos/elohmeier/fava/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elohmeier/fava/labels{/name}","releases_url":"https://api.github.com/repos/elohmeier/fava/releases{/id}","deployments_url":"https://api.github.com/repos/elohmeier/fava/deployments","created_at":"2018-04-04T21:08:32Z","updated_at":"2018-04-04T21:08:35Z","pushed_at":"2018-04-10T19:09:12Z","git_url":"git://github.com/elohmeier/fava.git","ssh_url":"git@github.com:elohmeier/fava.git","clone_url":"https://github.com/elohmeier/fava.git","svn_url":"https://github.com/elohmeier/fava","homepage":"https://beancount.github.io/fava/","size":7781,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"beancount:master","ref":"master","sha":"74169f5da373d92019706ce5e12b6c866c8bf2a9","user":{"login":"beancount","id":22910810,"avatar_url":"https://avatars1.githubusercontent.com/u/22910810?v=4","gravatar_id":"","url":"https://api.github.com/users/beancount","html_url":"https://github.com/beancount","followers_url":"https://api.github.com/users/beancount/followers","following_url":"https://api.github.com/users/beancount/following{/other_user}","gists_url":"https://api.github.com/users/beancount/gists{/gist_id}","starred_url":"https://api.github.com/users/beancount/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beancount/subscriptions","organizations_url":"https://api.github.com/users/beancount/orgs","repos_url":"https://api.github.com/users/beancount/repos","events_url":"https://api.github.com/users/beancount/events{/privacy}","received_events_url":"https://api.github.com/users/beancount/received_events","type":"Organization","site_admin":false},"repo":{"id":47411155,"name":"fava","full_name":"beancount/fava","owner":{"login":"beancount","id":22910810,"avatar_url":"https://avatars1.githubusercontent.com/u/22910810?v=4","gravatar_id":"","url":"https://api.github.com/users/beancount","html_url":"https://github.com/beancount","followers_url":"https://api.github.com/users/beancount/followers","following_url":"https://api.github.com/users/beancount/following{/other_user}","gists_url":"https://api.github.com/users/beancount/gists{/gist_id}","starred_url":"https://api.github.com/users/beancount/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beancount/subscriptions","organizations_url":"https://api.github.com/users/beancount/orgs","repos_url":"https://api.github.com/users/beancount/repos","events_url":"https://api.github.com/users/beancount/events{/privacy}","received_events_url":"https://api.github.com/users/beancount/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/beancount/fava","description":"Fava - web interface for Beancount","fork":false,"url":"https://api.github.com/repos/beancount/fava","forks_url":"https://api.github.com/repos/beancount/fava/forks","keys_url":"https://api.github.com/repos/beancount/fava/keys{/key_id}","collaborators_url":"https://api.github.com/repos/beancount/fava/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/beancount/fava/teams","hooks_url":"https://api.github.com/repos/beancount/fava/hooks","issue_events_url":"https://api.github.com/repos/beancount/fava/issues/events{/number}","events_url":"https://api.github.com/repos/beancount/fava/events","assignees_url":"https://api.github.com/repos/beancount/fava/assignees{/user}","branches_url":"https://api.github.com/repos/beancount/fava/branches{/branch}","tags_url":"https://api.github.com/repos/beancount/fava/tags","blobs_url":"https://api.github.com/repos/beancount/fava/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/beancount/fava/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/beancount/fava/git/refs{/sha}","trees_url":"https://api.github.com/repos/beancount/fava/git/trees{/sha}","statuses_url":"https://api.github.com/repos/beancount/fava/statuses/{sha}","languages_url":"https://api.github.com/repos/beancount/fava/languages","stargazers_url":"https://api.github.com/repos/beancount/fava/stargazers","contributors_url":"https://api.github.com/repos/beancount/fava/contributors","subscribers_url":"https://api.github.com/repos/beancount/fava/subscribers","subscription_url":"https://api.github.com/repos/beancount/fava/subscription","commits_url":"https://api.github.com/repos/beancount/fava/commits{/sha}","git_commits_url":"https://api.github.com/repos/beancount/fava/git/commits{/sha}","comments_url":"https://api.github.com/repos/beancount/fava/comments{/number}","issue_comment_url":"https://api.github.com/repos/beancount/fava/issues/comments{/number}","contents_url":"https://api.github.com/repos/beancount/fava/contents/{+path}","compare_url":"https://api.github.com/repos/beancount/fava/compare/{base}...{head}","merges_url":"https://api.github.com/repos/beancount/fava/merges","archive_url":"https://api.github.com/repos/beancount/fava/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/beancount/fava/downloads","issues_url":"https://api.github.com/repos/beancount/fava/issues{/number}","pulls_url":"https://api.github.com/repos/beancount/fava/pulls{/number}","milestones_url":"https://api.github.com/repos/beancount/fava/milestones{/number}","notifications_url":"https://api.github.com/repos/beancount/fava/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/beancount/fava/labels{/name}","releases_url":"https://api.github.com/repos/beancount/fava/releases{/id}","deployments_url":"https://api.github.com/repos/beancount/fava/deployments","created_at":"2015-12-04T15:12:55Z","updated_at":"2018-04-12T16:34:40Z","pushed_at":"2018-04-12T18:15:53Z","git_url":"git://github.com/beancount/fava.git","ssh_url":"git@github.com:beancount/fava.git","clone_url":"https://github.com/beancount/fava.git","svn_url":"https://github.com/beancount/fava","homepage":"https://beancount.github.io/fava/","size":7807,"stargazers_count":228,"watchers_count":228,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":49,"open_issues":32,"watchers":228,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/beancount/fava/pulls/737"},"html":{"href":"https://github.com/beancount/fava/pull/737"},"issue":{"href":"https://api.github.com/repos/beancount/fava/issues/737"},"comments":{"href":"https://api.github.com/repos/beancount/fava/issues/737/comments"},"review_comments":{"href":"https://api.github.com/repos/beancount/fava/pulls/737/comments"},"review_comment":{"href":"https://api.github.com/repos/beancount/fava/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/beancount/fava/pulls/737/commits"},"statuses":{"href":"https://api.github.com/repos/beancount/fava/statuses/f6e2183645ce74d4d78a172bf711107ccaca7ebc"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":1,"review_comments":7,"maintainer_can_modify":false,"commits":3,"additions":13,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"yagebu"}}