{"push_id":2908413455,"size":207,"distinct_size":207,"ref":"refs/heads/master","head":"dfe0378464f08e436481c477cfb1c4771092e86d","before":"cda6c97a5741cdfc31c1ad34b7b7268dfbe63b03","commits":[{"sha":"c106fa1b4f741294549e0b223f3cdd8e659673aa","author":{"name":"Rusty Russell","email":"df9728c9e5104131c08c7adb03af425394842596@rustcorp.com.au"},"message":"pytest: add test for reconnect immediately after feerate change.\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":true,"url":"https://api.github.com/repos/9735dev/lightning/commits/c106fa1b4f741294549e0b223f3cdd8e659673aa"},{"sha":"9f175deecdff6b047463e8fd9674009bef448172","author":{"name":"Rusty Russell","email":"df9728c9e5104131c08c7adb03af425394842596@rustcorp.com.au"},"message":"lightningd: update feerate upon receiving revoke_and_ack from fundee.\n\n1. l1     update_fee ->    l2\n2. l1 commitment_signed -> l2 (using new feerate)\n3. l1  <- revoke_and_ack   l2\n4. l1 <- commitment_signed l2 (using new feerate)\n5. l1  -> revoke_and_ack   l2\n\nWhen we break the connection after #3, the reconnection causes #4 to\nbe retransmitted, but it turns out l1 wasn't telling the master to set\nthe local feerate until it received the commitment_signed, so on\nreconnect it uses the old feerate, with predictable results (bad\nsignature).\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":true,"url":"https://api.github.com/repos/9735dev/lightning/commits/9f175deecdff6b047463e8fd9674009bef448172"},{"sha":"213be90e7722959b218fa7dd223138e95cf9676c","author":{"name":"Rusty Russell","email":"df9728c9e5104131c08c7adb03af425394842596@rustcorp.com.au"},"message":"log: implement reopening log-file on SIGHUP\n\nCloses: #1623\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":true,"url":"https://api.github.com/repos/9735dev/lightning/commits/213be90e7722959b218fa7dd223138e95cf9676c"},{"sha":"00696277d2a2cb0c1b70f0daba4b13928c24c159","author":{"name":"Rusty Russell","email":"df9728c9e5104131c08c7adb03af425394842596@rustcorp.com.au"},"message":"logging: always dump a crash log, but make files per-pid.\n\nSomeone had a 21GB crash.log, which doesn't help anyone!\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":true,"url":"https://api.github.com/repos/9735dev/lightning/commits/00696277d2a2cb0c1b70f0daba4b13928c24c159"},{"sha":"8f56d64a1f98ca6ce510864d94e05363d1677d1a","author":{"name":"Christian Decker","email":"bd5e2b43faa09124ca3857e2b70edbfebff5e94e@gmail.com"},"message":"log: Append the current time to the crash log filename\n\nThis should make it easier to identify the latest crash file and correlate\ncrashes with external monitoring tools.","distinct":true,"url":"https://api.github.com/repos/9735dev/lightning/commits/8f56d64a1f98ca6ce510864d94e05363d1677d1a"},{"sha":"2a73450818c1000936004dfabeef79ee69b4920d","author":{"name":"Rusty Russell","email":"df9728c9e5104131c08c7adb03af425394842596@rustcorp.com.au"},"message":"connectd: fix leak of peer.\n\nWe no longer need to keep 'struct peer' around: we free it as soon as\nwe hand off to the master daemon.\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":true,"url":"https://api.github.com/repos/9735dev/lightning/commits/2a73450818c1000936004dfabeef79ee69b4920d"},{"sha":"28977435a346a79ad3a6af118a16319e91318f38","author":{"name":"Rusty Russell","email":"df9728c9e5104131c08c7adb03af425394842596@rustcorp.com.au"},"message":"channeld: fix incorrect comment on reestablish.\n\nWe quote BOLT 2 on *local* above the *remote* checks (we quote it\nagain below when we do the local checks).\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":true,"url":"https://api.github.com/repos/9735dev/lightning/commits/28977435a346a79ad3a6af118a16319e91318f38"},{"sha":"83eadb3548299c0708da20510e5998a1e1dcf865","author":{"name":"Rusty Russell","email":"df9728c9e5104131c08c7adb03af425394842596@rustcorp.com.au"},"message":"gossipd: fix SUPERVERBOSE usage, enhance, when turned on.\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":true,"url":"https://api.github.com/repos/9735dev/lightning/commits/83eadb3548299c0708da20510e5998a1e1dcf865"},{"sha":"f5143d954984816b64f8a77214dc7aec35641e2b","author":{"name":"Rusty Russell","email":"df9728c9e5104131c08c7adb03af425394842596@rustcorp.com.au"},"message":"pytest: fail if we see 'bad reestablish' in the logs.\n\nReally, we should use log-level more cleverly here.\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":true,"url":"https://api.github.com/repos/9735dev/lightning/commits/f5143d954984816b64f8a77214dc7aec35641e2b"},{"sha":"162adfdf12d5e6907c18ffa6a5f9a6885d405590","author":{"name":"Rusty Russell","email":"df9728c9e5104131c08c7adb03af425394842596@rustcorp.com.au"},"message":"listpeers: correctly display features on reconnect.\n\npeer features are only kept for connected peers (as they can change),\nbut we didn't update them on reconnect.  The main effect was that\nafter a restart we displayed the features as empty, even after\nreconnect.\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":true,"url":"https://api.github.com/repos/9735dev/lightning/commits/162adfdf12d5e6907c18ffa6a5f9a6885d405590"},{"sha":"692bae78736ee8120c62cf70add2f91de7d40047","author":{"name":"Rusty Russell","email":"df9728c9e5104131c08c7adb03af425394842596@rustcorp.com.au"},"message":"channeld: create get_per_commitment_point helper.\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":true,"url":"https://api.github.com/repos/9735dev/lightning/commits/692bae78736ee8120c62cf70add2f91de7d40047"},{"sha":"b123b1867d6ba421d5830e8f6cbd156f88220fc8","author":{"name":"Rusty Russell","email":"df9728c9e5104131c08c7adb03af425394842596@rustcorp.com.au"},"message":"shachain: shachain_get_secret helper.\n\nThis is a wrapper around shachain_get_hash, which converts the\ncommit_num to an index and returns a 'struct secret' rather than a\n'struct sha256' (which is really an internal detail).\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":true,"url":"https://api.github.com/repos/9735dev/lightning/commits/b123b1867d6ba421d5830e8f6cbd156f88220fc8"},{"sha":"61c6b8b25a66100c4d3bb3618cd1924a687b0818","author":{"name":"Rusty Russell","email":"df9728c9e5104131c08c7adb03af425394842596@rustcorp.com.au"},"message":"tools/generate-wire.py: mark your_last_per_commitment_secret as a struct secret.\n\nWithout an override, the tool assumes it's a sha256.\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":true,"url":"https://api.github.com/repos/9735dev/lightning/commits/61c6b8b25a66100c4d3bb3618cd1924a687b0818"},{"sha":"ebaf5eaf2e9a401f9f7ce3ca8ef2e6d0724040db","author":{"name":"Rusty Russell","email":"df9728c9e5104131c08c7adb03af425394842596@rustcorp.com.au"},"message":"channeld: send option_data_loss_protect fields.\n\nWe ignore incoming for now, but this means we advertize the option and\nwe send the required fields.\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":true,"url":"https://api.github.com/repos/9735dev/lightning/commits/ebaf5eaf2e9a401f9f7ce3ca8ef2e6d0724040db"},{"sha":"9f044305db470027484f81344719814ea2f45e30","author":{"name":"Rusty Russell","email":"df9728c9e5104131c08c7adb03af425394842596@rustcorp.com.au"},"message":"pytest: dev env var LIGHTNINGD_DEV_LOG_IO turns io logging on immediately.\n\nThis is required for the next test, which has to log messages from channeld\nas soon as it starts (so might be too late if it sends SIGUSR1).\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":true,"url":"https://api.github.com/repos/9735dev/lightning/commits/9f044305db470027484f81344719814ea2f45e30"},{"sha":"4c891f466149409b0f8ab61d0078ab18763bd16b","author":{"name":"Rusty Russell","email":"df9728c9e5104131c08c7adb03af425394842596@rustcorp.com.au"},"message":"common: log when we toggle IO logging, don't edit env in tests!\n\nTests were failing when in the same thread after a test which set\nlog_all_io=True, because SIGUSR1 seemed to be turning logging *off*.\n\nThis is due to Python using references not copies for assignment.\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":true,"url":"https://api.github.com/repos/9735dev/lightning/commits/4c891f466149409b0f8ab61d0078ab18763bd16b"},{"sha":"da8d620907f64ac236fb195b5732aee91e0a1e88","author":{"name":"Rusty Russell","email":"df9728c9e5104131c08c7adb03af425394842596@rustcorp.com.au"},"message":"pytest: check that we advertise and send option_data_loss_protect.\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":true,"url":"https://api.github.com/repos/9735dev/lightning/commits/da8d620907f64ac236fb195b5732aee91e0a1e88"},{"sha":"8340d8c0708685bbd08216a47234fc5c6a659cda","author":{"name":"Rusty Russell","email":"df9728c9e5104131c08c7adb03af425394842596@rustcorp.com.au"},"message":"secret_eq: remove in favor of constant time variant.\n\nTo be safe, we should never memcmp secrets.  We don't do this\ncurrently outside tests, but we're about to.\n\nThe tests to prove this as constant time are the tricky bit.\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":true,"url":"https://api.github.com/repos/9735dev/lightning/commits/8340d8c0708685bbd08216a47234fc5c6a659cda"},{"sha":"7f37fa326304645cbfe3aca2d91476a54848e71e","author":{"name":"Rusty Russell","email":"df9728c9e5104131c08c7adb03af425394842596@rustcorp.com.au"},"message":"derive_basepoints: harden checking.\n\nI managed to crash the HSM by asking for point -1 (shachain_index has an\nassert).  Fail in this case, instead.\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":true,"url":"https://api.github.com/repos/9735dev/lightning/commits/7f37fa326304645cbfe3aca2d91476a54848e71e"},{"sha":"18297a173c469d4665c15fe8bb5186efbb4b9d05","author":{"name":"Rusty Russell","email":"df9728c9e5104131c08c7adb03af425394842596@rustcorp.com.au"},"message":"hsm: routine to validate that a future secret is correct.\n\nCurrently it works for any secret (we don't know the current secret),\nbut importantly it doesn't leak timing information when checking.\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":true,"url":"https://api.github.com/repos/9735dev/lightning/commits/18297a173c469d4665c15fe8bb5186efbb4b9d05"}]}
{"actor":{"display_login":"9735dev"}}