{"action":"created","comment":{"url":"https://api.github.com/repos/AugurProject/augur/pulls/comments/170177433","pull_request_review_id":98824088,"id":170177433,"diff_hunk":"@@ -95,7 +95,9 @@ const selectAggregatePricePoints = memoize((outcomeID, side, orders, orderCancel\n       const obj = {\n         isOfCurrentUser: shareCountPerPrice[price].isOfCurrentUser,\n         shares: formatShares(shareCountPerPrice[price].shares),\n-        price: formatEtherTokens(parseFloat(price))\n+        price: formatEtherTokens(parseFloat(price)),","path":"src/modules/bids-asks/helpers/select-order-book.js","position":5,"original_position":5,"commit_id":"bcc1350b9301a9f5fb5b0a74df6f5931530ffb68","original_commit_id":"bcc1350b9301a9f5fb5b0a74df6f5931530ffb68","user":{"login":"tinybike","id":2637020,"avatar_url":"https://avatars2.githubusercontent.com/u/2637020?v=4","gravatar_id":"","url":"https://api.github.com/users/tinybike","html_url":"https://github.com/tinybike","followers_url":"https://api.github.com/users/tinybike/followers","following_url":"https://api.github.com/users/tinybike/following{/other_user}","gists_url":"https://api.github.com/users/tinybike/gists{/gist_id}","starred_url":"https://api.github.com/users/tinybike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinybike/subscriptions","organizations_url":"https://api.github.com/users/tinybike/orgs","repos_url":"https://api.github.com/users/tinybike/repos","events_url":"https://api.github.com/users/tinybike/events{/privacy}","received_events_url":"https://api.github.com/users/tinybike/received_events","type":"User","site_admin":false},"body":"Does `formatEtherTokens` require a JS number input?  Recommend keeping numbers as either strings or BigNumbers (if you need to arithmetic with them); avoid JS numbers and their associated rounding errors.","created_at":"2018-02-23T06:50:24Z","updated_at":"2018-02-23T06:50:24Z","html_url":"https://github.com/AugurProject/augur/pull/1159#discussion_r170177433","pull_request_url":"https://api.github.com/repos/AugurProject/augur/pulls/1159","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/AugurProject/augur/pulls/comments/170177433"},"html":{"href":"https://github.com/AugurProject/augur/pull/1159#discussion_r170177433"},"pull_request":{"href":"https://api.github.com/repos/AugurProject/augur/pulls/1159"}}},"pull_request":{"url":"https://api.github.com/repos/AugurProject/augur/pulls/1159","id":170622122,"html_url":"https://github.com/AugurProject/augur/pull/1159","diff_url":"https://github.com/AugurProject/augur/pull/1159.diff","patch_url":"https://github.com/AugurProject/augur/pull/1159.patch","issue_url":"https://api.github.com/repos/AugurProject/augur/issues/1159","number":1159,"state":"open","locked":false,"title":"4785 order integration","user":{"login":"JohnDanz","id":10524630,"avatar_url":"https://avatars3.githubusercontent.com/u/10524630?v=4","gravatar_id":"","url":"https://api.github.com/users/JohnDanz","html_url":"https://github.com/JohnDanz","followers_url":"https://api.github.com/users/JohnDanz/followers","following_url":"https://api.github.com/users/JohnDanz/following{/other_user}","gists_url":"https://api.github.com/users/JohnDanz/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnDanz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnDanz/subscriptions","organizations_url":"https://api.github.com/users/JohnDanz/orgs","repos_url":"https://api.github.com/users/JohnDanz/repos","events_url":"https://api.github.com/users/JohnDanz/events{/privacy}","received_events_url":"https://api.github.com/users/JohnDanz/received_events","type":"User","site_admin":false},"body":"https://app.clubhouse.io/augur/story/4785/integration-validation-market-order-form\r\n\r\nThis requires the PR from augur.js: https://github.com/AugurProject/augur.js/pull/249 to be merged into augurjs and used for this version of Augur or else tests will fail/it will break. Travis should fail this PR until that augur.js is updated and this repo is updated to reflect it. ","created_at":"2018-02-21T23:56:53Z","updated_at":"2018-02-23T06:50:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a451de99aad8eef9ff637894517dfaad18602ab","assignee":{"login":"tinybike","id":2637020,"avatar_url":"https://avatars2.githubusercontent.com/u/2637020?v=4","gravatar_id":"","url":"https://api.github.com/users/tinybike","html_url":"https://github.com/tinybike","followers_url":"https://api.github.com/users/tinybike/followers","following_url":"https://api.github.com/users/tinybike/following{/other_user}","gists_url":"https://api.github.com/users/tinybike/gists{/gist_id}","starred_url":"https://api.github.com/users/tinybike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinybike/subscriptions","organizations_url":"https://api.github.com/users/tinybike/orgs","repos_url":"https://api.github.com/users/tinybike/repos","events_url":"https://api.github.com/users/tinybike/events{/privacy}","received_events_url":"https://api.github.com/users/tinybike/received_events","type":"User","site_admin":false},"assignees":[{"login":"tinybike","id":2637020,"avatar_url":"https://avatars2.githubusercontent.com/u/2637020?v=4","gravatar_id":"","url":"https://api.github.com/users/tinybike","html_url":"https://github.com/tinybike","followers_url":"https://api.github.com/users/tinybike/followers","following_url":"https://api.github.com/users/tinybike/following{/other_user}","gists_url":"https://api.github.com/users/tinybike/gists{/gist_id}","starred_url":"https://api.github.com/users/tinybike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinybike/subscriptions","organizations_url":"https://api.github.com/users/tinybike/orgs","repos_url":"https://api.github.com/users/tinybike/repos","events_url":"https://api.github.com/users/tinybike/events{/privacy}","received_events_url":"https://api.github.com/users/tinybike/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"stephensprinkle","id":287003,"avatar_url":"https://avatars3.githubusercontent.com/u/287003?v=4","gravatar_id":"","url":"https://api.github.com/users/stephensprinkle","html_url":"https://github.com/stephensprinkle","followers_url":"https://api.github.com/users/stephensprinkle/followers","following_url":"https://api.github.com/users/stephensprinkle/following{/other_user}","gists_url":"https://api.github.com/users/stephensprinkle/gists{/gist_id}","starred_url":"https://api.github.com/users/stephensprinkle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephensprinkle/subscriptions","organizations_url":"https://api.github.com/users/stephensprinkle/orgs","repos_url":"https://api.github.com/users/stephensprinkle/repos","events_url":"https://api.github.com/users/stephensprinkle/events{/privacy}","received_events_url":"https://api.github.com/users/stephensprinkle/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AugurProject/augur/pulls/1159/commits","review_comments_url":"https://api.github.com/repos/AugurProject/augur/pulls/1159/comments","review_comment_url":"https://api.github.com/repos/AugurProject/augur/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AugurProject/augur/issues/1159/comments","statuses_url":"https://api.github.com/repos/AugurProject/augur/statuses/bcc1350b9301a9f5fb5b0a74df6f5931530ffb68","head":{"label":"AugurProject:4785-order-integration","ref":"4785-order-integration","sha":"bcc1350b9301a9f5fb5b0a74df6f5931530ffb68","user":{"login":"AugurProject","id":9636524,"avatar_url":"https://avatars3.githubusercontent.com/u/9636524?v=4","gravatar_id":"","url":"https://api.github.com/users/AugurProject","html_url":"https://github.com/AugurProject","followers_url":"https://api.github.com/users/AugurProject/followers","following_url":"https://api.github.com/users/AugurProject/following{/other_user}","gists_url":"https://api.github.com/users/AugurProject/gists{/gist_id}","starred_url":"https://api.github.com/users/AugurProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AugurProject/subscriptions","organizations_url":"https://api.github.com/users/AugurProject/orgs","repos_url":"https://api.github.com/users/AugurProject/repos","events_url":"https://api.github.com/users/AugurProject/events{/privacy}","received_events_url":"https://api.github.com/users/AugurProject/received_events","type":"Organization","site_admin":false},"repo":{"id":30208175,"name":"augur","full_name":"AugurProject/augur","owner":{"login":"AugurProject","id":9636524,"avatar_url":"https://avatars3.githubusercontent.com/u/9636524?v=4","gravatar_id":"","url":"https://api.github.com/users/AugurProject","html_url":"https://github.com/AugurProject","followers_url":"https://api.github.com/users/AugurProject/followers","following_url":"https://api.github.com/users/AugurProject/following{/other_user}","gists_url":"https://api.github.com/users/AugurProject/gists{/gist_id}","starred_url":"https://api.github.com/users/AugurProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AugurProject/subscriptions","organizations_url":"https://api.github.com/users/AugurProject/orgs","repos_url":"https://api.github.com/users/AugurProject/repos","events_url":"https://api.github.com/users/AugurProject/events{/privacy}","received_events_url":"https://api.github.com/users/AugurProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AugurProject/augur","description":"Augur UI","fork":false,"url":"https://api.github.com/repos/AugurProject/augur","forks_url":"https://api.github.com/repos/AugurProject/augur/forks","keys_url":"https://api.github.com/repos/AugurProject/augur/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AugurProject/augur/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AugurProject/augur/teams","hooks_url":"https://api.github.com/repos/AugurProject/augur/hooks","issue_events_url":"https://api.github.com/repos/AugurProject/augur/issues/events{/number}","events_url":"https://api.github.com/repos/AugurProject/augur/events","assignees_url":"https://api.github.com/repos/AugurProject/augur/assignees{/user}","branches_url":"https://api.github.com/repos/AugurProject/augur/branches{/branch}","tags_url":"https://api.github.com/repos/AugurProject/augur/tags","blobs_url":"https://api.github.com/repos/AugurProject/augur/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AugurProject/augur/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AugurProject/augur/git/refs{/sha}","trees_url":"https://api.github.com/repos/AugurProject/augur/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AugurProject/augur/statuses/{sha}","languages_url":"https://api.github.com/repos/AugurProject/augur/languages","stargazers_url":"https://api.github.com/repos/AugurProject/augur/stargazers","contributors_url":"https://api.github.com/repos/AugurProject/augur/contributors","subscribers_url":"https://api.github.com/repos/AugurProject/augur/subscribers","subscription_url":"https://api.github.com/repos/AugurProject/augur/subscription","commits_url":"https://api.github.com/repos/AugurProject/augur/commits{/sha}","git_commits_url":"https://api.github.com/repos/AugurProject/augur/git/commits{/sha}","comments_url":"https://api.github.com/repos/AugurProject/augur/comments{/number}","issue_comment_url":"https://api.github.com/repos/AugurProject/augur/issues/comments{/number}","contents_url":"https://api.github.com/repos/AugurProject/augur/contents/{+path}","compare_url":"https://api.github.com/repos/AugurProject/augur/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AugurProject/augur/merges","archive_url":"https://api.github.com/repos/AugurProject/augur/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AugurProject/augur/downloads","issues_url":"https://api.github.com/repos/AugurProject/augur/issues{/number}","pulls_url":"https://api.github.com/repos/AugurProject/augur/pulls{/number}","milestones_url":"https://api.github.com/repos/AugurProject/augur/milestones{/number}","notifications_url":"https://api.github.com/repos/AugurProject/augur/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AugurProject/augur/labels{/name}","releases_url":"https://api.github.com/repos/AugurProject/augur/releases{/id}","deployments_url":"https://api.github.com/repos/AugurProject/augur/deployments","created_at":"2015-02-02T20:56:19Z","updated_at":"2018-02-20T23:07:26Z","pushed_at":"2018-02-23T06:45:20Z","git_url":"git://github.com/AugurProject/augur.git","ssh_url":"git@github.com:AugurProject/augur.git","clone_url":"https://github.com/AugurProject/augur.git","svn_url":"https://github.com/AugurProject/augur","homepage":"https://dev.augur.net","size":49458,"stargazers_count":324,"watchers_count":324,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":67,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":67,"open_issues":9,"watchers":324,"default_branch":"seadragon"}},"base":{"label":"AugurProject:seadragon","ref":"seadragon","sha":"e8a9319cea0a4d74c719f33856db1d75a61f61eb","user":{"login":"AugurProject","id":9636524,"avatar_url":"https://avatars3.githubusercontent.com/u/9636524?v=4","gravatar_id":"","url":"https://api.github.com/users/AugurProject","html_url":"https://github.com/AugurProject","followers_url":"https://api.github.com/users/AugurProject/followers","following_url":"https://api.github.com/users/AugurProject/following{/other_user}","gists_url":"https://api.github.com/users/AugurProject/gists{/gist_id}","starred_url":"https://api.github.com/users/AugurProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AugurProject/subscriptions","organizations_url":"https://api.github.com/users/AugurProject/orgs","repos_url":"https://api.github.com/users/AugurProject/repos","events_url":"https://api.github.com/users/AugurProject/events{/privacy}","received_events_url":"https://api.github.com/users/AugurProject/received_events","type":"Organization","site_admin":false},"repo":{"id":30208175,"name":"augur","full_name":"AugurProject/augur","owner":{"login":"AugurProject","id":9636524,"avatar_url":"https://avatars3.githubusercontent.com/u/9636524?v=4","gravatar_id":"","url":"https://api.github.com/users/AugurProject","html_url":"https://github.com/AugurProject","followers_url":"https://api.github.com/users/AugurProject/followers","following_url":"https://api.github.com/users/AugurProject/following{/other_user}","gists_url":"https://api.github.com/users/AugurProject/gists{/gist_id}","starred_url":"https://api.github.com/users/AugurProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AugurProject/subscriptions","organizations_url":"https://api.github.com/users/AugurProject/orgs","repos_url":"https://api.github.com/users/AugurProject/repos","events_url":"https://api.github.com/users/AugurProject/events{/privacy}","received_events_url":"https://api.github.com/users/AugurProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AugurProject/augur","description":"Augur UI","fork":false,"url":"https://api.github.com/repos/AugurProject/augur","forks_url":"https://api.github.com/repos/AugurProject/augur/forks","keys_url":"https://api.github.com/repos/AugurProject/augur/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AugurProject/augur/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AugurProject/augur/teams","hooks_url":"https://api.github.com/repos/AugurProject/augur/hooks","issue_events_url":"https://api.github.com/repos/AugurProject/augur/issues/events{/number}","events_url":"https://api.github.com/repos/AugurProject/augur/events","assignees_url":"https://api.github.com/repos/AugurProject/augur/assignees{/user}","branches_url":"https://api.github.com/repos/AugurProject/augur/branches{/branch}","tags_url":"https://api.github.com/repos/AugurProject/augur/tags","blobs_url":"https://api.github.com/repos/AugurProject/augur/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AugurProject/augur/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AugurProject/augur/git/refs{/sha}","trees_url":"https://api.github.com/repos/AugurProject/augur/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AugurProject/augur/statuses/{sha}","languages_url":"https://api.github.com/repos/AugurProject/augur/languages","stargazers_url":"https://api.github.com/repos/AugurProject/augur/stargazers","contributors_url":"https://api.github.com/repos/AugurProject/augur/contributors","subscribers_url":"https://api.github.com/repos/AugurProject/augur/subscribers","subscription_url":"https://api.github.com/repos/AugurProject/augur/subscription","commits_url":"https://api.github.com/repos/AugurProject/augur/commits{/sha}","git_commits_url":"https://api.github.com/repos/AugurProject/augur/git/commits{/sha}","comments_url":"https://api.github.com/repos/AugurProject/augur/comments{/number}","issue_comment_url":"https://api.github.com/repos/AugurProject/augur/issues/comments{/number}","contents_url":"https://api.github.com/repos/AugurProject/augur/contents/{+path}","compare_url":"https://api.github.com/repos/AugurProject/augur/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AugurProject/augur/merges","archive_url":"https://api.github.com/repos/AugurProject/augur/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AugurProject/augur/downloads","issues_url":"https://api.github.com/repos/AugurProject/augur/issues{/number}","pulls_url":"https://api.github.com/repos/AugurProject/augur/pulls{/number}","milestones_url":"https://api.github.com/repos/AugurProject/augur/milestones{/number}","notifications_url":"https://api.github.com/repos/AugurProject/augur/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AugurProject/augur/labels{/name}","releases_url":"https://api.github.com/repos/AugurProject/augur/releases{/id}","deployments_url":"https://api.github.com/repos/AugurProject/augur/deployments","created_at":"2015-02-02T20:56:19Z","updated_at":"2018-02-20T23:07:26Z","pushed_at":"2018-02-23T06:45:20Z","git_url":"git://github.com/AugurProject/augur.git","ssh_url":"git@github.com:AugurProject/augur.git","clone_url":"https://github.com/AugurProject/augur.git","svn_url":"https://github.com/AugurProject/augur","homepage":"https://dev.augur.net","size":49458,"stargazers_count":324,"watchers_count":324,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":67,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":67,"open_issues":9,"watchers":324,"default_branch":"seadragon"}},"_links":{"self":{"href":"https://api.github.com/repos/AugurProject/augur/pulls/1159"},"html":{"href":"https://github.com/AugurProject/augur/pull/1159"},"issue":{"href":"https://api.github.com/repos/AugurProject/augur/issues/1159"},"comments":{"href":"https://api.github.com/repos/AugurProject/augur/issues/1159/comments"},"review_comments":{"href":"https://api.github.com/repos/AugurProject/augur/pulls/1159/comments"},"review_comment":{"href":"https://api.github.com/repos/AugurProject/augur/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AugurProject/augur/pulls/1159/commits"},"statuses":{"href":"https://api.github.com/repos/AugurProject/augur/statuses/bcc1350b9301a9f5fb5b0a74df6f5931530ffb68"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tinybike"}}