{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/blueprint/pulls/comments/166474515","pull_request_review_id":94542534,"id":166474515,"diff_hunk":"@@ -212,7 +212,14 @@ export class DateInput extends AbstractComponent<IDateInputProps, IDateInputStat\n         const dateValue = this.isMomentValidAndInRange(value) ? fromMomentToDate(value) : null;\n         const dayPickerProps = {\n             ...this.props.dayPickerProps,\n-            onMonthChange: () => setTimeout(this.registerPopoverBlurHandler, 0),\n+            // dom elements for the updated month is not available when\n+            // onMonthChange is called. setTimeout is necessary to wait\n+            // for the updated month to be rendered\n+            onMonthChange: (month: Date) =>\n+                setTimeout(() => {\n+                    Utils.safeInvoke(this.props.dayPickerProps.onMonthChange, month);","path":"packages/datetime/src/dateInput.tsx","position":30,"original_position":36,"commit_id":"e6b3f4159b12797fc4f3cef5024b90989cb2f5cc","original_commit_id":"e6b3f4159b12797fc4f3cef5024b90989cb2f5cc","user":{"login":"giladgray","id":464822,"avatar_url":"https://avatars1.githubusercontent.com/u/464822?v=4","gravatar_id":"","url":"https://api.github.com/users/giladgray","html_url":"https://github.com/giladgray","followers_url":"https://api.github.com/users/giladgray/followers","following_url":"https://api.github.com/users/giladgray/following{/other_user}","gists_url":"https://api.github.com/users/giladgray/gists{/gist_id}","starred_url":"https://api.github.com/users/giladgray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giladgray/subscriptions","organizations_url":"https://api.github.com/users/giladgray/orgs","repos_url":"https://api.github.com/users/giladgray/repos","events_url":"https://api.github.com/users/giladgray/events{/privacy}","received_events_url":"https://api.github.com/users/giladgray/received_events","type":"User","site_admin":false},"body":"but this shouldn't be in the timeout, it should be called synchronously.","created_at":"2018-02-06T23:19:18Z","updated_at":"2018-02-06T23:24:23Z","html_url":"https://github.com/palantir/blueprint/pull/2093#discussion_r166474515","pull_request_url":"https://api.github.com/repos/palantir/blueprint/pulls/2093","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/comments/166474515"},"html":{"href":"https://github.com/palantir/blueprint/pull/2093#discussion_r166474515"},"pull_request":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/2093"}}},"pull_request":{"url":"https://api.github.com/repos/palantir/blueprint/pulls/2093","id":167325356,"html_url":"https://github.com/palantir/blueprint/pull/2093","diff_url":"https://github.com/palantir/blueprint/pull/2093.diff","patch_url":"https://github.com/palantir/blueprint/pull/2093.patch","issue_url":"https://api.github.com/repos/palantir/blueprint/issues/2093","number":2093,"state":"open","locked":false,"title":"Close dateinput popover","user":{"login":"mud","id":16532,"avatar_url":"https://avatars3.githubusercontent.com/u/16532?v=4","gravatar_id":"","url":"https://api.github.com/users/mud","html_url":"https://github.com/mud","followers_url":"https://api.github.com/users/mud/followers","following_url":"https://api.github.com/users/mud/following{/other_user}","gists_url":"https://api.github.com/users/mud/gists{/gist_id}","starred_url":"https://api.github.com/users/mud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mud/subscriptions","organizations_url":"https://api.github.com/users/mud/orgs","repos_url":"https://api.github.com/users/mud/repos","events_url":"https://api.github.com/users/mud/events{/privacy}","received_events_url":"https://api.github.com/users/mud/received_events","type":"User","site_admin":false},"body":"#### Changes proposed in this pull request:\r\nThis PR enables the dateinput popover to be closed:\r\n* after tabbing out of the last tabbable element inside the date popover\r\n* clicking ESC key\r\n\r\nCurrently, shift tabbing out of the dateinput will close the date popover, however, tabbing through the popover elements do not close the popover after tabbing out of the last tabbable element. ESC also does not have any effect.\r\n\r\n#### Reviewers should focus on:\r\n<!-- fill this out -->\r\nIs there a better way to implement this feature?\r\n\r\n#### Screenshot\r\n![feb-05-2018 21-41-13](https://user-images.githubusercontent.com/16532/35843521-80faf924-0abd-11e8-843b-2f58713cf729.gif)\r\n","created_at":"2018-02-06T05:44:56Z","updated_at":"2018-02-06T23:24:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"488897d9502000a7344ec8ee98c2cccbd8a51916","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/palantir/blueprint/pulls/2093/commits","review_comments_url":"https://api.github.com/repos/palantir/blueprint/pulls/2093/comments","review_comment_url":"https://api.github.com/repos/palantir/blueprint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/blueprint/issues/2093/comments","statuses_url":"https://api.github.com/repos/palantir/blueprint/statuses/e6b3f4159b12797fc4f3cef5024b90989cb2f5cc","head":{"label":"mud:to/dateinput-close","ref":"to/dateinput-close","sha":"e6b3f4159b12797fc4f3cef5024b90989cb2f5cc","user":{"login":"mud","id":16532,"avatar_url":"https://avatars3.githubusercontent.com/u/16532?v=4","gravatar_id":"","url":"https://api.github.com/users/mud","html_url":"https://github.com/mud","followers_url":"https://api.github.com/users/mud/followers","following_url":"https://api.github.com/users/mud/following{/other_user}","gists_url":"https://api.github.com/users/mud/gists{/gist_id}","starred_url":"https://api.github.com/users/mud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mud/subscriptions","organizations_url":"https://api.github.com/users/mud/orgs","repos_url":"https://api.github.com/users/mud/repos","events_url":"https://api.github.com/users/mud/events{/privacy}","received_events_url":"https://api.github.com/users/mud/received_events","type":"User","site_admin":false},"repo":{"id":120406534,"name":"blueprint","full_name":"mud/blueprint","owner":{"login":"mud","id":16532,"avatar_url":"https://avatars3.githubusercontent.com/u/16532?v=4","gravatar_id":"","url":"https://api.github.com/users/mud","html_url":"https://github.com/mud","followers_url":"https://api.github.com/users/mud/followers","following_url":"https://api.github.com/users/mud/following{/other_user}","gists_url":"https://api.github.com/users/mud/gists{/gist_id}","starred_url":"https://api.github.com/users/mud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mud/subscriptions","organizations_url":"https://api.github.com/users/mud/orgs","repos_url":"https://api.github.com/users/mud/repos","events_url":"https://api.github.com/users/mud/events{/privacy}","received_events_url":"https://api.github.com/users/mud/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mud/blueprint","description":"A React-based UI toolkit for the web","fork":true,"url":"https://api.github.com/repos/mud/blueprint","forks_url":"https://api.github.com/repos/mud/blueprint/forks","keys_url":"https://api.github.com/repos/mud/blueprint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mud/blueprint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mud/blueprint/teams","hooks_url":"https://api.github.com/repos/mud/blueprint/hooks","issue_events_url":"https://api.github.com/repos/mud/blueprint/issues/events{/number}","events_url":"https://api.github.com/repos/mud/blueprint/events","assignees_url":"https://api.github.com/repos/mud/blueprint/assignees{/user}","branches_url":"https://api.github.com/repos/mud/blueprint/branches{/branch}","tags_url":"https://api.github.com/repos/mud/blueprint/tags","blobs_url":"https://api.github.com/repos/mud/blueprint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mud/blueprint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mud/blueprint/git/refs{/sha}","trees_url":"https://api.github.com/repos/mud/blueprint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mud/blueprint/statuses/{sha}","languages_url":"https://api.github.com/repos/mud/blueprint/languages","stargazers_url":"https://api.github.com/repos/mud/blueprint/stargazers","contributors_url":"https://api.github.com/repos/mud/blueprint/contributors","subscribers_url":"https://api.github.com/repos/mud/blueprint/subscribers","subscription_url":"https://api.github.com/repos/mud/blueprint/subscription","commits_url":"https://api.github.com/repos/mud/blueprint/commits{/sha}","git_commits_url":"https://api.github.com/repos/mud/blueprint/git/commits{/sha}","comments_url":"https://api.github.com/repos/mud/blueprint/comments{/number}","issue_comment_url":"https://api.github.com/repos/mud/blueprint/issues/comments{/number}","contents_url":"https://api.github.com/repos/mud/blueprint/contents/{+path}","compare_url":"https://api.github.com/repos/mud/blueprint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mud/blueprint/merges","archive_url":"https://api.github.com/repos/mud/blueprint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mud/blueprint/downloads","issues_url":"https://api.github.com/repos/mud/blueprint/issues{/number}","pulls_url":"https://api.github.com/repos/mud/blueprint/pulls{/number}","milestones_url":"https://api.github.com/repos/mud/blueprint/milestones{/number}","notifications_url":"https://api.github.com/repos/mud/blueprint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mud/blueprint/labels{/name}","releases_url":"https://api.github.com/repos/mud/blueprint/releases{/id}","deployments_url":"https://api.github.com/repos/mud/blueprint/deployments","created_at":"2018-02-06T05:32:29Z","updated_at":"2018-02-06T05:32:34Z","pushed_at":"2018-02-06T20:27:08Z","git_url":"git://github.com/mud/blueprint.git","ssh_url":"git@github.com:mud/blueprint.git","clone_url":"https://github.com/mud/blueprint.git","svn_url":"https://github.com/mud/blueprint","homepage":"http://blueprintjs.com/","size":59970,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"palantir:release/1.x","ref":"release/1.x","sha":"b47a344bbfb8d5950dcc5e6843ab3ba5dbd13bac","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":71939872,"name":"blueprint","full_name":"palantir/blueprint","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/blueprint","description":"A React-based UI toolkit for the web","fork":false,"url":"https://api.github.com/repos/palantir/blueprint","forks_url":"https://api.github.com/repos/palantir/blueprint/forks","keys_url":"https://api.github.com/repos/palantir/blueprint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/blueprint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/blueprint/teams","hooks_url":"https://api.github.com/repos/palantir/blueprint/hooks","issue_events_url":"https://api.github.com/repos/palantir/blueprint/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/blueprint/events","assignees_url":"https://api.github.com/repos/palantir/blueprint/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/blueprint/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/blueprint/tags","blobs_url":"https://api.github.com/repos/palantir/blueprint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/blueprint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/blueprint/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/blueprint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/blueprint/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/blueprint/languages","stargazers_url":"https://api.github.com/repos/palantir/blueprint/stargazers","contributors_url":"https://api.github.com/repos/palantir/blueprint/contributors","subscribers_url":"https://api.github.com/repos/palantir/blueprint/subscribers","subscription_url":"https://api.github.com/repos/palantir/blueprint/subscription","commits_url":"https://api.github.com/repos/palantir/blueprint/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/blueprint/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/blueprint/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/blueprint/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/blueprint/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/blueprint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/blueprint/merges","archive_url":"https://api.github.com/repos/palantir/blueprint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/blueprint/downloads","issues_url":"https://api.github.com/repos/palantir/blueprint/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/blueprint/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/blueprint/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/blueprint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/blueprint/labels{/name}","releases_url":"https://api.github.com/repos/palantir/blueprint/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/blueprint/deployments","created_at":"2016-10-25T21:17:50Z","updated_at":"2018-02-06T21:35:15Z","pushed_at":"2018-02-06T21:49:09Z","git_url":"git://github.com/palantir/blueprint.git","ssh_url":"git@github.com:palantir/blueprint.git","clone_url":"https://github.com/palantir/blueprint.git","svn_url":"https://github.com/palantir/blueprint","homepage":"http://blueprintjs.com/","size":59951,"stargazers_count":8248,"watchers_count":8248,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":509,"mirror_url":null,"archived":false,"open_issues_count":276,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":509,"open_issues":276,"watchers":8248,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/2093"},"html":{"href":"https://github.com/palantir/blueprint/pull/2093"},"issue":{"href":"https://api.github.com/repos/palantir/blueprint/issues/2093"},"comments":{"href":"https://api.github.com/repos/palantir/blueprint/issues/2093/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/2093/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/2093/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/blueprint/statuses/e6b3f4159b12797fc4f3cef5024b90989cb2f5cc"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"giladgray"}}