{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/jest/issues/7202","repository_url":"https://api.github.com/repos/facebook/jest","labels_url":"https://api.github.com/repos/facebook/jest/issues/7202/labels{/name}","comments_url":"https://api.github.com/repos/facebook/jest/issues/7202/comments","events_url":"https://api.github.com/repos/facebook/jest/issues/7202/events","html_url":"https://github.com/facebook/jest/pull/7202","id":371411490,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzODYzMDgw","number":7202,"title":"Fix coverage test for Babel 7","user":{"login":"SimenB","id":1404810,"node_id":"MDQ6VXNlcjE0MDQ4MTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1404810?v=4","gravatar_id":"","url":"https://api.github.com/users/SimenB","html_url":"https://github.com/SimenB","followers_url":"https://api.github.com/users/SimenB/followers","following_url":"https://api.github.com/users/SimenB/following{/other_user}","gists_url":"https://api.github.com/users/SimenB/gists{/gist_id}","starred_url":"https://api.github.com/users/SimenB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimenB/subscriptions","organizations_url":"https://api.github.com/users/SimenB/orgs","repos_url":"https://api.github.com/users/SimenB/repos","events_url":"https://api.github.com/users/SimenB/events{/privacy}","received_events_url":"https://api.github.com/users/SimenB/received_events","type":"User","site_admin":false},"labels":[{"id":847426897,"node_id":"MDU6TGFiZWw4NDc0MjY4OTc=","url":"https://api.github.com/repos/facebook/jest/labels/cla%20signed","name":"cla signed","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/facebook/jest/milestones/8","html_url":"https://github.com/facebook/jest/milestone/8","labels_url":"https://api.github.com/repos/facebook/jest/milestones/8/labels","id":3744383,"node_id":"MDk6TWlsZXN0b25lMzc0NDM4Mw==","number":8,"title":"Jest 24","description":"","creator":{"login":"SimenB","id":1404810,"node_id":"MDQ6VXNlcjE0MDQ4MTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1404810?v=4","gravatar_id":"","url":"https://api.github.com/users/SimenB","html_url":"https://github.com/SimenB","followers_url":"https://api.github.com/users/SimenB/followers","following_url":"https://api.github.com/users/SimenB/following{/other_user}","gists_url":"https://api.github.com/users/SimenB/gists{/gist_id}","starred_url":"https://api.github.com/users/SimenB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimenB/subscriptions","organizations_url":"https://api.github.com/users/SimenB/orgs","repos_url":"https://api.github.com/users/SimenB/repos","events_url":"https://api.github.com/users/SimenB/events{/privacy}","received_events_url":"https://api.github.com/users/SimenB/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":9,"state":"open","created_at":"2018-10-16T21:31:36Z","updated_at":"2018-12-05T23:55:14Z","due_on":null,"closed_at":null},"comments":30,"created_at":"2018-10-18T08:15:36Z","updated_at":"2018-12-10T12:43:00Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/facebook/jest/pulls/7202","html_url":"https://github.com/facebook/jest/pull/7202","diff_url":"https://github.com/facebook/jest/pull/7202.diff","patch_url":"https://github.com/facebook/jest/pull/7202.patch"},"body":"## Summary\r\nOpening this up separately to keep it focused. I think this is a bug?\r\n\r\nEssentially https://github.com/facebook/jest/blob/ed671678796d4ceb7a6744e36490316ceedff5c2/e2e/coverage-report/notRequiredInTestSuite.js#L8-L11 is not reported as not covered. This is how the generated html report looks:\r\n\r\n![image](https://user-images.githubusercontent.com/1404810/47140307-2cadb180-d2be-11e8-9b11-6ee67a6a8c31.png)\r\n\r\nSo the `throw` is no longer counted as a statement, which is wrong. (right?)\r\n\r\n@bcoe any idea what's going on here? Help would be greatly appreciated 🙂 Background is that we're moving to Babel 7 (dropping 6). I'm not sure if it's a difference in the last versions of the babel istanbul plugin or if we're doing something odd.\r\nFull diff against master can be seen in #7016.\r\n\r\nRelevant istanbul dependnecy changes: \r\n![image](https://user-images.githubusercontent.com/1404810/47140689-2ec44000-d2bf-11e8-861e-d6c62c90ed27.png)\r\n\r\n## Test plan\r\nI'd like for this PR to have 0 diff in the coverage snapshots, while still passing those tests (others will fail). Then I'll merge it into #7016.\r\n\r\nThe relevant test is `e2e/__tests__/coverage_report.test.js`\r\n"},"comment":{"url":"https://api.github.com/repos/facebook/jest/issues/comments/445802357","html_url":"https://github.com/facebook/jest/pull/7202#issuecomment-445802357","issue_url":"https://api.github.com/repos/facebook/jest/issues/7202","id":445802357,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTgwMjM1Nw==","user":{"login":"thymikee","id":5106466,"node_id":"MDQ6VXNlcjUxMDY0NjY=","avatar_url":"https://avatars2.githubusercontent.com/u/5106466?v=4","gravatar_id":"","url":"https://api.github.com/users/thymikee","html_url":"https://github.com/thymikee","followers_url":"https://api.github.com/users/thymikee/followers","following_url":"https://api.github.com/users/thymikee/following{/other_user}","gists_url":"https://api.github.com/users/thymikee/gists{/gist_id}","starred_url":"https://api.github.com/users/thymikee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thymikee/subscriptions","organizations_url":"https://api.github.com/users/thymikee/orgs","repos_url":"https://api.github.com/users/thymikee/repos","events_url":"https://api.github.com/users/thymikee/events{/privacy}","received_events_url":"https://api.github.com/users/thymikee/received_events","type":"User","site_admin":false},"created_at":"2018-12-10T12:43:00Z","updated_at":"2018-12-10T12:43:00Z","author_association":"COLLABORATOR","body":"@bcoe did you find some time to take a look? Wonder if there are any blockers"}}
{"actor":{"display_login":"thymikee"}}