{"action":"created","comment":{"url":"https://api.github.com/repos/F-Stack/f-stack/pulls/comments/231780642","pull_request_review_id":172824471,"id":231780642,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTc4MDY0Mg==","diff_hunk":"@@ -24,12 +24,20 @@ FF_KNI=1\n #FF_IPFW=1\n \n ifeq ($(FF_DPDK),)\n+ifeq (${shell uname -m},aarch64)","path":"lib/Makefile","position":null,"original_position":4,"commit_id":"31b03876fc58a7b7fd27968aecc5aea6312dfeeb","original_commit_id":"e404bd1de6752b14c4c175e5b5fef940f7f62e8f","user":{"login":"DonBearH","id":32063987,"node_id":"MDQ6VXNlcjMyMDYzOTg3","avatar_url":"https://avatars2.githubusercontent.com/u/32063987?v=4","gravatar_id":"","url":"https://api.github.com/users/DonBearH","html_url":"https://github.com/DonBearH","followers_url":"https://api.github.com/users/DonBearH/followers","following_url":"https://api.github.com/users/DonBearH/following{/other_user}","gists_url":"https://api.github.com/users/DonBearH/gists{/gist_id}","starred_url":"https://api.github.com/users/DonBearH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DonBearH/subscriptions","organizations_url":"https://api.github.com/users/DonBearH/orgs","repos_url":"https://api.github.com/users/DonBearH/repos","events_url":"https://api.github.com/users/DonBearH/events{/privacy}","received_events_url":"https://api.github.com/users/DonBearH/received_events","type":"User","site_admin":false},"body":"Commited. Thanks.","created_at":"2018-11-08T06:59:52Z","updated_at":"2018-11-08T06:59:52Z","html_url":"https://github.com/F-Stack/f-stack/pull/304#discussion_r231780642","pull_request_url":"https://api.github.com/repos/F-Stack/f-stack/pulls/304","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/F-Stack/f-stack/pulls/comments/231780642"},"html":{"href":"https://github.com/F-Stack/f-stack/pull/304#discussion_r231780642"},"pull_request":{"href":"https://api.github.com/repos/F-Stack/f-stack/pulls/304"}},"in_reply_to_id":231749605},"pull_request":{"url":"https://api.github.com/repos/F-Stack/f-stack/pulls/304","id":228958035,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4OTU4MDM1","html_url":"https://github.com/F-Stack/f-stack/pull/304","diff_url":"https://github.com/F-Stack/f-stack/pull/304.diff","patch_url":"https://github.com/F-Stack/f-stack/pull/304.patch","issue_url":"https://api.github.com/repos/F-Stack/f-stack/issues/304","number":304,"state":"open","locked":false,"title":"F stack aarch64","user":{"login":"DonBearH","id":32063987,"node_id":"MDQ6VXNlcjMyMDYzOTg3","avatar_url":"https://avatars2.githubusercontent.com/u/32063987?v=4","gravatar_id":"","url":"https://api.github.com/users/DonBearH","html_url":"https://github.com/DonBearH","followers_url":"https://api.github.com/users/DonBearH/followers","following_url":"https://api.github.com/users/DonBearH/following{/other_user}","gists_url":"https://api.github.com/users/DonBearH/gists{/gist_id}","starred_url":"https://api.github.com/users/DonBearH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DonBearH/subscriptions","organizations_url":"https://api.github.com/users/DonBearH/orgs","repos_url":"https://api.github.com/users/DonBearH/repos","events_url":"https://api.github.com/users/DonBearH/events{/privacy}","received_events_url":"https://api.github.com/users/DonBearH/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nWe recently enable and test f_stack on our arm64 platform.\r\n\r\nIn out tests, there are some modifications to make f_stack run on arm64.\r\nPatch 1 adds arm64 compiler options to support native compilation on arm64,\r\npatch 2 fixes the  -Werror=unused-but-set-variable errors with gcc compilers (no only on arm64),\r\npatch 3 fixes the segmentation faults on arm64 platform when nginx starts up.\r\n\r\nThe performance of nginx and redis are promising.\r\nCompared with kernel stack, we get throughout improvements for about 20% of nginx and 35% of redis.\r\n\r\nHope these patches would merged into f_stack mainline for others want to test on arm64.\r\n\r\nThanks & Best Regards.\r\n","created_at":"2018-11-07T09:02:03Z","updated_at":"2018-11-08T06:59:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bc2d02eafc21ff81a8924f9869c69f707f48c5ea","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/F-Stack/f-stack/pulls/304/commits","review_comments_url":"https://api.github.com/repos/F-Stack/f-stack/pulls/304/comments","review_comment_url":"https://api.github.com/repos/F-Stack/f-stack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/F-Stack/f-stack/issues/304/comments","statuses_url":"https://api.github.com/repos/F-Stack/f-stack/statuses/31b03876fc58a7b7fd27968aecc5aea6312dfeeb","head":{"label":"DonBearH:f_stack_aarch64","ref":"f_stack_aarch64","sha":"31b03876fc58a7b7fd27968aecc5aea6312dfeeb","user":{"login":"DonBearH","id":32063987,"node_id":"MDQ6VXNlcjMyMDYzOTg3","avatar_url":"https://avatars2.githubusercontent.com/u/32063987?v=4","gravatar_id":"","url":"https://api.github.com/users/DonBearH","html_url":"https://github.com/DonBearH","followers_url":"https://api.github.com/users/DonBearH/followers","following_url":"https://api.github.com/users/DonBearH/following{/other_user}","gists_url":"https://api.github.com/users/DonBearH/gists{/gist_id}","starred_url":"https://api.github.com/users/DonBearH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DonBearH/subscriptions","organizations_url":"https://api.github.com/users/DonBearH/orgs","repos_url":"https://api.github.com/users/DonBearH/repos","events_url":"https://api.github.com/users/DonBearH/events{/privacy}","received_events_url":"https://api.github.com/users/DonBearH/received_events","type":"User","site_admin":false},"repo":{"id":156507597,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY1MDc1OTc=","name":"f-stack","full_name":"DonBearH/f-stack","private":false,"owner":{"login":"DonBearH","id":32063987,"node_id":"MDQ6VXNlcjMyMDYzOTg3","avatar_url":"https://avatars2.githubusercontent.com/u/32063987?v=4","gravatar_id":"","url":"https://api.github.com/users/DonBearH","html_url":"https://github.com/DonBearH","followers_url":"https://api.github.com/users/DonBearH/followers","following_url":"https://api.github.com/users/DonBearH/following{/other_user}","gists_url":"https://api.github.com/users/DonBearH/gists{/gist_id}","starred_url":"https://api.github.com/users/DonBearH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DonBearH/subscriptions","organizations_url":"https://api.github.com/users/DonBearH/orgs","repos_url":"https://api.github.com/users/DonBearH/repos","events_url":"https://api.github.com/users/DonBearH/events{/privacy}","received_events_url":"https://api.github.com/users/DonBearH/received_events","type":"User","site_admin":false},"html_url":"https://github.com/DonBearH/f-stack","description":"F-Stack is an user space  network development kit with high performance based on DPDK, FreeBSD TCP/IP stack and coroutine API.","fork":true,"url":"https://api.github.com/repos/DonBearH/f-stack","forks_url":"https://api.github.com/repos/DonBearH/f-stack/forks","keys_url":"https://api.github.com/repos/DonBearH/f-stack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DonBearH/f-stack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DonBearH/f-stack/teams","hooks_url":"https://api.github.com/repos/DonBearH/f-stack/hooks","issue_events_url":"https://api.github.com/repos/DonBearH/f-stack/issues/events{/number}","events_url":"https://api.github.com/repos/DonBearH/f-stack/events","assignees_url":"https://api.github.com/repos/DonBearH/f-stack/assignees{/user}","branches_url":"https://api.github.com/repos/DonBearH/f-stack/branches{/branch}","tags_url":"https://api.github.com/repos/DonBearH/f-stack/tags","blobs_url":"https://api.github.com/repos/DonBearH/f-stack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DonBearH/f-stack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DonBearH/f-stack/git/refs{/sha}","trees_url":"https://api.github.com/repos/DonBearH/f-stack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DonBearH/f-stack/statuses/{sha}","languages_url":"https://api.github.com/repos/DonBearH/f-stack/languages","stargazers_url":"https://api.github.com/repos/DonBearH/f-stack/stargazers","contributors_url":"https://api.github.com/repos/DonBearH/f-stack/contributors","subscribers_url":"https://api.github.com/repos/DonBearH/f-stack/subscribers","subscription_url":"https://api.github.com/repos/DonBearH/f-stack/subscription","commits_url":"https://api.github.com/repos/DonBearH/f-stack/commits{/sha}","git_commits_url":"https://api.github.com/repos/DonBearH/f-stack/git/commits{/sha}","comments_url":"https://api.github.com/repos/DonBearH/f-stack/comments{/number}","issue_comment_url":"https://api.github.com/repos/DonBearH/f-stack/issues/comments{/number}","contents_url":"https://api.github.com/repos/DonBearH/f-stack/contents/{+path}","compare_url":"https://api.github.com/repos/DonBearH/f-stack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DonBearH/f-stack/merges","archive_url":"https://api.github.com/repos/DonBearH/f-stack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DonBearH/f-stack/downloads","issues_url":"https://api.github.com/repos/DonBearH/f-stack/issues{/number}","pulls_url":"https://api.github.com/repos/DonBearH/f-stack/pulls{/number}","milestones_url":"https://api.github.com/repos/DonBearH/f-stack/milestones{/number}","notifications_url":"https://api.github.com/repos/DonBearH/f-stack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DonBearH/f-stack/labels{/name}","releases_url":"https://api.github.com/repos/DonBearH/f-stack/releases{/id}","deployments_url":"https://api.github.com/repos/DonBearH/f-stack/deployments","created_at":"2018-11-07T07:34:15Z","updated_at":"2018-11-07T07:38:36Z","pushed_at":"2018-11-08T06:57:45Z","git_url":"git://github.com/DonBearH/f-stack.git","ssh_url":"git@github.com:DonBearH/f-stack.git","clone_url":"https://github.com/DonBearH/f-stack.git","svn_url":"https://github.com/DonBearH/f-stack","homepage":"http://www.f-stack.org","size":47326,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"F-Stack:master","ref":"master","sha":"e427a0977fb9a101aaea34726f1b7e083b5127c0","user":{"login":"F-Stack","id":26062241,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDYyMjQx","avatar_url":"https://avatars0.githubusercontent.com/u/26062241?v=4","gravatar_id":"","url":"https://api.github.com/users/F-Stack","html_url":"https://github.com/F-Stack","followers_url":"https://api.github.com/users/F-Stack/followers","following_url":"https://api.github.com/users/F-Stack/following{/other_user}","gists_url":"https://api.github.com/users/F-Stack/gists{/gist_id}","starred_url":"https://api.github.com/users/F-Stack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/F-Stack/subscriptions","organizations_url":"https://api.github.com/users/F-Stack/orgs","repos_url":"https://api.github.com/users/F-Stack/repos","events_url":"https://api.github.com/users/F-Stack/events{/privacy}","received_events_url":"https://api.github.com/users/F-Stack/received_events","type":"Organization","site_admin":false},"repo":{"id":88224621,"node_id":"MDEwOlJlcG9zaXRvcnk4ODIyNDYyMQ==","name":"f-stack","full_name":"F-Stack/f-stack","private":false,"owner":{"login":"F-Stack","id":26062241,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDYyMjQx","avatar_url":"https://avatars0.githubusercontent.com/u/26062241?v=4","gravatar_id":"","url":"https://api.github.com/users/F-Stack","html_url":"https://github.com/F-Stack","followers_url":"https://api.github.com/users/F-Stack/followers","following_url":"https://api.github.com/users/F-Stack/following{/other_user}","gists_url":"https://api.github.com/users/F-Stack/gists{/gist_id}","starred_url":"https://api.github.com/users/F-Stack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/F-Stack/subscriptions","organizations_url":"https://api.github.com/users/F-Stack/orgs","repos_url":"https://api.github.com/users/F-Stack/repos","events_url":"https://api.github.com/users/F-Stack/events{/privacy}","received_events_url":"https://api.github.com/users/F-Stack/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/F-Stack/f-stack","description":"F-Stack is an user space  network development kit with high performance based on DPDK, FreeBSD TCP/IP stack and coroutine API.","fork":false,"url":"https://api.github.com/repos/F-Stack/f-stack","forks_url":"https://api.github.com/repos/F-Stack/f-stack/forks","keys_url":"https://api.github.com/repos/F-Stack/f-stack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/F-Stack/f-stack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/F-Stack/f-stack/teams","hooks_url":"https://api.github.com/repos/F-Stack/f-stack/hooks","issue_events_url":"https://api.github.com/repos/F-Stack/f-stack/issues/events{/number}","events_url":"https://api.github.com/repos/F-Stack/f-stack/events","assignees_url":"https://api.github.com/repos/F-Stack/f-stack/assignees{/user}","branches_url":"https://api.github.com/repos/F-Stack/f-stack/branches{/branch}","tags_url":"https://api.github.com/repos/F-Stack/f-stack/tags","blobs_url":"https://api.github.com/repos/F-Stack/f-stack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/F-Stack/f-stack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/F-Stack/f-stack/git/refs{/sha}","trees_url":"https://api.github.com/repos/F-Stack/f-stack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/F-Stack/f-stack/statuses/{sha}","languages_url":"https://api.github.com/repos/F-Stack/f-stack/languages","stargazers_url":"https://api.github.com/repos/F-Stack/f-stack/stargazers","contributors_url":"https://api.github.com/repos/F-Stack/f-stack/contributors","subscribers_url":"https://api.github.com/repos/F-Stack/f-stack/subscribers","subscription_url":"https://api.github.com/repos/F-Stack/f-stack/subscription","commits_url":"https://api.github.com/repos/F-Stack/f-stack/commits{/sha}","git_commits_url":"https://api.github.com/repos/F-Stack/f-stack/git/commits{/sha}","comments_url":"https://api.github.com/repos/F-Stack/f-stack/comments{/number}","issue_comment_url":"https://api.github.com/repos/F-Stack/f-stack/issues/comments{/number}","contents_url":"https://api.github.com/repos/F-Stack/f-stack/contents/{+path}","compare_url":"https://api.github.com/repos/F-Stack/f-stack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/F-Stack/f-stack/merges","archive_url":"https://api.github.com/repos/F-Stack/f-stack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/F-Stack/f-stack/downloads","issues_url":"https://api.github.com/repos/F-Stack/f-stack/issues{/number}","pulls_url":"https://api.github.com/repos/F-Stack/f-stack/pulls{/number}","milestones_url":"https://api.github.com/repos/F-Stack/f-stack/milestones{/number}","notifications_url":"https://api.github.com/repos/F-Stack/f-stack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/F-Stack/f-stack/labels{/name}","releases_url":"https://api.github.com/repos/F-Stack/f-stack/releases{/id}","deployments_url":"https://api.github.com/repos/F-Stack/f-stack/deployments","created_at":"2017-04-14T02:25:12Z","updated_at":"2018-11-08T03:54:11Z","pushed_at":"2018-11-08T06:57:46Z","git_url":"git://github.com/F-Stack/f-stack.git","ssh_url":"git@github.com:F-Stack/f-stack.git","clone_url":"https://github.com/F-Stack/f-stack.git","svn_url":"https://github.com/F-Stack/f-stack","homepage":"http://www.f-stack.org","size":47317,"stargazers_count":1706,"watchers_count":1706,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":397,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":397,"open_issues":40,"watchers":1706,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/F-Stack/f-stack/pulls/304"},"html":{"href":"https://github.com/F-Stack/f-stack/pull/304"},"issue":{"href":"https://api.github.com/repos/F-Stack/f-stack/issues/304"},"comments":{"href":"https://api.github.com/repos/F-Stack/f-stack/issues/304/comments"},"review_comments":{"href":"https://api.github.com/repos/F-Stack/f-stack/pulls/304/comments"},"review_comment":{"href":"https://api.github.com/repos/F-Stack/f-stack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/F-Stack/f-stack/pulls/304/commits"},"statuses":{"href":"https://api.github.com/repos/F-Stack/f-stack/statuses/31b03876fc58a7b7fd27968aecc5aea6312dfeeb"}},"author_association":"NONE"}}
{"actor":{"display_login":"DonBearH"}}