{"action":"created","issue":{"url":"https://api.github.com/repos/feedhenry/fh-logger/issues/27","repository_url":"https://api.github.com/repos/feedhenry/fh-logger","labels_url":"https://api.github.com/repos/feedhenry/fh-logger/issues/27/labels{/name}","comments_url":"https://api.github.com/repos/feedhenry/fh-logger/issues/27/comments","events_url":"https://api.github.com/repos/feedhenry/fh-logger/issues/27/events","html_url":"https://github.com/feedhenry/fh-logger/pull/27","id":351628848,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MTc0ODQ4","number":27,"title":" 🚀 update shrinkwrap file to support node10","user":{"login":"wei-lee","id":912729,"node_id":"MDQ6VXNlcjkxMjcyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/912729?v=4","gravatar_id":"","url":"https://api.github.com/users/wei-lee","html_url":"https://github.com/wei-lee","followers_url":"https://api.github.com/users/wei-lee/followers","following_url":"https://api.github.com/users/wei-lee/following{/other_user}","gists_url":"https://api.github.com/users/wei-lee/gists{/gist_id}","starred_url":"https://api.github.com/users/wei-lee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wei-lee/subscriptions","organizations_url":"https://api.github.com/users/wei-lee/orgs","repos_url":"https://api.github.com/users/wei-lee/repos","events_url":"https://api.github.com/users/wei-lee/events{/privacy}","received_events_url":"https://api.github.com/users/wei-lee/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-17T15:00:43Z","updated_at":"2018-08-17T15:09:45Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/feedhenry/fh-logger/pulls/27","html_url":"https://github.com/feedhenry/fh-logger/pull/27","diff_url":"https://github.com/feedhenry/fh-logger/pull/27.diff","patch_url":"https://github.com/feedhenry/fh-logger/pull/27.patch"},"body":"make sure the `npm install` works with node 10.\r\n\r\nTo verify:\r\n\r\n1. checkout master and run `npm install` using node 10. It will fail.\r\n2. checkout the PR, remove `node_modules` and try again, it will work.\r\n\r\nping @davidffrench @darahayes @odra "},"comment":{"url":"https://api.github.com/repos/feedhenry/fh-logger/issues/comments/413896448","html_url":"https://github.com/feedhenry/fh-logger/pull/27#issuecomment-413896448","issue_url":"https://api.github.com/repos/feedhenry/fh-logger/issues/27","id":413896448,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzg5NjQ0OA==","user":{"login":"davidffrench","id":1596014,"node_id":"MDQ6VXNlcjE1OTYwMTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1596014?v=4","gravatar_id":"","url":"https://api.github.com/users/davidffrench","html_url":"https://github.com/davidffrench","followers_url":"https://api.github.com/users/davidffrench/followers","following_url":"https://api.github.com/users/davidffrench/following{/other_user}","gists_url":"https://api.github.com/users/davidffrench/gists{/gist_id}","starred_url":"https://api.github.com/users/davidffrench/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidffrench/subscriptions","organizations_url":"https://api.github.com/users/davidffrench/orgs","repos_url":"https://api.github.com/users/davidffrench/repos","events_url":"https://api.github.com/users/davidffrench/events{/privacy}","received_events_url":"https://api.github.com/users/davidffrench/received_events","type":"User","site_admin":false},"created_at":"2018-08-17T15:09:45Z","updated_at":"2018-08-17T15:09:45Z","author_association":"MEMBER","body":"@wei-lee This did not fail for me on master running Node 10. Building `dtrace-provider` did fail but the overall install did not.\r\n\r\n`npm WARN read-shrinkwrap This version of npm is compatible with lockfileVersion@1, but npm-shrinkwrap.json was generated for lockfileVersion@0. I'll try to do my best with it!\r\nnpm WARN deprecated node-uuid@1.4.7: Use uuid module instead\r\nnpm WARN deprecated formatio@1.1.1: This package is unmaintained. Use @sinonjs/formatio instead\r\nnpm WARN deprecated to-iso-string@0.0.2: to-iso-string has been deprecated, use @segment/to-iso-string instead.\r\nnpm WARN deprecated jade@0.26.3: Jade has been renamed to pug, please install the latest version of pug instead of jade\r\nnpm WARN deprecated minimatch@0.3.0: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue\r\nnpm WARN deprecated hoek@2.16.3: The major version is no longer supported. Please update to 4.x or newer\r\n\r\n> dtrace-provider@0.6.0 install /Users/davidffrench/work/fh-logger/node_modules/bunyan/node_modules/dtrace-provider\r\n> node scripts/install.js\r\n\r\n---------------\r\nBuilding dtrace-provider failed with exit code 1 and signal 0\r\nre-run install with environment variable V set to see the build output\r\n---------------\r\n\r\n> iltorb@1.3.10 install /Users/davidffrench/work/fh-logger/node_modules/grunt-fh-build/node_modules/iltorb\r\n> detect-libc prebuild-install || node-gyp rebuild\r\n\r\nprebuild-install WARN install No prebuilt binaries found (target=10.9.0 runtime=node arch=x64 platform=darwin)\r\ngyp WARN download NVM_NODEJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use NODEJS_ORG_MIRROR\r\ngyp WARN download NVM_NODEJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use NODEJS_ORG_MIRROR\r\ngyp WARN download NVM_NODEJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use NODEJS_ORG_MIRROR\r\n  CC(target) Release/obj.target/iltorb/brotli/common/dictionary.o\r\n  CC(target) Release/obj.target/iltorb/brotli/dec/bit_reader.o\r\n  CC(target) Release/obj.target/iltorb/brotli/dec/decode.o\r\n  CC(target) Release/obj.target/iltorb/brotli/dec/huffman.o\r\n  CC(target) Release/obj.target/iltorb/brotli/dec/state.o\r\n  CC(target) Release/obj.target/iltorb/brotli/enc/backward_references.o\r\n  CC(target) Release/obj.target/iltorb/brotli/enc/backward_references_hq.o\r\n  CC(target) Release/obj.target/iltorb/brotli/enc/bit_cost.o\r\n  CC(target) Release/obj.target/iltorb/brotli/enc/block_splitter.o\r\n  CC(target) Release/obj.target/iltorb/brotli/enc/brotli_bit_stream.o\r\n  CC(target) Release/obj.target/iltorb/brotli/enc/cluster.o\r\n  CC(target) Release/obj.target/iltorb/brotli/enc/compress_fragment.o\r\n  CC(target) Release/obj.target/iltorb/brotli/enc/compress_fragment_two_pass.o\r\n  CC(target) Release/obj.target/iltorb/brotli/enc/dictionary_hash.o\r\n  CC(target) Release/obj.target/iltorb/brotli/enc/encode.o\r\n  CC(target) Release/obj.target/iltorb/brotli/enc/entropy_encode.o\r\n  CC(target) Release/obj.target/iltorb/brotli/enc/histogram.o\r\n  CC(target) Release/obj.target/iltorb/brotli/enc/literal_cost.o\r\n  CC(target) Release/obj.target/iltorb/brotli/enc/memory.o\r\n  CC(target) Release/obj.target/iltorb/brotli/enc/metablock.o\r\n  CC(target) Release/obj.target/iltorb/brotli/enc/static_dict.o\r\n  CC(target) Release/obj.target/iltorb/brotli/enc/utf8_util.o\r\n  CXX(target) Release/obj.target/iltorb/src/common/allocator.o\r\n  CXX(target) Release/obj.target/iltorb/src/common/stream_coder.o\r\n  CXX(target) Release/obj.target/iltorb/src/dec/stream_decode.o\r\n  CXX(target) Release/obj.target/iltorb/src/dec/stream_decode_worker.o\r\n../src/dec/stream_decode_worker.cc:46:15: warning: 'Call' is deprecated [-Wdeprecated-declarations]\r\n    callback->Call(1, argv);\r\n              ^\r\n../../nan/nan.h:1617:3: note: 'Call' has been explicitly marked deprecated here\r\n  NAN_DEPRECATED inline v8::Local<v8::Value>\r\n  ^\r\n../../nan/nan.h:98:40: note: expanded from macro 'NAN_DEPRECATED'\r\n# define NAN_DEPRECATED __attribute__((deprecated))\r\n                                       ^\r\n../src/dec/stream_decode_worker.cc:52:15: warning: 'Call' is deprecated [-Wdeprecated-declarations]\r\n    callback->Call(2, argv);\r\n              ^\r\n../../nan/nan.h:1617:3: note: 'Call' has been explicitly marked deprecated here\r\n  NAN_DEPRECATED inline v8::Local<v8::Value>\r\n  ^\r\n../../nan/nan.h:98:40: note: expanded from macro 'NAN_DEPRECATED'\r\n# define NAN_DEPRECATED __attribute__((deprecated))\r\n                                       ^\r\n2 warnings generated.\r\n  CXX(target) Release/obj.target/iltorb/src/enc/stream_encode.o\r\n  CXX(target) Release/obj.target/iltorb/src/enc/stream_encode_worker.o\r\n../src/enc/stream_encode_worker.cc:47:15: warning: 'Call' is deprecated [-Wdeprecated-declarations]\r\n    callback->Call(1, argv);\r\n              ^\r\n../../nan/nan.h:1617:3: note: 'Call' has been explicitly marked deprecated here\r\n  NAN_DEPRECATED inline v8::Local<v8::Value>\r\n  ^\r\n../../nan/nan.h:98:40: note: expanded from macro 'NAN_DEPRECATED'\r\n# define NAN_DEPRECATED __attribute__((deprecated))\r\n                                       ^\r\n../src/enc/stream_encode_worker.cc:53:15: warning: 'Call' is deprecated [-Wdeprecated-declarations]\r\n    callback->Call(2, argv);\r\n              ^\r\n../../nan/nan.h:1617:3: note: 'Call' has been explicitly marked deprecated here\r\n  NAN_DEPRECATED inline v8::Local<v8::Value>\r\n  ^\r\n../../nan/nan.h:98:40: note: expanded from macro 'NAN_DEPRECATED'\r\n# define NAN_DEPRECATED __attribute__((deprecated))\r\n                                       ^\r\n2 warnings generated.\r\n  CXX(target) Release/obj.target/iltorb/src/iltorb.o\r\n  SOLINK_MODULE(target) Release/iltorb.node\r\n  COPY ../build/bindings/iltorb.node\r\n  TOUCH Release/obj.target/action_after_build.stamp\r\n\r\n> phantomjs-prebuilt@2.1.16 install /Users/davidffrench/work/fh-logger/node_modules/grunt-fh-build/node_modules/phantomjs-prebuilt\r\n> node install.js\r\n\r\nPhantomJS not found on PATH\r\nDownload already available at /var/folders/fs/mx6hrzcs0vd1t40x0904phbw0000gn/T/phantomjs/phantomjs-2.1.1-macosx.zip\r\nVerified checksum of previously downloaded file\r\nExtracting zip contents\r\nRemoving /Users/davidffrench/work/fh-logger/node_modules/grunt-fh-build/node_modules/phantomjs-prebuilt/lib/phantom\r\nCopying extracted folder /var/folders/fs/mx6hrzcs0vd1t40x0904phbw0000gn/T/phantomjs/phantomjs-2.1.1-macosx.zip-extract-1534518337586/phantomjs-2.1.1-macosx -> /Users/davidffrench/work/fh-logger/node_modules/grunt-fh-build/node_modules/phantomjs-prebuilt/lib/phantom\r\nWriting location.js file\r\nDone. Phantomjs binary available at /Users/davidffrench/work/fh-logger/node_modules/grunt-fh-build/node_modules/phantomjs-prebuilt/lib/phantom/bin/phantomjs\r\n\r\n> phantomjs-prebuilt@2.1.16 install /Users/davidffrench/work/fh-logger/node_modules/phantomjs-prebuilt\r\n> node install.js\r\n\r\nPhantomJS not found on PATH\r\nDownload already available at /var/folders/fs/mx6hrzcs0vd1t40x0904phbw0000gn/T/phantomjs/phantomjs-2.1.1-macosx.zip\r\nVerified checksum of previously downloaded file\r\nExtracting zip contents\r\nRemoving /Users/davidffrench/work/fh-logger/node_modules/phantomjs-prebuilt/lib/phantom\r\nCopying extracted folder /var/folders/fs/mx6hrzcs0vd1t40x0904phbw0000gn/T/phantomjs/phantomjs-2.1.1-macosx.zip-extract-1534518338551/phantomjs-2.1.1-macosx -> /Users/davidffrench/work/fh-logger/node_modules/phantomjs-prebuilt/lib/phantom\r\nWriting location.js file\r\nDone. Phantomjs binary available at /Users/davidffrench/work/fh-logger/node_modules/phantomjs-prebuilt/lib/phantom/bin/phantomjs\r\nadded 1023 packages from 981 contributors and audited 3212 packages in 37.291s\r\nfound 39 vulnerabilities (24 low, 11 moderate, 2 high, 2 critical)\r\n  run `npm audit fix` to fix them, or `npm audit` for details`"}}
{"actor":{"display_login":"davidffrench"}}