{"action":"opened","number":9583,"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9583","id":201886849,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxODg2ODQ5","html_url":"https://github.com/RIOT-OS/RIOT/pull/9583","diff_url":"https://github.com/RIOT-OS/RIOT/pull/9583.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/9583.patch","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/9583","number":9583,"state":"open","locked":false,"title":"mrf24j40: Move flags from netdev to radio","user":{"login":"bergzand","id":5160052,"node_id":"MDQ6VXNlcjUxNjAwNTI=","avatar_url":"https://avatars2.githubusercontent.com/u/5160052?v=4","gravatar_id":"","url":"https://api.github.com/users/bergzand","html_url":"https://github.com/bergzand","followers_url":"https://api.github.com/users/bergzand/followers","following_url":"https://api.github.com/users/bergzand/following{/other_user}","gists_url":"https://api.github.com/users/bergzand/gists{/gist_id}","starred_url":"https://api.github.com/users/bergzand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bergzand/subscriptions","organizations_url":"https://api.github.com/users/bergzand/orgs","repos_url":"https://api.github.com/users/bergzand/repos","events_url":"https://api.github.com/users/bergzand/events{/privacy}","received_events_url":"https://api.github.com/users/bergzand/received_events","type":"User","site_admin":false},"body":"### Contribution description\r\n\r\nThe flags from the ieee802154 struct are only used in the radio code, there is no advantage of having make sense to have them in the netdev struct if their meaning is different per radio driver.\r\n\r\nAlso fixes a bug where the `NETOPT_AUTOACK` doesn't work, but is dis/enabled with the `NETOPT_ACK_REQ` setting.\r\n\r\n### Issues/PRs references\r\n\r\nMinor cleanup preparing for #7736\r\n\r\nSimilar PRs are required for the other radio drivers using flags.","created_at":"2018-07-17T09:59:05Z","updated_at":"2018-07-17T09:59:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":214816571,"node_id":"MDU6TGFiZWwyMTQ4MTY1NzE=","url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/Ready%20for%20CI%20build","name":"Ready for CI build","color":"bfdadc","default":false},{"id":23399098,"node_id":"MDU6TGFiZWwyMzM5OTA5OA==","url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/bug","name":"bug","color":"fc2929","default":true},{"id":135467271,"node_id":"MDU6TGFiZWwxMzU0NjcyNzE=","url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/driver","name":"driver","color":"aaffff","default":false},{"id":23399100,"node_id":"MDU6TGFiZWwyMzM5OTEwMA==","url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/enhancement","name":"enhancement","color":"f17070","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9583/commits","review_comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9583/comments","review_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/9583/comments","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/5616a4907dd6aeda4f46e971c1902dbfa0a8eb7b","head":{"label":"bergzand:pr/mrf24j40/flag_refactor","ref":"pr/mrf24j40/flag_refactor","sha":"5616a4907dd6aeda4f46e971c1902dbfa0a8eb7b","user":{"login":"bergzand","id":5160052,"node_id":"MDQ6VXNlcjUxNjAwNTI=","avatar_url":"https://avatars2.githubusercontent.com/u/5160052?v=4","gravatar_id":"","url":"https://api.github.com/users/bergzand","html_url":"https://github.com/bergzand","followers_url":"https://api.github.com/users/bergzand/followers","following_url":"https://api.github.com/users/bergzand/following{/other_user}","gists_url":"https://api.github.com/users/bergzand/gists{/gist_id}","starred_url":"https://api.github.com/users/bergzand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bergzand/subscriptions","organizations_url":"https://api.github.com/users/bergzand/orgs","repos_url":"https://api.github.com/users/bergzand/repos","events_url":"https://api.github.com/users/bergzand/events{/privacy}","received_events_url":"https://api.github.com/users/bergzand/received_events","type":"User","site_admin":false},"repo":{"id":73482253,"node_id":"MDEwOlJlcG9zaXRvcnk3MzQ4MjI1Mw==","name":"RIOT","full_name":"bergzand/RIOT","owner":{"login":"bergzand","id":5160052,"node_id":"MDQ6VXNlcjUxNjAwNTI=","avatar_url":"https://avatars2.githubusercontent.com/u/5160052?v=4","gravatar_id":"","url":"https://api.github.com/users/bergzand","html_url":"https://github.com/bergzand","followers_url":"https://api.github.com/users/bergzand/followers","following_url":"https://api.github.com/users/bergzand/following{/other_user}","gists_url":"https://api.github.com/users/bergzand/gists{/gist_id}","starred_url":"https://api.github.com/users/bergzand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bergzand/subscriptions","organizations_url":"https://api.github.com/users/bergzand/orgs","repos_url":"https://api.github.com/users/bergzand/repos","events_url":"https://api.github.com/users/bergzand/events{/privacy}","received_events_url":"https://api.github.com/users/bergzand/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bergzand/RIOT","description":"RIOT -  The friendly OS for IoT","fork":true,"url":"https://api.github.com/repos/bergzand/RIOT","forks_url":"https://api.github.com/repos/bergzand/RIOT/forks","keys_url":"https://api.github.com/repos/bergzand/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bergzand/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bergzand/RIOT/teams","hooks_url":"https://api.github.com/repos/bergzand/RIOT/hooks","issue_events_url":"https://api.github.com/repos/bergzand/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/bergzand/RIOT/events","assignees_url":"https://api.github.com/repos/bergzand/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/bergzand/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/bergzand/RIOT/tags","blobs_url":"https://api.github.com/repos/bergzand/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bergzand/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bergzand/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/bergzand/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bergzand/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/bergzand/RIOT/languages","stargazers_url":"https://api.github.com/repos/bergzand/RIOT/stargazers","contributors_url":"https://api.github.com/repos/bergzand/RIOT/contributors","subscribers_url":"https://api.github.com/repos/bergzand/RIOT/subscribers","subscription_url":"https://api.github.com/repos/bergzand/RIOT/subscription","commits_url":"https://api.github.com/repos/bergzand/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/bergzand/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/bergzand/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/bergzand/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/bergzand/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/bergzand/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bergzand/RIOT/merges","archive_url":"https://api.github.com/repos/bergzand/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bergzand/RIOT/downloads","issues_url":"https://api.github.com/repos/bergzand/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/bergzand/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/bergzand/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/bergzand/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bergzand/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/bergzand/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/bergzand/RIOT/deployments","created_at":"2016-11-11T14:02:28Z","updated_at":"2018-05-25T08:26:49Z","pushed_at":"2018-07-17T09:56:25Z","git_url":"git://github.com/bergzand/RIOT.git","ssh_url":"git@github.com:bergzand/RIOT.git","clone_url":"https://github.com/bergzand/RIOT.git","svn_url":"https://github.com/bergzand/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":55713,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RIOT-OS:master","ref":"master","sha":"7f6fe21b937c8e407abfa35080176f714a0a6f72","user":{"login":"RIOT-OS","id":3079480,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNzk0ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/3079480?v=4","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"repo":{"id":7370241,"node_id":"MDEwOlJlcG9zaXRvcnk3MzcwMjQx","name":"RIOT","full_name":"RIOT-OS/RIOT","owner":{"login":"RIOT-OS","id":3079480,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNzk0ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/3079480?v=4","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RIOT-OS/RIOT","description":"RIOT -  The friendly OS for IoT","fork":false,"url":"https://api.github.com/repos/RIOT-OS/RIOT","forks_url":"https://api.github.com/repos/RIOT-OS/RIOT/forks","keys_url":"https://api.github.com/repos/RIOT-OS/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RIOT-OS/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RIOT-OS/RIOT/teams","hooks_url":"https://api.github.com/repos/RIOT-OS/RIOT/hooks","issue_events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/events","assignees_url":"https://api.github.com/repos/RIOT-OS/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/RIOT-OS/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/tags","blobs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/RIOT-OS/RIOT/languages","stargazers_url":"https://api.github.com/repos/RIOT-OS/RIOT/stargazers","contributors_url":"https://api.github.com/repos/RIOT-OS/RIOT/contributors","subscribers_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscribers","subscription_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscription","commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/RIOT-OS/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/RIOT-OS/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RIOT-OS/RIOT/merges","archive_url":"https://api.github.com/repos/RIOT-OS/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RIOT-OS/RIOT/downloads","issues_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/RIOT-OS/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/RIOT-OS/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/RIOT-OS/RIOT/deployments","created_at":"2012-12-29T20:38:40Z","updated_at":"2018-07-17T08:32:11Z","pushed_at":"2018-07-17T09:24:34Z","git_url":"git://github.com/RIOT-OS/RIOT.git","ssh_url":"git@github.com:RIOT-OS/RIOT.git","clone_url":"https://github.com/RIOT-OS/RIOT.git","svn_url":"https://github.com/RIOT-OS/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":55169,"stargazers_count":1865,"watchers_count":1865,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1095,"mirror_url":null,"archived":false,"open_issues_count":757,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":1095,"open_issues":757,"watchers":1865,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9583"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/9583"},"issue":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/9583"},"comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/9583/comments"},"review_comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9583/comments"},"review_comment":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9583/commits"},"statuses":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/5616a4907dd6aeda4f46e971c1902dbfa0a8eb7b"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":34,"deletions":23,"changed_files":4}}
{"actor":{"display_login":"bergzand"}}