{"action":"created","issue":{"url":"https://api.github.com/repos/uber/ios-snapshot-test-case/issues/8","repository_url":"https://api.github.com/repos/uber/ios-snapshot-test-case","labels_url":"https://api.github.com/repos/uber/ios-snapshot-test-case/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/uber/ios-snapshot-test-case/issues/8/comments","events_url":"https://api.github.com/repos/uber/ios-snapshot-test-case/issues/8/events","html_url":"https://github.com/uber/ios-snapshot-test-case/pull/8","id":288741827,"number":8,"title":"Trims away the module names on Swift classes","user":{"login":"dzenbot","id":590579,"avatar_url":"https://avatars2.githubusercontent.com/u/590579?v=4","gravatar_id":"","url":"https://api.github.com/users/dzenbot","html_url":"https://github.com/dzenbot","followers_url":"https://api.github.com/users/dzenbot/followers","following_url":"https://api.github.com/users/dzenbot/following{/other_user}","gists_url":"https://api.github.com/users/dzenbot/gists{/gist_id}","starred_url":"https://api.github.com/users/dzenbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzenbot/subscriptions","organizations_url":"https://api.github.com/users/dzenbot/orgs","repos_url":"https://api.github.com/users/dzenbot/repos","events_url":"https://api.github.com/users/dzenbot/events{/privacy}","received_events_url":"https://api.github.com/users/dzenbot/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-01-15T23:24:41Z","updated_at":"2018-02-16T15:27:27Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/uber/ios-snapshot-test-case/pulls/8","html_url":"https://github.com/uber/ios-snapshot-test-case/pull/8","diff_url":"https://github.com/uber/ios-snapshot-test-case/pull/8.diff","patch_url":"https://github.com/uber/ios-snapshot-test-case/pull/8.patch"},"body":"Port from https://github.com/facebookarchive/ios-snapshot-test-case/pull/219 to new repo.\r\n\r\n#### What is this PR about:\r\nCalling `NSStringFromClass` in Objc for Swift classes creates long strings in form of **\"Module.Class\"**.\r\n\r\nTo be consistent with the Objc style, specially noticeable on reference paths, this patch trims away the module names on Swift classes.\r\n\r\n#### Important:\r\nMerging this could cause tests to fail for users that are currently testing Swift classes, since the image references may not be found. "},"comment":{"url":"https://api.github.com/repos/uber/ios-snapshot-test-case/issues/comments/366266477","html_url":"https://github.com/uber/ios-snapshot-test-case/pull/8#issuecomment-366266477","issue_url":"https://api.github.com/repos/uber/ios-snapshot-test-case/issues/8","id":366266477,"user":{"login":"nunogoncalves","id":3007012,"avatar_url":"https://avatars2.githubusercontent.com/u/3007012?v=4","gravatar_id":"","url":"https://api.github.com/users/nunogoncalves","html_url":"https://github.com/nunogoncalves","followers_url":"https://api.github.com/users/nunogoncalves/followers","following_url":"https://api.github.com/users/nunogoncalves/following{/other_user}","gists_url":"https://api.github.com/users/nunogoncalves/gists{/gist_id}","starred_url":"https://api.github.com/users/nunogoncalves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nunogoncalves/subscriptions","organizations_url":"https://api.github.com/users/nunogoncalves/orgs","repos_url":"https://api.github.com/users/nunogoncalves/repos","events_url":"https://api.github.com/users/nunogoncalves/events{/privacy}","received_events_url":"https://api.github.com/users/nunogoncalves/received_events","type":"User","site_admin":false},"created_at":"2018-02-16T15:27:27Z","updated_at":"2018-02-16T15:27:27Z","author_association":"NONE","body":"Was just looking into the code to perform this change as well. Any idea when this can get merged? :)"}}
{"actor":{"display_login":"nunogoncalves"}}