{"action":"closed","number":521,"pull_request":{"url":"https://api.github.com/repos/tidyverse/tidyr/pulls/521","id":237081547,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MDgxNTQ3","html_url":"https://github.com/tidyverse/tidyr/pull/521","diff_url":"https://github.com/tidyverse/tidyr/pull/521.diff","patch_url":"https://github.com/tidyverse/tidyr/pull/521.patch","issue_url":"https://api.github.com/repos/tidyverse/tidyr/issues/521","number":521,"state":"closed","locked":false,"title":"Improve error message related to irregular sequences","user":{"login":"statwonk","id":1160090,"node_id":"MDQ6VXNlcjExNjAwOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1160090?v=4","gravatar_id":"","url":"https://api.github.com/users/statwonk","html_url":"https://github.com/statwonk","followers_url":"https://api.github.com/users/statwonk/followers","following_url":"https://api.github.com/users/statwonk/following{/other_user}","gists_url":"https://api.github.com/users/statwonk/gists{/gist_id}","starred_url":"https://api.github.com/users/statwonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/statwonk/subscriptions","organizations_url":"https://api.github.com/users/statwonk/orgs","repos_url":"https://api.github.com/users/statwonk/repos","events_url":"https://api.github.com/users/statwonk/events{/privacy}","received_events_url":"https://api.github.com/users/statwonk/received_events","type":"User","site_admin":false},"body":"If I'd like a full sequence from `2018-11-01` to `2018-11-30` and try,\r\n\r\n```r\r\ntibble::tibble(date = c(as.POSIXct(\"2018-11-01\", origin = \"1970-01-01\"), \r\n                        as.POSIXct(\"2018-11-28\", origin = \"1970-01-01\"),\r\n                        as.POSIXct(\"2018-12-01\", origin = \"1970-01-01\"))) %>% \r\n    tidyr::complete(date = tidyr::full_seq(date, 60*60*24)) %>%\r\n    print(n = Inf)\r\n```\r\n\r\nI'll get `Error: `x` is not a regular sequence. ` as a reply. This is a nice error message, but it took me a bit to learn that `tol` would allow me to proceed having granted the data as an irregular sequence.\r\n\r\n```r\r\ntibble::tibble(date = c(as.POSIXct(\"2018-11-01\", origin = \"1970-01-01\"), \r\n                        as.POSIXct(\"2018-11-28\", origin = \"1970-01-01\"),\r\n                        as.POSIXct(\"2018-12-01\", origin = \"1970-01-01\"))) %>% \r\n    tidyr::complete(date = tidyr::full_seq(date, 60*60*24, tol = Inf)) %>%\r\n    print(n = Inf)\r\n```\r\n```\r\n# A tibble: 31 x 1\r\n   date               \r\n   <dttm>             \r\n 1 2018-11-01 00:00:00\r\n 2 2018-11-02 00:00:00\r\n 3 2018-11-03 00:00:00\r\n 4 2018-11-04 00:00:00\r\n 5 2018-11-04 23:00:00\r\n 6 2018-11-05 23:00:00\r\n 7 2018-11-06 23:00:00\r\n 8 2018-11-07 23:00:00\r\n 9 2018-11-08 23:00:00\r\n10 2018-11-09 23:00:00\r\n11 2018-11-10 23:00:00\r\n12 2018-11-11 23:00:00\r\n13 2018-11-12 23:00:00\r\n14 2018-11-13 23:00:00\r\n15 2018-11-14 23:00:00\r\n16 2018-11-15 23:00:00\r\n17 2018-11-16 23:00:00\r\n18 2018-11-17 23:00:00\r\n19 2018-11-18 23:00:00\r\n20 2018-11-19 23:00:00\r\n21 2018-11-20 23:00:00\r\n22 2018-11-21 23:00:00\r\n23 2018-11-22 23:00:00\r\n24 2018-11-23 23:00:00\r\n25 2018-11-24 23:00:00\r\n26 2018-11-25 23:00:00\r\n27 2018-11-26 23:00:00\r\n28 2018-11-27 23:00:00\r\n29 2018-11-28 23:00:00\r\n30 2018-11-29 23:00:00\r\n31 2018-11-30 23:00:00\r\n```\r\n\r\nThis update alerts the user to the `tol` functionality, \"`x` is not a regular sequence. Change `tol` to `Inf` if this is expected.\"","created_at":"2018-12-08T17:51:32Z","updated_at":"2019-01-04T17:50:44Z","closed_at":"2019-01-04T17:50:44Z","merged_at":null,"merge_commit_sha":"9a113ee5fd33135776ec0683715f8a69475b6bf5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tidyverse/tidyr/pulls/521/commits","review_comments_url":"https://api.github.com/repos/tidyverse/tidyr/pulls/521/comments","review_comment_url":"https://api.github.com/repos/tidyverse/tidyr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tidyverse/tidyr/issues/521/comments","statuses_url":"https://api.github.com/repos/tidyverse/tidyr/statuses/f4da88e3d3bdfed708a879c99e14f2f3a1aa63d8","head":{"label":"statwonk:improve-full_seq-tol-violation-message","ref":"improve-full_seq-tol-violation-message","sha":"f4da88e3d3bdfed708a879c99e14f2f3a1aa63d8","user":{"login":"statwonk","id":1160090,"node_id":"MDQ6VXNlcjExNjAwOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1160090?v=4","gravatar_id":"","url":"https://api.github.com/users/statwonk","html_url":"https://github.com/statwonk","followers_url":"https://api.github.com/users/statwonk/followers","following_url":"https://api.github.com/users/statwonk/following{/other_user}","gists_url":"https://api.github.com/users/statwonk/gists{/gist_id}","starred_url":"https://api.github.com/users/statwonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/statwonk/subscriptions","organizations_url":"https://api.github.com/users/statwonk/orgs","repos_url":"https://api.github.com/users/statwonk/repos","events_url":"https://api.github.com/users/statwonk/events{/privacy}","received_events_url":"https://api.github.com/users/statwonk/received_events","type":"User","site_admin":false},"repo":{"id":160958198,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA5NTgxOTg=","name":"tidyr","full_name":"statwonk/tidyr","private":false,"owner":{"login":"statwonk","id":1160090,"node_id":"MDQ6VXNlcjExNjAwOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1160090?v=4","gravatar_id":"","url":"https://api.github.com/users/statwonk","html_url":"https://github.com/statwonk","followers_url":"https://api.github.com/users/statwonk/followers","following_url":"https://api.github.com/users/statwonk/following{/other_user}","gists_url":"https://api.github.com/users/statwonk/gists{/gist_id}","starred_url":"https://api.github.com/users/statwonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/statwonk/subscriptions","organizations_url":"https://api.github.com/users/statwonk/orgs","repos_url":"https://api.github.com/users/statwonk/repos","events_url":"https://api.github.com/users/statwonk/events{/privacy}","received_events_url":"https://api.github.com/users/statwonk/received_events","type":"User","site_admin":false},"html_url":"https://github.com/statwonk/tidyr","description":"Easily tidy data with spread and gather functions.","fork":true,"url":"https://api.github.com/repos/statwonk/tidyr","forks_url":"https://api.github.com/repos/statwonk/tidyr/forks","keys_url":"https://api.github.com/repos/statwonk/tidyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/statwonk/tidyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/statwonk/tidyr/teams","hooks_url":"https://api.github.com/repos/statwonk/tidyr/hooks","issue_events_url":"https://api.github.com/repos/statwonk/tidyr/issues/events{/number}","events_url":"https://api.github.com/repos/statwonk/tidyr/events","assignees_url":"https://api.github.com/repos/statwonk/tidyr/assignees{/user}","branches_url":"https://api.github.com/repos/statwonk/tidyr/branches{/branch}","tags_url":"https://api.github.com/repos/statwonk/tidyr/tags","blobs_url":"https://api.github.com/repos/statwonk/tidyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/statwonk/tidyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/statwonk/tidyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/statwonk/tidyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/statwonk/tidyr/statuses/{sha}","languages_url":"https://api.github.com/repos/statwonk/tidyr/languages","stargazers_url":"https://api.github.com/repos/statwonk/tidyr/stargazers","contributors_url":"https://api.github.com/repos/statwonk/tidyr/contributors","subscribers_url":"https://api.github.com/repos/statwonk/tidyr/subscribers","subscription_url":"https://api.github.com/repos/statwonk/tidyr/subscription","commits_url":"https://api.github.com/repos/statwonk/tidyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/statwonk/tidyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/statwonk/tidyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/statwonk/tidyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/statwonk/tidyr/contents/{+path}","compare_url":"https://api.github.com/repos/statwonk/tidyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/statwonk/tidyr/merges","archive_url":"https://api.github.com/repos/statwonk/tidyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/statwonk/tidyr/downloads","issues_url":"https://api.github.com/repos/statwonk/tidyr/issues{/number}","pulls_url":"https://api.github.com/repos/statwonk/tidyr/pulls{/number}","milestones_url":"https://api.github.com/repos/statwonk/tidyr/milestones{/number}","notifications_url":"https://api.github.com/repos/statwonk/tidyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/statwonk/tidyr/labels{/name}","releases_url":"https://api.github.com/repos/statwonk/tidyr/releases{/id}","deployments_url":"https://api.github.com/repos/statwonk/tidyr/deployments","created_at":"2018-12-08T16:38:45Z","updated_at":"2018-12-08T16:38:47Z","pushed_at":"2018-12-08T17:51:27Z","git_url":"git://github.com/statwonk/tidyr.git","ssh_url":"git@github.com:statwonk/tidyr.git","clone_url":"https://github.com/statwonk/tidyr.git","svn_url":"https://github.com/statwonk/tidyr","homepage":"tidyr.tidyverse.org","size":3439,"stargazers_count":0,"watchers_count":0,"language":"R","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tidyverse:master","ref":"master","sha":"28af2f1c0f5d518f605b56b79e3c64f1ee2cd00d","user":{"login":"tidyverse","id":22032646,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDMyNjQ2","avatar_url":"https://avatars2.githubusercontent.com/u/22032646?v=4","gravatar_id":"","url":"https://api.github.com/users/tidyverse","html_url":"https://github.com/tidyverse","followers_url":"https://api.github.com/users/tidyverse/followers","following_url":"https://api.github.com/users/tidyverse/following{/other_user}","gists_url":"https://api.github.com/users/tidyverse/gists{/gist_id}","starred_url":"https://api.github.com/users/tidyverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tidyverse/subscriptions","organizations_url":"https://api.github.com/users/tidyverse/orgs","repos_url":"https://api.github.com/users/tidyverse/repos","events_url":"https://api.github.com/users/tidyverse/events{/privacy}","received_events_url":"https://api.github.com/users/tidyverse/received_events","type":"Organization","site_admin":false},"repo":{"id":20688261,"node_id":"MDEwOlJlcG9zaXRvcnkyMDY4ODI2MQ==","name":"tidyr","full_name":"tidyverse/tidyr","private":false,"owner":{"login":"tidyverse","id":22032646,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDMyNjQ2","avatar_url":"https://avatars2.githubusercontent.com/u/22032646?v=4","gravatar_id":"","url":"https://api.github.com/users/tidyverse","html_url":"https://github.com/tidyverse","followers_url":"https://api.github.com/users/tidyverse/followers","following_url":"https://api.github.com/users/tidyverse/following{/other_user}","gists_url":"https://api.github.com/users/tidyverse/gists{/gist_id}","starred_url":"https://api.github.com/users/tidyverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tidyverse/subscriptions","organizations_url":"https://api.github.com/users/tidyverse/orgs","repos_url":"https://api.github.com/users/tidyverse/repos","events_url":"https://api.github.com/users/tidyverse/events{/privacy}","received_events_url":"https://api.github.com/users/tidyverse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tidyverse/tidyr","description":"Easily tidy data with spread and gather functions.","fork":false,"url":"https://api.github.com/repos/tidyverse/tidyr","forks_url":"https://api.github.com/repos/tidyverse/tidyr/forks","keys_url":"https://api.github.com/repos/tidyverse/tidyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tidyverse/tidyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tidyverse/tidyr/teams","hooks_url":"https://api.github.com/repos/tidyverse/tidyr/hooks","issue_events_url":"https://api.github.com/repos/tidyverse/tidyr/issues/events{/number}","events_url":"https://api.github.com/repos/tidyverse/tidyr/events","assignees_url":"https://api.github.com/repos/tidyverse/tidyr/assignees{/user}","branches_url":"https://api.github.com/repos/tidyverse/tidyr/branches{/branch}","tags_url":"https://api.github.com/repos/tidyverse/tidyr/tags","blobs_url":"https://api.github.com/repos/tidyverse/tidyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tidyverse/tidyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tidyverse/tidyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/tidyverse/tidyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tidyverse/tidyr/statuses/{sha}","languages_url":"https://api.github.com/repos/tidyverse/tidyr/languages","stargazers_url":"https://api.github.com/repos/tidyverse/tidyr/stargazers","contributors_url":"https://api.github.com/repos/tidyverse/tidyr/contributors","subscribers_url":"https://api.github.com/repos/tidyverse/tidyr/subscribers","subscription_url":"https://api.github.com/repos/tidyverse/tidyr/subscription","commits_url":"https://api.github.com/repos/tidyverse/tidyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/tidyverse/tidyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/tidyverse/tidyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/tidyverse/tidyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/tidyverse/tidyr/contents/{+path}","compare_url":"https://api.github.com/repos/tidyverse/tidyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tidyverse/tidyr/merges","archive_url":"https://api.github.com/repos/tidyverse/tidyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tidyverse/tidyr/downloads","issues_url":"https://api.github.com/repos/tidyverse/tidyr/issues{/number}","pulls_url":"https://api.github.com/repos/tidyverse/tidyr/pulls{/number}","milestones_url":"https://api.github.com/repos/tidyverse/tidyr/milestones{/number}","notifications_url":"https://api.github.com/repos/tidyverse/tidyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tidyverse/tidyr/labels{/name}","releases_url":"https://api.github.com/repos/tidyverse/tidyr/releases{/id}","deployments_url":"https://api.github.com/repos/tidyverse/tidyr/deployments","created_at":"2014-06-10T14:24:33Z","updated_at":"2019-01-04T14:55:41Z","pushed_at":"2019-01-01T10:14:53Z","git_url":"git://github.com/tidyverse/tidyr.git","ssh_url":"git@github.com:tidyverse/tidyr.git","clone_url":"https://github.com/tidyverse/tidyr.git","svn_url":"https://github.com/tidyverse/tidyr","homepage":"tidyr.tidyverse.org","size":3457,"stargazers_count":668,"watchers_count":668,"language":"R","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":254,"mirror_url":null,"archived":false,"open_issues_count":59,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":254,"open_issues":59,"watchers":668,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tidyverse/tidyr/pulls/521"},"html":{"href":"https://github.com/tidyverse/tidyr/pull/521"},"issue":{"href":"https://api.github.com/repos/tidyverse/tidyr/issues/521"},"comments":{"href":"https://api.github.com/repos/tidyverse/tidyr/issues/521/comments"},"review_comments":{"href":"https://api.github.com/repos/tidyverse/tidyr/pulls/521/comments"},"review_comment":{"href":"https://api.github.com/repos/tidyverse/tidyr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tidyverse/tidyr/pulls/521/commits"},"statuses":{"href":"https://api.github.com/repos/tidyverse/tidyr/statuses/f4da88e3d3bdfed708a879c99e14f2f3a1aa63d8"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":5,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"hadley"}}