{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/234675149","pull_request_review_id":176366884,"id":234675149,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDY3NTE0OQ==","diff_hunk":"@@ -102,7 +102,11 @@ func DefaultKubeletConfiguration(internalcfg *kubeadmapi.ClusterConfiguration) {\n \texternalkubeletcfg.ReadOnlyPort = 0\n \n \t// Enables client certificate rotation for the kubelet\n-\texternalkubeletcfg.RotateCertificates = true\n+\tif internalcfg.ComponentConfigs.Kubelet != nil {","path":"cmd/kubeadm/app/componentconfigs/defaults.go","position":5,"original_position":5,"commit_id":"f3d39437066fef8a403b956649512f86e3d59b43","original_commit_id":"f3d39437066fef8a403b956649512f86e3d59b43","user":{"login":"bart0sh","id":13677519,"node_id":"MDQ6VXNlcjEzNjc3NTE5","avatar_url":"https://avatars2.githubusercontent.com/u/13677519?v=4","gravatar_id":"","url":"https://api.github.com/users/bart0sh","html_url":"https://github.com/bart0sh","followers_url":"https://api.github.com/users/bart0sh/followers","following_url":"https://api.github.com/users/bart0sh/following{/other_user}","gists_url":"https://api.github.com/users/bart0sh/gists{/gist_id}","starred_url":"https://api.github.com/users/bart0sh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bart0sh/subscriptions","organizations_url":"https://api.github.com/users/bart0sh/orgs","repos_url":"https://api.github.com/users/bart0sh/repos","events_url":"https://api.github.com/users/bart0sh/events{/privacy}","received_events_url":"https://api.github.com/users/bart0sh/received_events","type":"User","site_admin":false},"body":"from my pov it's more explicit and readable the way I wrote it. However, if other reviewers would prefer this way I'd be happy to change the code.","created_at":"2018-11-19T15:57:13Z","updated_at":"2018-11-19T15:57:13Z","html_url":"https://github.com/kubernetes/kubernetes/pull/71221#discussion_r234675149","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/71221","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/234675149"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/71221#discussion_r234675149"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/71221"}},"in_reply_to_id":234673369},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/71221","id":232015498,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMDE1NDk4","html_url":"https://github.com/kubernetes/kubernetes/pull/71221","diff_url":"https://github.com/kubernetes/kubernetes/pull/71221.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/71221.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71221","number":71221,"state":"open","locked":false,"title":"kubeadm: use rotateCertificates from user config","user":{"login":"bart0sh","id":13677519,"node_id":"MDQ6VXNlcjEzNjc3NTE5","avatar_url":"https://avatars2.githubusercontent.com/u/13677519?v=4","gravatar_id":"","url":"https://api.github.com/users/bart0sh","html_url":"https://github.com/bart0sh","followers_url":"https://api.github.com/users/bart0sh/followers","following_url":"https://api.github.com/users/bart0sh/following{/other_user}","gists_url":"https://api.github.com/users/bart0sh/gists{/gist_id}","starred_url":"https://api.github.com/users/bart0sh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bart0sh/subscriptions","organizations_url":"https://api.github.com/users/bart0sh/orgs","repos_url":"https://api.github.com/users/bart0sh/repos","events_url":"https://api.github.com/users/bart0sh/events{/privacy}","received_events_url":"https://api.github.com/users/bart0sh/received_events","type":"User","site_admin":false},"body":"**What type of PR is this?**\r\n\r\n/kind bug\r\n\r\n**What this PR does / why we need it**:\r\n\r\nKubeadm sets rotateCertificates = true in kubelet config\r\nunconditionally, which makes it impossible for user to change.\r\n\r\nIt's better to use this parameter from the user config if it's set\r\nthere.\r\n\r\n**Which issue(s) this PR fixes** :\r\n\r\nFixes: kubernetes/kubeadm#1252\r\n\r\n**Does this PR introduce a user-facing change?**:\r\n```release-note\r\nkubeadm: override default rotateCertificates parameter from config file provided by user \r\n```","created_at":"2018-11-19T15:34:28Z","updated_at":"2018-11-19T15:57:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a43f0255174abd04ba1c9d01e909503bf9522056","assignee":null,"assignees":[],"requested_reviewers":[{"login":"chuckha","id":98927,"node_id":"MDQ6VXNlcjk4OTI3","avatar_url":"https://avatars0.githubusercontent.com/u/98927?v=4","gravatar_id":"","url":"https://api.github.com/users/chuckha","html_url":"https://github.com/chuckha","followers_url":"https://api.github.com/users/chuckha/followers","following_url":"https://api.github.com/users/chuckha/following{/other_user}","gists_url":"https://api.github.com/users/chuckha/gists{/gist_id}","starred_url":"https://api.github.com/users/chuckha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuckha/subscriptions","organizations_url":"https://api.github.com/users/chuckha/orgs","repos_url":"https://api.github.com/users/chuckha/repos","events_url":"https://api.github.com/users/chuckha/events{/privacy}","received_events_url":"https://api.github.com/users/chuckha/received_events","type":"User","site_admin":false},{"login":"luxas","id":5442475,"node_id":"MDQ6VXNlcjU0NDI0NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/5442475?v=4","gravatar_id":"","url":"https://api.github.com/users/luxas","html_url":"https://github.com/luxas","followers_url":"https://api.github.com/users/luxas/followers","following_url":"https://api.github.com/users/luxas/following{/other_user}","gists_url":"https://api.github.com/users/luxas/gists{/gist_id}","starred_url":"https://api.github.com/users/luxas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luxas/subscriptions","organizations_url":"https://api.github.com/users/luxas/orgs","repos_url":"https://api.github.com/users/luxas/repos","events_url":"https://api.github.com/users/luxas/events{/privacy}","received_events_url":"https://api.github.com/users/luxas/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":451459590,"node_id":"MDU6TGFiZWw0NTE0NTk1OTA=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/kubeadm","name":"area/kubeadm","color":"0052cc","default":false},{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":105146071,"node_id":"MDU6TGFiZWwxMDUxNDYwNzE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/bug","name":"kind/bug","color":"e11d21","default":false},{"id":1111992057,"node_id":"MDU6TGFiZWwxMTExOTkyMDU3","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-priority","name":"needs-priority","color":"ededed","default":false},{"id":200149833,"node_id":"MDU6TGFiZWwyMDAxNDk4MzM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":173494222,"node_id":"MDU6TGFiZWwxNzM0OTQyMjI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/cluster-lifecycle","name":"sig/cluster-lifecycle","color":"d2b48c","default":false},{"id":253450793,"node_id":"MDU6TGFiZWwyNTM0NTA3OTM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XS","name":"size/XS","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/71221/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/71221/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71221/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/f3d39437066fef8a403b956649512f86e3d59b43","head":{"label":"bart0sh:PR0040-kubeadm-1252-override-rotateCertificates-from-config","ref":"PR0040-kubeadm-1252-override-rotateCertificates-from-config","sha":"f3d39437066fef8a403b956649512f86e3d59b43","user":{"login":"bart0sh","id":13677519,"node_id":"MDQ6VXNlcjEzNjc3NTE5","avatar_url":"https://avatars2.githubusercontent.com/u/13677519?v=4","gravatar_id":"","url":"https://api.github.com/users/bart0sh","html_url":"https://github.com/bart0sh","followers_url":"https://api.github.com/users/bart0sh/followers","following_url":"https://api.github.com/users/bart0sh/following{/other_user}","gists_url":"https://api.github.com/users/bart0sh/gists{/gist_id}","starred_url":"https://api.github.com/users/bart0sh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bart0sh/subscriptions","organizations_url":"https://api.github.com/users/bart0sh/orgs","repos_url":"https://api.github.com/users/bart0sh/repos","events_url":"https://api.github.com/users/bart0sh/events{/privacy}","received_events_url":"https://api.github.com/users/bart0sh/received_events","type":"User","site_admin":false},"repo":{"id":118890473,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg4OTA0NzM=","name":"kubernetes","full_name":"bart0sh/kubernetes","private":false,"owner":{"login":"bart0sh","id":13677519,"node_id":"MDQ6VXNlcjEzNjc3NTE5","avatar_url":"https://avatars2.githubusercontent.com/u/13677519?v=4","gravatar_id":"","url":"https://api.github.com/users/bart0sh","html_url":"https://github.com/bart0sh","followers_url":"https://api.github.com/users/bart0sh/followers","following_url":"https://api.github.com/users/bart0sh/following{/other_user}","gists_url":"https://api.github.com/users/bart0sh/gists{/gist_id}","starred_url":"https://api.github.com/users/bart0sh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bart0sh/subscriptions","organizations_url":"https://api.github.com/users/bart0sh/orgs","repos_url":"https://api.github.com/users/bart0sh/repos","events_url":"https://api.github.com/users/bart0sh/events{/privacy}","received_events_url":"https://api.github.com/users/bart0sh/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bart0sh/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/bart0sh/kubernetes","forks_url":"https://api.github.com/repos/bart0sh/kubernetes/forks","keys_url":"https://api.github.com/repos/bart0sh/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bart0sh/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bart0sh/kubernetes/teams","hooks_url":"https://api.github.com/repos/bart0sh/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/bart0sh/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/bart0sh/kubernetes/events","assignees_url":"https://api.github.com/repos/bart0sh/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/bart0sh/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/bart0sh/kubernetes/tags","blobs_url":"https://api.github.com/repos/bart0sh/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bart0sh/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bart0sh/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/bart0sh/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bart0sh/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/bart0sh/kubernetes/languages","stargazers_url":"https://api.github.com/repos/bart0sh/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/bart0sh/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/bart0sh/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/bart0sh/kubernetes/subscription","commits_url":"https://api.github.com/repos/bart0sh/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/bart0sh/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/bart0sh/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/bart0sh/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/bart0sh/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/bart0sh/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bart0sh/kubernetes/merges","archive_url":"https://api.github.com/repos/bart0sh/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bart0sh/kubernetes/downloads","issues_url":"https://api.github.com/repos/bart0sh/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/bart0sh/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/bart0sh/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/bart0sh/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bart0sh/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/bart0sh/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/bart0sh/kubernetes/deployments","created_at":"2018-01-25T09:16:35Z","updated_at":"2018-04-11T13:09:45Z","pushed_at":"2018-11-19T15:29:13Z","git_url":"git://github.com/bart0sh/kubernetes.git","ssh_url":"git@github.com:bart0sh/kubernetes.git","clone_url":"https://github.com/bart0sh/kubernetes.git","svn_url":"https://github.com/bart0sh/kubernetes","homepage":"http://kubernetes.io","size":588112,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"none"}},"base":{"label":"kubernetes:master","ref":"master","sha":"f7b9b669e5f18777f6a723d9d3055ffabadf070a","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4MDQ5OA==","name":"kubernetes","full_name":"kubernetes/kubernetes","private":false,"owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-11-19T15:13:52Z","pushed_at":"2018-11-19T15:54:57Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"https://kubernetes.io","size":815953,"stargazers_count":44016,"watchers_count":44016,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15295,"mirror_url":null,"archived":false,"open_issues_count":3134,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":15295,"open_issues":3134,"watchers":44016,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/71221"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/71221"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/71221"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/71221/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/71221/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/71221/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/f3d39437066fef8a403b956649512f86e3d59b43"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bart0sh"}}