{"action":"created","issue":{"url":"https://api.github.com/repos/Pulse-Eight/platform/issues/38","repository_url":"https://api.github.com/repos/Pulse-Eight/platform","labels_url":"https://api.github.com/repos/Pulse-Eight/platform/issues/38/labels{/name}","comments_url":"https://api.github.com/repos/Pulse-Eight/platform/issues/38/comments","events_url":"https://api.github.com/repos/Pulse-Eight/platform/issues/38/events","html_url":"https://github.com/Pulse-Eight/platform/pull/38","id":364920689,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4OTkyNTAx","number":38,"title":"Make resulting cmake config relocatable","user":{"login":"bachp","id":333807,"node_id":"MDQ6VXNlcjMzMzgwNw==","avatar_url":"https://avatars1.githubusercontent.com/u/333807?v=4","gravatar_id":"","url":"https://api.github.com/users/bachp","html_url":"https://github.com/bachp","followers_url":"https://api.github.com/users/bachp/followers","following_url":"https://api.github.com/users/bachp/following{/other_user}","gists_url":"https://api.github.com/users/bachp/gists{/gist_id}","starred_url":"https://api.github.com/users/bachp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bachp/subscriptions","organizations_url":"https://api.github.com/users/bachp/orgs","repos_url":"https://api.github.com/users/bachp/repos","events_url":"https://api.github.com/users/bachp/events{/privacy}","received_events_url":"https://api.github.com/users/bachp/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-09-28T14:45:44Z","updated_at":"2018-11-02T15:19:36Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Pulse-Eight/platform/pulls/38","html_url":"https://github.com/Pulse-Eight/platform/pull/38","diff_url":"https://github.com/Pulse-Eight/platform/pull/38.diff","patch_url":"https://github.com/Pulse-Eight/platform/pull/38.patch"},"body":"This change avoids hardcoded install prefix in the p8-platform-config.cmake.\r\nEspecially important when doing cross compilation with Yocto for example."},"comment":{"url":"https://api.github.com/repos/Pulse-Eight/platform/issues/comments/435414564","html_url":"https://github.com/Pulse-Eight/platform/pull/38#issuecomment-435414564","issue_url":"https://api.github.com/repos/Pulse-Eight/platform/issues/38","id":435414564,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTQxNDU2NA==","user":{"login":"opdenkamp","id":441806,"node_id":"MDQ6VXNlcjQ0MTgwNg==","avatar_url":"https://avatars0.githubusercontent.com/u/441806?v=4","gravatar_id":"","url":"https://api.github.com/users/opdenkamp","html_url":"https://github.com/opdenkamp","followers_url":"https://api.github.com/users/opdenkamp/followers","following_url":"https://api.github.com/users/opdenkamp/following{/other_user}","gists_url":"https://api.github.com/users/opdenkamp/gists{/gist_id}","starred_url":"https://api.github.com/users/opdenkamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opdenkamp/subscriptions","organizations_url":"https://api.github.com/users/opdenkamp/orgs","repos_url":"https://api.github.com/users/opdenkamp/repos","events_url":"https://api.github.com/users/opdenkamp/events{/privacy}","received_events_url":"https://api.github.com/users/opdenkamp/received_events","type":"User","site_admin":false},"created_at":"2018-11-02T15:19:36Z","updated_at":"2018-11-02T15:19:36Z","author_association":"CONTRIBUTOR","body":"I haven't checked cmake's commit history, but the links in the manual to `get_filename_component()` suggest that this has been added in cmake 3.0, so `cmake_minimum_required()` needs to be updated too: https://github.com/Pulse-Eight/platform/blob/2650bb3bd3644784359be373252b0436873ca8cb/CMakeLists.txt#L3\r\n\r\nIt also needs a quick rebase because of https://github.com/Pulse-Eight/platform/commit/b784c047d0bce4f4ec90305ce760718919074337\r\n\r\nthanks"}}
{"actor":{"display_login":"opdenkamp"}}