{"action":"created","comment":{"url":"https://api.github.com/repos/mrdoob/three.js/pulls/comments/205327249","pull_request_review_id":140574354,"id":205327249,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTMyNzI0OQ==","diff_hunk":"@@ -835,5 +849,79 @@ Object3D.prototype = Object.assign( Object.create( EventDispatcher.prototype ),\n \n } );\n \n+function Vector3WithDirtyFlag( x, y, z ) {\n+\n+\tthis._x = 0;\n+\tthis._y = 0;\n+\tthis._z = 0;\n+\n+\tVector3.call( this, x, y, z );\n+\n+\tthis._dirty = false;\n+\n+}\n+\n+Vector3WithDirtyFlag.prototype = Object.assign( Object.create( Vector3.prototype ), {\n+\n+\tconstructor: Vector3WithDirtyFlag,\n+\tisVector3WithDirtyFlag: true\n+\n+} );\n+\n+Object.defineProperties( Vector3WithDirtyFlag.prototype, {\n+\n+\tx: {\n+\n+\t\tget: function () {\n+\n+\t\t\treturn this._x;\n+\n+\t\t},\n+\n+\t\tset: function ( value ) {\n+\n+\t\t\tthis._x = value;\n+\t\t\tthis._dirty = true;\n+\n+\t\t}\n+\n+\t},\n+\n+\ty: {\n+\n+\t\tget: function () {\n+\n+\t\t\treturn this._y;\n+\n+\t\t},\n+\n+\t\tset: function ( value ) {\n+\n+\t\t\tthis._y = value;\n+\t\t\tthis._dirty = true;\n+\n+\t\t}\n+\n+\t},\n+\n+\tz: {\n+\n+\t\tget: function () {\n+\n+\t\t\treturn this._z;\n+\n+\t\t},\n+\n+\t\tset: function ( value ) {\n+\n+\t\t\tthis._z = value;\n+\t\t\tthis._dirty = true;\n+\n+\t\t}\n+\n+\t}\n+\n+} );\n+","path":"src/core/Object3D.js","position":126,"original_position":126,"commit_id":"634c231aa9425d59dc4729f40942c62c59b266e4","original_commit_id":"634c231aa9425d59dc4729f40942c62c59b266e4","user":{"login":"takahirox","id":7637832,"node_id":"MDQ6VXNlcjc2Mzc4MzI=","avatar_url":"https://avatars2.githubusercontent.com/u/7637832?v=4","gravatar_id":"","url":"https://api.github.com/users/takahirox","html_url":"https://github.com/takahirox","followers_url":"https://api.github.com/users/takahirox/followers","following_url":"https://api.github.com/users/takahirox/following{/other_user}","gists_url":"https://api.github.com/users/takahirox/gists{/gist_id}","starred_url":"https://api.github.com/users/takahirox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takahirox/subscriptions","organizations_url":"https://api.github.com/users/takahirox/orgs","repos_url":"https://api.github.com/users/takahirox/repos","events_url":"https://api.github.com/users/takahirox/events{/privacy}","received_events_url":"https://api.github.com/users/takahirox/received_events","type":"User","site_admin":false},"body":"I don't make `QuaternionWithDirtyFlag` yet in this PR because not sure why but somehow using the extension of `Quaternion` seems to lead the bad performance on my Windows Chrome...","created_at":"2018-07-26T04:14:34Z","updated_at":"2018-07-26T04:14:34Z","html_url":"https://github.com/mrdoob/three.js/pull/14543#discussion_r205327249","pull_request_url":"https://api.github.com/repos/mrdoob/three.js/pulls/14543","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/comments/205327249"},"html":{"href":"https://github.com/mrdoob/three.js/pull/14543#discussion_r205327249"},"pull_request":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/14543"}}},"pull_request":{"url":"https://api.github.com/repos/mrdoob/three.js/pulls/14543","id":203730576,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNzMwNTc2","html_url":"https://github.com/mrdoob/three.js/pull/14543","diff_url":"https://github.com/mrdoob/three.js/pull/14543.diff","patch_url":"https://github.com/mrdoob/three.js/pull/14543.patch","issue_url":"https://api.github.com/repos/mrdoob/three.js/issues/14543","number":14543,"state":"open","locked":false,"title":"[WIP] Dirty Flag for updateMatrix optimization","user":{"login":"takahirox","id":7637832,"node_id":"MDQ6VXNlcjc2Mzc4MzI=","avatar_url":"https://avatars2.githubusercontent.com/u/7637832?v=4","gravatar_id":"","url":"https://api.github.com/users/takahirox","html_url":"https://github.com/takahirox","followers_url":"https://api.github.com/users/takahirox/followers","following_url":"https://api.github.com/users/takahirox/following{/other_user}","gists_url":"https://api.github.com/users/takahirox/gists{/gist_id}","starred_url":"https://api.github.com/users/takahirox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takahirox/subscriptions","organizations_url":"https://api.github.com/users/takahirox/orgs","repos_url":"https://api.github.com/users/takahirox/repos","events_url":"https://api.github.com/users/takahirox/events{/privacy}","received_events_url":"https://api.github.com/users/takahirox/received_events","type":"User","site_admin":false},"body":"See #14138 for the discussion and performance gain.\r\n\r\nI still need to update some tests to pass then WIP yet. But you can start to evaluate the performance if you're interested in.","created_at":"2018-07-25T06:07:27Z","updated_at":"2018-07-26T04:14:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8999ae33ae98c08adf30d1cf5129335d477fdd4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mrdoob/three.js/pulls/14543/commits","review_comments_url":"https://api.github.com/repos/mrdoob/three.js/pulls/14543/comments","review_comment_url":"https://api.github.com/repos/mrdoob/three.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mrdoob/three.js/issues/14543/comments","statuses_url":"https://api.github.com/repos/mrdoob/three.js/statuses/634c231aa9425d59dc4729f40942c62c59b266e4","head":{"label":"takahirox:WithDirtyFlag","ref":"WithDirtyFlag","sha":"634c231aa9425d59dc4729f40942c62c59b266e4","user":{"login":"takahirox","id":7637832,"node_id":"MDQ6VXNlcjc2Mzc4MzI=","avatar_url":"https://avatars2.githubusercontent.com/u/7637832?v=4","gravatar_id":"","url":"https://api.github.com/users/takahirox","html_url":"https://github.com/takahirox","followers_url":"https://api.github.com/users/takahirox/followers","following_url":"https://api.github.com/users/takahirox/following{/other_user}","gists_url":"https://api.github.com/users/takahirox/gists{/gist_id}","starred_url":"https://api.github.com/users/takahirox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takahirox/subscriptions","organizations_url":"https://api.github.com/users/takahirox/orgs","repos_url":"https://api.github.com/users/takahirox/repos","events_url":"https://api.github.com/users/takahirox/events{/privacy}","received_events_url":"https://api.github.com/users/takahirox/received_events","type":"User","site_admin":false},"repo":{"id":45166916,"node_id":"MDEwOlJlcG9zaXRvcnk0NTE2NjkxNg==","name":"three.js","full_name":"takahirox/three.js","owner":{"login":"takahirox","id":7637832,"node_id":"MDQ6VXNlcjc2Mzc4MzI=","avatar_url":"https://avatars2.githubusercontent.com/u/7637832?v=4","gravatar_id":"","url":"https://api.github.com/users/takahirox","html_url":"https://github.com/takahirox","followers_url":"https://api.github.com/users/takahirox/followers","following_url":"https://api.github.com/users/takahirox/following{/other_user}","gists_url":"https://api.github.com/users/takahirox/gists{/gist_id}","starred_url":"https://api.github.com/users/takahirox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takahirox/subscriptions","organizations_url":"https://api.github.com/users/takahirox/orgs","repos_url":"https://api.github.com/users/takahirox/repos","events_url":"https://api.github.com/users/takahirox/events{/privacy}","received_events_url":"https://api.github.com/users/takahirox/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/takahirox/three.js","description":"Three.js fork for MMDLoader","fork":true,"url":"https://api.github.com/repos/takahirox/three.js","forks_url":"https://api.github.com/repos/takahirox/three.js/forks","keys_url":"https://api.github.com/repos/takahirox/three.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/takahirox/three.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/takahirox/three.js/teams","hooks_url":"https://api.github.com/repos/takahirox/three.js/hooks","issue_events_url":"https://api.github.com/repos/takahirox/three.js/issues/events{/number}","events_url":"https://api.github.com/repos/takahirox/three.js/events","assignees_url":"https://api.github.com/repos/takahirox/three.js/assignees{/user}","branches_url":"https://api.github.com/repos/takahirox/three.js/branches{/branch}","tags_url":"https://api.github.com/repos/takahirox/three.js/tags","blobs_url":"https://api.github.com/repos/takahirox/three.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/takahirox/three.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/takahirox/three.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/takahirox/three.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/takahirox/three.js/statuses/{sha}","languages_url":"https://api.github.com/repos/takahirox/three.js/languages","stargazers_url":"https://api.github.com/repos/takahirox/three.js/stargazers","contributors_url":"https://api.github.com/repos/takahirox/three.js/contributors","subscribers_url":"https://api.github.com/repos/takahirox/three.js/subscribers","subscription_url":"https://api.github.com/repos/takahirox/three.js/subscription","commits_url":"https://api.github.com/repos/takahirox/three.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/takahirox/three.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/takahirox/three.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/takahirox/three.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/takahirox/three.js/contents/{+path}","compare_url":"https://api.github.com/repos/takahirox/three.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/takahirox/three.js/merges","archive_url":"https://api.github.com/repos/takahirox/three.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/takahirox/three.js/downloads","issues_url":"https://api.github.com/repos/takahirox/three.js/issues{/number}","pulls_url":"https://api.github.com/repos/takahirox/three.js/pulls{/number}","milestones_url":"https://api.github.com/repos/takahirox/three.js/milestones{/number}","notifications_url":"https://api.github.com/repos/takahirox/three.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/takahirox/three.js/labels{/name}","releases_url":"https://api.github.com/repos/takahirox/three.js/releases{/id}","deployments_url":"https://api.github.com/repos/takahirox/three.js/deployments","created_at":"2015-10-29T07:20:39Z","updated_at":"2018-03-27T19:47:23Z","pushed_at":"2018-07-25T13:10:40Z","git_url":"git://github.com/takahirox/three.js.git","ssh_url":"git@github.com:takahirox/three.js.git","clone_url":"https://github.com/takahirox/three.js.git","svn_url":"https://github.com/takahirox/three.js","homepage":"http://takahirox.github.io/three.js/examples/#webgl_loader_mmd","size":723775,"stargazers_count":23,"watchers_count":23,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":0,"watchers":23,"default_branch":"master"}},"base":{"label":"mrdoob:dev","ref":"dev","sha":"d3f6a81ad1d3a07b1f6e6c49a14522aed8466c74","user":{"login":"mrdoob","id":97088,"node_id":"MDQ6VXNlcjk3MDg4","avatar_url":"https://avatars0.githubusercontent.com/u/97088?v=4","gravatar_id":"","url":"https://api.github.com/users/mrdoob","html_url":"https://github.com/mrdoob","followers_url":"https://api.github.com/users/mrdoob/followers","following_url":"https://api.github.com/users/mrdoob/following{/other_user}","gists_url":"https://api.github.com/users/mrdoob/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdoob/subscriptions","organizations_url":"https://api.github.com/users/mrdoob/orgs","repos_url":"https://api.github.com/users/mrdoob/repos","events_url":"https://api.github.com/users/mrdoob/events{/privacy}","received_events_url":"https://api.github.com/users/mrdoob/received_events","type":"User","site_admin":false},"repo":{"id":576201,"node_id":"MDEwOlJlcG9zaXRvcnk1NzYyMDE=","name":"three.js","full_name":"mrdoob/three.js","owner":{"login":"mrdoob","id":97088,"node_id":"MDQ6VXNlcjk3MDg4","avatar_url":"https://avatars0.githubusercontent.com/u/97088?v=4","gravatar_id":"","url":"https://api.github.com/users/mrdoob","html_url":"https://github.com/mrdoob","followers_url":"https://api.github.com/users/mrdoob/followers","following_url":"https://api.github.com/users/mrdoob/following{/other_user}","gists_url":"https://api.github.com/users/mrdoob/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdoob/subscriptions","organizations_url":"https://api.github.com/users/mrdoob/orgs","repos_url":"https://api.github.com/users/mrdoob/repos","events_url":"https://api.github.com/users/mrdoob/events{/privacy}","received_events_url":"https://api.github.com/users/mrdoob/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrdoob/three.js","description":"JavaScript 3D library.","fork":false,"url":"https://api.github.com/repos/mrdoob/three.js","forks_url":"https://api.github.com/repos/mrdoob/three.js/forks","keys_url":"https://api.github.com/repos/mrdoob/three.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrdoob/three.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrdoob/three.js/teams","hooks_url":"https://api.github.com/repos/mrdoob/three.js/hooks","issue_events_url":"https://api.github.com/repos/mrdoob/three.js/issues/events{/number}","events_url":"https://api.github.com/repos/mrdoob/three.js/events","assignees_url":"https://api.github.com/repos/mrdoob/three.js/assignees{/user}","branches_url":"https://api.github.com/repos/mrdoob/three.js/branches{/branch}","tags_url":"https://api.github.com/repos/mrdoob/three.js/tags","blobs_url":"https://api.github.com/repos/mrdoob/three.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrdoob/three.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrdoob/three.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrdoob/three.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrdoob/three.js/statuses/{sha}","languages_url":"https://api.github.com/repos/mrdoob/three.js/languages","stargazers_url":"https://api.github.com/repos/mrdoob/three.js/stargazers","contributors_url":"https://api.github.com/repos/mrdoob/three.js/contributors","subscribers_url":"https://api.github.com/repos/mrdoob/three.js/subscribers","subscription_url":"https://api.github.com/repos/mrdoob/three.js/subscription","commits_url":"https://api.github.com/repos/mrdoob/three.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrdoob/three.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrdoob/three.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrdoob/three.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrdoob/three.js/contents/{+path}","compare_url":"https://api.github.com/repos/mrdoob/three.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrdoob/three.js/merges","archive_url":"https://api.github.com/repos/mrdoob/three.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrdoob/three.js/downloads","issues_url":"https://api.github.com/repos/mrdoob/three.js/issues{/number}","pulls_url":"https://api.github.com/repos/mrdoob/three.js/pulls{/number}","milestones_url":"https://api.github.com/repos/mrdoob/three.js/milestones{/number}","notifications_url":"https://api.github.com/repos/mrdoob/three.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrdoob/three.js/labels{/name}","releases_url":"https://api.github.com/repos/mrdoob/three.js/releases{/id}","deployments_url":"https://api.github.com/repos/mrdoob/three.js/deployments","created_at":"2010-03-23T18:58:01Z","updated_at":"2018-07-26T03:45:43Z","pushed_at":"2018-07-26T03:30:56Z","git_url":"git://github.com/mrdoob/three.js.git","ssh_url":"git@github.com:mrdoob/three.js.git","clone_url":"https://github.com/mrdoob/three.js.git","svn_url":"https://github.com/mrdoob/three.js","homepage":"https://threejs.org/","size":646595,"stargazers_count":43517,"watchers_count":43517,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":16422,"mirror_url":null,"archived":false,"open_issues_count":747,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":16422,"open_issues":747,"watchers":43517,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/14543"},"html":{"href":"https://github.com/mrdoob/three.js/pull/14543"},"issue":{"href":"https://api.github.com/repos/mrdoob/three.js/issues/14543"},"comments":{"href":"https://api.github.com/repos/mrdoob/three.js/issues/14543/comments"},"review_comments":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/14543/comments"},"review_comment":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/14543/commits"},"statuses":{"href":"https://api.github.com/repos/mrdoob/three.js/statuses/634c231aa9425d59dc4729f40942c62c59b266e4"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"takahirox"}}