{"action":"created","comment":{"url":"https://api.github.com/repos/skydive-project/skydive/pulls/comments/235490406","pull_request_review_id":177368827,"id":235490406,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTQ5MDQwNg==","diff_hunk":"@@ -107,6 +117,25 @@ func createRootNode(g *graph.Graph) (*graph.Node, error) {\n \n \tm.SetField(\"CPU\", cpus)\n \n+        // Gets NUMA topology details\n+        numaInfo, err := numautils.GetNumaTopology()","path":"agent/host.go","position":29,"original_position":29,"commit_id":"ac3127217bcb663ac420580bf912666d0018e5b9","original_commit_id":"ac3127217bcb663ac420580bf912666d0018e5b9","user":{"login":"Jaganathancse","id":19686263,"node_id":"MDQ6VXNlcjE5Njg2MjYz","avatar_url":"https://avatars2.githubusercontent.com/u/19686263?v=4","gravatar_id":"","url":"https://api.github.com/users/Jaganathancse","html_url":"https://github.com/Jaganathancse","followers_url":"https://api.github.com/users/Jaganathancse/followers","following_url":"https://api.github.com/users/Jaganathancse/following{/other_user}","gists_url":"https://api.github.com/users/Jaganathancse/gists{/gist_id}","starred_url":"https://api.github.com/users/Jaganathancse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jaganathancse/subscriptions","organizations_url":"https://api.github.com/users/Jaganathancse/orgs","repos_url":"https://api.github.com/users/Jaganathancse/repos","events_url":"https://api.github.com/users/Jaganathancse/events{/privacy}","received_events_url":"https://api.github.com/users/Jaganathancse/received_events","type":"User","site_admin":false},"body":"Currently numautils library supports only RHEL, fedora and centos, and also not tested in other env's.\r\nSo Planning to add metadata only if no error in function call numautils.GetNumaTopology().\r\nThis change also avoids the creating issue in skydive code for unsupported env's. is this fine?","created_at":"2018-11-21T18:03:36Z","updated_at":"2018-11-21T18:03:36Z","html_url":"https://github.com/skydive-project/skydive/pull/1459#discussion_r235490406","pull_request_url":"https://api.github.com/repos/skydive-project/skydive/pulls/1459","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/skydive-project/skydive/pulls/comments/235490406"},"html":{"href":"https://github.com/skydive-project/skydive/pull/1459#discussion_r235490406"},"pull_request":{"href":"https://api.github.com/repos/skydive-project/skydive/pulls/1459"}},"in_reply_to_id":232989633},"pull_request":{"url":"https://api.github.com/repos/skydive-project/skydive/pulls/1459","id":230427790,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNDI3Nzkw","html_url":"https://github.com/skydive-project/skydive/pull/1459","diff_url":"https://github.com/skydive-project/skydive/pull/1459.diff","patch_url":"https://github.com/skydive-project/skydive/pull/1459.patch","issue_url":"https://api.github.com/repos/skydive-project/skydive/issues/1459","number":1459,"state":"open","locked":false,"title":"Adds NUMA topology details for host","user":{"login":"Jaganathancse","id":19686263,"node_id":"MDQ6VXNlcjE5Njg2MjYz","avatar_url":"https://avatars2.githubusercontent.com/u/19686263?v=4","gravatar_id":"","url":"https://api.github.com/users/Jaganathancse","html_url":"https://github.com/Jaganathancse","followers_url":"https://api.github.com/users/Jaganathancse/followers","following_url":"https://api.github.com/users/Jaganathancse/following{/other_user}","gists_url":"https://api.github.com/users/Jaganathancse/gists{/gist_id}","starred_url":"https://api.github.com/users/Jaganathancse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jaganathancse/subscriptions","organizations_url":"https://api.github.com/users/Jaganathancse/orgs","repos_url":"https://api.github.com/users/Jaganathancse/repos","events_url":"https://api.github.com/users/Jaganathancse/events{/privacy}","received_events_url":"https://api.github.com/users/Jaganathancse/received_events","type":"User","site_admin":false},"body":"Displays NUMA topology details like RAM, CPU Cores, thread siblings\r\nand NICs data for each NUMA node.","created_at":"2018-11-13T10:47:33Z","updated_at":"2018-11-21T18:03:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2daaa55593603d0cbb4cdf56616a6e46fdefb903","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/skydive-project/skydive/pulls/1459/commits","review_comments_url":"https://api.github.com/repos/skydive-project/skydive/pulls/1459/comments","review_comment_url":"https://api.github.com/repos/skydive-project/skydive/pulls/comments{/number}","comments_url":"https://api.github.com/repos/skydive-project/skydive/issues/1459/comments","statuses_url":"https://api.github.com/repos/skydive-project/skydive/statuses/ac3127217bcb663ac420580bf912666d0018e5b9","head":{"label":"Jaganathancse:numa-topology-details","ref":"numa-topology-details","sha":"ac3127217bcb663ac420580bf912666d0018e5b9","user":{"login":"Jaganathancse","id":19686263,"node_id":"MDQ6VXNlcjE5Njg2MjYz","avatar_url":"https://avatars2.githubusercontent.com/u/19686263?v=4","gravatar_id":"","url":"https://api.github.com/users/Jaganathancse","html_url":"https://github.com/Jaganathancse","followers_url":"https://api.github.com/users/Jaganathancse/followers","following_url":"https://api.github.com/users/Jaganathancse/following{/other_user}","gists_url":"https://api.github.com/users/Jaganathancse/gists{/gist_id}","starred_url":"https://api.github.com/users/Jaganathancse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jaganathancse/subscriptions","organizations_url":"https://api.github.com/users/Jaganathancse/orgs","repos_url":"https://api.github.com/users/Jaganathancse/repos","events_url":"https://api.github.com/users/Jaganathancse/events{/privacy}","received_events_url":"https://api.github.com/users/Jaganathancse/received_events","type":"User","site_admin":false},"repo":{"id":157362052,"node_id":"MDEwOlJlcG9zaXRvcnkxNTczNjIwNTI=","name":"skydive","full_name":"Jaganathancse/skydive","private":false,"owner":{"login":"Jaganathancse","id":19686263,"node_id":"MDQ6VXNlcjE5Njg2MjYz","avatar_url":"https://avatars2.githubusercontent.com/u/19686263?v=4","gravatar_id":"","url":"https://api.github.com/users/Jaganathancse","html_url":"https://github.com/Jaganathancse","followers_url":"https://api.github.com/users/Jaganathancse/followers","following_url":"https://api.github.com/users/Jaganathancse/following{/other_user}","gists_url":"https://api.github.com/users/Jaganathancse/gists{/gist_id}","starred_url":"https://api.github.com/users/Jaganathancse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jaganathancse/subscriptions","organizations_url":"https://api.github.com/users/Jaganathancse/orgs","repos_url":"https://api.github.com/users/Jaganathancse/repos","events_url":"https://api.github.com/users/Jaganathancse/events{/privacy}","received_events_url":"https://api.github.com/users/Jaganathancse/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Jaganathancse/skydive","description":"An open source real-time network topology and protocols analyzer","fork":true,"url":"https://api.github.com/repos/Jaganathancse/skydive","forks_url":"https://api.github.com/repos/Jaganathancse/skydive/forks","keys_url":"https://api.github.com/repos/Jaganathancse/skydive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jaganathancse/skydive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jaganathancse/skydive/teams","hooks_url":"https://api.github.com/repos/Jaganathancse/skydive/hooks","issue_events_url":"https://api.github.com/repos/Jaganathancse/skydive/issues/events{/number}","events_url":"https://api.github.com/repos/Jaganathancse/skydive/events","assignees_url":"https://api.github.com/repos/Jaganathancse/skydive/assignees{/user}","branches_url":"https://api.github.com/repos/Jaganathancse/skydive/branches{/branch}","tags_url":"https://api.github.com/repos/Jaganathancse/skydive/tags","blobs_url":"https://api.github.com/repos/Jaganathancse/skydive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jaganathancse/skydive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jaganathancse/skydive/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jaganathancse/skydive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jaganathancse/skydive/statuses/{sha}","languages_url":"https://api.github.com/repos/Jaganathancse/skydive/languages","stargazers_url":"https://api.github.com/repos/Jaganathancse/skydive/stargazers","contributors_url":"https://api.github.com/repos/Jaganathancse/skydive/contributors","subscribers_url":"https://api.github.com/repos/Jaganathancse/skydive/subscribers","subscription_url":"https://api.github.com/repos/Jaganathancse/skydive/subscription","commits_url":"https://api.github.com/repos/Jaganathancse/skydive/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jaganathancse/skydive/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jaganathancse/skydive/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jaganathancse/skydive/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jaganathancse/skydive/contents/{+path}","compare_url":"https://api.github.com/repos/Jaganathancse/skydive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jaganathancse/skydive/merges","archive_url":"https://api.github.com/repos/Jaganathancse/skydive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jaganathancse/skydive/downloads","issues_url":"https://api.github.com/repos/Jaganathancse/skydive/issues{/number}","pulls_url":"https://api.github.com/repos/Jaganathancse/skydive/pulls{/number}","milestones_url":"https://api.github.com/repos/Jaganathancse/skydive/milestones{/number}","notifications_url":"https://api.github.com/repos/Jaganathancse/skydive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jaganathancse/skydive/labels{/name}","releases_url":"https://api.github.com/repos/Jaganathancse/skydive/releases{/id}","deployments_url":"https://api.github.com/repos/Jaganathancse/skydive/deployments","created_at":"2018-11-13T10:26:49Z","updated_at":"2018-11-13T10:26:53Z","pushed_at":"2018-11-13T13:29:08Z","git_url":"git://github.com/Jaganathancse/skydive.git","ssh_url":"git@github.com:Jaganathancse/skydive.git","clone_url":"https://github.com/Jaganathancse/skydive.git","svn_url":"https://github.com/Jaganathancse/skydive","homepage":"","size":38788,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"skydive-project:master","ref":"master","sha":"02b360c62c084074d68e6743ff32d61b0e5adb7d","user":{"login":"skydive-project","id":19912486,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTEyNDg2","avatar_url":"https://avatars0.githubusercontent.com/u/19912486?v=4","gravatar_id":"","url":"https://api.github.com/users/skydive-project","html_url":"https://github.com/skydive-project","followers_url":"https://api.github.com/users/skydive-project/followers","following_url":"https://api.github.com/users/skydive-project/following{/other_user}","gists_url":"https://api.github.com/users/skydive-project/gists{/gist_id}","starred_url":"https://api.github.com/users/skydive-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skydive-project/subscriptions","organizations_url":"https://api.github.com/users/skydive-project/orgs","repos_url":"https://api.github.com/users/skydive-project/repos","events_url":"https://api.github.com/users/skydive-project/events{/privacy}","received_events_url":"https://api.github.com/users/skydive-project/received_events","type":"Organization","site_admin":false},"repo":{"id":44610195,"node_id":"MDEwOlJlcG9zaXRvcnk0NDYxMDE5NQ==","name":"skydive","full_name":"skydive-project/skydive","private":false,"owner":{"login":"skydive-project","id":19912486,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTEyNDg2","avatar_url":"https://avatars0.githubusercontent.com/u/19912486?v=4","gravatar_id":"","url":"https://api.github.com/users/skydive-project","html_url":"https://github.com/skydive-project","followers_url":"https://api.github.com/users/skydive-project/followers","following_url":"https://api.github.com/users/skydive-project/following{/other_user}","gists_url":"https://api.github.com/users/skydive-project/gists{/gist_id}","starred_url":"https://api.github.com/users/skydive-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skydive-project/subscriptions","organizations_url":"https://api.github.com/users/skydive-project/orgs","repos_url":"https://api.github.com/users/skydive-project/repos","events_url":"https://api.github.com/users/skydive-project/events{/privacy}","received_events_url":"https://api.github.com/users/skydive-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/skydive-project/skydive","description":"An open source real-time network topology and protocols analyzer","fork":false,"url":"https://api.github.com/repos/skydive-project/skydive","forks_url":"https://api.github.com/repos/skydive-project/skydive/forks","keys_url":"https://api.github.com/repos/skydive-project/skydive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skydive-project/skydive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skydive-project/skydive/teams","hooks_url":"https://api.github.com/repos/skydive-project/skydive/hooks","issue_events_url":"https://api.github.com/repos/skydive-project/skydive/issues/events{/number}","events_url":"https://api.github.com/repos/skydive-project/skydive/events","assignees_url":"https://api.github.com/repos/skydive-project/skydive/assignees{/user}","branches_url":"https://api.github.com/repos/skydive-project/skydive/branches{/branch}","tags_url":"https://api.github.com/repos/skydive-project/skydive/tags","blobs_url":"https://api.github.com/repos/skydive-project/skydive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skydive-project/skydive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skydive-project/skydive/git/refs{/sha}","trees_url":"https://api.github.com/repos/skydive-project/skydive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skydive-project/skydive/statuses/{sha}","languages_url":"https://api.github.com/repos/skydive-project/skydive/languages","stargazers_url":"https://api.github.com/repos/skydive-project/skydive/stargazers","contributors_url":"https://api.github.com/repos/skydive-project/skydive/contributors","subscribers_url":"https://api.github.com/repos/skydive-project/skydive/subscribers","subscription_url":"https://api.github.com/repos/skydive-project/skydive/subscription","commits_url":"https://api.github.com/repos/skydive-project/skydive/commits{/sha}","git_commits_url":"https://api.github.com/repos/skydive-project/skydive/git/commits{/sha}","comments_url":"https://api.github.com/repos/skydive-project/skydive/comments{/number}","issue_comment_url":"https://api.github.com/repos/skydive-project/skydive/issues/comments{/number}","contents_url":"https://api.github.com/repos/skydive-project/skydive/contents/{+path}","compare_url":"https://api.github.com/repos/skydive-project/skydive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skydive-project/skydive/merges","archive_url":"https://api.github.com/repos/skydive-project/skydive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skydive-project/skydive/downloads","issues_url":"https://api.github.com/repos/skydive-project/skydive/issues{/number}","pulls_url":"https://api.github.com/repos/skydive-project/skydive/pulls{/number}","milestones_url":"https://api.github.com/repos/skydive-project/skydive/milestones{/number}","notifications_url":"https://api.github.com/repos/skydive-project/skydive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skydive-project/skydive/labels{/name}","releases_url":"https://api.github.com/repos/skydive-project/skydive/releases{/id}","deployments_url":"https://api.github.com/repos/skydive-project/skydive/deployments","created_at":"2015-10-20T14:02:21Z","updated_at":"2018-11-21T16:10:01Z","pushed_at":"2018-11-21T17:54:53Z","git_url":"git://github.com/skydive-project/skydive.git","ssh_url":"git@github.com:skydive-project/skydive.git","clone_url":"https://github.com/skydive-project/skydive.git","svn_url":"https://github.com/skydive-project/skydive","homepage":"","size":38822,"stargazers_count":898,"watchers_count":898,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":192,"mirror_url":null,"archived":false,"open_issues_count":121,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":192,"open_issues":121,"watchers":898,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/skydive-project/skydive/pulls/1459"},"html":{"href":"https://github.com/skydive-project/skydive/pull/1459"},"issue":{"href":"https://api.github.com/repos/skydive-project/skydive/issues/1459"},"comments":{"href":"https://api.github.com/repos/skydive-project/skydive/issues/1459/comments"},"review_comments":{"href":"https://api.github.com/repos/skydive-project/skydive/pulls/1459/comments"},"review_comment":{"href":"https://api.github.com/repos/skydive-project/skydive/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/skydive-project/skydive/pulls/1459/commits"},"statuses":{"href":"https://api.github.com/repos/skydive-project/skydive/statuses/ac3127217bcb663ac420580bf912666d0018e5b9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Jaganathancse"}}