{"action":"created","issue":{"url":"https://api.github.com/repos/vtest/VTest/issues/1","repository_url":"https://api.github.com/repos/vtest/VTest","labels_url":"https://api.github.com/repos/vtest/VTest/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/vtest/VTest/issues/1/comments","events_url":"https://api.github.com/repos/vtest/VTest/issues/1/events","html_url":"https://github.com/vtest/VTest/pull/1","id":372628804,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NzYxNDM0","number":1,"title":"Porting the build system to meson","user":{"login":"gquintard","id":3776553,"node_id":"MDQ6VXNlcjM3NzY1NTM=","avatar_url":"https://avatars1.githubusercontent.com/u/3776553?v=4","gravatar_id":"","url":"https://api.github.com/users/gquintard","html_url":"https://github.com/gquintard","followers_url":"https://api.github.com/users/gquintard/followers","following_url":"https://api.github.com/users/gquintard/following{/other_user}","gists_url":"https://api.github.com/users/gquintard/gists{/gist_id}","starred_url":"https://api.github.com/users/gquintard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gquintard/subscriptions","organizations_url":"https://api.github.com/users/gquintard/orgs","repos_url":"https://api.github.com/users/gquintard/repos","events_url":"https://api.github.com/users/gquintard/events{/privacy}","received_events_url":"https://api.github.com/users/gquintard/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-22T17:58:22Z","updated_at":"2018-11-19T17:29:26Z","closed_at":"2018-11-19T17:29:26Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/vtest/VTest/pulls/1","html_url":"https://github.com/vtest/VTest/pull/1","diff_url":"https://github.com/vtest/VTest/pull/1.diff","patch_url":"https://github.com/vtest/VTest/pull/1.patch"},"body":"I'd like to get some feedback on this.\r\n\r\nI spend a couple of hours this week-end writing the necessary bits to have meson build VTest to see how good it was. Answer is: not bad at all. Here are a few (subjective) highlights:\r\n- only two steps: ``meson builddir`` to set things up, then ``ninja -C builddir`` to build\r\n- you can edit build definitions (the ``meson.build`` file, think of it as a Makefile), and ninja will know about it an rebuild what's needed\r\n- easy things are easy, hard stuff seems possible\r\n- damn fast\r\n- readable build definitions\r\n- out-of-tree builds\r\n\r\nI'm obviously using VTest as a sandbox to gather intel, and possibly move varnish to it, and since it's a bigger project, I'd like to make sure I don't work in vain. Possible hurdles:\r\n- meson+ninja availability on *BSD\r\n- it's a new language, people will need to adapt\r\n- our build system is so messed up that meson can't do it, but I highly doubt that\r\n\r\nThere are three commits here:\r\n- move the scripts to the root to please meson (I adapted the Makefile too)\r\n- add meson.build\r\n- implement conditional building in case we don't have ``libvarnishapi`` (that one trips the make system though, I added a few ifdefs and didn't care about the Makefile)"},"comment":{"url":"https://api.github.com/repos/vtest/VTest/issues/comments/439975775","html_url":"https://github.com/vtest/VTest/pull/1#issuecomment-439975775","issue_url":"https://api.github.com/repos/vtest/VTest/issues/1","id":439975775,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTk3NTc3NQ==","user":{"login":"gquintard","id":3776553,"node_id":"MDQ6VXNlcjM3NzY1NTM=","avatar_url":"https://avatars1.githubusercontent.com/u/3776553?v=4","gravatar_id":"","url":"https://api.github.com/users/gquintard","html_url":"https://github.com/gquintard","followers_url":"https://api.github.com/users/gquintard/followers","following_url":"https://api.github.com/users/gquintard/following{/other_user}","gists_url":"https://api.github.com/users/gquintard/gists{/gist_id}","starred_url":"https://api.github.com/users/gquintard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gquintard/subscriptions","organizations_url":"https://api.github.com/users/gquintard/orgs","repos_url":"https://api.github.com/users/gquintard/repos","events_url":"https://api.github.com/users/gquintard/events{/privacy}","received_events_url":"https://api.github.com/users/gquintard/received_events","type":"User","site_admin":false},"created_at":"2018-11-19T17:29:26Z","updated_at":"2018-11-19T17:29:26Z","author_association":"NONE","body":"fair enough"}}
{"actor":{"display_login":"gquintard"}}