{"action":"created","comment":{"url":"https://api.github.com/repos/python-lz4/python-lz4/pulls/comments/191268777","pull_request_review_id":123806680,"id":191268777,"diff_hunk":"@@ -321,13 +344,15 @@ decompress (PyObject * Py_UNUSED (self), PyObject * args, PyObject * kwargs)\n   Py_BEGIN_ALLOW_THREADS\n \n   output_size =\n-    LZ4_decompress_safe (source_start, dest, source_size, dest_size);\n+    LZ4_decompress_safe_usingDict (source_start, dest, source_size, dest_size,\n+\t\t\t\t   dict.buf, dict.len);\n \n   Py_END_ALLOW_THREADS\n \n   PyBuffer_Release(&source);\n+  PyBuffer_Release(&dict);\n \n-  if (output_size < 0)\n+  if ((ssize_t)output_size < 0)\n     {","path":"lz4/block/_block.c","position":181,"original_position":181,"commit_id":"f848a34629faa6dbf554bc94d367343eb30ceccf","original_commit_id":"f848a34629faa6dbf554bc94d367343eb30ceccf","user":{"login":"jonathanunderwood","id":992114,"avatar_url":"https://avatars2.githubusercontent.com/u/992114?v=4","gravatar_id":"","url":"https://api.github.com/users/jonathanunderwood","html_url":"https://github.com/jonathanunderwood","followers_url":"https://api.github.com/users/jonathanunderwood/followers","following_url":"https://api.github.com/users/jonathanunderwood/following{/other_user}","gists_url":"https://api.github.com/users/jonathanunderwood/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanunderwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanunderwood/subscriptions","organizations_url":"https://api.github.com/users/jonathanunderwood/orgs","repos_url":"https://api.github.com/users/jonathanunderwood/repos","events_url":"https://api.github.com/users/jonathanunderwood/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanunderwood/received_events","type":"User","site_admin":false},"body":"Ditto.","created_at":"2018-05-28T20:30:40Z","updated_at":"2018-05-28T20:32:58Z","html_url":"https://github.com/python-lz4/python-lz4/pull/128#discussion_r191268777","pull_request_url":"https://api.github.com/repos/python-lz4/python-lz4/pulls/128","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/python-lz4/python-lz4/pulls/comments/191268777"},"html":{"href":"https://github.com/python-lz4/python-lz4/pull/128#discussion_r191268777"},"pull_request":{"href":"https://api.github.com/repos/python-lz4/python-lz4/pulls/128"}}},"pull_request":{"url":"https://api.github.com/repos/python-lz4/python-lz4/pulls/128","id":190722555,"html_url":"https://github.com/python-lz4/python-lz4/pull/128","diff_url":"https://github.com/python-lz4/python-lz4/pull/128.diff","patch_url":"https://github.com/python-lz4/python-lz4/pull/128.patch","issue_url":"https://api.github.com/repos/python-lz4/python-lz4/issues/128","number":128,"state":"open","locked":false,"title":"Dictionary support","user":{"login":"mkuyper","id":24314779,"avatar_url":"https://avatars0.githubusercontent.com/u/24314779?v=4","gravatar_id":"","url":"https://api.github.com/users/mkuyper","html_url":"https://github.com/mkuyper","followers_url":"https://api.github.com/users/mkuyper/followers","following_url":"https://api.github.com/users/mkuyper/following{/other_user}","gists_url":"https://api.github.com/users/mkuyper/gists{/gist_id}","starred_url":"https://api.github.com/users/mkuyper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkuyper/subscriptions","organizations_url":"https://api.github.com/users/mkuyper/orgs","repos_url":"https://api.github.com/users/mkuyper/repos","events_url":"https://api.github.com/users/mkuyper/events{/privacy}","received_events_url":"https://api.github.com/users/mkuyper/received_events","type":"User","site_admin":false},"body":"This adds support for pre-loading a dictionary prior to block compression and decompression by optionally passing in a dictionary to the respective functions.\r\n\r\nFor compression, using a dictionary requires using `LZ4_resetStream()`/`LZ4_loadDict()`/`LZ4_compress_continue()` instead of the more convenient `LZ4_compress_*() functions` . I've unified the code paths for both cases, so that the convenience methods are no longer used even if there is no dictionary to be used.\r\n\r\nFor decompression, there is a `LZ4_decompress_safe_usingDict()` variant that could be used directly.","created_at":"2018-05-26T03:00:08Z","updated_at":"2018-05-28T20:32:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"32698fbebd96c0302b39725f5a38f017ca0e20fd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/python-lz4/python-lz4/pulls/128/commits","review_comments_url":"https://api.github.com/repos/python-lz4/python-lz4/pulls/128/comments","review_comment_url":"https://api.github.com/repos/python-lz4/python-lz4/pulls/comments{/number}","comments_url":"https://api.github.com/repos/python-lz4/python-lz4/issues/128/comments","statuses_url":"https://api.github.com/repos/python-lz4/python-lz4/statuses/f848a34629faa6dbf554bc94d367343eb30ceccf","head":{"label":"TrackNet:f-dictionary","ref":"f-dictionary","sha":"f848a34629faa6dbf554bc94d367343eb30ceccf","user":{"login":"TrackNet","id":24890713,"avatar_url":"https://avatars1.githubusercontent.com/u/24890713?v=4","gravatar_id":"","url":"https://api.github.com/users/TrackNet","html_url":"https://github.com/TrackNet","followers_url":"https://api.github.com/users/TrackNet/followers","following_url":"https://api.github.com/users/TrackNet/following{/other_user}","gists_url":"https://api.github.com/users/TrackNet/gists{/gist_id}","starred_url":"https://api.github.com/users/TrackNet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrackNet/subscriptions","organizations_url":"https://api.github.com/users/TrackNet/orgs","repos_url":"https://api.github.com/users/TrackNet/repos","events_url":"https://api.github.com/users/TrackNet/events{/privacy}","received_events_url":"https://api.github.com/users/TrackNet/received_events","type":"Organization","site_admin":false},"repo":{"id":134735377,"name":"python-lz4","full_name":"TrackNet/python-lz4","owner":{"login":"TrackNet","id":24890713,"avatar_url":"https://avatars1.githubusercontent.com/u/24890713?v=4","gravatar_id":"","url":"https://api.github.com/users/TrackNet","html_url":"https://github.com/TrackNet","followers_url":"https://api.github.com/users/TrackNet/followers","following_url":"https://api.github.com/users/TrackNet/following{/other_user}","gists_url":"https://api.github.com/users/TrackNet/gists{/gist_id}","starred_url":"https://api.github.com/users/TrackNet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrackNet/subscriptions","organizations_url":"https://api.github.com/users/TrackNet/orgs","repos_url":"https://api.github.com/users/TrackNet/repos","events_url":"https://api.github.com/users/TrackNet/events{/privacy}","received_events_url":"https://api.github.com/users/TrackNet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TrackNet/python-lz4","description":"LZ4 bindings for Python","fork":true,"url":"https://api.github.com/repos/TrackNet/python-lz4","forks_url":"https://api.github.com/repos/TrackNet/python-lz4/forks","keys_url":"https://api.github.com/repos/TrackNet/python-lz4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TrackNet/python-lz4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TrackNet/python-lz4/teams","hooks_url":"https://api.github.com/repos/TrackNet/python-lz4/hooks","issue_events_url":"https://api.github.com/repos/TrackNet/python-lz4/issues/events{/number}","events_url":"https://api.github.com/repos/TrackNet/python-lz4/events","assignees_url":"https://api.github.com/repos/TrackNet/python-lz4/assignees{/user}","branches_url":"https://api.github.com/repos/TrackNet/python-lz4/branches{/branch}","tags_url":"https://api.github.com/repos/TrackNet/python-lz4/tags","blobs_url":"https://api.github.com/repos/TrackNet/python-lz4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TrackNet/python-lz4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TrackNet/python-lz4/git/refs{/sha}","trees_url":"https://api.github.com/repos/TrackNet/python-lz4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TrackNet/python-lz4/statuses/{sha}","languages_url":"https://api.github.com/repos/TrackNet/python-lz4/languages","stargazers_url":"https://api.github.com/repos/TrackNet/python-lz4/stargazers","contributors_url":"https://api.github.com/repos/TrackNet/python-lz4/contributors","subscribers_url":"https://api.github.com/repos/TrackNet/python-lz4/subscribers","subscription_url":"https://api.github.com/repos/TrackNet/python-lz4/subscription","commits_url":"https://api.github.com/repos/TrackNet/python-lz4/commits{/sha}","git_commits_url":"https://api.github.com/repos/TrackNet/python-lz4/git/commits{/sha}","comments_url":"https://api.github.com/repos/TrackNet/python-lz4/comments{/number}","issue_comment_url":"https://api.github.com/repos/TrackNet/python-lz4/issues/comments{/number}","contents_url":"https://api.github.com/repos/TrackNet/python-lz4/contents/{+path}","compare_url":"https://api.github.com/repos/TrackNet/python-lz4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TrackNet/python-lz4/merges","archive_url":"https://api.github.com/repos/TrackNet/python-lz4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TrackNet/python-lz4/downloads","issues_url":"https://api.github.com/repos/TrackNet/python-lz4/issues{/number}","pulls_url":"https://api.github.com/repos/TrackNet/python-lz4/pulls{/number}","milestones_url":"https://api.github.com/repos/TrackNet/python-lz4/milestones{/number}","notifications_url":"https://api.github.com/repos/TrackNet/python-lz4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TrackNet/python-lz4/labels{/name}","releases_url":"https://api.github.com/repos/TrackNet/python-lz4/releases{/id}","deployments_url":"https://api.github.com/repos/TrackNet/python-lz4/deployments","created_at":"2018-05-24T15:33:04Z","updated_at":"2018-05-24T15:33:06Z","pushed_at":"2018-05-28T17:21:48Z","git_url":"git://github.com/TrackNet/python-lz4.git","ssh_url":"git@github.com:TrackNet/python-lz4.git","clone_url":"https://github.com/TrackNet/python-lz4.git","svn_url":"https://github.com/TrackNet/python-lz4","homepage":null,"size":922,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"python-lz4:development","ref":"development","sha":"1ef8262af40609925ee6d0a858cb608fe60fee28","user":{"login":"python-lz4","id":18689658,"avatar_url":"https://avatars2.githubusercontent.com/u/18689658?v=4","gravatar_id":"","url":"https://api.github.com/users/python-lz4","html_url":"https://github.com/python-lz4","followers_url":"https://api.github.com/users/python-lz4/followers","following_url":"https://api.github.com/users/python-lz4/following{/other_user}","gists_url":"https://api.github.com/users/python-lz4/gists{/gist_id}","starred_url":"https://api.github.com/users/python-lz4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-lz4/subscriptions","organizations_url":"https://api.github.com/users/python-lz4/orgs","repos_url":"https://api.github.com/users/python-lz4/repos","events_url":"https://api.github.com/users/python-lz4/events{/privacy}","received_events_url":"https://api.github.com/users/python-lz4/received_events","type":"Organization","site_admin":false},"repo":{"id":57201963,"name":"python-lz4","full_name":"python-lz4/python-lz4","owner":{"login":"python-lz4","id":18689658,"avatar_url":"https://avatars2.githubusercontent.com/u/18689658?v=4","gravatar_id":"","url":"https://api.github.com/users/python-lz4","html_url":"https://github.com/python-lz4","followers_url":"https://api.github.com/users/python-lz4/followers","following_url":"https://api.github.com/users/python-lz4/following{/other_user}","gists_url":"https://api.github.com/users/python-lz4/gists{/gist_id}","starred_url":"https://api.github.com/users/python-lz4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-lz4/subscriptions","organizations_url":"https://api.github.com/users/python-lz4/orgs","repos_url":"https://api.github.com/users/python-lz4/repos","events_url":"https://api.github.com/users/python-lz4/events{/privacy}","received_events_url":"https://api.github.com/users/python-lz4/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/python-lz4/python-lz4","description":"LZ4 bindings for Python","fork":false,"url":"https://api.github.com/repos/python-lz4/python-lz4","forks_url":"https://api.github.com/repos/python-lz4/python-lz4/forks","keys_url":"https://api.github.com/repos/python-lz4/python-lz4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python-lz4/python-lz4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python-lz4/python-lz4/teams","hooks_url":"https://api.github.com/repos/python-lz4/python-lz4/hooks","issue_events_url":"https://api.github.com/repos/python-lz4/python-lz4/issues/events{/number}","events_url":"https://api.github.com/repos/python-lz4/python-lz4/events","assignees_url":"https://api.github.com/repos/python-lz4/python-lz4/assignees{/user}","branches_url":"https://api.github.com/repos/python-lz4/python-lz4/branches{/branch}","tags_url":"https://api.github.com/repos/python-lz4/python-lz4/tags","blobs_url":"https://api.github.com/repos/python-lz4/python-lz4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python-lz4/python-lz4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python-lz4/python-lz4/git/refs{/sha}","trees_url":"https://api.github.com/repos/python-lz4/python-lz4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python-lz4/python-lz4/statuses/{sha}","languages_url":"https://api.github.com/repos/python-lz4/python-lz4/languages","stargazers_url":"https://api.github.com/repos/python-lz4/python-lz4/stargazers","contributors_url":"https://api.github.com/repos/python-lz4/python-lz4/contributors","subscribers_url":"https://api.github.com/repos/python-lz4/python-lz4/subscribers","subscription_url":"https://api.github.com/repos/python-lz4/python-lz4/subscription","commits_url":"https://api.github.com/repos/python-lz4/python-lz4/commits{/sha}","git_commits_url":"https://api.github.com/repos/python-lz4/python-lz4/git/commits{/sha}","comments_url":"https://api.github.com/repos/python-lz4/python-lz4/comments{/number}","issue_comment_url":"https://api.github.com/repos/python-lz4/python-lz4/issues/comments{/number}","contents_url":"https://api.github.com/repos/python-lz4/python-lz4/contents/{+path}","compare_url":"https://api.github.com/repos/python-lz4/python-lz4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python-lz4/python-lz4/merges","archive_url":"https://api.github.com/repos/python-lz4/python-lz4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python-lz4/python-lz4/downloads","issues_url":"https://api.github.com/repos/python-lz4/python-lz4/issues{/number}","pulls_url":"https://api.github.com/repos/python-lz4/python-lz4/pulls{/number}","milestones_url":"https://api.github.com/repos/python-lz4/python-lz4/milestones{/number}","notifications_url":"https://api.github.com/repos/python-lz4/python-lz4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python-lz4/python-lz4/labels{/name}","releases_url":"https://api.github.com/repos/python-lz4/python-lz4/releases{/id}","deployments_url":"https://api.github.com/repos/python-lz4/python-lz4/deployments","created_at":"2016-04-27T09:39:00Z","updated_at":"2018-05-06T04:00:25Z","pushed_at":"2018-05-28T17:21:49Z","git_url":"git://github.com/python-lz4/python-lz4.git","ssh_url":"git@github.com:python-lz4/python-lz4.git","clone_url":"https://github.com/python-lz4/python-lz4.git","svn_url":"https://github.com/python-lz4/python-lz4","homepage":null,"size":917,"stargazers_count":53,"watchers_count":53,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":20,"open_issues":5,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python-lz4/python-lz4/pulls/128"},"html":{"href":"https://github.com/python-lz4/python-lz4/pull/128"},"issue":{"href":"https://api.github.com/repos/python-lz4/python-lz4/issues/128"},"comments":{"href":"https://api.github.com/repos/python-lz4/python-lz4/issues/128/comments"},"review_comments":{"href":"https://api.github.com/repos/python-lz4/python-lz4/pulls/128/comments"},"review_comment":{"href":"https://api.github.com/repos/python-lz4/python-lz4/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/python-lz4/python-lz4/pulls/128/commits"},"statuses":{"href":"https://api.github.com/repos/python-lz4/python-lz4/statuses/f848a34629faa6dbf554bc94d367343eb30ceccf"}},"author_association":"NONE"}}
{"actor":{"display_login":"jonathanunderwood"}}