{"action":"created","comment":{"url":"https://api.github.com/repos/ufo-kit/ufo-filters/pulls/comments/171604171","pull_request_review_id":100486092,"id":171604171,"diff_hunk":"@@ -48,16 +78,31 @@ ufo_reduce_task_setup (UfoTask *task,\n                        UfoResources *resources,\n                        GError **error)\n {\n+    GValue *local_size_gvalue;\n+    UfoReduceTaskPrivate *priv = UFO_REDUCE_TASK_GET_PRIVATE (task);\n+    UfoGpuNode *node = UFO_GPU_NODE (ufo_task_node_get_proc_node (UFO_TASK_NODE (task)));\n+    local_size_gvalue = ufo_gpu_node_get_info (node, UFO_GPU_NODE_INFO_MAX_WORK_GROUP_SIZE);\n+    priv->local_size = g_value_get_ulong (local_size_gvalue);\n+    g_value_unset (local_size_gvalue);\n+\n+    priv->result = NULL;\n+    priv->kernel = ufo_resources_get_kernel (resources, \"reductor.cl\",\n+                                             g_strconcat (\"reduce_\", mode_values[priv->mode].value_name, NULL),\n+                                             error);","path":"src/ufo-reduce-task.c","position":71,"original_position":71,"commit_id":"218f281a82f984daa204d64086f3ccc07c6299a1","original_commit_id":"fec9e7ba941535814dcbe408c54d06594999fd0a","user":{"login":"matze","id":115270,"avatar_url":"https://avatars3.githubusercontent.com/u/115270?v=4","gravatar_id":"","url":"https://api.github.com/users/matze","html_url":"https://github.com/matze","followers_url":"https://api.github.com/users/matze/followers","following_url":"https://api.github.com/users/matze/following{/other_user}","gists_url":"https://api.github.com/users/matze/gists{/gist_id}","starred_url":"https://api.github.com/users/matze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matze/subscriptions","organizations_url":"https://api.github.com/users/matze/orgs","repos_url":"https://api.github.com/users/matze/repos","events_url":"https://api.github.com/users/matze/events{/privacy}","received_events_url":"https://api.github.com/users/matze/received_events","type":"User","site_admin":false},"body":"That is clever :clap: !","created_at":"2018-03-01T15:58:07Z","updated_at":"2018-03-01T15:58:07Z","html_url":"https://github.com/ufo-kit/ufo-filters/pull/155#discussion_r171604171","pull_request_url":"https://api.github.com/repos/ufo-kit/ufo-filters/pulls/155","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ufo-kit/ufo-filters/pulls/comments/171604171"},"html":{"href":"https://github.com/ufo-kit/ufo-filters/pull/155#discussion_r171604171"},"pull_request":{"href":"https://api.github.com/repos/ufo-kit/ufo-filters/pulls/155"}}},"pull_request":{"url":"https://api.github.com/repos/ufo-kit/ufo-filters/pulls/155","id":172276073,"html_url":"https://github.com/ufo-kit/ufo-filters/pull/155","diff_url":"https://github.com/ufo-kit/ufo-filters/pull/155.diff","patch_url":"https://github.com/ufo-kit/ufo-filters/pull/155.patch","issue_url":"https://api.github.com/repos/ufo-kit/ufo-filters/issues/155","number":155,"state":"open","locked":false,"title":"Implement reductor task","user":{"login":"tfarago","id":2648829,"avatar_url":"https://avatars1.githubusercontent.com/u/2648829?v=4","gravatar_id":"","url":"https://api.github.com/users/tfarago","html_url":"https://github.com/tfarago","followers_url":"https://api.github.com/users/tfarago/followers","following_url":"https://api.github.com/users/tfarago/following{/other_user}","gists_url":"https://api.github.com/users/tfarago/gists{/gist_id}","starred_url":"https://api.github.com/users/tfarago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tfarago/subscriptions","organizations_url":"https://api.github.com/users/tfarago/orgs","repos_url":"https://api.github.com/users/tfarago/repos","events_url":"https://api.github.com/users/tfarago/events{/privacy}","received_events_url":"https://api.github.com/users/tfarago/received_events","type":"User","site_admin":false},"body":"Here we go, min, max, sum, mean are enough for me for now. I use the metadata because after some thinking I though that would be cleaner than outputting one pixel. And the computed values actually are properties of the data, so, yeah.\r\nI was thinking of implementing also variance but that is a little too much for this task. I would rather create a task *statistics* which can use this task and do their business there. I see something like `ufo-launch dummy-data ! reduce mode=mean ! statistics mode=var ! ...`.\r\nAny remarks?\r\nI know there is the parallel_sum_2d which is very similar, but that's needed by the stitching and I wanted to have this without the need of 2D input data.","created_at":"2018-03-01T15:53:05Z","updated_at":"2018-03-01T15:58:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"237e345997d394cb6cc0953e7d1a223da7493406","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ufo-kit/ufo-filters/pulls/155/commits","review_comments_url":"https://api.github.com/repos/ufo-kit/ufo-filters/pulls/155/comments","review_comment_url":"https://api.github.com/repos/ufo-kit/ufo-filters/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ufo-kit/ufo-filters/issues/155/comments","statuses_url":"https://api.github.com/repos/ufo-kit/ufo-filters/statuses/218f281a82f984daa204d64086f3ccc07c6299a1","head":{"label":"ufo-kit:add-reductor","ref":"add-reductor","sha":"218f281a82f984daa204d64086f3ccc07c6299a1","user":{"login":"ufo-kit","id":4500176,"avatar_url":"https://avatars1.githubusercontent.com/u/4500176?v=4","gravatar_id":"","url":"https://api.github.com/users/ufo-kit","html_url":"https://github.com/ufo-kit","followers_url":"https://api.github.com/users/ufo-kit/followers","following_url":"https://api.github.com/users/ufo-kit/following{/other_user}","gists_url":"https://api.github.com/users/ufo-kit/gists{/gist_id}","starred_url":"https://api.github.com/users/ufo-kit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufo-kit/subscriptions","organizations_url":"https://api.github.com/users/ufo-kit/orgs","repos_url":"https://api.github.com/users/ufo-kit/repos","events_url":"https://api.github.com/users/ufo-kit/events{/privacy}","received_events_url":"https://api.github.com/users/ufo-kit/received_events","type":"Organization","site_admin":false},"repo":{"id":13275361,"name":"ufo-filters","full_name":"ufo-kit/ufo-filters","owner":{"login":"ufo-kit","id":4500176,"avatar_url":"https://avatars1.githubusercontent.com/u/4500176?v=4","gravatar_id":"","url":"https://api.github.com/users/ufo-kit","html_url":"https://github.com/ufo-kit","followers_url":"https://api.github.com/users/ufo-kit/followers","following_url":"https://api.github.com/users/ufo-kit/following{/other_user}","gists_url":"https://api.github.com/users/ufo-kit/gists{/gist_id}","starred_url":"https://api.github.com/users/ufo-kit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufo-kit/subscriptions","organizations_url":"https://api.github.com/users/ufo-kit/orgs","repos_url":"https://api.github.com/users/ufo-kit/repos","events_url":"https://api.github.com/users/ufo-kit/events{/privacy}","received_events_url":"https://api.github.com/users/ufo-kit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ufo-kit/ufo-filters","description":"Common plugin suite for the ufo-core processing framework","fork":false,"url":"https://api.github.com/repos/ufo-kit/ufo-filters","forks_url":"https://api.github.com/repos/ufo-kit/ufo-filters/forks","keys_url":"https://api.github.com/repos/ufo-kit/ufo-filters/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ufo-kit/ufo-filters/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ufo-kit/ufo-filters/teams","hooks_url":"https://api.github.com/repos/ufo-kit/ufo-filters/hooks","issue_events_url":"https://api.github.com/repos/ufo-kit/ufo-filters/issues/events{/number}","events_url":"https://api.github.com/repos/ufo-kit/ufo-filters/events","assignees_url":"https://api.github.com/repos/ufo-kit/ufo-filters/assignees{/user}","branches_url":"https://api.github.com/repos/ufo-kit/ufo-filters/branches{/branch}","tags_url":"https://api.github.com/repos/ufo-kit/ufo-filters/tags","blobs_url":"https://api.github.com/repos/ufo-kit/ufo-filters/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ufo-kit/ufo-filters/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ufo-kit/ufo-filters/git/refs{/sha}","trees_url":"https://api.github.com/repos/ufo-kit/ufo-filters/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ufo-kit/ufo-filters/statuses/{sha}","languages_url":"https://api.github.com/repos/ufo-kit/ufo-filters/languages","stargazers_url":"https://api.github.com/repos/ufo-kit/ufo-filters/stargazers","contributors_url":"https://api.github.com/repos/ufo-kit/ufo-filters/contributors","subscribers_url":"https://api.github.com/repos/ufo-kit/ufo-filters/subscribers","subscription_url":"https://api.github.com/repos/ufo-kit/ufo-filters/subscription","commits_url":"https://api.github.com/repos/ufo-kit/ufo-filters/commits{/sha}","git_commits_url":"https://api.github.com/repos/ufo-kit/ufo-filters/git/commits{/sha}","comments_url":"https://api.github.com/repos/ufo-kit/ufo-filters/comments{/number}","issue_comment_url":"https://api.github.com/repos/ufo-kit/ufo-filters/issues/comments{/number}","contents_url":"https://api.github.com/repos/ufo-kit/ufo-filters/contents/{+path}","compare_url":"https://api.github.com/repos/ufo-kit/ufo-filters/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ufo-kit/ufo-filters/merges","archive_url":"https://api.github.com/repos/ufo-kit/ufo-filters/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ufo-kit/ufo-filters/downloads","issues_url":"https://api.github.com/repos/ufo-kit/ufo-filters/issues{/number}","pulls_url":"https://api.github.com/repos/ufo-kit/ufo-filters/pulls{/number}","milestones_url":"https://api.github.com/repos/ufo-kit/ufo-filters/milestones{/number}","notifications_url":"https://api.github.com/repos/ufo-kit/ufo-filters/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ufo-kit/ufo-filters/labels{/name}","releases_url":"https://api.github.com/repos/ufo-kit/ufo-filters/releases{/id}","deployments_url":"https://api.github.com/repos/ufo-kit/ufo-filters/deployments","created_at":"2013-10-02T15:49:14Z","updated_at":"2016-10-24T09:42:27Z","pushed_at":"2018-03-01T15:53:55Z","git_url":"git://github.com/ufo-kit/ufo-filters.git","ssh_url":"git@github.com:ufo-kit/ufo-filters.git","clone_url":"https://github.com/ufo-kit/ufo-filters.git","svn_url":"https://github.com/ufo-kit/ufo-filters","homepage":null,"size":8290,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":13,"license":null,"forks":11,"open_issues":13,"watchers":3,"default_branch":"master"}},"base":{"label":"ufo-kit:master","ref":"master","sha":"d701b2c11122883321763c7611e0d8a487b41431","user":{"login":"ufo-kit","id":4500176,"avatar_url":"https://avatars1.githubusercontent.com/u/4500176?v=4","gravatar_id":"","url":"https://api.github.com/users/ufo-kit","html_url":"https://github.com/ufo-kit","followers_url":"https://api.github.com/users/ufo-kit/followers","following_url":"https://api.github.com/users/ufo-kit/following{/other_user}","gists_url":"https://api.github.com/users/ufo-kit/gists{/gist_id}","starred_url":"https://api.github.com/users/ufo-kit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufo-kit/subscriptions","organizations_url":"https://api.github.com/users/ufo-kit/orgs","repos_url":"https://api.github.com/users/ufo-kit/repos","events_url":"https://api.github.com/users/ufo-kit/events{/privacy}","received_events_url":"https://api.github.com/users/ufo-kit/received_events","type":"Organization","site_admin":false},"repo":{"id":13275361,"name":"ufo-filters","full_name":"ufo-kit/ufo-filters","owner":{"login":"ufo-kit","id":4500176,"avatar_url":"https://avatars1.githubusercontent.com/u/4500176?v=4","gravatar_id":"","url":"https://api.github.com/users/ufo-kit","html_url":"https://github.com/ufo-kit","followers_url":"https://api.github.com/users/ufo-kit/followers","following_url":"https://api.github.com/users/ufo-kit/following{/other_user}","gists_url":"https://api.github.com/users/ufo-kit/gists{/gist_id}","starred_url":"https://api.github.com/users/ufo-kit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufo-kit/subscriptions","organizations_url":"https://api.github.com/users/ufo-kit/orgs","repos_url":"https://api.github.com/users/ufo-kit/repos","events_url":"https://api.github.com/users/ufo-kit/events{/privacy}","received_events_url":"https://api.github.com/users/ufo-kit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ufo-kit/ufo-filters","description":"Common plugin suite for the ufo-core processing framework","fork":false,"url":"https://api.github.com/repos/ufo-kit/ufo-filters","forks_url":"https://api.github.com/repos/ufo-kit/ufo-filters/forks","keys_url":"https://api.github.com/repos/ufo-kit/ufo-filters/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ufo-kit/ufo-filters/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ufo-kit/ufo-filters/teams","hooks_url":"https://api.github.com/repos/ufo-kit/ufo-filters/hooks","issue_events_url":"https://api.github.com/repos/ufo-kit/ufo-filters/issues/events{/number}","events_url":"https://api.github.com/repos/ufo-kit/ufo-filters/events","assignees_url":"https://api.github.com/repos/ufo-kit/ufo-filters/assignees{/user}","branches_url":"https://api.github.com/repos/ufo-kit/ufo-filters/branches{/branch}","tags_url":"https://api.github.com/repos/ufo-kit/ufo-filters/tags","blobs_url":"https://api.github.com/repos/ufo-kit/ufo-filters/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ufo-kit/ufo-filters/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ufo-kit/ufo-filters/git/refs{/sha}","trees_url":"https://api.github.com/repos/ufo-kit/ufo-filters/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ufo-kit/ufo-filters/statuses/{sha}","languages_url":"https://api.github.com/repos/ufo-kit/ufo-filters/languages","stargazers_url":"https://api.github.com/repos/ufo-kit/ufo-filters/stargazers","contributors_url":"https://api.github.com/repos/ufo-kit/ufo-filters/contributors","subscribers_url":"https://api.github.com/repos/ufo-kit/ufo-filters/subscribers","subscription_url":"https://api.github.com/repos/ufo-kit/ufo-filters/subscription","commits_url":"https://api.github.com/repos/ufo-kit/ufo-filters/commits{/sha}","git_commits_url":"https://api.github.com/repos/ufo-kit/ufo-filters/git/commits{/sha}","comments_url":"https://api.github.com/repos/ufo-kit/ufo-filters/comments{/number}","issue_comment_url":"https://api.github.com/repos/ufo-kit/ufo-filters/issues/comments{/number}","contents_url":"https://api.github.com/repos/ufo-kit/ufo-filters/contents/{+path}","compare_url":"https://api.github.com/repos/ufo-kit/ufo-filters/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ufo-kit/ufo-filters/merges","archive_url":"https://api.github.com/repos/ufo-kit/ufo-filters/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ufo-kit/ufo-filters/downloads","issues_url":"https://api.github.com/repos/ufo-kit/ufo-filters/issues{/number}","pulls_url":"https://api.github.com/repos/ufo-kit/ufo-filters/pulls{/number}","milestones_url":"https://api.github.com/repos/ufo-kit/ufo-filters/milestones{/number}","notifications_url":"https://api.github.com/repos/ufo-kit/ufo-filters/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ufo-kit/ufo-filters/labels{/name}","releases_url":"https://api.github.com/repos/ufo-kit/ufo-filters/releases{/id}","deployments_url":"https://api.github.com/repos/ufo-kit/ufo-filters/deployments","created_at":"2013-10-02T15:49:14Z","updated_at":"2016-10-24T09:42:27Z","pushed_at":"2018-03-01T15:53:55Z","git_url":"git://github.com/ufo-kit/ufo-filters.git","ssh_url":"git@github.com:ufo-kit/ufo-filters.git","clone_url":"https://github.com/ufo-kit/ufo-filters.git","svn_url":"https://github.com/ufo-kit/ufo-filters","homepage":null,"size":8290,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":13,"license":null,"forks":11,"open_issues":13,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ufo-kit/ufo-filters/pulls/155"},"html":{"href":"https://github.com/ufo-kit/ufo-filters/pull/155"},"issue":{"href":"https://api.github.com/repos/ufo-kit/ufo-filters/issues/155"},"comments":{"href":"https://api.github.com/repos/ufo-kit/ufo-filters/issues/155/comments"},"review_comments":{"href":"https://api.github.com/repos/ufo-kit/ufo-filters/pulls/155/comments"},"review_comment":{"href":"https://api.github.com/repos/ufo-kit/ufo-filters/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ufo-kit/ufo-filters/pulls/155/commits"},"statuses":{"href":"https://api.github.com/repos/ufo-kit/ufo-filters/statuses/218f281a82f984daa204d64086f3ccc07c6299a1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"matze"}}