{"action":"created","comment":{"url":"https://api.github.com/repos/PowerShell/PowerShell/pulls/comments/202791087","pull_request_review_id":137556314,"id":202791087,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjc5MTA4Nw==","diff_hunk":"@@ -834,6 +834,19 @@ internal void AddToCompatiblePSEditions(string psEdition)\n             _compatiblePSEditions.Add(psEdition);\n         }\n \n+        internal void AddToCompatiblePSEditions(IEnumerable<string> psEditions)\n+        {\n+            _compatiblePSEditions.AddRange(psEditions);\n+        }\n+\n+        /// <summary>\n+        /// Describes whether the module was considered compatible at load time.\n+        /// Any module not on the System32 module path should have this as true.\n+        /// Modules loaded from the System32 module path will have this as true if they\n+        /// have declared edition compatibility with PowerShell Core.\n+        /// </summary>\n+        internal bool IsConsideredEditionCompatible { get; set; } = true;","path":"src/System.Management.Automation/engine/Modules/PSModuleInfo.cs","position":null,"original_position":15,"commit_id":"87a6c3266fd527ab25bebb283c85be2974a12d5e","original_commit_id":"90eb1d0db2bbe87bbaa251b7aa20b0d406f4e3b8","user":{"login":"daxian-dbw","id":127450,"node_id":"MDQ6VXNlcjEyNzQ1MA==","avatar_url":"https://avatars2.githubusercontent.com/u/127450?v=4","gravatar_id":"","url":"https://api.github.com/users/daxian-dbw","html_url":"https://github.com/daxian-dbw","followers_url":"https://api.github.com/users/daxian-dbw/followers","following_url":"https://api.github.com/users/daxian-dbw/following{/other_user}","gists_url":"https://api.github.com/users/daxian-dbw/gists{/gist_id}","starred_url":"https://api.github.com/users/daxian-dbw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daxian-dbw/subscriptions","organizations_url":"https://api.github.com/users/daxian-dbw/orgs","repos_url":"https://api.github.com/users/daxian-dbw/repos","events_url":"https://api.github.com/users/daxian-dbw/events{/privacy}","received_events_url":"https://api.github.com/users/daxian-dbw/received_events","type":"User","site_admin":false},"body":"Please open an issue tracking this.","created_at":"2018-07-16T19:08:56Z","updated_at":"2018-07-16T19:08:56Z","html_url":"https://github.com/PowerShell/PowerShell/pull/7183#discussion_r202791087","pull_request_url":"https://api.github.com/repos/PowerShell/PowerShell/pulls/7183","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/PowerShell/PowerShell/pulls/comments/202791087"},"html":{"href":"https://github.com/PowerShell/PowerShell/pull/7183#discussion_r202791087"},"pull_request":{"href":"https://api.github.com/repos/PowerShell/PowerShell/pulls/7183"}},"in_reply_to_id":202487888},"pull_request":{"url":"https://api.github.com/repos/PowerShell/PowerShell/pulls/7183","id":197504726,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NTA0NzI2","html_url":"https://github.com/PowerShell/PowerShell/pull/7183","diff_url":"https://github.com/PowerShell/PowerShell/pull/7183.diff","patch_url":"https://github.com/PowerShell/PowerShell/pull/7183.patch","issue_url":"https://api.github.com/repos/PowerShell/PowerShell/issues/7183","number":7183,"state":"open","locked":false,"title":"Check CompatiblePSEditions manifest field for modules loaded from Windows PowerShell $PSHOME","user":{"login":"rjmholt","id":7009879,"node_id":"MDQ6VXNlcjcwMDk4Nzk=","avatar_url":"https://avatars1.githubusercontent.com/u/7009879?v=4","gravatar_id":"","url":"https://api.github.com/users/rjmholt","html_url":"https://github.com/rjmholt","followers_url":"https://api.github.com/users/rjmholt/followers","following_url":"https://api.github.com/users/rjmholt/following{/other_user}","gists_url":"https://api.github.com/users/rjmholt/gists{/gist_id}","starred_url":"https://api.github.com/users/rjmholt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjmholt/subscriptions","organizations_url":"https://api.github.com/users/rjmholt/orgs","repos_url":"https://api.github.com/users/rjmholt/repos","events_url":"https://api.github.com/users/rjmholt/events{/privacy}","received_events_url":"https://api.github.com/users/rjmholt/received_events","type":"User","site_admin":false},"body":"## PR Summary\r\n\r\nResolves #6992, #6991, #6990. Also see https://github.com/PowerShell/PowerShell-RFC/pull/130.\r\n\r\n* Add `%WINDIR%\\System32\\WindowsPowerShell\\v1.0\\Modules` (Windows PowerShell $PSHOME) to the end of the default PSCore 6 module path (i.e. the module path as initially set at startup).\r\n* Cause an error to be thrown by `Import-Module` when a module with `CompatiblePSEditions` not containing `\"Core\"` is processed from Windows PowerShell $PSHOME.\r\n* Suppress output of modules listed by `Get-Module -ListAvailable` from Windows PowerShell $PSHOME when `CompatiblePSEditions` does not contain `\"Core\"`.\r\n* Introduce the `-SkipCompatibilityCheck` switch parameter on both `Import-Module` and `Get-Module` to respectively allow importing incompatible modules and listing incompatible modules.\r\n* Adds a  `PSEdition` column to the `Get-Module -ListAvailable` format\r\n* Ensures that completions are not given for incompatible modules on the System32 module path\r\n\r\n## PR Checklist\r\n\r\n- [x] [PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)\r\n    - Use the present tense and imperative mood when describing your changes\r\n- [x] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)\r\n- [ ] [Change is not breaking](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes)\r\n- [x] [Make sure all `.h`, `.cpp`, `.cs`, `.ps1` and `.psm1` files have the correct copyright header](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)\r\n- [x] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress).\r\n    - If the PR is work in progress, please add the prefix `WIP:` to the beginning of the title and remove the prefix when the PR is ready.\r\n- **User-facing changes**\r\n    - [ ] Not Applicable\r\n    - **OR**\r\n    - [x] User-facing [Documentation needed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)\r\n        - [ ] Issue filed - Issue link:\r\n- **Testing - New and feature**\r\n    - [ ] Not Applicable or can only be tested interactively\r\n    - **OR**\r\n    - [x] [Make sure you've added a new test if existing tests do not effectively test the code changed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting)\r\n        - [x] [Add `[feature]` if the change is significant or affects feature tests](https://github.com/PowerShell/PowerShell/blob/master/docs/testing-guidelines/testing-guidelines.md#requesting-additional-tests-for-a-pr)\r\n","created_at":"2018-06-26T17:56:56Z","updated_at":"2018-07-16T19:08:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"038056cd7b6fa9d43ba1808e16153678d33a5b0c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PowerShell/PowerShell/pulls/7183/commits","review_comments_url":"https://api.github.com/repos/PowerShell/PowerShell/pulls/7183/comments","review_comment_url":"https://api.github.com/repos/PowerShell/PowerShell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PowerShell/PowerShell/issues/7183/comments","statuses_url":"https://api.github.com/repos/PowerShell/PowerShell/statuses/87a6c3266fd527ab25bebb283c85be2974a12d5e","head":{"label":"rjmholt:respect-compatiblepseditions-system32","ref":"respect-compatiblepseditions-system32","sha":"87a6c3266fd527ab25bebb283c85be2974a12d5e","user":{"login":"rjmholt","id":7009879,"node_id":"MDQ6VXNlcjcwMDk4Nzk=","avatar_url":"https://avatars1.githubusercontent.com/u/7009879?v=4","gravatar_id":"","url":"https://api.github.com/users/rjmholt","html_url":"https://github.com/rjmholt","followers_url":"https://api.github.com/users/rjmholt/followers","following_url":"https://api.github.com/users/rjmholt/following{/other_user}","gists_url":"https://api.github.com/users/rjmholt/gists{/gist_id}","starred_url":"https://api.github.com/users/rjmholt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjmholt/subscriptions","organizations_url":"https://api.github.com/users/rjmholt/orgs","repos_url":"https://api.github.com/users/rjmholt/repos","events_url":"https://api.github.com/users/rjmholt/events{/privacy}","received_events_url":"https://api.github.com/users/rjmholt/received_events","type":"User","site_admin":false},"repo":{"id":76306290,"node_id":"MDEwOlJlcG9zaXRvcnk3NjMwNjI5MA==","name":"PowerShell","full_name":"rjmholt/PowerShell","owner":{"login":"rjmholt","id":7009879,"node_id":"MDQ6VXNlcjcwMDk4Nzk=","avatar_url":"https://avatars1.githubusercontent.com/u/7009879?v=4","gravatar_id":"","url":"https://api.github.com/users/rjmholt","html_url":"https://github.com/rjmholt","followers_url":"https://api.github.com/users/rjmholt/followers","following_url":"https://api.github.com/users/rjmholt/following{/other_user}","gists_url":"https://api.github.com/users/rjmholt/gists{/gist_id}","starred_url":"https://api.github.com/users/rjmholt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjmholt/subscriptions","organizations_url":"https://api.github.com/users/rjmholt/orgs","repos_url":"https://api.github.com/users/rjmholt/repos","events_url":"https://api.github.com/users/rjmholt/events{/privacy}","received_events_url":"https://api.github.com/users/rjmholt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rjmholt/PowerShell","description":"PowerShell for every system!","fork":true,"url":"https://api.github.com/repos/rjmholt/PowerShell","forks_url":"https://api.github.com/repos/rjmholt/PowerShell/forks","keys_url":"https://api.github.com/repos/rjmholt/PowerShell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rjmholt/PowerShell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rjmholt/PowerShell/teams","hooks_url":"https://api.github.com/repos/rjmholt/PowerShell/hooks","issue_events_url":"https://api.github.com/repos/rjmholt/PowerShell/issues/events{/number}","events_url":"https://api.github.com/repos/rjmholt/PowerShell/events","assignees_url":"https://api.github.com/repos/rjmholt/PowerShell/assignees{/user}","branches_url":"https://api.github.com/repos/rjmholt/PowerShell/branches{/branch}","tags_url":"https://api.github.com/repos/rjmholt/PowerShell/tags","blobs_url":"https://api.github.com/repos/rjmholt/PowerShell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rjmholt/PowerShell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rjmholt/PowerShell/git/refs{/sha}","trees_url":"https://api.github.com/repos/rjmholt/PowerShell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rjmholt/PowerShell/statuses/{sha}","languages_url":"https://api.github.com/repos/rjmholt/PowerShell/languages","stargazers_url":"https://api.github.com/repos/rjmholt/PowerShell/stargazers","contributors_url":"https://api.github.com/repos/rjmholt/PowerShell/contributors","subscribers_url":"https://api.github.com/repos/rjmholt/PowerShell/subscribers","subscription_url":"https://api.github.com/repos/rjmholt/PowerShell/subscription","commits_url":"https://api.github.com/repos/rjmholt/PowerShell/commits{/sha}","git_commits_url":"https://api.github.com/repos/rjmholt/PowerShell/git/commits{/sha}","comments_url":"https://api.github.com/repos/rjmholt/PowerShell/comments{/number}","issue_comment_url":"https://api.github.com/repos/rjmholt/PowerShell/issues/comments{/number}","contents_url":"https://api.github.com/repos/rjmholt/PowerShell/contents/{+path}","compare_url":"https://api.github.com/repos/rjmholt/PowerShell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rjmholt/PowerShell/merges","archive_url":"https://api.github.com/repos/rjmholt/PowerShell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rjmholt/PowerShell/downloads","issues_url":"https://api.github.com/repos/rjmholt/PowerShell/issues{/number}","pulls_url":"https://api.github.com/repos/rjmholt/PowerShell/pulls{/number}","milestones_url":"https://api.github.com/repos/rjmholt/PowerShell/milestones{/number}","notifications_url":"https://api.github.com/repos/rjmholt/PowerShell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rjmholt/PowerShell/labels{/name}","releases_url":"https://api.github.com/repos/rjmholt/PowerShell/releases{/id}","deployments_url":"https://api.github.com/repos/rjmholt/PowerShell/deployments","created_at":"2016-12-13T00:03:05Z","updated_at":"2018-07-09T18:52:54Z","pushed_at":"2018-07-15T20:29:06Z","git_url":"git://github.com/rjmholt/PowerShell.git","ssh_url":"git@github.com:rjmholt/PowerShell.git","clone_url":"https://github.com/rjmholt/PowerShell.git","svn_url":"https://github.com/rjmholt/PowerShell","homepage":"https://microsoft.com/powershell","size":40494,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PowerShell:master","ref":"master","sha":"7ba4d65a4230b5242ba22e71b3ccfe75ceb2e57d","user":{"login":"PowerShell","id":11524380,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTI0Mzgw","avatar_url":"https://avatars3.githubusercontent.com/u/11524380?v=4","gravatar_id":"","url":"https://api.github.com/users/PowerShell","html_url":"https://github.com/PowerShell","followers_url":"https://api.github.com/users/PowerShell/followers","following_url":"https://api.github.com/users/PowerShell/following{/other_user}","gists_url":"https://api.github.com/users/PowerShell/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerShell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerShell/subscriptions","organizations_url":"https://api.github.com/users/PowerShell/orgs","repos_url":"https://api.github.com/users/PowerShell/repos","events_url":"https://api.github.com/users/PowerShell/events{/privacy}","received_events_url":"https://api.github.com/users/PowerShell/received_events","type":"Organization","site_admin":false},"repo":{"id":49609581,"node_id":"MDEwOlJlcG9zaXRvcnk0OTYwOTU4MQ==","name":"PowerShell","full_name":"PowerShell/PowerShell","owner":{"login":"PowerShell","id":11524380,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTI0Mzgw","avatar_url":"https://avatars3.githubusercontent.com/u/11524380?v=4","gravatar_id":"","url":"https://api.github.com/users/PowerShell","html_url":"https://github.com/PowerShell","followers_url":"https://api.github.com/users/PowerShell/followers","following_url":"https://api.github.com/users/PowerShell/following{/other_user}","gists_url":"https://api.github.com/users/PowerShell/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerShell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerShell/subscriptions","organizations_url":"https://api.github.com/users/PowerShell/orgs","repos_url":"https://api.github.com/users/PowerShell/repos","events_url":"https://api.github.com/users/PowerShell/events{/privacy}","received_events_url":"https://api.github.com/users/PowerShell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PowerShell/PowerShell","description":"PowerShell for every system!","fork":false,"url":"https://api.github.com/repos/PowerShell/PowerShell","forks_url":"https://api.github.com/repos/PowerShell/PowerShell/forks","keys_url":"https://api.github.com/repos/PowerShell/PowerShell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PowerShell/PowerShell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PowerShell/PowerShell/teams","hooks_url":"https://api.github.com/repos/PowerShell/PowerShell/hooks","issue_events_url":"https://api.github.com/repos/PowerShell/PowerShell/issues/events{/number}","events_url":"https://api.github.com/repos/PowerShell/PowerShell/events","assignees_url":"https://api.github.com/repos/PowerShell/PowerShell/assignees{/user}","branches_url":"https://api.github.com/repos/PowerShell/PowerShell/branches{/branch}","tags_url":"https://api.github.com/repos/PowerShell/PowerShell/tags","blobs_url":"https://api.github.com/repos/PowerShell/PowerShell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PowerShell/PowerShell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PowerShell/PowerShell/git/refs{/sha}","trees_url":"https://api.github.com/repos/PowerShell/PowerShell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PowerShell/PowerShell/statuses/{sha}","languages_url":"https://api.github.com/repos/PowerShell/PowerShell/languages","stargazers_url":"https://api.github.com/repos/PowerShell/PowerShell/stargazers","contributors_url":"https://api.github.com/repos/PowerShell/PowerShell/contributors","subscribers_url":"https://api.github.com/repos/PowerShell/PowerShell/subscribers","subscription_url":"https://api.github.com/repos/PowerShell/PowerShell/subscription","commits_url":"https://api.github.com/repos/PowerShell/PowerShell/commits{/sha}","git_commits_url":"https://api.github.com/repos/PowerShell/PowerShell/git/commits{/sha}","comments_url":"https://api.github.com/repos/PowerShell/PowerShell/comments{/number}","issue_comment_url":"https://api.github.com/repos/PowerShell/PowerShell/issues/comments{/number}","contents_url":"https://api.github.com/repos/PowerShell/PowerShell/contents/{+path}","compare_url":"https://api.github.com/repos/PowerShell/PowerShell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PowerShell/PowerShell/merges","archive_url":"https://api.github.com/repos/PowerShell/PowerShell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PowerShell/PowerShell/downloads","issues_url":"https://api.github.com/repos/PowerShell/PowerShell/issues{/number}","pulls_url":"https://api.github.com/repos/PowerShell/PowerShell/pulls{/number}","milestones_url":"https://api.github.com/repos/PowerShell/PowerShell/milestones{/number}","notifications_url":"https://api.github.com/repos/PowerShell/PowerShell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PowerShell/PowerShell/labels{/name}","releases_url":"https://api.github.com/repos/PowerShell/PowerShell/releases{/id}","deployments_url":"https://api.github.com/repos/PowerShell/PowerShell/deployments","created_at":"2016-01-13T23:41:35Z","updated_at":"2018-07-16T18:45:40Z","pushed_at":"2018-07-16T18:45:33Z","git_url":"git://github.com/PowerShell/PowerShell.git","ssh_url":"git@github.com:PowerShell/PowerShell.git","clone_url":"https://github.com/PowerShell/PowerShell.git","svn_url":"https://github.com/PowerShell/PowerShell","homepage":"https://microsoft.com/powershell","size":40850,"stargazers_count":10710,"watchers_count":10710,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1656,"mirror_url":null,"archived":false,"open_issues_count":1531,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1656,"open_issues":1531,"watchers":10710,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PowerShell/PowerShell/pulls/7183"},"html":{"href":"https://github.com/PowerShell/PowerShell/pull/7183"},"issue":{"href":"https://api.github.com/repos/PowerShell/PowerShell/issues/7183"},"comments":{"href":"https://api.github.com/repos/PowerShell/PowerShell/issues/7183/comments"},"review_comments":{"href":"https://api.github.com/repos/PowerShell/PowerShell/pulls/7183/comments"},"review_comment":{"href":"https://api.github.com/repos/PowerShell/PowerShell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PowerShell/PowerShell/pulls/7183/commits"},"statuses":{"href":"https://api.github.com/repos/PowerShell/PowerShell/statuses/87a6c3266fd527ab25bebb283c85be2974a12d5e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"daxian-dbw"}}