{"action":"created","comment":{"url":"https://api.github.com/repos/moby/moby/pulls/comments/182427400","pull_request_review_id":113219031,"id":182427400,"diff_hunk":"@@ -330,77 +345,83 @@ func (s *DockerExternalGraphdriverSuite) setUpPlugin(c *check.C, name string, ex\n \t})\n \n \terr = os.MkdirAll(\"/etc/docker/plugins\", 0755)\n-\tc.Assert(err, check.IsNil, check.Commentf(\"error creating /etc/docker/plugins\"))\n+\tassert.NilError(t, err)\n \n \tspecFile := \"/etc/docker/plugins/\" + name + \".\" + ext\n \terr = ioutil.WriteFile(specFile, b, 0644)\n-\tc.Assert(err, check.IsNil, check.Commentf(\"error writing to %s\", specFile))\n-}\n-\n-func (s *DockerExternalGraphdriverSuite) TearDownSuite(c *check.C) {\n-\ts.server.Close()\n-\ts.jserver.Close()\n-\n-\terr := os.RemoveAll(\"/etc/docker/plugins\")\n-\tc.Assert(err, check.IsNil, check.Commentf(\"error removing /etc/docker/plugins\"))\n-}\n-\n-func (s *DockerExternalGraphdriverSuite) TestExternalGraphDriver(c *check.C) {\n-\ttestRequires(c, ExperimentalDaemon, SameHostDaemon)\n-\n-\ts.testExternalGraphDriver(\"test-external-graph-driver\", \"spec\", c)\n-\ts.testExternalGraphDriver(\"json-external-graph-driver\", \"json\", c)\n+\tassert.NilError(t, err)\n }\n \n-func (s *DockerExternalGraphdriverSuite) testExternalGraphDriver(name string, ext string, c *check.C) {\n-\ts.d.StartWithBusybox(c, \"-s\", name)\n-\n-\tout, err := s.d.Cmd(\"run\", \"--name=graphtest\", \"busybox\", \"sh\", \"-c\", \"echo hello > /hello\")\n-\tc.Assert(err, check.IsNil, check.Commentf(out))\n-\n-\ts.d.Restart(c, \"-s\", name)\n-\n-\tout, err = s.d.Cmd(\"inspect\", \"--format={{.GraphDriver.Name}}\", \"graphtest\")\n-\tc.Assert(err, check.IsNil, check.Commentf(out))\n-\tc.Assert(strings.TrimSpace(out), check.Equals, name)\n-\n-\tout, err = s.d.Cmd(\"diff\", \"graphtest\")\n-\tc.Assert(err, check.IsNil, check.Commentf(out))\n-\tc.Assert(strings.Contains(out, \"A /hello\"), check.Equals, true, check.Commentf(\"diff output: %s\", out))\n-\n-\tout, err = s.d.Cmd(\"rm\", \"-f\", \"graphtest\")\n-\tc.Assert(err, check.IsNil, check.Commentf(out))\n-\n-\tout, err = s.d.Cmd(\"info\")\n-\tc.Assert(err, check.IsNil, check.Commentf(out))\n-\n-\ts.d.Stop(c)\n-\n-\t// Don't check s.ec.exists, because the daemon no longer calls the\n-\t// Exists function.\n-\tc.Assert(s.ec[ext].activations, check.Equals, 2)\n-\tc.Assert(s.ec[ext].init, check.Equals, 2)\n-\tc.Assert(s.ec[ext].creations >= 1, check.Equals, true)\n-\tc.Assert(s.ec[ext].removals >= 1, check.Equals, true)\n-\tc.Assert(s.ec[ext].gets >= 1, check.Equals, true)\n-\tc.Assert(s.ec[ext].puts >= 1, check.Equals, true)\n-\tc.Assert(s.ec[ext].stats, check.Equals, 5)\n-\tc.Assert(s.ec[ext].cleanups, check.Equals, 2)\n-\tc.Assert(s.ec[ext].applydiff >= 1, check.Equals, true)\n-\tc.Assert(s.ec[ext].changes, check.Equals, 1)\n-\tc.Assert(s.ec[ext].diffsize, check.Equals, 0)\n-\tc.Assert(s.ec[ext].diff, check.Equals, 0)\n-\tc.Assert(s.ec[ext].metadata, check.Equals, 1)\n+func testExternalGraphDriver(ext string, ec map[string]*graphEventsCounter) func(client.APIClient, *daemon.Daemon) func(*testing.T) {\n+\treturn func(c client.APIClient, d *daemon.Daemon) func(*testing.T) {\n+\t\treturn func(t *testing.T) {\n+\t\t\tdriverName := fmt.Sprintf(\"%s-external-graph-driver\", ext)\n+\t\t\td.StartWithBusybox(t, \"-s\", driverName)\n+\n+\t\t\tctx := context.Background()\n+\n+\t\t\t/*","path":"integration/plugin/graphdriver/external_test.go","position":361,"original_position":361,"commit_id":"731b5135a6a672ba76658f15a46160fd130f5127","original_commit_id":"731b5135a6a672ba76658f15a46160fd130f5127","user":{"login":"cpuguy83","id":799078,"avatar_url":"https://avatars3.githubusercontent.com/u/799078?v=4","gravatar_id":"","url":"https://api.github.com/users/cpuguy83","html_url":"https://github.com/cpuguy83","followers_url":"https://api.github.com/users/cpuguy83/followers","following_url":"https://api.github.com/users/cpuguy83/following{/other_user}","gists_url":"https://api.github.com/users/cpuguy83/gists{/gist_id}","starred_url":"https://api.github.com/users/cpuguy83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpuguy83/subscriptions","organizations_url":"https://api.github.com/users/cpuguy83/orgs","repos_url":"https://api.github.com/users/cpuguy83/repos","events_url":"https://api.github.com/users/cpuguy83/events{/privacy}","received_events_url":"https://api.github.com/users/cpuguy83/received_events","type":"User","site_admin":false},"body":"??","created_at":"2018-04-18T13:33:56Z","updated_at":"2018-04-18T13:37:49Z","html_url":"https://github.com/moby/moby/pull/36886#discussion_r182427400","pull_request_url":"https://api.github.com/repos/moby/moby/pulls/36886","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/moby/moby/pulls/comments/182427400"},"html":{"href":"https://github.com/moby/moby/pull/36886#discussion_r182427400"},"pull_request":{"href":"https://api.github.com/repos/moby/moby/pulls/36886"}}},"pull_request":{"url":"https://api.github.com/repos/moby/moby/pulls/36886","id":182459012,"html_url":"https://github.com/moby/moby/pull/36886","diff_url":"https://github.com/moby/moby/pull/36886.diff","patch_url":"https://github.com/moby/moby/pull/36886.patch","issue_url":"https://api.github.com/repos/moby/moby/issues/36886","number":36886,"state":"open","locked":false,"title":"Migrate test-integration-cli experimental plugin tests to integration","user":{"login":"vdemeester","id":6508,"avatar_url":"https://avatars0.githubusercontent.com/u/6508?v=4","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"body":"All `plugins` tests that require an `ExperimentalDaemon` are migrated\r\nto `integration/plugin/*` and start an experimental daemon to test on\r\nit.\r\n\r\nThe end goal being to remove the `experimental` build.\r\n\r\n:lion: \r\n\r\nSigned-off-by: Vincent Demeester <vincent@sbr.pm>\r\n","created_at":"2018-04-18T12:14:19Z","updated_at":"2018-04-18T13:37:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd6d6acaa5abb9c67bec0b10da56e6f08e165e31","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tiborvass","id":827131,"avatar_url":"https://avatars2.githubusercontent.com/u/827131?v=4","gravatar_id":"","url":"https://api.github.com/users/tiborvass","html_url":"https://github.com/tiborvass","followers_url":"https://api.github.com/users/tiborvass/followers","following_url":"https://api.github.com/users/tiborvass/following{/other_user}","gists_url":"https://api.github.com/users/tiborvass/gists{/gist_id}","starred_url":"https://api.github.com/users/tiborvass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiborvass/subscriptions","organizations_url":"https://api.github.com/users/tiborvass/orgs","repos_url":"https://api.github.com/users/tiborvass/repos","events_url":"https://api.github.com/users/tiborvass/events{/privacy}","received_events_url":"https://api.github.com/users/tiborvass/received_events","type":"User","site_admin":false},{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars2.githubusercontent.com/u/1804568?v=4","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},{"login":"anusha-ragunathan","id":14184178,"avatar_url":"https://avatars0.githubusercontent.com/u/14184178?v=4","gravatar_id":"","url":"https://api.github.com/users/anusha-ragunathan","html_url":"https://github.com/anusha-ragunathan","followers_url":"https://api.github.com/users/anusha-ragunathan/followers","following_url":"https://api.github.com/users/anusha-ragunathan/following{/other_user}","gists_url":"https://api.github.com/users/anusha-ragunathan/gists{/gist_id}","starred_url":"https://api.github.com/users/anusha-ragunathan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anusha-ragunathan/subscriptions","organizations_url":"https://api.github.com/users/anusha-ragunathan/orgs","repos_url":"https://api.github.com/users/anusha-ragunathan/repos","events_url":"https://api.github.com/users/anusha-ragunathan/events{/privacy}","received_events_url":"https://api.github.com/users/anusha-ragunathan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":275636077,"url":"https://api.github.com/repos/moby/moby/labels/area/testing","name":"area/testing","color":"fbca04","default":false},{"id":175375407,"url":"https://api.github.com/repos/moby/moby/labels/status/2-code-review","name":"status/2-code-review","color":"fad8c7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/moby/moby/pulls/36886/commits","review_comments_url":"https://api.github.com/repos/moby/moby/pulls/36886/comments","review_comment_url":"https://api.github.com/repos/moby/moby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/moby/moby/issues/36886/comments","statuses_url":"https://api.github.com/repos/moby/moby/statuses/731b5135a6a672ba76658f15a46160fd130f5127","head":{"label":"vdemeester:experimental-plugins-migration","ref":"experimental-plugins-migration","sha":"731b5135a6a672ba76658f15a46160fd130f5127","user":{"login":"vdemeester","id":6508,"avatar_url":"https://avatars0.githubusercontent.com/u/6508?v=4","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"repo":{"id":32953007,"name":"moby","full_name":"vdemeester/moby","owner":{"login":"vdemeester","id":6508,"avatar_url":"https://avatars0.githubusercontent.com/u/6508?v=4","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vdemeester/moby","description":"🐳 Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/vdemeester/moby","forks_url":"https://api.github.com/repos/vdemeester/moby/forks","keys_url":"https://api.github.com/repos/vdemeester/moby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vdemeester/moby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vdemeester/moby/teams","hooks_url":"https://api.github.com/repos/vdemeester/moby/hooks","issue_events_url":"https://api.github.com/repos/vdemeester/moby/issues/events{/number}","events_url":"https://api.github.com/repos/vdemeester/moby/events","assignees_url":"https://api.github.com/repos/vdemeester/moby/assignees{/user}","branches_url":"https://api.github.com/repos/vdemeester/moby/branches{/branch}","tags_url":"https://api.github.com/repos/vdemeester/moby/tags","blobs_url":"https://api.github.com/repos/vdemeester/moby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vdemeester/moby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vdemeester/moby/git/refs{/sha}","trees_url":"https://api.github.com/repos/vdemeester/moby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vdemeester/moby/statuses/{sha}","languages_url":"https://api.github.com/repos/vdemeester/moby/languages","stargazers_url":"https://api.github.com/repos/vdemeester/moby/stargazers","contributors_url":"https://api.github.com/repos/vdemeester/moby/contributors","subscribers_url":"https://api.github.com/repos/vdemeester/moby/subscribers","subscription_url":"https://api.github.com/repos/vdemeester/moby/subscription","commits_url":"https://api.github.com/repos/vdemeester/moby/commits{/sha}","git_commits_url":"https://api.github.com/repos/vdemeester/moby/git/commits{/sha}","comments_url":"https://api.github.com/repos/vdemeester/moby/comments{/number}","issue_comment_url":"https://api.github.com/repos/vdemeester/moby/issues/comments{/number}","contents_url":"https://api.github.com/repos/vdemeester/moby/contents/{+path}","compare_url":"https://api.github.com/repos/vdemeester/moby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vdemeester/moby/merges","archive_url":"https://api.github.com/repos/vdemeester/moby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vdemeester/moby/downloads","issues_url":"https://api.github.com/repos/vdemeester/moby/issues{/number}","pulls_url":"https://api.github.com/repos/vdemeester/moby/pulls{/number}","milestones_url":"https://api.github.com/repos/vdemeester/moby/milestones{/number}","notifications_url":"https://api.github.com/repos/vdemeester/moby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vdemeester/moby/labels{/name}","releases_url":"https://api.github.com/repos/vdemeester/moby/releases{/id}","deployments_url":"https://api.github.com/repos/vdemeester/moby/deployments","created_at":"2015-03-26T21:32:15Z","updated_at":"2018-04-18T13:27:01Z","pushed_at":"2018-04-18T13:26:59Z","git_url":"git://github.com/vdemeester/moby.git","ssh_url":"git@github.com:vdemeester/moby.git","clone_url":"https://github.com/vdemeester/moby.git","svn_url":"https://github.com/vdemeester/moby","homepage":"http://www.docker.com","size":128040,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"moby:master","ref":"master","sha":"4923f8cc639e1ab01a251429495920e516ef779f","user":{"login":"moby","id":27259197,"avatar_url":"https://avatars1.githubusercontent.com/u/27259197?v=4","gravatar_id":"","url":"https://api.github.com/users/moby","html_url":"https://github.com/moby","followers_url":"https://api.github.com/users/moby/followers","following_url":"https://api.github.com/users/moby/following{/other_user}","gists_url":"https://api.github.com/users/moby/gists{/gist_id}","starred_url":"https://api.github.com/users/moby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moby/subscriptions","organizations_url":"https://api.github.com/users/moby/orgs","repos_url":"https://api.github.com/users/moby/repos","events_url":"https://api.github.com/users/moby/events{/privacy}","received_events_url":"https://api.github.com/users/moby/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"moby","full_name":"moby/moby","owner":{"login":"moby","id":27259197,"avatar_url":"https://avatars1.githubusercontent.com/u/27259197?v=4","gravatar_id":"","url":"https://api.github.com/users/moby","html_url":"https://github.com/moby","followers_url":"https://api.github.com/users/moby/followers","following_url":"https://api.github.com/users/moby/following{/other_user}","gists_url":"https://api.github.com/users/moby/gists{/gist_id}","starred_url":"https://api.github.com/users/moby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moby/subscriptions","organizations_url":"https://api.github.com/users/moby/orgs","repos_url":"https://api.github.com/users/moby/repos","events_url":"https://api.github.com/users/moby/events{/privacy}","received_events_url":"https://api.github.com/users/moby/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moby/moby","description":"Moby Project - a collaborative project for the container ecosystem to assemble container-based systems","fork":false,"url":"https://api.github.com/repos/moby/moby","forks_url":"https://api.github.com/repos/moby/moby/forks","keys_url":"https://api.github.com/repos/moby/moby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moby/moby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moby/moby/teams","hooks_url":"https://api.github.com/repos/moby/moby/hooks","issue_events_url":"https://api.github.com/repos/moby/moby/issues/events{/number}","events_url":"https://api.github.com/repos/moby/moby/events","assignees_url":"https://api.github.com/repos/moby/moby/assignees{/user}","branches_url":"https://api.github.com/repos/moby/moby/branches{/branch}","tags_url":"https://api.github.com/repos/moby/moby/tags","blobs_url":"https://api.github.com/repos/moby/moby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moby/moby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moby/moby/git/refs{/sha}","trees_url":"https://api.github.com/repos/moby/moby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moby/moby/statuses/{sha}","languages_url":"https://api.github.com/repos/moby/moby/languages","stargazers_url":"https://api.github.com/repos/moby/moby/stargazers","contributors_url":"https://api.github.com/repos/moby/moby/contributors","subscribers_url":"https://api.github.com/repos/moby/moby/subscribers","subscription_url":"https://api.github.com/repos/moby/moby/subscription","commits_url":"https://api.github.com/repos/moby/moby/commits{/sha}","git_commits_url":"https://api.github.com/repos/moby/moby/git/commits{/sha}","comments_url":"https://api.github.com/repos/moby/moby/comments{/number}","issue_comment_url":"https://api.github.com/repos/moby/moby/issues/comments{/number}","contents_url":"https://api.github.com/repos/moby/moby/contents/{+path}","compare_url":"https://api.github.com/repos/moby/moby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moby/moby/merges","archive_url":"https://api.github.com/repos/moby/moby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moby/moby/downloads","issues_url":"https://api.github.com/repos/moby/moby/issues{/number}","pulls_url":"https://api.github.com/repos/moby/moby/pulls{/number}","milestones_url":"https://api.github.com/repos/moby/moby/milestones{/number}","notifications_url":"https://api.github.com/repos/moby/moby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moby/moby/labels{/name}","releases_url":"https://api.github.com/repos/moby/moby/releases{/id}","deployments_url":"https://api.github.com/repos/moby/moby/deployments","created_at":"2013-01-18T18:10:57Z","updated_at":"2018-04-18T13:32:41Z","pushed_at":"2018-04-18T13:34:36Z","git_url":"git://github.com/moby/moby.git","ssh_url":"git@github.com:moby/moby.git","clone_url":"https://github.com/moby/moby.git","svn_url":"https://github.com/moby/moby","homepage":"https://mobyproject.org/","size":132626,"stargazers_count":48524,"watchers_count":48524,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14257,"mirror_url":null,"archived":false,"open_issues_count":3174,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":14257,"open_issues":3174,"watchers":48524,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/moby/moby/pulls/36886"},"html":{"href":"https://github.com/moby/moby/pull/36886"},"issue":{"href":"https://api.github.com/repos/moby/moby/issues/36886"},"comments":{"href":"https://api.github.com/repos/moby/moby/issues/36886/comments"},"review_comments":{"href":"https://api.github.com/repos/moby/moby/pulls/36886/comments"},"review_comment":{"href":"https://api.github.com/repos/moby/moby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/moby/moby/pulls/36886/commits"},"statuses":{"href":"https://api.github.com/repos/moby/moby/statuses/731b5135a6a672ba76658f15a46160fd130f5127"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"cpuguy83"}}