{"action":"created","issue":{"url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/issues/1211","repository_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python","labels_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/issues/1211/labels{/name}","comments_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/issues/1211/comments","events_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/issues/1211/events","html_url":"https://github.com/HypothesisWorks/hypothesis-python/pull/1211","id":311638989,"number":1211,"title":"Deprecate more settings to clarify and simplify the system","user":{"login":"Zac-HD","id":12229877,"avatar_url":"https://avatars1.githubusercontent.com/u/12229877?v=4","gravatar_id":"","url":"https://api.github.com/users/Zac-HD","html_url":"https://github.com/Zac-HD","followers_url":"https://api.github.com/users/Zac-HD/followers","following_url":"https://api.github.com/users/Zac-HD/following{/other_user}","gists_url":"https://api.github.com/users/Zac-HD/gists{/gist_id}","starred_url":"https://api.github.com/users/Zac-HD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zac-HD/subscriptions","organizations_url":"https://api.github.com/users/Zac-HD/orgs","repos_url":"https://api.github.com/users/Zac-HD/repos","events_url":"https://api.github.com/users/Zac-HD/events{/privacy}","received_events_url":"https://api.github.com/users/Zac-HD/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-04-05T14:40:27Z","updated_at":"2018-04-11T15:03:00Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls/1211","html_url":"https://github.com/HypothesisWorks/hypothesis-python/pull/1211","diff_url":"https://github.com/HypothesisWorks/hypothesis-python/pull/1211.diff","patch_url":"https://github.com/HypothesisWorks/hypothesis-python/pull/1211.patch"},"body":"Per #535, we have too many settings and they can be unhelpful.  Closes #197, where three settings interact, by deprecating and disabling two of them!  Removing `min_satisfying_examples` also closes #534 as it currently stands.\r\n\r\n- [x] Deprecated settings are no longer shown in the `settings()` repr, unless set to a non-default value (or having an ongoing effect, ie `timeout`).\r\n- [x] `min_satisfying_examples` and `max_iterations` now do nothing.  Users can still tweak `max_examples`, but we use internal heuristics which are equivalent to the old defaults.\r\n- [x] `perform_health_check` is deprecated in favor of `suppress_health_check`.\r\n- [x] `max_shrinks` is deprecated in favor of `phases`, with a degree of automatic translation (ie ignore arg, but disable shrink phase when n=0)"},"comment":{"url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/issues/comments/380485052","html_url":"https://github.com/HypothesisWorks/hypothesis-python/pull/1211#issuecomment-380485052","issue_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/issues/1211","id":380485052,"user":{"login":"bukzor","id":640328,"avatar_url":"https://avatars3.githubusercontent.com/u/640328?v=4","gravatar_id":"","url":"https://api.github.com/users/bukzor","html_url":"https://github.com/bukzor","followers_url":"https://api.github.com/users/bukzor/followers","following_url":"https://api.github.com/users/bukzor/following{/other_user}","gists_url":"https://api.github.com/users/bukzor/gists{/gist_id}","starred_url":"https://api.github.com/users/bukzor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bukzor/subscriptions","organizations_url":"https://api.github.com/users/bukzor/orgs","repos_url":"https://api.github.com/users/bukzor/repos","events_url":"https://api.github.com/users/bukzor/events{/privacy}","received_events_url":"https://api.github.com/users/bukzor/received_events","type":"User","site_admin":false},"created_at":"2018-04-11T15:02:59Z","updated_at":"2018-04-11T15:02:59Z","author_association":"CONTRIBUTOR","body":">> Please use 5x the max-examples value? 500 shrinks on some of my tests would be disastrous.\r\n> @bukzor, what's your use-case for this?\r\n\r\nSince timeout is going away, deadline and max-examples are my only knobs for controlling runtime of my tests. Under our (corporate) test system, I have to ensure that the test completes before a hard deadline, sometimes as low as sixty seconds, and some of my use cases run for many seconds per trial. So you can see, if hypothesis were to attempt 500 shrinks, I would never see *any* result. A somewhat non-minimal result is much preferred.\r\n\r\nCurrently, I have these tests set to max-trials:5 max-shrinks:2, and they reliably meet deadline. Setting max-shrinks to a constant 500 will cause the test to timeout and never show any counter example upon failure.\r\n\r\nPerhaps I'm thinking about this incorrectly, and instead I should open a feature request for an overall test deadline (currently we only have a per-trial deadline), upon which hypothesis will return what it has as quickly as possible."}}
{"actor":{"display_login":"bukzor"}}