{"action":"closed","number":3273,"pull_request":{"url":"https://api.github.com/repos/curl/curl/pulls/3273","id":231177591,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMTc3NTkx","html_url":"https://github.com/curl/curl/pull/3273","diff_url":"https://github.com/curl/curl/pull/3273.diff","patch_url":"https://github.com/curl/curl/pull/3273.patch","issue_url":"https://api.github.com/repos/curl/curl/issues/3273","number":3273,"state":"closed","locked":false,"title":"Use lgtm to find Python syntax errors","user":{"login":"cclauss","id":3709715,"node_id":"MDQ6VXNlcjM3MDk3MTU=","avatar_url":"https://avatars3.githubusercontent.com/u/3709715?v=4","gravatar_id":"","url":"https://api.github.com/users/cclauss","html_url":"https://github.com/cclauss","followers_url":"https://api.github.com/users/cclauss/followers","following_url":"https://api.github.com/users/cclauss/following{/other_user}","gists_url":"https://api.github.com/users/cclauss/gists{/gist_id}","starred_url":"https://api.github.com/users/cclauss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cclauss/subscriptions","organizations_url":"https://api.github.com/users/cclauss/orgs","repos_url":"https://api.github.com/users/cclauss/repos","events_url":"https://api.github.com/users/cclauss/events{/privacy}","received_events_url":"https://api.github.com/users/cclauss/received_events","type":"User","site_admin":false},"body":"Python is just 11.8% of the curl codebase but it is still good to spot the anachronisms in the impacket code.\r\n\r\n[flake8](http://flake8.pycqa.org) testing of https://github.com/curl/curl on Python 3.7.1\r\n\r\n$ __flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics__\r\n```\r\n./tests/python_dependencies/impacket/spnego.py:77:6: E999 TabError: inconsistent use of tabs and spaces in indentation\r\n\telse:\r\n     ^\r\n./tests/python_dependencies/impacket/structure.py:100:40: E999 SyntaxError: invalid syntax\r\n            print \"packField( %s | %s )\" % (fieldName, format)\r\n                                       ^\r\n./tests/python_dependencies/impacket/smb.py:632:27: E999 SyntaxError: invalid syntax\r\n        y = t & 0xffffffffL\r\n                          ^\r\n./tests/python_dependencies/impacket/ntlm.py:239:28: E999 SyntaxError: invalid syntax\r\n            print \"%s: {%r}\" % (i,self[i])\r\n                           ^\r\n./tests/python_dependencies/impacket/smb3.py:234:26: E999 SyntaxError: invalid syntax\r\n        print \"CONNECTION\"\r\n                         ^\r\n./tests/python_dependencies/impacket/uuid.py:22:13: E999 SyntaxError: invalid syntax\r\n    top = (1L<<31)-1\r\n            ^\r\n./tests/python_dependencies/impacket/nmb.py:457:31: E999 SyntaxError: invalid syntax\r\n            raise NetBIOSError, ( 'Cannot bind to a good UDP port', ERRCLASS_OS, errno.EAGAIN )\r\n                              ^\r\n./tests/python_dependencies/impacket/smbserver.py:83:25: E999 SyntaxError: invalid syntax\r\n        except Exception, e:\r\n                        ^\r\n8     E999 SyntaxError: invalid syntax\r\n8\r\n```","created_at":"2018-11-15T12:29:19Z","updated_at":"2018-11-15T15:35:28Z","closed_at":"2018-11-15T15:35:28Z","merged_at":null,"merge_commit_sha":"f2543430a25ae736dafbfaa7ad4052da51b06933","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/curl/curl/pulls/3273/commits","review_comments_url":"https://api.github.com/repos/curl/curl/pulls/3273/comments","review_comment_url":"https://api.github.com/repos/curl/curl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/curl/curl/issues/3273/comments","statuses_url":"https://api.github.com/repos/curl/curl/statuses/b40c289102b6948b724f4012b3174eb136cf00c2","head":{"label":"cclauss:patch-1","ref":"patch-1","sha":"b40c289102b6948b724f4012b3174eb136cf00c2","user":{"login":"cclauss","id":3709715,"node_id":"MDQ6VXNlcjM3MDk3MTU=","avatar_url":"https://avatars3.githubusercontent.com/u/3709715?v=4","gravatar_id":"","url":"https://api.github.com/users/cclauss","html_url":"https://github.com/cclauss","followers_url":"https://api.github.com/users/cclauss/followers","following_url":"https://api.github.com/users/cclauss/following{/other_user}","gists_url":"https://api.github.com/users/cclauss/gists{/gist_id}","starred_url":"https://api.github.com/users/cclauss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cclauss/subscriptions","organizations_url":"https://api.github.com/users/cclauss/orgs","repos_url":"https://api.github.com/users/cclauss/repos","events_url":"https://api.github.com/users/cclauss/events{/privacy}","received_events_url":"https://api.github.com/users/cclauss/received_events","type":"User","site_admin":false},"repo":{"id":157707010,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc3MDcwMTA=","name":"curl","full_name":"cclauss/curl","private":false,"owner":{"login":"cclauss","id":3709715,"node_id":"MDQ6VXNlcjM3MDk3MTU=","avatar_url":"https://avatars3.githubusercontent.com/u/3709715?v=4","gravatar_id":"","url":"https://api.github.com/users/cclauss","html_url":"https://github.com/cclauss","followers_url":"https://api.github.com/users/cclauss/followers","following_url":"https://api.github.com/users/cclauss/following{/other_user}","gists_url":"https://api.github.com/users/cclauss/gists{/gist_id}","starred_url":"https://api.github.com/users/cclauss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cclauss/subscriptions","organizations_url":"https://api.github.com/users/cclauss/orgs","repos_url":"https://api.github.com/users/cclauss/repos","events_url":"https://api.github.com/users/cclauss/events{/privacy}","received_events_url":"https://api.github.com/users/cclauss/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cclauss/curl","description":"A command line tool and library for transferring data with URL syntax, supporting HTTP, HTTPS, FTP, FTPS, GOPHER, TFTP, SCP, SFTP, SMB, TELNET, DICT, LDAP, LDAPS, FILE, IMAP, SMTP, POP3, RTSP and RTMP. libcurl offers a myriad of powerful features","fork":true,"url":"https://api.github.com/repos/cclauss/curl","forks_url":"https://api.github.com/repos/cclauss/curl/forks","keys_url":"https://api.github.com/repos/cclauss/curl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cclauss/curl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cclauss/curl/teams","hooks_url":"https://api.github.com/repos/cclauss/curl/hooks","issue_events_url":"https://api.github.com/repos/cclauss/curl/issues/events{/number}","events_url":"https://api.github.com/repos/cclauss/curl/events","assignees_url":"https://api.github.com/repos/cclauss/curl/assignees{/user}","branches_url":"https://api.github.com/repos/cclauss/curl/branches{/branch}","tags_url":"https://api.github.com/repos/cclauss/curl/tags","blobs_url":"https://api.github.com/repos/cclauss/curl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cclauss/curl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cclauss/curl/git/refs{/sha}","trees_url":"https://api.github.com/repos/cclauss/curl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cclauss/curl/statuses/{sha}","languages_url":"https://api.github.com/repos/cclauss/curl/languages","stargazers_url":"https://api.github.com/repos/cclauss/curl/stargazers","contributors_url":"https://api.github.com/repos/cclauss/curl/contributors","subscribers_url":"https://api.github.com/repos/cclauss/curl/subscribers","subscription_url":"https://api.github.com/repos/cclauss/curl/subscription","commits_url":"https://api.github.com/repos/cclauss/curl/commits{/sha}","git_commits_url":"https://api.github.com/repos/cclauss/curl/git/commits{/sha}","comments_url":"https://api.github.com/repos/cclauss/curl/comments{/number}","issue_comment_url":"https://api.github.com/repos/cclauss/curl/issues/comments{/number}","contents_url":"https://api.github.com/repos/cclauss/curl/contents/{+path}","compare_url":"https://api.github.com/repos/cclauss/curl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cclauss/curl/merges","archive_url":"https://api.github.com/repos/cclauss/curl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cclauss/curl/downloads","issues_url":"https://api.github.com/repos/cclauss/curl/issues{/number}","pulls_url":"https://api.github.com/repos/cclauss/curl/pulls{/number}","milestones_url":"https://api.github.com/repos/cclauss/curl/milestones{/number}","notifications_url":"https://api.github.com/repos/cclauss/curl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cclauss/curl/labels{/name}","releases_url":"https://api.github.com/repos/cclauss/curl/releases{/id}","deployments_url":"https://api.github.com/repos/cclauss/curl/deployments","created_at":"2018-11-15T12:23:33Z","updated_at":"2018-11-15T12:23:41Z","pushed_at":"2018-11-15T15:34:47Z","git_url":"git://github.com/cclauss/curl.git","ssh_url":"git@github.com:cclauss/curl.git","clone_url":"https://github.com/cclauss/curl.git","svn_url":"https://github.com/cclauss/curl","homepage":"https://curl.haxx.se/","size":57548,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"curl:master","ref":"master","sha":"3d988c5563f0438a88f4f31a1a176186aa3a399b","user":{"login":"curl","id":16928085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTI4MDg1","avatar_url":"https://avatars0.githubusercontent.com/u/16928085?v=4","gravatar_id":"","url":"https://api.github.com/users/curl","html_url":"https://github.com/curl","followers_url":"https://api.github.com/users/curl/followers","following_url":"https://api.github.com/users/curl/following{/other_user}","gists_url":"https://api.github.com/users/curl/gists{/gist_id}","starred_url":"https://api.github.com/users/curl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/curl/subscriptions","organizations_url":"https://api.github.com/users/curl/orgs","repos_url":"https://api.github.com/users/curl/repos","events_url":"https://api.github.com/users/curl/events{/privacy}","received_events_url":"https://api.github.com/users/curl/received_events","type":"Organization","site_admin":false},"repo":{"id":569041,"node_id":"MDEwOlJlcG9zaXRvcnk1NjkwNDE=","name":"curl","full_name":"curl/curl","private":false,"owner":{"login":"curl","id":16928085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTI4MDg1","avatar_url":"https://avatars0.githubusercontent.com/u/16928085?v=4","gravatar_id":"","url":"https://api.github.com/users/curl","html_url":"https://github.com/curl","followers_url":"https://api.github.com/users/curl/followers","following_url":"https://api.github.com/users/curl/following{/other_user}","gists_url":"https://api.github.com/users/curl/gists{/gist_id}","starred_url":"https://api.github.com/users/curl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/curl/subscriptions","organizations_url":"https://api.github.com/users/curl/orgs","repos_url":"https://api.github.com/users/curl/repos","events_url":"https://api.github.com/users/curl/events{/privacy}","received_events_url":"https://api.github.com/users/curl/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/curl/curl","description":"A command line tool and library for transferring data with URL syntax, supporting HTTP, HTTPS, FTP, FTPS, GOPHER, TFTP, SCP, SFTP, SMB, TELNET, DICT, LDAP, LDAPS, FILE, IMAP, SMTP, POP3, RTSP and RTMP. libcurl offers a myriad of powerful features","fork":false,"url":"https://api.github.com/repos/curl/curl","forks_url":"https://api.github.com/repos/curl/curl/forks","keys_url":"https://api.github.com/repos/curl/curl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/curl/curl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/curl/curl/teams","hooks_url":"https://api.github.com/repos/curl/curl/hooks","issue_events_url":"https://api.github.com/repos/curl/curl/issues/events{/number}","events_url":"https://api.github.com/repos/curl/curl/events","assignees_url":"https://api.github.com/repos/curl/curl/assignees{/user}","branches_url":"https://api.github.com/repos/curl/curl/branches{/branch}","tags_url":"https://api.github.com/repos/curl/curl/tags","blobs_url":"https://api.github.com/repos/curl/curl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/curl/curl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/curl/curl/git/refs{/sha}","trees_url":"https://api.github.com/repos/curl/curl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/curl/curl/statuses/{sha}","languages_url":"https://api.github.com/repos/curl/curl/languages","stargazers_url":"https://api.github.com/repos/curl/curl/stargazers","contributors_url":"https://api.github.com/repos/curl/curl/contributors","subscribers_url":"https://api.github.com/repos/curl/curl/subscribers","subscription_url":"https://api.github.com/repos/curl/curl/subscription","commits_url":"https://api.github.com/repos/curl/curl/commits{/sha}","git_commits_url":"https://api.github.com/repos/curl/curl/git/commits{/sha}","comments_url":"https://api.github.com/repos/curl/curl/comments{/number}","issue_comment_url":"https://api.github.com/repos/curl/curl/issues/comments{/number}","contents_url":"https://api.github.com/repos/curl/curl/contents/{+path}","compare_url":"https://api.github.com/repos/curl/curl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/curl/curl/merges","archive_url":"https://api.github.com/repos/curl/curl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/curl/curl/downloads","issues_url":"https://api.github.com/repos/curl/curl/issues{/number}","pulls_url":"https://api.github.com/repos/curl/curl/pulls{/number}","milestones_url":"https://api.github.com/repos/curl/curl/milestones{/number}","notifications_url":"https://api.github.com/repos/curl/curl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/curl/curl/labels{/name}","releases_url":"https://api.github.com/repos/curl/curl/releases{/id}","deployments_url":"https://api.github.com/repos/curl/curl/deployments","created_at":"2010-03-18T22:32:22Z","updated_at":"2018-11-15T15:24:18Z","pushed_at":"2018-11-15T14:23:13Z","git_url":"git://github.com/curl/curl.git","ssh_url":"git@github.com:curl/curl.git","clone_url":"https://github.com/curl/curl.git","svn_url":"https://github.com/curl/curl","homepage":"https://curl.haxx.se/","size":57547,"stargazers_count":11149,"watchers_count":11149,"language":"C","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":2647,"mirror_url":null,"archived":false,"open_issues_count":83,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2647,"open_issues":83,"watchers":11149,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/curl/curl/pulls/3273"},"html":{"href":"https://github.com/curl/curl/pull/3273"},"issue":{"href":"https://api.github.com/repos/curl/curl/issues/3273"},"comments":{"href":"https://api.github.com/repos/curl/curl/issues/3273/comments"},"review_comments":{"href":"https://api.github.com/repos/curl/curl/pulls/3273/comments"},"review_comment":{"href":"https://api.github.com/repos/curl/curl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/curl/curl/pulls/3273/commits"},"statuses":{"href":"https://api.github.com/repos/curl/curl/statuses/b40c289102b6948b724f4012b3174eb136cf00c2"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":11,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"cclauss"}}