{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/20637","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20637/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20637/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20637/events","html_url":"https://github.com/joomla/joomla-cms/pull/20637","id":328415258,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxOTU4MTcz","number":20637,"title":"[4.0] Removing com_search","user":{"login":"Hackwar","id":313866,"node_id":"MDQ6VXNlcjMxMzg2Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/313866?v=4","gravatar_id":"","url":"https://api.github.com/users/Hackwar","html_url":"https://github.com/Hackwar","followers_url":"https://api.github.com/users/Hackwar/followers","following_url":"https://api.github.com/users/Hackwar/following{/other_user}","gists_url":"https://api.github.com/users/Hackwar/gists{/gist_id}","starred_url":"https://api.github.com/users/Hackwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hackwar/subscriptions","organizations_url":"https://api.github.com/users/Hackwar/orgs","repos_url":"https://api.github.com/users/Hackwar/repos","events_url":"https://api.github.com/users/Hackwar/events{/privacy}","received_events_url":"https://api.github.com/users/Hackwar/received_events","type":"User","site_admin":false},"labels":[{"id":198658453,"node_id":"MDU6TGFiZWwxOTg2NTg0NTM=","url":"https://api.github.com/repos/joomla/joomla-cms/labels/Language%20Change","name":"Language Change","color":"eb6420","default":false},{"id":444033883,"node_id":"MDU6TGFiZWw0NDQwMzM4ODM=","url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-4.0-dev","name":"PR-4.0-dev","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":27,"created_at":"2018-06-01T07:46:47Z","updated_at":"2018-06-21T13:08:29Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/20637","html_url":"https://github.com/joomla/joomla-cms/pull/20637","diff_url":"https://github.com/joomla/joomla-cms/pull/20637.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/20637.patch"},"body":"With the changes to com_finder that I proposed, Smart Search should finally be ready for prime time. Having two complete search implementations in Joomla is pretty stupid, especially considering that Smart Search is far superior to com_search and thus this PR removes com_search from Joomla.\r\n\r\nThis PR should only be merged when all other changes to com_finder have been implemented."},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/399097414","html_url":"https://github.com/joomla/joomla-cms/pull/20637#issuecomment-399097414","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20637","id":399097414,"node_id":"MDEyOklzc3VlQ29tbWVudDM5OTA5NzQxNA==","user":{"login":"mbabker","id":368545,"node_id":"MDQ6VXNlcjM2ODU0NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/368545?v=4","gravatar_id":"","url":"https://api.github.com/users/mbabker","html_url":"https://github.com/mbabker","followers_url":"https://api.github.com/users/mbabker/followers","following_url":"https://api.github.com/users/mbabker/following{/other_user}","gists_url":"https://api.github.com/users/mbabker/gists{/gist_id}","starred_url":"https://api.github.com/users/mbabker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbabker/subscriptions","organizations_url":"https://api.github.com/users/mbabker/orgs","repos_url":"https://api.github.com/users/mbabker/repos","events_url":"https://api.github.com/users/mbabker/events{/privacy}","received_events_url":"https://api.github.com/users/mbabker/received_events","type":"User","site_admin":false},"created_at":"2018-06-21T13:08:29Z","updated_at":"2018-06-21T13:08:29Z","author_association":"MEMBER","body":"> Classic Search performs a realtime search, thus can't make suggestions but on the other hand doesn't need to do its work beforehand.\r\n\r\nHere's the kicker.  Most com_search integrations only support a database query with a `WHERE foo LIKE '%bar%'` structure, or you're doing some asininely crazy stuff to pull off a result.  In a lot of cases, you want your search to expand beyond a literal term match, and that's where com_finder makes its money.  Imagine if Google or Bing or Yahoo or Ask Jeeves only supported literal matches.\r\n\r\nWe really need to pull one of the search engines out of the core distro.  Period.  As long as search is an entirely plug and play driven system, there is no reason to ship two search components.  Pick one for core, make the other \"core supported\" (and hope it doesn't die like Weblinks, how's that going anyway?).  As far as human behavior and human expectations go, I would suggest com_finder more closely aligns with those than com_search does, even with all its flaws and higher technical knowledge to do a correct integration."}}
{"actor":{"display_login":"mbabker"}}