{"action":"created","issue":{"url":"https://api.github.com/repos/guardian/frontend/issues/19599","repository_url":"https://api.github.com/repos/guardian/frontend","labels_url":"https://api.github.com/repos/guardian/frontend/issues/19599/labels{/name}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/19599/comments","events_url":"https://api.github.com/repos/guardian/frontend/issues/19599/events","html_url":"https://github.com/guardian/frontend/pull/19599","id":319229261,"number":19599,"title":"Show football tabs when available","user":{"login":"GHaberis","id":1590704,"avatar_url":"https://avatars2.githubusercontent.com/u/1590704?v=4","gravatar_id":"","url":"https://api.github.com/users/GHaberis","html_url":"https://github.com/GHaberis","followers_url":"https://api.github.com/users/GHaberis/followers","following_url":"https://api.github.com/users/GHaberis/following{/other_user}","gists_url":"https://api.github.com/users/GHaberis/gists{/gist_id}","starred_url":"https://api.github.com/users/GHaberis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GHaberis/subscriptions","organizations_url":"https://api.github.com/users/GHaberis/orgs","repos_url":"https://api.github.com/users/GHaberis/repos","events_url":"https://api.github.com/users/GHaberis/events{/privacy}","received_events_url":"https://api.github.com/users/GHaberis/received_events","type":"User","site_admin":false},"labels":[{"id":512259700,"url":"https://api.github.com/repos/guardian/frontend/labels/Seen-on-PROD","name":"Seen-on-PROD","color":"bfe5bf","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-05-01T15:22:43Z","updated_at":"2018-05-02T10:06:34Z","closed_at":"2018-05-02T09:49:22Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/19599","html_url":"https://github.com/guardian/frontend/pull/19599","diff_url":"https://github.com/guardian/frontend/pull/19599.diff","patch_url":"https://github.com/guardian/frontend/pull/19599.patch"},"body":"## What does this change?\r\n\r\nThe \"min-by-min\" tab for this article wasn't being returned by the server:\r\n\r\nhttps://www.theguardian.com/football/2018/apr/24/liverpool-roma-champions-league-semi-final-first-leg-match-report-5-2\r\n\r\nThe server determines whether to include this tab by checking the related articles for a football match report, if it finds a related article which is a \"minute-by-minute\" article that was also published on the same day as the match it should include the tab.\r\n\r\nThe problem with this article was the published date of the match report was returning `2018-04-25` whilst the match date was `2018-04-24`. \r\n\r\nThis meant `c.trail.webPublicationDate.withZone(DateTimeZone.forID(\"Europe/London\")).toLocalDate == matchDate` returned `false`.\r\n\r\nI've fixed this by converting both dates to the same zone and using the `sameDay` method from `Dates.scala` to compare them.\r\n\r\n## What is the value of this and can you measure success?\r\n\r\nIf a match report has a related live blog published on the same day of the match we show it as a tab.\r\n\r\n## Does this affect other platforms - Amp, Apps, etc?\r\n\r\nNo\r\n\r\n## Screenshots\r\n\r\n**Before - No tabs**\r\n\r\n![picture 157](https://user-images.githubusercontent.com/1590704/39478933-aedf4530-4d5b-11e8-9cc1-f8d46cbe3c92.png)\r\n\r\n**After - with tabs**\r\n\r\n![picture 156](https://user-images.githubusercontent.com/1590704/39478954-c04aa990-4d5b-11e8-895c-d52b7542acda.png)\r\n\r\n## Tested in CODE?\r\n\r\nNo\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/guardian/frontend/issues/comments/385928631","html_url":"https://github.com/guardian/frontend/pull/19599#issuecomment-385928631","issue_url":"https://api.github.com/repos/guardian/frontend/issues/19599","id":385928631,"user":{"login":"prout-bot","id":8896019,"avatar_url":"https://avatars2.githubusercontent.com/u/8896019?v=4","gravatar_id":"","url":"https://api.github.com/users/prout-bot","html_url":"https://github.com/prout-bot","followers_url":"https://api.github.com/users/prout-bot/followers","following_url":"https://api.github.com/users/prout-bot/following{/other_user}","gists_url":"https://api.github.com/users/prout-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/prout-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prout-bot/subscriptions","organizations_url":"https://api.github.com/users/prout-bot/orgs","repos_url":"https://api.github.com/users/prout-bot/repos","events_url":"https://api.github.com/users/prout-bot/events{/privacy}","received_events_url":"https://api.github.com/users/prout-bot/received_events","type":"User","site_admin":false},"created_at":"2018-05-02T10:06:34Z","updated_at":"2018-05-02T10:06:34Z","author_association":"COLLABORATOR","body":"Seen on [PROD](https://frontend.gutools.co.uk/deploys?stage=PROD&pageSize=50) (merged by @GHaberis 17 minutes and 12 seconds ago) \n- Check your changes on [www.theguardian.com](https://www.theguardian.com) ✔️ \n- Keep an eye on the [deploy dashboard](https://kibana.gu-web.net/app/kibana#/dashboard/8730df10-49fd-11e7-b778-ebbe55169b8f) 📉 \n"}}
{"actor":{"display_login":"prout-bot"}}