{"action":"opened","number":881,"pull_request":{"url":"https://api.github.com/repos/redhat-developer/odo/pulls/881","id":226115494,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MTE1NDk0","html_url":"https://github.com/redhat-developer/odo/pull/881","diff_url":"https://github.com/redhat-developer/odo/pull/881.diff","patch_url":"https://github.com/redhat-developer/odo/pull/881.patch","issue_url":"https://api.github.com/repos/redhat-developer/odo/issues/881","number":881,"state":"open","locked":false,"title":"[do-not-merge] Switch to golang/dep with prune packages","user":{"login":"vdemeester","id":6508,"node_id":"MDQ6VXNlcjY1MDg=","avatar_url":"https://avatars0.githubusercontent.com/u/6508?v=4","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Vincent Demeester <vdemeest@redhat.com>\r\n\r\nWhat is the purpose of this change? What does it change?\r\n\r\nSwitching from `glide` to `golang/dep` (which is \"the tool of choice\" while waiting for \"go modules\", in go 1.11 and later). This also enables packages pruning, reducing drastically the vendored code.\r\n\r\nWas the change discussed in an issue?\r\n\r\nNop it's just a proposal, open for discussion — One argument against this PR would be to just switch to `go mod` when ready (and thus removing the need for vendoring altogether).\r\n\r\nHow to test changes?\r\n\r\n`make` :angel: \r\n","created_at":"2018-10-26T14:19:58Z","updated_at":"2018-10-26T14:19:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/redhat-developer/odo/pulls/881/commits","review_comments_url":"https://api.github.com/repos/redhat-developer/odo/pulls/881/comments","review_comment_url":"https://api.github.com/repos/redhat-developer/odo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/redhat-developer/odo/issues/881/comments","statuses_url":"https://api.github.com/repos/redhat-developer/odo/statuses/ae79920d253d8eface10284dc7a49aade9e66186","head":{"label":"vdemeester:dep-vendor","ref":"dep-vendor","sha":"ae79920d253d8eface10284dc7a49aade9e66186","user":{"login":"vdemeester","id":6508,"node_id":"MDQ6VXNlcjY1MDg=","avatar_url":"https://avatars0.githubusercontent.com/u/6508?v=4","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"repo":{"id":148546253,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg1NDYyNTM=","name":"odo","full_name":"vdemeester/odo","private":false,"owner":{"login":"vdemeester","id":6508,"node_id":"MDQ6VXNlcjY1MDg=","avatar_url":"https://avatars0.githubusercontent.com/u/6508?v=4","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"html_url":"https://github.com/vdemeester/odo","description":"OpenShift Command line for Developers","fork":true,"url":"https://api.github.com/repos/vdemeester/odo","forks_url":"https://api.github.com/repos/vdemeester/odo/forks","keys_url":"https://api.github.com/repos/vdemeester/odo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vdemeester/odo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vdemeester/odo/teams","hooks_url":"https://api.github.com/repos/vdemeester/odo/hooks","issue_events_url":"https://api.github.com/repos/vdemeester/odo/issues/events{/number}","events_url":"https://api.github.com/repos/vdemeester/odo/events","assignees_url":"https://api.github.com/repos/vdemeester/odo/assignees{/user}","branches_url":"https://api.github.com/repos/vdemeester/odo/branches{/branch}","tags_url":"https://api.github.com/repos/vdemeester/odo/tags","blobs_url":"https://api.github.com/repos/vdemeester/odo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vdemeester/odo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vdemeester/odo/git/refs{/sha}","trees_url":"https://api.github.com/repos/vdemeester/odo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vdemeester/odo/statuses/{sha}","languages_url":"https://api.github.com/repos/vdemeester/odo/languages","stargazers_url":"https://api.github.com/repos/vdemeester/odo/stargazers","contributors_url":"https://api.github.com/repos/vdemeester/odo/contributors","subscribers_url":"https://api.github.com/repos/vdemeester/odo/subscribers","subscription_url":"https://api.github.com/repos/vdemeester/odo/subscription","commits_url":"https://api.github.com/repos/vdemeester/odo/commits{/sha}","git_commits_url":"https://api.github.com/repos/vdemeester/odo/git/commits{/sha}","comments_url":"https://api.github.com/repos/vdemeester/odo/comments{/number}","issue_comment_url":"https://api.github.com/repos/vdemeester/odo/issues/comments{/number}","contents_url":"https://api.github.com/repos/vdemeester/odo/contents/{+path}","compare_url":"https://api.github.com/repos/vdemeester/odo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vdemeester/odo/merges","archive_url":"https://api.github.com/repos/vdemeester/odo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vdemeester/odo/downloads","issues_url":"https://api.github.com/repos/vdemeester/odo/issues{/number}","pulls_url":"https://api.github.com/repos/vdemeester/odo/pulls{/number}","milestones_url":"https://api.github.com/repos/vdemeester/odo/milestones{/number}","notifications_url":"https://api.github.com/repos/vdemeester/odo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vdemeester/odo/labels{/name}","releases_url":"https://api.github.com/repos/vdemeester/odo/releases{/id}","deployments_url":"https://api.github.com/repos/vdemeester/odo/deployments","created_at":"2018-09-12T21:49:57Z","updated_at":"2018-10-26T13:06:10Z","pushed_at":"2018-10-26T13:26:54Z","git_url":"git://github.com/vdemeester/odo.git","ssh_url":"git@github.com:vdemeester/odo.git","clone_url":"https://github.com/vdemeester/odo.git","svn_url":"https://github.com/vdemeester/odo","homepage":"","size":92581,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"redhat-developer:master","ref":"master","sha":"2e6e6beed60f19275d09d07d8b749861620ea920","user":{"login":"redhat-developer","id":11033755,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDMzNzU1","avatar_url":"https://avatars0.githubusercontent.com/u/11033755?v=4","gravatar_id":"","url":"https://api.github.com/users/redhat-developer","html_url":"https://github.com/redhat-developer","followers_url":"https://api.github.com/users/redhat-developer/followers","following_url":"https://api.github.com/users/redhat-developer/following{/other_user}","gists_url":"https://api.github.com/users/redhat-developer/gists{/gist_id}","starred_url":"https://api.github.com/users/redhat-developer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhat-developer/subscriptions","organizations_url":"https://api.github.com/users/redhat-developer/orgs","repos_url":"https://api.github.com/users/redhat-developer/repos","events_url":"https://api.github.com/users/redhat-developer/events{/privacy}","received_events_url":"https://api.github.com/users/redhat-developer/received_events","type":"Organization","site_admin":false},"repo":{"id":118630356,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg2MzAzNTY=","name":"odo","full_name":"redhat-developer/odo","private":false,"owner":{"login":"redhat-developer","id":11033755,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDMzNzU1","avatar_url":"https://avatars0.githubusercontent.com/u/11033755?v=4","gravatar_id":"","url":"https://api.github.com/users/redhat-developer","html_url":"https://github.com/redhat-developer","followers_url":"https://api.github.com/users/redhat-developer/followers","following_url":"https://api.github.com/users/redhat-developer/following{/other_user}","gists_url":"https://api.github.com/users/redhat-developer/gists{/gist_id}","starred_url":"https://api.github.com/users/redhat-developer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhat-developer/subscriptions","organizations_url":"https://api.github.com/users/redhat-developer/orgs","repos_url":"https://api.github.com/users/redhat-developer/repos","events_url":"https://api.github.com/users/redhat-developer/events{/privacy}","received_events_url":"https://api.github.com/users/redhat-developer/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/redhat-developer/odo","description":"OpenShift Command line for Developers","fork":false,"url":"https://api.github.com/repos/redhat-developer/odo","forks_url":"https://api.github.com/repos/redhat-developer/odo/forks","keys_url":"https://api.github.com/repos/redhat-developer/odo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redhat-developer/odo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redhat-developer/odo/teams","hooks_url":"https://api.github.com/repos/redhat-developer/odo/hooks","issue_events_url":"https://api.github.com/repos/redhat-developer/odo/issues/events{/number}","events_url":"https://api.github.com/repos/redhat-developer/odo/events","assignees_url":"https://api.github.com/repos/redhat-developer/odo/assignees{/user}","branches_url":"https://api.github.com/repos/redhat-developer/odo/branches{/branch}","tags_url":"https://api.github.com/repos/redhat-developer/odo/tags","blobs_url":"https://api.github.com/repos/redhat-developer/odo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redhat-developer/odo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redhat-developer/odo/git/refs{/sha}","trees_url":"https://api.github.com/repos/redhat-developer/odo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redhat-developer/odo/statuses/{sha}","languages_url":"https://api.github.com/repos/redhat-developer/odo/languages","stargazers_url":"https://api.github.com/repos/redhat-developer/odo/stargazers","contributors_url":"https://api.github.com/repos/redhat-developer/odo/contributors","subscribers_url":"https://api.github.com/repos/redhat-developer/odo/subscribers","subscription_url":"https://api.github.com/repos/redhat-developer/odo/subscription","commits_url":"https://api.github.com/repos/redhat-developer/odo/commits{/sha}","git_commits_url":"https://api.github.com/repos/redhat-developer/odo/git/commits{/sha}","comments_url":"https://api.github.com/repos/redhat-developer/odo/comments{/number}","issue_comment_url":"https://api.github.com/repos/redhat-developer/odo/issues/comments{/number}","contents_url":"https://api.github.com/repos/redhat-developer/odo/contents/{+path}","compare_url":"https://api.github.com/repos/redhat-developer/odo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redhat-developer/odo/merges","archive_url":"https://api.github.com/repos/redhat-developer/odo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redhat-developer/odo/downloads","issues_url":"https://api.github.com/repos/redhat-developer/odo/issues{/number}","pulls_url":"https://api.github.com/repos/redhat-developer/odo/pulls{/number}","milestones_url":"https://api.github.com/repos/redhat-developer/odo/milestones{/number}","notifications_url":"https://api.github.com/repos/redhat-developer/odo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redhat-developer/odo/labels{/name}","releases_url":"https://api.github.com/repos/redhat-developer/odo/releases{/id}","deployments_url":"https://api.github.com/repos/redhat-developer/odo/deployments","created_at":"2018-01-23T15:36:17Z","updated_at":"2018-10-26T12:47:17Z","pushed_at":"2018-10-26T14:17:28Z","git_url":"git://github.com/redhat-developer/odo.git","ssh_url":"git@github.com:redhat-developer/odo.git","clone_url":"https://github.com/redhat-developer/odo.git","svn_url":"https://github.com/redhat-developer/odo","homepage":"","size":92411,"stargazers_count":257,"watchers_count":257,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":156,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":52,"open_issues":156,"watchers":257,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/redhat-developer/odo/pulls/881"},"html":{"href":"https://github.com/redhat-developer/odo/pull/881"},"issue":{"href":"https://api.github.com/repos/redhat-developer/odo/issues/881"},"comments":{"href":"https://api.github.com/repos/redhat-developer/odo/issues/881/comments"},"review_comments":{"href":"https://api.github.com/repos/redhat-developer/odo/pulls/881/comments"},"review_comment":{"href":"https://api.github.com/repos/redhat-developer/odo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/redhat-developer/odo/pulls/881/commits"},"statuses":{"href":"https://api.github.com/repos/redhat-developer/odo/statuses/ae79920d253d8eface10284dc7a49aade9e66186"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":6705,"deletions":1725370,"changed_files":4829}}
{"actor":{"display_login":"vdemeester"}}