{"action":"created","issue":{"url":"https://api.github.com/repos/shroffk/phoebus/issues/201","repository_url":"https://api.github.com/repos/shroffk/phoebus","labels_url":"https://api.github.com/repos/shroffk/phoebus/issues/201/labels{/name}","comments_url":"https://api.github.com/repos/shroffk/phoebus/issues/201/comments","events_url":"https://api.github.com/repos/shroffk/phoebus/issues/201/events","html_url":"https://github.com/shroffk/phoebus/pull/201","id":335840785,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NDM4ODUw","number":201,"title":"Issue 136","user":{"login":"shroffk","id":2111304,"node_id":"MDQ6VXNlcjIxMTEzMDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2111304?v=4","gravatar_id":"","url":"https://api.github.com/users/shroffk","html_url":"https://github.com/shroffk","followers_url":"https://api.github.com/users/shroffk/followers","following_url":"https://api.github.com/users/shroffk/following{/other_user}","gists_url":"https://api.github.com/users/shroffk/gists{/gist_id}","starred_url":"https://api.github.com/users/shroffk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shroffk/subscriptions","organizations_url":"https://api.github.com/users/shroffk/orgs","repos_url":"https://api.github.com/users/shroffk/repos","events_url":"https://api.github.com/users/shroffk/events{/privacy}","received_events_url":"https://api.github.com/users/shroffk/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-06-26T14:16:35Z","updated_at":"2018-06-27T13:17:10Z","closed_at":"2018-06-26T19:08:19Z","author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/shroffk/phoebus/pulls/201","html_url":"https://github.com/shroffk/phoebus/pull/201","diff_url":"https://github.com/shroffk/phoebus/pull/201.diff","patch_url":"https://github.com/shroffk/phoebus/pull/201.patch"},"body":"Issue #136 and Issue #200 \r\n"},"comment":{"url":"https://api.github.com/repos/shroffk/phoebus/issues/comments/400667703","html_url":"https://github.com/shroffk/phoebus/pull/201#issuecomment-400667703","issue_url":"https://api.github.com/repos/shroffk/phoebus/issues/201","id":400667703,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDY2NzcwMw==","user":{"login":"kasemir","id":1932421,"node_id":"MDQ6VXNlcjE5MzI0MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/1932421?v=4","gravatar_id":"","url":"https://api.github.com/users/kasemir","html_url":"https://github.com/kasemir","followers_url":"https://api.github.com/users/kasemir/followers","following_url":"https://api.github.com/users/kasemir/following{/other_user}","gists_url":"https://api.github.com/users/kasemir/gists{/gist_id}","starred_url":"https://api.github.com/users/kasemir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kasemir/subscriptions","organizations_url":"https://api.github.com/users/kasemir/orgs","repos_url":"https://api.github.com/users/kasemir/repos","events_url":"https://api.github.com/users/kasemir/events{/privacy}","received_events_url":"https://api.github.com/users/kasemir/received_events","type":"User","site_admin":false},"created_at":"2018-06-27T13:17:10Z","updated_at":"2018-06-27T13:17:10Z","author_association":"COLLABORATOR","body":"`channel/utility/.classpath` listed `src/test/resources`, which doesn't exist.\r\n19c2c6120fba1d6467d446836cf179ef00e0c3a2 removed that in the ongoing alarm_actions branch.\r\n\r\nThe channel finder preference file, `channelfinder/src/main/resources/config/channelfinder.properties`, doesn't match the expected name for preference files (`*_preferences.properties`), so it's not included in the online help section that describes available settings (http://phoebus-doc.readthedocs.io/en/latest/preference_properties.html).\r\nAt this time, `core/mail` is a good example for handling preferences in the suggested way: Resource `*_preferences.properties` that's copied into the online help, with comment to indicate the package name,  and a `*Preferences` class that loads defaults via the `PreferencesReader`.\r\n\r\nSince the `CFProposalProvider` is included in the default project, a default configuration for https://localhost:8181/ChannelFinder is fine, but would be good to have a way to disable it, instead of continuing to run into connection errors for a missing channel finder setup.\r\nFor example, setting `channelfinder.serviceURL` to nothing could be a way to disable channel finder lookups, but that results in NPE during application startup (which until 70c925c70c700ea4758d6e91cdafb703d1706a15 prevented phoebus from starting up at all).\r\n\r\n\r\n\r\n"}}
{"actor":{"display_login":"kasemir"}}