{"action":"created","comment":{"url":"https://api.github.com/repos/Interkarma/daggerfall-unity/pulls/comments/243251349","pull_request_review_id":186969742,"id":243251349,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzI1MTM0OQ==","diff_hunk":"@@ -19,25 +19,41 @@ namespace DaggerfallWorkshop.Game.MagicAndEffects.MagicEffects\n     /// </summary>\n     public class InvisibilityNormal : ConcealmentEffect\n     {\n+        public static readonly string PublicKey = \"Invisibility-Normal\";\n+\n         public override void SetProperties()\n         {\n-            properties.Key = \"Invisibility-Normal\";\n+            properties.Key = PublicKey;","path":"Assets/Scripts/Game/MagicAndEffects/Effects/Illusion/InvisibilityNormal.cs","position":9,"original_position":9,"commit_id":"81fb1d39edc62f40ca00171d49adb074196c0f2e","original_commit_id":"d6ca6f826fee4d1f7ebfbb3fc1a11f3b12933c5e","user":{"login":"Interkarma","id":10426244,"node_id":"MDQ6VXNlcjEwNDI2MjQ0","avatar_url":"https://avatars3.githubusercontent.com/u/10426244?v=4","gravatar_id":"","url":"https://api.github.com/users/Interkarma","html_url":"https://github.com/Interkarma","followers_url":"https://api.github.com/users/Interkarma/followers","following_url":"https://api.github.com/users/Interkarma/following{/other_user}","gists_url":"https://api.github.com/users/Interkarma/gists{/gist_id}","starred_url":"https://api.github.com/users/Interkarma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Interkarma/subscriptions","organizations_url":"https://api.github.com/users/Interkarma/orgs","repos_url":"https://api.github.com/users/Interkarma/repos","events_url":"https://api.github.com/users/Interkarma/events{/privacy}","received_events_url":"https://api.github.com/users/Interkarma/received_events","type":"User","site_admin":false},"body":"I'm happy for that, if you'd like to work through it. I'll make sure I follow the same pattern for any future effects that I write.\r\n\r\nBTW, now you're across the effect system would you be interested in helping to build any of the remaining spell effects, item effects, advantages/disadvantages, or artifact effects? I plan to start knocking these over again soon once I'm done having fun with vampirism.","created_at":"2018-12-20T12:16:39Z","updated_at":"2018-12-20T12:16:39Z","html_url":"https://github.com/Interkarma/daggerfall-unity/pull/1101#discussion_r243251349","pull_request_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/pulls/1101","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Interkarma/daggerfall-unity/pulls/comments/243251349"},"html":{"href":"https://github.com/Interkarma/daggerfall-unity/pull/1101#discussion_r243251349"},"pull_request":{"href":"https://api.github.com/repos/Interkarma/daggerfall-unity/pulls/1101"}},"in_reply_to_id":243047510},"pull_request":{"url":"https://api.github.com/repos/Interkarma/daggerfall-unity/pulls/1101","id":239944549,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5OTQ0NTQ5","html_url":"https://github.com/Interkarma/daggerfall-unity/pull/1101","diff_url":"https://github.com/Interkarma/daggerfall-unity/pull/1101.diff","patch_url":"https://github.com/Interkarma/daggerfall-unity/pull/1101.patch","issue_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/issues/1101","number":1101,"state":"closed","locked":false,"title":"Potions initial implementation","user":{"login":"ajrb","id":2278830,"node_id":"MDQ6VXNlcjIyNzg4MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/2278830?v=4","gravatar_id":"","url":"https://api.github.com/users/ajrb","html_url":"https://github.com/ajrb","followers_url":"https://api.github.com/users/ajrb/followers","following_url":"https://api.github.com/users/ajrb/following{/other_user}","gists_url":"https://api.github.com/users/ajrb/gists{/gist_id}","starred_url":"https://api.github.com/users/ajrb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajrb/subscriptions","organizations_url":"https://api.github.com/users/ajrb/orgs","repos_url":"https://api.github.com/users/ajrb/repos","events_url":"https://api.github.com/users/ajrb/events{/privacy}","received_events_url":"https://api.github.com/users/ajrb/received_events","type":"User","site_admin":false},"body":"- All classic potions can be mixed.\r\n- All classic potions can be drunk and the effects work.\r\n- Failed potions are not created and a new message is displayed. (change from classic)\r\n- We need to decide whether to restrict random potions in loot. Should they be restricted to classic ones only? I have a function for all and another for classic only - one could be used for mixing and purchasing, with the classic one used for loot. Opinions?\r\n- Also added removeOne function to item collection which decrements stack and only removed item object when reaches 0. Please use it going forward where appropriate. Ta.\r\n- Need to discuss mechanism for mult-effect potions @Interkarma - see the review comments.\r\n","created_at":"2018-12-19T19:11:11Z","updated_at":"2018-12-20T12:16:39Z","closed_at":"2018-12-20T04:42:45Z","merged_at":"2018-12-20T04:42:45Z","merge_commit_sha":"c61c8eb5ded6a865e56166ed8a0f7ef68ae40668","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/pulls/1101/commits","review_comments_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/pulls/1101/comments","review_comment_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/issues/1101/comments","statuses_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/statuses/81fb1d39edc62f40ca00171d49adb074196c0f2e","head":{"label":"ajrb:potions","ref":"potions","sha":"81fb1d39edc62f40ca00171d49adb074196c0f2e","user":{"login":"ajrb","id":2278830,"node_id":"MDQ6VXNlcjIyNzg4MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/2278830?v=4","gravatar_id":"","url":"https://api.github.com/users/ajrb","html_url":"https://github.com/ajrb","followers_url":"https://api.github.com/users/ajrb/followers","following_url":"https://api.github.com/users/ajrb/following{/other_user}","gists_url":"https://api.github.com/users/ajrb/gists{/gist_id}","starred_url":"https://api.github.com/users/ajrb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajrb/subscriptions","organizations_url":"https://api.github.com/users/ajrb/orgs","repos_url":"https://api.github.com/users/ajrb/repos","events_url":"https://api.github.com/users/ajrb/events{/privacy}","received_events_url":"https://api.github.com/users/ajrb/received_events","type":"User","site_admin":false},"repo":{"id":101489647,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE0ODk2NDc=","name":"daggerfall-unity","full_name":"ajrb/daggerfall-unity","private":false,"owner":{"login":"ajrb","id":2278830,"node_id":"MDQ6VXNlcjIyNzg4MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/2278830?v=4","gravatar_id":"","url":"https://api.github.com/users/ajrb","html_url":"https://github.com/ajrb","followers_url":"https://api.github.com/users/ajrb/followers","following_url":"https://api.github.com/users/ajrb/following{/other_user}","gists_url":"https://api.github.com/users/ajrb/gists{/gist_id}","starred_url":"https://api.github.com/users/ajrb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajrb/subscriptions","organizations_url":"https://api.github.com/users/ajrb/orgs","repos_url":"https://api.github.com/users/ajrb/repos","events_url":"https://api.github.com/users/ajrb/events{/privacy}","received_events_url":"https://api.github.com/users/ajrb/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ajrb/daggerfall-unity","description":"Open source recreation of Daggerfall in the Unity engine","fork":true,"url":"https://api.github.com/repos/ajrb/daggerfall-unity","forks_url":"https://api.github.com/repos/ajrb/daggerfall-unity/forks","keys_url":"https://api.github.com/repos/ajrb/daggerfall-unity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajrb/daggerfall-unity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajrb/daggerfall-unity/teams","hooks_url":"https://api.github.com/repos/ajrb/daggerfall-unity/hooks","issue_events_url":"https://api.github.com/repos/ajrb/daggerfall-unity/issues/events{/number}","events_url":"https://api.github.com/repos/ajrb/daggerfall-unity/events","assignees_url":"https://api.github.com/repos/ajrb/daggerfall-unity/assignees{/user}","branches_url":"https://api.github.com/repos/ajrb/daggerfall-unity/branches{/branch}","tags_url":"https://api.github.com/repos/ajrb/daggerfall-unity/tags","blobs_url":"https://api.github.com/repos/ajrb/daggerfall-unity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajrb/daggerfall-unity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajrb/daggerfall-unity/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajrb/daggerfall-unity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajrb/daggerfall-unity/statuses/{sha}","languages_url":"https://api.github.com/repos/ajrb/daggerfall-unity/languages","stargazers_url":"https://api.github.com/repos/ajrb/daggerfall-unity/stargazers","contributors_url":"https://api.github.com/repos/ajrb/daggerfall-unity/contributors","subscribers_url":"https://api.github.com/repos/ajrb/daggerfall-unity/subscribers","subscription_url":"https://api.github.com/repos/ajrb/daggerfall-unity/subscription","commits_url":"https://api.github.com/repos/ajrb/daggerfall-unity/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajrb/daggerfall-unity/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajrb/daggerfall-unity/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajrb/daggerfall-unity/issues/comments{/number}","contents_url":"https://api.github.com/repos/ajrb/daggerfall-unity/contents/{+path}","compare_url":"https://api.github.com/repos/ajrb/daggerfall-unity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajrb/daggerfall-unity/merges","archive_url":"https://api.github.com/repos/ajrb/daggerfall-unity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajrb/daggerfall-unity/downloads","issues_url":"https://api.github.com/repos/ajrb/daggerfall-unity/issues{/number}","pulls_url":"https://api.github.com/repos/ajrb/daggerfall-unity/pulls{/number}","milestones_url":"https://api.github.com/repos/ajrb/daggerfall-unity/milestones{/number}","notifications_url":"https://api.github.com/repos/ajrb/daggerfall-unity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajrb/daggerfall-unity/labels{/name}","releases_url":"https://api.github.com/repos/ajrb/daggerfall-unity/releases{/id}","deployments_url":"https://api.github.com/repos/ajrb/daggerfall-unity/deployments","created_at":"2017-08-26T14:06:11Z","updated_at":"2018-12-20T12:14:21Z","pushed_at":"2018-12-20T12:14:18Z","git_url":"git://github.com/ajrb/daggerfall-unity.git","ssh_url":"git@github.com:ajrb/daggerfall-unity.git","clone_url":"https://github.com/ajrb/daggerfall-unity.git","svn_url":"https://github.com/ajrb/daggerfall-unity","homepage":"http://www.dfworkshop.net","size":97151,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Interkarma:master","ref":"master","sha":"b628d43518d4986114c064fa8c45f2a030eb8ecd","user":{"login":"Interkarma","id":10426244,"node_id":"MDQ6VXNlcjEwNDI2MjQ0","avatar_url":"https://avatars3.githubusercontent.com/u/10426244?v=4","gravatar_id":"","url":"https://api.github.com/users/Interkarma","html_url":"https://github.com/Interkarma","followers_url":"https://api.github.com/users/Interkarma/followers","following_url":"https://api.github.com/users/Interkarma/following{/other_user}","gists_url":"https://api.github.com/users/Interkarma/gists{/gist_id}","starred_url":"https://api.github.com/users/Interkarma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Interkarma/subscriptions","organizations_url":"https://api.github.com/users/Interkarma/orgs","repos_url":"https://api.github.com/users/Interkarma/repos","events_url":"https://api.github.com/users/Interkarma/events{/privacy}","received_events_url":"https://api.github.com/users/Interkarma/received_events","type":"User","site_admin":false},"repo":{"id":28884050,"node_id":"MDEwOlJlcG9zaXRvcnkyODg4NDA1MA==","name":"daggerfall-unity","full_name":"Interkarma/daggerfall-unity","private":false,"owner":{"login":"Interkarma","id":10426244,"node_id":"MDQ6VXNlcjEwNDI2MjQ0","avatar_url":"https://avatars3.githubusercontent.com/u/10426244?v=4","gravatar_id":"","url":"https://api.github.com/users/Interkarma","html_url":"https://github.com/Interkarma","followers_url":"https://api.github.com/users/Interkarma/followers","following_url":"https://api.github.com/users/Interkarma/following{/other_user}","gists_url":"https://api.github.com/users/Interkarma/gists{/gist_id}","starred_url":"https://api.github.com/users/Interkarma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Interkarma/subscriptions","organizations_url":"https://api.github.com/users/Interkarma/orgs","repos_url":"https://api.github.com/users/Interkarma/repos","events_url":"https://api.github.com/users/Interkarma/events{/privacy}","received_events_url":"https://api.github.com/users/Interkarma/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Interkarma/daggerfall-unity","description":"Open source recreation of Daggerfall in the Unity engine","fork":false,"url":"https://api.github.com/repos/Interkarma/daggerfall-unity","forks_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/forks","keys_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/teams","hooks_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/hooks","issue_events_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/issues/events{/number}","events_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/events","assignees_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/assignees{/user}","branches_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/branches{/branch}","tags_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/tags","blobs_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/git/refs{/sha}","trees_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/statuses/{sha}","languages_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/languages","stargazers_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/stargazers","contributors_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/contributors","subscribers_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/subscribers","subscription_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/subscription","commits_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/commits{/sha}","git_commits_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/git/commits{/sha}","comments_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/comments{/number}","issue_comment_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/issues/comments{/number}","contents_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/contents/{+path}","compare_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/merges","archive_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/downloads","issues_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/issues{/number}","pulls_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/pulls{/number}","milestones_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/milestones{/number}","notifications_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/labels{/name}","releases_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/releases{/id}","deployments_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/deployments","created_at":"2015-01-06T21:18:36Z","updated_at":"2018-12-20T12:03:36Z","pushed_at":"2018-12-20T12:06:35Z","git_url":"git://github.com/Interkarma/daggerfall-unity.git","ssh_url":"git@github.com:Interkarma/daggerfall-unity.git","clone_url":"https://github.com/Interkarma/daggerfall-unity.git","svn_url":"https://github.com/Interkarma/daggerfall-unity","homepage":"http://www.dfworkshop.net","size":97191,"stargazers_count":460,"watchers_count":460,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":83,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":83,"open_issues":6,"watchers":460,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Interkarma/daggerfall-unity/pulls/1101"},"html":{"href":"https://github.com/Interkarma/daggerfall-unity/pull/1101"},"issue":{"href":"https://api.github.com/repos/Interkarma/daggerfall-unity/issues/1101"},"comments":{"href":"https://api.github.com/repos/Interkarma/daggerfall-unity/issues/1101/comments"},"review_comments":{"href":"https://api.github.com/repos/Interkarma/daggerfall-unity/pulls/1101/comments"},"review_comment":{"href":"https://api.github.com/repos/Interkarma/daggerfall-unity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Interkarma/daggerfall-unity/pulls/1101/commits"},"statuses":{"href":"https://api.github.com/repos/Interkarma/daggerfall-unity/statuses/81fb1d39edc62f40ca00171d49adb074196c0f2e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Interkarma"}}