{"action":"created","issue":{"url":"https://api.github.com/repos/olifolkerd/tabulator/issues/1240","repository_url":"https://api.github.com/repos/olifolkerd/tabulator","labels_url":"https://api.github.com/repos/olifolkerd/tabulator/issues/1240/labels{/name}","comments_url":"https://api.github.com/repos/olifolkerd/tabulator/issues/1240/comments","events_url":"https://api.github.com/repos/olifolkerd/tabulator/issues/1240/events","html_url":"https://github.com/olifolkerd/tabulator/issues/1240","id":337489802,"node_id":"MDU6SXNzdWUzMzc0ODk4MDI=","number":1240,"title":"[Question] The name differenciation between select and lookup is expected?","user":{"login":"lgraziani2712","id":15050200,"node_id":"MDQ6VXNlcjE1MDUwMjAw","avatar_url":"https://avatars3.githubusercontent.com/u/15050200?v=4","gravatar_id":"","url":"https://api.github.com/users/lgraziani2712","html_url":"https://github.com/lgraziani2712","followers_url":"https://api.github.com/users/lgraziani2712/followers","following_url":"https://api.github.com/users/lgraziani2712/following{/other_user}","gists_url":"https://api.github.com/users/lgraziani2712/gists{/gist_id}","starred_url":"https://api.github.com/users/lgraziani2712/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgraziani2712/subscriptions","organizations_url":"https://api.github.com/users/lgraziani2712/orgs","repos_url":"https://api.github.com/users/lgraziani2712/repos","events_url":"https://api.github.com/users/lgraziani2712/events{/privacy}","received_events_url":"https://api.github.com/users/lgraziani2712/received_events","type":"User","site_admin":false},"labels":[{"id":277350038,"node_id":"MDU6TGFiZWwyNzczNTAwMzg=","url":"https://api.github.com/repos/olifolkerd/tabulator/labels/question","name":"question","color":"cc317c","default":true}],"state":"closed","locked":false,"assignee":{"login":"olifolkerd","id":6840524,"node_id":"MDQ6VXNlcjY4NDA1MjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6840524?v=4","gravatar_id":"","url":"https://api.github.com/users/olifolkerd","html_url":"https://github.com/olifolkerd","followers_url":"https://api.github.com/users/olifolkerd/followers","following_url":"https://api.github.com/users/olifolkerd/following{/other_user}","gists_url":"https://api.github.com/users/olifolkerd/gists{/gist_id}","starred_url":"https://api.github.com/users/olifolkerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olifolkerd/subscriptions","organizations_url":"https://api.github.com/users/olifolkerd/orgs","repos_url":"https://api.github.com/users/olifolkerd/repos","events_url":"https://api.github.com/users/olifolkerd/events{/privacy}","received_events_url":"https://api.github.com/users/olifolkerd/received_events","type":"User","site_admin":false},"assignees":[{"login":"olifolkerd","id":6840524,"node_id":"MDQ6VXNlcjY4NDA1MjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6840524?v=4","gravatar_id":"","url":"https://api.github.com/users/olifolkerd","html_url":"https://github.com/olifolkerd","followers_url":"https://api.github.com/users/olifolkerd/followers","following_url":"https://api.github.com/users/olifolkerd/following{/other_user}","gists_url":"https://api.github.com/users/olifolkerd/gists{/gist_id}","starred_url":"https://api.github.com/users/olifolkerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olifolkerd/subscriptions","organizations_url":"https://api.github.com/users/olifolkerd/orgs","repos_url":"https://api.github.com/users/olifolkerd/repos","events_url":"https://api.github.com/users/olifolkerd/events{/privacy}","received_events_url":"https://api.github.com/users/olifolkerd/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-07-02T12:02:58Z","updated_at":"2018-07-03T21:54:53Z","closed_at":"2018-07-03T21:54:53Z","author_association":"CONTRIBUTOR","body":"Hello! Is expected to have two different names for the select input?\r\n\r\nIs that because you would need to use the `editorParams` and `formatterParams` objects? If it is that, couldn't be better to reuse one of them? E.g. naive approach:\r\n\r\n```js\r\nTabulator.extendExtension('format', 'formatters', {\r\n  select(cell) {\r\n    return cell.getColumn().getDefinition().editorParams[cell.getValue()];\r\n  },\r\n});\r\n```\r\n\r\nOr instead, in the editor, use the formatterParams. Or maybe check first which of them is setted? With bigger param objects, more data you have to send from the server.\r\n\r\nThank you! Luciano."},"comment":{"url":"https://api.github.com/repos/olifolkerd/tabulator/issues/comments/402303261","html_url":"https://github.com/olifolkerd/tabulator/issues/1240#issuecomment-402303261","issue_url":"https://api.github.com/repos/olifolkerd/tabulator/issues/1240","id":402303261,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjMwMzI2MQ==","user":{"login":"olifolkerd","id":6840524,"node_id":"MDQ6VXNlcjY4NDA1MjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6840524?v=4","gravatar_id":"","url":"https://api.github.com/users/olifolkerd","html_url":"https://github.com/olifolkerd","followers_url":"https://api.github.com/users/olifolkerd/followers","following_url":"https://api.github.com/users/olifolkerd/following{/other_user}","gists_url":"https://api.github.com/users/olifolkerd/gists{/gist_id}","starred_url":"https://api.github.com/users/olifolkerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olifolkerd/subscriptions","organizations_url":"https://api.github.com/users/olifolkerd/orgs","repos_url":"https://api.github.com/users/olifolkerd/repos","events_url":"https://api.github.com/users/olifolkerd/events{/privacy}","received_events_url":"https://api.github.com/users/olifolkerd/received_events","type":"User","site_admin":false},"created_at":"2018-07-03T21:54:53Z","updated_at":"2018-07-03T21:54:53Z","author_association":"OWNER","body":"Hey @lgraziani2712 \r\n\r\nThanks for getting in touch,\r\n\r\nOn the whole the formatter and the editors used in Tabulator use very different params, the select/lookup option being one of the few where this is similar. that is why they are kept separate as it is the correct course for the majority of combinations.\r\n\r\nThere is nothing to stop you storing the params in a variable outside of tabulator and then referencing it twice, once for the editor and once for the formatter.\r\n\r\nCheers\r\n\r\nOli :)\r\n"}}
{"actor":{"display_login":"olifolkerd"}}