{"action":"created","comment":{"url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/pulls/comments/186896911","pull_request_review_id":118568225,"id":186896911,"diff_hunk":"@@ -1,8 +1,8 @@\n # Kubernetes Namespace Cleaner\n \n This is a python script to delete old namespace that are no longer use based on following 3 conditions:\n-1. namespace has allowCleanup in its annotations (prevent default/kube-system from being clean up)\n-2. namespace is inactive (no new deployment or deployment update for over a certain times, default is 5 days)\n+1. namespace has allowCleanup in its annotations (prevent default/kube-system from being clean up). We need to get this in our base yamls. \n+2. namespace is inactive (no new deployment or deployment update for over a certain times, default is 5 days) (still think one day is plenty and maybe minutes","path":"README.md","position":7,"original_position":7,"commit_id":"8bb98af011f17bab5af899bb148022f085ea6a91","original_commit_id":"8bb98af011f17bab5af899bb148022f085ea6a91","user":{"login":"tobytoyuito","id":10595504,"avatar_url":"https://avatars3.githubusercontent.com/u/10595504?v=4","gravatar_id":"","url":"https://api.github.com/users/tobytoyuito","html_url":"https://github.com/tobytoyuito","followers_url":"https://api.github.com/users/tobytoyuito/followers","following_url":"https://api.github.com/users/tobytoyuito/following{/other_user}","gists_url":"https://api.github.com/users/tobytoyuito/gists{/gist_id}","starred_url":"https://api.github.com/users/tobytoyuito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobytoyuito/subscriptions","organizations_url":"https://api.github.com/users/tobytoyuito/orgs","repos_url":"https://api.github.com/users/tobytoyuito/repos","events_url":"https://api.github.com/users/tobytoyuito/events{/privacy}","received_events_url":"https://api.github.com/users/tobytoyuito/received_events","type":"User","site_admin":false},"body":"keep one day for now? We can make change easily","created_at":"2018-05-08T23:32:05Z","updated_at":"2018-05-08T23:32:06Z","html_url":"https://github.com/tobytoyuito/kube-namespace-cleaner/pull/1#discussion_r186896911","pull_request_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/pulls/1","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/pulls/comments/186896911"},"html":{"href":"https://github.com/tobytoyuito/kube-namespace-cleaner/pull/1#discussion_r186896911"},"pull_request":{"href":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/pulls/1","id":186771397,"html_url":"https://github.com/tobytoyuito/kube-namespace-cleaner/pull/1","diff_url":"https://github.com/tobytoyuito/kube-namespace-cleaner/pull/1.diff","patch_url":"https://github.com/tobytoyuito/kube-namespace-cleaner/pull/1.patch","issue_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/issues/1","number":1,"state":"open","locked":false,"title":"comments!","user":{"login":"paulgmiller","id":1474379,"avatar_url":"https://avatars2.githubusercontent.com/u/1474379?v=4","gravatar_id":"","url":"https://api.github.com/users/paulgmiller","html_url":"https://github.com/paulgmiller","followers_url":"https://api.github.com/users/paulgmiller/followers","following_url":"https://api.github.com/users/paulgmiller/following{/other_user}","gists_url":"https://api.github.com/users/paulgmiller/gists{/gist_id}","starred_url":"https://api.github.com/users/paulgmiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulgmiller/subscriptions","organizations_url":"https://api.github.com/users/paulgmiller/orgs","repos_url":"https://api.github.com/users/paulgmiller/repos","events_url":"https://api.github.com/users/paulgmiller/events{/privacy}","received_events_url":"https://api.github.com/users/paulgmiller/received_events","type":"User","site_admin":false},"body":"Mostly this looks good. Just a few thngs that are mostly for fun. ","created_at":"2018-05-08T22:20:20Z","updated_at":"2018-05-08T23:32:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0216901cf7d9b695a5f700411579ac68c3540f7d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/pulls/1/commits","review_comments_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/pulls/1/comments","review_comment_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/issues/1/comments","statuses_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/statuses/8bb98af011f17bab5af899bb148022f085ea6a91","head":{"label":"paulgmiller:master","ref":"master","sha":"8bb98af011f17bab5af899bb148022f085ea6a91","user":{"login":"paulgmiller","id":1474379,"avatar_url":"https://avatars2.githubusercontent.com/u/1474379?v=4","gravatar_id":"","url":"https://api.github.com/users/paulgmiller","html_url":"https://github.com/paulgmiller","followers_url":"https://api.github.com/users/paulgmiller/followers","following_url":"https://api.github.com/users/paulgmiller/following{/other_user}","gists_url":"https://api.github.com/users/paulgmiller/gists{/gist_id}","starred_url":"https://api.github.com/users/paulgmiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulgmiller/subscriptions","organizations_url":"https://api.github.com/users/paulgmiller/orgs","repos_url":"https://api.github.com/users/paulgmiller/repos","events_url":"https://api.github.com/users/paulgmiller/events{/privacy}","received_events_url":"https://api.github.com/users/paulgmiller/received_events","type":"User","site_admin":false},"repo":{"id":132670368,"name":"kube-namespace-cleaner","full_name":"paulgmiller/kube-namespace-cleaner","owner":{"login":"paulgmiller","id":1474379,"avatar_url":"https://avatars2.githubusercontent.com/u/1474379?v=4","gravatar_id":"","url":"https://api.github.com/users/paulgmiller","html_url":"https://github.com/paulgmiller","followers_url":"https://api.github.com/users/paulgmiller/followers","following_url":"https://api.github.com/users/paulgmiller/following{/other_user}","gists_url":"https://api.github.com/users/paulgmiller/gists{/gist_id}","starred_url":"https://api.github.com/users/paulgmiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulgmiller/subscriptions","organizations_url":"https://api.github.com/users/paulgmiller/orgs","repos_url":"https://api.github.com/users/paulgmiller/repos","events_url":"https://api.github.com/users/paulgmiller/events{/privacy}","received_events_url":"https://api.github.com/users/paulgmiller/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paulgmiller/kube-namespace-cleaner","description":"Cronjob for Kubernetes to clean up Namespace based on certain criteria.","fork":true,"url":"https://api.github.com/repos/paulgmiller/kube-namespace-cleaner","forks_url":"https://api.github.com/repos/paulgmiller/kube-namespace-cleaner/forks","keys_url":"https://api.github.com/repos/paulgmiller/kube-namespace-cleaner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paulgmiller/kube-namespace-cleaner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paulgmiller/kube-namespace-cleaner/teams","hooks_url":"https://api.github.com/repos/paulgmiller/kube-namespace-cleaner/hooks","issue_events_url":"https://api.github.com/repos/paulgmiller/kube-namespace-cleaner/issues/events{/number}","events_url":"https://api.github.com/repos/paulgmiller/kube-namespace-cleaner/events","assignees_url":"https://api.github.com/repos/paulgmiller/kube-namespace-cleaner/assignees{/user}","branches_url":"https://api.github.com/repos/paulgmiller/kube-namespace-cleaner/branches{/branch}","tags_url":"https://api.github.com/repos/paulgmiller/kube-namespace-cleaner/tags","blobs_url":"https://api.github.com/repos/paulgmiller/kube-namespace-cleaner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paulgmiller/kube-namespace-cleaner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paulgmiller/kube-namespace-cleaner/git/refs{/sha}","trees_url":"https://api.github.com/repos/paulgmiller/kube-namespace-cleaner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paulgmiller/kube-namespace-cleaner/statuses/{sha}","languages_url":"https://api.github.com/repos/paulgmiller/kube-namespace-cleaner/languages","stargazers_url":"https://api.github.com/repos/paulgmiller/kube-namespace-cleaner/stargazers","contributors_url":"https://api.github.com/repos/paulgmiller/kube-namespace-cleaner/contributors","subscribers_url":"https://api.github.com/repos/paulgmiller/kube-namespace-cleaner/subscribers","subscription_url":"https://api.github.com/repos/paulgmiller/kube-namespace-cleaner/subscription","commits_url":"https://api.github.com/repos/paulgmiller/kube-namespace-cleaner/commits{/sha}","git_commits_url":"https://api.github.com/repos/paulgmiller/kube-namespace-cleaner/git/commits{/sha}","comments_url":"https://api.github.com/repos/paulgmiller/kube-namespace-cleaner/comments{/number}","issue_comment_url":"https://api.github.com/repos/paulgmiller/kube-namespace-cleaner/issues/comments{/number}","contents_url":"https://api.github.com/repos/paulgmiller/kube-namespace-cleaner/contents/{+path}","compare_url":"https://api.github.com/repos/paulgmiller/kube-namespace-cleaner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paulgmiller/kube-namespace-cleaner/merges","archive_url":"https://api.github.com/repos/paulgmiller/kube-namespace-cleaner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paulgmiller/kube-namespace-cleaner/downloads","issues_url":"https://api.github.com/repos/paulgmiller/kube-namespace-cleaner/issues{/number}","pulls_url":"https://api.github.com/repos/paulgmiller/kube-namespace-cleaner/pulls{/number}","milestones_url":"https://api.github.com/repos/paulgmiller/kube-namespace-cleaner/milestones{/number}","notifications_url":"https://api.github.com/repos/paulgmiller/kube-namespace-cleaner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paulgmiller/kube-namespace-cleaner/labels{/name}","releases_url":"https://api.github.com/repos/paulgmiller/kube-namespace-cleaner/releases{/id}","deployments_url":"https://api.github.com/repos/paulgmiller/kube-namespace-cleaner/deployments","created_at":"2018-05-08T22:07:41Z","updated_at":"2018-05-08T22:19:45Z","pushed_at":"2018-05-08T22:19:44Z","git_url":"git://github.com/paulgmiller/kube-namespace-cleaner.git","ssh_url":"git@github.com:paulgmiller/kube-namespace-cleaner.git","clone_url":"https://github.com/paulgmiller/kube-namespace-cleaner.git","svn_url":"https://github.com/paulgmiller/kube-namespace-cleaner","homepage":"","size":7,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tobytoyuito:master","ref":"master","sha":"db2ac45c6ab5e56b38c9b55a8c26ced15389b679","user":{"login":"tobytoyuito","id":10595504,"avatar_url":"https://avatars3.githubusercontent.com/u/10595504?v=4","gravatar_id":"","url":"https://api.github.com/users/tobytoyuito","html_url":"https://github.com/tobytoyuito","followers_url":"https://api.github.com/users/tobytoyuito/followers","following_url":"https://api.github.com/users/tobytoyuito/following{/other_user}","gists_url":"https://api.github.com/users/tobytoyuito/gists{/gist_id}","starred_url":"https://api.github.com/users/tobytoyuito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobytoyuito/subscriptions","organizations_url":"https://api.github.com/users/tobytoyuito/orgs","repos_url":"https://api.github.com/users/tobytoyuito/repos","events_url":"https://api.github.com/users/tobytoyuito/events{/privacy}","received_events_url":"https://api.github.com/users/tobytoyuito/received_events","type":"User","site_admin":false},"repo":{"id":132178319,"name":"kube-namespace-cleaner","full_name":"tobytoyuito/kube-namespace-cleaner","owner":{"login":"tobytoyuito","id":10595504,"avatar_url":"https://avatars3.githubusercontent.com/u/10595504?v=4","gravatar_id":"","url":"https://api.github.com/users/tobytoyuito","html_url":"https://github.com/tobytoyuito","followers_url":"https://api.github.com/users/tobytoyuito/followers","following_url":"https://api.github.com/users/tobytoyuito/following{/other_user}","gists_url":"https://api.github.com/users/tobytoyuito/gists{/gist_id}","starred_url":"https://api.github.com/users/tobytoyuito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobytoyuito/subscriptions","organizations_url":"https://api.github.com/users/tobytoyuito/orgs","repos_url":"https://api.github.com/users/tobytoyuito/repos","events_url":"https://api.github.com/users/tobytoyuito/events{/privacy}","received_events_url":"https://api.github.com/users/tobytoyuito/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tobytoyuito/kube-namespace-cleaner","description":"Cronjob for Kubernetes to clean up Namespace based on certain criteria.","fork":false,"url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner","forks_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/forks","keys_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/teams","hooks_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/hooks","issue_events_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/issues/events{/number}","events_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/events","assignees_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/assignees{/user}","branches_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/branches{/branch}","tags_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/tags","blobs_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/git/refs{/sha}","trees_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/statuses/{sha}","languages_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/languages","stargazers_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/stargazers","contributors_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/contributors","subscribers_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/subscribers","subscription_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/subscription","commits_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/commits{/sha}","git_commits_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/git/commits{/sha}","comments_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/comments{/number}","issue_comment_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/issues/comments{/number}","contents_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/contents/{+path}","compare_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/merges","archive_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/downloads","issues_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/issues{/number}","pulls_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/pulls{/number}","milestones_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/milestones{/number}","notifications_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/labels{/name}","releases_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/releases{/id}","deployments_url":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/deployments","created_at":"2018-05-04T19:00:00Z","updated_at":"2018-05-08T21:43:00Z","pushed_at":"2018-05-08T22:20:21Z","git_url":"git://github.com/tobytoyuito/kube-namespace-cleaner.git","ssh_url":"git@github.com:tobytoyuito/kube-namespace-cleaner.git","clone_url":"https://github.com/tobytoyuito/kube-namespace-cleaner.git","svn_url":"https://github.com/tobytoyuito/kube-namespace-cleaner","homepage":"","size":5,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/pulls/1"},"html":{"href":"https://github.com/tobytoyuito/kube-namespace-cleaner/pull/1"},"issue":{"href":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/issues/1"},"comments":{"href":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/tobytoyuito/kube-namespace-cleaner/statuses/8bb98af011f17bab5af899bb148022f085ea6a91"}},"author_association":"NONE"}}
{"actor":{"display_login":"tobytoyuito"}}