{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/hono/pulls/comments/211559911","pull_request_review_id":148002917,"id":211559911,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTU1OTkxMQ==","diff_hunk":"@@ -0,0 +1,217 @@\n+/*******************************************************************************\n+ * Copyright (c) 2016, 2018 Contributors to the Eclipse Foundation\n+ *\n+ * See the NOTICE file(s) distributed with this work for additional\n+ * information regarding copyright ownership.\n+ *\n+ * This program and the accompanying materials are made available under the\n+ * terms of the Eclipse Public License 2.0 which is available at\n+ * http://www.eclipse.org/legal/epl-2.0\n+ *\n+ * SPDX-License-Identifier: EPL-2.0\n+ *******************************************************************************/\n+package org.eclipse.hono.service.registration;\n+\n+import java.net.HttpURLConnection;\n+import java.util.Objects;\n+\n+import org.eclipse.hono.client.ClientErrorException;\n+import org.eclipse.hono.util.EventBusMessage;\n+import org.eclipse.hono.util.RegistrationConstants;\n+import org.eclipse.hono.util.RegistrationResult;\n+\n+import io.vertx.core.AsyncResult;\n+import io.vertx.core.Future;\n+import io.vertx.core.Handler;\n+import io.vertx.core.json.JsonObject;\n+\n+/**\n+ * Base class for implementing {@link CompleteRegistrationService}s.\n+ * <p>\n+ * In particular, this base class provides support for receiving service invocation request messages\n+ * via vert.x' event bus and route them to specific methods corresponding to the operation indicated\n+ * in the message.\n+ *\n+ * @param <T> The type of configuration properties this service requires.\n+ */\n+public abstract class CompleteBaseRegistrationService<T> extends BaseRegistrationService implements CompleteRegistrationService {","path":"service-base/src/main/java/org/eclipse/hono/service/registration/CompleteBaseRegistrationService.java","position":37,"original_position":37,"commit_id":"c312d1d2ef927c2467f79414de6e52abfa93a252","original_commit_id":"c312d1d2ef927c2467f79414de6e52abfa93a252","user":{"login":"dejanb","id":141611,"node_id":"MDQ6VXNlcjE0MTYxMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/141611?v=4","gravatar_id":"","url":"https://api.github.com/users/dejanb","html_url":"https://github.com/dejanb","followers_url":"https://api.github.com/users/dejanb/followers","following_url":"https://api.github.com/users/dejanb/following{/other_user}","gists_url":"https://api.github.com/users/dejanb/gists{/gist_id}","starred_url":"https://api.github.com/users/dejanb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dejanb/subscriptions","organizations_url":"https://api.github.com/users/dejanb/orgs","repos_url":"https://api.github.com/users/dejanb/repos","events_url":"https://api.github.com/users/dejanb/events{/privacy}","received_events_url":"https://api.github.com/users/dejanb/received_events","type":"User","site_admin":false},"body":"This should be `extends BaseRegistrationService<T>` to avoid erasure errors","created_at":"2018-08-21T10:45:51Z","updated_at":"2018-08-21T10:48:21Z","html_url":"https://github.com/eclipse/hono/pull/789#discussion_r211559911","pull_request_url":"https://api.github.com/repos/eclipse/hono/pulls/789","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/hono/pulls/comments/211559911"},"html":{"href":"https://github.com/eclipse/hono/pull/789#discussion_r211559911"},"pull_request":{"href":"https://api.github.com/repos/eclipse/hono/pulls/789"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/hono/pulls/789","id":209567692,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NTY3Njky","html_url":"https://github.com/eclipse/hono/pull/789","diff_url":"https://github.com/eclipse/hono/pull/789.diff","patch_url":"https://github.com/eclipse/hono/pull/789.patch","issue_url":"https://api.github.com/repos/eclipse/hono/issues/789","number":789,"state":"open","locked":false,"title":"[WIP]Device registry api refactor","user":{"login":"jbtrystram","id":12406409,"node_id":"MDQ6VXNlcjEyNDA2NDA5","avatar_url":"https://avatars1.githubusercontent.com/u/12406409?v=4","gravatar_id":"","url":"https://api.github.com/users/jbtrystram","html_url":"https://github.com/jbtrystram","followers_url":"https://api.github.com/users/jbtrystram/followers","following_url":"https://api.github.com/users/jbtrystram/following{/other_user}","gists_url":"https://api.github.com/users/jbtrystram/gists{/gist_id}","starred_url":"https://api.github.com/users/jbtrystram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbtrystram/subscriptions","organizations_url":"https://api.github.com/users/jbtrystram/orgs","repos_url":"https://api.github.com/users/jbtrystram/repos","events_url":"https://api.github.com/users/jbtrystram/events{/privacy}","received_events_url":"https://api.github.com/users/jbtrystram/received_events","type":"User","site_admin":false},"body":"This is some initial work toward https://github.com/eclipse/hono/issues/783\r\nhere is what I have came up with\r\n![Device Registry API refactor](https://user-images.githubusercontent.com/12406409/44387652-66fd0b80-a526-11e8-98a4-a3673908a2d0.jpg)\r\n\r\nThis is WIP, as the relevant tests need to be adjusted still. Please feel free to comment and suggest improvements!","created_at":"2018-08-20T15:56:55Z","updated_at":"2018-08-21T10:48:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8513e95cc92eda4727c1fb97750559475ffccf29","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/hono/pulls/789/commits","review_comments_url":"https://api.github.com/repos/eclipse/hono/pulls/789/comments","review_comment_url":"https://api.github.com/repos/eclipse/hono/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/hono/issues/789/comments","statuses_url":"https://api.github.com/repos/eclipse/hono/statuses/c312d1d2ef927c2467f79414de6e52abfa93a252","head":{"label":"jbtrystram:device_registry_api_refactor","ref":"device_registry_api_refactor","sha":"c312d1d2ef927c2467f79414de6e52abfa93a252","user":{"login":"jbtrystram","id":12406409,"node_id":"MDQ6VXNlcjEyNDA2NDA5","avatar_url":"https://avatars1.githubusercontent.com/u/12406409?v=4","gravatar_id":"","url":"https://api.github.com/users/jbtrystram","html_url":"https://github.com/jbtrystram","followers_url":"https://api.github.com/users/jbtrystram/followers","following_url":"https://api.github.com/users/jbtrystram/following{/other_user}","gists_url":"https://api.github.com/users/jbtrystram/gists{/gist_id}","starred_url":"https://api.github.com/users/jbtrystram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbtrystram/subscriptions","organizations_url":"https://api.github.com/users/jbtrystram/orgs","repos_url":"https://api.github.com/users/jbtrystram/repos","events_url":"https://api.github.com/users/jbtrystram/events{/privacy}","received_events_url":"https://api.github.com/users/jbtrystram/received_events","type":"User","site_admin":false},"repo":{"id":144995569,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ5OTU1Njk=","name":"hono","full_name":"jbtrystram/hono","owner":{"login":"jbtrystram","id":12406409,"node_id":"MDQ6VXNlcjEyNDA2NDA5","avatar_url":"https://avatars1.githubusercontent.com/u/12406409?v=4","gravatar_id":"","url":"https://api.github.com/users/jbtrystram","html_url":"https://github.com/jbtrystram","followers_url":"https://api.github.com/users/jbtrystram/followers","following_url":"https://api.github.com/users/jbtrystram/following{/other_user}","gists_url":"https://api.github.com/users/jbtrystram/gists{/gist_id}","starred_url":"https://api.github.com/users/jbtrystram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbtrystram/subscriptions","organizations_url":"https://api.github.com/users/jbtrystram/orgs","repos_url":"https://api.github.com/users/jbtrystram/repos","events_url":"https://api.github.com/users/jbtrystram/events{/privacy}","received_events_url":"https://api.github.com/users/jbtrystram/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jbtrystram/hono","description":"Eclipse Hono™ Project","fork":true,"url":"https://api.github.com/repos/jbtrystram/hono","forks_url":"https://api.github.com/repos/jbtrystram/hono/forks","keys_url":"https://api.github.com/repos/jbtrystram/hono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbtrystram/hono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbtrystram/hono/teams","hooks_url":"https://api.github.com/repos/jbtrystram/hono/hooks","issue_events_url":"https://api.github.com/repos/jbtrystram/hono/issues/events{/number}","events_url":"https://api.github.com/repos/jbtrystram/hono/events","assignees_url":"https://api.github.com/repos/jbtrystram/hono/assignees{/user}","branches_url":"https://api.github.com/repos/jbtrystram/hono/branches{/branch}","tags_url":"https://api.github.com/repos/jbtrystram/hono/tags","blobs_url":"https://api.github.com/repos/jbtrystram/hono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbtrystram/hono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbtrystram/hono/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbtrystram/hono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbtrystram/hono/statuses/{sha}","languages_url":"https://api.github.com/repos/jbtrystram/hono/languages","stargazers_url":"https://api.github.com/repos/jbtrystram/hono/stargazers","contributors_url":"https://api.github.com/repos/jbtrystram/hono/contributors","subscribers_url":"https://api.github.com/repos/jbtrystram/hono/subscribers","subscription_url":"https://api.github.com/repos/jbtrystram/hono/subscription","commits_url":"https://api.github.com/repos/jbtrystram/hono/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbtrystram/hono/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbtrystram/hono/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbtrystram/hono/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbtrystram/hono/contents/{+path}","compare_url":"https://api.github.com/repos/jbtrystram/hono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbtrystram/hono/merges","archive_url":"https://api.github.com/repos/jbtrystram/hono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbtrystram/hono/downloads","issues_url":"https://api.github.com/repos/jbtrystram/hono/issues{/number}","pulls_url":"https://api.github.com/repos/jbtrystram/hono/pulls{/number}","milestones_url":"https://api.github.com/repos/jbtrystram/hono/milestones{/number}","notifications_url":"https://api.github.com/repos/jbtrystram/hono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbtrystram/hono/labels{/name}","releases_url":"https://api.github.com/repos/jbtrystram/hono/releases{/id}","deployments_url":"https://api.github.com/repos/jbtrystram/hono/deployments","created_at":"2018-08-16T14:00:21Z","updated_at":"2018-08-16T14:00:25Z","pushed_at":"2018-08-21T07:15:10Z","git_url":"git://github.com/jbtrystram/hono.git","ssh_url":"git@github.com:jbtrystram/hono.git","clone_url":"https://github.com/jbtrystram/hono.git","svn_url":"https://github.com/jbtrystram/hono","homepage":"http://www.eclipse.org/hono","size":15764,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"bfe04e75b308dc873e3fbcbd38fc38c9732d91ad","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":51307016,"node_id":"MDEwOlJlcG9zaXRvcnk1MTMwNzAxNg==","name":"hono","full_name":"eclipse/hono","owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/hono","description":"Eclipse Hono™ Project","fork":false,"url":"https://api.github.com/repos/eclipse/hono","forks_url":"https://api.github.com/repos/eclipse/hono/forks","keys_url":"https://api.github.com/repos/eclipse/hono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/hono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/hono/teams","hooks_url":"https://api.github.com/repos/eclipse/hono/hooks","issue_events_url":"https://api.github.com/repos/eclipse/hono/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/hono/events","assignees_url":"https://api.github.com/repos/eclipse/hono/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/hono/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/hono/tags","blobs_url":"https://api.github.com/repos/eclipse/hono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/hono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/hono/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/hono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/hono/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/hono/languages","stargazers_url":"https://api.github.com/repos/eclipse/hono/stargazers","contributors_url":"https://api.github.com/repos/eclipse/hono/contributors","subscribers_url":"https://api.github.com/repos/eclipse/hono/subscribers","subscription_url":"https://api.github.com/repos/eclipse/hono/subscription","commits_url":"https://api.github.com/repos/eclipse/hono/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/hono/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/hono/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/hono/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/hono/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/hono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/hono/merges","archive_url":"https://api.github.com/repos/eclipse/hono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/hono/downloads","issues_url":"https://api.github.com/repos/eclipse/hono/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/hono/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/hono/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/hono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/hono/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/hono/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/hono/deployments","created_at":"2016-02-08T15:45:28Z","updated_at":"2018-08-21T08:57:59Z","pushed_at":"2018-08-21T09:42:04Z","git_url":"git://github.com/eclipse/hono.git","ssh_url":"git@github.com:eclipse/hono.git","clone_url":"https://github.com/eclipse/hono.git","svn_url":"https://github.com/eclipse/hono","homepage":"http://www.eclipse.org/hono","size":15530,"stargazers_count":159,"watchers_count":159,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":53,"mirror_url":null,"archived":false,"open_issues_count":66,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":53,"open_issues":66,"watchers":159,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/hono/pulls/789"},"html":{"href":"https://github.com/eclipse/hono/pull/789"},"issue":{"href":"https://api.github.com/repos/eclipse/hono/issues/789"},"comments":{"href":"https://api.github.com/repos/eclipse/hono/issues/789/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/hono/pulls/789/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/hono/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/hono/pulls/789/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/hono/statuses/c312d1d2ef927c2467f79414de6e52abfa93a252"}},"author_association":"NONE"}}
{"actor":{"display_login":"dejanb"}}