{"action":"created","issue":{"url":"https://api.github.com/repos/freifunk-berlin/firmware/issues/616","repository_url":"https://api.github.com/repos/freifunk-berlin/firmware","labels_url":"https://api.github.com/repos/freifunk-berlin/firmware/issues/616/labels{/name}","comments_url":"https://api.github.com/repos/freifunk-berlin/firmware/issues/616/comments","events_url":"https://api.github.com/repos/freifunk-berlin/firmware/issues/616/events","html_url":"https://github.com/freifunk-berlin/firmware/issues/616","id":379549946,"node_id":"MDU6SXNzdWUzNzk1NDk5NDY=","number":616,"title":"feeds.conf: comments about additional feeds would be useful","user":{"login":"pmelange","id":20710446,"node_id":"MDQ6VXNlcjIwNzEwNDQ2","avatar_url":"https://avatars0.githubusercontent.com/u/20710446?v=4","gravatar_id":"","url":"https://api.github.com/users/pmelange","html_url":"https://github.com/pmelange","followers_url":"https://api.github.com/users/pmelange/followers","following_url":"https://api.github.com/users/pmelange/following{/other_user}","gists_url":"https://api.github.com/users/pmelange/gists{/gist_id}","starred_url":"https://api.github.com/users/pmelange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmelange/subscriptions","organizations_url":"https://api.github.com/users/pmelange/orgs","repos_url":"https://api.github.com/users/pmelange/repos","events_url":"https://api.github.com/users/pmelange/events{/privacy}","received_events_url":"https://api.github.com/users/pmelange/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-11-11T18:36:45Z","updated_at":"2018-11-12T12:04:41Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"I recommend adding comments to feeds.conf.  Here is my proposal:\r\n\r\n```\r\n###\r\n# OpenWrt\r\n#\r\nsrc-git packages https://github.com/openwrt/packages.git^327a03e8f0c61f8ee98adbee5bd37ce7bccbb049\r\nsrc-git luci https://github.com/openwrt/luci.git^5ec72617eede467c932642b60291d627fca70342\r\nsrc-git routing https://github.com/openwrt-routing/packages.git^1b9d1c419f0ecefda51922a7845ab2183d6acd76\r\n###\r\n# Freifunk Berlin\r\n#   packages_berlin: addons, defaults, uplinks, utils\r\n#\r\nsrc-git packages_berlin https://github.com/freifunk-berlin/firmware-packages.git^d21ec055dc7ce199837f60e323639e9b4ca4054a\r\n###\r\n# Addtional\r\n#   gluon: l3roamd, simple-tc\r\nsrc-git gluon https://github.com/freifunk-gluon/packages.git^c34d129afb48f225741b683127beee6ba3c169d2\r\n\r\n##\r\n# just for reference (syntax of different feed-sources)\r\n# see https://wiki.openwrt.org/doc/devel/feeds for more info\r\n##\r\n#src-git packages_berlin https://github.com/freifunk-berlin/firmware-packages.git;master\r\n#src-link packages_berlin ../../../firmware-packages\r\n```"},"comment":{"url":"https://api.github.com/repos/freifunk-berlin/firmware/issues/comments/437855426","html_url":"https://github.com/freifunk-berlin/firmware/issues/616#issuecomment-437855426","issue_url":"https://api.github.com/repos/freifunk-berlin/firmware/issues/616","id":437855426,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzg1NTQyNg==","user":{"login":"pmelange","id":20710446,"node_id":"MDQ6VXNlcjIwNzEwNDQ2","avatar_url":"https://avatars0.githubusercontent.com/u/20710446?v=4","gravatar_id":"","url":"https://api.github.com/users/pmelange","html_url":"https://github.com/pmelange","followers_url":"https://api.github.com/users/pmelange/followers","following_url":"https://api.github.com/users/pmelange/following{/other_user}","gists_url":"https://api.github.com/users/pmelange/gists{/gist_id}","starred_url":"https://api.github.com/users/pmelange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmelange/subscriptions","organizations_url":"https://api.github.com/users/pmelange/orgs","repos_url":"https://api.github.com/users/pmelange/repos","events_url":"https://api.github.com/users/pmelange/events{/privacy}","received_events_url":"https://api.github.com/users/pmelange/received_events","type":"User","site_admin":false},"created_at":"2018-11-12T12:04:41Z","updated_at":"2018-11-12T12:04:41Z","author_association":"CONTRIBUTOR","body":"I still think that it makes sense to have comments in the feeds.conf file.  Having this information readily available without having to compile is documentation.  Needing to compile to find out what is happening is not documentation.  \r\n\r\nSure, the information could be placed somewhere else, like in a buried commit message, but that is still not the obvious place for (new) developers to look.\r\n"}}
{"actor":{"display_login":"pmelange"}}