{"action":"created","comment":{"url":"https://api.github.com/repos/treasure-data/digdag/pulls/comments/215364429","pull_request_review_id":152612034,"id":215364429,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTM2NDQyOQ==","diff_hunk":"@@ -208,9 +214,12 @@ public void list(String keyPrefix, FileListing callback)\n     @Override\n     public Optional<DirectUploadHandle> getDirectUploadHandle(String key)\n     {\n+        final long secondsToExpire = config.has(\"direct_upload_expiration\") ?\n+                config.get(\"direct_upload_expiration\", Long.class) : 10*60;","path":"digdag-storage-s3/src/main/java/io/digdag/storage/s3/S3Storage.java","position":44,"original_position":44,"commit_id":"d72f867dab2b138ec43895de76331e76bf391bd0","original_commit_id":"d72f867dab2b138ec43895de76331e76bf391bd0","user":{"login":"serihiro","id":681496,"node_id":"MDQ6VXNlcjY4MTQ5Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/681496?v=4","gravatar_id":"","url":"https://api.github.com/users/serihiro","html_url":"https://github.com/serihiro","followers_url":"https://api.github.com/users/serihiro/followers","following_url":"https://api.github.com/users/serihiro/following{/other_user}","gists_url":"https://api.github.com/users/serihiro/gists{/gist_id}","starred_url":"https://api.github.com/users/serihiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serihiro/subscriptions","organizations_url":"https://api.github.com/users/serihiro/orgs","repos_url":"https://api.github.com/users/serihiro/repos","events_url":"https://api.github.com/users/serihiro/events{/privacy}","received_events_url":"https://api.github.com/users/serihiro/received_events","type":"User","site_admin":false},"body":"ditto","created_at":"2018-09-05T17:42:37Z","updated_at":"2018-09-05T17:42:37Z","html_url":"https://github.com/treasure-data/digdag/pull/856#discussion_r215364429","pull_request_url":"https://api.github.com/repos/treasure-data/digdag/pulls/856","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/treasure-data/digdag/pulls/comments/215364429"},"html":{"href":"https://github.com/treasure-data/digdag/pull/856#discussion_r215364429"},"pull_request":{"href":"https://api.github.com/repos/treasure-data/digdag/pulls/856"}}},"pull_request":{"url":"https://api.github.com/repos/treasure-data/digdag/pulls/856","id":213130719,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMTMwNzE5","html_url":"https://github.com/treasure-data/digdag/pull/856","diff_url":"https://github.com/treasure-data/digdag/pull/856.diff","patch_url":"https://github.com/treasure-data/digdag/pull/856.patch","issue_url":"https://api.github.com/repos/treasure-data/digdag/issues/856","number":856,"state":"open","locked":false,"title":"Add 'direct_upload_' and 'direct_download_expiration' options to S3Storage to customize expiration of pre-signed URLs","user":{"login":"muga","id":127959,"node_id":"MDQ6VXNlcjEyNzk1OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/127959?v=4","gravatar_id":"","url":"https://api.github.com/users/muga","html_url":"https://github.com/muga","followers_url":"https://api.github.com/users/muga/followers","following_url":"https://api.github.com/users/muga/following{/other_user}","gists_url":"https://api.github.com/users/muga/gists{/gist_id}","starred_url":"https://api.github.com/users/muga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muga/subscriptions","organizations_url":"https://api.github.com/users/muga/orgs","repos_url":"https://api.github.com/users/muga/repos","events_url":"https://api.github.com/users/muga/events{/privacy}","received_events_url":"https://api.github.com/users/muga/received_events","type":"User","site_admin":false},"body":"This PR adds 'direct_upload_' and 'direct_download_expiration' options to S3Storage to customize expiration for pre-signed URLs. The default values of expiration are not changed.","created_at":"2018-09-04T23:30:52Z","updated_at":"2018-09-05T17:42:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f6b13f03f44b5241d78da866496e684573da9bbf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/treasure-data/digdag/pulls/856/commits","review_comments_url":"https://api.github.com/repos/treasure-data/digdag/pulls/856/comments","review_comment_url":"https://api.github.com/repos/treasure-data/digdag/pulls/comments{/number}","comments_url":"https://api.github.com/repos/treasure-data/digdag/issues/856/comments","statuses_url":"https://api.github.com/repos/treasure-data/digdag/statuses/d72f867dab2b138ec43895de76331e76bf391bd0","head":{"label":"muga:customize_expiration_of_presigned_url_generated_by_s3storage","ref":"customize_expiration_of_presigned_url_generated_by_s3storage","sha":"d72f867dab2b138ec43895de76331e76bf391bd0","user":{"login":"muga","id":127959,"node_id":"MDQ6VXNlcjEyNzk1OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/127959?v=4","gravatar_id":"","url":"https://api.github.com/users/muga","html_url":"https://github.com/muga","followers_url":"https://api.github.com/users/muga/followers","following_url":"https://api.github.com/users/muga/following{/other_user}","gists_url":"https://api.github.com/users/muga/gists{/gist_id}","starred_url":"https://api.github.com/users/muga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muga/subscriptions","organizations_url":"https://api.github.com/users/muga/orgs","repos_url":"https://api.github.com/users/muga/repos","events_url":"https://api.github.com/users/muga/events{/privacy}","received_events_url":"https://api.github.com/users/muga/received_events","type":"User","site_admin":false},"repo":{"id":128473150,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg0NzMxNTA=","name":"digdag","full_name":"muga/digdag","owner":{"login":"muga","id":127959,"node_id":"MDQ6VXNlcjEyNzk1OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/127959?v=4","gravatar_id":"","url":"https://api.github.com/users/muga","html_url":"https://github.com/muga","followers_url":"https://api.github.com/users/muga/followers","following_url":"https://api.github.com/users/muga/following{/other_user}","gists_url":"https://api.github.com/users/muga/gists{/gist_id}","starred_url":"https://api.github.com/users/muga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muga/subscriptions","organizations_url":"https://api.github.com/users/muga/orgs","repos_url":"https://api.github.com/users/muga/repos","events_url":"https://api.github.com/users/muga/events{/privacy}","received_events_url":"https://api.github.com/users/muga/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/muga/digdag","description":"Workload Automation System","fork":true,"url":"https://api.github.com/repos/muga/digdag","forks_url":"https://api.github.com/repos/muga/digdag/forks","keys_url":"https://api.github.com/repos/muga/digdag/keys{/key_id}","collaborators_url":"https://api.github.com/repos/muga/digdag/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/muga/digdag/teams","hooks_url":"https://api.github.com/repos/muga/digdag/hooks","issue_events_url":"https://api.github.com/repos/muga/digdag/issues/events{/number}","events_url":"https://api.github.com/repos/muga/digdag/events","assignees_url":"https://api.github.com/repos/muga/digdag/assignees{/user}","branches_url":"https://api.github.com/repos/muga/digdag/branches{/branch}","tags_url":"https://api.github.com/repos/muga/digdag/tags","blobs_url":"https://api.github.com/repos/muga/digdag/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/muga/digdag/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/muga/digdag/git/refs{/sha}","trees_url":"https://api.github.com/repos/muga/digdag/git/trees{/sha}","statuses_url":"https://api.github.com/repos/muga/digdag/statuses/{sha}","languages_url":"https://api.github.com/repos/muga/digdag/languages","stargazers_url":"https://api.github.com/repos/muga/digdag/stargazers","contributors_url":"https://api.github.com/repos/muga/digdag/contributors","subscribers_url":"https://api.github.com/repos/muga/digdag/subscribers","subscription_url":"https://api.github.com/repos/muga/digdag/subscription","commits_url":"https://api.github.com/repos/muga/digdag/commits{/sha}","git_commits_url":"https://api.github.com/repos/muga/digdag/git/commits{/sha}","comments_url":"https://api.github.com/repos/muga/digdag/comments{/number}","issue_comment_url":"https://api.github.com/repos/muga/digdag/issues/comments{/number}","contents_url":"https://api.github.com/repos/muga/digdag/contents/{+path}","compare_url":"https://api.github.com/repos/muga/digdag/compare/{base}...{head}","merges_url":"https://api.github.com/repos/muga/digdag/merges","archive_url":"https://api.github.com/repos/muga/digdag/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/muga/digdag/downloads","issues_url":"https://api.github.com/repos/muga/digdag/issues{/number}","pulls_url":"https://api.github.com/repos/muga/digdag/pulls{/number}","milestones_url":"https://api.github.com/repos/muga/digdag/milestones{/number}","notifications_url":"https://api.github.com/repos/muga/digdag/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/muga/digdag/labels{/name}","releases_url":"https://api.github.com/repos/muga/digdag/releases{/id}","deployments_url":"https://api.github.com/repos/muga/digdag/deployments","created_at":"2018-04-06T21:41:28Z","updated_at":"2018-07-18T00:11:00Z","pushed_at":"2018-09-04T23:27:56Z","git_url":"git://github.com/muga/digdag.git","ssh_url":"git@github.com:muga/digdag.git","clone_url":"https://github.com/muga/digdag.git","svn_url":"https://github.com/muga/digdag","homepage":"http://www.digdag.io/","size":55753,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"treasure-data:master","ref":"master","sha":"78d51f4eda8fdc9f2d985b0e30350dc97bf21995","user":{"login":"treasure-data","id":747746,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0Nzc0Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/747746?v=4","gravatar_id":"","url":"https://api.github.com/users/treasure-data","html_url":"https://github.com/treasure-data","followers_url":"https://api.github.com/users/treasure-data/followers","following_url":"https://api.github.com/users/treasure-data/following{/other_user}","gists_url":"https://api.github.com/users/treasure-data/gists{/gist_id}","starred_url":"https://api.github.com/users/treasure-data/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/treasure-data/subscriptions","organizations_url":"https://api.github.com/users/treasure-data/orgs","repos_url":"https://api.github.com/users/treasure-data/repos","events_url":"https://api.github.com/users/treasure-data/events{/privacy}","received_events_url":"https://api.github.com/users/treasure-data/received_events","type":"Organization","site_admin":false},"repo":{"id":42751387,"node_id":"MDEwOlJlcG9zaXRvcnk0Mjc1MTM4Nw==","name":"digdag","full_name":"treasure-data/digdag","owner":{"login":"treasure-data","id":747746,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0Nzc0Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/747746?v=4","gravatar_id":"","url":"https://api.github.com/users/treasure-data","html_url":"https://github.com/treasure-data","followers_url":"https://api.github.com/users/treasure-data/followers","following_url":"https://api.github.com/users/treasure-data/following{/other_user}","gists_url":"https://api.github.com/users/treasure-data/gists{/gist_id}","starred_url":"https://api.github.com/users/treasure-data/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/treasure-data/subscriptions","organizations_url":"https://api.github.com/users/treasure-data/orgs","repos_url":"https://api.github.com/users/treasure-data/repos","events_url":"https://api.github.com/users/treasure-data/events{/privacy}","received_events_url":"https://api.github.com/users/treasure-data/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/treasure-data/digdag","description":"Workload Automation System","fork":false,"url":"https://api.github.com/repos/treasure-data/digdag","forks_url":"https://api.github.com/repos/treasure-data/digdag/forks","keys_url":"https://api.github.com/repos/treasure-data/digdag/keys{/key_id}","collaborators_url":"https://api.github.com/repos/treasure-data/digdag/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/treasure-data/digdag/teams","hooks_url":"https://api.github.com/repos/treasure-data/digdag/hooks","issue_events_url":"https://api.github.com/repos/treasure-data/digdag/issues/events{/number}","events_url":"https://api.github.com/repos/treasure-data/digdag/events","assignees_url":"https://api.github.com/repos/treasure-data/digdag/assignees{/user}","branches_url":"https://api.github.com/repos/treasure-data/digdag/branches{/branch}","tags_url":"https://api.github.com/repos/treasure-data/digdag/tags","blobs_url":"https://api.github.com/repos/treasure-data/digdag/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/treasure-data/digdag/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/treasure-data/digdag/git/refs{/sha}","trees_url":"https://api.github.com/repos/treasure-data/digdag/git/trees{/sha}","statuses_url":"https://api.github.com/repos/treasure-data/digdag/statuses/{sha}","languages_url":"https://api.github.com/repos/treasure-data/digdag/languages","stargazers_url":"https://api.github.com/repos/treasure-data/digdag/stargazers","contributors_url":"https://api.github.com/repos/treasure-data/digdag/contributors","subscribers_url":"https://api.github.com/repos/treasure-data/digdag/subscribers","subscription_url":"https://api.github.com/repos/treasure-data/digdag/subscription","commits_url":"https://api.github.com/repos/treasure-data/digdag/commits{/sha}","git_commits_url":"https://api.github.com/repos/treasure-data/digdag/git/commits{/sha}","comments_url":"https://api.github.com/repos/treasure-data/digdag/comments{/number}","issue_comment_url":"https://api.github.com/repos/treasure-data/digdag/issues/comments{/number}","contents_url":"https://api.github.com/repos/treasure-data/digdag/contents/{+path}","compare_url":"https://api.github.com/repos/treasure-data/digdag/compare/{base}...{head}","merges_url":"https://api.github.com/repos/treasure-data/digdag/merges","archive_url":"https://api.github.com/repos/treasure-data/digdag/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/treasure-data/digdag/downloads","issues_url":"https://api.github.com/repos/treasure-data/digdag/issues{/number}","pulls_url":"https://api.github.com/repos/treasure-data/digdag/pulls{/number}","milestones_url":"https://api.github.com/repos/treasure-data/digdag/milestones{/number}","notifications_url":"https://api.github.com/repos/treasure-data/digdag/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/treasure-data/digdag/labels{/name}","releases_url":"https://api.github.com/repos/treasure-data/digdag/releases{/id}","deployments_url":"https://api.github.com/repos/treasure-data/digdag/deployments","created_at":"2015-09-18T23:18:08Z","updated_at":"2018-08-31T08:45:32Z","pushed_at":"2018-09-05T14:17:20Z","git_url":"git://github.com/treasure-data/digdag.git","ssh_url":"git@github.com:treasure-data/digdag.git","clone_url":"https://github.com/treasure-data/digdag.git","svn_url":"https://github.com/treasure-data/digdag","homepage":"https://www.digdag.io/","size":78739,"stargazers_count":628,"watchers_count":628,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":107,"mirror_url":null,"archived":false,"open_issues_count":122,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":107,"open_issues":122,"watchers":628,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/treasure-data/digdag/pulls/856"},"html":{"href":"https://github.com/treasure-data/digdag/pull/856"},"issue":{"href":"https://api.github.com/repos/treasure-data/digdag/issues/856"},"comments":{"href":"https://api.github.com/repos/treasure-data/digdag/issues/856/comments"},"review_comments":{"href":"https://api.github.com/repos/treasure-data/digdag/pulls/856/comments"},"review_comment":{"href":"https://api.github.com/repos/treasure-data/digdag/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/treasure-data/digdag/pulls/856/commits"},"statuses":{"href":"https://api.github.com/repos/treasure-data/digdag/statuses/d72f867dab2b138ec43895de76331e76bf391bd0"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"serihiro"}}