{"action":"created","issue":{"url":"https://api.github.com/repos/ronf/asyncssh/issues/125","repository_url":"https://api.github.com/repos/ronf/asyncssh","labels_url":"https://api.github.com/repos/ronf/asyncssh/issues/125/labels{/name}","comments_url":"https://api.github.com/repos/ronf/asyncssh/issues/125/comments","events_url":"https://api.github.com/repos/ronf/asyncssh/issues/125/events","html_url":"https://github.com/ronf/asyncssh/issues/125","id":296149635,"number":125,"title":"Docs incorrect for SSHServerSession","user":{"login":"b-ryan","id":1183997,"avatar_url":"https://avatars1.githubusercontent.com/u/1183997?v=4","gravatar_id":"","url":"https://api.github.com/users/b-ryan","html_url":"https://github.com/b-ryan","followers_url":"https://api.github.com/users/b-ryan/followers","following_url":"https://api.github.com/users/b-ryan/following{/other_user}","gists_url":"https://api.github.com/users/b-ryan/gists{/gist_id}","starred_url":"https://api.github.com/users/b-ryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b-ryan/subscriptions","organizations_url":"https://api.github.com/users/b-ryan/orgs","repos_url":"https://api.github.com/users/b-ryan/repos","events_url":"https://api.github.com/users/b-ryan/events{/privacy}","received_events_url":"https://api.github.com/users/b-ryan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-11T01:17:43Z","updated_at":"2018-02-11T05:58:11Z","closed_at":null,"author_association":"NONE","body":"https://github.com/ronf/asyncssh/blob/0267f2e98c60dd77f3fff8b6572ed50389b14751/asyncssh/session.py#L27\r\n\r\nThe docs say the `connection_made` function will receive an instance of `SSHClientChannel`, but for server sessions, this will actually be an instance of `SSHServerChannel`. I would make a PR to fix but I don't know the best way to do this."},"comment":{"url":"https://api.github.com/repos/ronf/asyncssh/issues/comments/364724592","html_url":"https://github.com/ronf/asyncssh/issues/125#issuecomment-364724592","issue_url":"https://api.github.com/repos/ronf/asyncssh/issues/125","id":364724592,"user":{"login":"ronf","id":1901085,"avatar_url":"https://avatars2.githubusercontent.com/u/1901085?v=4","gravatar_id":"","url":"https://api.github.com/users/ronf","html_url":"https://github.com/ronf","followers_url":"https://api.github.com/users/ronf/followers","following_url":"https://api.github.com/users/ronf/following{/other_user}","gists_url":"https://api.github.com/users/ronf/gists{/gist_id}","starred_url":"https://api.github.com/users/ronf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronf/subscriptions","organizations_url":"https://api.github.com/users/ronf/orgs","repos_url":"https://api.github.com/users/ronf/repos","events_url":"https://api.github.com/users/ronf/events{/privacy}","received_events_url":"https://api.github.com/users/ronf/received_events","type":"User","site_admin":false},"created_at":"2018-02-11T05:58:11Z","updated_at":"2018-02-11T05:58:11Z","author_association":"OWNER","body":"Thanks for catching this, Buck.\r\n\r\nIt looks like the problem is that I defined connection_made() on the parent class SSHSession, so the same documentation is inherited by both SSHClientSession and SSHServerSession. Even though the function signature is otherwise identical between the two, I guess I'll need to remove it from the parent and duplicate it on the two child classes if I want to be able to document a different type for the chan argument there.\r\n\r\nThis is a pretty simple change - I'll get it into the \"develop\" branch shortly, and it'll go into the next release when it goes out."}}
{"actor":{"display_login":"ronf"}}