{"action":"closed","number":41,"pull_request":{"url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/pulls/41","id":222697350,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNjk3MzUw","html_url":"https://github.com/Azure/kubernetes-keyvault-flexvol/pull/41","diff_url":"https://github.com/Azure/kubernetes-keyvault-flexvol/pull/41.diff","patch_url":"https://github.com/Azure/kubernetes-keyvault-flexvol/pull/41.patch","issue_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/issues/41","number":41,"state":"closed","locked":false,"title":"Redact client-id and accesstoken from log files.","user":{"login":"pjbgf","id":5452977,"node_id":"MDQ6VXNlcjU0NTI5Nzc=","avatar_url":"https://avatars2.githubusercontent.com/u/5452977?v=4","gravatar_id":"","url":"https://api.github.com/users/pjbgf","html_url":"https://github.com/pjbgf","followers_url":"https://api.github.com/users/pjbgf/followers","following_url":"https://api.github.com/users/pjbgf/following{/other_user}","gists_url":"https://api.github.com/users/pjbgf/gists{/gist_id}","starred_url":"https://api.github.com/users/pjbgf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjbgf/subscriptions","organizations_url":"https://api.github.com/users/pjbgf/orgs","repos_url":"https://api.github.com/users/pjbgf/repos","events_url":"https://api.github.com/users/pjbgf/events{/privacy}","received_events_url":"https://api.github.com/users/pjbgf/received_events","type":"User","site_admin":false},"body":"The accesstokens used by keyvault-flexvol will always have privileges to read secrets/keys/certs from a KeyVault. This should not be kept in plain-text within log files, otherwise we may be risking that information be compromised, allowing an attacker to spoof the Managed Identity in question.\r\n\r\nI have kept the initial 4 and the last 4 characters of both client id and access token, in order to not remove completely the \"debugging\" capability.","created_at":"2018-10-14T07:00:39Z","updated_at":"2018-10-15T06:43:58Z","closed_at":"2018-10-15T06:43:58Z","merged_at":"2018-10-15T06:43:58Z","merge_commit_sha":"61152c077d421eca0e1313122c4631f11b54b514","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/pulls/41/commits","review_comments_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/pulls/41/comments","review_comment_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/issues/41/comments","statuses_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/statuses/3db2c2ed10c7ab9fc5ecaef2b8b10b3423ca5bdf","head":{"label":"pjbgf:features/redact-log-files","ref":"features/redact-log-files","sha":"3db2c2ed10c7ab9fc5ecaef2b8b10b3423ca5bdf","user":{"login":"pjbgf","id":5452977,"node_id":"MDQ6VXNlcjU0NTI5Nzc=","avatar_url":"https://avatars2.githubusercontent.com/u/5452977?v=4","gravatar_id":"","url":"https://api.github.com/users/pjbgf","html_url":"https://github.com/pjbgf","followers_url":"https://api.github.com/users/pjbgf/followers","following_url":"https://api.github.com/users/pjbgf/following{/other_user}","gists_url":"https://api.github.com/users/pjbgf/gists{/gist_id}","starred_url":"https://api.github.com/users/pjbgf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjbgf/subscriptions","organizations_url":"https://api.github.com/users/pjbgf/orgs","repos_url":"https://api.github.com/users/pjbgf/repos","events_url":"https://api.github.com/users/pjbgf/events{/privacy}","received_events_url":"https://api.github.com/users/pjbgf/received_events","type":"User","site_admin":false},"repo":{"id":152851912,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI4NTE5MTI=","name":"kubernetes-keyvault-flexvol","full_name":"pjbgf/kubernetes-keyvault-flexvol","private":false,"owner":{"login":"pjbgf","id":5452977,"node_id":"MDQ6VXNlcjU0NTI5Nzc=","avatar_url":"https://avatars2.githubusercontent.com/u/5452977?v=4","gravatar_id":"","url":"https://api.github.com/users/pjbgf","html_url":"https://github.com/pjbgf","followers_url":"https://api.github.com/users/pjbgf/followers","following_url":"https://api.github.com/users/pjbgf/following{/other_user}","gists_url":"https://api.github.com/users/pjbgf/gists{/gist_id}","starred_url":"https://api.github.com/users/pjbgf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjbgf/subscriptions","organizations_url":"https://api.github.com/users/pjbgf/orgs","repos_url":"https://api.github.com/users/pjbgf/repos","events_url":"https://api.github.com/users/pjbgf/events{/privacy}","received_events_url":"https://api.github.com/users/pjbgf/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pjbgf/kubernetes-keyvault-flexvol","description":"Azure keyvault integration with Kubernetes via a Flex Volume","fork":true,"url":"https://api.github.com/repos/pjbgf/kubernetes-keyvault-flexvol","forks_url":"https://api.github.com/repos/pjbgf/kubernetes-keyvault-flexvol/forks","keys_url":"https://api.github.com/repos/pjbgf/kubernetes-keyvault-flexvol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pjbgf/kubernetes-keyvault-flexvol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pjbgf/kubernetes-keyvault-flexvol/teams","hooks_url":"https://api.github.com/repos/pjbgf/kubernetes-keyvault-flexvol/hooks","issue_events_url":"https://api.github.com/repos/pjbgf/kubernetes-keyvault-flexvol/issues/events{/number}","events_url":"https://api.github.com/repos/pjbgf/kubernetes-keyvault-flexvol/events","assignees_url":"https://api.github.com/repos/pjbgf/kubernetes-keyvault-flexvol/assignees{/user}","branches_url":"https://api.github.com/repos/pjbgf/kubernetes-keyvault-flexvol/branches{/branch}","tags_url":"https://api.github.com/repos/pjbgf/kubernetes-keyvault-flexvol/tags","blobs_url":"https://api.github.com/repos/pjbgf/kubernetes-keyvault-flexvol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pjbgf/kubernetes-keyvault-flexvol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pjbgf/kubernetes-keyvault-flexvol/git/refs{/sha}","trees_url":"https://api.github.com/repos/pjbgf/kubernetes-keyvault-flexvol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pjbgf/kubernetes-keyvault-flexvol/statuses/{sha}","languages_url":"https://api.github.com/repos/pjbgf/kubernetes-keyvault-flexvol/languages","stargazers_url":"https://api.github.com/repos/pjbgf/kubernetes-keyvault-flexvol/stargazers","contributors_url":"https://api.github.com/repos/pjbgf/kubernetes-keyvault-flexvol/contributors","subscribers_url":"https://api.github.com/repos/pjbgf/kubernetes-keyvault-flexvol/subscribers","subscription_url":"https://api.github.com/repos/pjbgf/kubernetes-keyvault-flexvol/subscription","commits_url":"https://api.github.com/repos/pjbgf/kubernetes-keyvault-flexvol/commits{/sha}","git_commits_url":"https://api.github.com/repos/pjbgf/kubernetes-keyvault-flexvol/git/commits{/sha}","comments_url":"https://api.github.com/repos/pjbgf/kubernetes-keyvault-flexvol/comments{/number}","issue_comment_url":"https://api.github.com/repos/pjbgf/kubernetes-keyvault-flexvol/issues/comments{/number}","contents_url":"https://api.github.com/repos/pjbgf/kubernetes-keyvault-flexvol/contents/{+path}","compare_url":"https://api.github.com/repos/pjbgf/kubernetes-keyvault-flexvol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pjbgf/kubernetes-keyvault-flexvol/merges","archive_url":"https://api.github.com/repos/pjbgf/kubernetes-keyvault-flexvol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pjbgf/kubernetes-keyvault-flexvol/downloads","issues_url":"https://api.github.com/repos/pjbgf/kubernetes-keyvault-flexvol/issues{/number}","pulls_url":"https://api.github.com/repos/pjbgf/kubernetes-keyvault-flexvol/pulls{/number}","milestones_url":"https://api.github.com/repos/pjbgf/kubernetes-keyvault-flexvol/milestones{/number}","notifications_url":"https://api.github.com/repos/pjbgf/kubernetes-keyvault-flexvol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pjbgf/kubernetes-keyvault-flexvol/labels{/name}","releases_url":"https://api.github.com/repos/pjbgf/kubernetes-keyvault-flexvol/releases{/id}","deployments_url":"https://api.github.com/repos/pjbgf/kubernetes-keyvault-flexvol/deployments","created_at":"2018-10-13T08:34:37Z","updated_at":"2018-10-13T08:34:39Z","pushed_at":"2018-10-14T06:22:57Z","git_url":"git://github.com/pjbgf/kubernetes-keyvault-flexvol.git","ssh_url":"git@github.com:pjbgf/kubernetes-keyvault-flexvol.git","clone_url":"https://github.com/pjbgf/kubernetes-keyvault-flexvol.git","svn_url":"https://github.com/pjbgf/kubernetes-keyvault-flexvol","homepage":null,"size":12648,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"fc7068c4bc0b94bbdd71abbb6f3a6dd1cfba1801","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":136075760,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYwNzU3NjA=","name":"kubernetes-keyvault-flexvol","full_name":"Azure/kubernetes-keyvault-flexvol","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/kubernetes-keyvault-flexvol","description":"Azure keyvault integration with Kubernetes via a Flex Volume","fork":false,"url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol","forks_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/forks","keys_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/teams","hooks_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/hooks","issue_events_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/events","assignees_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/tags","blobs_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/languages","stargazers_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/stargazers","contributors_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/contributors","subscribers_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/subscribers","subscription_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/subscription","commits_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/merges","archive_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/downloads","issues_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/labels{/name}","releases_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/deployments","created_at":"2018-06-04T19:56:17Z","updated_at":"2018-10-13T02:23:32Z","pushed_at":"2018-10-15T06:43:57Z","git_url":"git://github.com/Azure/kubernetes-keyvault-flexvol.git","ssh_url":"git@github.com:Azure/kubernetes-keyvault-flexvol.git","clone_url":"https://github.com/Azure/kubernetes-keyvault-flexvol.git","svn_url":"https://github.com/Azure/kubernetes-keyvault-flexvol","homepage":null,"size":12652,"stargazers_count":45,"watchers_count":45,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":14,"open_issues":13,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/pulls/41"},"html":{"href":"https://github.com/Azure/kubernetes-keyvault-flexvol/pull/41"},"issue":{"href":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/issues/41"},"comments":{"href":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/statuses/3db2c2ed10c7ab9fc5ecaef2b8b10b3423ca5bdf"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ritazh","id":1856066,"node_id":"MDQ6VXNlcjE4NTYwNjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1856066?v=4","gravatar_id":"","url":"https://api.github.com/users/ritazh","html_url":"https://github.com/ritazh","followers_url":"https://api.github.com/users/ritazh/followers","following_url":"https://api.github.com/users/ritazh/following{/other_user}","gists_url":"https://api.github.com/users/ritazh/gists{/gist_id}","starred_url":"https://api.github.com/users/ritazh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ritazh/subscriptions","organizations_url":"https://api.github.com/users/ritazh/orgs","repos_url":"https://api.github.com/users/ritazh/repos","events_url":"https://api.github.com/users/ritazh/events{/privacy}","received_events_url":"https://api.github.com/users/ritazh/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":5,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"ritazh"}}