{"action":"created","comment":{"url":"https://api.github.com/repos/sjug/pbench/pulls/comments/243384634","pull_request_review_id":187141892,"id":243384634,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzM4NDYzNA==","diff_hunk":"@@ -160,19 +139,39 @@ case \"$mode\" in\n \twhich go &>/dev/null\n \tif [[ $? != 0 ]]; then\n \t\tyum -y install go &>/dev/null\n+\t\tif [[ $? != 0 ]]; then\n+\t\t\terror_log \"[$script_name] \\\"yum -y install go\\\" failed!\"\n+\t\t\texit 1\n+\t\tfi\n \tfi\n \tmkdir -p $pbench_install_dir/.go\n+\tif [[ $? != 0 ]]; then\n+\t\terror_log \"[$script_name] \\\"mkdir -p $pbench_install_dir/.go\\\" failed!\"\n+\t\texit 1\n+\tfi\n \tGOPATH=$pbench_install_dir/.go go get github.com/prometheus/prom2json/cmd/prom2json\n+\tif [[ $? != 0 ]]; then\n+\t\terror_log \"[$script_name] \\\"go get github.com/prometheus/prom2json/cmd/prom2json\\\" failed!\"\n+\t\texit 1\n+\tfi\n \t;;\n \tstart)\n \tmkdir -p $tool_output_dir/json\n+\tif [[ $? != 0 ]]; then\n+\t\terror_log \"[$script_name] \\\"mkdir -p $tool_output_dir/json\\\" failed!\"\n+\t\texit 1\n+\tfi\n \twhile read -u 9 file; do\n-\t\t# If the port, cert or key is not set while registering the tool, read the input file for host, port, cert and key if any. \n-\t\t# In case the file doesn't have certs, port and they are not defined while registering the tool, the default values are set.\n-\t\t# host port=<port> cert=<cert> key=<key>\n+\t\t# If the port, cert or key is not set while registering","path":"agent/tool-scripts/prometheus-metrics","position":67,"original_position":67,"commit_id":"ba5791cfa10e64f9d2ce66ece47422144127d040","original_commit_id":"7be91c3a1e83f6d28c4c3f7da4b4ab9e0a928b60","user":{"login":"portante","id":949097,"node_id":"MDQ6VXNlcjk0OTA5Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/949097?v=4","gravatar_id":"","url":"https://api.github.com/users/portante","html_url":"https://github.com/portante","followers_url":"https://api.github.com/users/portante/followers","following_url":"https://api.github.com/users/portante/following{/other_user}","gists_url":"https://api.github.com/users/portante/gists{/gist_id}","starred_url":"https://api.github.com/users/portante/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/portante/subscriptions","organizations_url":"https://api.github.com/users/portante/orgs","repos_url":"https://api.github.com/users/portante/repos","events_url":"https://api.github.com/users/portante/events{/privacy}","received_events_url":"https://api.github.com/users/portante/received_events","type":"User","site_admin":false},"body":"They were not being used at all.  If they were given as values in the inventory file, then they were not used the default values.\r\n\r\nIf you think we should fix that, I'll add them back and make it so that the defaults are used.","created_at":"2018-12-20T19:06:58Z","updated_at":"2018-12-20T19:06:58Z","html_url":"https://github.com/sjug/pbench/pull/1#discussion_r243384634","pull_request_url":"https://api.github.com/repos/sjug/pbench/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/sjug/pbench/pulls/comments/243384634"},"html":{"href":"https://github.com/sjug/pbench/pull/1#discussion_r243384634"},"pull_request":{"href":"https://api.github.com/repos/sjug/pbench/pulls/1"}},"in_reply_to_id":243271477},"pull_request":{"url":"https://api.github.com/repos/sjug/pbench/pulls/1","id":240041010,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMDQxMDEw","html_url":"https://github.com/sjug/pbench/pull/1","diff_url":"https://github.com/sjug/pbench/pull/1.diff","patch_url":"https://github.com/sjug/pbench/pull/1.patch","issue_url":"https://api.github.com/repos/sjug/pbench/issues/1","number":1,"state":"open","locked":false,"title":"Fix prom2json cert","user":{"login":"portante","id":949097,"node_id":"MDQ6VXNlcjk0OTA5Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/949097?v=4","gravatar_id":"","url":"https://api.github.com/users/portante","html_url":"https://github.com/portante","followers_url":"https://api.github.com/users/portante/followers","following_url":"https://api.github.com/users/portante/following{/other_user}","gists_url":"https://api.github.com/users/portante/gists{/gist_id}","starred_url":"https://api.github.com/users/portante/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/portante/subscriptions","organizations_url":"https://api.github.com/users/portante/orgs","repos_url":"https://api.github.com/users/portante/repos","events_url":"https://api.github.com/users/portante/events{/privacy}","received_events_url":"https://api.github.com/users/portante/received_events","type":"User","site_admin":false},"body":"DON'T merge without first rebasing your original PR on upstream master.\r\n\r\nPlease consider the last two commits, \"9abf3f8\" and \"7be91c3\", \"Accept self-signed certs using host config\" and \"Refactor prom-metrics datalog loop to avoid drift\".","created_at":"2018-12-20T03:23:30Z","updated_at":"2018-12-20T19:06:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sjug/pbench/pulls/1/commits","review_comments_url":"https://api.github.com/repos/sjug/pbench/pulls/1/comments","review_comment_url":"https://api.github.com/repos/sjug/pbench/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sjug/pbench/issues/1/comments","statuses_url":"https://api.github.com/repos/sjug/pbench/statuses/ba5791cfa10e64f9d2ce66ece47422144127d040","head":{"label":"portante:fix_prom2json_cert","ref":"fix_prom2json_cert","sha":"ba5791cfa10e64f9d2ce66ece47422144127d040","user":{"login":"portante","id":949097,"node_id":"MDQ6VXNlcjk0OTA5Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/949097?v=4","gravatar_id":"","url":"https://api.github.com/users/portante","html_url":"https://github.com/portante","followers_url":"https://api.github.com/users/portante/followers","following_url":"https://api.github.com/users/portante/following{/other_user}","gists_url":"https://api.github.com/users/portante/gists{/gist_id}","starred_url":"https://api.github.com/users/portante/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/portante/subscriptions","organizations_url":"https://api.github.com/users/portante/orgs","repos_url":"https://api.github.com/users/portante/repos","events_url":"https://api.github.com/users/portante/events{/privacy}","received_events_url":"https://api.github.com/users/portante/received_events","type":"User","site_admin":false},"repo":{"id":38632076,"node_id":"MDEwOlJlcG9zaXRvcnkzODYzMjA3Ng==","name":"pbench","full_name":"portante/pbench","private":false,"owner":{"login":"portante","id":949097,"node_id":"MDQ6VXNlcjk0OTA5Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/949097?v=4","gravatar_id":"","url":"https://api.github.com/users/portante","html_url":"https://github.com/portante","followers_url":"https://api.github.com/users/portante/followers","following_url":"https://api.github.com/users/portante/following{/other_user}","gists_url":"https://api.github.com/users/portante/gists{/gist_id}","starred_url":"https://api.github.com/users/portante/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/portante/subscriptions","organizations_url":"https://api.github.com/users/portante/orgs","repos_url":"https://api.github.com/users/portante/repos","events_url":"https://api.github.com/users/portante/events{/privacy}","received_events_url":"https://api.github.com/users/portante/received_events","type":"User","site_admin":false},"html_url":"https://github.com/portante/pbench","description":"A benchmarking and performance analysis framework","fork":true,"url":"https://api.github.com/repos/portante/pbench","forks_url":"https://api.github.com/repos/portante/pbench/forks","keys_url":"https://api.github.com/repos/portante/pbench/keys{/key_id}","collaborators_url":"https://api.github.com/repos/portante/pbench/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/portante/pbench/teams","hooks_url":"https://api.github.com/repos/portante/pbench/hooks","issue_events_url":"https://api.github.com/repos/portante/pbench/issues/events{/number}","events_url":"https://api.github.com/repos/portante/pbench/events","assignees_url":"https://api.github.com/repos/portante/pbench/assignees{/user}","branches_url":"https://api.github.com/repos/portante/pbench/branches{/branch}","tags_url":"https://api.github.com/repos/portante/pbench/tags","blobs_url":"https://api.github.com/repos/portante/pbench/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/portante/pbench/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/portante/pbench/git/refs{/sha}","trees_url":"https://api.github.com/repos/portante/pbench/git/trees{/sha}","statuses_url":"https://api.github.com/repos/portante/pbench/statuses/{sha}","languages_url":"https://api.github.com/repos/portante/pbench/languages","stargazers_url":"https://api.github.com/repos/portante/pbench/stargazers","contributors_url":"https://api.github.com/repos/portante/pbench/contributors","subscribers_url":"https://api.github.com/repos/portante/pbench/subscribers","subscription_url":"https://api.github.com/repos/portante/pbench/subscription","commits_url":"https://api.github.com/repos/portante/pbench/commits{/sha}","git_commits_url":"https://api.github.com/repos/portante/pbench/git/commits{/sha}","comments_url":"https://api.github.com/repos/portante/pbench/comments{/number}","issue_comment_url":"https://api.github.com/repos/portante/pbench/issues/comments{/number}","contents_url":"https://api.github.com/repos/portante/pbench/contents/{+path}","compare_url":"https://api.github.com/repos/portante/pbench/compare/{base}...{head}","merges_url":"https://api.github.com/repos/portante/pbench/merges","archive_url":"https://api.github.com/repos/portante/pbench/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/portante/pbench/downloads","issues_url":"https://api.github.com/repos/portante/pbench/issues{/number}","pulls_url":"https://api.github.com/repos/portante/pbench/pulls{/number}","milestones_url":"https://api.github.com/repos/portante/pbench/milestones{/number}","notifications_url":"https://api.github.com/repos/portante/pbench/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/portante/pbench/labels{/name}","releases_url":"https://api.github.com/repos/portante/pbench/releases{/id}","deployments_url":"https://api.github.com/repos/portante/pbench/deployments","created_at":"2015-07-06T16:39:40Z","updated_at":"2016-12-19T15:05:53Z","pushed_at":"2018-12-20T19:05:36Z","git_url":"git://github.com/portante/pbench.git","ssh_url":"git@github.com:portante/pbench.git","clone_url":"https://github.com/portante/pbench.git","svn_url":"https://github.com/portante/pbench","homepage":null,"size":148451,"stargazers_count":1,"watchers_count":1,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"sjug:fix_prom2json_cert","ref":"fix_prom2json_cert","sha":"f510f44e5572b838d63b06f314c30f7fb3973699","user":{"login":"sjug","id":7550641,"node_id":"MDQ6VXNlcjc1NTA2NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/7550641?v=4","gravatar_id":"","url":"https://api.github.com/users/sjug","html_url":"https://github.com/sjug","followers_url":"https://api.github.com/users/sjug/followers","following_url":"https://api.github.com/users/sjug/following{/other_user}","gists_url":"https://api.github.com/users/sjug/gists{/gist_id}","starred_url":"https://api.github.com/users/sjug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjug/subscriptions","organizations_url":"https://api.github.com/users/sjug/orgs","repos_url":"https://api.github.com/users/sjug/repos","events_url":"https://api.github.com/users/sjug/events{/privacy}","received_events_url":"https://api.github.com/users/sjug/received_events","type":"User","site_admin":false},"repo":{"id":105029527,"node_id":"MDEwOlJlcG9zaXRvcnkxMDUwMjk1Mjc=","name":"pbench","full_name":"sjug/pbench","private":false,"owner":{"login":"sjug","id":7550641,"node_id":"MDQ6VXNlcjc1NTA2NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/7550641?v=4","gravatar_id":"","url":"https://api.github.com/users/sjug","html_url":"https://github.com/sjug","followers_url":"https://api.github.com/users/sjug/followers","following_url":"https://api.github.com/users/sjug/following{/other_user}","gists_url":"https://api.github.com/users/sjug/gists{/gist_id}","starred_url":"https://api.github.com/users/sjug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjug/subscriptions","organizations_url":"https://api.github.com/users/sjug/orgs","repos_url":"https://api.github.com/users/sjug/repos","events_url":"https://api.github.com/users/sjug/events{/privacy}","received_events_url":"https://api.github.com/users/sjug/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sjug/pbench","description":"A benchmarking and performance analysis framework","fork":true,"url":"https://api.github.com/repos/sjug/pbench","forks_url":"https://api.github.com/repos/sjug/pbench/forks","keys_url":"https://api.github.com/repos/sjug/pbench/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sjug/pbench/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sjug/pbench/teams","hooks_url":"https://api.github.com/repos/sjug/pbench/hooks","issue_events_url":"https://api.github.com/repos/sjug/pbench/issues/events{/number}","events_url":"https://api.github.com/repos/sjug/pbench/events","assignees_url":"https://api.github.com/repos/sjug/pbench/assignees{/user}","branches_url":"https://api.github.com/repos/sjug/pbench/branches{/branch}","tags_url":"https://api.github.com/repos/sjug/pbench/tags","blobs_url":"https://api.github.com/repos/sjug/pbench/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sjug/pbench/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sjug/pbench/git/refs{/sha}","trees_url":"https://api.github.com/repos/sjug/pbench/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sjug/pbench/statuses/{sha}","languages_url":"https://api.github.com/repos/sjug/pbench/languages","stargazers_url":"https://api.github.com/repos/sjug/pbench/stargazers","contributors_url":"https://api.github.com/repos/sjug/pbench/contributors","subscribers_url":"https://api.github.com/repos/sjug/pbench/subscribers","subscription_url":"https://api.github.com/repos/sjug/pbench/subscription","commits_url":"https://api.github.com/repos/sjug/pbench/commits{/sha}","git_commits_url":"https://api.github.com/repos/sjug/pbench/git/commits{/sha}","comments_url":"https://api.github.com/repos/sjug/pbench/comments{/number}","issue_comment_url":"https://api.github.com/repos/sjug/pbench/issues/comments{/number}","contents_url":"https://api.github.com/repos/sjug/pbench/contents/{+path}","compare_url":"https://api.github.com/repos/sjug/pbench/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sjug/pbench/merges","archive_url":"https://api.github.com/repos/sjug/pbench/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sjug/pbench/downloads","issues_url":"https://api.github.com/repos/sjug/pbench/issues{/number}","pulls_url":"https://api.github.com/repos/sjug/pbench/pulls{/number}","milestones_url":"https://api.github.com/repos/sjug/pbench/milestones{/number}","notifications_url":"https://api.github.com/repos/sjug/pbench/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sjug/pbench/labels{/name}","releases_url":"https://api.github.com/repos/sjug/pbench/releases{/id}","deployments_url":"https://api.github.com/repos/sjug/pbench/deployments","created_at":"2017-09-27T14:35:04Z","updated_at":"2018-12-20T13:21:12Z","pushed_at":"2018-12-20T19:05:38Z","git_url":"git://github.com/sjug/pbench.git","ssh_url":"git@github.com:sjug/pbench.git","clone_url":"https://github.com/sjug/pbench.git","svn_url":"https://github.com/sjug/pbench","homepage":"http://distributed-system-analysis.github.io/pbench/","size":181746,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sjug/pbench/pulls/1"},"html":{"href":"https://github.com/sjug/pbench/pull/1"},"issue":{"href":"https://api.github.com/repos/sjug/pbench/issues/1"},"comments":{"href":"https://api.github.com/repos/sjug/pbench/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/sjug/pbench/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/sjug/pbench/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sjug/pbench/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/sjug/pbench/statuses/ba5791cfa10e64f9d2ce66ece47422144127d040"}},"author_association":"NONE"}}
{"actor":{"display_login":"portante"}}