{"action":"created","comment":{"url":"https://api.github.com/repos/Esri/arcgis-rest-js/pulls/comments/186539051","pull_request_review_id":118138093,"id":186539051,"diff_hunk":"@@ -156,3 +156,157 @@ export function queryFeatures(\n   // TODO: do we need to serialize any of the array/object params?\n   return request(`${requestOptions.url}/query`, options);\n }\n+\n+/**\n+ * add, update and delete features results\n+ */\n+export interface IFeaturesResult {\n+  objectId?: number;\n+  globalId?: string;\n+  success?: boolean;\n+}\n+\n+/**\n+ * add and update features parameters\n+ */\n+export interface IAddUpdateFeaturesParams {\n+  features?: IFeature[];\n+  gdbVersion?: string;\n+  returnEditMoment?: boolean;\n+  rollbackOnFailure?: boolean;\n+}\n+\n+/**\n+ * add features request options\n+ *\n+ * @param url - layer service url\n+ * @param params - query parameters to be sent to the feature service\n+ */\n+export interface IAddFeaturesRequestOptions extends IRequestOptions {\n+  url: string;\n+  params?: IAddUpdateFeaturesParams;\n+}\n+\n+/**\n+ * add features results\n+ */\n+export interface IAddFeaturesResult {\n+  addResults?: IFeaturesResult[];\n+}\n+\n+/**\n+ * Add features\n+ *\n+ * @param requestOptions - Options for the request\n+ * @returns A Promise that will resolve with the query response.\n+ */\n+export function addFeatures(\n+  requestOptions: IAddFeaturesRequestOptions\n+): Promise<IAddFeaturesResult> {\n+  const url = `${requestOptions.url}/addFeatures`;","path":"packages/arcgis-rest-feature-service/src/features.ts","position":79,"original_position":51,"commit_id":"744e8fd0710e04e0ad8b7bd6da05ca386339fe7b","original_commit_id":"661801366acd3fecc62d01e8ce9cdfb71029b684","user":{"login":"COV-GIS","id":14297903,"avatar_url":"https://avatars1.githubusercontent.com/u/14297903?v=4","gravatar_id":"","url":"https://api.github.com/users/COV-GIS","html_url":"https://github.com/COV-GIS","followers_url":"https://api.github.com/users/COV-GIS/followers","following_url":"https://api.github.com/users/COV-GIS/following{/other_user}","gists_url":"https://api.github.com/users/COV-GIS/gists{/gist_id}","starred_url":"https://api.github.com/users/COV-GIS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/COV-GIS/subscriptions","organizations_url":"https://api.github.com/users/COV-GIS/orgs","repos_url":"https://api.github.com/users/COV-GIS/repos","events_url":"https://api.github.com/users/COV-GIS/events{/privacy}","received_events_url":"https://api.github.com/users/COV-GIS/received_events","type":"User","site_admin":false},"body":"I did not address this @jgravois. The main reason I prefer the dedicated operations is the simple and consistent response objects; and in my experience better error responses which don't require logging into ags manager to understand what the problem is. My use for this api is to deploy express app endpoints for apps and other apis without having to load the jsapi on the client, as well handling other logic on the backend as to what edit operation(s) need to occur. I took a closer look at `applyEdits`. it's going to require more interfaces and what have you. ","created_at":"2018-05-07T20:25:53Z","updated_at":"2018-05-07T20:25:53Z","html_url":"https://github.com/Esri/arcgis-rest-js/pull/185#discussion_r186539051","pull_request_url":"https://api.github.com/repos/Esri/arcgis-rest-js/pulls/185","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Esri/arcgis-rest-js/pulls/comments/186539051"},"html":{"href":"https://github.com/Esri/arcgis-rest-js/pull/185#discussion_r186539051"},"pull_request":{"href":"https://api.github.com/repos/Esri/arcgis-rest-js/pulls/185"}},"in_reply_to_id":186501333},"pull_request":{"url":"https://api.github.com/repos/Esri/arcgis-rest-js/pulls/185","id":186388154,"html_url":"https://github.com/Esri/arcgis-rest-js/pull/185","diff_url":"https://github.com/Esri/arcgis-rest-js/pull/185.diff","patch_url":"https://github.com/Esri/arcgis-rest-js/pull/185.patch","issue_url":"https://api.github.com/repos/Esri/arcgis-rest-js/issues/185","number":185,"state":"open","locked":false,"title":"Add add, update and delete features","user":{"login":"COV-GIS","id":14297903,"avatar_url":"https://avatars1.githubusercontent.com/u/14297903?v=4","gravatar_id":"","url":"https://api.github.com/users/COV-GIS","html_url":"https://github.com/COV-GIS","followers_url":"https://api.github.com/users/COV-GIS/followers","following_url":"https://api.github.com/users/COV-GIS/following{/other_user}","gists_url":"https://api.github.com/users/COV-GIS/gists{/gist_id}","starred_url":"https://api.github.com/users/COV-GIS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/COV-GIS/subscriptions","organizations_url":"https://api.github.com/users/COV-GIS/orgs","repos_url":"https://api.github.com/users/COV-GIS/repos","events_url":"https://api.github.com/users/COV-GIS/events{/privacy}","received_events_url":"https://api.github.com/users/COV-GIS/received_events","type":"User","site_admin":false},"body":"@jgravois I asked about these before. Might not be something you're interested in or might be in the works already. If you are, let me know and I'll work on tests.","created_at":"2018-05-07T15:42:22Z","updated_at":"2018-05-07T20:25:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a49064de1bc7b412a82b20af2c76e5a6d12eee97","assignee":{"login":"jgravois","id":3011734,"avatar_url":"https://avatars3.githubusercontent.com/u/3011734?v=4","gravatar_id":"","url":"https://api.github.com/users/jgravois","html_url":"https://github.com/jgravois","followers_url":"https://api.github.com/users/jgravois/followers","following_url":"https://api.github.com/users/jgravois/following{/other_user}","gists_url":"https://api.github.com/users/jgravois/gists{/gist_id}","starred_url":"https://api.github.com/users/jgravois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgravois/subscriptions","organizations_url":"https://api.github.com/users/jgravois/orgs","repos_url":"https://api.github.com/users/jgravois/repos","events_url":"https://api.github.com/users/jgravois/events{/privacy}","received_events_url":"https://api.github.com/users/jgravois/received_events","type":"User","site_admin":false},"assignees":[{"login":"jgravois","id":3011734,"avatar_url":"https://avatars3.githubusercontent.com/u/3011734?v=4","gravatar_id":"","url":"https://api.github.com/users/jgravois","html_url":"https://github.com/jgravois","followers_url":"https://api.github.com/users/jgravois/followers","following_url":"https://api.github.com/users/jgravois/following{/other_user}","gists_url":"https://api.github.com/users/jgravois/gists{/gist_id}","starred_url":"https://api.github.com/users/jgravois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgravois/subscriptions","organizations_url":"https://api.github.com/users/jgravois/orgs","repos_url":"https://api.github.com/users/jgravois/repos","events_url":"https://api.github.com/users/jgravois/events{/privacy}","received_events_url":"https://api.github.com/users/jgravois/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Esri/arcgis-rest-js/pulls/185/commits","review_comments_url":"https://api.github.com/repos/Esri/arcgis-rest-js/pulls/185/comments","review_comment_url":"https://api.github.com/repos/Esri/arcgis-rest-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Esri/arcgis-rest-js/issues/185/comments","statuses_url":"https://api.github.com/repos/Esri/arcgis-rest-js/statuses/744e8fd0710e04e0ad8b7bd6da05ca386339fe7b","head":{"label":"COV-GIS:add-update-delete-features","ref":"add-update-delete-features","sha":"744e8fd0710e04e0ad8b7bd6da05ca386339fe7b","user":{"login":"COV-GIS","id":14297903,"avatar_url":"https://avatars1.githubusercontent.com/u/14297903?v=4","gravatar_id":"","url":"https://api.github.com/users/COV-GIS","html_url":"https://github.com/COV-GIS","followers_url":"https://api.github.com/users/COV-GIS/followers","following_url":"https://api.github.com/users/COV-GIS/following{/other_user}","gists_url":"https://api.github.com/users/COV-GIS/gists{/gist_id}","starred_url":"https://api.github.com/users/COV-GIS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/COV-GIS/subscriptions","organizations_url":"https://api.github.com/users/COV-GIS/orgs","repos_url":"https://api.github.com/users/COV-GIS/repos","events_url":"https://api.github.com/users/COV-GIS/events{/privacy}","received_events_url":"https://api.github.com/users/COV-GIS/received_events","type":"User","site_admin":false},"repo":{"id":132055246,"name":"arcgis-rest-js","full_name":"COV-GIS/arcgis-rest-js","owner":{"login":"COV-GIS","id":14297903,"avatar_url":"https://avatars1.githubusercontent.com/u/14297903?v=4","gravatar_id":"","url":"https://api.github.com/users/COV-GIS","html_url":"https://github.com/COV-GIS","followers_url":"https://api.github.com/users/COV-GIS/followers","following_url":"https://api.github.com/users/COV-GIS/following{/other_user}","gists_url":"https://api.github.com/users/COV-GIS/gists{/gist_id}","starred_url":"https://api.github.com/users/COV-GIS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/COV-GIS/subscriptions","organizations_url":"https://api.github.com/users/COV-GIS/orgs","repos_url":"https://api.github.com/users/COV-GIS/repos","events_url":"https://api.github.com/users/COV-GIS/events{/privacy}","received_events_url":"https://api.github.com/users/COV-GIS/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/COV-GIS/arcgis-rest-js","description":"compact, modular JavaScript wrappers for the ArcGIS REST API","fork":true,"url":"https://api.github.com/repos/COV-GIS/arcgis-rest-js","forks_url":"https://api.github.com/repos/COV-GIS/arcgis-rest-js/forks","keys_url":"https://api.github.com/repos/COV-GIS/arcgis-rest-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/COV-GIS/arcgis-rest-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/COV-GIS/arcgis-rest-js/teams","hooks_url":"https://api.github.com/repos/COV-GIS/arcgis-rest-js/hooks","issue_events_url":"https://api.github.com/repos/COV-GIS/arcgis-rest-js/issues/events{/number}","events_url":"https://api.github.com/repos/COV-GIS/arcgis-rest-js/events","assignees_url":"https://api.github.com/repos/COV-GIS/arcgis-rest-js/assignees{/user}","branches_url":"https://api.github.com/repos/COV-GIS/arcgis-rest-js/branches{/branch}","tags_url":"https://api.github.com/repos/COV-GIS/arcgis-rest-js/tags","blobs_url":"https://api.github.com/repos/COV-GIS/arcgis-rest-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/COV-GIS/arcgis-rest-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/COV-GIS/arcgis-rest-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/COV-GIS/arcgis-rest-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/COV-GIS/arcgis-rest-js/statuses/{sha}","languages_url":"https://api.github.com/repos/COV-GIS/arcgis-rest-js/languages","stargazers_url":"https://api.github.com/repos/COV-GIS/arcgis-rest-js/stargazers","contributors_url":"https://api.github.com/repos/COV-GIS/arcgis-rest-js/contributors","subscribers_url":"https://api.github.com/repos/COV-GIS/arcgis-rest-js/subscribers","subscription_url":"https://api.github.com/repos/COV-GIS/arcgis-rest-js/subscription","commits_url":"https://api.github.com/repos/COV-GIS/arcgis-rest-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/COV-GIS/arcgis-rest-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/COV-GIS/arcgis-rest-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/COV-GIS/arcgis-rest-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/COV-GIS/arcgis-rest-js/contents/{+path}","compare_url":"https://api.github.com/repos/COV-GIS/arcgis-rest-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/COV-GIS/arcgis-rest-js/merges","archive_url":"https://api.github.com/repos/COV-GIS/arcgis-rest-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/COV-GIS/arcgis-rest-js/downloads","issues_url":"https://api.github.com/repos/COV-GIS/arcgis-rest-js/issues{/number}","pulls_url":"https://api.github.com/repos/COV-GIS/arcgis-rest-js/pulls{/number}","milestones_url":"https://api.github.com/repos/COV-GIS/arcgis-rest-js/milestones{/number}","notifications_url":"https://api.github.com/repos/COV-GIS/arcgis-rest-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/COV-GIS/arcgis-rest-js/labels{/name}","releases_url":"https://api.github.com/repos/COV-GIS/arcgis-rest-js/releases{/id}","deployments_url":"https://api.github.com/repos/COV-GIS/arcgis-rest-js/deployments","created_at":"2018-05-03T22:16:18Z","updated_at":"2018-05-03T22:16:20Z","pushed_at":"2018-05-07T20:14:44Z","git_url":"git://github.com/COV-GIS/arcgis-rest-js.git","ssh_url":"git@github.com:COV-GIS/arcgis-rest-js.git","clone_url":"https://github.com/COV-GIS/arcgis-rest-js.git","svn_url":"https://github.com/COV-GIS/arcgis-rest-js","homepage":"https://esri.github.io/arcgis-rest-js/","size":2223,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Esri:master","ref":"master","sha":"20296abf9ec64f89785b6f8766cb2a3f9b0d9cfc","user":{"login":"Esri","id":628795,"avatar_url":"https://avatars1.githubusercontent.com/u/628795?v=4","gravatar_id":"","url":"https://api.github.com/users/Esri","html_url":"https://github.com/Esri","followers_url":"https://api.github.com/users/Esri/followers","following_url":"https://api.github.com/users/Esri/following{/other_user}","gists_url":"https://api.github.com/users/Esri/gists{/gist_id}","starred_url":"https://api.github.com/users/Esri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Esri/subscriptions","organizations_url":"https://api.github.com/users/Esri/orgs","repos_url":"https://api.github.com/users/Esri/repos","events_url":"https://api.github.com/users/Esri/events{/privacy}","received_events_url":"https://api.github.com/users/Esri/received_events","type":"Organization","site_admin":false},"repo":{"id":96794098,"name":"arcgis-rest-js","full_name":"Esri/arcgis-rest-js","owner":{"login":"Esri","id":628795,"avatar_url":"https://avatars1.githubusercontent.com/u/628795?v=4","gravatar_id":"","url":"https://api.github.com/users/Esri","html_url":"https://github.com/Esri","followers_url":"https://api.github.com/users/Esri/followers","following_url":"https://api.github.com/users/Esri/following{/other_user}","gists_url":"https://api.github.com/users/Esri/gists{/gist_id}","starred_url":"https://api.github.com/users/Esri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Esri/subscriptions","organizations_url":"https://api.github.com/users/Esri/orgs","repos_url":"https://api.github.com/users/Esri/repos","events_url":"https://api.github.com/users/Esri/events{/privacy}","received_events_url":"https://api.github.com/users/Esri/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Esri/arcgis-rest-js","description":"compact, modular JavaScript wrappers for the ArcGIS REST API","fork":false,"url":"https://api.github.com/repos/Esri/arcgis-rest-js","forks_url":"https://api.github.com/repos/Esri/arcgis-rest-js/forks","keys_url":"https://api.github.com/repos/Esri/arcgis-rest-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Esri/arcgis-rest-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Esri/arcgis-rest-js/teams","hooks_url":"https://api.github.com/repos/Esri/arcgis-rest-js/hooks","issue_events_url":"https://api.github.com/repos/Esri/arcgis-rest-js/issues/events{/number}","events_url":"https://api.github.com/repos/Esri/arcgis-rest-js/events","assignees_url":"https://api.github.com/repos/Esri/arcgis-rest-js/assignees{/user}","branches_url":"https://api.github.com/repos/Esri/arcgis-rest-js/branches{/branch}","tags_url":"https://api.github.com/repos/Esri/arcgis-rest-js/tags","blobs_url":"https://api.github.com/repos/Esri/arcgis-rest-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Esri/arcgis-rest-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Esri/arcgis-rest-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Esri/arcgis-rest-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Esri/arcgis-rest-js/statuses/{sha}","languages_url":"https://api.github.com/repos/Esri/arcgis-rest-js/languages","stargazers_url":"https://api.github.com/repos/Esri/arcgis-rest-js/stargazers","contributors_url":"https://api.github.com/repos/Esri/arcgis-rest-js/contributors","subscribers_url":"https://api.github.com/repos/Esri/arcgis-rest-js/subscribers","subscription_url":"https://api.github.com/repos/Esri/arcgis-rest-js/subscription","commits_url":"https://api.github.com/repos/Esri/arcgis-rest-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Esri/arcgis-rest-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Esri/arcgis-rest-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Esri/arcgis-rest-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Esri/arcgis-rest-js/contents/{+path}","compare_url":"https://api.github.com/repos/Esri/arcgis-rest-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Esri/arcgis-rest-js/merges","archive_url":"https://api.github.com/repos/Esri/arcgis-rest-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Esri/arcgis-rest-js/downloads","issues_url":"https://api.github.com/repos/Esri/arcgis-rest-js/issues{/number}","pulls_url":"https://api.github.com/repos/Esri/arcgis-rest-js/pulls{/number}","milestones_url":"https://api.github.com/repos/Esri/arcgis-rest-js/milestones{/number}","notifications_url":"https://api.github.com/repos/Esri/arcgis-rest-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Esri/arcgis-rest-js/labels{/name}","releases_url":"https://api.github.com/repos/Esri/arcgis-rest-js/releases{/id}","deployments_url":"https://api.github.com/repos/Esri/arcgis-rest-js/deployments","created_at":"2017-07-10T15:40:20Z","updated_at":"2018-05-05T23:55:58Z","pushed_at":"2018-05-07T20:14:45Z","git_url":"git://github.com/Esri/arcgis-rest-js.git","ssh_url":"git@github.com:Esri/arcgis-rest-js.git","clone_url":"https://github.com/Esri/arcgis-rest-js.git","svn_url":"https://github.com/Esri/arcgis-rest-js","homepage":"https://esri.github.io/arcgis-rest-js/","size":2222,"stargazers_count":57,"watchers_count":57,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":10,"open_issues":26,"watchers":57,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Esri/arcgis-rest-js/pulls/185"},"html":{"href":"https://github.com/Esri/arcgis-rest-js/pull/185"},"issue":{"href":"https://api.github.com/repos/Esri/arcgis-rest-js/issues/185"},"comments":{"href":"https://api.github.com/repos/Esri/arcgis-rest-js/issues/185/comments"},"review_comments":{"href":"https://api.github.com/repos/Esri/arcgis-rest-js/pulls/185/comments"},"review_comment":{"href":"https://api.github.com/repos/Esri/arcgis-rest-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Esri/arcgis-rest-js/pulls/185/commits"},"statuses":{"href":"https://api.github.com/repos/Esri/arcgis-rest-js/statuses/744e8fd0710e04e0ad8b7bd6da05ca386339fe7b"}},"author_association":"NONE"}}
{"actor":{"display_login":"COV-GIS"}}