{"action":"created","issue":{"url":"https://api.github.com/repos/RadeonOpenCompute/ROCR-Runtime/issues/39","repository_url":"https://api.github.com/repos/RadeonOpenCompute/ROCR-Runtime","labels_url":"https://api.github.com/repos/RadeonOpenCompute/ROCR-Runtime/issues/39/labels{/name}","comments_url":"https://api.github.com/repos/RadeonOpenCompute/ROCR-Runtime/issues/39/comments","events_url":"https://api.github.com/repos/RadeonOpenCompute/ROCR-Runtime/issues/39/events","html_url":"https://github.com/RadeonOpenCompute/ROCR-Runtime/pull/39","id":330065270,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMTY2MTY5","number":39,"title":"Replace memset with std::fill","user":{"login":"oleid","id":3369899,"node_id":"MDQ6VXNlcjMzNjk4OTk=","avatar_url":"https://avatars2.githubusercontent.com/u/3369899?v=4","gravatar_id":"","url":"https://api.github.com/users/oleid","html_url":"https://github.com/oleid","followers_url":"https://api.github.com/users/oleid/followers","following_url":"https://api.github.com/users/oleid/following{/other_user}","gists_url":"https://api.github.com/users/oleid/gists{/gist_id}","starred_url":"https://api.github.com/users/oleid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oleid/subscriptions","organizations_url":"https://api.github.com/users/oleid/orgs","repos_url":"https://api.github.com/users/oleid/repos","events_url":"https://api.github.com/users/oleid/events{/privacy}","received_events_url":"https://api.github.com/users/oleid/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-06T23:18:39Z","updated_at":"2018-12-06T14:32:56Z","closed_at":"2018-12-06T14:32:56Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/RadeonOpenCompute/ROCR-Runtime/pulls/39","html_url":"https://github.com/RadeonOpenCompute/ROCR-Runtime/pull/39","diff_url":"https://github.com/RadeonOpenCompute/ROCR-Runtime/pull/39.diff","patch_url":"https://github.com/RadeonOpenCompute/ROCR-Runtime/pull/39.patch"},"body":"gcc-8.1 on ArchLinux complains about _clearing an object of non-trivial type._\r\n\r\n<pre>\r\n[  2%] Building CXX object CMakeFiles/hsa-runtime64.dir/core/runtime/runtime.cpp.o\r\n/usr/bin/c++  -DHAVE_MEMFD_CREATE -DHSA_EXPORT=1 -DHSA_EXPORT_FINALIZER=1 -DHSA_EXPORT_IMAGES=1 -DLITTLEENDIAN_CPU=1 -DROCR_BUILD_ID=1.0.0- -D__linux__ -Dhsa_runtime64_EXPORTS -I/opt/rocm/libhsakmt/include/libhsakmt -I/home/oleid/packages/hsa-rocr/src/ROCR-Runtime/src -I/home/oleid/packages/hsa-rocr/src/ROCR-Runtime/src/inc -I/home/oleid/packages/hsa-rocr/src/ROCR-Runtime/src/core/inc -I/home/oleid/packages/hsa-rocr/src/ROCR-Runtime/src/libamdhsacode  -Wall -std=c++11  -fpic -Wl,--unresolved-symbols=ignore-in-shared-libs -fno-strict-aliasing -m64  -msse -msse2 -Werror -fexceptions -fno-rtti -fvisibility=hidden -Wno-error=sign-compare -Wno-sign-compare -Wno-write-strings -Wno-conversion-null -fno-math-errno -fno-threadsafe-statics -fmerge-all-constants -fms-extensions -Wno-error=comment -Wno-comment -Wno-error=pointer-arith -Wno-pointer-arith -Wno-error=unused-variable -Wno-error=unused-but-set-variable -Wno-error=unused-function -fPIC   -D __STDC_LIMIT_MACROS -D __STDC_CONSTANT_MACROS -D __STDC_FORMAT_MACROS -D HSA_DEPRECATED= -o CMakeFiles/hsa-runtime64.dir/core/runtime/runtime.cpp.o -c /home/oleid/packages/hsa-rocr/src/ROCR-Runtime/src/core/runtime/runtime.cpp\r\n/home/oleid/packages/hsa-rocr/src/ROCR-Runtime/src/core/runtime/runtime.cpp: In member function 'void core::Runtime::SetLinkCount(size_t)':\r\n/home/oleid/packages/hsa-rocr/src/ROCR-Runtime/src/core/runtime/runtime.cpp:260:71: error: 'void* memset(void*, int, size_t)' clearing an object of non-trivial type '__gnu_cxx::__alloc_traits<std::allocator<core::Runtime::LinkInfo>, core::Runtime::LinkInfo>::value_type' {aka 'struct core::Runtime::LinkInfo'}; use assignment or value-initialization instead [-Werror=class-memaccess]\r\n          link_matrix_.size() * sizeof(hsa_amd_memory_pool_link_info_t));\r\n                                                                       ^\r\nIn file included from /home/oleid/packages/hsa-rocr/src/ROCR-Runtime/src/core/runtime/runtime.cpp:43:\r\n/home/oleid/packages/hsa-rocr/src/ROCR-Runtime/src/core/inc/runtime.h:96:10: note: '__gnu_cxx::__alloc_traits<std::allocator<core::Runtime::LinkInfo>, core::Runtime::LinkInfo>::value_type' {aka 'struct core::Runtime::LinkInfo'} declared here\r\n   struct LinkInfo {\r\n          ^~~~~~~~\r\ncc1plus: all warnings being treated as errors\r\nmake[2]: *** [CMakeFiles/hsa-runtime64.dir/build.make:352: CMakeFiles/hsa-runtime64.dir/core/runtime/runtime.cpp.o] Error 1\r\nmake[2]: Leaving directory '/home/oleid/packages/hsa-rocr/src/ROCR-Runtime/build'\r\nmake[1]: *** [CMakeFiles/Makefile2:71: CMakeFiles/hsa-runtime64.dir/all] Error 2\r\nmake[1]: Leaving directory '/home/oleid/packages/hsa-rocr/src/ROCR-Runtime/build'\r\nmake: *** [Makefile:155: all] Error 2\r\n==> ERROR: A failure occurred in build().\r\n    Aborting...\r\n</pre>\r\n\r\nThis patch makes the code more c++-ish."},"comment":{"url":"https://api.github.com/repos/RadeonOpenCompute/ROCR-Runtime/issues/comments/444890231","html_url":"https://github.com/RadeonOpenCompute/ROCR-Runtime/pull/39#issuecomment-444890231","issue_url":"https://api.github.com/repos/RadeonOpenCompute/ROCR-Runtime/issues/39","id":444890231,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NDg5MDIzMQ==","user":{"login":"jlgreathouse","id":12378225,"node_id":"MDQ6VXNlcjEyMzc4MjI1","avatar_url":"https://avatars3.githubusercontent.com/u/12378225?v=4","gravatar_id":"","url":"https://api.github.com/users/jlgreathouse","html_url":"https://github.com/jlgreathouse","followers_url":"https://api.github.com/users/jlgreathouse/followers","following_url":"https://api.github.com/users/jlgreathouse/following{/other_user}","gists_url":"https://api.github.com/users/jlgreathouse/gists{/gist_id}","starred_url":"https://api.github.com/users/jlgreathouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlgreathouse/subscriptions","organizations_url":"https://api.github.com/users/jlgreathouse/orgs","repos_url":"https://api.github.com/users/jlgreathouse/repos","events_url":"https://api.github.com/users/jlgreathouse/events{/privacy}","received_events_url":"https://api.github.com/users/jlgreathouse/received_events","type":"User","site_admin":false},"created_at":"2018-12-06T14:32:56Z","updated_at":"2018-12-06T14:32:56Z","author_association":"NONE","body":"I believe that this is fixed as of the release of the [ROCm 1.9.2 release](https://github.com/RadeonOpenCompute/ROCR-Runtime/releases/tag/roc-1.9.2) of ROCr. I can successfully build ROCr on Ubuntu 18.10 with GCC 8.2.0. Thanks for the patch that points out this issue!"}}
{"actor":{"display_login":"jlgreathouse"}}