{"action":"created","issue":{"url":"https://api.github.com/repos/glayzzle/php-parser/issues/176","repository_url":"https://api.github.com/repos/glayzzle/php-parser","labels_url":"https://api.github.com/repos/glayzzle/php-parser/issues/176/labels{/name}","comments_url":"https://api.github.com/repos/glayzzle/php-parser/issues/176/comments","events_url":"https://api.github.com/repos/glayzzle/php-parser/issues/176/events","html_url":"https://github.com/glayzzle/php-parser/issues/176","id":355519799,"node_id":"MDU6SXNzdWUzNTU1MTk3OTk=","number":176,"title":"[regressions] lost `?>` in program node","user":{"login":"evilebottnawi","id":4567934,"node_id":"MDQ6VXNlcjQ1Njc5MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4567934?v=4","gravatar_id":"","url":"https://api.github.com/users/evilebottnawi","html_url":"https://github.com/evilebottnawi","followers_url":"https://api.github.com/users/evilebottnawi/followers","following_url":"https://api.github.com/users/evilebottnawi/following{/other_user}","gists_url":"https://api.github.com/users/evilebottnawi/gists{/gist_id}","starred_url":"https://api.github.com/users/evilebottnawi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evilebottnawi/subscriptions","organizations_url":"https://api.github.com/users/evilebottnawi/orgs","repos_url":"https://api.github.com/users/evilebottnawi/repos","events_url":"https://api.github.com/users/evilebottnawi/events{/privacy}","received_events_url":"https://api.github.com/users/evilebottnawi/received_events","type":"User","site_admin":false},"labels":[{"id":509957486,"node_id":"MDU6TGFiZWw1MDk5NTc0ODY=","url":"https://api.github.com/repos/glayzzle/php-parser/labels/AST","name":"AST","color":"c5def5","default":false},{"id":155056623,"node_id":"MDU6TGFiZWwxNTUwNTY2MjM=","url":"https://api.github.com/repos/glayzzle/php-parser/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":{"login":"ichiriac","id":173203,"node_id":"MDQ6VXNlcjE3MzIwMw==","avatar_url":"https://avatars2.githubusercontent.com/u/173203?v=4","gravatar_id":"","url":"https://api.github.com/users/ichiriac","html_url":"https://github.com/ichiriac","followers_url":"https://api.github.com/users/ichiriac/followers","following_url":"https://api.github.com/users/ichiriac/following{/other_user}","gists_url":"https://api.github.com/users/ichiriac/gists{/gist_id}","starred_url":"https://api.github.com/users/ichiriac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ichiriac/subscriptions","organizations_url":"https://api.github.com/users/ichiriac/orgs","repos_url":"https://api.github.com/users/ichiriac/repos","events_url":"https://api.github.com/users/ichiriac/events{/privacy}","received_events_url":"https://api.github.com/users/ichiriac/received_events","type":"User","site_admin":false},"assignees":[{"login":"ichiriac","id":173203,"node_id":"MDQ6VXNlcjE3MzIwMw==","avatar_url":"https://avatars2.githubusercontent.com/u/173203?v=4","gravatar_id":"","url":"https://api.github.com/users/ichiriac","html_url":"https://github.com/ichiriac","followers_url":"https://api.github.com/users/ichiriac/followers","following_url":"https://api.github.com/users/ichiriac/following{/other_user}","gists_url":"https://api.github.com/users/ichiriac/gists{/gist_id}","starred_url":"https://api.github.com/users/ichiriac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ichiriac/subscriptions","organizations_url":"https://api.github.com/users/ichiriac/orgs","repos_url":"https://api.github.com/users/ichiriac/repos","events_url":"https://api.github.com/users/ichiriac/events{/privacy}","received_events_url":"https://api.github.com/users/ichiriac/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-08-30T10:18:57Z","updated_at":"2018-08-30T11:19:32Z","closed_at":null,"author_association":"NONE","body":"Input:\r\n```\r\n<?php\r\n__LINE__\r\n?>\r\n```\r\n\r\nReproducible:\r\n```\r\nconst ast = parser.parseCode(text);\r\n\r\nconsole.log(ast.loc.source);\r\n```\r\n\r\n`ast.loc.source` doesn't contain `?>`, looks like regressions because in `3.0.0-alpha2` this token exists in source"},"comment":{"url":"https://api.github.com/repos/glayzzle/php-parser/issues/comments/417284166","html_url":"https://github.com/glayzzle/php-parser/issues/176#issuecomment-417284166","issue_url":"https://api.github.com/repos/glayzzle/php-parser/issues/176","id":417284166,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzI4NDE2Ng==","user":{"login":"ichiriac","id":173203,"node_id":"MDQ6VXNlcjE3MzIwMw==","avatar_url":"https://avatars2.githubusercontent.com/u/173203?v=4","gravatar_id":"","url":"https://api.github.com/users/ichiriac","html_url":"https://github.com/ichiriac","followers_url":"https://api.github.com/users/ichiriac/followers","following_url":"https://api.github.com/users/ichiriac/following{/other_user}","gists_url":"https://api.github.com/users/ichiriac/gists{/gist_id}","starred_url":"https://api.github.com/users/ichiriac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ichiriac/subscriptions","organizations_url":"https://api.github.com/users/ichiriac/orgs","repos_url":"https://api.github.com/users/ichiriac/repos","events_url":"https://api.github.com/users/ichiriac/events{/privacy}","received_events_url":"https://api.github.com/users/ichiriac/received_events","type":"User","site_admin":false},"created_at":"2018-08-30T11:19:32Z","updated_at":"2018-08-30T11:19:32Z","author_association":"MEMBER","body":"yes, introduced by ignoring the close tag https://github.com/glayzzle/php-parser/issues/168 - I'll fix it but it could be a good practice to remove the last `?>` if there is no output after, in order to avoid extra spacing errors that could trigger a bad echo"}}
{"actor":{"display_login":"ichiriac"}}