{"action":"created","issue":{"url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues/785","repository_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine","labels_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues/785/labels{/name}","comments_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues/785/comments","events_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues/785/events","html_url":"https://github.com/wireapp/wire-ios-sync-engine/pull/785","id":335825655,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NDI3MDk3","number":785,"title":"Avoid double timer system messages","user":{"login":"nicorsm","id":2906234,"node_id":"MDQ6VXNlcjI5MDYyMzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2906234?v=4","gravatar_id":"","url":"https://api.github.com/users/nicorsm","html_url":"https://github.com/nicorsm","followers_url":"https://api.github.com/users/nicorsm/followers","following_url":"https://api.github.com/users/nicorsm/following{/other_user}","gists_url":"https://api.github.com/users/nicorsm/gists{/gist_id}","starred_url":"https://api.github.com/users/nicorsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicorsm/subscriptions","organizations_url":"https://api.github.com/users/nicorsm/orgs","repos_url":"https://api.github.com/users/nicorsm/repos","events_url":"https://api.github.com/users/nicorsm/events{/privacy}","received_events_url":"https://api.github.com/users/nicorsm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-26T13:41:55Z","updated_at":"2018-06-27T09:37:56Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls/785","html_url":"https://github.com/wireapp/wire-ios-sync-engine/pull/785","diff_url":"https://github.com/wireapp/wire-ios-sync-engine/pull/785.diff","patch_url":"https://github.com/wireapp/wire-ios-sync-engine/pull/785.patch"},"body":"## What's new in this PR?\r\n\r\nWhen a user changes the timer of a conversation, the system message is appended twice. This is because SE is considering the change sent from `ZMTransportSession`. I'm discarding the message if there are changes and if they're made by the current user.\r\n\r\n**Problem**: this solution doesn't work with _Off_ - in this case, the change is not ignored because here `.none` is different than `nil`:\r\nhttps://github.com/wireapp/wire-ios-sync-engine/blob/4bef033b9ee20872d9c69b03c9e6682b550b6d10/Source/Synchronization/Transcoders/ZMConversationTranscoder.swift#L50-L52"},"comment":{"url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues/comments/400609031","html_url":"https://github.com/wireapp/wire-ios-sync-engine/pull/785#issuecomment-400609031","issue_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues/785","id":400609031,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDYwOTAzMQ==","user":{"login":"wire-bot","id":20773876,"node_id":"MDQ6VXNlcjIwNzczODc2","avatar_url":"https://avatars3.githubusercontent.com/u/20773876?v=4","gravatar_id":"","url":"https://api.github.com/users/wire-bot","html_url":"https://github.com/wire-bot","followers_url":"https://api.github.com/users/wire-bot/followers","following_url":"https://api.github.com/users/wire-bot/following{/other_user}","gists_url":"https://api.github.com/users/wire-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/wire-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wire-bot/subscriptions","organizations_url":"https://api.github.com/users/wire-bot/orgs","repos_url":"https://api.github.com/users/wire-bot/repos","events_url":"https://api.github.com/users/wire-bot/events{/privacy}","received_events_url":"https://api.github.com/users/wire-bot/received_events","type":"User","site_admin":false},"created_at":"2018-06-27T09:37:56Z","updated_at":"2018-06-27T09:37:56Z","author_association":"COLLABORATOR","body":"<!--\n  0 Errors\n  1 Warning: Capabilities for WireSyncEngin...\n  0 Messages\n  0 Markdowns\n-->\n<table>\n  <thead>\n    <tr>\n      <th width=\"50\"></th>\n      <th width=\"100%\" data-danger-table=\"true\" data-kind=\"Warning\">\n          1 Warning\n      </th>\n     </tr>\n  </thead>\n  <tbody>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\">Capabilities for WireSyncEngine Test Host may not function correctly because its entitlements use a placeholder team ID. To resolve this, select a development team in the build settings editor. (in target ‘WireSyncEngine Test Host’)</td>\n    </tr>\n  </tbody>\n</table>\n\n<p align=\"right\" data-meta=\"generated_by_danger\">\n  Generated by :no_entry_sign: <a href=\"http://danger.systems/\">Danger</a>\n</p>\n"}}
{"actor":{"display_login":"wire-bot"}}