{"action":"closed","number":6982,"pull_request":{"url":"https://api.github.com/repos/webpack/webpack/pulls/6982","id":180133431,"html_url":"https://github.com/webpack/webpack/pull/6982","diff_url":"https://github.com/webpack/webpack/pull/6982.diff","patch_url":"https://github.com/webpack/webpack/pull/6982.patch","issue_url":"https://api.github.com/repos/webpack/webpack/issues/6982","number":6982,"state":"closed","locked":false,"title":"JSON and Date API usage fixes","user":{"login":"mohsen1","id":543633,"avatar_url":"https://avatars0.githubusercontent.com/u/543633?v=4","gravatar_id":"","url":"https://api.github.com/users/mohsen1","html_url":"https://github.com/mohsen1","followers_url":"https://api.github.com/users/mohsen1/followers","following_url":"https://api.github.com/users/mohsen1/following{/other_user}","gists_url":"https://api.github.com/users/mohsen1/gists{/gist_id}","starred_url":"https://api.github.com/users/mohsen1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mohsen1/subscriptions","organizations_url":"https://api.github.com/users/mohsen1/orgs","repos_url":"https://api.github.com/users/mohsen1/repos","events_url":"https://api.github.com/users/mohsen1/events{/privacy}","received_events_url":"https://api.github.com/users/mohsen1/received_events","type":"User","site_admin":false},"body":"<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. -->\r\n\r\n**What kind of change does this PR introduce?**\r\nRefactor \r\n<!-- E.g. a bugfix, feature, refactoring, build related change, etc… -->\r\n\r\n**Did you add tests for your changes?**\r\nNo\r\n<!-- Note that we won't merge your changes if you don't add tests -->\r\n\r\n**If relevant, link to documentation update:**\r\nN/A\r\n<!-- Link PR from webpack/webpack.js.org here, or N/A -->\r\n\r\n**Summary**\r\nAs part of https://github.com/webpack/webpack/pull/6862 I'm fixing issues that TypeScript has found. \r\n\r\n<!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? -->\r\n<!-- Try to link to an open issue for more information. -->\r\n\r\n**Does this PR introduce a breaking change?**\r\nNo\r\n<!-- If this PR introduces a breaking change, please describe the impact and a migration path for existing applications. -->\r\n\r\n**Other information**\r\n","created_at":"2018-04-08T01:18:58Z","updated_at":"2018-04-11T14:42:16Z","closed_at":"2018-04-11T14:42:16Z","merged_at":"2018-04-11T14:42:16Z","merge_commit_sha":"0b1e9d8e09aa3f346707776f08f3307b06758d8d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":572712741,"url":"https://api.github.com/repos/webpack/webpack/labels/PR:%20CI-ok","name":"PR: CI-ok","color":"0e8a16","default":false},{"id":575750680,"url":"https://api.github.com/repos/webpack/webpack/labels/PR:%20reviewed-approved","name":"PR: reviewed-approved","color":"0e8a16","default":false},{"id":575748502,"url":"https://api.github.com/repos/webpack/webpack/labels/PR:%20small","name":"PR: small","color":"5319e7","default":false},{"id":572838417,"url":"https://api.github.com/repos/webpack/webpack/labels/PR:%20tests-needed","name":"PR: tests-needed","color":"d93f0b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/webpack/webpack/pulls/6982/commits","review_comments_url":"https://api.github.com/repos/webpack/webpack/pulls/6982/comments","review_comment_url":"https://api.github.com/repos/webpack/webpack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/webpack/webpack/issues/6982/comments","statuses_url":"https://api.github.com/repos/webpack/webpack/statuses/37ff424dd9c7b010523b537cc6e2065716915ed0","head":{"label":"mohsen1:json-and-date-api-fixes","ref":"json-and-date-api-fixes","sha":"37ff424dd9c7b010523b537cc6e2065716915ed0","user":{"login":"mohsen1","id":543633,"avatar_url":"https://avatars0.githubusercontent.com/u/543633?v=4","gravatar_id":"","url":"https://api.github.com/users/mohsen1","html_url":"https://github.com/mohsen1","followers_url":"https://api.github.com/users/mohsen1/followers","following_url":"https://api.github.com/users/mohsen1/following{/other_user}","gists_url":"https://api.github.com/users/mohsen1/gists{/gist_id}","starred_url":"https://api.github.com/users/mohsen1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mohsen1/subscriptions","organizations_url":"https://api.github.com/users/mohsen1/orgs","repos_url":"https://api.github.com/users/mohsen1/repos","events_url":"https://api.github.com/users/mohsen1/events{/privacy}","received_events_url":"https://api.github.com/users/mohsen1/received_events","type":"User","site_admin":false},"repo":{"id":64545052,"name":"webpack","full_name":"mohsen1/webpack","owner":{"login":"mohsen1","id":543633,"avatar_url":"https://avatars0.githubusercontent.com/u/543633?v=4","gravatar_id":"","url":"https://api.github.com/users/mohsen1","html_url":"https://github.com/mohsen1","followers_url":"https://api.github.com/users/mohsen1/followers","following_url":"https://api.github.com/users/mohsen1/following{/other_user}","gists_url":"https://api.github.com/users/mohsen1/gists{/gist_id}","starred_url":"https://api.github.com/users/mohsen1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mohsen1/subscriptions","organizations_url":"https://api.github.com/users/mohsen1/orgs","repos_url":"https://api.github.com/users/mohsen1/repos","events_url":"https://api.github.com/users/mohsen1/events{/privacy}","received_events_url":"https://api.github.com/users/mohsen1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mohsen1/webpack","description":"A bundler for javascript and friends. Packs many modules into a few bundled assets. Code Splitting allows to load parts for the application on demand. Through \"loaders,\" modules can be CommonJs, AMD, ES6 modules, CSS, Images, JSON, Coffeescript, LESS, ... and your custom stuff.","fork":true,"url":"https://api.github.com/repos/mohsen1/webpack","forks_url":"https://api.github.com/repos/mohsen1/webpack/forks","keys_url":"https://api.github.com/repos/mohsen1/webpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mohsen1/webpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mohsen1/webpack/teams","hooks_url":"https://api.github.com/repos/mohsen1/webpack/hooks","issue_events_url":"https://api.github.com/repos/mohsen1/webpack/issues/events{/number}","events_url":"https://api.github.com/repos/mohsen1/webpack/events","assignees_url":"https://api.github.com/repos/mohsen1/webpack/assignees{/user}","branches_url":"https://api.github.com/repos/mohsen1/webpack/branches{/branch}","tags_url":"https://api.github.com/repos/mohsen1/webpack/tags","blobs_url":"https://api.github.com/repos/mohsen1/webpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mohsen1/webpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mohsen1/webpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/mohsen1/webpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mohsen1/webpack/statuses/{sha}","languages_url":"https://api.github.com/repos/mohsen1/webpack/languages","stargazers_url":"https://api.github.com/repos/mohsen1/webpack/stargazers","contributors_url":"https://api.github.com/repos/mohsen1/webpack/contributors","subscribers_url":"https://api.github.com/repos/mohsen1/webpack/subscribers","subscription_url":"https://api.github.com/repos/mohsen1/webpack/subscription","commits_url":"https://api.github.com/repos/mohsen1/webpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/mohsen1/webpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/mohsen1/webpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/mohsen1/webpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/mohsen1/webpack/contents/{+path}","compare_url":"https://api.github.com/repos/mohsen1/webpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mohsen1/webpack/merges","archive_url":"https://api.github.com/repos/mohsen1/webpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mohsen1/webpack/downloads","issues_url":"https://api.github.com/repos/mohsen1/webpack/issues{/number}","pulls_url":"https://api.github.com/repos/mohsen1/webpack/pulls{/number}","milestones_url":"https://api.github.com/repos/mohsen1/webpack/milestones{/number}","notifications_url":"https://api.github.com/repos/mohsen1/webpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mohsen1/webpack/labels{/name}","releases_url":"https://api.github.com/repos/mohsen1/webpack/releases{/id}","deployments_url":"https://api.github.com/repos/mohsen1/webpack/deployments","created_at":"2016-07-30T13:18:51Z","updated_at":"2018-04-04T04:37:12Z","pushed_at":"2018-04-10T19:32:12Z","git_url":"git://github.com/mohsen1/webpack.git","ssh_url":"git@github.com:mohsen1/webpack.git","clone_url":"https://github.com/mohsen1/webpack.git","svn_url":"https://github.com/mohsen1/webpack","homepage":"https://webpack.github.io","size":12620,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"webpack:master","ref":"master","sha":"c1a3676a802cb830b4a198b45f80a580cfb95525","user":{"login":"webpack","id":2105791,"avatar_url":"https://avatars2.githubusercontent.com/u/2105791?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack","html_url":"https://github.com/webpack","followers_url":"https://api.github.com/users/webpack/followers","following_url":"https://api.github.com/users/webpack/following{/other_user}","gists_url":"https://api.github.com/users/webpack/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack/subscriptions","organizations_url":"https://api.github.com/users/webpack/orgs","repos_url":"https://api.github.com/users/webpack/repos","events_url":"https://api.github.com/users/webpack/events{/privacy}","received_events_url":"https://api.github.com/users/webpack/received_events","type":"Organization","site_admin":false},"repo":{"id":3678731,"name":"webpack","full_name":"webpack/webpack","owner":{"login":"webpack","id":2105791,"avatar_url":"https://avatars2.githubusercontent.com/u/2105791?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack","html_url":"https://github.com/webpack","followers_url":"https://api.github.com/users/webpack/followers","following_url":"https://api.github.com/users/webpack/following{/other_user}","gists_url":"https://api.github.com/users/webpack/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack/subscriptions","organizations_url":"https://api.github.com/users/webpack/orgs","repos_url":"https://api.github.com/users/webpack/repos","events_url":"https://api.github.com/users/webpack/events{/privacy}","received_events_url":"https://api.github.com/users/webpack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webpack/webpack","description":"A bundler for javascript and friends. Packs many modules into a few bundled assets. Code Splitting allows to load parts for the application on demand. Through \"loaders,\" modules can be CommonJs, AMD, ES6 modules, CSS, Images, JSON, Coffeescript, LESS, ... and your custom stuff.","fork":false,"url":"https://api.github.com/repos/webpack/webpack","forks_url":"https://api.github.com/repos/webpack/webpack/forks","keys_url":"https://api.github.com/repos/webpack/webpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webpack/webpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webpack/webpack/teams","hooks_url":"https://api.github.com/repos/webpack/webpack/hooks","issue_events_url":"https://api.github.com/repos/webpack/webpack/issues/events{/number}","events_url":"https://api.github.com/repos/webpack/webpack/events","assignees_url":"https://api.github.com/repos/webpack/webpack/assignees{/user}","branches_url":"https://api.github.com/repos/webpack/webpack/branches{/branch}","tags_url":"https://api.github.com/repos/webpack/webpack/tags","blobs_url":"https://api.github.com/repos/webpack/webpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webpack/webpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webpack/webpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/webpack/webpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webpack/webpack/statuses/{sha}","languages_url":"https://api.github.com/repos/webpack/webpack/languages","stargazers_url":"https://api.github.com/repos/webpack/webpack/stargazers","contributors_url":"https://api.github.com/repos/webpack/webpack/contributors","subscribers_url":"https://api.github.com/repos/webpack/webpack/subscribers","subscription_url":"https://api.github.com/repos/webpack/webpack/subscription","commits_url":"https://api.github.com/repos/webpack/webpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/webpack/webpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/webpack/webpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/webpack/webpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/webpack/webpack/contents/{+path}","compare_url":"https://api.github.com/repos/webpack/webpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webpack/webpack/merges","archive_url":"https://api.github.com/repos/webpack/webpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webpack/webpack/downloads","issues_url":"https://api.github.com/repos/webpack/webpack/issues{/number}","pulls_url":"https://api.github.com/repos/webpack/webpack/pulls{/number}","milestones_url":"https://api.github.com/repos/webpack/webpack/milestones{/number}","notifications_url":"https://api.github.com/repos/webpack/webpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webpack/webpack/labels{/name}","releases_url":"https://api.github.com/repos/webpack/webpack/releases{/id}","deployments_url":"https://api.github.com/repos/webpack/webpack/deployments","created_at":"2012-03-10T10:08:14Z","updated_at":"2018-04-11T14:41:55Z","pushed_at":"2018-04-11T14:42:16Z","git_url":"git://github.com/webpack/webpack.git","ssh_url":"git@github.com:webpack/webpack.git","clone_url":"https://github.com/webpack/webpack.git","svn_url":"https://github.com/webpack/webpack","homepage":"https://webpack.js.org","size":13039,"stargazers_count":39718,"watchers_count":39718,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4950,"mirror_url":null,"archived":false,"open_issues_count":526,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":4950,"open_issues":526,"watchers":39718,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/webpack/webpack/pulls/6982"},"html":{"href":"https://github.com/webpack/webpack/pull/6982"},"issue":{"href":"https://api.github.com/repos/webpack/webpack/issues/6982"},"comments":{"href":"https://api.github.com/repos/webpack/webpack/issues/6982/comments"},"review_comments":{"href":"https://api.github.com/repos/webpack/webpack/pulls/6982/comments"},"review_comment":{"href":"https://api.github.com/repos/webpack/webpack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/webpack/webpack/pulls/6982/commits"},"statuses":{"href":"https://api.github.com/repos/webpack/webpack/statuses/37ff424dd9c7b010523b537cc6e2065716915ed0"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"sokra","id":1365881,"avatar_url":"https://avatars0.githubusercontent.com/u/1365881?v=4","gravatar_id":"","url":"https://api.github.com/users/sokra","html_url":"https://github.com/sokra","followers_url":"https://api.github.com/users/sokra/followers","following_url":"https://api.github.com/users/sokra/following{/other_user}","gists_url":"https://api.github.com/users/sokra/gists{/gist_id}","starred_url":"https://api.github.com/users/sokra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sokra/subscriptions","organizations_url":"https://api.github.com/users/sokra/orgs","repos_url":"https://api.github.com/users/sokra/repos","events_url":"https://api.github.com/users/sokra/events{/privacy}","received_events_url":"https://api.github.com/users/sokra/received_events","type":"User","site_admin":false},"comments":4,"review_comments":2,"maintainer_can_modify":false,"commits":3,"additions":3,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"sokra"}}