{"action":"created","comment":{"url":"https://api.github.com/repos/react-native-community/react-native-camera/pulls/comments/165754275","pull_request_review_id":93750121,"id":165754275,"diff_hunk":"@@ -1,4 +1,4 @@\n-<manifest xmlns:android=\"http://schemas.android.com/apk/res/android\" package=\"com.lwansbrough.RCTCamera\">\n+<manifest xmlns:android=\"http://schemas.android.com/apk/res/android\" package=\"org.reactnative\">","path":"android/src/main/AndroidManifest.xml","position":2,"original_position":2,"commit_id":"1805209e1c89f324dfadd7741a14a00500b335d2","original_commit_id":"1805209e1c89f324dfadd7741a14a00500b335d2","user":{"login":"sibelius","id":2005841,"avatar_url":"https://avatars3.githubusercontent.com/u/2005841?v=4","gravatar_id":"","url":"https://api.github.com/users/sibelius","html_url":"https://github.com/sibelius","followers_url":"https://api.github.com/users/sibelius/followers","following_url":"https://api.github.com/users/sibelius/following{/other_user}","gists_url":"https://api.github.com/users/sibelius/gists{/gist_id}","starred_url":"https://api.github.com/users/sibelius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sibelius/subscriptions","organizations_url":"https://api.github.com/users/sibelius/orgs","repos_url":"https://api.github.com/users/sibelius/repos","events_url":"https://api.github.com/users/sibelius/events{/privacy}","received_events_url":"https://api.github.com/users/sibelius/received_events","type":"User","site_admin":false},"body":"nice","created_at":"2018-02-02T20:41:14Z","updated_at":"2018-02-02T20:41:15Z","html_url":"https://github.com/react-native-community/react-native-camera/pull/1210#discussion_r165754275","pull_request_url":"https://api.github.com/repos/react-native-community/react-native-camera/pulls/1210","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/react-native-community/react-native-camera/pulls/comments/165754275"},"html":{"href":"https://github.com/react-native-community/react-native-camera/pull/1210#discussion_r165754275"},"pull_request":{"href":"https://api.github.com/repos/react-native-community/react-native-camera/pulls/1210"}}},"pull_request":{"url":"https://api.github.com/repos/react-native-community/react-native-camera/pulls/1210","id":166898416,"html_url":"https://github.com/react-native-community/react-native-camera/pull/1210","diff_url":"https://github.com/react-native-community/react-native-camera/pull/1210.diff","patch_url":"https://github.com/react-native-community/react-native-camera/pull/1210.patch","issue_url":"https://api.github.com/repos/react-native-community/react-native-camera/issues/1210","number":1210,"state":"open","locked":false,"title":"Rncamera migration","user":{"login":"jgfidelis","id":4925068,"avatar_url":"https://avatars1.githubusercontent.com/u/4925068?v=4","gravatar_id":"","url":"https://api.github.com/users/jgfidelis","html_url":"https://github.com/jgfidelis","followers_url":"https://api.github.com/users/jgfidelis/followers","following_url":"https://api.github.com/users/jgfidelis/following{/other_user}","gists_url":"https://api.github.com/users/jgfidelis/gists{/gist_id}","starred_url":"https://api.github.com/users/jgfidelis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgfidelis/subscriptions","organizations_url":"https://api.github.com/users/jgfidelis/orgs","repos_url":"https://api.github.com/users/jgfidelis/repos","events_url":"https://api.github.com/users/jgfidelis/events{/privacy}","received_events_url":"https://api.github.com/users/jgfidelis/received_events","type":"User","site_admin":false},"body":"iOS is working fine (in example).\r\n\r\nAndroid rncamera example is not starting \r\n\r\n```\r\n02-02 18:35:20.409 31142-31142/com.rncameraexample E/AndroidRuntime: FATAL EXCEPTION: main\r\n                                                                     Process: com.rncameraexample, PID: 31142\r\n                                                                     java.lang.NullPointerException: Attempt to invoke interface method 'java.lang.Object java.util.SortedSet.last()' on a null object reference\r\n                                                                         at com.google.android.cameraview.Camera1.adjustCameraParameters(Camera1.java:475)\r\n                                                                         at com.google.android.cameraview.Camera1$1.onSurfaceChanged(Camera1.java:108)\r\n                                                                         at com.google.android.cameraview.PreviewImpl.dispatchSurfaceChanged(PreviewImpl.java:56)\r\n                                                                         at com.google.android.cameraview.TextureViewPreview$1.onSurfaceTextureAvailable(TextureViewPreview.java:45)\r\n                                                                         at android.view.TextureView.getHardwareLayer(TextureView.java:370)\r\n                                                                         at android.view.View.updateDisplayListIfDirty(View.java:15443)\r\n                                                                         at android.view.View.getDisplayList(View.java:15488)\r\n                                                                         at android.view.View.draw(View.java:16258)\r\n                                                                         at android.view.ViewGroup.drawChild(ViewGroup.java:3713)\r\n                                                                         at android.view.ViewGroup.dispatchDraw(ViewGroup.java:3506)\r\n                                                                         at android.view.View.draw(View.java:16539)\r\n                                                                         at android.widget.FrameLayout.draw(FrameLayout.java:598)\r\n                                                                         at android.view.View.updateDisplayListIfDirty(View.java:15466)\r\n                                                                         at android.view.View.getDisplayList(View.java:15488)\r\n                                                                         at android.view.View.draw(View.java:16258)\r\n                                                                         at android.view.ViewGroup.drawChild(ViewGroup.java:3713)\r\n                                                                         at android.view.ViewGroup.dispatchDraw(ViewGroup.java:3506)\r\n                                                                         at com.facebook.react.views.view.ReactViewGroup.dispatchDraw(ReactViewGroup.java:778)\r\n                                                                         at android.view.View.draw(View.java:16539)\r\n                                                                         at android.view.View.updateDisplayListIfDirty(View.java:15466)\r\n                                                                         at android.view.View.getDisplayList(View.java:15488)\r\n                                                                         at android.view.View.draw(View.java:16258)\r\n                                                                         at android.view.ViewGroup.drawChild(ViewGroup.java:3713)\r\n                                                                         at android.view.ViewGroup.dispatchDraw(ViewGroup.java:3506)\r\n                                                                         at android.view.View.updateDisplayListIfDirty(View.java:15461)\r\n                                                                         at android.view.View.getDisplayList(View.java:15488)\r\n                                                                         at android.view.View.draw(View.java:16258)\r\n                                                                         at android.view.ViewGroup.drawChild(ViewGroup.java:3713)\r\n                                                                         at android.view.ViewGroup.dispatchDraw(ViewGroup.java:3506)\r\n                                                                         at android.view.View.updateDisplayListIfDirty(View.java:15461)\r\n                                                                         at android.view.View.getDisplayList(View.java:15488)\r\n                                                                         at android.view.View.draw(View.java:16258)\r\n                                                                         at android.view.ViewGroup.drawChild(ViewGroup.java:3713)\r\n                                                                         at android.view.ViewGroup.dispatchDraw(ViewGroup.java:3506)\r\n                                                                         at android.view.View.updateDisplayListIfDirty(View.java:15461)\r\n                                                                         at android.view.View.getDisplayList(View.java:15488)\r\n                                                                         at android.view.View.draw(View.java:16258)\r\n                                                                         at android.view.ViewGroup.drawChild(ViewGroup.java:3713)\r\n                                                                         at android.view.ViewGroup.dispatchDraw(ViewGroup.java:3506)\r\n                                                                         at android.view.View.draw(View.java:16539)\r\n                                                                         at android.widget.FrameLayout.draw(FrameLayout.java:598)\r\n                                                                         at com.android.internal.policy.impl.PhoneWindow$DecorView.draw(PhoneWindow.java:3111)\r\n                                                                         at android.view.View.updateDisplayListIfDirty(View.java:15466)\r\n                                                                         at android.view.View.getDisplayList(View.java:15488)\r\n                                                                         at android.view.ThreadedRenderer.updateViewTreeDisplayList(ThreadedRenderer.java:309)\r\n                                                                         at android.view.ThreadedRenderer.updateRootDisplayList(ThreadedRenderer.java:315)\r\n                                                                         at android.view.ThreadedRenderer.draw(ThreadedRenderer.java:354)\r\n                                                                         at android.view.ViewRootImpl.draw(ViewRootImpl.java:2956)\r\n                                                                         at android.view.ViewRootImpl.performDraw(ViewRootImpl.java:2753)\r\n                                                                         at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:2339)\r\n                                                                         at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1314)\r\n                                                                         at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:7057)\r\n                                                                         at android.view.Choreographer$CallbackRecord.run(Choreographer.java:829)\r\n                                                                         at android.view.Choreographer.doCallbacks(Choreographer.java:606)\r\n                                                                         at android.view.Choreographer.doFrame(Choreographer.java:576)\r\n                                                                         at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:815)\r\n                                                                         at android.os.Handler.handleCallback(Handler.java:739)\r\n                                                                         at android.os.Handler.dispatchMessage(Handler.java:95)\r\n                                                                         at android.os.Looper.loop(Looper.java:145)\r\n                                                                         at android.app.ActivityThread.main(ActivityThread.java:6934)\r\n                                                                         at java.lang.reflect.Method.invoke(Native Method)\r\n                                                                         at java.lang.reflect.Method.invoke(Method.java:372)\r\n                                                                     \tat com.android\r\n```","created_at":"2018-02-02T20:40:12Z","updated_at":"2018-02-02T20:41:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d701cb0d1ea32fd56db36a5414c4655285abeb9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/react-native-community/react-native-camera/pulls/1210/commits","review_comments_url":"https://api.github.com/repos/react-native-community/react-native-camera/pulls/1210/comments","review_comment_url":"https://api.github.com/repos/react-native-community/react-native-camera/pulls/comments{/number}","comments_url":"https://api.github.com/repos/react-native-community/react-native-camera/issues/1210/comments","statuses_url":"https://api.github.com/repos/react-native-community/react-native-camera/statuses/1805209e1c89f324dfadd7741a14a00500b335d2","head":{"label":"jgfidelis:rncamera-migration","ref":"rncamera-migration","sha":"1805209e1c89f324dfadd7741a14a00500b335d2","user":{"login":"jgfidelis","id":4925068,"avatar_url":"https://avatars1.githubusercontent.com/u/4925068?v=4","gravatar_id":"","url":"https://api.github.com/users/jgfidelis","html_url":"https://github.com/jgfidelis","followers_url":"https://api.github.com/users/jgfidelis/followers","following_url":"https://api.github.com/users/jgfidelis/following{/other_user}","gists_url":"https://api.github.com/users/jgfidelis/gists{/gist_id}","starred_url":"https://api.github.com/users/jgfidelis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgfidelis/subscriptions","organizations_url":"https://api.github.com/users/jgfidelis/orgs","repos_url":"https://api.github.com/users/jgfidelis/repos","events_url":"https://api.github.com/users/jgfidelis/events{/privacy}","received_events_url":"https://api.github.com/users/jgfidelis/received_events","type":"User","site_admin":false},"repo":{"id":118178149,"name":"react-native-camera","full_name":"jgfidelis/react-native-camera","owner":{"login":"jgfidelis","id":4925068,"avatar_url":"https://avatars1.githubusercontent.com/u/4925068?v=4","gravatar_id":"","url":"https://api.github.com/users/jgfidelis","html_url":"https://github.com/jgfidelis","followers_url":"https://api.github.com/users/jgfidelis/followers","following_url":"https://api.github.com/users/jgfidelis/following{/other_user}","gists_url":"https://api.github.com/users/jgfidelis/gists{/gist_id}","starred_url":"https://api.github.com/users/jgfidelis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgfidelis/subscriptions","organizations_url":"https://api.github.com/users/jgfidelis/orgs","repos_url":"https://api.github.com/users/jgfidelis/repos","events_url":"https://api.github.com/users/jgfidelis/events{/privacy}","received_events_url":"https://api.github.com/users/jgfidelis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jgfidelis/react-native-camera","description":"A Camera component for React Native. Also supports barcode scanning!","fork":true,"url":"https://api.github.com/repos/jgfidelis/react-native-camera","forks_url":"https://api.github.com/repos/jgfidelis/react-native-camera/forks","keys_url":"https://api.github.com/repos/jgfidelis/react-native-camera/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jgfidelis/react-native-camera/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jgfidelis/react-native-camera/teams","hooks_url":"https://api.github.com/repos/jgfidelis/react-native-camera/hooks","issue_events_url":"https://api.github.com/repos/jgfidelis/react-native-camera/issues/events{/number}","events_url":"https://api.github.com/repos/jgfidelis/react-native-camera/events","assignees_url":"https://api.github.com/repos/jgfidelis/react-native-camera/assignees{/user}","branches_url":"https://api.github.com/repos/jgfidelis/react-native-camera/branches{/branch}","tags_url":"https://api.github.com/repos/jgfidelis/react-native-camera/tags","blobs_url":"https://api.github.com/repos/jgfidelis/react-native-camera/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jgfidelis/react-native-camera/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jgfidelis/react-native-camera/git/refs{/sha}","trees_url":"https://api.github.com/repos/jgfidelis/react-native-camera/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jgfidelis/react-native-camera/statuses/{sha}","languages_url":"https://api.github.com/repos/jgfidelis/react-native-camera/languages","stargazers_url":"https://api.github.com/repos/jgfidelis/react-native-camera/stargazers","contributors_url":"https://api.github.com/repos/jgfidelis/react-native-camera/contributors","subscribers_url":"https://api.github.com/repos/jgfidelis/react-native-camera/subscribers","subscription_url":"https://api.github.com/repos/jgfidelis/react-native-camera/subscription","commits_url":"https://api.github.com/repos/jgfidelis/react-native-camera/commits{/sha}","git_commits_url":"https://api.github.com/repos/jgfidelis/react-native-camera/git/commits{/sha}","comments_url":"https://api.github.com/repos/jgfidelis/react-native-camera/comments{/number}","issue_comment_url":"https://api.github.com/repos/jgfidelis/react-native-camera/issues/comments{/number}","contents_url":"https://api.github.com/repos/jgfidelis/react-native-camera/contents/{+path}","compare_url":"https://api.github.com/repos/jgfidelis/react-native-camera/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jgfidelis/react-native-camera/merges","archive_url":"https://api.github.com/repos/jgfidelis/react-native-camera/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jgfidelis/react-native-camera/downloads","issues_url":"https://api.github.com/repos/jgfidelis/react-native-camera/issues{/number}","pulls_url":"https://api.github.com/repos/jgfidelis/react-native-camera/pulls{/number}","milestones_url":"https://api.github.com/repos/jgfidelis/react-native-camera/milestones{/number}","notifications_url":"https://api.github.com/repos/jgfidelis/react-native-camera/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jgfidelis/react-native-camera/labels{/name}","releases_url":"https://api.github.com/repos/jgfidelis/react-native-camera/releases{/id}","deployments_url":"https://api.github.com/repos/jgfidelis/react-native-camera/deployments","created_at":"2018-01-19T21:02:42Z","updated_at":"2018-02-02T17:53:24Z","pushed_at":"2018-02-02T20:39:12Z","git_url":"git://github.com/jgfidelis/react-native-camera.git","ssh_url":"git@github.com:jgfidelis/react-native-camera.git","clone_url":"https://github.com/jgfidelis/react-native-camera.git","svn_url":"https://github.com/jgfidelis/react-native-camera","homepage":"","size":8587,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"react-native-community:master","ref":"master","sha":"97f4e69375d63176a8390d6ee0576cdeda36caf1","user":{"login":"react-native-community","id":20269980,"avatar_url":"https://avatars1.githubusercontent.com/u/20269980?v=4","gravatar_id":"","url":"https://api.github.com/users/react-native-community","html_url":"https://github.com/react-native-community","followers_url":"https://api.github.com/users/react-native-community/followers","following_url":"https://api.github.com/users/react-native-community/following{/other_user}","gists_url":"https://api.github.com/users/react-native-community/gists{/gist_id}","starred_url":"https://api.github.com/users/react-native-community/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/react-native-community/subscriptions","organizations_url":"https://api.github.com/users/react-native-community/orgs","repos_url":"https://api.github.com/users/react-native-community/repos","events_url":"https://api.github.com/users/react-native-community/events{/privacy}","received_events_url":"https://api.github.com/users/react-native-community/received_events","type":"Organization","site_admin":false},"repo":{"id":33218414,"name":"react-native-camera","full_name":"react-native-community/react-native-camera","owner":{"login":"react-native-community","id":20269980,"avatar_url":"https://avatars1.githubusercontent.com/u/20269980?v=4","gravatar_id":"","url":"https://api.github.com/users/react-native-community","html_url":"https://github.com/react-native-community","followers_url":"https://api.github.com/users/react-native-community/followers","following_url":"https://api.github.com/users/react-native-community/following{/other_user}","gists_url":"https://api.github.com/users/react-native-community/gists{/gist_id}","starred_url":"https://api.github.com/users/react-native-community/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/react-native-community/subscriptions","organizations_url":"https://api.github.com/users/react-native-community/orgs","repos_url":"https://api.github.com/users/react-native-community/repos","events_url":"https://api.github.com/users/react-native-community/events{/privacy}","received_events_url":"https://api.github.com/users/react-native-community/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/react-native-community/react-native-camera","description":"A Camera component for React Native. Also supports barcode scanning!","fork":false,"url":"https://api.github.com/repos/react-native-community/react-native-camera","forks_url":"https://api.github.com/repos/react-native-community/react-native-camera/forks","keys_url":"https://api.github.com/repos/react-native-community/react-native-camera/keys{/key_id}","collaborators_url":"https://api.github.com/repos/react-native-community/react-native-camera/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/react-native-community/react-native-camera/teams","hooks_url":"https://api.github.com/repos/react-native-community/react-native-camera/hooks","issue_events_url":"https://api.github.com/repos/react-native-community/react-native-camera/issues/events{/number}","events_url":"https://api.github.com/repos/react-native-community/react-native-camera/events","assignees_url":"https://api.github.com/repos/react-native-community/react-native-camera/assignees{/user}","branches_url":"https://api.github.com/repos/react-native-community/react-native-camera/branches{/branch}","tags_url":"https://api.github.com/repos/react-native-community/react-native-camera/tags","blobs_url":"https://api.github.com/repos/react-native-community/react-native-camera/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/react-native-community/react-native-camera/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/react-native-community/react-native-camera/git/refs{/sha}","trees_url":"https://api.github.com/repos/react-native-community/react-native-camera/git/trees{/sha}","statuses_url":"https://api.github.com/repos/react-native-community/react-native-camera/statuses/{sha}","languages_url":"https://api.github.com/repos/react-native-community/react-native-camera/languages","stargazers_url":"https://api.github.com/repos/react-native-community/react-native-camera/stargazers","contributors_url":"https://api.github.com/repos/react-native-community/react-native-camera/contributors","subscribers_url":"https://api.github.com/repos/react-native-community/react-native-camera/subscribers","subscription_url":"https://api.github.com/repos/react-native-community/react-native-camera/subscription","commits_url":"https://api.github.com/repos/react-native-community/react-native-camera/commits{/sha}","git_commits_url":"https://api.github.com/repos/react-native-community/react-native-camera/git/commits{/sha}","comments_url":"https://api.github.com/repos/react-native-community/react-native-camera/comments{/number}","issue_comment_url":"https://api.github.com/repos/react-native-community/react-native-camera/issues/comments{/number}","contents_url":"https://api.github.com/repos/react-native-community/react-native-camera/contents/{+path}","compare_url":"https://api.github.com/repos/react-native-community/react-native-camera/compare/{base}...{head}","merges_url":"https://api.github.com/repos/react-native-community/react-native-camera/merges","archive_url":"https://api.github.com/repos/react-native-community/react-native-camera/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/react-native-community/react-native-camera/downloads","issues_url":"https://api.github.com/repos/react-native-community/react-native-camera/issues{/number}","pulls_url":"https://api.github.com/repos/react-native-community/react-native-camera/pulls{/number}","milestones_url":"https://api.github.com/repos/react-native-community/react-native-camera/milestones{/number}","notifications_url":"https://api.github.com/repos/react-native-community/react-native-camera/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/react-native-community/react-native-camera/labels{/name}","releases_url":"https://api.github.com/repos/react-native-community/react-native-camera/releases{/id}","deployments_url":"https://api.github.com/repos/react-native-community/react-native-camera/deployments","created_at":"2015-04-01T00:54:40Z","updated_at":"2018-02-02T19:26:33Z","pushed_at":"2018-02-02T20:40:13Z","git_url":"git://github.com/react-native-community/react-native-camera.git","ssh_url":"git@github.com:react-native-community/react-native-camera.git","clone_url":"https://github.com/react-native-community/react-native-camera.git","svn_url":"https://github.com/react-native-community/react-native-camera","homepage":"","size":8587,"stargazers_count":4614,"watchers_count":4614,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1277,"mirror_url":null,"archived":false,"open_issues_count":357,"license":null,"forks":1277,"open_issues":357,"watchers":4614,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/react-native-community/react-native-camera/pulls/1210"},"html":{"href":"https://github.com/react-native-community/react-native-camera/pull/1210"},"issue":{"href":"https://api.github.com/repos/react-native-community/react-native-camera/issues/1210"},"comments":{"href":"https://api.github.com/repos/react-native-community/react-native-camera/issues/1210/comments"},"review_comments":{"href":"https://api.github.com/repos/react-native-community/react-native-camera/pulls/1210/comments"},"review_comment":{"href":"https://api.github.com/repos/react-native-community/react-native-camera/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/react-native-community/react-native-camera/pulls/1210/commits"},"statuses":{"href":"https://api.github.com/repos/react-native-community/react-native-camera/statuses/1805209e1c89f324dfadd7741a14a00500b335d2"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"sibelius"}}