{"action":"created","comment":{"url":"https://api.github.com/repos/thepracticaldev/dev.to/pulls/comments/234929090","pull_request_review_id":176674227,"id":234929090,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDkyOTA5MA==","diff_hunk":"@@ -1,29 +1,57 @@\n version: \"3\"\n services:\n-  web: &rails_base\n+  app: &app\n     build:\n-      dockerfile: Dockerfile\n+      dockerfile: ./Dockerfile\n       context: .\n-    ports:\n-      - \"3000:3000\"\n     depends_on:\n       - db\n     environment:\n-      RAILS_ENV: development\n-      DATABASE_URL: postgres://postgres:mysecretpassword@db:5432/postgres\n       YARN_INTEGRITY_ENABLED: \"false\"\n+      RAILS_ENV: ${RAILS_ENV:-development}\n+      DATABASE_URL: postgres://postgres:mysecretpassword@db:5432/devto_${RAILS_ENV:-development}\n+      DATABASE_CLEANER_ALLOW_REMOTE_DATABASE_URL: \"true\"\n+      WEBPACKER_DEV_SERVER_HOST: webpacker\n+\n     volumes:\n-      - .:/usr/src/app\n+      - .:/app","path":"docker-compose.yml","position":null,"original_position":24,"commit_id":"64977edd45360e002bde0fbace48b8649842529d","original_commit_id":"3ff16664e95fcd9874ee8e1f127cb3c2c578be0e","user":{"login":"dsalahutdinov","id":204024,"node_id":"MDQ6VXNlcjIwNDAyNA==","avatar_url":"https://avatars3.githubusercontent.com/u/204024?v=4","gravatar_id":"","url":"https://api.github.com/users/dsalahutdinov","html_url":"https://github.com/dsalahutdinov","followers_url":"https://api.github.com/users/dsalahutdinov/followers","following_url":"https://api.github.com/users/dsalahutdinov/following{/other_user}","gists_url":"https://api.github.com/users/dsalahutdinov/gists{/gist_id}","starred_url":"https://api.github.com/users/dsalahutdinov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsalahutdinov/subscriptions","organizations_url":"https://api.github.com/users/dsalahutdinov/orgs","repos_url":"https://api.github.com/users/dsalahutdinov/repos","events_url":"https://api.github.com/users/dsalahutdinov/events{/privacy}","received_events_url":"https://api.github.com/users/dsalahutdinov/received_events","type":"User","site_admin":false},"body":"@bibendi great point! fixed","created_at":"2018-11-20T09:40:10Z","updated_at":"2018-11-20T09:40:10Z","html_url":"https://github.com/thepracticaldev/dev.to/pull/1125#discussion_r234929090","pull_request_url":"https://api.github.com/repos/thepracticaldev/dev.to/pulls/1125","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/thepracticaldev/dev.to/pulls/comments/234929090"},"html":{"href":"https://github.com/thepracticaldev/dev.to/pull/1125#discussion_r234929090"},"pull_request":{"href":"https://api.github.com/repos/thepracticaldev/dev.to/pulls/1125"}},"in_reply_to_id":234891814},"pull_request":{"url":"https://api.github.com/repos/thepracticaldev/dev.to/pulls/1125","id":231227540,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMjI3NTQw","html_url":"https://github.com/thepracticaldev/dev.to/pull/1125","diff_url":"https://github.com/thepracticaldev/dev.to/pull/1125.diff","patch_url":"https://github.com/thepracticaldev/dev.to/pull/1125.patch","issue_url":"https://api.github.com/repos/thepracticaldev/dev.to/issues/1125","number":1125,"state":"open","locked":false,"title":"Docker compose config for developing and running tests","user":{"login":"dsalahutdinov","id":204024,"node_id":"MDQ6VXNlcjIwNDAyNA==","avatar_url":"https://avatars3.githubusercontent.com/u/204024?v=4","gravatar_id":"","url":"https://api.github.com/users/dsalahutdinov","html_url":"https://github.com/dsalahutdinov","followers_url":"https://api.github.com/users/dsalahutdinov/followers","following_url":"https://api.github.com/users/dsalahutdinov/following{/other_user}","gists_url":"https://api.github.com/users/dsalahutdinov/gists{/gist_id}","starred_url":"https://api.github.com/users/dsalahutdinov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsalahutdinov/subscriptions","organizations_url":"https://api.github.com/users/dsalahutdinov/orgs","repos_url":"https://api.github.com/users/dsalahutdinov/repos","events_url":"https://api.github.com/users/dsalahutdinov/events{/privacy}","received_events_url":"https://api.github.com/users/dsalahutdinov/received_events","type":"User","site_admin":false},"body":"<!--- Prepend PR title with [WIP] if work in progress. Remove when ready for review. -->\r\n\r\n## What type of PR is this? (check all applicable)\r\n\r\n- [x] Refactor\r\n- [ ] Feature\r\n- [ ] Bug Fix\r\n- [x] Documentation Update\r\n\r\n## Description\r\nAdded a couple of features for running project with docker:\r\n - persistent volumes for database, bundles, node_modules etc\r\n - support for test environment in docker compose, running specs by `docker-compose run app bundle exec rspec`\r\n -extracted special base service `app` for running tasks\r\n - install postgres client to support `rails db` and browsing database \r\n - minor documentation improvements\r\n\r\n## Related Tickets & Documents\r\n\r\n## Mobile & Desktop Screenshots/Recordings (if there are UI changes)\r\n\r\n## Added to documentation?\r\n\r\n- [ ] docs.dev.to\r\n- [x] readme\r\n- [ ] no documentation needed\r\n\r\n## [optional] What gif best describes this PR or how it makes you feel?\r\n\r\n","created_at":"2018-11-15T15:08:28Z","updated_at":"2018-11-20T09:40:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b1e679d753bd4f521160ba5c9f76d741352e31a1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1110193903,"node_id":"MDU6TGFiZWwxMTEwMTkzOTAz","url":"https://api.github.com/repos/thepracticaldev/dev.to/labels/PR:%20unreviewed","name":"PR: unreviewed","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/thepracticaldev/dev.to/pulls/1125/commits","review_comments_url":"https://api.github.com/repos/thepracticaldev/dev.to/pulls/1125/comments","review_comment_url":"https://api.github.com/repos/thepracticaldev/dev.to/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thepracticaldev/dev.to/issues/1125/comments","statuses_url":"https://api.github.com/repos/thepracticaldev/dev.to/statuses/64977edd45360e002bde0fbace48b8649842529d","head":{"label":"dsalahutdinov:master","ref":"master","sha":"64977edd45360e002bde0fbace48b8649842529d","user":{"login":"dsalahutdinov","id":204024,"node_id":"MDQ6VXNlcjIwNDAyNA==","avatar_url":"https://avatars3.githubusercontent.com/u/204024?v=4","gravatar_id":"","url":"https://api.github.com/users/dsalahutdinov","html_url":"https://github.com/dsalahutdinov","followers_url":"https://api.github.com/users/dsalahutdinov/followers","following_url":"https://api.github.com/users/dsalahutdinov/following{/other_user}","gists_url":"https://api.github.com/users/dsalahutdinov/gists{/gist_id}","starred_url":"https://api.github.com/users/dsalahutdinov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsalahutdinov/subscriptions","organizations_url":"https://api.github.com/users/dsalahutdinov/orgs","repos_url":"https://api.github.com/users/dsalahutdinov/repos","events_url":"https://api.github.com/users/dsalahutdinov/events{/privacy}","received_events_url":"https://api.github.com/users/dsalahutdinov/received_events","type":"User","site_admin":false},"repo":{"id":157728746,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc3Mjg3NDY=","name":"dev.to","full_name":"dsalahutdinov/dev.to","private":false,"owner":{"login":"dsalahutdinov","id":204024,"node_id":"MDQ6VXNlcjIwNDAyNA==","avatar_url":"https://avatars3.githubusercontent.com/u/204024?v=4","gravatar_id":"","url":"https://api.github.com/users/dsalahutdinov","html_url":"https://github.com/dsalahutdinov","followers_url":"https://api.github.com/users/dsalahutdinov/followers","following_url":"https://api.github.com/users/dsalahutdinov/following{/other_user}","gists_url":"https://api.github.com/users/dsalahutdinov/gists{/gist_id}","starred_url":"https://api.github.com/users/dsalahutdinov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsalahutdinov/subscriptions","organizations_url":"https://api.github.com/users/dsalahutdinov/orgs","repos_url":"https://api.github.com/users/dsalahutdinov/repos","events_url":"https://api.github.com/users/dsalahutdinov/events{/privacy}","received_events_url":"https://api.github.com/users/dsalahutdinov/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dsalahutdinov/dev.to","description":"Where programmers share ideas and help each other grow","fork":true,"url":"https://api.github.com/repos/dsalahutdinov/dev.to","forks_url":"https://api.github.com/repos/dsalahutdinov/dev.to/forks","keys_url":"https://api.github.com/repos/dsalahutdinov/dev.to/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dsalahutdinov/dev.to/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dsalahutdinov/dev.to/teams","hooks_url":"https://api.github.com/repos/dsalahutdinov/dev.to/hooks","issue_events_url":"https://api.github.com/repos/dsalahutdinov/dev.to/issues/events{/number}","events_url":"https://api.github.com/repos/dsalahutdinov/dev.to/events","assignees_url":"https://api.github.com/repos/dsalahutdinov/dev.to/assignees{/user}","branches_url":"https://api.github.com/repos/dsalahutdinov/dev.to/branches{/branch}","tags_url":"https://api.github.com/repos/dsalahutdinov/dev.to/tags","blobs_url":"https://api.github.com/repos/dsalahutdinov/dev.to/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dsalahutdinov/dev.to/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dsalahutdinov/dev.to/git/refs{/sha}","trees_url":"https://api.github.com/repos/dsalahutdinov/dev.to/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dsalahutdinov/dev.to/statuses/{sha}","languages_url":"https://api.github.com/repos/dsalahutdinov/dev.to/languages","stargazers_url":"https://api.github.com/repos/dsalahutdinov/dev.to/stargazers","contributors_url":"https://api.github.com/repos/dsalahutdinov/dev.to/contributors","subscribers_url":"https://api.github.com/repos/dsalahutdinov/dev.to/subscribers","subscription_url":"https://api.github.com/repos/dsalahutdinov/dev.to/subscription","commits_url":"https://api.github.com/repos/dsalahutdinov/dev.to/commits{/sha}","git_commits_url":"https://api.github.com/repos/dsalahutdinov/dev.to/git/commits{/sha}","comments_url":"https://api.github.com/repos/dsalahutdinov/dev.to/comments{/number}","issue_comment_url":"https://api.github.com/repos/dsalahutdinov/dev.to/issues/comments{/number}","contents_url":"https://api.github.com/repos/dsalahutdinov/dev.to/contents/{+path}","compare_url":"https://api.github.com/repos/dsalahutdinov/dev.to/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dsalahutdinov/dev.to/merges","archive_url":"https://api.github.com/repos/dsalahutdinov/dev.to/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dsalahutdinov/dev.to/downloads","issues_url":"https://api.github.com/repos/dsalahutdinov/dev.to/issues{/number}","pulls_url":"https://api.github.com/repos/dsalahutdinov/dev.to/pulls{/number}","milestones_url":"https://api.github.com/repos/dsalahutdinov/dev.to/milestones{/number}","notifications_url":"https://api.github.com/repos/dsalahutdinov/dev.to/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dsalahutdinov/dev.to/labels{/name}","releases_url":"https://api.github.com/repos/dsalahutdinov/dev.to/releases{/id}","deployments_url":"https://api.github.com/repos/dsalahutdinov/dev.to/deployments","created_at":"2018-11-15T14:59:58Z","updated_at":"2018-11-20T08:03:07Z","pushed_at":"2018-11-20T08:03:05Z","git_url":"git://github.com/dsalahutdinov/dev.to.git","ssh_url":"git@github.com:dsalahutdinov/dev.to.git","clone_url":"https://github.com/dsalahutdinov/dev.to.git","svn_url":"https://github.com/dsalahutdinov/dev.to","homepage":"https://dev.to","size":21676,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"thepracticaldev:master","ref":"master","sha":"4ab0a070ea7e661ad1947a082b152211589115a0","user":{"login":"thepracticaldev","id":13521919,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNTIxOTE5","avatar_url":"https://avatars1.githubusercontent.com/u/13521919?v=4","gravatar_id":"","url":"https://api.github.com/users/thepracticaldev","html_url":"https://github.com/thepracticaldev","followers_url":"https://api.github.com/users/thepracticaldev/followers","following_url":"https://api.github.com/users/thepracticaldev/following{/other_user}","gists_url":"https://api.github.com/users/thepracticaldev/gists{/gist_id}","starred_url":"https://api.github.com/users/thepracticaldev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thepracticaldev/subscriptions","organizations_url":"https://api.github.com/users/thepracticaldev/orgs","repos_url":"https://api.github.com/users/thepracticaldev/repos","events_url":"https://api.github.com/users/thepracticaldev/events{/privacy}","received_events_url":"https://api.github.com/users/thepracticaldev/received_events","type":"Organization","site_admin":false},"repo":{"id":73648678,"node_id":"MDEwOlJlcG9zaXRvcnk3MzY0ODY3OA==","name":"dev.to","full_name":"thepracticaldev/dev.to","private":false,"owner":{"login":"thepracticaldev","id":13521919,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNTIxOTE5","avatar_url":"https://avatars1.githubusercontent.com/u/13521919?v=4","gravatar_id":"","url":"https://api.github.com/users/thepracticaldev","html_url":"https://github.com/thepracticaldev","followers_url":"https://api.github.com/users/thepracticaldev/followers","following_url":"https://api.github.com/users/thepracticaldev/following{/other_user}","gists_url":"https://api.github.com/users/thepracticaldev/gists{/gist_id}","starred_url":"https://api.github.com/users/thepracticaldev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thepracticaldev/subscriptions","organizations_url":"https://api.github.com/users/thepracticaldev/orgs","repos_url":"https://api.github.com/users/thepracticaldev/repos","events_url":"https://api.github.com/users/thepracticaldev/events{/privacy}","received_events_url":"https://api.github.com/users/thepracticaldev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/thepracticaldev/dev.to","description":"Where programmers share ideas and help each other grow","fork":false,"url":"https://api.github.com/repos/thepracticaldev/dev.to","forks_url":"https://api.github.com/repos/thepracticaldev/dev.to/forks","keys_url":"https://api.github.com/repos/thepracticaldev/dev.to/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thepracticaldev/dev.to/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thepracticaldev/dev.to/teams","hooks_url":"https://api.github.com/repos/thepracticaldev/dev.to/hooks","issue_events_url":"https://api.github.com/repos/thepracticaldev/dev.to/issues/events{/number}","events_url":"https://api.github.com/repos/thepracticaldev/dev.to/events","assignees_url":"https://api.github.com/repos/thepracticaldev/dev.to/assignees{/user}","branches_url":"https://api.github.com/repos/thepracticaldev/dev.to/branches{/branch}","tags_url":"https://api.github.com/repos/thepracticaldev/dev.to/tags","blobs_url":"https://api.github.com/repos/thepracticaldev/dev.to/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thepracticaldev/dev.to/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thepracticaldev/dev.to/git/refs{/sha}","trees_url":"https://api.github.com/repos/thepracticaldev/dev.to/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thepracticaldev/dev.to/statuses/{sha}","languages_url":"https://api.github.com/repos/thepracticaldev/dev.to/languages","stargazers_url":"https://api.github.com/repos/thepracticaldev/dev.to/stargazers","contributors_url":"https://api.github.com/repos/thepracticaldev/dev.to/contributors","subscribers_url":"https://api.github.com/repos/thepracticaldev/dev.to/subscribers","subscription_url":"https://api.github.com/repos/thepracticaldev/dev.to/subscription","commits_url":"https://api.github.com/repos/thepracticaldev/dev.to/commits{/sha}","git_commits_url":"https://api.github.com/repos/thepracticaldev/dev.to/git/commits{/sha}","comments_url":"https://api.github.com/repos/thepracticaldev/dev.to/comments{/number}","issue_comment_url":"https://api.github.com/repos/thepracticaldev/dev.to/issues/comments{/number}","contents_url":"https://api.github.com/repos/thepracticaldev/dev.to/contents/{+path}","compare_url":"https://api.github.com/repos/thepracticaldev/dev.to/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thepracticaldev/dev.to/merges","archive_url":"https://api.github.com/repos/thepracticaldev/dev.to/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thepracticaldev/dev.to/downloads","issues_url":"https://api.github.com/repos/thepracticaldev/dev.to/issues{/number}","pulls_url":"https://api.github.com/repos/thepracticaldev/dev.to/pulls{/number}","milestones_url":"https://api.github.com/repos/thepracticaldev/dev.to/milestones{/number}","notifications_url":"https://api.github.com/repos/thepracticaldev/dev.to/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thepracticaldev/dev.to/labels{/name}","releases_url":"https://api.github.com/repos/thepracticaldev/dev.to/releases{/id}","deployments_url":"https://api.github.com/repos/thepracticaldev/dev.to/deployments","created_at":"2016-11-13T23:02:13Z","updated_at":"2018-11-20T09:02:23Z","pushed_at":"2018-11-20T08:03:07Z","git_url":"git://github.com/thepracticaldev/dev.to.git","ssh_url":"git@github.com:thepracticaldev/dev.to.git","clone_url":"https://github.com/thepracticaldev/dev.to.git","svn_url":"https://github.com/thepracticaldev/dev.to","homepage":"https://dev.to","size":21901,"stargazers_count":7507,"watchers_count":7507,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":727,"mirror_url":null,"archived":false,"open_issues_count":271,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":727,"open_issues":271,"watchers":7507,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thepracticaldev/dev.to/pulls/1125"},"html":{"href":"https://github.com/thepracticaldev/dev.to/pull/1125"},"issue":{"href":"https://api.github.com/repos/thepracticaldev/dev.to/issues/1125"},"comments":{"href":"https://api.github.com/repos/thepracticaldev/dev.to/issues/1125/comments"},"review_comments":{"href":"https://api.github.com/repos/thepracticaldev/dev.to/pulls/1125/comments"},"review_comment":{"href":"https://api.github.com/repos/thepracticaldev/dev.to/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thepracticaldev/dev.to/pulls/1125/commits"},"statuses":{"href":"https://api.github.com/repos/thepracticaldev/dev.to/statuses/64977edd45360e002bde0fbace48b8649842529d"}},"author_association":"NONE"}}
{"actor":{"display_login":"dsalahutdinov"}}