{"action":"created","comment":{"url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/comments/181559937","pull_request_review_id":112215591,"id":181559937,"diff_hunk":"@@ -183,6 +195,10 @@ export class NgbCarousel implements AfterContentChecked,\n     }\n   }\n \n+  showNavigation(): boolean { return !this.hideNavigation || (this.slides != null && this.slides.length > 1); }\n+\n+  showIndicator(): boolean { return !this.hideIndicator || (this.slides != null && this.slides.length > 1); }","path":"src/carousel/carousel.ts","position":55,"original_position":55,"commit_id":"edd6373a136cd71e8ffafb3b8eddae2bd7402900","original_commit_id":"edd6373a136cd71e8ffafb3b8eddae2bd7402900","user":{"login":"wilhelmhb","id":13120818,"avatar_url":"https://avatars1.githubusercontent.com/u/13120818?v=4","gravatar_id":"","url":"https://api.github.com/users/wilhelmhb","html_url":"https://github.com/wilhelmhb","followers_url":"https://api.github.com/users/wilhelmhb/followers","following_url":"https://api.github.com/users/wilhelmhb/following{/other_user}","gists_url":"https://api.github.com/users/wilhelmhb/gists{/gist_id}","starred_url":"https://api.github.com/users/wilhelmhb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilhelmhb/subscriptions","organizations_url":"https://api.github.com/users/wilhelmhb/orgs","repos_url":"https://api.github.com/users/wilhelmhb/repos","events_url":"https://api.github.com/users/wilhelmhb/events{/privacy}","received_events_url":"https://api.github.com/users/wilhelmhb/received_events","type":"User","site_admin":false},"body":"if we have more than one slide, we probably still want to display the navigation item, right ?\r\nOtherwise the user won't see that he/she can slide through the several slides.","created_at":"2018-04-14T18:35:00Z","updated_at":"2018-04-14T18:35:00Z","html_url":"https://github.com/ng-bootstrap/ng-bootstrap/pull/2275#discussion_r181559937","pull_request_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/2275","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/comments/181559937"},"html":{"href":"https://github.com/ng-bootstrap/ng-bootstrap/pull/2275#discussion_r181559937"},"pull_request":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/2275"}},"in_reply_to_id":181427136},"pull_request":{"url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/2275","id":178669644,"html_url":"https://github.com/ng-bootstrap/ng-bootstrap/pull/2275","diff_url":"https://github.com/ng-bootstrap/ng-bootstrap/pull/2275.diff","patch_url":"https://github.com/ng-bootstrap/ng-bootstrap/pull/2275.patch","issue_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/2275","number":2275,"state":"open","locked":false,"title":"feat(carousel): Allow to hide navigation items if only one slide","user":{"login":"wilhelmhb","id":13120818,"avatar_url":"https://avatars1.githubusercontent.com/u/13120818?v=4","gravatar_id":"","url":"https://api.github.com/users/wilhelmhb","html_url":"https://github.com/wilhelmhb","followers_url":"https://api.github.com/users/wilhelmhb/followers","following_url":"https://api.github.com/users/wilhelmhb/following{/other_user}","gists_url":"https://api.github.com/users/wilhelmhb/gists{/gist_id}","starred_url":"https://api.github.com/users/wilhelmhb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilhelmhb/subscriptions","organizations_url":"https://api.github.com/users/wilhelmhb/orgs","repos_url":"https://api.github.com/users/wilhelmhb/repos","events_url":"https://api.github.com/users/wilhelmhb/events{/privacy}","received_events_url":"https://api.github.com/users/wilhelmhb/received_events","type":"User","site_admin":false},"body":"Closes #2274 ","created_at":"2018-03-31T06:53:57Z","updated_at":"2018-04-14T18:35:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e55a4d6e98fa2b9f2e53fbb635ac6a660474213","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":260883024,"url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/labels/component:%20carousel","name":"component: carousel","color":"ffffff","default":false},{"id":260885102,"url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/labels/needs:%20work","name":"needs: work","color":"207de5","default":false},{"id":260885728,"url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/labels/type:%20feature","name":"type: feature","color":"84b6eb","default":false}],"milestone":{"url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/milestones/56","html_url":"https://github.com/ng-bootstrap/ng-bootstrap/milestone/56","labels_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/milestones/56/labels","id":3265775,"number":56,"title":"2.2.0","description":"","creator":{"login":"pkozlowski-opensource","id":973550,"avatar_url":"https://avatars3.githubusercontent.com/u/973550?v=4","gravatar_id":"","url":"https://api.github.com/users/pkozlowski-opensource","html_url":"https://github.com/pkozlowski-opensource","followers_url":"https://api.github.com/users/pkozlowski-opensource/followers","following_url":"https://api.github.com/users/pkozlowski-opensource/following{/other_user}","gists_url":"https://api.github.com/users/pkozlowski-opensource/gists{/gist_id}","starred_url":"https://api.github.com/users/pkozlowski-opensource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkozlowski-opensource/subscriptions","organizations_url":"https://api.github.com/users/pkozlowski-opensource/orgs","repos_url":"https://api.github.com/users/pkozlowski-opensource/repos","events_url":"https://api.github.com/users/pkozlowski-opensource/events{/privacy}","received_events_url":"https://api.github.com/users/pkozlowski-opensource/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":0,"state":"open","created_at":"2018-04-13T13:45:03Z","updated_at":"2018-04-13T15:37:32Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/2275/commits","review_comments_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/2275/comments","review_comment_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/2275/comments","statuses_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/statuses/edd6373a136cd71e8ffafb3b8eddae2bd7402900","head":{"label":"wilhelmhb:hide-navigation-carousel","ref":"hide-navigation-carousel","sha":"edd6373a136cd71e8ffafb3b8eddae2bd7402900","user":{"login":"wilhelmhb","id":13120818,"avatar_url":"https://avatars1.githubusercontent.com/u/13120818?v=4","gravatar_id":"","url":"https://api.github.com/users/wilhelmhb","html_url":"https://github.com/wilhelmhb","followers_url":"https://api.github.com/users/wilhelmhb/followers","following_url":"https://api.github.com/users/wilhelmhb/following{/other_user}","gists_url":"https://api.github.com/users/wilhelmhb/gists{/gist_id}","starred_url":"https://api.github.com/users/wilhelmhb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilhelmhb/subscriptions","organizations_url":"https://api.github.com/users/wilhelmhb/orgs","repos_url":"https://api.github.com/users/wilhelmhb/repos","events_url":"https://api.github.com/users/wilhelmhb/events{/privacy}","received_events_url":"https://api.github.com/users/wilhelmhb/received_events","type":"User","site_admin":false},"repo":{"id":127505186,"name":"ng-bootstrap","full_name":"wilhelmhb/ng-bootstrap","owner":{"login":"wilhelmhb","id":13120818,"avatar_url":"https://avatars1.githubusercontent.com/u/13120818?v=4","gravatar_id":"","url":"https://api.github.com/users/wilhelmhb","html_url":"https://github.com/wilhelmhb","followers_url":"https://api.github.com/users/wilhelmhb/followers","following_url":"https://api.github.com/users/wilhelmhb/following{/other_user}","gists_url":"https://api.github.com/users/wilhelmhb/gists{/gist_id}","starred_url":"https://api.github.com/users/wilhelmhb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilhelmhb/subscriptions","organizations_url":"https://api.github.com/users/wilhelmhb/orgs","repos_url":"https://api.github.com/users/wilhelmhb/repos","events_url":"https://api.github.com/users/wilhelmhb/events{/privacy}","received_events_url":"https://api.github.com/users/wilhelmhb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wilhelmhb/ng-bootstrap","description":"Angular powered Bootstrap","fork":true,"url":"https://api.github.com/repos/wilhelmhb/ng-bootstrap","forks_url":"https://api.github.com/repos/wilhelmhb/ng-bootstrap/forks","keys_url":"https://api.github.com/repos/wilhelmhb/ng-bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wilhelmhb/ng-bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wilhelmhb/ng-bootstrap/teams","hooks_url":"https://api.github.com/repos/wilhelmhb/ng-bootstrap/hooks","issue_events_url":"https://api.github.com/repos/wilhelmhb/ng-bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/wilhelmhb/ng-bootstrap/events","assignees_url":"https://api.github.com/repos/wilhelmhb/ng-bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/wilhelmhb/ng-bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/wilhelmhb/ng-bootstrap/tags","blobs_url":"https://api.github.com/repos/wilhelmhb/ng-bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wilhelmhb/ng-bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wilhelmhb/ng-bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/wilhelmhb/ng-bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wilhelmhb/ng-bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/wilhelmhb/ng-bootstrap/languages","stargazers_url":"https://api.github.com/repos/wilhelmhb/ng-bootstrap/stargazers","contributors_url":"https://api.github.com/repos/wilhelmhb/ng-bootstrap/contributors","subscribers_url":"https://api.github.com/repos/wilhelmhb/ng-bootstrap/subscribers","subscription_url":"https://api.github.com/repos/wilhelmhb/ng-bootstrap/subscription","commits_url":"https://api.github.com/repos/wilhelmhb/ng-bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/wilhelmhb/ng-bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/wilhelmhb/ng-bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/wilhelmhb/ng-bootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/wilhelmhb/ng-bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/wilhelmhb/ng-bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wilhelmhb/ng-bootstrap/merges","archive_url":"https://api.github.com/repos/wilhelmhb/ng-bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wilhelmhb/ng-bootstrap/downloads","issues_url":"https://api.github.com/repos/wilhelmhb/ng-bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/wilhelmhb/ng-bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/wilhelmhb/ng-bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/wilhelmhb/ng-bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wilhelmhb/ng-bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/wilhelmhb/ng-bootstrap/releases{/id}","deployments_url":"https://api.github.com/repos/wilhelmhb/ng-bootstrap/deployments","created_at":"2018-03-31T06:21:50Z","updated_at":"2018-03-31T06:21:52Z","pushed_at":"2018-03-31T06:52:50Z","git_url":"git://github.com/wilhelmhb/ng-bootstrap.git","ssh_url":"git@github.com:wilhelmhb/ng-bootstrap.git","clone_url":"https://github.com/wilhelmhb/ng-bootstrap.git","svn_url":"https://github.com/wilhelmhb/ng-bootstrap","homepage":"https://ng-bootstrap.github.io","size":1987,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ng-bootstrap:master","ref":"master","sha":"e79a5d6131a750239144a639fb08268f6f086c39","user":{"login":"ng-bootstrap","id":14283866,"avatar_url":"https://avatars1.githubusercontent.com/u/14283866?v=4","gravatar_id":"","url":"https://api.github.com/users/ng-bootstrap","html_url":"https://github.com/ng-bootstrap","followers_url":"https://api.github.com/users/ng-bootstrap/followers","following_url":"https://api.github.com/users/ng-bootstrap/following{/other_user}","gists_url":"https://api.github.com/users/ng-bootstrap/gists{/gist_id}","starred_url":"https://api.github.com/users/ng-bootstrap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ng-bootstrap/subscriptions","organizations_url":"https://api.github.com/users/ng-bootstrap/orgs","repos_url":"https://api.github.com/users/ng-bootstrap/repos","events_url":"https://api.github.com/users/ng-bootstrap/events{/privacy}","received_events_url":"https://api.github.com/users/ng-bootstrap/received_events","type":"Organization","site_admin":false},"repo":{"id":42481664,"name":"ng-bootstrap","full_name":"ng-bootstrap/ng-bootstrap","owner":{"login":"ng-bootstrap","id":14283866,"avatar_url":"https://avatars1.githubusercontent.com/u/14283866?v=4","gravatar_id":"","url":"https://api.github.com/users/ng-bootstrap","html_url":"https://github.com/ng-bootstrap","followers_url":"https://api.github.com/users/ng-bootstrap/followers","following_url":"https://api.github.com/users/ng-bootstrap/following{/other_user}","gists_url":"https://api.github.com/users/ng-bootstrap/gists{/gist_id}","starred_url":"https://api.github.com/users/ng-bootstrap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ng-bootstrap/subscriptions","organizations_url":"https://api.github.com/users/ng-bootstrap/orgs","repos_url":"https://api.github.com/users/ng-bootstrap/repos","events_url":"https://api.github.com/users/ng-bootstrap/events{/privacy}","received_events_url":"https://api.github.com/users/ng-bootstrap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ng-bootstrap/ng-bootstrap","description":"Angular powered Bootstrap","fork":false,"url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap","forks_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/forks","keys_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/teams","hooks_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/hooks","issue_events_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/events","assignees_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/tags","blobs_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/languages","stargazers_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/stargazers","contributors_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/contributors","subscribers_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/subscribers","subscription_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/subscription","commits_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/merges","archive_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/downloads","issues_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/releases{/id}","deployments_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/deployments","created_at":"2015-09-14T22:55:53Z","updated_at":"2018-04-14T11:05:18Z","pushed_at":"2018-04-13T17:16:47Z","git_url":"git://github.com/ng-bootstrap/ng-bootstrap.git","ssh_url":"git@github.com:ng-bootstrap/ng-bootstrap.git","clone_url":"https://github.com/ng-bootstrap/ng-bootstrap.git","svn_url":"https://github.com/ng-bootstrap/ng-bootstrap","homepage":"https://ng-bootstrap.github.io","size":2303,"stargazers_count":5196,"watchers_count":5196,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":838,"mirror_url":null,"archived":false,"open_issues_count":185,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":838,"open_issues":185,"watchers":5196,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/2275"},"html":{"href":"https://github.com/ng-bootstrap/ng-bootstrap/pull/2275"},"issue":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/2275"},"comments":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/2275/comments"},"review_comments":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/2275/comments"},"review_comment":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/2275/commits"},"statuses":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/statuses/edd6373a136cd71e8ffafb3b8eddae2bd7402900"}},"author_association":"NONE"}}
{"actor":{"display_login":"wilhelmhb"}}