{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/pulls/comments/167002157","pull_request_review_id":95154145,"id":167002157,"diff_hunk":"@@ -11,9 +11,9 @@ The asynchronous `Sink` trait for the futures-rs library.\n \"\"\"\n \n [features]\n-std = [\"futures-core/std\"]\n+std = [\"futures-core/std\", \"futures-channel/std\"]","path":"futures-sink/Cargo.toml","position":5,"original_position":5,"commit_id":"21d8fdb4a6f98a76b5c7ad9a12a5b1cc95e3fd82","original_commit_id":"21d8fdb4a6f98a76b5c7ad9a12a5b1cc95e3fd82","user":{"login":"cramertj","id":5963049,"avatar_url":"https://avatars1.githubusercontent.com/u/5963049?v=4","gravatar_id":"","url":"https://api.github.com/users/cramertj","html_url":"https://github.com/cramertj","followers_url":"https://api.github.com/users/cramertj/followers","following_url":"https://api.github.com/users/cramertj/following{/other_user}","gists_url":"https://api.github.com/users/cramertj/gists{/gist_id}","starred_url":"https://api.github.com/users/cramertj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cramertj/subscriptions","organizations_url":"https://api.github.com/users/cramertj/orgs","repos_url":"https://api.github.com/users/cramertj/repos","events_url":"https://api.github.com/users/cramertj/events{/privacy}","received_events_url":"https://api.github.com/users/cramertj/received_events","type":"User","site_admin":false},"body":"Ditto question about `futures-channel/std`-- this crate currently doesn't have any non-std behavior. What should we do here?","created_at":"2018-02-08T17:04:05Z","updated_at":"2018-02-08T17:04:05Z","html_url":"https://github.com/rust-lang-nursery/futures-rs/pull/739#discussion_r167002157","pull_request_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/pulls/739","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/rust-lang-nursery/futures-rs/pulls/comments/167002157"},"html":{"href":"https://github.com/rust-lang-nursery/futures-rs/pull/739#discussion_r167002157"},"pull_request":{"href":"https://api.github.com/repos/rust-lang-nursery/futures-rs/pulls/739"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/pulls/739","id":168024621,"html_url":"https://github.com/rust-lang-nursery/futures-rs/pull/739","diff_url":"https://github.com/rust-lang-nursery/futures-rs/pull/739.diff","patch_url":"https://github.com/rust-lang-nursery/futures-rs/pull/739.patch","issue_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/issues/739","number":739,"state":"open","locked":false,"title":"Fill out `futures-executor`, fix some tests","user":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars1.githubusercontent.com/u/64996?v=4","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"body":"This implements the `Enter` type in the `futures-executor` crate and starts migrating and fixing a lot of tests. Not all tests are working just yet though!","created_at":"2018-02-08T16:40:34Z","updated_at":"2018-02-08T17:04:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4190a8ecb6671371610e238672b18b97bd25ca5c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/pulls/739/commits","review_comments_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/pulls/739/comments","review_comment_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/issues/739/comments","statuses_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/statuses/21d8fdb4a6f98a76b5c7ad9a12a5b1cc95e3fd82","head":{"label":"rust-lang-nursery:more-tests","ref":"more-tests","sha":"21d8fdb4a6f98a76b5c7ad9a12a5b1cc95e3fd82","user":{"login":"rust-lang-nursery","id":14631425,"avatar_url":"https://avatars1.githubusercontent.com/u/14631425?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang-nursery","html_url":"https://github.com/rust-lang-nursery","followers_url":"https://api.github.com/users/rust-lang-nursery/followers","following_url":"https://api.github.com/users/rust-lang-nursery/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang-nursery/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang-nursery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang-nursery/subscriptions","organizations_url":"https://api.github.com/users/rust-lang-nursery/orgs","repos_url":"https://api.github.com/users/rust-lang-nursery/repos","events_url":"https://api.github.com/users/rust-lang-nursery/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang-nursery/received_events","type":"Organization","site_admin":false},"repo":{"id":55077261,"name":"futures-rs","full_name":"rust-lang-nursery/futures-rs","owner":{"login":"rust-lang-nursery","id":14631425,"avatar_url":"https://avatars1.githubusercontent.com/u/14631425?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang-nursery","html_url":"https://github.com/rust-lang-nursery","followers_url":"https://api.github.com/users/rust-lang-nursery/followers","following_url":"https://api.github.com/users/rust-lang-nursery/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang-nursery/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang-nursery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang-nursery/subscriptions","organizations_url":"https://api.github.com/users/rust-lang-nursery/orgs","repos_url":"https://api.github.com/users/rust-lang-nursery/repos","events_url":"https://api.github.com/users/rust-lang-nursery/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang-nursery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang-nursery/futures-rs","description":"Zero-cost futures and streams in Rust","fork":false,"url":"https://api.github.com/repos/rust-lang-nursery/futures-rs","forks_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/forks","keys_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/teams","hooks_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/hooks","issue_events_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/events","assignees_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/tags","blobs_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/languages","stargazers_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/stargazers","contributors_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/contributors","subscribers_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/subscribers","subscription_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/subscription","commits_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/merges","archive_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/downloads","issues_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/deployments","created_at":"2016-03-30T16:03:08Z","updated_at":"2018-02-08T11:43:32Z","pushed_at":"2018-02-08T16:40:35Z","git_url":"git://github.com/rust-lang-nursery/futures-rs.git","ssh_url":"git@github.com:rust-lang-nursery/futures-rs.git","clone_url":"https://github.com/rust-lang-nursery/futures-rs.git","svn_url":"https://github.com/rust-lang-nursery/futures-rs","homepage":"https://docs.rs/futures","size":4148,"stargazers_count":1828,"watchers_count":1828,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":203,"mirror_url":null,"archived":false,"open_issues_count":87,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":203,"open_issues":87,"watchers":1828,"default_branch":"master"}},"base":{"label":"rust-lang-nursery:0.2","ref":"0.2","sha":"883ee60c10a310ce6f6b9904f3cfaa20bcc84f34","user":{"login":"rust-lang-nursery","id":14631425,"avatar_url":"https://avatars1.githubusercontent.com/u/14631425?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang-nursery","html_url":"https://github.com/rust-lang-nursery","followers_url":"https://api.github.com/users/rust-lang-nursery/followers","following_url":"https://api.github.com/users/rust-lang-nursery/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang-nursery/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang-nursery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang-nursery/subscriptions","organizations_url":"https://api.github.com/users/rust-lang-nursery/orgs","repos_url":"https://api.github.com/users/rust-lang-nursery/repos","events_url":"https://api.github.com/users/rust-lang-nursery/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang-nursery/received_events","type":"Organization","site_admin":false},"repo":{"id":55077261,"name":"futures-rs","full_name":"rust-lang-nursery/futures-rs","owner":{"login":"rust-lang-nursery","id":14631425,"avatar_url":"https://avatars1.githubusercontent.com/u/14631425?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang-nursery","html_url":"https://github.com/rust-lang-nursery","followers_url":"https://api.github.com/users/rust-lang-nursery/followers","following_url":"https://api.github.com/users/rust-lang-nursery/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang-nursery/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang-nursery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang-nursery/subscriptions","organizations_url":"https://api.github.com/users/rust-lang-nursery/orgs","repos_url":"https://api.github.com/users/rust-lang-nursery/repos","events_url":"https://api.github.com/users/rust-lang-nursery/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang-nursery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang-nursery/futures-rs","description":"Zero-cost futures and streams in Rust","fork":false,"url":"https://api.github.com/repos/rust-lang-nursery/futures-rs","forks_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/forks","keys_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/teams","hooks_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/hooks","issue_events_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/events","assignees_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/tags","blobs_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/languages","stargazers_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/stargazers","contributors_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/contributors","subscribers_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/subscribers","subscription_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/subscription","commits_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/merges","archive_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/downloads","issues_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/deployments","created_at":"2016-03-30T16:03:08Z","updated_at":"2018-02-08T11:43:32Z","pushed_at":"2018-02-08T16:40:35Z","git_url":"git://github.com/rust-lang-nursery/futures-rs.git","ssh_url":"git@github.com:rust-lang-nursery/futures-rs.git","clone_url":"https://github.com/rust-lang-nursery/futures-rs.git","svn_url":"https://github.com/rust-lang-nursery/futures-rs","homepage":"https://docs.rs/futures","size":4148,"stargazers_count":1828,"watchers_count":1828,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":203,"mirror_url":null,"archived":false,"open_issues_count":87,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":203,"open_issues":87,"watchers":1828,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang-nursery/futures-rs/pulls/739"},"html":{"href":"https://github.com/rust-lang-nursery/futures-rs/pull/739"},"issue":{"href":"https://api.github.com/repos/rust-lang-nursery/futures-rs/issues/739"},"comments":{"href":"https://api.github.com/repos/rust-lang-nursery/futures-rs/issues/739/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang-nursery/futures-rs/pulls/739/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang-nursery/futures-rs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang-nursery/futures-rs/pulls/739/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang-nursery/futures-rs/statuses/21d8fdb4a6f98a76b5c7ad9a12a5b1cc95e3fd82"}},"author_association":"OWNER"}}
{"actor":{"display_login":"cramertj"}}