{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/20928","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20928/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20928/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20928/events","html_url":"https://github.com/joomla/joomla-cms/issues/20928","id":336900515,"node_id":"MDU6SXNzdWUzMzY5MDA1MTU=","number":20928,"title":"[4.0] Namespacing ??","user":{"login":"brianteeman","id":1296369,"node_id":"MDQ6VXNlcjEyOTYzNjk=","avatar_url":"https://avatars3.githubusercontent.com/u/1296369?v=4","gravatar_id":"","url":"https://api.github.com/users/brianteeman","html_url":"https://github.com/brianteeman","followers_url":"https://api.github.com/users/brianteeman/followers","following_url":"https://api.github.com/users/brianteeman/following{/other_user}","gists_url":"https://api.github.com/users/brianteeman/gists{/gist_id}","starred_url":"https://api.github.com/users/brianteeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianteeman/subscriptions","organizations_url":"https://api.github.com/users/brianteeman/orgs","repos_url":"https://api.github.com/users/brianteeman/repos","events_url":"https://api.github.com/users/brianteeman/events{/privacy}","received_events_url":"https://api.github.com/users/brianteeman/received_events","type":"User","site_admin":false},"labels":[{"id":138443932,"node_id":"MDU6TGFiZWwxMzg0NDM5MzI=","url":"https://api.github.com/repos/joomla/joomla-cms/labels/No%20Code%20Attached%20Yet","name":"No Code Attached Yet","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-29T07:56:25Z","updated_at":"2018-06-29T08:02:12Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"I am starting to complete the namespacing of the admin components in J4 but I am only a trained monkey\r\n\r\nI can see some existing namespacing that looks like this\r\n\r\n```\r\nuse Joomla\\CMS\\Help\\Help as JHelp;\r\n\r\n\t$this->page = JHelp::createUrl(\\JFactory::getApplication()->input->get('page', 'JHELP_START_HERE'));\r\n\r\n```\r\n\r\nIs that just \"lazy\" coding to avoid having to rename every instance in the file of JHelp\r\n\r\nIs it not more correct to be changed to \r\n\r\n```\r\nuse Joomla\\CMS\\Help\\Help;\r\n\r\n\t$this->page = JHelp::createUrl(\\JFactory::getApplication()->input->get('page', 'JHELP_START_HERE'));\r\n\r\n```\r\n\r\n@laoneo @wilsonge "},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/401280098","html_url":"https://github.com/joomla/joomla-cms/issues/20928#issuecomment-401280098","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20928","id":401280098,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTI4MDA5OA==","user":{"login":"Bakual","id":1018684,"node_id":"MDQ6VXNlcjEwMTg2ODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1018684?v=4","gravatar_id":"","url":"https://api.github.com/users/Bakual","html_url":"https://github.com/Bakual","followers_url":"https://api.github.com/users/Bakual/followers","following_url":"https://api.github.com/users/Bakual/following{/other_user}","gists_url":"https://api.github.com/users/Bakual/gists{/gist_id}","starred_url":"https://api.github.com/users/Bakual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bakual/subscriptions","organizations_url":"https://api.github.com/users/Bakual/orgs","repos_url":"https://api.github.com/users/Bakual/repos","events_url":"https://api.github.com/users/Bakual/events{/privacy}","received_events_url":"https://api.github.com/users/Bakual/received_events","type":"User","site_admin":false},"created_at":"2018-06-29T08:02:12Z","updated_at":"2018-06-29T08:02:12Z","author_association":"CONTRIBUTOR","body":"Yes, first one is \"lazy\", but it's valid as well.\r\nIn the second case, you would have to change `JHelp` in the code to `Help`. So ` JHelp::createUrl` becomes ` Help::createUrl`"}}
{"actor":{"display_login":"Bakual"}}