{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/33241","repository_url":"https://api.github.com/repos/elastic/elasticsearch","labels_url":"https://api.github.com/repos/elastic/elasticsearch/issues/33241/labels{/name}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/33241/comments","events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/33241/events","html_url":"https://github.com/elastic/elasticsearch/pull/33241","id":355202337,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNzg1NTA5","number":33241,"title":"Move file-based discovery to core","user":{"login":"DaveCTurner","id":5058284,"node_id":"MDQ6VXNlcjUwNTgyODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5058284?v=4","gravatar_id":"","url":"https://api.github.com/users/DaveCTurner","html_url":"https://github.com/DaveCTurner","followers_url":"https://api.github.com/users/DaveCTurner/followers","following_url":"https://api.github.com/users/DaveCTurner/following{/other_user}","gists_url":"https://api.github.com/users/DaveCTurner/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveCTurner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveCTurner/subscriptions","organizations_url":"https://api.github.com/users/DaveCTurner/orgs","repos_url":"https://api.github.com/users/DaveCTurner/repos","events_url":"https://api.github.com/users/DaveCTurner/events{/privacy}","received_events_url":"https://api.github.com/users/DaveCTurner/received_events","type":"User","site_admin":false},"labels":[{"id":160579278,"node_id":"MDU6TGFiZWwxNjA1NzkyNzg=","url":"https://api.github.com/repos/elastic/elasticsearch/labels/:Distributed/Discovery-Plugins","name":":Distributed/Discovery-Plugins","color":"0e8a16","default":false},{"id":416200220,"node_id":"MDU6TGFiZWw0MTYyMDAyMjA=","url":"https://api.github.com/repos/elastic/elasticsearch/labels/%3Ebreaking-java","name":">breaking-java","color":"d93f0b","default":false},{"id":60445228,"node_id":"MDU6TGFiZWw2MDQ0NTIyOA==","url":"https://api.github.com/repos/elastic/elasticsearch/labels/%3Etest","name":">test","color":"5319e7","default":false},{"id":962378555,"node_id":"MDU6TGFiZWw5NjIzNzg1NTU=","url":"https://api.github.com/repos/elastic/elasticsearch/labels/v6.5.0","name":"v6.5.0","color":"Dddddd","default":false},{"id":484855464,"node_id":"MDU6TGFiZWw0ODQ4NTU0NjQ=","url":"https://api.github.com/repos/elastic/elasticsearch/labels/v7.0.0","name":"v7.0.0","color":"dddddd","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-29T14:59:28Z","updated_at":"2018-08-30T04:28:46Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/33241","html_url":"https://github.com/elastic/elasticsearch/pull/33241","diff_url":"https://github.com/elastic/elasticsearch/pull/33241.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/33241.patch"},"body":"Today we support a static list of seed hosts in core Elasticsearch, and allow a\r\ndynamic list of seed hosts to be provided via a file using the `discovery-file`\r\nplugin. In fact the ability to provide a dynamic list of seed hosts is\r\nincreasingly important in containerized environments, so this change moves this\r\nfunctionality to core Elasticsearch to avoid the need for a plugin.\r\n\r\nFor BWC purposes the plugin still exists, but does nothing more than issue a\r\nwarning when it is used. A followup PR will introduce the breaking change of\r\nits removal.\r\n\r\nFurthermore, in order to start up nodes in integration tests we currently\r\nassign a known port to each node before startup, which unfortunately sometimes\r\nfails if another process grabs the selected port in the meantime. By moving the\r\n`discovery-file` functionality into the core product we can use it to avoid\r\nthis race.\r\n\r\nRelates #29244\r\nCloses #33030"},"comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments/417186229","html_url":"https://github.com/elastic/elasticsearch/pull/33241#issuecomment-417186229","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/33241","id":417186229,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzE4NjIyOQ==","user":{"login":"jasontedor","id":4744941,"node_id":"MDQ6VXNlcjQ3NDQ5NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/4744941?v=4","gravatar_id":"","url":"https://api.github.com/users/jasontedor","html_url":"https://github.com/jasontedor","followers_url":"https://api.github.com/users/jasontedor/followers","following_url":"https://api.github.com/users/jasontedor/following{/other_user}","gists_url":"https://api.github.com/users/jasontedor/gists{/gist_id}","starred_url":"https://api.github.com/users/jasontedor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasontedor/subscriptions","organizations_url":"https://api.github.com/users/jasontedor/orgs","repos_url":"https://api.github.com/users/jasontedor/repos","events_url":"https://api.github.com/users/jasontedor/events{/privacy}","received_events_url":"https://api.github.com/users/jasontedor/received_events","type":"User","site_admin":false},"created_at":"2018-08-30T04:28:46Z","updated_at":"2018-08-30T04:28:46Z","author_association":"MEMBER","body":"Two comments:\r\n - I think we should add an entry to the migration guide on the backport (saying it is deprecated), and in master (saying it's removed); those can be separate\r\n - I think the label on this PR should be `>breaking` and not `>breaking-java`"}}
{"actor":{"display_login":"jasontedor"}}