{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaArrays/BlockArrays.jl/issues/51","repository_url":"https://api.github.com/repos/JuliaArrays/BlockArrays.jl","labels_url":"https://api.github.com/repos/JuliaArrays/BlockArrays.jl/issues/51/labels{/name}","comments_url":"https://api.github.com/repos/JuliaArrays/BlockArrays.jl/issues/51/comments","events_url":"https://api.github.com/repos/JuliaArrays/BlockArrays.jl/issues/51/events","html_url":"https://github.com/JuliaArrays/BlockArrays.jl/pull/51","id":334642646,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NTY0NDMx","number":51,"title":"fix inlining expression usage in generated functions","user":{"login":"rdeits","id":591886,"node_id":"MDQ6VXNlcjU5MTg4Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/591886?v=4","gravatar_id":"","url":"https://api.github.com/users/rdeits","html_url":"https://github.com/rdeits","followers_url":"https://api.github.com/users/rdeits/followers","following_url":"https://api.github.com/users/rdeits/following{/other_user}","gists_url":"https://api.github.com/users/rdeits/gists{/gist_id}","starred_url":"https://api.github.com/users/rdeits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdeits/subscriptions","organizations_url":"https://api.github.com/users/rdeits/orgs","repos_url":"https://api.github.com/users/rdeits/repos","events_url":"https://api.github.com/users/rdeits/events{/privacy}","received_events_url":"https://api.github.com/users/rdeits/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-21T20:20:37Z","updated_at":"2018-06-21T20:25:36Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/JuliaArrays/BlockArrays.jl/pulls/51","html_url":"https://github.com/JuliaArrays/BlockArrays.jl/pull/51","diff_url":"https://github.com/JuliaArrays/BlockArrays.jl/pull/51.diff","patch_url":"https://github.com/JuliaArrays/BlockArrays.jl/pull/51.patch"},"body":"See https://github.com/JuliaMatrices/BlockBandedMatrices.jl/issues/10#issuecomment-399229062\r\n\r\nAll of the `$Expr(:meta, :inline)` lines are doing the wrong thing currently: they're interpolating *just* the `Expr` symbol, not the entire expression, which actually results in trying to construct a new `Expr` at run-time inside each generated function body. Fixing this brings things like `global2blockindex` down to 0 memory allocation and improves performance substantially. "},"comment":{"url":"https://api.github.com/repos/JuliaArrays/BlockArrays.jl/issues/comments/399231466","html_url":"https://github.com/JuliaArrays/BlockArrays.jl/pull/51#issuecomment-399231466","issue_url":"https://api.github.com/repos/JuliaArrays/BlockArrays.jl/issues/51","id":399231466,"node_id":"MDEyOklzc3VlQ29tbWVudDM5OTIzMTQ2Ng==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-06-21T20:25:36Z","updated_at":"2018-06-21T20:25:36Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/JuliaArrays/BlockArrays.jl/pull/51?src=pr&el=h1) Report\n> Merging [#51](https://codecov.io/gh/JuliaArrays/BlockArrays.jl/pull/51?src=pr&el=desc) into [master](https://codecov.io/gh/JuliaArrays/BlockArrays.jl/commit/d5710bb15357b26c942df8c983a8f14992a8d922?src=pr&el=desc) will **decrease** coverage by `0.2%`.\n> The diff coverage is `25%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/JuliaArrays/BlockArrays.jl/pull/51/graphs/tree.svg?width=650&src=pr&token=Pl1AnoV9xh&height=150)](https://codecov.io/gh/JuliaArrays/BlockArrays.jl/pull/51?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master      #51      +/-   ##\n==========================================\n- Coverage   83.29%   83.09%   -0.21%     \n==========================================\n  Files          10       10              \n  Lines         485      485              \n==========================================\n- Hits          404      403       -1     \n- Misses         81       82       +1\n```\n\n\n| [Impacted Files](https://codecov.io/gh/JuliaArrays/BlockArrays.jl/pull/51?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/blocksizes.jl](https://codecov.io/gh/JuliaArrays/BlockArrays.jl/pull/51/diff?src=pr&el=tree#diff-c3JjL2Jsb2Nrc2l6ZXMuamw=) | `85.71% <0%> (ø)` | :arrow_up: |\n| [src/blockindices.jl](https://codecov.io/gh/JuliaArrays/BlockArrays.jl/pull/51/diff?src=pr&el=tree#diff-c3JjL2Jsb2NraW5kaWNlcy5qbA==) | `60% <33.33%> (ø)` | :arrow_up: |\n| [src/show.jl](https://codecov.io/gh/JuliaArrays/BlockArrays.jl/pull/51/diff?src=pr&el=tree#diff-c3JjL3Nob3cuamw=) | `73.75% <0%> (-1.25%)` | :arrow_down: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/JuliaArrays/BlockArrays.jl/pull/51?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/JuliaArrays/BlockArrays.jl/pull/51?src=pr&el=footer). Last update [d5710bb...925c304](https://codecov.io/gh/JuliaArrays/BlockArrays.jl/pull/51?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}