{"action":"closed","number":414,"pull_request":{"url":"https://api.github.com/repos/circonus-labs/libmtev/pulls/414","id":201738480,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNzM4NDgw","html_url":"https://github.com/circonus-labs/libmtev/pull/414","diff_url":"https://github.com/circonus-labs/libmtev/pull/414.diff","patch_url":"https://github.com/circonus-labs/libmtev/pull/414.patch","issue_url":"https://api.github.com/repos/circonus-labs/libmtev/issues/414","number":414,"state":"closed","locked":false,"title":"Lua mtev.shared_seq","user":{"login":"HeinrichHartmann","id":2446981,"node_id":"MDQ6VXNlcjI0NDY5ODE=","avatar_url":"https://avatars1.githubusercontent.com/u/2446981?v=4","gravatar_id":"","url":"https://api.github.com/users/HeinrichHartmann","html_url":"https://github.com/HeinrichHartmann","followers_url":"https://api.github.com/users/HeinrichHartmann/followers","following_url":"https://api.github.com/users/HeinrichHartmann/following{/other_user}","gists_url":"https://api.github.com/users/HeinrichHartmann/gists{/gist_id}","starred_url":"https://api.github.com/users/HeinrichHartmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HeinrichHartmann/subscriptions","organizations_url":"https://api.github.com/users/HeinrichHartmann/orgs","repos_url":"https://api.github.com/users/HeinrichHartmann/repos","events_url":"https://api.github.com/users/HeinrichHartmann/events{/privacy}","received_events_url":"https://api.github.com/users/HeinrichHartmann/received_events","type":"User","site_admin":false},"body":"There are situations where we want to have access to an sequence number in lua that is increasing across all lua states and co-routines. E.g. to generate monotonic requests ids.\r\n\r\nThe given implementation is fast and straight forward.\r\n\r\nIt has the downside, that there is only one single SEQ in a single process / applications. So if you have two libs that make use of sequences they would see each other's incs. \r\nThis is fine for situations where only monotony is required not single stepping.\r\nAlso, I don't see a way around this that does not sacrifice simplicity and performance by introducing locks.","created_at":"2018-07-16T19:37:08Z","updated_at":"2018-07-17T18:40:14Z","closed_at":"2018-07-17T18:40:14Z","merged_at":"2018-07-17T18:40:14Z","merge_commit_sha":"4687663e24106a8cf87e920d8377cc5efe8bd2a5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/circonus-labs/libmtev/pulls/414/commits","review_comments_url":"https://api.github.com/repos/circonus-labs/libmtev/pulls/414/comments","review_comment_url":"https://api.github.com/repos/circonus-labs/libmtev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/circonus-labs/libmtev/issues/414/comments","statuses_url":"https://api.github.com/repos/circonus-labs/libmtev/statuses/3c72848a12df34e33796faa4c7c8760f6c26b283","head":{"label":"circonus-labs:lua-shared_seq","ref":"lua-shared_seq","sha":"3c72848a12df34e33796faa4c7c8760f6c26b283","user":{"login":"circonus-labs","id":2091329,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwOTEzMjk=","avatar_url":"https://avatars0.githubusercontent.com/u/2091329?v=4","gravatar_id":"","url":"https://api.github.com/users/circonus-labs","html_url":"https://github.com/circonus-labs","followers_url":"https://api.github.com/users/circonus-labs/followers","following_url":"https://api.github.com/users/circonus-labs/following{/other_user}","gists_url":"https://api.github.com/users/circonus-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/circonus-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/circonus-labs/subscriptions","organizations_url":"https://api.github.com/users/circonus-labs/orgs","repos_url":"https://api.github.com/users/circonus-labs/repos","events_url":"https://api.github.com/users/circonus-labs/events{/privacy}","received_events_url":"https://api.github.com/users/circonus-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":31102547,"node_id":"MDEwOlJlcG9zaXRvcnkzMTEwMjU0Nw==","name":"libmtev","full_name":"circonus-labs/libmtev","owner":{"login":"circonus-labs","id":2091329,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwOTEzMjk=","avatar_url":"https://avatars0.githubusercontent.com/u/2091329?v=4","gravatar_id":"","url":"https://api.github.com/users/circonus-labs","html_url":"https://github.com/circonus-labs","followers_url":"https://api.github.com/users/circonus-labs/followers","following_url":"https://api.github.com/users/circonus-labs/following{/other_user}","gists_url":"https://api.github.com/users/circonus-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/circonus-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/circonus-labs/subscriptions","organizations_url":"https://api.github.com/users/circonus-labs/orgs","repos_url":"https://api.github.com/users/circonus-labs/repos","events_url":"https://api.github.com/users/circonus-labs/events{/privacy}","received_events_url":"https://api.github.com/users/circonus-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/circonus-labs/libmtev","description":"Mount Everest Application Framework","fork":false,"url":"https://api.github.com/repos/circonus-labs/libmtev","forks_url":"https://api.github.com/repos/circonus-labs/libmtev/forks","keys_url":"https://api.github.com/repos/circonus-labs/libmtev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/circonus-labs/libmtev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/circonus-labs/libmtev/teams","hooks_url":"https://api.github.com/repos/circonus-labs/libmtev/hooks","issue_events_url":"https://api.github.com/repos/circonus-labs/libmtev/issues/events{/number}","events_url":"https://api.github.com/repos/circonus-labs/libmtev/events","assignees_url":"https://api.github.com/repos/circonus-labs/libmtev/assignees{/user}","branches_url":"https://api.github.com/repos/circonus-labs/libmtev/branches{/branch}","tags_url":"https://api.github.com/repos/circonus-labs/libmtev/tags","blobs_url":"https://api.github.com/repos/circonus-labs/libmtev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/circonus-labs/libmtev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/circonus-labs/libmtev/git/refs{/sha}","trees_url":"https://api.github.com/repos/circonus-labs/libmtev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/circonus-labs/libmtev/statuses/{sha}","languages_url":"https://api.github.com/repos/circonus-labs/libmtev/languages","stargazers_url":"https://api.github.com/repos/circonus-labs/libmtev/stargazers","contributors_url":"https://api.github.com/repos/circonus-labs/libmtev/contributors","subscribers_url":"https://api.github.com/repos/circonus-labs/libmtev/subscribers","subscription_url":"https://api.github.com/repos/circonus-labs/libmtev/subscription","commits_url":"https://api.github.com/repos/circonus-labs/libmtev/commits{/sha}","git_commits_url":"https://api.github.com/repos/circonus-labs/libmtev/git/commits{/sha}","comments_url":"https://api.github.com/repos/circonus-labs/libmtev/comments{/number}","issue_comment_url":"https://api.github.com/repos/circonus-labs/libmtev/issues/comments{/number}","contents_url":"https://api.github.com/repos/circonus-labs/libmtev/contents/{+path}","compare_url":"https://api.github.com/repos/circonus-labs/libmtev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/circonus-labs/libmtev/merges","archive_url":"https://api.github.com/repos/circonus-labs/libmtev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/circonus-labs/libmtev/downloads","issues_url":"https://api.github.com/repos/circonus-labs/libmtev/issues{/number}","pulls_url":"https://api.github.com/repos/circonus-labs/libmtev/pulls{/number}","milestones_url":"https://api.github.com/repos/circonus-labs/libmtev/milestones{/number}","notifications_url":"https://api.github.com/repos/circonus-labs/libmtev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/circonus-labs/libmtev/labels{/name}","releases_url":"https://api.github.com/repos/circonus-labs/libmtev/releases{/id}","deployments_url":"https://api.github.com/repos/circonus-labs/libmtev/deployments","created_at":"2015-02-21T01:27:31Z","updated_at":"2018-07-12T16:35:20Z","pushed_at":"2018-07-17T18:40:14Z","git_url":"git://github.com/circonus-labs/libmtev.git","ssh_url":"git@github.com:circonus-labs/libmtev.git","clone_url":"https://github.com/circonus-labs/libmtev.git","svn_url":"https://github.com/circonus-labs/libmtev","homepage":null,"size":13359,"stargazers_count":75,"watchers_count":75,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":26,"open_issues":0,"watchers":75,"default_branch":"master"}},"base":{"label":"circonus-labs:master","ref":"master","sha":"530cc2bf414d719424d6c19e7f15ae749fd7c89a","user":{"login":"circonus-labs","id":2091329,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwOTEzMjk=","avatar_url":"https://avatars0.githubusercontent.com/u/2091329?v=4","gravatar_id":"","url":"https://api.github.com/users/circonus-labs","html_url":"https://github.com/circonus-labs","followers_url":"https://api.github.com/users/circonus-labs/followers","following_url":"https://api.github.com/users/circonus-labs/following{/other_user}","gists_url":"https://api.github.com/users/circonus-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/circonus-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/circonus-labs/subscriptions","organizations_url":"https://api.github.com/users/circonus-labs/orgs","repos_url":"https://api.github.com/users/circonus-labs/repos","events_url":"https://api.github.com/users/circonus-labs/events{/privacy}","received_events_url":"https://api.github.com/users/circonus-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":31102547,"node_id":"MDEwOlJlcG9zaXRvcnkzMTEwMjU0Nw==","name":"libmtev","full_name":"circonus-labs/libmtev","owner":{"login":"circonus-labs","id":2091329,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwOTEzMjk=","avatar_url":"https://avatars0.githubusercontent.com/u/2091329?v=4","gravatar_id":"","url":"https://api.github.com/users/circonus-labs","html_url":"https://github.com/circonus-labs","followers_url":"https://api.github.com/users/circonus-labs/followers","following_url":"https://api.github.com/users/circonus-labs/following{/other_user}","gists_url":"https://api.github.com/users/circonus-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/circonus-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/circonus-labs/subscriptions","organizations_url":"https://api.github.com/users/circonus-labs/orgs","repos_url":"https://api.github.com/users/circonus-labs/repos","events_url":"https://api.github.com/users/circonus-labs/events{/privacy}","received_events_url":"https://api.github.com/users/circonus-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/circonus-labs/libmtev","description":"Mount Everest Application Framework","fork":false,"url":"https://api.github.com/repos/circonus-labs/libmtev","forks_url":"https://api.github.com/repos/circonus-labs/libmtev/forks","keys_url":"https://api.github.com/repos/circonus-labs/libmtev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/circonus-labs/libmtev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/circonus-labs/libmtev/teams","hooks_url":"https://api.github.com/repos/circonus-labs/libmtev/hooks","issue_events_url":"https://api.github.com/repos/circonus-labs/libmtev/issues/events{/number}","events_url":"https://api.github.com/repos/circonus-labs/libmtev/events","assignees_url":"https://api.github.com/repos/circonus-labs/libmtev/assignees{/user}","branches_url":"https://api.github.com/repos/circonus-labs/libmtev/branches{/branch}","tags_url":"https://api.github.com/repos/circonus-labs/libmtev/tags","blobs_url":"https://api.github.com/repos/circonus-labs/libmtev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/circonus-labs/libmtev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/circonus-labs/libmtev/git/refs{/sha}","trees_url":"https://api.github.com/repos/circonus-labs/libmtev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/circonus-labs/libmtev/statuses/{sha}","languages_url":"https://api.github.com/repos/circonus-labs/libmtev/languages","stargazers_url":"https://api.github.com/repos/circonus-labs/libmtev/stargazers","contributors_url":"https://api.github.com/repos/circonus-labs/libmtev/contributors","subscribers_url":"https://api.github.com/repos/circonus-labs/libmtev/subscribers","subscription_url":"https://api.github.com/repos/circonus-labs/libmtev/subscription","commits_url":"https://api.github.com/repos/circonus-labs/libmtev/commits{/sha}","git_commits_url":"https://api.github.com/repos/circonus-labs/libmtev/git/commits{/sha}","comments_url":"https://api.github.com/repos/circonus-labs/libmtev/comments{/number}","issue_comment_url":"https://api.github.com/repos/circonus-labs/libmtev/issues/comments{/number}","contents_url":"https://api.github.com/repos/circonus-labs/libmtev/contents/{+path}","compare_url":"https://api.github.com/repos/circonus-labs/libmtev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/circonus-labs/libmtev/merges","archive_url":"https://api.github.com/repos/circonus-labs/libmtev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/circonus-labs/libmtev/downloads","issues_url":"https://api.github.com/repos/circonus-labs/libmtev/issues{/number}","pulls_url":"https://api.github.com/repos/circonus-labs/libmtev/pulls{/number}","milestones_url":"https://api.github.com/repos/circonus-labs/libmtev/milestones{/number}","notifications_url":"https://api.github.com/repos/circonus-labs/libmtev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/circonus-labs/libmtev/labels{/name}","releases_url":"https://api.github.com/repos/circonus-labs/libmtev/releases{/id}","deployments_url":"https://api.github.com/repos/circonus-labs/libmtev/deployments","created_at":"2015-02-21T01:27:31Z","updated_at":"2018-07-12T16:35:20Z","pushed_at":"2018-07-17T18:40:14Z","git_url":"git://github.com/circonus-labs/libmtev.git","ssh_url":"git@github.com:circonus-labs/libmtev.git","clone_url":"https://github.com/circonus-labs/libmtev.git","svn_url":"https://github.com/circonus-labs/libmtev","homepage":null,"size":13359,"stargazers_count":75,"watchers_count":75,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":26,"open_issues":0,"watchers":75,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/circonus-labs/libmtev/pulls/414"},"html":{"href":"https://github.com/circonus-labs/libmtev/pull/414"},"issue":{"href":"https://api.github.com/repos/circonus-labs/libmtev/issues/414"},"comments":{"href":"https://api.github.com/repos/circonus-labs/libmtev/issues/414/comments"},"review_comments":{"href":"https://api.github.com/repos/circonus-labs/libmtev/pulls/414/comments"},"review_comment":{"href":"https://api.github.com/repos/circonus-labs/libmtev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/circonus-labs/libmtev/pulls/414/commits"},"statuses":{"href":"https://api.github.com/repos/circonus-labs/libmtev/statuses/3c72848a12df34e33796faa4c7c8760f6c26b283"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"HeinrichHartmann","id":2446981,"node_id":"MDQ6VXNlcjI0NDY5ODE=","avatar_url":"https://avatars1.githubusercontent.com/u/2446981?v=4","gravatar_id":"","url":"https://api.github.com/users/HeinrichHartmann","html_url":"https://github.com/HeinrichHartmann","followers_url":"https://api.github.com/users/HeinrichHartmann/followers","following_url":"https://api.github.com/users/HeinrichHartmann/following{/other_user}","gists_url":"https://api.github.com/users/HeinrichHartmann/gists{/gist_id}","starred_url":"https://api.github.com/users/HeinrichHartmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HeinrichHartmann/subscriptions","organizations_url":"https://api.github.com/users/HeinrichHartmann/orgs","repos_url":"https://api.github.com/users/HeinrichHartmann/repos","events_url":"https://api.github.com/users/HeinrichHartmann/events{/privacy}","received_events_url":"https://api.github.com/users/HeinrichHartmann/received_events","type":"User","site_admin":false},"comments":0,"review_comments":1,"maintainer_can_modify":false,"commits":3,"additions":40,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"HeinrichHartmann"}}