{"action":"closed","number":6,"pull_request":{"url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/pulls/6","id":178514162,"html_url":"https://github.com/DopplerFoundation/example-app-similar-words/pull/6","diff_url":"https://github.com/DopplerFoundation/example-app-similar-words/pull/6.diff","patch_url":"https://github.com/DopplerFoundation/example-app-similar-words/pull/6.patch","issue_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/issues/6","number":6,"state":"closed","locked":false,"title":"Minor updates/fixes","user":{"login":"jkarimi91","id":8411317,"avatar_url":"https://avatars1.githubusercontent.com/u/8411317?v=4","gravatar_id":"","url":"https://api.github.com/users/jkarimi91","html_url":"https://github.com/jkarimi91","followers_url":"https://api.github.com/users/jkarimi91/followers","following_url":"https://api.github.com/users/jkarimi91/following{/other_user}","gists_url":"https://api.github.com/users/jkarimi91/gists{/gist_id}","starred_url":"https://api.github.com/users/jkarimi91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkarimi91/subscriptions","organizations_url":"https://api.github.com/users/jkarimi91/orgs","repos_url":"https://api.github.com/users/jkarimi91/repos","events_url":"https://api.github.com/users/jkarimi91/events{/privacy}","received_events_url":"https://api.github.com/users/jkarimi91/received_events","type":"User","site_admin":false},"body":"This PR addresses several issues/concerns:\r\n  1. Need to add limit to the input scheme in `package.json`.\r\n  2. Need a test for missing limit key (in input).\r\n  3. README suggests limit key is optional when it is actually required.\r\n  4. Tests are hard to read/keep track of.\r\n  5. Limit logic \r\n      1. can be flatter, more concise, explicit and pythonic.\r\n      2. errors can be more explicit/informative.\r\n  6.  Data path should not be relative to project directory\r\n  7. Need an venv spec file to speed up development; rather than having to install dependencies one by one by hand, we can recreate the dev venv from the env file (standard practice)","created_at":"2018-03-30T08:03:49Z","updated_at":"2018-04-08T01:08:59Z","closed_at":"2018-04-08T01:08:59Z","merged_at":"2018-04-08T01:08:59Z","merge_commit_sha":"0300d8e0feba64982f8a1fa2a70e0e00fd802bec","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/pulls/6/commits","review_comments_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/pulls/6/comments","review_comment_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/issues/6/comments","statuses_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/statuses/4f6888779ec6b60aa51297105006670b65d1278e","head":{"label":"DopplerFoundation:develop","ref":"develop","sha":"4f6888779ec6b60aa51297105006670b65d1278e","user":{"login":"DopplerFoundation","id":34022344,"avatar_url":"https://avatars2.githubusercontent.com/u/34022344?v=4","gravatar_id":"","url":"https://api.github.com/users/DopplerFoundation","html_url":"https://github.com/DopplerFoundation","followers_url":"https://api.github.com/users/DopplerFoundation/followers","following_url":"https://api.github.com/users/DopplerFoundation/following{/other_user}","gists_url":"https://api.github.com/users/DopplerFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/DopplerFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DopplerFoundation/subscriptions","organizations_url":"https://api.github.com/users/DopplerFoundation/orgs","repos_url":"https://api.github.com/users/DopplerFoundation/repos","events_url":"https://api.github.com/users/DopplerFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/DopplerFoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":127045188,"name":"example-app-similar-words","full_name":"DopplerFoundation/example-app-similar-words","owner":{"login":"DopplerFoundation","id":34022344,"avatar_url":"https://avatars2.githubusercontent.com/u/34022344?v=4","gravatar_id":"","url":"https://api.github.com/users/DopplerFoundation","html_url":"https://github.com/DopplerFoundation","followers_url":"https://api.github.com/users/DopplerFoundation/followers","following_url":"https://api.github.com/users/DopplerFoundation/following{/other_user}","gists_url":"https://api.github.com/users/DopplerFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/DopplerFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DopplerFoundation/subscriptions","organizations_url":"https://api.github.com/users/DopplerFoundation/orgs","repos_url":"https://api.github.com/users/DopplerFoundation/repos","events_url":"https://api.github.com/users/DopplerFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/DopplerFoundation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DopplerFoundation/example-app-similar-words","description":"A Doppler machine learning app that will tell you which words are most similar to each other.","fork":false,"url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words","forks_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/forks","keys_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/teams","hooks_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/hooks","issue_events_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/issues/events{/number}","events_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/events","assignees_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/assignees{/user}","branches_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/branches{/branch}","tags_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/tags","blobs_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/git/refs{/sha}","trees_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/statuses/{sha}","languages_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/languages","stargazers_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/stargazers","contributors_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/contributors","subscribers_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/subscribers","subscription_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/subscription","commits_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/commits{/sha}","git_commits_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/git/commits{/sha}","comments_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/comments{/number}","issue_comment_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/issues/comments{/number}","contents_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/contents/{+path}","compare_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/merges","archive_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/downloads","issues_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/issues{/number}","pulls_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/pulls{/number}","milestones_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/milestones{/number}","notifications_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/labels{/name}","releases_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/releases{/id}","deployments_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/deployments","created_at":"2018-03-27T20:58:50Z","updated_at":"2018-03-30T07:35:45Z","pushed_at":"2018-04-08T01:08:59Z","git_url":"git://github.com/DopplerFoundation/example-app-similar-words.git","ssh_url":"git@github.com:DopplerFoundation/example-app-similar-words.git","clone_url":"https://github.com/DopplerFoundation/example-app-similar-words.git","svn_url":"https://github.com/DopplerFoundation/example-app-similar-words","homepage":"https://doppler.market/apps/similar-words","size":39,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DopplerFoundation:master","ref":"master","sha":"a69ba71ea643b085a63fe4f07ff1de0ba35e81ec","user":{"login":"DopplerFoundation","id":34022344,"avatar_url":"https://avatars2.githubusercontent.com/u/34022344?v=4","gravatar_id":"","url":"https://api.github.com/users/DopplerFoundation","html_url":"https://github.com/DopplerFoundation","followers_url":"https://api.github.com/users/DopplerFoundation/followers","following_url":"https://api.github.com/users/DopplerFoundation/following{/other_user}","gists_url":"https://api.github.com/users/DopplerFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/DopplerFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DopplerFoundation/subscriptions","organizations_url":"https://api.github.com/users/DopplerFoundation/orgs","repos_url":"https://api.github.com/users/DopplerFoundation/repos","events_url":"https://api.github.com/users/DopplerFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/DopplerFoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":127045188,"name":"example-app-similar-words","full_name":"DopplerFoundation/example-app-similar-words","owner":{"login":"DopplerFoundation","id":34022344,"avatar_url":"https://avatars2.githubusercontent.com/u/34022344?v=4","gravatar_id":"","url":"https://api.github.com/users/DopplerFoundation","html_url":"https://github.com/DopplerFoundation","followers_url":"https://api.github.com/users/DopplerFoundation/followers","following_url":"https://api.github.com/users/DopplerFoundation/following{/other_user}","gists_url":"https://api.github.com/users/DopplerFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/DopplerFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DopplerFoundation/subscriptions","organizations_url":"https://api.github.com/users/DopplerFoundation/orgs","repos_url":"https://api.github.com/users/DopplerFoundation/repos","events_url":"https://api.github.com/users/DopplerFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/DopplerFoundation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DopplerFoundation/example-app-similar-words","description":"A Doppler machine learning app that will tell you which words are most similar to each other.","fork":false,"url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words","forks_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/forks","keys_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/teams","hooks_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/hooks","issue_events_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/issues/events{/number}","events_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/events","assignees_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/assignees{/user}","branches_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/branches{/branch}","tags_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/tags","blobs_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/git/refs{/sha}","trees_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/statuses/{sha}","languages_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/languages","stargazers_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/stargazers","contributors_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/contributors","subscribers_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/subscribers","subscription_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/subscription","commits_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/commits{/sha}","git_commits_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/git/commits{/sha}","comments_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/comments{/number}","issue_comment_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/issues/comments{/number}","contents_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/contents/{+path}","compare_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/merges","archive_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/downloads","issues_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/issues{/number}","pulls_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/pulls{/number}","milestones_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/milestones{/number}","notifications_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/labels{/name}","releases_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/releases{/id}","deployments_url":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/deployments","created_at":"2018-03-27T20:58:50Z","updated_at":"2018-03-30T07:35:45Z","pushed_at":"2018-04-08T01:08:59Z","git_url":"git://github.com/DopplerFoundation/example-app-similar-words.git","ssh_url":"git@github.com:DopplerFoundation/example-app-similar-words.git","clone_url":"https://github.com/DopplerFoundation/example-app-similar-words.git","svn_url":"https://github.com/DopplerFoundation/example-app-similar-words","homepage":"https://doppler.market/apps/similar-words","size":39,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/pulls/6"},"html":{"href":"https://github.com/DopplerFoundation/example-app-similar-words/pull/6"},"issue":{"href":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/issues/6"},"comments":{"href":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/DopplerFoundation/example-app-similar-words/statuses/4f6888779ec6b60aa51297105006670b65d1278e"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"bvallelunga","id":1920007,"avatar_url":"https://avatars3.githubusercontent.com/u/1920007?v=4","gravatar_id":"","url":"https://api.github.com/users/bvallelunga","html_url":"https://github.com/bvallelunga","followers_url":"https://api.github.com/users/bvallelunga/followers","following_url":"https://api.github.com/users/bvallelunga/following{/other_user}","gists_url":"https://api.github.com/users/bvallelunga/gists{/gist_id}","starred_url":"https://api.github.com/users/bvallelunga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bvallelunga/subscriptions","organizations_url":"https://api.github.com/users/bvallelunga/orgs","repos_url":"https://api.github.com/users/bvallelunga/repos","events_url":"https://api.github.com/users/bvallelunga/events{/privacy}","received_events_url":"https://api.github.com/users/bvallelunga/received_events","type":"User","site_admin":false},"comments":0,"review_comments":8,"maintainer_can_modify":false,"commits":13,"additions":130,"deletions":37,"changed_files":5}}
{"actor":{"display_login":"bvallelunga"}}