{"action":"created","comment":{"url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments/180936311","pull_request_review_id":111447147,"id":180936311,"diff_hunk":"@@ -645,6 +661,10 @@ void AP_GPS::update_instance(uint8_t instance)\n         if (state[instance].status >= GPS_OK_FIX_2D) {\n             timing[instance].last_fix_time_ms = tnow;\n         }\n+\n+        if (should_df_log() && !AP::ahrs().have_ekf_logging()) {\n+            DataFlash_Class::instance()->Log_Write_GPS(instance);","path":"libraries/AP_GPS/AP_GPS.cpp","position":29,"original_position":29,"commit_id":"9f11ae490155f5fc6353a48443623a41ca395714","original_commit_id":"9f11ae490155f5fc6353a48443623a41ca395714","user":{"login":"WickedShell","id":567688,"avatar_url":"https://avatars2.githubusercontent.com/u/567688?v=4","gravatar_id":"","url":"https://api.github.com/users/WickedShell","html_url":"https://github.com/WickedShell","followers_url":"https://api.github.com/users/WickedShell/followers","following_url":"https://api.github.com/users/WickedShell/following{/other_user}","gists_url":"https://api.github.com/users/WickedShell/gists{/gist_id}","starred_url":"https://api.github.com/users/WickedShell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WickedShell/subscriptions","organizations_url":"https://api.github.com/users/WickedShell/orgs","repos_url":"https://api.github.com/users/WickedShell/repos","events_url":"https://api.github.com/users/WickedShell/events{/privacy}","received_events_url":"https://api.github.com/users/WickedShell/received_events","type":"User","site_admin":false},"body":"This needs to be done in the case when we delete the driver as well, as we need a log message for when we give up on a GPS. The previous version caught that via the resulting timestamp shift.","created_at":"2018-04-12T00:31:13Z","updated_at":"2018-04-12T00:31:28Z","html_url":"https://github.com/ArduPilot/ardupilot/pull/8144#discussion_r180936311","pull_request_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/8144","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments/180936311"},"html":{"href":"https://github.com/ArduPilot/ardupilot/pull/8144#discussion_r180936311"},"pull_request":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/8144"}}},"pull_request":{"url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/8144","id":180900404,"html_url":"https://github.com/ArduPilot/ardupilot/pull/8144","diff_url":"https://github.com/ArduPilot/ardupilot/pull/8144.diff","patch_url":"https://github.com/ArduPilot/ardupilot/pull/8144.patch","issue_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/8144","number":8144,"state":"open","locked":false,"title":"Move GPS logging into AP_GPS from vehicle code","user":{"login":"peterbarker","id":7077857,"avatar_url":"https://avatars0.githubusercontent.com/u/7077857?v=4","gravatar_id":"","url":"https://api.github.com/users/peterbarker","html_url":"https://github.com/peterbarker","followers_url":"https://api.github.com/users/peterbarker/followers","following_url":"https://api.github.com/users/peterbarker/following{/other_user}","gists_url":"https://api.github.com/users/peterbarker/gists{/gist_id}","starred_url":"https://api.github.com/users/peterbarker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterbarker/subscriptions","organizations_url":"https://api.github.com/users/peterbarker/orgs","repos_url":"https://api.github.com/users/peterbarker/repos","events_url":"https://api.github.com/users/peterbarker/events{/privacy}","received_events_url":"https://api.github.com/users/peterbarker/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-11T13:17:51Z","updated_at":"2018-04-12T00:31:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"23f6b4c28977d06f0d631ac5944a26d25e4f4e10","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/8144/commits","review_comments_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/8144/comments","review_comment_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/8144/comments","statuses_url":"https://api.github.com/repos/ArduPilot/ardupilot/statuses/9f11ae490155f5fc6353a48443623a41ca395714","head":{"label":"peterbarker:gps-logging","ref":"gps-logging","sha":"9f11ae490155f5fc6353a48443623a41ca395714","user":{"login":"peterbarker","id":7077857,"avatar_url":"https://avatars0.githubusercontent.com/u/7077857?v=4","gravatar_id":"","url":"https://api.github.com/users/peterbarker","html_url":"https://github.com/peterbarker","followers_url":"https://api.github.com/users/peterbarker/followers","following_url":"https://api.github.com/users/peterbarker/following{/other_user}","gists_url":"https://api.github.com/users/peterbarker/gists{/gist_id}","starred_url":"https://api.github.com/users/peterbarker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterbarker/subscriptions","organizations_url":"https://api.github.com/users/peterbarker/orgs","repos_url":"https://api.github.com/users/peterbarker/repos","events_url":"https://api.github.com/users/peterbarker/events{/privacy}","received_events_url":"https://api.github.com/users/peterbarker/received_events","type":"User","site_admin":false},"repo":{"id":34165570,"name":"ardupilot","full_name":"peterbarker/ardupilot","owner":{"login":"peterbarker","id":7077857,"avatar_url":"https://avatars0.githubusercontent.com/u/7077857?v=4","gravatar_id":"","url":"https://api.github.com/users/peterbarker","html_url":"https://github.com/peterbarker","followers_url":"https://api.github.com/users/peterbarker/followers","following_url":"https://api.github.com/users/peterbarker/following{/other_user}","gists_url":"https://api.github.com/users/peterbarker/gists{/gist_id}","starred_url":"https://api.github.com/users/peterbarker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterbarker/subscriptions","organizations_url":"https://api.github.com/users/peterbarker/orgs","repos_url":"https://api.github.com/users/peterbarker/repos","events_url":"https://api.github.com/users/peterbarker/events{/privacy}","received_events_url":"https://api.github.com/users/peterbarker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peterbarker/ardupilot","description":"APM Plane, APM Copter, APM Rover source","fork":true,"url":"https://api.github.com/repos/peterbarker/ardupilot","forks_url":"https://api.github.com/repos/peterbarker/ardupilot/forks","keys_url":"https://api.github.com/repos/peterbarker/ardupilot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peterbarker/ardupilot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peterbarker/ardupilot/teams","hooks_url":"https://api.github.com/repos/peterbarker/ardupilot/hooks","issue_events_url":"https://api.github.com/repos/peterbarker/ardupilot/issues/events{/number}","events_url":"https://api.github.com/repos/peterbarker/ardupilot/events","assignees_url":"https://api.github.com/repos/peterbarker/ardupilot/assignees{/user}","branches_url":"https://api.github.com/repos/peterbarker/ardupilot/branches{/branch}","tags_url":"https://api.github.com/repos/peterbarker/ardupilot/tags","blobs_url":"https://api.github.com/repos/peterbarker/ardupilot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peterbarker/ardupilot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peterbarker/ardupilot/git/refs{/sha}","trees_url":"https://api.github.com/repos/peterbarker/ardupilot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peterbarker/ardupilot/statuses/{sha}","languages_url":"https://api.github.com/repos/peterbarker/ardupilot/languages","stargazers_url":"https://api.github.com/repos/peterbarker/ardupilot/stargazers","contributors_url":"https://api.github.com/repos/peterbarker/ardupilot/contributors","subscribers_url":"https://api.github.com/repos/peterbarker/ardupilot/subscribers","subscription_url":"https://api.github.com/repos/peterbarker/ardupilot/subscription","commits_url":"https://api.github.com/repos/peterbarker/ardupilot/commits{/sha}","git_commits_url":"https://api.github.com/repos/peterbarker/ardupilot/git/commits{/sha}","comments_url":"https://api.github.com/repos/peterbarker/ardupilot/comments{/number}","issue_comment_url":"https://api.github.com/repos/peterbarker/ardupilot/issues/comments{/number}","contents_url":"https://api.github.com/repos/peterbarker/ardupilot/contents/{+path}","compare_url":"https://api.github.com/repos/peterbarker/ardupilot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peterbarker/ardupilot/merges","archive_url":"https://api.github.com/repos/peterbarker/ardupilot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peterbarker/ardupilot/downloads","issues_url":"https://api.github.com/repos/peterbarker/ardupilot/issues{/number}","pulls_url":"https://api.github.com/repos/peterbarker/ardupilot/pulls{/number}","milestones_url":"https://api.github.com/repos/peterbarker/ardupilot/milestones{/number}","notifications_url":"https://api.github.com/repos/peterbarker/ardupilot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peterbarker/ardupilot/labels{/name}","releases_url":"https://api.github.com/repos/peterbarker/ardupilot/releases{/id}","deployments_url":"https://api.github.com/repos/peterbarker/ardupilot/deployments","created_at":"2015-04-18T12:46:36Z","updated_at":"2016-11-30T01:59:51Z","pushed_at":"2018-04-11T13:23:28Z","git_url":"git://github.com/peterbarker/ardupilot.git","ssh_url":"git@github.com:peterbarker/ardupilot.git","clone_url":"https://github.com/peterbarker/ardupilot.git","svn_url":"https://github.com/peterbarker/ardupilot","homepage":"http://ardupilot.com/","size":100609,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ArduPilot:master","ref":"master","sha":"2817cc61f396fcf9b3b8fbe57af23c1807e60015","user":{"login":"ArduPilot","id":17919847,"avatar_url":"https://avatars3.githubusercontent.com/u/17919847?v=4","gravatar_id":"","url":"https://api.github.com/users/ArduPilot","html_url":"https://github.com/ArduPilot","followers_url":"https://api.github.com/users/ArduPilot/followers","following_url":"https://api.github.com/users/ArduPilot/following{/other_user}","gists_url":"https://api.github.com/users/ArduPilot/gists{/gist_id}","starred_url":"https://api.github.com/users/ArduPilot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArduPilot/subscriptions","organizations_url":"https://api.github.com/users/ArduPilot/orgs","repos_url":"https://api.github.com/users/ArduPilot/repos","events_url":"https://api.github.com/users/ArduPilot/events{/privacy}","received_events_url":"https://api.github.com/users/ArduPilot/received_events","type":"Organization","site_admin":false},"repo":{"id":7512484,"name":"ardupilot","full_name":"ArduPilot/ardupilot","owner":{"login":"ArduPilot","id":17919847,"avatar_url":"https://avatars3.githubusercontent.com/u/17919847?v=4","gravatar_id":"","url":"https://api.github.com/users/ArduPilot","html_url":"https://github.com/ArduPilot","followers_url":"https://api.github.com/users/ArduPilot/followers","following_url":"https://api.github.com/users/ArduPilot/following{/other_user}","gists_url":"https://api.github.com/users/ArduPilot/gists{/gist_id}","starred_url":"https://api.github.com/users/ArduPilot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArduPilot/subscriptions","organizations_url":"https://api.github.com/users/ArduPilot/orgs","repos_url":"https://api.github.com/users/ArduPilot/repos","events_url":"https://api.github.com/users/ArduPilot/events{/privacy}","received_events_url":"https://api.github.com/users/ArduPilot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ArduPilot/ardupilot","description":"ArduPlane, ArduCopter, ArduRover source","fork":false,"url":"https://api.github.com/repos/ArduPilot/ardupilot","forks_url":"https://api.github.com/repos/ArduPilot/ardupilot/forks","keys_url":"https://api.github.com/repos/ArduPilot/ardupilot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArduPilot/ardupilot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArduPilot/ardupilot/teams","hooks_url":"https://api.github.com/repos/ArduPilot/ardupilot/hooks","issue_events_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/events{/number}","events_url":"https://api.github.com/repos/ArduPilot/ardupilot/events","assignees_url":"https://api.github.com/repos/ArduPilot/ardupilot/assignees{/user}","branches_url":"https://api.github.com/repos/ArduPilot/ardupilot/branches{/branch}","tags_url":"https://api.github.com/repos/ArduPilot/ardupilot/tags","blobs_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArduPilot/ardupilot/statuses/{sha}","languages_url":"https://api.github.com/repos/ArduPilot/ardupilot/languages","stargazers_url":"https://api.github.com/repos/ArduPilot/ardupilot/stargazers","contributors_url":"https://api.github.com/repos/ArduPilot/ardupilot/contributors","subscribers_url":"https://api.github.com/repos/ArduPilot/ardupilot/subscribers","subscription_url":"https://api.github.com/repos/ArduPilot/ardupilot/subscription","commits_url":"https://api.github.com/repos/ArduPilot/ardupilot/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArduPilot/ardupilot/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArduPilot/ardupilot/contents/{+path}","compare_url":"https://api.github.com/repos/ArduPilot/ardupilot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArduPilot/ardupilot/merges","archive_url":"https://api.github.com/repos/ArduPilot/ardupilot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArduPilot/ardupilot/downloads","issues_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues{/number}","pulls_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls{/number}","milestones_url":"https://api.github.com/repos/ArduPilot/ardupilot/milestones{/number}","notifications_url":"https://api.github.com/repos/ArduPilot/ardupilot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArduPilot/ardupilot/labels{/name}","releases_url":"https://api.github.com/repos/ArduPilot/ardupilot/releases{/id}","deployments_url":"https://api.github.com/repos/ArduPilot/ardupilot/deployments","created_at":"2013-01-09T00:58:52Z","updated_at":"2018-04-11T21:34:43Z","pushed_at":"2018-04-12T00:01:13Z","git_url":"git://github.com/ArduPilot/ardupilot.git","ssh_url":"git@github.com:ArduPilot/ardupilot.git","clone_url":"https://github.com/ArduPilot/ardupilot.git","svn_url":"https://github.com/ArduPilot/ardupilot","homepage":"http://ardupilot.org/","size":100086,"stargazers_count":3128,"watchers_count":3128,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6191,"mirror_url":null,"archived":false,"open_issues_count":1111,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":6191,"open_issues":1111,"watchers":3128,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/8144"},"html":{"href":"https://github.com/ArduPilot/ardupilot/pull/8144"},"issue":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/issues/8144"},"comments":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/issues/8144/comments"},"review_comments":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/8144/comments"},"review_comment":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/8144/commits"},"statuses":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/statuses/9f11ae490155f5fc6353a48443623a41ca395714"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"WickedShell"}}