{"action":"opened","issue":{"url":"https://api.github.com/repos/naver/pinpoint/issues/4358","repository_url":"https://api.github.com/repos/naver/pinpoint","labels_url":"https://api.github.com/repos/naver/pinpoint/issues/4358/labels{/name}","comments_url":"https://api.github.com/repos/naver/pinpoint/issues/4358/comments","events_url":"https://api.github.com/repos/naver/pinpoint/issues/4358/events","html_url":"https://github.com/naver/pinpoint/issues/4358","id":340518340,"node_id":"MDU6SXNzdWUzNDA1MTgzNDA=","number":4358,"title":"Change the save results policy in handshake","user":{"login":"koo-taejin","id":10057874,"node_id":"MDQ6VXNlcjEwMDU3ODc0","avatar_url":"https://avatars2.githubusercontent.com/u/10057874?v=4","gravatar_id":"","url":"https://api.github.com/users/koo-taejin","html_url":"https://github.com/koo-taejin","followers_url":"https://api.github.com/users/koo-taejin/followers","following_url":"https://api.github.com/users/koo-taejin/following{/other_user}","gists_url":"https://api.github.com/users/koo-taejin/gists{/gist_id}","starred_url":"https://api.github.com/users/koo-taejin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koo-taejin/subscriptions","organizations_url":"https://api.github.com/users/koo-taejin/orgs","repos_url":"https://api.github.com/users/koo-taejin/repos","events_url":"https://api.github.com/users/koo-taejin/events{/privacy}","received_events_url":"https://api.github.com/users/koo-taejin/received_events","type":"User","site_admin":false},"labels":[{"id":139511914,"node_id":"MDU6TGFiZWwxMzk1MTE5MTQ=","url":"https://api.github.com/repos/naver/pinpoint/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":751035160,"node_id":"MDU6TGFiZWw3NTEwMzUxNjA=","url":"https://api.github.com/repos/naver/pinpoint/labels/module:project-common","name":"module:project-common","color":"82e835","default":false}],"state":"open","locked":false,"assignee":{"login":"koo-taejin","id":10057874,"node_id":"MDQ6VXNlcjEwMDU3ODc0","avatar_url":"https://avatars2.githubusercontent.com/u/10057874?v=4","gravatar_id":"","url":"https://api.github.com/users/koo-taejin","html_url":"https://github.com/koo-taejin","followers_url":"https://api.github.com/users/koo-taejin/followers","following_url":"https://api.github.com/users/koo-taejin/following{/other_user}","gists_url":"https://api.github.com/users/koo-taejin/gists{/gist_id}","starred_url":"https://api.github.com/users/koo-taejin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koo-taejin/subscriptions","organizations_url":"https://api.github.com/users/koo-taejin/orgs","repos_url":"https://api.github.com/users/koo-taejin/repos","events_url":"https://api.github.com/users/koo-taejin/events{/privacy}","received_events_url":"https://api.github.com/users/koo-taejin/received_events","type":"User","site_admin":false},"assignees":[{"login":"koo-taejin","id":10057874,"node_id":"MDQ6VXNlcjEwMDU3ODc0","avatar_url":"https://avatars2.githubusercontent.com/u/10057874?v=4","gravatar_id":"","url":"https://api.github.com/users/koo-taejin","html_url":"https://github.com/koo-taejin","followers_url":"https://api.github.com/users/koo-taejin/followers","following_url":"https://api.github.com/users/koo-taejin/following{/other_user}","gists_url":"https://api.github.com/users/koo-taejin/gists{/gist_id}","starred_url":"https://api.github.com/users/koo-taejin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koo-taejin/subscriptions","organizations_url":"https://api.github.com/users/koo-taejin/orgs","repos_url":"https://api.github.com/users/koo-taejin/repos","events_url":"https://api.github.com/users/koo-taejin/events{/privacy}","received_events_url":"https://api.github.com/users/koo-taejin/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/naver/pinpoint/milestones/15","html_url":"https://github.com/naver/pinpoint/milestone/15","labels_url":"https://api.github.com/repos/naver/pinpoint/milestones/15/labels","id":3099259,"node_id":"MDk6TWlsZXN0b25lMzA5OTI1OQ==","number":15,"title":"1.8.0","description":"","creator":{"login":"emeroad","id":7564547,"node_id":"MDQ6VXNlcjc1NjQ1NDc=","avatar_url":"https://avatars1.githubusercontent.com/u/7564547?v=4","gravatar_id":"","url":"https://api.github.com/users/emeroad","html_url":"https://github.com/emeroad","followers_url":"https://api.github.com/users/emeroad/followers","following_url":"https://api.github.com/users/emeroad/following{/other_user}","gists_url":"https://api.github.com/users/emeroad/gists{/gist_id}","starred_url":"https://api.github.com/users/emeroad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emeroad/subscriptions","organizations_url":"https://api.github.com/users/emeroad/orgs","repos_url":"https://api.github.com/users/emeroad/repos","events_url":"https://api.github.com/users/emeroad/events{/privacy}","received_events_url":"https://api.github.com/users/emeroad/received_events","type":"User","site_admin":false},"open_issues":26,"closed_issues":157,"state":"open","created_at":"2018-02-08T09:59:41Z","updated_at":"2018-07-12T07:23:41Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-07-12T07:23:41Z","updated_at":"2018-07-12T07:23:41Z","closed_at":null,"author_association":"MEMBER","body":"#### description\r\n\r\nSometimes the handshake result is not ready to respond.\r\nIf return null in handleHandshake method, do not save the result immediately.\r\nLet the client send a handshake packet again.\r\n\r\nas-is \r\n```\r\n        HandshakeResponseCode responseCode = messageListener.handleHandshake(handshakeData);\r\n        boolean isFirst = setChannelProperties(handshakeData);\r\n        if (isFirst) {\r\n            if (HandshakeResponseCode.DUPLEX_COMMUNICATION == responseCode) {\r\n                this.remoteClusterOption = getClusterOption(handshakeData);\r\n                state.toRunDuplex();\r\n            } else if (HandshakeResponseCode.SIMPLEX_COMMUNICATION == responseCode || HandshakeResponseCode.SUCCESS == responseCode) {\r\n                state.toRunSimplex();\r\n            }\r\n        }\r\n```\r\n\r\nto-be\r\n```\r\n        HandshakeResponseCode responseCode = messageListener.handleHandshake(handshakeData);\r\n        if (responseCode != null) {\r\n            boolean isFirst = setChannelProperties(handshakeData);\r\n            if (isFirst) {\r\n                if (HandshakeResponseCode.DUPLEX_COMMUNICATION == responseCode) {\r\n                    this.remoteClusterOption = getClusterOption(handshakeData);\r\n                    state.toRunDuplex();\r\n                } else if (HandshakeResponseCode.SIMPLEX_COMMUNICATION == responseCode || HandshakeResponseCode.SUCCESS == responseCode) {\r\n                    state.toRunSimplex();\r\n                }\r\n            }\r\n\r\n```\r\n\r\n"}}
{"actor":{"display_login":"koo-taejin"}}