{"action":"closed","number":4199,"pull_request":{"url":"https://api.github.com/repos/Azure/acs-engine/pulls/4199","id":228881935,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4ODgxOTM1","html_url":"https://github.com/Azure/acs-engine/pull/4199","diff_url":"https://github.com/Azure/acs-engine/pull/4199.diff","patch_url":"https://github.com/Azure/acs-engine/pull/4199.patch","issue_url":"https://api.github.com/repos/Azure/acs-engine/issues/4199","number":4199,"state":"closed","locked":false,"title":"More validations for custom vnet and vmss masters","user":{"login":"ritazh","id":1856066,"node_id":"MDQ6VXNlcjE4NTYwNjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1856066?v=4","gravatar_id":"","url":"https://api.github.com/users/ritazh","html_url":"https://github.com/ritazh","followers_url":"https://api.github.com/users/ritazh/followers","following_url":"https://api.github.com/users/ritazh/following{/other_user}","gists_url":"https://api.github.com/users/ritazh/gists{/gist_id}","starred_url":"https://api.github.com/users/ritazh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ritazh/subscriptions","organizations_url":"https://api.github.com/users/ritazh/orgs","repos_url":"https://api.github.com/users/ritazh/repos","events_url":"https://api.github.com/users/ritazh/events{/privacy}","received_events_url":"https://api.github.com/users/ritazh/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If you want *faster* PR reviews, read how: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n- Add validation for `firstConsecutiveStaticIP` when using custom vnet and vmss masters\r\n- Add unit test for validation of `firstConsecutiveStaticIP` and vmss masters\r\n- Add docs for using custom VNET with VirtualMachineScaleSets MasterProfile\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #4168 \r\n\r\n**Special notes for your reviewer**:\r\n\r\n**If applicable**:\r\n- [ ] documentation\r\n- [ ] unit tests\r\n- [ ] tested backward compatibility (ie. deploy with previous version, upgrade with this branch)\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```release-note\r\n```\r\n","created_at":"2018-11-07T00:38:11Z","updated_at":"2018-11-07T17:17:24Z","closed_at":"2018-11-07T17:17:24Z","merged_at":"2018-11-07T17:17:23Z","merge_commit_sha":"61aac0686d936504d213af04b9f7c861e60cec7e","assignee":{"login":"ritazh","id":1856066,"node_id":"MDQ6VXNlcjE4NTYwNjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1856066?v=4","gravatar_id":"","url":"https://api.github.com/users/ritazh","html_url":"https://github.com/ritazh","followers_url":"https://api.github.com/users/ritazh/followers","following_url":"https://api.github.com/users/ritazh/following{/other_user}","gists_url":"https://api.github.com/users/ritazh/gists{/gist_id}","starred_url":"https://api.github.com/users/ritazh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ritazh/subscriptions","organizations_url":"https://api.github.com/users/ritazh/orgs","repos_url":"https://api.github.com/users/ritazh/repos","events_url":"https://api.github.com/users/ritazh/events{/privacy}","received_events_url":"https://api.github.com/users/ritazh/received_events","type":"User","site_admin":false},"assignees":[{"login":"jackfrancis","id":1494193,"node_id":"MDQ6VXNlcjE0OTQxOTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1494193?v=4","gravatar_id":"","url":"https://api.github.com/users/jackfrancis","html_url":"https://github.com/jackfrancis","followers_url":"https://api.github.com/users/jackfrancis/followers","following_url":"https://api.github.com/users/jackfrancis/following{/other_user}","gists_url":"https://api.github.com/users/jackfrancis/gists{/gist_id}","starred_url":"https://api.github.com/users/jackfrancis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackfrancis/subscriptions","organizations_url":"https://api.github.com/users/jackfrancis/orgs","repos_url":"https://api.github.com/users/jackfrancis/repos","events_url":"https://api.github.com/users/jackfrancis/events{/privacy}","received_events_url":"https://api.github.com/users/jackfrancis/received_events","type":"User","site_admin":false},{"login":"ritazh","id":1856066,"node_id":"MDQ6VXNlcjE4NTYwNjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1856066?v=4","gravatar_id":"","url":"https://api.github.com/users/ritazh","html_url":"https://github.com/ritazh","followers_url":"https://api.github.com/users/ritazh/followers","following_url":"https://api.github.com/users/ritazh/following{/other_user}","gists_url":"https://api.github.com/users/ritazh/gists{/gist_id}","starred_url":"https://api.github.com/users/ritazh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ritazh/subscriptions","organizations_url":"https://api.github.com/users/ritazh/orgs","repos_url":"https://api.github.com/users/ritazh/repos","events_url":"https://api.github.com/users/ritazh/events{/privacy}","received_events_url":"https://api.github.com/users/ritazh/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":936414293,"node_id":"MDU6TGFiZWw5MzY0MTQyOTM=","url":"https://api.github.com/repos/Azure/acs-engine/labels/approved","name":"approved","color":"52f2d4","default":false},{"id":616225832,"node_id":"MDU6TGFiZWw2MTYyMjU4MzI=","url":"https://api.github.com/repos/Azure/acs-engine/labels/in%20progress","name":"in progress","color":"b8ddf9","default":false},{"id":936411741,"node_id":"MDU6TGFiZWw5MzY0MTE3NDE=","url":"https://api.github.com/repos/Azure/acs-engine/labels/lgtm","name":"lgtm","color":"11fc63","default":false},{"id":936790424,"node_id":"MDU6TGFiZWw5MzY3OTA0MjQ=","url":"https://api.github.com/repos/Azure/acs-engine/labels/size/M","name":"size/M","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/acs-engine/pulls/4199/commits","review_comments_url":"https://api.github.com/repos/Azure/acs-engine/pulls/4199/comments","review_comment_url":"https://api.github.com/repos/Azure/acs-engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/acs-engine/issues/4199/comments","statuses_url":"https://api.github.com/repos/Azure/acs-engine/statuses/ee8ed76b06e9e2400f3b469ce1e012c069535b7b","head":{"label":"ritazh:fix-4168","ref":"fix-4168","sha":"ee8ed76b06e9e2400f3b469ce1e012c069535b7b","user":{"login":"ritazh","id":1856066,"node_id":"MDQ6VXNlcjE4NTYwNjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1856066?v=4","gravatar_id":"","url":"https://api.github.com/users/ritazh","html_url":"https://github.com/ritazh","followers_url":"https://api.github.com/users/ritazh/followers","following_url":"https://api.github.com/users/ritazh/following{/other_user}","gists_url":"https://api.github.com/users/ritazh/gists{/gist_id}","starred_url":"https://api.github.com/users/ritazh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ritazh/subscriptions","organizations_url":"https://api.github.com/users/ritazh/orgs","repos_url":"https://api.github.com/users/ritazh/repos","events_url":"https://api.github.com/users/ritazh/events{/privacy}","received_events_url":"https://api.github.com/users/ritazh/received_events","type":"User","site_admin":false},"repo":{"id":84111079,"node_id":"MDEwOlJlcG9zaXRvcnk4NDExMTA3OQ==","name":"acs-engine","full_name":"ritazh/acs-engine","private":false,"owner":{"login":"ritazh","id":1856066,"node_id":"MDQ6VXNlcjE4NTYwNjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1856066?v=4","gravatar_id":"","url":"https://api.github.com/users/ritazh","html_url":"https://github.com/ritazh","followers_url":"https://api.github.com/users/ritazh/followers","following_url":"https://api.github.com/users/ritazh/following{/other_user}","gists_url":"https://api.github.com/users/ritazh/gists{/gist_id}","starred_url":"https://api.github.com/users/ritazh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ritazh/subscriptions","organizations_url":"https://api.github.com/users/ritazh/orgs","repos_url":"https://api.github.com/users/ritazh/repos","events_url":"https://api.github.com/users/ritazh/events{/privacy}","received_events_url":"https://api.github.com/users/ritazh/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ritazh/acs-engine","description":"Azure Container Service Engine - a place for community to collaborate and build the best open Docker container infrastructure for Azure.","fork":true,"url":"https://api.github.com/repos/ritazh/acs-engine","forks_url":"https://api.github.com/repos/ritazh/acs-engine/forks","keys_url":"https://api.github.com/repos/ritazh/acs-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ritazh/acs-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ritazh/acs-engine/teams","hooks_url":"https://api.github.com/repos/ritazh/acs-engine/hooks","issue_events_url":"https://api.github.com/repos/ritazh/acs-engine/issues/events{/number}","events_url":"https://api.github.com/repos/ritazh/acs-engine/events","assignees_url":"https://api.github.com/repos/ritazh/acs-engine/assignees{/user}","branches_url":"https://api.github.com/repos/ritazh/acs-engine/branches{/branch}","tags_url":"https://api.github.com/repos/ritazh/acs-engine/tags","blobs_url":"https://api.github.com/repos/ritazh/acs-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ritazh/acs-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ritazh/acs-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/ritazh/acs-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ritazh/acs-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/ritazh/acs-engine/languages","stargazers_url":"https://api.github.com/repos/ritazh/acs-engine/stargazers","contributors_url":"https://api.github.com/repos/ritazh/acs-engine/contributors","subscribers_url":"https://api.github.com/repos/ritazh/acs-engine/subscribers","subscription_url":"https://api.github.com/repos/ritazh/acs-engine/subscription","commits_url":"https://api.github.com/repos/ritazh/acs-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/ritazh/acs-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/ritazh/acs-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/ritazh/acs-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/ritazh/acs-engine/contents/{+path}","compare_url":"https://api.github.com/repos/ritazh/acs-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ritazh/acs-engine/merges","archive_url":"https://api.github.com/repos/ritazh/acs-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ritazh/acs-engine/downloads","issues_url":"https://api.github.com/repos/ritazh/acs-engine/issues{/number}","pulls_url":"https://api.github.com/repos/ritazh/acs-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/ritazh/acs-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/ritazh/acs-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ritazh/acs-engine/labels{/name}","releases_url":"https://api.github.com/repos/ritazh/acs-engine/releases{/id}","deployments_url":"https://api.github.com/repos/ritazh/acs-engine/deployments","created_at":"2017-03-06T19:16:37Z","updated_at":"2017-11-13T17:35:18Z","pushed_at":"2018-11-07T03:03:10Z","git_url":"git://github.com/ritazh/acs-engine.git","ssh_url":"git@github.com:ritazh/acs-engine.git","clone_url":"https://github.com/ritazh/acs-engine.git","svn_url":"https://github.com/ritazh/acs-engine","homepage":"","size":80187,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"31d660d47a5f9d7014c7e12a3b995de694086eb4","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":66011370,"node_id":"MDEwOlJlcG9zaXRvcnk2NjAxMTM3MA==","name":"acs-engine","full_name":"Azure/acs-engine","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/acs-engine","description":"Azure Container Service Engine - provision and deploy container orchestrators on Azure: Kubernetes, DC/OS, and Docker Swarm.","fork":false,"url":"https://api.github.com/repos/Azure/acs-engine","forks_url":"https://api.github.com/repos/Azure/acs-engine/forks","keys_url":"https://api.github.com/repos/Azure/acs-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/acs-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/acs-engine/teams","hooks_url":"https://api.github.com/repos/Azure/acs-engine/hooks","issue_events_url":"https://api.github.com/repos/Azure/acs-engine/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/acs-engine/events","assignees_url":"https://api.github.com/repos/Azure/acs-engine/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/acs-engine/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/acs-engine/tags","blobs_url":"https://api.github.com/repos/Azure/acs-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/acs-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/acs-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/acs-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/acs-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/acs-engine/languages","stargazers_url":"https://api.github.com/repos/Azure/acs-engine/stargazers","contributors_url":"https://api.github.com/repos/Azure/acs-engine/contributors","subscribers_url":"https://api.github.com/repos/Azure/acs-engine/subscribers","subscription_url":"https://api.github.com/repos/Azure/acs-engine/subscription","commits_url":"https://api.github.com/repos/Azure/acs-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/acs-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/acs-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/acs-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/acs-engine/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/acs-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/acs-engine/merges","archive_url":"https://api.github.com/repos/Azure/acs-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/acs-engine/downloads","issues_url":"https://api.github.com/repos/Azure/acs-engine/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/acs-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/acs-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/acs-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/acs-engine/labels{/name}","releases_url":"https://api.github.com/repos/Azure/acs-engine/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/acs-engine/deployments","created_at":"2016-08-18T16:05:16Z","updated_at":"2018-11-07T17:02:17Z","pushed_at":"2018-11-07T17:17:23Z","git_url":"git://github.com/Azure/acs-engine.git","ssh_url":"git@github.com:Azure/acs-engine.git","clone_url":"https://github.com/Azure/acs-engine.git","svn_url":"https://github.com/Azure/acs-engine","homepage":"","size":90271,"stargazers_count":1008,"watchers_count":1008,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":627,"mirror_url":null,"archived":false,"open_issues_count":615,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":627,"open_issues":615,"watchers":1008,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/4199"},"html":{"href":"https://github.com/Azure/acs-engine/pull/4199"},"issue":{"href":"https://api.github.com/repos/Azure/acs-engine/issues/4199"},"comments":{"href":"https://api.github.com/repos/Azure/acs-engine/issues/4199/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/4199/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/4199/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/acs-engine/statuses/ee8ed76b06e9e2400f3b469ce1e012c069535b7b"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jackfrancis","id":1494193,"node_id":"MDQ6VXNlcjE0OTQxOTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1494193?v=4","gravatar_id":"","url":"https://api.github.com/users/jackfrancis","html_url":"https://github.com/jackfrancis","followers_url":"https://api.github.com/users/jackfrancis/followers","following_url":"https://api.github.com/users/jackfrancis/following{/other_user}","gists_url":"https://api.github.com/users/jackfrancis/gists{/gist_id}","starred_url":"https://api.github.com/users/jackfrancis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackfrancis/subscriptions","organizations_url":"https://api.github.com/users/jackfrancis/orgs","repos_url":"https://api.github.com/users/jackfrancis/repos","events_url":"https://api.github.com/users/jackfrancis/events{/privacy}","received_events_url":"https://api.github.com/users/jackfrancis/received_events","type":"User","site_admin":false},"comments":3,"review_comments":2,"maintainer_can_modify":false,"commits":1,"additions":59,"deletions":5,"changed_files":3}}
{"actor":{"display_login":"jackfrancis"}}