{"action":"created","comment":{"url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/comments/241222070","pull_request_review_id":184441721,"id":241222070,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTIyMjA3MA==","diff_hunk":"@@ -19,15 +19,14 @@ export class AddMissingHandles extends Strategy {\n           return undefined;\n         }\n         // Don't add use handles to a recipe with free handles\n-        const freeHandles = recipe.handles.filter(handle => handle.connections.length === 0);\n+        const freeHandles = recipe.getFreeHandles();\n         if (freeHandles.length > 0) {","path":"src/runtime/strategies/add-missing-handles.ts","position":6,"original_position":6,"commit_id":"0af330710bf60fedfe1718b2f4961e446d4cd939","original_commit_id":"0af330710bf60fedfe1718b2f4961e446d4cd939","user":{"login":"mykmartin","id":34528845,"node_id":"MDQ6VXNlcjM0NTI4ODQ1","avatar_url":"https://avatars0.githubusercontent.com/u/34528845?v=4","gravatar_id":"","url":"https://api.github.com/users/mykmartin","html_url":"https://github.com/mykmartin","followers_url":"https://api.github.com/users/mykmartin/followers","following_url":"https://api.github.com/users/mykmartin/following{/other_user}","gists_url":"https://api.github.com/users/mykmartin/gists{/gist_id}","starred_url":"https://api.github.com/users/mykmartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mykmartin/subscriptions","organizations_url":"https://api.github.com/users/mykmartin/orgs","repos_url":"https://api.github.com/users/mykmartin/repos","events_url":"https://api.github.com/users/mykmartin/events{/privacy}","received_events_url":"https://api.github.com/users/mykmartin/received_events","type":"User","site_admin":false},"body":"Consider inlining: `if (recipe.getFreeHandles().length > 0) {`","created_at":"2018-12-12T23:21:44Z","updated_at":"2018-12-12T23:22:25Z","html_url":"https://github.com/PolymerLabs/arcs/pull/2444#discussion_r241222070","pull_request_url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/2444","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/comments/241222070"},"html":{"href":"https://github.com/PolymerLabs/arcs/pull/2444#discussion_r241222070"},"pull_request":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/2444"}}},"pull_request":{"url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/2444","id":238215350,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MjE1MzUw","html_url":"https://github.com/PolymerLabs/arcs/pull/2444","diff_url":"https://github.com/PolymerLabs/arcs/pull/2444.diff","patch_url":"https://github.com/PolymerLabs/arcs/pull/2444.patch","issue_url":"https://api.github.com/repos/PolymerLabs/arcs/issues/2444","number":2444,"state":"open","locked":false,"title":"First stages of moving recipe logic from strategies to Recipe class.","user":{"login":"AliceLetitia","id":25454572,"node_id":"MDQ6VXNlcjI1NDU0NTcy","avatar_url":"https://avatars1.githubusercontent.com/u/25454572?v=4","gravatar_id":"","url":"https://api.github.com/users/AliceLetitia","html_url":"https://github.com/AliceLetitia","followers_url":"https://api.github.com/users/AliceLetitia/followers","following_url":"https://api.github.com/users/AliceLetitia/following{/other_user}","gists_url":"https://api.github.com/users/AliceLetitia/gists{/gist_id}","starred_url":"https://api.github.com/users/AliceLetitia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AliceLetitia/subscriptions","organizations_url":"https://api.github.com/users/AliceLetitia/orgs","repos_url":"https://api.github.com/users/AliceLetitia/repos","events_url":"https://api.github.com/users/AliceLetitia/events{/privacy}","received_events_url":"https://api.github.com/users/AliceLetitia/received_events","type":"User","site_admin":false},"body":"Move recipe logic from add-missing-handles strategy to Recipe class","created_at":"2018-12-12T23:18:46Z","updated_at":"2018-12-12T23:22:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31cfbdebb07bc4d9d66569d1e23a113ec91dc364","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/2444/commits","review_comments_url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/2444/comments","review_comment_url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PolymerLabs/arcs/issues/2444/comments","statuses_url":"https://api.github.com/repos/PolymerLabs/arcs/statuses/0af330710bf60fedfe1718b2f4961e446d4cd939","head":{"label":"AliceLetitia:recipeRequire","ref":"recipeRequire","sha":"0af330710bf60fedfe1718b2f4961e446d4cd939","user":{"login":"AliceLetitia","id":25454572,"node_id":"MDQ6VXNlcjI1NDU0NTcy","avatar_url":"https://avatars1.githubusercontent.com/u/25454572?v=4","gravatar_id":"","url":"https://api.github.com/users/AliceLetitia","html_url":"https://github.com/AliceLetitia","followers_url":"https://api.github.com/users/AliceLetitia/followers","following_url":"https://api.github.com/users/AliceLetitia/following{/other_user}","gists_url":"https://api.github.com/users/AliceLetitia/gists{/gist_id}","starred_url":"https://api.github.com/users/AliceLetitia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AliceLetitia/subscriptions","organizations_url":"https://api.github.com/users/AliceLetitia/orgs","repos_url":"https://api.github.com/users/AliceLetitia/repos","events_url":"https://api.github.com/users/AliceLetitia/events{/privacy}","received_events_url":"https://api.github.com/users/AliceLetitia/received_events","type":"User","site_admin":false},"repo":{"id":159445748,"node_id":"MDEwOlJlcG9zaXRvcnkxNTk0NDU3NDg=","name":"arcs","full_name":"AliceLetitia/arcs","private":false,"owner":{"login":"AliceLetitia","id":25454572,"node_id":"MDQ6VXNlcjI1NDU0NTcy","avatar_url":"https://avatars1.githubusercontent.com/u/25454572?v=4","gravatar_id":"","url":"https://api.github.com/users/AliceLetitia","html_url":"https://github.com/AliceLetitia","followers_url":"https://api.github.com/users/AliceLetitia/followers","following_url":"https://api.github.com/users/AliceLetitia/following{/other_user}","gists_url":"https://api.github.com/users/AliceLetitia/gists{/gist_id}","starred_url":"https://api.github.com/users/AliceLetitia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AliceLetitia/subscriptions","organizations_url":"https://api.github.com/users/AliceLetitia/orgs","repos_url":"https://api.github.com/users/AliceLetitia/repos","events_url":"https://api.github.com/users/AliceLetitia/events{/privacy}","received_events_url":"https://api.github.com/users/AliceLetitia/received_events","type":"User","site_admin":false},"html_url":"https://github.com/AliceLetitia/arcs","description":"Arcs","fork":true,"url":"https://api.github.com/repos/AliceLetitia/arcs","forks_url":"https://api.github.com/repos/AliceLetitia/arcs/forks","keys_url":"https://api.github.com/repos/AliceLetitia/arcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AliceLetitia/arcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AliceLetitia/arcs/teams","hooks_url":"https://api.github.com/repos/AliceLetitia/arcs/hooks","issue_events_url":"https://api.github.com/repos/AliceLetitia/arcs/issues/events{/number}","events_url":"https://api.github.com/repos/AliceLetitia/arcs/events","assignees_url":"https://api.github.com/repos/AliceLetitia/arcs/assignees{/user}","branches_url":"https://api.github.com/repos/AliceLetitia/arcs/branches{/branch}","tags_url":"https://api.github.com/repos/AliceLetitia/arcs/tags","blobs_url":"https://api.github.com/repos/AliceLetitia/arcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AliceLetitia/arcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AliceLetitia/arcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/AliceLetitia/arcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AliceLetitia/arcs/statuses/{sha}","languages_url":"https://api.github.com/repos/AliceLetitia/arcs/languages","stargazers_url":"https://api.github.com/repos/AliceLetitia/arcs/stargazers","contributors_url":"https://api.github.com/repos/AliceLetitia/arcs/contributors","subscribers_url":"https://api.github.com/repos/AliceLetitia/arcs/subscribers","subscription_url":"https://api.github.com/repos/AliceLetitia/arcs/subscription","commits_url":"https://api.github.com/repos/AliceLetitia/arcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/AliceLetitia/arcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/AliceLetitia/arcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/AliceLetitia/arcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/AliceLetitia/arcs/contents/{+path}","compare_url":"https://api.github.com/repos/AliceLetitia/arcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AliceLetitia/arcs/merges","archive_url":"https://api.github.com/repos/AliceLetitia/arcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AliceLetitia/arcs/downloads","issues_url":"https://api.github.com/repos/AliceLetitia/arcs/issues{/number}","pulls_url":"https://api.github.com/repos/AliceLetitia/arcs/pulls{/number}","milestones_url":"https://api.github.com/repos/AliceLetitia/arcs/milestones{/number}","notifications_url":"https://api.github.com/repos/AliceLetitia/arcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AliceLetitia/arcs/labels{/name}","releases_url":"https://api.github.com/repos/AliceLetitia/arcs/releases{/id}","deployments_url":"https://api.github.com/repos/AliceLetitia/arcs/deployments","created_at":"2018-11-28T04:54:57Z","updated_at":"2018-12-12T05:10:24Z","pushed_at":"2018-12-12T23:16:26Z","git_url":"git://github.com/AliceLetitia/arcs.git","ssh_url":"git@github.com:AliceLetitia/arcs.git","clone_url":"https://github.com/AliceLetitia/arcs.git","svn_url":"https://github.com/AliceLetitia/arcs","homepage":"","size":30881,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PolymerLabs:master","ref":"master","sha":"0e31905787543030d9986796857e247008aa209c","user":{"login":"PolymerLabs","id":5912903,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5MTI5MDM=","avatar_url":"https://avatars2.githubusercontent.com/u/5912903?v=4","gravatar_id":"","url":"https://api.github.com/users/PolymerLabs","html_url":"https://github.com/PolymerLabs","followers_url":"https://api.github.com/users/PolymerLabs/followers","following_url":"https://api.github.com/users/PolymerLabs/following{/other_user}","gists_url":"https://api.github.com/users/PolymerLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerLabs/subscriptions","organizations_url":"https://api.github.com/users/PolymerLabs/orgs","repos_url":"https://api.github.com/users/PolymerLabs/repos","events_url":"https://api.github.com/users/PolymerLabs/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":80783122,"node_id":"MDEwOlJlcG9zaXRvcnk4MDc4MzEyMg==","name":"arcs","full_name":"PolymerLabs/arcs","private":false,"owner":{"login":"PolymerLabs","id":5912903,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5MTI5MDM=","avatar_url":"https://avatars2.githubusercontent.com/u/5912903?v=4","gravatar_id":"","url":"https://api.github.com/users/PolymerLabs","html_url":"https://github.com/PolymerLabs","followers_url":"https://api.github.com/users/PolymerLabs/followers","following_url":"https://api.github.com/users/PolymerLabs/following{/other_user}","gists_url":"https://api.github.com/users/PolymerLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerLabs/subscriptions","organizations_url":"https://api.github.com/users/PolymerLabs/orgs","repos_url":"https://api.github.com/users/PolymerLabs/repos","events_url":"https://api.github.com/users/PolymerLabs/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerLabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PolymerLabs/arcs","description":"Arcs","fork":false,"url":"https://api.github.com/repos/PolymerLabs/arcs","forks_url":"https://api.github.com/repos/PolymerLabs/arcs/forks","keys_url":"https://api.github.com/repos/PolymerLabs/arcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolymerLabs/arcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolymerLabs/arcs/teams","hooks_url":"https://api.github.com/repos/PolymerLabs/arcs/hooks","issue_events_url":"https://api.github.com/repos/PolymerLabs/arcs/issues/events{/number}","events_url":"https://api.github.com/repos/PolymerLabs/arcs/events","assignees_url":"https://api.github.com/repos/PolymerLabs/arcs/assignees{/user}","branches_url":"https://api.github.com/repos/PolymerLabs/arcs/branches{/branch}","tags_url":"https://api.github.com/repos/PolymerLabs/arcs/tags","blobs_url":"https://api.github.com/repos/PolymerLabs/arcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolymerLabs/arcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolymerLabs/arcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolymerLabs/arcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolymerLabs/arcs/statuses/{sha}","languages_url":"https://api.github.com/repos/PolymerLabs/arcs/languages","stargazers_url":"https://api.github.com/repos/PolymerLabs/arcs/stargazers","contributors_url":"https://api.github.com/repos/PolymerLabs/arcs/contributors","subscribers_url":"https://api.github.com/repos/PolymerLabs/arcs/subscribers","subscription_url":"https://api.github.com/repos/PolymerLabs/arcs/subscription","commits_url":"https://api.github.com/repos/PolymerLabs/arcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolymerLabs/arcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolymerLabs/arcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolymerLabs/arcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolymerLabs/arcs/contents/{+path}","compare_url":"https://api.github.com/repos/PolymerLabs/arcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolymerLabs/arcs/merges","archive_url":"https://api.github.com/repos/PolymerLabs/arcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolymerLabs/arcs/downloads","issues_url":"https://api.github.com/repos/PolymerLabs/arcs/issues{/number}","pulls_url":"https://api.github.com/repos/PolymerLabs/arcs/pulls{/number}","milestones_url":"https://api.github.com/repos/PolymerLabs/arcs/milestones{/number}","notifications_url":"https://api.github.com/repos/PolymerLabs/arcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolymerLabs/arcs/labels{/name}","releases_url":"https://api.github.com/repos/PolymerLabs/arcs/releases{/id}","deployments_url":"https://api.github.com/repos/PolymerLabs/arcs/deployments","created_at":"2017-02-03T00:32:19Z","updated_at":"2018-12-12T22:50:53Z","pushed_at":"2018-12-12T23:18:47Z","git_url":"git://github.com/PolymerLabs/arcs.git","ssh_url":"git@github.com:PolymerLabs/arcs.git","clone_url":"https://github.com/PolymerLabs/arcs.git","svn_url":"https://github.com/PolymerLabs/arcs","homepage":"","size":30995,"stargazers_count":34,"watchers_count":34,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":192,"license":null,"forks":11,"open_issues":192,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/2444"},"html":{"href":"https://github.com/PolymerLabs/arcs/pull/2444"},"issue":{"href":"https://api.github.com/repos/PolymerLabs/arcs/issues/2444"},"comments":{"href":"https://api.github.com/repos/PolymerLabs/arcs/issues/2444/comments"},"review_comments":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/2444/comments"},"review_comment":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/2444/commits"},"statuses":{"href":"https://api.github.com/repos/PolymerLabs/arcs/statuses/0af330710bf60fedfe1718b2f4961e446d4cd939"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mykmartin"}}