{"action":"created","comment":{"url":"https://api.github.com/repos/Linaro/odp/pulls/comments/172022477","pull_request_review_id":100980673,"id":172022477,"diff_hunk":"@@ -1327,15 +1365,30 @@ static ipsec_sa_t *ipsec_out_single(odp_packet_t pkt,\n \todp_ipsec_frag_mode_t frag_mode;\n \tuint32_t mtu;\n \n-\tstate.ip_offset = odp_packet_l3_offset(pkt);\n-\tODP_ASSERT(ODP_PACKET_OFFSET_INVALID != state.ip_offset);\n-\n-\tstate.ip = odp_packet_l3_ptr(pkt, NULL);\n-\tODP_ASSERT(NULL != state.ip);\n-\n \tipsec_sa = _odp_ipsec_sa_use(sa);\n \tODP_ASSERT(NULL != ipsec_sa);\n \n+\tif (opt->flag.tfc_dummy) {","path":"platform/linux-generic/odp_ipsec.c","position":156,"original_position":123,"commit_id":"e29e8e83c29604dbf53e4b8228d70221c3c31396","original_commit_id":"6caa218fa15dc071c5fd47f9c21add28e19bfae5","user":{"login":"Bill-Fischofer-Linaro","id":13422322,"avatar_url":"https://avatars1.githubusercontent.com/u/13422322?v=4","gravatar_id":"","url":"https://api.github.com/users/Bill-Fischofer-Linaro","html_url":"https://github.com/Bill-Fischofer-Linaro","followers_url":"https://api.github.com/users/Bill-Fischofer-Linaro/followers","following_url":"https://api.github.com/users/Bill-Fischofer-Linaro/following{/other_user}","gists_url":"https://api.github.com/users/Bill-Fischofer-Linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/Bill-Fischofer-Linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bill-Fischofer-Linaro/subscriptions","organizations_url":"https://api.github.com/users/Bill-Fischofer-Linaro/orgs","repos_url":"https://api.github.com/users/Bill-Fischofer-Linaro/repos","events_url":"https://api.github.com/users/Bill-Fischofer-Linaro/events{/privacy}","received_events_url":"https://api.github.com/users/Bill-Fischofer-Linaro/received_events","type":"User","site_admin":false},"body":"An `odp_unlikely()` would be appropriate for this `if`.","created_at":"2018-03-03T17:10:20Z","updated_at":"2018-03-03T17:27:21Z","html_url":"https://github.com/Linaro/odp/pull/494#discussion_r172022477","pull_request_url":"https://api.github.com/repos/Linaro/odp/pulls/494","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Linaro/odp/pulls/comments/172022477"},"html":{"href":"https://github.com/Linaro/odp/pull/494#discussion_r172022477"},"pull_request":{"href":"https://api.github.com/repos/Linaro/odp/pulls/494"}}},"pull_request":{"url":"https://api.github.com/repos/Linaro/odp/pulls/494","id":170519569,"html_url":"https://github.com/Linaro/odp/pull/494","diff_url":"https://github.com/Linaro/odp/pull/494.diff","patch_url":"https://github.com/Linaro/odp/pull/494.patch","issue_url":"https://api.github.com/repos/Linaro/odp/issues/494","number":494,"state":"open","locked":false,"title":"[PATCH API-NEXT v4] IPsec TFC implementation","user":{"login":"lumag","id":20323,"avatar_url":"https://avatars2.githubusercontent.com/u/20323?v=4","gravatar_id":"","url":"https://api.github.com/users/lumag","html_url":"https://github.com/lumag","followers_url":"https://api.github.com/users/lumag/followers","following_url":"https://api.github.com/users/lumag/following{/other_user}","gists_url":"https://api.github.com/users/lumag/gists{/gist_id}","starred_url":"https://api.github.com/users/lumag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lumag/subscriptions","organizations_url":"https://api.github.com/users/lumag/orgs","repos_url":"https://api.github.com/users/lumag/repos","events_url":"https://api.github.com/users/lumag/events{/privacy}","received_events_url":"https://api.github.com/users/lumag/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-21T16:23:55Z","updated_at":"2018-03-03T17:27:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e394f2fe63bc1d520446367d0cebc0309c267ced","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":837255251,"url":"https://api.github.com/repos/Linaro/odp/labels/AfterTM","name":"AfterTM","color":"f9e82c","default":false},{"id":577854052,"url":"https://api.github.com/repos/Linaro/odp/labels/Email_sent","name":"Email_sent","color":"ededed","default":false},{"id":666131932,"url":"https://api.github.com/repos/Linaro/odp/labels/checkpatch","name":"checkpatch","color":"0000ff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Linaro/odp/pulls/494/commits","review_comments_url":"https://api.github.com/repos/Linaro/odp/pulls/494/comments","review_comment_url":"https://api.github.com/repos/Linaro/odp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Linaro/odp/issues/494/comments","statuses_url":"https://api.github.com/repos/Linaro/odp/statuses/e29e8e83c29604dbf53e4b8228d70221c3c31396","head":{"label":"lumag:ipsec-tfc-imp","ref":"ipsec-tfc-imp","sha":"e29e8e83c29604dbf53e4b8228d70221c3c31396","user":{"login":"lumag","id":20323,"avatar_url":"https://avatars2.githubusercontent.com/u/20323?v=4","gravatar_id":"","url":"https://api.github.com/users/lumag","html_url":"https://github.com/lumag","followers_url":"https://api.github.com/users/lumag/followers","following_url":"https://api.github.com/users/lumag/following{/other_user}","gists_url":"https://api.github.com/users/lumag/gists{/gist_id}","starred_url":"https://api.github.com/users/lumag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lumag/subscriptions","organizations_url":"https://api.github.com/users/lumag/orgs","repos_url":"https://api.github.com/users/lumag/repos","events_url":"https://api.github.com/users/lumag/events{/privacy}","received_events_url":"https://api.github.com/users/lumag/received_events","type":"User","site_admin":false},"repo":{"id":87109113,"name":"odp","full_name":"lumag/odp","owner":{"login":"lumag","id":20323,"avatar_url":"https://avatars2.githubusercontent.com/u/20323?v=4","gravatar_id":"","url":"https://api.github.com/users/lumag","html_url":"https://github.com/lumag","followers_url":"https://api.github.com/users/lumag/followers","following_url":"https://api.github.com/users/lumag/following{/other_user}","gists_url":"https://api.github.com/users/lumag/gists{/gist_id}","starred_url":"https://api.github.com/users/lumag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lumag/subscriptions","organizations_url":"https://api.github.com/users/lumag/orgs","repos_url":"https://api.github.com/users/lumag/repos","events_url":"https://api.github.com/users/lumag/events{/privacy}","received_events_url":"https://api.github.com/users/lumag/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lumag/odp","description":"The ODP project is an open-source, cross-platform set of application programming interfaces (APIs) for the networking data plane","fork":true,"url":"https://api.github.com/repos/lumag/odp","forks_url":"https://api.github.com/repos/lumag/odp/forks","keys_url":"https://api.github.com/repos/lumag/odp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lumag/odp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lumag/odp/teams","hooks_url":"https://api.github.com/repos/lumag/odp/hooks","issue_events_url":"https://api.github.com/repos/lumag/odp/issues/events{/number}","events_url":"https://api.github.com/repos/lumag/odp/events","assignees_url":"https://api.github.com/repos/lumag/odp/assignees{/user}","branches_url":"https://api.github.com/repos/lumag/odp/branches{/branch}","tags_url":"https://api.github.com/repos/lumag/odp/tags","blobs_url":"https://api.github.com/repos/lumag/odp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lumag/odp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lumag/odp/git/refs{/sha}","trees_url":"https://api.github.com/repos/lumag/odp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lumag/odp/statuses/{sha}","languages_url":"https://api.github.com/repos/lumag/odp/languages","stargazers_url":"https://api.github.com/repos/lumag/odp/stargazers","contributors_url":"https://api.github.com/repos/lumag/odp/contributors","subscribers_url":"https://api.github.com/repos/lumag/odp/subscribers","subscription_url":"https://api.github.com/repos/lumag/odp/subscription","commits_url":"https://api.github.com/repos/lumag/odp/commits{/sha}","git_commits_url":"https://api.github.com/repos/lumag/odp/git/commits{/sha}","comments_url":"https://api.github.com/repos/lumag/odp/comments{/number}","issue_comment_url":"https://api.github.com/repos/lumag/odp/issues/comments{/number}","contents_url":"https://api.github.com/repos/lumag/odp/contents/{+path}","compare_url":"https://api.github.com/repos/lumag/odp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lumag/odp/merges","archive_url":"https://api.github.com/repos/lumag/odp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lumag/odp/downloads","issues_url":"https://api.github.com/repos/lumag/odp/issues{/number}","pulls_url":"https://api.github.com/repos/lumag/odp/pulls{/number}","milestones_url":"https://api.github.com/repos/lumag/odp/milestones{/number}","notifications_url":"https://api.github.com/repos/lumag/odp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lumag/odp/labels{/name}","releases_url":"https://api.github.com/repos/lumag/odp/releases{/id}","deployments_url":"https://api.github.com/repos/lumag/odp/deployments","created_at":"2017-04-03T18:50:14Z","updated_at":"2017-04-03T18:50:17Z","pushed_at":"2018-03-03T12:18:36Z","git_url":"git://github.com/lumag/odp.git","ssh_url":"git@github.com:lumag/odp.git","clone_url":"https://github.com/lumag/odp.git","svn_url":"https://github.com/lumag/odp","homepage":"http://www.opendataplane.org/","size":11384,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Linaro:api-next","ref":"api-next","sha":"89f735041d4474f5da399ff683200991fc73cdd9","user":{"login":"Linaro","id":1180626,"avatar_url":"https://avatars0.githubusercontent.com/u/1180626?v=4","gravatar_id":"","url":"https://api.github.com/users/Linaro","html_url":"https://github.com/Linaro","followers_url":"https://api.github.com/users/Linaro/followers","following_url":"https://api.github.com/users/Linaro/following{/other_user}","gists_url":"https://api.github.com/users/Linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/Linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Linaro/subscriptions","organizations_url":"https://api.github.com/users/Linaro/orgs","repos_url":"https://api.github.com/users/Linaro/repos","events_url":"https://api.github.com/users/Linaro/events{/privacy}","received_events_url":"https://api.github.com/users/Linaro/received_events","type":"Organization","site_admin":false},"repo":{"id":79130215,"name":"odp","full_name":"Linaro/odp","owner":{"login":"Linaro","id":1180626,"avatar_url":"https://avatars0.githubusercontent.com/u/1180626?v=4","gravatar_id":"","url":"https://api.github.com/users/Linaro","html_url":"https://github.com/Linaro","followers_url":"https://api.github.com/users/Linaro/followers","following_url":"https://api.github.com/users/Linaro/following{/other_user}","gists_url":"https://api.github.com/users/Linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/Linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Linaro/subscriptions","organizations_url":"https://api.github.com/users/Linaro/orgs","repos_url":"https://api.github.com/users/Linaro/repos","events_url":"https://api.github.com/users/Linaro/events{/privacy}","received_events_url":"https://api.github.com/users/Linaro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Linaro/odp","description":"The ODP project is an open-source, cross-platform set of application programming interfaces (APIs) for the networking data plane","fork":false,"url":"https://api.github.com/repos/Linaro/odp","forks_url":"https://api.github.com/repos/Linaro/odp/forks","keys_url":"https://api.github.com/repos/Linaro/odp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Linaro/odp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Linaro/odp/teams","hooks_url":"https://api.github.com/repos/Linaro/odp/hooks","issue_events_url":"https://api.github.com/repos/Linaro/odp/issues/events{/number}","events_url":"https://api.github.com/repos/Linaro/odp/events","assignees_url":"https://api.github.com/repos/Linaro/odp/assignees{/user}","branches_url":"https://api.github.com/repos/Linaro/odp/branches{/branch}","tags_url":"https://api.github.com/repos/Linaro/odp/tags","blobs_url":"https://api.github.com/repos/Linaro/odp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Linaro/odp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Linaro/odp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Linaro/odp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Linaro/odp/statuses/{sha}","languages_url":"https://api.github.com/repos/Linaro/odp/languages","stargazers_url":"https://api.github.com/repos/Linaro/odp/stargazers","contributors_url":"https://api.github.com/repos/Linaro/odp/contributors","subscribers_url":"https://api.github.com/repos/Linaro/odp/subscribers","subscription_url":"https://api.github.com/repos/Linaro/odp/subscription","commits_url":"https://api.github.com/repos/Linaro/odp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Linaro/odp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Linaro/odp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Linaro/odp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Linaro/odp/contents/{+path}","compare_url":"https://api.github.com/repos/Linaro/odp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Linaro/odp/merges","archive_url":"https://api.github.com/repos/Linaro/odp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Linaro/odp/downloads","issues_url":"https://api.github.com/repos/Linaro/odp/issues{/number}","pulls_url":"https://api.github.com/repos/Linaro/odp/pulls{/number}","milestones_url":"https://api.github.com/repos/Linaro/odp/milestones{/number}","notifications_url":"https://api.github.com/repos/Linaro/odp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Linaro/odp/labels{/name}","releases_url":"https://api.github.com/repos/Linaro/odp/releases{/id}","deployments_url":"https://api.github.com/repos/Linaro/odp/deployments","created_at":"2017-01-16T15:11:12Z","updated_at":"2018-02-27T00:14:45Z","pushed_at":"2018-03-03T12:18:37Z","git_url":"git://github.com/Linaro/odp.git","ssh_url":"git@github.com:Linaro/odp.git","clone_url":"https://github.com/Linaro/odp.git","svn_url":"https://github.com/Linaro/odp","homepage":"http://www.opendataplane.org/","size":11144,"stargazers_count":38,"watchers_count":38,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":47,"open_issues":18,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Linaro/odp/pulls/494"},"html":{"href":"https://github.com/Linaro/odp/pull/494"},"issue":{"href":"https://api.github.com/repos/Linaro/odp/issues/494"},"comments":{"href":"https://api.github.com/repos/Linaro/odp/issues/494/comments"},"review_comments":{"href":"https://api.github.com/repos/Linaro/odp/pulls/494/comments"},"review_comment":{"href":"https://api.github.com/repos/Linaro/odp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Linaro/odp/pulls/494/commits"},"statuses":{"href":"https://api.github.com/repos/Linaro/odp/statuses/e29e8e83c29604dbf53e4b8228d70221c3c31396"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Bill-Fischofer-Linaro"}}