{"action":"created","comment":{"url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/pulls/comments/212499060","pull_request_review_id":149148025,"id":212499060,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjQ5OTA2MA==","diff_hunk":"@@ -1,2 +1,29 @@\n function StackDataStructure () {\n+    this.stackControl = [];\n+    this.MAX_SIZE = 10;\n }\n+\n+StackDataStructure.prototype.isEmpty = function (){\n+    if(this.stackControl.length == 0) return true;\n+    else return false;","path":"starter-code/src/StackDataStructure.js","position":8,"original_position":8,"commit_id":"b25078a7f7590c09ce4d0bb57f441d30c09096e4","original_commit_id":"b25078a7f7590c09ce4d0bb57f441d30c09096e4","user":{"login":"ta-web-mex","id":35221964,"node_id":"MDQ6VXNlcjM1MjIxOTY0","avatar_url":"https://avatars1.githubusercontent.com/u/35221964?v=4","gravatar_id":"","url":"https://api.github.com/users/ta-web-mex","html_url":"https://github.com/ta-web-mex","followers_url":"https://api.github.com/users/ta-web-mex/followers","following_url":"https://api.github.com/users/ta-web-mex/following{/other_user}","gists_url":"https://api.github.com/users/ta-web-mex/gists{/gist_id}","starred_url":"https://api.github.com/users/ta-web-mex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ta-web-mex/subscriptions","organizations_url":"https://api.github.com/users/ta-web-mex/orgs","repos_url":"https://api.github.com/users/ta-web-mex/repos","events_url":"https://api.github.com/users/ta-web-mex/events{/privacy}","received_events_url":"https://api.github.com/users/ta-web-mex/received_events","type":"User","site_admin":false},"body":"you can avoid ``èlse```","created_at":"2018-08-24T01:14:41Z","updated_at":"2018-08-24T01:14:41Z","html_url":"https://github.com/ironhack-labs/lab-javascript-advanced-algorithms/pull/313#discussion_r212499060","pull_request_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/pulls/313","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/pulls/comments/212499060"},"html":{"href":"https://github.com/ironhack-labs/lab-javascript-advanced-algorithms/pull/313#discussion_r212499060"},"pull_request":{"href":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/pulls/313"}}},"pull_request":{"url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/pulls/313","id":209679460,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5Njc5NDYw","html_url":"https://github.com/ironhack-labs/lab-javascript-advanced-algorithms/pull/313","diff_url":"https://github.com/ironhack-labs/lab-javascript-advanced-algorithms/pull/313.diff","patch_url":"https://github.com/ironhack-labs/lab-javascript-advanced-algorithms/pull/313.patch","issue_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/issues/313","number":313,"state":"open","locked":false,"title":"DE-PT2MEX-Vermont","user":{"login":"vermontgarcia","id":40477541,"node_id":"MDQ6VXNlcjQwNDc3NTQx","avatar_url":"https://avatars0.githubusercontent.com/u/40477541?v=4","gravatar_id":"","url":"https://api.github.com/users/vermontgarcia","html_url":"https://github.com/vermontgarcia","followers_url":"https://api.github.com/users/vermontgarcia/followers","following_url":"https://api.github.com/users/vermontgarcia/following{/other_user}","gists_url":"https://api.github.com/users/vermontgarcia/gists{/gist_id}","starred_url":"https://api.github.com/users/vermontgarcia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vermontgarcia/subscriptions","organizations_url":"https://api.github.com/users/vermontgarcia/orgs","repos_url":"https://api.github.com/users/vermontgarcia/repos","events_url":"https://api.github.com/users/vermontgarcia/events{/privacy}","received_events_url":"https://api.github.com/users/vermontgarcia/received_events","type":"User","site_admin":false},"body":"I'm wondering which is the best way to link the logic with the UI and how far or close I am.","created_at":"2018-08-21T00:40:44Z","updated_at":"2018-08-24T01:14:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79178ccb5432f421ecac0135c2636bcc220ee770","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/pulls/313/commits","review_comments_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/pulls/313/comments","review_comment_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/issues/313/comments","statuses_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/statuses/b25078a7f7590c09ce4d0bb57f441d30c09096e4","head":{"label":"vermontgarcia:master","ref":"master","sha":"b25078a7f7590c09ce4d0bb57f441d30c09096e4","user":{"login":"vermontgarcia","id":40477541,"node_id":"MDQ6VXNlcjQwNDc3NTQx","avatar_url":"https://avatars0.githubusercontent.com/u/40477541?v=4","gravatar_id":"","url":"https://api.github.com/users/vermontgarcia","html_url":"https://github.com/vermontgarcia","followers_url":"https://api.github.com/users/vermontgarcia/followers","following_url":"https://api.github.com/users/vermontgarcia/following{/other_user}","gists_url":"https://api.github.com/users/vermontgarcia/gists{/gist_id}","starred_url":"https://api.github.com/users/vermontgarcia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vermontgarcia/subscriptions","organizations_url":"https://api.github.com/users/vermontgarcia/orgs","repos_url":"https://api.github.com/users/vermontgarcia/repos","events_url":"https://api.github.com/users/vermontgarcia/events{/privacy}","received_events_url":"https://api.github.com/users/vermontgarcia/received_events","type":"User","site_admin":false},"repo":{"id":145256148,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUyNTYxNDg=","name":"lab-javascript-advanced-algorithms","full_name":"vermontgarcia/lab-javascript-advanced-algorithms","owner":{"login":"vermontgarcia","id":40477541,"node_id":"MDQ6VXNlcjQwNDc3NTQx","avatar_url":"https://avatars0.githubusercontent.com/u/40477541?v=4","gravatar_id":"","url":"https://api.github.com/users/vermontgarcia","html_url":"https://github.com/vermontgarcia","followers_url":"https://api.github.com/users/vermontgarcia/followers","following_url":"https://api.github.com/users/vermontgarcia/following{/other_user}","gists_url":"https://api.github.com/users/vermontgarcia/gists{/gist_id}","starred_url":"https://api.github.com/users/vermontgarcia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vermontgarcia/subscriptions","organizations_url":"https://api.github.com/users/vermontgarcia/orgs","repos_url":"https://api.github.com/users/vermontgarcia/repos","events_url":"https://api.github.com/users/vermontgarcia/events{/privacy}","received_events_url":"https://api.github.com/users/vermontgarcia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vermontgarcia/lab-javascript-advanced-algorithms","description":"An exercise to practice JavaScript and use testing to create a solution","fork":true,"url":"https://api.github.com/repos/vermontgarcia/lab-javascript-advanced-algorithms","forks_url":"https://api.github.com/repos/vermontgarcia/lab-javascript-advanced-algorithms/forks","keys_url":"https://api.github.com/repos/vermontgarcia/lab-javascript-advanced-algorithms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vermontgarcia/lab-javascript-advanced-algorithms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vermontgarcia/lab-javascript-advanced-algorithms/teams","hooks_url":"https://api.github.com/repos/vermontgarcia/lab-javascript-advanced-algorithms/hooks","issue_events_url":"https://api.github.com/repos/vermontgarcia/lab-javascript-advanced-algorithms/issues/events{/number}","events_url":"https://api.github.com/repos/vermontgarcia/lab-javascript-advanced-algorithms/events","assignees_url":"https://api.github.com/repos/vermontgarcia/lab-javascript-advanced-algorithms/assignees{/user}","branches_url":"https://api.github.com/repos/vermontgarcia/lab-javascript-advanced-algorithms/branches{/branch}","tags_url":"https://api.github.com/repos/vermontgarcia/lab-javascript-advanced-algorithms/tags","blobs_url":"https://api.github.com/repos/vermontgarcia/lab-javascript-advanced-algorithms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vermontgarcia/lab-javascript-advanced-algorithms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vermontgarcia/lab-javascript-advanced-algorithms/git/refs{/sha}","trees_url":"https://api.github.com/repos/vermontgarcia/lab-javascript-advanced-algorithms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vermontgarcia/lab-javascript-advanced-algorithms/statuses/{sha}","languages_url":"https://api.github.com/repos/vermontgarcia/lab-javascript-advanced-algorithms/languages","stargazers_url":"https://api.github.com/repos/vermontgarcia/lab-javascript-advanced-algorithms/stargazers","contributors_url":"https://api.github.com/repos/vermontgarcia/lab-javascript-advanced-algorithms/contributors","subscribers_url":"https://api.github.com/repos/vermontgarcia/lab-javascript-advanced-algorithms/subscribers","subscription_url":"https://api.github.com/repos/vermontgarcia/lab-javascript-advanced-algorithms/subscription","commits_url":"https://api.github.com/repos/vermontgarcia/lab-javascript-advanced-algorithms/commits{/sha}","git_commits_url":"https://api.github.com/repos/vermontgarcia/lab-javascript-advanced-algorithms/git/commits{/sha}","comments_url":"https://api.github.com/repos/vermontgarcia/lab-javascript-advanced-algorithms/comments{/number}","issue_comment_url":"https://api.github.com/repos/vermontgarcia/lab-javascript-advanced-algorithms/issues/comments{/number}","contents_url":"https://api.github.com/repos/vermontgarcia/lab-javascript-advanced-algorithms/contents/{+path}","compare_url":"https://api.github.com/repos/vermontgarcia/lab-javascript-advanced-algorithms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vermontgarcia/lab-javascript-advanced-algorithms/merges","archive_url":"https://api.github.com/repos/vermontgarcia/lab-javascript-advanced-algorithms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vermontgarcia/lab-javascript-advanced-algorithms/downloads","issues_url":"https://api.github.com/repos/vermontgarcia/lab-javascript-advanced-algorithms/issues{/number}","pulls_url":"https://api.github.com/repos/vermontgarcia/lab-javascript-advanced-algorithms/pulls{/number}","milestones_url":"https://api.github.com/repos/vermontgarcia/lab-javascript-advanced-algorithms/milestones{/number}","notifications_url":"https://api.github.com/repos/vermontgarcia/lab-javascript-advanced-algorithms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vermontgarcia/lab-javascript-advanced-algorithms/labels{/name}","releases_url":"https://api.github.com/repos/vermontgarcia/lab-javascript-advanced-algorithms/releases{/id}","deployments_url":"https://api.github.com/repos/vermontgarcia/lab-javascript-advanced-algorithms/deployments","created_at":"2018-08-18T22:16:18Z","updated_at":"2018-08-21T00:35:18Z","pushed_at":"2018-08-21T00:35:16Z","git_url":"git://github.com/vermontgarcia/lab-javascript-advanced-algorithms.git","ssh_url":"git@github.com:vermontgarcia/lab-javascript-advanced-algorithms.git","clone_url":"https://github.com/vermontgarcia/lab-javascript-advanced-algorithms.git","svn_url":"https://github.com/vermontgarcia/lab-javascript-advanced-algorithms","homepage":null,"size":75,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ironhack-labs:master","ref":"master","sha":"0c2dd9690c01d65cc795739d3fb2d4a5e134f683","user":{"login":"ironhack-labs","id":25032046,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDMyMDQ2","avatar_url":"https://avatars3.githubusercontent.com/u/25032046?v=4","gravatar_id":"","url":"https://api.github.com/users/ironhack-labs","html_url":"https://github.com/ironhack-labs","followers_url":"https://api.github.com/users/ironhack-labs/followers","following_url":"https://api.github.com/users/ironhack-labs/following{/other_user}","gists_url":"https://api.github.com/users/ironhack-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/ironhack-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironhack-labs/subscriptions","organizations_url":"https://api.github.com/users/ironhack-labs/orgs","repos_url":"https://api.github.com/users/ironhack-labs/repos","events_url":"https://api.github.com/users/ironhack-labs/events{/privacy}","received_events_url":"https://api.github.com/users/ironhack-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":78558169,"node_id":"MDEwOlJlcG9zaXRvcnk3ODU1ODE2OQ==","name":"lab-javascript-advanced-algorithms","full_name":"ironhack-labs/lab-javascript-advanced-algorithms","owner":{"login":"ironhack-labs","id":25032046,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDMyMDQ2","avatar_url":"https://avatars3.githubusercontent.com/u/25032046?v=4","gravatar_id":"","url":"https://api.github.com/users/ironhack-labs","html_url":"https://github.com/ironhack-labs","followers_url":"https://api.github.com/users/ironhack-labs/followers","following_url":"https://api.github.com/users/ironhack-labs/following{/other_user}","gists_url":"https://api.github.com/users/ironhack-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/ironhack-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironhack-labs/subscriptions","organizations_url":"https://api.github.com/users/ironhack-labs/orgs","repos_url":"https://api.github.com/users/ironhack-labs/repos","events_url":"https://api.github.com/users/ironhack-labs/events{/privacy}","received_events_url":"https://api.github.com/users/ironhack-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ironhack-labs/lab-javascript-advanced-algorithms","description":"An exercise to practice JavaScript and use testing to create a solution","fork":false,"url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms","forks_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/forks","keys_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/teams","hooks_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/hooks","issue_events_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/issues/events{/number}","events_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/events","assignees_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/assignees{/user}","branches_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/branches{/branch}","tags_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/tags","blobs_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/git/refs{/sha}","trees_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/statuses/{sha}","languages_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/languages","stargazers_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/stargazers","contributors_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/contributors","subscribers_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/subscribers","subscription_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/subscription","commits_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/commits{/sha}","git_commits_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/git/commits{/sha}","comments_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/comments{/number}","issue_comment_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/issues/comments{/number}","contents_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/contents/{+path}","compare_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/merges","archive_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/downloads","issues_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/issues{/number}","pulls_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/pulls{/number}","milestones_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/milestones{/number}","notifications_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/labels{/name}","releases_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/releases{/id}","deployments_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/deployments","created_at":"2017-01-10T17:44:23Z","updated_at":"2018-01-21T01:24:16Z","pushed_at":"2018-08-23T13:07:29Z","git_url":"git://github.com/ironhack-labs/lab-javascript-advanced-algorithms.git","ssh_url":"git@github.com:ironhack-labs/lab-javascript-advanced-algorithms.git","clone_url":"https://github.com/ironhack-labs/lab-javascript-advanced-algorithms.git","svn_url":"https://github.com/ironhack-labs/lab-javascript-advanced-algorithms","homepage":null,"size":72,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":431,"mirror_url":null,"archived":false,"open_issues_count":31,"license":null,"forks":431,"open_issues":31,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/pulls/313"},"html":{"href":"https://github.com/ironhack-labs/lab-javascript-advanced-algorithms/pull/313"},"issue":{"href":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/issues/313"},"comments":{"href":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/issues/313/comments"},"review_comments":{"href":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/pulls/313/comments"},"review_comment":{"href":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/pulls/313/commits"},"statuses":{"href":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/statuses/b25078a7f7590c09ce4d0bb57f441d30c09096e4"}},"author_association":"NONE"}}
{"actor":{"display_login":"ta-web-mex"}}