{"action":"created","comment":{"url":"https://api.github.com/repos/folio-org/stripes-core/pulls/comments/168471593","pull_request_review_id":96842010,"id":168471593,"diff_hunk":"@@ -4,22 +4,45 @@\n \n import React from 'react';\n import PropTypes from 'prop-types';\n-import NavButton from '../NavButton';\n+import AppIcon from '@folio/stripes-components/lib/AppIcon';\n+import Badge from '@folio/stripes-components/lib/Badge';\n+import Headline from '@folio/stripes-components/lib/Headline';\n+import css from './CurrentApp.css';\n \n const propTypes = {\n-  currentApp: PropTypes.object,\n+  currentApp: PropTypes.shape(\n+    {\n+      displayName: PropTypes.string,\n+      description: PropTypes.string,\n+    },\n+  ),\n+  id: PropTypes.string,\n+  icon: PropTypes.oneOfType([\n+    PropTypes.element,\n+  ]),\n+  badge: PropTypes.oneOfType([\n+    PropTypes.string,\n+    PropTypes.number,\n+  ]),\n };\n \n-const CurrentApp = ({ currentApp }) => {\n-  const { displayName, description } = currentApp;\n+const defaultProps = {\n+  currentApp: { displayName: 'FOLIO', description: 'FOLIO platform' },\n+};","path":"src/components/MainNav/CurrentApp/CurrentApp.js","position":32,"original_position":32,"commit_id":"87daa1630d299614c598eb23c217a4fbf3df60e5","original_commit_id":"87daa1630d299614c598eb23c217a4fbf3df60e5","user":{"login":"rasmuswoelk","id":640976,"avatar_url":"https://avatars3.githubusercontent.com/u/640976?v=4","gravatar_id":"","url":"https://api.github.com/users/rasmuswoelk","html_url":"https://github.com/rasmuswoelk","followers_url":"https://api.github.com/users/rasmuswoelk/followers","following_url":"https://api.github.com/users/rasmuswoelk/following{/other_user}","gists_url":"https://api.github.com/users/rasmuswoelk/gists{/gist_id}","starred_url":"https://api.github.com/users/rasmuswoelk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rasmuswoelk/subscriptions","organizations_url":"https://api.github.com/users/rasmuswoelk/orgs","repos_url":"https://api.github.com/users/rasmuswoelk/repos","events_url":"https://api.github.com/users/rasmuswoelk/events{/privacy}","received_events_url":"https://api.github.com/users/rasmuswoelk/received_events","type":"User","site_admin":false},"body":"Instead of having \"Folio\" as default it should be the last open app as default (or the first app in the list) meaning that you shouldn't be able to _not_ have any open apps.\r\n\r\nI think we can leave it like this for now since the \"last open app\" feature isn't made yet. The last open app should be stored somewhere - probably on each individual user. It probably needs it's own issue I assume.","created_at":"2018-02-15T13:17:44Z","updated_at":"2018-02-15T13:17:44Z","html_url":"https://github.com/folio-org/stripes-core/pull/206#discussion_r168471593","pull_request_url":"https://api.github.com/repos/folio-org/stripes-core/pulls/206","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/folio-org/stripes-core/pulls/comments/168471593"},"html":{"href":"https://github.com/folio-org/stripes-core/pull/206#discussion_r168471593"},"pull_request":{"href":"https://api.github.com/repos/folio-org/stripes-core/pulls/206"}}},"pull_request":{"url":"https://api.github.com/repos/folio-org/stripes-core/pulls/206","id":168675497,"html_url":"https://github.com/folio-org/stripes-core/pull/206","diff_url":"https://github.com/folio-org/stripes-core/pull/206.diff","patch_url":"https://github.com/folio-org/stripes-core/pull/206.patch","issue_url":"https://api.github.com/repos/folio-org/stripes-core/issues/206","number":206,"state":"open","locked":false,"title":"STCOR-159 Render current app as h1, setup default display","user":{"login":"JohnC-80","id":20704067,"avatar_url":"https://avatars1.githubusercontent.com/u/20704067?v=4","gravatar_id":"","url":"https://api.github.com/users/JohnC-80","html_url":"https://github.com/JohnC-80","followers_url":"https://api.github.com/users/JohnC-80/followers","following_url":"https://api.github.com/users/JohnC-80/following{/other_user}","gists_url":"https://api.github.com/users/JohnC-80/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnC-80/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnC-80/subscriptions","organizations_url":"https://api.github.com/users/JohnC-80/orgs","repos_url":"https://api.github.com/users/JohnC-80/repos","events_url":"https://api.github.com/users/JohnC-80/events{/privacy}","received_events_url":"https://api.github.com/users/JohnC-80/received_events","type":"User","site_admin":false},"body":"As part of a continuing effort to improve the accessibility of STRIPES UI, this PR is an initial step in giving FOLIO modules a mark-up structure that outlines nicely so that assistive technologies can have a clean way to navigate the page via its heading tags.\r\nIdeally, pages have a structure that flows in a hierarchical fashion - \r\n```\r\n<h1>\r\n  <h2>\r\n    <!-- h2 content -->\r\n    <h3>\r\n      <!-- h3 content -->\r\n  <h2>\r\n    <!-- h2 content -->\r\n    <h3>\r\n      <!-- h3 content -->\r\n      <h4>\r\n        <!-- h4 content -->\r\n  <h2>\r\n  <!-- h2 content -->\r\n```\r\nIt's best for pages to have only a single `<h1>` tag followed by `<h2-6>` tags arranged as seen in the example.\r\nThis GREATLY eases navigation for those using assistive technologies to perceive page content (and is a low-hanging fruit on the accessibility tree that sites can sometimes miss.)\r\nThere will be future PR's in other modules to set up a hierarchical flow to the headers used in an app. Much can be handled at the level of `stripes-components` with its `<Accordion>` and `<Headline>` components.\r\n\r\nBefore a module is selected in the UI, the `<CurrentApp>` displays \"FOLIO\" with the title \"FOLIO platform\"","created_at":"2018-02-12T20:07:22Z","updated_at":"2018-02-15T13:17:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3dc17d6e955b4f2985b9b7c9c8377678a26131f1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/folio-org/stripes-core/pulls/206/commits","review_comments_url":"https://api.github.com/repos/folio-org/stripes-core/pulls/206/comments","review_comment_url":"https://api.github.com/repos/folio-org/stripes-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/folio-org/stripes-core/issues/206/comments","statuses_url":"https://api.github.com/repos/folio-org/stripes-core/statuses/87daa1630d299614c598eb23c217a4fbf3df60e5","head":{"label":"folio-org:stcor-159-current-app-h1","ref":"stcor-159-current-app-h1","sha":"87daa1630d299614c598eb23c217a4fbf3df60e5","user":{"login":"folio-org","id":16495055,"avatar_url":"https://avatars2.githubusercontent.com/u/16495055?v=4","gravatar_id":"","url":"https://api.github.com/users/folio-org","html_url":"https://github.com/folio-org","followers_url":"https://api.github.com/users/folio-org/followers","following_url":"https://api.github.com/users/folio-org/following{/other_user}","gists_url":"https://api.github.com/users/folio-org/gists{/gist_id}","starred_url":"https://api.github.com/users/folio-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/folio-org/subscriptions","organizations_url":"https://api.github.com/users/folio-org/orgs","repos_url":"https://api.github.com/users/folio-org/repos","events_url":"https://api.github.com/users/folio-org/events{/privacy}","received_events_url":"https://api.github.com/users/folio-org/received_events","type":"Organization","site_admin":false},"repo":{"id":71846636,"name":"stripes-core","full_name":"folio-org/stripes-core","owner":{"login":"folio-org","id":16495055,"avatar_url":"https://avatars2.githubusercontent.com/u/16495055?v=4","gravatar_id":"","url":"https://api.github.com/users/folio-org","html_url":"https://github.com/folio-org","followers_url":"https://api.github.com/users/folio-org/followers","following_url":"https://api.github.com/users/folio-org/following{/other_user}","gists_url":"https://api.github.com/users/folio-org/gists{/gist_id}","starred_url":"https://api.github.com/users/folio-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/folio-org/subscriptions","organizations_url":"https://api.github.com/users/folio-org/orgs","repos_url":"https://api.github.com/users/folio-org/repos","events_url":"https://api.github.com/users/folio-org/events{/privacy}","received_events_url":"https://api.github.com/users/folio-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/folio-org/stripes-core","description":"The core of Stripes, an opinionated and modular platform for React components consuming REST data and the UI framework for the FOLIO project","fork":false,"url":"https://api.github.com/repos/folio-org/stripes-core","forks_url":"https://api.github.com/repos/folio-org/stripes-core/forks","keys_url":"https://api.github.com/repos/folio-org/stripes-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/folio-org/stripes-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/folio-org/stripes-core/teams","hooks_url":"https://api.github.com/repos/folio-org/stripes-core/hooks","issue_events_url":"https://api.github.com/repos/folio-org/stripes-core/issues/events{/number}","events_url":"https://api.github.com/repos/folio-org/stripes-core/events","assignees_url":"https://api.github.com/repos/folio-org/stripes-core/assignees{/user}","branches_url":"https://api.github.com/repos/folio-org/stripes-core/branches{/branch}","tags_url":"https://api.github.com/repos/folio-org/stripes-core/tags","blobs_url":"https://api.github.com/repos/folio-org/stripes-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/folio-org/stripes-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/folio-org/stripes-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/folio-org/stripes-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/folio-org/stripes-core/statuses/{sha}","languages_url":"https://api.github.com/repos/folio-org/stripes-core/languages","stargazers_url":"https://api.github.com/repos/folio-org/stripes-core/stargazers","contributors_url":"https://api.github.com/repos/folio-org/stripes-core/contributors","subscribers_url":"https://api.github.com/repos/folio-org/stripes-core/subscribers","subscription_url":"https://api.github.com/repos/folio-org/stripes-core/subscription","commits_url":"https://api.github.com/repos/folio-org/stripes-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/folio-org/stripes-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/folio-org/stripes-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/folio-org/stripes-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/folio-org/stripes-core/contents/{+path}","compare_url":"https://api.github.com/repos/folio-org/stripes-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/folio-org/stripes-core/merges","archive_url":"https://api.github.com/repos/folio-org/stripes-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/folio-org/stripes-core/downloads","issues_url":"https://api.github.com/repos/folio-org/stripes-core/issues{/number}","pulls_url":"https://api.github.com/repos/folio-org/stripes-core/pulls{/number}","milestones_url":"https://api.github.com/repos/folio-org/stripes-core/milestones{/number}","notifications_url":"https://api.github.com/repos/folio-org/stripes-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/folio-org/stripes-core/labels{/name}","releases_url":"https://api.github.com/repos/folio-org/stripes-core/releases{/id}","deployments_url":"https://api.github.com/repos/folio-org/stripes-core/deployments","created_at":"2016-10-25T01:15:59Z","updated_at":"2018-02-06T19:38:22Z","pushed_at":"2018-02-15T05:43:08Z","git_url":"git://github.com/folio-org/stripes-core.git","ssh_url":"git@github.com:folio-org/stripes-core.git","clone_url":"https://github.com/folio-org/stripes-core.git","svn_url":"https://github.com/folio-org/stripes-core","homepage":null,"size":1592,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":13,"open_issues":2,"watchers":5,"default_branch":"master"}},"base":{"label":"folio-org:master","ref":"master","sha":"4f86c058be8c1dee7ab66231085a1f34bb0188e2","user":{"login":"folio-org","id":16495055,"avatar_url":"https://avatars2.githubusercontent.com/u/16495055?v=4","gravatar_id":"","url":"https://api.github.com/users/folio-org","html_url":"https://github.com/folio-org","followers_url":"https://api.github.com/users/folio-org/followers","following_url":"https://api.github.com/users/folio-org/following{/other_user}","gists_url":"https://api.github.com/users/folio-org/gists{/gist_id}","starred_url":"https://api.github.com/users/folio-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/folio-org/subscriptions","organizations_url":"https://api.github.com/users/folio-org/orgs","repos_url":"https://api.github.com/users/folio-org/repos","events_url":"https://api.github.com/users/folio-org/events{/privacy}","received_events_url":"https://api.github.com/users/folio-org/received_events","type":"Organization","site_admin":false},"repo":{"id":71846636,"name":"stripes-core","full_name":"folio-org/stripes-core","owner":{"login":"folio-org","id":16495055,"avatar_url":"https://avatars2.githubusercontent.com/u/16495055?v=4","gravatar_id":"","url":"https://api.github.com/users/folio-org","html_url":"https://github.com/folio-org","followers_url":"https://api.github.com/users/folio-org/followers","following_url":"https://api.github.com/users/folio-org/following{/other_user}","gists_url":"https://api.github.com/users/folio-org/gists{/gist_id}","starred_url":"https://api.github.com/users/folio-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/folio-org/subscriptions","organizations_url":"https://api.github.com/users/folio-org/orgs","repos_url":"https://api.github.com/users/folio-org/repos","events_url":"https://api.github.com/users/folio-org/events{/privacy}","received_events_url":"https://api.github.com/users/folio-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/folio-org/stripes-core","description":"The core of Stripes, an opinionated and modular platform for React components consuming REST data and the UI framework for the FOLIO project","fork":false,"url":"https://api.github.com/repos/folio-org/stripes-core","forks_url":"https://api.github.com/repos/folio-org/stripes-core/forks","keys_url":"https://api.github.com/repos/folio-org/stripes-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/folio-org/stripes-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/folio-org/stripes-core/teams","hooks_url":"https://api.github.com/repos/folio-org/stripes-core/hooks","issue_events_url":"https://api.github.com/repos/folio-org/stripes-core/issues/events{/number}","events_url":"https://api.github.com/repos/folio-org/stripes-core/events","assignees_url":"https://api.github.com/repos/folio-org/stripes-core/assignees{/user}","branches_url":"https://api.github.com/repos/folio-org/stripes-core/branches{/branch}","tags_url":"https://api.github.com/repos/folio-org/stripes-core/tags","blobs_url":"https://api.github.com/repos/folio-org/stripes-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/folio-org/stripes-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/folio-org/stripes-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/folio-org/stripes-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/folio-org/stripes-core/statuses/{sha}","languages_url":"https://api.github.com/repos/folio-org/stripes-core/languages","stargazers_url":"https://api.github.com/repos/folio-org/stripes-core/stargazers","contributors_url":"https://api.github.com/repos/folio-org/stripes-core/contributors","subscribers_url":"https://api.github.com/repos/folio-org/stripes-core/subscribers","subscription_url":"https://api.github.com/repos/folio-org/stripes-core/subscription","commits_url":"https://api.github.com/repos/folio-org/stripes-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/folio-org/stripes-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/folio-org/stripes-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/folio-org/stripes-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/folio-org/stripes-core/contents/{+path}","compare_url":"https://api.github.com/repos/folio-org/stripes-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/folio-org/stripes-core/merges","archive_url":"https://api.github.com/repos/folio-org/stripes-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/folio-org/stripes-core/downloads","issues_url":"https://api.github.com/repos/folio-org/stripes-core/issues{/number}","pulls_url":"https://api.github.com/repos/folio-org/stripes-core/pulls{/number}","milestones_url":"https://api.github.com/repos/folio-org/stripes-core/milestones{/number}","notifications_url":"https://api.github.com/repos/folio-org/stripes-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/folio-org/stripes-core/labels{/name}","releases_url":"https://api.github.com/repos/folio-org/stripes-core/releases{/id}","deployments_url":"https://api.github.com/repos/folio-org/stripes-core/deployments","created_at":"2016-10-25T01:15:59Z","updated_at":"2018-02-06T19:38:22Z","pushed_at":"2018-02-15T05:43:08Z","git_url":"git://github.com/folio-org/stripes-core.git","ssh_url":"git@github.com:folio-org/stripes-core.git","clone_url":"https://github.com/folio-org/stripes-core.git","svn_url":"https://github.com/folio-org/stripes-core","homepage":null,"size":1592,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":13,"open_issues":2,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/folio-org/stripes-core/pulls/206"},"html":{"href":"https://github.com/folio-org/stripes-core/pull/206"},"issue":{"href":"https://api.github.com/repos/folio-org/stripes-core/issues/206"},"comments":{"href":"https://api.github.com/repos/folio-org/stripes-core/issues/206/comments"},"review_comments":{"href":"https://api.github.com/repos/folio-org/stripes-core/pulls/206/comments"},"review_comment":{"href":"https://api.github.com/repos/folio-org/stripes-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/folio-org/stripes-core/pulls/206/commits"},"statuses":{"href":"https://api.github.com/repos/folio-org/stripes-core/statuses/87daa1630d299614c598eb23c217a4fbf3df60e5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rasmuswoelk"}}