{"action":"created","issue":{"url":"https://api.github.com/repos/LucCoiffier/DSS/issues/32","repository_url":"https://api.github.com/repos/LucCoiffier/DSS","labels_url":"https://api.github.com/repos/LucCoiffier/DSS/issues/32/labels{/name}","comments_url":"https://api.github.com/repos/LucCoiffier/DSS/issues/32/comments","events_url":"https://api.github.com/repos/LucCoiffier/DSS/issues/32/events","html_url":"https://github.com/LucCoiffier/DSS/issues/32","id":326560314,"number":32,"title":"Windows XP Support","user":{"login":"MartinDrab","id":14164315,"avatar_url":"https://avatars3.githubusercontent.com/u/14164315?v=4","gravatar_id":"","url":"https://api.github.com/users/MartinDrab","html_url":"https://github.com/MartinDrab","followers_url":"https://api.github.com/users/MartinDrab/followers","following_url":"https://api.github.com/users/MartinDrab/following{/other_user}","gists_url":"https://api.github.com/users/MartinDrab/gists{/gist_id}","starred_url":"https://api.github.com/users/MartinDrab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartinDrab/subscriptions","organizations_url":"https://api.github.com/users/MartinDrab/orgs","repos_url":"https://api.github.com/users/MartinDrab/repos","events_url":"https://api.github.com/users/MartinDrab/events{/privacy}","received_events_url":"https://api.github.com/users/MartinDrab/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-05-25T15:04:03Z","updated_at":"2018-05-27T15:34:53Z","closed_at":"2018-05-27T15:34:53Z","author_association":"NONE","body":"Hello,\r\n\r\nactually, this is not a real issue (maybe, sending an e-mail would be more appropriate in this case, however, I seem not to be able to find one, so I decided to create an issue.\r\n\r\nA close relative of mine needed to run DSS on a machine with Windows XP. I decided to port DSS to thsi system and I seem to be successful so far. Code modifications related to this case are relatively insignifficant. I would create a pull request for this, however, I had to make several other changes:\r\n* I had to do some small modifications to compile the VS solution on my machine.\r\n* Since the system on the target machine is quite out-dated (and XP updates are no longer being shipped for XP home users, with several exceptions), I had to link DSS' executables statically because I had been unable to install necessary redistributable packages or use the runtime and MFC DLL(s). Of couse, it is not a problem to change the linking to dynamic again.\r\n* Because of the previous point, I included sources of external libraries, such as zlib, in my DSS fork. They needed to be linked statically with the runtime too.\r\n* I changed the structure of existing projects a bit (e.g. exporting common settings to a property sheet file, moving public headers of the libraries to an include directory global for all projects).\r\n* I changed the platform toolset to \"Visual Studio 2017 – WIndows XP\".\r\n\r\nThe fork may be found on my Gihtub. If you were interested in somewhat merging my changes to your repository, I would be glad to help. I will probably make some changes, since my fork was tested in the Win32 | Release configuration settings only, however, that should be minor ones. In any case, I plan to keep the XP support as long as possible/necessary.\r\n\r\nMartin\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/LucCoiffier/DSS/issues/comments/392340066","html_url":"https://github.com/LucCoiffier/DSS/issues/32#issuecomment-392340066","issue_url":"https://api.github.com/repos/LucCoiffier/DSS/issues/32","id":392340066,"user":{"login":"perdrix52","id":20211762,"avatar_url":"https://avatars0.githubusercontent.com/u/20211762?v=4","gravatar_id":"","url":"https://api.github.com/users/perdrix52","html_url":"https://github.com/perdrix52","followers_url":"https://api.github.com/users/perdrix52/followers","following_url":"https://api.github.com/users/perdrix52/following{/other_user}","gists_url":"https://api.github.com/users/perdrix52/gists{/gist_id}","starred_url":"https://api.github.com/users/perdrix52/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perdrix52/subscriptions","organizations_url":"https://api.github.com/users/perdrix52/orgs","repos_url":"https://api.github.com/users/perdrix52/repos","events_url":"https://api.github.com/users/perdrix52/events{/privacy}","received_events_url":"https://api.github.com/users/perdrix52/received_events","type":"User","site_admin":false},"created_at":"2018-05-27T15:34:53Z","updated_at":"2018-05-27T15:34:53Z","author_association":"COLLABORATOR","body":"We've discussed this a some length and have decided that we don't wish to support XP.  We of course don't object you you maintaining a fork that does.  So I'm closing this issue."}}
{"actor":{"display_login":"perdrix52"}}