{"action":"created","issue":{"url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/3556","repository_url":"https://api.github.com/repos/input-output-hk/cardano-sl","labels_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/3556/labels{/name}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/3556/comments","events_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/3556/events","html_url":"https://github.com/input-output-hk/cardano-sl/pull/3556","id":357875624,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNzg0OTE4","number":3556,"title":"[release/1.3.1] [CO-354] Add `RequiresNetworkMagic` and modify `ProtocolMagic`","user":{"login":"intricate","id":19835357,"node_id":"MDQ6VXNlcjE5ODM1MzU3","avatar_url":"https://avatars1.githubusercontent.com/u/19835357?v=4","gravatar_id":"","url":"https://api.github.com/users/intricate","html_url":"https://github.com/intricate","followers_url":"https://api.github.com/users/intricate/followers","following_url":"https://api.github.com/users/intricate/following{/other_user}","gists_url":"https://api.github.com/users/intricate/gists{/gist_id}","starred_url":"https://api.github.com/users/intricate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intricate/subscriptions","organizations_url":"https://api.github.com/users/intricate/orgs","repos_url":"https://api.github.com/users/intricate/repos","events_url":"https://api.github.com/users/intricate/events{/privacy}","received_events_url":"https://api.github.com/users/intricate/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"mhuesch","id":1151946,"node_id":"MDQ6VXNlcjExNTE5NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/1151946?v=4","gravatar_id":"","url":"https://api.github.com/users/mhuesch","html_url":"https://github.com/mhuesch","followers_url":"https://api.github.com/users/mhuesch/followers","following_url":"https://api.github.com/users/mhuesch/following{/other_user}","gists_url":"https://api.github.com/users/mhuesch/gists{/gist_id}","starred_url":"https://api.github.com/users/mhuesch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhuesch/subscriptions","organizations_url":"https://api.github.com/users/mhuesch/orgs","repos_url":"https://api.github.com/users/mhuesch/repos","events_url":"https://api.github.com/users/mhuesch/events{/privacy}","received_events_url":"https://api.github.com/users/mhuesch/received_events","type":"User","site_admin":false},"assignees":[{"login":"mhuesch","id":1151946,"node_id":"MDQ6VXNlcjExNTE5NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/1151946?v=4","gravatar_id":"","url":"https://api.github.com/users/mhuesch","html_url":"https://github.com/mhuesch","followers_url":"https://api.github.com/users/mhuesch/followers","following_url":"https://api.github.com/users/mhuesch/following{/other_user}","gists_url":"https://api.github.com/users/mhuesch/gists{/gist_id}","starred_url":"https://api.github.com/users/mhuesch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhuesch/subscriptions","organizations_url":"https://api.github.com/users/mhuesch/orgs","repos_url":"https://api.github.com/users/mhuesch/repos","events_url":"https://api.github.com/users/mhuesch/events{/privacy}","received_events_url":"https://api.github.com/users/mhuesch/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-09-07T00:21:17Z","updated_at":"2018-09-07T15:50:58Z","closed_at":"2018-09-07T15:41:17Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/3556","html_url":"https://github.com/input-output-hk/cardano-sl/pull/3556","diff_url":"https://github.com/input-output-hk/cardano-sl/pull/3556.diff","patch_url":"https://github.com/input-output-hk/cardano-sl/pull/3556.patch"},"body":"## Description\r\n\r\nThis PR modifies the `ProtocolMagic` data structure and introduces new data types: `RequiresNetworkMagic` and `ProtocolMagicId` (a new type wrapper around an `Int32`). \r\n\r\n`ProtocolMagic` has been modified such that it consists of two fields: `getProtocolMagicId :: ProtocolMagicId` and `getRequiresNetworkMagic :: RequiresNetworkMagic`.\r\n\r\nThe  `goldenTestJSONDec` and `goldenTestCanonicalJSONDec` tests which were introduced in #3540 have assisted us in ensuring that we've maintained backwards compatibility in our implementation of `ProtocolMagic`.\r\n\r\n## Linked issue\r\n\r\n[https://iohk.myjetbrains.com/youtrack/issue/CO-354](https://iohk.myjetbrains.com/youtrack/issue/CO-354)\r\n## Type of change\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply and `~` in the ones that do not: -->\r\n- [ ] 🐞 Bug fix (non-breaking change which fixes an issue)\r\n- [x] 🛠 New feature (non-breaking change which adds functionality)\r\n- [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)\r\n- [ ] 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc\r\n- [ ] 🔨 New or improved tests for existing code\r\n- [ ] ⛑ git-flow chore (backport, hotfix, etc)\r\n\r\n## Developer checklist\r\n<!--- A mental checklist for the developer submitting the PR. Put an `x` in all the boxes that apply and `~` in the ones that do not: --->\r\n- [x] I have read the [style guide](https://github.com/input-output-hk/cardano-sl/blob/develop/docs/style-guide.md) document, and my code follows the code style of this project.\r\n- [ ] If my code deals with exceptions, it follows the [guidelines](https://github.com/input-output-hk/cardano-sl/blob/develop/docs/exceptions.md).\r\n- [ ] I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on [cardanodocs.com](https://github.com/input-output-hk/cardanodocs.com), amending the inline [Haddock](https://www.haskell.org/haddock/) comments, any relevant README file or one of the document listed in the [docs](https://github.com/input-output-hk/cardano-sl/tree/develop/docs) directory.\r\n\r\n## Testing checklist\r\n<!-- If you aren't providing any tests as part of this PR, use this section to state clearly why. It needs to be a strong motivation and definitely the exception, not the rule. -->\r\n- [ ] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n\r\n## QA Steps\r\n<!--- Which are the steps needed to test this feature, if any? -->\r\n\r\n## Screenshots (if available)\r\n<!--- Upload a GIF, an asciinema video or an image demoing the feature -->\r\n"},"comment":{"url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/comments/419483075","html_url":"https://github.com/input-output-hk/cardano-sl/pull/3556#issuecomment-419483075","issue_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/3556","id":419483075,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTQ4MzA3NQ==","user":{"login":"mhuesch","id":1151946,"node_id":"MDQ6VXNlcjExNTE5NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/1151946?v=4","gravatar_id":"","url":"https://api.github.com/users/mhuesch","html_url":"https://github.com/mhuesch","followers_url":"https://api.github.com/users/mhuesch/followers","following_url":"https://api.github.com/users/mhuesch/following{/other_user}","gists_url":"https://api.github.com/users/mhuesch/gists{/gist_id}","starred_url":"https://api.github.com/users/mhuesch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhuesch/subscriptions","organizations_url":"https://api.github.com/users/mhuesch/orgs","repos_url":"https://api.github.com/users/mhuesch/repos","events_url":"https://api.github.com/users/mhuesch/events{/privacy}","received_events_url":"https://api.github.com/users/mhuesch/received_events","type":"User","site_admin":false},"created_at":"2018-09-07T15:50:58Z","updated_at":"2018-09-07T15:50:58Z","author_association":"CONTRIBUTOR","body":"@ruhatch @intricate For better or worse, we began most of this work on `develop` and then cherry-picked it over to `release/1.3.1`. So we've already experienced >=1/2 of the pain of merging 😅 and it shouldn't be too bad to get this over to `develop`. The harder part is convincing ourselves that the code does the same thing 🤔 "}}
{"actor":{"display_login":"mhuesch"}}