{"action":"created","issue":{"url":"https://api.github.com/repos/netty/netty/issues/7731","repository_url":"https://api.github.com/repos/netty/netty","labels_url":"https://api.github.com/repos/netty/netty/issues/7731/labels{/name}","comments_url":"https://api.github.com/repos/netty/netty/issues/7731/comments","events_url":"https://api.github.com/repos/netty/netty/issues/7731/events","html_url":"https://github.com/netty/netty/pull/7731","id":298195845,"number":7731,"title":"Fix Snappy decoding of large 2-byte literal lengths and copy offsets","user":{"login":"dnault","id":9012551,"avatar_url":"https://avatars0.githubusercontent.com/u/9012551?v=4","gravatar_id":"","url":"https://api.github.com/users/dnault","html_url":"https://github.com/dnault","followers_url":"https://api.github.com/users/dnault/followers","following_url":"https://api.github.com/users/dnault/following{/other_user}","gists_url":"https://api.github.com/users/dnault/gists{/gist_id}","starred_url":"https://api.github.com/users/dnault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnault/subscriptions","organizations_url":"https://api.github.com/users/dnault/orgs","repos_url":"https://api.github.com/users/dnault/repos","events_url":"https://api.github.com/users/dnault/events{/privacy}","received_events_url":"https://api.github.com/users/dnault/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-02-19T08:39:48Z","updated_at":"2018-02-20T06:49:11Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/netty/netty/pulls/7731","html_url":"https://github.com/netty/netty/pull/7731","diff_url":"https://github.com/netty/netty/pull/7731.diff","patch_url":"https://github.com/netty/netty/pull/7731.patch"},"body":"Motivation:\r\n\r\nThe Snappy decoder was failing on valid inputs containing literals\r\nwith 2-byte lengths > 0x8000 or copies with 2-byte offsets >= 0x8000.\r\n\r\nThe decoder was also enforcing an artificially low offset limit of\r\n0x7FFF, something the Snappy format description advises against,\r\nand which prevents decoding valid inputs generated by other encoders.\r\n\r\nModifications:\r\n\r\nInterpret 2-byte literal lengths and 2-byte copy offsets as unsigned\r\nshorts, in accordance with the format description and reference\r\nimplementation.\r\n\r\nAllow any positive offset value. Throw an appropriate exception\r\nfor negative values (which can theoretically occur due to arithmetic\r\noverflow on 4-byte offsets, but are unlikely to occur in the wild).\r\n\r\nResult:\r\n\r\nThe Snappy decoder can handle valid inputs that previously caused\r\nit to throw exceptions.\r\n"},"comment":{"url":"https://api.github.com/repos/netty/netty/issues/comments/366882860","html_url":"https://github.com/netty/netty/pull/7731#issuecomment-366882860","issue_url":"https://api.github.com/repos/netty/netty/issues/7731","id":366882860,"user":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars3.githubusercontent.com/u/439362?v=4","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"created_at":"2018-02-20T06:49:11Z","updated_at":"2018-02-20T06:49:11Z","author_association":"OWNER","body":"@lw346 can you have a look ? Also @idelpivnitskiy "}}
{"actor":{"display_login":"normanmaurer"}}