{"action":"created","comment":{"url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/pulls/comments/243296078","pull_request_review_id":187025644,"id":243296078,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzI5NjA3OA==","diff_hunk":"@@ -316,25 +324,42 @@ int adev_open_output_stream(struct audio_hw_device *dev,\n         return -EINVAL;\n     }\n     /* check requested device */\n-    /* TODO we should handle only devices described in XML configuration and \"default\" one */\n     if ((devices & AUDIO_DEVICE_BIT_IN) != 0) {\n         ALOGE(\"Failed. Incorrect device type. -EINVAL\");\n         *stream_out = NULL;\n         pthread_mutex_unlock(&xdev->lock);\n         return -EINVAL;\n     }\n \n-    /* TODO define card_id and dev_id for stream, using provided parameters:\n-       devices, flags, address, source */\n+    /* For now we have one card, so card id is always constant */\n+    /* Get device id. We expect (same as parser in car audio service)\n+     * that address has format \"busX_%s\" */\n+    if (sscanf(address, \"bus%u\", &dev_id) != 1) {\n+        ALOGE(\"Address has not supported format.\");","path":"device.c","position":127,"original_position":127,"commit_id":"8d6e1332ff784139a64fb1a6ecf319cbd12c5aa2","original_commit_id":"8d6e1332ff784139a64fb1a6ecf319cbd12c5aa2","user":{"login":"andr2000","id":827874,"node_id":"MDQ6VXNlcjgyNzg3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/827874?v=4","gravatar_id":"","url":"https://api.github.com/users/andr2000","html_url":"https://github.com/andr2000","followers_url":"https://api.github.com/users/andr2000/followers","following_url":"https://api.github.com/users/andr2000/following{/other_user}","gists_url":"https://api.github.com/users/andr2000/gists{/gist_id}","starred_url":"https://api.github.com/users/andr2000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andr2000/subscriptions","organizations_url":"https://api.github.com/users/andr2000/orgs","repos_url":"https://api.github.com/users/andr2000/repos","events_url":"https://api.github.com/users/andr2000/events{/privacy}","received_events_url":"https://api.github.com/users/andr2000/received_events","type":"User","site_admin":false},"body":"I would change wording here to be more... precise?","created_at":"2018-12-20T14:45:15Z","updated_at":"2018-12-20T14:52:29Z","html_url":"https://github.com/xen-troops/android_vendor_xen_audio/pull/3#discussion_r243296078","pull_request_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/pulls/3","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/pulls/comments/243296078"},"html":{"href":"https://github.com/xen-troops/android_vendor_xen_audio/pull/3#discussion_r243296078"},"pull_request":{"href":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/pulls/3","id":239841969,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5ODQxOTY5","html_url":"https://github.com/xen-troops/android_vendor_xen_audio/pull/3","diff_url":"https://github.com/xen-troops/android_vendor_xen_audio/pull/3.diff","patch_url":"https://github.com/xen-troops/android_vendor_xen_audio/pull/3.patch","issue_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/issues/3","number":3,"state":"open","locked":false,"title":"Support for multiple output devices","user":{"login":"rshym","id":42776496,"node_id":"MDQ6VXNlcjQyNzc2NDk2","avatar_url":"https://avatars2.githubusercontent.com/u/42776496?v=4","gravatar_id":"","url":"https://api.github.com/users/rshym","html_url":"https://github.com/rshym","followers_url":"https://api.github.com/users/rshym/followers","following_url":"https://api.github.com/users/rshym/following{/other_user}","gists_url":"https://api.github.com/users/rshym/gists{/gist_id}","starred_url":"https://api.github.com/users/rshym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rshym/subscriptions","organizations_url":"https://api.github.com/users/rshym/orgs","repos_url":"https://api.github.com/users/rshym/repos","events_url":"https://api.github.com/users/rshym/events{/privacy}","received_events_url":"https://api.github.com/users/rshym/received_events","type":"User","site_admin":false},"body":"NOTE: This have to merged only after merge of pull request 114 to meta-xt-prod-devel.\r\n\r\nProvides support for multiple output devices.\r\nClean up some debug messages.","created_at":"2018-12-19T13:48:16Z","updated_at":"2018-12-20T14:52:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3fba018bbfb4d2d9d0f1f1dafeaae5d2560cbda7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"arminn","id":545298,"node_id":"MDQ6VXNlcjU0NTI5OA==","avatar_url":"https://avatars3.githubusercontent.com/u/545298?v=4","gravatar_id":"","url":"https://api.github.com/users/arminn","html_url":"https://github.com/arminn","followers_url":"https://api.github.com/users/arminn/followers","following_url":"https://api.github.com/users/arminn/following{/other_user}","gists_url":"https://api.github.com/users/arminn/gists{/gist_id}","starred_url":"https://api.github.com/users/arminn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arminn/subscriptions","organizations_url":"https://api.github.com/users/arminn/orgs","repos_url":"https://api.github.com/users/arminn/repos","events_url":"https://api.github.com/users/arminn/events{/privacy}","received_events_url":"https://api.github.com/users/arminn/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/pulls/3/commits","review_comments_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/pulls/3/comments","review_comment_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/issues/3/comments","statuses_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/statuses/8d6e1332ff784139a64fb1a6ecf319cbd12c5aa2","head":{"label":"rshym:mr_support_multiple_devices","ref":"mr_support_multiple_devices","sha":"8d6e1332ff784139a64fb1a6ecf319cbd12c5aa2","user":{"login":"rshym","id":42776496,"node_id":"MDQ6VXNlcjQyNzc2NDk2","avatar_url":"https://avatars2.githubusercontent.com/u/42776496?v=4","gravatar_id":"","url":"https://api.github.com/users/rshym","html_url":"https://github.com/rshym","followers_url":"https://api.github.com/users/rshym/followers","following_url":"https://api.github.com/users/rshym/following{/other_user}","gists_url":"https://api.github.com/users/rshym/gists{/gist_id}","starred_url":"https://api.github.com/users/rshym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rshym/subscriptions","organizations_url":"https://api.github.com/users/rshym/orgs","repos_url":"https://api.github.com/users/rshym/repos","events_url":"https://api.github.com/users/rshym/events{/privacy}","received_events_url":"https://api.github.com/users/rshym/received_events","type":"User","site_admin":false},"repo":{"id":159684603,"node_id":"MDEwOlJlcG9zaXRvcnkxNTk2ODQ2MDM=","name":"android_vendor_xen_audio","full_name":"rshym/android_vendor_xen_audio","private":false,"owner":{"login":"rshym","id":42776496,"node_id":"MDQ6VXNlcjQyNzc2NDk2","avatar_url":"https://avatars2.githubusercontent.com/u/42776496?v=4","gravatar_id":"","url":"https://api.github.com/users/rshym","html_url":"https://github.com/rshym","followers_url":"https://api.github.com/users/rshym/followers","following_url":"https://api.github.com/users/rshym/following{/other_user}","gists_url":"https://api.github.com/users/rshym/gists{/gist_id}","starred_url":"https://api.github.com/users/rshym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rshym/subscriptions","organizations_url":"https://api.github.com/users/rshym/orgs","repos_url":"https://api.github.com/users/rshym/repos","events_url":"https://api.github.com/users/rshym/events{/privacy}","received_events_url":"https://api.github.com/users/rshym/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rshym/android_vendor_xen_audio","description":null,"fork":true,"url":"https://api.github.com/repos/rshym/android_vendor_xen_audio","forks_url":"https://api.github.com/repos/rshym/android_vendor_xen_audio/forks","keys_url":"https://api.github.com/repos/rshym/android_vendor_xen_audio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rshym/android_vendor_xen_audio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rshym/android_vendor_xen_audio/teams","hooks_url":"https://api.github.com/repos/rshym/android_vendor_xen_audio/hooks","issue_events_url":"https://api.github.com/repos/rshym/android_vendor_xen_audio/issues/events{/number}","events_url":"https://api.github.com/repos/rshym/android_vendor_xen_audio/events","assignees_url":"https://api.github.com/repos/rshym/android_vendor_xen_audio/assignees{/user}","branches_url":"https://api.github.com/repos/rshym/android_vendor_xen_audio/branches{/branch}","tags_url":"https://api.github.com/repos/rshym/android_vendor_xen_audio/tags","blobs_url":"https://api.github.com/repos/rshym/android_vendor_xen_audio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rshym/android_vendor_xen_audio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rshym/android_vendor_xen_audio/git/refs{/sha}","trees_url":"https://api.github.com/repos/rshym/android_vendor_xen_audio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rshym/android_vendor_xen_audio/statuses/{sha}","languages_url":"https://api.github.com/repos/rshym/android_vendor_xen_audio/languages","stargazers_url":"https://api.github.com/repos/rshym/android_vendor_xen_audio/stargazers","contributors_url":"https://api.github.com/repos/rshym/android_vendor_xen_audio/contributors","subscribers_url":"https://api.github.com/repos/rshym/android_vendor_xen_audio/subscribers","subscription_url":"https://api.github.com/repos/rshym/android_vendor_xen_audio/subscription","commits_url":"https://api.github.com/repos/rshym/android_vendor_xen_audio/commits{/sha}","git_commits_url":"https://api.github.com/repos/rshym/android_vendor_xen_audio/git/commits{/sha}","comments_url":"https://api.github.com/repos/rshym/android_vendor_xen_audio/comments{/number}","issue_comment_url":"https://api.github.com/repos/rshym/android_vendor_xen_audio/issues/comments{/number}","contents_url":"https://api.github.com/repos/rshym/android_vendor_xen_audio/contents/{+path}","compare_url":"https://api.github.com/repos/rshym/android_vendor_xen_audio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rshym/android_vendor_xen_audio/merges","archive_url":"https://api.github.com/repos/rshym/android_vendor_xen_audio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rshym/android_vendor_xen_audio/downloads","issues_url":"https://api.github.com/repos/rshym/android_vendor_xen_audio/issues{/number}","pulls_url":"https://api.github.com/repos/rshym/android_vendor_xen_audio/pulls{/number}","milestones_url":"https://api.github.com/repos/rshym/android_vendor_xen_audio/milestones{/number}","notifications_url":"https://api.github.com/repos/rshym/android_vendor_xen_audio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rshym/android_vendor_xen_audio/labels{/name}","releases_url":"https://api.github.com/repos/rshym/android_vendor_xen_audio/releases{/id}","deployments_url":"https://api.github.com/repos/rshym/android_vendor_xen_audio/deployments","created_at":"2018-11-29T15:09:10Z","updated_at":"2018-12-14T11:51:44Z","pushed_at":"2018-12-19T16:13:24Z","git_url":"git://github.com/rshym/android_vendor_xen_audio.git","ssh_url":"git@github.com:rshym/android_vendor_xen_audio.git","clone_url":"https://github.com/rshym/android_vendor_xen_audio.git","svn_url":"https://github.com/rshym/android_vendor_xen_audio","homepage":null,"size":58,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"android-9.0.0_r3-xt0.2"}},"base":{"label":"xen-troops:android-9.0.0_r3-xt0.2","ref":"android-9.0.0_r3-xt0.2","sha":"abf69e124e7ad3b54d52f112808942c2115cf953","user":{"login":"xen-troops","id":22070357,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDcwMzU3","avatar_url":"https://avatars1.githubusercontent.com/u/22070357?v=4","gravatar_id":"","url":"https://api.github.com/users/xen-troops","html_url":"https://github.com/xen-troops","followers_url":"https://api.github.com/users/xen-troops/followers","following_url":"https://api.github.com/users/xen-troops/following{/other_user}","gists_url":"https://api.github.com/users/xen-troops/gists{/gist_id}","starred_url":"https://api.github.com/users/xen-troops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xen-troops/subscriptions","organizations_url":"https://api.github.com/users/xen-troops/orgs","repos_url":"https://api.github.com/users/xen-troops/repos","events_url":"https://api.github.com/users/xen-troops/events{/privacy}","received_events_url":"https://api.github.com/users/xen-troops/received_events","type":"Organization","site_admin":false},"repo":{"id":159505587,"node_id":"MDEwOlJlcG9zaXRvcnkxNTk1MDU1ODc=","name":"android_vendor_xen_audio","full_name":"xen-troops/android_vendor_xen_audio","private":false,"owner":{"login":"xen-troops","id":22070357,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDcwMzU3","avatar_url":"https://avatars1.githubusercontent.com/u/22070357?v=4","gravatar_id":"","url":"https://api.github.com/users/xen-troops","html_url":"https://github.com/xen-troops","followers_url":"https://api.github.com/users/xen-troops/followers","following_url":"https://api.github.com/users/xen-troops/following{/other_user}","gists_url":"https://api.github.com/users/xen-troops/gists{/gist_id}","starred_url":"https://api.github.com/users/xen-troops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xen-troops/subscriptions","organizations_url":"https://api.github.com/users/xen-troops/orgs","repos_url":"https://api.github.com/users/xen-troops/repos","events_url":"https://api.github.com/users/xen-troops/events{/privacy}","received_events_url":"https://api.github.com/users/xen-troops/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/xen-troops/android_vendor_xen_audio","description":null,"fork":false,"url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio","forks_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/forks","keys_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/teams","hooks_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/hooks","issue_events_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/issues/events{/number}","events_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/events","assignees_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/assignees{/user}","branches_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/branches{/branch}","tags_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/tags","blobs_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/git/refs{/sha}","trees_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/statuses/{sha}","languages_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/languages","stargazers_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/stargazers","contributors_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/contributors","subscribers_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/subscribers","subscription_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/subscription","commits_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/commits{/sha}","git_commits_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/git/commits{/sha}","comments_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/comments{/number}","issue_comment_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/issues/comments{/number}","contents_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/contents/{+path}","compare_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/merges","archive_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/downloads","issues_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/issues{/number}","pulls_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/pulls{/number}","milestones_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/milestones{/number}","notifications_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/labels{/name}","releases_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/releases{/id}","deployments_url":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/deployments","created_at":"2018-11-28T13:22:28Z","updated_at":"2018-12-14T11:42:59Z","pushed_at":"2018-12-19T13:48:17Z","git_url":"git://github.com/xen-troops/android_vendor_xen_audio.git","ssh_url":"git@github.com:xen-troops/android_vendor_xen_audio.git","clone_url":"https://github.com/xen-troops/android_vendor_xen_audio.git","svn_url":"https://github.com/xen-troops/android_vendor_xen_audio","homepage":null,"size":44,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":1,"watchers":0,"default_branch":"android-9.0.0_r3-xt0.2"}},"_links":{"self":{"href":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/pulls/3"},"html":{"href":"https://github.com/xen-troops/android_vendor_xen_audio/pull/3"},"issue":{"href":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/issues/3"},"comments":{"href":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/xen-troops/android_vendor_xen_audio/statuses/8d6e1332ff784139a64fb1a6ecf319cbd12c5aa2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"andr2000"}}