{"action":"created","comment":{"url":"https://api.github.com/repos/pvlib/pvlib-python/pulls/comments/168594004","pull_request_review_id":96989370,"id":168594004,"diff_hunk":"@@ -138,7 +138,7 @@ Decomposing and combining irradiance\n    irradiance.aoi_projection\n    irradiance.poa_horizontal_ratio\n    irradiance.beam_component\n-   irradiance.globalinplane\n+   irradiance.poa_components\n    irradiance.grounddiffuse","path":"docs/sphinx/source/api.rst","position":6,"original_position":6,"commit_id":"e88458d0605262d462a0b4bc34243d02b5ef1769","original_commit_id":"e88458d0605262d462a0b4bc34243d02b5ef1769","user":{"login":"thunderfish24","id":1125363,"avatar_url":"https://avatars3.githubusercontent.com/u/1125363?v=4","gravatar_id":"","url":"https://api.github.com/users/thunderfish24","html_url":"https://github.com/thunderfish24","followers_url":"https://api.github.com/users/thunderfish24/followers","following_url":"https://api.github.com/users/thunderfish24/following{/other_user}","gists_url":"https://api.github.com/users/thunderfish24/gists{/gist_id}","starred_url":"https://api.github.com/users/thunderfish24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thunderfish24/subscriptions","organizations_url":"https://api.github.com/users/thunderfish24/orgs","repos_url":"https://api.github.com/users/thunderfish24/repos","events_url":"https://api.github.com/users/thunderfish24/events{/privacy}","received_events_url":"https://api.github.com/users/thunderfish24/received_events","type":"User","site_admin":false},"body":"Is this a good opportunity to make naming more consistent, such as `irradiance.extra_radiation` and `irradiance.ground_diffuse`?","created_at":"2018-02-15T20:10:45Z","updated_at":"2018-02-15T20:25:34Z","html_url":"https://github.com/pvlib/pvlib-python/pull/427#discussion_r168594004","pull_request_url":"https://api.github.com/repos/pvlib/pvlib-python/pulls/427","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pvlib/pvlib-python/pulls/comments/168594004"},"html":{"href":"https://github.com/pvlib/pvlib-python/pull/427#discussion_r168594004"},"pull_request":{"href":"https://api.github.com/repos/pvlib/pvlib-python/pulls/427"}}},"pull_request":{"url":"https://api.github.com/repos/pvlib/pvlib-python/pulls/427","id":168989239,"html_url":"https://github.com/pvlib/pvlib-python/pull/427","diff_url":"https://github.com/pvlib/pvlib-python/pull/427.diff","patch_url":"https://github.com/pvlib/pvlib-python/pull/427.patch","issue_url":"https://api.github.com/repos/pvlib/pvlib-python/issues/427","number":427,"state":"open","locked":false,"title":"refactor total_irrad, globalinplane","user":{"login":"wholmgren","id":4383303,"avatar_url":"https://avatars0.githubusercontent.com/u/4383303?v=4","gravatar_id":"","url":"https://api.github.com/users/wholmgren","html_url":"https://github.com/wholmgren","followers_url":"https://api.github.com/users/wholmgren/followers","following_url":"https://api.github.com/users/wholmgren/following{/other_user}","gists_url":"https://api.github.com/users/wholmgren/gists{/gist_id}","starred_url":"https://api.github.com/users/wholmgren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wholmgren/subscriptions","organizations_url":"https://api.github.com/users/wholmgren/orgs","repos_url":"https://api.github.com/users/wholmgren/repos","events_url":"https://api.github.com/users/wholmgren/events{/privacy}","received_events_url":"https://api.github.com/users/wholmgren/received_events","type":"User","site_admin":false},"body":" - [x] Closes #422 \r\n - [ ] Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests must pass on the TravisCI and Appveyor testing services.\r\n - [ ] Code quality and style is sufficient. Passes ``git diff upstream/master -u -- \"*.py\" | flake8 --diff`` and/or landscape.io linting service.\r\n - [ ] New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.\r\n - [ ] Updates entries to `docs/sphinx/source/api.rst` for API changes.\r\n - [ ] Adds description and name entries in the appropriate `docs/sphinx/source/whatsnew` file for all changes.\r\n\r\nThis PR implements the refactoring discussed in #422.\r\n\r\nI added a deprecation warning to globalinplane. \r\n\r\nWe could go ahead and change the name of total_irrad in this PR, but that would require changes to a few other parts of the library that I wasn't yet ready to commit to. If we do change it, we'd keep the old name until 0.6 and add a deprecation warning in the mean time (like I did for globalinplane).\r\n\r\nEverything here is open for discussion.","created_at":"2018-02-13T23:56:32Z","updated_at":"2018-02-15T20:25:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d22c3eaa2e5c57af279d54abda415eec062fe602","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":186023279,"url":"https://api.github.com/repos/pvlib/pvlib-python/labels/api","name":"api","color":"fef2c0","default":false}],"milestone":{"url":"https://api.github.com/repos/pvlib/pvlib-python/milestones/21","html_url":"https://github.com/pvlib/pvlib-python/milestone/21","labels_url":"https://api.github.com/repos/pvlib/pvlib-python/milestones/21/labels","id":2818759,"number":21,"title":"0.5.2","description":"","creator":{"login":"wholmgren","id":4383303,"avatar_url":"https://avatars0.githubusercontent.com/u/4383303?v=4","gravatar_id":"","url":"https://api.github.com/users/wholmgren","html_url":"https://github.com/wholmgren","followers_url":"https://api.github.com/users/wholmgren/followers","following_url":"https://api.github.com/users/wholmgren/following{/other_user}","gists_url":"https://api.github.com/users/wholmgren/gists{/gist_id}","starred_url":"https://api.github.com/users/wholmgren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wholmgren/subscriptions","organizations_url":"https://api.github.com/users/wholmgren/orgs","repos_url":"https://api.github.com/users/wholmgren/repos","events_url":"https://api.github.com/users/wholmgren/events{/privacy}","received_events_url":"https://api.github.com/users/wholmgren/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":16,"state":"open","created_at":"2017-10-06T00:08:03Z","updated_at":"2018-02-15T17:11:57Z","due_on":"2017-11-30T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/pvlib/pvlib-python/pulls/427/commits","review_comments_url":"https://api.github.com/repos/pvlib/pvlib-python/pulls/427/comments","review_comment_url":"https://api.github.com/repos/pvlib/pvlib-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pvlib/pvlib-python/issues/427/comments","statuses_url":"https://api.github.com/repos/pvlib/pvlib-python/statuses/e88458d0605262d462a0b4bc34243d02b5ef1769","head":{"label":"wholmgren:totalirrad","ref":"totalirrad","sha":"e88458d0605262d462a0b4bc34243d02b5ef1769","user":{"login":"wholmgren","id":4383303,"avatar_url":"https://avatars0.githubusercontent.com/u/4383303?v=4","gravatar_id":"","url":"https://api.github.com/users/wholmgren","html_url":"https://github.com/wholmgren","followers_url":"https://api.github.com/users/wholmgren/followers","following_url":"https://api.github.com/users/wholmgren/following{/other_user}","gists_url":"https://api.github.com/users/wholmgren/gists{/gist_id}","starred_url":"https://api.github.com/users/wholmgren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wholmgren/subscriptions","organizations_url":"https://api.github.com/users/wholmgren/orgs","repos_url":"https://api.github.com/users/wholmgren/repos","events_url":"https://api.github.com/users/wholmgren/events{/privacy}","received_events_url":"https://api.github.com/users/wholmgren/received_events","type":"User","site_admin":false},"repo":{"id":30896535,"name":"pvlib-python","full_name":"wholmgren/pvlib-python","owner":{"login":"wholmgren","id":4383303,"avatar_url":"https://avatars0.githubusercontent.com/u/4383303?v=4","gravatar_id":"","url":"https://api.github.com/users/wholmgren","html_url":"https://github.com/wholmgren","followers_url":"https://api.github.com/users/wholmgren/followers","following_url":"https://api.github.com/users/wholmgren/following{/other_user}","gists_url":"https://api.github.com/users/wholmgren/gists{/gist_id}","starred_url":"https://api.github.com/users/wholmgren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wholmgren/subscriptions","organizations_url":"https://api.github.com/users/wholmgren/orgs","repos_url":"https://api.github.com/users/wholmgren/repos","events_url":"https://api.github.com/users/wholmgren/events{/privacy}","received_events_url":"https://api.github.com/users/wholmgren/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wholmgren/pvlib-python","description":"The PV_LIB Toolbox provides a set of well-documented functions for simulating the performance of photovoltaic energy systems. The toolbox was developed at Sandia National Laboratories and it implements many of the models and methods developed at the Labs.","fork":true,"url":"https://api.github.com/repos/wholmgren/pvlib-python","forks_url":"https://api.github.com/repos/wholmgren/pvlib-python/forks","keys_url":"https://api.github.com/repos/wholmgren/pvlib-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wholmgren/pvlib-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wholmgren/pvlib-python/teams","hooks_url":"https://api.github.com/repos/wholmgren/pvlib-python/hooks","issue_events_url":"https://api.github.com/repos/wholmgren/pvlib-python/issues/events{/number}","events_url":"https://api.github.com/repos/wholmgren/pvlib-python/events","assignees_url":"https://api.github.com/repos/wholmgren/pvlib-python/assignees{/user}","branches_url":"https://api.github.com/repos/wholmgren/pvlib-python/branches{/branch}","tags_url":"https://api.github.com/repos/wholmgren/pvlib-python/tags","blobs_url":"https://api.github.com/repos/wholmgren/pvlib-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wholmgren/pvlib-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wholmgren/pvlib-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/wholmgren/pvlib-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wholmgren/pvlib-python/statuses/{sha}","languages_url":"https://api.github.com/repos/wholmgren/pvlib-python/languages","stargazers_url":"https://api.github.com/repos/wholmgren/pvlib-python/stargazers","contributors_url":"https://api.github.com/repos/wholmgren/pvlib-python/contributors","subscribers_url":"https://api.github.com/repos/wholmgren/pvlib-python/subscribers","subscription_url":"https://api.github.com/repos/wholmgren/pvlib-python/subscription","commits_url":"https://api.github.com/repos/wholmgren/pvlib-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/wholmgren/pvlib-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/wholmgren/pvlib-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/wholmgren/pvlib-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/wholmgren/pvlib-python/contents/{+path}","compare_url":"https://api.github.com/repos/wholmgren/pvlib-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wholmgren/pvlib-python/merges","archive_url":"https://api.github.com/repos/wholmgren/pvlib-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wholmgren/pvlib-python/downloads","issues_url":"https://api.github.com/repos/wholmgren/pvlib-python/issues{/number}","pulls_url":"https://api.github.com/repos/wholmgren/pvlib-python/pulls{/number}","milestones_url":"https://api.github.com/repos/wholmgren/pvlib-python/milestones{/number}","notifications_url":"https://api.github.com/repos/wholmgren/pvlib-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wholmgren/pvlib-python/labels{/name}","releases_url":"https://api.github.com/repos/wholmgren/pvlib-python/releases{/id}","deployments_url":"https://api.github.com/repos/wholmgren/pvlib-python/deployments","created_at":"2015-02-17T00:55:18Z","updated_at":"2016-01-12T23:57:03Z","pushed_at":"2018-02-15T18:57:16Z","git_url":"git://github.com/wholmgren/pvlib-python.git","ssh_url":"git@github.com:wholmgren/pvlib-python.git","clone_url":"https://github.com/wholmgren/pvlib-python.git","svn_url":"https://github.com/wholmgren/pvlib-python","homepage":"","size":75627,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"pvlib:master","ref":"master","sha":"8a4aacaa68d7339aab20f83205cc46eb9c47d3b5","user":{"login":"pvlib","id":11037261,"avatar_url":"https://avatars3.githubusercontent.com/u/11037261?v=4","gravatar_id":"","url":"https://api.github.com/users/pvlib","html_url":"https://github.com/pvlib","followers_url":"https://api.github.com/users/pvlib/followers","following_url":"https://api.github.com/users/pvlib/following{/other_user}","gists_url":"https://api.github.com/users/pvlib/gists{/gist_id}","starred_url":"https://api.github.com/users/pvlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvlib/subscriptions","organizations_url":"https://api.github.com/users/pvlib/orgs","repos_url":"https://api.github.com/users/pvlib/repos","events_url":"https://api.github.com/users/pvlib/events{/privacy}","received_events_url":"https://api.github.com/users/pvlib/received_events","type":"Organization","site_admin":false},"repo":{"id":30895522,"name":"pvlib-python","full_name":"pvlib/pvlib-python","owner":{"login":"pvlib","id":11037261,"avatar_url":"https://avatars3.githubusercontent.com/u/11037261?v=4","gravatar_id":"","url":"https://api.github.com/users/pvlib","html_url":"https://github.com/pvlib","followers_url":"https://api.github.com/users/pvlib/followers","following_url":"https://api.github.com/users/pvlib/following{/other_user}","gists_url":"https://api.github.com/users/pvlib/gists{/gist_id}","starred_url":"https://api.github.com/users/pvlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvlib/subscriptions","organizations_url":"https://api.github.com/users/pvlib/orgs","repos_url":"https://api.github.com/users/pvlib/repos","events_url":"https://api.github.com/users/pvlib/events{/privacy}","received_events_url":"https://api.github.com/users/pvlib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pvlib/pvlib-python","description":"A set of documented functions for simulating the performance of photovoltaic energy systems.","fork":false,"url":"https://api.github.com/repos/pvlib/pvlib-python","forks_url":"https://api.github.com/repos/pvlib/pvlib-python/forks","keys_url":"https://api.github.com/repos/pvlib/pvlib-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pvlib/pvlib-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pvlib/pvlib-python/teams","hooks_url":"https://api.github.com/repos/pvlib/pvlib-python/hooks","issue_events_url":"https://api.github.com/repos/pvlib/pvlib-python/issues/events{/number}","events_url":"https://api.github.com/repos/pvlib/pvlib-python/events","assignees_url":"https://api.github.com/repos/pvlib/pvlib-python/assignees{/user}","branches_url":"https://api.github.com/repos/pvlib/pvlib-python/branches{/branch}","tags_url":"https://api.github.com/repos/pvlib/pvlib-python/tags","blobs_url":"https://api.github.com/repos/pvlib/pvlib-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pvlib/pvlib-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pvlib/pvlib-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/pvlib/pvlib-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pvlib/pvlib-python/statuses/{sha}","languages_url":"https://api.github.com/repos/pvlib/pvlib-python/languages","stargazers_url":"https://api.github.com/repos/pvlib/pvlib-python/stargazers","contributors_url":"https://api.github.com/repos/pvlib/pvlib-python/contributors","subscribers_url":"https://api.github.com/repos/pvlib/pvlib-python/subscribers","subscription_url":"https://api.github.com/repos/pvlib/pvlib-python/subscription","commits_url":"https://api.github.com/repos/pvlib/pvlib-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/pvlib/pvlib-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/pvlib/pvlib-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/pvlib/pvlib-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/pvlib/pvlib-python/contents/{+path}","compare_url":"https://api.github.com/repos/pvlib/pvlib-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pvlib/pvlib-python/merges","archive_url":"https://api.github.com/repos/pvlib/pvlib-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pvlib/pvlib-python/downloads","issues_url":"https://api.github.com/repos/pvlib/pvlib-python/issues{/number}","pulls_url":"https://api.github.com/repos/pvlib/pvlib-python/pulls{/number}","milestones_url":"https://api.github.com/repos/pvlib/pvlib-python/milestones{/number}","notifications_url":"https://api.github.com/repos/pvlib/pvlib-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pvlib/pvlib-python/labels{/name}","releases_url":"https://api.github.com/repos/pvlib/pvlib-python/releases{/id}","deployments_url":"https://api.github.com/repos/pvlib/pvlib-python/deployments","created_at":"2015-02-17T00:21:33Z","updated_at":"2018-02-06T08:54:46Z","pushed_at":"2018-02-15T18:57:18Z","git_url":"git://github.com/pvlib/pvlib-python.git","ssh_url":"git@github.com:pvlib/pvlib-python.git","clone_url":"https://github.com/pvlib/pvlib-python.git","svn_url":"https://github.com/pvlib/pvlib-python","homepage":"","size":74476,"stargazers_count":120,"watchers_count":120,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":154,"mirror_url":null,"archived":false,"open_issues_count":67,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":154,"open_issues":67,"watchers":120,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pvlib/pvlib-python/pulls/427"},"html":{"href":"https://github.com/pvlib/pvlib-python/pull/427"},"issue":{"href":"https://api.github.com/repos/pvlib/pvlib-python/issues/427"},"comments":{"href":"https://api.github.com/repos/pvlib/pvlib-python/issues/427/comments"},"review_comments":{"href":"https://api.github.com/repos/pvlib/pvlib-python/pulls/427/comments"},"review_comment":{"href":"https://api.github.com/repos/pvlib/pvlib-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pvlib/pvlib-python/pulls/427/commits"},"statuses":{"href":"https://api.github.com/repos/pvlib/pvlib-python/statuses/e88458d0605262d462a0b4bc34243d02b5ef1769"}},"author_association":"OWNER"}}
{"actor":{"display_login":"thunderfish24"}}