{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments/204104816","pull_request_review_id":139130979,"id":204104816,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDEwNDgxNg==","diff_hunk":"@@ -542,6 +542,15 @@ func testClusterServiceClassClient(sType server.StorageType, client servicecatal\n \t\treturn fmt.Errorf(\"should have two ClusterServiceClasses, had %v ClusterServiceClasses\", len(serviceClasses.Items))\n \t}\n \n+\tserviceClasses, err = serviceClassClient.List(metav1.ListOptions{FieldSelector: \"metadata.name=\" + name})","path":"test/integration/clientset_test.go","position":4,"original_position":4,"commit_id":"ddc4ce1d989ffb86ca3937f8c0e5ac5e5a3a7c0c","original_commit_id":"ddc4ce1d989ffb86ca3937f8c0e5ac5e5a3a7c0c","user":{"login":"carolynvs","id":1368985,"node_id":"MDQ6VXNlcjEzNjg5ODU=","avatar_url":"https://avatars1.githubusercontent.com/u/1368985?v=4","gravatar_id":"","url":"https://api.github.com/users/carolynvs","html_url":"https://github.com/carolynvs","followers_url":"https://api.github.com/users/carolynvs/followers","following_url":"https://api.github.com/users/carolynvs/following{/other_user}","gists_url":"https://api.github.com/users/carolynvs/gists{/gist_id}","starred_url":"https://api.github.com/users/carolynvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carolynvs/subscriptions","organizations_url":"https://api.github.com/users/carolynvs/orgs","repos_url":"https://api.github.com/users/carolynvs/repos","events_url":"https://api.github.com/users/carolynvs/events{/privacy}","received_events_url":"https://api.github.com/users/carolynvs/received_events","type":"User","site_admin":false},"body":"Looks like we are missing existing tests for `ServiceClasses` and `ServicePlan` which were also modified in this PR. \r\n\r\nLet's use those existing tests in this file and add tests for these resources as well so that we can test all of your changes.","created_at":"2018-07-20T16:48:22Z","updated_at":"2018-07-20T16:49:17Z","html_url":"https://github.com/kubernetes-incubator/service-catalog/pull/2214#discussion_r204104816","pull_request_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/2214","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments/204104816"},"html":{"href":"https://github.com/kubernetes-incubator/service-catalog/pull/2214#discussion_r204104816"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/2214"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/2214","id":202518845,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNTE4ODQ1","html_url":"https://github.com/kubernetes-incubator/service-catalog/pull/2214","diff_url":"https://github.com/kubernetes-incubator/service-catalog/pull/2214.diff","patch_url":"https://github.com/kubernetes-incubator/service-catalog/pull/2214.patch","issue_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/2214","number":2214,"state":"open","locked":false,"title":"Ensure that ObjectMeta field selectors (e.g. name and namespace) can be used appropriately for all types","user":{"login":"jimmidyson","id":464659,"node_id":"MDQ6VXNlcjQ2NDY1OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/464659?v=4","gravatar_id":"","url":"https://api.github.com/users/jimmidyson","html_url":"https://github.com/jimmidyson","followers_url":"https://api.github.com/users/jimmidyson/followers","following_url":"https://api.github.com/users/jimmidyson/following{/other_user}","gists_url":"https://api.github.com/users/jimmidyson/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmidyson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmidyson/subscriptions","organizations_url":"https://api.github.com/users/jimmidyson/orgs","repos_url":"https://api.github.com/users/jimmidyson/repos","events_url":"https://api.github.com/users/jimmidyson/events{/privacy}","received_events_url":"https://api.github.com/users/jimmidyson/received_events","type":"User","site_admin":false},"body":"Noticed that the ObjectMeta fields `metadata.name` and `metadata.namespace` do not work as they haven't been registered in conversions.\n\nI also took the liberty of tidying up the fields methods in registry to make them consitent in their approach.","created_at":"2018-07-19T10:46:33Z","updated_at":"2018-07-20T16:49:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b8da87f8fb5b6b465d1ed287b3fee66fb3120c7e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jpeeler","id":834161,"node_id":"MDQ6VXNlcjgzNDE2MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/834161?v=4","gravatar_id":"","url":"https://api.github.com/users/jpeeler","html_url":"https://github.com/jpeeler","followers_url":"https://api.github.com/users/jpeeler/followers","following_url":"https://api.github.com/users/jpeeler/following{/other_user}","gists_url":"https://api.github.com/users/jpeeler/gists{/gist_id}","starred_url":"https://api.github.com/users/jpeeler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpeeler/subscriptions","organizations_url":"https://api.github.com/users/jpeeler/orgs","repos_url":"https://api.github.com/users/jpeeler/repos","events_url":"https://api.github.com/users/jpeeler/events{/privacy}","received_events_url":"https://api.github.com/users/jpeeler/received_events","type":"User","site_admin":false},{"login":"nilebox","id":6176360,"node_id":"MDQ6VXNlcjYxNzYzNjA=","avatar_url":"https://avatars0.githubusercontent.com/u/6176360?v=4","gravatar_id":"","url":"https://api.github.com/users/nilebox","html_url":"https://github.com/nilebox","followers_url":"https://api.github.com/users/nilebox/followers","following_url":"https://api.github.com/users/nilebox/following{/other_user}","gists_url":"https://api.github.com/users/nilebox/gists{/gist_id}","starred_url":"https://api.github.com/users/nilebox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nilebox/subscriptions","organizations_url":"https://api.github.com/users/nilebox/orgs","repos_url":"https://api.github.com/users/nilebox/repos","events_url":"https://api.github.com/users/nilebox/events{/privacy}","received_events_url":"https://api.github.com/users/nilebox/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":485046198,"node_id":"MDU6TGFiZWw0ODUwNDYxOTg=","url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"ededed","default":false},{"id":678335376,"node_id":"MDU6TGFiZWw2NzgzMzUzNzY=","url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/labels/size/M","name":"size/M","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/2214/commits","review_comments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/2214/comments","review_comment_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/2214/comments","statuses_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/statuses/ddc4ce1d989ffb86ca3937f8c0e5ac5e5a3a7c0c","head":{"label":"jimmidyson:fix-object-meta-field-selectors","ref":"fix-object-meta-field-selectors","sha":"ddc4ce1d989ffb86ca3937f8c0e5ac5e5a3a7c0c","user":{"login":"jimmidyson","id":464659,"node_id":"MDQ6VXNlcjQ2NDY1OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/464659?v=4","gravatar_id":"","url":"https://api.github.com/users/jimmidyson","html_url":"https://github.com/jimmidyson","followers_url":"https://api.github.com/users/jimmidyson/followers","following_url":"https://api.github.com/users/jimmidyson/following{/other_user}","gists_url":"https://api.github.com/users/jimmidyson/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmidyson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmidyson/subscriptions","organizations_url":"https://api.github.com/users/jimmidyson/orgs","repos_url":"https://api.github.com/users/jimmidyson/repos","events_url":"https://api.github.com/users/jimmidyson/events{/privacy}","received_events_url":"https://api.github.com/users/jimmidyson/received_events","type":"User","site_admin":false},"repo":{"id":140737465,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA3Mzc0NjU=","name":"service-catalog","full_name":"jimmidyson/service-catalog","owner":{"login":"jimmidyson","id":464659,"node_id":"MDQ6VXNlcjQ2NDY1OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/464659?v=4","gravatar_id":"","url":"https://api.github.com/users/jimmidyson","html_url":"https://github.com/jimmidyson","followers_url":"https://api.github.com/users/jimmidyson/followers","following_url":"https://api.github.com/users/jimmidyson/following{/other_user}","gists_url":"https://api.github.com/users/jimmidyson/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmidyson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmidyson/subscriptions","organizations_url":"https://api.github.com/users/jimmidyson/orgs","repos_url":"https://api.github.com/users/jimmidyson/repos","events_url":"https://api.github.com/users/jimmidyson/events{/privacy}","received_events_url":"https://api.github.com/users/jimmidyson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jimmidyson/service-catalog","description":"Consume services in Kubernetes using the Open Service Broker API","fork":true,"url":"https://api.github.com/repos/jimmidyson/service-catalog","forks_url":"https://api.github.com/repos/jimmidyson/service-catalog/forks","keys_url":"https://api.github.com/repos/jimmidyson/service-catalog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jimmidyson/service-catalog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jimmidyson/service-catalog/teams","hooks_url":"https://api.github.com/repos/jimmidyson/service-catalog/hooks","issue_events_url":"https://api.github.com/repos/jimmidyson/service-catalog/issues/events{/number}","events_url":"https://api.github.com/repos/jimmidyson/service-catalog/events","assignees_url":"https://api.github.com/repos/jimmidyson/service-catalog/assignees{/user}","branches_url":"https://api.github.com/repos/jimmidyson/service-catalog/branches{/branch}","tags_url":"https://api.github.com/repos/jimmidyson/service-catalog/tags","blobs_url":"https://api.github.com/repos/jimmidyson/service-catalog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jimmidyson/service-catalog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jimmidyson/service-catalog/git/refs{/sha}","trees_url":"https://api.github.com/repos/jimmidyson/service-catalog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jimmidyson/service-catalog/statuses/{sha}","languages_url":"https://api.github.com/repos/jimmidyson/service-catalog/languages","stargazers_url":"https://api.github.com/repos/jimmidyson/service-catalog/stargazers","contributors_url":"https://api.github.com/repos/jimmidyson/service-catalog/contributors","subscribers_url":"https://api.github.com/repos/jimmidyson/service-catalog/subscribers","subscription_url":"https://api.github.com/repos/jimmidyson/service-catalog/subscription","commits_url":"https://api.github.com/repos/jimmidyson/service-catalog/commits{/sha}","git_commits_url":"https://api.github.com/repos/jimmidyson/service-catalog/git/commits{/sha}","comments_url":"https://api.github.com/repos/jimmidyson/service-catalog/comments{/number}","issue_comment_url":"https://api.github.com/repos/jimmidyson/service-catalog/issues/comments{/number}","contents_url":"https://api.github.com/repos/jimmidyson/service-catalog/contents/{+path}","compare_url":"https://api.github.com/repos/jimmidyson/service-catalog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jimmidyson/service-catalog/merges","archive_url":"https://api.github.com/repos/jimmidyson/service-catalog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jimmidyson/service-catalog/downloads","issues_url":"https://api.github.com/repos/jimmidyson/service-catalog/issues{/number}","pulls_url":"https://api.github.com/repos/jimmidyson/service-catalog/pulls{/number}","milestones_url":"https://api.github.com/repos/jimmidyson/service-catalog/milestones{/number}","notifications_url":"https://api.github.com/repos/jimmidyson/service-catalog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jimmidyson/service-catalog/labels{/name}","releases_url":"https://api.github.com/repos/jimmidyson/service-catalog/releases{/id}","deployments_url":"https://api.github.com/repos/jimmidyson/service-catalog/deployments","created_at":"2018-07-12T16:16:47Z","updated_at":"2018-07-12T16:16:51Z","pushed_at":"2018-07-19T10:53:17Z","git_url":"git://github.com/jimmidyson/service-catalog.git","ssh_url":"git@github.com:jimmidyson/service-catalog.git","clone_url":"https://github.com/jimmidyson/service-catalog.git","svn_url":"https://github.com/jimmidyson/service-catalog","homepage":"","size":103551,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-incubator:master","ref":"master","sha":"3019df28499d3b318e16c5a78b4cef7c8391774a","user":{"login":"kubernetes-incubator","id":20862812,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODYyODEy","avatar_url":"https://avatars2.githubusercontent.com/u/20862812?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":68024288,"node_id":"MDEwOlJlcG9zaXRvcnk2ODAyNDI4OA==","name":"service-catalog","full_name":"kubernetes-incubator/service-catalog","owner":{"login":"kubernetes-incubator","id":20862812,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODYyODEy","avatar_url":"https://avatars2.githubusercontent.com/u/20862812?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes-incubator/service-catalog","description":"Consume services in Kubernetes using the Open Service Broker API","fork":false,"url":"https://api.github.com/repos/kubernetes-incubator/service-catalog","forks_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/forks","keys_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/teams","hooks_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/events","assignees_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/tags","blobs_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/languages","stargazers_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/subscription","commits_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/merges","archive_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/downloads","issues_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/deployments","created_at":"2016-09-12T15:58:39Z","updated_at":"2018-07-20T14:57:20Z","pushed_at":"2018-07-20T14:57:12Z","git_url":"git://github.com/kubernetes-incubator/service-catalog.git","ssh_url":"git@github.com:kubernetes-incubator/service-catalog.git","clone_url":"https://github.com/kubernetes-incubator/service-catalog.git","svn_url":"https://github.com/kubernetes-incubator/service-catalog","homepage":"","size":103629,"stargazers_count":559,"watchers_count":559,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":192,"mirror_url":null,"archived":false,"open_issues_count":246,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":192,"open_issues":246,"watchers":559,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/2214"},"html":{"href":"https://github.com/kubernetes-incubator/service-catalog/pull/2214"},"issue":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/2214"},"comments":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/2214/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/2214/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/2214/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/statuses/ddc4ce1d989ffb86ca3937f8c0e5ac5e5a3a7c0c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"carolynvs"}}