{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaLang/julia/issues/27249","repository_url":"https://api.github.com/repos/JuliaLang/julia","labels_url":"https://api.github.com/repos/JuliaLang/julia/issues/27249/labels{/name}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/27249/comments","events_url":"https://api.github.com/repos/JuliaLang/julia/issues/27249/events","html_url":"https://github.com/JuliaLang/julia/pull/27249","id":326239558,"number":27249,"title":"Finish breaking the decompositions: deprecate chol and chol!","user":{"login":"mbauman","id":154641,"avatar_url":"https://avatars0.githubusercontent.com/u/154641?v=4","gravatar_id":"","url":"https://api.github.com/users/mbauman","html_url":"https://github.com/mbauman","followers_url":"https://api.github.com/users/mbauman/followers","following_url":"https://api.github.com/users/mbauman/following{/other_user}","gists_url":"https://api.github.com/users/mbauman/gists{/gist_id}","starred_url":"https://api.github.com/users/mbauman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbauman/subscriptions","organizations_url":"https://api.github.com/users/mbauman/orgs","repos_url":"https://api.github.com/users/mbauman/repos","events_url":"https://api.github.com/users/mbauman/events{/privacy}","received_events_url":"https://api.github.com/users/mbauman/received_events","type":"User","site_admin":false},"labels":[{"id":514135802,"url":"https://api.github.com/repos/JuliaLang/julia/labels/deprecation","name":"deprecation","color":"c5def5","default":false},{"id":61807486,"url":"https://api.github.com/repos/JuliaLang/julia/labels/linear%20algebra","name":"linear algebra","color":"f2b3db","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-05-24T18:29:53Z","updated_at":"2018-05-25T20:55:58Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/27249","html_url":"https://github.com/JuliaLang/julia/pull/27249","diff_url":"https://github.com/JuliaLang/julia/pull/27249.diff","patch_url":"https://github.com/JuliaLang/julia/pull/27249.patch"},"body":"This branch simply rebases @fredrikekre's work on top of the work done in #27212.\r\n\r\nThere was a slight question about what to do with the `chol(::Number)` and `chol(::UniformScaling)` methods since we can't construct `Cholesky`s for those — I believe that using `sqrt` is just fine here and cannot construct a case where this simplification would change any existing support."},"comment":{"url":"https://api.github.com/repos/JuliaLang/julia/issues/comments/392184978","html_url":"https://github.com/JuliaLang/julia/pull/27249#issuecomment-392184978","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/27249","id":392184978,"user":{"login":"Sacha0","id":5799177,"avatar_url":"https://avatars0.githubusercontent.com/u/5799177?v=4","gravatar_id":"","url":"https://api.github.com/users/Sacha0","html_url":"https://github.com/Sacha0","followers_url":"https://api.github.com/users/Sacha0/followers","following_url":"https://api.github.com/users/Sacha0/following{/other_user}","gists_url":"https://api.github.com/users/Sacha0/gists{/gist_id}","starred_url":"https://api.github.com/users/Sacha0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sacha0/subscriptions","organizations_url":"https://api.github.com/users/Sacha0/orgs","repos_url":"https://api.github.com/users/Sacha0/repos","events_url":"https://api.github.com/users/Sacha0/events{/privacy}","received_events_url":"https://api.github.com/users/Sacha0/received_events","type":"User","site_admin":false},"created_at":"2018-05-25T20:55:58Z","updated_at":"2018-05-25T20:55:58Z","author_association":"MEMBER","body":"Observations from a chat with `@mbauman`: One troubling consideration is that multiple notions of matrix root exist for positive definite operators. Moreover, even fixing the definition of matrix root to traditional Cholesky factor, there remains a choice of factor: upper or lower by default? In other words, A == C'C or CC'?"}}
{"actor":{"display_login":"Sacha0"}}