{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-dubbo/issues/1873","repository_url":"https://api.github.com/repos/apache/incubator-dubbo","labels_url":"https://api.github.com/repos/apache/incubator-dubbo/issues/1873/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-dubbo/issues/1873/comments","events_url":"https://api.github.com/repos/apache/incubator-dubbo/issues/1873/events","html_url":"https://github.com/apache/incubator-dubbo/pull/1873","id":328424117,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxOTY0NzI4","number":1873,"title":"support proxy for provider side. #67","user":{"login":"diecui1202","id":1152291,"node_id":"MDQ6VXNlcjExNTIyOTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1152291?v=4","gravatar_id":"","url":"https://api.github.com/users/diecui1202","html_url":"https://github.com/diecui1202","followers_url":"https://api.github.com/users/diecui1202/followers","following_url":"https://api.github.com/users/diecui1202/following{/other_user}","gists_url":"https://api.github.com/users/diecui1202/gists{/gist_id}","starred_url":"https://api.github.com/users/diecui1202/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diecui1202/subscriptions","organizations_url":"https://api.github.com/users/diecui1202/orgs","repos_url":"https://api.github.com/users/diecui1202/repos","events_url":"https://api.github.com/users/diecui1202/events{/privacy}","received_events_url":"https://api.github.com/users/diecui1202/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-01T08:20:05Z","updated_at":"2018-06-01T09:08:27Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/incubator-dubbo/pulls/1873","html_url":"https://github.com/apache/incubator-dubbo/pull/1873","diff_url":"https://github.com/apache/incubator-dubbo/pull/1873.diff","patch_url":"https://github.com/apache/incubator-dubbo/pull/1873.patch"},"body":"## What is the purpose of the change\r\n\r\nSupport use custom proxy to generate invoker on provider side.\r\n\r\n## Brief changelog\r\n\r\n1. dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ServiceConfig.java\r\n2. Unit tests\r\n\r\n## Verifying this change\r\n\r\nAdd related test case.\r\n\r\nFollow this checklist to help us incorporate your contribution quickly and easily:\r\n\r\n- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.\r\n- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.\r\n- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.\r\n- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/alibaba/dubbo/tree/master/dubbo-test).\r\n- [ ] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.\r\n- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).\r\n"},"comment":{"url":"https://api.github.com/repos/apache/incubator-dubbo/issues/comments/393820750","html_url":"https://github.com/apache/incubator-dubbo/pull/1873#issuecomment-393820750","issue_url":"https://api.github.com/repos/apache/incubator-dubbo/issues/1873","id":393820750,"node_id":"MDEyOklzc3VlQ29tbWVudDM5MzgyMDc1MA==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-06-01T09:08:27Z","updated_at":"2018-06-01T09:08:27Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1873?src=pr&el=h1) Report\n> Merging [#1873](https://codecov.io/gh/apache/incubator-dubbo/pull/1873?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/e255f54be07c02b1031372aa2a6e8a83e94a60d6?src=pr&el=desc) will **increase** coverage by `0.02%`.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1873/graphs/tree.svg?token=VnEIkiFQT0&src=pr&width=650&height=150)](https://codecov.io/gh/apache/incubator-dubbo/pull/1873?src=pr&el=tree)\n\n```diff\n@@             Coverage Diff              @@\n##             master    #1873      +/-   ##\n============================================\n+ Coverage     42.49%   42.51%   +0.02%     \n- Complexity     4707     4713       +6     \n============================================\n  Files           646      646              \n  Lines         30680    30683       +3     \n  Branches       5390     5391       +1     \n============================================\n+ Hits          13037    13046       +9     \n+ Misses        15620    15617       -3     \n+ Partials       2023     2020       -3\n```\n\n\n| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1873?src=pr&el=tree) | Coverage Δ | Complexity Δ | |\n|---|---|---|---|\n| [...n/java/com/alibaba/dubbo/config/ServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1873/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvU2VydmljZUNvbmZpZy5qYXZh) | `47.44% <100%> (+0.83%)` | `62 <0> (+3)` | :arrow_up: |\n| [.../dubbo/monitor/support/AbstractMonitorFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1873/diff?src=pr&el=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWFwaS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL21vbml0b3Ivc3VwcG9ydC9BYnN0cmFjdE1vbml0b3JGYWN0b3J5LmphdmE=) | `84.09% <0%> (+2.27%)` | `6% <0%> (+1%)` | :arrow_up: |\n| [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1873/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvSW52b2tlVGVsbmV0SGFuZGxlci5qYXZh) | `55.69% <0%> (+3.79%)` | `13% <0%> (+2%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1873?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1873?src=pr&el=footer). Last update [e255f54...e146d32](https://codecov.io/gh/apache/incubator-dubbo/pull/1873?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}