{"action":"created","comment":{"url":"https://api.github.com/repos/llxff/coney/pulls/comments/239002237","pull_request_review_id":181677292,"id":239002237,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTAwMjIzNw==","diff_hunk":"@@ -9,7 +9,7 @@ defmodule Coney.ConsumerExecutor do\n   rescue\n     exception ->\n       if function_exported?(consumer, :error_happened, 3) do\n-        exception\n+        {exception, System.stacktrace()}","path":"lib/coney/consumer_executor.ex","position":5,"original_position":5,"commit_id":"c3de39969618dd811891a2a7eb5a9da216b9ed00","original_commit_id":"c3de39969618dd811891a2a7eb5a9da216b9ed00","user":{"login":"segaz2002","id":3873358,"node_id":"MDQ6VXNlcjM4NzMzNTg=","avatar_url":"https://avatars3.githubusercontent.com/u/3873358?v=4","gravatar_id":"","url":"https://api.github.com/users/segaz2002","html_url":"https://github.com/segaz2002","followers_url":"https://api.github.com/users/segaz2002/followers","following_url":"https://api.github.com/users/segaz2002/following{/other_user}","gists_url":"https://api.github.com/users/segaz2002/gists{/gist_id}","starred_url":"https://api.github.com/users/segaz2002/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/segaz2002/subscriptions","organizations_url":"https://api.github.com/users/segaz2002/orgs","repos_url":"https://api.github.com/users/segaz2002/repos","events_url":"https://api.github.com/users/segaz2002/events{/privacy}","received_events_url":"https://api.github.com/users/segaz2002/received_events","type":"User","site_admin":false},"body":"Perfect.","created_at":"2018-12-05T10:10:02Z","updated_at":"2018-12-05T10:10:03Z","html_url":"https://github.com/llxff/coney/pull/8#discussion_r239002237","pull_request_url":"https://api.github.com/repos/llxff/coney/pulls/8","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/llxff/coney/pulls/comments/239002237"},"html":{"href":"https://github.com/llxff/coney/pull/8#discussion_r239002237"},"pull_request":{"href":"https://api.github.com/repos/llxff/coney/pulls/8"}},"in_reply_to_id":238601536},"pull_request":{"url":"https://api.github.com/repos/llxff/coney/pulls/8","id":235738286,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1NzM4Mjg2","html_url":"https://github.com/llxff/coney/pull/8","diff_url":"https://github.com/llxff/coney/pull/8.diff","patch_url":"https://github.com/llxff/coney/pull/8.patch","issue_url":"https://api.github.com/repos/llxff/coney/issues/8","number":8,"state":"open","locked":false,"title":"Expose stacktrace along with the exemption in executor","user":{"login":"segaz2002","id":3873358,"node_id":"MDQ6VXNlcjM4NzMzNTg=","avatar_url":"https://avatars3.githubusercontent.com/u/3873358?v=4","gravatar_id":"","url":"https://api.github.com/users/segaz2002","html_url":"https://github.com/segaz2002","followers_url":"https://api.github.com/users/segaz2002/followers","following_url":"https://api.github.com/users/segaz2002/following{/other_user}","gists_url":"https://api.github.com/users/segaz2002/gists{/gist_id}","starred_url":"https://api.github.com/users/segaz2002/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/segaz2002/subscriptions","organizations_url":"https://api.github.com/users/segaz2002/orgs","repos_url":"https://api.github.com/users/segaz2002/repos","events_url":"https://api.github.com/users/segaz2002/events{/privacy}","received_events_url":"https://api.github.com/users/segaz2002/received_events","type":"User","site_admin":false},"body":"**Issue**\r\nAt the moment, the executor does not reveal the actual source of issue when an exemption is encountered within coney's executor and also there is no straight priviledge to accession `__STACKTRACE__` or `System.stacktrace/0` outside of rescue.\r\n\r\n**Solution**\r\nconvert the first parameter of `error_happend` callback to a tuple where the first element will be the exemption itself and the second element can be the stacktrace.\r\n\r\n**Benefit**\r\n- Makes error discovery faster\r\n- Better debugging, happy developer.","created_at":"2018-12-04T09:39:36Z","updated_at":"2018-12-05T10:10:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31113e715c2ffc8829fd2eb35a215a252390f2f7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":576208575,"node_id":"MDU6TGFiZWw1NzYyMDg1NzU=","url":"https://api.github.com/repos/llxff/coney/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/llxff/coney/pulls/8/commits","review_comments_url":"https://api.github.com/repos/llxff/coney/pulls/8/comments","review_comment_url":"https://api.github.com/repos/llxff/coney/pulls/comments{/number}","comments_url":"https://api.github.com/repos/llxff/coney/issues/8/comments","statuses_url":"https://api.github.com/repos/llxff/coney/statuses/c3de39969618dd811891a2a7eb5a9da216b9ed00","head":{"label":"segaz2002:error-friendly-coney","ref":"error-friendly-coney","sha":"c3de39969618dd811891a2a7eb5a9da216b9ed00","user":{"login":"segaz2002","id":3873358,"node_id":"MDQ6VXNlcjM4NzMzNTg=","avatar_url":"https://avatars3.githubusercontent.com/u/3873358?v=4","gravatar_id":"","url":"https://api.github.com/users/segaz2002","html_url":"https://github.com/segaz2002","followers_url":"https://api.github.com/users/segaz2002/followers","following_url":"https://api.github.com/users/segaz2002/following{/other_user}","gists_url":"https://api.github.com/users/segaz2002/gists{/gist_id}","starred_url":"https://api.github.com/users/segaz2002/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/segaz2002/subscriptions","organizations_url":"https://api.github.com/users/segaz2002/orgs","repos_url":"https://api.github.com/users/segaz2002/repos","events_url":"https://api.github.com/users/segaz2002/events{/privacy}","received_events_url":"https://api.github.com/users/segaz2002/received_events","type":"User","site_admin":false},"repo":{"id":160332898,"node_id":"MDEwOlJlcG9zaXRvcnkxNjAzMzI4OTg=","name":"coney","full_name":"segaz2002/coney","private":false,"owner":{"login":"segaz2002","id":3873358,"node_id":"MDQ6VXNlcjM4NzMzNTg=","avatar_url":"https://avatars3.githubusercontent.com/u/3873358?v=4","gravatar_id":"","url":"https://api.github.com/users/segaz2002","html_url":"https://github.com/segaz2002","followers_url":"https://api.github.com/users/segaz2002/followers","following_url":"https://api.github.com/users/segaz2002/following{/other_user}","gists_url":"https://api.github.com/users/segaz2002/gists{/gist_id}","starred_url":"https://api.github.com/users/segaz2002/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/segaz2002/subscriptions","organizations_url":"https://api.github.com/users/segaz2002/orgs","repos_url":"https://api.github.com/users/segaz2002/repos","events_url":"https://api.github.com/users/segaz2002/events{/privacy}","received_events_url":"https://api.github.com/users/segaz2002/received_events","type":"User","site_admin":false},"html_url":"https://github.com/segaz2002/coney","description":"Consumer server for RabbitMQ.","fork":true,"url":"https://api.github.com/repos/segaz2002/coney","forks_url":"https://api.github.com/repos/segaz2002/coney/forks","keys_url":"https://api.github.com/repos/segaz2002/coney/keys{/key_id}","collaborators_url":"https://api.github.com/repos/segaz2002/coney/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/segaz2002/coney/teams","hooks_url":"https://api.github.com/repos/segaz2002/coney/hooks","issue_events_url":"https://api.github.com/repos/segaz2002/coney/issues/events{/number}","events_url":"https://api.github.com/repos/segaz2002/coney/events","assignees_url":"https://api.github.com/repos/segaz2002/coney/assignees{/user}","branches_url":"https://api.github.com/repos/segaz2002/coney/branches{/branch}","tags_url":"https://api.github.com/repos/segaz2002/coney/tags","blobs_url":"https://api.github.com/repos/segaz2002/coney/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/segaz2002/coney/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/segaz2002/coney/git/refs{/sha}","trees_url":"https://api.github.com/repos/segaz2002/coney/git/trees{/sha}","statuses_url":"https://api.github.com/repos/segaz2002/coney/statuses/{sha}","languages_url":"https://api.github.com/repos/segaz2002/coney/languages","stargazers_url":"https://api.github.com/repos/segaz2002/coney/stargazers","contributors_url":"https://api.github.com/repos/segaz2002/coney/contributors","subscribers_url":"https://api.github.com/repos/segaz2002/coney/subscribers","subscription_url":"https://api.github.com/repos/segaz2002/coney/subscription","commits_url":"https://api.github.com/repos/segaz2002/coney/commits{/sha}","git_commits_url":"https://api.github.com/repos/segaz2002/coney/git/commits{/sha}","comments_url":"https://api.github.com/repos/segaz2002/coney/comments{/number}","issue_comment_url":"https://api.github.com/repos/segaz2002/coney/issues/comments{/number}","contents_url":"https://api.github.com/repos/segaz2002/coney/contents/{+path}","compare_url":"https://api.github.com/repos/segaz2002/coney/compare/{base}...{head}","merges_url":"https://api.github.com/repos/segaz2002/coney/merges","archive_url":"https://api.github.com/repos/segaz2002/coney/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/segaz2002/coney/downloads","issues_url":"https://api.github.com/repos/segaz2002/coney/issues{/number}","pulls_url":"https://api.github.com/repos/segaz2002/coney/pulls{/number}","milestones_url":"https://api.github.com/repos/segaz2002/coney/milestones{/number}","notifications_url":"https://api.github.com/repos/segaz2002/coney/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/segaz2002/coney/labels{/name}","releases_url":"https://api.github.com/repos/segaz2002/coney/releases{/id}","deployments_url":"https://api.github.com/repos/segaz2002/coney/deployments","created_at":"2018-12-04T09:33:28Z","updated_at":"2018-12-04T09:33:30Z","pushed_at":"2018-12-04T09:34:26Z","git_url":"git://github.com/segaz2002/coney.git","ssh_url":"git@github.com:segaz2002/coney.git","clone_url":"https://github.com/segaz2002/coney.git","svn_url":"https://github.com/segaz2002/coney","homepage":null,"size":61,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"llxff:master","ref":"master","sha":"7b98a1b4f0da4d316fd2118ba6394779212563ed","user":{"login":"llxff","id":866273,"node_id":"MDQ6VXNlcjg2NjI3Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/866273?v=4","gravatar_id":"","url":"https://api.github.com/users/llxff","html_url":"https://github.com/llxff","followers_url":"https://api.github.com/users/llxff/followers","following_url":"https://api.github.com/users/llxff/following{/other_user}","gists_url":"https://api.github.com/users/llxff/gists{/gist_id}","starred_url":"https://api.github.com/users/llxff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llxff/subscriptions","organizations_url":"https://api.github.com/users/llxff/orgs","repos_url":"https://api.github.com/users/llxff/repos","events_url":"https://api.github.com/users/llxff/events{/privacy}","received_events_url":"https://api.github.com/users/llxff/received_events","type":"User","site_admin":false},"repo":{"id":87182008,"node_id":"MDEwOlJlcG9zaXRvcnk4NzE4MjAwOA==","name":"coney","full_name":"llxff/coney","private":false,"owner":{"login":"llxff","id":866273,"node_id":"MDQ6VXNlcjg2NjI3Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/866273?v=4","gravatar_id":"","url":"https://api.github.com/users/llxff","html_url":"https://github.com/llxff","followers_url":"https://api.github.com/users/llxff/followers","following_url":"https://api.github.com/users/llxff/following{/other_user}","gists_url":"https://api.github.com/users/llxff/gists{/gist_id}","starred_url":"https://api.github.com/users/llxff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llxff/subscriptions","organizations_url":"https://api.github.com/users/llxff/orgs","repos_url":"https://api.github.com/users/llxff/repos","events_url":"https://api.github.com/users/llxff/events{/privacy}","received_events_url":"https://api.github.com/users/llxff/received_events","type":"User","site_admin":false},"html_url":"https://github.com/llxff/coney","description":"Consumer server for RabbitMQ.","fork":false,"url":"https://api.github.com/repos/llxff/coney","forks_url":"https://api.github.com/repos/llxff/coney/forks","keys_url":"https://api.github.com/repos/llxff/coney/keys{/key_id}","collaborators_url":"https://api.github.com/repos/llxff/coney/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/llxff/coney/teams","hooks_url":"https://api.github.com/repos/llxff/coney/hooks","issue_events_url":"https://api.github.com/repos/llxff/coney/issues/events{/number}","events_url":"https://api.github.com/repos/llxff/coney/events","assignees_url":"https://api.github.com/repos/llxff/coney/assignees{/user}","branches_url":"https://api.github.com/repos/llxff/coney/branches{/branch}","tags_url":"https://api.github.com/repos/llxff/coney/tags","blobs_url":"https://api.github.com/repos/llxff/coney/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/llxff/coney/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/llxff/coney/git/refs{/sha}","trees_url":"https://api.github.com/repos/llxff/coney/git/trees{/sha}","statuses_url":"https://api.github.com/repos/llxff/coney/statuses/{sha}","languages_url":"https://api.github.com/repos/llxff/coney/languages","stargazers_url":"https://api.github.com/repos/llxff/coney/stargazers","contributors_url":"https://api.github.com/repos/llxff/coney/contributors","subscribers_url":"https://api.github.com/repos/llxff/coney/subscribers","subscription_url":"https://api.github.com/repos/llxff/coney/subscription","commits_url":"https://api.github.com/repos/llxff/coney/commits{/sha}","git_commits_url":"https://api.github.com/repos/llxff/coney/git/commits{/sha}","comments_url":"https://api.github.com/repos/llxff/coney/comments{/number}","issue_comment_url":"https://api.github.com/repos/llxff/coney/issues/comments{/number}","contents_url":"https://api.github.com/repos/llxff/coney/contents/{+path}","compare_url":"https://api.github.com/repos/llxff/coney/compare/{base}...{head}","merges_url":"https://api.github.com/repos/llxff/coney/merges","archive_url":"https://api.github.com/repos/llxff/coney/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/llxff/coney/downloads","issues_url":"https://api.github.com/repos/llxff/coney/issues{/number}","pulls_url":"https://api.github.com/repos/llxff/coney/pulls{/number}","milestones_url":"https://api.github.com/repos/llxff/coney/milestones{/number}","notifications_url":"https://api.github.com/repos/llxff/coney/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/llxff/coney/labels{/name}","releases_url":"https://api.github.com/repos/llxff/coney/releases{/id}","deployments_url":"https://api.github.com/repos/llxff/coney/deployments","created_at":"2017-04-04T12:08:11Z","updated_at":"2018-11-19T10:58:18Z","pushed_at":"2018-12-04T09:39:36Z","git_url":"git://github.com/llxff/coney.git","ssh_url":"git@github.com:llxff/coney.git","clone_url":"https://github.com/llxff/coney.git","svn_url":"https://github.com/llxff/coney","homepage":null,"size":60,"stargazers_count":12,"watchers_count":12,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4,"open_issues":1,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/llxff/coney/pulls/8"},"html":{"href":"https://github.com/llxff/coney/pull/8"},"issue":{"href":"https://api.github.com/repos/llxff/coney/issues/8"},"comments":{"href":"https://api.github.com/repos/llxff/coney/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/llxff/coney/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/llxff/coney/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/llxff/coney/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/llxff/coney/statuses/c3de39969618dd811891a2a7eb5a9da216b9ed00"}},"author_association":"NONE"}}
{"actor":{"display_login":"segaz2002"}}