{"action":"created","comment":{"url":"https://api.github.com/repos/genodelabs/genode/pulls/comments/181380670","pull_request_review_id":112000914,"id":181380670,"diff_hunk":"@@ -402,6 +393,28 @@ void Platform::_init_rom_modules()\n \t\t     next <= last && element->id != SEL4_BOOTINFO_HEADER_PADDING;\n \t\t\t element = next)\n \t\t{\n+\t\t\tif (element->id == SEL4_BOOTINFO_HEADER_X86_TSC_FREQ) {\n+\t\t\t\tstruct tsc_freq {\n+\t\t\t\t\tuint32_t freq_mhz;\n+\t\t\t\t} __attribute__((packed));\n+\t\t\t\tif (sizeof(tsc_freq) + sizeof(*element) != element->len) {\n+\t\t\t\t\terror(\"unexpected tsc frequency format\");\n+\t\t\t\t\tcontinue;\n+\t\t\t\t}\n+\n+\t\t\t\ttsc_freq const * boot_freq = reinterpret_cast<tsc_freq const *>(reinterpret_cast<addr_t>(element) + sizeof(* element));\n+\n+\t\t\t\txml.node(\"hardware\", [&] () {\n+\t\t\t\t\txml.node(\"features\", [&] () {\n+\t\t\t\t\t\txml.attribute(\"svm\", false);\n+\t\t\t\t\t\txml.attribute(\"vmx\", false);\n+\t\t\t\t\t});\n+\t\t\t\t\txml.node(\"tsc\", [&] () {\n+\t\t\t\t\t\txml.attribute(\"freq_khz\" , boot_freq->freq_mhz / 1000UL);","path":"repos/base-sel4/src/core/platform.cc","position":37,"original_position":37,"commit_id":"fa4529f1617775884abb0173d94232d66b9adf20","original_commit_id":"fa4529f1617775884abb0173d94232d66b9adf20","user":{"login":"chelmuth","id":968883,"avatar_url":"https://avatars0.githubusercontent.com/u/968883?v=4","gravatar_id":"","url":"https://api.github.com/users/chelmuth","html_url":"https://github.com/chelmuth","followers_url":"https://api.github.com/users/chelmuth/followers","following_url":"https://api.github.com/users/chelmuth/following{/other_user}","gists_url":"https://api.github.com/users/chelmuth/gists{/gist_id}","starred_url":"https://api.github.com/users/chelmuth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chelmuth/subscriptions","organizations_url":"https://api.github.com/users/chelmuth/orgs","repos_url":"https://api.github.com/users/chelmuth/repos","events_url":"https://api.github.com/users/chelmuth/events{/privacy}","received_events_url":"https://api.github.com/users/chelmuth/received_events","type":"User","site_admin":false},"body":"IMO the calculation should be `kHz=1000*MHz`, right?","created_at":"2018-04-13T13:04:19Z","updated_at":"2018-04-13T13:04:19Z","html_url":"https://github.com/genodelabs/genode/pull/2764#discussion_r181380670","pull_request_url":"https://api.github.com/repos/genodelabs/genode/pulls/2764","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/genodelabs/genode/pulls/comments/181380670"},"html":{"href":"https://github.com/genodelabs/genode/pull/2764#discussion_r181380670"},"pull_request":{"href":"https://api.github.com/repos/genodelabs/genode/pulls/2764"}}},"pull_request":{"url":"https://api.github.com/repos/genodelabs/genode/pulls/2764","id":181479726,"html_url":"https://github.com/genodelabs/genode/pull/2764","diff_url":"https://github.com/genodelabs/genode/pull/2764.diff","patch_url":"https://github.com/genodelabs/genode/pull/2764.patch","issue_url":"https://api.github.com/repos/genodelabs/genode/issues/2764","number":2764,"state":"open","locked":false,"title":"sel4: update to version 9.0.0","user":{"login":"N8Fear","id":1010132,"avatar_url":"https://avatars2.githubusercontent.com/u/1010132?v=4","gravatar_id":"","url":"https://api.github.com/users/N8Fear","html_url":"https://github.com/N8Fear","followers_url":"https://api.github.com/users/N8Fear/followers","following_url":"https://api.github.com/users/N8Fear/following{/other_user}","gists_url":"https://api.github.com/users/N8Fear/gists{/gist_id}","starred_url":"https://api.github.com/users/N8Fear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/N8Fear/subscriptions","organizations_url":"https://api.github.com/users/N8Fear/orgs","repos_url":"https://api.github.com/users/N8Fear/repos","events_url":"https://api.github.com/users/N8Fear/events{/privacy}","received_events_url":"https://api.github.com/users/N8Fear/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nI updated the seL4 port to use seL4 version 9.0.0. The required changes are relatively small and it seems to work fine.\r\nI tested it on x86_64 and x86_32 with a bunch of scenarios (log, thread, demo, noux_terminal_fs and genode_org) and it seems to work fine (or at least as well as on current master: on x86_64 the heavier scenarios like demo seem to need adjustments concerning RAM and CAPS, but that's the same as on current master).\r\nI also tested the build on wand_quad but due to lack of of hardware I couldn't test the function. Due to the kind of code changes I expect it to work anyways.","created_at":"2018-04-13T12:54:54Z","updated_at":"2018-04-13T13:04:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f6ef46bf23e4cacf26e5cb253a6cb249e8b84bda","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":203357,"url":"https://api.github.com/repos/genodelabs/genode/labels/fixed","name":"fixed","color":"a02b19","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/genodelabs/genode/pulls/2764/commits","review_comments_url":"https://api.github.com/repos/genodelabs/genode/pulls/2764/comments","review_comment_url":"https://api.github.com/repos/genodelabs/genode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/genodelabs/genode/issues/2764/comments","statuses_url":"https://api.github.com/repos/genodelabs/genode/statuses/fa4529f1617775884abb0173d94232d66b9adf20","head":{"label":"N8Fear:sel4-update","ref":"sel4-update","sha":"fa4529f1617775884abb0173d94232d66b9adf20","user":{"login":"N8Fear","id":1010132,"avatar_url":"https://avatars2.githubusercontent.com/u/1010132?v=4","gravatar_id":"","url":"https://api.github.com/users/N8Fear","html_url":"https://github.com/N8Fear","followers_url":"https://api.github.com/users/N8Fear/followers","following_url":"https://api.github.com/users/N8Fear/following{/other_user}","gists_url":"https://api.github.com/users/N8Fear/gists{/gist_id}","starred_url":"https://api.github.com/users/N8Fear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/N8Fear/subscriptions","organizations_url":"https://api.github.com/users/N8Fear/orgs","repos_url":"https://api.github.com/users/N8Fear/repos","events_url":"https://api.github.com/users/N8Fear/events{/privacy}","received_events_url":"https://api.github.com/users/N8Fear/received_events","type":"User","site_admin":false},"repo":{"id":72628682,"name":"genode","full_name":"N8Fear/genode","owner":{"login":"N8Fear","id":1010132,"avatar_url":"https://avatars2.githubusercontent.com/u/1010132?v=4","gravatar_id":"","url":"https://api.github.com/users/N8Fear","html_url":"https://github.com/N8Fear","followers_url":"https://api.github.com/users/N8Fear/followers","following_url":"https://api.github.com/users/N8Fear/following{/other_user}","gists_url":"https://api.github.com/users/N8Fear/gists{/gist_id}","starred_url":"https://api.github.com/users/N8Fear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/N8Fear/subscriptions","organizations_url":"https://api.github.com/users/N8Fear/orgs","repos_url":"https://api.github.com/users/N8Fear/repos","events_url":"https://api.github.com/users/N8Fear/events{/privacy}","received_events_url":"https://api.github.com/users/N8Fear/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/N8Fear/genode","description":"Genode OS Framework","fork":true,"url":"https://api.github.com/repos/N8Fear/genode","forks_url":"https://api.github.com/repos/N8Fear/genode/forks","keys_url":"https://api.github.com/repos/N8Fear/genode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/N8Fear/genode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/N8Fear/genode/teams","hooks_url":"https://api.github.com/repos/N8Fear/genode/hooks","issue_events_url":"https://api.github.com/repos/N8Fear/genode/issues/events{/number}","events_url":"https://api.github.com/repos/N8Fear/genode/events","assignees_url":"https://api.github.com/repos/N8Fear/genode/assignees{/user}","branches_url":"https://api.github.com/repos/N8Fear/genode/branches{/branch}","tags_url":"https://api.github.com/repos/N8Fear/genode/tags","blobs_url":"https://api.github.com/repos/N8Fear/genode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/N8Fear/genode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/N8Fear/genode/git/refs{/sha}","trees_url":"https://api.github.com/repos/N8Fear/genode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/N8Fear/genode/statuses/{sha}","languages_url":"https://api.github.com/repos/N8Fear/genode/languages","stargazers_url":"https://api.github.com/repos/N8Fear/genode/stargazers","contributors_url":"https://api.github.com/repos/N8Fear/genode/contributors","subscribers_url":"https://api.github.com/repos/N8Fear/genode/subscribers","subscription_url":"https://api.github.com/repos/N8Fear/genode/subscription","commits_url":"https://api.github.com/repos/N8Fear/genode/commits{/sha}","git_commits_url":"https://api.github.com/repos/N8Fear/genode/git/commits{/sha}","comments_url":"https://api.github.com/repos/N8Fear/genode/comments{/number}","issue_comment_url":"https://api.github.com/repos/N8Fear/genode/issues/comments{/number}","contents_url":"https://api.github.com/repos/N8Fear/genode/contents/{+path}","compare_url":"https://api.github.com/repos/N8Fear/genode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/N8Fear/genode/merges","archive_url":"https://api.github.com/repos/N8Fear/genode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/N8Fear/genode/downloads","issues_url":"https://api.github.com/repos/N8Fear/genode/issues{/number}","pulls_url":"https://api.github.com/repos/N8Fear/genode/pulls{/number}","milestones_url":"https://api.github.com/repos/N8Fear/genode/milestones{/number}","notifications_url":"https://api.github.com/repos/N8Fear/genode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/N8Fear/genode/labels{/name}","releases_url":"https://api.github.com/repos/N8Fear/genode/releases{/id}","deployments_url":"https://api.github.com/repos/N8Fear/genode/deployments","created_at":"2016-11-02T10:23:27Z","updated_at":"2016-11-02T10:23:41Z","pushed_at":"2018-04-13T12:07:08Z","git_url":"git://github.com/N8Fear/genode.git","ssh_url":"git@github.com:N8Fear/genode.git","clone_url":"https://github.com/N8Fear/genode.git","svn_url":"https://github.com/N8Fear/genode","homepage":"http://genode.org/","size":36386,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"genodelabs:master","ref":"master","sha":"d54f95d497c8f9c7052e8679df32221ac49f0026","user":{"login":"genodelabs","id":1256097,"avatar_url":"https://avatars2.githubusercontent.com/u/1256097?v=4","gravatar_id":"","url":"https://api.github.com/users/genodelabs","html_url":"https://github.com/genodelabs","followers_url":"https://api.github.com/users/genodelabs/followers","following_url":"https://api.github.com/users/genodelabs/following{/other_user}","gists_url":"https://api.github.com/users/genodelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/genodelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genodelabs/subscriptions","organizations_url":"https://api.github.com/users/genodelabs/orgs","repos_url":"https://api.github.com/users/genodelabs/repos","events_url":"https://api.github.com/users/genodelabs/events{/privacy}","received_events_url":"https://api.github.com/users/genodelabs/received_events","type":"Organization","site_admin":false},"repo":{"id":3018212,"name":"genode","full_name":"genodelabs/genode","owner":{"login":"genodelabs","id":1256097,"avatar_url":"https://avatars2.githubusercontent.com/u/1256097?v=4","gravatar_id":"","url":"https://api.github.com/users/genodelabs","html_url":"https://github.com/genodelabs","followers_url":"https://api.github.com/users/genodelabs/followers","following_url":"https://api.github.com/users/genodelabs/following{/other_user}","gists_url":"https://api.github.com/users/genodelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/genodelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genodelabs/subscriptions","organizations_url":"https://api.github.com/users/genodelabs/orgs","repos_url":"https://api.github.com/users/genodelabs/repos","events_url":"https://api.github.com/users/genodelabs/events{/privacy}","received_events_url":"https://api.github.com/users/genodelabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/genodelabs/genode","description":"Genode OS Framework","fork":false,"url":"https://api.github.com/repos/genodelabs/genode","forks_url":"https://api.github.com/repos/genodelabs/genode/forks","keys_url":"https://api.github.com/repos/genodelabs/genode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/genodelabs/genode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/genodelabs/genode/teams","hooks_url":"https://api.github.com/repos/genodelabs/genode/hooks","issue_events_url":"https://api.github.com/repos/genodelabs/genode/issues/events{/number}","events_url":"https://api.github.com/repos/genodelabs/genode/events","assignees_url":"https://api.github.com/repos/genodelabs/genode/assignees{/user}","branches_url":"https://api.github.com/repos/genodelabs/genode/branches{/branch}","tags_url":"https://api.github.com/repos/genodelabs/genode/tags","blobs_url":"https://api.github.com/repos/genodelabs/genode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/genodelabs/genode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/genodelabs/genode/git/refs{/sha}","trees_url":"https://api.github.com/repos/genodelabs/genode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/genodelabs/genode/statuses/{sha}","languages_url":"https://api.github.com/repos/genodelabs/genode/languages","stargazers_url":"https://api.github.com/repos/genodelabs/genode/stargazers","contributors_url":"https://api.github.com/repos/genodelabs/genode/contributors","subscribers_url":"https://api.github.com/repos/genodelabs/genode/subscribers","subscription_url":"https://api.github.com/repos/genodelabs/genode/subscription","commits_url":"https://api.github.com/repos/genodelabs/genode/commits{/sha}","git_commits_url":"https://api.github.com/repos/genodelabs/genode/git/commits{/sha}","comments_url":"https://api.github.com/repos/genodelabs/genode/comments{/number}","issue_comment_url":"https://api.github.com/repos/genodelabs/genode/issues/comments{/number}","contents_url":"https://api.github.com/repos/genodelabs/genode/contents/{+path}","compare_url":"https://api.github.com/repos/genodelabs/genode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/genodelabs/genode/merges","archive_url":"https://api.github.com/repos/genodelabs/genode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/genodelabs/genode/downloads","issues_url":"https://api.github.com/repos/genodelabs/genode/issues{/number}","pulls_url":"https://api.github.com/repos/genodelabs/genode/pulls{/number}","milestones_url":"https://api.github.com/repos/genodelabs/genode/milestones{/number}","notifications_url":"https://api.github.com/repos/genodelabs/genode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/genodelabs/genode/labels{/name}","releases_url":"https://api.github.com/repos/genodelabs/genode/releases{/id}","deployments_url":"https://api.github.com/repos/genodelabs/genode/deployments","created_at":"2011-12-20T08:27:40Z","updated_at":"2018-04-10T11:37:44Z","pushed_at":"2018-04-13T12:54:55Z","git_url":"git://github.com/genodelabs/genode.git","ssh_url":"git@github.com:genodelabs/genode.git","clone_url":"https://github.com/genodelabs/genode.git","svn_url":"https://github.com/genodelabs/genode","homepage":"http://genode.org/","size":36776,"stargazers_count":413,"watchers_count":413,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":167,"mirror_url":null,"archived":false,"open_issues_count":179,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":167,"open_issues":179,"watchers":413,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/genodelabs/genode/pulls/2764"},"html":{"href":"https://github.com/genodelabs/genode/pull/2764"},"issue":{"href":"https://api.github.com/repos/genodelabs/genode/issues/2764"},"comments":{"href":"https://api.github.com/repos/genodelabs/genode/issues/2764/comments"},"review_comments":{"href":"https://api.github.com/repos/genodelabs/genode/pulls/2764/comments"},"review_comment":{"href":"https://api.github.com/repos/genodelabs/genode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/genodelabs/genode/pulls/2764/commits"},"statuses":{"href":"https://api.github.com/repos/genodelabs/genode/statuses/fa4529f1617775884abb0173d94232d66b9adf20"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"chelmuth"}}