{"action":"created","issue":{"url":"https://api.github.com/repos/xqemu/xqemu/issues/79","repository_url":"https://api.github.com/repos/xqemu/xqemu","labels_url":"https://api.github.com/repos/xqemu/xqemu/issues/79/labels{/name}","comments_url":"https://api.github.com/repos/xqemu/xqemu/issues/79/comments","events_url":"https://api.github.com/repos/xqemu/xqemu/issues/79/events","html_url":"https://github.com/xqemu/xqemu/pull/79","id":340432286,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwODQ2MzUx","number":79,"title":"Add ARL-bias to work around OpenGL float behaviour","user":{"login":"JayFoxRox","id":360330,"node_id":"MDQ6VXNlcjM2MDMzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/360330?v=4","gravatar_id":"","url":"https://api.github.com/users/JayFoxRox","html_url":"https://github.com/JayFoxRox","followers_url":"https://api.github.com/users/JayFoxRox/followers","following_url":"https://api.github.com/users/JayFoxRox/following{/other_user}","gists_url":"https://api.github.com/users/JayFoxRox/gists{/gist_id}","starred_url":"https://api.github.com/users/JayFoxRox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JayFoxRox/subscriptions","organizations_url":"https://api.github.com/users/JayFoxRox/orgs","repos_url":"https://api.github.com/users/JayFoxRox/repos","events_url":"https://api.github.com/users/JayFoxRox/events{/privacy}","received_events_url":"https://api.github.com/users/JayFoxRox/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-11T22:49:47Z","updated_at":"2018-07-12T22:11:04Z","closed_at":"2018-07-12T22:11:00Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/xqemu/xqemu/pulls/79","html_url":"https://github.com/xqemu/xqemu/pull/79","diff_url":"https://github.com/xqemu/xqemu/pull/79.diff","patch_url":"https://github.com/xqemu/xqemu/pull/79.patch"},"body":"This adds a small bias to the ARL (address register loads) Vertex Shader instruction to work around an issue we have with OpenGL / GLSL. I've tried a short version of the explanation in the GLSL code comment.\r\n\r\nSee #78 for more details. That issue also has a screenshot of how Azurik *would* look on current master if it ran (Azurik needs some additional patches to run on current master (fifo-refactor), this patch is purely about the graphical issues with characters).\r\n\r\nAn issue with this workaround is, that this problem also exists in the other direction, where we now accidentally turn 16.99 into 17 when it *really* was supposed to be 16.\r\nHowever, this is probably less likely to happen, so this workaround should do more good than bad.\r\n\r\nHere is how it looks with the bias:\r\n\r\n![Azurik in XQEMU after this patch + fifo-refactor](https://cdn.discordapp.com/attachments/428359372842991616/466300152219566080/azurik_wip.JPG)\r\n\r\n*Screenshot by [John GodGames](https://www.youtube.com/channel/UC993yJ3ET5aFc6cRyukofjQ)*\r\n\r\nAccording to John GodGames, this also fixes the known issue in Digimon Rumble Arena 2.\r\n\r\n*This only fixes one instance how the problems mentioned in #78 manifest, so that issue is still valid after merge. This is not a permanent solution.*"},"comment":{"url":"https://api.github.com/repos/xqemu/xqemu/issues/comments/404666833","html_url":"https://github.com/xqemu/xqemu/pull/79#issuecomment-404666833","issue_url":"https://api.github.com/repos/xqemu/xqemu/issues/79","id":404666833,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDY2NjgzMw==","user":{"login":"mborgerson","id":8210,"node_id":"MDQ6VXNlcjgyMTA=","avatar_url":"https://avatars0.githubusercontent.com/u/8210?v=4","gravatar_id":"","url":"https://api.github.com/users/mborgerson","html_url":"https://github.com/mborgerson","followers_url":"https://api.github.com/users/mborgerson/followers","following_url":"https://api.github.com/users/mborgerson/following{/other_user}","gists_url":"https://api.github.com/users/mborgerson/gists{/gist_id}","starred_url":"https://api.github.com/users/mborgerson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mborgerson/subscriptions","organizations_url":"https://api.github.com/users/mborgerson/orgs","repos_url":"https://api.github.com/users/mborgerson/repos","events_url":"https://api.github.com/users/mborgerson/events{/privacy}","received_events_url":"https://api.github.com/users/mborgerson/received_events","type":"User","site_admin":false},"created_at":"2018-07-12T22:11:04Z","updated_at":"2018-07-12T22:11:04Z","author_association":"MEMBER","body":"Thank you!"}}
{"actor":{"display_login":"mborgerson"}}