{"action":"created","issue":{"url":"https://api.github.com/repos/lettuce-io/lettuce-core/issues/738","repository_url":"https://api.github.com/repos/lettuce-io/lettuce-core","labels_url":"https://api.github.com/repos/lettuce-io/lettuce-core/issues/738/labels{/name}","comments_url":"https://api.github.com/repos/lettuce-io/lettuce-core/issues/738/comments","events_url":"https://api.github.com/repos/lettuce-io/lettuce-core/issues/738/events","html_url":"https://github.com/lettuce-io/lettuce-core/issues/738","id":307412566,"number":738,"title":"Question about large transactions","user":{"login":"hookumsnivy","id":3420717,"avatar_url":"https://avatars1.githubusercontent.com/u/3420717?v=4","gravatar_id":"","url":"https://api.github.com/users/hookumsnivy","html_url":"https://github.com/hookumsnivy","followers_url":"https://api.github.com/users/hookumsnivy/followers","following_url":"https://api.github.com/users/hookumsnivy/following{/other_user}","gists_url":"https://api.github.com/users/hookumsnivy/gists{/gist_id}","starred_url":"https://api.github.com/users/hookumsnivy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hookumsnivy/subscriptions","organizations_url":"https://api.github.com/users/hookumsnivy/orgs","repos_url":"https://api.github.com/users/hookumsnivy/repos","events_url":"https://api.github.com/users/hookumsnivy/events{/privacy}","received_events_url":"https://api.github.com/users/hookumsnivy/received_events","type":"User","site_admin":false},"labels":[{"id":98544795,"url":"https://api.github.com/repos/lettuce-io/lettuce-core/labels/duplicate","name":"duplicate","color":"cccccc","default":true},{"id":448480068,"url":"https://api.github.com/repos/lettuce-io/lettuce-core/labels/feedback%20requested","name":"feedback requested","color":"fbca04","default":false},{"id":98544799,"url":"https://api.github.com/repos/lettuce-io/lettuce-core/labels/question","name":"question","color":"cc317c","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-21T20:49:14Z","updated_at":"2018-04-03T06:58:52Z","closed_at":"2018-04-03T06:58:52Z","author_association":"NONE","body":"I'm using 5.0.2.RELEASE and processing **large** transactions - approximately 200k hsets. \r\nI'm not interacting with lettuce directly, but instead through Spring Boot 2.0.0 and Spring Redis Data 2.0.5. Both were recent upgrades and I was using jedis in the past without a problem.\r\nI'm not familiar with Lettuce at all, so please forgive my lack of understanding if I say something wrong.\r\n\r\nCommitting the transaction takes an abnormally long time (I haven't let it finish) and only the MULTI command has been written to Redis before I kill the process. I've stepped through the code and I think I may have found the culprit:\r\n\r\nThe `addToStack` method in `CommandHandler`. Before adding the command to the stack, it is checking to see if the command is already in the stack. This operation gets more and more expensive each time a command is added as it has to iterate through the entire stack each time. \r\nIs this expected?\r\nIs it necessary to make sure there aren't duplicates?"},"comment":{"url":"https://api.github.com/repos/lettuce-io/lettuce-core/issues/comments/378148170","html_url":"https://github.com/lettuce-io/lettuce-core/issues/738#issuecomment-378148170","issue_url":"https://api.github.com/repos/lettuce-io/lettuce-core/issues/738","id":378148170,"user":{"login":"mp911de","id":1035015,"avatar_url":"https://avatars3.githubusercontent.com/u/1035015?v=4","gravatar_id":"","url":"https://api.github.com/users/mp911de","html_url":"https://github.com/mp911de","followers_url":"https://api.github.com/users/mp911de/followers","following_url":"https://api.github.com/users/mp911de/following{/other_user}","gists_url":"https://api.github.com/users/mp911de/gists{/gist_id}","starred_url":"https://api.github.com/users/mp911de/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mp911de/subscriptions","organizations_url":"https://api.github.com/users/mp911de/orgs","repos_url":"https://api.github.com/users/mp911de/repos","events_url":"https://api.github.com/users/mp911de/events{/privacy}","received_events_url":"https://api.github.com/users/mp911de/received_events","type":"User","site_admin":false},"created_at":"2018-04-03T06:58:52Z","updated_at":"2018-04-03T06:58:52Z","author_association":"OWNER","body":"Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue."}}
{"actor":{"display_login":"mp911de"}}