{"action":"created","comment":{"url":"https://api.github.com/repos/elixir-lang/elixir/pulls/comments/175287718","pull_request_review_id":104795874,"id":175287718,"diff_hunk":"@@ -1592,43 +1592,32 @@ defmodule Kernel do\n \n   \"\"\"\n   defmacro left <> right do\n-    concats = extract_concatenations({:<>, [], [left, right]})\n+    concats = extract_concatenations({:<>, [], [left, right]}, __CALLER__)\n     quote(do: <<unquote_splicing(concats)>>)\n   end\n \n   # Extracts concatenations in order to optimize many\n   # concatenations into one single clause.\n-  defp extract_concatenations({:<>, _, [left, right]}) do\n-    [wrap_concatenation(left, :left) | extract_concatenations(right)]\n+  defp extract_concatenations({:<>, _, [left, right]}, caller) do\n+    [wrap_concatenation(left, :left, caller) | extract_concatenations(right, caller)]\n   end\n \n-  defp extract_concatenations(other) do\n-    [wrap_concatenation(other, :right)]\n+  defp extract_concatenations(other, caller) do\n+    [wrap_concatenation(other, :right, caller)]\n   end\n \n-  defp wrap_concatenation(binary, _side) when is_binary(binary) do\n+  defp wrap_concatenation(binary, _side, _caller) when is_binary(binary) do\n     binary\n   end\n \n-  defp wrap_concatenation(other, side) do\n-    {:::, [],\n-     [\n-       {:expand_concatenation_argument, [context: Elixir, import: Kernel], [other, side]},\n-       {:binary, [], nil}\n-     ]}\n-  end\n-\n-  @doc false\n-  # Used internally to check the arguments expansion of <> operator.\n-  # This function is private and must be used only internally.\n-  defmacro expand_concatenation_argument(other, side) do\n+  defp wrap_concatenation(other, side, caller) do\n     expand =\n-      case bootstrapped?(Macro) do\n-        true -> &Macro.expand(&1, __CALLER__)\n-        false -> & &1\n+      case caller.context do","path":"lib/elixir/lib/kernel.ex","position":null,"original_position":45,"commit_id":"a3d26eb62bc6998c6669d072336fbb055c42e2b9","original_commit_id":"240a123a1b976d9c07f4b5d9ccd3818eaf06b8b8","user":{"login":"ggcampinho","id":2848166,"avatar_url":"https://avatars2.githubusercontent.com/u/2848166?v=4","gravatar_id":"","url":"https://api.github.com/users/ggcampinho","html_url":"https://github.com/ggcampinho","followers_url":"https://api.github.com/users/ggcampinho/followers","following_url":"https://api.github.com/users/ggcampinho/following{/other_user}","gists_url":"https://api.github.com/users/ggcampinho/gists{/gist_id}","starred_url":"https://api.github.com/users/ggcampinho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggcampinho/subscriptions","organizations_url":"https://api.github.com/users/ggcampinho/orgs","repos_url":"https://api.github.com/users/ggcampinho/repos","events_url":"https://api.github.com/users/ggcampinho/events{/privacy}","received_events_url":"https://api.github.com/users/ggcampinho/received_events","type":"User","site_admin":false},"body":"One thing that I was thinking was to always expand to check the errors, but add to the final expression the original value. It will expand two times, but it won't cause any issues with the env and it won't allow any strange error when checking the generated expression","created_at":"2018-03-18T12:42:30Z","updated_at":"2018-03-18T12:42:30Z","html_url":"https://github.com/elixir-lang/elixir/pull/7349#discussion_r175287718","pull_request_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/7349","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/comments/175287718"},"html":{"href":"https://github.com/elixir-lang/elixir/pull/7349#discussion_r175287718"},"pull_request":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/7349"}},"in_reply_to_id":175286800},"pull_request":{"url":"https://api.github.com/repos/elixir-lang/elixir/pulls/7349","id":169221338,"html_url":"https://github.com/elixir-lang/elixir/pull/7349","diff_url":"https://github.com/elixir-lang/elixir/pull/7349.diff","patch_url":"https://github.com/elixir-lang/elixir/pull/7349.patch","issue_url":"https://api.github.com/repos/elixir-lang/elixir/issues/7349","number":7349,"state":"open","locked":false,"title":"Improve error messages for <> operator","user":{"login":"ggcampinho","id":2848166,"avatar_url":"https://avatars2.githubusercontent.com/u/2848166?v=4","gravatar_id":"","url":"https://api.github.com/users/ggcampinho","html_url":"https://github.com/ggcampinho","followers_url":"https://api.github.com/users/ggcampinho/followers","following_url":"https://api.github.com/users/ggcampinho/following{/other_user}","gists_url":"https://api.github.com/users/ggcampinho/gists{/gist_id}","starred_url":"https://api.github.com/users/ggcampinho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggcampinho/subscriptions","organizations_url":"https://api.github.com/users/ggcampinho/orgs","repos_url":"https://api.github.com/users/ggcampinho/repos","events_url":"https://api.github.com/users/ggcampinho/events{/privacy}","received_events_url":"https://api.github.com/users/ggcampinho/received_events","type":"User","site_admin":false},"body":"Closes #7277","created_at":"2018-02-14T21:03:24Z","updated_at":"2018-03-18T12:42:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"19ad92354816877300e94af2d3e5eed147332851","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/7349/commits","review_comments_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/7349/comments","review_comment_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elixir-lang/elixir/issues/7349/comments","statuses_url":"https://api.github.com/repos/elixir-lang/elixir/statuses/a3d26eb62bc6998c6669d072336fbb055c42e2b9","head":{"label":"ggcampinho:pinop-left-binary-error","ref":"pinop-left-binary-error","sha":"a3d26eb62bc6998c6669d072336fbb055c42e2b9","user":{"login":"ggcampinho","id":2848166,"avatar_url":"https://avatars2.githubusercontent.com/u/2848166?v=4","gravatar_id":"","url":"https://api.github.com/users/ggcampinho","html_url":"https://github.com/ggcampinho","followers_url":"https://api.github.com/users/ggcampinho/followers","following_url":"https://api.github.com/users/ggcampinho/following{/other_user}","gists_url":"https://api.github.com/users/ggcampinho/gists{/gist_id}","starred_url":"https://api.github.com/users/ggcampinho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggcampinho/subscriptions","organizations_url":"https://api.github.com/users/ggcampinho/orgs","repos_url":"https://api.github.com/users/ggcampinho/repos","events_url":"https://api.github.com/users/ggcampinho/events{/privacy}","received_events_url":"https://api.github.com/users/ggcampinho/received_events","type":"User","site_admin":false},"repo":{"id":92685240,"name":"elixir","full_name":"ggcampinho/elixir","owner":{"login":"ggcampinho","id":2848166,"avatar_url":"https://avatars2.githubusercontent.com/u/2848166?v=4","gravatar_id":"","url":"https://api.github.com/users/ggcampinho","html_url":"https://github.com/ggcampinho","followers_url":"https://api.github.com/users/ggcampinho/followers","following_url":"https://api.github.com/users/ggcampinho/following{/other_user}","gists_url":"https://api.github.com/users/ggcampinho/gists{/gist_id}","starred_url":"https://api.github.com/users/ggcampinho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggcampinho/subscriptions","organizations_url":"https://api.github.com/users/ggcampinho/orgs","repos_url":"https://api.github.com/users/ggcampinho/repos","events_url":"https://api.github.com/users/ggcampinho/events{/privacy}","received_events_url":"https://api.github.com/users/ggcampinho/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ggcampinho/elixir","description":"Elixir is a dynamic, functional language designed for building scalable and maintainable applications","fork":true,"url":"https://api.github.com/repos/ggcampinho/elixir","forks_url":"https://api.github.com/repos/ggcampinho/elixir/forks","keys_url":"https://api.github.com/repos/ggcampinho/elixir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ggcampinho/elixir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ggcampinho/elixir/teams","hooks_url":"https://api.github.com/repos/ggcampinho/elixir/hooks","issue_events_url":"https://api.github.com/repos/ggcampinho/elixir/issues/events{/number}","events_url":"https://api.github.com/repos/ggcampinho/elixir/events","assignees_url":"https://api.github.com/repos/ggcampinho/elixir/assignees{/user}","branches_url":"https://api.github.com/repos/ggcampinho/elixir/branches{/branch}","tags_url":"https://api.github.com/repos/ggcampinho/elixir/tags","blobs_url":"https://api.github.com/repos/ggcampinho/elixir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ggcampinho/elixir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ggcampinho/elixir/git/refs{/sha}","trees_url":"https://api.github.com/repos/ggcampinho/elixir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ggcampinho/elixir/statuses/{sha}","languages_url":"https://api.github.com/repos/ggcampinho/elixir/languages","stargazers_url":"https://api.github.com/repos/ggcampinho/elixir/stargazers","contributors_url":"https://api.github.com/repos/ggcampinho/elixir/contributors","subscribers_url":"https://api.github.com/repos/ggcampinho/elixir/subscribers","subscription_url":"https://api.github.com/repos/ggcampinho/elixir/subscription","commits_url":"https://api.github.com/repos/ggcampinho/elixir/commits{/sha}","git_commits_url":"https://api.github.com/repos/ggcampinho/elixir/git/commits{/sha}","comments_url":"https://api.github.com/repos/ggcampinho/elixir/comments{/number}","issue_comment_url":"https://api.github.com/repos/ggcampinho/elixir/issues/comments{/number}","contents_url":"https://api.github.com/repos/ggcampinho/elixir/contents/{+path}","compare_url":"https://api.github.com/repos/ggcampinho/elixir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ggcampinho/elixir/merges","archive_url":"https://api.github.com/repos/ggcampinho/elixir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ggcampinho/elixir/downloads","issues_url":"https://api.github.com/repos/ggcampinho/elixir/issues{/number}","pulls_url":"https://api.github.com/repos/ggcampinho/elixir/pulls{/number}","milestones_url":"https://api.github.com/repos/ggcampinho/elixir/milestones{/number}","notifications_url":"https://api.github.com/repos/ggcampinho/elixir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ggcampinho/elixir/labels{/name}","releases_url":"https://api.github.com/repos/ggcampinho/elixir/releases{/id}","deployments_url":"https://api.github.com/repos/ggcampinho/elixir/deployments","created_at":"2017-05-28T20:26:50Z","updated_at":"2017-05-29T02:02:38Z","pushed_at":"2018-03-18T12:32:23Z","git_url":"git://github.com/ggcampinho/elixir.git","ssh_url":"git@github.com:ggcampinho/elixir.git","clone_url":"https://github.com/ggcampinho/elixir.git","svn_url":"https://github.com/ggcampinho/elixir","homepage":"http://elixir-lang.org/","size":35393,"stargazers_count":1,"watchers_count":1,"language":"Elixir","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"elixir-lang:master","ref":"master","sha":"b42aa5739b750ce8de1ef314ecb8efccf6251061","user":{"login":"elixir-lang","id":1481354,"avatar_url":"https://avatars1.githubusercontent.com/u/1481354?v=4","gravatar_id":"","url":"https://api.github.com/users/elixir-lang","html_url":"https://github.com/elixir-lang","followers_url":"https://api.github.com/users/elixir-lang/followers","following_url":"https://api.github.com/users/elixir-lang/following{/other_user}","gists_url":"https://api.github.com/users/elixir-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/elixir-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elixir-lang/subscriptions","organizations_url":"https://api.github.com/users/elixir-lang/orgs","repos_url":"https://api.github.com/users/elixir-lang/repos","events_url":"https://api.github.com/users/elixir-lang/events{/privacy}","received_events_url":"https://api.github.com/users/elixir-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":1234714,"name":"elixir","full_name":"elixir-lang/elixir","owner":{"login":"elixir-lang","id":1481354,"avatar_url":"https://avatars1.githubusercontent.com/u/1481354?v=4","gravatar_id":"","url":"https://api.github.com/users/elixir-lang","html_url":"https://github.com/elixir-lang","followers_url":"https://api.github.com/users/elixir-lang/followers","following_url":"https://api.github.com/users/elixir-lang/following{/other_user}","gists_url":"https://api.github.com/users/elixir-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/elixir-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elixir-lang/subscriptions","organizations_url":"https://api.github.com/users/elixir-lang/orgs","repos_url":"https://api.github.com/users/elixir-lang/repos","events_url":"https://api.github.com/users/elixir-lang/events{/privacy}","received_events_url":"https://api.github.com/users/elixir-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elixir-lang/elixir","description":"Elixir is a dynamic, functional language designed for building scalable and maintainable applications","fork":false,"url":"https://api.github.com/repos/elixir-lang/elixir","forks_url":"https://api.github.com/repos/elixir-lang/elixir/forks","keys_url":"https://api.github.com/repos/elixir-lang/elixir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elixir-lang/elixir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elixir-lang/elixir/teams","hooks_url":"https://api.github.com/repos/elixir-lang/elixir/hooks","issue_events_url":"https://api.github.com/repos/elixir-lang/elixir/issues/events{/number}","events_url":"https://api.github.com/repos/elixir-lang/elixir/events","assignees_url":"https://api.github.com/repos/elixir-lang/elixir/assignees{/user}","branches_url":"https://api.github.com/repos/elixir-lang/elixir/branches{/branch}","tags_url":"https://api.github.com/repos/elixir-lang/elixir/tags","blobs_url":"https://api.github.com/repos/elixir-lang/elixir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elixir-lang/elixir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elixir-lang/elixir/git/refs{/sha}","trees_url":"https://api.github.com/repos/elixir-lang/elixir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elixir-lang/elixir/statuses/{sha}","languages_url":"https://api.github.com/repos/elixir-lang/elixir/languages","stargazers_url":"https://api.github.com/repos/elixir-lang/elixir/stargazers","contributors_url":"https://api.github.com/repos/elixir-lang/elixir/contributors","subscribers_url":"https://api.github.com/repos/elixir-lang/elixir/subscribers","subscription_url":"https://api.github.com/repos/elixir-lang/elixir/subscription","commits_url":"https://api.github.com/repos/elixir-lang/elixir/commits{/sha}","git_commits_url":"https://api.github.com/repos/elixir-lang/elixir/git/commits{/sha}","comments_url":"https://api.github.com/repos/elixir-lang/elixir/comments{/number}","issue_comment_url":"https://api.github.com/repos/elixir-lang/elixir/issues/comments{/number}","contents_url":"https://api.github.com/repos/elixir-lang/elixir/contents/{+path}","compare_url":"https://api.github.com/repos/elixir-lang/elixir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elixir-lang/elixir/merges","archive_url":"https://api.github.com/repos/elixir-lang/elixir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elixir-lang/elixir/downloads","issues_url":"https://api.github.com/repos/elixir-lang/elixir/issues{/number}","pulls_url":"https://api.github.com/repos/elixir-lang/elixir/pulls{/number}","milestones_url":"https://api.github.com/repos/elixir-lang/elixir/milestones{/number}","notifications_url":"https://api.github.com/repos/elixir-lang/elixir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elixir-lang/elixir/labels{/name}","releases_url":"https://api.github.com/repos/elixir-lang/elixir/releases{/id}","deployments_url":"https://api.github.com/repos/elixir-lang/elixir/deployments","created_at":"2011-01-09T08:43:57Z","updated_at":"2018-03-18T12:16:06Z","pushed_at":"2018-03-18T12:32:26Z","git_url":"git://github.com/elixir-lang/elixir.git","ssh_url":"git@github.com:elixir-lang/elixir.git","clone_url":"https://github.com/elixir-lang/elixir.git","svn_url":"https://github.com/elixir-lang/elixir","homepage":"http://elixir-lang.org/","size":35352,"stargazers_count":12526,"watchers_count":12526,"language":"Elixir","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1826,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1826,"open_issues":32,"watchers":12526,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/7349"},"html":{"href":"https://github.com/elixir-lang/elixir/pull/7349"},"issue":{"href":"https://api.github.com/repos/elixir-lang/elixir/issues/7349"},"comments":{"href":"https://api.github.com/repos/elixir-lang/elixir/issues/7349/comments"},"review_comments":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/7349/comments"},"review_comment":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/7349/commits"},"statuses":{"href":"https://api.github.com/repos/elixir-lang/elixir/statuses/a3d26eb62bc6998c6669d072336fbb055c42e2b9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ggcampinho"}}