{"action":"closed","number":141,"pull_request":{"url":"https://api.github.com/repos/ONSdigital/zebedee/pulls/141","id":173978717,"html_url":"https://github.com/ONSdigital/zebedee/pull/141","diff_url":"https://github.com/ONSdigital/zebedee/pull/141.diff","patch_url":"https://github.com/ONSdigital/zebedee/pull/141.patch","issue_url":"https://api.github.com/repos/ONSdigital/zebedee/issues/141","number":141,"state":"closed","locked":false,"title":"Set correct HTTP response codes for null session / collection","user":{"login":"CarlHembrough","id":1786012,"avatar_url":"https://avatars0.githubusercontent.com/u/1786012?v=4","gravatar_id":"","url":"https://api.github.com/users/CarlHembrough","html_url":"https://github.com/CarlHembrough","followers_url":"https://api.github.com/users/CarlHembrough/followers","following_url":"https://api.github.com/users/CarlHembrough/following{/other_user}","gists_url":"https://api.github.com/users/CarlHembrough/gists{/gist_id}","starred_url":"https://api.github.com/users/CarlHembrough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CarlHembrough/subscriptions","organizations_url":"https://api.github.com/users/CarlHembrough/orgs","repos_url":"https://api.github.com/users/CarlHembrough/repos","events_url":"https://api.github.com/users/CarlHembrough/events{/privacy}","received_events_url":"https://api.github.com/users/CarlHembrough/received_events","type":"User","site_admin":false},"body":"### What\r\n\r\n* add null check to getSession\r\n* refactor existing dataset service to not contain ZebedeeCmsService. This was only used to get collection instances, which now takes place in the HTTP handler.\r\n* pass the collection instance into the dataset service instead of the collectionId\r\n* add null check for getCollection, returning a 404 if not found.\r\n\r\n### How to review\r\n\r\nreview / run tests\r\n\r\n### Who can review\r\n\r\nAnyone","created_at":"2018-03-09T11:10:27Z","updated_at":"2018-03-12T11:56:26Z","closed_at":"2018-03-12T11:56:26Z","merged_at":"2018-03-12T11:56:26Z","merge_commit_sha":"9e0f113c9d7151d9973ee7d83da094f1aae0c756","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ONSdigital/zebedee/pulls/141/commits","review_comments_url":"https://api.github.com/repos/ONSdigital/zebedee/pulls/141/comments","review_comment_url":"https://api.github.com/repos/ONSdigital/zebedee/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ONSdigital/zebedee/issues/141/comments","statuses_url":"https://api.github.com/repos/ONSdigital/zebedee/statuses/9e0f113c9d7151d9973ee7d83da094f1aae0c756","head":{"label":"ONSdigital:fix/collection-status-codes","ref":"fix/collection-status-codes","sha":"9e0f113c9d7151d9973ee7d83da094f1aae0c756","user":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":31659554,"name":"zebedee","full_name":"ONSdigital/zebedee","owner":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ONSdigital/zebedee","description":"Simple CMS back-end","fork":false,"url":"https://api.github.com/repos/ONSdigital/zebedee","forks_url":"https://api.github.com/repos/ONSdigital/zebedee/forks","keys_url":"https://api.github.com/repos/ONSdigital/zebedee/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/zebedee/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/zebedee/teams","hooks_url":"https://api.github.com/repos/ONSdigital/zebedee/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/zebedee/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/zebedee/events","assignees_url":"https://api.github.com/repos/ONSdigital/zebedee/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/zebedee/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/zebedee/tags","blobs_url":"https://api.github.com/repos/ONSdigital/zebedee/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/zebedee/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/zebedee/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/zebedee/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/zebedee/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/zebedee/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/zebedee/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/zebedee/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/zebedee/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/zebedee/subscription","commits_url":"https://api.github.com/repos/ONSdigital/zebedee/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/zebedee/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/zebedee/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/zebedee/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/zebedee/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/zebedee/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/zebedee/merges","archive_url":"https://api.github.com/repos/ONSdigital/zebedee/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/zebedee/downloads","issues_url":"https://api.github.com/repos/ONSdigital/zebedee/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/zebedee/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/zebedee/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/zebedee/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/zebedee/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/zebedee/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/zebedee/deployments","created_at":"2015-03-04T13:56:34Z","updated_at":"2016-10-26T10:47:19Z","pushed_at":"2018-03-12T11:56:25Z","git_url":"git://github.com/ONSdigital/zebedee.git","ssh_url":"git@github.com:ONSdigital/zebedee.git","clone_url":"https://github.com/ONSdigital/zebedee.git","svn_url":"https://github.com/ONSdigital/zebedee","homepage":null,"size":22508,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":7,"license":null,"forks":0,"open_issues":7,"watchers":1,"default_branch":"develop"}},"base":{"label":"ONSdigital:cmd-develop","ref":"cmd-develop","sha":"fb62288571e20ec3bb4ef31e15ab2692876c7ad0","user":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":31659554,"name":"zebedee","full_name":"ONSdigital/zebedee","owner":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ONSdigital/zebedee","description":"Simple CMS back-end","fork":false,"url":"https://api.github.com/repos/ONSdigital/zebedee","forks_url":"https://api.github.com/repos/ONSdigital/zebedee/forks","keys_url":"https://api.github.com/repos/ONSdigital/zebedee/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/zebedee/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/zebedee/teams","hooks_url":"https://api.github.com/repos/ONSdigital/zebedee/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/zebedee/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/zebedee/events","assignees_url":"https://api.github.com/repos/ONSdigital/zebedee/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/zebedee/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/zebedee/tags","blobs_url":"https://api.github.com/repos/ONSdigital/zebedee/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/zebedee/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/zebedee/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/zebedee/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/zebedee/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/zebedee/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/zebedee/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/zebedee/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/zebedee/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/zebedee/subscription","commits_url":"https://api.github.com/repos/ONSdigital/zebedee/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/zebedee/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/zebedee/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/zebedee/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/zebedee/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/zebedee/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/zebedee/merges","archive_url":"https://api.github.com/repos/ONSdigital/zebedee/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/zebedee/downloads","issues_url":"https://api.github.com/repos/ONSdigital/zebedee/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/zebedee/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/zebedee/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/zebedee/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/zebedee/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/zebedee/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/zebedee/deployments","created_at":"2015-03-04T13:56:34Z","updated_at":"2016-10-26T10:47:19Z","pushed_at":"2018-03-12T11:56:25Z","git_url":"git://github.com/ONSdigital/zebedee.git","ssh_url":"git@github.com:ONSdigital/zebedee.git","clone_url":"https://github.com/ONSdigital/zebedee.git","svn_url":"https://github.com/ONSdigital/zebedee","homepage":null,"size":22508,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":7,"license":null,"forks":0,"open_issues":7,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ONSdigital/zebedee/pulls/141"},"html":{"href":"https://github.com/ONSdigital/zebedee/pull/141"},"issue":{"href":"https://api.github.com/repos/ONSdigital/zebedee/issues/141"},"comments":{"href":"https://api.github.com/repos/ONSdigital/zebedee/issues/141/comments"},"review_comments":{"href":"https://api.github.com/repos/ONSdigital/zebedee/pulls/141/comments"},"review_comment":{"href":"https://api.github.com/repos/ONSdigital/zebedee/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ONSdigital/zebedee/pulls/141/commits"},"statuses":{"href":"https://api.github.com/repos/ONSdigital/zebedee/statuses/9e0f113c9d7151d9973ee7d83da094f1aae0c756"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"CarlHembrough","id":1786012,"avatar_url":"https://avatars0.githubusercontent.com/u/1786012?v=4","gravatar_id":"","url":"https://api.github.com/users/CarlHembrough","html_url":"https://github.com/CarlHembrough","followers_url":"https://api.github.com/users/CarlHembrough/followers","following_url":"https://api.github.com/users/CarlHembrough/following{/other_user}","gists_url":"https://api.github.com/users/CarlHembrough/gists{/gist_id}","starred_url":"https://api.github.com/users/CarlHembrough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CarlHembrough/subscriptions","organizations_url":"https://api.github.com/users/CarlHembrough/orgs","repos_url":"https://api.github.com/users/CarlHembrough/repos","events_url":"https://api.github.com/users/CarlHembrough/events{/privacy}","received_events_url":"https://api.github.com/users/CarlHembrough/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":170,"deletions":167,"changed_files":7}}
{"actor":{"display_login":"CarlHembrough"}}