{"action":"created","issue":{"url":"https://api.github.com/repos/JMRI/JMRI/issues/6195","repository_url":"https://api.github.com/repos/JMRI/JMRI","labels_url":"https://api.github.com/repos/JMRI/JMRI/issues/6195/labels{/name}","comments_url":"https://api.github.com/repos/JMRI/JMRI/issues/6195/comments","events_url":"https://api.github.com/repos/JMRI/JMRI/issues/6195/events","html_url":"https://github.com/JMRI/JMRI/pull/6195","id":384119408,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNDAxMDQw","number":6195,"title":"Adds user-configurable settings for OpenLCB protocols","user":{"login":"balazsracz","id":3719690,"node_id":"MDQ6VXNlcjM3MTk2OTA=","avatar_url":"https://avatars1.githubusercontent.com/u/3719690?v=4","gravatar_id":"","url":"https://api.github.com/users/balazsracz","html_url":"https://github.com/balazsracz","followers_url":"https://api.github.com/users/balazsracz/followers","following_url":"https://api.github.com/users/balazsracz/following{/other_user}","gists_url":"https://api.github.com/users/balazsracz/gists{/gist_id}","starred_url":"https://api.github.com/users/balazsracz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balazsracz/subscriptions","organizations_url":"https://api.github.com/users/balazsracz/orgs","repos_url":"https://api.github.com/users/balazsracz/repos","events_url":"https://api.github.com/users/balazsracz/events{/privacy}","received_events_url":"https://api.github.com/users/balazsracz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-25T21:12:11Z","updated_at":"2018-11-25T21:34:02Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/JMRI/JMRI/pulls/6195","html_url":"https://github.com/JMRI/JMRI/pull/6195","diff_url":"https://github.com/JMRI/JMRI/pull/6195.diff","patch_url":"https://github.com/JMRI/JMRI/pull/6195.patch"},"body":"Adds a framework for setting protocol options for OpenLCB by the user:\r\n- adds a button in the Preferences -> Connection -> [OpenLCB connection tab] to open the protocol options\r\n- adds a new JmriFrame to have the user enter the options\r\n- there are tabs available for the different protocols to set options for (only one currently)\r\n- options are accessible to the protocol implementations via the CanSystemConnectionMemo\r\n- the options are persisted in the profile.xml under the XML element of the specific connection.\r\n\r\nAdds an initial set of options for node identification:\r\n- Node ID. If the user wishes to set a node ID, they can do that now instead of the automatically generated Node ID that JMRI uses so far.\r\n- Node User Name & Description. Specifies what should be reported in the SNIP reply. Allows identifying multiple JMRIs via the network browser.\r\n\r\nHaving the options in the SystemConnectionMemo and persisting in the <connection> of the profile.xml allows options that are different on a per-connection basis; for example a single JMRI could be connected to the same OpenLCB network twice with two different connections; those can then have different Node IDs."},"comment":{"url":"https://api.github.com/repos/JMRI/JMRI/issues/comments/441475570","html_url":"https://github.com/JMRI/JMRI/pull/6195#issuecomment-441475570","issue_url":"https://api.github.com/repos/JMRI/JMRI/issues/6195","id":441475570,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTQ3NTU3MA==","user":{"login":"bobjacobsen","id":2774117,"node_id":"MDQ6VXNlcjI3NzQxMTc=","avatar_url":"https://avatars1.githubusercontent.com/u/2774117?v=4","gravatar_id":"","url":"https://api.github.com/users/bobjacobsen","html_url":"https://github.com/bobjacobsen","followers_url":"https://api.github.com/users/bobjacobsen/followers","following_url":"https://api.github.com/users/bobjacobsen/following{/other_user}","gists_url":"https://api.github.com/users/bobjacobsen/gists{/gist_id}","starred_url":"https://api.github.com/users/bobjacobsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobjacobsen/subscriptions","organizations_url":"https://api.github.com/users/bobjacobsen/orgs","repos_url":"https://api.github.com/users/bobjacobsen/repos","events_url":"https://api.github.com/users/bobjacobsen/events{/privacy}","received_events_url":"https://api.github.com/users/bobjacobsen/received_events","type":"User","site_admin":false},"created_at":"2018-11-25T21:34:02Z","updated_at":"2018-11-25T21:34:02Z","author_association":"MEMBER","body":"\r\nWhen I create a new connection (using the HEAD of this branch) with mfg: OpenLCB, connection: CAN via GridConnect adapter and then click the \"Protocol settings\" button, I get a minimalized frame:\r\n\r\n![image](https://user-images.githubusercontent.com/2774117/48984785-1fea5d80-f0b5-11e8-9cfe-5a2bd64c102d.png)\r\n\r\nI can expand it, and it then looks OK:\r\n![image](https://user-images.githubusercontent.com/2774117/48984827-b7e84700-f0b5-11e8-84e3-5db70e7e5c40.png)\r\n\r\nBut the \"Ctrl+F1\" doesn't seem to work on my MacBook Pro.  At least, it doesn't seem to do anything.  The tooltips do surface fine."}}
{"actor":{"display_login":"bobjacobsen"}}