{"action":"created","comment":{"url":"https://api.github.com/repos/perry-mitchell/ads.txt/pulls/comments/186300396","pull_request_review_id":117852999,"id":186300396,"diff_hunk":"@@ -78,9 +78,8 @@ function generateAdsTxt(manifest, header, footer) {\n }\n \n function generateLineForField(field) {\n-    const domainExp = getDomainRegex();\n     const { domain, publisherAccountID, accountType, certificateAuthorityID, comment } = field;\n-    if (domainExp.test(domain) !== true) {\n+    if (!isDomainName(domain, false)) {","path":"source/index.js","position":15,"original_position":15,"commit_id":"dc89b2e3d2a4bdc0da6369152895e0599d9261e0","original_commit_id":"dc89b2e3d2a4bdc0da6369152895e0599d9261e0","user":{"login":"perry-mitchell","id":3869469,"avatar_url":"https://avatars0.githubusercontent.com/u/3869469?v=4","gravatar_id":"","url":"https://api.github.com/users/perry-mitchell","html_url":"https://github.com/perry-mitchell","followers_url":"https://api.github.com/users/perry-mitchell/followers","following_url":"https://api.github.com/users/perry-mitchell/following{/other_user}","gists_url":"https://api.github.com/users/perry-mitchell/gists{/gist_id}","starred_url":"https://api.github.com/users/perry-mitchell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perry-mitchell/subscriptions","organizations_url":"https://api.github.com/users/perry-mitchell/orgs","repos_url":"https://api.github.com/users/perry-mitchell/repos","events_url":"https://api.github.com/users/perry-mitchell/events{/privacy}","received_events_url":"https://api.github.com/users/perry-mitchell/received_events","type":"User","site_admin":false},"body":"Ok, I thought we were going to use is-valid-domain instead?\r\n\r\nIf you keep `is-domain-name`, the `false` as the second parameter isn't required, as it's the default value.","created_at":"2018-05-06T19:27:50Z","updated_at":"2018-05-06T19:27:54Z","html_url":"https://github.com/perry-mitchell/ads.txt/pull/3#discussion_r186300396","pull_request_url":"https://api.github.com/repos/perry-mitchell/ads.txt/pulls/3","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/perry-mitchell/ads.txt/pulls/comments/186300396"},"html":{"href":"https://github.com/perry-mitchell/ads.txt/pull/3#discussion_r186300396"},"pull_request":{"href":"https://api.github.com/repos/perry-mitchell/ads.txt/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/perry-mitchell/ads.txt/pulls/3","id":186220669,"html_url":"https://github.com/perry-mitchell/ads.txt/pull/3","diff_url":"https://github.com/perry-mitchell/ads.txt/pull/3.diff","patch_url":"https://github.com/perry-mitchell/ads.txt/pull/3.patch","issue_url":"https://api.github.com/repos/perry-mitchell/ads.txt/issues/3","number":3,"state":"open","locked":false,"title":"Case-insensitive treatment added to Field #1 and Field #3","user":{"login":"andrewmolyuk","id":3962313,"avatar_url":"https://avatars3.githubusercontent.com/u/3962313?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewmolyuk","html_url":"https://github.com/andrewmolyuk","followers_url":"https://api.github.com/users/andrewmolyuk/followers","following_url":"https://api.github.com/users/andrewmolyuk/following{/other_user}","gists_url":"https://api.github.com/users/andrewmolyuk/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewmolyuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewmolyuk/subscriptions","organizations_url":"https://api.github.com/users/andrewmolyuk/orgs","repos_url":"https://api.github.com/users/andrewmolyuk/repos","events_url":"https://api.github.com/users/andrewmolyuk/events{/privacy}","received_events_url":"https://api.github.com/users/andrewmolyuk/received_events","type":"User","site_admin":false},"body":"Dependency on domain-regex was removed as incorrect.","created_at":"2018-05-06T18:56:52Z","updated_at":"2018-05-06T19:27:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d9e700f696cb45fb92e9bd47d2f11ae8f468b85b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/perry-mitchell/ads.txt/pulls/3/commits","review_comments_url":"https://api.github.com/repos/perry-mitchell/ads.txt/pulls/3/comments","review_comment_url":"https://api.github.com/repos/perry-mitchell/ads.txt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/perry-mitchell/ads.txt/issues/3/comments","statuses_url":"https://api.github.com/repos/perry-mitchell/ads.txt/statuses/dc89b2e3d2a4bdc0da6369152895e0599d9261e0","head":{"label":"andrewmolyuk:case-insensitive","ref":"case-insensitive","sha":"dc89b2e3d2a4bdc0da6369152895e0599d9261e0","user":{"login":"andrewmolyuk","id":3962313,"avatar_url":"https://avatars3.githubusercontent.com/u/3962313?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewmolyuk","html_url":"https://github.com/andrewmolyuk","followers_url":"https://api.github.com/users/andrewmolyuk/followers","following_url":"https://api.github.com/users/andrewmolyuk/following{/other_user}","gists_url":"https://api.github.com/users/andrewmolyuk/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewmolyuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewmolyuk/subscriptions","organizations_url":"https://api.github.com/users/andrewmolyuk/orgs","repos_url":"https://api.github.com/users/andrewmolyuk/repos","events_url":"https://api.github.com/users/andrewmolyuk/events{/privacy}","received_events_url":"https://api.github.com/users/andrewmolyuk/received_events","type":"User","site_admin":false},"repo":{"id":132363798,"name":"ads.txt","full_name":"andrewmolyuk/ads.txt","owner":{"login":"andrewmolyuk","id":3962313,"avatar_url":"https://avatars3.githubusercontent.com/u/3962313?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewmolyuk","html_url":"https://github.com/andrewmolyuk","followers_url":"https://api.github.com/users/andrewmolyuk/followers","following_url":"https://api.github.com/users/andrewmolyuk/following{/other_user}","gists_url":"https://api.github.com/users/andrewmolyuk/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewmolyuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewmolyuk/subscriptions","organizations_url":"https://api.github.com/users/andrewmolyuk/orgs","repos_url":"https://api.github.com/users/andrewmolyuk/repos","events_url":"https://api.github.com/users/andrewmolyuk/events{/privacy}","received_events_url":"https://api.github.com/users/andrewmolyuk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrewmolyuk/ads.txt","description":"Ads.txt parser/generator","fork":true,"url":"https://api.github.com/repos/andrewmolyuk/ads.txt","forks_url":"https://api.github.com/repos/andrewmolyuk/ads.txt/forks","keys_url":"https://api.github.com/repos/andrewmolyuk/ads.txt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewmolyuk/ads.txt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewmolyuk/ads.txt/teams","hooks_url":"https://api.github.com/repos/andrewmolyuk/ads.txt/hooks","issue_events_url":"https://api.github.com/repos/andrewmolyuk/ads.txt/issues/events{/number}","events_url":"https://api.github.com/repos/andrewmolyuk/ads.txt/events","assignees_url":"https://api.github.com/repos/andrewmolyuk/ads.txt/assignees{/user}","branches_url":"https://api.github.com/repos/andrewmolyuk/ads.txt/branches{/branch}","tags_url":"https://api.github.com/repos/andrewmolyuk/ads.txt/tags","blobs_url":"https://api.github.com/repos/andrewmolyuk/ads.txt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewmolyuk/ads.txt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewmolyuk/ads.txt/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewmolyuk/ads.txt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewmolyuk/ads.txt/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewmolyuk/ads.txt/languages","stargazers_url":"https://api.github.com/repos/andrewmolyuk/ads.txt/stargazers","contributors_url":"https://api.github.com/repos/andrewmolyuk/ads.txt/contributors","subscribers_url":"https://api.github.com/repos/andrewmolyuk/ads.txt/subscribers","subscription_url":"https://api.github.com/repos/andrewmolyuk/ads.txt/subscription","commits_url":"https://api.github.com/repos/andrewmolyuk/ads.txt/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewmolyuk/ads.txt/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewmolyuk/ads.txt/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewmolyuk/ads.txt/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewmolyuk/ads.txt/contents/{+path}","compare_url":"https://api.github.com/repos/andrewmolyuk/ads.txt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewmolyuk/ads.txt/merges","archive_url":"https://api.github.com/repos/andrewmolyuk/ads.txt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewmolyuk/ads.txt/downloads","issues_url":"https://api.github.com/repos/andrewmolyuk/ads.txt/issues{/number}","pulls_url":"https://api.github.com/repos/andrewmolyuk/ads.txt/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewmolyuk/ads.txt/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewmolyuk/ads.txt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewmolyuk/ads.txt/labels{/name}","releases_url":"https://api.github.com/repos/andrewmolyuk/ads.txt/releases{/id}","deployments_url":"https://api.github.com/repos/andrewmolyuk/ads.txt/deployments","created_at":"2018-05-06T18:09:19Z","updated_at":"2018-05-06T19:05:00Z","pushed_at":"2018-05-06T19:23:40Z","git_url":"git://github.com/andrewmolyuk/ads.txt.git","ssh_url":"git@github.com:andrewmolyuk/ads.txt.git","clone_url":"https://github.com/andrewmolyuk/ads.txt.git","svn_url":"https://github.com/andrewmolyuk/ads.txt","homepage":"","size":85,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"perry-mitchell:master","ref":"master","sha":"f3410afdb13ed7abbf9e5d443b50d0177388ccd4","user":{"login":"perry-mitchell","id":3869469,"avatar_url":"https://avatars0.githubusercontent.com/u/3869469?v=4","gravatar_id":"","url":"https://api.github.com/users/perry-mitchell","html_url":"https://github.com/perry-mitchell","followers_url":"https://api.github.com/users/perry-mitchell/followers","following_url":"https://api.github.com/users/perry-mitchell/following{/other_user}","gists_url":"https://api.github.com/users/perry-mitchell/gists{/gist_id}","starred_url":"https://api.github.com/users/perry-mitchell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perry-mitchell/subscriptions","organizations_url":"https://api.github.com/users/perry-mitchell/orgs","repos_url":"https://api.github.com/users/perry-mitchell/repos","events_url":"https://api.github.com/users/perry-mitchell/events{/privacy}","received_events_url":"https://api.github.com/users/perry-mitchell/received_events","type":"User","site_admin":false},"repo":{"id":110521846,"name":"ads.txt","full_name":"perry-mitchell/ads.txt","owner":{"login":"perry-mitchell","id":3869469,"avatar_url":"https://avatars0.githubusercontent.com/u/3869469?v=4","gravatar_id":"","url":"https://api.github.com/users/perry-mitchell","html_url":"https://github.com/perry-mitchell","followers_url":"https://api.github.com/users/perry-mitchell/followers","following_url":"https://api.github.com/users/perry-mitchell/following{/other_user}","gists_url":"https://api.github.com/users/perry-mitchell/gists{/gist_id}","starred_url":"https://api.github.com/users/perry-mitchell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perry-mitchell/subscriptions","organizations_url":"https://api.github.com/users/perry-mitchell/orgs","repos_url":"https://api.github.com/users/perry-mitchell/repos","events_url":"https://api.github.com/users/perry-mitchell/events{/privacy}","received_events_url":"https://api.github.com/users/perry-mitchell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/perry-mitchell/ads.txt","description":"Ads.txt parser/generator","fork":false,"url":"https://api.github.com/repos/perry-mitchell/ads.txt","forks_url":"https://api.github.com/repos/perry-mitchell/ads.txt/forks","keys_url":"https://api.github.com/repos/perry-mitchell/ads.txt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/perry-mitchell/ads.txt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/perry-mitchell/ads.txt/teams","hooks_url":"https://api.github.com/repos/perry-mitchell/ads.txt/hooks","issue_events_url":"https://api.github.com/repos/perry-mitchell/ads.txt/issues/events{/number}","events_url":"https://api.github.com/repos/perry-mitchell/ads.txt/events","assignees_url":"https://api.github.com/repos/perry-mitchell/ads.txt/assignees{/user}","branches_url":"https://api.github.com/repos/perry-mitchell/ads.txt/branches{/branch}","tags_url":"https://api.github.com/repos/perry-mitchell/ads.txt/tags","blobs_url":"https://api.github.com/repos/perry-mitchell/ads.txt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/perry-mitchell/ads.txt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/perry-mitchell/ads.txt/git/refs{/sha}","trees_url":"https://api.github.com/repos/perry-mitchell/ads.txt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/perry-mitchell/ads.txt/statuses/{sha}","languages_url":"https://api.github.com/repos/perry-mitchell/ads.txt/languages","stargazers_url":"https://api.github.com/repos/perry-mitchell/ads.txt/stargazers","contributors_url":"https://api.github.com/repos/perry-mitchell/ads.txt/contributors","subscribers_url":"https://api.github.com/repos/perry-mitchell/ads.txt/subscribers","subscription_url":"https://api.github.com/repos/perry-mitchell/ads.txt/subscription","commits_url":"https://api.github.com/repos/perry-mitchell/ads.txt/commits{/sha}","git_commits_url":"https://api.github.com/repos/perry-mitchell/ads.txt/git/commits{/sha}","comments_url":"https://api.github.com/repos/perry-mitchell/ads.txt/comments{/number}","issue_comment_url":"https://api.github.com/repos/perry-mitchell/ads.txt/issues/comments{/number}","contents_url":"https://api.github.com/repos/perry-mitchell/ads.txt/contents/{+path}","compare_url":"https://api.github.com/repos/perry-mitchell/ads.txt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/perry-mitchell/ads.txt/merges","archive_url":"https://api.github.com/repos/perry-mitchell/ads.txt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/perry-mitchell/ads.txt/downloads","issues_url":"https://api.github.com/repos/perry-mitchell/ads.txt/issues{/number}","pulls_url":"https://api.github.com/repos/perry-mitchell/ads.txt/pulls{/number}","milestones_url":"https://api.github.com/repos/perry-mitchell/ads.txt/milestones{/number}","notifications_url":"https://api.github.com/repos/perry-mitchell/ads.txt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/perry-mitchell/ads.txt/labels{/name}","releases_url":"https://api.github.com/repos/perry-mitchell/ads.txt/releases{/id}","deployments_url":"https://api.github.com/repos/perry-mitchell/ads.txt/deployments","created_at":"2017-11-13T08:38:30Z","updated_at":"2018-04-20T09:41:38Z","pushed_at":"2018-05-06T19:23:42Z","git_url":"git://github.com/perry-mitchell/ads.txt.git","ssh_url":"git@github.com:perry-mitchell/ads.txt.git","clone_url":"https://github.com/perry-mitchell/ads.txt.git","svn_url":"https://github.com/perry-mitchell/ads.txt","homepage":"","size":85,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/perry-mitchell/ads.txt/pulls/3"},"html":{"href":"https://github.com/perry-mitchell/ads.txt/pull/3"},"issue":{"href":"https://api.github.com/repos/perry-mitchell/ads.txt/issues/3"},"comments":{"href":"https://api.github.com/repos/perry-mitchell/ads.txt/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/perry-mitchell/ads.txt/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/perry-mitchell/ads.txt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/perry-mitchell/ads.txt/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/perry-mitchell/ads.txt/statuses/dc89b2e3d2a4bdc0da6369152895e0599d9261e0"}},"author_association":"NONE"}}
{"actor":{"display_login":"perry-mitchell"}}