{"action":"created","comment":{"url":"https://api.github.com/repos/minetest/minetest/pulls/comments/179923331","pull_request_review_id":110262242,"id":179923331,"diff_hunk":"@@ -386,14 +386,21 @@ class TextureSource : public IWritableTextureSource\n \n \t// Generate image based on a string like \"stone.png\" or \"[crack:1:0\".\n \t// if baseimg is NULL, it is created. Otherwise stuff is made on it.\n-\tbool generateImagePart(std::string part_of_name, video::IImage *& baseimg);\n+\tbool generateImagePart(std::string part_of_name, video::IImage *& baseimg,\n+\t\tbool normalmap_found);\n \n+\tenum normal_presence {\n+\t\tNORMAL_ABSENT,\n+\t\tNORMAL_PRESENT,\n+\t\tNORMAL_UNKNOWN,\n+\t};\n \t/*! Generates an image from a full string like\n \t * \"stone.png^mineral_coal.png^[crack:1:0\".\n \t * Shall be called from the main thread.\n \t * The returned Image should be dropped.\n \t */\n-\tvideo::IImage* generateImage(const std::string &name);\n+\tvideo::IImage* generateImage(const std::string &name,\n+\t\tnormal_presence is_normalmap = NORMAL_UNKNOWN);","path":"src/client/tile.cpp","position":20,"original_position":20,"commit_id":"92685e80d8ed04815b66ed99ce0046ae5204ad8a","original_commit_id":"92685e80d8ed04815b66ed99ce0046ae5204ad8a","user":{"login":"SmallJoker","id":1497498,"avatar_url":"https://avatars1.githubusercontent.com/u/1497498?v=4","gravatar_id":"","url":"https://api.github.com/users/SmallJoker","html_url":"https://github.com/SmallJoker","followers_url":"https://api.github.com/users/SmallJoker/followers","following_url":"https://api.github.com/users/SmallJoker/following{/other_user}","gists_url":"https://api.github.com/users/SmallJoker/gists{/gist_id}","starred_url":"https://api.github.com/users/SmallJoker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmallJoker/subscriptions","organizations_url":"https://api.github.com/users/SmallJoker/orgs","repos_url":"https://api.github.com/users/SmallJoker/repos","events_url":"https://api.github.com/users/SmallJoker/events{/privacy}","received_events_url":"https://api.github.com/users/SmallJoker/received_events","type":"User","site_admin":false},"body":"Pointer misplaced (touched line)\r\n`is_normalmap` sounds like a boolean value, but it's an enum. How about `image_type` or `image_info`?","created_at":"2018-04-07T17:45:09Z","updated_at":"2018-04-07T17:45:09Z","html_url":"https://github.com/minetest/minetest/pull/7144#discussion_r179923331","pull_request_url":"https://api.github.com/repos/minetest/minetest/pulls/7144","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments/179923331"},"html":{"href":"https://github.com/minetest/minetest/pull/7144#discussion_r179923331"},"pull_request":{"href":"https://api.github.com/repos/minetest/minetest/pulls/7144"}}},"pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/7144","id":175742803,"html_url":"https://github.com/minetest/minetest/pull/7144","diff_url":"https://github.com/minetest/minetest/pull/7144.diff","patch_url":"https://github.com/minetest/minetest/pull/7144.patch","issue_url":"https://api.github.com/repos/minetest/minetest/issues/7144","number":7144,"state":"open","locked":false,"title":"Normalmaps: Apply only specific texture modifiers","user":{"login":"HybridDog","id":3192173,"avatar_url":"https://avatars2.githubusercontent.com/u/3192173?v=4","gravatar_id":"","url":"https://api.github.com/users/HybridDog","html_url":"https://github.com/HybridDog","followers_url":"https://api.github.com/users/HybridDog/followers","following_url":"https://api.github.com/users/HybridDog/following{/other_user}","gists_url":"https://api.github.com/users/HybridDog/gists{/gist_id}","starred_url":"https://api.github.com/users/HybridDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HybridDog/subscriptions","organizations_url":"https://api.github.com/users/HybridDog/orgs","repos_url":"https://api.github.com/users/HybridDog/repos","events_url":"https://api.github.com/users/HybridDog/events{/privacy}","received_events_url":"https://api.github.com/users/HybridDog/received_events","type":"User","site_admin":false},"body":"Texture modifiers such as colorize must not be applied on normalmaps, however something like transform (e.g. rotating) should be applied.\r\nAdditionally texture modifiers are not longer attempted to be applied on missing normalmap images, this fixes error messages.\r\nThe error log regarding a missing result image is also disabled for normalmaps because normalmaps are optional.\r\n\r\nThis should fix #3217","created_at":"2018-03-18T09:43:22Z","updated_at":"2018-04-07T17:45:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8397431f9dd46ab241cdeba64a893f9e0f7b8559","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":73369003,"url":"https://api.github.com/repos/minetest/minetest/labels/@%20Client%20/%20Audiovisuals","name":"@ Client / Audiovisuals","color":"0e8a16","default":false},{"id":372290178,"url":"https://api.github.com/repos/minetest/minetest/labels/Bugfix","name":"Bugfix","color":"c5def5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/minetest/minetest/pulls/7144/commits","review_comments_url":"https://api.github.com/repos/minetest/minetest/pulls/7144/comments","review_comment_url":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/7144/comments","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/92685e80d8ed04815b66ed99ce0046ae5204ad8a","head":{"label":"HybridDog:normalmap_modifier_fix","ref":"normalmap_modifier_fix","sha":"92685e80d8ed04815b66ed99ce0046ae5204ad8a","user":{"login":"HybridDog","id":3192173,"avatar_url":"https://avatars2.githubusercontent.com/u/3192173?v=4","gravatar_id":"","url":"https://api.github.com/users/HybridDog","html_url":"https://github.com/HybridDog","followers_url":"https://api.github.com/users/HybridDog/followers","following_url":"https://api.github.com/users/HybridDog/following{/other_user}","gists_url":"https://api.github.com/users/HybridDog/gists{/gist_id}","starred_url":"https://api.github.com/users/HybridDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HybridDog/subscriptions","organizations_url":"https://api.github.com/users/HybridDog/orgs","repos_url":"https://api.github.com/users/HybridDog/repos","events_url":"https://api.github.com/users/HybridDog/events{/privacy}","received_events_url":"https://api.github.com/users/HybridDog/received_events","type":"User","site_admin":false},"repo":{"id":11761683,"name":"minetest","full_name":"HybridDog/minetest","owner":{"login":"HybridDog","id":3192173,"avatar_url":"https://avatars2.githubusercontent.com/u/3192173?v=4","gravatar_id":"","url":"https://api.github.com/users/HybridDog","html_url":"https://github.com/HybridDog","followers_url":"https://api.github.com/users/HybridDog/followers","following_url":"https://api.github.com/users/HybridDog/following{/other_user}","gists_url":"https://api.github.com/users/HybridDog/gists{/gist_id}","starred_url":"https://api.github.com/users/HybridDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HybridDog/subscriptions","organizations_url":"https://api.github.com/users/HybridDog/orgs","repos_url":"https://api.github.com/users/HybridDog/repos","events_url":"https://api.github.com/users/HybridDog/events{/privacy}","received_events_url":"https://api.github.com/users/HybridDog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HybridDog/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":true,"url":"https://api.github.com/repos/HybridDog/minetest","forks_url":"https://api.github.com/repos/HybridDog/minetest/forks","keys_url":"https://api.github.com/repos/HybridDog/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HybridDog/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HybridDog/minetest/teams","hooks_url":"https://api.github.com/repos/HybridDog/minetest/hooks","issue_events_url":"https://api.github.com/repos/HybridDog/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/HybridDog/minetest/events","assignees_url":"https://api.github.com/repos/HybridDog/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/HybridDog/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/HybridDog/minetest/tags","blobs_url":"https://api.github.com/repos/HybridDog/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HybridDog/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HybridDog/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/HybridDog/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HybridDog/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/HybridDog/minetest/languages","stargazers_url":"https://api.github.com/repos/HybridDog/minetest/stargazers","contributors_url":"https://api.github.com/repos/HybridDog/minetest/contributors","subscribers_url":"https://api.github.com/repos/HybridDog/minetest/subscribers","subscription_url":"https://api.github.com/repos/HybridDog/minetest/subscription","commits_url":"https://api.github.com/repos/HybridDog/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/HybridDog/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/HybridDog/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/HybridDog/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/HybridDog/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/HybridDog/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HybridDog/minetest/merges","archive_url":"https://api.github.com/repos/HybridDog/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HybridDog/minetest/downloads","issues_url":"https://api.github.com/repos/HybridDog/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/HybridDog/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/HybridDog/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/HybridDog/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HybridDog/minetest/labels{/name}","releases_url":"https://api.github.com/repos/HybridDog/minetest/releases{/id}","deployments_url":"https://api.github.com/repos/HybridDog/minetest/deployments","created_at":"2013-07-30T09:40:51Z","updated_at":"2016-02-10T21:28:13Z","pushed_at":"2018-04-02T17:02:46Z","git_url":"git://github.com/HybridDog/minetest.git","ssh_url":"git@github.com:HybridDog/minetest.git","clone_url":"https://github.com/HybridDog/minetest.git","svn_url":"https://github.com/HybridDog/minetest","homepage":"http://minetest.net/","size":56704,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minetest:master","ref":"master","sha":"93eb0794d6f7366df5fb375855b2e5e5888304c6","user":{"login":"minetest","id":2624745,"avatar_url":"https://avatars1.githubusercontent.com/u/2624745?v=4","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"repo":{"id":2168780,"name":"minetest","full_name":"minetest/minetest","owner":{"login":"minetest","id":2624745,"avatar_url":"https://avatars1.githubusercontent.com/u/2624745?v=4","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minetest/minetest","description":"Minetest, an open source infinite-world block sandbox game engine with support for survival and crafting. Also see https://github.com/minetest/minetest_game","fork":false,"url":"https://api.github.com/repos/minetest/minetest","forks_url":"https://api.github.com/repos/minetest/minetest/forks","keys_url":"https://api.github.com/repos/minetest/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minetest/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minetest/minetest/teams","hooks_url":"https://api.github.com/repos/minetest/minetest/hooks","issue_events_url":"https://api.github.com/repos/minetest/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/minetest/minetest/events","assignees_url":"https://api.github.com/repos/minetest/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/minetest/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/minetest/minetest/tags","blobs_url":"https://api.github.com/repos/minetest/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minetest/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minetest/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/minetest/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/minetest/minetest/languages","stargazers_url":"https://api.github.com/repos/minetest/minetest/stargazers","contributors_url":"https://api.github.com/repos/minetest/minetest/contributors","subscribers_url":"https://api.github.com/repos/minetest/minetest/subscribers","subscription_url":"https://api.github.com/repos/minetest/minetest/subscription","commits_url":"https://api.github.com/repos/minetest/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/minetest/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/minetest/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/minetest/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/minetest/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/minetest/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minetest/minetest/merges","archive_url":"https://api.github.com/repos/minetest/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minetest/minetest/downloads","issues_url":"https://api.github.com/repos/minetest/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/minetest/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/minetest/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/minetest/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minetest/minetest/labels{/name}","releases_url":"https://api.github.com/repos/minetest/minetest/releases{/id}","deployments_url":"https://api.github.com/repos/minetest/minetest/deployments","created_at":"2011-08-07T13:48:36Z","updated_at":"2018-04-07T14:02:20Z","pushed_at":"2018-04-07T13:49:36Z","git_url":"git://github.com/minetest/minetest.git","ssh_url":"git@github.com:minetest/minetest.git","clone_url":"https://github.com/minetest/minetest.git","svn_url":"https://github.com/minetest/minetest","homepage":"http://minetest.net/","size":56650,"stargazers_count":3213,"watchers_count":3213,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":893,"mirror_url":null,"archived":false,"open_issues_count":901,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":893,"open_issues":901,"watchers":3213,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/7144"},"html":{"href":"https://github.com/minetest/minetest/pull/7144"},"issue":{"href":"https://api.github.com/repos/minetest/minetest/issues/7144"},"comments":{"href":"https://api.github.com/repos/minetest/minetest/issues/7144/comments"},"review_comments":{"href":"https://api.github.com/repos/minetest/minetest/pulls/7144/comments"},"review_comment":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minetest/minetest/pulls/7144/commits"},"statuses":{"href":"https://api.github.com/repos/minetest/minetest/statuses/92685e80d8ed04815b66ed99ce0046ae5204ad8a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"SmallJoker"}}