{"action":"closed","number":3455,"pull_request":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/3455","id":166615933,"html_url":"https://github.com/facebook/rocksdb/pull/3455","diff_url":"https://github.com/facebook/rocksdb/pull/3455.diff","patch_url":"https://github.com/facebook/rocksdb/pull/3455.patch","issue_url":"https://api.github.com/repos/facebook/rocksdb/issues/3455","number":3455,"state":"closed","locked":false,"title":" WritePrepared Txn: Duplicate Keys, Txn Part","user":{"login":"maysamyabandeh","id":1167741,"avatar_url":"https://avatars2.githubusercontent.com/u/1167741?v=4","gravatar_id":"","url":"https://api.github.com/users/maysamyabandeh","html_url":"https://github.com/maysamyabandeh","followers_url":"https://api.github.com/users/maysamyabandeh/followers","following_url":"https://api.github.com/users/maysamyabandeh/following{/other_user}","gists_url":"https://api.github.com/users/maysamyabandeh/gists{/gist_id}","starred_url":"https://api.github.com/users/maysamyabandeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maysamyabandeh/subscriptions","organizations_url":"https://api.github.com/users/maysamyabandeh/orgs","repos_url":"https://api.github.com/users/maysamyabandeh/repos","events_url":"https://api.github.com/users/maysamyabandeh/events{/privacy}","received_events_url":"https://api.github.com/users/maysamyabandeh/received_events","type":"User","site_admin":false},"body":"This patch takes advantage of memtable being able to detect duplicate <key,seq> and returning TryAgain to handle duplicate keys in WritePrepared Txns. Through WriteBatchWithIndex's index it detects existence of at least a duplicate key in the write batch. If duplicate key was reported, it then pays the cost of counting the number of sub-patches by iterating over the write batch and pass it to DBImpl::Write. DB will make use of the provided batch_count to assign proper sequence numbers before sending them to the WAL. When later inserting the batch to the memtable, it increases the seq each time memtbale reports a duplicate (a sub-patch in our counting) and tries again.","created_at":"2018-02-01T18:27:53Z","updated_at":"2018-02-06T02:43:40Z","closed_at":"2018-02-06T02:43:40Z","merged_at":null,"merge_commit_sha":"36eb478f7dd569b2e8a2c373e259ba1398b08369","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/rocksdb/pulls/3455/commits","review_comments_url":"https://api.github.com/repos/facebook/rocksdb/pulls/3455/comments","review_comment_url":"https://api.github.com/repos/facebook/rocksdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/rocksdb/issues/3455/comments","statuses_url":"https://api.github.com/repos/facebook/rocksdb/statuses/c6a2b24a3cb80b95ca66abc629486d44356cf9ad","head":{"label":"maysamyabandeh:duplicatekey-rebased-db","ref":"duplicatekey-rebased-db","sha":"c6a2b24a3cb80b95ca66abc629486d44356cf9ad","user":{"login":"maysamyabandeh","id":1167741,"avatar_url":"https://avatars2.githubusercontent.com/u/1167741?v=4","gravatar_id":"","url":"https://api.github.com/users/maysamyabandeh","html_url":"https://github.com/maysamyabandeh","followers_url":"https://api.github.com/users/maysamyabandeh/followers","following_url":"https://api.github.com/users/maysamyabandeh/following{/other_user}","gists_url":"https://api.github.com/users/maysamyabandeh/gists{/gist_id}","starred_url":"https://api.github.com/users/maysamyabandeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maysamyabandeh/subscriptions","organizations_url":"https://api.github.com/users/maysamyabandeh/orgs","repos_url":"https://api.github.com/users/maysamyabandeh/repos","events_url":"https://api.github.com/users/maysamyabandeh/events{/privacy}","received_events_url":"https://api.github.com/users/maysamyabandeh/received_events","type":"User","site_admin":false},"repo":{"id":73221890,"name":"rocksdb","full_name":"maysamyabandeh/rocksdb","owner":{"login":"maysamyabandeh","id":1167741,"avatar_url":"https://avatars2.githubusercontent.com/u/1167741?v=4","gravatar_id":"","url":"https://api.github.com/users/maysamyabandeh","html_url":"https://github.com/maysamyabandeh","followers_url":"https://api.github.com/users/maysamyabandeh/followers","following_url":"https://api.github.com/users/maysamyabandeh/following{/other_user}","gists_url":"https://api.github.com/users/maysamyabandeh/gists{/gist_id}","starred_url":"https://api.github.com/users/maysamyabandeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maysamyabandeh/subscriptions","organizations_url":"https://api.github.com/users/maysamyabandeh/orgs","repos_url":"https://api.github.com/users/maysamyabandeh/repos","events_url":"https://api.github.com/users/maysamyabandeh/events{/privacy}","received_events_url":"https://api.github.com/users/maysamyabandeh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maysamyabandeh/rocksdb","description":"A library that provides an embeddable, persistent key-value store for fast storage.","fork":true,"url":"https://api.github.com/repos/maysamyabandeh/rocksdb","forks_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/forks","keys_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/teams","hooks_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/hooks","issue_events_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/events","assignees_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/tags","blobs_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/languages","stargazers_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/stargazers","contributors_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/contributors","subscribers_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/subscribers","subscription_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/subscription","commits_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/merges","archive_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/downloads","issues_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/releases{/id}","deployments_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/deployments","created_at":"2016-11-08T19:56:13Z","updated_at":"2016-11-08T19:56:19Z","pushed_at":"2018-02-06T00:14:46Z","git_url":"git://github.com/maysamyabandeh/rocksdb.git","ssh_url":"git@github.com:maysamyabandeh/rocksdb.git","clone_url":"https://github.com/maysamyabandeh/rocksdb.git","svn_url":"https://github.com/maysamyabandeh/rocksdb","homepage":"http://rocksdb.org","size":109293,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"b78ed0460b7f16013e62f72a0253eb98220a0965","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":6934395,"name":"rocksdb","full_name":"facebook/rocksdb","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/rocksdb","description":"A library that provides an embeddable, persistent key-value store for fast storage.","fork":false,"url":"https://api.github.com/repos/facebook/rocksdb","forks_url":"https://api.github.com/repos/facebook/rocksdb/forks","keys_url":"https://api.github.com/repos/facebook/rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/rocksdb/teams","hooks_url":"https://api.github.com/repos/facebook/rocksdb/hooks","issue_events_url":"https://api.github.com/repos/facebook/rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/rocksdb/events","assignees_url":"https://api.github.com/repos/facebook/rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/rocksdb/tags","blobs_url":"https://api.github.com/repos/facebook/rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/rocksdb/languages","stargazers_url":"https://api.github.com/repos/facebook/rocksdb/stargazers","contributors_url":"https://api.github.com/repos/facebook/rocksdb/contributors","subscribers_url":"https://api.github.com/repos/facebook/rocksdb/subscribers","subscription_url":"https://api.github.com/repos/facebook/rocksdb/subscription","commits_url":"https://api.github.com/repos/facebook/rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/rocksdb/merges","archive_url":"https://api.github.com/repos/facebook/rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/rocksdb/downloads","issues_url":"https://api.github.com/repos/facebook/rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/facebook/rocksdb/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/rocksdb/deployments","created_at":"2012-11-30T06:16:18Z","updated_at":"2018-02-06T01:44:54Z","pushed_at":"2018-02-06T02:43:35Z","git_url":"git://github.com/facebook/rocksdb.git","ssh_url":"git@github.com:facebook/rocksdb.git","clone_url":"https://github.com/facebook/rocksdb.git","svn_url":"https://github.com/facebook/rocksdb","homepage":"http://rocksdb.org","size":111286,"stargazers_count":9681,"watchers_count":9681,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2141,"mirror_url":null,"archived":false,"open_issues_count":137,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":2141,"open_issues":137,"watchers":9681,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/3455"},"html":{"href":"https://github.com/facebook/rocksdb/pull/3455"},"issue":{"href":"https://api.github.com/repos/facebook/rocksdb/issues/3455"},"comments":{"href":"https://api.github.com/repos/facebook/rocksdb/issues/3455/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/3455/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/3455/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/rocksdb/statuses/c6a2b24a3cb80b95ca66abc629486d44356cf9ad"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":3,"review_comments":23,"maintainer_can_modify":false,"commits":10,"additions":701,"deletions":247,"changed_files":18}}
{"actor":{"display_login":"facebook-github-bot"}}