{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments/204155848","pull_request_review_id":139194029,"id":204155848,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDE1NTg0OA==","diff_hunk":"@@ -18,3 +18,28 @@ presubmits:\n         env:\n         - name: NO_DOCKER\n           value: \"1\"\n+  - name: pull-service-catalog-xbuild\n+    agent: kubernetes\n+    context: pull-service-catalog-xbuild\n+    always_run: true\n+    skip_report: false\n+    rerun_command: \"/test pull-service-catalog-xbuild\"\n+    trigger: \"(?m)^/test (all|pull-service-catalog-xbuild)\\\\s*\"\n+    spec:\n+      containers:\n+      - args:\n+        - \"--repo=sigs.k8s.io/$(REPO_NAME)=$(PULL_REFS)\"\n+        - \"--root=/go/src/github.com/kubernetes-incubator/$(REPO_NAME)\"\n+        - \"--timeout=90\"\n+        - \"--scenario=execute\"\n+        - \"--\"\n+        - \"make\"\n+        - \"images-all\"\n+        - \"svcat-all\"\n+      env:\n+      - name: DOCKER_IN_DOCKER_ENABLED","path":"config/jobs/kubernetes-incubator/service-catalog/service-catalog-presubmits.yaml","position":23,"original_position":23,"commit_id":"0912ab89b1cb4465efddbc8c78a10775cf5f969f","original_commit_id":"0912ab89b1cb4465efddbc8c78a10775cf5f969f","user":{"login":"MHBauer","id":13337345,"node_id":"MDQ6VXNlcjEzMzM3MzQ1","avatar_url":"https://avatars2.githubusercontent.com/u/13337345?v=4","gravatar_id":"","url":"https://api.github.com/users/MHBauer","html_url":"https://github.com/MHBauer","followers_url":"https://api.github.com/users/MHBauer/followers","following_url":"https://api.github.com/users/MHBauer/following{/other_user}","gists_url":"https://api.github.com/users/MHBauer/gists{/gist_id}","starred_url":"https://api.github.com/users/MHBauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MHBauer/subscriptions","organizations_url":"https://api.github.com/users/MHBauer/orgs","repos_url":"https://api.github.com/users/MHBauer/repos","events_url":"https://api.github.com/users/MHBauer/events{/privacy}","received_events_url":"https://api.github.com/users/MHBauer/received_events","type":"User","site_admin":false},"body":"searched for `emptyDir` and found helm/charts repo\r\nhttps://github.com/kubernetes/test-infra/blob/1c40d5125cd571010e6949fe0b41065f5973542c/config/jobs/helm/charts/charts.yaml\r\n","created_at":"2018-07-20T20:05:37Z","updated_at":"2018-07-20T20:05:37Z","html_url":"https://github.com/kubernetes/test-infra/pull/8734#discussion_r204155848","pull_request_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/8734","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments/204155848"},"html":{"href":"https://github.com/kubernetes/test-infra/pull/8734#discussion_r204155848"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/8734"}},"in_reply_to_id":204095196},"pull_request":{"url":"https://api.github.com/repos/kubernetes/test-infra/pulls/8734","id":202634505,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNjM0NTA1","html_url":"https://github.com/kubernetes/test-infra/pull/8734","diff_url":"https://github.com/kubernetes/test-infra/pull/8734.diff","patch_url":"https://github.com/kubernetes/test-infra/pull/8734.patch","issue_url":"https://api.github.com/repos/kubernetes/test-infra/issues/8734","number":8734,"state":"open","locked":false,"title":"service-catalog cross build test with dind","user":{"login":"MHBauer","id":13337345,"node_id":"MDQ6VXNlcjEzMzM3MzQ1","avatar_url":"https://avatars2.githubusercontent.com/u/13337345?v=4","gravatar_id":"","url":"https://api.github.com/users/MHBauer","html_url":"https://github.com/MHBauer","followers_url":"https://api.github.com/users/MHBauer/followers","following_url":"https://api.github.com/users/MHBauer/following{/other_user}","gists_url":"https://api.github.com/users/MHBauer/gists{/gist_id}","starred_url":"https://api.github.com/users/MHBauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MHBauer/subscriptions","organizations_url":"https://api.github.com/users/MHBauer/orgs","repos_url":"https://api.github.com/users/MHBauer/repos","events_url":"https://api.github.com/users/MHBauer/events{/privacy}","received_events_url":"https://api.github.com/users/MHBauer/received_events","type":"User","site_admin":false},"body":"\r\nI created this by guessing that I need a docker-in-docker enabled instance.\r\n\r\nI found the variable DOCKER_IN_DOCKER_ENABLED, and searched for it.\r\n\r\nI picked this to copy from\r\nhttps://github.com/kubernetes/test-infra/blob/68c68683a066e7b9986113c73a6dcb0f48775ef9/config/jobs/kubernetes-sigs/cluster-api-provider-openstack/cluster-api-provider-openstack-presubmits.yaml\r\nbecause it's in the new location for config, so I figure that means someone has looked at it.\r\n\r\nI didn't totally copy it, because I don't know what some of the args are, such as:\r\n```\r\n    labels: \r\n        preset-service-account: \"true\"\r\n```\r\nand  ` - \"--upload=gs://kubernetes-jenkins/pr-logs\"` \r\n\r\nI also don't know how much memory it needs, so I dropped the 6G requirement. I do not know what the default is, but I'm going to hope it's enough for now.","created_at":"2018-07-19T17:42:15Z","updated_at":"2018-07-20T20:05:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e2fd38f213453fd811b92385421f74ac96ae992","assignee":{"login":"BenTheElder","id":917931,"node_id":"MDQ6VXNlcjkxNzkzMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/917931?v=4","gravatar_id":"","url":"https://api.github.com/users/BenTheElder","html_url":"https://github.com/BenTheElder","followers_url":"https://api.github.com/users/BenTheElder/followers","following_url":"https://api.github.com/users/BenTheElder/following{/other_user}","gists_url":"https://api.github.com/users/BenTheElder/gists{/gist_id}","starred_url":"https://api.github.com/users/BenTheElder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenTheElder/subscriptions","organizations_url":"https://api.github.com/users/BenTheElder/orgs","repos_url":"https://api.github.com/users/BenTheElder/repos","events_url":"https://api.github.com/users/BenTheElder/events{/privacy}","received_events_url":"https://api.github.com/users/BenTheElder/received_events","type":"User","site_admin":false},"assignees":[{"login":"BenTheElder","id":917931,"node_id":"MDQ6VXNlcjkxNzkzMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/917931?v=4","gravatar_id":"","url":"https://api.github.com/users/BenTheElder","html_url":"https://github.com/BenTheElder","followers_url":"https://api.github.com/users/BenTheElder/followers","following_url":"https://api.github.com/users/BenTheElder/following{/other_user}","gists_url":"https://api.github.com/users/BenTheElder/gists{/gist_id}","starred_url":"https://api.github.com/users/BenTheElder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenTheElder/subscriptions","organizations_url":"https://api.github.com/users/BenTheElder/orgs","repos_url":"https://api.github.com/users/BenTheElder/repos","events_url":"https://api.github.com/users/BenTheElder/events{/privacy}","received_events_url":"https://api.github.com/users/BenTheElder/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":705940018,"node_id":"MDU6TGFiZWw3MDU5NDAwMTg=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":484580953,"node_id":"MDU6TGFiZWw0ODQ1ODA5NTM=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":671132825,"node_id":"MDU6TGFiZWw2NzExMzI4MjU=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/size/S","name":"size/S","color":"77bb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/8734/commits","review_comments_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/8734/comments","review_comment_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/issues/8734/comments","statuses_url":"https://api.github.com/repos/kubernetes/test-infra/statuses/0912ab89b1cb4465efddbc8c78a10775cf5f969f","head":{"label":"MHBauer:svc-cat-xbuild","ref":"svc-cat-xbuild","sha":"0912ab89b1cb4465efddbc8c78a10775cf5f969f","user":{"login":"MHBauer","id":13337345,"node_id":"MDQ6VXNlcjEzMzM3MzQ1","avatar_url":"https://avatars2.githubusercontent.com/u/13337345?v=4","gravatar_id":"","url":"https://api.github.com/users/MHBauer","html_url":"https://github.com/MHBauer","followers_url":"https://api.github.com/users/MHBauer/followers","following_url":"https://api.github.com/users/MHBauer/following{/other_user}","gists_url":"https://api.github.com/users/MHBauer/gists{/gist_id}","starred_url":"https://api.github.com/users/MHBauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MHBauer/subscriptions","organizations_url":"https://api.github.com/users/MHBauer/orgs","repos_url":"https://api.github.com/users/MHBauer/repos","events_url":"https://api.github.com/users/MHBauer/events{/privacy}","received_events_url":"https://api.github.com/users/MHBauer/received_events","type":"User","site_admin":false},"repo":{"id":60374671,"node_id":"MDEwOlJlcG9zaXRvcnk2MDM3NDY3MQ==","name":"test-infra","full_name":"MHBauer/test-infra","owner":{"login":"MHBauer","id":13337345,"node_id":"MDQ6VXNlcjEzMzM3MzQ1","avatar_url":"https://avatars2.githubusercontent.com/u/13337345?v=4","gravatar_id":"","url":"https://api.github.com/users/MHBauer","html_url":"https://github.com/MHBauer","followers_url":"https://api.github.com/users/MHBauer/followers","following_url":"https://api.github.com/users/MHBauer/following{/other_user}","gists_url":"https://api.github.com/users/MHBauer/gists{/gist_id}","starred_url":"https://api.github.com/users/MHBauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MHBauer/subscriptions","organizations_url":"https://api.github.com/users/MHBauer/orgs","repos_url":"https://api.github.com/users/MHBauer/repos","events_url":"https://api.github.com/users/MHBauer/events{/privacy}","received_events_url":"https://api.github.com/users/MHBauer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MHBauer/test-infra","description":"Test infrastructure for the Kubernetes project.","fork":true,"url":"https://api.github.com/repos/MHBauer/test-infra","forks_url":"https://api.github.com/repos/MHBauer/test-infra/forks","keys_url":"https://api.github.com/repos/MHBauer/test-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MHBauer/test-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MHBauer/test-infra/teams","hooks_url":"https://api.github.com/repos/MHBauer/test-infra/hooks","issue_events_url":"https://api.github.com/repos/MHBauer/test-infra/issues/events{/number}","events_url":"https://api.github.com/repos/MHBauer/test-infra/events","assignees_url":"https://api.github.com/repos/MHBauer/test-infra/assignees{/user}","branches_url":"https://api.github.com/repos/MHBauer/test-infra/branches{/branch}","tags_url":"https://api.github.com/repos/MHBauer/test-infra/tags","blobs_url":"https://api.github.com/repos/MHBauer/test-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MHBauer/test-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MHBauer/test-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/MHBauer/test-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MHBauer/test-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/MHBauer/test-infra/languages","stargazers_url":"https://api.github.com/repos/MHBauer/test-infra/stargazers","contributors_url":"https://api.github.com/repos/MHBauer/test-infra/contributors","subscribers_url":"https://api.github.com/repos/MHBauer/test-infra/subscribers","subscription_url":"https://api.github.com/repos/MHBauer/test-infra/subscription","commits_url":"https://api.github.com/repos/MHBauer/test-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/MHBauer/test-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/MHBauer/test-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/MHBauer/test-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/MHBauer/test-infra/contents/{+path}","compare_url":"https://api.github.com/repos/MHBauer/test-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MHBauer/test-infra/merges","archive_url":"https://api.github.com/repos/MHBauer/test-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MHBauer/test-infra/downloads","issues_url":"https://api.github.com/repos/MHBauer/test-infra/issues{/number}","pulls_url":"https://api.github.com/repos/MHBauer/test-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/MHBauer/test-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/MHBauer/test-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MHBauer/test-infra/labels{/name}","releases_url":"https://api.github.com/repos/MHBauer/test-infra/releases{/id}","deployments_url":"https://api.github.com/repos/MHBauer/test-infra/deployments","created_at":"2016-06-03T20:06:28Z","updated_at":"2018-07-19T17:39:30Z","pushed_at":"2018-07-20T01:16:28Z","git_url":"git://github.com/MHBauer/test-infra.git","ssh_url":"git@github.com:MHBauer/test-infra.git","clone_url":"https://github.com/MHBauer/test-infra.git","svn_url":"https://github.com/MHBauer/test-infra","homepage":null,"size":56485,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"a795de360ae683943a23140eca46cc12260c374a","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":57333709,"node_id":"MDEwOlJlcG9zaXRvcnk1NzMzMzcwOQ==","name":"test-infra","full_name":"kubernetes/test-infra","owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/test-infra","description":"Test infrastructure for the Kubernetes project.","fork":false,"url":"https://api.github.com/repos/kubernetes/test-infra","forks_url":"https://api.github.com/repos/kubernetes/test-infra/forks","keys_url":"https://api.github.com/repos/kubernetes/test-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/test-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/test-infra/teams","hooks_url":"https://api.github.com/repos/kubernetes/test-infra/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/test-infra/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/test-infra/events","assignees_url":"https://api.github.com/repos/kubernetes/test-infra/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/test-infra/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/test-infra/tags","blobs_url":"https://api.github.com/repos/kubernetes/test-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/test-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/test-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/test-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/test-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/test-infra/languages","stargazers_url":"https://api.github.com/repos/kubernetes/test-infra/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/test-infra/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/test-infra/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/test-infra/subscription","commits_url":"https://api.github.com/repos/kubernetes/test-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/test-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/test-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/test-infra/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/test-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/test-infra/merges","archive_url":"https://api.github.com/repos/kubernetes/test-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/test-infra/downloads","issues_url":"https://api.github.com/repos/kubernetes/test-infra/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/test-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/test-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/test-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/test-infra/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/test-infra/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/test-infra/deployments","created_at":"2016-04-28T21:05:35Z","updated_at":"2018-07-20T20:04:42Z","pushed_at":"2018-07-20T20:04:33Z","git_url":"git://github.com/kubernetes/test-infra.git","ssh_url":"git@github.com:kubernetes/test-infra.git","clone_url":"https://github.com/kubernetes/test-infra.git","svn_url":"https://github.com/kubernetes/test-infra","homepage":null,"size":57507,"stargazers_count":467,"watchers_count":467,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":504,"mirror_url":null,"archived":false,"open_issues_count":307,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":504,"open_issues":307,"watchers":467,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/8734"},"html":{"href":"https://github.com/kubernetes/test-infra/pull/8734"},"issue":{"href":"https://api.github.com/repos/kubernetes/test-infra/issues/8734"},"comments":{"href":"https://api.github.com/repos/kubernetes/test-infra/issues/8734/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/8734/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/8734/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/test-infra/statuses/0912ab89b1cb4465efddbc8c78a10775cf5f969f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"MHBauer"}}