{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Templating/pulls/comments/204192164","pull_request_review_id":139236588,"id":204192164,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDE5MjE2NA==","diff_hunk":"@@ -10,48 +10,42 @@\n         <link rel=\"stylesheet\" href=\"~/css/site.css\" />\n     </environment>\n     <environment exclude=\"Development\">\n-        <link rel=\"stylesheet\" href=\"https://ajax.aspnetcdn.com/ajax/bootstrap/3.3.7/css/bootstrap.min.css\"\n+        <link rel=\"stylesheet\" href=\"https://ajax.aspnetcdn.com/ajax/bootstrap/4.1.1/css/bootstrap.min.css\"\n               asp-fallback-href=\"~/lib/bootstrap/dist/css/bootstrap.min.css\"\n               asp-fallback-test-class=\"sr-only\" asp-fallback-test-property=\"position\" asp-fallback-test-value=\"absolute\" />\n         <link rel=\"stylesheet\" href=\"~/css/site.min.css\" asp-append-version=\"true\" />\n     </environment>\n </head>\n <body>\n-    <nav class=\"navbar navbar-inverse navbar-fixed-top\">\n-        <div class=\"container\">\n-            <div class=\"navbar-header\">\n-                <button type=\"button\" class=\"navbar-toggle\" data-toggle=\"collapse\" data-target=\".navbar-collapse\">\n-                    <span class=\"sr-only\">Toggle navigation</span>\n-                    <span class=\"icon-bar\"></span>\n-                    <span class=\"icon-bar\"></span>\n-                    <span class=\"icon-bar\"></span>\n-                </button>\n-                <a asp-area=\"\" asp-controller=\"Home\" asp-action=\"Index\" class=\"navbar-brand\">Company.WebApplication1</a>\n-            </div>\n-            <div class=\"navbar-collapse collapse\">\n-                <ul class=\"nav navbar-nav\">\n-                    <li><a asp-area=\"\" asp-controller=\"Home\" asp-action=\"Index\">Home</a></li>\n-                    <li><a asp-area=\"\" asp-controller=\"Home\" asp-action=\"About\">About</a></li>\n-                    <li><a asp-area=\"\" asp-controller=\"Home\" asp-action=\"Contact\">Contact</a></li>\n-                </ul>\n+    <header>\n+        <nav class=\"mb-3 navbar navbar-expand navbar-light flex-column flex-md-row bg-white border-bottom box-shadow\">\n+            <a class=\"navbar-brand\" asp-area=\"\" asp-controller=\"Home\" asp-action=\"Index\">Company.WebApplication1</a>\n+            <ul class=\"navbar-nav ml-md-auto\">\n+                <li class=\"nav-item\">\n+                    <a class=\"nav-link text-dark\" asp-area=\"\" asp-controller=\"Home\" asp-action=\"Index\">Page1</a>\n+                </li>\n+                <li class=\"nav-item\">\n+                    <a class=\"nav-link text-dark\" asp-area=\"\" asp-controller=\"Home\" asp-action=\"Index\">Page2</a>\n+                </li>\n+            </ul>\n @*#if (IndividualAuth || OrganizationalAuth)\n-                <partial name=\"_LoginPartial\" />\n+            <partial name=\"_LoginPartial\" />\n #elseif (WindowsAuth)\n-                <p class=\"nav navbar-text navbar-right\">Hello, @User.Identity.Name!</p>\n+            <p class=\"nav navbar-text navbar-right\">Hello, @User.Identity.Name!</p>\n #endif*@\n-            </div>\n-        </div>\n-    </nav>\n+        </nav>\n+    </header>\n \n-    <partial name=\"_CookieConsentPartial\" />\n-\n-    <div class=\"container body-content\">\n-        @RenderBody()\n-        <hr />\n-        <footer>\n-            <p>&copy; copyrightYear - Company.WebApplication1</p>\n-        </footer>\n+    <div class=\"container\">\n+        <partial name=\"_CookieConsentPartial\" />\n     </div>\n+    <main role=\"main\" class=\"container pb-1\">","path":"src/Microsoft.DotNet.Web.ProjectTemplates/content/StarterWeb-CSharp/Views/Shared/_Layout.cshtml","position":64,"original_position":64,"commit_id":"270754e16357c99061ced483d1e854e262163ef9","original_commit_id":"270754e16357c99061ced483d1e854e262163ef9","user":{"login":"DamianEdwards","id":249088,"node_id":"MDQ6VXNlcjI0OTA4OA==","avatar_url":"https://avatars1.githubusercontent.com/u/249088?v=4","gravatar_id":"","url":"https://api.github.com/users/DamianEdwards","html_url":"https://github.com/DamianEdwards","followers_url":"https://api.github.com/users/DamianEdwards/followers","following_url":"https://api.github.com/users/DamianEdwards/following{/other_user}","gists_url":"https://api.github.com/users/DamianEdwards/gists{/gist_id}","starred_url":"https://api.github.com/users/DamianEdwards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DamianEdwards/subscriptions","organizations_url":"https://api.github.com/users/DamianEdwards/orgs","repos_url":"https://api.github.com/users/DamianEdwards/repos","events_url":"https://api.github.com/users/DamianEdwards/events{/privacy}","received_events_url":"https://api.github.com/users/DamianEdwards/received_events","type":"User","site_admin":false},"body":"Is it typical to have multiple elements using the `container` class on a single page? Especially one as simple as this?","created_at":"2018-07-20T23:47:00Z","updated_at":"2018-07-20T23:49:54Z","html_url":"https://github.com/aspnet/Templating/pull/595#discussion_r204192164","pull_request_url":"https://api.github.com/repos/aspnet/Templating/pulls/595","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Templating/pulls/comments/204192164"},"html":{"href":"https://github.com/aspnet/Templating/pull/595#discussion_r204192164"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Templating/pulls/595"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Templating/pulls/595","id":198180971,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MTgwOTcx","html_url":"https://github.com/aspnet/Templating/pull/595","diff_url":"https://github.com/aspnet/Templating/pull/595.diff","patch_url":"https://github.com/aspnet/Templating/pull/595.patch","issue_url":"https://api.github.com/repos/aspnet/Templating/issues/595","number":595,"state":"open","locked":false,"title":"[Design] Move to Bootstrap 4","user":{"login":"ryanbrandenburg","id":14987221,"node_id":"MDQ6VXNlcjE0OTg3MjIx","avatar_url":"https://avatars0.githubusercontent.com/u/14987221?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanbrandenburg","html_url":"https://github.com/ryanbrandenburg","followers_url":"https://api.github.com/users/ryanbrandenburg/followers","following_url":"https://api.github.com/users/ryanbrandenburg/following{/other_user}","gists_url":"https://api.github.com/users/ryanbrandenburg/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanbrandenburg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanbrandenburg/subscriptions","organizations_url":"https://api.github.com/users/ryanbrandenburg/orgs","repos_url":"https://api.github.com/users/ryanbrandenburg/repos","events_url":"https://api.github.com/users/ryanbrandenburg/events{/privacy}","received_events_url":"https://api.github.com/users/ryanbrandenburg/received_events","type":"User","site_admin":false},"body":"Fixes #278 and #567.\r\n\r\nI also added a small script which does the steps required to make the StarterWeb app work locally to make testing easier.\r\n\r\nThis PR is pretty huge because we check in a copy of bootstrap and we have to overwrite the whole thing. In the future I would like to check in less intermediate product (which might include a move away from bower, #422), but I don't think that's in scope for this PR.\r\n\r\nI've only moved one project for now, but once we've agreed this is what we want we'll be moving all our projects to BS4.","created_at":"2018-06-28T23:40:18Z","updated_at":"2018-07-20T23:49:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81a77c7cbe06e1f9a4bcf3a7664a1e51ade884b0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Templating/pulls/595/commits","review_comments_url":"https://api.github.com/repos/aspnet/Templating/pulls/595/comments","review_comment_url":"https://api.github.com/repos/aspnet/Templating/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Templating/issues/595/comments","statuses_url":"https://api.github.com/repos/aspnet/Templating/statuses/270754e16357c99061ced483d1e854e262163ef9","head":{"label":"aspnet:rybrande/Bootstrap4","ref":"rybrande/Bootstrap4","sha":"270754e16357c99061ced483d1e854e262163ef9","user":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":101210459,"node_id":"MDEwOlJlcG9zaXRvcnkxMDEyMTA0NTk=","name":"Templating","full_name":"aspnet/Templating","owner":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Templating","description":"ASP.NET Core templates for .NET CLI and Visual Studio","fork":false,"url":"https://api.github.com/repos/aspnet/Templating","forks_url":"https://api.github.com/repos/aspnet/Templating/forks","keys_url":"https://api.github.com/repos/aspnet/Templating/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Templating/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Templating/teams","hooks_url":"https://api.github.com/repos/aspnet/Templating/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Templating/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Templating/events","assignees_url":"https://api.github.com/repos/aspnet/Templating/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Templating/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Templating/tags","blobs_url":"https://api.github.com/repos/aspnet/Templating/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Templating/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Templating/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Templating/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Templating/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Templating/languages","stargazers_url":"https://api.github.com/repos/aspnet/Templating/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Templating/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Templating/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Templating/subscription","commits_url":"https://api.github.com/repos/aspnet/Templating/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Templating/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Templating/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Templating/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Templating/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Templating/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Templating/merges","archive_url":"https://api.github.com/repos/aspnet/Templating/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Templating/downloads","issues_url":"https://api.github.com/repos/aspnet/Templating/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Templating/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Templating/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Templating/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Templating/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Templating/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/Templating/deployments","created_at":"2017-08-23T18:04:16Z","updated_at":"2018-07-20T06:00:56Z","pushed_at":"2018-07-20T22:47:40Z","git_url":"git://github.com/aspnet/Templating.git","ssh_url":"git@github.com:aspnet/Templating.git","clone_url":"https://github.com/aspnet/Templating.git","svn_url":"https://github.com/aspnet/Templating","homepage":null,"size":2805,"stargazers_count":169,"watchers_count":169,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":72,"mirror_url":null,"archived":false,"open_issues_count":98,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":72,"open_issues":98,"watchers":169,"default_branch":"master"}},"base":{"label":"aspnet:release/2.2","ref":"release/2.2","sha":"26fd3dce2572a1c1b1bfe43ee3c6dae54c48e987","user":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":101210459,"node_id":"MDEwOlJlcG9zaXRvcnkxMDEyMTA0NTk=","name":"Templating","full_name":"aspnet/Templating","owner":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Templating","description":"ASP.NET Core templates for .NET CLI and Visual Studio","fork":false,"url":"https://api.github.com/repos/aspnet/Templating","forks_url":"https://api.github.com/repos/aspnet/Templating/forks","keys_url":"https://api.github.com/repos/aspnet/Templating/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Templating/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Templating/teams","hooks_url":"https://api.github.com/repos/aspnet/Templating/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Templating/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Templating/events","assignees_url":"https://api.github.com/repos/aspnet/Templating/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Templating/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Templating/tags","blobs_url":"https://api.github.com/repos/aspnet/Templating/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Templating/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Templating/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Templating/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Templating/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Templating/languages","stargazers_url":"https://api.github.com/repos/aspnet/Templating/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Templating/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Templating/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Templating/subscription","commits_url":"https://api.github.com/repos/aspnet/Templating/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Templating/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Templating/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Templating/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Templating/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Templating/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Templating/merges","archive_url":"https://api.github.com/repos/aspnet/Templating/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Templating/downloads","issues_url":"https://api.github.com/repos/aspnet/Templating/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Templating/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Templating/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Templating/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Templating/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Templating/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/Templating/deployments","created_at":"2017-08-23T18:04:16Z","updated_at":"2018-07-20T06:00:56Z","pushed_at":"2018-07-20T22:47:40Z","git_url":"git://github.com/aspnet/Templating.git","ssh_url":"git@github.com:aspnet/Templating.git","clone_url":"https://github.com/aspnet/Templating.git","svn_url":"https://github.com/aspnet/Templating","homepage":null,"size":2805,"stargazers_count":169,"watchers_count":169,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":72,"mirror_url":null,"archived":false,"open_issues_count":98,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":72,"open_issues":98,"watchers":169,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Templating/pulls/595"},"html":{"href":"https://github.com/aspnet/Templating/pull/595"},"issue":{"href":"https://api.github.com/repos/aspnet/Templating/issues/595"},"comments":{"href":"https://api.github.com/repos/aspnet/Templating/issues/595/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Templating/pulls/595/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Templating/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Templating/pulls/595/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Templating/statuses/270754e16357c99061ced483d1e854e262163ef9"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"DamianEdwards"}}