{"action":"created","issue":{"url":"https://api.github.com/repos/reakit/reakit/issues/173","repository_url":"https://api.github.com/repos/reakit/reakit","labels_url":"https://api.github.com/repos/reakit/reakit/issues/173/labels{/name}","comments_url":"https://api.github.com/repos/reakit/reakit/issues/173/comments","events_url":"https://api.github.com/repos/reakit/reakit/issues/173/events","html_url":"https://github.com/reakit/reakit/issues/173","id":348144630,"node_id":"MDU6SXNzdWUzNDgxNDQ2MzA=","number":173,"title":"Remove react-known-props dependency","user":{"login":"diegohaz","id":3068563,"node_id":"MDQ6VXNlcjMwNjg1NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/3068563?v=4","gravatar_id":"","url":"https://api.github.com/users/diegohaz","html_url":"https://github.com/diegohaz","followers_url":"https://api.github.com/users/diegohaz/followers","following_url":"https://api.github.com/users/diegohaz/following{/other_user}","gists_url":"https://api.github.com/users/diegohaz/gists{/gist_id}","starred_url":"https://api.github.com/users/diegohaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diegohaz/subscriptions","organizations_url":"https://api.github.com/users/diegohaz/orgs","repos_url":"https://api.github.com/users/diegohaz/repos","events_url":"https://api.github.com/users/diegohaz/events{/privacy}","received_events_url":"https://api.github.com/users/diegohaz/received_events","type":"User","site_admin":false},"labels":[{"id":988950644,"node_id":"MDU6TGFiZWw5ODg5NTA2NDQ=","url":"https://api.github.com/repos/reakit/reakit/labels/breaking%20change","name":"breaking change","color":"FF9800","default":false},{"id":999244571,"node_id":"MDU6TGFiZWw5OTkyNDQ1NzE=","url":"https://api.github.com/repos/reakit/reakit/labels/difficulty:%20medium","name":"difficulty: medium","color":"FBC02D","default":false},{"id":813246763,"node_id":"MDU6TGFiZWw4MTMyNDY3NjM=","url":"https://api.github.com/repos/reakit/reakit/labels/pr%20welcome","name":"pr welcome","color":"0e8a16","default":false},{"id":999243931,"node_id":"MDU6TGFiZWw5OTkyNDM5MzE=","url":"https://api.github.com/repos/reakit/reakit/labels/priority:%20medium","name":"priority: medium","color":"FBC02D","default":false}],"state":"open","locked":false,"assignee":{"login":"Thomazella","id":15015324,"node_id":"MDQ6VXNlcjE1MDE1MzI0","avatar_url":"https://avatars0.githubusercontent.com/u/15015324?v=4","gravatar_id":"","url":"https://api.github.com/users/Thomazella","html_url":"https://github.com/Thomazella","followers_url":"https://api.github.com/users/Thomazella/followers","following_url":"https://api.github.com/users/Thomazella/following{/other_user}","gists_url":"https://api.github.com/users/Thomazella/gists{/gist_id}","starred_url":"https://api.github.com/users/Thomazella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thomazella/subscriptions","organizations_url":"https://api.github.com/users/Thomazella/orgs","repos_url":"https://api.github.com/users/Thomazella/repos","events_url":"https://api.github.com/users/Thomazella/events{/privacy}","received_events_url":"https://api.github.com/users/Thomazella/received_events","type":"User","site_admin":false},"assignees":[{"login":"Thomazella","id":15015324,"node_id":"MDQ6VXNlcjE1MDE1MzI0","avatar_url":"https://avatars0.githubusercontent.com/u/15015324?v=4","gravatar_id":"","url":"https://api.github.com/users/Thomazella","html_url":"https://github.com/Thomazella","followers_url":"https://api.github.com/users/Thomazella/followers","following_url":"https://api.github.com/users/Thomazella/following{/other_user}","gists_url":"https://api.github.com/users/Thomazella/gists{/gist_id}","starred_url":"https://api.github.com/users/Thomazella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thomazella/subscriptions","organizations_url":"https://api.github.com/users/Thomazella/orgs","repos_url":"https://api.github.com/users/Thomazella/repos","events_url":"https://api.github.com/users/Thomazella/events{/privacy}","received_events_url":"https://api.github.com/users/Thomazella/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-08-07T02:36:41Z","updated_at":"2018-08-07T09:51:08Z","closed_at":null,"author_association":"MEMBER","body":"In order to reduce bundle size, we should remove the dependency on [react-known-props](https://github.com/Thomazella/react-known-props). \r\n\r\nCurrently, we're using it here to filter custom props and render only valid html props on the component:\r\nhttps://github.com/reakit/reakit/blob/63284abac891b47b7bb313d827c588468b4a6b1b/src/utils/pickHTMLProps.js#L1-L21\r\n\r\nWe should replace `getElementProps` and `getEventProps` with our own, without filtering SVG props, which is what makes `react-known-props` heavy."},"comment":{"url":"https://api.github.com/repos/reakit/reakit/issues/comments/411001045","html_url":"https://github.com/reakit/reakit/issues/173#issuecomment-411001045","issue_url":"https://api.github.com/repos/reakit/reakit/issues/173","id":411001045,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTAwMTA0NQ==","user":{"login":"Andarist","id":9800850,"node_id":"MDQ6VXNlcjk4MDA4NTA=","avatar_url":"https://avatars2.githubusercontent.com/u/9800850?v=4","gravatar_id":"","url":"https://api.github.com/users/Andarist","html_url":"https://github.com/Andarist","followers_url":"https://api.github.com/users/Andarist/followers","following_url":"https://api.github.com/users/Andarist/following{/other_user}","gists_url":"https://api.github.com/users/Andarist/gists{/gist_id}","starred_url":"https://api.github.com/users/Andarist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Andarist/subscriptions","organizations_url":"https://api.github.com/users/Andarist/orgs","repos_url":"https://api.github.com/users/Andarist/repos","events_url":"https://api.github.com/users/Andarist/events{/privacy}","received_events_url":"https://api.github.com/users/Andarist/received_events","type":"User","site_admin":false},"created_at":"2018-08-07T09:51:08Z","updated_at":"2018-08-07T09:51:08Z","author_association":"CONTRIBUTOR","body":"They are flat bundling, so you won't be able to access that file either way.\r\n\r\nPersonally I'm emotion (👩‍🎤) user and we have `shouldForwardProp` option that can be passed to `styled` call (& reuse existing filtering). Maybe worth proposing something similar to styled-components?\r\n\r\nExample from emotion\r\n```js\r\nimport isPropValid from '@emotion/is-prop-valid'\r\n\r\nconst StyledTextarea = styled(TextareaAutosize, { shouldForwardProp: isPropValid })({\r\n  fontSize: '16px',\r\n})\r\n```"}}
{"actor":{"display_login":"Andarist"}}