{"action":"opened","number":67,"pull_request":{"url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/pulls/67","id":200663177,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNjYzMTc3","html_url":"https://github.com/alexandrebarachant/pyRiemann/pull/67","diff_url":"https://github.com/alexandrebarachant/pyRiemann/pull/67.diff","patch_url":"https://github.com/alexandrebarachant/pyRiemann/pull/67.patch","issue_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/issues/67","number":67,"state":"open","locked":false,"title":"Minor change in classification.py","user":{"login":"GReguig","id":11228281,"node_id":"MDQ6VXNlcjExMjI4Mjgx","avatar_url":"https://avatars1.githubusercontent.com/u/11228281?v=4","gravatar_id":"","url":"https://api.github.com/users/GReguig","html_url":"https://github.com/GReguig","followers_url":"https://api.github.com/users/GReguig/followers","following_url":"https://api.github.com/users/GReguig/following{/other_user}","gists_url":"https://api.github.com/users/GReguig/gists{/gist_id}","starred_url":"https://api.github.com/users/GReguig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GReguig/subscriptions","organizations_url":"https://api.github.com/users/GReguig/orgs","repos_url":"https://api.github.com/users/GReguig/repos","events_url":"https://api.github.com/users/GReguig/events{/privacy}","received_events_url":"https://api.github.com/users/GReguig/received_events","type":"User","site_admin":false},"body":"Hello,\r\n\r\nI would like to propose some minor changes in the classification.py file:\r\n\r\n- Replacing the for loop : \r\n`for l in self.classes_:\r\n                 self.covmeans_.append(\r\n                     mean_covariance(X[y == l], metric=self.metric_mean,\r\n                                     sample_weight=sample_weight[y == l]))`\r\nby a list comprehension :\r\n`self.covmeans_ = [mean_covariance(X[y == l], metric=self.metric_mean,\r\n                                    sample_weight=sample_weight[y == l])\r\n                                        for l in self.classes_]`\r\n\r\n- Adding a predict_proba function to FgMDM :\r\n\r\n- Deleting an unused TangentSpace object ","created_at":"2018-07-11T11:03:48Z","updated_at":"2018-07-11T11:03:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/pulls/67/commits","review_comments_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/pulls/67/comments","review_comment_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/issues/67/comments","statuses_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/statuses/ec2a6e8e1d7c16eb077720fdc57ec10db59e0c05","head":{"label":"GReguig:master","ref":"master","sha":"ec2a6e8e1d7c16eb077720fdc57ec10db59e0c05","user":{"login":"GReguig","id":11228281,"node_id":"MDQ6VXNlcjExMjI4Mjgx","avatar_url":"https://avatars1.githubusercontent.com/u/11228281?v=4","gravatar_id":"","url":"https://api.github.com/users/GReguig","html_url":"https://github.com/GReguig","followers_url":"https://api.github.com/users/GReguig/followers","following_url":"https://api.github.com/users/GReguig/following{/other_user}","gists_url":"https://api.github.com/users/GReguig/gists{/gist_id}","starred_url":"https://api.github.com/users/GReguig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GReguig/subscriptions","organizations_url":"https://api.github.com/users/GReguig/orgs","repos_url":"https://api.github.com/users/GReguig/repos","events_url":"https://api.github.com/users/GReguig/events{/privacy}","received_events_url":"https://api.github.com/users/GReguig/received_events","type":"User","site_admin":false},"repo":{"id":140554757,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA1NTQ3NTc=","name":"pyRiemann","full_name":"GReguig/pyRiemann","owner":{"login":"GReguig","id":11228281,"node_id":"MDQ6VXNlcjExMjI4Mjgx","avatar_url":"https://avatars1.githubusercontent.com/u/11228281?v=4","gravatar_id":"","url":"https://api.github.com/users/GReguig","html_url":"https://github.com/GReguig","followers_url":"https://api.github.com/users/GReguig/followers","following_url":"https://api.github.com/users/GReguig/following{/other_user}","gists_url":"https://api.github.com/users/GReguig/gists{/gist_id}","starred_url":"https://api.github.com/users/GReguig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GReguig/subscriptions","organizations_url":"https://api.github.com/users/GReguig/orgs","repos_url":"https://api.github.com/users/GReguig/repos","events_url":"https://api.github.com/users/GReguig/events{/privacy}","received_events_url":"https://api.github.com/users/GReguig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GReguig/pyRiemann","description":"Python package for covariance matrices manipulation and Biosignal classification with application in Brain Computer interface","fork":true,"url":"https://api.github.com/repos/GReguig/pyRiemann","forks_url":"https://api.github.com/repos/GReguig/pyRiemann/forks","keys_url":"https://api.github.com/repos/GReguig/pyRiemann/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GReguig/pyRiemann/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GReguig/pyRiemann/teams","hooks_url":"https://api.github.com/repos/GReguig/pyRiemann/hooks","issue_events_url":"https://api.github.com/repos/GReguig/pyRiemann/issues/events{/number}","events_url":"https://api.github.com/repos/GReguig/pyRiemann/events","assignees_url":"https://api.github.com/repos/GReguig/pyRiemann/assignees{/user}","branches_url":"https://api.github.com/repos/GReguig/pyRiemann/branches{/branch}","tags_url":"https://api.github.com/repos/GReguig/pyRiemann/tags","blobs_url":"https://api.github.com/repos/GReguig/pyRiemann/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GReguig/pyRiemann/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GReguig/pyRiemann/git/refs{/sha}","trees_url":"https://api.github.com/repos/GReguig/pyRiemann/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GReguig/pyRiemann/statuses/{sha}","languages_url":"https://api.github.com/repos/GReguig/pyRiemann/languages","stargazers_url":"https://api.github.com/repos/GReguig/pyRiemann/stargazers","contributors_url":"https://api.github.com/repos/GReguig/pyRiemann/contributors","subscribers_url":"https://api.github.com/repos/GReguig/pyRiemann/subscribers","subscription_url":"https://api.github.com/repos/GReguig/pyRiemann/subscription","commits_url":"https://api.github.com/repos/GReguig/pyRiemann/commits{/sha}","git_commits_url":"https://api.github.com/repos/GReguig/pyRiemann/git/commits{/sha}","comments_url":"https://api.github.com/repos/GReguig/pyRiemann/comments{/number}","issue_comment_url":"https://api.github.com/repos/GReguig/pyRiemann/issues/comments{/number}","contents_url":"https://api.github.com/repos/GReguig/pyRiemann/contents/{+path}","compare_url":"https://api.github.com/repos/GReguig/pyRiemann/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GReguig/pyRiemann/merges","archive_url":"https://api.github.com/repos/GReguig/pyRiemann/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GReguig/pyRiemann/downloads","issues_url":"https://api.github.com/repos/GReguig/pyRiemann/issues{/number}","pulls_url":"https://api.github.com/repos/GReguig/pyRiemann/pulls{/number}","milestones_url":"https://api.github.com/repos/GReguig/pyRiemann/milestones{/number}","notifications_url":"https://api.github.com/repos/GReguig/pyRiemann/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GReguig/pyRiemann/labels{/name}","releases_url":"https://api.github.com/repos/GReguig/pyRiemann/releases{/id}","deployments_url":"https://api.github.com/repos/GReguig/pyRiemann/deployments","created_at":"2018-07-11T09:45:10Z","updated_at":"2018-07-11T10:57:39Z","pushed_at":"2018-07-11T10:57:45Z","git_url":"git://github.com/GReguig/pyRiemann.git","ssh_url":"git@github.com:GReguig/pyRiemann.git","clone_url":"https://github.com/GReguig/pyRiemann.git","svn_url":"https://github.com/GReguig/pyRiemann","homepage":"","size":326,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"alexandrebarachant:master","ref":"master","sha":"d41921e201eb626992c098f126f16c75172e607c","user":{"login":"alexandrebarachant","id":2145718,"node_id":"MDQ6VXNlcjIxNDU3MTg=","avatar_url":"https://avatars2.githubusercontent.com/u/2145718?v=4","gravatar_id":"","url":"https://api.github.com/users/alexandrebarachant","html_url":"https://github.com/alexandrebarachant","followers_url":"https://api.github.com/users/alexandrebarachant/followers","following_url":"https://api.github.com/users/alexandrebarachant/following{/other_user}","gists_url":"https://api.github.com/users/alexandrebarachant/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandrebarachant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandrebarachant/subscriptions","organizations_url":"https://api.github.com/users/alexandrebarachant/orgs","repos_url":"https://api.github.com/users/alexandrebarachant/repos","events_url":"https://api.github.com/users/alexandrebarachant/events{/privacy}","received_events_url":"https://api.github.com/users/alexandrebarachant/received_events","type":"User","site_admin":false},"repo":{"id":34213430,"node_id":"MDEwOlJlcG9zaXRvcnkzNDIxMzQzMA==","name":"pyRiemann","full_name":"alexandrebarachant/pyRiemann","owner":{"login":"alexandrebarachant","id":2145718,"node_id":"MDQ6VXNlcjIxNDU3MTg=","avatar_url":"https://avatars2.githubusercontent.com/u/2145718?v=4","gravatar_id":"","url":"https://api.github.com/users/alexandrebarachant","html_url":"https://github.com/alexandrebarachant","followers_url":"https://api.github.com/users/alexandrebarachant/followers","following_url":"https://api.github.com/users/alexandrebarachant/following{/other_user}","gists_url":"https://api.github.com/users/alexandrebarachant/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandrebarachant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandrebarachant/subscriptions","organizations_url":"https://api.github.com/users/alexandrebarachant/orgs","repos_url":"https://api.github.com/users/alexandrebarachant/repos","events_url":"https://api.github.com/users/alexandrebarachant/events{/privacy}","received_events_url":"https://api.github.com/users/alexandrebarachant/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexandrebarachant/pyRiemann","description":"Python package for covariance matrices manipulation and Biosignal classification with application in Brain Computer interface","fork":false,"url":"https://api.github.com/repos/alexandrebarachant/pyRiemann","forks_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/forks","keys_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/teams","hooks_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/hooks","issue_events_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/issues/events{/number}","events_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/events","assignees_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/assignees{/user}","branches_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/branches{/branch}","tags_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/tags","blobs_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/statuses/{sha}","languages_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/languages","stargazers_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/stargazers","contributors_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/contributors","subscribers_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/subscribers","subscription_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/subscription","commits_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/contents/{+path}","compare_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/merges","archive_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/downloads","issues_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/issues{/number}","pulls_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/pulls{/number}","milestones_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/milestones{/number}","notifications_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/labels{/name}","releases_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/releases{/id}","deployments_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/deployments","created_at":"2015-04-19T16:01:44Z","updated_at":"2018-07-10T09:01:16Z","pushed_at":"2018-06-13T17:31:40Z","git_url":"git://github.com/alexandrebarachant/pyRiemann.git","ssh_url":"git@github.com:alexandrebarachant/pyRiemann.git","clone_url":"https://github.com/alexandrebarachant/pyRiemann.git","svn_url":"https://github.com/alexandrebarachant/pyRiemann","homepage":"","size":326,"stargazers_count":122,"watchers_count":122,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":41,"open_issues":16,"watchers":122,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alexandrebarachant/pyRiemann/pulls/67"},"html":{"href":"https://github.com/alexandrebarachant/pyRiemann/pull/67"},"issue":{"href":"https://api.github.com/repos/alexandrebarachant/pyRiemann/issues/67"},"comments":{"href":"https://api.github.com/repos/alexandrebarachant/pyRiemann/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/alexandrebarachant/pyRiemann/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/alexandrebarachant/pyRiemann/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alexandrebarachant/pyRiemann/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/alexandrebarachant/pyRiemann/statuses/ec2a6e8e1d7c16eb077720fdc57ec10db59e0c05"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":23,"deletions":5,"changed_files":1}}
{"actor":{"display_login":"GReguig"}}