{"action":"opened","number":13449,"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/13449","id":168680951,"html_url":"https://github.com/ampproject/amphtml/pull/13449","diff_url":"https://github.com/ampproject/amphtml/pull/13449.diff","patch_url":"https://github.com/ampproject/amphtml/pull/13449.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/13449","number":13449,"state":"open","locked":false,"title":"🏗️ Scoped Query Selector: linting and audit","user":{"login":"jridgewell","id":112982,"avatar_url":"https://avatars1.githubusercontent.com/u/112982?v=4","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"body":"This implements a much more rigorous `#querySelector` and `scopedQuerySelector` linting rule. We now reliably detect buggy `#querySelector` uses, and warn for non-escaped values in the selector.\r\n\r\nThis also implements the reverse, warning when we use `scopedQuerySelector` where it's not needed. This is nice because it avoids escaping hazards, and it's faster at runtime. 😃","created_at":"2018-02-12T20:33:33Z","updated_at":"2018-02-12T20:33:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/13449/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/13449/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/13449/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/ac00c9f34803c4c7387d56cf26d8e7f26e9b39e0","head":{"label":"jridgewell:scoped-query-selector-audit","ref":"scoped-query-selector-audit","sha":"ac00c9f34803c4c7387d56cf26d8e7f26e9b39e0","user":{"login":"jridgewell","id":112982,"avatar_url":"https://avatars1.githubusercontent.com/u/112982?v=4","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"repo":{"id":48198933,"name":"amphtml","full_name":"jridgewell/amphtml","owner":{"login":"jridgewell","id":112982,"avatar_url":"https://avatars1.githubusercontent.com/u/112982?v=4","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jridgewell/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/jridgewell/amphtml","forks_url":"https://api.github.com/repos/jridgewell/amphtml/forks","keys_url":"https://api.github.com/repos/jridgewell/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jridgewell/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jridgewell/amphtml/teams","hooks_url":"https://api.github.com/repos/jridgewell/amphtml/hooks","issue_events_url":"https://api.github.com/repos/jridgewell/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/jridgewell/amphtml/events","assignees_url":"https://api.github.com/repos/jridgewell/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/jridgewell/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/jridgewell/amphtml/tags","blobs_url":"https://api.github.com/repos/jridgewell/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jridgewell/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jridgewell/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/jridgewell/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jridgewell/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/jridgewell/amphtml/languages","stargazers_url":"https://api.github.com/repos/jridgewell/amphtml/stargazers","contributors_url":"https://api.github.com/repos/jridgewell/amphtml/contributors","subscribers_url":"https://api.github.com/repos/jridgewell/amphtml/subscribers","subscription_url":"https://api.github.com/repos/jridgewell/amphtml/subscription","commits_url":"https://api.github.com/repos/jridgewell/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/jridgewell/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/jridgewell/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/jridgewell/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/jridgewell/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/jridgewell/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jridgewell/amphtml/merges","archive_url":"https://api.github.com/repos/jridgewell/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jridgewell/amphtml/downloads","issues_url":"https://api.github.com/repos/jridgewell/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/jridgewell/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/jridgewell/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/jridgewell/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jridgewell/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/jridgewell/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/jridgewell/amphtml/deployments","created_at":"2015-12-17T21:21:35Z","updated_at":"2016-11-03T19:21:35Z","pushed_at":"2018-02-12T20:29:00Z","git_url":"git://github.com/jridgewell/amphtml.git","ssh_url":"git@github.com:jridgewell/amphtml.git","clone_url":"https://github.com/jridgewell/amphtml.git","svn_url":"https://github.com/jridgewell/amphtml","homepage":"http://justin.ridgewell.name/amphtml/","size":306272,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"d03f1692437af5779d0eef026d7ee1f72167d592","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2018-02-12T20:28:54Z","pushed_at":"2018-02-12T19:54:16Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://www.ampproject.org","size":374959,"stargazers_count":10944,"watchers_count":10944,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2210,"mirror_url":null,"archived":false,"open_issues_count":1130,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2210,"open_issues":1130,"watchers":10944,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/13449"},"html":{"href":"https://github.com/ampproject/amphtml/pull/13449"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/13449"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/13449/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/13449/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/13449/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/ac00c9f34803c4c7387d56cf26d8e7f26e9b39e0"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":5,"additions":272,"deletions":172,"changed_files":32}}
{"actor":{"display_login":"jridgewell"}}