{"action":"created","issue":{"url":"https://api.github.com/repos/alphagov/paas-team-manual/issues/204","repository_url":"https://api.github.com/repos/alphagov/paas-team-manual","labels_url":"https://api.github.com/repos/alphagov/paas-team-manual/issues/204/labels{/name}","comments_url":"https://api.github.com/repos/alphagov/paas-team-manual/issues/204/comments","events_url":"https://api.github.com/repos/alphagov/paas-team-manual/issues/204/events","html_url":"https://github.com/alphagov/paas-team-manual/pull/204","id":319514028,"number":204,"title":"[#156658598] Update to use a custom domain","user":{"login":"alext","id":5560,"avatar_url":"https://avatars3.githubusercontent.com/u/5560?v=4","gravatar_id":"","url":"https://api.github.com/users/alext","html_url":"https://github.com/alext","followers_url":"https://api.github.com/users/alext/followers","following_url":"https://api.github.com/users/alext/following{/other_user}","gists_url":"https://api.github.com/users/alext/gists{/gist_id}","starred_url":"https://api.github.com/users/alext/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alext/subscriptions","organizations_url":"https://api.github.com/users/alext/orgs","repos_url":"https://api.github.com/users/alext/repos","events_url":"https://api.github.com/users/alext/events{/privacy}","received_events_url":"https://api.github.com/users/alext/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-02T11:27:18Z","updated_at":"2018-05-02T15:12:24Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/alphagov/paas-team-manual/pulls/204","html_url":"https://github.com/alphagov/paas-team-manual/pull/204","diff_url":"https://github.com/alphagov/paas-team-manual/pull/204.diff","patch_url":"https://github.com/alphagov/paas-team-manual/pull/204.patch"},"body":"## What\r\nUsing a [custom domain](https://blog.github.com/2018-05-01-github-pages-custom-domains-https/) avoids issues with some internal links that\r\nlinke between sections and therefore have to use an absolute path. When\r\ndeployed on the alphagov.github.io domain, Github Pages adds a\r\npaas-team-manual path prefix, which breaks these links. The link checker\r\ndoesn't pick these up as broke because the prefix doesn't exist when\r\nbuilding/viewing locally.  Using a custom domain avoids the need for\r\nthis prefix.\r\n\r\n## How to review\r\n\r\n* Build locally ('bundle exec middleman build`)\r\n* Verify that absolute links use the correct hostname\r\n\r\n## :rotating_light: Before Merging :rotating_light:\r\n\r\nhttps://github.com/alphagov/paas-aws-account-wide-terraform/pull/124 must be merged and applied, and Github Pages must be configured accordingly before this is merged.\r\n\r\n## Who can review\r\n\r\nNot me"},"comment":{"url":"https://api.github.com/repos/alphagov/paas-team-manual/issues/comments/386012854","html_url":"https://github.com/alphagov/paas-team-manual/pull/204#issuecomment-386012854","issue_url":"https://api.github.com/repos/alphagov/paas-team-manual/issues/204","id":386012854,"user":{"login":"alext","id":5560,"avatar_url":"https://avatars3.githubusercontent.com/u/5560?v=4","gravatar_id":"","url":"https://api.github.com/users/alext","html_url":"https://github.com/alext","followers_url":"https://api.github.com/users/alext/followers","following_url":"https://api.github.com/users/alext/following{/other_user}","gists_url":"https://api.github.com/users/alext/gists{/gist_id}","starred_url":"https://api.github.com/users/alext/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alext/subscriptions","organizations_url":"https://api.github.com/users/alext/orgs","repos_url":"https://api.github.com/users/alext/repos","events_url":"https://api.github.com/users/alext/events{/privacy}","received_events_url":"https://api.github.com/users/alext/received_events","type":"User","site_admin":false},"created_at":"2018-05-02T15:12:24Z","updated_at":"2018-05-02T15:12:24Z","author_association":"OWNER","body":"Actually, the site verification file doesn't need to change."}}
{"actor":{"display_login":"alext"}}