{"push_id":2952342050,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"55382391626553e5e1aff8b6ec5ad7abd5967f0d","before":"9c3165110eff9b4b5c6a4dcda34226500644f50d","commits":[{"sha":"55382391626553e5e1aff8b6ec5ad7abd5967f0d","author":{"name":"Shannon Zhu","email":"aba954dd0d24f72c34940062bf73c05b82e4883d@fb.com"},"message":"Store postcondition for nodes in shared memory\n\nSummary:\nEvaluating performance difference on this.\n\nDecided to give this a shot rather than a more hacky (but less duplicated storage) approach, which would be to store the post condition of the last statement as some special key, and then when accessing the postconditions in astExport fixpoint, pass in the previous statement in each iteration to store the value of the lookup under each time, looking up the \"fake\" end statement in the last case.\n\nThat's gross, but currently we do not store the final resolution of each define anywhere else and so this wouldn't be accessible after typecheck is over any other way. If adding extra storage to the existing shared memory per statement doesn't have any meaningful perf impact, doing the extra storage might be preferable (and also make it more obvious that we're getting a precondition).\n\nReviewed By: sinancepel\n\nDifferential Revision: D10250799\n\nfbshipit-source-id: 5dee9de0b8cb2aa0094b0749ef203cc5197bc98d","distinct":true,"url":"https://api.github.com/repos/facebook/pyre-check/commits/55382391626553e5e1aff8b6ec5ad7abd5967f0d"}]}
{"actor":{"display_login":"facebook-github-bot"}}