{"action":"created","issue":{"url":"https://api.github.com/repos/openjournals/jose-reviews/issues/32","repository_url":"https://api.github.com/repos/openjournals/jose-reviews","labels_url":"https://api.github.com/repos/openjournals/jose-reviews/issues/32/labels{/name}","comments_url":"https://api.github.com/repos/openjournals/jose-reviews/issues/32/comments","events_url":"https://api.github.com/repos/openjournals/jose-reviews/issues/32/events","html_url":"https://github.com/openjournals/jose-reviews/issues/32","id":367798714,"node_id":"MDU6SXNzdWUzNjc3OTg3MTQ=","number":32,"title":"[REVIEW]: nbgrader: A Tool for Creating and Grading Assignments in the Jupyter Notebook","user":{"login":"whedon","id":18508068,"node_id":"MDQ6VXNlcjE4NTA4MDY4","avatar_url":"https://avatars3.githubusercontent.com/u/18508068?v=4","gravatar_id":"","url":"https://api.github.com/users/whedon","html_url":"https://github.com/whedon","followers_url":"https://api.github.com/users/whedon/followers","following_url":"https://api.github.com/users/whedon/following{/other_user}","gists_url":"https://api.github.com/users/whedon/gists{/gist_id}","starred_url":"https://api.github.com/users/whedon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whedon/subscriptions","organizations_url":"https://api.github.com/users/whedon/orgs","repos_url":"https://api.github.com/users/whedon/repos","events_url":"https://api.github.com/users/whedon/events{/privacy}","received_events_url":"https://api.github.com/users/whedon/received_events","type":"User","site_admin":false},"labels":[{"id":854420195,"node_id":"MDU6TGFiZWw4NTQ0MjAxOTU=","url":"https://api.github.com/repos/openjournals/jose-reviews/labels/review","name":"review","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"jedbrown","id":3303,"node_id":"MDQ6VXNlcjMzMDM=","avatar_url":"https://avatars3.githubusercontent.com/u/3303?v=4","gravatar_id":"","url":"https://api.github.com/users/jedbrown","html_url":"https://github.com/jedbrown","followers_url":"https://api.github.com/users/jedbrown/followers","following_url":"https://api.github.com/users/jedbrown/following{/other_user}","gists_url":"https://api.github.com/users/jedbrown/gists{/gist_id}","starred_url":"https://api.github.com/users/jedbrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedbrown/subscriptions","organizations_url":"https://api.github.com/users/jedbrown/orgs","repos_url":"https://api.github.com/users/jedbrown/repos","events_url":"https://api.github.com/users/jedbrown/events{/privacy}","received_events_url":"https://api.github.com/users/jedbrown/received_events","type":"User","site_admin":false},"assignees":[{"login":"jedbrown","id":3303,"node_id":"MDQ6VXNlcjMzMDM=","avatar_url":"https://avatars3.githubusercontent.com/u/3303?v=4","gravatar_id":"","url":"https://api.github.com/users/jedbrown","html_url":"https://github.com/jedbrown","followers_url":"https://api.github.com/users/jedbrown/followers","following_url":"https://api.github.com/users/jedbrown/following{/other_user}","gists_url":"https://api.github.com/users/jedbrown/gists{/gist_id}","starred_url":"https://api.github.com/users/jedbrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedbrown/subscriptions","organizations_url":"https://api.github.com/users/jedbrown/orgs","repos_url":"https://api.github.com/users/jedbrown/repos","events_url":"https://api.github.com/users/jedbrown/events{/privacy}","received_events_url":"https://api.github.com/users/jedbrown/received_events","type":"User","site_admin":false},{"login":"MattForshaw","id":1705898,"node_id":"MDQ6VXNlcjE3MDU4OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1705898?v=4","gravatar_id":"","url":"https://api.github.com/users/MattForshaw","html_url":"https://github.com/MattForshaw","followers_url":"https://api.github.com/users/MattForshaw/followers","following_url":"https://api.github.com/users/MattForshaw/following{/other_user}","gists_url":"https://api.github.com/users/MattForshaw/gists{/gist_id}","starred_url":"https://api.github.com/users/MattForshaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattForshaw/subscriptions","organizations_url":"https://api.github.com/users/MattForshaw/orgs","repos_url":"https://api.github.com/users/MattForshaw/repos","events_url":"https://api.github.com/users/MattForshaw/events{/privacy}","received_events_url":"https://api.github.com/users/MattForshaw/received_events","type":"User","site_admin":false},{"login":"labarba","id":4800109,"node_id":"MDQ6VXNlcjQ4MDAxMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/4800109?v=4","gravatar_id":"","url":"https://api.github.com/users/labarba","html_url":"https://github.com/labarba","followers_url":"https://api.github.com/users/labarba/followers","following_url":"https://api.github.com/users/labarba/following{/other_user}","gists_url":"https://api.github.com/users/labarba/gists{/gist_id}","starred_url":"https://api.github.com/users/labarba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labarba/subscriptions","organizations_url":"https://api.github.com/users/labarba/orgs","repos_url":"https://api.github.com/users/labarba/repos","events_url":"https://api.github.com/users/labarba/events{/privacy}","received_events_url":"https://api.github.com/users/labarba/received_events","type":"User","site_admin":false}],"milestone":null,"comments":17,"created_at":"2018-10-08T13:47:26Z","updated_at":"2018-11-22T19:31:35Z","closed_at":null,"author_association":"COLLABORATOR","body":"**Submitting author:** @jhamrick (<a href=\"http://orcid.org/0000-0002-3860-0429\">Jessica B. Hamrick</a>)\r\n**Repository:** <a href=\"https://github.com/jupyter/nbgrader\" target =\"_blank\">https://github.com/jupyter/nbgrader</a>\r\n**Version:** v0.5.4\r\n**Editor:** @labarba\r\n**Reviewers:** @MattForshaw, @jedbrown\r\n**Archive:** Pending\r\n\r\n## Status\r\n\r\n[![status](http://jose.theoj.org/papers/d86e078cd3990138cc6e630331410d29/status.svg)](http://jose.theoj.org/papers/d86e078cd3990138cc6e630331410d29)\r\n\r\nStatus badge code:\r\n\r\n```\r\nHTML: <a href=\"http://jose.theoj.org/papers/d86e078cd3990138cc6e630331410d29\"><img src=\"http://jose.theoj.org/papers/d86e078cd3990138cc6e630331410d29/status.svg\"></a>\r\nMarkdown: [![status](http://jose.theoj.org/papers/d86e078cd3990138cc6e630331410d29/status.svg)](http://jose.theoj.org/papers/d86e078cd3990138cc6e630331410d29)\r\n```\r\n**Reviewers and authors**:\r\n\r\nPlease avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the <a href=\"https://github.com/jupyter/nbgrader\" target=\"_blank\">target repository</a> and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)\r\n\r\n## Reviewer instructions & questions\r\n\r\n@MattForshaw, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:\r\n1. Make sure you're logged in to your GitHub account\r\n2. Be sure to accept the invite at this URL: https://github.com/openjournals/jose-reviews/invitations\r\n\r\nThe reviewer guidelines are available here: https://jose.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @labarba know.\r\n\r\n## Review checklist for @MattForshaw\r\n\r\n### Conflict of interest\r\n\r\n- [x] As the reviewer I confirm that I have read the [JOSE conflict of interest policy](https://github.com/openjournals/jose/blob/master/COI.md) and that there are no conflicts of interest for me to review this work.\r\n\r\n### Code of Conduct\r\n\r\n- [x] I confirm that I read and will adhere to the [JOSE code of conduct](https://jose.theoj.org/about#code_of_conduct).\r\n\r\n### General checks\r\n\r\n- [x] **Repository:** Is the source code for this software available at the <a target=\"_blank\" href=\"https://github.com/jupyter/nbgrader\">repository url</a>?\r\n- [x] **License:** Does the repository contain a plain-text LICENSE file with the contents of an [OSI approved](https://opensource.org/licenses/alphabetical) software license?\r\n- [x] **Version:** Does the release version given match the GitHub release (v0.5.4)?\r\n- [x] **Authorship:** Has the submitting author (@jhamrick) made substantial contributions to the software? Does the full list of paper authors seem appropriate and complete?\r\n\r\n### Functionality\r\n\r\n- [x] **Installation:** Does installation proceed as outlined in the documentation? (and documentation is sufficient?)\r\n- [x] **Functionality:** Have the functional claims of the software been confirmed?\r\n- [x] **Performance:** If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)\r\n\r\n### Documentation\r\n\r\n- [x] **A statement of need:** Do the authors clearly state the need for this software and who the target audience is?\r\n- [x] **Installation instructions:** Is there a clearly stated list of dependencies? (Ideally these should be handled with an automated package management solution.)\r\n- [x] **Example usage:** Do the authors include examples of how to use the software?\r\n- [x] **Functionality documentation:** Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?\r\n- [x] **Tests:** Are there automated tests or manual steps described so that the function of the software can be verified?\r\n- [x] **Community guidelines:** Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support\r\n\r\n### Software paper\r\n\r\n- [x] **Authors:** Does the `paper.md` file include a list of authors with their affiliations?\r\n- [x] **A statement of need:** Do the authors clearly state the need for this software and who the target audience is?\r\n- [x] **References:** Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?\r\n\r\n## Review checklist for @jedbrown\r\n\r\n### Conflict of interest\r\n\r\n- [x] As the reviewer I confirm that I have read the [JOSE conflict of interest policy](https://github.com/openjournals/jose/blob/master/COI.md) and that there are no conflicts of interest for me to review this work.\r\n\r\n### Code of Conduct\r\n\r\n- [x] I confirm that I read and will adhere to the [JOSE code of conduct](https://jose.theoj.org/about#code_of_conduct).\r\n\r\n### General checks\r\n\r\n- [x] **Repository:** Is the source code for this software available at the <a target=\"_blank\" href=\"https://github.com/jupyter/nbgrader\">repository url</a>?\r\n- [x] **License:** Does the repository contain a plain-text LICENSE file with the contents of an [OSI approved](https://opensource.org/licenses/alphabetical) software license?\r\n- [ ] **Version:** Does the release version given match the GitHub release (v0.5.4)?\r\n- [x] **Authorship:** Has the submitting author (@jhamrick) made substantial contributions to the software? Does the full list of paper authors seem appropriate and complete?\r\n\r\n### Functionality\r\n\r\n- [x] **Installation:** Does installation proceed as outlined in the documentation? (and documentation is sufficient?)\r\n- [x] **Functionality:** Have the functional claims of the software been confirmed?\r\n- [x] **Performance:** If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)\r\n\r\n### Documentation\r\n\r\n- [x] **A statement of need:** Do the authors clearly state the need for this software and who the target audience is?\r\n- [x] **Installation instructions:** Is there a clearly stated list of dependencies? (Ideally these should be handled with an automated package management solution.)\r\n- [x] **Example usage:** Do the authors include examples of how to use the software?\r\n- [x] **Functionality documentation:** Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?\r\n- [ ] **Tests:** Are there automated tests or manual steps described so that the function of the software can be verified?\r\n- [x] **Community guidelines:** Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support\r\n\r\n### Software paper\r\n\r\n- [x] **Authors:** Does the `paper.md` file include a list of authors with their affiliations?\r\n- [x] **A statement of need:** Do the authors clearly state the need for this software and who the target audience is?\r\n- [ ] **References:** Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?\r\n"},"comment":{"url":"https://api.github.com/repos/openjournals/jose-reviews/issues/comments/441108621","html_url":"https://github.com/openjournals/jose-reviews/issues/32#issuecomment-441108621","issue_url":"https://api.github.com/repos/openjournals/jose-reviews/issues/32","id":441108621,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTEwODYyMQ==","user":{"login":"jedbrown","id":3303,"node_id":"MDQ6VXNlcjMzMDM=","avatar_url":"https://avatars3.githubusercontent.com/u/3303?v=4","gravatar_id":"","url":"https://api.github.com/users/jedbrown","html_url":"https://github.com/jedbrown","followers_url":"https://api.github.com/users/jedbrown/followers","following_url":"https://api.github.com/users/jedbrown/following{/other_user}","gists_url":"https://api.github.com/users/jedbrown/gists{/gist_id}","starred_url":"https://api.github.com/users/jedbrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedbrown/subscriptions","organizations_url":"https://api.github.com/users/jedbrown/orgs","repos_url":"https://api.github.com/users/jedbrown/repos","events_url":"https://api.github.com/users/jedbrown/events{/privacy}","received_events_url":"https://api.github.com/users/jedbrown/received_events","type":"User","site_admin":false},"created_at":"2018-11-22T19:31:35Z","updated_at":"2018-11-22T19:31:35Z","author_association":"COLLABORATOR","body":"Is there documentation of the branching scheme? The branch `0.5.x` is neither a subset nor superset of `master`. Most branching schemes would merge one way or the other. Also, the tags are \"lightweight\" as opposed to \"annotated\" so `git describe` fails without the `--tags` option. Also, the paper is build from `master` which is not a descendant of `v0.5.4`.\r\n\r\nI filed a couple issues relating to testing. They are not mandatory to address at this time, but I'd like authors to have a chance to respond.\r\n\r\nSome references need capitalization help (see PR)."}}
{"actor":{"display_login":"jedbrown"}}