{"action":"created","comment":{"url":"https://api.github.com/repos/aicis/fresco/pulls/comments/224564006","pull_request_review_id":163963707,"id":224564006,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDU2NDAwNg==","diff_hunk":"@@ -77,6 +77,9 @@ private void runTest(\n       TestThreadRunner.TestThreadFactory<DummyArithmeticResourcePool, ProtocolBuilderNumeric> f,\n       EvaluationStrategy evalStrategy, int noOfParties, BigInteger mod, int maxBitLength,\n       int fixedPointPrecision, boolean logPerformance) {\n+    if (evalStrategy == EvaluationStrategy.SEQUENTIAL) {\n+      throw new IllegalArgumentException(\":(\");","path":"core/src/test/java/dk/alexandra/fresco/suite/dummy/arithmetic/AbstractDummyArithmeticTest.java","position":5,"original_position":5,"commit_id":"21e114d97bdfb6279fc4235f87d96d517dac5332","original_commit_id":"21e114d97bdfb6279fc4235f87d96d517dac5332","user":{"login":"n1v0lg","id":13320119,"node_id":"MDQ6VXNlcjEzMzIwMTE5","avatar_url":"https://avatars3.githubusercontent.com/u/13320119?v=4","gravatar_id":"","url":"https://api.github.com/users/n1v0lg","html_url":"https://github.com/n1v0lg","followers_url":"https://api.github.com/users/n1v0lg/followers","following_url":"https://api.github.com/users/n1v0lg/following{/other_user}","gists_url":"https://api.github.com/users/n1v0lg/gists{/gist_id}","starred_url":"https://api.github.com/users/n1v0lg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n1v0lg/subscriptions","organizations_url":"https://api.github.com/users/n1v0lg/orgs","repos_url":"https://api.github.com/users/n1v0lg/repos","events_url":"https://api.github.com/users/n1v0lg/events{/privacy}","received_events_url":"https://api.github.com/users/n1v0lg/received_events","type":"User","site_admin":false},"body":"Ah, good catch, forgot to delete that.","created_at":"2018-10-11T18:52:05Z","updated_at":"2018-10-11T18:52:05Z","html_url":"https://github.com/aicis/fresco/pull/308#discussion_r224564006","pull_request_url":"https://api.github.com/repos/aicis/fresco/pulls/308","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/aicis/fresco/pulls/comments/224564006"},"html":{"href":"https://github.com/aicis/fresco/pull/308#discussion_r224564006"},"pull_request":{"href":"https://api.github.com/repos/aicis/fresco/pulls/308"}},"in_reply_to_id":224541028},"pull_request":{"url":"https://api.github.com/repos/aicis/fresco/pulls/308","id":222109398,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMTA5Mzk4","html_url":"https://github.com/aicis/fresco/pull/308","diff_url":"https://github.com/aicis/fresco/pull/308.diff","patch_url":"https://github.com/aicis/fresco/pull/308.patch","issue_url":"https://api.github.com/repos/aicis/fresco/issues/308","number":308,"state":"open","locked":false,"title":"307 kill seq tests","user":{"login":"n1v0lg","id":13320119,"node_id":"MDQ6VXNlcjEzMzIwMTE5","avatar_url":"https://avatars3.githubusercontent.com/u/13320119?v=4","gravatar_id":"","url":"https://api.github.com/users/n1v0lg","html_url":"https://github.com/n1v0lg","followers_url":"https://api.github.com/users/n1v0lg/followers","following_url":"https://api.github.com/users/n1v0lg/following{/other_user}","gists_url":"https://api.github.com/users/n1v0lg/gists{/gist_id}","starred_url":"https://api.github.com/users/n1v0lg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n1v0lg/subscriptions","organizations_url":"https://api.github.com/users/n1v0lg/orgs","repos_url":"https://api.github.com/users/n1v0lg/repos","events_url":"https://api.github.com/users/n1v0lg/events{/privacy}","received_events_url":"https://api.github.com/users/n1v0lg/received_events","type":"User","site_admin":false},"body":"- Removes sequential tests from spdz/ dummy arithmetic suites\r\n- Uses smaller modulus where possible for spdz\r\n- Sets up AbstractSpdzTest for more refactoring","created_at":"2018-10-11T11:54:59Z","updated_at":"2018-10-11T18:52:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f8184b725d07e5942014ae6ecfba56b9e9ad407","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aicis/fresco/pulls/308/commits","review_comments_url":"https://api.github.com/repos/aicis/fresco/pulls/308/comments","review_comment_url":"https://api.github.com/repos/aicis/fresco/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aicis/fresco/issues/308/comments","statuses_url":"https://api.github.com/repos/aicis/fresco/statuses/21e114d97bdfb6279fc4235f87d96d517dac5332","head":{"label":"aicis:307-kill-seq-tests","ref":"307-kill-seq-tests","sha":"21e114d97bdfb6279fc4235f87d96d517dac5332","user":{"login":"aicis","id":23210753,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjEwNzUz","avatar_url":"https://avatars1.githubusercontent.com/u/23210753?v=4","gravatar_id":"","url":"https://api.github.com/users/aicis","html_url":"https://github.com/aicis","followers_url":"https://api.github.com/users/aicis/followers","following_url":"https://api.github.com/users/aicis/following{/other_user}","gists_url":"https://api.github.com/users/aicis/gists{/gist_id}","starred_url":"https://api.github.com/users/aicis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aicis/subscriptions","organizations_url":"https://api.github.com/users/aicis/orgs","repos_url":"https://api.github.com/users/aicis/repos","events_url":"https://api.github.com/users/aicis/events{/privacy}","received_events_url":"https://api.github.com/users/aicis/received_events","type":"Organization","site_admin":false},"repo":{"id":46789213,"node_id":"MDEwOlJlcG9zaXRvcnk0Njc4OTIxMw==","name":"fresco","full_name":"aicis/fresco","private":false,"owner":{"login":"aicis","id":23210753,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjEwNzUz","avatar_url":"https://avatars1.githubusercontent.com/u/23210753?v=4","gravatar_id":"","url":"https://api.github.com/users/aicis","html_url":"https://github.com/aicis","followers_url":"https://api.github.com/users/aicis/followers","following_url":"https://api.github.com/users/aicis/following{/other_user}","gists_url":"https://api.github.com/users/aicis/gists{/gist_id}","starred_url":"https://api.github.com/users/aicis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aicis/subscriptions","organizations_url":"https://api.github.com/users/aicis/orgs","repos_url":"https://api.github.com/users/aicis/repos","events_url":"https://api.github.com/users/aicis/events{/privacy}","received_events_url":"https://api.github.com/users/aicis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aicis/fresco","description":"A FRamework for Efficient Secure COmputation","fork":false,"url":"https://api.github.com/repos/aicis/fresco","forks_url":"https://api.github.com/repos/aicis/fresco/forks","keys_url":"https://api.github.com/repos/aicis/fresco/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aicis/fresco/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aicis/fresco/teams","hooks_url":"https://api.github.com/repos/aicis/fresco/hooks","issue_events_url":"https://api.github.com/repos/aicis/fresco/issues/events{/number}","events_url":"https://api.github.com/repos/aicis/fresco/events","assignees_url":"https://api.github.com/repos/aicis/fresco/assignees{/user}","branches_url":"https://api.github.com/repos/aicis/fresco/branches{/branch}","tags_url":"https://api.github.com/repos/aicis/fresco/tags","blobs_url":"https://api.github.com/repos/aicis/fresco/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aicis/fresco/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aicis/fresco/git/refs{/sha}","trees_url":"https://api.github.com/repos/aicis/fresco/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aicis/fresco/statuses/{sha}","languages_url":"https://api.github.com/repos/aicis/fresco/languages","stargazers_url":"https://api.github.com/repos/aicis/fresco/stargazers","contributors_url":"https://api.github.com/repos/aicis/fresco/contributors","subscribers_url":"https://api.github.com/repos/aicis/fresco/subscribers","subscription_url":"https://api.github.com/repos/aicis/fresco/subscription","commits_url":"https://api.github.com/repos/aicis/fresco/commits{/sha}","git_commits_url":"https://api.github.com/repos/aicis/fresco/git/commits{/sha}","comments_url":"https://api.github.com/repos/aicis/fresco/comments{/number}","issue_comment_url":"https://api.github.com/repos/aicis/fresco/issues/comments{/number}","contents_url":"https://api.github.com/repos/aicis/fresco/contents/{+path}","compare_url":"https://api.github.com/repos/aicis/fresco/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aicis/fresco/merges","archive_url":"https://api.github.com/repos/aicis/fresco/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aicis/fresco/downloads","issues_url":"https://api.github.com/repos/aicis/fresco/issues{/number}","pulls_url":"https://api.github.com/repos/aicis/fresco/pulls{/number}","milestones_url":"https://api.github.com/repos/aicis/fresco/milestones{/number}","notifications_url":"https://api.github.com/repos/aicis/fresco/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aicis/fresco/labels{/name}","releases_url":"https://api.github.com/repos/aicis/fresco/releases{/id}","deployments_url":"https://api.github.com/repos/aicis/fresco/deployments","created_at":"2015-11-24T12:05:17Z","updated_at":"2018-10-11T08:47:46Z","pushed_at":"2018-10-11T16:00:15Z","git_url":"git://github.com/aicis/fresco.git","ssh_url":"git@github.com:aicis/fresco.git","clone_url":"https://github.com/aicis/fresco.git","svn_url":"https://github.com/aicis/fresco","homepage":null,"size":16381,"stargazers_count":38,"watchers_count":38,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":18,"open_issues":27,"watchers":38,"default_branch":"master"}},"base":{"label":"aicis:master","ref":"master","sha":"c7c9b573682847ecb8500f2a76d0f7666d070bc5","user":{"login":"aicis","id":23210753,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjEwNzUz","avatar_url":"https://avatars1.githubusercontent.com/u/23210753?v=4","gravatar_id":"","url":"https://api.github.com/users/aicis","html_url":"https://github.com/aicis","followers_url":"https://api.github.com/users/aicis/followers","following_url":"https://api.github.com/users/aicis/following{/other_user}","gists_url":"https://api.github.com/users/aicis/gists{/gist_id}","starred_url":"https://api.github.com/users/aicis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aicis/subscriptions","organizations_url":"https://api.github.com/users/aicis/orgs","repos_url":"https://api.github.com/users/aicis/repos","events_url":"https://api.github.com/users/aicis/events{/privacy}","received_events_url":"https://api.github.com/users/aicis/received_events","type":"Organization","site_admin":false},"repo":{"id":46789213,"node_id":"MDEwOlJlcG9zaXRvcnk0Njc4OTIxMw==","name":"fresco","full_name":"aicis/fresco","private":false,"owner":{"login":"aicis","id":23210753,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjEwNzUz","avatar_url":"https://avatars1.githubusercontent.com/u/23210753?v=4","gravatar_id":"","url":"https://api.github.com/users/aicis","html_url":"https://github.com/aicis","followers_url":"https://api.github.com/users/aicis/followers","following_url":"https://api.github.com/users/aicis/following{/other_user}","gists_url":"https://api.github.com/users/aicis/gists{/gist_id}","starred_url":"https://api.github.com/users/aicis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aicis/subscriptions","organizations_url":"https://api.github.com/users/aicis/orgs","repos_url":"https://api.github.com/users/aicis/repos","events_url":"https://api.github.com/users/aicis/events{/privacy}","received_events_url":"https://api.github.com/users/aicis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aicis/fresco","description":"A FRamework for Efficient Secure COmputation","fork":false,"url":"https://api.github.com/repos/aicis/fresco","forks_url":"https://api.github.com/repos/aicis/fresco/forks","keys_url":"https://api.github.com/repos/aicis/fresco/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aicis/fresco/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aicis/fresco/teams","hooks_url":"https://api.github.com/repos/aicis/fresco/hooks","issue_events_url":"https://api.github.com/repos/aicis/fresco/issues/events{/number}","events_url":"https://api.github.com/repos/aicis/fresco/events","assignees_url":"https://api.github.com/repos/aicis/fresco/assignees{/user}","branches_url":"https://api.github.com/repos/aicis/fresco/branches{/branch}","tags_url":"https://api.github.com/repos/aicis/fresco/tags","blobs_url":"https://api.github.com/repos/aicis/fresco/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aicis/fresco/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aicis/fresco/git/refs{/sha}","trees_url":"https://api.github.com/repos/aicis/fresco/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aicis/fresco/statuses/{sha}","languages_url":"https://api.github.com/repos/aicis/fresco/languages","stargazers_url":"https://api.github.com/repos/aicis/fresco/stargazers","contributors_url":"https://api.github.com/repos/aicis/fresco/contributors","subscribers_url":"https://api.github.com/repos/aicis/fresco/subscribers","subscription_url":"https://api.github.com/repos/aicis/fresco/subscription","commits_url":"https://api.github.com/repos/aicis/fresco/commits{/sha}","git_commits_url":"https://api.github.com/repos/aicis/fresco/git/commits{/sha}","comments_url":"https://api.github.com/repos/aicis/fresco/comments{/number}","issue_comment_url":"https://api.github.com/repos/aicis/fresco/issues/comments{/number}","contents_url":"https://api.github.com/repos/aicis/fresco/contents/{+path}","compare_url":"https://api.github.com/repos/aicis/fresco/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aicis/fresco/merges","archive_url":"https://api.github.com/repos/aicis/fresco/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aicis/fresco/downloads","issues_url":"https://api.github.com/repos/aicis/fresco/issues{/number}","pulls_url":"https://api.github.com/repos/aicis/fresco/pulls{/number}","milestones_url":"https://api.github.com/repos/aicis/fresco/milestones{/number}","notifications_url":"https://api.github.com/repos/aicis/fresco/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aicis/fresco/labels{/name}","releases_url":"https://api.github.com/repos/aicis/fresco/releases{/id}","deployments_url":"https://api.github.com/repos/aicis/fresco/deployments","created_at":"2015-11-24T12:05:17Z","updated_at":"2018-10-11T08:47:46Z","pushed_at":"2018-10-11T16:00:15Z","git_url":"git://github.com/aicis/fresco.git","ssh_url":"git@github.com:aicis/fresco.git","clone_url":"https://github.com/aicis/fresco.git","svn_url":"https://github.com/aicis/fresco","homepage":null,"size":16381,"stargazers_count":38,"watchers_count":38,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":18,"open_issues":27,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aicis/fresco/pulls/308"},"html":{"href":"https://github.com/aicis/fresco/pull/308"},"issue":{"href":"https://api.github.com/repos/aicis/fresco/issues/308"},"comments":{"href":"https://api.github.com/repos/aicis/fresco/issues/308/comments"},"review_comments":{"href":"https://api.github.com/repos/aicis/fresco/pulls/308/comments"},"review_comment":{"href":"https://api.github.com/repos/aicis/fresco/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aicis/fresco/pulls/308/commits"},"statuses":{"href":"https://api.github.com/repos/aicis/fresco/statuses/21e114d97bdfb6279fc4235f87d96d517dac5332"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"n1v0lg"}}