{"action":"created","issue":{"url":"https://api.github.com/repos/samonzeweb/godb/issues/18","repository_url":"https://api.github.com/repos/samonzeweb/godb","labels_url":"https://api.github.com/repos/samonzeweb/godb/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/samonzeweb/godb/issues/18/comments","events_url":"https://api.github.com/repos/samonzeweb/godb/issues/18/events","html_url":"https://github.com/samonzeweb/godb/issues/18","id":344952764,"node_id":"MDU6SXNzdWUzNDQ5NTI3NjQ=","number":18,"title":"Null* times MarshalJSON and UnmarshalJSON","user":{"login":"derkan","id":1723142,"node_id":"MDQ6VXNlcjE3MjMxNDI=","avatar_url":"https://avatars1.githubusercontent.com/u/1723142?v=4","gravatar_id":"","url":"https://api.github.com/users/derkan","html_url":"https://github.com/derkan","followers_url":"https://api.github.com/users/derkan/followers","following_url":"https://api.github.com/users/derkan/following{/other_user}","gists_url":"https://api.github.com/users/derkan/gists{/gist_id}","starred_url":"https://api.github.com/users/derkan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derkan/subscriptions","organizations_url":"https://api.github.com/users/derkan/orgs","repos_url":"https://api.github.com/users/derkan/repos","events_url":"https://api.github.com/users/derkan/events{/privacy}","received_events_url":"https://api.github.com/users/derkan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-26T18:18:19Z","updated_at":"2018-07-30T04:59:19Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Hi Samuel,\r\n\r\nIn my first pull request for `types`, I've added wrappers around `sql.Null*` types, but later we removed these wrappers to use directly `sql.Null*` types. But `sql.Null*` types don't have `MarshalJSON` and `UnmarshalJSON`  methods, which makes json data handling a problem. Also `types.NullTime` does not have such methods.\r\n\r\nIs it OK to add wrappers for `sql.Null*` types again for `MarshalJSON` and `UnmarshalJSON` methods? \r\n\r\nIf it is OK I'll create a pull request for json compatibility to all(`types.Null*`, `sql.Null*`), if not I'll create a pull request for json compatibility to only our types(`types.Null*`)."},"comment":{"url":"https://api.github.com/repos/samonzeweb/godb/issues/comments/408747237","html_url":"https://github.com/samonzeweb/godb/issues/18#issuecomment-408747237","issue_url":"https://api.github.com/repos/samonzeweb/godb/issues/18","id":408747237,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODc0NzIzNw==","user":{"login":"samonzeweb","id":1175552,"node_id":"MDQ6VXNlcjExNzU1NTI=","avatar_url":"https://avatars0.githubusercontent.com/u/1175552?v=4","gravatar_id":"","url":"https://api.github.com/users/samonzeweb","html_url":"https://github.com/samonzeweb","followers_url":"https://api.github.com/users/samonzeweb/followers","following_url":"https://api.github.com/users/samonzeweb/following{/other_user}","gists_url":"https://api.github.com/users/samonzeweb/gists{/gist_id}","starred_url":"https://api.github.com/users/samonzeweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samonzeweb/subscriptions","organizations_url":"https://api.github.com/users/samonzeweb/orgs","repos_url":"https://api.github.com/users/samonzeweb/repos","events_url":"https://api.github.com/users/samonzeweb/events{/privacy}","received_events_url":"https://api.github.com/users/samonzeweb/received_events","type":"User","site_admin":false},"created_at":"2018-07-30T04:59:19Z","updated_at":"2018-07-30T04:59:19Z","author_association":"OWNER","body":"Hi derkan,\r\n\r\nI'm on holiday, I'll get back in two weeks  and will not review anything before. I've no computer with me. And need to do anything except dev tasks ;)\r\n\r\nBut I think you can add types if needed. Take all your time to write docs, tests, ... as I'm not available. I'll try to review this near mid august.\r\n\r\nSam.\r\n\r\n\r\n"}}
{"actor":{"display_login":"samonzeweb"}}