{"action":"created","issue":{"url":"https://api.github.com/repos/pingcap/tidb/issues/8687","repository_url":"https://api.github.com/repos/pingcap/tidb","labels_url":"https://api.github.com/repos/pingcap/tidb/issues/8687/labels{/name}","comments_url":"https://api.github.com/repos/pingcap/tidb/issues/8687/comments","events_url":"https://api.github.com/repos/pingcap/tidb/issues/8687/events","html_url":"https://github.com/pingcap/tidb/pull/8687","id":390666751,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MzgwMDAx","number":8687,"title":"session: add error log to catch bug stack in Commit","user":{"login":"tiancaiamao","id":1420062,"node_id":"MDQ6VXNlcjE0MjAwNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1420062?v=4","gravatar_id":"","url":"https://api.github.com/users/tiancaiamao","html_url":"https://github.com/tiancaiamao","followers_url":"https://api.github.com/users/tiancaiamao/followers","following_url":"https://api.github.com/users/tiancaiamao/following{/other_user}","gists_url":"https://api.github.com/users/tiancaiamao/gists{/gist_id}","starred_url":"https://api.github.com/users/tiancaiamao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiancaiamao/subscriptions","organizations_url":"https://api.github.com/users/tiancaiamao/orgs","repos_url":"https://api.github.com/users/tiancaiamao/repos","events_url":"https://api.github.com/users/tiancaiamao/events{/privacy}","received_events_url":"https://api.github.com/users/tiancaiamao/received_events","type":"User","site_admin":false},"labels":[{"id":1160332888,"node_id":"MDU6TGFiZWwxMTYwMzMyODg4","url":"https://api.github.com/repos/pingcap/tidb/labels/component/session","name":"component/session","color":"49309b","default":false},{"id":472740874,"node_id":"MDU6TGFiZWw0NzI3NDA4NzQ=","url":"https://api.github.com/repos/pingcap/tidb/labels/priority/P1","name":"priority/P1","color":"b60205","default":false},{"id":660753991,"node_id":"MDU6TGFiZWw2NjA3NTM5OTE=","url":"https://api.github.com/repos/pingcap/tidb/labels/priority/release-blocker","name":"priority/release-blocker","color":"b60205","default":false},{"id":916643523,"node_id":"MDU6TGFiZWw5MTY2NDM1MjM=","url":"https://api.github.com/repos/pingcap/tidb/labels/require-LGT3","name":"require-LGT3","color":"d93f0b","default":false},{"id":630229257,"node_id":"MDU6TGFiZWw2MzAyMjkyNTc=","url":"https://api.github.com/repos/pingcap/tidb/labels/type/bug-fix","name":"type/bug-fix","color":"fc2929","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-12-13T12:55:57Z","updated_at":"2018-12-14T06:58:15Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/8687","html_url":"https://github.com/pingcap/tidb/pull/8687","diff_url":"https://github.com/pingcap/tidb/pull/8687.diff","patch_url":"https://github.com/pingcap/tidb/pull/8687.patch"},"body":"<!--\r\nThank you for contributing to TiDB! Please read TiDB's [CONTRIBUTING](https://github.com/pingcap/tidb/blob/master/CONTRIBUTING.md) document **BEFORE** filing this PR.\r\n-->\r\n\r\n### What problem does this PR solve? <!--add issue link with summary if exists-->\r\n\r\nMake the code more robust and easier to debug bug.\r\n\r\n### What is changed and how it works?\r\n\r\nAdd an error log if the transaction state is unexpected when calling `Commit` \r\n\r\n### Check List <!--REMOVE the items that are not applicable-->\r\n\r\nTests <!-- At least one of them must be included. -->\r\n\r\n - No code\r\n\r\n\r\nRelated changes\r\n\r\n - Need to cherry-pick to the release branch\r\n\r\n@winkyao @crazycs520\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/pingcap/tidb/8687)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/pingcap/tidb/issues/comments/447233818","html_url":"https://github.com/pingcap/tidb/pull/8687#issuecomment-447233818","issue_url":"https://api.github.com/repos/pingcap/tidb/issues/8687","id":447233818,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzIzMzgxOA==","user":{"login":"tiancaiamao","id":1420062,"node_id":"MDQ6VXNlcjE0MjAwNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1420062?v=4","gravatar_id":"","url":"https://api.github.com/users/tiancaiamao","html_url":"https://github.com/tiancaiamao","followers_url":"https://api.github.com/users/tiancaiamao/followers","following_url":"https://api.github.com/users/tiancaiamao/following{/other_user}","gists_url":"https://api.github.com/users/tiancaiamao/gists{/gist_id}","starred_url":"https://api.github.com/users/tiancaiamao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiancaiamao/subscriptions","organizations_url":"https://api.github.com/users/tiancaiamao/orgs","repos_url":"https://api.github.com/users/tiancaiamao/repos","events_url":"https://api.github.com/users/tiancaiamao/events{/privacy}","received_events_url":"https://api.github.com/users/tiancaiamao/received_events","type":"User","site_admin":false},"created_at":"2018-12-14T06:58:15Z","updated_at":"2018-12-14T06:58:15Z","author_association":"CONTRIBUTOR","body":"/run-all-tests"}}
{"actor":{"display_login":"tiancaiamao"}}