{"action":"created","comment":{"url":"https://api.github.com/repos/go1com/util_dataset/pulls/comments/237345002","pull_request_review_id":179619146,"id":237345002,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzM0NTAwMg==","diff_hunk":"@@ -248,6 +248,11 @@ private function generate(array $generators, int $index = 0)\n             return;\n         }\n \n+        # Skip if generator is disabled.\n+        if ($generators[$index][1] == false) {\n+            return;\n+        }\n+","path":"generator/CoreDataGeneratorTrait.php","position":8,"original_position":8,"commit_id":"20ff80f173dee08a75c74c7667f037d222bfcea6","original_commit_id":"20ff80f173dee08a75c74c7667f037d222bfcea6","user":{"login":"tienvx","id":3327643,"node_id":"MDQ6VXNlcjMzMjc2NDM=","avatar_url":"https://avatars2.githubusercontent.com/u/3327643?v=4","gravatar_id":"","url":"https://api.github.com/users/tienvx","html_url":"https://github.com/tienvx","followers_url":"https://api.github.com/users/tienvx/followers","following_url":"https://api.github.com/users/tienvx/following{/other_user}","gists_url":"https://api.github.com/users/tienvx/gists{/gist_id}","starred_url":"https://api.github.com/users/tienvx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tienvx/subscriptions","organizations_url":"https://api.github.com/users/tienvx/orgs","repos_url":"https://api.github.com/users/tienvx/repos","events_url":"https://api.github.com/users/tienvx/events{/privacy}","received_events_url":"https://api.github.com/users/tienvx/received_events","type":"User","site_admin":false},"body":"No need to do this, the code below already handle the enable/disable flag:\r\n```\r\n$generator->generate(\r\n            $this,\r\n            empty($generators[$index][1]) ? null : function () use (&$generators, $index) {\r\n                $this->generate($generators, $index + 1);\r\n            }\r\n        );\r\n```","created_at":"2018-11-29T03:46:29Z","updated_at":"2018-11-29T03:46:34Z","html_url":"https://github.com/go1com/util_dataset/pull/14#discussion_r237345002","pull_request_url":"https://api.github.com/repos/go1com/util_dataset/pulls/14","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/go1com/util_dataset/pulls/comments/237345002"},"html":{"href":"https://github.com/go1com/util_dataset/pull/14#discussion_r237345002"},"pull_request":{"href":"https://api.github.com/repos/go1com/util_dataset/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/go1com/util_dataset/pulls/14","id":234499394,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NDk5Mzk0","html_url":"https://github.com/go1com/util_dataset/pull/14","diff_url":"https://github.com/go1com/util_dataset/pull/14.diff","patch_url":"https://github.com/go1com/util_dataset/pull/14.patch","issue_url":"https://api.github.com/repos/go1com/util_dataset/issues/14","number":14,"state":"closed","locked":false,"title":"Make flag configuration work","user":{"login":"drushman","id":1734172,"node_id":"MDQ6VXNlcjE3MzQxNzI=","avatar_url":"https://avatars1.githubusercontent.com/u/1734172?v=4","gravatar_id":"","url":"https://api.github.com/users/drushman","html_url":"https://github.com/drushman","followers_url":"https://api.github.com/users/drushman/followers","following_url":"https://api.github.com/users/drushman/following{/other_user}","gists_url":"https://api.github.com/users/drushman/gists{/gist_id}","starred_url":"https://api.github.com/users/drushman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drushman/subscriptions","organizations_url":"https://api.github.com/users/drushman/orgs","repos_url":"https://api.github.com/users/drushman/repos","events_url":"https://api.github.com/users/drushman/events{/privacy}","received_events_url":"https://api.github.com/users/drushman/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-29T03:42:17Z","updated_at":"2018-11-29T03:46:34Z","closed_at":"2018-11-29T03:44:48Z","merged_at":"2018-11-29T03:44:48Z","merge_commit_sha":"09d24c67cffc8938e7365fa850c544a52b6edfad","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/go1com/util_dataset/pulls/14/commits","review_comments_url":"https://api.github.com/repos/go1com/util_dataset/pulls/14/comments","review_comment_url":"https://api.github.com/repos/go1com/util_dataset/pulls/comments{/number}","comments_url":"https://api.github.com/repos/go1com/util_dataset/issues/14/comments","statuses_url":"https://api.github.com/repos/go1com/util_dataset/statuses/20ff80f173dee08a75c74c7667f037d222bfcea6","head":{"label":"go1com:make-flag-work","ref":"make-flag-work","sha":"20ff80f173dee08a75c74c7667f037d222bfcea6","user":{"login":"go1com","id":16556899,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTU2ODk5","avatar_url":"https://avatars2.githubusercontent.com/u/16556899?v=4","gravatar_id":"","url":"https://api.github.com/users/go1com","html_url":"https://github.com/go1com","followers_url":"https://api.github.com/users/go1com/followers","following_url":"https://api.github.com/users/go1com/following{/other_user}","gists_url":"https://api.github.com/users/go1com/gists{/gist_id}","starred_url":"https://api.github.com/users/go1com/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go1com/subscriptions","organizations_url":"https://api.github.com/users/go1com/orgs","repos_url":"https://api.github.com/users/go1com/repos","events_url":"https://api.github.com/users/go1com/events{/privacy}","received_events_url":"https://api.github.com/users/go1com/received_events","type":"Organization","site_admin":false},"repo":{"id":119934850,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk5MzQ4NTA=","name":"util_dataset","full_name":"go1com/util_dataset","private":false,"owner":{"login":"go1com","id":16556899,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTU2ODk5","avatar_url":"https://avatars2.githubusercontent.com/u/16556899?v=4","gravatar_id":"","url":"https://api.github.com/users/go1com","html_url":"https://github.com/go1com","followers_url":"https://api.github.com/users/go1com/followers","following_url":"https://api.github.com/users/go1com/following{/other_user}","gists_url":"https://api.github.com/users/go1com/gists{/gist_id}","starred_url":"https://api.github.com/users/go1com/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go1com/subscriptions","organizations_url":"https://api.github.com/users/go1com/orgs","repos_url":"https://api.github.com/users/go1com/repos","events_url":"https://api.github.com/users/go1com/events{/privacy}","received_events_url":"https://api.github.com/users/go1com/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/go1com/util_dataset","description":"Dataset for test cases.","fork":false,"url":"https://api.github.com/repos/go1com/util_dataset","forks_url":"https://api.github.com/repos/go1com/util_dataset/forks","keys_url":"https://api.github.com/repos/go1com/util_dataset/keys{/key_id}","collaborators_url":"https://api.github.com/repos/go1com/util_dataset/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/go1com/util_dataset/teams","hooks_url":"https://api.github.com/repos/go1com/util_dataset/hooks","issue_events_url":"https://api.github.com/repos/go1com/util_dataset/issues/events{/number}","events_url":"https://api.github.com/repos/go1com/util_dataset/events","assignees_url":"https://api.github.com/repos/go1com/util_dataset/assignees{/user}","branches_url":"https://api.github.com/repos/go1com/util_dataset/branches{/branch}","tags_url":"https://api.github.com/repos/go1com/util_dataset/tags","blobs_url":"https://api.github.com/repos/go1com/util_dataset/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/go1com/util_dataset/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/go1com/util_dataset/git/refs{/sha}","trees_url":"https://api.github.com/repos/go1com/util_dataset/git/trees{/sha}","statuses_url":"https://api.github.com/repos/go1com/util_dataset/statuses/{sha}","languages_url":"https://api.github.com/repos/go1com/util_dataset/languages","stargazers_url":"https://api.github.com/repos/go1com/util_dataset/stargazers","contributors_url":"https://api.github.com/repos/go1com/util_dataset/contributors","subscribers_url":"https://api.github.com/repos/go1com/util_dataset/subscribers","subscription_url":"https://api.github.com/repos/go1com/util_dataset/subscription","commits_url":"https://api.github.com/repos/go1com/util_dataset/commits{/sha}","git_commits_url":"https://api.github.com/repos/go1com/util_dataset/git/commits{/sha}","comments_url":"https://api.github.com/repos/go1com/util_dataset/comments{/number}","issue_comment_url":"https://api.github.com/repos/go1com/util_dataset/issues/comments{/number}","contents_url":"https://api.github.com/repos/go1com/util_dataset/contents/{+path}","compare_url":"https://api.github.com/repos/go1com/util_dataset/compare/{base}...{head}","merges_url":"https://api.github.com/repos/go1com/util_dataset/merges","archive_url":"https://api.github.com/repos/go1com/util_dataset/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/go1com/util_dataset/downloads","issues_url":"https://api.github.com/repos/go1com/util_dataset/issues{/number}","pulls_url":"https://api.github.com/repos/go1com/util_dataset/pulls{/number}","milestones_url":"https://api.github.com/repos/go1com/util_dataset/milestones{/number}","notifications_url":"https://api.github.com/repos/go1com/util_dataset/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/go1com/util_dataset/labels{/name}","releases_url":"https://api.github.com/repos/go1com/util_dataset/releases{/id}","deployments_url":"https://api.github.com/repos/go1com/util_dataset/deployments","created_at":"2018-02-02T05:09:25Z","updated_at":"2018-11-29T03:44:50Z","pushed_at":"2018-11-29T03:45:02Z","git_url":"git://github.com/go1com/util_dataset.git","ssh_url":"git@github.com:go1com/util_dataset.git","clone_url":"https://github.com/go1com/util_dataset.git","svn_url":"https://github.com/go1com/util_dataset","homepage":null,"size":57,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":4,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"go1com:master","ref":"master","sha":"4b036279ca360ecfa95b56add3ee26a882c31939","user":{"login":"go1com","id":16556899,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTU2ODk5","avatar_url":"https://avatars2.githubusercontent.com/u/16556899?v=4","gravatar_id":"","url":"https://api.github.com/users/go1com","html_url":"https://github.com/go1com","followers_url":"https://api.github.com/users/go1com/followers","following_url":"https://api.github.com/users/go1com/following{/other_user}","gists_url":"https://api.github.com/users/go1com/gists{/gist_id}","starred_url":"https://api.github.com/users/go1com/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go1com/subscriptions","organizations_url":"https://api.github.com/users/go1com/orgs","repos_url":"https://api.github.com/users/go1com/repos","events_url":"https://api.github.com/users/go1com/events{/privacy}","received_events_url":"https://api.github.com/users/go1com/received_events","type":"Organization","site_admin":false},"repo":{"id":119934850,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk5MzQ4NTA=","name":"util_dataset","full_name":"go1com/util_dataset","private":false,"owner":{"login":"go1com","id":16556899,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTU2ODk5","avatar_url":"https://avatars2.githubusercontent.com/u/16556899?v=4","gravatar_id":"","url":"https://api.github.com/users/go1com","html_url":"https://github.com/go1com","followers_url":"https://api.github.com/users/go1com/followers","following_url":"https://api.github.com/users/go1com/following{/other_user}","gists_url":"https://api.github.com/users/go1com/gists{/gist_id}","starred_url":"https://api.github.com/users/go1com/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go1com/subscriptions","organizations_url":"https://api.github.com/users/go1com/orgs","repos_url":"https://api.github.com/users/go1com/repos","events_url":"https://api.github.com/users/go1com/events{/privacy}","received_events_url":"https://api.github.com/users/go1com/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/go1com/util_dataset","description":"Dataset for test cases.","fork":false,"url":"https://api.github.com/repos/go1com/util_dataset","forks_url":"https://api.github.com/repos/go1com/util_dataset/forks","keys_url":"https://api.github.com/repos/go1com/util_dataset/keys{/key_id}","collaborators_url":"https://api.github.com/repos/go1com/util_dataset/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/go1com/util_dataset/teams","hooks_url":"https://api.github.com/repos/go1com/util_dataset/hooks","issue_events_url":"https://api.github.com/repos/go1com/util_dataset/issues/events{/number}","events_url":"https://api.github.com/repos/go1com/util_dataset/events","assignees_url":"https://api.github.com/repos/go1com/util_dataset/assignees{/user}","branches_url":"https://api.github.com/repos/go1com/util_dataset/branches{/branch}","tags_url":"https://api.github.com/repos/go1com/util_dataset/tags","blobs_url":"https://api.github.com/repos/go1com/util_dataset/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/go1com/util_dataset/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/go1com/util_dataset/git/refs{/sha}","trees_url":"https://api.github.com/repos/go1com/util_dataset/git/trees{/sha}","statuses_url":"https://api.github.com/repos/go1com/util_dataset/statuses/{sha}","languages_url":"https://api.github.com/repos/go1com/util_dataset/languages","stargazers_url":"https://api.github.com/repos/go1com/util_dataset/stargazers","contributors_url":"https://api.github.com/repos/go1com/util_dataset/contributors","subscribers_url":"https://api.github.com/repos/go1com/util_dataset/subscribers","subscription_url":"https://api.github.com/repos/go1com/util_dataset/subscription","commits_url":"https://api.github.com/repos/go1com/util_dataset/commits{/sha}","git_commits_url":"https://api.github.com/repos/go1com/util_dataset/git/commits{/sha}","comments_url":"https://api.github.com/repos/go1com/util_dataset/comments{/number}","issue_comment_url":"https://api.github.com/repos/go1com/util_dataset/issues/comments{/number}","contents_url":"https://api.github.com/repos/go1com/util_dataset/contents/{+path}","compare_url":"https://api.github.com/repos/go1com/util_dataset/compare/{base}...{head}","merges_url":"https://api.github.com/repos/go1com/util_dataset/merges","archive_url":"https://api.github.com/repos/go1com/util_dataset/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/go1com/util_dataset/downloads","issues_url":"https://api.github.com/repos/go1com/util_dataset/issues{/number}","pulls_url":"https://api.github.com/repos/go1com/util_dataset/pulls{/number}","milestones_url":"https://api.github.com/repos/go1com/util_dataset/milestones{/number}","notifications_url":"https://api.github.com/repos/go1com/util_dataset/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/go1com/util_dataset/labels{/name}","releases_url":"https://api.github.com/repos/go1com/util_dataset/releases{/id}","deployments_url":"https://api.github.com/repos/go1com/util_dataset/deployments","created_at":"2018-02-02T05:09:25Z","updated_at":"2018-11-29T03:44:50Z","pushed_at":"2018-11-29T03:45:02Z","git_url":"git://github.com/go1com/util_dataset.git","ssh_url":"git@github.com:go1com/util_dataset.git","clone_url":"https://github.com/go1com/util_dataset.git","svn_url":"https://github.com/go1com/util_dataset","homepage":null,"size":57,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":4,"open_issues":0,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/go1com/util_dataset/pulls/14"},"html":{"href":"https://github.com/go1com/util_dataset/pull/14"},"issue":{"href":"https://api.github.com/repos/go1com/util_dataset/issues/14"},"comments":{"href":"https://api.github.com/repos/go1com/util_dataset/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/go1com/util_dataset/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/go1com/util_dataset/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/go1com/util_dataset/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/go1com/util_dataset/statuses/20ff80f173dee08a75c74c7667f037d222bfcea6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tienvx"}}