{"action":"created","issue":{"url":"https://api.github.com/repos/oppia/oppia/issues/5109","repository_url":"https://api.github.com/repos/oppia/oppia","labels_url":"https://api.github.com/repos/oppia/oppia/issues/5109/labels{/name}","comments_url":"https://api.github.com/repos/oppia/oppia/issues/5109/comments","events_url":"https://api.github.com/repos/oppia/oppia/issues/5109/events","html_url":"https://github.com/oppia/oppia/pull/5109","id":332730056,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MTQwNTM4","number":5109,"title":"Fix #5009: Add wait for suggestions e2e test","user":{"login":"nithusha21","id":11898234,"node_id":"MDQ6VXNlcjExODk4MjM0","avatar_url":"https://avatars2.githubusercontent.com/u/11898234?v=4","gravatar_id":"","url":"https://api.github.com/users/nithusha21","html_url":"https://github.com/nithusha21","followers_url":"https://api.github.com/users/nithusha21/followers","following_url":"https://api.github.com/users/nithusha21/following{/other_user}","gists_url":"https://api.github.com/users/nithusha21/gists{/gist_id}","starred_url":"https://api.github.com/users/nithusha21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nithusha21/subscriptions","organizations_url":"https://api.github.com/users/nithusha21/orgs","repos_url":"https://api.github.com/users/nithusha21/repos","events_url":"https://api.github.com/users/nithusha21/events{/privacy}","received_events_url":"https://api.github.com/users/nithusha21/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-06-15T10:51:15Z","updated_at":"2018-06-16T05:53:27Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/oppia/oppia/pulls/5109","html_url":"https://github.com/oppia/oppia/pull/5109","diff_url":"https://github.com/oppia/oppia/pull/5109.diff","patch_url":"https://github.com/oppia/oppia/pull/5109.patch"},"body":"## Explanation\r\nFix #5009 -- The e2e test that tests suggestions was flaky. The reason is possibly because after clicking the view suggestion button, before the modal appears, the test tries to click the accept button and then it fails to find the button. So I added a wait after the click view suggestion button statement.\r\n\r\nPTAL @apb7 @seanlip \r\n\r\n## Checklist\r\n- [x] The PR title starts with \"Fix #bugnum: \", followed by a short, clear summary of the changes.\r\n- [x] The PR explanation includes the words \"Fixes #bugnum: ...\".\r\n- [x] The linter/Karma presubmit checks have passed.\r\n  - These should run automatically, but if not, you can manually trigger them locally using `python scripts/pre_commit_linter.py` and `bash scripts/run_frontend_tests.sh`.\r\n- [x] The PR is made from a branch that's **not** called \"develop\".\r\n- [x] The PR follows the [style guide](https://github.com/oppia/oppia/wiki/Coding-style-guide).\r\n- [x] The PR is assigned to an appropriate reviewer.\r\n  - If you're a new contributor, please ask on [Gitter](https://gitter.im/oppia/oppia-chat) for someone to assign a reviewer.\r\n  - If you're not sure who the appropriate reviewer is, please assign to the issue's \"owner\" -- see the \"talk-to\" label on the issue.\r\n"},"comment":{"url":"https://api.github.com/repos/oppia/oppia/issues/comments/397789381","html_url":"https://github.com/oppia/oppia/pull/5109#issuecomment-397789381","issue_url":"https://api.github.com/repos/oppia/oppia/issues/5109","id":397789381,"node_id":"MDEyOklzc3VlQ29tbWVudDM5Nzc4OTM4MQ==","user":{"login":"nithusha21","id":11898234,"node_id":"MDQ6VXNlcjExODk4MjM0","avatar_url":"https://avatars2.githubusercontent.com/u/11898234?v=4","gravatar_id":"","url":"https://api.github.com/users/nithusha21","html_url":"https://github.com/nithusha21","followers_url":"https://api.github.com/users/nithusha21/followers","following_url":"https://api.github.com/users/nithusha21/following{/other_user}","gists_url":"https://api.github.com/users/nithusha21/gists{/gist_id}","starred_url":"https://api.github.com/users/nithusha21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nithusha21/subscriptions","organizations_url":"https://api.github.com/users/nithusha21/orgs","repos_url":"https://api.github.com/users/nithusha21/repos","events_url":"https://api.github.com/users/nithusha21/events{/privacy}","received_events_url":"https://api.github.com/users/nithusha21/received_events","type":"User","site_admin":false},"created_at":"2018-06-16T05:53:27Z","updated_at":"2018-06-16T05:53:27Z","author_association":"MEMBER","body":"Hmmm. I have no more ideas. This part of the test was the only part which I felt was a flake. If either of you could run this test a few times to identify another location where the test is flaky, it would be great! Thanks!"}}
{"actor":{"display_login":"nithusha21"}}