{"action":"created","issue":{"url":"https://api.github.com/repos/ohmybash/oh-my-bash/issues/24","repository_url":"https://api.github.com/repos/ohmybash/oh-my-bash","labels_url":"https://api.github.com/repos/ohmybash/oh-my-bash/issues/24/labels{/name}","comments_url":"https://api.github.com/repos/ohmybash/oh-my-bash/issues/24/comments","events_url":"https://api.github.com/repos/ohmybash/oh-my-bash/issues/24/events","html_url":"https://github.com/ohmybash/oh-my-bash/pull/24","id":344967433,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MjM3MTQ2","number":24,"title":"Allow overriding of prompt addition","user":{"login":"pokowaka","id":4935150,"node_id":"MDQ6VXNlcjQ5MzUxNTA=","avatar_url":"https://avatars1.githubusercontent.com/u/4935150?v=4","gravatar_id":"","url":"https://api.github.com/users/pokowaka","html_url":"https://github.com/pokowaka","followers_url":"https://api.github.com/users/pokowaka/followers","following_url":"https://api.github.com/users/pokowaka/following{/other_user}","gists_url":"https://api.github.com/users/pokowaka/gists{/gist_id}","starred_url":"https://api.github.com/users/pokowaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pokowaka/subscriptions","organizations_url":"https://api.github.com/users/pokowaka/orgs","repos_url":"https://api.github.com/users/pokowaka/repos","events_url":"https://api.github.com/users/pokowaka/events{/privacy}","received_events_url":"https://api.github.com/users/pokowaka/received_events","type":"User","site_admin":false},"labels":[{"id":1005313099,"node_id":"MDU6TGFiZWwxMDA1MzEzMDk5","url":"https://api.github.com/repos/ohmybash/oh-my-bash/labels/Next%20:next_track_button:","name":"Next :next_track_button:","color":"f2ca1a","default":false},{"id":1005311745,"node_id":"MDU6TGFiZWwxMDA1MzExNzQ1","url":"https://api.github.com/repos/ohmybash/oh-my-bash/labels/Ready%20To%20Merge","name":"Ready To Merge","color":"ffccf4","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-26T19:03:07Z","updated_at":"2018-08-15T19:29:03Z","closed_at":"2018-08-13T06:18:50Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ohmybash/oh-my-bash/pulls/24","html_url":"https://github.com/ohmybash/oh-my-bash/pull/24","diff_url":"https://github.com/ohmybash/oh-my-bash/pull/24.diff","patch_url":"https://github.com/ohmybash/oh-my-bash/pull/24.patch"},"body":"Some environments have stringent security features that do not allow the\r\nexecution of functions inside $PROMPT_COMMAND, breaking every individual\r\ntheme.\r\n\r\nWe now allow the overriding of the prompt setter command to workaround\r\nthis.\r\n\r\nExample usage:\r\n\r\nfunction append_prompt_command_override() {¶\r\n    pre_prompt_functions+=($1)\r\n}"},"comment":{"url":"https://api.github.com/repos/ohmybash/oh-my-bash/issues/comments/413308682","html_url":"https://github.com/ohmybash/oh-my-bash/pull/24#issuecomment-413308682","issue_url":"https://api.github.com/repos/ohmybash/oh-my-bash/issues/24","id":413308682,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzMwODY4Mg==","user":{"login":"DDifDEVzero","id":39010000,"node_id":"MDQ6VXNlcjM5MDEwMDAw","avatar_url":"https://avatars2.githubusercontent.com/u/39010000?v=4","gravatar_id":"","url":"https://api.github.com/users/DDifDEVzero","html_url":"https://github.com/DDifDEVzero","followers_url":"https://api.github.com/users/DDifDEVzero/followers","following_url":"https://api.github.com/users/DDifDEVzero/following{/other_user}","gists_url":"https://api.github.com/users/DDifDEVzero/gists{/gist_id}","starred_url":"https://api.github.com/users/DDifDEVzero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DDifDEVzero/subscriptions","organizations_url":"https://api.github.com/users/DDifDEVzero/orgs","repos_url":"https://api.github.com/users/DDifDEVzero/repos","events_url":"https://api.github.com/users/DDifDEVzero/events{/privacy}","received_events_url":"https://api.github.com/users/DDifDEVzero/received_events","type":"User","site_admin":false},"created_at":"2018-08-15T19:29:03Z","updated_at":"2018-08-15T19:29:03Z","author_association":"NONE","body":"So, I think I found the error:\r\n\r\nThe original code is\r\n\r\n**# See if we need to use the overriden version\r\n    if [[ $(fn_exists append_prompt_command_override) ]]; then\r\n       append_prompt_command_override $1\r\n       return\r\n    fi**\r\n\r\nand I think you have to insert \"function\" before append_prompt_command_override like the 1st post:\r\n\r\nExample usage:\r\n\r\nfunction append_prompt_command_override() {¶\r\npre_prompt_functions+=($1)\r\n}\r\n\r\nand so the code look like this:\r\n\r\n**# See if we need to use the overriden version\r\n    if [[ $(fn_exists function append_prompt_command_override) ]]; then\r\n       append_prompt_command_override $1\r\n       return\r\n    fi**\r\n\r\nEnjoy!"}}
{"actor":{"display_login":"DDifDEVzero"}}