{"action":"created","issue":{"url":"https://api.github.com/repos/openlayers/openlayers/issues/8385","repository_url":"https://api.github.com/repos/openlayers/openlayers","labels_url":"https://api.github.com/repos/openlayers/openlayers/issues/8385/labels{/name}","comments_url":"https://api.github.com/repos/openlayers/openlayers/issues/8385/comments","events_url":"https://api.github.com/repos/openlayers/openlayers/issues/8385/events","html_url":"https://github.com/openlayers/openlayers/pull/8385","id":341720085,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNzkxODMw","number":8385,"title":"Use class syntax","user":{"login":"tschaub","id":41094,"node_id":"MDQ6VXNlcjQxMDk0","avatar_url":"https://avatars0.githubusercontent.com/u/41094?v=4","gravatar_id":"","url":"https://api.github.com/users/tschaub","html_url":"https://github.com/tschaub","followers_url":"https://api.github.com/users/tschaub/followers","following_url":"https://api.github.com/users/tschaub/following{/other_user}","gists_url":"https://api.github.com/users/tschaub/gists{/gist_id}","starred_url":"https://api.github.com/users/tschaub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschaub/subscriptions","organizations_url":"https://api.github.com/users/tschaub/orgs","repos_url":"https://api.github.com/users/tschaub/repos","events_url":"https://api.github.com/users/tschaub/events{/privacy}","received_events_url":"https://api.github.com/users/tschaub/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-07-17T00:05:51Z","updated_at":"2018-07-17T11:56:54Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/openlayers/openlayers/pulls/8385","html_url":"https://github.com/openlayers/openlayers/pull/8385","diff_url":"https://github.com/openlayers/openlayers/pull/8385.diff","patch_url":"https://github.com/openlayers/openlayers/pull/8385.patch"},"body":"This branch converts our sources to use `class` syntax.  The purpose of this change is to get TypeScript type checking (see #8345).\r\n\r\nThe initial commit is an automated transform, but there will be a lot of manual work to complete this effort, so I think it makes sense to pause other work (hold off on merging other PRs) until this is complete.  Contributions are welcome - either pushed directly to this branch or pushed to other branches and cherry picked here.\r\n\r\nRemaining work:\r\n\r\n - [ ] Replace use of `inherits` with `extends`\r\n - [ ] Call `super()` instead of `Parent.call(this)`\r\n - [ ] Get rid of remaining `prototype` assignment\r\n - [ ] Add a transform to the test config\r\n - [ ] Add a transform step to the `prepare` script (using buble or babel if we want more control over our target browsers)\r\n\r\nFixes #8328."},"comment":{"url":"https://api.github.com/repos/openlayers/openlayers/issues/comments/405556465","html_url":"https://github.com/openlayers/openlayers/pull/8385#issuecomment-405556465","issue_url":"https://api.github.com/repos/openlayers/openlayers/issues/8385","id":405556465,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTU1NjQ2NQ==","user":{"login":"ahocevar","id":211514,"node_id":"MDQ6VXNlcjIxMTUxNA==","avatar_url":"https://avatars1.githubusercontent.com/u/211514?v=4","gravatar_id":"","url":"https://api.github.com/users/ahocevar","html_url":"https://github.com/ahocevar","followers_url":"https://api.github.com/users/ahocevar/followers","following_url":"https://api.github.com/users/ahocevar/following{/other_user}","gists_url":"https://api.github.com/users/ahocevar/gists{/gist_id}","starred_url":"https://api.github.com/users/ahocevar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahocevar/subscriptions","organizations_url":"https://api.github.com/users/ahocevar/orgs","repos_url":"https://api.github.com/users/ahocevar/repos","events_url":"https://api.github.com/users/ahocevar/events{/privacy}","received_events_url":"https://api.github.com/users/ahocevar/received_events","type":"User","site_admin":false},"created_at":"2018-07-17T11:56:54Z","updated_at":"2018-07-17T11:56:54Z","author_association":"MEMBER","body":"Done with A-M, now making the aforementioned changes for N-Z."}}
{"actor":{"display_login":"ahocevar"}}