{"action":"created","comment":{"url":"https://api.github.com/repos/python-trio/trio/pulls/comments/224623323","pull_request_review_id":164037994,"id":224623323,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDYyMzMyMw==","diff_hunk":"@@ -9,6 +9,62 @@\n from . import _socket\n import sys as _sys\n \n+# expose all uppercase names from standardlib socket to trio.socket\n+import socket as _stdlib_socket","path":"trio/socket.py","position":5,"original_position":5,"commit_id":"8bedd9511053e51cab0f08ef99b73517b69d4278","original_commit_id":"8bedd9511053e51cab0f08ef99b73517b69d4278","user":{"login":"njsmith","id":609896,"node_id":"MDQ6VXNlcjYwOTg5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/609896?v=4","gravatar_id":"","url":"https://api.github.com/users/njsmith","html_url":"https://github.com/njsmith","followers_url":"https://api.github.com/users/njsmith/followers","following_url":"https://api.github.com/users/njsmith/following{/other_user}","gists_url":"https://api.github.com/users/njsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/njsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njsmith/subscriptions","organizations_url":"https://api.github.com/users/njsmith/orgs","repos_url":"https://api.github.com/users/njsmith/repos","events_url":"https://api.github.com/users/njsmith/events{/privacy}","received_events_url":"https://api.github.com/users/njsmith/received_events","type":"User","site_admin":false},"body":"Let's move this back down next to the loop where we use it.","created_at":"2018-10-11T22:25:11Z","updated_at":"2018-10-11T22:27:57Z","html_url":"https://github.com/python-trio/trio/pull/730#discussion_r224623323","pull_request_url":"https://api.github.com/repos/python-trio/trio/pulls/730","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/python-trio/trio/pulls/comments/224623323"},"html":{"href":"https://github.com/python-trio/trio/pull/730#discussion_r224623323"},"pull_request":{"href":"https://api.github.com/repos/python-trio/trio/pulls/730"}}},"pull_request":{"url":"https://api.github.com/repos/python-trio/trio/pulls/730","id":222209701,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMjA5NzAx","html_url":"https://github.com/python-trio/trio/pull/730","diff_url":"https://github.com/python-trio/trio/pull/730.diff","patch_url":"https://github.com/python-trio/trio/pull/730.patch","issue_url":"https://api.github.com/repos/python-trio/trio/issues/730","number":730,"state":"open","locked":false,"title":"Added typechecking block for static analysis tools","user":{"login":"jmfrank63","id":3090462,"node_id":"MDQ6VXNlcjMwOTA0NjI=","avatar_url":"https://avatars3.githubusercontent.com/u/3090462?v=4","gravatar_id":"","url":"https://api.github.com/users/jmfrank63","html_url":"https://github.com/jmfrank63","followers_url":"https://api.github.com/users/jmfrank63/followers","following_url":"https://api.github.com/users/jmfrank63/following{/other_user}","gists_url":"https://api.github.com/users/jmfrank63/gists{/gist_id}","starred_url":"https://api.github.com/users/jmfrank63/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmfrank63/subscriptions","organizations_url":"https://api.github.com/users/jmfrank63/orgs","repos_url":"https://api.github.com/users/jmfrank63/repos","events_url":"https://api.github.com/users/jmfrank63/events{/privacy}","received_events_url":"https://api.github.com/users/jmfrank63/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-11T16:55:29Z","updated_at":"2018-10-11T22:27:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"714a6863aa142bbe497304b95d432c4eca504ba7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/python-trio/trio/pulls/730/commits","review_comments_url":"https://api.github.com/repos/python-trio/trio/pulls/730/comments","review_comment_url":"https://api.github.com/repos/python-trio/trio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/python-trio/trio/issues/730/comments","statuses_url":"https://api.github.com/repos/python-trio/trio/statuses/8bedd9511053e51cab0f08ef99b73517b69d4278","head":{"label":"jmfrank63:sockets_reloaded","ref":"sockets_reloaded","sha":"8bedd9511053e51cab0f08ef99b73517b69d4278","user":{"login":"jmfrank63","id":3090462,"node_id":"MDQ6VXNlcjMwOTA0NjI=","avatar_url":"https://avatars3.githubusercontent.com/u/3090462?v=4","gravatar_id":"","url":"https://api.github.com/users/jmfrank63","html_url":"https://github.com/jmfrank63","followers_url":"https://api.github.com/users/jmfrank63/followers","following_url":"https://api.github.com/users/jmfrank63/following{/other_user}","gists_url":"https://api.github.com/users/jmfrank63/gists{/gist_id}","starred_url":"https://api.github.com/users/jmfrank63/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmfrank63/subscriptions","organizations_url":"https://api.github.com/users/jmfrank63/orgs","repos_url":"https://api.github.com/users/jmfrank63/repos","events_url":"https://api.github.com/users/jmfrank63/events{/privacy}","received_events_url":"https://api.github.com/users/jmfrank63/received_events","type":"User","site_admin":false},"repo":{"id":143880774,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM4ODA3NzQ=","name":"trio","full_name":"jmfrank63/trio","private":false,"owner":{"login":"jmfrank63","id":3090462,"node_id":"MDQ6VXNlcjMwOTA0NjI=","avatar_url":"https://avatars3.githubusercontent.com/u/3090462?v=4","gravatar_id":"","url":"https://api.github.com/users/jmfrank63","html_url":"https://github.com/jmfrank63","followers_url":"https://api.github.com/users/jmfrank63/followers","following_url":"https://api.github.com/users/jmfrank63/following{/other_user}","gists_url":"https://api.github.com/users/jmfrank63/gists{/gist_id}","starred_url":"https://api.github.com/users/jmfrank63/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmfrank63/subscriptions","organizations_url":"https://api.github.com/users/jmfrank63/orgs","repos_url":"https://api.github.com/users/jmfrank63/repos","events_url":"https://api.github.com/users/jmfrank63/events{/privacy}","received_events_url":"https://api.github.com/users/jmfrank63/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jmfrank63/trio","description":"Trio – Pythonic async I/O for humans and snake people 🐍","fork":true,"url":"https://api.github.com/repos/jmfrank63/trio","forks_url":"https://api.github.com/repos/jmfrank63/trio/forks","keys_url":"https://api.github.com/repos/jmfrank63/trio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmfrank63/trio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmfrank63/trio/teams","hooks_url":"https://api.github.com/repos/jmfrank63/trio/hooks","issue_events_url":"https://api.github.com/repos/jmfrank63/trio/issues/events{/number}","events_url":"https://api.github.com/repos/jmfrank63/trio/events","assignees_url":"https://api.github.com/repos/jmfrank63/trio/assignees{/user}","branches_url":"https://api.github.com/repos/jmfrank63/trio/branches{/branch}","tags_url":"https://api.github.com/repos/jmfrank63/trio/tags","blobs_url":"https://api.github.com/repos/jmfrank63/trio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmfrank63/trio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmfrank63/trio/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmfrank63/trio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmfrank63/trio/statuses/{sha}","languages_url":"https://api.github.com/repos/jmfrank63/trio/languages","stargazers_url":"https://api.github.com/repos/jmfrank63/trio/stargazers","contributors_url":"https://api.github.com/repos/jmfrank63/trio/contributors","subscribers_url":"https://api.github.com/repos/jmfrank63/trio/subscribers","subscription_url":"https://api.github.com/repos/jmfrank63/trio/subscription","commits_url":"https://api.github.com/repos/jmfrank63/trio/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmfrank63/trio/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmfrank63/trio/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmfrank63/trio/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmfrank63/trio/contents/{+path}","compare_url":"https://api.github.com/repos/jmfrank63/trio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmfrank63/trio/merges","archive_url":"https://api.github.com/repos/jmfrank63/trio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmfrank63/trio/downloads","issues_url":"https://api.github.com/repos/jmfrank63/trio/issues{/number}","pulls_url":"https://api.github.com/repos/jmfrank63/trio/pulls{/number}","milestones_url":"https://api.github.com/repos/jmfrank63/trio/milestones{/number}","notifications_url":"https://api.github.com/repos/jmfrank63/trio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmfrank63/trio/labels{/name}","releases_url":"https://api.github.com/repos/jmfrank63/trio/releases{/id}","deployments_url":"https://api.github.com/repos/jmfrank63/trio/deployments","created_at":"2018-08-07T13:56:14Z","updated_at":"2018-10-11T06:19:45Z","pushed_at":"2018-10-11T20:38:10Z","git_url":"git://github.com/jmfrank63/trio.git","ssh_url":"git@github.com:jmfrank63/trio.git","clone_url":"https://github.com/jmfrank63/trio.git","svn_url":"https://github.com/jmfrank63/trio","homepage":"https://trio.readthedocs.io","size":2651,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"python-trio:master","ref":"master","sha":"468de276616a8fb8ec2fb4d76f750c72d2183b0a","user":{"login":"python-trio","id":26335827,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MzM1ODI3","avatar_url":"https://avatars2.githubusercontent.com/u/26335827?v=4","gravatar_id":"","url":"https://api.github.com/users/python-trio","html_url":"https://github.com/python-trio","followers_url":"https://api.github.com/users/python-trio/followers","following_url":"https://api.github.com/users/python-trio/following{/other_user}","gists_url":"https://api.github.com/users/python-trio/gists{/gist_id}","starred_url":"https://api.github.com/users/python-trio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-trio/subscriptions","organizations_url":"https://api.github.com/users/python-trio/orgs","repos_url":"https://api.github.com/users/python-trio/repos","events_url":"https://api.github.com/users/python-trio/events{/privacy}","received_events_url":"https://api.github.com/users/python-trio/received_events","type":"Organization","site_admin":false},"repo":{"id":79083614,"node_id":"MDEwOlJlcG9zaXRvcnk3OTA4MzYxNA==","name":"trio","full_name":"python-trio/trio","private":false,"owner":{"login":"python-trio","id":26335827,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MzM1ODI3","avatar_url":"https://avatars2.githubusercontent.com/u/26335827?v=4","gravatar_id":"","url":"https://api.github.com/users/python-trio","html_url":"https://github.com/python-trio","followers_url":"https://api.github.com/users/python-trio/followers","following_url":"https://api.github.com/users/python-trio/following{/other_user}","gists_url":"https://api.github.com/users/python-trio/gists{/gist_id}","starred_url":"https://api.github.com/users/python-trio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-trio/subscriptions","organizations_url":"https://api.github.com/users/python-trio/orgs","repos_url":"https://api.github.com/users/python-trio/repos","events_url":"https://api.github.com/users/python-trio/events{/privacy}","received_events_url":"https://api.github.com/users/python-trio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/python-trio/trio","description":"Trio – Pythonic async I/O for humans and snake people 🐍","fork":false,"url":"https://api.github.com/repos/python-trio/trio","forks_url":"https://api.github.com/repos/python-trio/trio/forks","keys_url":"https://api.github.com/repos/python-trio/trio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python-trio/trio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python-trio/trio/teams","hooks_url":"https://api.github.com/repos/python-trio/trio/hooks","issue_events_url":"https://api.github.com/repos/python-trio/trio/issues/events{/number}","events_url":"https://api.github.com/repos/python-trio/trio/events","assignees_url":"https://api.github.com/repos/python-trio/trio/assignees{/user}","branches_url":"https://api.github.com/repos/python-trio/trio/branches{/branch}","tags_url":"https://api.github.com/repos/python-trio/trio/tags","blobs_url":"https://api.github.com/repos/python-trio/trio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python-trio/trio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python-trio/trio/git/refs{/sha}","trees_url":"https://api.github.com/repos/python-trio/trio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python-trio/trio/statuses/{sha}","languages_url":"https://api.github.com/repos/python-trio/trio/languages","stargazers_url":"https://api.github.com/repos/python-trio/trio/stargazers","contributors_url":"https://api.github.com/repos/python-trio/trio/contributors","subscribers_url":"https://api.github.com/repos/python-trio/trio/subscribers","subscription_url":"https://api.github.com/repos/python-trio/trio/subscription","commits_url":"https://api.github.com/repos/python-trio/trio/commits{/sha}","git_commits_url":"https://api.github.com/repos/python-trio/trio/git/commits{/sha}","comments_url":"https://api.github.com/repos/python-trio/trio/comments{/number}","issue_comment_url":"https://api.github.com/repos/python-trio/trio/issues/comments{/number}","contents_url":"https://api.github.com/repos/python-trio/trio/contents/{+path}","compare_url":"https://api.github.com/repos/python-trio/trio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python-trio/trio/merges","archive_url":"https://api.github.com/repos/python-trio/trio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python-trio/trio/downloads","issues_url":"https://api.github.com/repos/python-trio/trio/issues{/number}","pulls_url":"https://api.github.com/repos/python-trio/trio/pulls{/number}","milestones_url":"https://api.github.com/repos/python-trio/trio/milestones{/number}","notifications_url":"https://api.github.com/repos/python-trio/trio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python-trio/trio/labels{/name}","releases_url":"https://api.github.com/repos/python-trio/trio/releases{/id}","deployments_url":"https://api.github.com/repos/python-trio/trio/deployments","created_at":"2017-01-16T04:45:25Z","updated_at":"2018-10-11T17:52:30Z","pushed_at":"2018-10-11T20:38:11Z","git_url":"git://github.com/python-trio/trio.git","ssh_url":"git@github.com:python-trio/trio.git","clone_url":"https://github.com/python-trio/trio.git","svn_url":"https://github.com/python-trio/trio","homepage":"https://trio.readthedocs.io","size":2660,"stargazers_count":1557,"watchers_count":1557,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":95,"mirror_url":null,"archived":false,"open_issues_count":182,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":95,"open_issues":182,"watchers":1557,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python-trio/trio/pulls/730"},"html":{"href":"https://github.com/python-trio/trio/pull/730"},"issue":{"href":"https://api.github.com/repos/python-trio/trio/issues/730"},"comments":{"href":"https://api.github.com/repos/python-trio/trio/issues/730/comments"},"review_comments":{"href":"https://api.github.com/repos/python-trio/trio/pulls/730/comments"},"review_comment":{"href":"https://api.github.com/repos/python-trio/trio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/python-trio/trio/pulls/730/commits"},"statuses":{"href":"https://api.github.com/repos/python-trio/trio/statuses/8bedd9511053e51cab0f08ef99b73517b69d4278"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"njsmith"}}