{"action":"created","issue":{"url":"https://api.github.com/repos/rear/rear/issues/1844","repository_url":"https://api.github.com/repos/rear/rear","labels_url":"https://api.github.com/repos/rear/rear/issues/1844/labels{/name}","comments_url":"https://api.github.com/repos/rear/rear/issues/1844/comments","events_url":"https://api.github.com/repos/rear/rear/issues/1844/events","html_url":"https://github.com/rear/rear/issues/1844","id":336544693,"node_id":"MDU6SXNzdWUzMzY1NDQ2OTM=","number":1844,"title":"Strange `# vim: set et ts=4 sw=4:` comments at the end of some scrips","user":{"login":"jsmeix","id":1788608,"node_id":"MDQ6VXNlcjE3ODg2MDg=","avatar_url":"https://avatars0.githubusercontent.com/u/1788608?v=4","gravatar_id":"","url":"https://api.github.com/users/jsmeix","html_url":"https://github.com/jsmeix","followers_url":"https://api.github.com/users/jsmeix/followers","following_url":"https://api.github.com/users/jsmeix/following{/other_user}","gists_url":"https://api.github.com/users/jsmeix/gists{/gist_id}","starred_url":"https://api.github.com/users/jsmeix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsmeix/subscriptions","organizations_url":"https://api.github.com/users/jsmeix/orgs","repos_url":"https://api.github.com/users/jsmeix/repos","events_url":"https://api.github.com/users/jsmeix/events{/privacy}","received_events_url":"https://api.github.com/users/jsmeix/received_events","type":"User","site_admin":false},"labels":[{"id":2222609,"node_id":"MDU6TGFiZWwyMjIyNjA5","url":"https://api.github.com/repos/rear/rear/labels/discuss/RFC","name":"discuss/RFC","color":"ffdd00","default":false},{"id":1809711,"node_id":"MDU6TGFiZWwxODA5NzEx","url":"https://api.github.com/repos/rear/rear/labels/waiting%20for%20info","name":"waiting for info","color":"ffff40","default":false}],"state":"open","locked":false,"assignee":{"login":"gdha","id":888633,"node_id":"MDQ6VXNlcjg4ODYzMw==","avatar_url":"https://avatars2.githubusercontent.com/u/888633?v=4","gravatar_id":"","url":"https://api.github.com/users/gdha","html_url":"https://github.com/gdha","followers_url":"https://api.github.com/users/gdha/followers","following_url":"https://api.github.com/users/gdha/following{/other_user}","gists_url":"https://api.github.com/users/gdha/gists{/gist_id}","starred_url":"https://api.github.com/users/gdha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdha/subscriptions","organizations_url":"https://api.github.com/users/gdha/orgs","repos_url":"https://api.github.com/users/gdha/repos","events_url":"https://api.github.com/users/gdha/events{/privacy}","received_events_url":"https://api.github.com/users/gdha/received_events","type":"User","site_admin":false},"assignees":[{"login":"gdha","id":888633,"node_id":"MDQ6VXNlcjg4ODYzMw==","avatar_url":"https://avatars2.githubusercontent.com/u/888633?v=4","gravatar_id":"","url":"https://api.github.com/users/gdha","html_url":"https://github.com/gdha","followers_url":"https://api.github.com/users/gdha/followers","following_url":"https://api.github.com/users/gdha/following{/other_user}","gists_url":"https://api.github.com/users/gdha/gists{/gist_id}","starred_url":"https://api.github.com/users/gdha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdha/subscriptions","organizations_url":"https://api.github.com/users/gdha/orgs","repos_url":"https://api.github.com/users/gdha/repos","events_url":"https://api.github.com/users/gdha/events{/privacy}","received_events_url":"https://api.github.com/users/gdha/received_events","type":"User","site_admin":false},{"login":"jsmeix","id":1788608,"node_id":"MDQ6VXNlcjE3ODg2MDg=","avatar_url":"https://avatars0.githubusercontent.com/u/1788608?v=4","gravatar_id":"","url":"https://api.github.com/users/jsmeix","html_url":"https://github.com/jsmeix","followers_url":"https://api.github.com/users/jsmeix/followers","following_url":"https://api.github.com/users/jsmeix/following{/other_user}","gists_url":"https://api.github.com/users/jsmeix/gists{/gist_id}","starred_url":"https://api.github.com/users/jsmeix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsmeix/subscriptions","organizations_url":"https://api.github.com/users/jsmeix/orgs","repos_url":"https://api.github.com/users/jsmeix/repos","events_url":"https://api.github.com/users/jsmeix/events{/privacy}","received_events_url":"https://api.github.com/users/jsmeix/received_events","type":"User","site_admin":false},{"login":"gozora","id":12116358,"node_id":"MDQ6VXNlcjEyMTE2MzU4","avatar_url":"https://avatars3.githubusercontent.com/u/12116358?v=4","gravatar_id":"","url":"https://api.github.com/users/gozora","html_url":"https://github.com/gozora","followers_url":"https://api.github.com/users/gozora/followers","following_url":"https://api.github.com/users/gozora/following{/other_user}","gists_url":"https://api.github.com/users/gozora/gists{/gist_id}","starred_url":"https://api.github.com/users/gozora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gozora/subscriptions","organizations_url":"https://api.github.com/users/gozora/orgs","repos_url":"https://api.github.com/users/gozora/repos","events_url":"https://api.github.com/users/gozora/events{/privacy}","received_events_url":"https://api.github.com/users/gozora/received_events","type":"User","site_admin":false},{"login":"schabrolles","id":19491077,"node_id":"MDQ6VXNlcjE5NDkxMDc3","avatar_url":"https://avatars1.githubusercontent.com/u/19491077?v=4","gravatar_id":"","url":"https://api.github.com/users/schabrolles","html_url":"https://github.com/schabrolles","followers_url":"https://api.github.com/users/schabrolles/followers","following_url":"https://api.github.com/users/schabrolles/following{/other_user}","gists_url":"https://api.github.com/users/schabrolles/gists{/gist_id}","starred_url":"https://api.github.com/users/schabrolles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schabrolles/subscriptions","organizations_url":"https://api.github.com/users/schabrolles/orgs","repos_url":"https://api.github.com/users/schabrolles/repos","events_url":"https://api.github.com/users/schabrolles/events{/privacy}","received_events_url":"https://api.github.com/users/schabrolles/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/rear/rear/milestones/16","html_url":"https://github.com/rear/rear/milestone/16","labels_url":"https://api.github.com/repos/rear/rear/milestones/16/labels","id":3315699,"node_id":"MDk6TWlsZXN0b25lMzMxNTY5OQ==","number":16,"title":"ReaR v2.5","description":"For ReaR release 2.5 we do not have a release date in mind (maybe end of 2018 or beginning 2019). It depends on bug fixes or bleeding edge new features...\r\nOr, it can get faster when a company (or person) sponsor us to do the release sooner.","creator":{"login":"gdha","id":888633,"node_id":"MDQ6VXNlcjg4ODYzMw==","avatar_url":"https://avatars2.githubusercontent.com/u/888633?v=4","gravatar_id":"","url":"https://api.github.com/users/gdha","html_url":"https://github.com/gdha","followers_url":"https://api.github.com/users/gdha/followers","following_url":"https://api.github.com/users/gdha/following{/other_user}","gists_url":"https://api.github.com/users/gdha/gists{/gist_id}","starred_url":"https://api.github.com/users/gdha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdha/subscriptions","organizations_url":"https://api.github.com/users/gdha/orgs","repos_url":"https://api.github.com/users/gdha/repos","events_url":"https://api.github.com/users/gdha/events{/privacy}","received_events_url":"https://api.github.com/users/gdha/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":0,"state":"open","created_at":"2018-05-02T18:19:50Z","updated_at":"2018-06-28T10:28:43Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2018-06-28T09:32:20Z","updated_at":"2018-06-28T15:02:24Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"In current ReaR master code some scripts have a last line\r\n<pre>\r\n# vim: set et ts=4 sw=4:\r\n</pre>\r\nwhich got added by @rmetrich via\r\nhttps://github.com/rear/rear/commit/b184194f37dd22a7e55655ff388579297239e73c\r\nand\r\nhttps://github.com/rear/rear/commit/84f03a4a2828ad21a1ab770b5737db9dac41074c\r\n\r\nI.e. in current ReaR master code there is\r\n<pre>\r\n $ find usr/sbin/rear usr/share/rear/ | xargs grep 'vim:' 2>/dev/null\r\n\r\nusr/share/rear/lib/layout-functions.sh:# vim: set et ts=4 sw=4:\r\nusr/share/rear/prep/GNU/Linux/220_include_lvm_tools.sh:# vim: set et ts=4 sw=4:\r\nusr/share/rear/layout/prepare/GNU/Linux/110_include_lvm_code.sh:# vim: set et ts=4 sw=4:\r\nusr/share/rear/layout/save/GNU/Linux/220_lvm_layout.sh:# vim: set et ts=4 sw=4:\r\n</pre>\r\n\r\nI guess this is some special automatism by the `vi` editor.\r\n\r\n@rmetrich \r\ncould you explan the reason behind\r\nand whether or not I should remove them\r\nor if it makes sense to have those trailing comment lines.\r\n"},"comment":{"url":"https://api.github.com/repos/rear/rear/issues/comments/401066013","html_url":"https://github.com/rear/rear/issues/1844#issuecomment-401066013","issue_url":"https://api.github.com/repos/rear/rear/issues/1844","id":401066013,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTA2NjAxMw==","user":{"login":"gozora","id":12116358,"node_id":"MDQ6VXNlcjEyMTE2MzU4","avatar_url":"https://avatars3.githubusercontent.com/u/12116358?v=4","gravatar_id":"","url":"https://api.github.com/users/gozora","html_url":"https://github.com/gozora","followers_url":"https://api.github.com/users/gozora/followers","following_url":"https://api.github.com/users/gozora/following{/other_user}","gists_url":"https://api.github.com/users/gozora/gists{/gist_id}","starred_url":"https://api.github.com/users/gozora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gozora/subscriptions","organizations_url":"https://api.github.com/users/gozora/orgs","repos_url":"https://api.github.com/users/gozora/repos","events_url":"https://api.github.com/users/gozora/events{/privacy}","received_events_url":"https://api.github.com/users/gozora/received_events","type":"User","site_admin":false},"created_at":"2018-06-28T15:02:24Z","updated_at":"2018-06-28T15:02:24Z","author_association":"MEMBER","body":"Honestly I didn't know about this feature, but I'd personally prefer to keep editor settings out of source code mainly because other users might appear with different editors storing another set of \"meta-data\" which could lead to mess...\r\n\r\nV."}}
{"actor":{"display_login":"gozora"}}