{"action":"created","comment":{"url":"https://api.github.com/repos/3scale/apicast/pulls/comments/167234213","pull_request_review_id":95392848,"id":167234213,"diff_hunk":"@@ -0,0 +1,87 @@\n+apiVersion: v1\n+kind: Template\n+labels:\n+  template: apicast-build\n+metadata:\n+  annotations:\n+    description: |-\n+      A BuildConfig for OpenShift that builds images of Apicast from source.","path":"openshift/apicast-build-template.yaml","position":null,"original_position":8,"commit_id":"e39f6bd5b62b4a1a4c96ca3c0fc5af7a35dd3450","original_commit_id":"09dae5fa4d1bf543597a8c6424508e36ccc59d52","user":{"login":"maneta","id":1528321,"avatar_url":"https://avatars2.githubusercontent.com/u/1528321?v=4","gravatar_id":"","url":"https://api.github.com/users/maneta","html_url":"https://github.com/maneta","followers_url":"https://api.github.com/users/maneta/followers","following_url":"https://api.github.com/users/maneta/following{/other_user}","gists_url":"https://api.github.com/users/maneta/gists{/gist_id}","starred_url":"https://api.github.com/users/maneta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maneta/subscriptions","organizations_url":"https://api.github.com/users/maneta/orgs","repos_url":"https://api.github.com/users/maneta/repos","events_url":"https://api.github.com/users/maneta/events{/privacy}","received_events_url":"https://api.github.com/users/maneta/received_events","type":"User","site_admin":false},"body":"yes, the guidelines I have from product are:\r\n\r\n```yaml\r\nopenshift.io/display-name: 3scale APIcast API Gateway\r\nopenshift.io/provider-display-name: Red Hat, Inc.\r\niconClass: icon-3scale\r\ndescription: >-\r\n  3scale's APIcast is an NGINX based API gateway used to integrate your internal and external\r\n  API services with 3scale's API Management Platform. It supports OpenID connect to integrate\r\n  with external Identity Providers such as Red Hat Single Sign On, for API traffic authentication.\r\n```","created_at":"2018-02-09T14:02:44Z","updated_at":"2018-02-09T14:04:07Z","html_url":"https://github.com/3scale/apicast/pull/583#discussion_r167234213","pull_request_url":"https://api.github.com/repos/3scale/apicast/pulls/583","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/3scale/apicast/pulls/comments/167234213"},"html":{"href":"https://github.com/3scale/apicast/pull/583#discussion_r167234213"},"pull_request":{"href":"https://api.github.com/repos/3scale/apicast/pulls/583"}},"in_reply_to_id":167060423},"pull_request":{"url":"https://api.github.com/repos/3scale/apicast/pulls/583","id":168005556,"html_url":"https://github.com/3scale/apicast/pull/583","diff_url":"https://github.com/3scale/apicast/pull/583.diff","patch_url":"https://github.com/3scale/apicast/pull/583.patch","issue_url":"https://api.github.com/repos/3scale/apicast/issues/583","number":583,"state":"open","locked":false,"title":"An openshift template that builds apicast from source","user":{"login":"nmasse-itix","id":7472564,"avatar_url":"https://avatars0.githubusercontent.com/u/7472564?v=4","gravatar_id":"","url":"https://api.github.com/users/nmasse-itix","html_url":"https://github.com/nmasse-itix","followers_url":"https://api.github.com/users/nmasse-itix/followers","following_url":"https://api.github.com/users/nmasse-itix/following{/other_user}","gists_url":"https://api.github.com/users/nmasse-itix/gists{/gist_id}","starred_url":"https://api.github.com/users/nmasse-itix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmasse-itix/subscriptions","organizations_url":"https://api.github.com/users/nmasse-itix/orgs","repos_url":"https://api.github.com/users/nmasse-itix/repos","events_url":"https://api.github.com/users/nmasse-itix/events{/privacy}","received_events_url":"https://api.github.com/users/nmasse-itix/received_events","type":"User","site_admin":false},"body":"When working on Apicast, such as developing policies or customizations, it might be good to have Continuous Integration and sometimes Continuous Delivery. \r\n\r\nThis pull requests is a template for OpenShift that enables CI/CD. Once the template instanciated, a two-stage buildconfig is created (first a custom builder, then the apicast build using this custom builder). \r\n\r\nIf you want to give it a try, on an OCP cluster you can use : \r\n```\r\noc process -f build-template.yaml -p GIT_REPO=https://github.com/nmasse-itix/3scale-apicast.git -p GIT_REFERENCE=openshift-builder-latest -p OPENSHIFT_BASE_IMAGE=registry.access.redhat.com/openshift3/ose:v3.7 |oc create -f -\r\n```\r\n\r\nOr on a minishift/OpenShift origin, you can use :\r\n```\r\noc process -f build-template.yaml -p GIT_REPO=https://github.com/nmasse-itix/3scale-apicast.git -p GIT_REFERENCE=openshift-builder-latest |oc create -f -\r\n```\r\n\r\nThe build can then be triggered from Jenkins, as usual. \r\n","created_at":"2018-02-08T15:35:16Z","updated_at":"2018-02-09T14:04:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad667121e758283504b65baf3c583d879e04a7f9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/3scale/apicast/pulls/583/commits","review_comments_url":"https://api.github.com/repos/3scale/apicast/pulls/583/comments","review_comment_url":"https://api.github.com/repos/3scale/apicast/pulls/comments{/number}","comments_url":"https://api.github.com/repos/3scale/apicast/issues/583/comments","statuses_url":"https://api.github.com/repos/3scale/apicast/statuses/e39f6bd5b62b4a1a4c96ca3c0fc5af7a35dd3450","head":{"label":"nmasse-itix:openshift-builder-latest","ref":"openshift-builder-latest","sha":"e39f6bd5b62b4a1a4c96ca3c0fc5af7a35dd3450","user":{"login":"nmasse-itix","id":7472564,"avatar_url":"https://avatars0.githubusercontent.com/u/7472564?v=4","gravatar_id":"","url":"https://api.github.com/users/nmasse-itix","html_url":"https://github.com/nmasse-itix","followers_url":"https://api.github.com/users/nmasse-itix/followers","following_url":"https://api.github.com/users/nmasse-itix/following{/other_user}","gists_url":"https://api.github.com/users/nmasse-itix/gists{/gist_id}","starred_url":"https://api.github.com/users/nmasse-itix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmasse-itix/subscriptions","organizations_url":"https://api.github.com/users/nmasse-itix/orgs","repos_url":"https://api.github.com/users/nmasse-itix/repos","events_url":"https://api.github.com/users/nmasse-itix/events{/privacy}","received_events_url":"https://api.github.com/users/nmasse-itix/received_events","type":"User","site_admin":false},"repo":{"id":103826944,"name":"3scale-apicast","full_name":"nmasse-itix/3scale-apicast","owner":{"login":"nmasse-itix","id":7472564,"avatar_url":"https://avatars0.githubusercontent.com/u/7472564?v=4","gravatar_id":"","url":"https://api.github.com/users/nmasse-itix","html_url":"https://github.com/nmasse-itix","followers_url":"https://api.github.com/users/nmasse-itix/followers","following_url":"https://api.github.com/users/nmasse-itix/following{/other_user}","gists_url":"https://api.github.com/users/nmasse-itix/gists{/gist_id}","starred_url":"https://api.github.com/users/nmasse-itix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmasse-itix/subscriptions","organizations_url":"https://api.github.com/users/nmasse-itix/orgs","repos_url":"https://api.github.com/users/nmasse-itix/repos","events_url":"https://api.github.com/users/nmasse-itix/events{/privacy}","received_events_url":"https://api.github.com/users/nmasse-itix/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nmasse-itix/3scale-apicast","description":"3scale api gateway reloaded","fork":true,"url":"https://api.github.com/repos/nmasse-itix/3scale-apicast","forks_url":"https://api.github.com/repos/nmasse-itix/3scale-apicast/forks","keys_url":"https://api.github.com/repos/nmasse-itix/3scale-apicast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nmasse-itix/3scale-apicast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nmasse-itix/3scale-apicast/teams","hooks_url":"https://api.github.com/repos/nmasse-itix/3scale-apicast/hooks","issue_events_url":"https://api.github.com/repos/nmasse-itix/3scale-apicast/issues/events{/number}","events_url":"https://api.github.com/repos/nmasse-itix/3scale-apicast/events","assignees_url":"https://api.github.com/repos/nmasse-itix/3scale-apicast/assignees{/user}","branches_url":"https://api.github.com/repos/nmasse-itix/3scale-apicast/branches{/branch}","tags_url":"https://api.github.com/repos/nmasse-itix/3scale-apicast/tags","blobs_url":"https://api.github.com/repos/nmasse-itix/3scale-apicast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nmasse-itix/3scale-apicast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nmasse-itix/3scale-apicast/git/refs{/sha}","trees_url":"https://api.github.com/repos/nmasse-itix/3scale-apicast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nmasse-itix/3scale-apicast/statuses/{sha}","languages_url":"https://api.github.com/repos/nmasse-itix/3scale-apicast/languages","stargazers_url":"https://api.github.com/repos/nmasse-itix/3scale-apicast/stargazers","contributors_url":"https://api.github.com/repos/nmasse-itix/3scale-apicast/contributors","subscribers_url":"https://api.github.com/repos/nmasse-itix/3scale-apicast/subscribers","subscription_url":"https://api.github.com/repos/nmasse-itix/3scale-apicast/subscription","commits_url":"https://api.github.com/repos/nmasse-itix/3scale-apicast/commits{/sha}","git_commits_url":"https://api.github.com/repos/nmasse-itix/3scale-apicast/git/commits{/sha}","comments_url":"https://api.github.com/repos/nmasse-itix/3scale-apicast/comments{/number}","issue_comment_url":"https://api.github.com/repos/nmasse-itix/3scale-apicast/issues/comments{/number}","contents_url":"https://api.github.com/repos/nmasse-itix/3scale-apicast/contents/{+path}","compare_url":"https://api.github.com/repos/nmasse-itix/3scale-apicast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nmasse-itix/3scale-apicast/merges","archive_url":"https://api.github.com/repos/nmasse-itix/3scale-apicast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nmasse-itix/3scale-apicast/downloads","issues_url":"https://api.github.com/repos/nmasse-itix/3scale-apicast/issues{/number}","pulls_url":"https://api.github.com/repos/nmasse-itix/3scale-apicast/pulls{/number}","milestones_url":"https://api.github.com/repos/nmasse-itix/3scale-apicast/milestones{/number}","notifications_url":"https://api.github.com/repos/nmasse-itix/3scale-apicast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nmasse-itix/3scale-apicast/labels{/name}","releases_url":"https://api.github.com/repos/nmasse-itix/3scale-apicast/releases{/id}","deployments_url":"https://api.github.com/repos/nmasse-itix/3scale-apicast/deployments","created_at":"2017-09-17T12:27:09Z","updated_at":"2017-09-17T12:28:22Z","pushed_at":"2018-02-09T06:32:31Z","git_url":"git://github.com/nmasse-itix/3scale-apicast.git","ssh_url":"git@github.com:nmasse-itix/3scale-apicast.git","clone_url":"https://github.com/nmasse-itix/3scale-apicast.git","svn_url":"https://github.com/nmasse-itix/3scale-apicast","homepage":"","size":2227,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"3scale:master","ref":"master","sha":"9b6e49504f05c93f3f5d0744c1afd4047090f6e4","user":{"login":"3scale","id":21415,"avatar_url":"https://avatars0.githubusercontent.com/u/21415?v=4","gravatar_id":"","url":"https://api.github.com/users/3scale","html_url":"https://github.com/3scale","followers_url":"https://api.github.com/users/3scale/followers","following_url":"https://api.github.com/users/3scale/following{/other_user}","gists_url":"https://api.github.com/users/3scale/gists{/gist_id}","starred_url":"https://api.github.com/users/3scale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3scale/subscriptions","organizations_url":"https://api.github.com/users/3scale/orgs","repos_url":"https://api.github.com/users/3scale/repos","events_url":"https://api.github.com/users/3scale/events{/privacy}","received_events_url":"https://api.github.com/users/3scale/received_events","type":"Organization","site_admin":false},"repo":{"id":53965666,"name":"apicast","full_name":"3scale/apicast","owner":{"login":"3scale","id":21415,"avatar_url":"https://avatars0.githubusercontent.com/u/21415?v=4","gravatar_id":"","url":"https://api.github.com/users/3scale","html_url":"https://github.com/3scale","followers_url":"https://api.github.com/users/3scale/followers","following_url":"https://api.github.com/users/3scale/following{/other_user}","gists_url":"https://api.github.com/users/3scale/gists{/gist_id}","starred_url":"https://api.github.com/users/3scale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3scale/subscriptions","organizations_url":"https://api.github.com/users/3scale/orgs","repos_url":"https://api.github.com/users/3scale/repos","events_url":"https://api.github.com/users/3scale/events{/privacy}","received_events_url":"https://api.github.com/users/3scale/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/3scale/apicast","description":"3scale api gateway reloaded","fork":false,"url":"https://api.github.com/repos/3scale/apicast","forks_url":"https://api.github.com/repos/3scale/apicast/forks","keys_url":"https://api.github.com/repos/3scale/apicast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/3scale/apicast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/3scale/apicast/teams","hooks_url":"https://api.github.com/repos/3scale/apicast/hooks","issue_events_url":"https://api.github.com/repos/3scale/apicast/issues/events{/number}","events_url":"https://api.github.com/repos/3scale/apicast/events","assignees_url":"https://api.github.com/repos/3scale/apicast/assignees{/user}","branches_url":"https://api.github.com/repos/3scale/apicast/branches{/branch}","tags_url":"https://api.github.com/repos/3scale/apicast/tags","blobs_url":"https://api.github.com/repos/3scale/apicast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/3scale/apicast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/3scale/apicast/git/refs{/sha}","trees_url":"https://api.github.com/repos/3scale/apicast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/3scale/apicast/statuses/{sha}","languages_url":"https://api.github.com/repos/3scale/apicast/languages","stargazers_url":"https://api.github.com/repos/3scale/apicast/stargazers","contributors_url":"https://api.github.com/repos/3scale/apicast/contributors","subscribers_url":"https://api.github.com/repos/3scale/apicast/subscribers","subscription_url":"https://api.github.com/repos/3scale/apicast/subscription","commits_url":"https://api.github.com/repos/3scale/apicast/commits{/sha}","git_commits_url":"https://api.github.com/repos/3scale/apicast/git/commits{/sha}","comments_url":"https://api.github.com/repos/3scale/apicast/comments{/number}","issue_comment_url":"https://api.github.com/repos/3scale/apicast/issues/comments{/number}","contents_url":"https://api.github.com/repos/3scale/apicast/contents/{+path}","compare_url":"https://api.github.com/repos/3scale/apicast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/3scale/apicast/merges","archive_url":"https://api.github.com/repos/3scale/apicast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/3scale/apicast/downloads","issues_url":"https://api.github.com/repos/3scale/apicast/issues{/number}","pulls_url":"https://api.github.com/repos/3scale/apicast/pulls{/number}","milestones_url":"https://api.github.com/repos/3scale/apicast/milestones{/number}","notifications_url":"https://api.github.com/repos/3scale/apicast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/3scale/apicast/labels{/name}","releases_url":"https://api.github.com/repos/3scale/apicast/releases{/id}","deployments_url":"https://api.github.com/repos/3scale/apicast/deployments","created_at":"2016-03-15T17:41:51Z","updated_at":"2018-02-09T07:00:57Z","pushed_at":"2018-02-09T13:44:58Z","git_url":"git://github.com/3scale/apicast.git","ssh_url":"git@github.com:3scale/apicast.git","clone_url":"https://github.com/3scale/apicast.git","svn_url":"https://github.com/3scale/apicast","homepage":"","size":2319,"stargazers_count":66,"watchers_count":66,"language":"Lua","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":48,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":48,"open_issues":38,"watchers":66,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/3scale/apicast/pulls/583"},"html":{"href":"https://github.com/3scale/apicast/pull/583"},"issue":{"href":"https://api.github.com/repos/3scale/apicast/issues/583"},"comments":{"href":"https://api.github.com/repos/3scale/apicast/issues/583/comments"},"review_comments":{"href":"https://api.github.com/repos/3scale/apicast/pulls/583/comments"},"review_comment":{"href":"https://api.github.com/repos/3scale/apicast/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/3scale/apicast/pulls/583/commits"},"statuses":{"href":"https://api.github.com/repos/3scale/apicast/statuses/e39f6bd5b62b4a1a4c96ca3c0fc5af7a35dd3450"}},"author_association":"NONE"}}
{"actor":{"display_login":"maneta"}}