{"action":"created","comment":{"url":"https://api.github.com/repos/awslabs/aws-c-common/pulls/comments/203878006","pull_request_review_id":138768108,"id":203878006,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzg3ODAwNg==","diff_hunk":"@@ -0,0 +1,97 @@\n+/*\n+* Copyright 2010-2018 Amazon.com, Inc. or its affiliates. All Rights Reserved.\n+*\n+* Licensed under the Apache License, Version 2.0 (the \"License\").\n+* You may not use this file except in compliance with the License.\n+* A copy of the License is located at\n+*\n+*  http://aws.amazon.com/apache2.0\n+*\n+* or in the \"license\" file accompanying this file. This file is distributed\n+* on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either\n+* express or implied. See the License for the specific language governing\n+* permissions and limitations under the License.\n+*/\n+\n+#include <aws/common/memory_pool.h>\n+\n+int aws_memory_pool_init(struct aws_memory_pool *pool, struct aws_allocator* alloc, size_t element_size, int element_count) {\n+    size_t stride = element_size + sizeof(void *);","path":"source/memory_pool.c","position":null,"original_position":19,"commit_id":"f3de38647fa4fc120c6a55415d3631a1b23e5b05","original_commit_id":"f5efe529be6d852c4dff4e820d101b35df4a01df","user":{"login":"graebm","id":24399397,"node_id":"MDQ6VXNlcjI0Mzk5Mzk3","avatar_url":"https://avatars3.githubusercontent.com/u/24399397?v=4","gravatar_id":"","url":"https://api.github.com/users/graebm","html_url":"https://github.com/graebm","followers_url":"https://api.github.com/users/graebm/followers","following_url":"https://api.github.com/users/graebm/following{/other_user}","gists_url":"https://api.github.com/users/graebm/gists{/gist_id}","starred_url":"https://api.github.com/users/graebm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graebm/subscriptions","organizations_url":"https://api.github.com/users/graebm/orgs","repos_url":"https://api.github.com/users/graebm/repos","events_url":"https://api.github.com/users/graebm/events{/privacy}","received_events_url":"https://api.github.com/users/graebm/received_events","type":"User","site_admin":false},"body":"[optional] couldn't stride just be `max(element_size, sizeof(void *))`?","created_at":"2018-07-19T21:26:47Z","updated_at":"2018-07-19T21:47:20Z","html_url":"https://github.com/awslabs/aws-c-common/pull/85#discussion_r203878006","pull_request_url":"https://api.github.com/repos/awslabs/aws-c-common/pulls/85","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/awslabs/aws-c-common/pulls/comments/203878006"},"html":{"href":"https://github.com/awslabs/aws-c-common/pull/85#discussion_r203878006"},"pull_request":{"href":"https://api.github.com/repos/awslabs/aws-c-common/pulls/85"}}},"pull_request":{"url":"https://api.github.com/repos/awslabs/aws-c-common/pulls/85","id":202098600,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMDk4NjAw","html_url":"https://github.com/awslabs/aws-c-common/pull/85","diff_url":"https://github.com/awslabs/aws-c-common/pull/85.diff","patch_url":"https://github.com/awslabs/aws-c-common/pull/85.patch","issue_url":"https://api.github.com/repos/awslabs/aws-c-common/issues/85","number":85,"state":"open","locked":false,"title":"Logger","user":{"login":"RandyGaul","id":1919825,"node_id":"MDQ6VXNlcjE5MTk4MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/1919825?v=4","gravatar_id":"","url":"https://api.github.com/users/RandyGaul","html_url":"https://github.com/RandyGaul","followers_url":"https://api.github.com/users/RandyGaul/followers","following_url":"https://api.github.com/users/RandyGaul/following{/other_user}","gists_url":"https://api.github.com/users/RandyGaul/gists{/gist_id}","starred_url":"https://api.github.com/users/RandyGaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RandyGaul/subscriptions","organizations_url":"https://api.github.com/users/RandyGaul/orgs","repos_url":"https://api.github.com/users/RandyGaul/repos","events_url":"https://api.github.com/users/RandyGaul/events{/privacy}","received_events_url":"https://api.github.com/users/RandyGaul/received_events","type":"User","site_admin":false},"body":"First bit of log CR. Wanted to put this up before I head home today. Still some work to do (will continue on these below points tomorrow morning):\r\n\r\n- Document the log.h\r\n- Unit test the atomic operations\r\n- Some more sophisticated tests for the logger (very basic for now)\r\n- Probably doesn't build on non-Windows (yet)\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.\r\n","created_at":"2018-07-17T23:09:24Z","updated_at":"2018-07-19T21:47:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be2cd8a184db7f72b817c446bb9034b626fe9daa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/awslabs/aws-c-common/pulls/85/commits","review_comments_url":"https://api.github.com/repos/awslabs/aws-c-common/pulls/85/comments","review_comment_url":"https://api.github.com/repos/awslabs/aws-c-common/pulls/comments{/number}","comments_url":"https://api.github.com/repos/awslabs/aws-c-common/issues/85/comments","statuses_url":"https://api.github.com/repos/awslabs/aws-c-common/statuses/f3de38647fa4fc120c6a55415d3631a1b23e5b05","head":{"label":"awslabs:logger","ref":"logger","sha":"f3de38647fa4fc120c6a55415d3631a1b23e5b05","user":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":117142517,"node_id":"MDEwOlJlcG9zaXRvcnkxMTcxNDI1MTc=","name":"aws-c-common","full_name":"awslabs/aws-c-common","owner":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/awslabs/aws-c-common","description":"Core c99 package for AWS SDK for C. Includes cross-platform primitives, configuration, data structures, and error handling.","fork":false,"url":"https://api.github.com/repos/awslabs/aws-c-common","forks_url":"https://api.github.com/repos/awslabs/aws-c-common/forks","keys_url":"https://api.github.com/repos/awslabs/aws-c-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awslabs/aws-c-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awslabs/aws-c-common/teams","hooks_url":"https://api.github.com/repos/awslabs/aws-c-common/hooks","issue_events_url":"https://api.github.com/repos/awslabs/aws-c-common/issues/events{/number}","events_url":"https://api.github.com/repos/awslabs/aws-c-common/events","assignees_url":"https://api.github.com/repos/awslabs/aws-c-common/assignees{/user}","branches_url":"https://api.github.com/repos/awslabs/aws-c-common/branches{/branch}","tags_url":"https://api.github.com/repos/awslabs/aws-c-common/tags","blobs_url":"https://api.github.com/repos/awslabs/aws-c-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awslabs/aws-c-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awslabs/aws-c-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/awslabs/aws-c-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awslabs/aws-c-common/statuses/{sha}","languages_url":"https://api.github.com/repos/awslabs/aws-c-common/languages","stargazers_url":"https://api.github.com/repos/awslabs/aws-c-common/stargazers","contributors_url":"https://api.github.com/repos/awslabs/aws-c-common/contributors","subscribers_url":"https://api.github.com/repos/awslabs/aws-c-common/subscribers","subscription_url":"https://api.github.com/repos/awslabs/aws-c-common/subscription","commits_url":"https://api.github.com/repos/awslabs/aws-c-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/awslabs/aws-c-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/awslabs/aws-c-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/awslabs/aws-c-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/awslabs/aws-c-common/contents/{+path}","compare_url":"https://api.github.com/repos/awslabs/aws-c-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awslabs/aws-c-common/merges","archive_url":"https://api.github.com/repos/awslabs/aws-c-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awslabs/aws-c-common/downloads","issues_url":"https://api.github.com/repos/awslabs/aws-c-common/issues{/number}","pulls_url":"https://api.github.com/repos/awslabs/aws-c-common/pulls{/number}","milestones_url":"https://api.github.com/repos/awslabs/aws-c-common/milestones{/number}","notifications_url":"https://api.github.com/repos/awslabs/aws-c-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awslabs/aws-c-common/labels{/name}","releases_url":"https://api.github.com/repos/awslabs/aws-c-common/releases{/id}","deployments_url":"https://api.github.com/repos/awslabs/aws-c-common/deployments","created_at":"2018-01-11T19:17:12Z","updated_at":"2018-07-19T19:47:50Z","pushed_at":"2018-07-19T20:48:24Z","git_url":"git://github.com/awslabs/aws-c-common.git","ssh_url":"git@github.com:awslabs/aws-c-common.git","clone_url":"https://github.com/awslabs/aws-c-common.git","svn_url":"https://github.com/awslabs/aws-c-common","homepage":null,"size":475,"stargazers_count":25,"watchers_count":25,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":9,"open_issues":7,"watchers":25,"default_branch":"master"}},"base":{"label":"awslabs:master","ref":"master","sha":"163a642f46a00023adc2acdf1d4ad7054a2880ed","user":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":117142517,"node_id":"MDEwOlJlcG9zaXRvcnkxMTcxNDI1MTc=","name":"aws-c-common","full_name":"awslabs/aws-c-common","owner":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/awslabs/aws-c-common","description":"Core c99 package for AWS SDK for C. Includes cross-platform primitives, configuration, data structures, and error handling.","fork":false,"url":"https://api.github.com/repos/awslabs/aws-c-common","forks_url":"https://api.github.com/repos/awslabs/aws-c-common/forks","keys_url":"https://api.github.com/repos/awslabs/aws-c-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awslabs/aws-c-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awslabs/aws-c-common/teams","hooks_url":"https://api.github.com/repos/awslabs/aws-c-common/hooks","issue_events_url":"https://api.github.com/repos/awslabs/aws-c-common/issues/events{/number}","events_url":"https://api.github.com/repos/awslabs/aws-c-common/events","assignees_url":"https://api.github.com/repos/awslabs/aws-c-common/assignees{/user}","branches_url":"https://api.github.com/repos/awslabs/aws-c-common/branches{/branch}","tags_url":"https://api.github.com/repos/awslabs/aws-c-common/tags","blobs_url":"https://api.github.com/repos/awslabs/aws-c-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awslabs/aws-c-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awslabs/aws-c-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/awslabs/aws-c-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awslabs/aws-c-common/statuses/{sha}","languages_url":"https://api.github.com/repos/awslabs/aws-c-common/languages","stargazers_url":"https://api.github.com/repos/awslabs/aws-c-common/stargazers","contributors_url":"https://api.github.com/repos/awslabs/aws-c-common/contributors","subscribers_url":"https://api.github.com/repos/awslabs/aws-c-common/subscribers","subscription_url":"https://api.github.com/repos/awslabs/aws-c-common/subscription","commits_url":"https://api.github.com/repos/awslabs/aws-c-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/awslabs/aws-c-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/awslabs/aws-c-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/awslabs/aws-c-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/awslabs/aws-c-common/contents/{+path}","compare_url":"https://api.github.com/repos/awslabs/aws-c-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awslabs/aws-c-common/merges","archive_url":"https://api.github.com/repos/awslabs/aws-c-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awslabs/aws-c-common/downloads","issues_url":"https://api.github.com/repos/awslabs/aws-c-common/issues{/number}","pulls_url":"https://api.github.com/repos/awslabs/aws-c-common/pulls{/number}","milestones_url":"https://api.github.com/repos/awslabs/aws-c-common/milestones{/number}","notifications_url":"https://api.github.com/repos/awslabs/aws-c-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awslabs/aws-c-common/labels{/name}","releases_url":"https://api.github.com/repos/awslabs/aws-c-common/releases{/id}","deployments_url":"https://api.github.com/repos/awslabs/aws-c-common/deployments","created_at":"2018-01-11T19:17:12Z","updated_at":"2018-07-19T19:47:50Z","pushed_at":"2018-07-19T20:48:24Z","git_url":"git://github.com/awslabs/aws-c-common.git","ssh_url":"git@github.com:awslabs/aws-c-common.git","clone_url":"https://github.com/awslabs/aws-c-common.git","svn_url":"https://github.com/awslabs/aws-c-common","homepage":null,"size":475,"stargazers_count":25,"watchers_count":25,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":9,"open_issues":7,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/awslabs/aws-c-common/pulls/85"},"html":{"href":"https://github.com/awslabs/aws-c-common/pull/85"},"issue":{"href":"https://api.github.com/repos/awslabs/aws-c-common/issues/85"},"comments":{"href":"https://api.github.com/repos/awslabs/aws-c-common/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/awslabs/aws-c-common/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/awslabs/aws-c-common/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/awslabs/aws-c-common/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/awslabs/aws-c-common/statuses/f3de38647fa4fc120c6a55415d3631a1b23e5b05"}},"author_association":"NONE"}}
{"actor":{"display_login":"graebm"}}