{"action":"created","comment":{"url":"https://api.github.com/repos/thewca/worldcubeassociation.org/pulls/comments/201492706","pull_request_review_id":136006929,"id":201492706,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTQ5MjcwNg==","diff_hunk":"@@ -40,6 +40,40 @@ def event\n     Event.c_find(competition_event.event_id)\n   end\n \n+  # Compute a round type id from round information\n+  def round_type_id","path":"WcaOnRails/app/models/round.rb","position":5,"original_position":5,"commit_id":"3a8059f959a8b3bedb8d519d379a2bdc84edec3e","original_commit_id":"3a8059f959a8b3bedb8d519d379a2bdc84edec3e","user":{"login":"SAuroux","id":3089192,"node_id":"MDQ6VXNlcjMwODkxOTI=","avatar_url":"https://avatars1.githubusercontent.com/u/3089192?v=4","gravatar_id":"","url":"https://api.github.com/users/SAuroux","html_url":"https://github.com/SAuroux","followers_url":"https://api.github.com/users/SAuroux/followers","following_url":"https://api.github.com/users/SAuroux/following{/other_user}","gists_url":"https://api.github.com/users/SAuroux/gists{/gist_id}","starred_url":"https://api.github.com/users/SAuroux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SAuroux/subscriptions","organizations_url":"https://api.github.com/users/SAuroux/orgs","repos_url":"https://api.github.com/users/SAuroux/repos","events_url":"https://api.github.com/users/SAuroux/events{/privacy}","received_events_url":"https://api.github.com/users/SAuroux/received_events","type":"User","site_admin":false},"body":"@viroulep yes, the logic looks perfectly fine to me!","created_at":"2018-07-10T20:58:44Z","updated_at":"2018-07-10T20:58:45Z","html_url":"https://github.com/thewca/worldcubeassociation.org/pull/3032#discussion_r201492706","pull_request_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/pulls/3032","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/thewca/worldcubeassociation.org/pulls/comments/201492706"},"html":{"href":"https://github.com/thewca/worldcubeassociation.org/pull/3032#discussion_r201492706"},"pull_request":{"href":"https://api.github.com/repos/thewca/worldcubeassociation.org/pulls/3032"}},"in_reply_to_id":200958943},"pull_request":{"url":"https://api.github.com/repos/thewca/worldcubeassociation.org/pulls/3032","id":198534474,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NTM0NDc0","html_url":"https://github.com/thewca/worldcubeassociation.org/pull/3032","diff_url":"https://github.com/thewca/worldcubeassociation.org/pull/3032.diff","patch_url":"https://github.com/thewca/worldcubeassociation.org/pull/3032.patch","issue_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/issues/3032","number":3032,"state":"open","locked":false,"title":"Adds roundTypeId to round","user":{"login":"viroulep","id":1007485,"node_id":"MDQ6VXNlcjEwMDc0ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/1007485?v=4","gravatar_id":"","url":"https://api.github.com/users/viroulep","html_url":"https://github.com/viroulep","followers_url":"https://api.github.com/users/viroulep/followers","following_url":"https://api.github.com/users/viroulep/following{/other_user}","gists_url":"https://api.github.com/users/viroulep/gists{/gist_id}","starred_url":"https://api.github.com/users/viroulep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viroulep/subscriptions","organizations_url":"https://api.github.com/users/viroulep/orgs","repos_url":"https://api.github.com/users/viroulep/repos","events_url":"https://api.github.com/users/viroulep/events{/privacy}","received_events_url":"https://api.github.com/users/viroulep/received_events","type":"User","site_admin":false},"body":"See [this discussion](https://github.com/thewca/worldcubeassociation.org/pull/3018#issuecomment-401594865) for the motivation behind this.\r\n\r\nThis introduces:\r\n  - a way to link a round to its type id (db column)\r\n  - a method to compute the round type id from a round and competition's attributes (round number, total number of rounds for the event, does the round have a cutoff?)\r\n  - computation of the round type id when creating rounds (that currently occurs only through the events WCIF)\r\n  - migration to update existing rounds (can only affect competitions after the introduction of `competition_event` in 2017)\r\n\r\nI did not export the `roundTypeId` into the WCIF as it's not in the spec (yet?), but in any case we should always compute it ourselves.\r\nAlso I used camel case for the field, just in case some day we want to do joins with existing data.","created_at":"2018-07-01T17:38:55Z","updated_at":"2018-07-10T20:58:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b67d31b0f6912523fde853617964ee45f72d8e87","assignee":null,"assignees":[],"requested_reviewers":[{"login":"SAuroux","id":3089192,"node_id":"MDQ6VXNlcjMwODkxOTI=","avatar_url":"https://avatars1.githubusercontent.com/u/3089192?v=4","gravatar_id":"","url":"https://api.github.com/users/SAuroux","html_url":"https://github.com/SAuroux","followers_url":"https://api.github.com/users/SAuroux/followers","following_url":"https://api.github.com/users/SAuroux/following{/other_user}","gists_url":"https://api.github.com/users/SAuroux/gists{/gist_id}","starred_url":"https://api.github.com/users/SAuroux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SAuroux/subscriptions","organizations_url":"https://api.github.com/users/SAuroux/orgs","repos_url":"https://api.github.com/users/SAuroux/repos","events_url":"https://api.github.com/users/SAuroux/events{/privacy}","received_events_url":"https://api.github.com/users/SAuroux/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/pulls/3032/commits","review_comments_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/pulls/3032/comments","review_comment_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/issues/3032/comments","statuses_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/statuses/3a8059f959a8b3bedb8d519d379a2bdc84edec3e","head":{"label":"viroulep:add-round-type-to-round","ref":"add-round-type-to-round","sha":"3a8059f959a8b3bedb8d519d379a2bdc84edec3e","user":{"login":"viroulep","id":1007485,"node_id":"MDQ6VXNlcjEwMDc0ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/1007485?v=4","gravatar_id":"","url":"https://api.github.com/users/viroulep","html_url":"https://github.com/viroulep","followers_url":"https://api.github.com/users/viroulep/followers","following_url":"https://api.github.com/users/viroulep/following{/other_user}","gists_url":"https://api.github.com/users/viroulep/gists{/gist_id}","starred_url":"https://api.github.com/users/viroulep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viroulep/subscriptions","organizations_url":"https://api.github.com/users/viroulep/orgs","repos_url":"https://api.github.com/users/viroulep/repos","events_url":"https://api.github.com/users/viroulep/events{/privacy}","received_events_url":"https://api.github.com/users/viroulep/received_events","type":"User","site_admin":false},"repo":{"id":49994335,"node_id":"MDEwOlJlcG9zaXRvcnk0OTk5NDMzNQ==","name":"worldcubeassociation.org","full_name":"viroulep/worldcubeassociation.org","owner":{"login":"viroulep","id":1007485,"node_id":"MDQ6VXNlcjEwMDc0ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/1007485?v=4","gravatar_id":"","url":"https://api.github.com/users/viroulep","html_url":"https://github.com/viroulep","followers_url":"https://api.github.com/users/viroulep/followers","following_url":"https://api.github.com/users/viroulep/following{/other_user}","gists_url":"https://api.github.com/users/viroulep/gists{/gist_id}","starred_url":"https://api.github.com/users/viroulep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viroulep/subscriptions","organizations_url":"https://api.github.com/users/viroulep/orgs","repos_url":"https://api.github.com/users/viroulep/repos","events_url":"https://api.github.com/users/viroulep/events{/privacy}","received_events_url":"https://api.github.com/users/viroulep/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/viroulep/worldcubeassociation.org","description":"[WCA Project] All of the code that runs on worldcubeassociation.org","fork":true,"url":"https://api.github.com/repos/viroulep/worldcubeassociation.org","forks_url":"https://api.github.com/repos/viroulep/worldcubeassociation.org/forks","keys_url":"https://api.github.com/repos/viroulep/worldcubeassociation.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/viroulep/worldcubeassociation.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/viroulep/worldcubeassociation.org/teams","hooks_url":"https://api.github.com/repos/viroulep/worldcubeassociation.org/hooks","issue_events_url":"https://api.github.com/repos/viroulep/worldcubeassociation.org/issues/events{/number}","events_url":"https://api.github.com/repos/viroulep/worldcubeassociation.org/events","assignees_url":"https://api.github.com/repos/viroulep/worldcubeassociation.org/assignees{/user}","branches_url":"https://api.github.com/repos/viroulep/worldcubeassociation.org/branches{/branch}","tags_url":"https://api.github.com/repos/viroulep/worldcubeassociation.org/tags","blobs_url":"https://api.github.com/repos/viroulep/worldcubeassociation.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/viroulep/worldcubeassociation.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/viroulep/worldcubeassociation.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/viroulep/worldcubeassociation.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/viroulep/worldcubeassociation.org/statuses/{sha}","languages_url":"https://api.github.com/repos/viroulep/worldcubeassociation.org/languages","stargazers_url":"https://api.github.com/repos/viroulep/worldcubeassociation.org/stargazers","contributors_url":"https://api.github.com/repos/viroulep/worldcubeassociation.org/contributors","subscribers_url":"https://api.github.com/repos/viroulep/worldcubeassociation.org/subscribers","subscription_url":"https://api.github.com/repos/viroulep/worldcubeassociation.org/subscription","commits_url":"https://api.github.com/repos/viroulep/worldcubeassociation.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/viroulep/worldcubeassociation.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/viroulep/worldcubeassociation.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/viroulep/worldcubeassociation.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/viroulep/worldcubeassociation.org/contents/{+path}","compare_url":"https://api.github.com/repos/viroulep/worldcubeassociation.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/viroulep/worldcubeassociation.org/merges","archive_url":"https://api.github.com/repos/viroulep/worldcubeassociation.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/viroulep/worldcubeassociation.org/downloads","issues_url":"https://api.github.com/repos/viroulep/worldcubeassociation.org/issues{/number}","pulls_url":"https://api.github.com/repos/viroulep/worldcubeassociation.org/pulls{/number}","milestones_url":"https://api.github.com/repos/viroulep/worldcubeassociation.org/milestones{/number}","notifications_url":"https://api.github.com/repos/viroulep/worldcubeassociation.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/viroulep/worldcubeassociation.org/labels{/name}","releases_url":"https://api.github.com/repos/viroulep/worldcubeassociation.org/releases{/id}","deployments_url":"https://api.github.com/repos/viroulep/worldcubeassociation.org/deployments","created_at":"2016-01-20T01:01:37Z","updated_at":"2018-07-03T21:14:57Z","pushed_at":"2018-07-09T16:21:05Z","git_url":"git://github.com/viroulep/worldcubeassociation.org.git","ssh_url":"git@github.com:viroulep/worldcubeassociation.org.git","clone_url":"https://github.com/viroulep/worldcubeassociation.org.git","svn_url":"https://github.com/viroulep/worldcubeassociation.org","homepage":"https://www.worldcubeassociation.org/","size":114658,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"thewca:master","ref":"master","sha":"2479da18bca7acd15e5f209bd72a862c864bc1e6","user":{"login":"thewca","id":19806436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5ODA2NDM2","avatar_url":"https://avatars0.githubusercontent.com/u/19806436?v=4","gravatar_id":"","url":"https://api.github.com/users/thewca","html_url":"https://github.com/thewca","followers_url":"https://api.github.com/users/thewca/followers","following_url":"https://api.github.com/users/thewca/following{/other_user}","gists_url":"https://api.github.com/users/thewca/gists{/gist_id}","starred_url":"https://api.github.com/users/thewca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thewca/subscriptions","organizations_url":"https://api.github.com/users/thewca/orgs","repos_url":"https://api.github.com/users/thewca/repos","events_url":"https://api.github.com/users/thewca/events{/privacy}","received_events_url":"https://api.github.com/users/thewca/received_events","type":"Organization","site_admin":false},"repo":{"id":34161579,"node_id":"MDEwOlJlcG9zaXRvcnkzNDE2MTU3OQ==","name":"worldcubeassociation.org","full_name":"thewca/worldcubeassociation.org","owner":{"login":"thewca","id":19806436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5ODA2NDM2","avatar_url":"https://avatars0.githubusercontent.com/u/19806436?v=4","gravatar_id":"","url":"https://api.github.com/users/thewca","html_url":"https://github.com/thewca","followers_url":"https://api.github.com/users/thewca/followers","following_url":"https://api.github.com/users/thewca/following{/other_user}","gists_url":"https://api.github.com/users/thewca/gists{/gist_id}","starred_url":"https://api.github.com/users/thewca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thewca/subscriptions","organizations_url":"https://api.github.com/users/thewca/orgs","repos_url":"https://api.github.com/users/thewca/repos","events_url":"https://api.github.com/users/thewca/events{/privacy}","received_events_url":"https://api.github.com/users/thewca/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thewca/worldcubeassociation.org","description":"All of the code that runs on worldcubeassociation.org","fork":false,"url":"https://api.github.com/repos/thewca/worldcubeassociation.org","forks_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/forks","keys_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/teams","hooks_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/hooks","issue_events_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/issues/events{/number}","events_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/events","assignees_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/assignees{/user}","branches_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/branches{/branch}","tags_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/tags","blobs_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/statuses/{sha}","languages_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/languages","stargazers_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/stargazers","contributors_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/contributors","subscribers_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/subscribers","subscription_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/subscription","commits_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/contents/{+path}","compare_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/merges","archive_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/downloads","issues_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/issues{/number}","pulls_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/pulls{/number}","milestones_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/milestones{/number}","notifications_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/labels{/name}","releases_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/releases{/id}","deployments_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/deployments","created_at":"2015-04-18T10:21:53Z","updated_at":"2018-07-10T17:16:45Z","pushed_at":"2018-07-10T20:47:49Z","git_url":"git://github.com/thewca/worldcubeassociation.org.git","ssh_url":"git@github.com:thewca/worldcubeassociation.org.git","clone_url":"https://github.com/thewca/worldcubeassociation.org.git","svn_url":"https://github.com/thewca/worldcubeassociation.org","homepage":"https://www.worldcubeassociation.org/","size":124566,"stargazers_count":76,"watchers_count":76,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":57,"mirror_url":null,"archived":false,"open_issues_count":241,"license":null,"forks":57,"open_issues":241,"watchers":76,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thewca/worldcubeassociation.org/pulls/3032"},"html":{"href":"https://github.com/thewca/worldcubeassociation.org/pull/3032"},"issue":{"href":"https://api.github.com/repos/thewca/worldcubeassociation.org/issues/3032"},"comments":{"href":"https://api.github.com/repos/thewca/worldcubeassociation.org/issues/3032/comments"},"review_comments":{"href":"https://api.github.com/repos/thewca/worldcubeassociation.org/pulls/3032/comments"},"review_comment":{"href":"https://api.github.com/repos/thewca/worldcubeassociation.org/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thewca/worldcubeassociation.org/pulls/3032/commits"},"statuses":{"href":"https://api.github.com/repos/thewca/worldcubeassociation.org/statuses/3a8059f959a8b3bedb8d519d379a2bdc84edec3e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"SAuroux"}}