{"action":"created","issue":{"url":"https://api.github.com/repos/sylvainjule/kirby-colorextractor/issues/3","repository_url":"https://api.github.com/repos/sylvainjule/kirby-colorextractor","labels_url":"https://api.github.com/repos/sylvainjule/kirby-colorextractor/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/sylvainjule/kirby-colorextractor/issues/3/comments","events_url":"https://api.github.com/repos/sylvainjule/kirby-colorextractor/issues/3/events","html_url":"https://github.com/sylvainjule/kirby-colorextractor/issues/3","id":368355616,"node_id":"MDU6SXNzdWUzNjgzNTU2MTY=","number":3,"title":"color extraction fails with absolute urls","user":{"login":"joernroeder","id":270540,"node_id":"MDQ6VXNlcjI3MDU0MA==","avatar_url":"https://avatars2.githubusercontent.com/u/270540?v=4","gravatar_id":"","url":"https://api.github.com/users/joernroeder","html_url":"https://github.com/joernroeder","followers_url":"https://api.github.com/users/joernroeder/followers","following_url":"https://api.github.com/users/joernroeder/following{/other_user}","gists_url":"https://api.github.com/users/joernroeder/gists{/gist_id}","starred_url":"https://api.github.com/users/joernroeder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joernroeder/subscriptions","organizations_url":"https://api.github.com/users/joernroeder/orgs","repos_url":"https://api.github.com/users/joernroeder/repos","events_url":"https://api.github.com/users/joernroeder/events{/privacy}","received_events_url":"https://api.github.com/users/joernroeder/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-10-09T19:12:03Z","updated_at":"2018-10-13T08:34:09Z","closed_at":null,"author_association":"NONE","body":"My image urls start with `/media/…` and the file is therefore not found. \r\nhttps://github.com/sylvainjule/kirby-colorextractor/blob/master/lib/functions.php#L9 could be prefixed with the  media folder path from kirby->roots() but it's just a shot in the dark…"},"comment":{"url":"https://api.github.com/repos/sylvainjule/kirby-colorextractor/issues/comments/429522613","html_url":"https://github.com/sylvainjule/kirby-colorextractor/issues/3#issuecomment-429522613","issue_url":"https://api.github.com/repos/sylvainjule/kirby-colorextractor/issues/3","id":429522613,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTUyMjYxMw==","user":{"login":"sylvainjule","id":14079751,"node_id":"MDQ6VXNlcjE0MDc5NzUx","avatar_url":"https://avatars2.githubusercontent.com/u/14079751?v=4","gravatar_id":"","url":"https://api.github.com/users/sylvainjule","html_url":"https://github.com/sylvainjule","followers_url":"https://api.github.com/users/sylvainjule/followers","following_url":"https://api.github.com/users/sylvainjule/following{/other_user}","gists_url":"https://api.github.com/users/sylvainjule/gists{/gist_id}","starred_url":"https://api.github.com/users/sylvainjule/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sylvainjule/subscriptions","organizations_url":"https://api.github.com/users/sylvainjule/orgs","repos_url":"https://api.github.com/users/sylvainjule/repos","events_url":"https://api.github.com/users/sylvainjule/events{/privacy}","received_events_url":"https://api.github.com/users/sylvainjule/received_events","type":"User","site_admin":false},"created_at":"2018-10-13T08:34:09Z","updated_at":"2018-10-13T08:34:09Z","author_association":"OWNER","body":"My bad, within the new docs, what should have been `$kirby->roots()->media()` is shown as `$kirby->url('media')`, which returns the url of the folder, not its disk path.\r\n\r\nActually the better way would be to call `$thumb->root()` or `$thumb->mediaRoot()`, but I can't go with it right now as there is [an issue](https://github.com/k-next/kirby/issues/1015) with the $thumb object, this is why I went for `url`. Probably best to wait for its fix than getting lost in quickfixes that will need to be changed in the end."}}
{"actor":{"display_login":"sylvainjule"}}