{"action":"created","issue":{"url":"https://api.github.com/repos/keepassxreboot/keepassxc/issues/2430","repository_url":"https://api.github.com/repos/keepassxreboot/keepassxc","labels_url":"https://api.github.com/repos/keepassxreboot/keepassxc/issues/2430/labels{/name}","comments_url":"https://api.github.com/repos/keepassxreboot/keepassxc/issues/2430/comments","events_url":"https://api.github.com/repos/keepassxreboot/keepassxc/issues/2430/events","html_url":"https://github.com/keepassxreboot/keepassxc/pull/2430","id":374666097,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MzA4MjMw","number":2430,"title":"Add more expiration presets","user":{"login":"st-sloth","id":19147756,"node_id":"MDQ6VXNlcjE5MTQ3NzU2","avatar_url":"https://avatars0.githubusercontent.com/u/19147756?v=4","gravatar_id":"","url":"https://api.github.com/users/st-sloth","html_url":"https://github.com/st-sloth","followers_url":"https://api.github.com/users/st-sloth/followers","following_url":"https://api.github.com/users/st-sloth/following{/other_user}","gists_url":"https://api.github.com/users/st-sloth/gists{/gist_id}","starred_url":"https://api.github.com/users/st-sloth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/st-sloth/subscriptions","organizations_url":"https://api.github.com/users/st-sloth/orgs","repos_url":"https://api.github.com/users/st-sloth/repos","events_url":"https://api.github.com/users/st-sloth/events{/privacy}","received_events_url":"https://api.github.com/users/st-sloth/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-27T17:02:09Z","updated_at":"2018-10-29T03:38:51Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/2430","html_url":"https://github.com/keepassxreboot/keepassxc/pull/2430","diff_url":"https://github.com/keepassxreboot/keepassxc/pull/2430.diff","patch_url":"https://github.com/keepassxreboot/keepassxc/pull/2430.patch"},"body":"<!--- Provide a general summary of your changes in the title above -->\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\nChanged single expiration preset \"1 year\" to \"1 year(s)\", \"2 year(s)\", \"3 year(s)\", analogous to \"week(s)\" and \"month(s)\". Because of the changed literal, translations changed too, and I only updated translations for English and Russian. Others are marked \"unfinished\". Which is why I consider this a breaking change so far. But perhaps this added flexibility is worth updating translations. Still, I see why these changes might be too much to fix a little inconvenience.\r\n\r\n## Motivation and context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\nPersonally I prefer setting 2 or even 3 year expiration for many less used and less valuable passwords because changing them yearly or renew expiration is too much of a hassle. And for that I have to manually edit date which is also not ideal. And I would assume, I'm not the only one.\r\n\r\n## How has this been tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\nIt hasn't been tested. I am not a C++ developer but know how long and exhausting setting up the environment often is. The code change is pretty tiny and based on the \"month(s)\" presets, translation changes are bigger but seem to be fine (except for not being present for most languages). Because of this I decided to give PR a shot without making a build.\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? -->\r\n<!--- Please remove all lines which don't apply. -->\r\n- ✅ New feature (non-breaking change which adds functionality)\r\n- ✅ Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Please go over all the following points. -->\r\n<!--- Again, remove any lines which don't apply. -->\r\n<!--- Pull Requests that don't fulfill all [REQUIRED] requisites are likely -->\r\n<!--- to be sent back to you for correction or will be rejected.  -->\r\n- ✅ I have read the **CONTRIBUTING** document. **[REQUIRED]**\r\n- ✅ My code follows the code style of this project. **[REQUIRED]**\r\n"},"comment":{"url":"https://api.github.com/repos/keepassxreboot/keepassxc/issues/comments/433779285","html_url":"https://github.com/keepassxreboot/keepassxc/pull/2430#issuecomment-433779285","issue_url":"https://api.github.com/repos/keepassxreboot/keepassxc/issues/2430","id":433779285,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzc3OTI4NQ==","user":{"login":"droidmonkey","id":2809491,"node_id":"MDQ6VXNlcjI4MDk0OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/2809491?v=4","gravatar_id":"","url":"https://api.github.com/users/droidmonkey","html_url":"https://github.com/droidmonkey","followers_url":"https://api.github.com/users/droidmonkey/followers","following_url":"https://api.github.com/users/droidmonkey/following{/other_user}","gists_url":"https://api.github.com/users/droidmonkey/gists{/gist_id}","starred_url":"https://api.github.com/users/droidmonkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droidmonkey/subscriptions","organizations_url":"https://api.github.com/users/droidmonkey/orgs","repos_url":"https://api.github.com/users/droidmonkey/repos","events_url":"https://api.github.com/users/droidmonkey/events{/privacy}","received_events_url":"https://api.github.com/users/droidmonkey/received_events","type":"User","site_admin":false},"created_at":"2018-10-29T03:38:51Z","updated_at":"2018-10-29T03:38:51Z","author_association":"MEMBER","body":"Your fix did not remove the translation file changes. Only CPP/H files should be changed."}}
{"actor":{"display_login":"droidmonkey"}}