{"action":"opened","number":55,"pull_request":{"url":"https://api.github.com/repos/rescrv/libmacaroons/pulls/55","id":241208097,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxMjA4MDk3","html_url":"https://github.com/rescrv/libmacaroons/pull/55","diff_url":"https://github.com/rescrv/libmacaroons/pull/55.diff","patch_url":"https://github.com/rescrv/libmacaroons/pull/55.patch","issue_url":"https://api.github.com/repos/rescrv/libmacaroons/issues/55","number":55,"state":"open","locked":false,"title":"Initialize empty structs to void missing data being serialized to JSON.","user":{"login":"nickrobison-usds","id":44269964,"node_id":"MDQ6VXNlcjQ0MjY5OTY0","avatar_url":"https://avatars3.githubusercontent.com/u/44269964?v=4","gravatar_id":"","url":"https://api.github.com/users/nickrobison-usds","html_url":"https://github.com/nickrobison-usds","followers_url":"https://api.github.com/users/nickrobison-usds/followers","following_url":"https://api.github.com/users/nickrobison-usds/following{/other_user}","gists_url":"https://api.github.com/users/nickrobison-usds/gists{/gist_id}","starred_url":"https://api.github.com/users/nickrobison-usds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickrobison-usds/subscriptions","organizations_url":"https://api.github.com/users/nickrobison-usds/orgs","repos_url":"https://api.github.com/users/nickrobison-usds/repos","events_url":"https://api.github.com/users/nickrobison-usds/events{/privacy}","received_events_url":"https://api.github.com/users/nickrobison-usds/received_events","type":"User","site_admin":false},"body":"When serializing a macaroon to the V2 JSON format, any fields which are not utilized (such as when serializing a discharge macaroon) result in garbage data being emitted.\r\n\r\nThe patch simply initializes the fields with empty data, which is then filtered out.","created_at":"2018-12-27T19:07:13Z","updated_at":"2018-12-27T19:07:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rescrv/libmacaroons/pulls/55/commits","review_comments_url":"https://api.github.com/repos/rescrv/libmacaroons/pulls/55/comments","review_comment_url":"https://api.github.com/repos/rescrv/libmacaroons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rescrv/libmacaroons/issues/55/comments","statuses_url":"https://api.github.com/repos/rescrv/libmacaroons/statuses/da35c9d67698f37b7c64674274fc12b952a3cc8e","head":{"label":"nickrobison-usds:json-fields","ref":"json-fields","sha":"da35c9d67698f37b7c64674274fc12b952a3cc8e","user":{"login":"nickrobison-usds","id":44269964,"node_id":"MDQ6VXNlcjQ0MjY5OTY0","avatar_url":"https://avatars3.githubusercontent.com/u/44269964?v=4","gravatar_id":"","url":"https://api.github.com/users/nickrobison-usds","html_url":"https://github.com/nickrobison-usds","followers_url":"https://api.github.com/users/nickrobison-usds/followers","following_url":"https://api.github.com/users/nickrobison-usds/following{/other_user}","gists_url":"https://api.github.com/users/nickrobison-usds/gists{/gist_id}","starred_url":"https://api.github.com/users/nickrobison-usds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickrobison-usds/subscriptions","organizations_url":"https://api.github.com/users/nickrobison-usds/orgs","repos_url":"https://api.github.com/users/nickrobison-usds/repos","events_url":"https://api.github.com/users/nickrobison-usds/events{/privacy}","received_events_url":"https://api.github.com/users/nickrobison-usds/received_events","type":"User","site_admin":false},"repo":{"id":160399300,"node_id":"MDEwOlJlcG9zaXRvcnkxNjAzOTkzMDA=","name":"libmacaroons","full_name":"nickrobison-usds/libmacaroons","private":false,"owner":{"login":"nickrobison-usds","id":44269964,"node_id":"MDQ6VXNlcjQ0MjY5OTY0","avatar_url":"https://avatars3.githubusercontent.com/u/44269964?v=4","gravatar_id":"","url":"https://api.github.com/users/nickrobison-usds","html_url":"https://github.com/nickrobison-usds","followers_url":"https://api.github.com/users/nickrobison-usds/followers","following_url":"https://api.github.com/users/nickrobison-usds/following{/other_user}","gists_url":"https://api.github.com/users/nickrobison-usds/gists{/gist_id}","starred_url":"https://api.github.com/users/nickrobison-usds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickrobison-usds/subscriptions","organizations_url":"https://api.github.com/users/nickrobison-usds/orgs","repos_url":"https://api.github.com/users/nickrobison-usds/repos","events_url":"https://api.github.com/users/nickrobison-usds/events{/privacy}","received_events_url":"https://api.github.com/users/nickrobison-usds/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nickrobison-usds/libmacaroons","description":"Macaroons are flexible authorization credentials that support decentralized delegation, attenuation, and verification.","fork":true,"url":"https://api.github.com/repos/nickrobison-usds/libmacaroons","forks_url":"https://api.github.com/repos/nickrobison-usds/libmacaroons/forks","keys_url":"https://api.github.com/repos/nickrobison-usds/libmacaroons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nickrobison-usds/libmacaroons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nickrobison-usds/libmacaroons/teams","hooks_url":"https://api.github.com/repos/nickrobison-usds/libmacaroons/hooks","issue_events_url":"https://api.github.com/repos/nickrobison-usds/libmacaroons/issues/events{/number}","events_url":"https://api.github.com/repos/nickrobison-usds/libmacaroons/events","assignees_url":"https://api.github.com/repos/nickrobison-usds/libmacaroons/assignees{/user}","branches_url":"https://api.github.com/repos/nickrobison-usds/libmacaroons/branches{/branch}","tags_url":"https://api.github.com/repos/nickrobison-usds/libmacaroons/tags","blobs_url":"https://api.github.com/repos/nickrobison-usds/libmacaroons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nickrobison-usds/libmacaroons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nickrobison-usds/libmacaroons/git/refs{/sha}","trees_url":"https://api.github.com/repos/nickrobison-usds/libmacaroons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nickrobison-usds/libmacaroons/statuses/{sha}","languages_url":"https://api.github.com/repos/nickrobison-usds/libmacaroons/languages","stargazers_url":"https://api.github.com/repos/nickrobison-usds/libmacaroons/stargazers","contributors_url":"https://api.github.com/repos/nickrobison-usds/libmacaroons/contributors","subscribers_url":"https://api.github.com/repos/nickrobison-usds/libmacaroons/subscribers","subscription_url":"https://api.github.com/repos/nickrobison-usds/libmacaroons/subscription","commits_url":"https://api.github.com/repos/nickrobison-usds/libmacaroons/commits{/sha}","git_commits_url":"https://api.github.com/repos/nickrobison-usds/libmacaroons/git/commits{/sha}","comments_url":"https://api.github.com/repos/nickrobison-usds/libmacaroons/comments{/number}","issue_comment_url":"https://api.github.com/repos/nickrobison-usds/libmacaroons/issues/comments{/number}","contents_url":"https://api.github.com/repos/nickrobison-usds/libmacaroons/contents/{+path}","compare_url":"https://api.github.com/repos/nickrobison-usds/libmacaroons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nickrobison-usds/libmacaroons/merges","archive_url":"https://api.github.com/repos/nickrobison-usds/libmacaroons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nickrobison-usds/libmacaroons/downloads","issues_url":"https://api.github.com/repos/nickrobison-usds/libmacaroons/issues{/number}","pulls_url":"https://api.github.com/repos/nickrobison-usds/libmacaroons/pulls{/number}","milestones_url":"https://api.github.com/repos/nickrobison-usds/libmacaroons/milestones{/number}","notifications_url":"https://api.github.com/repos/nickrobison-usds/libmacaroons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nickrobison-usds/libmacaroons/labels{/name}","releases_url":"https://api.github.com/repos/nickrobison-usds/libmacaroons/releases{/id}","deployments_url":"https://api.github.com/repos/nickrobison-usds/libmacaroons/deployments","created_at":"2018-12-04T18:10:09Z","updated_at":"2018-12-04T18:10:12Z","pushed_at":"2018-12-27T19:05:51Z","git_url":"git://github.com/nickrobison-usds/libmacaroons.git","ssh_url":"git@github.com:nickrobison-usds/libmacaroons.git","clone_url":"https://github.com/nickrobison-usds/libmacaroons.git","svn_url":"https://github.com/nickrobison-usds/libmacaroons","homepage":null,"size":242,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rescrv:master","ref":"master","sha":"fb878b975bbf42d77be883a5327644594578d59e","user":{"login":"rescrv","id":1453649,"node_id":"MDQ6VXNlcjE0NTM2NDk=","avatar_url":"https://avatars0.githubusercontent.com/u/1453649?v=4","gravatar_id":"","url":"https://api.github.com/users/rescrv","html_url":"https://github.com/rescrv","followers_url":"https://api.github.com/users/rescrv/followers","following_url":"https://api.github.com/users/rescrv/following{/other_user}","gists_url":"https://api.github.com/users/rescrv/gists{/gist_id}","starred_url":"https://api.github.com/users/rescrv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rescrv/subscriptions","organizations_url":"https://api.github.com/users/rescrv/orgs","repos_url":"https://api.github.com/users/rescrv/repos","events_url":"https://api.github.com/users/rescrv/events{/privacy}","received_events_url":"https://api.github.com/users/rescrv/received_events","type":"User","site_admin":false},"repo":{"id":19852596,"node_id":"MDEwOlJlcG9zaXRvcnkxOTg1MjU5Ng==","name":"libmacaroons","full_name":"rescrv/libmacaroons","private":false,"owner":{"login":"rescrv","id":1453649,"node_id":"MDQ6VXNlcjE0NTM2NDk=","avatar_url":"https://avatars0.githubusercontent.com/u/1453649?v=4","gravatar_id":"","url":"https://api.github.com/users/rescrv","html_url":"https://github.com/rescrv","followers_url":"https://api.github.com/users/rescrv/followers","following_url":"https://api.github.com/users/rescrv/following{/other_user}","gists_url":"https://api.github.com/users/rescrv/gists{/gist_id}","starred_url":"https://api.github.com/users/rescrv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rescrv/subscriptions","organizations_url":"https://api.github.com/users/rescrv/orgs","repos_url":"https://api.github.com/users/rescrv/repos","events_url":"https://api.github.com/users/rescrv/events{/privacy}","received_events_url":"https://api.github.com/users/rescrv/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rescrv/libmacaroons","description":"Macaroons are flexible authorization credentials that support decentralized delegation, attenuation, and verification.","fork":false,"url":"https://api.github.com/repos/rescrv/libmacaroons","forks_url":"https://api.github.com/repos/rescrv/libmacaroons/forks","keys_url":"https://api.github.com/repos/rescrv/libmacaroons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rescrv/libmacaroons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rescrv/libmacaroons/teams","hooks_url":"https://api.github.com/repos/rescrv/libmacaroons/hooks","issue_events_url":"https://api.github.com/repos/rescrv/libmacaroons/issues/events{/number}","events_url":"https://api.github.com/repos/rescrv/libmacaroons/events","assignees_url":"https://api.github.com/repos/rescrv/libmacaroons/assignees{/user}","branches_url":"https://api.github.com/repos/rescrv/libmacaroons/branches{/branch}","tags_url":"https://api.github.com/repos/rescrv/libmacaroons/tags","blobs_url":"https://api.github.com/repos/rescrv/libmacaroons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rescrv/libmacaroons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rescrv/libmacaroons/git/refs{/sha}","trees_url":"https://api.github.com/repos/rescrv/libmacaroons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rescrv/libmacaroons/statuses/{sha}","languages_url":"https://api.github.com/repos/rescrv/libmacaroons/languages","stargazers_url":"https://api.github.com/repos/rescrv/libmacaroons/stargazers","contributors_url":"https://api.github.com/repos/rescrv/libmacaroons/contributors","subscribers_url":"https://api.github.com/repos/rescrv/libmacaroons/subscribers","subscription_url":"https://api.github.com/repos/rescrv/libmacaroons/subscription","commits_url":"https://api.github.com/repos/rescrv/libmacaroons/commits{/sha}","git_commits_url":"https://api.github.com/repos/rescrv/libmacaroons/git/commits{/sha}","comments_url":"https://api.github.com/repos/rescrv/libmacaroons/comments{/number}","issue_comment_url":"https://api.github.com/repos/rescrv/libmacaroons/issues/comments{/number}","contents_url":"https://api.github.com/repos/rescrv/libmacaroons/contents/{+path}","compare_url":"https://api.github.com/repos/rescrv/libmacaroons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rescrv/libmacaroons/merges","archive_url":"https://api.github.com/repos/rescrv/libmacaroons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rescrv/libmacaroons/downloads","issues_url":"https://api.github.com/repos/rescrv/libmacaroons/issues{/number}","pulls_url":"https://api.github.com/repos/rescrv/libmacaroons/pulls{/number}","milestones_url":"https://api.github.com/repos/rescrv/libmacaroons/milestones{/number}","notifications_url":"https://api.github.com/repos/rescrv/libmacaroons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rescrv/libmacaroons/labels{/name}","releases_url":"https://api.github.com/repos/rescrv/libmacaroons/releases{/id}","deployments_url":"https://api.github.com/repos/rescrv/libmacaroons/deployments","created_at":"2014-05-16T10:17:06Z","updated_at":"2018-12-26T21:58:49Z","pushed_at":"2018-07-13T15:46:04Z","git_url":"git://github.com/rescrv/libmacaroons.git","ssh_url":"git@github.com:rescrv/libmacaroons.git","clone_url":"https://github.com/rescrv/libmacaroons.git","svn_url":"https://github.com/rescrv/libmacaroons","homepage":null,"size":236,"stargazers_count":389,"watchers_count":389,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":39,"open_issues":15,"watchers":389,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rescrv/libmacaroons/pulls/55"},"html":{"href":"https://github.com/rescrv/libmacaroons/pull/55"},"issue":{"href":"https://api.github.com/repos/rescrv/libmacaroons/issues/55"},"comments":{"href":"https://api.github.com/repos/rescrv/libmacaroons/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/rescrv/libmacaroons/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/rescrv/libmacaroons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rescrv/libmacaroons/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/rescrv/libmacaroons/statuses/da35c9d67698f37b7c64674274fc12b952a3cc8e"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":4,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"nickrobison-usds"}}