{"action":"created","comment":{"url":"https://api.github.com/repos/superRaytin/react-monaco-editor/pulls/comments/234083636","pull_request_review_id":175650129,"id":234083636,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDA4MzYzNg==","diff_hunk":"@@ -71,7 +74,7 @@ class MonacoEditor extends React.Component {\n     const { language, theme, options } = this.props;\n     if (this.containerElement) {\n       // Before initializing monaco editor\n-      Object.assign(options, this.editorWillMount());\n+      Object.assign({}, options, this.editorWillMount());","path":"src/editor.js","position":15,"original_position":15,"commit_id":"5d960b23e7413abd86025af9690462db2710565d","original_commit_id":"5d960b23e7413abd86025af9690462db2710565d","user":{"login":"domoritz","id":589034,"node_id":"MDQ6VXNlcjU4OTAzNA==","avatar_url":"https://avatars2.githubusercontent.com/u/589034?v=4","gravatar_id":"","url":"https://api.github.com/users/domoritz","html_url":"https://github.com/domoritz","followers_url":"https://api.github.com/users/domoritz/followers","following_url":"https://api.github.com/users/domoritz/following{/other_user}","gists_url":"https://api.github.com/users/domoritz/gists{/gist_id}","starred_url":"https://api.github.com/users/domoritz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domoritz/subscriptions","organizations_url":"https://api.github.com/users/domoritz/orgs","repos_url":"https://api.github.com/users/domoritz/repos","events_url":"https://api.github.com/users/domoritz/events{/privacy}","received_events_url":"https://api.github.com/users/domoritz/received_events","type":"User","site_admin":false},"body":"Yeah, I understand that. What I wonder is whether `this.editorWillMount()` should be merged into the options or not. It looks very intentional to me and so I just wondered what was happening here.","created_at":"2018-11-16T03:51:03Z","updated_at":"2018-11-16T03:51:03Z","html_url":"https://github.com/superRaytin/react-monaco-editor/pull/162#discussion_r234083636","pull_request_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/pulls/162","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/superRaytin/react-monaco-editor/pulls/comments/234083636"},"html":{"href":"https://github.com/superRaytin/react-monaco-editor/pull/162#discussion_r234083636"},"pull_request":{"href":"https://api.github.com/repos/superRaytin/react-monaco-editor/pulls/162"}},"in_reply_to_id":234079728},"pull_request":{"url":"https://api.github.com/repos/superRaytin/react-monaco-editor/pulls/162","id":231399561,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMzk5NTYx","html_url":"https://github.com/superRaytin/react-monaco-editor/pull/162","diff_url":"https://github.com/superRaytin/react-monaco-editor/pull/162.diff","patch_url":"https://github.com/superRaytin/react-monaco-editor/pull/162.patch","issue_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/issues/162","number":162,"state":"open","locked":false,"title":"fix update options","user":{"login":"stevemao","id":6316590,"node_id":"MDQ6VXNlcjYzMTY1OTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6316590?v=4","gravatar_id":"","url":"https://api.github.com/users/stevemao","html_url":"https://github.com/stevemao","followers_url":"https://api.github.com/users/stevemao/followers","following_url":"https://api.github.com/users/stevemao/following{/other_user}","gists_url":"https://api.github.com/users/stevemao/gists{/gist_id}","starred_url":"https://api.github.com/users/stevemao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevemao/subscriptions","organizations_url":"https://api.github.com/users/stevemao/orgs","repos_url":"https://api.github.com/users/stevemao/repos","events_url":"https://api.github.com/users/stevemao/events{/privacy}","received_events_url":"https://api.github.com/users/stevemao/received_events","type":"User","site_admin":false},"body":"fixes https://github.com/superRaytin/react-monaco-editor/issues/156","created_at":"2018-11-16T02:47:59Z","updated_at":"2018-11-16T03:51:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c8634ac81038b01debdc91015fe4df7f73d0c92f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/pulls/162/commits","review_comments_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/pulls/162/comments","review_comment_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/issues/162/comments","statuses_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/statuses/5d960b23e7413abd86025af9690462db2710565d","head":{"label":"stevemao:feature/fix-update-options","ref":"feature/fix-update-options","sha":"5d960b23e7413abd86025af9690462db2710565d","user":{"login":"stevemao","id":6316590,"node_id":"MDQ6VXNlcjYzMTY1OTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6316590?v=4","gravatar_id":"","url":"https://api.github.com/users/stevemao","html_url":"https://github.com/stevemao","followers_url":"https://api.github.com/users/stevemao/followers","following_url":"https://api.github.com/users/stevemao/following{/other_user}","gists_url":"https://api.github.com/users/stevemao/gists{/gist_id}","starred_url":"https://api.github.com/users/stevemao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevemao/subscriptions","organizations_url":"https://api.github.com/users/stevemao/orgs","repos_url":"https://api.github.com/users/stevemao/repos","events_url":"https://api.github.com/users/stevemao/events{/privacy}","received_events_url":"https://api.github.com/users/stevemao/received_events","type":"User","site_admin":false},"repo":{"id":157791157,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc3OTExNTc=","name":"react-monaco-editor","full_name":"stevemao/react-monaco-editor","private":false,"owner":{"login":"stevemao","id":6316590,"node_id":"MDQ6VXNlcjYzMTY1OTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6316590?v=4","gravatar_id":"","url":"https://api.github.com/users/stevemao","html_url":"https://github.com/stevemao","followers_url":"https://api.github.com/users/stevemao/followers","following_url":"https://api.github.com/users/stevemao/following{/other_user}","gists_url":"https://api.github.com/users/stevemao/gists{/gist_id}","starred_url":"https://api.github.com/users/stevemao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevemao/subscriptions","organizations_url":"https://api.github.com/users/stevemao/orgs","repos_url":"https://api.github.com/users/stevemao/repos","events_url":"https://api.github.com/users/stevemao/events{/privacy}","received_events_url":"https://api.github.com/users/stevemao/received_events","type":"User","site_admin":false},"html_url":"https://github.com/stevemao/react-monaco-editor","description":"Monaco Editor for React.","fork":true,"url":"https://api.github.com/repos/stevemao/react-monaco-editor","forks_url":"https://api.github.com/repos/stevemao/react-monaco-editor/forks","keys_url":"https://api.github.com/repos/stevemao/react-monaco-editor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stevemao/react-monaco-editor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stevemao/react-monaco-editor/teams","hooks_url":"https://api.github.com/repos/stevemao/react-monaco-editor/hooks","issue_events_url":"https://api.github.com/repos/stevemao/react-monaco-editor/issues/events{/number}","events_url":"https://api.github.com/repos/stevemao/react-monaco-editor/events","assignees_url":"https://api.github.com/repos/stevemao/react-monaco-editor/assignees{/user}","branches_url":"https://api.github.com/repos/stevemao/react-monaco-editor/branches{/branch}","tags_url":"https://api.github.com/repos/stevemao/react-monaco-editor/tags","blobs_url":"https://api.github.com/repos/stevemao/react-monaco-editor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stevemao/react-monaco-editor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stevemao/react-monaco-editor/git/refs{/sha}","trees_url":"https://api.github.com/repos/stevemao/react-monaco-editor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stevemao/react-monaco-editor/statuses/{sha}","languages_url":"https://api.github.com/repos/stevemao/react-monaco-editor/languages","stargazers_url":"https://api.github.com/repos/stevemao/react-monaco-editor/stargazers","contributors_url":"https://api.github.com/repos/stevemao/react-monaco-editor/contributors","subscribers_url":"https://api.github.com/repos/stevemao/react-monaco-editor/subscribers","subscription_url":"https://api.github.com/repos/stevemao/react-monaco-editor/subscription","commits_url":"https://api.github.com/repos/stevemao/react-monaco-editor/commits{/sha}","git_commits_url":"https://api.github.com/repos/stevemao/react-monaco-editor/git/commits{/sha}","comments_url":"https://api.github.com/repos/stevemao/react-monaco-editor/comments{/number}","issue_comment_url":"https://api.github.com/repos/stevemao/react-monaco-editor/issues/comments{/number}","contents_url":"https://api.github.com/repos/stevemao/react-monaco-editor/contents/{+path}","compare_url":"https://api.github.com/repos/stevemao/react-monaco-editor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stevemao/react-monaco-editor/merges","archive_url":"https://api.github.com/repos/stevemao/react-monaco-editor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stevemao/react-monaco-editor/downloads","issues_url":"https://api.github.com/repos/stevemao/react-monaco-editor/issues{/number}","pulls_url":"https://api.github.com/repos/stevemao/react-monaco-editor/pulls{/number}","milestones_url":"https://api.github.com/repos/stevemao/react-monaco-editor/milestones{/number}","notifications_url":"https://api.github.com/repos/stevemao/react-monaco-editor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stevemao/react-monaco-editor/labels{/name}","releases_url":"https://api.github.com/repos/stevemao/react-monaco-editor/releases{/id}","deployments_url":"https://api.github.com/repos/stevemao/react-monaco-editor/deployments","created_at":"2018-11-16T00:42:22Z","updated_at":"2018-11-16T00:42:24Z","pushed_at":"2018-11-16T02:47:48Z","git_url":"git://github.com/stevemao/react-monaco-editor.git","ssh_url":"git@github.com:stevemao/react-monaco-editor.git","clone_url":"https://github.com/stevemao/react-monaco-editor.git","svn_url":"https://github.com/stevemao/react-monaco-editor","homepage":"","size":319,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"superRaytin:master","ref":"master","sha":"fab51f96a7e8e0172dea5f2f44ebc3cc3209c294","user":{"login":"superRaytin","id":2723376,"node_id":"MDQ6VXNlcjI3MjMzNzY=","avatar_url":"https://avatars3.githubusercontent.com/u/2723376?v=4","gravatar_id":"","url":"https://api.github.com/users/superRaytin","html_url":"https://github.com/superRaytin","followers_url":"https://api.github.com/users/superRaytin/followers","following_url":"https://api.github.com/users/superRaytin/following{/other_user}","gists_url":"https://api.github.com/users/superRaytin/gists{/gist_id}","starred_url":"https://api.github.com/users/superRaytin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superRaytin/subscriptions","organizations_url":"https://api.github.com/users/superRaytin/orgs","repos_url":"https://api.github.com/users/superRaytin/repos","events_url":"https://api.github.com/users/superRaytin/events{/privacy}","received_events_url":"https://api.github.com/users/superRaytin/received_events","type":"User","site_admin":false},"repo":{"id":67396709,"node_id":"MDEwOlJlcG9zaXRvcnk2NzM5NjcwOQ==","name":"react-monaco-editor","full_name":"superRaytin/react-monaco-editor","private":false,"owner":{"login":"superRaytin","id":2723376,"node_id":"MDQ6VXNlcjI3MjMzNzY=","avatar_url":"https://avatars3.githubusercontent.com/u/2723376?v=4","gravatar_id":"","url":"https://api.github.com/users/superRaytin","html_url":"https://github.com/superRaytin","followers_url":"https://api.github.com/users/superRaytin/followers","following_url":"https://api.github.com/users/superRaytin/following{/other_user}","gists_url":"https://api.github.com/users/superRaytin/gists{/gist_id}","starred_url":"https://api.github.com/users/superRaytin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superRaytin/subscriptions","organizations_url":"https://api.github.com/users/superRaytin/orgs","repos_url":"https://api.github.com/users/superRaytin/repos","events_url":"https://api.github.com/users/superRaytin/events{/privacy}","received_events_url":"https://api.github.com/users/superRaytin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/superRaytin/react-monaco-editor","description":"Monaco Editor for React.","fork":false,"url":"https://api.github.com/repos/superRaytin/react-monaco-editor","forks_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/forks","keys_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/teams","hooks_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/hooks","issue_events_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/issues/events{/number}","events_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/events","assignees_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/assignees{/user}","branches_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/branches{/branch}","tags_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/tags","blobs_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/git/refs{/sha}","trees_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/statuses/{sha}","languages_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/languages","stargazers_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/stargazers","contributors_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/contributors","subscribers_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/subscribers","subscription_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/subscription","commits_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/commits{/sha}","git_commits_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/git/commits{/sha}","comments_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/comments{/number}","issue_comment_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/issues/comments{/number}","contents_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/contents/{+path}","compare_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/merges","archive_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/downloads","issues_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/issues{/number}","pulls_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/pulls{/number}","milestones_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/milestones{/number}","notifications_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/labels{/name}","releases_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/releases{/id}","deployments_url":"https://api.github.com/repos/superRaytin/react-monaco-editor/deployments","created_at":"2016-09-05T07:11:05Z","updated_at":"2018-11-14T16:01:17Z","pushed_at":"2018-11-16T02:48:00Z","git_url":"git://github.com/superRaytin/react-monaco-editor.git","ssh_url":"git@github.com:superRaytin/react-monaco-editor.git","clone_url":"https://github.com/superRaytin/react-monaco-editor.git","svn_url":"https://github.com/superRaytin/react-monaco-editor","homepage":"","size":318,"stargazers_count":544,"watchers_count":544,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":117,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":117,"open_issues":21,"watchers":544,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/superRaytin/react-monaco-editor/pulls/162"},"html":{"href":"https://github.com/superRaytin/react-monaco-editor/pull/162"},"issue":{"href":"https://api.github.com/repos/superRaytin/react-monaco-editor/issues/162"},"comments":{"href":"https://api.github.com/repos/superRaytin/react-monaco-editor/issues/162/comments"},"review_comments":{"href":"https://api.github.com/repos/superRaytin/react-monaco-editor/pulls/162/comments"},"review_comment":{"href":"https://api.github.com/repos/superRaytin/react-monaco-editor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/superRaytin/react-monaco-editor/pulls/162/commits"},"statuses":{"href":"https://api.github.com/repos/superRaytin/react-monaco-editor/statuses/5d960b23e7413abd86025af9690462db2710565d"}},"author_association":"NONE"}}
{"actor":{"display_login":"domoritz"}}