{"action":"opened","number":20869,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/20869","id":176368843,"html_url":"https://github.com/apache/spark/pull/20869","diff_url":"https://github.com/apache/spark/pull/20869.diff","patch_url":"https://github.com/apache/spark/pull/20869.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/20869","number":20869,"state":"open","locked":false,"title":"Improve implicitNotFound message for Encoder","user":{"login":"ceedubs","id":977929,"avatar_url":"https://avatars0.githubusercontent.com/u/977929?v=4","gravatar_id":"","url":"https://api.github.com/users/ceedubs","html_url":"https://github.com/ceedubs","followers_url":"https://api.github.com/users/ceedubs/followers","following_url":"https://api.github.com/users/ceedubs/following{/other_user}","gists_url":"https://api.github.com/users/ceedubs/gists{/gist_id}","starred_url":"https://api.github.com/users/ceedubs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceedubs/subscriptions","organizations_url":"https://api.github.com/users/ceedubs/orgs","repos_url":"https://api.github.com/users/ceedubs/repos","events_url":"https://api.github.com/users/ceedubs/events{/privacy}","received_events_url":"https://api.github.com/users/ceedubs/received_events","type":"User","site_admin":false},"body":"The `implicitNotFound` message for `Encoder` doesn't mention the name of\r\nthe type for which it can't find an encoder. Furthermore, it covers up\r\nthe fact that `Encoder` is the name of the relevant type class.\r\nHopefully this new message provides a little more specific type detail\r\nwhile still giving the general message about which types are supported.\r\n\r\n## What changes were proposed in this pull request?\r\n\r\nAugment the existing message to mention that it's looking for an `Encoder` and what the type of the encoder is.\r\n\r\nFor example instead of:\r\n\r\n```\r\nUnable to find encoder for type stored in a Dataset.  Primitive types (Int, String, etc) and Product types (case classes) are supported by importing spark.implicits._  Support for serializing other types will be added in future releases.\r\n```\r\n\r\nreturn this message:\r\n\r\n```\r\nUnable to find encoder for type Exception. An implicit Encoder[Exception] is needed to store Exception instances in a Dataset. Primitive types (Int, String, etc) and Product types (ca\r\nse classes) are supported by importing spark.implicits._  Support for serializing other types will be added in future releases.\r\n```\r\n\r\n## How was this patch tested?\r\n\r\nIt was tested manually in the Scala REPL, since triggering this in a test would cause a compilation error.\r\n\r\n```\r\nscala> implicitly[Encoder[Exception]]                                                                                                                             \r\n<console>:51: error: Unable to find encoder for type Exception. An implicit Encoder[Exception] is needed to store Exception instances in a Dataset. Primitive types (Int, String, etc) and Product types (ca\r\nse classes) are supported by importing spark.implicits._  Support for serializing other types will be added in future releases.  \r\n       implicitly[Encoder[Exception]]                                                                                                  \r\n                 ^\r\n```\r\n","created_at":"2018-03-21T02:19:15Z","updated_at":"2018-03-21T02:19:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/20869/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/20869/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/20869/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/588dffc51df53bcbb885305e8ecd5bf39aa2e465","head":{"label":"ceedubs:encoder-implicit-msg","ref":"encoder-implicit-msg","sha":"588dffc51df53bcbb885305e8ecd5bf39aa2e465","user":{"login":"ceedubs","id":977929,"avatar_url":"https://avatars0.githubusercontent.com/u/977929?v=4","gravatar_id":"","url":"https://api.github.com/users/ceedubs","html_url":"https://github.com/ceedubs","followers_url":"https://api.github.com/users/ceedubs/followers","following_url":"https://api.github.com/users/ceedubs/following{/other_user}","gists_url":"https://api.github.com/users/ceedubs/gists{/gist_id}","starred_url":"https://api.github.com/users/ceedubs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceedubs/subscriptions","organizations_url":"https://api.github.com/users/ceedubs/orgs","repos_url":"https://api.github.com/users/ceedubs/repos","events_url":"https://api.github.com/users/ceedubs/events{/privacy}","received_events_url":"https://api.github.com/users/ceedubs/received_events","type":"User","site_admin":false},"repo":{"id":126103118,"name":"spark","full_name":"ceedubs/spark","owner":{"login":"ceedubs","id":977929,"avatar_url":"https://avatars0.githubusercontent.com/u/977929?v=4","gravatar_id":"","url":"https://api.github.com/users/ceedubs","html_url":"https://github.com/ceedubs","followers_url":"https://api.github.com/users/ceedubs/followers","following_url":"https://api.github.com/users/ceedubs/following{/other_user}","gists_url":"https://api.github.com/users/ceedubs/gists{/gist_id}","starred_url":"https://api.github.com/users/ceedubs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceedubs/subscriptions","organizations_url":"https://api.github.com/users/ceedubs/orgs","repos_url":"https://api.github.com/users/ceedubs/repos","events_url":"https://api.github.com/users/ceedubs/events{/privacy}","received_events_url":"https://api.github.com/users/ceedubs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ceedubs/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/ceedubs/spark","forks_url":"https://api.github.com/repos/ceedubs/spark/forks","keys_url":"https://api.github.com/repos/ceedubs/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceedubs/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceedubs/spark/teams","hooks_url":"https://api.github.com/repos/ceedubs/spark/hooks","issue_events_url":"https://api.github.com/repos/ceedubs/spark/issues/events{/number}","events_url":"https://api.github.com/repos/ceedubs/spark/events","assignees_url":"https://api.github.com/repos/ceedubs/spark/assignees{/user}","branches_url":"https://api.github.com/repos/ceedubs/spark/branches{/branch}","tags_url":"https://api.github.com/repos/ceedubs/spark/tags","blobs_url":"https://api.github.com/repos/ceedubs/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceedubs/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceedubs/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceedubs/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceedubs/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/ceedubs/spark/languages","stargazers_url":"https://api.github.com/repos/ceedubs/spark/stargazers","contributors_url":"https://api.github.com/repos/ceedubs/spark/contributors","subscribers_url":"https://api.github.com/repos/ceedubs/spark/subscribers","subscription_url":"https://api.github.com/repos/ceedubs/spark/subscription","commits_url":"https://api.github.com/repos/ceedubs/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceedubs/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceedubs/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceedubs/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceedubs/spark/contents/{+path}","compare_url":"https://api.github.com/repos/ceedubs/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceedubs/spark/merges","archive_url":"https://api.github.com/repos/ceedubs/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceedubs/spark/downloads","issues_url":"https://api.github.com/repos/ceedubs/spark/issues{/number}","pulls_url":"https://api.github.com/repos/ceedubs/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/ceedubs/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/ceedubs/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceedubs/spark/labels{/name}","releases_url":"https://api.github.com/repos/ceedubs/spark/releases{/id}","deployments_url":"https://api.github.com/repos/ceedubs/spark/deployments","created_at":"2018-03-21T01:04:53Z","updated_at":"2018-03-21T01:05:20Z","pushed_at":"2018-03-21T02:06:19Z","git_url":"git://github.com/ceedubs/spark.git","ssh_url":"git@github.com:ceedubs/spark.git","clone_url":"https://github.com/ceedubs/spark.git","svn_url":"https://github.com/ceedubs/spark","homepage":null,"size":269659,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"477d6bd7265e255fd43e53edda02019b32f29bb2","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2018-03-21T00:45:53Z","pushed_at":"2018-03-21T01:55:06Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":269659,"stargazers_count":16576,"watchers_count":16576,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15243,"mirror_url":null,"archived":false,"open_issues_count":479,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":15243,"open_issues":479,"watchers":16576,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/20869"},"html":{"href":"https://github.com/apache/spark/pull/20869"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/20869"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/20869/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/20869/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/20869/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/588dffc51df53bcbb885305e8ecd5bf39aa2e465"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":4,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"ceedubs"}}