{"action":"created","issue":{"url":"https://api.github.com/repos/nokia/moler/issues/13","repository_url":"https://api.github.com/repos/nokia/moler","labels_url":"https://api.github.com/repos/nokia/moler/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/nokia/moler/issues/13/comments","events_url":"https://api.github.com/repos/nokia/moler/issues/13/events","html_url":"https://github.com/nokia/moler/issues/13","id":345727677,"node_id":"MDU6SXNzdWUzNDU3Mjc2Nzc=","number":13,"title":"use six.string_types to check for strings","user":{"login":"greg-latuszek","id":16943593,"node_id":"MDQ6VXNlcjE2OTQzNTkz","avatar_url":"https://avatars2.githubusercontent.com/u/16943593?v=4","gravatar_id":"","url":"https://api.github.com/users/greg-latuszek","html_url":"https://github.com/greg-latuszek","followers_url":"https://api.github.com/users/greg-latuszek/followers","following_url":"https://api.github.com/users/greg-latuszek/following{/other_user}","gists_url":"https://api.github.com/users/greg-latuszek/gists{/gist_id}","starred_url":"https://api.github.com/users/greg-latuszek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg-latuszek/subscriptions","organizations_url":"https://api.github.com/users/greg-latuszek/orgs","repos_url":"https://api.github.com/users/greg-latuszek/repos","events_url":"https://api.github.com/users/greg-latuszek/events{/privacy}","received_events_url":"https://api.github.com/users/greg-latuszek/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"marcin-usielski","id":35992110,"node_id":"MDQ6VXNlcjM1OTkyMTEw","avatar_url":"https://avatars3.githubusercontent.com/u/35992110?v=4","gravatar_id":"","url":"https://api.github.com/users/marcin-usielski","html_url":"https://github.com/marcin-usielski","followers_url":"https://api.github.com/users/marcin-usielski/followers","following_url":"https://api.github.com/users/marcin-usielski/following{/other_user}","gists_url":"https://api.github.com/users/marcin-usielski/gists{/gist_id}","starred_url":"https://api.github.com/users/marcin-usielski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcin-usielski/subscriptions","organizations_url":"https://api.github.com/users/marcin-usielski/orgs","repos_url":"https://api.github.com/users/marcin-usielski/repos","events_url":"https://api.github.com/users/marcin-usielski/events{/privacy}","received_events_url":"https://api.github.com/users/marcin-usielski/received_events","type":"User","site_admin":false},"assignees":[{"login":"marcin-usielski","id":35992110,"node_id":"MDQ6VXNlcjM1OTkyMTEw","avatar_url":"https://avatars3.githubusercontent.com/u/35992110?v=4","gravatar_id":"","url":"https://api.github.com/users/marcin-usielski","html_url":"https://github.com/marcin-usielski","followers_url":"https://api.github.com/users/marcin-usielski/followers","following_url":"https://api.github.com/users/marcin-usielski/following{/other_user}","gists_url":"https://api.github.com/users/marcin-usielski/gists{/gist_id}","starred_url":"https://api.github.com/users/marcin-usielski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcin-usielski/subscriptions","organizations_url":"https://api.github.com/users/marcin-usielski/orgs","repos_url":"https://api.github.com/users/marcin-usielski/repos","events_url":"https://api.github.com/users/marcin-usielski/events{/privacy}","received_events_url":"https://api.github.com/users/marcin-usielski/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-07-30T12:00:04Z","updated_at":"2018-08-02T14:28:50Z","closed_at":null,"author_association":"COLLABORATOR","body":"@marcin-usielski see: https://github.com/nokia/moler/blob/master/moler/cmd/commandtextualgeneric.py#L60\r\n\r\ninstead of:\r\n```\r\n        if sys.version_info >= (3, 0):\r\n            if isinstance(prompt, str):\r\n                prompt = re.compile(prompt)\r\n        else:\r\n            if isinstance(prompt, basestring):\r\n                prompt = re.compile(prompt)\r\n```\r\nyou can write it simpler via:\r\n```\r\nimport six\r\n\r\n        if isinstance(prompt, six.string_types):\r\n            prompt = re.compile(prompt)\r\n```"},"comment":{"url":"https://api.github.com/repos/nokia/moler/issues/comments/409946353","html_url":"https://github.com/nokia/moler/issues/13#issuecomment-409946353","issue_url":"https://api.github.com/repos/nokia/moler/issues/13","id":409946353,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTk0NjM1Mw==","user":{"login":"greg-latuszek","id":16943593,"node_id":"MDQ6VXNlcjE2OTQzNTkz","avatar_url":"https://avatars2.githubusercontent.com/u/16943593?v=4","gravatar_id":"","url":"https://api.github.com/users/greg-latuszek","html_url":"https://github.com/greg-latuszek","followers_url":"https://api.github.com/users/greg-latuszek/followers","following_url":"https://api.github.com/users/greg-latuszek/following{/other_user}","gists_url":"https://api.github.com/users/greg-latuszek/gists{/gist_id}","starred_url":"https://api.github.com/users/greg-latuszek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg-latuszek/subscriptions","organizations_url":"https://api.github.com/users/greg-latuszek/orgs","repos_url":"https://api.github.com/users/greg-latuszek/repos","events_url":"https://api.github.com/users/greg-latuszek/events{/privacy}","received_events_url":"https://api.github.com/users/greg-latuszek/received_events","type":"User","site_admin":false},"created_at":"2018-08-02T14:28:50Z","updated_at":"2018-08-02T14:28:50Z","author_association":"COLLABORATOR","body":"We are already dependent - used inside connection, connection_observer, memory, runner\r\n\r\nand six is \"the most standard way\" to keep Py2-Py3 compatibility.\r\n\r\nand simplification is worth - if-s are hidden inside six library."}}
{"actor":{"display_login":"greg-latuszek"}}