{"action":"created","issue":{"url":"https://api.github.com/repos/cparaiso/form-builder/issues/11","repository_url":"https://api.github.com/repos/cparaiso/form-builder","labels_url":"https://api.github.com/repos/cparaiso/form-builder/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/cparaiso/form-builder/issues/11/comments","events_url":"https://api.github.com/repos/cparaiso/form-builder/issues/11/events","html_url":"https://github.com/cparaiso/form-builder/issues/11","id":338672386,"node_id":"MDU6SXNzdWUzMzg2NzIzODY=","number":11,"title":"Refactor properties on the custom element","user":{"login":"drewwills","id":1127174,"node_id":"MDQ6VXNlcjExMjcxNzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1127174?v=4","gravatar_id":"","url":"https://api.github.com/users/drewwills","html_url":"https://github.com/drewwills","followers_url":"https://api.github.com/users/drewwills/followers","following_url":"https://api.github.com/users/drewwills/following{/other_user}","gists_url":"https://api.github.com/users/drewwills/gists{/gist_id}","starred_url":"https://api.github.com/users/drewwills/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewwills/subscriptions","organizations_url":"https://api.github.com/users/drewwills/orgs","repos_url":"https://api.github.com/users/drewwills/repos","events_url":"https://api.github.com/users/drewwills/events{/privacy}","received_events_url":"https://api.github.com/users/drewwills/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-05T18:01:10Z","updated_at":"2018-07-05T22:47:30Z","closed_at":"2018-07-05T22:47:30Z","author_association":"CONTRIBUTOR","body":"Currently we have (to the best of my knowledge)...\r\n\r\n```\r\n            <form-builder\r\n              fbms-base-url=\"/fbms/api/v1/forms/\"\r\n              fbms-form-name=\"communication-preferences\"\r\n              response-url=\"/fbms/api/v1/responses/\"\r\n              oidc-url=\"/uPortal/api/v5-1/userinfo\">\r\n            </form-builder>\r\n```\r\n\r\nBetter would be (as far as I can see)...\r\n\r\n```\r\n            <form-builder\r\n              fbms-base-url=\"/fbms\"\r\n              fbms-form-fname=\"communication-preferences\"\r\n              oidc-url=\"/uPortal/api/v5-1/userinfo\">\r\n            </form-builder>\r\n```\r\n\r\nDifferences:\r\n  - `fbms-base-url` does not include the `/api/v1/forms/` path info (which can be hard-coded)\r\n  - `fbms-form-name` has been renamed to `fbms-form-fname`\r\n  - `response-url` is not required (b/c it can be infered from `fbms-base-url` just as easily as the `/forms/` endpoint)\r\n\r\n### Also Note\r\n\r\nThe URI for users' previous responses is `/fbms/api/v1/submissions`, not `/fbms/api/v1/responses`."},"comment":{"url":"https://api.github.com/repos/cparaiso/form-builder/issues/comments/402874230","html_url":"https://github.com/cparaiso/form-builder/issues/11#issuecomment-402874230","issue_url":"https://api.github.com/repos/cparaiso/form-builder/issues/11","id":402874230,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjg3NDIzMA==","user":{"login":"cparaiso","id":1245850,"node_id":"MDQ6VXNlcjEyNDU4NTA=","avatar_url":"https://avatars2.githubusercontent.com/u/1245850?v=4","gravatar_id":"","url":"https://api.github.com/users/cparaiso","html_url":"https://github.com/cparaiso","followers_url":"https://api.github.com/users/cparaiso/followers","following_url":"https://api.github.com/users/cparaiso/following{/other_user}","gists_url":"https://api.github.com/users/cparaiso/gists{/gist_id}","starred_url":"https://api.github.com/users/cparaiso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cparaiso/subscriptions","organizations_url":"https://api.github.com/users/cparaiso/orgs","repos_url":"https://api.github.com/users/cparaiso/repos","events_url":"https://api.github.com/users/cparaiso/events{/privacy}","received_events_url":"https://api.github.com/users/cparaiso/received_events","type":"User","site_admin":false},"created_at":"2018-07-05T22:47:30Z","updated_at":"2018-07-05T22:47:30Z","author_association":"OWNER","body":"response-url removed and now inferred based on fbms-base-url and fbms-form-fname. updated props/defaults."}}
{"actor":{"display_login":"cparaiso"}}