{"action":"created","comment":{"url":"https://api.github.com/repos/servo/servo/pulls/comments/216139657","pull_request_review_id":153563532,"id":216139657,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjEzOTY1Nw==","diff_hunk":"@@ -710,15 +763,28 @@ impl XMLHttpRequestMethods for XMLHttpRequest {\n             XMLHttpRequestState::Loading | XMLHttpRequestState::Done => return Err(Error::InvalidState),\n             _ => {},\n         }\n+        debug!(\"OverrideMimeType: {:?}\", mime);\n         // Step 2\n         let override_mime = mime.parse::<Mime>().map_err(|_| Error::Syntax)?;\n+        debug!(\"OverrideMimeType: {:?}\", override_mime);\n         // Step 3\n-        let mime_no_params = Mime(override_mime.clone().0, override_mime.clone().1, vec![]);\n+        let mime_str = override_mime.as_ref();\n+        debug!(\"mime_str: {:?}\", mime_str);\n+        let mime_parts: Vec<&str> = mime_str.split(\";\").collect();\n+        debug!(\"mime_parts: {:?}\", mime_parts);\n+        let mime_no_params = if mime_parts.len() > 1 {\n+            mime_parts[0].parse().unwrap()\n+        } else {\n+            override_mime.clone()\n+        };\n+        debug!(\"mime_no_params: {:?}\", mime_no_params);\n+\n         *self.override_mime_type.borrow_mut() = Some(mime_no_params);\n         // Step 4\n-        let value = override_mime.get_param(mime::Attr::Charset);\n+        let value = override_mime.get_param(mime::CHARSET);\n         *self.override_charset.borrow_mut() = value.and_then(|value| {\n-            Encoding::for_label(value.as_bytes())\n+            debug!(\"COUCOU: {:?}\", value);","path":"components/script/dom/xmlhttprequest.rs","position":270,"original_position":270,"commit_id":"e42914f1030f1a4302b2a7533dd460f3b58f8812","original_commit_id":"e42914f1030f1a4302b2a7533dd460f3b58f8812","user":{"login":"Eijebong","id":3650385,"node_id":"MDQ6VXNlcjM2NTAzODU=","avatar_url":"https://avatars2.githubusercontent.com/u/3650385?v=4","gravatar_id":"","url":"https://api.github.com/users/Eijebong","html_url":"https://github.com/Eijebong","followers_url":"https://api.github.com/users/Eijebong/followers","following_url":"https://api.github.com/users/Eijebong/following{/other_user}","gists_url":"https://api.github.com/users/Eijebong/gists{/gist_id}","starred_url":"https://api.github.com/users/Eijebong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eijebong/subscriptions","organizations_url":"https://api.github.com/users/Eijebong/orgs","repos_url":"https://api.github.com/users/Eijebong/repos","events_url":"https://api.github.com/users/Eijebong/events{/privacy}","received_events_url":"https://api.github.com/users/Eijebong/received_events","type":"User","site_admin":false},"body":"Coucou, Leftover debug","created_at":"2018-09-08T20:05:46Z","updated_at":"2018-09-08T20:07:00Z","html_url":"https://github.com/servo/servo/pull/21644#discussion_r216139657","pull_request_url":"https://api.github.com/repos/servo/servo/pulls/21644","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/comments/216139657"},"html":{"href":"https://github.com/servo/servo/pull/21644#discussion_r216139657"},"pull_request":{"href":"https://api.github.com/repos/servo/servo/pulls/21644"}}},"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/21644","id":214111589,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MTExNTg5","html_url":"https://github.com/servo/servo/pull/21644","diff_url":"https://github.com/servo/servo/pull/21644.diff","patch_url":"https://github.com/servo/servo/pull/21644.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/21644","number":21644,"state":"open","locked":false,"title":"WIP: Update hyper to 0.12","user":{"login":"Eijebong","id":3650385,"node_id":"MDQ6VXNlcjM2NTAzODU=","avatar_url":"https://avatars2.githubusercontent.com/u/3650385?v=4","gravatar_id":"","url":"https://api.github.com/users/Eijebong","html_url":"https://github.com/Eijebong","followers_url":"https://api.github.com/users/Eijebong/followers","following_url":"https://api.github.com/users/Eijebong/following{/other_user}","gists_url":"https://api.github.com/users/Eijebong/gists{/gist_id}","starred_url":"https://api.github.com/users/Eijebong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eijebong/subscriptions","organizations_url":"https://api.github.com/users/Eijebong/orgs","repos_url":"https://api.github.com/users/Eijebong/repos","events_url":"https://api.github.com/users/Eijebong/events{/privacy}","received_events_url":"https://api.github.com/users/Eijebong/received_events","type":"User","site_admin":false},"body":"Left to do:\r\n - Fix the influent::Client call\r\n - https://github.com/servo/webrender/pull/3034\r\n - https://github.com/hyperium/mime/pull/91\r\n - https://github.com/sfackler/typed-headers/pull/3 (still need a lot of work)\r\n - https://bugzilla.mozilla.org/show_bug.cgi?id=1489792\r\n - Merge and release the ws stuff (I'll do it once I know everything is ok)\r\n - Merge and release the influent stuff (Same here, I'll do it once I know everything is ok)\r\n - https://github.com/servo/servo/pull/21325\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/21644)\r\n<!-- Reviewable:end -->\r\n","created_at":"2018-09-08T19:49:30Z","updated_at":"2018-09-08T20:06:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"94518d8f1d1b18638733f15245fe5b0eb2f55d91","assignee":{"login":"ferjm","id":480202,"node_id":"MDQ6VXNlcjQ4MDIwMg==","avatar_url":"https://avatars0.githubusercontent.com/u/480202?v=4","gravatar_id":"","url":"https://api.github.com/users/ferjm","html_url":"https://github.com/ferjm","followers_url":"https://api.github.com/users/ferjm/followers","following_url":"https://api.github.com/users/ferjm/following{/other_user}","gists_url":"https://api.github.com/users/ferjm/gists{/gist_id}","starred_url":"https://api.github.com/users/ferjm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferjm/subscriptions","organizations_url":"https://api.github.com/users/ferjm/orgs","repos_url":"https://api.github.com/users/ferjm/repos","events_url":"https://api.github.com/users/ferjm/events{/privacy}","received_events_url":"https://api.github.com/users/ferjm/received_events","type":"User","site_admin":false},"assignees":[{"login":"ferjm","id":480202,"node_id":"MDQ6VXNlcjQ4MDIwMg==","avatar_url":"https://avatars0.githubusercontent.com/u/480202?v=4","gravatar_id":"","url":"https://api.github.com/users/ferjm","html_url":"https://github.com/ferjm","followers_url":"https://api.github.com/users/ferjm/followers","following_url":"https://api.github.com/users/ferjm/following{/other_user}","gists_url":"https://api.github.com/users/ferjm/gists{/gist_id}","starred_url":"https://api.github.com/users/ferjm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferjm/subscriptions","organizations_url":"https://api.github.com/users/ferjm/orgs","repos_url":"https://api.github.com/users/ferjm/repos","events_url":"https://api.github.com/users/ferjm/events{/privacy}","received_events_url":"https://api.github.com/users/ferjm/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":152310043,"node_id":"MDU6TGFiZWwxNTIzMTAwNDM=","url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-review","name":"S-awaiting-review","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/21644/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/21644/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/21644/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/e42914f1030f1a4302b2a7533dd460f3b58f8812","head":{"label":"Eijebong:hyperup","ref":"hyperup","sha":"e42914f1030f1a4302b2a7533dd460f3b58f8812","user":{"login":"Eijebong","id":3650385,"node_id":"MDQ6VXNlcjM2NTAzODU=","avatar_url":"https://avatars2.githubusercontent.com/u/3650385?v=4","gravatar_id":"","url":"https://api.github.com/users/Eijebong","html_url":"https://github.com/Eijebong","followers_url":"https://api.github.com/users/Eijebong/followers","following_url":"https://api.github.com/users/Eijebong/following{/other_user}","gists_url":"https://api.github.com/users/Eijebong/gists{/gist_id}","starred_url":"https://api.github.com/users/Eijebong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eijebong/subscriptions","organizations_url":"https://api.github.com/users/Eijebong/orgs","repos_url":"https://api.github.com/users/Eijebong/repos","events_url":"https://api.github.com/users/Eijebong/events{/privacy}","received_events_url":"https://api.github.com/users/Eijebong/received_events","type":"User","site_admin":false},"repo":{"id":92883614,"node_id":"MDEwOlJlcG9zaXRvcnk5Mjg4MzYxNA==","name":"servo","full_name":"Eijebong/servo","owner":{"login":"Eijebong","id":3650385,"node_id":"MDQ6VXNlcjM2NTAzODU=","avatar_url":"https://avatars2.githubusercontent.com/u/3650385?v=4","gravatar_id":"","url":"https://api.github.com/users/Eijebong","html_url":"https://github.com/Eijebong","followers_url":"https://api.github.com/users/Eijebong/followers","following_url":"https://api.github.com/users/Eijebong/following{/other_user}","gists_url":"https://api.github.com/users/Eijebong/gists{/gist_id}","starred_url":"https://api.github.com/users/Eijebong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eijebong/subscriptions","organizations_url":"https://api.github.com/users/Eijebong/orgs","repos_url":"https://api.github.com/users/Eijebong/repos","events_url":"https://api.github.com/users/Eijebong/events{/privacy}","received_events_url":"https://api.github.com/users/Eijebong/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Eijebong/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/Eijebong/servo","forks_url":"https://api.github.com/repos/Eijebong/servo/forks","keys_url":"https://api.github.com/repos/Eijebong/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Eijebong/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Eijebong/servo/teams","hooks_url":"https://api.github.com/repos/Eijebong/servo/hooks","issue_events_url":"https://api.github.com/repos/Eijebong/servo/issues/events{/number}","events_url":"https://api.github.com/repos/Eijebong/servo/events","assignees_url":"https://api.github.com/repos/Eijebong/servo/assignees{/user}","branches_url":"https://api.github.com/repos/Eijebong/servo/branches{/branch}","tags_url":"https://api.github.com/repos/Eijebong/servo/tags","blobs_url":"https://api.github.com/repos/Eijebong/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Eijebong/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Eijebong/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/Eijebong/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Eijebong/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/Eijebong/servo/languages","stargazers_url":"https://api.github.com/repos/Eijebong/servo/stargazers","contributors_url":"https://api.github.com/repos/Eijebong/servo/contributors","subscribers_url":"https://api.github.com/repos/Eijebong/servo/subscribers","subscription_url":"https://api.github.com/repos/Eijebong/servo/subscription","commits_url":"https://api.github.com/repos/Eijebong/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/Eijebong/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/Eijebong/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/Eijebong/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/Eijebong/servo/contents/{+path}","compare_url":"https://api.github.com/repos/Eijebong/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Eijebong/servo/merges","archive_url":"https://api.github.com/repos/Eijebong/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Eijebong/servo/downloads","issues_url":"https://api.github.com/repos/Eijebong/servo/issues{/number}","pulls_url":"https://api.github.com/repos/Eijebong/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/Eijebong/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/Eijebong/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Eijebong/servo/labels{/name}","releases_url":"https://api.github.com/repos/Eijebong/servo/releases{/id}","deployments_url":"https://api.github.com/repos/Eijebong/servo/deployments","created_at":"2017-05-30T23:04:29Z","updated_at":"2017-05-30T21:32:44Z","pushed_at":"2018-09-08T19:46:23Z","git_url":"git://github.com/Eijebong/servo.git","ssh_url":"git@github.com:Eijebong/servo.git","clone_url":"https://github.com/Eijebong/servo.git","svn_url":"https://github.com/Eijebong/servo","homepage":"https://servo.org/","size":440943,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"9c1c58a49873e6e9b015129527ee5b4d2e34e390","user":{"login":"servo","id":2566135,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NjYxMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/2566135?v=4","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"node_id":"MDEwOlJlcG9zaXRvcnkzMzkwMjQz","name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NjYxMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/2566135?v=4","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","deployments_url":"https://api.github.com/repos/servo/servo/deployments","created_at":"2012-02-08T19:07:25Z","updated_at":"2018-09-08T18:22:28Z","pushed_at":"2018-09-08T19:49:46Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"https://servo.org/","size":590214,"stargazers_count":12359,"watchers_count":12359,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1955,"mirror_url":null,"archived":false,"open_issues_count":2418,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":1955,"open_issues":2418,"watchers":12359,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/21644"},"html":{"href":"https://github.com/servo/servo/pull/21644"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/21644"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/21644/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/21644/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/21644/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/e42914f1030f1a4302b2a7533dd460f3b58f8812"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Eijebong"}}