{"action":"closed","number":4149,"pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/4149","id":239187248,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MTg3MjQ4","html_url":"https://github.com/codice/ddf/pull/4149","diff_url":"https://github.com/codice/ddf/pull/4149.diff","patch_url":"https://github.com/codice/ddf/pull/4149.patch","issue_url":"https://api.github.com/repos/codice/ddf/issues/4149","number":4149,"state":"closed","locked":false,"title":"DDF-4316: Fix race condition where landing page bundle starts before availability header is availabile","user":{"login":"tbatie","id":9013620,"node_id":"MDQ6VXNlcjkwMTM2MjA=","avatar_url":"https://avatars3.githubusercontent.com/u/9013620?v=4","gravatar_id":"","url":"https://api.github.com/users/tbatie","html_url":"https://github.com/tbatie","followers_url":"https://api.github.com/users/tbatie/followers","following_url":"https://api.github.com/users/tbatie/following{/other_user}","gists_url":"https://api.github.com/users/tbatie/gists{/gist_id}","starred_url":"https://api.github.com/users/tbatie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbatie/subscriptions","organizations_url":"https://api.github.com/users/tbatie/orgs","repos_url":"https://api.github.com/users/tbatie/repos","events_url":"https://api.github.com/users/tbatie/events{/privacy}","received_events_url":"https://api.github.com/users/tbatie/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\nMoves a landing page config to ddf-common instead of having it installed via features. Installing through a feature created a race condition where the landing page bundle could start before the configuration was set, resulting in bundle startup failure.\r\n \r\n#### Who is reviewing it? \r\n<!--(please choose AT LEAST two reviewers that need to approve the PR before it can get merged)-->\r\n@bellcc \r\n@ethantmanns \r\n@jhunzik \r\n\r\n#### Ask 2 committers to review/merge the PR and tag them here.\r\n@figliold \r\n@vinamartin\r\n\r\n#### How should this be tested?\r\nLanding page works as expected.\r\n\r\n#### Any background context you want to provide?\r\n\r\n#### What are the relevant tickets?\r\n[](https://codice.atlassian.net/browse/DDF-4316)\r\n\r\n#### Screenshots\r\n\r\n#### Checklist:\r\n- [ ] Documentation Updated\r\n- [ ] Update / Add Unit Tests\r\n- [ ] Update / Add Integration Tests\r\n\r\n#### Notes on Review Process\r\nPlease see [Notes on Review Process](https://codice.atlassian.net/wiki/spaces/DDF/pages/71946981/Pull+Request+Guidelines) for further guidance on requirements for merging and abbreviated reviews. \r\n\r\n#### Review Comment Legend:\r\n- ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist. \r\n- ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.\r\n- ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.\r\n","created_at":"2018-12-17T15:36:31Z","updated_at":"2018-12-18T17:10:07Z","closed_at":"2018-12-18T17:10:07Z","merged_at":"2018-12-18T17:10:07Z","merge_commit_sha":"7643812a95212957e6427389a266992d470e8be5","assignee":{"login":"djblue","id":1986211,"node_id":"MDQ6VXNlcjE5ODYyMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1986211?v=4","gravatar_id":"","url":"https://api.github.com/users/djblue","html_url":"https://github.com/djblue","followers_url":"https://api.github.com/users/djblue/followers","following_url":"https://api.github.com/users/djblue/following{/other_user}","gists_url":"https://api.github.com/users/djblue/gists{/gist_id}","starred_url":"https://api.github.com/users/djblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djblue/subscriptions","organizations_url":"https://api.github.com/users/djblue/orgs","repos_url":"https://api.github.com/users/djblue/repos","events_url":"https://api.github.com/users/djblue/events{/privacy}","received_events_url":"https://api.github.com/users/djblue/received_events","type":"User","site_admin":false},"assignees":[{"login":"djblue","id":1986211,"node_id":"MDQ6VXNlcjE5ODYyMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1986211?v=4","gravatar_id":"","url":"https://api.github.com/users/djblue","html_url":"https://github.com/djblue","followers_url":"https://api.github.com/users/djblue/followers","following_url":"https://api.github.com/users/djblue/following{/other_user}","gists_url":"https://api.github.com/users/djblue/gists{/gist_id}","starred_url":"https://api.github.com/users/djblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djblue/subscriptions","organizations_url":"https://api.github.com/users/djblue/orgs","repos_url":"https://api.github.com/users/djblue/repos","events_url":"https://api.github.com/users/djblue/events{/privacy}","received_events_url":"https://api.github.com/users/djblue/received_events","type":"User","site_admin":false},{"login":"vinamartin","id":9013407,"node_id":"MDQ6VXNlcjkwMTM0MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/9013407?v=4","gravatar_id":"","url":"https://api.github.com/users/vinamartin","html_url":"https://github.com/vinamartin","followers_url":"https://api.github.com/users/vinamartin/followers","following_url":"https://api.github.com/users/vinamartin/following{/other_user}","gists_url":"https://api.github.com/users/vinamartin/gists{/gist_id}","starred_url":"https://api.github.com/users/vinamartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinamartin/subscriptions","organizations_url":"https://api.github.com/users/vinamartin/orgs","repos_url":"https://api.github.com/users/vinamartin/repos","events_url":"https://api.github.com/users/vinamartin/events{/privacy}","received_events_url":"https://api.github.com/users/vinamartin/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"stustison","id":4391679,"node_id":"MDQ6VXNlcjQzOTE2Nzk=","avatar_url":"https://avatars0.githubusercontent.com/u/4391679?v=4","gravatar_id":"","url":"https://api.github.com/users/stustison","html_url":"https://github.com/stustison","followers_url":"https://api.github.com/users/stustison/followers","following_url":"https://api.github.com/users/stustison/following{/other_user}","gists_url":"https://api.github.com/users/stustison/gists{/gist_id}","starred_url":"https://api.github.com/users/stustison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stustison/subscriptions","organizations_url":"https://api.github.com/users/stustison/orgs","repos_url":"https://api.github.com/users/stustison/repos","events_url":"https://api.github.com/users/stustison/events{/privacy}","received_events_url":"https://api.github.com/users/stustison/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":70549482,"node_id":"MDU6TGFiZWw3MDU0OTQ4Mg==","url":"https://api.github.com/repos/codice/ddf/labels/%F0%9F%91%9EBug%20Fix","name":"👞Bug Fix","color":"8480fc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/codice/ddf/pulls/4149/commits","review_comments_url":"https://api.github.com/repos/codice/ddf/pulls/4149/comments","review_comment_url":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codice/ddf/issues/4149/comments","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/097d55e5247116041a03b70f5fbf536bdc8b6f69","head":{"label":"tbatie:landing-page-config-fix","ref":"landing-page-config-fix","sha":"097d55e5247116041a03b70f5fbf536bdc8b6f69","user":{"login":"tbatie","id":9013620,"node_id":"MDQ6VXNlcjkwMTM2MjA=","avatar_url":"https://avatars3.githubusercontent.com/u/9013620?v=4","gravatar_id":"","url":"https://api.github.com/users/tbatie","html_url":"https://github.com/tbatie","followers_url":"https://api.github.com/users/tbatie/followers","following_url":"https://api.github.com/users/tbatie/following{/other_user}","gists_url":"https://api.github.com/users/tbatie/gists{/gist_id}","starred_url":"https://api.github.com/users/tbatie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbatie/subscriptions","organizations_url":"https://api.github.com/users/tbatie/orgs","repos_url":"https://api.github.com/users/tbatie/repos","events_url":"https://api.github.com/users/tbatie/events{/privacy}","received_events_url":"https://api.github.com/users/tbatie/received_events","type":"User","site_admin":false},"repo":{"id":38900987,"node_id":"MDEwOlJlcG9zaXRvcnkzODkwMDk4Nw==","name":"ddf","full_name":"tbatie/ddf","private":false,"owner":{"login":"tbatie","id":9013620,"node_id":"MDQ6VXNlcjkwMTM2MjA=","avatar_url":"https://avatars3.githubusercontent.com/u/9013620?v=4","gravatar_id":"","url":"https://api.github.com/users/tbatie","html_url":"https://github.com/tbatie","followers_url":"https://api.github.com/users/tbatie/followers","following_url":"https://api.github.com/users/tbatie/following{/other_user}","gists_url":"https://api.github.com/users/tbatie/gists{/gist_id}","starred_url":"https://api.github.com/users/tbatie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbatie/subscriptions","organizations_url":"https://api.github.com/users/tbatie/orgs","repos_url":"https://api.github.com/users/tbatie/repos","events_url":"https://api.github.com/users/tbatie/events{/privacy}","received_events_url":"https://api.github.com/users/tbatie/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tbatie/ddf","description":"The Distributed Data Framework - Distribution, SDK, and Test","fork":true,"url":"https://api.github.com/repos/tbatie/ddf","forks_url":"https://api.github.com/repos/tbatie/ddf/forks","keys_url":"https://api.github.com/repos/tbatie/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tbatie/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tbatie/ddf/teams","hooks_url":"https://api.github.com/repos/tbatie/ddf/hooks","issue_events_url":"https://api.github.com/repos/tbatie/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/tbatie/ddf/events","assignees_url":"https://api.github.com/repos/tbatie/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/tbatie/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/tbatie/ddf/tags","blobs_url":"https://api.github.com/repos/tbatie/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tbatie/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tbatie/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/tbatie/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tbatie/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/tbatie/ddf/languages","stargazers_url":"https://api.github.com/repos/tbatie/ddf/stargazers","contributors_url":"https://api.github.com/repos/tbatie/ddf/contributors","subscribers_url":"https://api.github.com/repos/tbatie/ddf/subscribers","subscription_url":"https://api.github.com/repos/tbatie/ddf/subscription","commits_url":"https://api.github.com/repos/tbatie/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/tbatie/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/tbatie/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/tbatie/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/tbatie/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/tbatie/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tbatie/ddf/merges","archive_url":"https://api.github.com/repos/tbatie/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tbatie/ddf/downloads","issues_url":"https://api.github.com/repos/tbatie/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/tbatie/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/tbatie/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/tbatie/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tbatie/ddf/labels{/name}","releases_url":"https://api.github.com/repos/tbatie/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/tbatie/ddf/deployments","created_at":"2015-07-10T20:36:35Z","updated_at":"2016-04-06T16:24:17Z","pushed_at":"2018-12-18T00:20:26Z","git_url":"git://github.com/tbatie/ddf.git","ssh_url":"git@github.com:tbatie/ddf.git","clone_url":"https://github.com/tbatie/ddf.git","svn_url":"https://github.com/tbatie/ddf","homepage":"","size":213284,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codice:master","ref":"master","sha":"df2b2537bf32a0e613ea7801808b513b284132ba","user":{"login":"codice","id":2386734,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzODY3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2386734?v=4","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"repo":{"id":15173563,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE3MzU2Mw==","name":"ddf","full_name":"codice/ddf","private":false,"owner":{"login":"codice","id":2386734,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzODY3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2386734?v=4","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/codice/ddf","description":"DDF Distributed Data Framework - an open source, modular integration framework.","fork":false,"url":"https://api.github.com/repos/codice/ddf","forks_url":"https://api.github.com/repos/codice/ddf/forks","keys_url":"https://api.github.com/repos/codice/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codice/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codice/ddf/teams","hooks_url":"https://api.github.com/repos/codice/ddf/hooks","issue_events_url":"https://api.github.com/repos/codice/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/codice/ddf/events","assignees_url":"https://api.github.com/repos/codice/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/codice/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/codice/ddf/tags","blobs_url":"https://api.github.com/repos/codice/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codice/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codice/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/codice/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/codice/ddf/languages","stargazers_url":"https://api.github.com/repos/codice/ddf/stargazers","contributors_url":"https://api.github.com/repos/codice/ddf/contributors","subscribers_url":"https://api.github.com/repos/codice/ddf/subscribers","subscription_url":"https://api.github.com/repos/codice/ddf/subscription","commits_url":"https://api.github.com/repos/codice/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/codice/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/codice/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/codice/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/codice/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/codice/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codice/ddf/merges","archive_url":"https://api.github.com/repos/codice/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codice/ddf/downloads","issues_url":"https://api.github.com/repos/codice/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/codice/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/codice/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/codice/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codice/ddf/labels{/name}","releases_url":"https://api.github.com/repos/codice/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/codice/ddf/deployments","created_at":"2013-12-13T20:38:28Z","updated_at":"2018-12-18T16:36:24Z","pushed_at":"2018-12-18T17:10:07Z","git_url":"git://github.com/codice/ddf.git","ssh_url":"git@github.com:codice/ddf.git","clone_url":"https://github.com/codice/ddf.git","svn_url":"https://github.com/codice/ddf","homepage":"http://ddf.codice.org","size":415981,"stargazers_count":92,"watchers_count":92,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":158,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":158,"open_issues":33,"watchers":92,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/4149"},"html":{"href":"https://github.com/codice/ddf/pull/4149"},"issue":{"href":"https://api.github.com/repos/codice/ddf/issues/4149"},"comments":{"href":"https://api.github.com/repos/codice/ddf/issues/4149/comments"},"review_comments":{"href":"https://api.github.com/repos/codice/ddf/pulls/4149/comments"},"review_comment":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codice/ddf/pulls/4149/commits"},"statuses":{"href":"https://api.github.com/repos/codice/ddf/statuses/097d55e5247116041a03b70f5fbf536bdc8b6f69"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"tbatie","id":9013620,"node_id":"MDQ6VXNlcjkwMTM2MjA=","avatar_url":"https://avatars3.githubusercontent.com/u/9013620?v=4","gravatar_id":"","url":"https://api.github.com/users/tbatie","html_url":"https://github.com/tbatie","followers_url":"https://api.github.com/users/tbatie/followers","following_url":"https://api.github.com/users/tbatie/following{/other_user}","gists_url":"https://api.github.com/users/tbatie/gists{/gist_id}","starred_url":"https://api.github.com/users/tbatie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbatie/subscriptions","organizations_url":"https://api.github.com/users/tbatie/orgs","repos_url":"https://api.github.com/users/tbatie/repos","events_url":"https://api.github.com/users/tbatie/events{/privacy}","received_events_url":"https://api.github.com/users/tbatie/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":27,"changed_files":3}}
{"actor":{"display_login":"tbatie"}}