{"action":"created","comment":{"url":"https://api.github.com/repos/shopware/shopware/pulls/comments/208522035","pull_request_review_id":144345661,"id":208522035,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODUyMjAzNQ==","diff_hunk":"@@ -51,20 +51,24 @@ public function getListQuery($filter, $orderBy, $offset, $limit)\n      * Helper function to create the query builder for the \"getListQuery\" function.\n      * This function can be hooked to modify the query builder of the query object.\n      *\n-     * @param null $filter\n+     * @param null|array $filter\n      * @param null $orderBy\n      *\n      * @return \\Doctrine\\ORM\\QueryBuilder\n      */\n-    public function getListQueryBuilder($filter = null, $orderBy = null)\n+    public function getListQueryBuilder($filter = [], $orderBy = null)\n     {\n         $builder = $this->getEntityManager()->createQueryBuilder();\n         $builder->select(['form', 'attribute'])\n             ->from($this->getEntityName(), 'form')\n             ->leftJoin('form.attribute', 'attribute');\n-\n+        \n         $this->addFilter($builder, $filter);","path":"engine/Shopware/Models/Form/Repository.php","position":19,"original_position":19,"commit_id":"d5894987942789c44d8718c7aedb05187b8e3ae9","original_commit_id":"d5894987942789c44d8718c7aedb05187b8e3ae9","user":{"login":"shopwareBot","id":4725494,"node_id":"MDQ6VXNlcjQ3MjU0OTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4725494?v=4","gravatar_id":"","url":"https://api.github.com/users/shopwareBot","html_url":"https://github.com/shopwareBot","followers_url":"https://api.github.com/users/shopwareBot/followers","following_url":"https://api.github.com/users/shopwareBot/following{/other_user}","gists_url":"https://api.github.com/users/shopwareBot/gists{/gist_id}","starred_url":"https://api.github.com/users/shopwareBot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopwareBot/subscriptions","organizations_url":"https://api.github.com/users/shopwareBot/orgs","repos_url":"https://api.github.com/users/shopwareBot/repos","events_url":"https://api.github.com/users/shopwareBot/events{/privacy}","received_events_url":"https://api.github.com/users/shopwareBot/received_events","type":"User","site_admin":false},"body":"Can you add here also a if condition that the $filter is not null and keep the default value in the parameter.","created_at":"2018-08-08T09:52:08Z","updated_at":"2018-08-08T09:52:09Z","html_url":"https://github.com/shopware/shopware/pull/1742#discussion_r208522035","pull_request_url":"https://api.github.com/repos/shopware/shopware/pulls/1742","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/shopware/shopware/pulls/comments/208522035"},"html":{"href":"https://github.com/shopware/shopware/pull/1742#discussion_r208522035"},"pull_request":{"href":"https://api.github.com/repos/shopware/shopware/pulls/1742"}}},"pull_request":{"url":"https://api.github.com/repos/shopware/shopware/pulls/1742","id":206718717,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NzE4NzE3","html_url":"https://github.com/shopware/shopware/pull/1742","diff_url":"https://github.com/shopware/shopware/pull/1742.diff","patch_url":"https://github.com/shopware/shopware/pull/1742.patch","issue_url":"https://api.github.com/repos/shopware/shopware/issues/1742","number":1742,"state":"open","locked":false,"title":"Changed repository method params to be allowed to be emtpy","user":{"login":"Gugiman","id":5836639,"node_id":"MDQ6VXNlcjU4MzY2Mzk=","avatar_url":"https://avatars2.githubusercontent.com/u/5836639?v=4","gravatar_id":"","url":"https://api.github.com/users/Gugiman","html_url":"https://github.com/Gugiman","followers_url":"https://api.github.com/users/Gugiman/followers","following_url":"https://api.github.com/users/Gugiman/following{/other_user}","gists_url":"https://api.github.com/users/Gugiman/gists{/gist_id}","starred_url":"https://api.github.com/users/Gugiman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gugiman/subscriptions","organizations_url":"https://api.github.com/users/Gugiman/orgs","repos_url":"https://api.github.com/users/Gugiman/repos","events_url":"https://api.github.com/users/Gugiman/events{/privacy}","received_events_url":"https://api.github.com/users/Gugiman/received_events","type":"User","site_admin":false},"body":"getListQueryBuilder can't be called without optional params because of false type of the filter param which should be array\r\n\r\n### 1. Why is this change necessary?\r\nMethod can be called without parms to get all results\r\n\r\n### 2. What does this change do, exactly?\r\nChanged default value of optional param \r\n\r\n### 3. Describe each step to reproduce the issue or behaviour.\r\ncall getListQueryBuilder() without params\r\n\r\n### 4. Please link to the relevant issues (if any).\r\n\r\n\r\n### 5. Which documentation changes (if any) need to be made because of this PR?\r\nnone\r\n\r\n### 6. Checklist\r\n\r\n- [ ] I have written tests and verified that they fail without my change\r\n- [ ] I have squashed any insignificant commits\r\n- [x] This change has comments for package types, values, functions, and non-obvious lines of code\r\n- [x] I have read the contribution requirements and fulfil them.","created_at":"2018-08-07T14:31:13Z","updated_at":"2018-08-08T09:52:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a41e786cd49364b3477c40f68b752ebc663d8aa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/shopware/shopware/pulls/1742/commits","review_comments_url":"https://api.github.com/repos/shopware/shopware/pulls/1742/comments","review_comment_url":"https://api.github.com/repos/shopware/shopware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shopware/shopware/issues/1742/comments","statuses_url":"https://api.github.com/repos/shopware/shopware/statuses/d5894987942789c44d8718c7aedb05187b8e3ae9","head":{"label":"Gugiman:patch-11","ref":"patch-11","sha":"d5894987942789c44d8718c7aedb05187b8e3ae9","user":{"login":"Gugiman","id":5836639,"node_id":"MDQ6VXNlcjU4MzY2Mzk=","avatar_url":"https://avatars2.githubusercontent.com/u/5836639?v=4","gravatar_id":"","url":"https://api.github.com/users/Gugiman","html_url":"https://github.com/Gugiman","followers_url":"https://api.github.com/users/Gugiman/followers","following_url":"https://api.github.com/users/Gugiman/following{/other_user}","gists_url":"https://api.github.com/users/Gugiman/gists{/gist_id}","starred_url":"https://api.github.com/users/Gugiman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gugiman/subscriptions","organizations_url":"https://api.github.com/users/Gugiman/orgs","repos_url":"https://api.github.com/users/Gugiman/repos","events_url":"https://api.github.com/users/Gugiman/events{/privacy}","received_events_url":"https://api.github.com/users/Gugiman/received_events","type":"User","site_admin":false},"repo":{"id":55153930,"node_id":"MDEwOlJlcG9zaXRvcnk1NTE1MzkzMA==","name":"shopware","full_name":"Gugiman/shopware","owner":{"login":"Gugiman","id":5836639,"node_id":"MDQ6VXNlcjU4MzY2Mzk=","avatar_url":"https://avatars2.githubusercontent.com/u/5836639?v=4","gravatar_id":"","url":"https://api.github.com/users/Gugiman","html_url":"https://github.com/Gugiman","followers_url":"https://api.github.com/users/Gugiman/followers","following_url":"https://api.github.com/users/Gugiman/following{/other_user}","gists_url":"https://api.github.com/users/Gugiman/gists{/gist_id}","starred_url":"https://api.github.com/users/Gugiman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gugiman/subscriptions","organizations_url":"https://api.github.com/users/Gugiman/orgs","repos_url":"https://api.github.com/users/Gugiman/repos","events_url":"https://api.github.com/users/Gugiman/events{/privacy}","received_events_url":"https://api.github.com/users/Gugiman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Gugiman/shopware","description":"Shopware Repository","fork":true,"url":"https://api.github.com/repos/Gugiman/shopware","forks_url":"https://api.github.com/repos/Gugiman/shopware/forks","keys_url":"https://api.github.com/repos/Gugiman/shopware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Gugiman/shopware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Gugiman/shopware/teams","hooks_url":"https://api.github.com/repos/Gugiman/shopware/hooks","issue_events_url":"https://api.github.com/repos/Gugiman/shopware/issues/events{/number}","events_url":"https://api.github.com/repos/Gugiman/shopware/events","assignees_url":"https://api.github.com/repos/Gugiman/shopware/assignees{/user}","branches_url":"https://api.github.com/repos/Gugiman/shopware/branches{/branch}","tags_url":"https://api.github.com/repos/Gugiman/shopware/tags","blobs_url":"https://api.github.com/repos/Gugiman/shopware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Gugiman/shopware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Gugiman/shopware/git/refs{/sha}","trees_url":"https://api.github.com/repos/Gugiman/shopware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Gugiman/shopware/statuses/{sha}","languages_url":"https://api.github.com/repos/Gugiman/shopware/languages","stargazers_url":"https://api.github.com/repos/Gugiman/shopware/stargazers","contributors_url":"https://api.github.com/repos/Gugiman/shopware/contributors","subscribers_url":"https://api.github.com/repos/Gugiman/shopware/subscribers","subscription_url":"https://api.github.com/repos/Gugiman/shopware/subscription","commits_url":"https://api.github.com/repos/Gugiman/shopware/commits{/sha}","git_commits_url":"https://api.github.com/repos/Gugiman/shopware/git/commits{/sha}","comments_url":"https://api.github.com/repos/Gugiman/shopware/comments{/number}","issue_comment_url":"https://api.github.com/repos/Gugiman/shopware/issues/comments{/number}","contents_url":"https://api.github.com/repos/Gugiman/shopware/contents/{+path}","compare_url":"https://api.github.com/repos/Gugiman/shopware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Gugiman/shopware/merges","archive_url":"https://api.github.com/repos/Gugiman/shopware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Gugiman/shopware/downloads","issues_url":"https://api.github.com/repos/Gugiman/shopware/issues{/number}","pulls_url":"https://api.github.com/repos/Gugiman/shopware/pulls{/number}","milestones_url":"https://api.github.com/repos/Gugiman/shopware/milestones{/number}","notifications_url":"https://api.github.com/repos/Gugiman/shopware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Gugiman/shopware/labels{/name}","releases_url":"https://api.github.com/repos/Gugiman/shopware/releases{/id}","deployments_url":"https://api.github.com/repos/Gugiman/shopware/deployments","created_at":"2016-03-31T13:45:59Z","updated_at":"2016-03-31T13:46:18Z","pushed_at":"2018-08-07T14:28:42Z","git_url":"git://github.com/Gugiman/shopware.git","ssh_url":"git@github.com:Gugiman/shopware.git","clone_url":"https://github.com/Gugiman/shopware.git","svn_url":"https://github.com/Gugiman/shopware","homepage":"http://www.shopware.com","size":184391,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.1"}},"base":{"label":"shopware:5.5","ref":"5.5","sha":"9d081831ca3c284d2317913cf32e5baf4c2d60e5","user":{"login":"shopware","id":612628,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxMjYyOA==","avatar_url":"https://avatars2.githubusercontent.com/u/612628?v=4","gravatar_id":"","url":"https://api.github.com/users/shopware","html_url":"https://github.com/shopware","followers_url":"https://api.github.com/users/shopware/followers","following_url":"https://api.github.com/users/shopware/following{/other_user}","gists_url":"https://api.github.com/users/shopware/gists{/gist_id}","starred_url":"https://api.github.com/users/shopware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopware/subscriptions","organizations_url":"https://api.github.com/users/shopware/orgs","repos_url":"https://api.github.com/users/shopware/repos","events_url":"https://api.github.com/users/shopware/events{/privacy}","received_events_url":"https://api.github.com/users/shopware/received_events","type":"Organization","site_admin":false},"repo":{"id":5682970,"node_id":"MDEwOlJlcG9zaXRvcnk1NjgyOTcw","name":"shopware","full_name":"shopware/shopware","owner":{"login":"shopware","id":612628,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxMjYyOA==","avatar_url":"https://avatars2.githubusercontent.com/u/612628?v=4","gravatar_id":"","url":"https://api.github.com/users/shopware","html_url":"https://github.com/shopware","followers_url":"https://api.github.com/users/shopware/followers","following_url":"https://api.github.com/users/shopware/following{/other_user}","gists_url":"https://api.github.com/users/shopware/gists{/gist_id}","starred_url":"https://api.github.com/users/shopware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopware/subscriptions","organizations_url":"https://api.github.com/users/shopware/orgs","repos_url":"https://api.github.com/users/shopware/repos","events_url":"https://api.github.com/users/shopware/events{/privacy}","received_events_url":"https://api.github.com/users/shopware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shopware/shopware","description":"Shopware Repository","fork":false,"url":"https://api.github.com/repos/shopware/shopware","forks_url":"https://api.github.com/repos/shopware/shopware/forks","keys_url":"https://api.github.com/repos/shopware/shopware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shopware/shopware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shopware/shopware/teams","hooks_url":"https://api.github.com/repos/shopware/shopware/hooks","issue_events_url":"https://api.github.com/repos/shopware/shopware/issues/events{/number}","events_url":"https://api.github.com/repos/shopware/shopware/events","assignees_url":"https://api.github.com/repos/shopware/shopware/assignees{/user}","branches_url":"https://api.github.com/repos/shopware/shopware/branches{/branch}","tags_url":"https://api.github.com/repos/shopware/shopware/tags","blobs_url":"https://api.github.com/repos/shopware/shopware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shopware/shopware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shopware/shopware/git/refs{/sha}","trees_url":"https://api.github.com/repos/shopware/shopware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shopware/shopware/statuses/{sha}","languages_url":"https://api.github.com/repos/shopware/shopware/languages","stargazers_url":"https://api.github.com/repos/shopware/shopware/stargazers","contributors_url":"https://api.github.com/repos/shopware/shopware/contributors","subscribers_url":"https://api.github.com/repos/shopware/shopware/subscribers","subscription_url":"https://api.github.com/repos/shopware/shopware/subscription","commits_url":"https://api.github.com/repos/shopware/shopware/commits{/sha}","git_commits_url":"https://api.github.com/repos/shopware/shopware/git/commits{/sha}","comments_url":"https://api.github.com/repos/shopware/shopware/comments{/number}","issue_comment_url":"https://api.github.com/repos/shopware/shopware/issues/comments{/number}","contents_url":"https://api.github.com/repos/shopware/shopware/contents/{+path}","compare_url":"https://api.github.com/repos/shopware/shopware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shopware/shopware/merges","archive_url":"https://api.github.com/repos/shopware/shopware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shopware/shopware/downloads","issues_url":"https://api.github.com/repos/shopware/shopware/issues{/number}","pulls_url":"https://api.github.com/repos/shopware/shopware/pulls{/number}","milestones_url":"https://api.github.com/repos/shopware/shopware/milestones{/number}","notifications_url":"https://api.github.com/repos/shopware/shopware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shopware/shopware/labels{/name}","releases_url":"https://api.github.com/repos/shopware/shopware/releases{/id}","deployments_url":"https://api.github.com/repos/shopware/shopware/deployments","created_at":"2012-09-05T05:32:50Z","updated_at":"2018-08-06T19:02:47Z","pushed_at":"2018-08-08T07:24:57Z","git_url":"git://github.com/shopware/shopware.git","ssh_url":"git@github.com:shopware/shopware.git","clone_url":"https://github.com/shopware/shopware.git","svn_url":"https://github.com/shopware/shopware","homepage":"http://www.shopware.com","size":215044,"stargazers_count":888,"watchers_count":888,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":633,"mirror_url":null,"archived":false,"open_issues_count":236,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":633,"open_issues":236,"watchers":888,"default_branch":"5.4"}},"_links":{"self":{"href":"https://api.github.com/repos/shopware/shopware/pulls/1742"},"html":{"href":"https://github.com/shopware/shopware/pull/1742"},"issue":{"href":"https://api.github.com/repos/shopware/shopware/issues/1742"},"comments":{"href":"https://api.github.com/repos/shopware/shopware/issues/1742/comments"},"review_comments":{"href":"https://api.github.com/repos/shopware/shopware/pulls/1742/comments"},"review_comment":{"href":"https://api.github.com/repos/shopware/shopware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shopware/shopware/pulls/1742/commits"},"statuses":{"href":"https://api.github.com/repos/shopware/shopware/statuses/d5894987942789c44d8718c7aedb05187b8e3ae9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"shopwareBot"}}