{"action":"created","issue":{"url":"https://api.github.com/repos/dart-lang/build/issues/1793","repository_url":"https://api.github.com/repos/dart-lang/build","labels_url":"https://api.github.com/repos/dart-lang/build/issues/1793/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/build/issues/1793/comments","events_url":"https://api.github.com/repos/dart-lang/build/issues/1793/events","html_url":"https://github.com/dart-lang/build/pull/1793","id":354392412,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMTY1MzE0","number":1793,"title":"Adds support for config specific imports","user":{"login":"jakemac53","id":984921,"node_id":"MDQ6VXNlcjk4NDkyMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/984921?v=4","gravatar_id":"","url":"https://api.github.com/users/jakemac53","html_url":"https://github.com/jakemac53","followers_url":"https://api.github.com/users/jakemac53/followers","following_url":"https://api.github.com/users/jakemac53/following{/other_user}","gists_url":"https://api.github.com/users/jakemac53/gists{/gist_id}","starred_url":"https://api.github.com/users/jakemac53/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakemac53/subscriptions","organizations_url":"https://api.github.com/users/jakemac53/orgs","repos_url":"https://api.github.com/users/jakemac53/repos","events_url":"https://api.github.com/users/jakemac53/events{/privacy}","received_events_url":"https://api.github.com/users/jakemac53/received_events","type":"User","site_admin":false},"labels":[{"id":421017987,"node_id":"MDU6TGFiZWw0MjEwMTc5ODc=","url":"https://api.github.com/repos/dart-lang/build/labels/cla:%20yes","name":"cla: yes","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-08-27T16:44:42Z","updated_at":"2018-08-28T17:32:15Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/dart-lang/build/pulls/1793","html_url":"https://github.com/dart-lang/build/pull/1793","diff_url":"https://github.com/dart-lang/build/pull/1793.diff","patch_url":"https://github.com/dart-lang/build/pull/1793.patch"},"body":"Most of the changes are to the build_modules package, and there is now a separate set of module files per platform.\r\n\r\n- Each platform is set up with a builder in the build_modules package - but they are not applied by default. Any new platforms should also be configured in the build_modules package.\r\n- Individual compiler packages (or other consumers of modules) must apply the module builder for the platforms they care about, using `applies_builders` config.\r\n\r\ncc @pulyaevskiy the build_node_compilers package will need an update as well - see the build_web_compilers package updates here."},"comment":{"url":"https://api.github.com/repos/dart-lang/build/issues/comments/416673838","html_url":"https://github.com/dart-lang/build/pull/1793#issuecomment-416673838","issue_url":"https://api.github.com/repos/dart-lang/build/issues/1793","id":416673838,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjY3MzgzOA==","user":{"login":"vsmenon","id":2119553,"node_id":"MDQ6VXNlcjIxMTk1NTM=","avatar_url":"https://avatars0.githubusercontent.com/u/2119553?v=4","gravatar_id":"","url":"https://api.github.com/users/vsmenon","html_url":"https://github.com/vsmenon","followers_url":"https://api.github.com/users/vsmenon/followers","following_url":"https://api.github.com/users/vsmenon/following{/other_user}","gists_url":"https://api.github.com/users/vsmenon/gists{/gist_id}","starred_url":"https://api.github.com/users/vsmenon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsmenon/subscriptions","organizations_url":"https://api.github.com/users/vsmenon/orgs","repos_url":"https://api.github.com/users/vsmenon/repos","events_url":"https://api.github.com/users/vsmenon/events{/privacy}","received_events_url":"https://api.github.com/users/vsmenon/received_events","type":"User","site_admin":false},"created_at":"2018-08-28T17:32:15Z","updated_at":"2018-08-28T17:32:15Z","author_association":"MEMBER","body":"> can we expect stability in inclusion/exclusion of dart.library.* for each platform throughout the lifetime of Dart 2.x?\r\n\r\n@natebosch Yes, I think so.  We're not making breaking changes in 2.x here - and removing would clearly be breaking.  We *might* consider new libraries / platform.\r\n\r\nWe're hardcoding what's true and false in DDC today."}}
{"actor":{"display_login":"vsmenon"}}