{"action":"closed","number":33,"pull_request":{"url":"https://api.github.com/repos/c4urself/bump2version/pulls/33","id":210627632,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNjI3NjMy","html_url":"https://github.com/c4urself/bump2version/pull/33","diff_url":"https://github.com/c4urself/bump2version/pull/33.diff","patch_url":"https://github.com/c4urself/bump2version/pull/33.patch","issue_url":"https://api.github.com/repos/c4urself/bump2version/issues/33","number":33,"state":"closed","locked":false,"title":"Windows behavior fixed, with appveyor tests passing","user":{"login":"jeremycarroll","id":549519,"node_id":"MDQ6VXNlcjU0OTUxOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/549519?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremycarroll","html_url":"https://github.com/jeremycarroll","followers_url":"https://api.github.com/users/jeremycarroll/followers","following_url":"https://api.github.com/users/jeremycarroll/following{/other_user}","gists_url":"https://api.github.com/users/jeremycarroll/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremycarroll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremycarroll/subscriptions","organizations_url":"https://api.github.com/users/jeremycarroll/orgs","repos_url":"https://api.github.com/users/jeremycarroll/repos","events_url":"https://api.github.com/users/jeremycarroll/events{/privacy}","received_events_url":"https://api.github.com/users/jeremycarroll/received_events","type":"User","site_admin":false},"body":"This PR fixes issues on the Windows platform, particularly python2, revealed in the appveyor test failures.\r\nIn particular, encoding when making external calls with `subprocess` was usually incorrect.\r\n\r\nTwo specific changes on py2:\r\n- use strings not unicode to add to the environment before making `subprocess` calls\r\n- encode any non-ascii command line arguments (particularly `→`) in utf-8 before making the call.\r\n\r\nA third change for both py2 and py3 is to change the file operations to text mode rather than binary mode, which simplifies handling of encoding.\r\n\r\nIn the tests, two further issues were addressed:\r\n- incorrect handling when `hg` (or presumably `git`) is absent (this issue was not visible on appveyor, but locally to me)\r\n- `test_usage_string_fork` changed to not explicit encode, and to use byte strings instead; xfailing in the most difficult case to fix: Windows on py3.\r\n\r\nNB: I don't have a windows machine, so I am entirely reliant on appveyor for above analysis","created_at":"2018-08-24T03:06:14Z","updated_at":"2018-08-27T02:58:26Z","closed_at":"2018-08-27T02:58:26Z","merged_at":null,"merge_commit_sha":"99c128be4af9742fcbd2db98f4b54efb58e48359","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/c4urself/bump2version/pulls/33/commits","review_comments_url":"https://api.github.com/repos/c4urself/bump2version/pulls/33/comments","review_comment_url":"https://api.github.com/repos/c4urself/bump2version/pulls/comments{/number}","comments_url":"https://api.github.com/repos/c4urself/bump2version/issues/33/comments","statuses_url":"https://api.github.com/repos/c4urself/bump2version/statuses/8379713543556138c433d6c11d6fa707c75da76d","head":{"label":"jeremycarroll:appveyor-fixes","ref":"appveyor-fixes","sha":"8379713543556138c433d6c11d6fa707c75da76d","user":{"login":"jeremycarroll","id":549519,"node_id":"MDQ6VXNlcjU0OTUxOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/549519?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremycarroll","html_url":"https://github.com/jeremycarroll","followers_url":"https://api.github.com/users/jeremycarroll/followers","following_url":"https://api.github.com/users/jeremycarroll/following{/other_user}","gists_url":"https://api.github.com/users/jeremycarroll/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremycarroll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremycarroll/subscriptions","organizations_url":"https://api.github.com/users/jeremycarroll/orgs","repos_url":"https://api.github.com/users/jeremycarroll/repos","events_url":"https://api.github.com/users/jeremycarroll/events{/privacy}","received_events_url":"https://api.github.com/users/jeremycarroll/received_events","type":"User","site_admin":false},"repo":{"id":145223489,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUyMjM0ODk=","name":"bump2version","full_name":"jeremycarroll/bump2version","owner":{"login":"jeremycarroll","id":549519,"node_id":"MDQ6VXNlcjU0OTUxOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/549519?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremycarroll","html_url":"https://github.com/jeremycarroll","followers_url":"https://api.github.com/users/jeremycarroll/followers","following_url":"https://api.github.com/users/jeremycarroll/following{/other_user}","gists_url":"https://api.github.com/users/jeremycarroll/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremycarroll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremycarroll/subscriptions","organizations_url":"https://api.github.com/users/jeremycarroll/orgs","repos_url":"https://api.github.com/users/jeremycarroll/repos","events_url":"https://api.github.com/users/jeremycarroll/events{/privacy}","received_events_url":"https://api.github.com/users/jeremycarroll/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeremycarroll/bump2version","description":"Version-bump your software with a single command","fork":true,"url":"https://api.github.com/repos/jeremycarroll/bump2version","forks_url":"https://api.github.com/repos/jeremycarroll/bump2version/forks","keys_url":"https://api.github.com/repos/jeremycarroll/bump2version/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeremycarroll/bump2version/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeremycarroll/bump2version/teams","hooks_url":"https://api.github.com/repos/jeremycarroll/bump2version/hooks","issue_events_url":"https://api.github.com/repos/jeremycarroll/bump2version/issues/events{/number}","events_url":"https://api.github.com/repos/jeremycarroll/bump2version/events","assignees_url":"https://api.github.com/repos/jeremycarroll/bump2version/assignees{/user}","branches_url":"https://api.github.com/repos/jeremycarroll/bump2version/branches{/branch}","tags_url":"https://api.github.com/repos/jeremycarroll/bump2version/tags","blobs_url":"https://api.github.com/repos/jeremycarroll/bump2version/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeremycarroll/bump2version/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeremycarroll/bump2version/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeremycarroll/bump2version/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeremycarroll/bump2version/statuses/{sha}","languages_url":"https://api.github.com/repos/jeremycarroll/bump2version/languages","stargazers_url":"https://api.github.com/repos/jeremycarroll/bump2version/stargazers","contributors_url":"https://api.github.com/repos/jeremycarroll/bump2version/contributors","subscribers_url":"https://api.github.com/repos/jeremycarroll/bump2version/subscribers","subscription_url":"https://api.github.com/repos/jeremycarroll/bump2version/subscription","commits_url":"https://api.github.com/repos/jeremycarroll/bump2version/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeremycarroll/bump2version/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeremycarroll/bump2version/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeremycarroll/bump2version/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeremycarroll/bump2version/contents/{+path}","compare_url":"https://api.github.com/repos/jeremycarroll/bump2version/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeremycarroll/bump2version/merges","archive_url":"https://api.github.com/repos/jeremycarroll/bump2version/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeremycarroll/bump2version/downloads","issues_url":"https://api.github.com/repos/jeremycarroll/bump2version/issues{/number}","pulls_url":"https://api.github.com/repos/jeremycarroll/bump2version/pulls{/number}","milestones_url":"https://api.github.com/repos/jeremycarroll/bump2version/milestones{/number}","notifications_url":"https://api.github.com/repos/jeremycarroll/bump2version/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeremycarroll/bump2version/labels{/name}","releases_url":"https://api.github.com/repos/jeremycarroll/bump2version/releases{/id}","deployments_url":"https://api.github.com/repos/jeremycarroll/bump2version/deployments","created_at":"2018-08-18T13:46:42Z","updated_at":"2018-08-18T13:46:44Z","pushed_at":"2018-08-27T02:49:39Z","git_url":"git://github.com/jeremycarroll/bump2version.git","ssh_url":"git@github.com:jeremycarroll/bump2version.git","clone_url":"https://github.com/jeremycarroll/bump2version.git","svn_url":"https://github.com/jeremycarroll/bump2version","homepage":"https://pypi.python.org/pypi/bump2version","size":450,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"c4urself:master","ref":"master","sha":"4fe77840f9daaaecaf8367002699b3a516d00a4f","user":{"login":"c4urself","id":391030,"node_id":"MDQ6VXNlcjM5MTAzMA==","avatar_url":"https://avatars3.githubusercontent.com/u/391030?v=4","gravatar_id":"","url":"https://api.github.com/users/c4urself","html_url":"https://github.com/c4urself","followers_url":"https://api.github.com/users/c4urself/followers","following_url":"https://api.github.com/users/c4urself/following{/other_user}","gists_url":"https://api.github.com/users/c4urself/gists{/gist_id}","starred_url":"https://api.github.com/users/c4urself/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c4urself/subscriptions","organizations_url":"https://api.github.com/users/c4urself/orgs","repos_url":"https://api.github.com/users/c4urself/repos","events_url":"https://api.github.com/users/c4urself/events{/privacy}","received_events_url":"https://api.github.com/users/c4urself/received_events","type":"User","site_admin":false},"repo":{"id":86366332,"node_id":"MDEwOlJlcG9zaXRvcnk4NjM2NjMzMg==","name":"bump2version","full_name":"c4urself/bump2version","owner":{"login":"c4urself","id":391030,"node_id":"MDQ6VXNlcjM5MTAzMA==","avatar_url":"https://avatars3.githubusercontent.com/u/391030?v=4","gravatar_id":"","url":"https://api.github.com/users/c4urself","html_url":"https://github.com/c4urself","followers_url":"https://api.github.com/users/c4urself/followers","following_url":"https://api.github.com/users/c4urself/following{/other_user}","gists_url":"https://api.github.com/users/c4urself/gists{/gist_id}","starred_url":"https://api.github.com/users/c4urself/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c4urself/subscriptions","organizations_url":"https://api.github.com/users/c4urself/orgs","repos_url":"https://api.github.com/users/c4urself/repos","events_url":"https://api.github.com/users/c4urself/events{/privacy}","received_events_url":"https://api.github.com/users/c4urself/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/c4urself/bump2version","description":"Version-bump your software with a single command","fork":true,"url":"https://api.github.com/repos/c4urself/bump2version","forks_url":"https://api.github.com/repos/c4urself/bump2version/forks","keys_url":"https://api.github.com/repos/c4urself/bump2version/keys{/key_id}","collaborators_url":"https://api.github.com/repos/c4urself/bump2version/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/c4urself/bump2version/teams","hooks_url":"https://api.github.com/repos/c4urself/bump2version/hooks","issue_events_url":"https://api.github.com/repos/c4urself/bump2version/issues/events{/number}","events_url":"https://api.github.com/repos/c4urself/bump2version/events","assignees_url":"https://api.github.com/repos/c4urself/bump2version/assignees{/user}","branches_url":"https://api.github.com/repos/c4urself/bump2version/branches{/branch}","tags_url":"https://api.github.com/repos/c4urself/bump2version/tags","blobs_url":"https://api.github.com/repos/c4urself/bump2version/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/c4urself/bump2version/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/c4urself/bump2version/git/refs{/sha}","trees_url":"https://api.github.com/repos/c4urself/bump2version/git/trees{/sha}","statuses_url":"https://api.github.com/repos/c4urself/bump2version/statuses/{sha}","languages_url":"https://api.github.com/repos/c4urself/bump2version/languages","stargazers_url":"https://api.github.com/repos/c4urself/bump2version/stargazers","contributors_url":"https://api.github.com/repos/c4urself/bump2version/contributors","subscribers_url":"https://api.github.com/repos/c4urself/bump2version/subscribers","subscription_url":"https://api.github.com/repos/c4urself/bump2version/subscription","commits_url":"https://api.github.com/repos/c4urself/bump2version/commits{/sha}","git_commits_url":"https://api.github.com/repos/c4urself/bump2version/git/commits{/sha}","comments_url":"https://api.github.com/repos/c4urself/bump2version/comments{/number}","issue_comment_url":"https://api.github.com/repos/c4urself/bump2version/issues/comments{/number}","contents_url":"https://api.github.com/repos/c4urself/bump2version/contents/{+path}","compare_url":"https://api.github.com/repos/c4urself/bump2version/compare/{base}...{head}","merges_url":"https://api.github.com/repos/c4urself/bump2version/merges","archive_url":"https://api.github.com/repos/c4urself/bump2version/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/c4urself/bump2version/downloads","issues_url":"https://api.github.com/repos/c4urself/bump2version/issues{/number}","pulls_url":"https://api.github.com/repos/c4urself/bump2version/pulls{/number}","milestones_url":"https://api.github.com/repos/c4urself/bump2version/milestones{/number}","notifications_url":"https://api.github.com/repos/c4urself/bump2version/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/c4urself/bump2version/labels{/name}","releases_url":"https://api.github.com/repos/c4urself/bump2version/releases{/id}","deployments_url":"https://api.github.com/repos/c4urself/bump2version/deployments","created_at":"2017-03-27T17:48:58Z","updated_at":"2018-08-24T14:30:53Z","pushed_at":"2018-08-27T02:50:01Z","git_url":"git://github.com/c4urself/bump2version.git","ssh_url":"git@github.com:c4urself/bump2version.git","clone_url":"https://github.com/c4urself/bump2version.git","svn_url":"https://github.com/c4urself/bump2version","homepage":"https://pypi.python.org/pypi/bump2version","size":417,"stargazers_count":45,"watchers_count":45,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":15,"open_issues":14,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/c4urself/bump2version/pulls/33"},"html":{"href":"https://github.com/c4urself/bump2version/pull/33"},"issue":{"href":"https://api.github.com/repos/c4urself/bump2version/issues/33"},"comments":{"href":"https://api.github.com/repos/c4urself/bump2version/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/c4urself/bump2version/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/c4urself/bump2version/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/c4urself/bump2version/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/c4urself/bump2version/statuses/8379713543556138c433d6c11d6fa707c75da76d"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":2,"maintainer_can_modify":false,"commits":21,"additions":53,"deletions":30,"changed_files":3}}
{"actor":{"display_login":"jeremycarroll"}}