{"action":"created","issue":{"url":"https://api.github.com/repos/intermine/intermine/issues/1907","repository_url":"https://api.github.com/repos/intermine/intermine","labels_url":"https://api.github.com/repos/intermine/intermine/issues/1907/labels{/name}","comments_url":"https://api.github.com/repos/intermine/intermine/issues/1907/comments","events_url":"https://api.github.com/repos/intermine/intermine/issues/1907/events","html_url":"https://github.com/intermine/intermine/pull/1907","id":369007586,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMDQ4MDEx","number":1907,"title":"Versioned postprocesses","user":{"login":"julie-sullivan","id":1663057,"node_id":"MDQ6VXNlcjE2NjMwNTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1663057?v=4","gravatar_id":"","url":"https://api.github.com/users/julie-sullivan","html_url":"https://github.com/julie-sullivan","followers_url":"https://api.github.com/users/julie-sullivan/followers","following_url":"https://api.github.com/users/julie-sullivan/following{/other_user}","gists_url":"https://api.github.com/users/julie-sullivan/gists{/gist_id}","starred_url":"https://api.github.com/users/julie-sullivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julie-sullivan/subscriptions","organizations_url":"https://api.github.com/users/julie-sullivan/orgs","repos_url":"https://api.github.com/users/julie-sullivan/repos","events_url":"https://api.github.com/users/julie-sullivan/events{/privacy}","received_events_url":"https://api.github.com/users/julie-sullivan/received_events","type":"User","site_admin":false},"labels":[{"id":8223558,"node_id":"MDU6TGFiZWw4MjIzNTU4","url":"https://api.github.com/repos/intermine/intermine/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":{"login":"julie-sullivan","id":1663057,"node_id":"MDQ6VXNlcjE2NjMwNTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1663057?v=4","gravatar_id":"","url":"https://api.github.com/users/julie-sullivan","html_url":"https://github.com/julie-sullivan","followers_url":"https://api.github.com/users/julie-sullivan/followers","following_url":"https://api.github.com/users/julie-sullivan/following{/other_user}","gists_url":"https://api.github.com/users/julie-sullivan/gists{/gist_id}","starred_url":"https://api.github.com/users/julie-sullivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julie-sullivan/subscriptions","organizations_url":"https://api.github.com/users/julie-sullivan/orgs","repos_url":"https://api.github.com/users/julie-sullivan/repos","events_url":"https://api.github.com/users/julie-sullivan/events{/privacy}","received_events_url":"https://api.github.com/users/julie-sullivan/received_events","type":"User","site_admin":false},"assignees":[{"login":"julie-sullivan","id":1663057,"node_id":"MDQ6VXNlcjE2NjMwNTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1663057?v=4","gravatar_id":"","url":"https://api.github.com/users/julie-sullivan","html_url":"https://github.com/julie-sullivan","followers_url":"https://api.github.com/users/julie-sullivan/followers","following_url":"https://api.github.com/users/julie-sullivan/following{/other_user}","gists_url":"https://api.github.com/users/julie-sullivan/gists{/gist_id}","starred_url":"https://api.github.com/users/julie-sullivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julie-sullivan/subscriptions","organizations_url":"https://api.github.com/users/julie-sullivan/orgs","repos_url":"https://api.github.com/users/julie-sullivan/repos","events_url":"https://api.github.com/users/julie-sullivan/events{/privacy}","received_events_url":"https://api.github.com/users/julie-sullivan/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-10-11T08:28:25Z","updated_at":"2018-10-11T08:57:46Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/intermine/intermine/pulls/1907","html_url":"https://github.com/intermine/intermine/pull/1907","diff_url":"https://github.com/intermine/intermine/pull/1907.diff","patch_url":"https://github.com/intermine/intermine/pull/1907.patch"},"body":"## Details\r\n\r\nUsers need to be able to version their sources. I did this in #1899. However I missed two things:\r\n\r\n* Postprocesses need to be versioned in the same way\r\n* Generating the keys file to use also puts bio-sources on the classpath and needs to use the custom version. I don't know how I missed that in the original commit? \r\n\r\n## Testing\r\n\r\n* Versioning sources works with and without a version specified in project XML file\r\n* Versioning postprocesses works with and without a version specified in project XML file\r\n\r\nI don't know how I missed the keys thing, so please be sure to clean. However, I am pretty sure I _did_ do a clean. The code worked on FlyMine and locally but NOT in HumanMine. Don't know why. \r\n\r\n## Checklist\r\n\r\nBefore your pull request can be approved, be sure to check all boxes:\r\n\r\n- [ ] Passing unit test for new or updated code (if applicable)\r\n- [ ] Passes all tests – according to Travis\r\n- [ ] Documentation (if applicable)\r\n- [ ] Single purpose\r\n- [ ] Detailed commit messages\r\n- [ ] Well commented code\r\n- [ ] Checkstyle\r\n\r\n(I haven't done documentation yet)"},"comment":{"url":"https://api.github.com/repos/intermine/intermine/issues/comments/428876615","html_url":"https://github.com/intermine/intermine/pull/1907#issuecomment-428876615","issue_url":"https://api.github.com/repos/intermine/intermine/issues/1907","id":428876615,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODg3NjYxNQ==","user":{"login":"julie-sullivan","id":1663057,"node_id":"MDQ6VXNlcjE2NjMwNTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1663057?v=4","gravatar_id":"","url":"https://api.github.com/users/julie-sullivan","html_url":"https://github.com/julie-sullivan","followers_url":"https://api.github.com/users/julie-sullivan/followers","following_url":"https://api.github.com/users/julie-sullivan/following{/other_user}","gists_url":"https://api.github.com/users/julie-sullivan/gists{/gist_id}","starred_url":"https://api.github.com/users/julie-sullivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julie-sullivan/subscriptions","organizations_url":"https://api.github.com/users/julie-sullivan/orgs","repos_url":"https://api.github.com/users/julie-sullivan/repos","events_url":"https://api.github.com/users/julie-sullivan/events{/privacy}","received_events_url":"https://api.github.com/users/julie-sullivan/received_events","type":"User","site_admin":false},"created_at":"2018-10-11T08:57:46Z","updated_at":"2018-10-11T08:57:46Z","author_association":"MEMBER","body":"Sorry, closing and reopening against the dev branch"}}
{"actor":{"display_login":"julie-sullivan"}}