{"action":"created","comment":{"url":"https://api.github.com/repos/STScI-JWST/jwst/pulls/comments/195534518","pull_request_review_id":128924385,"id":195534518,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTUzNDUxOA==","diff_hunk":"@@ -65,6 +66,8 @@ def process(self, input):\n             # Get the MSA metadata file if needed and add to reffiles\n             msa_metadata_file = input_model.meta.instrument.msa_metadata_file\n             if msa_metadata_file is not None:\n+                if isinstance(input, str):","path":"jwst/assign_wcs/assign_wcs_step.py","position":10,"original_position":10,"commit_id":"b204834a4900385e2544c1d781f083783df5590b","original_commit_id":"b204834a4900385e2544c1d781f083783df5590b","user":{"login":"nden","id":1110361,"node_id":"MDQ6VXNlcjExMTAzNjE=","avatar_url":"https://avatars2.githubusercontent.com/u/1110361?v=4","gravatar_id":"","url":"https://api.github.com/users/nden","html_url":"https://github.com/nden","followers_url":"https://api.github.com/users/nden/followers","following_url":"https://api.github.com/users/nden/following{/other_user}","gists_url":"https://api.github.com/users/nden/gists{/gist_id}","starred_url":"https://api.github.com/users/nden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nden/subscriptions","organizations_url":"https://api.github.com/users/nden/orgs","repos_url":"https://api.github.com/users/nden/repos","events_url":"https://api.github.com/users/nden/events{/privacy}","received_events_url":"https://api.github.com/users/nden/received_events","type":"User","site_admin":false},"body":"Given that #2157 now implements a setter for step.input_dir, I think this is all I need.","created_at":"2018-06-14T18:53:41Z","updated_at":"2018-06-14T18:53:42Z","html_url":"https://github.com/STScI-JWST/jwst/pull/2108#discussion_r195534518","pull_request_url":"https://api.github.com/repos/STScI-JWST/jwst/pulls/2108","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/STScI-JWST/jwst/pulls/comments/195534518"},"html":{"href":"https://github.com/STScI-JWST/jwst/pull/2108#discussion_r195534518"},"pull_request":{"href":"https://api.github.com/repos/STScI-JWST/jwst/pulls/2108"}},"in_reply_to_id":195530901},"pull_request":{"url":"https://api.github.com/repos/STScI-JWST/jwst/pulls/2108","id":191820818,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxODIwODE4","html_url":"https://github.com/STScI-JWST/jwst/pull/2108","diff_url":"https://github.com/STScI-JWST/jwst/pull/2108.diff","patch_url":"https://github.com/STScI-JWST/jwst/pull/2108.patch","issue_url":"https://api.github.com/repos/STScI-JWST/jwst/issues/2108","number":2108,"state":"open","locked":false,"title":"step.input_dir from step.process()","user":{"login":"nden","id":1110361,"node_id":"MDQ6VXNlcjExMTAzNjE=","avatar_url":"https://avatars2.githubusercontent.com/u/1110361?v=4","gravatar_id":"","url":"https://api.github.com/users/nden","html_url":"https://github.com/nden","followers_url":"https://api.github.com/users/nden/followers","following_url":"https://api.github.com/users/nden/following{/other_user}","gists_url":"https://api.github.com/users/nden/gists{/gist_id}","starred_url":"https://api.github.com/users/nden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nden/subscriptions","organizations_url":"https://api.github.com/users/nden/orgs","repos_url":"https://api.github.com/users/nden/repos","events_url":"https://api.github.com/users/nden/events{/privacy}","received_events_url":"https://api.github.com/users/nden/received_events","type":"User","site_admin":false},"body":"`Step.input_dir` is not set when the step is run in an interactive session using `Step.process(input)`.\r\nThis PR fixes the immediate issue by calling `_set_input_dir` within `assign_wcs.process`.\r\n\r\nConsider making `step._set_input_dir` public.","created_at":"2018-05-31T17:20:21Z","updated_at":"2018-06-14T18:53:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4feee83be00803f00ce2a4d76fc55b307a645770","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":390242343,"node_id":"MDU6TGFiZWwzOTAyNDIzNDM=","url":"https://api.github.com/repos/STScI-JWST/jwst/labels/assign_wcs","name":"assign_wcs","color":"0e8a16","default":false},{"id":390243892,"node_id":"MDU6TGFiZWwzOTAyNDM4OTI=","url":"https://api.github.com/repos/STScI-JWST/jwst/labels/stpipe","name":"stpipe","color":"b60205","default":false}],"milestone":{"url":"https://api.github.com/repos/STScI-JWST/jwst/milestones/8","html_url":"https://github.com/STScI-JWST/jwst/milestone/8","labels_url":"https://api.github.com/repos/STScI-JWST/jwst/milestones/8/labels","id":3349568,"node_id":"MDk6TWlsZXN0b25lMzM0OTU2OA==","number":8,"title":"0.10.0","description":"Cal & CRDS development due 27-Jul-2018.   This is not associated with any deliveries but an intermediate step towards Build 7.2.  Focus for this milestone is Time Series Observations and Spectral Resampling. ","creator":{"login":"stscicrawford","id":36652656,"node_id":"MDQ6VXNlcjM2NjUyNjU2","avatar_url":"https://avatars3.githubusercontent.com/u/36652656?v=4","gravatar_id":"","url":"https://api.github.com/users/stscicrawford","html_url":"https://github.com/stscicrawford","followers_url":"https://api.github.com/users/stscicrawford/followers","following_url":"https://api.github.com/users/stscicrawford/following{/other_user}","gists_url":"https://api.github.com/users/stscicrawford/gists{/gist_id}","starred_url":"https://api.github.com/users/stscicrawford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stscicrawford/subscriptions","organizations_url":"https://api.github.com/users/stscicrawford/orgs","repos_url":"https://api.github.com/users/stscicrawford/repos","events_url":"https://api.github.com/users/stscicrawford/events{/privacy}","received_events_url":"https://api.github.com/users/stscicrawford/received_events","type":"User","site_admin":false},"open_issues":47,"closed_issues":11,"state":"open","created_at":"2018-05-15T18:15:34Z","updated_at":"2018-06-14T18:24:00Z","due_on":"2018-07-27T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/STScI-JWST/jwst/pulls/2108/commits","review_comments_url":"https://api.github.com/repos/STScI-JWST/jwst/pulls/2108/comments","review_comment_url":"https://api.github.com/repos/STScI-JWST/jwst/pulls/comments{/number}","comments_url":"https://api.github.com/repos/STScI-JWST/jwst/issues/2108/comments","statuses_url":"https://api.github.com/repos/STScI-JWST/jwst/statuses/b204834a4900385e2544c1d781f083783df5590b","head":{"label":"nden:input-dir-from-process","ref":"input-dir-from-process","sha":"b204834a4900385e2544c1d781f083783df5590b","user":{"login":"nden","id":1110361,"node_id":"MDQ6VXNlcjExMTAzNjE=","avatar_url":"https://avatars2.githubusercontent.com/u/1110361?v=4","gravatar_id":"","url":"https://api.github.com/users/nden","html_url":"https://github.com/nden","followers_url":"https://api.github.com/users/nden/followers","following_url":"https://api.github.com/users/nden/following{/other_user}","gists_url":"https://api.github.com/users/nden/gists{/gist_id}","starred_url":"https://api.github.com/users/nden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nden/subscriptions","organizations_url":"https://api.github.com/users/nden/orgs","repos_url":"https://api.github.com/users/nden/repos","events_url":"https://api.github.com/users/nden/events{/privacy}","received_events_url":"https://api.github.com/users/nden/received_events","type":"User","site_admin":false},"repo":{"id":60785193,"node_id":"MDEwOlJlcG9zaXRvcnk2MDc4NTE5Mw==","name":"jwst","full_name":"nden/jwst","owner":{"login":"nden","id":1110361,"node_id":"MDQ6VXNlcjExMTAzNjE=","avatar_url":"https://avatars2.githubusercontent.com/u/1110361?v=4","gravatar_id":"","url":"https://api.github.com/users/nden","html_url":"https://github.com/nden","followers_url":"https://api.github.com/users/nden/followers","following_url":"https://api.github.com/users/nden/following{/other_user}","gists_url":"https://api.github.com/users/nden/gists{/gist_id}","starred_url":"https://api.github.com/users/nden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nden/subscriptions","organizations_url":"https://api.github.com/users/nden/orgs","repos_url":"https://api.github.com/users/nden/repos","events_url":"https://api.github.com/users/nden/events{/privacy}","received_events_url":"https://api.github.com/users/nden/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nden/jwst","description":null,"fork":true,"url":"https://api.github.com/repos/nden/jwst","forks_url":"https://api.github.com/repos/nden/jwst/forks","keys_url":"https://api.github.com/repos/nden/jwst/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nden/jwst/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nden/jwst/teams","hooks_url":"https://api.github.com/repos/nden/jwst/hooks","issue_events_url":"https://api.github.com/repos/nden/jwst/issues/events{/number}","events_url":"https://api.github.com/repos/nden/jwst/events","assignees_url":"https://api.github.com/repos/nden/jwst/assignees{/user}","branches_url":"https://api.github.com/repos/nden/jwst/branches{/branch}","tags_url":"https://api.github.com/repos/nden/jwst/tags","blobs_url":"https://api.github.com/repos/nden/jwst/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nden/jwst/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nden/jwst/git/refs{/sha}","trees_url":"https://api.github.com/repos/nden/jwst/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nden/jwst/statuses/{sha}","languages_url":"https://api.github.com/repos/nden/jwst/languages","stargazers_url":"https://api.github.com/repos/nden/jwst/stargazers","contributors_url":"https://api.github.com/repos/nden/jwst/contributors","subscribers_url":"https://api.github.com/repos/nden/jwst/subscribers","subscription_url":"https://api.github.com/repos/nden/jwst/subscription","commits_url":"https://api.github.com/repos/nden/jwst/commits{/sha}","git_commits_url":"https://api.github.com/repos/nden/jwst/git/commits{/sha}","comments_url":"https://api.github.com/repos/nden/jwst/comments{/number}","issue_comment_url":"https://api.github.com/repos/nden/jwst/issues/comments{/number}","contents_url":"https://api.github.com/repos/nden/jwst/contents/{+path}","compare_url":"https://api.github.com/repos/nden/jwst/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nden/jwst/merges","archive_url":"https://api.github.com/repos/nden/jwst/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nden/jwst/downloads","issues_url":"https://api.github.com/repos/nden/jwst/issues{/number}","pulls_url":"https://api.github.com/repos/nden/jwst/pulls{/number}","milestones_url":"https://api.github.com/repos/nden/jwst/milestones{/number}","notifications_url":"https://api.github.com/repos/nden/jwst/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nden/jwst/labels{/name}","releases_url":"https://api.github.com/repos/nden/jwst/releases{/id}","deployments_url":"https://api.github.com/repos/nden/jwst/deployments","created_at":"2016-06-09T15:24:24Z","updated_at":"2016-06-09T15:24:26Z","pushed_at":"2018-06-14T18:22:19Z","git_url":"git://github.com/nden/jwst.git","ssh_url":"git@github.com:nden/jwst.git","clone_url":"https://github.com/nden/jwst.git","svn_url":"https://github.com/nden/jwst","homepage":null,"size":67689,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"STScI-JWST:master","ref":"master","sha":"36b4cf97f408bee442ac164e371cf51e133aeefc","user":{"login":"STScI-JWST","id":17731768,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzMxNzY4","avatar_url":"https://avatars0.githubusercontent.com/u/17731768?v=4","gravatar_id":"","url":"https://api.github.com/users/STScI-JWST","html_url":"https://github.com/STScI-JWST","followers_url":"https://api.github.com/users/STScI-JWST/followers","following_url":"https://api.github.com/users/STScI-JWST/following{/other_user}","gists_url":"https://api.github.com/users/STScI-JWST/gists{/gist_id}","starred_url":"https://api.github.com/users/STScI-JWST/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STScI-JWST/subscriptions","organizations_url":"https://api.github.com/users/STScI-JWST/orgs","repos_url":"https://api.github.com/users/STScI-JWST/repos","events_url":"https://api.github.com/users/STScI-JWST/events{/privacy}","received_events_url":"https://api.github.com/users/STScI-JWST/received_events","type":"Organization","site_admin":false},"repo":{"id":60551519,"node_id":"MDEwOlJlcG9zaXRvcnk2MDU1MTUxOQ==","name":"jwst","full_name":"STScI-JWST/jwst","owner":{"login":"STScI-JWST","id":17731768,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzMxNzY4","avatar_url":"https://avatars0.githubusercontent.com/u/17731768?v=4","gravatar_id":"","url":"https://api.github.com/users/STScI-JWST","html_url":"https://github.com/STScI-JWST","followers_url":"https://api.github.com/users/STScI-JWST/followers","following_url":"https://api.github.com/users/STScI-JWST/following{/other_user}","gists_url":"https://api.github.com/users/STScI-JWST/gists{/gist_id}","starred_url":"https://api.github.com/users/STScI-JWST/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STScI-JWST/subscriptions","organizations_url":"https://api.github.com/users/STScI-JWST/orgs","repos_url":"https://api.github.com/users/STScI-JWST/repos","events_url":"https://api.github.com/users/STScI-JWST/events{/privacy}","received_events_url":"https://api.github.com/users/STScI-JWST/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/STScI-JWST/jwst","description":"JWST Calibration Pipeline","fork":false,"url":"https://api.github.com/repos/STScI-JWST/jwst","forks_url":"https://api.github.com/repos/STScI-JWST/jwst/forks","keys_url":"https://api.github.com/repos/STScI-JWST/jwst/keys{/key_id}","collaborators_url":"https://api.github.com/repos/STScI-JWST/jwst/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/STScI-JWST/jwst/teams","hooks_url":"https://api.github.com/repos/STScI-JWST/jwst/hooks","issue_events_url":"https://api.github.com/repos/STScI-JWST/jwst/issues/events{/number}","events_url":"https://api.github.com/repos/STScI-JWST/jwst/events","assignees_url":"https://api.github.com/repos/STScI-JWST/jwst/assignees{/user}","branches_url":"https://api.github.com/repos/STScI-JWST/jwst/branches{/branch}","tags_url":"https://api.github.com/repos/STScI-JWST/jwst/tags","blobs_url":"https://api.github.com/repos/STScI-JWST/jwst/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/STScI-JWST/jwst/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/STScI-JWST/jwst/git/refs{/sha}","trees_url":"https://api.github.com/repos/STScI-JWST/jwst/git/trees{/sha}","statuses_url":"https://api.github.com/repos/STScI-JWST/jwst/statuses/{sha}","languages_url":"https://api.github.com/repos/STScI-JWST/jwst/languages","stargazers_url":"https://api.github.com/repos/STScI-JWST/jwst/stargazers","contributors_url":"https://api.github.com/repos/STScI-JWST/jwst/contributors","subscribers_url":"https://api.github.com/repos/STScI-JWST/jwst/subscribers","subscription_url":"https://api.github.com/repos/STScI-JWST/jwst/subscription","commits_url":"https://api.github.com/repos/STScI-JWST/jwst/commits{/sha}","git_commits_url":"https://api.github.com/repos/STScI-JWST/jwst/git/commits{/sha}","comments_url":"https://api.github.com/repos/STScI-JWST/jwst/comments{/number}","issue_comment_url":"https://api.github.com/repos/STScI-JWST/jwst/issues/comments{/number}","contents_url":"https://api.github.com/repos/STScI-JWST/jwst/contents/{+path}","compare_url":"https://api.github.com/repos/STScI-JWST/jwst/compare/{base}...{head}","merges_url":"https://api.github.com/repos/STScI-JWST/jwst/merges","archive_url":"https://api.github.com/repos/STScI-JWST/jwst/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/STScI-JWST/jwst/downloads","issues_url":"https://api.github.com/repos/STScI-JWST/jwst/issues{/number}","pulls_url":"https://api.github.com/repos/STScI-JWST/jwst/pulls{/number}","milestones_url":"https://api.github.com/repos/STScI-JWST/jwst/milestones{/number}","notifications_url":"https://api.github.com/repos/STScI-JWST/jwst/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/STScI-JWST/jwst/labels{/name}","releases_url":"https://api.github.com/repos/STScI-JWST/jwst/releases{/id}","deployments_url":"https://api.github.com/repos/STScI-JWST/jwst/deployments","created_at":"2016-06-06T18:34:23Z","updated_at":"2018-06-14T16:12:18Z","pushed_at":"2018-06-14T18:24:01Z","git_url":"git://github.com/STScI-JWST/jwst.git","ssh_url":"git@github.com:STScI-JWST/jwst.git","clone_url":"https://github.com/STScI-JWST/jwst.git","svn_url":"https://github.com/STScI-JWST/jwst","homepage":"https://jwst-pipeline.readthedocs.io/en/latest/","size":67702,"stargazers_count":44,"watchers_count":44,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":212,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":40,"open_issues":212,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/STScI-JWST/jwst/pulls/2108"},"html":{"href":"https://github.com/STScI-JWST/jwst/pull/2108"},"issue":{"href":"https://api.github.com/repos/STScI-JWST/jwst/issues/2108"},"comments":{"href":"https://api.github.com/repos/STScI-JWST/jwst/issues/2108/comments"},"review_comments":{"href":"https://api.github.com/repos/STScI-JWST/jwst/pulls/2108/comments"},"review_comment":{"href":"https://api.github.com/repos/STScI-JWST/jwst/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/STScI-JWST/jwst/pulls/2108/commits"},"statuses":{"href":"https://api.github.com/repos/STScI-JWST/jwst/statuses/b204834a4900385e2544c1d781f083783df5590b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nden"}}