{"action":"created","comment":{"url":"https://api.github.com/repos/saltstack/salt/pulls/comments/190754674","pull_request_review_id":123201826,"id":190754674,"diff_hunk":"@@ -494,6 +561,31 @@ def _sunos_memdata():\n     return grains\n \n \n+def _aix_memdata():\n+    '''\n+    Return the memory information for AIX systems\n+    '''\n+    grains = {'mem_total': 0, 'swap_total': 0}\n+\n+    prtconf = '/usr/sbin/prtconf 2>/dev/null'","path":"salt/grains/core.py","position":null,"original_position":84,"commit_id":"463ebac9c8e7355403c31beb1903ceba17eb6a4e","original_commit_id":"e14d9062afe0286ede7d2f265fc4cba95b090ce7","user":{"login":"dmurphy18","id":9943204,"avatar_url":"https://avatars2.githubusercontent.com/u/9943204?v=4","gravatar_id":"","url":"https://api.github.com/users/dmurphy18","html_url":"https://github.com/dmurphy18","followers_url":"https://api.github.com/users/dmurphy18/followers","following_url":"https://api.github.com/users/dmurphy18/following{/other_user}","gists_url":"https://api.github.com/users/dmurphy18/gists{/gist_id}","starred_url":"https://api.github.com/users/dmurphy18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmurphy18/subscriptions","organizations_url":"https://api.github.com/users/dmurphy18/orgs","repos_url":"https://api.github.com/users/dmurphy18/repos","events_url":"https://api.github.com/users/dmurphy18/events{/privacy}","received_events_url":"https://api.github.com/users/dmurphy18/received_events","type":"User","site_admin":false},"body":"Revised to use salt.utils.path.which, which attempts to use decorator for which caused issues in the loader, see approx line 734 /salt/loader.py, problem with decorator requiring an argument.","created_at":"2018-05-24T23:07:15Z","updated_at":"2018-05-24T23:07:15Z","html_url":"https://github.com/saltstack/salt/pull/47808#discussion_r190754674","pull_request_url":"https://api.github.com/repos/saltstack/salt/pulls/47808","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments/190754674"},"html":{"href":"https://github.com/saltstack/salt/pull/47808#discussion_r190754674"},"pull_request":{"href":"https://api.github.com/repos/saltstack/salt/pulls/47808"}},"in_reply_to_id":190506840},"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/47808","id":190065001,"html_url":"https://github.com/saltstack/salt/pull/47808","diff_url":"https://github.com/saltstack/salt/pull/47808.diff","patch_url":"https://github.com/saltstack/salt/pull/47808.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/47808","number":47808,"state":"open","locked":false,"title":"Updated AIX support for grains reported","user":{"login":"dmurphy18","id":9943204,"avatar_url":"https://avatars2.githubusercontent.com/u/9943204?v=4","gravatar_id":"","url":"https://api.github.com/users/dmurphy18","html_url":"https://github.com/dmurphy18","followers_url":"https://api.github.com/users/dmurphy18/followers","following_url":"https://api.github.com/users/dmurphy18/following{/other_user}","gists_url":"https://api.github.com/users/dmurphy18/gists{/gist_id}","starred_url":"https://api.github.com/users/dmurphy18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmurphy18/subscriptions","organizations_url":"https://api.github.com/users/dmurphy18/orgs","repos_url":"https://api.github.com/users/dmurphy18/repos","events_url":"https://api.github.com/users/dmurphy18/events{/privacy}","received_events_url":"https://api.github.com/users/dmurphy18/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\nIncreased the grains reported and corrects the values reported for machien_id, cpuarch, cpu_model,  os information, product name, manufacturer, serialn umber and firmware\r\n\r\n### What issues does this PR fix or reference?\r\nhttps://github.com/saltstack/zh/issues/1341\r\n\r\n### Previous Behavior\r\nSome of the grains were not reported or with incomplete information\r\n\r\n### New Behavior\r\nAIX now reports grains fully, similar to Redhat\r\n\r\n### Tests written?\r\nNo, check by hand\r\n\r\n### Commits signed with GPG?\r\nNo\r\n\r\nPlease review [Salt's Contributing Guide](https://docs.saltstack.com/en/latest/topics/development/contributing.html) for best practices.\r\n\r\nSee GitHub's [page on GPG signing](https://help.github.com/articles/signing-commits-using-gpg/) for more information about signing commits with GPG.\r\n","created_at":"2018-05-23T18:26:06Z","updated_at":"2018-05-24T23:07:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a326a644730b5d98a0523c784c1a801e16b1200b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"team-core","id":1734030,"slug":"team-core","description":"Merge access to all core saltstack repos (including raet, libnacl, and the like)","privacy":"closed","url":"https://api.github.com/teams/1734030","members_url":"https://api.github.com/teams/1734030/members{/member}","repositories_url":"https://api.github.com/teams/1734030/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/47808/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/47808/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/47808/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/463ebac9c8e7355403c31beb1903ceba17eb6a4e","head":{"label":"dmurphy18:aix_grains_upd","ref":"aix_grains_upd","sha":"463ebac9c8e7355403c31beb1903ceba17eb6a4e","user":{"login":"dmurphy18","id":9943204,"avatar_url":"https://avatars2.githubusercontent.com/u/9943204?v=4","gravatar_id":"","url":"https://api.github.com/users/dmurphy18","html_url":"https://github.com/dmurphy18","followers_url":"https://api.github.com/users/dmurphy18/followers","following_url":"https://api.github.com/users/dmurphy18/following{/other_user}","gists_url":"https://api.github.com/users/dmurphy18/gists{/gist_id}","starred_url":"https://api.github.com/users/dmurphy18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmurphy18/subscriptions","organizations_url":"https://api.github.com/users/dmurphy18/orgs","repos_url":"https://api.github.com/users/dmurphy18/repos","events_url":"https://api.github.com/users/dmurphy18/events{/privacy}","received_events_url":"https://api.github.com/users/dmurphy18/received_events","type":"User","site_admin":false},"repo":{"id":27693778,"name":"salt","full_name":"dmurphy18/salt","owner":{"login":"dmurphy18","id":9943204,"avatar_url":"https://avatars2.githubusercontent.com/u/9943204?v=4","gravatar_id":"","url":"https://api.github.com/users/dmurphy18","html_url":"https://github.com/dmurphy18","followers_url":"https://api.github.com/users/dmurphy18/followers","following_url":"https://api.github.com/users/dmurphy18/following{/other_user}","gists_url":"https://api.github.com/users/dmurphy18/gists{/gist_id}","starred_url":"https://api.github.com/users/dmurphy18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmurphy18/subscriptions","organizations_url":"https://api.github.com/users/dmurphy18/orgs","repos_url":"https://api.github.com/users/dmurphy18/repos","events_url":"https://api.github.com/users/dmurphy18/events{/privacy}","received_events_url":"https://api.github.com/users/dmurphy18/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmurphy18/salt","description":"Infrastructure automation and management system","fork":true,"url":"https://api.github.com/repos/dmurphy18/salt","forks_url":"https://api.github.com/repos/dmurphy18/salt/forks","keys_url":"https://api.github.com/repos/dmurphy18/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmurphy18/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmurphy18/salt/teams","hooks_url":"https://api.github.com/repos/dmurphy18/salt/hooks","issue_events_url":"https://api.github.com/repos/dmurphy18/salt/issues/events{/number}","events_url":"https://api.github.com/repos/dmurphy18/salt/events","assignees_url":"https://api.github.com/repos/dmurphy18/salt/assignees{/user}","branches_url":"https://api.github.com/repos/dmurphy18/salt/branches{/branch}","tags_url":"https://api.github.com/repos/dmurphy18/salt/tags","blobs_url":"https://api.github.com/repos/dmurphy18/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmurphy18/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmurphy18/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmurphy18/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmurphy18/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/dmurphy18/salt/languages","stargazers_url":"https://api.github.com/repos/dmurphy18/salt/stargazers","contributors_url":"https://api.github.com/repos/dmurphy18/salt/contributors","subscribers_url":"https://api.github.com/repos/dmurphy18/salt/subscribers","subscription_url":"https://api.github.com/repos/dmurphy18/salt/subscription","commits_url":"https://api.github.com/repos/dmurphy18/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmurphy18/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmurphy18/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmurphy18/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmurphy18/salt/contents/{+path}","compare_url":"https://api.github.com/repos/dmurphy18/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmurphy18/salt/merges","archive_url":"https://api.github.com/repos/dmurphy18/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmurphy18/salt/downloads","issues_url":"https://api.github.com/repos/dmurphy18/salt/issues{/number}","pulls_url":"https://api.github.com/repos/dmurphy18/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/dmurphy18/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/dmurphy18/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmurphy18/salt/labels{/name}","releases_url":"https://api.github.com/repos/dmurphy18/salt/releases{/id}","deployments_url":"https://api.github.com/repos/dmurphy18/salt/deployments","created_at":"2014-12-08T02:20:49Z","updated_at":"2018-05-24T18:33:26Z","pushed_at":"2018-05-24T23:02:35Z","git_url":"git://github.com/dmurphy18/salt.git","ssh_url":"git@github.com:dmurphy18/salt.git","clone_url":"https://github.com/dmurphy18/salt.git","svn_url":"https://github.com/dmurphy18/salt","homepage":"saltstack.com","size":403941,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"saltstack:develop","ref":"develop","sha":"c21e8c7f0c37ff807abe0b15d28de90b2d466803","user":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars3.githubusercontent.com/u/1147473?v=4","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars3.githubusercontent.com/u/1147473?v=4","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt software package repository here: ","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","deployments_url":"https://api.github.com/repos/saltstack/salt/deployments","created_at":"2011-02-20T20:16:56Z","updated_at":"2018-05-24T16:37:43Z","pushed_at":"2018-05-24T23:02:40Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"https://repo.saltstack.com/","size":404905,"stargazers_count":8867,"watchers_count":8867,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4163,"mirror_url":null,"archived":false,"open_issues_count":3379,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":4163,"open_issues":3379,"watchers":8867,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/47808"},"html":{"href":"https://github.com/saltstack/salt/pull/47808"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/47808"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/47808/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/47808/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/47808/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/463ebac9c8e7355403c31beb1903ceba17eb6a4e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dmurphy18"}}