{"action":"created","issue":{"url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues/2130","repository_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline","labels_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues/2130/labels{/name}","comments_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues/2130/comments","events_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues/2130/events","html_url":"https://github.com/Unity-Technologies/ScriptableRenderPipeline/pull/2130","id":367397404,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwODQ2ODU2","number":2130,"title":"Revamp of XR/SRP hookup + Full screen blit fix for single-pass stereo","user":{"login":"nerites","id":3450690,"node_id":"MDQ6VXNlcjM0NTA2OTA=","avatar_url":"https://avatars1.githubusercontent.com/u/3450690?v=4","gravatar_id":"","url":"https://api.github.com/users/nerites","html_url":"https://github.com/nerites","followers_url":"https://api.github.com/users/nerites/followers","following_url":"https://api.github.com/users/nerites/following{/other_user}","gists_url":"https://api.github.com/users/nerites/gists{/gist_id}","starred_url":"https://api.github.com/users/nerites/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nerites/subscriptions","organizations_url":"https://api.github.com/users/nerites/orgs","repos_url":"https://api.github.com/users/nerites/repos","events_url":"https://api.github.com/users/nerites/events{/privacy}","received_events_url":"https://api.github.com/users/nerites/received_events","type":"User","site_admin":false},"labels":[{"id":862572140,"node_id":"MDU6TGFiZWw4NjI1NzIxNDA=","url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/labels/HDRP","name":"HDRP","color":"dd75a6","default":false},{"id":851900683,"node_id":"MDU6TGFiZWw4NTE5MDA2ODM=","url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/labels/XR","name":"XR","color":"1d76db","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-10-05T23:22:27Z","updated_at":"2018-10-13T00:35:24Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls/2130","html_url":"https://github.com/Unity-Technologies/ScriptableRenderPipeline/pull/2130","diff_url":"https://github.com/Unity-Technologies/ScriptableRenderPipeline/pull/2130.diff","patch_url":"https://github.com/Unity-Technologies/ScriptableRenderPipeline/pull/2130.patch"},"body":"### Purpose of this PR\r\nMike Chow made a convincing argument for preserving a single-point-of-contact programming model for XRSettings for as long as XRSettings exists. Because of this, XRGraphicsConfig has been converted to a read-only XRGraphics interface with XRSettings. \r\n\r\nWhen stereo is enabled, SRP will be overridden by analogous settings in XRSettings. For now, the only affected setting is RenderScale in LWRP. Whenever ViewportScale is added, that too will be overridden.\r\n\r\nNo other XRSettings should overlap with SRP controls. \r\n\r\nThis PR also contains a shader change to HDRP's Blit shader. It adds a shader variant to correctly sample a double-wide texture for a single-pass double-wide Blit. This Blit is dispatched through the command buffer, which takes advantage of native Y-flip correction. \r\n\r\n---\r\n### Release Notes\r\n- Fixes Y-flip in HDRP by using HDRP's Blit shader, which has been adapted to work with single-pass double-wide stereo rendering\r\n- Changed SRP's interface with XRSettings to XRSettings override of common functionality\r\n\r\n---\r\n### Testing status\r\n**Katana Tests**: First off we need to make sure the Katana SRP tests are green?\r\nhttps://katana.bf.unity3d.com/projects/com.unity.render-pipelines/builders?ScriptableRenderLoop_branch=stereoplumbing&unity_branch=trunk&automation-tools_branch=add-platform-filter\r\n\r\n**Manual Tests**: What did you do?\r\nManually tested single-pass double-wide (with and without postprocessing enabled) in the template workshop scene. \r\n![image](https://user-images.githubusercontent.com/3450690/46564128-6643ed00-c8ba-11e8-935f-6fe1170ffbae.png)\r\n\r\n\r\n**Automated Tests**: What did you setup?\r\nNothing\r\n\r\nAny test projects to go with this to help reviewers?\r\nJust the template project should do it\r\n\r\n---\r\n### Overall Product Risks\r\n**Technical Risk**: None, Low, Medium, High?\r\nLow- change is a straightforward shift to the simplest possible integration with XR.\r\n\r\n**Halo Effect**: None, Low, Medium, High?\r\nMedium- changes touched many places across LWRP and HDRP, including UI. \r\n\r\n---\r\n### Comments to reviewers\r\nHopefully this is the final iteration of the attempts to fix y-flip for HDRP. \r\nRequesting feedback on HDRP control of stereo rendering- in this changeset, I've basically removed any additional control HDRP would have had over stereo rendering, the idea being that StartMultiEye and StopMultiEye are all the control over that that's needed on the SRP side. Feel free to give feedback on this. \r\n"},"comment":{"url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues/comments/429496419","html_url":"https://github.com/Unity-Technologies/ScriptableRenderPipeline/pull/2130#issuecomment-429496419","issue_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues/2130","id":429496419,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTQ5NjQxOQ==","user":{"login":"nerites","id":3450690,"node_id":"MDQ6VXNlcjM0NTA2OTA=","avatar_url":"https://avatars1.githubusercontent.com/u/3450690?v=4","gravatar_id":"","url":"https://api.github.com/users/nerites","html_url":"https://github.com/nerites","followers_url":"https://api.github.com/users/nerites/followers","following_url":"https://api.github.com/users/nerites/following{/other_user}","gists_url":"https://api.github.com/users/nerites/gists{/gist_id}","starred_url":"https://api.github.com/users/nerites/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nerites/subscriptions","organizations_url":"https://api.github.com/users/nerites/orgs","repos_url":"https://api.github.com/users/nerites/repos","events_url":"https://api.github.com/users/nerites/events{/privacy}","received_events_url":"https://api.github.com/users/nerites/received_events","type":"User","site_admin":false},"created_at":"2018-10-13T00:35:24Z","updated_at":"2018-10-13T00:35:24Z","author_association":"CONTRIBUTOR","body":"Rename done. \r\nI tried to have a mouseover explaining why renderscale gets greyed out when XR is enabled but it looks like it doesn't appear.\r\n\r\n@mikecunity rename complete, does it look ok? "}}
{"actor":{"display_login":"nerites"}}