{"action":"created","comment":{"url":"https://api.github.com/repos/Sylius/RefundPlugin/pulls/comments/203693209","pull_request_review_id":138631038,"id":203693209,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzY5MzIwOQ==","diff_hunk":"@@ -11,12 +11,13 @@\n {\n     use PayloadTrait;\n \n-    public function __construct(string $orderNumber, array $refundedUnitIds)\n+    public function __construct(string $orderNumber, array $refundedUnitIds, array $refundedShipmentIds)","path":"src/Command/RefundUnits.php","position":5,"original_position":5,"commit_id":"e0ab960eaca7b0dcf2d82c6fc43ee4376b6c080c","original_commit_id":"e0ab960eaca7b0dcf2d82c6fc43ee4376b6c080c","user":{"login":"GSadee","id":6140884,"node_id":"MDQ6VXNlcjYxNDA4ODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6140884?v=4","gravatar_id":"","url":"https://api.github.com/users/GSadee","html_url":"https://github.com/GSadee","followers_url":"https://api.github.com/users/GSadee/followers","following_url":"https://api.github.com/users/GSadee/following{/other_user}","gists_url":"https://api.github.com/users/GSadee/gists{/gist_id}","starred_url":"https://api.github.com/users/GSadee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GSadee/subscriptions","organizations_url":"https://api.github.com/users/GSadee/orgs","repos_url":"https://api.github.com/users/GSadee/repos","events_url":"https://api.github.com/users/GSadee/events{/privacy}","received_events_url":"https://api.github.com/users/GSadee/received_events","type":"User","site_admin":false},"body":"IMO `$unitIds` or `$orderItemUnitIds` instead of `$orderUnitIds`","created_at":"2018-07-19T11:35:11Z","updated_at":"2018-07-19T11:35:11Z","html_url":"https://github.com/Sylius/RefundPlugin/pull/13#discussion_r203693209","pull_request_url":"https://api.github.com/repos/Sylius/RefundPlugin/pulls/13","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Sylius/RefundPlugin/pulls/comments/203693209"},"html":{"href":"https://github.com/Sylius/RefundPlugin/pull/13#discussion_r203693209"},"pull_request":{"href":"https://api.github.com/repos/Sylius/RefundPlugin/pulls/13"}},"in_reply_to_id":203655011},"pull_request":{"url":"https://api.github.com/repos/Sylius/RefundPlugin/pulls/13","id":202280502,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMjgwNTAy","html_url":"https://github.com/Sylius/RefundPlugin/pull/13","diff_url":"https://github.com/Sylius/RefundPlugin/pull/13.diff","patch_url":"https://github.com/Sylius/RefundPlugin/pull/13.patch","issue_url":"https://api.github.com/repos/Sylius/RefundPlugin/issues/13","number":13,"state":"open","locked":false,"title":"Refunding order shipping","user":{"login":"Zales0123","id":6212718,"node_id":"MDQ6VXNlcjYyMTI3MTg=","avatar_url":"https://avatars1.githubusercontent.com/u/6212718?v=4","gravatar_id":"","url":"https://api.github.com/users/Zales0123","html_url":"https://github.com/Zales0123","followers_url":"https://api.github.com/users/Zales0123/followers","following_url":"https://api.github.com/users/Zales0123/following{/other_user}","gists_url":"https://api.github.com/users/Zales0123/gists{/gist_id}","starred_url":"https://api.github.com/users/Zales0123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zales0123/subscriptions","organizations_url":"https://api.github.com/users/Zales0123/orgs","repos_url":"https://api.github.com/users/Zales0123/repos","events_url":"https://api.github.com/users/Zales0123/events{/privacy}","received_events_url":"https://api.github.com/users/Zales0123/received_events","type":"User","site_admin":false},"body":"The only thing I'm not sure about is `RefundUnits` command, with which now we can also refund shipments. On one hand, it's quite confusing (the natural thing is we think about `order units`)... On the other hand, we can say that in a context of `Refund` everything is a **refund unit**, no matter is it a shipment or order unit. And I have no idea how can it be named better 😄 \r\n\r\n> Note\r\n\r\nFor now, there is only a support for one order shipment - the reason why, is that there could be some troubles about shipments in Sylius (we have one shipping adjustment even for multiple shipments) and even though Sylius supports multiple shipments, it's base on single-shipment architecture right now.\r\n\r\n<img width=\"1172\" alt=\"zrzut ekranu 2018-07-19 o 08 49 05\" src=\"https://user-images.githubusercontent.com/6212718/42926093-a584a5d0-8b30-11e8-9102-17a44332f38f.png\">\r\n","created_at":"2018-07-18T14:52:14Z","updated_at":"2018-07-19T11:35:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aaad8b79a4d1a14c8ed44583b735e9569de86a02","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":982434160,"node_id":"MDU6TGFiZWw5ODI0MzQxNjA=","url":"https://api.github.com/repos/Sylius/RefundPlugin/labels/feature","name":"feature","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Sylius/RefundPlugin/pulls/13/commits","review_comments_url":"https://api.github.com/repos/Sylius/RefundPlugin/pulls/13/comments","review_comment_url":"https://api.github.com/repos/Sylius/RefundPlugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Sylius/RefundPlugin/issues/13/comments","statuses_url":"https://api.github.com/repos/Sylius/RefundPlugin/statuses/e0ab960eaca7b0dcf2d82c6fc43ee4376b6c080c","head":{"label":"Zales0123:refunding-order-shipping","ref":"refunding-order-shipping","sha":"e0ab960eaca7b0dcf2d82c6fc43ee4376b6c080c","user":{"login":"Zales0123","id":6212718,"node_id":"MDQ6VXNlcjYyMTI3MTg=","avatar_url":"https://avatars1.githubusercontent.com/u/6212718?v=4","gravatar_id":"","url":"https://api.github.com/users/Zales0123","html_url":"https://github.com/Zales0123","followers_url":"https://api.github.com/users/Zales0123/followers","following_url":"https://api.github.com/users/Zales0123/following{/other_user}","gists_url":"https://api.github.com/users/Zales0123/gists{/gist_id}","starred_url":"https://api.github.com/users/Zales0123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zales0123/subscriptions","organizations_url":"https://api.github.com/users/Zales0123/orgs","repos_url":"https://api.github.com/users/Zales0123/repos","events_url":"https://api.github.com/users/Zales0123/events{/privacy}","received_events_url":"https://api.github.com/users/Zales0123/received_events","type":"User","site_admin":false},"repo":{"id":139553102,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk1NTMxMDI=","name":"RefundPlugin","full_name":"Zales0123/RefundPlugin","owner":{"login":"Zales0123","id":6212718,"node_id":"MDQ6VXNlcjYyMTI3MTg=","avatar_url":"https://avatars1.githubusercontent.com/u/6212718?v=4","gravatar_id":"","url":"https://api.github.com/users/Zales0123","html_url":"https://github.com/Zales0123","followers_url":"https://api.github.com/users/Zales0123/followers","following_url":"https://api.github.com/users/Zales0123/following{/other_user}","gists_url":"https://api.github.com/users/Zales0123/gists{/gist_id}","starred_url":"https://api.github.com/users/Zales0123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zales0123/subscriptions","organizations_url":"https://api.github.com/users/Zales0123/orgs","repos_url":"https://api.github.com/users/Zales0123/repos","events_url":"https://api.github.com/users/Zales0123/events{/privacy}","received_events_url":"https://api.github.com/users/Zales0123/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Zales0123/RefundPlugin","description":"[WIP] Basic refunds functionality for Sylius","fork":true,"url":"https://api.github.com/repos/Zales0123/RefundPlugin","forks_url":"https://api.github.com/repos/Zales0123/RefundPlugin/forks","keys_url":"https://api.github.com/repos/Zales0123/RefundPlugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zales0123/RefundPlugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zales0123/RefundPlugin/teams","hooks_url":"https://api.github.com/repos/Zales0123/RefundPlugin/hooks","issue_events_url":"https://api.github.com/repos/Zales0123/RefundPlugin/issues/events{/number}","events_url":"https://api.github.com/repos/Zales0123/RefundPlugin/events","assignees_url":"https://api.github.com/repos/Zales0123/RefundPlugin/assignees{/user}","branches_url":"https://api.github.com/repos/Zales0123/RefundPlugin/branches{/branch}","tags_url":"https://api.github.com/repos/Zales0123/RefundPlugin/tags","blobs_url":"https://api.github.com/repos/Zales0123/RefundPlugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zales0123/RefundPlugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zales0123/RefundPlugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zales0123/RefundPlugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zales0123/RefundPlugin/statuses/{sha}","languages_url":"https://api.github.com/repos/Zales0123/RefundPlugin/languages","stargazers_url":"https://api.github.com/repos/Zales0123/RefundPlugin/stargazers","contributors_url":"https://api.github.com/repos/Zales0123/RefundPlugin/contributors","subscribers_url":"https://api.github.com/repos/Zales0123/RefundPlugin/subscribers","subscription_url":"https://api.github.com/repos/Zales0123/RefundPlugin/subscription","commits_url":"https://api.github.com/repos/Zales0123/RefundPlugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zales0123/RefundPlugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zales0123/RefundPlugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zales0123/RefundPlugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zales0123/RefundPlugin/contents/{+path}","compare_url":"https://api.github.com/repos/Zales0123/RefundPlugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zales0123/RefundPlugin/merges","archive_url":"https://api.github.com/repos/Zales0123/RefundPlugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zales0123/RefundPlugin/downloads","issues_url":"https://api.github.com/repos/Zales0123/RefundPlugin/issues{/number}","pulls_url":"https://api.github.com/repos/Zales0123/RefundPlugin/pulls{/number}","milestones_url":"https://api.github.com/repos/Zales0123/RefundPlugin/milestones{/number}","notifications_url":"https://api.github.com/repos/Zales0123/RefundPlugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zales0123/RefundPlugin/labels{/name}","releases_url":"https://api.github.com/repos/Zales0123/RefundPlugin/releases{/id}","deployments_url":"https://api.github.com/repos/Zales0123/RefundPlugin/deployments","created_at":"2018-07-03T08:33:56Z","updated_at":"2018-07-11T12:28:00Z","pushed_at":"2018-07-19T11:22:41Z","git_url":"git://github.com/Zales0123/RefundPlugin.git","ssh_url":"git@github.com:Zales0123/RefundPlugin.git","clone_url":"https://github.com/Zales0123/RefundPlugin.git","svn_url":"https://github.com/Zales0123/RefundPlugin","homepage":null,"size":148,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Sylius:master","ref":"master","sha":"226e9c8a65d138ff17221bdc48fb6ff6a1fcb6a2","user":{"login":"Sylius","id":719423,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxOTQyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/719423?v=4","gravatar_id":"","url":"https://api.github.com/users/Sylius","html_url":"https://github.com/Sylius","followers_url":"https://api.github.com/users/Sylius/followers","following_url":"https://api.github.com/users/Sylius/following{/other_user}","gists_url":"https://api.github.com/users/Sylius/gists{/gist_id}","starred_url":"https://api.github.com/users/Sylius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sylius/subscriptions","organizations_url":"https://api.github.com/users/Sylius/orgs","repos_url":"https://api.github.com/users/Sylius/repos","events_url":"https://api.github.com/users/Sylius/events{/privacy}","received_events_url":"https://api.github.com/users/Sylius/received_events","type":"Organization","site_admin":false},"repo":{"id":139500281,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk1MDAyODE=","name":"RefundPlugin","full_name":"Sylius/RefundPlugin","owner":{"login":"Sylius","id":719423,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxOTQyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/719423?v=4","gravatar_id":"","url":"https://api.github.com/users/Sylius","html_url":"https://github.com/Sylius","followers_url":"https://api.github.com/users/Sylius/followers","following_url":"https://api.github.com/users/Sylius/following{/other_user}","gists_url":"https://api.github.com/users/Sylius/gists{/gist_id}","starred_url":"https://api.github.com/users/Sylius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sylius/subscriptions","organizations_url":"https://api.github.com/users/Sylius/orgs","repos_url":"https://api.github.com/users/Sylius/repos","events_url":"https://api.github.com/users/Sylius/events{/privacy}","received_events_url":"https://api.github.com/users/Sylius/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Sylius/RefundPlugin","description":"[WIP] Basic refunds functionality for Sylius","fork":false,"url":"https://api.github.com/repos/Sylius/RefundPlugin","forks_url":"https://api.github.com/repos/Sylius/RefundPlugin/forks","keys_url":"https://api.github.com/repos/Sylius/RefundPlugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sylius/RefundPlugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sylius/RefundPlugin/teams","hooks_url":"https://api.github.com/repos/Sylius/RefundPlugin/hooks","issue_events_url":"https://api.github.com/repos/Sylius/RefundPlugin/issues/events{/number}","events_url":"https://api.github.com/repos/Sylius/RefundPlugin/events","assignees_url":"https://api.github.com/repos/Sylius/RefundPlugin/assignees{/user}","branches_url":"https://api.github.com/repos/Sylius/RefundPlugin/branches{/branch}","tags_url":"https://api.github.com/repos/Sylius/RefundPlugin/tags","blobs_url":"https://api.github.com/repos/Sylius/RefundPlugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sylius/RefundPlugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sylius/RefundPlugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sylius/RefundPlugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sylius/RefundPlugin/statuses/{sha}","languages_url":"https://api.github.com/repos/Sylius/RefundPlugin/languages","stargazers_url":"https://api.github.com/repos/Sylius/RefundPlugin/stargazers","contributors_url":"https://api.github.com/repos/Sylius/RefundPlugin/contributors","subscribers_url":"https://api.github.com/repos/Sylius/RefundPlugin/subscribers","subscription_url":"https://api.github.com/repos/Sylius/RefundPlugin/subscription","commits_url":"https://api.github.com/repos/Sylius/RefundPlugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sylius/RefundPlugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sylius/RefundPlugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sylius/RefundPlugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sylius/RefundPlugin/contents/{+path}","compare_url":"https://api.github.com/repos/Sylius/RefundPlugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sylius/RefundPlugin/merges","archive_url":"https://api.github.com/repos/Sylius/RefundPlugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sylius/RefundPlugin/downloads","issues_url":"https://api.github.com/repos/Sylius/RefundPlugin/issues{/number}","pulls_url":"https://api.github.com/repos/Sylius/RefundPlugin/pulls{/number}","milestones_url":"https://api.github.com/repos/Sylius/RefundPlugin/milestones{/number}","notifications_url":"https://api.github.com/repos/Sylius/RefundPlugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sylius/RefundPlugin/labels{/name}","releases_url":"https://api.github.com/repos/Sylius/RefundPlugin/releases{/id}","deployments_url":"https://api.github.com/repos/Sylius/RefundPlugin/deployments","created_at":"2018-07-02T22:15:38Z","updated_at":"2018-07-19T10:18:10Z","pushed_at":"2018-07-19T11:22:51Z","git_url":"git://github.com/Sylius/RefundPlugin.git","ssh_url":"git@github.com:Sylius/RefundPlugin.git","clone_url":"https://github.com/Sylius/RefundPlugin.git","svn_url":"https://github.com/Sylius/RefundPlugin","homepage":null,"size":116,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":2,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Sylius/RefundPlugin/pulls/13"},"html":{"href":"https://github.com/Sylius/RefundPlugin/pull/13"},"issue":{"href":"https://api.github.com/repos/Sylius/RefundPlugin/issues/13"},"comments":{"href":"https://api.github.com/repos/Sylius/RefundPlugin/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/Sylius/RefundPlugin/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/Sylius/RefundPlugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Sylius/RefundPlugin/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/Sylius/RefundPlugin/statuses/e0ab960eaca7b0dcf2d82c6fc43ee4376b6c080c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"GSadee"}}