{"action":"created","comment":{"url":"https://api.github.com/repos/yola/yodeploy/pulls/comments/186363226","pull_request_review_id":117924468,"id":186363226,"diff_hunk":"@@ -0,0 +1,20 @@\n+import getpass\n+\n+import mock\n+\n+from os.path import join\n+\n+from yodeploy.hooks.nginx import NginxHostedApp\n+from yodeploy.test_integration.helpers import tests_dir\n+\n+\n+class Hooks(NginxHostedApp):\n+    # these overrides are only needed for testing\n+    nginx = mock.Mock()\n+    logs_path = join(tests_dir, 'filesys/var/log/nginx')","path":"yodeploy/test_integration/samples/nginx-app/deploy/hooks.py","position":14,"original_position":14,"commit_id":"b12978c99739ba49fb981de496521f53c49f679e","original_commit_id":"b12978c99739ba49fb981de496521f53c49f679e","user":{"login":"ekoval","id":954264,"avatar_url":"https://avatars0.githubusercontent.com/u/954264?v=4","gravatar_id":"","url":"https://api.github.com/users/ekoval","html_url":"https://github.com/ekoval","followers_url":"https://api.github.com/users/ekoval/followers","following_url":"https://api.github.com/users/ekoval/following{/other_user}","gists_url":"https://api.github.com/users/ekoval/gists{/gist_id}","starred_url":"https://api.github.com/users/ekoval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekoval/subscriptions","organizations_url":"https://api.github.com/users/ekoval/orgs","repos_url":"https://api.github.com/users/ekoval/repos","events_url":"https://api.github.com/users/ekoval/events{/privacy}","received_events_url":"https://api.github.com/users/ekoval/received_events","type":"User","site_admin":false},"body":"Oh, it is imported from `os`. I wouldn't to do this, it is easy to mix up with string `''.join()`","created_at":"2018-05-07T08:46:15Z","updated_at":"2018-05-07T08:46:15Z","html_url":"https://github.com/yola/yodeploy/pull/219#discussion_r186363226","pull_request_url":"https://api.github.com/repos/yola/yodeploy/pulls/219","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/yola/yodeploy/pulls/comments/186363226"},"html":{"href":"https://github.com/yola/yodeploy/pull/219#discussion_r186363226"},"pull_request":{"href":"https://api.github.com/repos/yola/yodeploy/pulls/219"}},"in_reply_to_id":186360661},"pull_request":{"url":"https://api.github.com/repos/yola/yodeploy/pulls/219","id":184330035,"html_url":"https://github.com/yola/yodeploy/pull/219","diff_url":"https://github.com/yola/yodeploy/pull/219.diff","patch_url":"https://github.com/yola/yodeploy/pull/219.patch","issue_url":"https://api.github.com/repos/yola/yodeploy/issues/219","number":219,"state":"open","locked":false,"title":"Add NginxHostedApp and UwsgiHostedApp deploy hooks","user":{"login":"serhii-karelov","id":4457579,"avatar_url":"https://avatars3.githubusercontent.com/u/4457579?v=4","gravatar_id":"","url":"https://api.github.com/users/serhii-karelov","html_url":"https://github.com/serhii-karelov","followers_url":"https://api.github.com/users/serhii-karelov/followers","following_url":"https://api.github.com/users/serhii-karelov/following{/other_user}","gists_url":"https://api.github.com/users/serhii-karelov/gists{/gist_id}","starred_url":"https://api.github.com/users/serhii-karelov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serhii-karelov/subscriptions","organizations_url":"https://api.github.com/users/serhii-karelov/orgs","repos_url":"https://api.github.com/users/serhii-karelov/repos","events_url":"https://api.github.com/users/serhii-karelov/events{/privacy}","received_events_url":"https://api.github.com/users/serhii-karelov/received_events","type":"User","site_admin":false},"body":"Move out apache hooks from `DjangoApp` to new `ApacheHostedDjangoApp`. \r\nRename `DjangoMultiSiteApp` into `ApacheHostedDjangoMultiSiteApp`\r\nAdd `NginxHostedApp` and `UwsgiHostedApp` deploy hooks \r\n\r\n@yola/service-engineering @yola/operations-engineering ","created_at":"2018-04-26T12:53:27Z","updated_at":"2018-05-07T08:46:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bdafabbbff97fcf0ed2c34492dd0d4e05e436528","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":189697977,"url":"https://api.github.com/repos/yola/yodeploy/labels/service","name":"service","color":"FFB347","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/yola/yodeploy/pulls/219/commits","review_comments_url":"https://api.github.com/repos/yola/yodeploy/pulls/219/comments","review_comment_url":"https://api.github.com/repos/yola/yodeploy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yola/yodeploy/issues/219/comments","statuses_url":"https://api.github.com/repos/yola/yodeploy/statuses/b12978c99739ba49fb981de496521f53c49f679e","head":{"label":"yola:update-djang-app-hooks","ref":"update-djang-app-hooks","sha":"b12978c99739ba49fb981de496521f53c49f679e","user":{"login":"yola","id":861497,"avatar_url":"https://avatars0.githubusercontent.com/u/861497?v=4","gravatar_id":"","url":"https://api.github.com/users/yola","html_url":"https://github.com/yola","followers_url":"https://api.github.com/users/yola/followers","following_url":"https://api.github.com/users/yola/following{/other_user}","gists_url":"https://api.github.com/users/yola/gists{/gist_id}","starred_url":"https://api.github.com/users/yola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yola/subscriptions","organizations_url":"https://api.github.com/users/yola/orgs","repos_url":"https://api.github.com/users/yola/repos","events_url":"https://api.github.com/users/yola/events{/privacy}","received_events_url":"https://api.github.com/users/yola/received_events","type":"Organization","site_admin":false},"repo":{"id":4809050,"name":"yodeploy","full_name":"yola/yodeploy","owner":{"login":"yola","id":861497,"avatar_url":"https://avatars0.githubusercontent.com/u/861497?v=4","gravatar_id":"","url":"https://api.github.com/users/yola","html_url":"https://github.com/yola","followers_url":"https://api.github.com/users/yola/followers","following_url":"https://api.github.com/users/yola/following{/other_user}","gists_url":"https://api.github.com/users/yola/gists{/gist_id}","starred_url":"https://api.github.com/users/yola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yola/subscriptions","organizations_url":"https://api.github.com/users/yola/orgs","repos_url":"https://api.github.com/users/yola/repos","events_url":"https://api.github.com/users/yola/events{/privacy}","received_events_url":"https://api.github.com/users/yola/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yola/yodeploy","description":"Python library for deployment","fork":false,"url":"https://api.github.com/repos/yola/yodeploy","forks_url":"https://api.github.com/repos/yola/yodeploy/forks","keys_url":"https://api.github.com/repos/yola/yodeploy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yola/yodeploy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yola/yodeploy/teams","hooks_url":"https://api.github.com/repos/yola/yodeploy/hooks","issue_events_url":"https://api.github.com/repos/yola/yodeploy/issues/events{/number}","events_url":"https://api.github.com/repos/yola/yodeploy/events","assignees_url":"https://api.github.com/repos/yola/yodeploy/assignees{/user}","branches_url":"https://api.github.com/repos/yola/yodeploy/branches{/branch}","tags_url":"https://api.github.com/repos/yola/yodeploy/tags","blobs_url":"https://api.github.com/repos/yola/yodeploy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yola/yodeploy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yola/yodeploy/git/refs{/sha}","trees_url":"https://api.github.com/repos/yola/yodeploy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yola/yodeploy/statuses/{sha}","languages_url":"https://api.github.com/repos/yola/yodeploy/languages","stargazers_url":"https://api.github.com/repos/yola/yodeploy/stargazers","contributors_url":"https://api.github.com/repos/yola/yodeploy/contributors","subscribers_url":"https://api.github.com/repos/yola/yodeploy/subscribers","subscription_url":"https://api.github.com/repos/yola/yodeploy/subscription","commits_url":"https://api.github.com/repos/yola/yodeploy/commits{/sha}","git_commits_url":"https://api.github.com/repos/yola/yodeploy/git/commits{/sha}","comments_url":"https://api.github.com/repos/yola/yodeploy/comments{/number}","issue_comment_url":"https://api.github.com/repos/yola/yodeploy/issues/comments{/number}","contents_url":"https://api.github.com/repos/yola/yodeploy/contents/{+path}","compare_url":"https://api.github.com/repos/yola/yodeploy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yola/yodeploy/merges","archive_url":"https://api.github.com/repos/yola/yodeploy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yola/yodeploy/downloads","issues_url":"https://api.github.com/repos/yola/yodeploy/issues{/number}","pulls_url":"https://api.github.com/repos/yola/yodeploy/pulls{/number}","milestones_url":"https://api.github.com/repos/yola/yodeploy/milestones{/number}","notifications_url":"https://api.github.com/repos/yola/yodeploy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yola/yodeploy/labels{/name}","releases_url":"https://api.github.com/repos/yola/yodeploy/releases{/id}","deployments_url":"https://api.github.com/repos/yola/yodeploy/deployments","created_at":"2012-06-27T14:06:15Z","updated_at":"2017-05-04T19:55:25Z","pushed_at":"2018-05-05T13:10:49Z","git_url":"git://github.com/yola/yodeploy.git","ssh_url":"git@github.com:yola/yodeploy.git","clone_url":"https://github.com/yola/yodeploy.git","svn_url":"https://github.com/yola/yodeploy","homepage":null,"size":625,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":15,"license":null,"forks":0,"open_issues":15,"watchers":2,"default_branch":"master"}},"base":{"label":"yola:master","ref":"master","sha":"319f07df1c0e894c80ce5b32f52f1718eeabaae7","user":{"login":"yola","id":861497,"avatar_url":"https://avatars0.githubusercontent.com/u/861497?v=4","gravatar_id":"","url":"https://api.github.com/users/yola","html_url":"https://github.com/yola","followers_url":"https://api.github.com/users/yola/followers","following_url":"https://api.github.com/users/yola/following{/other_user}","gists_url":"https://api.github.com/users/yola/gists{/gist_id}","starred_url":"https://api.github.com/users/yola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yola/subscriptions","organizations_url":"https://api.github.com/users/yola/orgs","repos_url":"https://api.github.com/users/yola/repos","events_url":"https://api.github.com/users/yola/events{/privacy}","received_events_url":"https://api.github.com/users/yola/received_events","type":"Organization","site_admin":false},"repo":{"id":4809050,"name":"yodeploy","full_name":"yola/yodeploy","owner":{"login":"yola","id":861497,"avatar_url":"https://avatars0.githubusercontent.com/u/861497?v=4","gravatar_id":"","url":"https://api.github.com/users/yola","html_url":"https://github.com/yola","followers_url":"https://api.github.com/users/yola/followers","following_url":"https://api.github.com/users/yola/following{/other_user}","gists_url":"https://api.github.com/users/yola/gists{/gist_id}","starred_url":"https://api.github.com/users/yola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yola/subscriptions","organizations_url":"https://api.github.com/users/yola/orgs","repos_url":"https://api.github.com/users/yola/repos","events_url":"https://api.github.com/users/yola/events{/privacy}","received_events_url":"https://api.github.com/users/yola/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yola/yodeploy","description":"Python library for deployment","fork":false,"url":"https://api.github.com/repos/yola/yodeploy","forks_url":"https://api.github.com/repos/yola/yodeploy/forks","keys_url":"https://api.github.com/repos/yola/yodeploy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yola/yodeploy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yola/yodeploy/teams","hooks_url":"https://api.github.com/repos/yola/yodeploy/hooks","issue_events_url":"https://api.github.com/repos/yola/yodeploy/issues/events{/number}","events_url":"https://api.github.com/repos/yola/yodeploy/events","assignees_url":"https://api.github.com/repos/yola/yodeploy/assignees{/user}","branches_url":"https://api.github.com/repos/yola/yodeploy/branches{/branch}","tags_url":"https://api.github.com/repos/yola/yodeploy/tags","blobs_url":"https://api.github.com/repos/yola/yodeploy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yola/yodeploy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yola/yodeploy/git/refs{/sha}","trees_url":"https://api.github.com/repos/yola/yodeploy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yola/yodeploy/statuses/{sha}","languages_url":"https://api.github.com/repos/yola/yodeploy/languages","stargazers_url":"https://api.github.com/repos/yola/yodeploy/stargazers","contributors_url":"https://api.github.com/repos/yola/yodeploy/contributors","subscribers_url":"https://api.github.com/repos/yola/yodeploy/subscribers","subscription_url":"https://api.github.com/repos/yola/yodeploy/subscription","commits_url":"https://api.github.com/repos/yola/yodeploy/commits{/sha}","git_commits_url":"https://api.github.com/repos/yola/yodeploy/git/commits{/sha}","comments_url":"https://api.github.com/repos/yola/yodeploy/comments{/number}","issue_comment_url":"https://api.github.com/repos/yola/yodeploy/issues/comments{/number}","contents_url":"https://api.github.com/repos/yola/yodeploy/contents/{+path}","compare_url":"https://api.github.com/repos/yola/yodeploy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yola/yodeploy/merges","archive_url":"https://api.github.com/repos/yola/yodeploy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yola/yodeploy/downloads","issues_url":"https://api.github.com/repos/yola/yodeploy/issues{/number}","pulls_url":"https://api.github.com/repos/yola/yodeploy/pulls{/number}","milestones_url":"https://api.github.com/repos/yola/yodeploy/milestones{/number}","notifications_url":"https://api.github.com/repos/yola/yodeploy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yola/yodeploy/labels{/name}","releases_url":"https://api.github.com/repos/yola/yodeploy/releases{/id}","deployments_url":"https://api.github.com/repos/yola/yodeploy/deployments","created_at":"2012-06-27T14:06:15Z","updated_at":"2017-05-04T19:55:25Z","pushed_at":"2018-05-05T13:10:49Z","git_url":"git://github.com/yola/yodeploy.git","ssh_url":"git@github.com:yola/yodeploy.git","clone_url":"https://github.com/yola/yodeploy.git","svn_url":"https://github.com/yola/yodeploy","homepage":null,"size":625,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":15,"license":null,"forks":0,"open_issues":15,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yola/yodeploy/pulls/219"},"html":{"href":"https://github.com/yola/yodeploy/pull/219"},"issue":{"href":"https://api.github.com/repos/yola/yodeploy/issues/219"},"comments":{"href":"https://api.github.com/repos/yola/yodeploy/issues/219/comments"},"review_comments":{"href":"https://api.github.com/repos/yola/yodeploy/pulls/219/comments"},"review_comment":{"href":"https://api.github.com/repos/yola/yodeploy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yola/yodeploy/pulls/219/commits"},"statuses":{"href":"https://api.github.com/repos/yola/yodeploy/statuses/b12978c99739ba49fb981de496521f53c49f679e"}},"author_association":"NONE"}}
{"actor":{"display_login":"ekoval"}}