{"action":"created","comment":{"url":"https://api.github.com/repos/apache/trafficserver/pulls/comments/181461827","pull_request_review_id":112100402,"id":181461827,"diff_hunk":"@@ -644,6 +647,103 @@ class NetVConnection : public VConnection\n   NetVConnection(const NetVConnection &) = delete;\n   NetVConnection &operator=(const NetVConnection &) = delete;\n \n+  enum ProxyProtocolVersion_t {\n+    PROXY_VERSION_UNDEFINED,\n+    PROXY_V1,\n+    PROXY_V2,\n+  };\n+\n+  enum ProxyProtocolData_t {\n+    PROXY_PROTO_UNDEFINED,\n+    PROXY_PROTO_SRC,","path":"iocore/net/I_NetVConnection.h","position":22,"original_position":22,"commit_id":"84e089d827dc4d89a737d6ebd942d87fa675b65f","original_commit_id":"a9fd370978123d6c4eafd20aacc63b16be5c06bc","user":{"login":"reveller","id":2183596,"avatar_url":"https://avatars0.githubusercontent.com/u/2183596?v=4","gravatar_id":"","url":"https://api.github.com/users/reveller","html_url":"https://github.com/reveller","followers_url":"https://api.github.com/users/reveller/followers","following_url":"https://api.github.com/users/reveller/following{/other_user}","gists_url":"https://api.github.com/users/reveller/gists{/gist_id}","starred_url":"https://api.github.com/users/reveller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reveller/subscriptions","organizations_url":"https://api.github.com/users/reveller/orgs","repos_url":"https://api.github.com/users/reveller/repos","events_url":"https://api.github.com/users/reveller/events{/privacy}","received_events_url":"https://api.github.com/users/reveller/received_events","type":"User","site_admin":false},"body":"I am converting both of these enums to enum classes, and reducing the names to UNDEFINED, VI, etc.  As for the ProxyProtocolData enum, I use this as a sort of switch for the get_ and set_proxy_protocol_addr(). E.g. the intent is to call set_proxy_protocol_src_addr() which sets the SRC or DST flag before calling set_proxy_protocol_src_addr().  If this doesn't work for you guys, I can change it to a simple bool.  I was just looking for something I could expand on down the road.","created_at":"2018-04-13T17:43:53Z","updated_at":"2018-04-13T17:43:53Z","html_url":"https://github.com/apache/trafficserver/pull/3123#discussion_r181461827","pull_request_url":"https://api.github.com/repos/apache/trafficserver/pulls/3123","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/comments/181461827"},"html":{"href":"https://github.com/apache/trafficserver/pull/3123#discussion_r181461827"},"pull_request":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/3123"}},"in_reply_to_id":178959636},"pull_request":{"url":"https://api.github.com/repos/apache/trafficserver/pulls/3123","id":169234637,"html_url":"https://github.com/apache/trafficserver/pull/3123","diff_url":"https://github.com/apache/trafficserver/pull/3123.diff","patch_url":"https://github.com/apache/trafficserver/pull/3123.patch","issue_url":"https://api.github.com/repos/apache/trafficserver/issues/3123","number":3123,"state":"open","locked":false,"title":"PROXY Protocol transformed to Forwarded HTTP heder.","user":{"login":"reveller","id":2183596,"avatar_url":"https://avatars0.githubusercontent.com/u/2183596?v=4","gravatar_id":"","url":"https://api.github.com/users/reveller","html_url":"https://github.com/reveller","followers_url":"https://api.github.com/users/reveller/followers","following_url":"https://api.github.com/users/reveller/following{/other_user}","gists_url":"https://api.github.com/users/reveller/gists{/gist_id}","starred_url":"https://api.github.com/users/reveller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reveller/subscriptions","organizations_url":"https://api.github.com/users/reveller/orgs","repos_url":"https://api.github.com/users/reveller/repos","events_url":"https://api.github.com/users/reveller/events{/privacy}","received_events_url":"https://api.github.com/users/reveller/received_events","type":"User","site_admin":false},"body":"This update automatically detects a PROXY protocol header that precludes either http or https incoming requests.  If the header is available, it is parsed and used internally by ATS as the client IP.  If the proxy.config.http.insert_forwarded if configured with the 'for:' field, the Forwarded: HTTP header sent to the origin servers will be populated with the client IP passed through the PROXY protocol header.  This will facilitate logging of the proper client IP versus load balancer IP.  In addition, the origin servers can now use this IP address for tasks such as authz and authn.","created_at":"2018-02-14T22:04:03Z","updated_at":"2018-04-13T17:43:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43828ae5ddcaf54d614f8b6037de67da1a2e86fe","assignee":{"login":"reveller","id":2183596,"avatar_url":"https://avatars0.githubusercontent.com/u/2183596?v=4","gravatar_id":"","url":"https://api.github.com/users/reveller","html_url":"https://github.com/reveller","followers_url":"https://api.github.com/users/reveller/followers","following_url":"https://api.github.com/users/reveller/following{/other_user}","gists_url":"https://api.github.com/users/reveller/gists{/gist_id}","starred_url":"https://api.github.com/users/reveller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reveller/subscriptions","organizations_url":"https://api.github.com/users/reveller/orgs","repos_url":"https://api.github.com/users/reveller/repos","events_url":"https://api.github.com/users/reveller/events{/privacy}","received_events_url":"https://api.github.com/users/reveller/received_events","type":"User","site_admin":false},"assignees":[{"login":"reveller","id":2183596,"avatar_url":"https://avatars0.githubusercontent.com/u/2183596?v=4","gravatar_id":"","url":"https://api.github.com/users/reveller","html_url":"https://github.com/reveller","followers_url":"https://api.github.com/users/reveller/followers","following_url":"https://api.github.com/users/reveller/following{/other_user}","gists_url":"https://api.github.com/users/reveller/gists{/gist_id}","starred_url":"https://api.github.com/users/reveller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reveller/subscriptions","organizations_url":"https://api.github.com/users/reveller/orgs","repos_url":"https://api.github.com/users/reveller/repos","events_url":"https://api.github.com/users/reveller/events{/privacy}","received_events_url":"https://api.github.com/users/reveller/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":374860755,"url":"https://api.github.com/repos/apache/trafficserver/labels/Core","name":"Core","color":"006b75","default":false}],"milestone":{"url":"https://api.github.com/repos/apache/trafficserver/milestones/6","html_url":"https://github.com/apache/trafficserver/milestone/6","labels_url":"https://api.github.com/repos/apache/trafficserver/milestones/6/labels","id":1763406,"number":6,"title":"8.0.0","description":"","creator":{"login":"zwoop","id":202131,"avatar_url":"https://avatars1.githubusercontent.com/u/202131?v=4","gravatar_id":"","url":"https://api.github.com/users/zwoop","html_url":"https://github.com/zwoop","followers_url":"https://api.github.com/users/zwoop/followers","following_url":"https://api.github.com/users/zwoop/following{/other_user}","gists_url":"https://api.github.com/users/zwoop/gists{/gist_id}","starred_url":"https://api.github.com/users/zwoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zwoop/subscriptions","organizations_url":"https://api.github.com/users/zwoop/orgs","repos_url":"https://api.github.com/users/zwoop/repos","events_url":"https://api.github.com/users/zwoop/events{/privacy}","received_events_url":"https://api.github.com/users/zwoop/received_events","type":"User","site_admin":false},"open_issues":80,"closed_issues":1011,"state":"open","created_at":"2016-05-12T22:13:34Z","updated_at":"2018-04-13T03:16:13Z","due_on":"2018-06-18T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/apache/trafficserver/pulls/3123/commits","review_comments_url":"https://api.github.com/repos/apache/trafficserver/pulls/3123/comments","review_comment_url":"https://api.github.com/repos/apache/trafficserver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/trafficserver/issues/3123/comments","statuses_url":"https://api.github.com/repos/apache/trafficserver/statuses/84e089d827dc4d89a737d6ebd942d87fa675b65f","head":{"label":"reveller:proxy-protocol-submit","ref":"proxy-protocol-submit","sha":"84e089d827dc4d89a737d6ebd942d87fa675b65f","user":{"login":"reveller","id":2183596,"avatar_url":"https://avatars0.githubusercontent.com/u/2183596?v=4","gravatar_id":"","url":"https://api.github.com/users/reveller","html_url":"https://github.com/reveller","followers_url":"https://api.github.com/users/reveller/followers","following_url":"https://api.github.com/users/reveller/following{/other_user}","gists_url":"https://api.github.com/users/reveller/gists{/gist_id}","starred_url":"https://api.github.com/users/reveller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reveller/subscriptions","organizations_url":"https://api.github.com/users/reveller/orgs","repos_url":"https://api.github.com/users/reveller/repos","events_url":"https://api.github.com/users/reveller/events{/privacy}","received_events_url":"https://api.github.com/users/reveller/received_events","type":"User","site_admin":false},"repo":{"id":41687643,"name":"trafficserver","full_name":"reveller/trafficserver","owner":{"login":"reveller","id":2183596,"avatar_url":"https://avatars0.githubusercontent.com/u/2183596?v=4","gravatar_id":"","url":"https://api.github.com/users/reveller","html_url":"https://github.com/reveller","followers_url":"https://api.github.com/users/reveller/followers","following_url":"https://api.github.com/users/reveller/following{/other_user}","gists_url":"https://api.github.com/users/reveller/gists{/gist_id}","starred_url":"https://api.github.com/users/reveller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reveller/subscriptions","organizations_url":"https://api.github.com/users/reveller/orgs","repos_url":"https://api.github.com/users/reveller/repos","events_url":"https://api.github.com/users/reveller/events{/privacy}","received_events_url":"https://api.github.com/users/reveller/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/reveller/trafficserver","description":"Mirror of Apache Traffic Server","fork":true,"url":"https://api.github.com/repos/reveller/trafficserver","forks_url":"https://api.github.com/repos/reveller/trafficserver/forks","keys_url":"https://api.github.com/repos/reveller/trafficserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reveller/trafficserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reveller/trafficserver/teams","hooks_url":"https://api.github.com/repos/reveller/trafficserver/hooks","issue_events_url":"https://api.github.com/repos/reveller/trafficserver/issues/events{/number}","events_url":"https://api.github.com/repos/reveller/trafficserver/events","assignees_url":"https://api.github.com/repos/reveller/trafficserver/assignees{/user}","branches_url":"https://api.github.com/repos/reveller/trafficserver/branches{/branch}","tags_url":"https://api.github.com/repos/reveller/trafficserver/tags","blobs_url":"https://api.github.com/repos/reveller/trafficserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reveller/trafficserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reveller/trafficserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/reveller/trafficserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reveller/trafficserver/statuses/{sha}","languages_url":"https://api.github.com/repos/reveller/trafficserver/languages","stargazers_url":"https://api.github.com/repos/reveller/trafficserver/stargazers","contributors_url":"https://api.github.com/repos/reveller/trafficserver/contributors","subscribers_url":"https://api.github.com/repos/reveller/trafficserver/subscribers","subscription_url":"https://api.github.com/repos/reveller/trafficserver/subscription","commits_url":"https://api.github.com/repos/reveller/trafficserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/reveller/trafficserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/reveller/trafficserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/reveller/trafficserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/reveller/trafficserver/contents/{+path}","compare_url":"https://api.github.com/repos/reveller/trafficserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reveller/trafficserver/merges","archive_url":"https://api.github.com/repos/reveller/trafficserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reveller/trafficserver/downloads","issues_url":"https://api.github.com/repos/reveller/trafficserver/issues{/number}","pulls_url":"https://api.github.com/repos/reveller/trafficserver/pulls{/number}","milestones_url":"https://api.github.com/repos/reveller/trafficserver/milestones{/number}","notifications_url":"https://api.github.com/repos/reveller/trafficserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reveller/trafficserver/labels{/name}","releases_url":"https://api.github.com/repos/reveller/trafficserver/releases{/id}","deployments_url":"https://api.github.com/repos/reveller/trafficserver/deployments","created_at":"2015-08-31T16:37:03Z","updated_at":"2016-05-18T00:11:26Z","pushed_at":"2018-04-12T20:40:24Z","git_url":"git://github.com/reveller/trafficserver.git","ssh_url":"git@github.com:reveller/trafficserver.git","clone_url":"https://github.com/reveller/trafficserver.git","svn_url":"https://github.com/reveller/trafficserver","homepage":null,"size":78866,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"d52f317f704bc87ba2ef223c2a6437df308eabf1","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":356066,"name":"trafficserver","full_name":"apache/trafficserver","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/trafficserver","description":"Mirror of Apache Traffic Server","fork":false,"url":"https://api.github.com/repos/apache/trafficserver","forks_url":"https://api.github.com/repos/apache/trafficserver/forks","keys_url":"https://api.github.com/repos/apache/trafficserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/trafficserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/trafficserver/teams","hooks_url":"https://api.github.com/repos/apache/trafficserver/hooks","issue_events_url":"https://api.github.com/repos/apache/trafficserver/issues/events{/number}","events_url":"https://api.github.com/repos/apache/trafficserver/events","assignees_url":"https://api.github.com/repos/apache/trafficserver/assignees{/user}","branches_url":"https://api.github.com/repos/apache/trafficserver/branches{/branch}","tags_url":"https://api.github.com/repos/apache/trafficserver/tags","blobs_url":"https://api.github.com/repos/apache/trafficserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/trafficserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/trafficserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/trafficserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/trafficserver/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/trafficserver/languages","stargazers_url":"https://api.github.com/repos/apache/trafficserver/stargazers","contributors_url":"https://api.github.com/repos/apache/trafficserver/contributors","subscribers_url":"https://api.github.com/repos/apache/trafficserver/subscribers","subscription_url":"https://api.github.com/repos/apache/trafficserver/subscription","commits_url":"https://api.github.com/repos/apache/trafficserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/trafficserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/trafficserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/trafficserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/trafficserver/contents/{+path}","compare_url":"https://api.github.com/repos/apache/trafficserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/trafficserver/merges","archive_url":"https://api.github.com/repos/apache/trafficserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/trafficserver/downloads","issues_url":"https://api.github.com/repos/apache/trafficserver/issues{/number}","pulls_url":"https://api.github.com/repos/apache/trafficserver/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/trafficserver/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/trafficserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/trafficserver/labels{/name}","releases_url":"https://api.github.com/repos/apache/trafficserver/releases{/id}","deployments_url":"https://api.github.com/repos/apache/trafficserver/deployments","created_at":"2009-10-31T08:00:10Z","updated_at":"2018-04-13T00:35:15Z","pushed_at":"2018-04-13T17:43:13Z","git_url":"git://github.com/apache/trafficserver.git","ssh_url":"git@github.com:apache/trafficserver.git","clone_url":"https://github.com/apache/trafficserver.git","svn_url":"https://github.com/apache/trafficserver","homepage":null,"size":82280,"stargazers_count":686,"watchers_count":686,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":508,"mirror_url":null,"archived":false,"open_issues_count":282,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":508,"open_issues":282,"watchers":686,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/3123"},"html":{"href":"https://github.com/apache/trafficserver/pull/3123"},"issue":{"href":"https://api.github.com/repos/apache/trafficserver/issues/3123"},"comments":{"href":"https://api.github.com/repos/apache/trafficserver/issues/3123/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/3123/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/3123/commits"},"statuses":{"href":"https://api.github.com/repos/apache/trafficserver/statuses/84e089d827dc4d89a737d6ebd942d87fa675b65f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"reveller"}}