{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls/comments/185581106","pull_request_review_id":116999545,"id":185581106,"diff_hunk":"@@ -0,0 +1,94 @@\n+﻿using System.Collections;\n+using System.Collections.Generic;\n+using UnityEngine;\n+\n+namespace HoloToolkit.ARCapture\n+{\n+    /// <summary>\n+    /// Utility for fading out marker\n+    /// </summary>\n+    public class TweenAlpha : MonoBehaviour\n+    {\n+        /// <summary>\n+        /// Alpha value to fade to\n+        /// </summary>\n+        [Tooltip(\"Alpha value to fade to\")]\n+        [SerializeField]\n+        private float targetAlpha;\n+        /// <summary>\n+        /// Alpha value to fade to\n+        /// </summary>\n+        public float TargetAlpha\n+        {\n+            get\n+            {\n+                return targetAlpha;\n+            }\n+\n+            set\n+            {\n+                targetAlpha = value;\n+            }\n+        }\n+\n+        /// <summary>\n+        /// Time taken to fade from current alpha to TargetAlpha\n+        /// </summary>\n+        [Tooltip(\"Time taken to fade from current alpha to TargetAlpha\")]\n+        [SerializeField]\n+        private float duration = 0.5f;\n+        /// <summary>\n+        /// Time taken to fade from current alpha to TargetAlpha\n+        /// </summary>\n+        public float Duration\n+        {\n+            get\n+            {\n+                return duration;\n+            }\n+\n+            set\n+            {\n+                duration = value;\n+            }\n+        }\n+\n+        /// <summary>\n+        /// Material to operate on\n+        /// </summary>\n+        private Material mat;\n+\n+\n+        void Start()","path":"Assets/HoloToolkit/SpectatorView/Scripts/Utils/TweenAlpha.cs","position":null,"original_position":62,"commit_id":"11aa7630fd4a7f62a6e24b28c8983b5a27343093","original_commit_id":"0b34d7f63231b5358c5aee26c35469e22dfd8b81","user":{"login":"StephenHodgson","id":13334553,"avatar_url":"https://avatars2.githubusercontent.com/u/13334553?v=4","gravatar_id":"","url":"https://api.github.com/users/StephenHodgson","html_url":"https://github.com/StephenHodgson","followers_url":"https://api.github.com/users/StephenHodgson/followers","following_url":"https://api.github.com/users/StephenHodgson/following{/other_user}","gists_url":"https://api.github.com/users/StephenHodgson/gists{/gist_id}","starred_url":"https://api.github.com/users/StephenHodgson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StephenHodgson/subscriptions","organizations_url":"https://api.github.com/users/StephenHodgson/orgs","repos_url":"https://api.github.com/users/StephenHodgson/repos","events_url":"https://api.github.com/users/StephenHodgson/events{/privacy}","received_events_url":"https://api.github.com/users/StephenHodgson/received_events","type":"User","site_admin":false},"body":"Nit: explicit access modifiers","created_at":"2018-05-02T17:46:31Z","updated_at":"2018-05-02T17:46:31Z","html_url":"https://github.com/Microsoft/MixedRealityToolkit-Unity/pull/1884#discussion_r185581106","pull_request_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls/1884","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls/comments/185581106"},"html":{"href":"https://github.com/Microsoft/MixedRealityToolkit-Unity/pull/1884#discussion_r185581106"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls/1884"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls/1884","id":177667462,"html_url":"https://github.com/Microsoft/MixedRealityToolkit-Unity/pull/1884","diff_url":"https://github.com/Microsoft/MixedRealityToolkit-Unity/pull/1884.diff","patch_url":"https://github.com/Microsoft/MixedRealityToolkit-Unity/pull/1884.patch","issue_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/issues/1884","number":1884,"state":"open","locked":false,"title":"Feature: SpectatorView integration","user":{"login":"danielescudero","id":19855491,"avatar_url":"https://avatars2.githubusercontent.com/u/19855491?v=4","gravatar_id":"","url":"https://api.github.com/users/danielescudero","html_url":"https://github.com/danielescudero","followers_url":"https://api.github.com/users/danielescudero/followers","following_url":"https://api.github.com/users/danielescudero/following{/other_user}","gists_url":"https://api.github.com/users/danielescudero/gists{/gist_id}","starred_url":"https://api.github.com/users/danielescudero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielescudero/subscriptions","organizations_url":"https://api.github.com/users/danielescudero/orgs","repos_url":"https://api.github.com/users/danielescudero/repos","events_url":"https://api.github.com/users/danielescudero/events{/privacy}","received_events_url":"https://api.github.com/users/danielescudero/received_events","type":"User","site_admin":false},"body":"Overview\r\n---\r\nThis is an implementation of Spectator View that takes advantage of the ARKit for iOS and ARKit capable devices. Users of those devices can witness what HoloLens users are experiencing. They can even record straight from their phones.\r\n\r\nFeatures\r\n---\r\n•\tSpatial synchronization of Holograms, so phones see holograms where HoloLens see’s them.\r\n•\tNetwork auto-discovery for adding ARKit capable devices to a session. All networking is implemented using Unet.\r\n•\tAutomatic session handling, so users are added to the correct session (when multiple HoloLens sessions run on the same network).\r\n•\tiOS support (ARKit capable devices).\r\n•\tMultiple iOS guests.\r\n•\tRecording of Video + Holograms + Ambient sound + Hologram Sounds.\r\n•\tShare sheet so you can Save the Video, email it, or share it with other supporting apps.\r\n•\tSwitches elegantly between platforms in Unity Editor.\r\n","created_at":"2018-03-27T08:37:25Z","updated_at":"2018-05-02T17:46:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"19cf74074c7143691861958e36373925944b3e82","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":318131837,"url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/labels/Enhancement","name":"Enhancement","color":"84b6eb","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls/1884/commits","review_comments_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls/1884/comments","review_comment_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/issues/1884/comments","statuses_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/statuses/11aa7630fd4a7f62a6e24b28c8983b5a27343093","head":{"label":"danielescudero:feature/ARCAintegration","ref":"feature/ARCAintegration","sha":"11aa7630fd4a7f62a6e24b28c8983b5a27343093","user":{"login":"danielescudero","id":19855491,"avatar_url":"https://avatars2.githubusercontent.com/u/19855491?v=4","gravatar_id":"","url":"https://api.github.com/users/danielescudero","html_url":"https://github.com/danielescudero","followers_url":"https://api.github.com/users/danielescudero/followers","following_url":"https://api.github.com/users/danielescudero/following{/other_user}","gists_url":"https://api.github.com/users/danielescudero/gists{/gist_id}","starred_url":"https://api.github.com/users/danielescudero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielescudero/subscriptions","organizations_url":"https://api.github.com/users/danielescudero/orgs","repos_url":"https://api.github.com/users/danielescudero/repos","events_url":"https://api.github.com/users/danielescudero/events{/privacy}","received_events_url":"https://api.github.com/users/danielescudero/received_events","type":"User","site_admin":false},"repo":{"id":126796875,"name":"MixedRealityToolkit-Unity","full_name":"danielescudero/MixedRealityToolkit-Unity","owner":{"login":"danielescudero","id":19855491,"avatar_url":"https://avatars2.githubusercontent.com/u/19855491?v=4","gravatar_id":"","url":"https://api.github.com/users/danielescudero","html_url":"https://github.com/danielescudero","followers_url":"https://api.github.com/users/danielescudero/followers","following_url":"https://api.github.com/users/danielescudero/following{/other_user}","gists_url":"https://api.github.com/users/danielescudero/gists{/gist_id}","starred_url":"https://api.github.com/users/danielescudero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielescudero/subscriptions","organizations_url":"https://api.github.com/users/danielescudero/orgs","repos_url":"https://api.github.com/users/danielescudero/repos","events_url":"https://api.github.com/users/danielescudero/events{/privacy}","received_events_url":"https://api.github.com/users/danielescudero/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danielescudero/MixedRealityToolkit-Unity","description":"MixedRealityToolkit-Unity uses code from the base MixedRealityToolkit repository and makes it easier to consume in Unity.","fork":true,"url":"https://api.github.com/repos/danielescudero/MixedRealityToolkit-Unity","forks_url":"https://api.github.com/repos/danielescudero/MixedRealityToolkit-Unity/forks","keys_url":"https://api.github.com/repos/danielescudero/MixedRealityToolkit-Unity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danielescudero/MixedRealityToolkit-Unity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danielescudero/MixedRealityToolkit-Unity/teams","hooks_url":"https://api.github.com/repos/danielescudero/MixedRealityToolkit-Unity/hooks","issue_events_url":"https://api.github.com/repos/danielescudero/MixedRealityToolkit-Unity/issues/events{/number}","events_url":"https://api.github.com/repos/danielescudero/MixedRealityToolkit-Unity/events","assignees_url":"https://api.github.com/repos/danielescudero/MixedRealityToolkit-Unity/assignees{/user}","branches_url":"https://api.github.com/repos/danielescudero/MixedRealityToolkit-Unity/branches{/branch}","tags_url":"https://api.github.com/repos/danielescudero/MixedRealityToolkit-Unity/tags","blobs_url":"https://api.github.com/repos/danielescudero/MixedRealityToolkit-Unity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danielescudero/MixedRealityToolkit-Unity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danielescudero/MixedRealityToolkit-Unity/git/refs{/sha}","trees_url":"https://api.github.com/repos/danielescudero/MixedRealityToolkit-Unity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danielescudero/MixedRealityToolkit-Unity/statuses/{sha}","languages_url":"https://api.github.com/repos/danielescudero/MixedRealityToolkit-Unity/languages","stargazers_url":"https://api.github.com/repos/danielescudero/MixedRealityToolkit-Unity/stargazers","contributors_url":"https://api.github.com/repos/danielescudero/MixedRealityToolkit-Unity/contributors","subscribers_url":"https://api.github.com/repos/danielescudero/MixedRealityToolkit-Unity/subscribers","subscription_url":"https://api.github.com/repos/danielescudero/MixedRealityToolkit-Unity/subscription","commits_url":"https://api.github.com/repos/danielescudero/MixedRealityToolkit-Unity/commits{/sha}","git_commits_url":"https://api.github.com/repos/danielescudero/MixedRealityToolkit-Unity/git/commits{/sha}","comments_url":"https://api.github.com/repos/danielescudero/MixedRealityToolkit-Unity/comments{/number}","issue_comment_url":"https://api.github.com/repos/danielescudero/MixedRealityToolkit-Unity/issues/comments{/number}","contents_url":"https://api.github.com/repos/danielescudero/MixedRealityToolkit-Unity/contents/{+path}","compare_url":"https://api.github.com/repos/danielescudero/MixedRealityToolkit-Unity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danielescudero/MixedRealityToolkit-Unity/merges","archive_url":"https://api.github.com/repos/danielescudero/MixedRealityToolkit-Unity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danielescudero/MixedRealityToolkit-Unity/downloads","issues_url":"https://api.github.com/repos/danielescudero/MixedRealityToolkit-Unity/issues{/number}","pulls_url":"https://api.github.com/repos/danielescudero/MixedRealityToolkit-Unity/pulls{/number}","milestones_url":"https://api.github.com/repos/danielescudero/MixedRealityToolkit-Unity/milestones{/number}","notifications_url":"https://api.github.com/repos/danielescudero/MixedRealityToolkit-Unity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danielescudero/MixedRealityToolkit-Unity/labels{/name}","releases_url":"https://api.github.com/repos/danielescudero/MixedRealityToolkit-Unity/releases{/id}","deployments_url":"https://api.github.com/repos/danielescudero/MixedRealityToolkit-Unity/deployments","created_at":"2018-03-26T08:22:31Z","updated_at":"2018-03-26T08:22:51Z","pushed_at":"2018-05-02T15:57:17Z","git_url":"git://github.com/danielescudero/MixedRealityToolkit-Unity.git","ssh_url":"git@github.com:danielescudero/MixedRealityToolkit-Unity.git","clone_url":"https://github.com/danielescudero/MixedRealityToolkit-Unity.git","svn_url":"https://github.com/danielescudero/MixedRealityToolkit-Unity","homepage":"","size":606481,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:may18_dev","ref":"may18_dev","sha":"8bff7834f0829509ba42cb6f4125516f01bed40e","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":50605426,"name":"MixedRealityToolkit-Unity","full_name":"Microsoft/MixedRealityToolkit-Unity","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/MixedRealityToolkit-Unity","description":"MixedRealityToolkit-Unity uses code from the base MixedRealityToolkit repository and makes it easier to consume in Unity.","fork":false,"url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity","forks_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/forks","keys_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/teams","hooks_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/events","assignees_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/tags","blobs_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/languages","stargazers_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/subscription","commits_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/merges","archive_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/downloads","issues_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/deployments","created_at":"2016-01-28T18:54:58Z","updated_at":"2018-05-02T15:32:01Z","pushed_at":"2018-05-02T15:57:21Z","git_url":"git://github.com/Microsoft/MixedRealityToolkit-Unity.git","ssh_url":"git@github.com:Microsoft/MixedRealityToolkit-Unity.git","clone_url":"https://github.com/Microsoft/MixedRealityToolkit-Unity.git","svn_url":"https://github.com/Microsoft/MixedRealityToolkit-Unity","homepage":"","size":603992,"stargazers_count":1683,"watchers_count":1683,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":833,"mirror_url":null,"archived":false,"open_issues_count":367,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":833,"open_issues":367,"watchers":1683,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls/1884"},"html":{"href":"https://github.com/Microsoft/MixedRealityToolkit-Unity/pull/1884"},"issue":{"href":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/issues/1884"},"comments":{"href":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/issues/1884/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls/1884/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls/1884/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/statuses/11aa7630fd4a7f62a6e24b28c8983b5a27343093"}},"author_association":"NONE"}}
{"actor":{"display_login":"StephenHodgson"}}