{"action":"closed","number":1297,"pull_request":{"url":"https://api.github.com/repos/apache/mynewt-core/pulls/1297","id":204227945,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MjI3OTQ1","html_url":"https://github.com/apache/mynewt-core/pull/1297","diff_url":"https://github.com/apache/mynewt-core/pull/1297.diff","patch_url":"https://github.com/apache/mynewt-core/pull/1297.patch","issue_url":"https://api.github.com/repos/apache/mynewt-core/issues/1297","number":1297,"state":"closed","locked":false,"title":"Fix some issues with the L1/L0 flash driver","user":{"login":"utzig","id":107070,"node_id":"MDQ6VXNlcjEwNzA3MA==","avatar_url":"https://avatars0.githubusercontent.com/u/107070?v=4","gravatar_id":"","url":"https://api.github.com/users/utzig","html_url":"https://github.com/utzig","followers_url":"https://api.github.com/users/utzig/followers","following_url":"https://api.github.com/users/utzig/following{/other_user}","gists_url":"https://api.github.com/users/utzig/gists{/gist_id}","starred_url":"https://api.github.com/users/utzig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/utzig/subscriptions","organizations_url":"https://api.github.com/users/utzig/orgs","repos_url":"https://api.github.com/users/utzig/repos","events_url":"https://api.github.com/users/utzig/events{/privacy}","received_events_url":"https://api.github.com/users/utzig/received_events","type":"User","site_admin":false},"body":"- Fix alignment;\r\n- Disable write protection just while erasing/writing instead of always leaving the flash unlocked. Since the watchdog was left on in Mynewt when asking for an upgrade, and not initialized on MCUBoot, the tickle in this driver was causing an invalid write to the flash, that was unprotected, as well as a restart failing verification of the swapped image. A related watchdog issue is being submitted to MCUBoot;\r\n- Other small refactorings applied to ease merging L4/L1/L0 into one single configurable flash driver.","created_at":"2018-07-26T18:27:17Z","updated_at":"2018-07-30T11:31:25Z","closed_at":"2018-07-30T11:31:25Z","merged_at":"2018-07-30T11:31:25Z","merge_commit_sha":"5e5dee8148123bd9b592311bd1271ab245833eab","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/mynewt-core/pulls/1297/commits","review_comments_url":"https://api.github.com/repos/apache/mynewt-core/pulls/1297/comments","review_comment_url":"https://api.github.com/repos/apache/mynewt-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/mynewt-core/issues/1297/comments","statuses_url":"https://api.github.com/repos/apache/mynewt-core/statuses/eb09e90b6a98a0e0d8e56f75d665dbd5b756adc7","head":{"label":"utzig:stm32l1-flash-updates","ref":"stm32l1-flash-updates","sha":"eb09e90b6a98a0e0d8e56f75d665dbd5b756adc7","user":{"login":"utzig","id":107070,"node_id":"MDQ6VXNlcjEwNzA3MA==","avatar_url":"https://avatars0.githubusercontent.com/u/107070?v=4","gravatar_id":"","url":"https://api.github.com/users/utzig","html_url":"https://github.com/utzig","followers_url":"https://api.github.com/users/utzig/followers","following_url":"https://api.github.com/users/utzig/following{/other_user}","gists_url":"https://api.github.com/users/utzig/gists{/gist_id}","starred_url":"https://api.github.com/users/utzig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/utzig/subscriptions","organizations_url":"https://api.github.com/users/utzig/orgs","repos_url":"https://api.github.com/users/utzig/repos","events_url":"https://api.github.com/users/utzig/events{/privacy}","received_events_url":"https://api.github.com/users/utzig/received_events","type":"User","site_admin":false},"repo":{"id":66736866,"node_id":"MDEwOlJlcG9zaXRvcnk2NjczNjg2Ng==","name":"mynewt-core","full_name":"utzig/mynewt-core","owner":{"login":"utzig","id":107070,"node_id":"MDQ6VXNlcjEwNzA3MA==","avatar_url":"https://avatars0.githubusercontent.com/u/107070?v=4","gravatar_id":"","url":"https://api.github.com/users/utzig","html_url":"https://github.com/utzig","followers_url":"https://api.github.com/users/utzig/followers","following_url":"https://api.github.com/users/utzig/following{/other_user}","gists_url":"https://api.github.com/users/utzig/gists{/gist_id}","starred_url":"https://api.github.com/users/utzig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/utzig/subscriptions","organizations_url":"https://api.github.com/users/utzig/orgs","repos_url":"https://api.github.com/users/utzig/repos","events_url":"https://api.github.com/users/utzig/events{/privacy}","received_events_url":"https://api.github.com/users/utzig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/utzig/mynewt-core","description":"Apache Mynewt Core","fork":true,"url":"https://api.github.com/repos/utzig/mynewt-core","forks_url":"https://api.github.com/repos/utzig/mynewt-core/forks","keys_url":"https://api.github.com/repos/utzig/mynewt-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/utzig/mynewt-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/utzig/mynewt-core/teams","hooks_url":"https://api.github.com/repos/utzig/mynewt-core/hooks","issue_events_url":"https://api.github.com/repos/utzig/mynewt-core/issues/events{/number}","events_url":"https://api.github.com/repos/utzig/mynewt-core/events","assignees_url":"https://api.github.com/repos/utzig/mynewt-core/assignees{/user}","branches_url":"https://api.github.com/repos/utzig/mynewt-core/branches{/branch}","tags_url":"https://api.github.com/repos/utzig/mynewt-core/tags","blobs_url":"https://api.github.com/repos/utzig/mynewt-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/utzig/mynewt-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/utzig/mynewt-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/utzig/mynewt-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/utzig/mynewt-core/statuses/{sha}","languages_url":"https://api.github.com/repos/utzig/mynewt-core/languages","stargazers_url":"https://api.github.com/repos/utzig/mynewt-core/stargazers","contributors_url":"https://api.github.com/repos/utzig/mynewt-core/contributors","subscribers_url":"https://api.github.com/repos/utzig/mynewt-core/subscribers","subscription_url":"https://api.github.com/repos/utzig/mynewt-core/subscription","commits_url":"https://api.github.com/repos/utzig/mynewt-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/utzig/mynewt-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/utzig/mynewt-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/utzig/mynewt-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/utzig/mynewt-core/contents/{+path}","compare_url":"https://api.github.com/repos/utzig/mynewt-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/utzig/mynewt-core/merges","archive_url":"https://api.github.com/repos/utzig/mynewt-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/utzig/mynewt-core/downloads","issues_url":"https://api.github.com/repos/utzig/mynewt-core/issues{/number}","pulls_url":"https://api.github.com/repos/utzig/mynewt-core/pulls{/number}","milestones_url":"https://api.github.com/repos/utzig/mynewt-core/milestones{/number}","notifications_url":"https://api.github.com/repos/utzig/mynewt-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/utzig/mynewt-core/labels{/name}","releases_url":"https://api.github.com/repos/utzig/mynewt-core/releases{/id}","deployments_url":"https://api.github.com/repos/utzig/mynewt-core/deployments","created_at":"2016-08-27T21:44:45Z","updated_at":"2018-07-18T19:16:02Z","pushed_at":"2018-07-27T17:10:24Z","git_url":"git://github.com/utzig/mynewt-core.git","ssh_url":"git@github.com:utzig/mynewt-core.git","clone_url":"https://github.com/utzig/mynewt-core.git","svn_url":"https://github.com/utzig/mynewt-core","homepage":"","size":157669,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"b886f237076f8206ffc1c8f0b451ae61abd023b4","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":45165993,"node_id":"MDEwOlJlcG9zaXRvcnk0NTE2NTk5Mw==","name":"mynewt-core","full_name":"apache/mynewt-core","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/mynewt-core","description":"An OS to build, deploy and securely manage billions of devices","fork":false,"url":"https://api.github.com/repos/apache/mynewt-core","forks_url":"https://api.github.com/repos/apache/mynewt-core/forks","keys_url":"https://api.github.com/repos/apache/mynewt-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/mynewt-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/mynewt-core/teams","hooks_url":"https://api.github.com/repos/apache/mynewt-core/hooks","issue_events_url":"https://api.github.com/repos/apache/mynewt-core/issues/events{/number}","events_url":"https://api.github.com/repos/apache/mynewt-core/events","assignees_url":"https://api.github.com/repos/apache/mynewt-core/assignees{/user}","branches_url":"https://api.github.com/repos/apache/mynewt-core/branches{/branch}","tags_url":"https://api.github.com/repos/apache/mynewt-core/tags","blobs_url":"https://api.github.com/repos/apache/mynewt-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/mynewt-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/mynewt-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/mynewt-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/mynewt-core/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/mynewt-core/languages","stargazers_url":"https://api.github.com/repos/apache/mynewt-core/stargazers","contributors_url":"https://api.github.com/repos/apache/mynewt-core/contributors","subscribers_url":"https://api.github.com/repos/apache/mynewt-core/subscribers","subscription_url":"https://api.github.com/repos/apache/mynewt-core/subscription","commits_url":"https://api.github.com/repos/apache/mynewt-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/mynewt-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/mynewt-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/mynewt-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/mynewt-core/contents/{+path}","compare_url":"https://api.github.com/repos/apache/mynewt-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/mynewt-core/merges","archive_url":"https://api.github.com/repos/apache/mynewt-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/mynewt-core/downloads","issues_url":"https://api.github.com/repos/apache/mynewt-core/issues{/number}","pulls_url":"https://api.github.com/repos/apache/mynewt-core/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/mynewt-core/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/mynewt-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/mynewt-core/labels{/name}","releases_url":"https://api.github.com/repos/apache/mynewt-core/releases{/id}","deployments_url":"https://api.github.com/repos/apache/mynewt-core/deployments","created_at":"2015-10-29T07:00:07Z","updated_at":"2018-07-29T13:29:12Z","pushed_at":"2018-07-30T11:31:25Z","git_url":"git://github.com/apache/mynewt-core.git","ssh_url":"git@github.com:apache/mynewt-core.git","clone_url":"https://github.com/apache/mynewt-core.git","svn_url":"https://github.com/apache/mynewt-core","homepage":"https://mynewt.apache.org/","size":156819,"stargazers_count":363,"watchers_count":363,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":181,"mirror_url":null,"archived":false,"open_issues_count":50,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":181,"open_issues":50,"watchers":363,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/mynewt-core/pulls/1297"},"html":{"href":"https://github.com/apache/mynewt-core/pull/1297"},"issue":{"href":"https://api.github.com/repos/apache/mynewt-core/issues/1297"},"comments":{"href":"https://api.github.com/repos/apache/mynewt-core/issues/1297/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/mynewt-core/pulls/1297/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/mynewt-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/mynewt-core/pulls/1297/commits"},"statuses":{"href":"https://api.github.com/repos/apache/mynewt-core/statuses/eb09e90b6a98a0e0d8e56f75d665dbd5b756adc7"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"utzig","id":107070,"node_id":"MDQ6VXNlcjEwNzA3MA==","avatar_url":"https://avatars0.githubusercontent.com/u/107070?v=4","gravatar_id":"","url":"https://api.github.com/users/utzig","html_url":"https://github.com/utzig","followers_url":"https://api.github.com/users/utzig/followers","following_url":"https://api.github.com/users/utzig/following{/other_user}","gists_url":"https://api.github.com/users/utzig/gists{/gist_id}","starred_url":"https://api.github.com/users/utzig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/utzig/subscriptions","organizations_url":"https://api.github.com/users/utzig/orgs","repos_url":"https://api.github.com/users/utzig/repos","events_url":"https://api.github.com/users/utzig/events{/privacy}","received_events_url":"https://api.github.com/users/utzig/received_events","type":"User","site_admin":false},"comments":4,"review_comments":4,"maintainer_can_modify":false,"commits":1,"additions":38,"deletions":11,"changed_files":2}}
{"actor":{"display_login":"utzig"}}