{"action":"created","comment":{"url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/pulls/comments/168816444","pull_request_review_id":97251341,"id":168816444,"diff_hunk":"@@ -129,10 +124,14 @@ void get_full_type_inner(SEXP sexp, SEXP rho, full_sexp_type &result,\n                 return;","path":"src/sexptypes.cpp","position":23,"original_position":31,"commit_id":"24a0638773d9b8e6ce744779ef511f3aeb194a44","original_commit_id":"24a0638773d9b8e6ce744779ef511f3aeb194a44","user":{"login":"aviralg","id":4531751,"avatar_url":"https://avatars3.githubusercontent.com/u/4531751?v=4","gravatar_id":"","url":"https://api.github.com/users/aviralg","html_url":"https://github.com/aviralg","followers_url":"https://api.github.com/users/aviralg/followers","following_url":"https://api.github.com/users/aviralg/following{/other_user}","gists_url":"https://api.github.com/users/aviralg/gists{/gist_id}","starred_url":"https://api.github.com/users/aviralg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aviralg/subscriptions","organizations_url":"https://api.github.com/users/aviralg/orgs","repos_url":"https://api.github.com/users/aviralg/repos","events_url":"https://api.github.com/users/aviralg/events{/privacy}","received_events_url":"https://api.github.com/users/aviralg/received_events","type":"User","site_admin":false},"body":"Can we end at active bindings? We know that an active binding means the symbol is bound to a function that will be called automatically when the symbol is looked up or reassigned. So, adding the type of function after active binding may not be insightful. Also, ending at active binding lets our script show the type of this symbol as ACTIVE_BINDING which is a useful thing to know in itself.","created_at":"2018-02-16T17:13:06Z","updated_at":"2018-02-16T17:13:06Z","html_url":"https://github.com/PRL-PRG/promisedyntracer/pull/39#discussion_r168816444","pull_request_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/pulls/39","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/PRL-PRG/promisedyntracer/pulls/comments/168816444"},"html":{"href":"https://github.com/PRL-PRG/promisedyntracer/pull/39#discussion_r168816444"},"pull_request":{"href":"https://api.github.com/repos/PRL-PRG/promisedyntracer/pulls/39"}}},"pull_request":{"url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/pulls/39","id":169604700,"html_url":"https://github.com/PRL-PRG/promisedyntracer/pull/39","diff_url":"https://github.com/PRL-PRG/promisedyntracer/pull/39.diff","patch_url":"https://github.com/PRL-PRG/promisedyntracer/pull/39.patch","issue_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/issues/39","number":39,"state":"open","locked":false,"title":"Fix unwinding partially and track environment","user":{"login":"kondziu","id":50334,"avatar_url":"https://avatars2.githubusercontent.com/u/50334?v=4","gravatar_id":"","url":"https://api.github.com/users/kondziu","html_url":"https://github.com/kondziu","followers_url":"https://api.github.com/users/kondziu/followers","following_url":"https://api.github.com/users/kondziu/following{/other_user}","gists_url":"https://api.github.com/users/kondziu/gists{/gist_id}","starred_url":"https://api.github.com/users/kondziu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kondziu/subscriptions","organizations_url":"https://api.github.com/users/kondziu/orgs","repos_url":"https://api.github.com/users/kondziu/repos","events_url":"https://api.github.com/users/kondziu/events{/privacy}","received_events_url":"https://api.github.com/users/kondziu/received_events","type":"User","site_admin":false},"body":"It fixes some of the problems with unwinding the stack, but not completely: some packages still cause problems. This is #37.\r\n\r\nIt also fixes #38: type traces to remove the promises that have cycles. ","created_at":"2018-02-16T11:44:17Z","updated_at":"2018-02-16T17:13:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14e45c6ef28a98e33a6cd5874c3bdfd8b37c474a","assignee":{"login":"aviralg","id":4531751,"avatar_url":"https://avatars3.githubusercontent.com/u/4531751?v=4","gravatar_id":"","url":"https://api.github.com/users/aviralg","html_url":"https://github.com/aviralg","followers_url":"https://api.github.com/users/aviralg/followers","following_url":"https://api.github.com/users/aviralg/following{/other_user}","gists_url":"https://api.github.com/users/aviralg/gists{/gist_id}","starred_url":"https://api.github.com/users/aviralg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aviralg/subscriptions","organizations_url":"https://api.github.com/users/aviralg/orgs","repos_url":"https://api.github.com/users/aviralg/repos","events_url":"https://api.github.com/users/aviralg/events{/privacy}","received_events_url":"https://api.github.com/users/aviralg/received_events","type":"User","site_admin":false},"assignees":[{"login":"aviralg","id":4531751,"avatar_url":"https://avatars3.githubusercontent.com/u/4531751?v=4","gravatar_id":"","url":"https://api.github.com/users/aviralg","html_url":"https://github.com/aviralg","followers_url":"https://api.github.com/users/aviralg/followers","following_url":"https://api.github.com/users/aviralg/following{/other_user}","gists_url":"https://api.github.com/users/aviralg/gists{/gist_id}","starred_url":"https://api.github.com/users/aviralg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aviralg/subscriptions","organizations_url":"https://api.github.com/users/aviralg/orgs","repos_url":"https://api.github.com/users/aviralg/repos","events_url":"https://api.github.com/users/aviralg/events{/privacy}","received_events_url":"https://api.github.com/users/aviralg/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/pulls/39/commits","review_comments_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/pulls/39/comments","review_comment_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/issues/39/comments","statuses_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/statuses/24a0638773d9b8e6ce744779ef511f3aeb194a44","head":{"label":"PRL-PRG:fix_unwinding_partially_and_track_environment","ref":"fix_unwinding_partially_and_track_environment","sha":"24a0638773d9b8e6ce744779ef511f3aeb194a44","user":{"login":"PRL-PRG","id":22217634,"avatar_url":"https://avatars1.githubusercontent.com/u/22217634?v=4","gravatar_id":"","url":"https://api.github.com/users/PRL-PRG","html_url":"https://github.com/PRL-PRG","followers_url":"https://api.github.com/users/PRL-PRG/followers","following_url":"https://api.github.com/users/PRL-PRG/following{/other_user}","gists_url":"https://api.github.com/users/PRL-PRG/gists{/gist_id}","starred_url":"https://api.github.com/users/PRL-PRG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PRL-PRG/subscriptions","organizations_url":"https://api.github.com/users/PRL-PRG/orgs","repos_url":"https://api.github.com/users/PRL-PRG/repos","events_url":"https://api.github.com/users/PRL-PRG/events{/privacy}","received_events_url":"https://api.github.com/users/PRL-PRG/received_events","type":"Organization","site_admin":false},"repo":{"id":108461502,"name":"promisedyntracer","full_name":"PRL-PRG/promisedyntracer","owner":{"login":"PRL-PRG","id":22217634,"avatar_url":"https://avatars1.githubusercontent.com/u/22217634?v=4","gravatar_id":"","url":"https://api.github.com/users/PRL-PRG","html_url":"https://github.com/PRL-PRG","followers_url":"https://api.github.com/users/PRL-PRG/followers","following_url":"https://api.github.com/users/PRL-PRG/following{/other_user}","gists_url":"https://api.github.com/users/PRL-PRG/gists{/gist_id}","starred_url":"https://api.github.com/users/PRL-PRG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PRL-PRG/subscriptions","organizations_url":"https://api.github.com/users/PRL-PRG/orgs","repos_url":"https://api.github.com/users/PRL-PRG/repos","events_url":"https://api.github.com/users/PRL-PRG/events{/privacy}","received_events_url":"https://api.github.com/users/PRL-PRG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PRL-PRG/promisedyntracer","description":"Tracer for promises in R","fork":false,"url":"https://api.github.com/repos/PRL-PRG/promisedyntracer","forks_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/forks","keys_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/teams","hooks_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/hooks","issue_events_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/issues/events{/number}","events_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/events","assignees_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/assignees{/user}","branches_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/branches{/branch}","tags_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/tags","blobs_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/git/refs{/sha}","trees_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/statuses/{sha}","languages_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/languages","stargazers_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/stargazers","contributors_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/contributors","subscribers_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/subscribers","subscription_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/subscription","commits_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/commits{/sha}","git_commits_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/git/commits{/sha}","comments_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/comments{/number}","issue_comment_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/issues/comments{/number}","contents_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/contents/{+path}","compare_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/merges","archive_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/downloads","issues_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/issues{/number}","pulls_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/pulls{/number}","milestones_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/milestones{/number}","notifications_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/labels{/name}","releases_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/releases{/id}","deployments_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/deployments","created_at":"2017-10-26T20:21:24Z","updated_at":"2018-01-19T13:50:49Z","pushed_at":"2018-02-16T11:44:17Z","git_url":"git://github.com/PRL-PRG/promisedyntracer.git","ssh_url":"git@github.com:PRL-PRG/promisedyntracer.git","clone_url":"https://github.com/PRL-PRG/promisedyntracer.git","svn_url":"https://github.com/PRL-PRG/promisedyntracer","homepage":null,"size":2137,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":11,"license":null,"forks":1,"open_issues":11,"watchers":1,"default_branch":"master"}},"base":{"label":"PRL-PRG:master","ref":"master","sha":"2184ec06e1b22fcb96bcec5ff1f78eb5d3bf6cb3","user":{"login":"PRL-PRG","id":22217634,"avatar_url":"https://avatars1.githubusercontent.com/u/22217634?v=4","gravatar_id":"","url":"https://api.github.com/users/PRL-PRG","html_url":"https://github.com/PRL-PRG","followers_url":"https://api.github.com/users/PRL-PRG/followers","following_url":"https://api.github.com/users/PRL-PRG/following{/other_user}","gists_url":"https://api.github.com/users/PRL-PRG/gists{/gist_id}","starred_url":"https://api.github.com/users/PRL-PRG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PRL-PRG/subscriptions","organizations_url":"https://api.github.com/users/PRL-PRG/orgs","repos_url":"https://api.github.com/users/PRL-PRG/repos","events_url":"https://api.github.com/users/PRL-PRG/events{/privacy}","received_events_url":"https://api.github.com/users/PRL-PRG/received_events","type":"Organization","site_admin":false},"repo":{"id":108461502,"name":"promisedyntracer","full_name":"PRL-PRG/promisedyntracer","owner":{"login":"PRL-PRG","id":22217634,"avatar_url":"https://avatars1.githubusercontent.com/u/22217634?v=4","gravatar_id":"","url":"https://api.github.com/users/PRL-PRG","html_url":"https://github.com/PRL-PRG","followers_url":"https://api.github.com/users/PRL-PRG/followers","following_url":"https://api.github.com/users/PRL-PRG/following{/other_user}","gists_url":"https://api.github.com/users/PRL-PRG/gists{/gist_id}","starred_url":"https://api.github.com/users/PRL-PRG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PRL-PRG/subscriptions","organizations_url":"https://api.github.com/users/PRL-PRG/orgs","repos_url":"https://api.github.com/users/PRL-PRG/repos","events_url":"https://api.github.com/users/PRL-PRG/events{/privacy}","received_events_url":"https://api.github.com/users/PRL-PRG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PRL-PRG/promisedyntracer","description":"Tracer for promises in R","fork":false,"url":"https://api.github.com/repos/PRL-PRG/promisedyntracer","forks_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/forks","keys_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/teams","hooks_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/hooks","issue_events_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/issues/events{/number}","events_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/events","assignees_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/assignees{/user}","branches_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/branches{/branch}","tags_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/tags","blobs_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/git/refs{/sha}","trees_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/statuses/{sha}","languages_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/languages","stargazers_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/stargazers","contributors_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/contributors","subscribers_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/subscribers","subscription_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/subscription","commits_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/commits{/sha}","git_commits_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/git/commits{/sha}","comments_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/comments{/number}","issue_comment_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/issues/comments{/number}","contents_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/contents/{+path}","compare_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/merges","archive_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/downloads","issues_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/issues{/number}","pulls_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/pulls{/number}","milestones_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/milestones{/number}","notifications_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/labels{/name}","releases_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/releases{/id}","deployments_url":"https://api.github.com/repos/PRL-PRG/promisedyntracer/deployments","created_at":"2017-10-26T20:21:24Z","updated_at":"2018-01-19T13:50:49Z","pushed_at":"2018-02-16T11:44:17Z","git_url":"git://github.com/PRL-PRG/promisedyntracer.git","ssh_url":"git@github.com:PRL-PRG/promisedyntracer.git","clone_url":"https://github.com/PRL-PRG/promisedyntracer.git","svn_url":"https://github.com/PRL-PRG/promisedyntracer","homepage":null,"size":2137,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":11,"license":null,"forks":1,"open_issues":11,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PRL-PRG/promisedyntracer/pulls/39"},"html":{"href":"https://github.com/PRL-PRG/promisedyntracer/pull/39"},"issue":{"href":"https://api.github.com/repos/PRL-PRG/promisedyntracer/issues/39"},"comments":{"href":"https://api.github.com/repos/PRL-PRG/promisedyntracer/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/PRL-PRG/promisedyntracer/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/PRL-PRG/promisedyntracer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PRL-PRG/promisedyntracer/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/PRL-PRG/promisedyntracer/statuses/24a0638773d9b8e6ce744779ef511f3aeb194a44"}},"author_association":"OWNER"}}
{"actor":{"display_login":"aviralg"}}