{"action":"closed","issue":{"url":"https://api.github.com/repos/danivek/json-api-serializer/issues/49","repository_url":"https://api.github.com/repos/danivek/json-api-serializer","labels_url":"https://api.github.com/repos/danivek/json-api-serializer/issues/49/labels{/name}","comments_url":"https://api.github.com/repos/danivek/json-api-serializer/issues/49/comments","events_url":"https://api.github.com/repos/danivek/json-api-serializer/issues/49/events","html_url":"https://github.com/danivek/json-api-serializer/issues/49","id":302738350,"number":49,"title":"Acceptance of malformed relationships","user":{"login":"chamini2","id":2745502,"avatar_url":"https://avatars0.githubusercontent.com/u/2745502?v=4","gravatar_id":"","url":"https://api.github.com/users/chamini2","html_url":"https://github.com/chamini2","followers_url":"https://api.github.com/users/chamini2/followers","following_url":"https://api.github.com/users/chamini2/following{/other_user}","gists_url":"https://api.github.com/users/chamini2/gists{/gist_id}","starred_url":"https://api.github.com/users/chamini2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chamini2/subscriptions","organizations_url":"https://api.github.com/users/chamini2/orgs","repos_url":"https://api.github.com/users/chamini2/repos","events_url":"https://api.github.com/users/chamini2/events{/privacy}","received_events_url":"https://api.github.com/users/chamini2/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-06T15:09:06Z","updated_at":"2018-03-06T19:40:19Z","closed_at":"2018-03-06T19:40:19Z","author_association":"CONTRIBUTOR","body":"I noticed that in 62b73867b272a2a93f661e1122fca733c2624d9b you are handling malformed relationships by ignoring them. This seems to me a debatable thing to do, since maybe we should be warning the user of the malformed data, rather than ignoring it.\r\n\r\nI don't ask for us to check if it's malformed and throw on it, what I would suggest is not check for this at all. JSON API specifies a very clear payload format, so if it is not followed, it's understandable that this package would not work correctly.\r\n\r\nWhat I am trying to say is, why not make the code __easier__ to maintain by accounting for less cases? Maybe I can remove this specific check in #48."}}
{"actor":{"display_login":"danivek"}}