{"action":"closed","number":72,"pull_request":{"url":"https://api.github.com/repos/dropbox/pygerduty/pulls/72","id":217344762,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MzQ0NzYy","html_url":"https://github.com/dropbox/pygerduty/pull/72","diff_url":"https://github.com/dropbox/pygerduty/pull/72.diff","patch_url":"https://github.com/dropbox/pygerduty/pull/72.patch","issue_url":"https://api.github.com/repos/dropbox/pygerduty/issues/72","number":72,"state":"closed","locked":false,"title":"Cleanup Oncalls and add Tests","user":{"login":"cugini-dbx","id":41594004,"node_id":"MDQ6VXNlcjQxNTk0MDA0","avatar_url":"https://avatars2.githubusercontent.com/u/41594004?v=4","gravatar_id":"","url":"https://api.github.com/users/cugini-dbx","html_url":"https://github.com/cugini-dbx","followers_url":"https://api.github.com/users/cugini-dbx/followers","following_url":"https://api.github.com/users/cugini-dbx/following{/other_user}","gists_url":"https://api.github.com/users/cugini-dbx/gists{/gist_id}","starred_url":"https://api.github.com/users/cugini-dbx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cugini-dbx/subscriptions","organizations_url":"https://api.github.com/users/cugini-dbx/orgs","repos_url":"https://api.github.com/users/cugini-dbx/repos","events_url":"https://api.github.com/users/cugini-dbx/events{/privacy}","received_events_url":"https://api.github.com/users/cugini-dbx/received_events","type":"User","site_admin":false},"body":"Added a unique id to the oncall container which ensures `list` works\r\nwith the Collection implemented pagination logic (requires an id).\r\n\r\nRemoved the overridden `show()` method which is inconsistent with how\r\nshow works on other objects (the `oncalls` endpoint does not support\r\ngetting a single oncall, as there is no PagerDuty id for them).\r\n\r\nAlso tested that filtering with `oncalls.list()` works (for example `oncalls.list(schedule_ids=['<id>']`).\r\n\r\nI also added some tests for the `extensions` and `oncalls` objects. I don't think the `extensions` tests are exhaustive yet, but it's a start. Likely needs more work to ensure create/updating extensions works.","created_at":"2018-09-21T16:59:32Z","updated_at":"2018-09-28T22:30:06Z","closed_at":"2018-09-28T22:30:06Z","merged_at":"2018-09-28T22:30:06Z","merge_commit_sha":"f1846941e1d87a12b580717871c98f9abcbdab86","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dropbox/pygerduty/pulls/72/commits","review_comments_url":"https://api.github.com/repos/dropbox/pygerduty/pulls/72/comments","review_comment_url":"https://api.github.com/repos/dropbox/pygerduty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dropbox/pygerduty/issues/72/comments","statuses_url":"https://api.github.com/repos/dropbox/pygerduty/statuses/8a5610141f7af082d2fa50e4eee501816b6f8af5","head":{"label":"cugini-dbx:tests-cleanup","ref":"tests-cleanup","sha":"8a5610141f7af082d2fa50e4eee501816b6f8af5","user":{"login":"cugini-dbx","id":41594004,"node_id":"MDQ6VXNlcjQxNTk0MDA0","avatar_url":"https://avatars2.githubusercontent.com/u/41594004?v=4","gravatar_id":"","url":"https://api.github.com/users/cugini-dbx","html_url":"https://github.com/cugini-dbx","followers_url":"https://api.github.com/users/cugini-dbx/followers","following_url":"https://api.github.com/users/cugini-dbx/following{/other_user}","gists_url":"https://api.github.com/users/cugini-dbx/gists{/gist_id}","starred_url":"https://api.github.com/users/cugini-dbx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cugini-dbx/subscriptions","organizations_url":"https://api.github.com/users/cugini-dbx/orgs","repos_url":"https://api.github.com/users/cugini-dbx/repos","events_url":"https://api.github.com/users/cugini-dbx/events{/privacy}","received_events_url":"https://api.github.com/users/cugini-dbx/received_events","type":"User","site_admin":false},"repo":{"id":143183853,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMxODM4NTM=","name":"pygerduty","full_name":"cugini-dbx/pygerduty","private":false,"owner":{"login":"cugini-dbx","id":41594004,"node_id":"MDQ6VXNlcjQxNTk0MDA0","avatar_url":"https://avatars2.githubusercontent.com/u/41594004?v=4","gravatar_id":"","url":"https://api.github.com/users/cugini-dbx","html_url":"https://github.com/cugini-dbx","followers_url":"https://api.github.com/users/cugini-dbx/followers","following_url":"https://api.github.com/users/cugini-dbx/following{/other_user}","gists_url":"https://api.github.com/users/cugini-dbx/gists{/gist_id}","starred_url":"https://api.github.com/users/cugini-dbx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cugini-dbx/subscriptions","organizations_url":"https://api.github.com/users/cugini-dbx/orgs","repos_url":"https://api.github.com/users/cugini-dbx/repos","events_url":"https://api.github.com/users/cugini-dbx/events{/privacy}","received_events_url":"https://api.github.com/users/cugini-dbx/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cugini-dbx/pygerduty","description":"A Python library for PagerDuty.","fork":true,"url":"https://api.github.com/repos/cugini-dbx/pygerduty","forks_url":"https://api.github.com/repos/cugini-dbx/pygerduty/forks","keys_url":"https://api.github.com/repos/cugini-dbx/pygerduty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cugini-dbx/pygerduty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cugini-dbx/pygerduty/teams","hooks_url":"https://api.github.com/repos/cugini-dbx/pygerduty/hooks","issue_events_url":"https://api.github.com/repos/cugini-dbx/pygerduty/issues/events{/number}","events_url":"https://api.github.com/repos/cugini-dbx/pygerduty/events","assignees_url":"https://api.github.com/repos/cugini-dbx/pygerduty/assignees{/user}","branches_url":"https://api.github.com/repos/cugini-dbx/pygerduty/branches{/branch}","tags_url":"https://api.github.com/repos/cugini-dbx/pygerduty/tags","blobs_url":"https://api.github.com/repos/cugini-dbx/pygerduty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cugini-dbx/pygerduty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cugini-dbx/pygerduty/git/refs{/sha}","trees_url":"https://api.github.com/repos/cugini-dbx/pygerduty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cugini-dbx/pygerduty/statuses/{sha}","languages_url":"https://api.github.com/repos/cugini-dbx/pygerduty/languages","stargazers_url":"https://api.github.com/repos/cugini-dbx/pygerduty/stargazers","contributors_url":"https://api.github.com/repos/cugini-dbx/pygerduty/contributors","subscribers_url":"https://api.github.com/repos/cugini-dbx/pygerduty/subscribers","subscription_url":"https://api.github.com/repos/cugini-dbx/pygerduty/subscription","commits_url":"https://api.github.com/repos/cugini-dbx/pygerduty/commits{/sha}","git_commits_url":"https://api.github.com/repos/cugini-dbx/pygerduty/git/commits{/sha}","comments_url":"https://api.github.com/repos/cugini-dbx/pygerduty/comments{/number}","issue_comment_url":"https://api.github.com/repos/cugini-dbx/pygerduty/issues/comments{/number}","contents_url":"https://api.github.com/repos/cugini-dbx/pygerduty/contents/{+path}","compare_url":"https://api.github.com/repos/cugini-dbx/pygerduty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cugini-dbx/pygerduty/merges","archive_url":"https://api.github.com/repos/cugini-dbx/pygerduty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cugini-dbx/pygerduty/downloads","issues_url":"https://api.github.com/repos/cugini-dbx/pygerduty/issues{/number}","pulls_url":"https://api.github.com/repos/cugini-dbx/pygerduty/pulls{/number}","milestones_url":"https://api.github.com/repos/cugini-dbx/pygerduty/milestones{/number}","notifications_url":"https://api.github.com/repos/cugini-dbx/pygerduty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cugini-dbx/pygerduty/labels{/name}","releases_url":"https://api.github.com/repos/cugini-dbx/pygerduty/releases{/id}","deployments_url":"https://api.github.com/repos/cugini-dbx/pygerduty/deployments","created_at":"2018-08-01T16:51:31Z","updated_at":"2018-08-01T16:51:33Z","pushed_at":"2018-09-21T16:53:32Z","git_url":"git://github.com/cugini-dbx/pygerduty.git","ssh_url":"git@github.com:cugini-dbx/pygerduty.git","clone_url":"https://github.com/cugini-dbx/pygerduty.git","svn_url":"https://github.com/cugini-dbx/pygerduty","homepage":"","size":151,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dropbox:master","ref":"master","sha":"90c35ce739a253e360c33bd52aa908714ab38e01","user":{"login":"dropbox","id":559357,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1OTM1Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/559357?v=4","gravatar_id":"","url":"https://api.github.com/users/dropbox","html_url":"https://github.com/dropbox","followers_url":"https://api.github.com/users/dropbox/followers","following_url":"https://api.github.com/users/dropbox/following{/other_user}","gists_url":"https://api.github.com/users/dropbox/gists{/gist_id}","starred_url":"https://api.github.com/users/dropbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dropbox/subscriptions","organizations_url":"https://api.github.com/users/dropbox/orgs","repos_url":"https://api.github.com/users/dropbox/repos","events_url":"https://api.github.com/users/dropbox/events{/privacy}","received_events_url":"https://api.github.com/users/dropbox/received_events","type":"Organization","site_admin":false},"repo":{"id":7139164,"node_id":"MDEwOlJlcG9zaXRvcnk3MTM5MTY0","name":"pygerduty","full_name":"dropbox/pygerduty","private":false,"owner":{"login":"dropbox","id":559357,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1OTM1Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/559357?v=4","gravatar_id":"","url":"https://api.github.com/users/dropbox","html_url":"https://github.com/dropbox","followers_url":"https://api.github.com/users/dropbox/followers","following_url":"https://api.github.com/users/dropbox/following{/other_user}","gists_url":"https://api.github.com/users/dropbox/gists{/gist_id}","starred_url":"https://api.github.com/users/dropbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dropbox/subscriptions","organizations_url":"https://api.github.com/users/dropbox/orgs","repos_url":"https://api.github.com/users/dropbox/repos","events_url":"https://api.github.com/users/dropbox/events{/privacy}","received_events_url":"https://api.github.com/users/dropbox/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dropbox/pygerduty","description":"A Python library for PagerDuty.","fork":false,"url":"https://api.github.com/repos/dropbox/pygerduty","forks_url":"https://api.github.com/repos/dropbox/pygerduty/forks","keys_url":"https://api.github.com/repos/dropbox/pygerduty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dropbox/pygerduty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dropbox/pygerduty/teams","hooks_url":"https://api.github.com/repos/dropbox/pygerduty/hooks","issue_events_url":"https://api.github.com/repos/dropbox/pygerduty/issues/events{/number}","events_url":"https://api.github.com/repos/dropbox/pygerduty/events","assignees_url":"https://api.github.com/repos/dropbox/pygerduty/assignees{/user}","branches_url":"https://api.github.com/repos/dropbox/pygerduty/branches{/branch}","tags_url":"https://api.github.com/repos/dropbox/pygerduty/tags","blobs_url":"https://api.github.com/repos/dropbox/pygerduty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dropbox/pygerduty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dropbox/pygerduty/git/refs{/sha}","trees_url":"https://api.github.com/repos/dropbox/pygerduty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dropbox/pygerduty/statuses/{sha}","languages_url":"https://api.github.com/repos/dropbox/pygerduty/languages","stargazers_url":"https://api.github.com/repos/dropbox/pygerduty/stargazers","contributors_url":"https://api.github.com/repos/dropbox/pygerduty/contributors","subscribers_url":"https://api.github.com/repos/dropbox/pygerduty/subscribers","subscription_url":"https://api.github.com/repos/dropbox/pygerduty/subscription","commits_url":"https://api.github.com/repos/dropbox/pygerduty/commits{/sha}","git_commits_url":"https://api.github.com/repos/dropbox/pygerduty/git/commits{/sha}","comments_url":"https://api.github.com/repos/dropbox/pygerduty/comments{/number}","issue_comment_url":"https://api.github.com/repos/dropbox/pygerduty/issues/comments{/number}","contents_url":"https://api.github.com/repos/dropbox/pygerduty/contents/{+path}","compare_url":"https://api.github.com/repos/dropbox/pygerduty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dropbox/pygerduty/merges","archive_url":"https://api.github.com/repos/dropbox/pygerduty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dropbox/pygerduty/downloads","issues_url":"https://api.github.com/repos/dropbox/pygerduty/issues{/number}","pulls_url":"https://api.github.com/repos/dropbox/pygerduty/pulls{/number}","milestones_url":"https://api.github.com/repos/dropbox/pygerduty/milestones{/number}","notifications_url":"https://api.github.com/repos/dropbox/pygerduty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dropbox/pygerduty/labels{/name}","releases_url":"https://api.github.com/repos/dropbox/pygerduty/releases{/id}","deployments_url":"https://api.github.com/repos/dropbox/pygerduty/deployments","created_at":"2012-12-12T22:53:08Z","updated_at":"2018-09-20T17:07:07Z","pushed_at":"2018-09-28T22:30:06Z","git_url":"git://github.com/dropbox/pygerduty.git","ssh_url":"git@github.com:dropbox/pygerduty.git","clone_url":"https://github.com/dropbox/pygerduty.git","svn_url":"https://github.com/dropbox/pygerduty","homepage":"","size":141,"stargazers_count":133,"watchers_count":133,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":68,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":68,"open_issues":2,"watchers":133,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dropbox/pygerduty/pulls/72"},"html":{"href":"https://github.com/dropbox/pygerduty/pull/72"},"issue":{"href":"https://api.github.com/repos/dropbox/pygerduty/issues/72"},"comments":{"href":"https://api.github.com/repos/dropbox/pygerduty/issues/72/comments"},"review_comments":{"href":"https://api.github.com/repos/dropbox/pygerduty/pulls/72/comments"},"review_comment":{"href":"https://api.github.com/repos/dropbox/pygerduty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dropbox/pygerduty/pulls/72/commits"},"statuses":{"href":"https://api.github.com/repos/dropbox/pygerduty/statuses/8a5610141f7af082d2fa50e4eee501816b6f8af5"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"cugini-dbx","id":41594004,"node_id":"MDQ6VXNlcjQxNTk0MDA0","avatar_url":"https://avatars2.githubusercontent.com/u/41594004?v=4","gravatar_id":"","url":"https://api.github.com/users/cugini-dbx","html_url":"https://github.com/cugini-dbx","followers_url":"https://api.github.com/users/cugini-dbx/followers","following_url":"https://api.github.com/users/cugini-dbx/following{/other_user}","gists_url":"https://api.github.com/users/cugini-dbx/gists{/gist_id}","starred_url":"https://api.github.com/users/cugini-dbx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cugini-dbx/subscriptions","organizations_url":"https://api.github.com/users/cugini-dbx/orgs","repos_url":"https://api.github.com/users/cugini-dbx/repos","events_url":"https://api.github.com/users/cugini-dbx/events{/privacy}","received_events_url":"https://api.github.com/users/cugini-dbx/received_events","type":"User","site_admin":false},"comments":10,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":326,"deletions":14,"changed_files":7}}
{"actor":{"display_login":"cugini-dbx"}}