{"action":"created","comment":{"url":"https://api.github.com/repos/OpenSC/OpenSC/pulls/comments/171815864","pull_request_review_id":100736159,"id":171815864,"diff_hunk":"@@ -160,14 +166,16 @@ typedef struct piv_private_data {\n \tchar * offCardCertURL;\n \tint pin_preference; /* set from Discovery object */\n \tint logged_in;\n+\tint pstate;\n \tint pin_cmd_verify;\n+\tint context_specific;","path":"src/libopensc/card-piv.c","position":19,"original_position":19,"commit_id":"4222036a60c92701d1ef233734463182f2410484","original_commit_id":"4222036a60c92701d1ef233734463182f2410484","user":{"login":"martinpaljak","id":46006,"avatar_url":"https://avatars1.githubusercontent.com/u/46006?v=4","gravatar_id":"","url":"https://api.github.com/users/martinpaljak","html_url":"https://github.com/martinpaljak","followers_url":"https://api.github.com/users/martinpaljak/followers","following_url":"https://api.github.com/users/martinpaljak/following{/other_user}","gists_url":"https://api.github.com/users/martinpaljak/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpaljak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpaljak/subscriptions","organizations_url":"https://api.github.com/users/martinpaljak/orgs","repos_url":"https://api.github.com/users/martinpaljak/repos","events_url":"https://api.github.com/users/martinpaljak/events{/privacy}","received_events_url":"https://api.github.com/users/martinpaljak/received_events","type":"User","site_admin":false},"body":"Maybe add a comment about what this field does and why. Same for other maybe not-so-obvious fields?","created_at":"2018-03-02T10:44:32Z","updated_at":"2018-03-02T10:44:32Z","html_url":"https://github.com/OpenSC/OpenSC/pull/1256#discussion_r171815864","pull_request_url":"https://api.github.com/repos/OpenSC/OpenSC/pulls/1256","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/OpenSC/OpenSC/pulls/comments/171815864"},"html":{"href":"https://github.com/OpenSC/OpenSC/pull/1256#discussion_r171815864"},"pull_request":{"href":"https://api.github.com/repos/OpenSC/OpenSC/pulls/1256"}}},"pull_request":{"url":"https://api.github.com/repos/OpenSC/OpenSC/pulls/1256","id":165764961,"html_url":"https://github.com/OpenSC/OpenSC/pull/1256","diff_url":"https://github.com/OpenSC/OpenSC/pull/1256.diff","patch_url":"https://github.com/OpenSC/OpenSC/pull/1256.patch","issue_url":"https://api.github.com/repos/OpenSC/OpenSC/issues/1256","number":1256,"state":"open","locked":false,"title":"PIV detection of AID using Discovery Object before doing select AID - Partial Fix #1243","user":{"login":"dengert","id":865329,"avatar_url":"https://avatars2.githubusercontent.com/u/865329?v=4","gravatar_id":"","url":"https://api.github.com/users/dengert","html_url":"https://github.com/dengert","followers_url":"https://api.github.com/users/dengert/followers","following_url":"https://api.github.com/users/dengert/following{/other_user}","gists_url":"https://api.github.com/users/dengert/gists{/gist_id}","starred_url":"https://api.github.com/users/dengert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dengert/subscriptions","organizations_url":"https://api.github.com/users/dengert/orgs","repos_url":"https://api.github.com/users/dengert/repos","events_url":"https://api.github.com/users/dengert/events{/privacy}","received_events_url":"https://api.github.com/users/dengert/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request.\r\n\r\nIf this fixes a github issue, make sure to have a line saying 'Fixes #XXXX' (without quotes) in the commit message.\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n- [ ] Documentation is added or updated\r\n- [ ] New files have a LGPL 2.1 license statement\r\n- [X] Tested with the following cards: Yubikey 4 and PIV cards \r\n\t- [X] tested PKCS#11\r\n\t- [ ] tested Windows Minidriver\r\n\t- [ ] tested macOS Tokend\r\n","created_at":"2018-01-29T17:15:17Z","updated_at":"2018-03-02T10:44:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f4324136fa575f8b1d02e38cf48e5a02353a223","assignee":{"login":"frankmorgner","id":1266577,"avatar_url":"https://avatars0.githubusercontent.com/u/1266577?v=4","gravatar_id":"","url":"https://api.github.com/users/frankmorgner","html_url":"https://github.com/frankmorgner","followers_url":"https://api.github.com/users/frankmorgner/followers","following_url":"https://api.github.com/users/frankmorgner/following{/other_user}","gists_url":"https://api.github.com/users/frankmorgner/gists{/gist_id}","starred_url":"https://api.github.com/users/frankmorgner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankmorgner/subscriptions","organizations_url":"https://api.github.com/users/frankmorgner/orgs","repos_url":"https://api.github.com/users/frankmorgner/repos","events_url":"https://api.github.com/users/frankmorgner/events{/privacy}","received_events_url":"https://api.github.com/users/frankmorgner/received_events","type":"User","site_admin":false},"assignees":[{"login":"frankmorgner","id":1266577,"avatar_url":"https://avatars0.githubusercontent.com/u/1266577?v=4","gravatar_id":"","url":"https://api.github.com/users/frankmorgner","html_url":"https://github.com/frankmorgner","followers_url":"https://api.github.com/users/frankmorgner/followers","following_url":"https://api.github.com/users/frankmorgner/following{/other_user}","gists_url":"https://api.github.com/users/frankmorgner/gists{/gist_id}","starred_url":"https://api.github.com/users/frankmorgner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankmorgner/subscriptions","organizations_url":"https://api.github.com/users/frankmorgner/orgs","repos_url":"https://api.github.com/users/frankmorgner/repos","events_url":"https://api.github.com/users/frankmorgner/events{/privacy}","received_events_url":"https://api.github.com/users/frankmorgner/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenSC/OpenSC/pulls/1256/commits","review_comments_url":"https://api.github.com/repos/OpenSC/OpenSC/pulls/1256/comments","review_comment_url":"https://api.github.com/repos/OpenSC/OpenSC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenSC/OpenSC/issues/1256/comments","statuses_url":"https://api.github.com/repos/OpenSC/OpenSC/statuses/4222036a60c92701d1ef233734463182f2410484","head":{"label":"dengert:piv-aid-discovery","ref":"piv-aid-discovery","sha":"4222036a60c92701d1ef233734463182f2410484","user":{"login":"dengert","id":865329,"avatar_url":"https://avatars2.githubusercontent.com/u/865329?v=4","gravatar_id":"","url":"https://api.github.com/users/dengert","html_url":"https://github.com/dengert","followers_url":"https://api.github.com/users/dengert/followers","following_url":"https://api.github.com/users/dengert/following{/other_user}","gists_url":"https://api.github.com/users/dengert/gists{/gist_id}","starred_url":"https://api.github.com/users/dengert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dengert/subscriptions","organizations_url":"https://api.github.com/users/dengert/orgs","repos_url":"https://api.github.com/users/dengert/repos","events_url":"https://api.github.com/users/dengert/events{/privacy}","received_events_url":"https://api.github.com/users/dengert/received_events","type":"User","site_admin":false},"repo":{"id":26346144,"name":"OpenSC","full_name":"dengert/OpenSC","owner":{"login":"dengert","id":865329,"avatar_url":"https://avatars2.githubusercontent.com/u/865329?v=4","gravatar_id":"","url":"https://api.github.com/users/dengert","html_url":"https://github.com/dengert","followers_url":"https://api.github.com/users/dengert/followers","following_url":"https://api.github.com/users/dengert/following{/other_user}","gists_url":"https://api.github.com/users/dengert/gists{/gist_id}","starred_url":"https://api.github.com/users/dengert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dengert/subscriptions","organizations_url":"https://api.github.com/users/dengert/orgs","repos_url":"https://api.github.com/users/dengert/repos","events_url":"https://api.github.com/users/dengert/events{/privacy}","received_events_url":"https://api.github.com/users/dengert/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dengert/OpenSC","description":"Open source smart card tools and middleware. PKCS#11/MiniDriver/Tokend","fork":true,"url":"https://api.github.com/repos/dengert/OpenSC","forks_url":"https://api.github.com/repos/dengert/OpenSC/forks","keys_url":"https://api.github.com/repos/dengert/OpenSC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dengert/OpenSC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dengert/OpenSC/teams","hooks_url":"https://api.github.com/repos/dengert/OpenSC/hooks","issue_events_url":"https://api.github.com/repos/dengert/OpenSC/issues/events{/number}","events_url":"https://api.github.com/repos/dengert/OpenSC/events","assignees_url":"https://api.github.com/repos/dengert/OpenSC/assignees{/user}","branches_url":"https://api.github.com/repos/dengert/OpenSC/branches{/branch}","tags_url":"https://api.github.com/repos/dengert/OpenSC/tags","blobs_url":"https://api.github.com/repos/dengert/OpenSC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dengert/OpenSC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dengert/OpenSC/git/refs{/sha}","trees_url":"https://api.github.com/repos/dengert/OpenSC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dengert/OpenSC/statuses/{sha}","languages_url":"https://api.github.com/repos/dengert/OpenSC/languages","stargazers_url":"https://api.github.com/repos/dengert/OpenSC/stargazers","contributors_url":"https://api.github.com/repos/dengert/OpenSC/contributors","subscribers_url":"https://api.github.com/repos/dengert/OpenSC/subscribers","subscription_url":"https://api.github.com/repos/dengert/OpenSC/subscription","commits_url":"https://api.github.com/repos/dengert/OpenSC/commits{/sha}","git_commits_url":"https://api.github.com/repos/dengert/OpenSC/git/commits{/sha}","comments_url":"https://api.github.com/repos/dengert/OpenSC/comments{/number}","issue_comment_url":"https://api.github.com/repos/dengert/OpenSC/issues/comments{/number}","contents_url":"https://api.github.com/repos/dengert/OpenSC/contents/{+path}","compare_url":"https://api.github.com/repos/dengert/OpenSC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dengert/OpenSC/merges","archive_url":"https://api.github.com/repos/dengert/OpenSC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dengert/OpenSC/downloads","issues_url":"https://api.github.com/repos/dengert/OpenSC/issues{/number}","pulls_url":"https://api.github.com/repos/dengert/OpenSC/pulls{/number}","milestones_url":"https://api.github.com/repos/dengert/OpenSC/milestones{/number}","notifications_url":"https://api.github.com/repos/dengert/OpenSC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dengert/OpenSC/labels{/name}","releases_url":"https://api.github.com/repos/dengert/OpenSC/releases{/id}","deployments_url":"https://api.github.com/repos/dengert/OpenSC/deployments","created_at":"2014-11-08T01:38:28Z","updated_at":"2016-01-19T03:43:23Z","pushed_at":"2018-02-28T19:56:08Z","git_url":"git://github.com/dengert/OpenSC.git","ssh_url":"git@github.com:dengert/OpenSC.git","clone_url":"https://github.com/dengert/OpenSC.git","svn_url":"https://github.com/dengert/OpenSC","homepage":"https://github.com/OpenSC/OpenSC/wiki","size":13335,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenSC:master","ref":"master","sha":"1d4f59ea51dd1713a3b99186498cb8fe074abc4c","user":{"login":"OpenSC","id":895249,"avatar_url":"https://avatars2.githubusercontent.com/u/895249?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenSC","html_url":"https://github.com/OpenSC","followers_url":"https://api.github.com/users/OpenSC/followers","following_url":"https://api.github.com/users/OpenSC/following{/other_user}","gists_url":"https://api.github.com/users/OpenSC/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenSC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenSC/subscriptions","organizations_url":"https://api.github.com/users/OpenSC/orgs","repos_url":"https://api.github.com/users/OpenSC/repos","events_url":"https://api.github.com/users/OpenSC/events{/privacy}","received_events_url":"https://api.github.com/users/OpenSC/received_events","type":"Organization","site_admin":false},"repo":{"id":1999692,"name":"OpenSC","full_name":"OpenSC/OpenSC","owner":{"login":"OpenSC","id":895249,"avatar_url":"https://avatars2.githubusercontent.com/u/895249?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenSC","html_url":"https://github.com/OpenSC","followers_url":"https://api.github.com/users/OpenSC/followers","following_url":"https://api.github.com/users/OpenSC/following{/other_user}","gists_url":"https://api.github.com/users/OpenSC/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenSC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenSC/subscriptions","organizations_url":"https://api.github.com/users/OpenSC/orgs","repos_url":"https://api.github.com/users/OpenSC/repos","events_url":"https://api.github.com/users/OpenSC/events{/privacy}","received_events_url":"https://api.github.com/users/OpenSC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenSC/OpenSC","description":"Open source smart card tools and middleware. PKCS#11/MiniDriver/Tokend","fork":false,"url":"https://api.github.com/repos/OpenSC/OpenSC","forks_url":"https://api.github.com/repos/OpenSC/OpenSC/forks","keys_url":"https://api.github.com/repos/OpenSC/OpenSC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenSC/OpenSC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenSC/OpenSC/teams","hooks_url":"https://api.github.com/repos/OpenSC/OpenSC/hooks","issue_events_url":"https://api.github.com/repos/OpenSC/OpenSC/issues/events{/number}","events_url":"https://api.github.com/repos/OpenSC/OpenSC/events","assignees_url":"https://api.github.com/repos/OpenSC/OpenSC/assignees{/user}","branches_url":"https://api.github.com/repos/OpenSC/OpenSC/branches{/branch}","tags_url":"https://api.github.com/repos/OpenSC/OpenSC/tags","blobs_url":"https://api.github.com/repos/OpenSC/OpenSC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenSC/OpenSC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenSC/OpenSC/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenSC/OpenSC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenSC/OpenSC/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenSC/OpenSC/languages","stargazers_url":"https://api.github.com/repos/OpenSC/OpenSC/stargazers","contributors_url":"https://api.github.com/repos/OpenSC/OpenSC/contributors","subscribers_url":"https://api.github.com/repos/OpenSC/OpenSC/subscribers","subscription_url":"https://api.github.com/repos/OpenSC/OpenSC/subscription","commits_url":"https://api.github.com/repos/OpenSC/OpenSC/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenSC/OpenSC/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenSC/OpenSC/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenSC/OpenSC/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenSC/OpenSC/contents/{+path}","compare_url":"https://api.github.com/repos/OpenSC/OpenSC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenSC/OpenSC/merges","archive_url":"https://api.github.com/repos/OpenSC/OpenSC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenSC/OpenSC/downloads","issues_url":"https://api.github.com/repos/OpenSC/OpenSC/issues{/number}","pulls_url":"https://api.github.com/repos/OpenSC/OpenSC/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenSC/OpenSC/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenSC/OpenSC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenSC/OpenSC/labels{/name}","releases_url":"https://api.github.com/repos/OpenSC/OpenSC/releases{/id}","deployments_url":"https://api.github.com/repos/OpenSC/OpenSC/deployments","created_at":"2011-07-05T09:45:08Z","updated_at":"2018-03-01T02:40:56Z","pushed_at":"2018-03-02T00:59:52Z","git_url":"git://github.com/OpenSC/OpenSC.git","ssh_url":"git@github.com:OpenSC/OpenSC.git","clone_url":"https://github.com/OpenSC/OpenSC.git","svn_url":"https://github.com/OpenSC/OpenSC","homepage":"https://github.com/OpenSC/OpenSC/wiki","size":13228,"stargazers_count":810,"watchers_count":810,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":354,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":354,"open_issues":49,"watchers":810,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenSC/OpenSC/pulls/1256"},"html":{"href":"https://github.com/OpenSC/OpenSC/pull/1256"},"issue":{"href":"https://api.github.com/repos/OpenSC/OpenSC/issues/1256"},"comments":{"href":"https://api.github.com/repos/OpenSC/OpenSC/issues/1256/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenSC/OpenSC/pulls/1256/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenSC/OpenSC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenSC/OpenSC/pulls/1256/commits"},"statuses":{"href":"https://api.github.com/repos/OpenSC/OpenSC/statuses/4222036a60c92701d1ef233734463182f2410484"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"martinpaljak"}}