{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Mvc/pulls/comments/211089642","pull_request_review_id":147445071,"id":211089642,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTA4OTY0Mg==","diff_hunk":"@@ -0,0 +1,12 @@\n+﻿using System;\n+using System.Collections.Generic;\n+using System.ComponentModel.DataAnnotations;\n+using System.Text;\n+\n+namespace Microsoft.AspNetCore.Mvc.Analyzers.TestFiles.TopLevelParameterAttributeAnalyzerTest\n+{\n+   public class DiagnosticsAreReturned_ForControllerActionsWithParametersWithRequiredAttributeForIEnumerable : Controller\n+    {\n+        public IActionResult Index([Required]IEnumerable<int> /*MM*/collection) => null;","path":"test/Mvc.Analyzers.Test/TestFiles/TopLevelParameterAttributeAnalyzerTest/DiagnosticsAreReturned_ForControllerActionsWithParametersWithRequiredAttributeForIEnumerable.cs","position":10,"original_position":10,"commit_id":"5899cab05fed089eb4ca332b2fa43998aec078b7","original_commit_id":"5899cab05fed089eb4ca332b2fa43998aec078b7","user":{"login":"kishanAnem","id":8208927,"node_id":"MDQ6VXNlcjgyMDg5Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/8208927?v=4","gravatar_id":"","url":"https://api.github.com/users/kishanAnem","html_url":"https://github.com/kishanAnem","followers_url":"https://api.github.com/users/kishanAnem/followers","following_url":"https://api.github.com/users/kishanAnem/following{/other_user}","gists_url":"https://api.github.com/users/kishanAnem/gists{/gist_id}","starred_url":"https://api.github.com/users/kishanAnem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kishanAnem/subscriptions","organizations_url":"https://api.github.com/users/kishanAnem/orgs","repos_url":"https://api.github.com/users/kishanAnem/repos","events_url":"https://api.github.com/users/kishanAnem/events{/privacy}","received_events_url":"https://api.github.com/users/kishanAnem/received_events","type":"User","site_admin":false},"body":"Yes, you're right @dougbu  will fix this.","created_at":"2018-08-19T01:53:48Z","updated_at":"2018-08-19T01:53:48Z","html_url":"https://github.com/aspnet/Mvc/pull/8290#discussion_r211089642","pull_request_url":"https://api.github.com/repos/aspnet/Mvc/pulls/8290","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/comments/211089642"},"html":{"href":"https://github.com/aspnet/Mvc/pull/8290#discussion_r211089642"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/8290"}},"in_reply_to_id":211085349},"pull_request":{"url":"https://api.github.com/repos/aspnet/Mvc/pulls/8290","id":209297694,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5Mjk3Njk0","html_url":"https://github.com/aspnet/Mvc/pull/8290","diff_url":"https://github.com/aspnet/Mvc/pull/8290.diff","patch_url":"https://github.com/aspnet/Mvc/pull/8290.patch","issue_url":"https://api.github.com/repos/aspnet/Mvc/issues/8290","number":8290,"state":"open","locked":false,"title":"Create an Analyzer to warn customers to not user Required attribute opn top-level parameters #7415","user":{"login":"kishanAnem","id":8208927,"node_id":"MDQ6VXNlcjgyMDg5Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/8208927?v=4","gravatar_id":"","url":"https://api.github.com/users/kishanAnem","html_url":"https://github.com/kishanAnem","followers_url":"https://api.github.com/users/kishanAnem/followers","following_url":"https://api.github.com/users/kishanAnem/following{/other_user}","gists_url":"https://api.github.com/users/kishanAnem/gists{/gist_id}","starred_url":"https://api.github.com/users/kishanAnem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kishanAnem/subscriptions","organizations_url":"https://api.github.com/users/kishanAnem/orgs","repos_url":"https://api.github.com/users/kishanAnem/repos","events_url":"https://api.github.com/users/kishanAnem/events{/privacy}","received_events_url":"https://api.github.com/users/kishanAnem/received_events","type":"User","site_admin":false},"body":"#7415\r\n\r\nHi @dougbu\r\n\r\n #7415 this is only about Action parameter in next commit will work on  Properties. Please let me know, is this is fine?\r\nThanks @pranavkm, used your framework a lot.","created_at":"2018-08-18T06:32:14Z","updated_at":"2018-08-19T01:53:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f41cf3f8b7d992731eaf973711628d89b48fa8e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Mvc/pulls/8290/commits","review_comments_url":"https://api.github.com/repos/aspnet/Mvc/pulls/8290/comments","review_comment_url":"https://api.github.com/repos/aspnet/Mvc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Mvc/issues/8290/comments","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/5899cab05fed089eb4ca332b2fa43998aec078b7","head":{"label":"kishanAnem:dev","ref":"dev","sha":"5899cab05fed089eb4ca332b2fa43998aec078b7","user":{"login":"kishanAnem","id":8208927,"node_id":"MDQ6VXNlcjgyMDg5Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/8208927?v=4","gravatar_id":"","url":"https://api.github.com/users/kishanAnem","html_url":"https://github.com/kishanAnem","followers_url":"https://api.github.com/users/kishanAnem/followers","following_url":"https://api.github.com/users/kishanAnem/following{/other_user}","gists_url":"https://api.github.com/users/kishanAnem/gists{/gist_id}","starred_url":"https://api.github.com/users/kishanAnem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kishanAnem/subscriptions","organizations_url":"https://api.github.com/users/kishanAnem/orgs","repos_url":"https://api.github.com/users/kishanAnem/repos","events_url":"https://api.github.com/users/kishanAnem/events{/privacy}","received_events_url":"https://api.github.com/users/kishanAnem/received_events","type":"User","site_admin":false},"repo":{"id":132357514,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIzNTc1MTQ=","name":"Mvc","full_name":"kishanAnem/Mvc","owner":{"login":"kishanAnem","id":8208927,"node_id":"MDQ6VXNlcjgyMDg5Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/8208927?v=4","gravatar_id":"","url":"https://api.github.com/users/kishanAnem","html_url":"https://github.com/kishanAnem","followers_url":"https://api.github.com/users/kishanAnem/followers","following_url":"https://api.github.com/users/kishanAnem/following{/other_user}","gists_url":"https://api.github.com/users/kishanAnem/gists{/gist_id}","starred_url":"https://api.github.com/users/kishanAnem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kishanAnem/subscriptions","organizations_url":"https://api.github.com/users/kishanAnem/orgs","repos_url":"https://api.github.com/users/kishanAnem/repos","events_url":"https://api.github.com/users/kishanAnem/events{/privacy}","received_events_url":"https://api.github.com/users/kishanAnem/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kishanAnem/Mvc","description":"ASP.NET Core MVC is a model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor.","fork":true,"url":"https://api.github.com/repos/kishanAnem/Mvc","forks_url":"https://api.github.com/repos/kishanAnem/Mvc/forks","keys_url":"https://api.github.com/repos/kishanAnem/Mvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kishanAnem/Mvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kishanAnem/Mvc/teams","hooks_url":"https://api.github.com/repos/kishanAnem/Mvc/hooks","issue_events_url":"https://api.github.com/repos/kishanAnem/Mvc/issues/events{/number}","events_url":"https://api.github.com/repos/kishanAnem/Mvc/events","assignees_url":"https://api.github.com/repos/kishanAnem/Mvc/assignees{/user}","branches_url":"https://api.github.com/repos/kishanAnem/Mvc/branches{/branch}","tags_url":"https://api.github.com/repos/kishanAnem/Mvc/tags","blobs_url":"https://api.github.com/repos/kishanAnem/Mvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kishanAnem/Mvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kishanAnem/Mvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/kishanAnem/Mvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kishanAnem/Mvc/statuses/{sha}","languages_url":"https://api.github.com/repos/kishanAnem/Mvc/languages","stargazers_url":"https://api.github.com/repos/kishanAnem/Mvc/stargazers","contributors_url":"https://api.github.com/repos/kishanAnem/Mvc/contributors","subscribers_url":"https://api.github.com/repos/kishanAnem/Mvc/subscribers","subscription_url":"https://api.github.com/repos/kishanAnem/Mvc/subscription","commits_url":"https://api.github.com/repos/kishanAnem/Mvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/kishanAnem/Mvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/kishanAnem/Mvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/kishanAnem/Mvc/issues/comments{/number}","contents_url":"https://api.github.com/repos/kishanAnem/Mvc/contents/{+path}","compare_url":"https://api.github.com/repos/kishanAnem/Mvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kishanAnem/Mvc/merges","archive_url":"https://api.github.com/repos/kishanAnem/Mvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kishanAnem/Mvc/downloads","issues_url":"https://api.github.com/repos/kishanAnem/Mvc/issues{/number}","pulls_url":"https://api.github.com/repos/kishanAnem/Mvc/pulls{/number}","milestones_url":"https://api.github.com/repos/kishanAnem/Mvc/milestones{/number}","notifications_url":"https://api.github.com/repos/kishanAnem/Mvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kishanAnem/Mvc/labels{/name}","releases_url":"https://api.github.com/repos/kishanAnem/Mvc/releases{/id}","deployments_url":"https://api.github.com/repos/kishanAnem/Mvc/deployments","created_at":"2018-05-06T16:43:28Z","updated_at":"2018-08-18T06:29:57Z","pushed_at":"2018-08-18T06:29:53Z","git_url":"git://github.com/kishanAnem/Mvc.git","ssh_url":"git@github.com:kishanAnem/Mvc.git","clone_url":"https://github.com/kishanAnem/Mvc.git","svn_url":"https://github.com/kishanAnem/Mvc","homepage":"","size":70633,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"aspnet:release/2.2","ref":"release/2.2","sha":"522006d2c866add522a546aa3b4720577f1cee57","user":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15126429,"node_id":"MDEwOlJlcG9zaXRvcnkxNTEyNjQyOQ==","name":"Mvc","full_name":"aspnet/Mvc","owner":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Mvc","description":"ASP.NET Core MVC is a model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor.","fork":false,"url":"https://api.github.com/repos/aspnet/Mvc","forks_url":"https://api.github.com/repos/aspnet/Mvc/forks","keys_url":"https://api.github.com/repos/aspnet/Mvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Mvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Mvc/teams","hooks_url":"https://api.github.com/repos/aspnet/Mvc/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Mvc/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Mvc/events","assignees_url":"https://api.github.com/repos/aspnet/Mvc/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Mvc/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Mvc/tags","blobs_url":"https://api.github.com/repos/aspnet/Mvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Mvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Mvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Mvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Mvc/languages","stargazers_url":"https://api.github.com/repos/aspnet/Mvc/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Mvc/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Mvc/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Mvc/subscription","commits_url":"https://api.github.com/repos/aspnet/Mvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Mvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Mvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Mvc/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Mvc/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Mvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Mvc/merges","archive_url":"https://api.github.com/repos/aspnet/Mvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Mvc/downloads","issues_url":"https://api.github.com/repos/aspnet/Mvc/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Mvc/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Mvc/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Mvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Mvc/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Mvc/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/Mvc/deployments","created_at":"2013-12-12T03:54:00Z","updated_at":"2018-08-18T18:00:56Z","pushed_at":"2018-08-18T06:32:15Z","git_url":"git://github.com/aspnet/Mvc.git","ssh_url":"git@github.com:aspnet/Mvc.git","clone_url":"https://github.com/aspnet/Mvc.git","svn_url":"https://github.com/aspnet/Mvc","homepage":"","size":70566,"stargazers_count":5543,"watchers_count":5543,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2174,"mirror_url":null,"archived":false,"open_issues_count":213,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2174,"open_issues":213,"watchers":5543,"default_branch":"release/2.2"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/8290"},"html":{"href":"https://github.com/aspnet/Mvc/pull/8290"},"issue":{"href":"https://api.github.com/repos/aspnet/Mvc/issues/8290"},"comments":{"href":"https://api.github.com/repos/aspnet/Mvc/issues/8290/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/8290/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/8290/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Mvc/statuses/5899cab05fed089eb4ca332b2fa43998aec078b7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kishanAnem"}}