{"action":"closed","number":78,"pull_request":{"url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/pulls/78","id":180155833,"html_url":"https://github.com/momo-sa/categorical_syllogisms/pull/78","diff_url":"https://github.com/momo-sa/categorical_syllogisms/pull/78.diff","patch_url":"https://github.com/momo-sa/categorical_syllogisms/pull/78.patch","issue_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/issues/78","number":78,"state":"closed","locked":false,"title":"Improve specification of dockerfile","user":{"login":"momo-sa","id":7398682,"avatar_url":"https://avatars2.githubusercontent.com/u/7398682?v=4","gravatar_id":"","url":"https://api.github.com/users/momo-sa","html_url":"https://github.com/momo-sa","followers_url":"https://api.github.com/users/momo-sa/followers","following_url":"https://api.github.com/users/momo-sa/following{/other_user}","gists_url":"https://api.github.com/users/momo-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/momo-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/momo-sa/subscriptions","organizations_url":"https://api.github.com/users/momo-sa/orgs","repos_url":"https://api.github.com/users/momo-sa/repos","events_url":"https://api.github.com/users/momo-sa/events{/privacy}","received_events_url":"https://api.github.com/users/momo-sa/received_events","type":"User","site_admin":false},"body":"## Overview\r\n\r\nAs a dev or admin I want to build docker containers with fewer steps so I can minimize the risk of unwanted artifacts.\r\n\r\n[Link to card](https://trello.com/c/XJdk1H3y).\r\n\r\n----\r\n\r\n## Summary of changes\r\n\r\nThis change just introduces the `--file` option to specify the dockerfile. \r\n\r\n----\r\n\r\n## Discussion points\r\n\r\nI specifically looked for this option when writing the original script, but didn't find it. Either I just missed it or it's new-ish. Regardless, it's better to use this option than to copy the dockerfile around.\r\n\r\n----\r\n\r\n## Testing\r\n\r\n- [x] Unit tests pass\r\n- [x] Lint tests pass\r\n- [x] API tests pass\r\n\r\nRunning tests:\r\n\r\n```shell\r\n# Build the dev containers\r\n# If prerequisites changed since you last built, build all, instead\r\n$CATEGORICAL_SYLLOGISMS/bin/build.sh dev\r\n\r\n$CATEGORICAL_SYLLOGISMS/bin/run.sh unit_tests\r\n\r\n$CATEGORICAL_SYLLOGISMS/bin/run.sh lint_tests\r\n\r\n$CATEGORICAL_SYLLOGISMS/bin/run.sh api_tests\r\n```\r\n","created_at":"2018-04-08T11:52:07Z","updated_at":"2018-04-10T00:35:58Z","closed_at":"2018-04-10T00:35:58Z","merged_at":"2018-04-10T00:35:58Z","merge_commit_sha":"1c6f06b916e0909c6a0f827443fb68e704a43ca8","assignee":{"login":"momo-sa","id":7398682,"avatar_url":"https://avatars2.githubusercontent.com/u/7398682?v=4","gravatar_id":"","url":"https://api.github.com/users/momo-sa","html_url":"https://github.com/momo-sa","followers_url":"https://api.github.com/users/momo-sa/followers","following_url":"https://api.github.com/users/momo-sa/following{/other_user}","gists_url":"https://api.github.com/users/momo-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/momo-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/momo-sa/subscriptions","organizations_url":"https://api.github.com/users/momo-sa/orgs","repos_url":"https://api.github.com/users/momo-sa/repos","events_url":"https://api.github.com/users/momo-sa/events{/privacy}","received_events_url":"https://api.github.com/users/momo-sa/received_events","type":"User","site_admin":false},"assignees":[{"login":"momo-sa","id":7398682,"avatar_url":"https://avatars2.githubusercontent.com/u/7398682?v=4","gravatar_id":"","url":"https://api.github.com/users/momo-sa","html_url":"https://github.com/momo-sa","followers_url":"https://api.github.com/users/momo-sa/followers","following_url":"https://api.github.com/users/momo-sa/following{/other_user}","gists_url":"https://api.github.com/users/momo-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/momo-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/momo-sa/subscriptions","organizations_url":"https://api.github.com/users/momo-sa/orgs","repos_url":"https://api.github.com/users/momo-sa/repos","events_url":"https://api.github.com/users/momo-sa/events{/privacy}","received_events_url":"https://api.github.com/users/momo-sa/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"StephenKoller","id":1561673,"avatar_url":"https://avatars1.githubusercontent.com/u/1561673?v=4","gravatar_id":"","url":"https://api.github.com/users/StephenKoller","html_url":"https://github.com/StephenKoller","followers_url":"https://api.github.com/users/StephenKoller/followers","following_url":"https://api.github.com/users/StephenKoller/following{/other_user}","gists_url":"https://api.github.com/users/StephenKoller/gists{/gist_id}","starred_url":"https://api.github.com/users/StephenKoller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StephenKoller/subscriptions","organizations_url":"https://api.github.com/users/StephenKoller/orgs","repos_url":"https://api.github.com/users/StephenKoller/repos","events_url":"https://api.github.com/users/StephenKoller/events{/privacy}","received_events_url":"https://api.github.com/users/StephenKoller/received_events","type":"User","site_admin":false},{"login":"maddy531","id":10200622,"avatar_url":"https://avatars3.githubusercontent.com/u/10200622?v=4","gravatar_id":"","url":"https://api.github.com/users/maddy531","html_url":"https://github.com/maddy531","followers_url":"https://api.github.com/users/maddy531/followers","following_url":"https://api.github.com/users/maddy531/following{/other_user}","gists_url":"https://api.github.com/users/maddy531/gists{/gist_id}","starred_url":"https://api.github.com/users/maddy531/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maddy531/subscriptions","organizations_url":"https://api.github.com/users/maddy531/orgs","repos_url":"https://api.github.com/users/maddy531/repos","events_url":"https://api.github.com/users/maddy531/events{/privacy}","received_events_url":"https://api.github.com/users/maddy531/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":112230717,"url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/pulls/78/commits","review_comments_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/pulls/78/comments","review_comment_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/issues/78/comments","statuses_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/statuses/3e8e9c5735fc91b827661078f6486a3f5f359503","head":{"label":"momo-sa:sys/dockerfile-specification","ref":"sys/dockerfile-specification","sha":"3e8e9c5735fc91b827661078f6486a3f5f359503","user":{"login":"momo-sa","id":7398682,"avatar_url":"https://avatars2.githubusercontent.com/u/7398682?v=4","gravatar_id":"","url":"https://api.github.com/users/momo-sa","html_url":"https://github.com/momo-sa","followers_url":"https://api.github.com/users/momo-sa/followers","following_url":"https://api.github.com/users/momo-sa/following{/other_user}","gists_url":"https://api.github.com/users/momo-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/momo-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/momo-sa/subscriptions","organizations_url":"https://api.github.com/users/momo-sa/orgs","repos_url":"https://api.github.com/users/momo-sa/repos","events_url":"https://api.github.com/users/momo-sa/events{/privacy}","received_events_url":"https://api.github.com/users/momo-sa/received_events","type":"User","site_admin":false},"repo":{"id":21587835,"name":"categorical_syllogisms","full_name":"momo-sa/categorical_syllogisms","owner":{"login":"momo-sa","id":7398682,"avatar_url":"https://avatars2.githubusercontent.com/u/7398682?v=4","gravatar_id":"","url":"https://api.github.com/users/momo-sa","html_url":"https://github.com/momo-sa","followers_url":"https://api.github.com/users/momo-sa/followers","following_url":"https://api.github.com/users/momo-sa/following{/other_user}","gists_url":"https://api.github.com/users/momo-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/momo-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/momo-sa/subscriptions","organizations_url":"https://api.github.com/users/momo-sa/orgs","repos_url":"https://api.github.com/users/momo-sa/repos","events_url":"https://api.github.com/users/momo-sa/events{/privacy}","received_events_url":"https://api.github.com/users/momo-sa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/momo-sa/categorical_syllogisms","description":"Automated generation of categorical sentences and syllogisms","fork":false,"url":"https://api.github.com/repos/momo-sa/categorical_syllogisms","forks_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/forks","keys_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/teams","hooks_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/hooks","issue_events_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/issues/events{/number}","events_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/events","assignees_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/assignees{/user}","branches_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/branches{/branch}","tags_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/tags","blobs_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/git/refs{/sha}","trees_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/statuses/{sha}","languages_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/languages","stargazers_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/stargazers","contributors_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/contributors","subscribers_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/subscribers","subscription_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/subscription","commits_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/commits{/sha}","git_commits_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/git/commits{/sha}","comments_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/comments{/number}","issue_comment_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/issues/comments{/number}","contents_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/contents/{+path}","compare_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/merges","archive_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/downloads","issues_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/issues{/number}","pulls_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/pulls{/number}","milestones_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/milestones{/number}","notifications_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/labels{/name}","releases_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/releases{/id}","deployments_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/deployments","created_at":"2014-07-07T21:41:26Z","updated_at":"2018-04-10T00:35:33Z","pushed_at":"2018-04-10T00:35:58Z","git_url":"git://github.com/momo-sa/categorical_syllogisms.git","ssh_url":"git@github.com:momo-sa/categorical_syllogisms.git","clone_url":"https://github.com/momo-sa/categorical_syllogisms.git","svn_url":"https://github.com/momo-sa/categorical_syllogisms","homepage":"","size":668,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"momo-sa:master","ref":"master","sha":"d0c95ff6dee9555f1af7e0de7103786dd6696b55","user":{"login":"momo-sa","id":7398682,"avatar_url":"https://avatars2.githubusercontent.com/u/7398682?v=4","gravatar_id":"","url":"https://api.github.com/users/momo-sa","html_url":"https://github.com/momo-sa","followers_url":"https://api.github.com/users/momo-sa/followers","following_url":"https://api.github.com/users/momo-sa/following{/other_user}","gists_url":"https://api.github.com/users/momo-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/momo-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/momo-sa/subscriptions","organizations_url":"https://api.github.com/users/momo-sa/orgs","repos_url":"https://api.github.com/users/momo-sa/repos","events_url":"https://api.github.com/users/momo-sa/events{/privacy}","received_events_url":"https://api.github.com/users/momo-sa/received_events","type":"User","site_admin":false},"repo":{"id":21587835,"name":"categorical_syllogisms","full_name":"momo-sa/categorical_syllogisms","owner":{"login":"momo-sa","id":7398682,"avatar_url":"https://avatars2.githubusercontent.com/u/7398682?v=4","gravatar_id":"","url":"https://api.github.com/users/momo-sa","html_url":"https://github.com/momo-sa","followers_url":"https://api.github.com/users/momo-sa/followers","following_url":"https://api.github.com/users/momo-sa/following{/other_user}","gists_url":"https://api.github.com/users/momo-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/momo-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/momo-sa/subscriptions","organizations_url":"https://api.github.com/users/momo-sa/orgs","repos_url":"https://api.github.com/users/momo-sa/repos","events_url":"https://api.github.com/users/momo-sa/events{/privacy}","received_events_url":"https://api.github.com/users/momo-sa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/momo-sa/categorical_syllogisms","description":"Automated generation of categorical sentences and syllogisms","fork":false,"url":"https://api.github.com/repos/momo-sa/categorical_syllogisms","forks_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/forks","keys_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/teams","hooks_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/hooks","issue_events_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/issues/events{/number}","events_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/events","assignees_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/assignees{/user}","branches_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/branches{/branch}","tags_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/tags","blobs_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/git/refs{/sha}","trees_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/statuses/{sha}","languages_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/languages","stargazers_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/stargazers","contributors_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/contributors","subscribers_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/subscribers","subscription_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/subscription","commits_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/commits{/sha}","git_commits_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/git/commits{/sha}","comments_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/comments{/number}","issue_comment_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/issues/comments{/number}","contents_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/contents/{+path}","compare_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/merges","archive_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/downloads","issues_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/issues{/number}","pulls_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/pulls{/number}","milestones_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/milestones{/number}","notifications_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/labels{/name}","releases_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/releases{/id}","deployments_url":"https://api.github.com/repos/momo-sa/categorical_syllogisms/deployments","created_at":"2014-07-07T21:41:26Z","updated_at":"2018-04-10T00:35:33Z","pushed_at":"2018-04-10T00:35:58Z","git_url":"git://github.com/momo-sa/categorical_syllogisms.git","ssh_url":"git@github.com:momo-sa/categorical_syllogisms.git","clone_url":"https://github.com/momo-sa/categorical_syllogisms.git","svn_url":"https://github.com/momo-sa/categorical_syllogisms","homepage":"","size":668,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/momo-sa/categorical_syllogisms/pulls/78"},"html":{"href":"https://github.com/momo-sa/categorical_syllogisms/pull/78"},"issue":{"href":"https://api.github.com/repos/momo-sa/categorical_syllogisms/issues/78"},"comments":{"href":"https://api.github.com/repos/momo-sa/categorical_syllogisms/issues/78/comments"},"review_comments":{"href":"https://api.github.com/repos/momo-sa/categorical_syllogisms/pulls/78/comments"},"review_comment":{"href":"https://api.github.com/repos/momo-sa/categorical_syllogisms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/momo-sa/categorical_syllogisms/pulls/78/commits"},"statuses":{"href":"https://api.github.com/repos/momo-sa/categorical_syllogisms/statuses/3e8e9c5735fc91b827661078f6486a3f5f359503"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"momo-sa","id":7398682,"avatar_url":"https://avatars2.githubusercontent.com/u/7398682?v=4","gravatar_id":"","url":"https://api.github.com/users/momo-sa","html_url":"https://github.com/momo-sa","followers_url":"https://api.github.com/users/momo-sa/followers","following_url":"https://api.github.com/users/momo-sa/following{/other_user}","gists_url":"https://api.github.com/users/momo-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/momo-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/momo-sa/subscriptions","organizations_url":"https://api.github.com/users/momo-sa/orgs","repos_url":"https://api.github.com/users/momo-sa/repos","events_url":"https://api.github.com/users/momo-sa/events{/privacy}","received_events_url":"https://api.github.com/users/momo-sa/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":5,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"momo-sa"}}