{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/notes/pulls/comments/185004704","pull_request_review_id":116308844,"id":185004704,"diff_hunk":"@@ -66,8 +68,11 @@ syncNotReady2=Sorry, syncing notes isn’t quite ready. We will count your click\n syncReady=Good news - Sync is ready! Enable it below to get your notes where you need them.\n \n signInToSync=Sign in to Sync\n+signIn=SIGN IN","path":"locales/en-US/notes.properties","position":16,"original_position":16,"commit_id":"fe84bff3c92b18126e0f23255de7740059b65240","original_commit_id":"fe84bff3c92b18126e0f23255de7740059b65240","user":{"login":"flodolo","id":3644868,"avatar_url":"https://avatars0.githubusercontent.com/u/3644868?v=4","gravatar_id":"","url":"https://api.github.com/users/flodolo","html_url":"https://github.com/flodolo","followers_url":"https://api.github.com/users/flodolo/followers","following_url":"https://api.github.com/users/flodolo/following{/other_user}","gists_url":"https://api.github.com/users/flodolo/gists{/gist_id}","starred_url":"https://api.github.com/users/flodolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flodolo/subscriptions","organizations_url":"https://api.github.com/users/flodolo/orgs","repos_url":"https://api.github.com/users/flodolo/repos","events_url":"https://api.github.com/users/flodolo/events{/privacy}","received_events_url":"https://api.github.com/users/flodolo/received_events","type":"User","site_admin":false},"body":"Uppercase in the code is not safe, better to have the string uppercase with a note.","created_at":"2018-04-30T14:35:50Z","updated_at":"2018-04-30T14:36:34Z","html_url":"https://github.com/mozilla/notes/pull/1017#discussion_r185004704","pull_request_url":"https://api.github.com/repos/mozilla/notes/pulls/1017","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/mozilla/notes/pulls/comments/185004704"},"html":{"href":"https://github.com/mozilla/notes/pull/1017#discussion_r185004704"},"pull_request":{"href":"https://api.github.com/repos/mozilla/notes/pulls/1017"}},"in_reply_to_id":185000717},"pull_request":{"url":"https://api.github.com/repos/mozilla/notes/pulls/1017","id":184968707,"html_url":"https://github.com/mozilla/notes/pull/1017","diff_url":"https://github.com/mozilla/notes/pull/1017.diff","patch_url":"https://github.com/mozilla/notes/pull/1017.patch","issue_url":"https://api.github.com/repos/mozilla/notes/issues/1017","number":1017,"state":"open","locked":false,"title":"i18n","user":{"login":"sebastienbarbier","id":3018618,"avatar_url":"https://avatars2.githubusercontent.com/u/3018618?v=4","gravatar_id":"","url":"https://api.github.com/users/sebastienbarbier","html_url":"https://github.com/sebastienbarbier","followers_url":"https://api.github.com/users/sebastienbarbier/followers","following_url":"https://api.github.com/users/sebastienbarbier/following{/other_user}","gists_url":"https://api.github.com/users/sebastienbarbier/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastienbarbier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastienbarbier/subscriptions","organizations_url":"https://api.github.com/users/sebastienbarbier/orgs","repos_url":"https://api.github.com/users/sebastienbarbier/repos","events_url":"https://api.github.com/users/sebastienbarbier/events{/privacy}","received_events_url":"https://api.github.com/users/sebastienbarbier/received_events","type":"User","site_admin":false},"body":"This pull request implement i18n in **notes native app**.\r\n\r\nTexts **still need to be to be defined** and tested before requesting official translation. \r\nWill be completed during the next couple of weeks.\r\n\r\nFix #957 ","created_at":"2018-04-30T14:18:42Z","updated_at":"2018-04-30T14:36:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18d75df3fc654b11f8346ca64c51f4e930b555da","assignee":null,"assignees":[],"requested_reviewers":[{"login":"antlam","id":1994820,"avatar_url":"https://avatars0.githubusercontent.com/u/1994820?v=4","gravatar_id":"","url":"https://api.github.com/users/antlam","html_url":"https://github.com/antlam","followers_url":"https://api.github.com/users/antlam/followers","following_url":"https://api.github.com/users/antlam/following{/other_user}","gists_url":"https://api.github.com/users/antlam/gists{/gist_id}","starred_url":"https://api.github.com/users/antlam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antlam/subscriptions","organizations_url":"https://api.github.com/users/antlam/orgs","repos_url":"https://api.github.com/users/antlam/repos","events_url":"https://api.github.com/users/antlam/events{/privacy}","received_events_url":"https://api.github.com/users/antlam/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":868638032,"url":"https://api.github.com/repos/mozilla/notes/labels/WIP","name":"WIP","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/notes/pulls/1017/commits","review_comments_url":"https://api.github.com/repos/mozilla/notes/pulls/1017/comments","review_comment_url":"https://api.github.com/repos/mozilla/notes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/notes/issues/1017/comments","statuses_url":"https://api.github.com/repos/mozilla/notes/statuses/fe84bff3c92b18126e0f23255de7740059b65240","head":{"label":"mozilla:957-use-getMessage","ref":"957-use-getMessage","sha":"fe84bff3c92b18126e0f23255de7740059b65240","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":91073350,"name":"notes","full_name":"mozilla/notes","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/notes","description":"A notepad for Firefox","fork":false,"url":"https://api.github.com/repos/mozilla/notes","forks_url":"https://api.github.com/repos/mozilla/notes/forks","keys_url":"https://api.github.com/repos/mozilla/notes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/notes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/notes/teams","hooks_url":"https://api.github.com/repos/mozilla/notes/hooks","issue_events_url":"https://api.github.com/repos/mozilla/notes/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/notes/events","assignees_url":"https://api.github.com/repos/mozilla/notes/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/notes/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/notes/tags","blobs_url":"https://api.github.com/repos/mozilla/notes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/notes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/notes/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/notes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/notes/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/notes/languages","stargazers_url":"https://api.github.com/repos/mozilla/notes/stargazers","contributors_url":"https://api.github.com/repos/mozilla/notes/contributors","subscribers_url":"https://api.github.com/repos/mozilla/notes/subscribers","subscription_url":"https://api.github.com/repos/mozilla/notes/subscription","commits_url":"https://api.github.com/repos/mozilla/notes/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/notes/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/notes/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/notes/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/notes/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/notes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/notes/merges","archive_url":"https://api.github.com/repos/mozilla/notes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/notes/downloads","issues_url":"https://api.github.com/repos/mozilla/notes/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/notes/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/notes/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/notes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/notes/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/notes/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/notes/deployments","created_at":"2017-05-12T09:12:56Z","updated_at":"2018-04-30T14:05:04Z","pushed_at":"2018-04-30T14:18:43Z","git_url":"git://github.com/mozilla/notes.git","ssh_url":"git@github.com:mozilla/notes.git","clone_url":"https://github.com/mozilla/notes.git","svn_url":"https://github.com/mozilla/notes","homepage":"https://testpilot.firefox.com/experiments/notes","size":23834,"stargazers_count":166,"watchers_count":166,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":65,"mirror_url":null,"archived":false,"open_issues_count":156,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":65,"open_issues":156,"watchers":166,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"78c2d2377f0cd5a70c86f3bbee1aff0001eec951","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":91073350,"name":"notes","full_name":"mozilla/notes","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/notes","description":"A notepad for Firefox","fork":false,"url":"https://api.github.com/repos/mozilla/notes","forks_url":"https://api.github.com/repos/mozilla/notes/forks","keys_url":"https://api.github.com/repos/mozilla/notes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/notes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/notes/teams","hooks_url":"https://api.github.com/repos/mozilla/notes/hooks","issue_events_url":"https://api.github.com/repos/mozilla/notes/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/notes/events","assignees_url":"https://api.github.com/repos/mozilla/notes/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/notes/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/notes/tags","blobs_url":"https://api.github.com/repos/mozilla/notes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/notes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/notes/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/notes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/notes/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/notes/languages","stargazers_url":"https://api.github.com/repos/mozilla/notes/stargazers","contributors_url":"https://api.github.com/repos/mozilla/notes/contributors","subscribers_url":"https://api.github.com/repos/mozilla/notes/subscribers","subscription_url":"https://api.github.com/repos/mozilla/notes/subscription","commits_url":"https://api.github.com/repos/mozilla/notes/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/notes/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/notes/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/notes/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/notes/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/notes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/notes/merges","archive_url":"https://api.github.com/repos/mozilla/notes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/notes/downloads","issues_url":"https://api.github.com/repos/mozilla/notes/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/notes/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/notes/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/notes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/notes/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/notes/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/notes/deployments","created_at":"2017-05-12T09:12:56Z","updated_at":"2018-04-30T14:05:04Z","pushed_at":"2018-04-30T14:18:43Z","git_url":"git://github.com/mozilla/notes.git","ssh_url":"git@github.com:mozilla/notes.git","clone_url":"https://github.com/mozilla/notes.git","svn_url":"https://github.com/mozilla/notes","homepage":"https://testpilot.firefox.com/experiments/notes","size":23834,"stargazers_count":166,"watchers_count":166,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":65,"mirror_url":null,"archived":false,"open_issues_count":156,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":65,"open_issues":156,"watchers":166,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/notes/pulls/1017"},"html":{"href":"https://github.com/mozilla/notes/pull/1017"},"issue":{"href":"https://api.github.com/repos/mozilla/notes/issues/1017"},"comments":{"href":"https://api.github.com/repos/mozilla/notes/issues/1017/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/notes/pulls/1017/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/notes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/notes/pulls/1017/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/notes/statuses/fe84bff3c92b18126e0f23255de7740059b65240"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"flodolo"}}