{"action":"closed","number":1408,"pull_request":{"url":"https://api.github.com/repos/TypeStrong/atom-typescript/pulls/1408","id":171932489,"html_url":"https://github.com/TypeStrong/atom-typescript/pull/1408","diff_url":"https://github.com/TypeStrong/atom-typescript/pull/1408.diff","patch_url":"https://github.com/TypeStrong/atom-typescript/pull/1408.patch","issue_url":"https://api.github.com/repos/TypeStrong/atom-typescript/issues/1408","number":1408,"state":"closed","locked":false,"title":"[experimental] Symbols view","user":{"login":"lierdakil","id":7275622,"avatar_url":"https://avatars1.githubusercontent.com/u/7275622?v=4","gravatar_id":"","url":"https://api.github.com/users/lierdakil","html_url":"https://github.com/lierdakil","followers_url":"https://api.github.com/users/lierdakil/followers","following_url":"https://api.github.com/users/lierdakil/following{/other_user}","gists_url":"https://api.github.com/users/lierdakil/gists{/gist_id}","starred_url":"https://api.github.com/users/lierdakil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lierdakil/subscriptions","organizations_url":"https://api.github.com/users/lierdakil/orgs","repos_url":"https://api.github.com/users/lierdakil/repos","events_url":"https://api.github.com/users/lierdakil/events{/privacy}","received_events_url":"https://api.github.com/users/lierdakil/received_events","type":"User","site_admin":false},"body":"- [X] All compiled assets are included (atom packages are git tags and hence the built files need to be a part of the source control)\r\n\r\n@russaa, this is based on #1407 \r\n\r\nOne big change I made is instead of using `navTo` for project navigation, I just run `navTree` for all project files (except those in `/node_modules/`, but the exclusion algorithm is stupid and needs some work). That's not necessarily because I think it's better, just because I didn't have time to fumble with streaming loading.\r\n\r\nOh, yes, and I moved getting navTree into `TypescriptBuffer`.\r\n\r\nThis is by no means perfect emulation of `symbols-view`, but the code ended up being *a lot* more straightforward IMO, and I would argue that we don't *want* the perfect emulation of `symbols-view`, since it refers to `ctags` more than once, which can be confusing.\r\n\r\nThe only features missing compared to `symbols-view` at the moment are `symbols-view:return-from-declaration` and highlighting of the matched prefix in select-view.\r\n\r\nThe former we have already, actually, so we just need to hook new code into that.\r\n\r\nThe latter I couldn't be bothered with at the moment, but it *should* be rather straightforward.\r\n\r\nAnyway, let me know if you think this seems somewhat reasonable.","created_at":"2018-02-28T11:55:50Z","updated_at":"2018-03-01T08:31:18Z","closed_at":"2018-03-01T08:31:18Z","merged_at":null,"merge_commit_sha":"017a796f5f77f29c42c8aa1c11fc705a600d7e20","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/TypeStrong/atom-typescript/pulls/1408/commits","review_comments_url":"https://api.github.com/repos/TypeStrong/atom-typescript/pulls/1408/comments","review_comment_url":"https://api.github.com/repos/TypeStrong/atom-typescript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TypeStrong/atom-typescript/issues/1408/comments","statuses_url":"https://api.github.com/repos/TypeStrong/atom-typescript/statuses/c7c2d0c64751cf89ac54f4f42a2b9bff13c448cb","head":{"label":"TypeStrong:mmig-issue1219_symbols-view","ref":"mmig-issue1219_symbols-view","sha":"c7c2d0c64751cf89ac54f4f42a2b9bff13c448cb","user":{"login":"TypeStrong","id":6759814,"avatar_url":"https://avatars3.githubusercontent.com/u/6759814?v=4","gravatar_id":"","url":"https://api.github.com/users/TypeStrong","html_url":"https://github.com/TypeStrong","followers_url":"https://api.github.com/users/TypeStrong/followers","following_url":"https://api.github.com/users/TypeStrong/following{/other_user}","gists_url":"https://api.github.com/users/TypeStrong/gists{/gist_id}","starred_url":"https://api.github.com/users/TypeStrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TypeStrong/subscriptions","organizations_url":"https://api.github.com/users/TypeStrong/orgs","repos_url":"https://api.github.com/users/TypeStrong/repos","events_url":"https://api.github.com/users/TypeStrong/events{/privacy}","received_events_url":"https://api.github.com/users/TypeStrong/received_events","type":"Organization","site_admin":false},"repo":{"id":21060126,"name":"atom-typescript","full_name":"TypeStrong/atom-typescript","owner":{"login":"TypeStrong","id":6759814,"avatar_url":"https://avatars3.githubusercontent.com/u/6759814?v=4","gravatar_id":"","url":"https://api.github.com/users/TypeStrong","html_url":"https://github.com/TypeStrong","followers_url":"https://api.github.com/users/TypeStrong/followers","following_url":"https://api.github.com/users/TypeStrong/following{/other_user}","gists_url":"https://api.github.com/users/TypeStrong/gists{/gist_id}","starred_url":"https://api.github.com/users/TypeStrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TypeStrong/subscriptions","organizations_url":"https://api.github.com/users/TypeStrong/orgs","repos_url":"https://api.github.com/users/TypeStrong/repos","events_url":"https://api.github.com/users/TypeStrong/events{/privacy}","received_events_url":"https://api.github.com/users/TypeStrong/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TypeStrong/atom-typescript","description":"The only TypeScript package you will ever need","fork":false,"url":"https://api.github.com/repos/TypeStrong/atom-typescript","forks_url":"https://api.github.com/repos/TypeStrong/atom-typescript/forks","keys_url":"https://api.github.com/repos/TypeStrong/atom-typescript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TypeStrong/atom-typescript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TypeStrong/atom-typescript/teams","hooks_url":"https://api.github.com/repos/TypeStrong/atom-typescript/hooks","issue_events_url":"https://api.github.com/repos/TypeStrong/atom-typescript/issues/events{/number}","events_url":"https://api.github.com/repos/TypeStrong/atom-typescript/events","assignees_url":"https://api.github.com/repos/TypeStrong/atom-typescript/assignees{/user}","branches_url":"https://api.github.com/repos/TypeStrong/atom-typescript/branches{/branch}","tags_url":"https://api.github.com/repos/TypeStrong/atom-typescript/tags","blobs_url":"https://api.github.com/repos/TypeStrong/atom-typescript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TypeStrong/atom-typescript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TypeStrong/atom-typescript/git/refs{/sha}","trees_url":"https://api.github.com/repos/TypeStrong/atom-typescript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TypeStrong/atom-typescript/statuses/{sha}","languages_url":"https://api.github.com/repos/TypeStrong/atom-typescript/languages","stargazers_url":"https://api.github.com/repos/TypeStrong/atom-typescript/stargazers","contributors_url":"https://api.github.com/repos/TypeStrong/atom-typescript/contributors","subscribers_url":"https://api.github.com/repos/TypeStrong/atom-typescript/subscribers","subscription_url":"https://api.github.com/repos/TypeStrong/atom-typescript/subscription","commits_url":"https://api.github.com/repos/TypeStrong/atom-typescript/commits{/sha}","git_commits_url":"https://api.github.com/repos/TypeStrong/atom-typescript/git/commits{/sha}","comments_url":"https://api.github.com/repos/TypeStrong/atom-typescript/comments{/number}","issue_comment_url":"https://api.github.com/repos/TypeStrong/atom-typescript/issues/comments{/number}","contents_url":"https://api.github.com/repos/TypeStrong/atom-typescript/contents/{+path}","compare_url":"https://api.github.com/repos/TypeStrong/atom-typescript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TypeStrong/atom-typescript/merges","archive_url":"https://api.github.com/repos/TypeStrong/atom-typescript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TypeStrong/atom-typescript/downloads","issues_url":"https://api.github.com/repos/TypeStrong/atom-typescript/issues{/number}","pulls_url":"https://api.github.com/repos/TypeStrong/atom-typescript/pulls{/number}","milestones_url":"https://api.github.com/repos/TypeStrong/atom-typescript/milestones{/number}","notifications_url":"https://api.github.com/repos/TypeStrong/atom-typescript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TypeStrong/atom-typescript/labels{/name}","releases_url":"https://api.github.com/repos/TypeStrong/atom-typescript/releases{/id}","deployments_url":"https://api.github.com/repos/TypeStrong/atom-typescript/deployments","created_at":"2014-06-21T04:14:41Z","updated_at":"2018-02-28T07:51:48Z","pushed_at":"2018-03-01T08:29:30Z","git_url":"git://github.com/TypeStrong/atom-typescript.git","ssh_url":"git@github.com:TypeStrong/atom-typescript.git","clone_url":"https://github.com/TypeStrong/atom-typescript.git","svn_url":"https://github.com/TypeStrong/atom-typescript","homepage":"https://atom.io/packages/atom-typescript","size":23661,"stargazers_count":978,"watchers_count":978,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":194,"mirror_url":null,"archived":false,"open_issues_count":262,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":194,"open_issues":262,"watchers":978,"default_branch":"master"}},"base":{"label":"TypeStrong:master","ref":"master","sha":"ae4ece5f7ce560cb9ccbee21758a4416669bdc67","user":{"login":"TypeStrong","id":6759814,"avatar_url":"https://avatars3.githubusercontent.com/u/6759814?v=4","gravatar_id":"","url":"https://api.github.com/users/TypeStrong","html_url":"https://github.com/TypeStrong","followers_url":"https://api.github.com/users/TypeStrong/followers","following_url":"https://api.github.com/users/TypeStrong/following{/other_user}","gists_url":"https://api.github.com/users/TypeStrong/gists{/gist_id}","starred_url":"https://api.github.com/users/TypeStrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TypeStrong/subscriptions","organizations_url":"https://api.github.com/users/TypeStrong/orgs","repos_url":"https://api.github.com/users/TypeStrong/repos","events_url":"https://api.github.com/users/TypeStrong/events{/privacy}","received_events_url":"https://api.github.com/users/TypeStrong/received_events","type":"Organization","site_admin":false},"repo":{"id":21060126,"name":"atom-typescript","full_name":"TypeStrong/atom-typescript","owner":{"login":"TypeStrong","id":6759814,"avatar_url":"https://avatars3.githubusercontent.com/u/6759814?v=4","gravatar_id":"","url":"https://api.github.com/users/TypeStrong","html_url":"https://github.com/TypeStrong","followers_url":"https://api.github.com/users/TypeStrong/followers","following_url":"https://api.github.com/users/TypeStrong/following{/other_user}","gists_url":"https://api.github.com/users/TypeStrong/gists{/gist_id}","starred_url":"https://api.github.com/users/TypeStrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TypeStrong/subscriptions","organizations_url":"https://api.github.com/users/TypeStrong/orgs","repos_url":"https://api.github.com/users/TypeStrong/repos","events_url":"https://api.github.com/users/TypeStrong/events{/privacy}","received_events_url":"https://api.github.com/users/TypeStrong/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TypeStrong/atom-typescript","description":"The only TypeScript package you will ever need","fork":false,"url":"https://api.github.com/repos/TypeStrong/atom-typescript","forks_url":"https://api.github.com/repos/TypeStrong/atom-typescript/forks","keys_url":"https://api.github.com/repos/TypeStrong/atom-typescript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TypeStrong/atom-typescript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TypeStrong/atom-typescript/teams","hooks_url":"https://api.github.com/repos/TypeStrong/atom-typescript/hooks","issue_events_url":"https://api.github.com/repos/TypeStrong/atom-typescript/issues/events{/number}","events_url":"https://api.github.com/repos/TypeStrong/atom-typescript/events","assignees_url":"https://api.github.com/repos/TypeStrong/atom-typescript/assignees{/user}","branches_url":"https://api.github.com/repos/TypeStrong/atom-typescript/branches{/branch}","tags_url":"https://api.github.com/repos/TypeStrong/atom-typescript/tags","blobs_url":"https://api.github.com/repos/TypeStrong/atom-typescript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TypeStrong/atom-typescript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TypeStrong/atom-typescript/git/refs{/sha}","trees_url":"https://api.github.com/repos/TypeStrong/atom-typescript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TypeStrong/atom-typescript/statuses/{sha}","languages_url":"https://api.github.com/repos/TypeStrong/atom-typescript/languages","stargazers_url":"https://api.github.com/repos/TypeStrong/atom-typescript/stargazers","contributors_url":"https://api.github.com/repos/TypeStrong/atom-typescript/contributors","subscribers_url":"https://api.github.com/repos/TypeStrong/atom-typescript/subscribers","subscription_url":"https://api.github.com/repos/TypeStrong/atom-typescript/subscription","commits_url":"https://api.github.com/repos/TypeStrong/atom-typescript/commits{/sha}","git_commits_url":"https://api.github.com/repos/TypeStrong/atom-typescript/git/commits{/sha}","comments_url":"https://api.github.com/repos/TypeStrong/atom-typescript/comments{/number}","issue_comment_url":"https://api.github.com/repos/TypeStrong/atom-typescript/issues/comments{/number}","contents_url":"https://api.github.com/repos/TypeStrong/atom-typescript/contents/{+path}","compare_url":"https://api.github.com/repos/TypeStrong/atom-typescript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TypeStrong/atom-typescript/merges","archive_url":"https://api.github.com/repos/TypeStrong/atom-typescript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TypeStrong/atom-typescript/downloads","issues_url":"https://api.github.com/repos/TypeStrong/atom-typescript/issues{/number}","pulls_url":"https://api.github.com/repos/TypeStrong/atom-typescript/pulls{/number}","milestones_url":"https://api.github.com/repos/TypeStrong/atom-typescript/milestones{/number}","notifications_url":"https://api.github.com/repos/TypeStrong/atom-typescript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TypeStrong/atom-typescript/labels{/name}","releases_url":"https://api.github.com/repos/TypeStrong/atom-typescript/releases{/id}","deployments_url":"https://api.github.com/repos/TypeStrong/atom-typescript/deployments","created_at":"2014-06-21T04:14:41Z","updated_at":"2018-02-28T07:51:48Z","pushed_at":"2018-03-01T08:29:30Z","git_url":"git://github.com/TypeStrong/atom-typescript.git","ssh_url":"git@github.com:TypeStrong/atom-typescript.git","clone_url":"https://github.com/TypeStrong/atom-typescript.git","svn_url":"https://github.com/TypeStrong/atom-typescript","homepage":"https://atom.io/packages/atom-typescript","size":23661,"stargazers_count":978,"watchers_count":978,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":194,"mirror_url":null,"archived":false,"open_issues_count":262,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":194,"open_issues":262,"watchers":978,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TypeStrong/atom-typescript/pulls/1408"},"html":{"href":"https://github.com/TypeStrong/atom-typescript/pull/1408"},"issue":{"href":"https://api.github.com/repos/TypeStrong/atom-typescript/issues/1408"},"comments":{"href":"https://api.github.com/repos/TypeStrong/atom-typescript/issues/1408/comments"},"review_comments":{"href":"https://api.github.com/repos/TypeStrong/atom-typescript/pulls/1408/comments"},"review_comment":{"href":"https://api.github.com/repos/TypeStrong/atom-typescript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TypeStrong/atom-typescript/pulls/1408/commits"},"statuses":{"href":"https://api.github.com/repos/TypeStrong/atom-typescript/statuses/c7c2d0c64751cf89ac54f4f42a2b9bff13c448cb"}},"author_association":"COLLABORATOR","merged":false,"mergeable":true,"rebaseable":false,"mergeable_state":"clean","merged_by":null,"comments":6,"review_comments":0,"maintainer_can_modify":false,"commits":36,"additions":832,"deletions":59,"changed_files":60}}
{"actor":{"display_login":"lierdakil"}}