{"action":"closed","number":1460,"pull_request":{"url":"https://api.github.com/repos/mlpack/mlpack/pulls/1460","id":199080551,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MDgwNTUx","html_url":"https://github.com/mlpack/mlpack/pull/1460","diff_url":"https://github.com/mlpack/mlpack/pull/1460.diff","patch_url":"https://github.com/mlpack/mlpack/pull/1460.patch","issue_url":"https://api.github.com/repos/mlpack/mlpack/issues/1460","number":1460,"state":"closed","locked":false,"title":"Add documentation fields to setup.py.in","user":{"login":"rcurtin","id":1845039,"node_id":"MDQ6VXNlcjE4NDUwMzk=","avatar_url":"https://avatars0.githubusercontent.com/u/1845039?v=4","gravatar_id":"","url":"https://api.github.com/users/rcurtin","html_url":"https://github.com/rcurtin","followers_url":"https://api.github.com/users/rcurtin/followers","following_url":"https://api.github.com/users/rcurtin/following{/other_user}","gists_url":"https://api.github.com/users/rcurtin/gists{/gist_id}","starred_url":"https://api.github.com/users/rcurtin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcurtin/subscriptions","organizations_url":"https://api.github.com/users/rcurtin/orgs","repos_url":"https://api.github.com/users/rcurtin/repos","events_url":"https://api.github.com/users/rcurtin/events{/privacy}","received_events_url":"https://api.github.com/users/rcurtin/received_events","type":"User","site_admin":false},"body":"Also simplify the CXXFLAGS setting process.\r\n\r\nI found that these fields were missing from the package uploaded to PyPI back when I packaged mlpack 3.0.0, and today I pushed mlpack 3.0.2 and noticed I needed to modify the script.  So it would be a good thing to merge these into master.\r\n\r\nIf you see any changes that we should make to the documentation please feel free.  Here is the PyPI page this results in:\r\n\r\nhttps://pypi.org/project/mlpack3/\r\n\r\nWe could modify it a bit---for instance, scikit actually loads their entire README into the long description with code like:\r\n\r\n```\r\nwith open('README.rst') as f:\r\n  LONG_DESCRIPTION = f.read()\r\n```\r\n\r\nBut unless someone explicitly wants me to do that (and it's no problem if anyone does want it), I'll leave it as-is.","created_at":"2018-07-03T20:53:59Z","updated_at":"2018-07-14T13:51:33Z","closed_at":"2018-07-14T13:51:33Z","merged_at":"2018-07-14T13:51:33Z","merge_commit_sha":"884523db6103bccea300607d1277775428abe516","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mlpack/mlpack/pulls/1460/commits","review_comments_url":"https://api.github.com/repos/mlpack/mlpack/pulls/1460/comments","review_comment_url":"https://api.github.com/repos/mlpack/mlpack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mlpack/mlpack/issues/1460/comments","statuses_url":"https://api.github.com/repos/mlpack/mlpack/statuses/5b1b7d3b3d5ee5cf960e7dc8a5ea34c24becf7df","head":{"label":"rcurtin:master","ref":"master","sha":"5b1b7d3b3d5ee5cf960e7dc8a5ea34c24becf7df","user":{"login":"rcurtin","id":1845039,"node_id":"MDQ6VXNlcjE4NDUwMzk=","avatar_url":"https://avatars0.githubusercontent.com/u/1845039?v=4","gravatar_id":"","url":"https://api.github.com/users/rcurtin","html_url":"https://github.com/rcurtin","followers_url":"https://api.github.com/users/rcurtin/followers","following_url":"https://api.github.com/users/rcurtin/following{/other_user}","gists_url":"https://api.github.com/users/rcurtin/gists{/gist_id}","starred_url":"https://api.github.com/users/rcurtin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcurtin/subscriptions","organizations_url":"https://api.github.com/users/rcurtin/orgs","repos_url":"https://api.github.com/users/rcurtin/repos","events_url":"https://api.github.com/users/rcurtin/events{/privacy}","received_events_url":"https://api.github.com/users/rcurtin/received_events","type":"User","site_admin":false},"repo":{"id":28698514,"node_id":"MDEwOlJlcG9zaXRvcnkyODY5ODUxNA==","name":"mlpack","full_name":"rcurtin/mlpack","owner":{"login":"rcurtin","id":1845039,"node_id":"MDQ6VXNlcjE4NDUwMzk=","avatar_url":"https://avatars0.githubusercontent.com/u/1845039?v=4","gravatar_id":"","url":"https://api.github.com/users/rcurtin","html_url":"https://github.com/rcurtin","followers_url":"https://api.github.com/users/rcurtin/followers","following_url":"https://api.github.com/users/rcurtin/following{/other_user}","gists_url":"https://api.github.com/users/rcurtin/gists{/gist_id}","starred_url":"https://api.github.com/users/rcurtin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcurtin/subscriptions","organizations_url":"https://api.github.com/users/rcurtin/orgs","repos_url":"https://api.github.com/users/rcurtin/repos","events_url":"https://api.github.com/users/rcurtin/events{/privacy}","received_events_url":"https://api.github.com/users/rcurtin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rcurtin/mlpack","description":"mlpack: a scalable C++ machine learning library","fork":true,"url":"https://api.github.com/repos/rcurtin/mlpack","forks_url":"https://api.github.com/repos/rcurtin/mlpack/forks","keys_url":"https://api.github.com/repos/rcurtin/mlpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rcurtin/mlpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rcurtin/mlpack/teams","hooks_url":"https://api.github.com/repos/rcurtin/mlpack/hooks","issue_events_url":"https://api.github.com/repos/rcurtin/mlpack/issues/events{/number}","events_url":"https://api.github.com/repos/rcurtin/mlpack/events","assignees_url":"https://api.github.com/repos/rcurtin/mlpack/assignees{/user}","branches_url":"https://api.github.com/repos/rcurtin/mlpack/branches{/branch}","tags_url":"https://api.github.com/repos/rcurtin/mlpack/tags","blobs_url":"https://api.github.com/repos/rcurtin/mlpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rcurtin/mlpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rcurtin/mlpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/rcurtin/mlpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rcurtin/mlpack/statuses/{sha}","languages_url":"https://api.github.com/repos/rcurtin/mlpack/languages","stargazers_url":"https://api.github.com/repos/rcurtin/mlpack/stargazers","contributors_url":"https://api.github.com/repos/rcurtin/mlpack/contributors","subscribers_url":"https://api.github.com/repos/rcurtin/mlpack/subscribers","subscription_url":"https://api.github.com/repos/rcurtin/mlpack/subscription","commits_url":"https://api.github.com/repos/rcurtin/mlpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/rcurtin/mlpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/rcurtin/mlpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/rcurtin/mlpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/rcurtin/mlpack/contents/{+path}","compare_url":"https://api.github.com/repos/rcurtin/mlpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rcurtin/mlpack/merges","archive_url":"https://api.github.com/repos/rcurtin/mlpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rcurtin/mlpack/downloads","issues_url":"https://api.github.com/repos/rcurtin/mlpack/issues{/number}","pulls_url":"https://api.github.com/repos/rcurtin/mlpack/pulls{/number}","milestones_url":"https://api.github.com/repos/rcurtin/mlpack/milestones{/number}","notifications_url":"https://api.github.com/repos/rcurtin/mlpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rcurtin/mlpack/labels{/name}","releases_url":"https://api.github.com/repos/rcurtin/mlpack/releases{/id}","deployments_url":"https://api.github.com/repos/rcurtin/mlpack/deployments","created_at":"2015-01-01T23:37:11Z","updated_at":"2018-07-12T17:57:10Z","pushed_at":"2018-07-12T17:57:08Z","git_url":"git://github.com/rcurtin/mlpack.git","ssh_url":"git@github.com:rcurtin/mlpack.git","clone_url":"https://github.com/rcurtin/mlpack.git","svn_url":"https://github.com/rcurtin/mlpack","homepage":null,"size":242606,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":5,"default_branch":"master"}},"base":{"label":"mlpack:master","ref":"master","sha":"255bc42165cb7785e93992ad32ad54b880fcd3c5","user":{"login":"mlpack","id":10216045,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjE2MDQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10216045?v=4","gravatar_id":"","url":"https://api.github.com/users/mlpack","html_url":"https://github.com/mlpack","followers_url":"https://api.github.com/users/mlpack/followers","following_url":"https://api.github.com/users/mlpack/following{/other_user}","gists_url":"https://api.github.com/users/mlpack/gists{/gist_id}","starred_url":"https://api.github.com/users/mlpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlpack/subscriptions","organizations_url":"https://api.github.com/users/mlpack/orgs","repos_url":"https://api.github.com/users/mlpack/repos","events_url":"https://api.github.com/users/mlpack/events{/privacy}","received_events_url":"https://api.github.com/users/mlpack/received_events","type":"Organization","site_admin":false},"repo":{"id":28149409,"node_id":"MDEwOlJlcG9zaXRvcnkyODE0OTQwOQ==","name":"mlpack","full_name":"mlpack/mlpack","owner":{"login":"mlpack","id":10216045,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjE2MDQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10216045?v=4","gravatar_id":"","url":"https://api.github.com/users/mlpack","html_url":"https://github.com/mlpack","followers_url":"https://api.github.com/users/mlpack/followers","following_url":"https://api.github.com/users/mlpack/following{/other_user}","gists_url":"https://api.github.com/users/mlpack/gists{/gist_id}","starred_url":"https://api.github.com/users/mlpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlpack/subscriptions","organizations_url":"https://api.github.com/users/mlpack/orgs","repos_url":"https://api.github.com/users/mlpack/repos","events_url":"https://api.github.com/users/mlpack/events{/privacy}","received_events_url":"https://api.github.com/users/mlpack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mlpack/mlpack","description":"mlpack: a scalable C++ machine learning library -- ","fork":false,"url":"https://api.github.com/repos/mlpack/mlpack","forks_url":"https://api.github.com/repos/mlpack/mlpack/forks","keys_url":"https://api.github.com/repos/mlpack/mlpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlpack/mlpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlpack/mlpack/teams","hooks_url":"https://api.github.com/repos/mlpack/mlpack/hooks","issue_events_url":"https://api.github.com/repos/mlpack/mlpack/issues/events{/number}","events_url":"https://api.github.com/repos/mlpack/mlpack/events","assignees_url":"https://api.github.com/repos/mlpack/mlpack/assignees{/user}","branches_url":"https://api.github.com/repos/mlpack/mlpack/branches{/branch}","tags_url":"https://api.github.com/repos/mlpack/mlpack/tags","blobs_url":"https://api.github.com/repos/mlpack/mlpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlpack/mlpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlpack/mlpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlpack/mlpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlpack/mlpack/statuses/{sha}","languages_url":"https://api.github.com/repos/mlpack/mlpack/languages","stargazers_url":"https://api.github.com/repos/mlpack/mlpack/stargazers","contributors_url":"https://api.github.com/repos/mlpack/mlpack/contributors","subscribers_url":"https://api.github.com/repos/mlpack/mlpack/subscribers","subscription_url":"https://api.github.com/repos/mlpack/mlpack/subscription","commits_url":"https://api.github.com/repos/mlpack/mlpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlpack/mlpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlpack/mlpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlpack/mlpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlpack/mlpack/contents/{+path}","compare_url":"https://api.github.com/repos/mlpack/mlpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlpack/mlpack/merges","archive_url":"https://api.github.com/repos/mlpack/mlpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlpack/mlpack/downloads","issues_url":"https://api.github.com/repos/mlpack/mlpack/issues{/number}","pulls_url":"https://api.github.com/repos/mlpack/mlpack/pulls{/number}","milestones_url":"https://api.github.com/repos/mlpack/mlpack/milestones{/number}","notifications_url":"https://api.github.com/repos/mlpack/mlpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlpack/mlpack/labels{/name}","releases_url":"https://api.github.com/repos/mlpack/mlpack/releases{/id}","deployments_url":"https://api.github.com/repos/mlpack/mlpack/deployments","created_at":"2014-12-17T18:16:59Z","updated_at":"2018-07-12T13:34:27Z","pushed_at":"2018-07-14T13:51:33Z","git_url":"git://github.com/mlpack/mlpack.git","ssh_url":"git@github.com:mlpack/mlpack.git","clone_url":"https://github.com/mlpack/mlpack.git","svn_url":"https://github.com/mlpack/mlpack","homepage":"http://www.mlpack.org/","size":244398,"stargazers_count":2267,"watchers_count":2267,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":817,"mirror_url":null,"archived":false,"open_issues_count":110,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":817,"open_issues":110,"watchers":2267,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mlpack/mlpack/pulls/1460"},"html":{"href":"https://github.com/mlpack/mlpack/pull/1460"},"issue":{"href":"https://api.github.com/repos/mlpack/mlpack/issues/1460"},"comments":{"href":"https://api.github.com/repos/mlpack/mlpack/issues/1460/comments"},"review_comments":{"href":"https://api.github.com/repos/mlpack/mlpack/pulls/1460/comments"},"review_comment":{"href":"https://api.github.com/repos/mlpack/mlpack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mlpack/mlpack/pulls/1460/commits"},"statuses":{"href":"https://api.github.com/repos/mlpack/mlpack/statuses/5b1b7d3b3d5ee5cf960e7dc8a5ea34c24becf7df"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"rcurtin","id":1845039,"node_id":"MDQ6VXNlcjE4NDUwMzk=","avatar_url":"https://avatars0.githubusercontent.com/u/1845039?v=4","gravatar_id":"","url":"https://api.github.com/users/rcurtin","html_url":"https://github.com/rcurtin","followers_url":"https://api.github.com/users/rcurtin/followers","following_url":"https://api.github.com/users/rcurtin/following{/other_user}","gists_url":"https://api.github.com/users/rcurtin/gists{/gist_id}","starred_url":"https://api.github.com/users/rcurtin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcurtin/subscriptions","organizations_url":"https://api.github.com/users/rcurtin/orgs","repos_url":"https://api.github.com/users/rcurtin/repos","events_url":"https://api.github.com/users/rcurtin/events{/privacy}","received_events_url":"https://api.github.com/users/rcurtin/received_events","type":"User","site_admin":false},"comments":1,"review_comments":3,"maintainer_can_modify":false,"commits":2,"additions":28,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"rcurtin"}}