{"action":"created","issue":{"url":"https://api.github.com/repos/halide/Halide/issues/3020","repository_url":"https://api.github.com/repos/halide/Halide","labels_url":"https://api.github.com/repos/halide/Halide/issues/3020/labels{/name}","comments_url":"https://api.github.com/repos/halide/Halide/issues/3020/comments","events_url":"https://api.github.com/repos/halide/Halide/issues/3020/events","html_url":"https://github.com/halide/Halide/pull/3020","id":329194784,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNTExNTcw","number":3020,"title":"Disallow unsafe Buffer::crop calls()","user":{"login":"steven-johnson","id":328955,"node_id":"MDQ6VXNlcjMyODk1NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/328955?v=4","gravatar_id":"","url":"https://api.github.com/users/steven-johnson","html_url":"https://github.com/steven-johnson","followers_url":"https://api.github.com/users/steven-johnson/followers","following_url":"https://api.github.com/users/steven-johnson/following{/other_user}","gists_url":"https://api.github.com/users/steven-johnson/gists{/gist_id}","starred_url":"https://api.github.com/users/steven-johnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steven-johnson/subscriptions","organizations_url":"https://api.github.com/users/steven-johnson/orgs","repos_url":"https://api.github.com/users/steven-johnson/repos","events_url":"https://api.github.com/users/steven-johnson/events{/privacy}","received_events_url":"https://api.github.com/users/steven-johnson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-04T19:57:35Z","updated_at":"2018-06-04T20:18:36Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/halide/Halide/pulls/3020","html_url":"https://github.com/halide/Halide/pull/3020","diff_url":"https://github.com/halide/Halide/pull/3020.diff","patch_url":"https://github.com/halide/Halide/pull/3020.patch"},"body":"Previously we explicitly allowed crop() calls that expanded the Buffer, as the implementation of Func::infer_input_bounds() relied upon it. This is a dangerous and bad idea. Add assertion-checks that require crop() goes inward, and fix the implementation of Func::infer_input_bounds() to not rely upon the previous behavior."},"comment":{"url":"https://api.github.com/repos/halide/Halide/issues/comments/394484927","html_url":"https://github.com/halide/Halide/pull/3020#issuecomment-394484927","issue_url":"https://api.github.com/repos/halide/Halide/issues/3020","id":394484927,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDQ4NDkyNw==","user":{"login":"abadams","id":515398,"node_id":"MDQ6VXNlcjUxNTM5OA==","avatar_url":"https://avatars0.githubusercontent.com/u/515398?v=4","gravatar_id":"","url":"https://api.github.com/users/abadams","html_url":"https://github.com/abadams","followers_url":"https://api.github.com/users/abadams/followers","following_url":"https://api.github.com/users/abadams/following{/other_user}","gists_url":"https://api.github.com/users/abadams/gists{/gist_id}","starred_url":"https://api.github.com/users/abadams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abadams/subscriptions","organizations_url":"https://api.github.com/users/abadams/orgs","repos_url":"https://api.github.com/users/abadams/repos","events_url":"https://api.github.com/users/abadams/events{/privacy}","received_events_url":"https://api.github.com/users/abadams/received_events","type":"User","site_admin":false},"created_at":"2018-06-04T20:18:36Z","updated_at":"2018-06-04T20:18:36Z","author_association":"MEMBER","body":"In terms of relative ickiness, how do you feel about using the constructor that takes an explicit pointer, and passing a bogus value?"}}
{"actor":{"display_login":"abadams"}}