{"action":"created","issue":{"url":"https://api.github.com/repos/nunit/nunit3-vs-adapter/issues/541","repository_url":"https://api.github.com/repos/nunit/nunit3-vs-adapter","labels_url":"https://api.github.com/repos/nunit/nunit3-vs-adapter/issues/541/labels{/name}","comments_url":"https://api.github.com/repos/nunit/nunit3-vs-adapter/issues/541/comments","events_url":"https://api.github.com/repos/nunit/nunit3-vs-adapter/issues/541/events","html_url":"https://github.com/nunit/nunit3-vs-adapter/pull/541","id":354133332,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwOTczNjk0","number":541,"title":" Embed Mono.Cecil so user dependencies are no longer overwritten ","user":{"login":"jnm2","id":8040367,"node_id":"MDQ6VXNlcjgwNDAzNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/8040367?v=4","gravatar_id":"","url":"https://api.github.com/users/jnm2","html_url":"https://github.com/jnm2","followers_url":"https://api.github.com/users/jnm2/followers","following_url":"https://api.github.com/users/jnm2/following{/other_user}","gists_url":"https://api.github.com/users/jnm2/gists{/gist_id}","starred_url":"https://api.github.com/users/jnm2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnm2/subscriptions","organizations_url":"https://api.github.com/users/jnm2/orgs","repos_url":"https://api.github.com/users/jnm2/repos","events_url":"https://api.github.com/users/jnm2/events{/privacy}","received_events_url":"https://api.github.com/users/jnm2/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-08-26T22:10:03Z","updated_at":"2018-09-05T01:51:47Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/nunit/nunit3-vs-adapter/pulls/541","html_url":"https://github.com/nunit/nunit3-vs-adapter/pull/541","diff_url":"https://github.com/nunit/nunit3-vs-adapter/pull/541.diff","patch_url":"https://github.com/nunit/nunit3-vs-adapter/pull/541.patch"},"body":"Closes nunit/nunit-console#389, #366, and #488 for all platforms! Pretty excited about this after all our frustrations! 🎉\r\n\r\nThe first commit adds a simple passing acceptance test that proves the adapter is packaged basically correctly. The acceptance tests hardly add any time on my machine after a `git clean -xfd`, despite having to cache all NuGet packages from scratch.\r\n\r\nThe third commit adds a failing test asserting that the test project's desired version of Mono.Cecil has been loaded, which is the problem discussed in nunit/nunit-console#389, #366, and #488.\r\n\r\nThe fourth commit fixes the problem by embedding Mono.Cecil as an adapter assembly resource and resolving it on demand."},"comment":{"url":"https://api.github.com/repos/nunit/nunit3-vs-adapter/issues/comments/418573240","html_url":"https://github.com/nunit/nunit3-vs-adapter/pull/541#issuecomment-418573240","issue_url":"https://api.github.com/repos/nunit/nunit3-vs-adapter/issues/541","id":418573240,"node_id":"MDEyOklzc3VlQ29tbWVudDQxODU3MzI0MA==","user":{"login":"jnm2","id":8040367,"node_id":"MDQ6VXNlcjgwNDAzNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/8040367?v=4","gravatar_id":"","url":"https://api.github.com/users/jnm2","html_url":"https://github.com/jnm2","followers_url":"https://api.github.com/users/jnm2/followers","following_url":"https://api.github.com/users/jnm2/following{/other_user}","gists_url":"https://api.github.com/users/jnm2/gists{/gist_id}","starred_url":"https://api.github.com/users/jnm2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnm2/subscriptions","organizations_url":"https://api.github.com/users/jnm2/orgs","repos_url":"https://api.github.com/users/jnm2/repos","events_url":"https://api.github.com/users/jnm2/events{/privacy}","received_events_url":"https://api.github.com/users/jnm2/received_events","type":"User","site_admin":false},"created_at":"2018-09-05T01:51:47Z","updated_at":"2018-09-05T01:51:47Z","author_association":"CONTRIBUTOR","body":"So Mono.Cecil 0.10.0 has a breaking change that does effect the engine!\r\n\r\n> CS0030 Cannot convert type 'Mono.Cecil.InterfaceImplementation' to 'Mono.Cecil.TypeReference'\t\r\n\r\nOn this line:\r\n\r\nhttps://github.com/jnm2/nunit-console/blob/e3558779c790a731776e2ea07ab27f45dc97143dO/src/NUnitEngine/nunit.engine/Services/ExtensionService.cs#L271\r\n\r\nSo I have a little more work to do."}}
{"actor":{"display_login":"jnm2"}}