{"action":"created","comment":{"url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/pulls/comments/189323611","pull_request_review_id":121486978,"id":189323611,"diff_hunk":"@@ -49,8 +51,20 @@ class IqPolicyEvaluatorUtil\n           new IqClientFactoryConfiguration(credentialsId: iqPolicyEvaluator.jobCredentialsId, context: run.parent,\n               log: loggerBridge))\n \n-      def verified = iqClient.verifyOrCreateApplication(applicationId)\n-      checkArgument(verified, 'The application ID ' + applicationId + ' is invalid.')\n+      try {\n+        def verified = iqClient.verifyOrCreateApplication(applicationId)\n+        checkArgument(verified, 'The application ID ' + applicationId + ' is invalid.')\n+      }\n+      catch (IqClientException e) {\n+        if (isHttp404Error(e)) {\n+          listener.logger.println Messages._IqPolicyEvaluation_AutoAppMissing()\n+          run.result = Result.FAILURE\n+          return null","path":"src/main/java/org/sonatype/nexus/ci/iq/IqPolicyEvaluatorUtil.groovy","position":24,"original_position":24,"commit_id":"2580539eed1355021ee83cefb085ff57796c01cd","original_commit_id":"2580539eed1355021ee83cefb085ff57796c01cd","user":{"login":"ja98200wilcox","id":4838322,"avatar_url":"https://avatars3.githubusercontent.com/u/4838322?v=4","gravatar_id":"","url":"https://api.github.com/users/ja98200wilcox","html_url":"https://github.com/ja98200wilcox","followers_url":"https://api.github.com/users/ja98200wilcox/followers","following_url":"https://api.github.com/users/ja98200wilcox/following{/other_user}","gists_url":"https://api.github.com/users/ja98200wilcox/gists{/gist_id}","starred_url":"https://api.github.com/users/ja98200wilcox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ja98200wilcox/subscriptions","organizations_url":"https://api.github.com/users/ja98200wilcox/orgs","repos_url":"https://api.github.com/users/ja98200wilcox/repos","events_url":"https://api.github.com/users/ja98200wilcox/events{/privacy}","received_events_url":"https://api.github.com/users/ja98200wilcox/received_events","type":"User","site_admin":false},"body":"> What happens after you return null here? Isn't that still an exception that must be thrown?\r\n\r\nNo exception is thrown.  I inform Jenkins it failed by setting the ``run.result = Result.FAILURE```.   If I did throw an exception it will be displayed instead of my message.   If I let the exception be thrown it would change the output to be the stacktrace.","created_at":"2018-05-18T16:25:29Z","updated_at":"2018-05-18T16:25:29Z","html_url":"https://github.com/sonatype/nexus-platform-plugin/pull/18#discussion_r189323611","pull_request_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/pulls/18","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/sonatype/nexus-platform-plugin/pulls/comments/189323611"},"html":{"href":"https://github.com/sonatype/nexus-platform-plugin/pull/18#discussion_r189323611"},"pull_request":{"href":"https://api.github.com/repos/sonatype/nexus-platform-plugin/pulls/18"}},"in_reply_to_id":189316391},"pull_request":{"url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/pulls/18","id":188864259,"html_url":"https://github.com/sonatype/nexus-platform-plugin/pull/18","diff_url":"https://github.com/sonatype/nexus-platform-plugin/pull/18.diff","patch_url":"https://github.com/sonatype/nexus-platform-plugin/pull/18.patch","issue_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/issues/18","number":18,"state":"open","locked":false,"title":"New jenkins plugin fails with confusing message when used with older IQ Servers CLM-10117 CLM-10103 ","user":{"login":"ja98200wilcox","id":4838322,"avatar_url":"https://avatars3.githubusercontent.com/u/4838322?v=4","gravatar_id":"","url":"https://api.github.com/users/ja98200wilcox","html_url":"https://github.com/ja98200wilcox","followers_url":"https://api.github.com/users/ja98200wilcox/followers","following_url":"https://api.github.com/users/ja98200wilcox/following{/other_user}","gists_url":"https://api.github.com/users/ja98200wilcox/gists{/gist_id}","starred_url":"https://api.github.com/users/ja98200wilcox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ja98200wilcox/subscriptions","organizations_url":"https://api.github.com/users/ja98200wilcox/orgs","repos_url":"https://api.github.com/users/ja98200wilcox/repos","events_url":"https://api.github.com/users/ja98200wilcox/events{/privacy}","received_events_url":"https://api.github.com/users/ja98200wilcox/received_events","type":"User","site_admin":false},"body":"Provide an error message when the IQ server and Jenkins plugin are not compatible.\r\n\r\nhttps://jenkins.zion.aws.s/job/integrations/job/jenkins/job/sonatype-nexus-platform-plugin-feature/job/CLM-10103_Need_better_msg_for_unsupported_IQ/\r\n\r\nhttps://issues.sonatype.org/browse/CLM-10117","created_at":"2018-05-17T21:19:03Z","updated_at":"2018-05-18T16:25:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66128720a3b6725abc9e5e0e2627eb631d3c698e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/pulls/18/commits","review_comments_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/pulls/18/comments","review_comment_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/issues/18/comments","statuses_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/statuses/2580539eed1355021ee83cefb085ff57796c01cd","head":{"label":"sonatype:CLM-10103_Need_better_msg_for_unsupported_IQ","ref":"CLM-10103_Need_better_msg_for_unsupported_IQ","sha":"2580539eed1355021ee83cefb085ff57796c01cd","user":{"login":"sonatype","id":44938,"avatar_url":"https://avatars0.githubusercontent.com/u/44938?v=4","gravatar_id":"","url":"https://api.github.com/users/sonatype","html_url":"https://github.com/sonatype","followers_url":"https://api.github.com/users/sonatype/followers","following_url":"https://api.github.com/users/sonatype/following{/other_user}","gists_url":"https://api.github.com/users/sonatype/gists{/gist_id}","starred_url":"https://api.github.com/users/sonatype/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonatype/subscriptions","organizations_url":"https://api.github.com/users/sonatype/orgs","repos_url":"https://api.github.com/users/sonatype/repos","events_url":"https://api.github.com/users/sonatype/events{/privacy}","received_events_url":"https://api.github.com/users/sonatype/received_events","type":"Organization","site_admin":false},"repo":{"id":123488182,"name":"nexus-platform-plugin","full_name":"sonatype/nexus-platform-plugin","owner":{"login":"sonatype","id":44938,"avatar_url":"https://avatars0.githubusercontent.com/u/44938?v=4","gravatar_id":"","url":"https://api.github.com/users/sonatype","html_url":"https://github.com/sonatype","followers_url":"https://api.github.com/users/sonatype/followers","following_url":"https://api.github.com/users/sonatype/following{/other_user}","gists_url":"https://api.github.com/users/sonatype/gists{/gist_id}","starred_url":"https://api.github.com/users/sonatype/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonatype/subscriptions","organizations_url":"https://api.github.com/users/sonatype/orgs","repos_url":"https://api.github.com/users/sonatype/repos","events_url":"https://api.github.com/users/sonatype/events{/privacy}","received_events_url":"https://api.github.com/users/sonatype/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sonatype/nexus-platform-plugin","description":"Nexus Platform Plugin for Jenkins","fork":true,"url":"https://api.github.com/repos/sonatype/nexus-platform-plugin","forks_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/forks","keys_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/teams","hooks_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/hooks","issue_events_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/events","assignees_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/tags","blobs_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/languages","stargazers_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/stargazers","contributors_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/contributors","subscribers_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/subscribers","subscription_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/subscription","commits_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/merges","archive_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/downloads","issues_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/labels{/name}","releases_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/deployments","created_at":"2018-03-01T20:23:20Z","updated_at":"2018-04-30T23:30:18Z","pushed_at":"2018-05-18T15:29:31Z","git_url":"git://github.com/sonatype/nexus-platform-plugin.git","ssh_url":"git@github.com:sonatype/nexus-platform-plugin.git","clone_url":"https://github.com/sonatype/nexus-platform-plugin.git","svn_url":"https://github.com/sonatype/nexus-platform-plugin","homepage":null,"size":445,"stargazers_count":1,"watchers_count":1,"language":"Groovy","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1,"open_issues":4,"watchers":1,"default_branch":"master"}},"base":{"label":"sonatype:master","ref":"master","sha":"39b293a3c0e390091a910feeb6ea63374b213ace","user":{"login":"sonatype","id":44938,"avatar_url":"https://avatars0.githubusercontent.com/u/44938?v=4","gravatar_id":"","url":"https://api.github.com/users/sonatype","html_url":"https://github.com/sonatype","followers_url":"https://api.github.com/users/sonatype/followers","following_url":"https://api.github.com/users/sonatype/following{/other_user}","gists_url":"https://api.github.com/users/sonatype/gists{/gist_id}","starred_url":"https://api.github.com/users/sonatype/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonatype/subscriptions","organizations_url":"https://api.github.com/users/sonatype/orgs","repos_url":"https://api.github.com/users/sonatype/repos","events_url":"https://api.github.com/users/sonatype/events{/privacy}","received_events_url":"https://api.github.com/users/sonatype/received_events","type":"Organization","site_admin":false},"repo":{"id":123488182,"name":"nexus-platform-plugin","full_name":"sonatype/nexus-platform-plugin","owner":{"login":"sonatype","id":44938,"avatar_url":"https://avatars0.githubusercontent.com/u/44938?v=4","gravatar_id":"","url":"https://api.github.com/users/sonatype","html_url":"https://github.com/sonatype","followers_url":"https://api.github.com/users/sonatype/followers","following_url":"https://api.github.com/users/sonatype/following{/other_user}","gists_url":"https://api.github.com/users/sonatype/gists{/gist_id}","starred_url":"https://api.github.com/users/sonatype/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonatype/subscriptions","organizations_url":"https://api.github.com/users/sonatype/orgs","repos_url":"https://api.github.com/users/sonatype/repos","events_url":"https://api.github.com/users/sonatype/events{/privacy}","received_events_url":"https://api.github.com/users/sonatype/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sonatype/nexus-platform-plugin","description":"Nexus Platform Plugin for Jenkins","fork":true,"url":"https://api.github.com/repos/sonatype/nexus-platform-plugin","forks_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/forks","keys_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/teams","hooks_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/hooks","issue_events_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/events","assignees_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/tags","blobs_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/languages","stargazers_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/stargazers","contributors_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/contributors","subscribers_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/subscribers","subscription_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/subscription","commits_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/merges","archive_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/downloads","issues_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/labels{/name}","releases_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/sonatype/nexus-platform-plugin/deployments","created_at":"2018-03-01T20:23:20Z","updated_at":"2018-04-30T23:30:18Z","pushed_at":"2018-05-18T15:29:31Z","git_url":"git://github.com/sonatype/nexus-platform-plugin.git","ssh_url":"git@github.com:sonatype/nexus-platform-plugin.git","clone_url":"https://github.com/sonatype/nexus-platform-plugin.git","svn_url":"https://github.com/sonatype/nexus-platform-plugin","homepage":null,"size":445,"stargazers_count":1,"watchers_count":1,"language":"Groovy","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1,"open_issues":4,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sonatype/nexus-platform-plugin/pulls/18"},"html":{"href":"https://github.com/sonatype/nexus-platform-plugin/pull/18"},"issue":{"href":"https://api.github.com/repos/sonatype/nexus-platform-plugin/issues/18"},"comments":{"href":"https://api.github.com/repos/sonatype/nexus-platform-plugin/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/sonatype/nexus-platform-plugin/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/sonatype/nexus-platform-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sonatype/nexus-platform-plugin/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/sonatype/nexus-platform-plugin/statuses/2580539eed1355021ee83cefb085ff57796c01cd"}},"author_association":"NONE"}}
{"actor":{"display_login":"ja98200wilcox"}}