{"action":"created","comment":{"url":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/comments/166139219","pull_request_review_id":94173181,"id":166139219,"diff_hunk":"@@ -118,6 +121,12 @@\n      */\n     private ServiceReference<?> recoveryAuthDataRef;\n \n+    /**\n+     * MQ Queue manager id function is enabled by default. This will automatically be disabled if\n+     * this function is not required by the resource adapter.\n+     */\n+    private boolean qmidenabled = true;","path":"dev/com.ibm.ws.jca.cm/src/com/ibm/ws/jca/cm/AbstractConnectionFactoryService.java","position":25,"original_position":25,"commit_id":"3d963520870efe90b68a699f60a95f279fabf35e","original_commit_id":"3d963520870efe90b68a699f60a95f279fabf35e","user":{"login":"njr-11","id":13710803,"avatar_url":"https://avatars3.githubusercontent.com/u/13710803?v=4","gravatar_id":"","url":"https://api.github.com/users/njr-11","html_url":"https://github.com/njr-11","followers_url":"https://api.github.com/users/njr-11/followers","following_url":"https://api.github.com/users/njr-11/following{/other_user}","gists_url":"https://api.github.com/users/njr-11/gists{/gist_id}","starred_url":"https://api.github.com/users/njr-11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njr-11/subscriptions","organizations_url":"https://api.github.com/users/njr-11/orgs","repos_url":"https://api.github.com/users/njr-11/repos","events_url":"https://api.github.com/users/njr-11/events{/privacy}","received_events_url":"https://api.github.com/users/njr-11/received_events","type":"User","site_admin":false},"body":"Remove this from AbstractConnectionFactoryService. It will break the load-from-application path for JDBC.\r\nAll of your logic should be in ConnectionFactoryService such that it is for JCA only.","created_at":"2018-02-05T22:56:13Z","updated_at":"2018-02-05T22:56:13Z","html_url":"https://github.com/OpenLiberty/open-liberty/pull/2027#discussion_r166139219","pull_request_url":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/2027","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/comments/166139219"},"html":{"href":"https://github.com/OpenLiberty/open-liberty/pull/2027#discussion_r166139219"},"pull_request":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/2027"}}},"pull_request":{"url":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/2027","id":167266557,"html_url":"https://github.com/OpenLiberty/open-liberty/pull/2027","diff_url":"https://github.com/OpenLiberty/open-liberty/pull/2027.diff","patch_url":"https://github.com/OpenLiberty/open-liberty/pull/2027.patch","issue_url":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/2027","number":2027,"state":"open","locked":false,"title":"get qmid from mc and use if for recovery","user":{"login":"jmstephensgit","id":29738418,"avatar_url":"https://avatars0.githubusercontent.com/u/29738418?v=4","gravatar_id":"","url":"https://api.github.com/users/jmstephensgit","html_url":"https://github.com/jmstephensgit","followers_url":"https://api.github.com/users/jmstephensgit/followers","following_url":"https://api.github.com/users/jmstephensgit/following{/other_user}","gists_url":"https://api.github.com/users/jmstephensgit/gists{/gist_id}","starred_url":"https://api.github.com/users/jmstephensgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmstephensgit/subscriptions","organizations_url":"https://api.github.com/users/jmstephensgit/orgs","repos_url":"https://api.github.com/users/jmstephensgit/repos","events_url":"https://api.github.com/users/jmstephensgit/events{/privacy}","received_events_url":"https://api.github.com/users/jmstephensgit/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-05T22:02:09Z","updated_at":"2018-02-05T22:56:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e73fe5400c919abc323de0440363a7fe5787b259","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/2027/commits","review_comments_url":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/2027/comments","review_comment_url":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/2027/comments","statuses_url":"https://api.github.com/repos/OpenLiberty/open-liberty/statuses/3d963520870efe90b68a699f60a95f279fabf35e","head":{"label":"jmstephensgit:8901-getQMIDfromMCandStore","ref":"8901-getQMIDfromMCandStore","sha":"3d963520870efe90b68a699f60a95f279fabf35e","user":{"login":"jmstephensgit","id":29738418,"avatar_url":"https://avatars0.githubusercontent.com/u/29738418?v=4","gravatar_id":"","url":"https://api.github.com/users/jmstephensgit","html_url":"https://github.com/jmstephensgit","followers_url":"https://api.github.com/users/jmstephensgit/followers","following_url":"https://api.github.com/users/jmstephensgit/following{/other_user}","gists_url":"https://api.github.com/users/jmstephensgit/gists{/gist_id}","starred_url":"https://api.github.com/users/jmstephensgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmstephensgit/subscriptions","organizations_url":"https://api.github.com/users/jmstephensgit/orgs","repos_url":"https://api.github.com/users/jmstephensgit/repos","events_url":"https://api.github.com/users/jmstephensgit/events{/privacy}","received_events_url":"https://api.github.com/users/jmstephensgit/received_events","type":"User","site_admin":false},"repo":{"id":104485924,"name":"open-liberty","full_name":"jmstephensgit/open-liberty","owner":{"login":"jmstephensgit","id":29738418,"avatar_url":"https://avatars0.githubusercontent.com/u/29738418?v=4","gravatar_id":"","url":"https://api.github.com/users/jmstephensgit","html_url":"https://github.com/jmstephensgit","followers_url":"https://api.github.com/users/jmstephensgit/followers","following_url":"https://api.github.com/users/jmstephensgit/following{/other_user}","gists_url":"https://api.github.com/users/jmstephensgit/gists{/gist_id}","starred_url":"https://api.github.com/users/jmstephensgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmstephensgit/subscriptions","organizations_url":"https://api.github.com/users/jmstephensgit/orgs","repos_url":"https://api.github.com/users/jmstephensgit/repos","events_url":"https://api.github.com/users/jmstephensgit/events{/privacy}","received_events_url":"https://api.github.com/users/jmstephensgit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmstephensgit/open-liberty","description":"Open Liberty is a highly composable, fast to start, dynamic application server runtime environment ","fork":true,"url":"https://api.github.com/repos/jmstephensgit/open-liberty","forks_url":"https://api.github.com/repos/jmstephensgit/open-liberty/forks","keys_url":"https://api.github.com/repos/jmstephensgit/open-liberty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmstephensgit/open-liberty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmstephensgit/open-liberty/teams","hooks_url":"https://api.github.com/repos/jmstephensgit/open-liberty/hooks","issue_events_url":"https://api.github.com/repos/jmstephensgit/open-liberty/issues/events{/number}","events_url":"https://api.github.com/repos/jmstephensgit/open-liberty/events","assignees_url":"https://api.github.com/repos/jmstephensgit/open-liberty/assignees{/user}","branches_url":"https://api.github.com/repos/jmstephensgit/open-liberty/branches{/branch}","tags_url":"https://api.github.com/repos/jmstephensgit/open-liberty/tags","blobs_url":"https://api.github.com/repos/jmstephensgit/open-liberty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmstephensgit/open-liberty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmstephensgit/open-liberty/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmstephensgit/open-liberty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmstephensgit/open-liberty/statuses/{sha}","languages_url":"https://api.github.com/repos/jmstephensgit/open-liberty/languages","stargazers_url":"https://api.github.com/repos/jmstephensgit/open-liberty/stargazers","contributors_url":"https://api.github.com/repos/jmstephensgit/open-liberty/contributors","subscribers_url":"https://api.github.com/repos/jmstephensgit/open-liberty/subscribers","subscription_url":"https://api.github.com/repos/jmstephensgit/open-liberty/subscription","commits_url":"https://api.github.com/repos/jmstephensgit/open-liberty/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmstephensgit/open-liberty/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmstephensgit/open-liberty/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmstephensgit/open-liberty/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmstephensgit/open-liberty/contents/{+path}","compare_url":"https://api.github.com/repos/jmstephensgit/open-liberty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmstephensgit/open-liberty/merges","archive_url":"https://api.github.com/repos/jmstephensgit/open-liberty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmstephensgit/open-liberty/downloads","issues_url":"https://api.github.com/repos/jmstephensgit/open-liberty/issues{/number}","pulls_url":"https://api.github.com/repos/jmstephensgit/open-liberty/pulls{/number}","milestones_url":"https://api.github.com/repos/jmstephensgit/open-liberty/milestones{/number}","notifications_url":"https://api.github.com/repos/jmstephensgit/open-liberty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmstephensgit/open-liberty/labels{/name}","releases_url":"https://api.github.com/repos/jmstephensgit/open-liberty/releases{/id}","deployments_url":"https://api.github.com/repos/jmstephensgit/open-liberty/deployments","created_at":"2017-09-22T14:49:16Z","updated_at":"2017-09-22T14:50:20Z","pushed_at":"2018-02-05T22:25:54Z","git_url":"git://github.com/jmstephensgit/open-liberty.git","ssh_url":"git@github.com:jmstephensgit/open-liberty.git","clone_url":"https://github.com/jmstephensgit/open-liberty.git","svn_url":"https://github.com/jmstephensgit/open-liberty","homepage":"http://openliberty.io","size":107979,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"integration"}},"base":{"label":"OpenLiberty:integration","ref":"integration","sha":"02adb1748dfb52780f883b1effbea50263bdf4df","user":{"login":"OpenLiberty","id":28316667,"avatar_url":"https://avatars2.githubusercontent.com/u/28316667?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenLiberty","html_url":"https://github.com/OpenLiberty","followers_url":"https://api.github.com/users/OpenLiberty/followers","following_url":"https://api.github.com/users/OpenLiberty/following{/other_user}","gists_url":"https://api.github.com/users/OpenLiberty/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenLiberty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenLiberty/subscriptions","organizations_url":"https://api.github.com/users/OpenLiberty/orgs","repos_url":"https://api.github.com/users/OpenLiberty/repos","events_url":"https://api.github.com/users/OpenLiberty/events{/privacy}","received_events_url":"https://api.github.com/users/OpenLiberty/received_events","type":"Organization","site_admin":false},"repo":{"id":103694377,"name":"open-liberty","full_name":"OpenLiberty/open-liberty","owner":{"login":"OpenLiberty","id":28316667,"avatar_url":"https://avatars2.githubusercontent.com/u/28316667?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenLiberty","html_url":"https://github.com/OpenLiberty","followers_url":"https://api.github.com/users/OpenLiberty/followers","following_url":"https://api.github.com/users/OpenLiberty/following{/other_user}","gists_url":"https://api.github.com/users/OpenLiberty/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenLiberty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenLiberty/subscriptions","organizations_url":"https://api.github.com/users/OpenLiberty/orgs","repos_url":"https://api.github.com/users/OpenLiberty/repos","events_url":"https://api.github.com/users/OpenLiberty/events{/privacy}","received_events_url":"https://api.github.com/users/OpenLiberty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenLiberty/open-liberty","description":"Open Liberty is a highly composable, fast to start, dynamic application server runtime environment ","fork":false,"url":"https://api.github.com/repos/OpenLiberty/open-liberty","forks_url":"https://api.github.com/repos/OpenLiberty/open-liberty/forks","keys_url":"https://api.github.com/repos/OpenLiberty/open-liberty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenLiberty/open-liberty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenLiberty/open-liberty/teams","hooks_url":"https://api.github.com/repos/OpenLiberty/open-liberty/hooks","issue_events_url":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/events{/number}","events_url":"https://api.github.com/repos/OpenLiberty/open-liberty/events","assignees_url":"https://api.github.com/repos/OpenLiberty/open-liberty/assignees{/user}","branches_url":"https://api.github.com/repos/OpenLiberty/open-liberty/branches{/branch}","tags_url":"https://api.github.com/repos/OpenLiberty/open-liberty/tags","blobs_url":"https://api.github.com/repos/OpenLiberty/open-liberty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenLiberty/open-liberty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenLiberty/open-liberty/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenLiberty/open-liberty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenLiberty/open-liberty/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenLiberty/open-liberty/languages","stargazers_url":"https://api.github.com/repos/OpenLiberty/open-liberty/stargazers","contributors_url":"https://api.github.com/repos/OpenLiberty/open-liberty/contributors","subscribers_url":"https://api.github.com/repos/OpenLiberty/open-liberty/subscribers","subscription_url":"https://api.github.com/repos/OpenLiberty/open-liberty/subscription","commits_url":"https://api.github.com/repos/OpenLiberty/open-liberty/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenLiberty/open-liberty/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenLiberty/open-liberty/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenLiberty/open-liberty/contents/{+path}","compare_url":"https://api.github.com/repos/OpenLiberty/open-liberty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenLiberty/open-liberty/merges","archive_url":"https://api.github.com/repos/OpenLiberty/open-liberty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenLiberty/open-liberty/downloads","issues_url":"https://api.github.com/repos/OpenLiberty/open-liberty/issues{/number}","pulls_url":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenLiberty/open-liberty/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenLiberty/open-liberty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenLiberty/open-liberty/labels{/name}","releases_url":"https://api.github.com/repos/OpenLiberty/open-liberty/releases{/id}","deployments_url":"https://api.github.com/repos/OpenLiberty/open-liberty/deployments","created_at":"2017-09-15T19:34:25Z","updated_at":"2018-02-05T08:19:12Z","pushed_at":"2018-02-05T22:25:55Z","git_url":"git://github.com/OpenLiberty/open-liberty.git","ssh_url":"git@github.com:OpenLiberty/open-liberty.git","clone_url":"https://github.com/OpenLiberty/open-liberty.git","svn_url":"https://github.com/OpenLiberty/open-liberty","homepage":"http://openliberty.io","size":109040,"stargazers_count":259,"watchers_count":259,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":212,"mirror_url":null,"archived":false,"open_issues_count":426,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0"},"forks":212,"open_issues":426,"watchers":259,"default_branch":"integration"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/2027"},"html":{"href":"https://github.com/OpenLiberty/open-liberty/pull/2027"},"issue":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/2027"},"comments":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/2027/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/2027/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/2027/commits"},"statuses":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/statuses/3d963520870efe90b68a699f60a95f279fabf35e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"njr-11"}}