{"action":"closed","number":3383,"pull_request":{"url":"https://api.github.com/repos/ray-project/ray/pulls/3383","id":232880208,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyODgwMjA4","html_url":"https://github.com/ray-project/ray/pull/3383","diff_url":"https://github.com/ray-project/ray/pull/3383.diff","patch_url":"https://github.com/ray-project/ray/pull/3383.patch","issue_url":"https://api.github.com/repos/ray-project/ray/issues/3383","number":3383,"state":"closed","locked":false,"title":"When getting a role/profile, catch only exception that indicates the …","user":{"login":"GiliR4t1qbit","id":5490972,"node_id":"MDQ6VXNlcjU0OTA5NzI=","avatar_url":"https://avatars3.githubusercontent.com/u/5490972?v=4","gravatar_id":"","url":"https://api.github.com/users/GiliR4t1qbit","html_url":"https://github.com/GiliR4t1qbit","followers_url":"https://api.github.com/users/GiliR4t1qbit/followers","following_url":"https://api.github.com/users/GiliR4t1qbit/following{/other_user}","gists_url":"https://api.github.com/users/GiliR4t1qbit/gists{/gist_id}","starred_url":"https://api.github.com/users/GiliR4t1qbit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GiliR4t1qbit/subscriptions","organizations_url":"https://api.github.com/users/GiliR4t1qbit/orgs","repos_url":"https://api.github.com/users/GiliR4t1qbit/repos","events_url":"https://api.github.com/users/GiliR4t1qbit/events{/privacy}","received_events_url":"https://api.github.com/users/GiliR4t1qbit/received_events","type":"User","site_admin":false},"body":"## What do these changes do?\r\n\r\nWhen using AWS autoscaler, we need to check if the role/profile already exists, in order to know whether to create a new one or not. Previously, the indicator for this was catching ANY exception on attempting to get the role/profile. This resulted in catching other exceptions too, and interpreting them as \"role/profile exists\". The fix is to catch only the appropriate exception, and allow the others to be raised. \r\n\r\n## Related issue number\r\n\r\nCloses [issue #3380](https://github.com/ray-project/ray/issues/3380)","created_at":"2018-11-22T07:18:58Z","updated_at":"2018-11-22T17:42:59Z","closed_at":"2018-11-22T17:42:59Z","merged_at":"2018-11-22T17:42:59Z","merge_commit_sha":"b9ae5edf744265b6917a9946806e29db297854c1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ray-project/ray/pulls/3383/commits","review_comments_url":"https://api.github.com/repos/ray-project/ray/pulls/3383/comments","review_comment_url":"https://api.github.com/repos/ray-project/ray/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ray-project/ray/issues/3383/comments","statuses_url":"https://api.github.com/repos/ray-project/ray/statuses/889523654c3a4eea5d2d7dd6a7419f11353b71a1","head":{"label":"GiliR4t1qbit:boto_exceptions","ref":"boto_exceptions","sha":"889523654c3a4eea5d2d7dd6a7419f11353b71a1","user":{"login":"GiliR4t1qbit","id":5490972,"node_id":"MDQ6VXNlcjU0OTA5NzI=","avatar_url":"https://avatars3.githubusercontent.com/u/5490972?v=4","gravatar_id":"","url":"https://api.github.com/users/GiliR4t1qbit","html_url":"https://github.com/GiliR4t1qbit","followers_url":"https://api.github.com/users/GiliR4t1qbit/followers","following_url":"https://api.github.com/users/GiliR4t1qbit/following{/other_user}","gists_url":"https://api.github.com/users/GiliR4t1qbit/gists{/gist_id}","starred_url":"https://api.github.com/users/GiliR4t1qbit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GiliR4t1qbit/subscriptions","organizations_url":"https://api.github.com/users/GiliR4t1qbit/orgs","repos_url":"https://api.github.com/users/GiliR4t1qbit/repos","events_url":"https://api.github.com/users/GiliR4t1qbit/events{/privacy}","received_events_url":"https://api.github.com/users/GiliR4t1qbit/received_events","type":"User","site_admin":false},"repo":{"id":158656604,"node_id":"MDEwOlJlcG9zaXRvcnkxNTg2NTY2MDQ=","name":"ray","full_name":"GiliR4t1qbit/ray","private":false,"owner":{"login":"GiliR4t1qbit","id":5490972,"node_id":"MDQ6VXNlcjU0OTA5NzI=","avatar_url":"https://avatars3.githubusercontent.com/u/5490972?v=4","gravatar_id":"","url":"https://api.github.com/users/GiliR4t1qbit","html_url":"https://github.com/GiliR4t1qbit","followers_url":"https://api.github.com/users/GiliR4t1qbit/followers","following_url":"https://api.github.com/users/GiliR4t1qbit/following{/other_user}","gists_url":"https://api.github.com/users/GiliR4t1qbit/gists{/gist_id}","starred_url":"https://api.github.com/users/GiliR4t1qbit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GiliR4t1qbit/subscriptions","organizations_url":"https://api.github.com/users/GiliR4t1qbit/orgs","repos_url":"https://api.github.com/users/GiliR4t1qbit/repos","events_url":"https://api.github.com/users/GiliR4t1qbit/events{/privacy}","received_events_url":"https://api.github.com/users/GiliR4t1qbit/received_events","type":"User","site_admin":false},"html_url":"https://github.com/GiliR4t1qbit/ray","description":"A system for parallel and distributed Python that unifies the ML ecosystem.","fork":true,"url":"https://api.github.com/repos/GiliR4t1qbit/ray","forks_url":"https://api.github.com/repos/GiliR4t1qbit/ray/forks","keys_url":"https://api.github.com/repos/GiliR4t1qbit/ray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GiliR4t1qbit/ray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GiliR4t1qbit/ray/teams","hooks_url":"https://api.github.com/repos/GiliR4t1qbit/ray/hooks","issue_events_url":"https://api.github.com/repos/GiliR4t1qbit/ray/issues/events{/number}","events_url":"https://api.github.com/repos/GiliR4t1qbit/ray/events","assignees_url":"https://api.github.com/repos/GiliR4t1qbit/ray/assignees{/user}","branches_url":"https://api.github.com/repos/GiliR4t1qbit/ray/branches{/branch}","tags_url":"https://api.github.com/repos/GiliR4t1qbit/ray/tags","blobs_url":"https://api.github.com/repos/GiliR4t1qbit/ray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GiliR4t1qbit/ray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GiliR4t1qbit/ray/git/refs{/sha}","trees_url":"https://api.github.com/repos/GiliR4t1qbit/ray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GiliR4t1qbit/ray/statuses/{sha}","languages_url":"https://api.github.com/repos/GiliR4t1qbit/ray/languages","stargazers_url":"https://api.github.com/repos/GiliR4t1qbit/ray/stargazers","contributors_url":"https://api.github.com/repos/GiliR4t1qbit/ray/contributors","subscribers_url":"https://api.github.com/repos/GiliR4t1qbit/ray/subscribers","subscription_url":"https://api.github.com/repos/GiliR4t1qbit/ray/subscription","commits_url":"https://api.github.com/repos/GiliR4t1qbit/ray/commits{/sha}","git_commits_url":"https://api.github.com/repos/GiliR4t1qbit/ray/git/commits{/sha}","comments_url":"https://api.github.com/repos/GiliR4t1qbit/ray/comments{/number}","issue_comment_url":"https://api.github.com/repos/GiliR4t1qbit/ray/issues/comments{/number}","contents_url":"https://api.github.com/repos/GiliR4t1qbit/ray/contents/{+path}","compare_url":"https://api.github.com/repos/GiliR4t1qbit/ray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GiliR4t1qbit/ray/merges","archive_url":"https://api.github.com/repos/GiliR4t1qbit/ray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GiliR4t1qbit/ray/downloads","issues_url":"https://api.github.com/repos/GiliR4t1qbit/ray/issues{/number}","pulls_url":"https://api.github.com/repos/GiliR4t1qbit/ray/pulls{/number}","milestones_url":"https://api.github.com/repos/GiliR4t1qbit/ray/milestones{/number}","notifications_url":"https://api.github.com/repos/GiliR4t1qbit/ray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GiliR4t1qbit/ray/labels{/name}","releases_url":"https://api.github.com/repos/GiliR4t1qbit/ray/releases{/id}","deployments_url":"https://api.github.com/repos/GiliR4t1qbit/ray/deployments","created_at":"2018-11-22T07:07:19Z","updated_at":"2018-11-22T07:07:23Z","pushed_at":"2018-11-22T07:14:48Z","git_url":"git://github.com/GiliR4t1qbit/ray.git","ssh_url":"git@github.com:GiliR4t1qbit/ray.git","clone_url":"https://github.com/GiliR4t1qbit/ray.git","svn_url":"https://github.com/GiliR4t1qbit/ray","homepage":"https://ray.readthedocs.io/en/latest/","size":16686,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ray-project:master","ref":"master","sha":"24bfe8ab76f743983aa494528c4ec8fe1e9d1a3e","user":{"login":"ray-project","id":22125274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTI1Mjc0","avatar_url":"https://avatars3.githubusercontent.com/u/22125274?v=4","gravatar_id":"","url":"https://api.github.com/users/ray-project","html_url":"https://github.com/ray-project","followers_url":"https://api.github.com/users/ray-project/followers","following_url":"https://api.github.com/users/ray-project/following{/other_user}","gists_url":"https://api.github.com/users/ray-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ray-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ray-project/subscriptions","organizations_url":"https://api.github.com/users/ray-project/orgs","repos_url":"https://api.github.com/users/ray-project/repos","events_url":"https://api.github.com/users/ray-project/events{/privacy}","received_events_url":"https://api.github.com/users/ray-project/received_events","type":"Organization","site_admin":false},"repo":{"id":71932349,"node_id":"MDEwOlJlcG9zaXRvcnk3MTkzMjM0OQ==","name":"ray","full_name":"ray-project/ray","private":false,"owner":{"login":"ray-project","id":22125274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTI1Mjc0","avatar_url":"https://avatars3.githubusercontent.com/u/22125274?v=4","gravatar_id":"","url":"https://api.github.com/users/ray-project","html_url":"https://github.com/ray-project","followers_url":"https://api.github.com/users/ray-project/followers","following_url":"https://api.github.com/users/ray-project/following{/other_user}","gists_url":"https://api.github.com/users/ray-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ray-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ray-project/subscriptions","organizations_url":"https://api.github.com/users/ray-project/orgs","repos_url":"https://api.github.com/users/ray-project/repos","events_url":"https://api.github.com/users/ray-project/events{/privacy}","received_events_url":"https://api.github.com/users/ray-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ray-project/ray","description":"A system for parallel and distributed Python that unifies the ML ecosystem.","fork":false,"url":"https://api.github.com/repos/ray-project/ray","forks_url":"https://api.github.com/repos/ray-project/ray/forks","keys_url":"https://api.github.com/repos/ray-project/ray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ray-project/ray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ray-project/ray/teams","hooks_url":"https://api.github.com/repos/ray-project/ray/hooks","issue_events_url":"https://api.github.com/repos/ray-project/ray/issues/events{/number}","events_url":"https://api.github.com/repos/ray-project/ray/events","assignees_url":"https://api.github.com/repos/ray-project/ray/assignees{/user}","branches_url":"https://api.github.com/repos/ray-project/ray/branches{/branch}","tags_url":"https://api.github.com/repos/ray-project/ray/tags","blobs_url":"https://api.github.com/repos/ray-project/ray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ray-project/ray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ray-project/ray/git/refs{/sha}","trees_url":"https://api.github.com/repos/ray-project/ray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ray-project/ray/statuses/{sha}","languages_url":"https://api.github.com/repos/ray-project/ray/languages","stargazers_url":"https://api.github.com/repos/ray-project/ray/stargazers","contributors_url":"https://api.github.com/repos/ray-project/ray/contributors","subscribers_url":"https://api.github.com/repos/ray-project/ray/subscribers","subscription_url":"https://api.github.com/repos/ray-project/ray/subscription","commits_url":"https://api.github.com/repos/ray-project/ray/commits{/sha}","git_commits_url":"https://api.github.com/repos/ray-project/ray/git/commits{/sha}","comments_url":"https://api.github.com/repos/ray-project/ray/comments{/number}","issue_comment_url":"https://api.github.com/repos/ray-project/ray/issues/comments{/number}","contents_url":"https://api.github.com/repos/ray-project/ray/contents/{+path}","compare_url":"https://api.github.com/repos/ray-project/ray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ray-project/ray/merges","archive_url":"https://api.github.com/repos/ray-project/ray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ray-project/ray/downloads","issues_url":"https://api.github.com/repos/ray-project/ray/issues{/number}","pulls_url":"https://api.github.com/repos/ray-project/ray/pulls{/number}","milestones_url":"https://api.github.com/repos/ray-project/ray/milestones{/number}","notifications_url":"https://api.github.com/repos/ray-project/ray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ray-project/ray/labels{/name}","releases_url":"https://api.github.com/repos/ray-project/ray/releases{/id}","deployments_url":"https://api.github.com/repos/ray-project/ray/deployments","created_at":"2016-10-25T19:38:30Z","updated_at":"2018-11-22T13:10:57Z","pushed_at":"2018-11-22T17:42:59Z","git_url":"git://github.com/ray-project/ray.git","ssh_url":"git@github.com:ray-project/ray.git","clone_url":"https://github.com/ray-project/ray.git","svn_url":"https://github.com/ray-project/ray","homepage":"https://ray.readthedocs.io/en/latest/","size":16675,"stargazers_count":4800,"watchers_count":4800,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":652,"mirror_url":null,"archived":false,"open_issues_count":479,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":652,"open_issues":479,"watchers":4800,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ray-project/ray/pulls/3383"},"html":{"href":"https://github.com/ray-project/ray/pull/3383"},"issue":{"href":"https://api.github.com/repos/ray-project/ray/issues/3383"},"comments":{"href":"https://api.github.com/repos/ray-project/ray/issues/3383/comments"},"review_comments":{"href":"https://api.github.com/repos/ray-project/ray/pulls/3383/comments"},"review_comment":{"href":"https://api.github.com/repos/ray-project/ray/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ray-project/ray/pulls/3383/commits"},"statuses":{"href":"https://api.github.com/repos/ray-project/ray/statuses/889523654c3a4eea5d2d7dd6a7419f11353b71a1"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ericl","id":14922,"node_id":"MDQ6VXNlcjE0OTIy","avatar_url":"https://avatars3.githubusercontent.com/u/14922?v=4","gravatar_id":"","url":"https://api.github.com/users/ericl","html_url":"https://github.com/ericl","followers_url":"https://api.github.com/users/ericl/followers","following_url":"https://api.github.com/users/ericl/following{/other_user}","gists_url":"https://api.github.com/users/ericl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericl/subscriptions","organizations_url":"https://api.github.com/users/ericl/orgs","repos_url":"https://api.github.com/users/ericl/repos","events_url":"https://api.github.com/users/ericl/events{/privacy}","received_events_url":"https://api.github.com/users/ericl/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"ericl"}}