{"push_id":2694199115,"size":12,"distinct_size":12,"ref":"refs/heads/develop","head":"186987b880c5cb3d0c4996d3b94ce3e59f6500d0","before":"612b728143c7ffed44469398701b74ebf7d07630","commits":[{"sha":"098127307ae33b07af47240b44c5ae644c715c43","author":{"name":"Simon Richardson","email":"38cb9bc0fbf97d369412d62cd93ffb127a9d6265@gmail.com"},"message":"Use container/lxd\n\nThe following commit removes the tools/lxdclient from the provider.\nThe tools/lxdclient is around until we move all the storage checking\nrequired, before we cull the package.\n\nWe also simplify the creation of the server, where by we pass a\nfactory around so that mocks can utilise it. Along with cleaning up\nwhat's local and what is remote communication.","distinct":true,"url":"https://api.github.com/repos/vinu2003/juju/commits/098127307ae33b07af47240b44c5ae644c715c43"},{"sha":"22148aa1521d54960f2f630e40253fbdc25e6fe7","author":{"name":"Simon Richardson","email":"38cb9bc0fbf97d369412d62cd93ffb127a9d6265@gmail.com"},"message":"Local Server Factory changes\n\nThe following commit ensures that the server creates a new local\nserver, that has all the connections setup correctly, before handing\nit back. The reason for this is so that we don't have to place\nretries everywhere outside of the server initialisation code path.\n\nThis should ensure any consumer of the factory can then ensure that\nwhen they get a local server, they are in fact getting the right\none.","distinct":true,"url":"https://api.github.com/repos/vinu2003/juju/commits/22148aa1521d54960f2f630e40253fbdc25e6fe7"},{"sha":"07e00a023ffec4dc781d1f5f0f3264d7382276ef","author":{"name":"Simon Richardson","email":"38cb9bc0fbf97d369412d62cd93ffb127a9d6265@gmail.com"},"message":"Cleaning up the tests\n\nThis ensures the server is created once, which cleans up the tests\nsomewhat.","distinct":true,"url":"https://api.github.com/repos/vinu2003/juju/commits/07e00a023ffec4dc781d1f5f0f3264d7382276ef"},{"sha":"a96930fa2ee082ec348fbe79cf3f4316d4373134","author":{"name":"Simon Richardson","email":"38cb9bc0fbf97d369412d62cd93ffb127a9d6265@gmail.com"},"message":"Local server factory testing\n\nThe following tests that the new local server factory correctly\ntests that the new local server is correctly setup.\n\nIt checks that we also create a new local server in the correct\nway.","distinct":true,"url":"https://api.github.com/repos/vinu2003/juju/commits/a96930fa2ee082ec348fbe79cf3f4316d4373134"},{"sha":"f06c35cc4a1ffd430c42232073b225aa8e646c32","author":{"name":"Simon Richardson","email":"38cb9bc0fbf97d369412d62cd93ffb127a9d6265@gmail.com"},"message":"Test remote server factory\n\nThe following changes test the remote server functionality, so that\nwe can understand what side-effects the creation of a remote server\nhas upon creation.\n\n - Ensure remote server","distinct":true,"url":"https://api.github.com/repos/vinu2003/juju/commits/f06c35cc4a1ffd430c42232073b225aa8e646c32"},{"sha":"1d0f500039d98cb66703358cf8c25dba1453a082","author":{"name":"Joseph Phillips","email":"e5bd52f2ca7ebabfe4c1d21f6bc97a445dff815c@canonical.com"},"message":"Ensures network-get returns an IP address for ingress networks.","distinct":true,"url":"https://api.github.com/repos/vinu2003/juju/commits/1d0f500039d98cb66703358cf8c25dba1453a082"},{"sha":"4b1a047bf90814d244002d62c627a898c0582aee","author":{"name":"Simon Richardson","email":"38cb9bc0fbf97d369412d62cd93ffb127a9d6265@gmail.com"},"message":"Rename LocalServerHostName to LocalServerAddress\n\nThis just makes it clearer as a user of the provider server factory\nwhat is expected from just the naming.","distinct":true,"url":"https://api.github.com/repos/vinu2003/juju/commits/4b1a047bf90814d244002d62c627a898c0582aee"},{"sha":"05f612a53eb9e3c0217d1be7613ce3e0074b16bb","author":{"name":"Simon Richardson","email":"38cb9bc0fbf97d369412d62cd93ffb127a9d6265@gmail.com"},"message":"Clean up the ServerFactory\n\nThe following cleans the server factory up, in doing so, make it a\nlot easier to understand how to create the server factory correctly.\n\nWe still create eschew the lxd container functions so that it's\neasier to mock, but at least these are now encapsulated a way from\nthe consumer of the factory.","distinct":true,"url":"https://api.github.com/repos/vinu2003/juju/commits/05f612a53eb9e3c0217d1be7613ce3e0074b16bb"},{"sha":"00b2f00d866db0ed6989d83a9d0b5284213908a8","author":{"name":"Simon Richardson","email":"38cb9bc0fbf97d369412d62cd93ffb127a9d6265@gmail.com"},"message":"Negative test connection errors\n\nThe following tests error messages that comes from the server factory,\nwhere by the server gives useful advice.","distinct":true,"url":"https://api.github.com/repos/vinu2003/juju/commits/00b2f00d866db0ed6989d83a9d0b5284213908a8"},{"sha":"55cf0ecb6fa42fb87e7c47625791fa92b2ae4afd","author":{"name":"Simon Richardson","email":"38cb9bc0fbf97d369412d62cd93ffb127a9d6265@gmail.com"},"message":"ServerSpec proxy\n\nEnable passing the proxy through to the server spec","distinct":true,"url":"https://api.github.com/repos/vinu2003/juju/commits/55cf0ecb6fa42fb87e7c47625791fa92b2ae4afd"},{"sha":"f447ddcdc0417863feb78e764b2cefd0805b130d","author":{"name":"Juju bot","email":"28c2b79e213f53c52a14677e00898d5b855059a0@users.noreply.github.com"},"message":"Merge pull request #8885 from manadart/network-get-ingress-address\n\nhttps://github.com/juju/juju/pull/8885\n\n## Description of change\r\n\r\nA prior patch, https://github.com/juju/juju/pull/8672, ensured that the primary address value from the _network-get_ action returned an IP address when stored as a host-name.\r\n\r\nThis further extends the same change to ensure that ingress addresses are reported as IP addresses in the same fashion.\r\n\r\n## QA steps\r\n\r\n1. Bootstrap to localhost. \r\n2. Manually launch a LXD container.\r\n3. Ensure that you can SSH into the machine (copy a host SSH public key into authorized_keys for a user in the container).\r\n4. Assign the machine a resolvable hostname (e.g. add an entry to /etc/hosts on the host)\r\n5. manually provision machine using `ssh:<user>@<hostname>` placement directive format \r\n6. deploy mysql to manually provisioned machine\r\n7. `juju run mysql/0 -- network-get --ingress-address --format yaml db` \r\n\r\n## Documentation changes\r\n\r\nNone.\r\n\r\n## Bug reference\r\n\r\nhttps://bugs.launchpad.net/juju/+bug/1721368","distinct":true,"url":"https://api.github.com/repos/vinu2003/juju/commits/f447ddcdc0417863feb78e764b2cefd0805b130d"},{"sha":"186987b880c5cb3d0c4996d3b94ce3e59f6500d0","author":{"name":"Juju bot","email":"28c2b79e213f53c52a14677e00898d5b855059a0@users.noreply.github.com"},"message":"Merge pull request #8882 from SimonRichardson/lxd-error-msg\n\nhttps://github.com/juju/juju/pull/8882\n\n## Description of change\r\n\r\nThis PR includes the previously local server error message, where \r\nby, if you couldn't connect to the lxd server via the unix socket, then\r\nit would provide better guidance around how to solve that.\r\n\r\n```sh\r\nPlease install LXD by running:\r\n $ sudo snap install lxd\r\nand then configure it with:\r\n $ newgrp lxd\r\n $ lxd init\r\n```\r\n\r\nThe following commit also removes the tools/lxdclient from the provider.\r\nThe tools/lxdclient is around until we move all the storage checking\r\nrequired, before we cull the package.\r\n\r\nWe also simplify the creation of the server, where by we pass a\r\nfactory around so that mocks can utilise it. Along with cleaning up\r\nwhat's local and what is remote communication.\r\n\r\n## QA steps\r\n\r\nThis is a massive change, as we no longer depend on the `tools/lxdclient`.\r\nThis instead uses the new `container/lxd` and connects via the localhost\r\nto that.\r\n\r\n**All avenues of testing should be done here!**\r\n\r\n## Documentation changes\r\n\r\nThis should be backwards compatible with the existing commands and\r\nthe user shouldn't notice any difference.\r\n\r\n[![demo](https://asciinema.org/a/189701.png)](https://asciinema.org/a/189701?autoplay=1&speed=3)\r\n\r\nhttps://trello.com/c/uKWwlPMh/314-remove-old-lxd-client-and-use-new-lxd-server-directly-in-lxd-provider","distinct":true,"url":"https://api.github.com/repos/vinu2003/juju/commits/186987b880c5cb3d0c4996d3b94ce3e59f6500d0"}]}
{"actor":{"display_login":"vinu2003"}}