{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/37147","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/37147/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/37147/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/37147/events","html_url":"https://github.com/NixOS/nixpkgs/pull/37147","id":305727934,"number":37147,"title":"thumbor: fix build","user":{"login":"Ma27","id":6025220,"avatar_url":"https://avatars0.githubusercontent.com/u/6025220?v=4","gravatar_id":"","url":"https://api.github.com/users/Ma27","html_url":"https://github.com/Ma27","followers_url":"https://api.github.com/users/Ma27/followers","following_url":"https://api.github.com/users/Ma27/following{/other_user}","gists_url":"https://api.github.com/users/Ma27/gists{/gist_id}","starred_url":"https://api.github.com/users/Ma27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ma27/subscriptions","organizations_url":"https://api.github.com/users/Ma27/orgs","repos_url":"https://api.github.com/users/Ma27/repos","events_url":"https://api.github.com/users/Ma27/events{/privacy}","received_events_url":"https://api.github.com/users/Ma27/received_events","type":"User","site_admin":false},"labels":[{"id":731735222,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%201-10","name":"10.rebuild-darwin: 1-10","color":"eeffee","default":false},{"id":731733923,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%201-10","name":"10.rebuild-linux: 1-10","color":"eeffee","default":false},{"id":9820195,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20python","name":"6.topic: python","color":"fef2c0","default":false},{"id":290122734,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20package%20(new)","name":"8.has: package (new)","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-03-15T21:36:03Z","updated_at":"2018-03-18T09:13:33Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/37147","html_url":"https://github.com/NixOS/nixpkgs/pull/37147","diff_url":"https://github.com/NixOS/nixpkgs/pull/37147.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/37147.patch"},"body":"###### Motivation for this change\r\n\r\nOrigianlly the package was broken as bumping `pythonPackages.pillow` to\r\n5.x broke `thumbor`. The latest upstream version `6.4.2` solved this\r\nissue, so a simple package bump was sufficient.\r\n\r\nFurthermore the following changes were made:\r\n\r\n- moved the expression into its own file\r\n- added myself as maintainer in case of any further breackage\r\n- re-enabled python3 build: 6.4.2 is fine with python3, however the\r\n  `futures` dependency can't be satisfied anymore as it's part of\r\n  Python3. Therefore a patch for `setup.py` will be applied for Python3\r\n  buildsto drop the dependency\r\n\r\nNote: the testsuite is disabled for now as several impure tests are done\r\nand our testing environment seems to be unable to work the with the\r\nnatively compiled python modules properly.\r\n\r\nTherefore I tested the module using the following expression:\r\n\r\n``` nix\r\nwith import ./. {};\r\n\r\nstdenv.mkDerivation {\r\n  name = \"thumbor-test\";\r\n  src = null;\r\n  buildInputs = [ python pythonPackages.thumbor ];\r\n}\r\n```\r\n\r\nInside this nix shell `thumbor` works fine and the native modules can be\r\nimported.\r\n\r\nSee https://hydra.nixos.org/build/71062729/log\r\nSee ticket #36453\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/373983263","html_url":"https://github.com/NixOS/nixpkgs/pull/37147#issuecomment-373983263","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/37147","id":373983263,"user":{"login":"dotlambda","id":6806011,"avatar_url":"https://avatars2.githubusercontent.com/u/6806011?v=4","gravatar_id":"","url":"https://api.github.com/users/dotlambda","html_url":"https://github.com/dotlambda","followers_url":"https://api.github.com/users/dotlambda/followers","following_url":"https://api.github.com/users/dotlambda/following{/other_user}","gists_url":"https://api.github.com/users/dotlambda/gists{/gist_id}","starred_url":"https://api.github.com/users/dotlambda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotlambda/subscriptions","organizations_url":"https://api.github.com/users/dotlambda/orgs","repos_url":"https://api.github.com/users/dotlambda/repos","events_url":"https://api.github.com/users/dotlambda/events{/privacy}","received_events_url":"https://api.github.com/users/dotlambda/received_events","type":"User","site_admin":false},"created_at":"2018-03-18T09:13:33Z","updated_at":"2018-03-18T09:13:33Z","author_association":"CONTRIBUTOR","body":"That's strange. Wasn't pycurl fixed by https://github.com/NixOS/nixpkgs/pull/37008?"}}
{"actor":{"display_login":"dotlambda"}}