{"action":"created","comment":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/comments/217317590","pull_request_review_id":154995399,"id":217317590,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzMxNzU5MA==","diff_hunk":"@@ -38,68 +38,81 @@\n #/Changes                 merge=union\n \n # No header for text files (would be too obtrusive).\n-*.md                     ocaml-typo=missing-header\n-README*                  ocaml-typo=missing-header\n-*.adoc                   ocaml-typo=missing-header,long-line,unused-prop\n-\n-/.mailmap                ocaml-typo=long-line,missing-header,non-ascii\n-/.merlin                 ocaml-typo=missing-header\n-/Changes                 ocaml-typo=utf8,missing-header\n-/INSTALL                 ocaml-typo=missing-header\n-/LICENSE                 ocaml-typo=long-line,very-long-line,missing-header\n+*.md                     typo.missing-header\n+README*                  typo.missing-header\n+*.adoc                   typo.missing-header\n+*.adoc                   typo.long-line=may\n+\n+/.mailmap                typo.long-line typo.missing-header typo.non-ascii\n+/.merlin                 typo.missing-header\n+/Changes                 typo.utf8 typo.missing-header\n+/INSTALL                 typo.missing-header\n+/LICENSE                 typo.long-line typo.very-long-line typo.missing-header\n # tools/ci/appveyor/appveyor_build.cmd only has missing-header because\n # dra27 too lazy to update check-typo to interpret Cmd-style comments!\n-/tools/ci/appveyor/appveyor_build.cmd      ocaml-typo=long-line,very-long-line,missing-header,non-ascii text eol=crlf\n-/tools/ci/appveyor/appveyor_build.sh       ocaml-typo=non-ascii\n+/tools/ci/appveyor/appveyor_build.cmd       typo.long-line typo.very-long-line typo.missing-header typo.non-ascii\n+/tools/ci/appveyor/appveyor_build.sh        typo.non-ascii\n+/tools/ci/inria/remove-sinh-primitive.patch typo.white-at-eol typo.missing-header\n \n+# ignore auto-generated .depend files\n+.depend                  typo.prune\n \n-asmcomp/*/emit.mlp       ocaml-typo=tab,long-line,unused-prop\n-asmcomp/power/NOTES.md   ocaml-typo=missing-header\n+# Makefiles may contain tabs\n+Makefile*                typo.tab=may\n \n-/config/gnu              ocaml-typo=prune\n+asmcomp/*/emit.mlp       typo.tab=may typo.long-line=may\n+asmcomp/power/NOTES.md   typo.missing-header\n \n-emacs/*.el               ocaml-typo=long-line,unused-prop\n-emacs/caml.el            ocaml-typo=long-line,unused-prop,missing-header\n-emacs/COPYING            ocaml-typo=tab,non-printing,missing-header\n-emacs/ocamltags.in       ocaml-typo=non-printing\n+/config/gnu              typo.prune\n \n-/experimental            ocaml-typo=prune\n+emacs/*.el               typo.long-line=may\n+emacs/caml.el            typo.long-line=may typo.missing-header\n+emacs/COPYING            typo.tab typo.non-printing typo.missing-header\n+emacs/ocamltags.in       typo.non-printing\n \n-/manual                  ocaml-typo=prune\n+/experimental            typo.prune\n \n-ocamldoc/Changes.txt     ocaml-typo=missing-header\n-ocamldoc/ocamldoc.sty    ocaml-typo=missing-header\n-ocamldoc/odoc_index.html ocaml-typo=missing-header\n+/manual                  typo.prune\n \n-otherlibs/win32unix/readlink.c    ocaml-typo=long-line\n-otherlibs/win32unix/stat.c        ocaml-typo=long-line\n-otherlibs/win32unix/symlink.c     ocaml-typo=long-line\n+ocamldoc/**              typo.long-line=may\n+ocamldoc/Changes.txt     typo.missing-header\n+ocamldoc/ocamldoc.sty    typo.missing-header\n+ocamldoc/odoc_index.html typo.missing-header\n \n-runtime/i386.S            ocaml-typo=long-line\n+otherlibs/win32unix/readlink.c    typo.long-line\n+otherlibs/win32unix/stat.c        typo.long-line\n+otherlibs/win32unix/symlink.c     typo.long-line\n \n-stdlib/hashbang     ocaml-typo=white-at-eol,missing-lf\n+runtime/i386.S      typo.long-line\n \n-testsuite/tests/**                                      ocaml-typo=missing-header\n-testsuite/tests/lib-bigarray-2/bigarrf.f                ocaml-typo=missing-header,tab\n-testsuite/tests/lib-unix/win-stat/fakeclock.c           ocaml-typo=\n-testsuite/tests/misc-unsafe/almabench.ml                ocaml-typo=missing-header,long-line\n-testsuite/tests/tool-toplevel/strings.ml                ocaml-typo=utf8,missing-header\n-testsuite/tests/typing-unboxed-types/test.ml.reference* ocaml-typo=white-at-eof,missing-header\n-testsuite/tests/win-unicode/*.ml                        ocaml-typo=utf8,missing-header\n-testsuite/tools/*.S                                     ocaml-typo=missing-header\n-testsuite/tools/*.asm                                   ocaml-typo=missing-header\n-testsuite/typing                                        ocaml-typo=missing-header\n+stdlib/hashbang     typo.white-at-eol typo.missing-lf\n+\n+testsuite/tests/**                                      typo.missing-header\n+testsuite/tests/lib-bigarray-2/bigarrf.f                typo.tab\n+testsuite/tests/lib-unix/win-stat/fakeclock.c           typo.missing-header=false\n+testsuite/tests/misc-unsafe/almabench.ml                typo.long-line\n+testsuite/tests/tool-toplevel/strings.ml                typo.utf8\n+testsuite/tests/typing-unboxed-types/test.ml.reference* typo.white-at-eof\n+testsuite/tests/win-unicode/*.ml                        typo.utf8\n+testsuite/tools/*.S                                     typo.missing-header\n+testsuite/tools/*.asm                                   typo.missing-header\n+testsuite/typing                                        typo.missing-header\n+\n+# prune testsuite reference files\n+testsuite/tests/**/*.reference               typo.prune\n+testsuite/tests/**/reference                 typo.prune","path":".gitattributes","position":115,"original_position":115,"commit_id":"6a7dcd0d3c7e51ed7d825be8db0862c590aeab04","original_commit_id":"6a7dcd0d3c7e51ed7d825be8db0862c590aeab04","user":{"login":"damiendoligez","id":19104,"node_id":"MDQ6VXNlcjE5MTA0","avatar_url":"https://avatars2.githubusercontent.com/u/19104?v=4","gravatar_id":"","url":"https://api.github.com/users/damiendoligez","html_url":"https://github.com/damiendoligez","followers_url":"https://api.github.com/users/damiendoligez/followers","following_url":"https://api.github.com/users/damiendoligez/following{/other_user}","gists_url":"https://api.github.com/users/damiendoligez/gists{/gist_id}","starred_url":"https://api.github.com/users/damiendoligez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damiendoligez/subscriptions","organizations_url":"https://api.github.com/users/damiendoligez/orgs","repos_url":"https://api.github.com/users/damiendoligez/repos","events_url":"https://api.github.com/users/damiendoligez/events{/privacy}","received_events_url":"https://api.github.com/users/damiendoligez/received_events","type":"User","site_admin":false},"body":"Seconded. That should slightly simplify the test script itself.","created_at":"2018-09-13T09:25:15Z","updated_at":"2018-09-13T09:38:20Z","html_url":"https://github.com/ocaml/ocaml/pull/1910#discussion_r217317590","pull_request_url":"https://api.github.com/repos/ocaml/ocaml/pulls/1910","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/comments/217317590"},"html":{"href":"https://github.com/ocaml/ocaml/pull/1910#discussion_r217317590"},"pull_request":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/1910"}},"in_reply_to_id":215534444},"pull_request":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/1910","id":201876668,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxODc2NjY4","html_url":"https://github.com/ocaml/ocaml/pull/1910","diff_url":"https://github.com/ocaml/ocaml/pull/1910.diff","patch_url":"https://github.com/ocaml/ocaml/pull/1910.patch","issue_url":"https://api.github.com/repos/ocaml/ocaml/issues/1910","number":1910,"state":"open","locked":false,"title":"Simpler check-typo","user":{"login":"gasche","id":426238,"node_id":"MDQ6VXNlcjQyNjIzOA==","avatar_url":"https://avatars2.githubusercontent.com/u/426238?v=4","gravatar_id":"","url":"https://api.github.com/users/gasche","html_url":"https://github.com/gasche","followers_url":"https://api.github.com/users/gasche/followers","following_url":"https://api.github.com/users/gasche/following{/other_user}","gists_url":"https://api.github.com/users/gasche/gists{/gist_id}","starred_url":"https://api.github.com/users/gasche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gasche/subscriptions","organizations_url":"https://api.github.com/users/gasche/orgs","repos_url":"https://api.github.com/users/gasche/repos","events_url":"https://api.github.com/users/gasche/events{/privacy}","received_events_url":"https://api.github.com/users/gasche/received_events","type":"User","site_admin":false},"body":"I wanted this to fix [this particular comment](https://github.com/ocaml/ocaml/pull/1905#discussion_r202782208) of @dra27 in the review of #1905. If the present PR is accepted, I will rebase #1905 on top of it.","created_at":"2018-07-17T09:23:36Z","updated_at":"2018-09-13T09:38:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e0ac14b48481e737784e7007aec898c950fe831b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ocaml/ocaml/pulls/1910/commits","review_comments_url":"https://api.github.com/repos/ocaml/ocaml/pulls/1910/comments","review_comment_url":"https://api.github.com/repos/ocaml/ocaml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ocaml/ocaml/issues/1910/comments","statuses_url":"https://api.github.com/repos/ocaml/ocaml/statuses/6a7dcd0d3c7e51ed7d825be8db0862c590aeab04","head":{"label":"gasche:simpler-check-typo","ref":"simpler-check-typo","sha":"6a7dcd0d3c7e51ed7d825be8db0862c590aeab04","user":{"login":"gasche","id":426238,"node_id":"MDQ6VXNlcjQyNjIzOA==","avatar_url":"https://avatars2.githubusercontent.com/u/426238?v=4","gravatar_id":"","url":"https://api.github.com/users/gasche","html_url":"https://github.com/gasche","followers_url":"https://api.github.com/users/gasche/followers","following_url":"https://api.github.com/users/gasche/following{/other_user}","gists_url":"https://api.github.com/users/gasche/gists{/gist_id}","starred_url":"https://api.github.com/users/gasche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gasche/subscriptions","organizations_url":"https://api.github.com/users/gasche/orgs","repos_url":"https://api.github.com/users/gasche/repos","events_url":"https://api.github.com/users/gasche/events{/privacy}","received_events_url":"https://api.github.com/users/gasche/received_events","type":"User","site_admin":false},"repo":{"id":18431480,"node_id":"MDEwOlJlcG9zaXRvcnkxODQzMTQ4MA==","name":"ocaml","full_name":"gasche/ocaml","owner":{"login":"gasche","id":426238,"node_id":"MDQ6VXNlcjQyNjIzOA==","avatar_url":"https://avatars2.githubusercontent.com/u/426238?v=4","gravatar_id":"","url":"https://api.github.com/users/gasche","html_url":"https://github.com/gasche","followers_url":"https://api.github.com/users/gasche/followers","following_url":"https://api.github.com/users/gasche/following{/other_user}","gists_url":"https://api.github.com/users/gasche/gists{/gist_id}","starred_url":"https://api.github.com/users/gasche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gasche/subscriptions","organizations_url":"https://api.github.com/users/gasche/orgs","repos_url":"https://api.github.com/users/gasche/repos","events_url":"https://api.github.com/users/gasche/events{/privacy}","received_events_url":"https://api.github.com/users/gasche/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gasche/ocaml","description":" The core OCaml system: compilers, runtime system, base libraries ","fork":true,"url":"https://api.github.com/repos/gasche/ocaml","forks_url":"https://api.github.com/repos/gasche/ocaml/forks","keys_url":"https://api.github.com/repos/gasche/ocaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gasche/ocaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gasche/ocaml/teams","hooks_url":"https://api.github.com/repos/gasche/ocaml/hooks","issue_events_url":"https://api.github.com/repos/gasche/ocaml/issues/events{/number}","events_url":"https://api.github.com/repos/gasche/ocaml/events","assignees_url":"https://api.github.com/repos/gasche/ocaml/assignees{/user}","branches_url":"https://api.github.com/repos/gasche/ocaml/branches{/branch}","tags_url":"https://api.github.com/repos/gasche/ocaml/tags","blobs_url":"https://api.github.com/repos/gasche/ocaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gasche/ocaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gasche/ocaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/gasche/ocaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gasche/ocaml/statuses/{sha}","languages_url":"https://api.github.com/repos/gasche/ocaml/languages","stargazers_url":"https://api.github.com/repos/gasche/ocaml/stargazers","contributors_url":"https://api.github.com/repos/gasche/ocaml/contributors","subscribers_url":"https://api.github.com/repos/gasche/ocaml/subscribers","subscription_url":"https://api.github.com/repos/gasche/ocaml/subscription","commits_url":"https://api.github.com/repos/gasche/ocaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/gasche/ocaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/gasche/ocaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/gasche/ocaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/gasche/ocaml/contents/{+path}","compare_url":"https://api.github.com/repos/gasche/ocaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gasche/ocaml/merges","archive_url":"https://api.github.com/repos/gasche/ocaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gasche/ocaml/downloads","issues_url":"https://api.github.com/repos/gasche/ocaml/issues{/number}","pulls_url":"https://api.github.com/repos/gasche/ocaml/pulls{/number}","milestones_url":"https://api.github.com/repos/gasche/ocaml/milestones{/number}","notifications_url":"https://api.github.com/repos/gasche/ocaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gasche/ocaml/labels{/name}","releases_url":"https://api.github.com/repos/gasche/ocaml/releases{/id}","deployments_url":"https://api.github.com/repos/gasche/ocaml/deployments","created_at":"2014-04-04T07:49:39Z","updated_at":"2018-09-07T11:24:38Z","pushed_at":"2018-09-10T20:41:51Z","git_url":"git://github.com/gasche/ocaml.git","ssh_url":"git@github.com:gasche/ocaml.git","clone_url":"https://github.com/gasche/ocaml.git","svn_url":"https://github.com/gasche/ocaml","homepage":"","size":195674,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"ocaml:trunk","ref":"trunk","sha":"213d1dbffa724bc2742c41df470291f2b0148a19","user":{"login":"ocaml","id":1841483,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NDE0ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/1841483?v=4","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"repo":{"id":6786166,"node_id":"MDEwOlJlcG9zaXRvcnk2Nzg2MTY2","name":"ocaml","full_name":"ocaml/ocaml","owner":{"login":"ocaml","id":1841483,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NDE0ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/1841483?v=4","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ocaml/ocaml","description":"The core OCaml system: compilers, runtime system, base libraries","fork":false,"url":"https://api.github.com/repos/ocaml/ocaml","forks_url":"https://api.github.com/repos/ocaml/ocaml/forks","keys_url":"https://api.github.com/repos/ocaml/ocaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocaml/ocaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocaml/ocaml/teams","hooks_url":"https://api.github.com/repos/ocaml/ocaml/hooks","issue_events_url":"https://api.github.com/repos/ocaml/ocaml/issues/events{/number}","events_url":"https://api.github.com/repos/ocaml/ocaml/events","assignees_url":"https://api.github.com/repos/ocaml/ocaml/assignees{/user}","branches_url":"https://api.github.com/repos/ocaml/ocaml/branches{/branch}","tags_url":"https://api.github.com/repos/ocaml/ocaml/tags","blobs_url":"https://api.github.com/repos/ocaml/ocaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocaml/ocaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocaml/ocaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocaml/ocaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocaml/ocaml/statuses/{sha}","languages_url":"https://api.github.com/repos/ocaml/ocaml/languages","stargazers_url":"https://api.github.com/repos/ocaml/ocaml/stargazers","contributors_url":"https://api.github.com/repos/ocaml/ocaml/contributors","subscribers_url":"https://api.github.com/repos/ocaml/ocaml/subscribers","subscription_url":"https://api.github.com/repos/ocaml/ocaml/subscription","commits_url":"https://api.github.com/repos/ocaml/ocaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocaml/ocaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocaml/ocaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocaml/ocaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocaml/ocaml/contents/{+path}","compare_url":"https://api.github.com/repos/ocaml/ocaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocaml/ocaml/merges","archive_url":"https://api.github.com/repos/ocaml/ocaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocaml/ocaml/downloads","issues_url":"https://api.github.com/repos/ocaml/ocaml/issues{/number}","pulls_url":"https://api.github.com/repos/ocaml/ocaml/pulls{/number}","milestones_url":"https://api.github.com/repos/ocaml/ocaml/milestones{/number}","notifications_url":"https://api.github.com/repos/ocaml/ocaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocaml/ocaml/labels{/name}","releases_url":"https://api.github.com/repos/ocaml/ocaml/releases{/id}","deployments_url":"https://api.github.com/repos/ocaml/ocaml/deployments","created_at":"2012-11-20T22:18:22Z","updated_at":"2018-09-13T08:38:37Z","pushed_at":"2018-09-13T08:38:07Z","git_url":"git://github.com/ocaml/ocaml.git","ssh_url":"git@github.com:ocaml/ocaml.git","clone_url":"https://github.com/ocaml/ocaml.git","svn_url":"https://github.com/ocaml/ocaml","homepage":"","size":178103,"stargazers_count":1985,"watchers_count":1985,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":480,"mirror_url":null,"archived":false,"open_issues_count":169,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":480,"open_issues":169,"watchers":1985,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/1910"},"html":{"href":"https://github.com/ocaml/ocaml/pull/1910"},"issue":{"href":"https://api.github.com/repos/ocaml/ocaml/issues/1910"},"comments":{"href":"https://api.github.com/repos/ocaml/ocaml/issues/1910/comments"},"review_comments":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/1910/comments"},"review_comment":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/1910/commits"},"statuses":{"href":"https://api.github.com/repos/ocaml/ocaml/statuses/6a7dcd0d3c7e51ed7d825be8db0862c590aeab04"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"damiendoligez"}}