{"action":"created","comment":{"url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/pulls/comments/195768213","pull_request_review_id":129202502,"id":195768213,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTc2ODIxMw==","diff_hunk":"@@ -0,0 +1,36 @@\n+# Domain Name System (DNS) Pattern\n+\n+To standardise on how services route their application traffic to the appropriate hosting platform and to offer consistency in how we approach DNS we have a standard DNS naming convention services.\n+\n+In parallel to this, users need to also be aware of [the limits on certificates and letsencrypt](../how-to-docs/certificates.md).\n+\n+### For Non-production Services\n+\n+The following categories are something we would expect a service to specify:\n+\n+`Service Name` - The name of the service users or other services will attempt to consume i.e. `web-portal`\n+\n+`Env` - The environment of the service i.e. `Dev`\n+\n+`Service` - The overall service name or project name i.e. `example-service`\n+\n+```\n+<servicename>.<env>.<service>-notprod.homeoffice.gov.uk\n+\n+web-portal.dev.example-service-notprod.homeoffice.gov.uk\n+```\n+\n+\n+### For Production Services\n+\n+As we want to protect production services from hitting limits and to create a distinction between services that at not-production and production, we simplify the overall approach by using the main service name as the domain.","path":"docs/dns.md","position":26,"original_position":26,"commit_id":"cc2473694dec94d44effc9effdfa3da4b35fe6b1","original_commit_id":"cc2473694dec94d44effc9effdfa3da4b35fe6b1","user":{"login":"KashifSaadat","id":6972966,"node_id":"MDQ6VXNlcjY5NzI5NjY=","avatar_url":"https://avatars0.githubusercontent.com/u/6972966?v=4","gravatar_id":"","url":"https://api.github.com/users/KashifSaadat","html_url":"https://github.com/KashifSaadat","followers_url":"https://api.github.com/users/KashifSaadat/followers","following_url":"https://api.github.com/users/KashifSaadat/following{/other_user}","gists_url":"https://api.github.com/users/KashifSaadat/gists{/gist_id}","starred_url":"https://api.github.com/users/KashifSaadat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KashifSaadat/subscriptions","organizations_url":"https://api.github.com/users/KashifSaadat/orgs","repos_url":"https://api.github.com/users/KashifSaadat/repos","events_url":"https://api.github.com/users/KashifSaadat/events{/privacy}","received_events_url":"https://api.github.com/users/KashifSaadat/received_events","type":"User","site_admin":false},"body":"`that at` => `that are`","created_at":"2018-06-15T14:58:56Z","updated_at":"2018-06-15T14:58:56Z","html_url":"https://github.com/UKHomeOffice/application-container-platform/pull/572#discussion_r195768213","pull_request_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/pulls/572","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/UKHomeOffice/application-container-platform/pulls/comments/195768213"},"html":{"href":"https://github.com/UKHomeOffice/application-container-platform/pull/572#discussion_r195768213"},"pull_request":{"href":"https://api.github.com/repos/UKHomeOffice/application-container-platform/pulls/572"}}},"pull_request":{"url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/pulls/572","id":195200516,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MjAwNTE2","html_url":"https://github.com/UKHomeOffice/application-container-platform/pull/572","diff_url":"https://github.com/UKHomeOffice/application-container-platform/pull/572.diff","patch_url":"https://github.com/UKHomeOffice/application-container-platform/pull/572.patch","issue_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/issues/572","number":572,"state":"open","locked":false,"title":"adding in dns docs","user":{"login":"jon-shanks","id":3877018,"node_id":"MDQ6VXNlcjM4NzcwMTg=","avatar_url":"https://avatars2.githubusercontent.com/u/3877018?v=4","gravatar_id":"","url":"https://api.github.com/users/jon-shanks","html_url":"https://github.com/jon-shanks","followers_url":"https://api.github.com/users/jon-shanks/followers","following_url":"https://api.github.com/users/jon-shanks/following{/other_user}","gists_url":"https://api.github.com/users/jon-shanks/gists{/gist_id}","starred_url":"https://api.github.com/users/jon-shanks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jon-shanks/subscriptions","organizations_url":"https://api.github.com/users/jon-shanks/orgs","repos_url":"https://api.github.com/users/jon-shanks/repos","events_url":"https://api.github.com/users/jon-shanks/events{/privacy}","received_events_url":"https://api.github.com/users/jon-shanks/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-15T14:55:29Z","updated_at":"2018-06-15T14:58:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30c4b42e96cac524dfdebde5911e40ba5aa41ea3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/pulls/572/commits","review_comments_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/pulls/572/comments","review_comment_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/issues/572/comments","statuses_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/statuses/cc2473694dec94d44effc9effdfa3da4b35fe6b1","head":{"label":"UKHomeOffice:dns","ref":"dns","sha":"cc2473694dec94d44effc9effdfa3da4b35fe6b1","user":{"login":"UKHomeOffice","id":3778081,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NzgwODE=","avatar_url":"https://avatars2.githubusercontent.com/u/3778081?v=4","gravatar_id":"","url":"https://api.github.com/users/UKHomeOffice","html_url":"https://github.com/UKHomeOffice","followers_url":"https://api.github.com/users/UKHomeOffice/followers","following_url":"https://api.github.com/users/UKHomeOffice/following{/other_user}","gists_url":"https://api.github.com/users/UKHomeOffice/gists{/gist_id}","starred_url":"https://api.github.com/users/UKHomeOffice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UKHomeOffice/subscriptions","organizations_url":"https://api.github.com/users/UKHomeOffice/orgs","repos_url":"https://api.github.com/users/UKHomeOffice/repos","events_url":"https://api.github.com/users/UKHomeOffice/events{/privacy}","received_events_url":"https://api.github.com/users/UKHomeOffice/received_events","type":"Organization","site_admin":false},"repo":{"id":39407860,"node_id":"MDEwOlJlcG9zaXRvcnkzOTQwNzg2MA==","name":"application-container-platform","full_name":"UKHomeOffice/application-container-platform","owner":{"login":"UKHomeOffice","id":3778081,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NzgwODE=","avatar_url":"https://avatars2.githubusercontent.com/u/3778081?v=4","gravatar_id":"","url":"https://api.github.com/users/UKHomeOffice","html_url":"https://github.com/UKHomeOffice","followers_url":"https://api.github.com/users/UKHomeOffice/followers","following_url":"https://api.github.com/users/UKHomeOffice/following{/other_user}","gists_url":"https://api.github.com/users/UKHomeOffice/gists{/gist_id}","starred_url":"https://api.github.com/users/UKHomeOffice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UKHomeOffice/subscriptions","organizations_url":"https://api.github.com/users/UKHomeOffice/orgs","repos_url":"https://api.github.com/users/UKHomeOffice/repos","events_url":"https://api.github.com/users/UKHomeOffice/events{/privacy}","received_events_url":"https://api.github.com/users/UKHomeOffice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UKHomeOffice/application-container-platform","description":"Application Container Platform","fork":false,"url":"https://api.github.com/repos/UKHomeOffice/application-container-platform","forks_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/forks","keys_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/teams","hooks_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/hooks","issue_events_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/issues/events{/number}","events_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/events","assignees_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/assignees{/user}","branches_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/branches{/branch}","tags_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/tags","blobs_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/languages","stargazers_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/stargazers","contributors_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/contributors","subscribers_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/subscribers","subscription_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/subscription","commits_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/contents/{+path}","compare_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/merges","archive_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/downloads","issues_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/issues{/number}","pulls_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/labels{/name}","releases_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/releases{/id}","deployments_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/deployments","created_at":"2015-07-20T20:52:37Z","updated_at":"2018-06-14T13:43:31Z","pushed_at":"2018-06-15T14:56:59Z","git_url":"git://github.com/UKHomeOffice/application-container-platform.git","ssh_url":"git@github.com:UKHomeOffice/application-container-platform.git","clone_url":"https://github.com/UKHomeOffice/application-container-platform.git","svn_url":"https://github.com/UKHomeOffice/application-container-platform","homepage":"","size":894,"stargazers_count":30,"watchers_count":30,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":35,"open_issues":1,"watchers":30,"default_branch":"master"}},"base":{"label":"UKHomeOffice:master","ref":"master","sha":"bffbe28e87de5e7aa961d030c2ebb0e03fee31ef","user":{"login":"UKHomeOffice","id":3778081,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NzgwODE=","avatar_url":"https://avatars2.githubusercontent.com/u/3778081?v=4","gravatar_id":"","url":"https://api.github.com/users/UKHomeOffice","html_url":"https://github.com/UKHomeOffice","followers_url":"https://api.github.com/users/UKHomeOffice/followers","following_url":"https://api.github.com/users/UKHomeOffice/following{/other_user}","gists_url":"https://api.github.com/users/UKHomeOffice/gists{/gist_id}","starred_url":"https://api.github.com/users/UKHomeOffice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UKHomeOffice/subscriptions","organizations_url":"https://api.github.com/users/UKHomeOffice/orgs","repos_url":"https://api.github.com/users/UKHomeOffice/repos","events_url":"https://api.github.com/users/UKHomeOffice/events{/privacy}","received_events_url":"https://api.github.com/users/UKHomeOffice/received_events","type":"Organization","site_admin":false},"repo":{"id":39407860,"node_id":"MDEwOlJlcG9zaXRvcnkzOTQwNzg2MA==","name":"application-container-platform","full_name":"UKHomeOffice/application-container-platform","owner":{"login":"UKHomeOffice","id":3778081,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NzgwODE=","avatar_url":"https://avatars2.githubusercontent.com/u/3778081?v=4","gravatar_id":"","url":"https://api.github.com/users/UKHomeOffice","html_url":"https://github.com/UKHomeOffice","followers_url":"https://api.github.com/users/UKHomeOffice/followers","following_url":"https://api.github.com/users/UKHomeOffice/following{/other_user}","gists_url":"https://api.github.com/users/UKHomeOffice/gists{/gist_id}","starred_url":"https://api.github.com/users/UKHomeOffice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UKHomeOffice/subscriptions","organizations_url":"https://api.github.com/users/UKHomeOffice/orgs","repos_url":"https://api.github.com/users/UKHomeOffice/repos","events_url":"https://api.github.com/users/UKHomeOffice/events{/privacy}","received_events_url":"https://api.github.com/users/UKHomeOffice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UKHomeOffice/application-container-platform","description":"Application Container Platform","fork":false,"url":"https://api.github.com/repos/UKHomeOffice/application-container-platform","forks_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/forks","keys_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/teams","hooks_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/hooks","issue_events_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/issues/events{/number}","events_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/events","assignees_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/assignees{/user}","branches_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/branches{/branch}","tags_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/tags","blobs_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/languages","stargazers_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/stargazers","contributors_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/contributors","subscribers_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/subscribers","subscription_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/subscription","commits_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/contents/{+path}","compare_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/merges","archive_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/downloads","issues_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/issues{/number}","pulls_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/labels{/name}","releases_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/releases{/id}","deployments_url":"https://api.github.com/repos/UKHomeOffice/application-container-platform/deployments","created_at":"2015-07-20T20:52:37Z","updated_at":"2018-06-14T13:43:31Z","pushed_at":"2018-06-15T14:56:59Z","git_url":"git://github.com/UKHomeOffice/application-container-platform.git","ssh_url":"git@github.com:UKHomeOffice/application-container-platform.git","clone_url":"https://github.com/UKHomeOffice/application-container-platform.git","svn_url":"https://github.com/UKHomeOffice/application-container-platform","homepage":"","size":894,"stargazers_count":30,"watchers_count":30,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":35,"open_issues":1,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UKHomeOffice/application-container-platform/pulls/572"},"html":{"href":"https://github.com/UKHomeOffice/application-container-platform/pull/572"},"issue":{"href":"https://api.github.com/repos/UKHomeOffice/application-container-platform/issues/572"},"comments":{"href":"https://api.github.com/repos/UKHomeOffice/application-container-platform/issues/572/comments"},"review_comments":{"href":"https://api.github.com/repos/UKHomeOffice/application-container-platform/pulls/572/comments"},"review_comment":{"href":"https://api.github.com/repos/UKHomeOffice/application-container-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UKHomeOffice/application-container-platform/pulls/572/commits"},"statuses":{"href":"https://api.github.com/repos/UKHomeOffice/application-container-platform/statuses/cc2473694dec94d44effc9effdfa3da4b35fe6b1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"KashifSaadat"}}