{"action":"created","issue":{"url":"https://api.github.com/repos/emotion-js/emotion/issues/881","repository_url":"https://api.github.com/repos/emotion-js/emotion","labels_url":"https://api.github.com/repos/emotion-js/emotion/issues/881/labels{/name}","comments_url":"https://api.github.com/repos/emotion-js/emotion/issues/881/comments","events_url":"https://api.github.com/repos/emotion-js/emotion/issues/881/events","html_url":"https://github.com/emotion-js/emotion/issues/881","id":365096647,"node_id":"MDU6SXNzdWUzNjUwOTY2NDc=","number":881,"title":"Code base does not \"just work\" when cloned (on Windows?)","user":{"login":"Brondahl","id":6950421,"node_id":"MDQ6VXNlcjY5NTA0MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/6950421?v=4","gravatar_id":"","url":"https://api.github.com/users/Brondahl","html_url":"https://github.com/Brondahl","followers_url":"https://api.github.com/users/Brondahl/followers","following_url":"https://api.github.com/users/Brondahl/following{/other_user}","gists_url":"https://api.github.com/users/Brondahl/gists{/gist_id}","starred_url":"https://api.github.com/users/Brondahl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brondahl/subscriptions","organizations_url":"https://api.github.com/users/Brondahl/orgs","repos_url":"https://api.github.com/users/Brondahl/repos","events_url":"https://api.github.com/users/Brondahl/events{/privacy}","received_events_url":"https://api.github.com/users/Brondahl/received_events","type":"User","site_admin":false},"labels":[{"id":706011414,"node_id":"MDU6TGFiZWw3MDYwMTE0MTQ=","url":"https://api.github.com/repos/emotion-js/emotion/labels/bug","name":"bug","color":"b60205","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":26,"created_at":"2018-09-29T04:43:58Z","updated_at":"2018-10-11T09:12:32Z","closed_at":"2018-10-10T20:17:51Z","author_association":"NONE","body":"Hi there,\r\nI've got 8 years experience of professional software development, but only ~4 months of experience on modern JS stack, so it's very possible that this is entirely mistakes or lack of knowledge about yarn / npm on my part, but I would hope that I was capable of following basic Setup steps for an OS project.\r\n\r\nEven if the error is with me, it seems likely that the documentation could be improved to cater to other dummies who still want to Contribute, and I'm happy to submit a PR for that ... once I know what the solution is ... :)\r\n\r\n-----------------------------\r\n\r\nI wanted to raise a pretty trivial code feature PR for `emotion`, so I forked and cloned the project. I expected to be able to just run it and have everything work perfectly before I made my changes, but that isn't the case - if you just follow the direct instructions you get a bunch of warnings followed by an enormous collection of errors and test failures.\r\n\r\nDetails:\r\n\r\nVersions:\r\n- `emotion` version: current `master` as of 29/09/2018. (looks like npm pkg version 9.2.10. Commit: `0fdabe`.)\r\n- `react` version: (N/A: This is a bug with the library development, not its usage)\r\n- `node` version: v10.10.1\r\n- `npm` version: 6.4.1\r\n- `yarn` version: 1.10.1\r\n\r\n\r\nWhat you did:\r\n`git clone`\r\nrun Yarn installer from here: https://yarnpkg.com/en/docs/install#windows-stable\r\nrun `yarn` from the root of the cloned repo.\r\nrun `yarn test` from the root of the repo.\r\n\r\nI believe the above sequence represents the instructions as currently given on the CONTRIBUTE page and then ran `yarn` from the root of my clone.\r\n\r\nWhat happened:\r\n\r\n`yarn` (which I assume to be roughly equivalent to `npm install`?) generated the following set of 17 peer-dependency warnings:\r\n\r\n```\r\nwarning \"workspace-aggregator-498a386e-835c-4f6f-ac4d-c847ab622954 > create-emotion-styled@9.2.8\" has unmet peer dependency \"prop-types@15.x\".\r\nwarning \"workspace-aggregator-498a386e-835c-4f6f-ac4d-c847ab622954 > emotion-theming@9.2.9\" has unmet peer dependency \"prop-types@15.x\".\r\nwarning \"workspace-aggregator-498a386e-835c-4f6f-ac4d-c847ab622954 > @emotion/native@9.2.9\" has unmet peer dependency \"prop-types@15.x\".\r\nwarning \"workspace-aggregator-498a386e-835c-4f6f-ac4d-c847ab622954 > @emotion/native@9.2.9\" has unmet peer dependency \"react-native@>=0.14.0 && < 1\".\r\nwarning \"workspace-aggregator-498a386e-835c-4f6f-ac4d-c847ab622954 > @emotion/primitives-core@9.2.9\" has unmet peer dependency \"prop-types@15.x\".\r\nwarning \"workspace-aggregator-498a386e-835c-4f6f-ac4d-c847ab622954 > @emotion/primitives@9.2.10\" has unmet peer dependency \"prop-types@15.x\".\r\nwarning \"workspace-aggregator-498a386e-835c-4f6f-ac4d-c847ab622954 > @emotion/primitives@9.2.10\" has unmet peer dependency \"react-primitives@^0.5.1\".\r\nwarning \"workspace-aggregator-498a386e-835c-4f6f-ac4d-c847ab622954 > @emotion/native > react-native@0.57.0\" has incorrect peer dependency \"react@16.5.0\".\r\nwarning \"workspace-aggregator-498a386e-835c-4f6f-ac4d-c847ab622954 > emotion-site > favicons-webpack-plugin@0.0.9\" has unmet peer dependency \"webpack@^1.13.0 || ^2.0.0 || ^3.0.0 || ^4.0.0\".\r\nwarning \"workspace-aggregator-498a386e-835c-4f6f-ac4d-c847ab622954 > emotion-site > gatsby-remark-prismjs@3.0.0-beta.3\" has unmet peer dependency \"prismjs@^1.13.0\".\r\nwarning \"workspace-aggregator-498a386e-835c-4f6f-ac4d-c847ab622954 > emotion-site > worker-loader@2.0.0\" has unmet peer dependency \"webpack@^3.0.0 || ^4.0.0-alpha.0 || ^4.0.0\".\r\nwarning \"workspace-aggregator-498a386e-835c-4f6f-ac4d-c847ab622954 > emotion-site > graphql-type-json@0.1.4\" has unmet peer dependency \"graphql@>=0.4.0\".\r\nwarning \"workspace-aggregator-498a386e-835c-4f6f-ac4d-c847ab622954 > benchmarks > react-native-web@0.8.8\" has unmet peer dependency \"react-art@16.x.x\".\r\nwarning \"workspace-aggregator-498a386e-835c-4f6f-ac4d-c847ab622954 > emotion-site > gatsby > babel-loader@8.0.0-beta.0\" has incorrect peer dependency \"webpack@2 || 3\".\r\nwarning \"workspace-aggregator-498a386e-835c-4f6f-ac4d-c847ab622954 > emotion-site > gatsby > babel-plugin-remove-graphql-queries@2.0.2-beta.4\" has incorrect peer dependency \"graphql@^0.11.7\".\r\nwarning \"workspace-aggregator-498a386e-835c-4f6f-ac4d-c847ab622954 > emotion-site > worker-loader > schema-utils@0.4.5\" has unmet peer dependency \"webpack@^2.0.0 || ^3.0.0 || ^4.0.0\".\r\nwarning \"workspace-aggregator-498a386e-835c-4f6f-ac4d-c847ab622954 > @emotion/native > react-native > metro > metro-visualizer > antd > rc-editor-mention@1.1.7\" has unmet peer dependency \"immutable@^3.7.4\".\r\n```\r\n`yarn test` then generated about a minute and a half of scrolling screen errors, with the final punchline:\r\n\r\n```\r\nSnapshot Summary\r\n › 166 snapshots failed from 23 test suites. Inspect your code changes or run `yarn run coverage -u` to update them.\r\n\r\nTest Suites: 35 failed, 49 passed, 84 total\r\nTests:       284 failed, 17 skipped, 692 passed, 993 total\r\nSnapshots:   166 failed, 617 passed, 783 total\r\nTime:        97.817s\r\nRan all test suites.\r\n```\r\n\r\nTo be clear, all of this is from a blank, untouched `git clone` of a fork of the emotion code base.\r\n\r\nReproduction:\r\nN/A\r\n\r\nProblem description:\r\nThe repo should JustWork when cloned for development, and/or should Document how to get it working properly.\r\n\r\n\r\nSuggested solution:\r\nMy first guess is that to get this all working I need to install some necessary dependencies.\r\nIf that's correct then I suspect the correct solution is to declare those as dev dependencies?\r\nFailing that, then we should be providing notes on what is necessary in the CONTRIBUTING.md file."},"comment":{"url":"https://api.github.com/repos/emotion-js/emotion/issues/comments/428881330","html_url":"https://github.com/emotion-js/emotion/issues/881#issuecomment-428881330","issue_url":"https://api.github.com/repos/emotion-js/emotion/issues/881","id":428881330,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODg4MTMzMA==","user":{"login":"Brondahl","id":6950421,"node_id":"MDQ6VXNlcjY5NTA0MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/6950421?v=4","gravatar_id":"","url":"https://api.github.com/users/Brondahl","html_url":"https://github.com/Brondahl","followers_url":"https://api.github.com/users/Brondahl/followers","following_url":"https://api.github.com/users/Brondahl/following{/other_user}","gists_url":"https://api.github.com/users/Brondahl/gists{/gist_id}","starred_url":"https://api.github.com/users/Brondahl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brondahl/subscriptions","organizations_url":"https://api.github.com/users/Brondahl/orgs","repos_url":"https://api.github.com/users/Brondahl/repos","events_url":"https://api.github.com/users/Brondahl/events{/privacy}","received_events_url":"https://api.github.com/users/Brondahl/received_events","type":"User","site_admin":false},"created_at":"2018-10-11T09:12:32Z","updated_at":"2018-10-11T09:12:32Z","author_association":"NONE","body":"[windowsSuccessfulOutput.txt](https://github.com/emotion-js/emotion/files/2468212/windowsSuccessfulOutput.txt)\r\n"}}
{"actor":{"display_login":"Brondahl"}}