{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/comments/241808245","pull_request_review_id":185178725,"id":241808245,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTgwODI0NQ==","diff_hunk":"@@ -93,6 +95,9 @@ object DockerContainer {\n       network) ++\n       environmentArgs ++\n       dnsServers.flatMap(d => Seq(\"--dns\", d)) ++\n+      dnsSearch.flatMap(d => Seq(\"--dns-search\", d)) ++\n+      // NOTE: --dns-option on modern versions of docker, but is --dns-opt on docker 1.12\n+      dnsOptions.flatMap(d => Seq(\"--dns-opt\", d)) ++","path":"core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/docker/DockerContainer.scala","position":15,"original_position":15,"commit_id":"790979641a20e95c14440a4682b42177cbcf757d","original_commit_id":"790979641a20e95c14440a4682b42177cbcf757d","user":{"login":"dgrove-oss","id":5099100,"node_id":"MDQ6VXNlcjUwOTkxMDA=","avatar_url":"https://avatars1.githubusercontent.com/u/5099100?v=4","gravatar_id":"","url":"https://api.github.com/users/dgrove-oss","html_url":"https://github.com/dgrove-oss","followers_url":"https://api.github.com/users/dgrove-oss/followers","following_url":"https://api.github.com/users/dgrove-oss/following{/other_user}","gists_url":"https://api.github.com/users/dgrove-oss/gists{/gist_id}","starred_url":"https://api.github.com/users/dgrove-oss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgrove-oss/subscriptions","organizations_url":"https://api.github.com/users/dgrove-oss/orgs","repos_url":"https://api.github.com/users/dgrove-oss/repos","events_url":"https://api.github.com/users/dgrove-oss/events{/privacy}","received_events_url":"https://api.github.com/users/dgrove-oss/received_events","type":"User","site_admin":false},"body":"It annoyingly needs to match the version of the docker client embedded in the invoker Dockerfile.  I could add a comment to the Dockerfile with a pointer to change this line of code when the version is (finally) updated.  I thought about making this more parameterized, but that seemed like overkill.\r\n\r\nI do need to get the ndots:5 option into the user actions resolv.conf file to enable user actions to invoke kube services, so we do need to do something.","created_at":"2018-12-14T16:15:17Z","updated_at":"2018-12-14T16:15:17Z","html_url":"https://github.com/apache/incubator-openwhisk/pull/4176#discussion_r241808245","pull_request_url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/4176","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/comments/241808245"},"html":{"href":"https://github.com/apache/incubator-openwhisk/pull/4176#discussion_r241808245"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/4176"}},"in_reply_to_id":241804108},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/4176","id":238541263,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NTQxMjYz","html_url":"https://github.com/apache/incubator-openwhisk/pull/4176","diff_url":"https://github.com/apache/incubator-openwhisk/pull/4176.diff","patch_url":"https://github.com/apache/incubator-openwhisk/pull/4176.patch","issue_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/4176","number":4176,"state":"open","locked":false,"title":"additional container factory dns configuration","user":{"login":"dgrove-oss","id":5099100,"node_id":"MDQ6VXNlcjUwOTkxMDA=","avatar_url":"https://avatars1.githubusercontent.com/u/5099100?v=4","gravatar_id":"","url":"https://api.github.com/users/dgrove-oss","html_url":"https://github.com/dgrove-oss","followers_url":"https://api.github.com/users/dgrove-oss/followers","following_url":"https://api.github.com/users/dgrove-oss/following{/other_user}","gists_url":"https://api.github.com/users/dgrove-oss/gists{/gist_id}","starred_url":"https://api.github.com/users/dgrove-oss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgrove-oss/subscriptions","organizations_url":"https://api.github.com/users/dgrove-oss/orgs","repos_url":"https://api.github.com/users/dgrove-oss/repos","events_url":"https://api.github.com/users/dgrove-oss/events{/privacy}","received_events_url":"https://api.github.com/users/dgrove-oss/received_events","type":"User","site_admin":false},"body":"Allow configuration of the --dns-search and --dns-opt (--dns-option)\r\narguments to the docker run command of the DockerContainerFactory.\r\nMotivated by better support of event providers in Kubernetes when\r\nusing the DockerContainerFactory.\r\n","created_at":"2018-12-13T21:40:53Z","updated_at":"2018-12-14T16:15:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8862b086255405dbaffe250bc9b08ef28db1d961","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":354873442,"node_id":"MDU6TGFiZWwzNTQ4NzM0NDI=","url":"https://api.github.com/repos/apache/incubator-openwhisk/labels/invoker","name":"invoker","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/4176/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/4176/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/4176/comments","statuses_url":"https://api.github.com/repos/apache/incubator-openwhisk/statuses/790979641a20e95c14440a4682b42177cbcf757d","head":{"label":"dgrove-oss:dns-config","ref":"dns-config","sha":"790979641a20e95c14440a4682b42177cbcf757d","user":{"login":"dgrove-oss","id":5099100,"node_id":"MDQ6VXNlcjUwOTkxMDA=","avatar_url":"https://avatars1.githubusercontent.com/u/5099100?v=4","gravatar_id":"","url":"https://api.github.com/users/dgrove-oss","html_url":"https://github.com/dgrove-oss","followers_url":"https://api.github.com/users/dgrove-oss/followers","following_url":"https://api.github.com/users/dgrove-oss/following{/other_user}","gists_url":"https://api.github.com/users/dgrove-oss/gists{/gist_id}","starred_url":"https://api.github.com/users/dgrove-oss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgrove-oss/subscriptions","organizations_url":"https://api.github.com/users/dgrove-oss/orgs","repos_url":"https://api.github.com/users/dgrove-oss/repos","events_url":"https://api.github.com/users/dgrove-oss/events{/privacy}","received_events_url":"https://api.github.com/users/dgrove-oss/received_events","type":"User","site_admin":false},"repo":{"id":90789275,"node_id":"MDEwOlJlcG9zaXRvcnk5MDc4OTI3NQ==","name":"openwhisk","full_name":"dgrove-oss/openwhisk","private":false,"owner":{"login":"dgrove-oss","id":5099100,"node_id":"MDQ6VXNlcjUwOTkxMDA=","avatar_url":"https://avatars1.githubusercontent.com/u/5099100?v=4","gravatar_id":"","url":"https://api.github.com/users/dgrove-oss","html_url":"https://github.com/dgrove-oss","followers_url":"https://api.github.com/users/dgrove-oss/followers","following_url":"https://api.github.com/users/dgrove-oss/following{/other_user}","gists_url":"https://api.github.com/users/dgrove-oss/gists{/gist_id}","starred_url":"https://api.github.com/users/dgrove-oss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgrove-oss/subscriptions","organizations_url":"https://api.github.com/users/dgrove-oss/orgs","repos_url":"https://api.github.com/users/dgrove-oss/repos","events_url":"https://api.github.com/users/dgrove-oss/events{/privacy}","received_events_url":"https://api.github.com/users/dgrove-oss/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dgrove-oss/openwhisk","description":"Apache OpenWhisk is a serverless event-based programming service and an Apache Incubator project.","fork":true,"url":"https://api.github.com/repos/dgrove-oss/openwhisk","forks_url":"https://api.github.com/repos/dgrove-oss/openwhisk/forks","keys_url":"https://api.github.com/repos/dgrove-oss/openwhisk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dgrove-oss/openwhisk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dgrove-oss/openwhisk/teams","hooks_url":"https://api.github.com/repos/dgrove-oss/openwhisk/hooks","issue_events_url":"https://api.github.com/repos/dgrove-oss/openwhisk/issues/events{/number}","events_url":"https://api.github.com/repos/dgrove-oss/openwhisk/events","assignees_url":"https://api.github.com/repos/dgrove-oss/openwhisk/assignees{/user}","branches_url":"https://api.github.com/repos/dgrove-oss/openwhisk/branches{/branch}","tags_url":"https://api.github.com/repos/dgrove-oss/openwhisk/tags","blobs_url":"https://api.github.com/repos/dgrove-oss/openwhisk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dgrove-oss/openwhisk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dgrove-oss/openwhisk/git/refs{/sha}","trees_url":"https://api.github.com/repos/dgrove-oss/openwhisk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dgrove-oss/openwhisk/statuses/{sha}","languages_url":"https://api.github.com/repos/dgrove-oss/openwhisk/languages","stargazers_url":"https://api.github.com/repos/dgrove-oss/openwhisk/stargazers","contributors_url":"https://api.github.com/repos/dgrove-oss/openwhisk/contributors","subscribers_url":"https://api.github.com/repos/dgrove-oss/openwhisk/subscribers","subscription_url":"https://api.github.com/repos/dgrove-oss/openwhisk/subscription","commits_url":"https://api.github.com/repos/dgrove-oss/openwhisk/commits{/sha}","git_commits_url":"https://api.github.com/repos/dgrove-oss/openwhisk/git/commits{/sha}","comments_url":"https://api.github.com/repos/dgrove-oss/openwhisk/comments{/number}","issue_comment_url":"https://api.github.com/repos/dgrove-oss/openwhisk/issues/comments{/number}","contents_url":"https://api.github.com/repos/dgrove-oss/openwhisk/contents/{+path}","compare_url":"https://api.github.com/repos/dgrove-oss/openwhisk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dgrove-oss/openwhisk/merges","archive_url":"https://api.github.com/repos/dgrove-oss/openwhisk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dgrove-oss/openwhisk/downloads","issues_url":"https://api.github.com/repos/dgrove-oss/openwhisk/issues{/number}","pulls_url":"https://api.github.com/repos/dgrove-oss/openwhisk/pulls{/number}","milestones_url":"https://api.github.com/repos/dgrove-oss/openwhisk/milestones{/number}","notifications_url":"https://api.github.com/repos/dgrove-oss/openwhisk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dgrove-oss/openwhisk/labels{/name}","releases_url":"https://api.github.com/repos/dgrove-oss/openwhisk/releases{/id}","deployments_url":"https://api.github.com/repos/dgrove-oss/openwhisk/deployments","created_at":"2017-05-09T20:32:41Z","updated_at":"2018-12-13T20:13:00Z","pushed_at":"2018-12-14T14:53:59Z","git_url":"git://github.com/dgrove-oss/openwhisk.git","ssh_url":"git@github.com:dgrove-oss/openwhisk.git","clone_url":"https://github.com/dgrove-oss/openwhisk.git","svn_url":"https://github.com/dgrove-oss/openwhisk","homepage":"http://openwhisk.org","size":63541,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"9f66633aa930547b0ea7caa36d4c46d935d6224d","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":52039373,"node_id":"MDEwOlJlcG9zaXRvcnk1MjAzOTM3Mw==","name":"incubator-openwhisk","full_name":"apache/incubator-openwhisk","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/incubator-openwhisk","description":"Apache OpenWhisk is a serverless event-based programming service and an Apache Incubator project.","fork":false,"url":"https://api.github.com/repos/apache/incubator-openwhisk","forks_url":"https://api.github.com/repos/apache/incubator-openwhisk/forks","keys_url":"https://api.github.com/repos/apache/incubator-openwhisk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-openwhisk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-openwhisk/teams","hooks_url":"https://api.github.com/repos/apache/incubator-openwhisk/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-openwhisk/events","assignees_url":"https://api.github.com/repos/apache/incubator-openwhisk/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-openwhisk/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-openwhisk/tags","blobs_url":"https://api.github.com/repos/apache/incubator-openwhisk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-openwhisk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-openwhisk/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-openwhisk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-openwhisk/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-openwhisk/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-openwhisk/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-openwhisk/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-openwhisk/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-openwhisk/subscription","commits_url":"https://api.github.com/repos/apache/incubator-openwhisk/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-openwhisk/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-openwhisk/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-openwhisk/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-openwhisk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-openwhisk/merges","archive_url":"https://api.github.com/repos/apache/incubator-openwhisk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-openwhisk/downloads","issues_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-openwhisk/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-openwhisk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-openwhisk/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-openwhisk/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-openwhisk/deployments","created_at":"2016-02-18T21:16:19Z","updated_at":"2018-12-14T11:48:06Z","pushed_at":"2018-12-14T14:54:01Z","git_url":"git://github.com/apache/incubator-openwhisk.git","ssh_url":"git@github.com:apache/incubator-openwhisk.git","clone_url":"https://github.com/apache/incubator-openwhisk.git","svn_url":"https://github.com/apache/incubator-openwhisk","homepage":"https://openwhisk.apache.org/ ","size":63508,"stargazers_count":3680,"watchers_count":3680,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":705,"mirror_url":null,"archived":false,"open_issues_count":431,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":705,"open_issues":431,"watchers":3680,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/4176"},"html":{"href":"https://github.com/apache/incubator-openwhisk/pull/4176"},"issue":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/issues/4176"},"comments":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/issues/4176/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/4176/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/4176/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/statuses/790979641a20e95c14440a4682b42177cbcf757d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dgrove-oss"}}