{"action":"created","comment":{"url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/pulls/comments/177393467","pull_request_review_id":107253123,"id":177393467,"diff_hunk":"@@ -7,15 +7,20 @@ function mandatorySelectionMessage() {\n }\n \n function emptyPostcodeMessage() {\n-  return 'You must enter a postcode to find the service you are looking for.';\n+  return 'You must enter a postcode.';\n }\n \n function invalidPostcodeMessage(location) {\n-  return `We can't find the postcode '${location}'. Check the postcode is correct and try again.`;\n+  return `We can't find the postcode '${location.toUpperCase()}'. Check the postcode is correct and try again.`;\n }\n \n function outsideOfEnglandPostcodeMessage() {\n-  return 'This is an England only service. Please enter an English postcode.';\n+  /* eslint-disable quotes */\n+  return `This postcode is not in England. Get help to find a chlamydia test in \\","path":"app/lib/messages.js","position":16,"original_position":16,"commit_id":"6742120d65f411a0d91350be00a6bdfa4ecacf31","original_commit_id":"9b4c860595cea683146aea20e1c3ead62fbcd060","user":{"login":"st3v3nhunt","id":639706,"avatar_url":"https://avatars0.githubusercontent.com/u/639706?v=4","gravatar_id":"","url":"https://api.github.com/users/st3v3nhunt","html_url":"https://github.com/st3v3nhunt","followers_url":"https://api.github.com/users/st3v3nhunt/followers","following_url":"https://api.github.com/users/st3v3nhunt/following{/other_user}","gists_url":"https://api.github.com/users/st3v3nhunt/gists{/gist_id}","starred_url":"https://api.github.com/users/st3v3nhunt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/st3v3nhunt/subscriptions","organizations_url":"https://api.github.com/users/st3v3nhunt/orgs","repos_url":"https://api.github.com/users/st3v3nhunt/repos","events_url":"https://api.github.com/users/st3v3nhunt/events{/privacy}","received_events_url":"https://api.github.com/users/st3v3nhunt/received_events","type":"User","site_admin":false},"body":"Whilst the pattern of having a simple string is in place, I'd say this should not be case when there is html elements being included within the message. There is going to be reduced or no support for static help such as syntax highlighting when the html is contained in a JS file compared to when it is within a view file. I'd like to see it moved into a view please.","created_at":"2018-03-27T11:39:14Z","updated_at":"2018-03-27T11:46:08Z","html_url":"https://github.com/nhsuk/sexual-health-service-finder/pull/17#discussion_r177393467","pull_request_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/pulls/17","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/pulls/comments/177393467"},"html":{"href":"https://github.com/nhsuk/sexual-health-service-finder/pull/17#discussion_r177393467"},"pull_request":{"href":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/pulls/17"}},"in_reply_to_id":177327637},"pull_request":{"url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/pulls/17","id":175328588,"html_url":"https://github.com/nhsuk/sexual-health-service-finder/pull/17","diff_url":"https://github.com/nhsuk/sexual-health-service-finder/pull/17.diff","patch_url":"https://github.com/nhsuk/sexual-health-service-finder/pull/17.patch","issue_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/issues/17","number":17,"state":"open","locked":false,"title":"Elasticsearch integration with location and results place","user":{"login":"beseven","id":1902266,"avatar_url":"https://avatars0.githubusercontent.com/u/1902266?v=4","gravatar_id":"","url":"https://api.github.com/users/beseven","html_url":"https://github.com/beseven","followers_url":"https://api.github.com/users/beseven/followers","following_url":"https://api.github.com/users/beseven/following{/other_user}","gists_url":"https://api.github.com/users/beseven/gists{/gist_id}","starred_url":"https://api.github.com/users/beseven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beseven/subscriptions","organizations_url":"https://api.github.com/users/beseven/orgs","repos_url":"https://api.github.com/users/beseven/repos","events_url":"https://api.github.com/users/beseven/events{/privacy}","received_events_url":"https://api.github.com/users/beseven/received_events","type":"User","site_admin":false},"body":"<!--\r\nThanks for wanting to contribute to this repository.\r\n\r\nIn order for the changes to be integrated into the repo with as little friction\r\nas possible please follow the guidance here. This includes completing all\r\nsections as fully as possible.\r\nPrior to creating a Pull Request, please ensure there is an open issue for the\r\nchanges you wish to make. This will provide visibility to others early in the\r\nprocess. Potentially other people will wish to help out. It also allows us to\r\nvalidate the change is inline with our vision for the product.\r\n\r\nProvide a general summary of your changes in the Title\r\n-->\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\nElasticsearch integration and results view\r\n\r\n## Related Issue\r\nhttps://jira.service.nhs.uk/browse/PCFC-126\r\nhttps://jira.service.nhs.uk/browse/PCFC-187\r\n\r\n<!--- This project only accepts pull requests related to open issues -->\r\n<!--- If suggesting a new feature or change, please discuss it in an issue first -->\r\n<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->\r\n<!--- Please link to the issue here: -->\r\n\r\n## Motivation and Context\r\nPart of the first slice for user journey for sexual health professionals and under 16th\r\n\r\n## Checklist\r\n<!-- Ensure each of the points below have been considered and completed where applicable -->\r\n- [x] An [ADR](http://thinkrelevance.com/blog/2011/11/15/documenting-architecture-decisions)\r\n- [x] New and/or updated tests\r\n- [x] Changes log in `CHANGELOG`\r\n","created_at":"2018-03-15T17:43:06Z","updated_at":"2018-03-27T11:46:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9500ccc5ba78e9fa4b3e497eb8f29c9b4a0cc46f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/pulls/17/commits","review_comments_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/pulls/17/comments","review_comment_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/issues/17/comments","statuses_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/statuses/6742120d65f411a0d91350be00a6bdfa4ecacf31","head":{"label":"nhsuk:feature/ES-integration","ref":"feature/ES-integration","sha":"6742120d65f411a0d91350be00a6bdfa4ecacf31","user":{"login":"nhsuk","id":18658529,"avatar_url":"https://avatars2.githubusercontent.com/u/18658529?v=4","gravatar_id":"","url":"https://api.github.com/users/nhsuk","html_url":"https://github.com/nhsuk","followers_url":"https://api.github.com/users/nhsuk/followers","following_url":"https://api.github.com/users/nhsuk/following{/other_user}","gists_url":"https://api.github.com/users/nhsuk/gists{/gist_id}","starred_url":"https://api.github.com/users/nhsuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhsuk/subscriptions","organizations_url":"https://api.github.com/users/nhsuk/orgs","repos_url":"https://api.github.com/users/nhsuk/repos","events_url":"https://api.github.com/users/nhsuk/events{/privacy}","received_events_url":"https://api.github.com/users/nhsuk/received_events","type":"Organization","site_admin":false},"repo":{"id":121743138,"name":"sexual-health-service-finder","full_name":"nhsuk/sexual-health-service-finder","owner":{"login":"nhsuk","id":18658529,"avatar_url":"https://avatars2.githubusercontent.com/u/18658529?v=4","gravatar_id":"","url":"https://api.github.com/users/nhsuk","html_url":"https://github.com/nhsuk","followers_url":"https://api.github.com/users/nhsuk/followers","following_url":"https://api.github.com/users/nhsuk/following{/other_user}","gists_url":"https://api.github.com/users/nhsuk/gists{/gist_id}","starred_url":"https://api.github.com/users/nhsuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhsuk/subscriptions","organizations_url":"https://api.github.com/users/nhsuk/orgs","repos_url":"https://api.github.com/users/nhsuk/repos","events_url":"https://api.github.com/users/nhsuk/events{/privacy}","received_events_url":"https://api.github.com/users/nhsuk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nhsuk/sexual-health-service-finder","description":"Helping to connect people to sexual health services.","fork":false,"url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder","forks_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/forks","keys_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/teams","hooks_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/hooks","issue_events_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/issues/events{/number}","events_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/events","assignees_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/assignees{/user}","branches_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/branches{/branch}","tags_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/tags","blobs_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/git/refs{/sha}","trees_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/statuses/{sha}","languages_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/languages","stargazers_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/stargazers","contributors_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/contributors","subscribers_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/subscribers","subscription_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/subscription","commits_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/commits{/sha}","git_commits_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/git/commits{/sha}","comments_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/comments{/number}","issue_comment_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/issues/comments{/number}","contents_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/contents/{+path}","compare_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/merges","archive_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/downloads","issues_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/issues{/number}","pulls_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/pulls{/number}","milestones_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/milestones{/number}","notifications_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/labels{/name}","releases_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/releases{/id}","deployments_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/deployments","created_at":"2018-02-16T11:23:57Z","updated_at":"2018-03-26T08:51:42Z","pushed_at":"2018-03-27T11:06:47Z","git_url":"git://github.com/nhsuk/sexual-health-service-finder.git","ssh_url":"git@github.com:nhsuk/sexual-health-service-finder.git","clone_url":"https://github.com/nhsuk/sexual-health-service-finder.git","svn_url":"https://github.com/nhsuk/sexual-health-service-finder","homepage":null,"size":655,"stargazers_count":1,"watchers_count":1,"language":"CSS","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":4,"watchers":1,"default_branch":"master"}},"base":{"label":"nhsuk:master","ref":"master","sha":"74118cdb71b517cadb81443f73f085ea1d9a8a54","user":{"login":"nhsuk","id":18658529,"avatar_url":"https://avatars2.githubusercontent.com/u/18658529?v=4","gravatar_id":"","url":"https://api.github.com/users/nhsuk","html_url":"https://github.com/nhsuk","followers_url":"https://api.github.com/users/nhsuk/followers","following_url":"https://api.github.com/users/nhsuk/following{/other_user}","gists_url":"https://api.github.com/users/nhsuk/gists{/gist_id}","starred_url":"https://api.github.com/users/nhsuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhsuk/subscriptions","organizations_url":"https://api.github.com/users/nhsuk/orgs","repos_url":"https://api.github.com/users/nhsuk/repos","events_url":"https://api.github.com/users/nhsuk/events{/privacy}","received_events_url":"https://api.github.com/users/nhsuk/received_events","type":"Organization","site_admin":false},"repo":{"id":121743138,"name":"sexual-health-service-finder","full_name":"nhsuk/sexual-health-service-finder","owner":{"login":"nhsuk","id":18658529,"avatar_url":"https://avatars2.githubusercontent.com/u/18658529?v=4","gravatar_id":"","url":"https://api.github.com/users/nhsuk","html_url":"https://github.com/nhsuk","followers_url":"https://api.github.com/users/nhsuk/followers","following_url":"https://api.github.com/users/nhsuk/following{/other_user}","gists_url":"https://api.github.com/users/nhsuk/gists{/gist_id}","starred_url":"https://api.github.com/users/nhsuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhsuk/subscriptions","organizations_url":"https://api.github.com/users/nhsuk/orgs","repos_url":"https://api.github.com/users/nhsuk/repos","events_url":"https://api.github.com/users/nhsuk/events{/privacy}","received_events_url":"https://api.github.com/users/nhsuk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nhsuk/sexual-health-service-finder","description":"Helping to connect people to sexual health services.","fork":false,"url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder","forks_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/forks","keys_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/teams","hooks_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/hooks","issue_events_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/issues/events{/number}","events_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/events","assignees_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/assignees{/user}","branches_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/branches{/branch}","tags_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/tags","blobs_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/git/refs{/sha}","trees_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/statuses/{sha}","languages_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/languages","stargazers_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/stargazers","contributors_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/contributors","subscribers_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/subscribers","subscription_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/subscription","commits_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/commits{/sha}","git_commits_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/git/commits{/sha}","comments_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/comments{/number}","issue_comment_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/issues/comments{/number}","contents_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/contents/{+path}","compare_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/merges","archive_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/downloads","issues_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/issues{/number}","pulls_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/pulls{/number}","milestones_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/milestones{/number}","notifications_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/labels{/name}","releases_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/releases{/id}","deployments_url":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/deployments","created_at":"2018-02-16T11:23:57Z","updated_at":"2018-03-26T08:51:42Z","pushed_at":"2018-03-27T11:06:47Z","git_url":"git://github.com/nhsuk/sexual-health-service-finder.git","ssh_url":"git@github.com:nhsuk/sexual-health-service-finder.git","clone_url":"https://github.com/nhsuk/sexual-health-service-finder.git","svn_url":"https://github.com/nhsuk/sexual-health-service-finder","homepage":null,"size":655,"stargazers_count":1,"watchers_count":1,"language":"CSS","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":4,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/pulls/17"},"html":{"href":"https://github.com/nhsuk/sexual-health-service-finder/pull/17"},"issue":{"href":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/issues/17"},"comments":{"href":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/nhsuk/sexual-health-service-finder/statuses/6742120d65f411a0d91350be00a6bdfa4ecacf31"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"st3v3nhunt"}}