{"action":"created","issue":{"url":"https://api.github.com/repos/status-im/status-react/issues/4919","repository_url":"https://api.github.com/repos/status-im/status-react","labels_url":"https://api.github.com/repos/status-im/status-react/issues/4919/labels{/name}","comments_url":"https://api.github.com/repos/status-im/status-react/issues/4919/comments","events_url":"https://api.github.com/repos/status-im/status-react/issues/4919/events","html_url":"https://github.com/status-im/status-react/pull/4919","id":335099135,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2OTAxMTY3","number":4919,"title":"[WIP] Fixes #3639 Persist browser history to allow to go back & forth when user returns to DApp","user":{"login":"pacamara","id":19371062,"node_id":"MDQ6VXNlcjE5MzcxMDYy","avatar_url":"https://avatars3.githubusercontent.com/u/19371062?v=4","gravatar_id":"","url":"https://api.github.com/users/pacamara","html_url":"https://github.com/pacamara","followers_url":"https://api.github.com/users/pacamara/followers","following_url":"https://api.github.com/users/pacamara/following{/other_user}","gists_url":"https://api.github.com/users/pacamara/gists{/gist_id}","starred_url":"https://api.github.com/users/pacamara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pacamara/subscriptions","organizations_url":"https://api.github.com/users/pacamara/orgs","repos_url":"https://api.github.com/users/pacamara/repos","events_url":"https://api.github.com/users/pacamara/events{/privacy}","received_events_url":"https://api.github.com/users/pacamara/received_events","type":"User","site_admin":false},"labels":[{"id":523025415,"node_id":"MDU6TGFiZWw1MjMwMjU0MTU=","url":"https://api.github.com/repos/status-im/status-react/labels/bounty","name":"bounty","color":"FAFAD2","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2018-06-23T13:04:18Z","updated_at":"2018-06-26T10:33:04Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/status-im/status-react/pulls/4919","html_url":"https://github.com/status-im/status-react/pull/4919","diff_url":"https://github.com/status-im/status-react/pull/4919.diff","patch_url":"https://github.com/status-im/status-react/pull/4919.patch"},"body":"Fixes #3639 Persist browser history to allow to go back & forth when user returns to DApp\r\n\r\n### Summary\r\n\r\n* Store `:history` and `:history-index` in browser.\r\n* Use for back/forward and ignore built-in back/forward of `WebView`.\r\n* `:history-index` is zero if user has not navigated back.\r\n* If user clicks link on old page, `:history` is truncated and new page added to it.\r\n\r\n### Review notes\r\nWIP but works already, only minor tweaks to do:\r\n* Prefer not to use `@forget-page-load` atom but don't see alternative.\r\n* More testing of DApps needed\r\n* Probably should get rid of obsolete `:browser/can-go-back?` and `:browser/can-go-forward?` options.\r\n\r\n### Steps to test:\r\n- Open Status, open browser and navigate to URL / Open DApp\r\n- Navigate forward few pages.\r\n- Close, reopen browser, verify history still navigable\r\n- Verify for old pages (go back to halfway thru history, close, reopen)\r\n- Verify history truncated correctly if user clicks link on old page\r\n\r\nstatus: wip (only minor tweaks remain, works already)\r\n"},"comment":{"url":"https://api.github.com/repos/status-im/status-react/issues/comments/400261053","html_url":"https://github.com/status-im/status-react/pull/4919#issuecomment-400261053","issue_url":"https://api.github.com/repos/status-im/status-react/issues/4919","id":400261053,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDI2MTA1Mw==","user":{"login":"pacamara","id":19371062,"node_id":"MDQ6VXNlcjE5MzcxMDYy","avatar_url":"https://avatars3.githubusercontent.com/u/19371062?v=4","gravatar_id":"","url":"https://api.github.com/users/pacamara","html_url":"https://github.com/pacamara","followers_url":"https://api.github.com/users/pacamara/followers","following_url":"https://api.github.com/users/pacamara/following{/other_user}","gists_url":"https://api.github.com/users/pacamara/gists{/gist_id}","starred_url":"https://api.github.com/users/pacamara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pacamara/subscriptions","organizations_url":"https://api.github.com/users/pacamara/orgs","repos_url":"https://api.github.com/users/pacamara/repos","events_url":"https://api.github.com/users/pacamara/events{/privacy}","received_events_url":"https://api.github.com/users/pacamara/received_events","type":"User","site_admin":false},"created_at":"2018-06-26T10:33:04Z","updated_at":"2018-06-26T10:33:04Z","author_association":"CONTRIBUTOR","body":"@flexsurfer Aha got it. So we just add that snippet to `resources/js/webview.js` right? Can we break this out into a separate bounty? It seems like fixing an existing bug that is related to but not part of the original bounty scope (and wasn't mentioned in the bounty description)."}}
{"actor":{"display_login":"pacamara"}}