{"action":"created","issue":{"url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/issues/2523","repository_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup","labels_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/issues/2523/labels{/name}","comments_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/issues/2523/comments","events_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/issues/2523/events","html_url":"https://github.com/RetroPie/RetroPie-Setup/pull/2523","id":374750833,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MzY0ODg0","number":2523,"title":"usbromservice - small fix in update hook and improve remove function","user":{"login":"hhromic","id":5802993,"node_id":"MDQ6VXNlcjU4MDI5OTM=","avatar_url":"https://avatars3.githubusercontent.com/u/5802993?v=4","gravatar_id":"","url":"https://api.github.com/users/hhromic","html_url":"https://github.com/hhromic","followers_url":"https://api.github.com/users/hhromic/followers","following_url":"https://api.github.com/users/hhromic/following{/other_user}","gists_url":"https://api.github.com/users/hhromic/gists{/gist_id}","starred_url":"https://api.github.com/users/hhromic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhromic/subscriptions","organizations_url":"https://api.github.com/users/hhromic/orgs","repos_url":"https://api.github.com/users/hhromic/repos","events_url":"https://api.github.com/users/hhromic/events{/privacy}","received_events_url":"https://api.github.com/users/hhromic/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-28T12:54:15Z","updated_at":"2018-10-29T15:36:26Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/pulls/2523","html_url":"https://github.com/RetroPie/RetroPie-Setup/pull/2523","diff_url":"https://github.com/RetroPie/RetroPie-Setup/pull/2523.diff","patch_url":"https://github.com/RetroPie/RetroPie-Setup/pull/2523.patch"},"body":"**PR summary:** do not run update hook if not installed and clean installed flag file on remove\r\n\r\nI observed the following error during updates when you don't have the `usbromservice` installed:\r\n```\r\n= = = = = = = = = = = = = = = = = = = = =\r\nRunning post update hooks\r\n= = = = = = = = = = = = = = = = = = = = =\r\n\r\n/home/hughro/RetroPie-Setup/scriptmodules/supplementary/usbromservice.sh: line 49: /etc/usbmount/mount.d/01_retropie_copyroms: No such file or directory\r\nchmod: cannot access '/etc/usbmount/mount.d/01_retropie_copyroms': No such file or directory\r\n/home/hughro/RetroPie-Setup/scriptmodules/supplementary/usbromservice.sh: line 49: /etc/usbmount/mount.d/10_retropie_mount: No such file or directory\r\nchmod: cannot access '/etc/usbmount/mount.d/10_retropie_mount': No such file or directory\r\n\r\nLog ended at: Sun Oct 28 12:39:48 GMT 2018\r\nTotal running time: 0 hours, 0 mins, 1 secs\r\n```\r\nIt appears very quickly between the *fetched latest* and *notice disclaimer* dialogs when you update the RetroPie script and you **don't have** the `usbromservice` module installed. It is easier to see using an ssh session where you can simply scroll-up your terminal.\r\n\r\nThe fix is simple: use the installed flag file feature introduced in commit e95bca3 to condition the execution of the update hook function. Btw, I also noticed that this flag file is not cleaned when removing the module, henceforth I quickly fixed that too."},"comment":{"url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/issues/comments/433958233","html_url":"https://github.com/RetroPie/RetroPie-Setup/pull/2523#issuecomment-433958233","issue_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/issues/2523","id":433958233,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzk1ODIzMw==","user":{"login":"joolswills","id":5365574,"node_id":"MDQ6VXNlcjUzNjU1NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5365574?v=4","gravatar_id":"","url":"https://api.github.com/users/joolswills","html_url":"https://github.com/joolswills","followers_url":"https://api.github.com/users/joolswills/followers","following_url":"https://api.github.com/users/joolswills/following{/other_user}","gists_url":"https://api.github.com/users/joolswills/gists{/gist_id}","starred_url":"https://api.github.com/users/joolswills/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joolswills/subscriptions","organizations_url":"https://api.github.com/users/joolswills/orgs","repos_url":"https://api.github.com/users/joolswills/repos","events_url":"https://api.github.com/users/joolswills/events{/privacy}","received_events_url":"https://api.github.com/users/joolswills/received_events","type":"User","site_admin":false},"created_at":"2018-10-29T15:36:26Z","updated_at":"2018-10-29T15:36:26Z","author_association":"MEMBER","body":"the installed file is only there to avoid the install directly from being removed afair. So the correct check is to use rp_isInstalled. should be no need to \"remove\" the installed file either. I will fix the hook up and check though."}}
{"actor":{"display_login":"joolswills"}}