{"action":"created","comment":{"url":"https://api.github.com/repos/moderntribe/events-gutenberg/pulls/comments/182231464","pull_request_review_id":112994234,"id":182231464,"diff_hunk":"@@ -101,37 +140,44 @@ class SearchPosts extends Component {\n \t\t);\n \t}\n \n-\trenderDropdown( { onToggle, isOpen, onClose } ) {\n-\t\tconst instanceId = uniqueId( 'search-' );\n-\t\tconst { searchLabel } = this.props;\n+\trenderDropdown = ( { onToggle, isOpen, onClose } ) => {\n \t\tthis.onClose = onClose.bind( this );\n \n \t\treturn (\n-\t\t\t<div className={ classNames( 'tribe-element-search-posts' ) }>\n-\t\t\t\t{\n-\t\t\t\t\t/**\n-\t\t\t\t\t * @todo We need to add Search Later on, for now it adds unecessary complexity\n-\t\t\t\t\t */\n-\t\t\t\t\t/*\n-\t\t\t\t\t\t<label htmlFor={ `editor-inserter__${ instanceId }` } className=\"screen-reader-text\">\n-\t\t\t\t\t\t\t{ searchLabel }\n-\t\t\t\t\t\t</label>\n-\t\t\t\t\t\t<input\n-\t\t\t\t\t\t\tid={ `editor-inserter__${ instanceId }` }\n-\t\t\t\t\t\t\ttype='search'\n-\t\t\t\t\t\t\tplaceholder={ searchLabel }\n-\t\t\t\t\t\t\tclassName='editor-inserter__search'\n-\t\t\t\t\t\t\tonChange={ ( event ) => console.log( event.target.value ) }\n-\t\t\t\t\t\t/>\n-\t\t\t\t\t */}\n-\t\t\t\t<div role=\"menu\" className={ classNames( 'tribe-element-search-posts-results' ) }>\n-\t\t\t\t\t{ this.renderList() }\n+\t\t\t<div className={classNames( 'tribe-element-search-posts' )} onScroll={this.onScroll}>\n+\t\t\t\t{this.renderSearchInput()}\n+\t\t\t\t<div role=\"menu\" className={classNames( 'tribe-element-search-posts-results' )}>\n+\t\t\t\t\t{this.renderList()}\n \t\t\t\t</div>\n \t\t\t</div>\n \t\t);\n \t}\n \n-\trenderToggle ( { onToggle, isOpen } ) {\n+\trenderSearchInput() {\n+\t\tconst { searchable, searchLabel } = this.props;\n+\t\tconst instanceId = uniqueId( 'search-' );\n+\n+\t\tif ( ! searchable ) {\n+\t\t\treturn null;\n+\t\t}\n+\n+\t\treturn <div>\n+\t\t\t<label htmlFor={`editor-inserter__${ instanceId }`} className=\"screen-reader-text\">","path":"src/modules/elements/search-posts/element.js","position":180,"original_position":180,"commit_id":"cff0fac792039e3fe2793531d4261dc6b8b94a7a","original_commit_id":"cff0fac792039e3fe2793531d4261dc6b8b94a7a","user":{"login":"bordoni","id":236579,"avatar_url":"https://avatars2.githubusercontent.com/u/236579?v=4","gravatar_id":"","url":"https://api.github.com/users/bordoni","html_url":"https://github.com/bordoni","followers_url":"https://api.github.com/users/bordoni/followers","following_url":"https://api.github.com/users/bordoni/following{/other_user}","gists_url":"https://api.github.com/users/bordoni/gists{/gist_id}","starred_url":"https://api.github.com/users/bordoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bordoni/subscriptions","organizations_url":"https://api.github.com/users/bordoni/orgs","repos_url":"https://api.github.com/users/bordoni/repos","events_url":"https://api.github.com/users/bordoni/events{/privacy}","received_events_url":"https://api.github.com/users/bordoni/received_events","type":"User","site_admin":false},"body":"Spacing around `{}`","created_at":"2018-04-17T20:58:05Z","updated_at":"2018-04-17T21:00:21Z","html_url":"https://github.com/moderntribe/events-gutenberg/pull/50#discussion_r182231464","pull_request_url":"https://api.github.com/repos/moderntribe/events-gutenberg/pulls/50","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/moderntribe/events-gutenberg/pulls/comments/182231464"},"html":{"href":"https://github.com/moderntribe/events-gutenberg/pull/50#discussion_r182231464"},"pull_request":{"href":"https://api.github.com/repos/moderntribe/events-gutenberg/pulls/50"}}},"pull_request":{"url":"https://api.github.com/repos/moderntribe/events-gutenberg/pulls/50","id":181934085,"html_url":"https://github.com/moderntribe/events-gutenberg/pull/50","diff_url":"https://github.com/moderntribe/events-gutenberg/pull/50.diff","patch_url":"https://github.com/moderntribe/events-gutenberg/pull/50.patch","issue_url":"https://api.github.com/repos/moderntribe/events-gutenberg/issues/50","number":50,"state":"open","locked":false,"title":"Add store implementations for Venues and Organizer","user":{"login":"mitogh","id":3921289,"avatar_url":"https://avatars1.githubusercontent.com/u/3921289?v=4","gravatar_id":"","url":"https://api.github.com/users/mitogh","html_url":"https://github.com/mitogh","followers_url":"https://api.github.com/users/mitogh/followers","following_url":"https://api.github.com/users/mitogh/following{/other_user}","gists_url":"https://api.github.com/users/mitogh/gists{/gist_id}","starred_url":"https://api.github.com/users/mitogh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitogh/subscriptions","organizations_url":"https://api.github.com/users/mitogh/orgs","repos_url":"https://api.github.com/users/mitogh/repos","events_url":"https://api.github.com/users/mitogh/events{/privacy}","received_events_url":"https://api.github.com/users/mitogh/received_events","type":"User","site_admin":false},"body":"With this change the data is stored in a store instead of the component as the components can be unmounted or removed from the virtual DOM,\nalso the stores are the ones in charge to perfom the requests for the next pages.","created_at":"2018-04-16T17:17:53Z","updated_at":"2018-04-17T21:00:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"705d53060b84c3ec537b097b43e192d9eac15dea","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":807884484,"url":"https://api.github.com/repos/moderntribe/events-gutenberg/labels/review:merge","name":"review:merge","color":"33aa3f","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/moderntribe/events-gutenberg/pulls/50/commits","review_comments_url":"https://api.github.com/repos/moderntribe/events-gutenberg/pulls/50/comments","review_comment_url":"https://api.github.com/repos/moderntribe/events-gutenberg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/moderntribe/events-gutenberg/issues/50/comments","statuses_url":"https://api.github.com/repos/moderntribe/events-gutenberg/statuses/cff0fac792039e3fe2793531d4261dc6b8b94a7a","head":{"label":"moderntribe:feature/102556-search-form","ref":"feature/102556-search-form","sha":"cff0fac792039e3fe2793531d4261dc6b8b94a7a","user":{"login":"moderntribe","id":2279551,"avatar_url":"https://avatars1.githubusercontent.com/u/2279551?v=4","gravatar_id":"","url":"https://api.github.com/users/moderntribe","html_url":"https://github.com/moderntribe","followers_url":"https://api.github.com/users/moderntribe/followers","following_url":"https://api.github.com/users/moderntribe/following{/other_user}","gists_url":"https://api.github.com/users/moderntribe/gists{/gist_id}","starred_url":"https://api.github.com/users/moderntribe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moderntribe/subscriptions","organizations_url":"https://api.github.com/users/moderntribe/orgs","repos_url":"https://api.github.com/users/moderntribe/repos","events_url":"https://api.github.com/users/moderntribe/events{/privacy}","received_events_url":"https://api.github.com/users/moderntribe/received_events","type":"Organization","site_admin":false},"repo":{"id":117871285,"name":"events-gutenberg","full_name":"moderntribe/events-gutenberg","owner":{"login":"moderntribe","id":2279551,"avatar_url":"https://avatars1.githubusercontent.com/u/2279551?v=4","gravatar_id":"","url":"https://api.github.com/users/moderntribe","html_url":"https://github.com/moderntribe","followers_url":"https://api.github.com/users/moderntribe/followers","following_url":"https://api.github.com/users/moderntribe/following{/other_user}","gists_url":"https://api.github.com/users/moderntribe/gists{/gist_id}","starred_url":"https://api.github.com/users/moderntribe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moderntribe/subscriptions","organizations_url":"https://api.github.com/users/moderntribe/orgs","repos_url":"https://api.github.com/users/moderntribe/repos","events_url":"https://api.github.com/users/moderntribe/events{/privacy}","received_events_url":"https://api.github.com/users/moderntribe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moderntribe/events-gutenberg","description":null,"fork":false,"url":"https://api.github.com/repos/moderntribe/events-gutenberg","forks_url":"https://api.github.com/repos/moderntribe/events-gutenberg/forks","keys_url":"https://api.github.com/repos/moderntribe/events-gutenberg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moderntribe/events-gutenberg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moderntribe/events-gutenberg/teams","hooks_url":"https://api.github.com/repos/moderntribe/events-gutenberg/hooks","issue_events_url":"https://api.github.com/repos/moderntribe/events-gutenberg/issues/events{/number}","events_url":"https://api.github.com/repos/moderntribe/events-gutenberg/events","assignees_url":"https://api.github.com/repos/moderntribe/events-gutenberg/assignees{/user}","branches_url":"https://api.github.com/repos/moderntribe/events-gutenberg/branches{/branch}","tags_url":"https://api.github.com/repos/moderntribe/events-gutenberg/tags","blobs_url":"https://api.github.com/repos/moderntribe/events-gutenberg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moderntribe/events-gutenberg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moderntribe/events-gutenberg/git/refs{/sha}","trees_url":"https://api.github.com/repos/moderntribe/events-gutenberg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moderntribe/events-gutenberg/statuses/{sha}","languages_url":"https://api.github.com/repos/moderntribe/events-gutenberg/languages","stargazers_url":"https://api.github.com/repos/moderntribe/events-gutenberg/stargazers","contributors_url":"https://api.github.com/repos/moderntribe/events-gutenberg/contributors","subscribers_url":"https://api.github.com/repos/moderntribe/events-gutenberg/subscribers","subscription_url":"https://api.github.com/repos/moderntribe/events-gutenberg/subscription","commits_url":"https://api.github.com/repos/moderntribe/events-gutenberg/commits{/sha}","git_commits_url":"https://api.github.com/repos/moderntribe/events-gutenberg/git/commits{/sha}","comments_url":"https://api.github.com/repos/moderntribe/events-gutenberg/comments{/number}","issue_comment_url":"https://api.github.com/repos/moderntribe/events-gutenberg/issues/comments{/number}","contents_url":"https://api.github.com/repos/moderntribe/events-gutenberg/contents/{+path}","compare_url":"https://api.github.com/repos/moderntribe/events-gutenberg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moderntribe/events-gutenberg/merges","archive_url":"https://api.github.com/repos/moderntribe/events-gutenberg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moderntribe/events-gutenberg/downloads","issues_url":"https://api.github.com/repos/moderntribe/events-gutenberg/issues{/number}","pulls_url":"https://api.github.com/repos/moderntribe/events-gutenberg/pulls{/number}","milestones_url":"https://api.github.com/repos/moderntribe/events-gutenberg/milestones{/number}","notifications_url":"https://api.github.com/repos/moderntribe/events-gutenberg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moderntribe/events-gutenberg/labels{/name}","releases_url":"https://api.github.com/repos/moderntribe/events-gutenberg/releases{/id}","deployments_url":"https://api.github.com/repos/moderntribe/events-gutenberg/deployments","created_at":"2018-01-17T17:46:47Z","updated_at":"2018-04-16T17:52:04Z","pushed_at":"2018-04-17T19:59:30Z","git_url":"git://github.com/moderntribe/events-gutenberg.git","ssh_url":"git@github.com:moderntribe/events-gutenberg.git","clone_url":"https://github.com/moderntribe/events-gutenberg.git","svn_url":"https://github.com/moderntribe/events-gutenberg","homepage":"https://theeventscalendar.com/extensions/events-gutenberg/","size":573,"stargazers_count":12,"watchers_count":12,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":12,"watchers":12,"default_branch":"master"}},"base":{"label":"moderntribe:master","ref":"master","sha":"48b26de6de0aadb7d7a3abf45e7ea2ceaecb343e","user":{"login":"moderntribe","id":2279551,"avatar_url":"https://avatars1.githubusercontent.com/u/2279551?v=4","gravatar_id":"","url":"https://api.github.com/users/moderntribe","html_url":"https://github.com/moderntribe","followers_url":"https://api.github.com/users/moderntribe/followers","following_url":"https://api.github.com/users/moderntribe/following{/other_user}","gists_url":"https://api.github.com/users/moderntribe/gists{/gist_id}","starred_url":"https://api.github.com/users/moderntribe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moderntribe/subscriptions","organizations_url":"https://api.github.com/users/moderntribe/orgs","repos_url":"https://api.github.com/users/moderntribe/repos","events_url":"https://api.github.com/users/moderntribe/events{/privacy}","received_events_url":"https://api.github.com/users/moderntribe/received_events","type":"Organization","site_admin":false},"repo":{"id":117871285,"name":"events-gutenberg","full_name":"moderntribe/events-gutenberg","owner":{"login":"moderntribe","id":2279551,"avatar_url":"https://avatars1.githubusercontent.com/u/2279551?v=4","gravatar_id":"","url":"https://api.github.com/users/moderntribe","html_url":"https://github.com/moderntribe","followers_url":"https://api.github.com/users/moderntribe/followers","following_url":"https://api.github.com/users/moderntribe/following{/other_user}","gists_url":"https://api.github.com/users/moderntribe/gists{/gist_id}","starred_url":"https://api.github.com/users/moderntribe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moderntribe/subscriptions","organizations_url":"https://api.github.com/users/moderntribe/orgs","repos_url":"https://api.github.com/users/moderntribe/repos","events_url":"https://api.github.com/users/moderntribe/events{/privacy}","received_events_url":"https://api.github.com/users/moderntribe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moderntribe/events-gutenberg","description":null,"fork":false,"url":"https://api.github.com/repos/moderntribe/events-gutenberg","forks_url":"https://api.github.com/repos/moderntribe/events-gutenberg/forks","keys_url":"https://api.github.com/repos/moderntribe/events-gutenberg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moderntribe/events-gutenberg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moderntribe/events-gutenberg/teams","hooks_url":"https://api.github.com/repos/moderntribe/events-gutenberg/hooks","issue_events_url":"https://api.github.com/repos/moderntribe/events-gutenberg/issues/events{/number}","events_url":"https://api.github.com/repos/moderntribe/events-gutenberg/events","assignees_url":"https://api.github.com/repos/moderntribe/events-gutenberg/assignees{/user}","branches_url":"https://api.github.com/repos/moderntribe/events-gutenberg/branches{/branch}","tags_url":"https://api.github.com/repos/moderntribe/events-gutenberg/tags","blobs_url":"https://api.github.com/repos/moderntribe/events-gutenberg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moderntribe/events-gutenberg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moderntribe/events-gutenberg/git/refs{/sha}","trees_url":"https://api.github.com/repos/moderntribe/events-gutenberg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moderntribe/events-gutenberg/statuses/{sha}","languages_url":"https://api.github.com/repos/moderntribe/events-gutenberg/languages","stargazers_url":"https://api.github.com/repos/moderntribe/events-gutenberg/stargazers","contributors_url":"https://api.github.com/repos/moderntribe/events-gutenberg/contributors","subscribers_url":"https://api.github.com/repos/moderntribe/events-gutenberg/subscribers","subscription_url":"https://api.github.com/repos/moderntribe/events-gutenberg/subscription","commits_url":"https://api.github.com/repos/moderntribe/events-gutenberg/commits{/sha}","git_commits_url":"https://api.github.com/repos/moderntribe/events-gutenberg/git/commits{/sha}","comments_url":"https://api.github.com/repos/moderntribe/events-gutenberg/comments{/number}","issue_comment_url":"https://api.github.com/repos/moderntribe/events-gutenberg/issues/comments{/number}","contents_url":"https://api.github.com/repos/moderntribe/events-gutenberg/contents/{+path}","compare_url":"https://api.github.com/repos/moderntribe/events-gutenberg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moderntribe/events-gutenberg/merges","archive_url":"https://api.github.com/repos/moderntribe/events-gutenberg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moderntribe/events-gutenberg/downloads","issues_url":"https://api.github.com/repos/moderntribe/events-gutenberg/issues{/number}","pulls_url":"https://api.github.com/repos/moderntribe/events-gutenberg/pulls{/number}","milestones_url":"https://api.github.com/repos/moderntribe/events-gutenberg/milestones{/number}","notifications_url":"https://api.github.com/repos/moderntribe/events-gutenberg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moderntribe/events-gutenberg/labels{/name}","releases_url":"https://api.github.com/repos/moderntribe/events-gutenberg/releases{/id}","deployments_url":"https://api.github.com/repos/moderntribe/events-gutenberg/deployments","created_at":"2018-01-17T17:46:47Z","updated_at":"2018-04-16T17:52:04Z","pushed_at":"2018-04-17T19:59:30Z","git_url":"git://github.com/moderntribe/events-gutenberg.git","ssh_url":"git@github.com:moderntribe/events-gutenberg.git","clone_url":"https://github.com/moderntribe/events-gutenberg.git","svn_url":"https://github.com/moderntribe/events-gutenberg","homepage":"https://theeventscalendar.com/extensions/events-gutenberg/","size":573,"stargazers_count":12,"watchers_count":12,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":12,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/moderntribe/events-gutenberg/pulls/50"},"html":{"href":"https://github.com/moderntribe/events-gutenberg/pull/50"},"issue":{"href":"https://api.github.com/repos/moderntribe/events-gutenberg/issues/50"},"comments":{"href":"https://api.github.com/repos/moderntribe/events-gutenberg/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/moderntribe/events-gutenberg/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/moderntribe/events-gutenberg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/moderntribe/events-gutenberg/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/moderntribe/events-gutenberg/statuses/cff0fac792039e3fe2793531d4261dc6b8b94a7a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"bordoni"}}