{"action":"created","issue":{"url":"https://api.github.com/repos/aws/aws-xray-sdk-python/issues/29","repository_url":"https://api.github.com/repos/aws/aws-xray-sdk-python","labels_url":"https://api.github.com/repos/aws/aws-xray-sdk-python/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/aws/aws-xray-sdk-python/issues/29/comments","events_url":"https://api.github.com/repos/aws/aws-xray-sdk-python/issues/29/events","html_url":"https://github.com/aws/aws-xray-sdk-python/pull/29","id":301561624,"number":29,"title":"Use the official middleware pattern for Aiohttp ext","user":{"login":"pfreixes","id":1226121,"avatar_url":"https://avatars0.githubusercontent.com/u/1226121?v=4","gravatar_id":"","url":"https://api.github.com/users/pfreixes","html_url":"https://github.com/pfreixes","followers_url":"https://api.github.com/users/pfreixes/followers","following_url":"https://api.github.com/users/pfreixes/following{/other_user}","gists_url":"https://api.github.com/users/pfreixes/gists{/gist_id}","starred_url":"https://api.github.com/users/pfreixes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfreixes/subscriptions","organizations_url":"https://api.github.com/users/pfreixes/orgs","repos_url":"https://api.github.com/users/pfreixes/repos","events_url":"https://api.github.com/users/pfreixes/events{/privacy}","received_events_url":"https://api.github.com/users/pfreixes/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-03-01T21:14:06Z","updated_at":"2018-03-02T19:55:37Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/aws/aws-xray-sdk-python/pulls/29","html_url":"https://github.com/aws/aws-xray-sdk-python/pull/29","diff_url":"https://github.com/aws/aws-xray-sdk-python/pull/29.diff","patch_url":"https://github.com/aws/aws-xray-sdk-python/pull/29.patch"},"body":"The previous implementation was using the former version of Aiohttp that\r\ngot deprecated since 2.3.0. Related to #28.\r\n\r\nThe interface didn't change, so from the point of the view of the user, it does not suppose a breaking change. I would suggest using a minor release."},"comment":{"url":"https://api.github.com/repos/aws/aws-xray-sdk-python/issues/comments/370035003","html_url":"https://github.com/aws/aws-xray-sdk-python/pull/29#issuecomment-370035003","issue_url":"https://api.github.com/repos/aws/aws-xray-sdk-python/issues/29","id":370035003,"user":{"login":"haotianw465","id":3795229,"avatar_url":"https://avatars3.githubusercontent.com/u/3795229?v=4","gravatar_id":"","url":"https://api.github.com/users/haotianw465","html_url":"https://github.com/haotianw465","followers_url":"https://api.github.com/users/haotianw465/followers","following_url":"https://api.github.com/users/haotianw465/following{/other_user}","gists_url":"https://api.github.com/users/haotianw465/gists{/gist_id}","starred_url":"https://api.github.com/users/haotianw465/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haotianw465/subscriptions","organizations_url":"https://api.github.com/users/haotianw465/orgs","repos_url":"https://api.github.com/users/haotianw465/repos","events_url":"https://api.github.com/users/haotianw465/events{/privacy}","received_events_url":"https://api.github.com/users/haotianw465/received_events","type":"User","site_admin":false},"created_at":"2018-03-02T19:55:37Z","updated_at":"2018-03-02T19:55:37Z","author_association":"CONTRIBUTOR","body":"I totally understand what you are saying. The issue is not about whether they upgrade to 2.3 or 3.x, it is about when. We cannot assume upgrading `aiohttp` is at top priorities for all of our customers who depend on `aiohttp`. And a minor release with this also breaks `semver` convention and the expectations on minor upgrade.\r\n\r\nWe definitely want the `aiohttp` support to use the best practices. I purpose to copy the current middleware to another class and make necessary changes, and then note the old one is deprecated. In the user guide and `README` we can advertising only the new class.\r\n\r\nThis way whoever new to X-Ray and have `aiohttp` 2.3+ can always get the latest and greatest, and existing X-Ray users running older `aiohttp` can upgrade X-Ray SDK freely. \r\n\r\nPlease let me know your thoughts."}}
{"actor":{"display_login":"haotianw465"}}