{"action":"created","comment":{"url":"https://api.github.com/repos/SpongePowered/Ore/pulls/comments/202552941","pull_request_review_id":137276885,"id":202552941,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjU1Mjk0MQ==","diff_hunk":"@@ -309,7 +309,11 @@ final class ApiController @Inject()(api: OreRestfulApi,\n               if (groups.trim == \"\")\n                 Set.empty\n               else\n-                groups.split(\",\").map(group => RoleTypes.withInternalName(group)).toSet[RoleType]\n+                groups.split(\",\")\n+                  .map(group => RoleTypes.withInternalName(group))\n+                  .filter(group => group.nonEmpty)","path":"app/controllers/ApiController.scala","position":7,"original_position":7,"commit_id":"2ab4e18a91f5387fb713168bb86fe7d5589a9362","original_commit_id":"2ab4e18a91f5387fb713168bb86fe7d5589a9362","user":{"login":"Katrix","id":11007080,"node_id":"MDQ6VXNlcjExMDA3MDgw","avatar_url":"https://avatars3.githubusercontent.com/u/11007080?v=4","gravatar_id":"","url":"https://api.github.com/users/Katrix","html_url":"https://github.com/Katrix","followers_url":"https://api.github.com/users/Katrix/followers","following_url":"https://api.github.com/users/Katrix/following{/other_user}","gists_url":"https://api.github.com/users/Katrix/gists{/gist_id}","starred_url":"https://api.github.com/users/Katrix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Katrix/subscriptions","organizations_url":"https://api.github.com/users/Katrix/orgs","repos_url":"https://api.github.com/users/Katrix/repos","events_url":"https://api.github.com/users/Katrix/events{/privacy}","received_events_url":"https://api.github.com/users/Katrix/received_events","type":"User","site_admin":false},"body":"Use flatMap here instead of filter + map, or use collect","created_at":"2018-07-15T20:07:55Z","updated_at":"2018-07-15T20:07:55Z","html_url":"https://github.com/SpongePowered/Ore/pull/572#discussion_r202552941","pull_request_url":"https://api.github.com/repos/SpongePowered/Ore/pulls/572","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/SpongePowered/Ore/pulls/comments/202552941"},"html":{"href":"https://github.com/SpongePowered/Ore/pull/572#discussion_r202552941"},"pull_request":{"href":"https://api.github.com/repos/SpongePowered/Ore/pulls/572"}}},"pull_request":{"url":"https://api.github.com/repos/SpongePowered/Ore/pulls/572","id":201512332,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNTEyMzMy","html_url":"https://github.com/SpongePowered/Ore/pull/572","diff_url":"https://github.com/SpongePowered/Ore/pull/572.diff","patch_url":"https://github.com/SpongePowered/Ore/pull/572.patch","issue_url":"https://api.github.com/repos/SpongePowered/Ore/issues/572","number":572,"state":"open","locked":false,"title":"don't require all groups to exist in RoleTypes","user":{"login":"kashike","id":5474071,"node_id":"MDQ6VXNlcjU0NzQwNzE=","avatar_url":"https://avatars0.githubusercontent.com/u/5474071?v=4","gravatar_id":"","url":"https://api.github.com/users/kashike","html_url":"https://github.com/kashike","followers_url":"https://api.github.com/users/kashike/followers","following_url":"https://api.github.com/users/kashike/following{/other_user}","gists_url":"https://api.github.com/users/kashike/gists{/gist_id}","starred_url":"https://api.github.com/users/kashike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kashike/subscriptions","organizations_url":"https://api.github.com/users/kashike/orgs","repos_url":"https://api.github.com/users/kashike/repos","events_url":"https://api.github.com/users/kashike/events{/privacy}","received_events_url":"https://api.github.com/users/kashike/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-15T19:43:52Z","updated_at":"2018-07-15T20:07:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e69551caf4e3a0f966613790f1016fddeffec13","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SpongePowered/Ore/pulls/572/commits","review_comments_url":"https://api.github.com/repos/SpongePowered/Ore/pulls/572/comments","review_comment_url":"https://api.github.com/repos/SpongePowered/Ore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SpongePowered/Ore/issues/572/comments","statuses_url":"https://api.github.com/repos/SpongePowered/Ore/statuses/2ab4e18a91f5387fb713168bb86fe7d5589a9362","head":{"label":"SpongePowered:fix/groups","ref":"fix/groups","sha":"2ab4e18a91f5387fb713168bb86fe7d5589a9362","user":{"login":"SpongePowered","id":8683473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2ODM0NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/8683473?v=4","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"repo":{"id":52847258,"node_id":"MDEwOlJlcG9zaXRvcnk1Mjg0NzI1OA==","name":"Ore","full_name":"SpongePowered/Ore","owner":{"login":"SpongePowered","id":8683473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2ODM0NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/8683473?v=4","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpongePowered/Ore","description":"Repository software for Sponge plugins and Forge mods","fork":false,"url":"https://api.github.com/repos/SpongePowered/Ore","forks_url":"https://api.github.com/repos/SpongePowered/Ore/forks","keys_url":"https://api.github.com/repos/SpongePowered/Ore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpongePowered/Ore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpongePowered/Ore/teams","hooks_url":"https://api.github.com/repos/SpongePowered/Ore/hooks","issue_events_url":"https://api.github.com/repos/SpongePowered/Ore/issues/events{/number}","events_url":"https://api.github.com/repos/SpongePowered/Ore/events","assignees_url":"https://api.github.com/repos/SpongePowered/Ore/assignees{/user}","branches_url":"https://api.github.com/repos/SpongePowered/Ore/branches{/branch}","tags_url":"https://api.github.com/repos/SpongePowered/Ore/tags","blobs_url":"https://api.github.com/repos/SpongePowered/Ore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpongePowered/Ore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpongePowered/Ore/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpongePowered/Ore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpongePowered/Ore/statuses/{sha}","languages_url":"https://api.github.com/repos/SpongePowered/Ore/languages","stargazers_url":"https://api.github.com/repos/SpongePowered/Ore/stargazers","contributors_url":"https://api.github.com/repos/SpongePowered/Ore/contributors","subscribers_url":"https://api.github.com/repos/SpongePowered/Ore/subscribers","subscription_url":"https://api.github.com/repos/SpongePowered/Ore/subscription","commits_url":"https://api.github.com/repos/SpongePowered/Ore/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpongePowered/Ore/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpongePowered/Ore/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpongePowered/Ore/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpongePowered/Ore/contents/{+path}","compare_url":"https://api.github.com/repos/SpongePowered/Ore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpongePowered/Ore/merges","archive_url":"https://api.github.com/repos/SpongePowered/Ore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpongePowered/Ore/downloads","issues_url":"https://api.github.com/repos/SpongePowered/Ore/issues{/number}","pulls_url":"https://api.github.com/repos/SpongePowered/Ore/pulls{/number}","milestones_url":"https://api.github.com/repos/SpongePowered/Ore/milestones{/number}","notifications_url":"https://api.github.com/repos/SpongePowered/Ore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpongePowered/Ore/labels{/name}","releases_url":"https://api.github.com/repos/SpongePowered/Ore/releases{/id}","deployments_url":"https://api.github.com/repos/SpongePowered/Ore/deployments","created_at":"2016-03-01T04:12:53Z","updated_at":"2018-07-15T19:45:29Z","pushed_at":"2018-07-15T20:00:01Z","git_url":"git://github.com/SpongePowered/Ore.git","ssh_url":"git@github.com:SpongePowered/Ore.git","clone_url":"https://github.com/SpongePowered/Ore.git","svn_url":"https://github.com/SpongePowered/Ore","homepage":"https://ore.spongepowered.org/","size":5951,"stargazers_count":43,"watchers_count":43,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":109,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":22,"open_issues":109,"watchers":43,"default_branch":"master"}},"base":{"label":"SpongePowered:master","ref":"master","sha":"390927d3bbaea12b47e3117393178d47a7893464","user":{"login":"SpongePowered","id":8683473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2ODM0NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/8683473?v=4","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"repo":{"id":52847258,"node_id":"MDEwOlJlcG9zaXRvcnk1Mjg0NzI1OA==","name":"Ore","full_name":"SpongePowered/Ore","owner":{"login":"SpongePowered","id":8683473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2ODM0NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/8683473?v=4","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpongePowered/Ore","description":"Repository software for Sponge plugins and Forge mods","fork":false,"url":"https://api.github.com/repos/SpongePowered/Ore","forks_url":"https://api.github.com/repos/SpongePowered/Ore/forks","keys_url":"https://api.github.com/repos/SpongePowered/Ore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpongePowered/Ore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpongePowered/Ore/teams","hooks_url":"https://api.github.com/repos/SpongePowered/Ore/hooks","issue_events_url":"https://api.github.com/repos/SpongePowered/Ore/issues/events{/number}","events_url":"https://api.github.com/repos/SpongePowered/Ore/events","assignees_url":"https://api.github.com/repos/SpongePowered/Ore/assignees{/user}","branches_url":"https://api.github.com/repos/SpongePowered/Ore/branches{/branch}","tags_url":"https://api.github.com/repos/SpongePowered/Ore/tags","blobs_url":"https://api.github.com/repos/SpongePowered/Ore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpongePowered/Ore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpongePowered/Ore/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpongePowered/Ore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpongePowered/Ore/statuses/{sha}","languages_url":"https://api.github.com/repos/SpongePowered/Ore/languages","stargazers_url":"https://api.github.com/repos/SpongePowered/Ore/stargazers","contributors_url":"https://api.github.com/repos/SpongePowered/Ore/contributors","subscribers_url":"https://api.github.com/repos/SpongePowered/Ore/subscribers","subscription_url":"https://api.github.com/repos/SpongePowered/Ore/subscription","commits_url":"https://api.github.com/repos/SpongePowered/Ore/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpongePowered/Ore/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpongePowered/Ore/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpongePowered/Ore/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpongePowered/Ore/contents/{+path}","compare_url":"https://api.github.com/repos/SpongePowered/Ore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpongePowered/Ore/merges","archive_url":"https://api.github.com/repos/SpongePowered/Ore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpongePowered/Ore/downloads","issues_url":"https://api.github.com/repos/SpongePowered/Ore/issues{/number}","pulls_url":"https://api.github.com/repos/SpongePowered/Ore/pulls{/number}","milestones_url":"https://api.github.com/repos/SpongePowered/Ore/milestones{/number}","notifications_url":"https://api.github.com/repos/SpongePowered/Ore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpongePowered/Ore/labels{/name}","releases_url":"https://api.github.com/repos/SpongePowered/Ore/releases{/id}","deployments_url":"https://api.github.com/repos/SpongePowered/Ore/deployments","created_at":"2016-03-01T04:12:53Z","updated_at":"2018-07-15T19:45:29Z","pushed_at":"2018-07-15T20:00:01Z","git_url":"git://github.com/SpongePowered/Ore.git","ssh_url":"git@github.com:SpongePowered/Ore.git","clone_url":"https://github.com/SpongePowered/Ore.git","svn_url":"https://github.com/SpongePowered/Ore","homepage":"https://ore.spongepowered.org/","size":5951,"stargazers_count":43,"watchers_count":43,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":109,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":22,"open_issues":109,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SpongePowered/Ore/pulls/572"},"html":{"href":"https://github.com/SpongePowered/Ore/pull/572"},"issue":{"href":"https://api.github.com/repos/SpongePowered/Ore/issues/572"},"comments":{"href":"https://api.github.com/repos/SpongePowered/Ore/issues/572/comments"},"review_comments":{"href":"https://api.github.com/repos/SpongePowered/Ore/pulls/572/comments"},"review_comment":{"href":"https://api.github.com/repos/SpongePowered/Ore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SpongePowered/Ore/pulls/572/commits"},"statuses":{"href":"https://api.github.com/repos/SpongePowered/Ore/statuses/2ab4e18a91f5387fb713168bb86fe7d5589a9362"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Katrix"}}