{"action":"created","comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/pulls/comments/196842465","pull_request_review_id":130471775,"id":196842465,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Njg0MjQ2NQ==","diff_hunk":"@@ -425,16 +466,6 @@ public void eurekaClientClosed() {\n \t\t}\n \t}\n \n-\t@Test\n-\tpublic void eurekaRegistrationClosed() throws IOException {","path":"spring-cloud-netflix-eureka-client/src/test/java/org/springframework/cloud/netflix/eureka/EurekaClientAutoConfigurationTests.java","position":94,"original_position":94,"commit_id":"616e901e1b1fc9b94d243669e1abd8a5a2e3878b","original_commit_id":"616e901e1b1fc9b94d243669e1abd8a5a2e3878b","user":{"login":"tdanylchuk","id":3741358,"node_id":"MDQ6VXNlcjM3NDEzNTg=","avatar_url":"https://avatars2.githubusercontent.com/u/3741358?v=4","gravatar_id":"","url":"https://api.github.com/users/tdanylchuk","html_url":"https://github.com/tdanylchuk","followers_url":"https://api.github.com/users/tdanylchuk/followers","following_url":"https://api.github.com/users/tdanylchuk/following{/other_user}","gists_url":"https://api.github.com/users/tdanylchuk/gists{/gist_id}","starred_url":"https://api.github.com/users/tdanylchuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdanylchuk/subscriptions","organizations_url":"https://api.github.com/users/tdanylchuk/orgs","repos_url":"https://api.github.com/users/tdanylchuk/repos","events_url":"https://api.github.com/users/tdanylchuk/events{/privacy}","received_events_url":"https://api.github.com/users/tdanylchuk/received_events","type":"User","site_admin":false},"body":"test is being moved to ```shouldCloseDiscoveryClient``` since `EurekaRegistration` is not closing DiscoveryClient anymore","created_at":"2018-06-20T16:06:46Z","updated_at":"2018-06-20T16:08:46Z","html_url":"https://github.com/spring-cloud/spring-cloud-netflix/pull/3018#discussion_r196842465","pull_request_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/pulls/3018","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/pulls/comments/196842465"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-netflix/pull/3018#discussion_r196842465"},"pull_request":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/pulls/3018"}},"in_reply_to_id":196840247},"pull_request":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/pulls/3018","id":196189117,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MTg5MTE3","html_url":"https://github.com/spring-cloud/spring-cloud-netflix/pull/3018","diff_url":"https://github.com/spring-cloud/spring-cloud-netflix/pull/3018.diff","patch_url":"https://github.com/spring-cloud/spring-cloud-netflix/pull/3018.patch","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/issues/3018","number":3018,"state":"open","locked":false,"title":"fixes permanently down after refresh","user":{"login":"tdanylchuk","id":3741358,"node_id":"MDQ6VXNlcjM3NDEzNTg=","avatar_url":"https://avatars2.githubusercontent.com/u/3741358?v=4","gravatar_id":"","url":"https://api.github.com/users/tdanylchuk","html_url":"https://github.com/tdanylchuk","followers_url":"https://api.github.com/users/tdanylchuk/followers","following_url":"https://api.github.com/users/tdanylchuk/following{/other_user}","gists_url":"https://api.github.com/users/tdanylchuk/gists{/gist_id}","starred_url":"https://api.github.com/users/tdanylchuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdanylchuk/subscriptions","organizations_url":"https://api.github.com/users/tdanylchuk/orgs","repos_url":"https://api.github.com/users/tdanylchuk/repos","events_url":"https://api.github.com/users/tdanylchuk/events{/privacy}","received_events_url":"https://api.github.com/users/tdanylchuk/received_events","type":"User","site_admin":false},"body":"root cause:\r\ncached bean trying to re-register\r\nresolution summary:\r\nget re-created bean from context to re-register\r\n\r\nFixes #2972","created_at":"2018-06-20T15:52:38Z","updated_at":"2018-06-20T16:08:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0d08f2d54a7f97d6fcef4111dccde53e7a03507","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/pulls/3018/commits","review_comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/pulls/3018/comments","review_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/issues/3018/comments","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/statuses/616e901e1b1fc9b94d243669e1abd8a5a2e3878b","head":{"label":"tdanylchuk:1.4.x-fix-gh-2972","ref":"1.4.x-fix-gh-2972","sha":"616e901e1b1fc9b94d243669e1abd8a5a2e3878b","user":{"login":"tdanylchuk","id":3741358,"node_id":"MDQ6VXNlcjM3NDEzNTg=","avatar_url":"https://avatars2.githubusercontent.com/u/3741358?v=4","gravatar_id":"","url":"https://api.github.com/users/tdanylchuk","html_url":"https://github.com/tdanylchuk","followers_url":"https://api.github.com/users/tdanylchuk/followers","following_url":"https://api.github.com/users/tdanylchuk/following{/other_user}","gists_url":"https://api.github.com/users/tdanylchuk/gists{/gist_id}","starred_url":"https://api.github.com/users/tdanylchuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdanylchuk/subscriptions","organizations_url":"https://api.github.com/users/tdanylchuk/orgs","repos_url":"https://api.github.com/users/tdanylchuk/repos","events_url":"https://api.github.com/users/tdanylchuk/events{/privacy}","received_events_url":"https://api.github.com/users/tdanylchuk/received_events","type":"User","site_admin":false},"repo":{"id":135621999,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU2MjE5OTk=","name":"spring-cloud-netflix","full_name":"tdanylchuk/spring-cloud-netflix","owner":{"login":"tdanylchuk","id":3741358,"node_id":"MDQ6VXNlcjM3NDEzNTg=","avatar_url":"https://avatars2.githubusercontent.com/u/3741358?v=4","gravatar_id":"","url":"https://api.github.com/users/tdanylchuk","html_url":"https://github.com/tdanylchuk","followers_url":"https://api.github.com/users/tdanylchuk/followers","following_url":"https://api.github.com/users/tdanylchuk/following{/other_user}","gists_url":"https://api.github.com/users/tdanylchuk/gists{/gist_id}","starred_url":"https://api.github.com/users/tdanylchuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdanylchuk/subscriptions","organizations_url":"https://api.github.com/users/tdanylchuk/orgs","repos_url":"https://api.github.com/users/tdanylchuk/repos","events_url":"https://api.github.com/users/tdanylchuk/events{/privacy}","received_events_url":"https://api.github.com/users/tdanylchuk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tdanylchuk/spring-cloud-netflix","description":"Integration with Netflix OSS components","fork":true,"url":"https://api.github.com/repos/tdanylchuk/spring-cloud-netflix","forks_url":"https://api.github.com/repos/tdanylchuk/spring-cloud-netflix/forks","keys_url":"https://api.github.com/repos/tdanylchuk/spring-cloud-netflix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tdanylchuk/spring-cloud-netflix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tdanylchuk/spring-cloud-netflix/teams","hooks_url":"https://api.github.com/repos/tdanylchuk/spring-cloud-netflix/hooks","issue_events_url":"https://api.github.com/repos/tdanylchuk/spring-cloud-netflix/issues/events{/number}","events_url":"https://api.github.com/repos/tdanylchuk/spring-cloud-netflix/events","assignees_url":"https://api.github.com/repos/tdanylchuk/spring-cloud-netflix/assignees{/user}","branches_url":"https://api.github.com/repos/tdanylchuk/spring-cloud-netflix/branches{/branch}","tags_url":"https://api.github.com/repos/tdanylchuk/spring-cloud-netflix/tags","blobs_url":"https://api.github.com/repos/tdanylchuk/spring-cloud-netflix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tdanylchuk/spring-cloud-netflix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tdanylchuk/spring-cloud-netflix/git/refs{/sha}","trees_url":"https://api.github.com/repos/tdanylchuk/spring-cloud-netflix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tdanylchuk/spring-cloud-netflix/statuses/{sha}","languages_url":"https://api.github.com/repos/tdanylchuk/spring-cloud-netflix/languages","stargazers_url":"https://api.github.com/repos/tdanylchuk/spring-cloud-netflix/stargazers","contributors_url":"https://api.github.com/repos/tdanylchuk/spring-cloud-netflix/contributors","subscribers_url":"https://api.github.com/repos/tdanylchuk/spring-cloud-netflix/subscribers","subscription_url":"https://api.github.com/repos/tdanylchuk/spring-cloud-netflix/subscription","commits_url":"https://api.github.com/repos/tdanylchuk/spring-cloud-netflix/commits{/sha}","git_commits_url":"https://api.github.com/repos/tdanylchuk/spring-cloud-netflix/git/commits{/sha}","comments_url":"https://api.github.com/repos/tdanylchuk/spring-cloud-netflix/comments{/number}","issue_comment_url":"https://api.github.com/repos/tdanylchuk/spring-cloud-netflix/issues/comments{/number}","contents_url":"https://api.github.com/repos/tdanylchuk/spring-cloud-netflix/contents/{+path}","compare_url":"https://api.github.com/repos/tdanylchuk/spring-cloud-netflix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tdanylchuk/spring-cloud-netflix/merges","archive_url":"https://api.github.com/repos/tdanylchuk/spring-cloud-netflix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tdanylchuk/spring-cloud-netflix/downloads","issues_url":"https://api.github.com/repos/tdanylchuk/spring-cloud-netflix/issues{/number}","pulls_url":"https://api.github.com/repos/tdanylchuk/spring-cloud-netflix/pulls{/number}","milestones_url":"https://api.github.com/repos/tdanylchuk/spring-cloud-netflix/milestones{/number}","notifications_url":"https://api.github.com/repos/tdanylchuk/spring-cloud-netflix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tdanylchuk/spring-cloud-netflix/labels{/name}","releases_url":"https://api.github.com/repos/tdanylchuk/spring-cloud-netflix/releases{/id}","deployments_url":"https://api.github.com/repos/tdanylchuk/spring-cloud-netflix/deployments","created_at":"2018-05-31T18:37:23Z","updated_at":"2018-05-31T18:37:27Z","pushed_at":"2018-06-20T15:51:47Z","git_url":"git://github.com/tdanylchuk/spring-cloud-netflix.git","ssh_url":"git@github.com:tdanylchuk/spring-cloud-netflix.git","clone_url":"https://github.com/tdanylchuk/spring-cloud-netflix.git","svn_url":"https://github.com/tdanylchuk/spring-cloud-netflix","homepage":"http://cloud.spring.io/spring-cloud-netflix/","size":12969,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-cloud:1.4.x","ref":"1.4.x","sha":"2df81038f9033c77b03283407bb8864491543f2a","user":{"login":"spring-cloud","id":7815877,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MTU4Nzc=","avatar_url":"https://avatars0.githubusercontent.com/u/7815877?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":21741891,"node_id":"MDEwOlJlcG9zaXRvcnkyMTc0MTg5MQ==","name":"spring-cloud-netflix","full_name":"spring-cloud/spring-cloud-netflix","owner":{"login":"spring-cloud","id":7815877,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MTU4Nzc=","avatar_url":"https://avatars0.githubusercontent.com/u/7815877?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-netflix","description":"Integration with Netflix OSS components","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/releases{/id}","deployments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/deployments","created_at":"2014-07-11T15:46:12Z","updated_at":"2018-06-20T06:16:31Z","pushed_at":"2018-06-20T15:52:39Z","git_url":"git://github.com/spring-cloud/spring-cloud-netflix.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-netflix.git","clone_url":"https://github.com/spring-cloud/spring-cloud-netflix.git","svn_url":"https://github.com/spring-cloud/spring-cloud-netflix","homepage":"http://cloud.spring.io/spring-cloud-netflix/","size":13344,"stargazers_count":2397,"watchers_count":2397,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1206,"mirror_url":null,"archived":false,"open_issues_count":413,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1206,"open_issues":413,"watchers":2397,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/pulls/3018"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-netflix/pull/3018"},"issue":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/issues/3018"},"comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/issues/3018/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/pulls/3018/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/pulls/3018/commits"},"statuses":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-netflix/statuses/616e901e1b1fc9b94d243669e1abd8a5a2e3878b"}},"author_association":"NONE"}}
{"actor":{"display_login":"tdanylchuk"}}