{"action":"created","issue":{"url":"https://api.github.com/repos/snowleopard/alga/issues/73","repository_url":"https://api.github.com/repos/snowleopard/alga","labels_url":"https://api.github.com/repos/snowleopard/alga/issues/73/labels{/name}","comments_url":"https://api.github.com/repos/snowleopard/alga/issues/73/comments","events_url":"https://api.github.com/repos/snowleopard/alga/issues/73/events","html_url":"https://github.com/snowleopard/alga/pull/73","id":330410241,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNDI3OTg4","number":73,"title":"Speedup vertices","user":{"login":"nobrakal","id":6417395,"node_id":"MDQ6VXNlcjY0MTczOTU=","avatar_url":"https://avatars1.githubusercontent.com/u/6417395?v=4","gravatar_id":"","url":"https://api.github.com/users/nobrakal","html_url":"https://github.com/nobrakal","followers_url":"https://api.github.com/users/nobrakal/followers","following_url":"https://api.github.com/users/nobrakal/following{/other_user}","gists_url":"https://api.github.com/users/nobrakal/gists{/gist_id}","starred_url":"https://api.github.com/users/nobrakal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nobrakal/subscriptions","organizations_url":"https://api.github.com/users/nobrakal/orgs","repos_url":"https://api.github.com/users/nobrakal/repos","events_url":"https://api.github.com/users/nobrakal/events{/privacy}","received_events_url":"https://api.github.com/users/nobrakal/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-06-07T19:45:34Z","updated_at":"2018-06-07T21:29:45Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/snowleopard/alga/pulls/73","html_url":"https://github.com/snowleopard/alga/pull/73","diff_url":"https://github.com/snowleopard/alga/pull/73.diff","patch_url":"https://github.com/snowleopard/alga/pull/73.patch"},"body":"Hi,\r\n\r\nI noticed that the function `vertices` was made of a map and a fold, it can be reduced to a fold alone: \r\nIt divide the time took by the original function by 2\r\n\r\nAlso, this is pure make up, I used `foldr1` when possible, I think it is more clearer."},"comment":{"url":"https://api.github.com/repos/snowleopard/alga/issues/comments/395571405","html_url":"https://github.com/snowleopard/alga/pull/73#issuecomment-395571405","issue_url":"https://api.github.com/repos/snowleopard/alga/issues/73","id":395571405,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTU3MTQwNQ==","user":{"login":"snowleopard","id":675286,"node_id":"MDQ6VXNlcjY3NTI4Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/675286?v=4","gravatar_id":"","url":"https://api.github.com/users/snowleopard","html_url":"https://github.com/snowleopard","followers_url":"https://api.github.com/users/snowleopard/followers","following_url":"https://api.github.com/users/snowleopard/following{/other_user}","gists_url":"https://api.github.com/users/snowleopard/gists{/gist_id}","starred_url":"https://api.github.com/users/snowleopard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snowleopard/subscriptions","organizations_url":"https://api.github.com/users/snowleopard/orgs","repos_url":"https://api.github.com/users/snowleopard/repos","events_url":"https://api.github.com/users/snowleopard/events{/privacy}","received_events_url":"https://api.github.com/users/snowleopard/received_events","type":"User","site_admin":false},"created_at":"2018-06-07T21:29:44Z","updated_at":"2018-06-07T21:29:44Z","author_association":"OWNER","body":"@nobrakal Well, I guess you can make the following test. Benchmark these cases:\r\n* `vertices` without any optimisation.\r\n* `vertices` with the rewrite rule.\r\n* `overlays . map vertex` with the rewrite rule -- this will test whether the rule applies in user code.\r\n\r\nI've never used rewrite rules before, so I suggest you study this topic. And then share what you learn :)"}}
{"actor":{"display_login":"snowleopard"}}