{"action":"closed","number":4924,"pull_request":{"url":"https://api.github.com/repos/status-im/status-react/pulls/4924","id":197027264,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MDI3MjY0","html_url":"https://github.com/status-im/status-react/pull/4924","diff_url":"https://github.com/status-im/status-react/pull/4924.diff","patch_url":"https://github.com/status-im/status-react/pull/4924.patch","issue_url":"https://api.github.com/repos/status-im/status-react/issues/4924","number":4924,"state":"closed","locked":false,"title":"bug #4921 - adds a workaround for the conflicting bugs #4876 and #4755","user":{"login":"goranjovic","id":711764,"node_id":"MDQ6VXNlcjcxMTc2NA==","avatar_url":"https://avatars0.githubusercontent.com/u/711764?v=4","gravatar_id":"","url":"https://api.github.com/users/goranjovic","html_url":"https://github.com/goranjovic","followers_url":"https://api.github.com/users/goranjovic/followers","following_url":"https://api.github.com/users/goranjovic/following{/other_user}","gists_url":"https://api.github.com/users/goranjovic/gists{/gist_id}","starred_url":"https://api.github.com/users/goranjovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goranjovic/subscriptions","organizations_url":"https://api.github.com/users/goranjovic/orgs","repos_url":"https://api.github.com/users/goranjovic/repos","events_url":"https://api.github.com/users/goranjovic/events{/privacy}","received_events_url":"https://api.github.com/users/goranjovic/received_events","type":"User","site_admin":false},"body":"fixes #4921 \r\n\r\n### Summary:\r\n\r\nWe've got two bugfixes causing each other's bugs. \r\n\r\nIf we clear `:from-chat?` from transaction, then we lose the read only state in chat transactions when user clicks cancel or say tries to sign with incorrect password. (bug #4755)\r\n\r\nIf we don't clear `:from-chat?` then if we have a dapp transaction before wallet onboarding has been done, then app will think that there is a chat tx in progress and will redirect to onboarding. Since there is no chat tx the app will crash (bug #4876)\r\n\r\nThis PR adds a workaround to have a special partial clean function for transactions started from chat - one that cleans everything except `:from-chat?` property. This will prevent the fields from getting unlocked and would not cause the onboarding crash since with chat transactions onboarding should happen before we get to this screen anyway (there is interception).\r\n\r\nThis is merely a hotfix. A proper solution would involve:\r\n\r\n- adding onboarding interception for dapp transactions to avoid the #4876 scenario altogether. (issue #4724)\r\n- fixing the transaction creation and signing to be a one step process to avoid the #4755 scenario altogether - there would be no intermediate step with a half done tx after cancel or fail. (issue https://github.com/status-im/status-go/issues/1027)\r\n\r\n### Steps to test:\r\ntest for #4876 and #4755\r\n\r\nstatus: ready","created_at":"2018-06-25T07:44:56Z","updated_at":"2018-06-25T10:53:19Z","closed_at":"2018-06-25T10:53:19Z","merged_at":"2018-06-25T10:53:19Z","merge_commit_sha":"9a348390d3bee503355bacf49948ff6331d141bf","assignee":{"login":"goranjovic","id":711764,"node_id":"MDQ6VXNlcjcxMTc2NA==","avatar_url":"https://avatars0.githubusercontent.com/u/711764?v=4","gravatar_id":"","url":"https://api.github.com/users/goranjovic","html_url":"https://github.com/goranjovic","followers_url":"https://api.github.com/users/goranjovic/followers","following_url":"https://api.github.com/users/goranjovic/following{/other_user}","gists_url":"https://api.github.com/users/goranjovic/gists{/gist_id}","starred_url":"https://api.github.com/users/goranjovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goranjovic/subscriptions","organizations_url":"https://api.github.com/users/goranjovic/orgs","repos_url":"https://api.github.com/users/goranjovic/repos","events_url":"https://api.github.com/users/goranjovic/events{/privacy}","received_events_url":"https://api.github.com/users/goranjovic/received_events","type":"User","site_admin":false},"assignees":[{"login":"goranjovic","id":711764,"node_id":"MDQ6VXNlcjcxMTc2NA==","avatar_url":"https://avatars0.githubusercontent.com/u/711764?v=4","gravatar_id":"","url":"https://api.github.com/users/goranjovic","html_url":"https://github.com/goranjovic","followers_url":"https://api.github.com/users/goranjovic/followers","following_url":"https://api.github.com/users/goranjovic/following{/other_user}","gists_url":"https://api.github.com/users/goranjovic/gists{/gist_id}","starred_url":"https://api.github.com/users/goranjovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goranjovic/subscriptions","organizations_url":"https://api.github.com/users/goranjovic/orgs","repos_url":"https://api.github.com/users/goranjovic/repos","events_url":"https://api.github.com/users/goranjovic/events{/privacy}","received_events_url":"https://api.github.com/users/goranjovic/received_events","type":"User","site_admin":false},{"login":"Serhy","id":8749671,"node_id":"MDQ6VXNlcjg3NDk2NzE=","avatar_url":"https://avatars2.githubusercontent.com/u/8749671?v=4","gravatar_id":"","url":"https://api.github.com/users/Serhy","html_url":"https://github.com/Serhy","followers_url":"https://api.github.com/users/Serhy/followers","following_url":"https://api.github.com/users/Serhy/following{/other_user}","gists_url":"https://api.github.com/users/Serhy/gists{/gist_id}","starred_url":"https://api.github.com/users/Serhy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Serhy/subscriptions","organizations_url":"https://api.github.com/users/Serhy/orgs","repos_url":"https://api.github.com/users/Serhy/repos","events_url":"https://api.github.com/users/Serhy/events{/privacy}","received_events_url":"https://api.github.com/users/Serhy/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":613726559,"node_id":"MDU6TGFiZWw2MTM3MjY1NTk=","url":"https://api.github.com/repos/status-im/status-react/labels/Tested%20-%20OK","name":"Tested - OK","color":"0e8a16","default":false}],"milestone":{"url":"https://api.github.com/repos/status-im/status-react/milestones/21","html_url":"https://github.com/status-im/status-react/milestone/21","labels_url":"https://api.github.com/repos/status-im/status-react/milestones/21/labels","id":3355444,"node_id":"MDk6TWlsZXN0b25lMzM1NTQ0NA==","number":21,"title":"Beta","description":"Issues and blockers required for the Q2 beta release","creator":{"login":"chadyj","id":116099,"node_id":"MDQ6VXNlcjExNjA5OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/116099?v=4","gravatar_id":"","url":"https://api.github.com/users/chadyj","html_url":"https://github.com/chadyj","followers_url":"https://api.github.com/users/chadyj/followers","following_url":"https://api.github.com/users/chadyj/following{/other_user}","gists_url":"https://api.github.com/users/chadyj/gists{/gist_id}","starred_url":"https://api.github.com/users/chadyj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadyj/subscriptions","organizations_url":"https://api.github.com/users/chadyj/orgs","repos_url":"https://api.github.com/users/chadyj/repos","events_url":"https://api.github.com/users/chadyj/events{/privacy}","received_events_url":"https://api.github.com/users/chadyj/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":118,"state":"open","created_at":"2018-05-17T18:10:04Z","updated_at":"2018-06-25T10:53:19Z","due_on":"2018-06-20T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/status-im/status-react/pulls/4924/commits","review_comments_url":"https://api.github.com/repos/status-im/status-react/pulls/4924/comments","review_comment_url":"https://api.github.com/repos/status-im/status-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/status-im/status-react/issues/4924/comments","statuses_url":"https://api.github.com/repos/status-im/status-react/statuses/9a348390d3bee503355bacf49948ff6331d141bf","head":{"label":"status-im:bug/unlocked-chat-send-fields-4921","ref":"bug/unlocked-chat-send-fields-4921","sha":"9a348390d3bee503355bacf49948ff6331d141bf","user":{"login":"status-im","id":11767950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzY3OTUw","avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"repo":{"id":52308441,"node_id":"MDEwOlJlcG9zaXRvcnk1MjMwODQ0MQ==","name":"status-react","full_name":"status-im/status-react","owner":{"login":"status-im","id":11767950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzY3OTUw","avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/status-im/status-react","description":"a free (libre) open source, mobile OS for Ethereum","fork":false,"url":"https://api.github.com/repos/status-im/status-react","forks_url":"https://api.github.com/repos/status-im/status-react/forks","keys_url":"https://api.github.com/repos/status-im/status-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/status-im/status-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/status-im/status-react/teams","hooks_url":"https://api.github.com/repos/status-im/status-react/hooks","issue_events_url":"https://api.github.com/repos/status-im/status-react/issues/events{/number}","events_url":"https://api.github.com/repos/status-im/status-react/events","assignees_url":"https://api.github.com/repos/status-im/status-react/assignees{/user}","branches_url":"https://api.github.com/repos/status-im/status-react/branches{/branch}","tags_url":"https://api.github.com/repos/status-im/status-react/tags","blobs_url":"https://api.github.com/repos/status-im/status-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/status-im/status-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/status-im/status-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/status-im/status-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/status-im/status-react/statuses/{sha}","languages_url":"https://api.github.com/repos/status-im/status-react/languages","stargazers_url":"https://api.github.com/repos/status-im/status-react/stargazers","contributors_url":"https://api.github.com/repos/status-im/status-react/contributors","subscribers_url":"https://api.github.com/repos/status-im/status-react/subscribers","subscription_url":"https://api.github.com/repos/status-im/status-react/subscription","commits_url":"https://api.github.com/repos/status-im/status-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/status-im/status-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/status-im/status-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/status-im/status-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/status-im/status-react/contents/{+path}","compare_url":"https://api.github.com/repos/status-im/status-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/status-im/status-react/merges","archive_url":"https://api.github.com/repos/status-im/status-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/status-im/status-react/downloads","issues_url":"https://api.github.com/repos/status-im/status-react/issues{/number}","pulls_url":"https://api.github.com/repos/status-im/status-react/pulls{/number}","milestones_url":"https://api.github.com/repos/status-im/status-react/milestones{/number}","notifications_url":"https://api.github.com/repos/status-im/status-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/status-im/status-react/labels{/name}","releases_url":"https://api.github.com/repos/status-im/status-react/releases{/id}","deployments_url":"https://api.github.com/repos/status-im/status-react/deployments","created_at":"2016-02-22T21:48:48Z","updated_at":"2018-06-25T06:05:53Z","pushed_at":"2018-06-25T10:53:15Z","git_url":"git://github.com/status-im/status-react.git","ssh_url":"git@github.com:status-im/status-react.git","clone_url":"https://github.com/status-im/status-react.git","svn_url":"https://github.com/status-im/status-react","homepage":"https://status.im","size":56605,"stargazers_count":2292,"watchers_count":2292,"language":"Clojure","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":564,"mirror_url":null,"archived":false,"open_issues_count":668,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":564,"open_issues":668,"watchers":2292,"default_branch":"develop"}},"base":{"label":"status-im:develop","ref":"develop","sha":"ad1a31073e0456618fdebb7de01f86c7632589ea","user":{"login":"status-im","id":11767950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzY3OTUw","avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"repo":{"id":52308441,"node_id":"MDEwOlJlcG9zaXRvcnk1MjMwODQ0MQ==","name":"status-react","full_name":"status-im/status-react","owner":{"login":"status-im","id":11767950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzY3OTUw","avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/status-im/status-react","description":"a free (libre) open source, mobile OS for Ethereum","fork":false,"url":"https://api.github.com/repos/status-im/status-react","forks_url":"https://api.github.com/repos/status-im/status-react/forks","keys_url":"https://api.github.com/repos/status-im/status-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/status-im/status-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/status-im/status-react/teams","hooks_url":"https://api.github.com/repos/status-im/status-react/hooks","issue_events_url":"https://api.github.com/repos/status-im/status-react/issues/events{/number}","events_url":"https://api.github.com/repos/status-im/status-react/events","assignees_url":"https://api.github.com/repos/status-im/status-react/assignees{/user}","branches_url":"https://api.github.com/repos/status-im/status-react/branches{/branch}","tags_url":"https://api.github.com/repos/status-im/status-react/tags","blobs_url":"https://api.github.com/repos/status-im/status-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/status-im/status-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/status-im/status-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/status-im/status-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/status-im/status-react/statuses/{sha}","languages_url":"https://api.github.com/repos/status-im/status-react/languages","stargazers_url":"https://api.github.com/repos/status-im/status-react/stargazers","contributors_url":"https://api.github.com/repos/status-im/status-react/contributors","subscribers_url":"https://api.github.com/repos/status-im/status-react/subscribers","subscription_url":"https://api.github.com/repos/status-im/status-react/subscription","commits_url":"https://api.github.com/repos/status-im/status-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/status-im/status-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/status-im/status-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/status-im/status-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/status-im/status-react/contents/{+path}","compare_url":"https://api.github.com/repos/status-im/status-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/status-im/status-react/merges","archive_url":"https://api.github.com/repos/status-im/status-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/status-im/status-react/downloads","issues_url":"https://api.github.com/repos/status-im/status-react/issues{/number}","pulls_url":"https://api.github.com/repos/status-im/status-react/pulls{/number}","milestones_url":"https://api.github.com/repos/status-im/status-react/milestones{/number}","notifications_url":"https://api.github.com/repos/status-im/status-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/status-im/status-react/labels{/name}","releases_url":"https://api.github.com/repos/status-im/status-react/releases{/id}","deployments_url":"https://api.github.com/repos/status-im/status-react/deployments","created_at":"2016-02-22T21:48:48Z","updated_at":"2018-06-25T06:05:53Z","pushed_at":"2018-06-25T10:53:15Z","git_url":"git://github.com/status-im/status-react.git","ssh_url":"git@github.com:status-im/status-react.git","clone_url":"https://github.com/status-im/status-react.git","svn_url":"https://github.com/status-im/status-react","homepage":"https://status.im","size":56605,"stargazers_count":2292,"watchers_count":2292,"language":"Clojure","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":564,"mirror_url":null,"archived":false,"open_issues_count":668,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":564,"open_issues":668,"watchers":2292,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/status-im/status-react/pulls/4924"},"html":{"href":"https://github.com/status-im/status-react/pull/4924"},"issue":{"href":"https://api.github.com/repos/status-im/status-react/issues/4924"},"comments":{"href":"https://api.github.com/repos/status-im/status-react/issues/4924/comments"},"review_comments":{"href":"https://api.github.com/repos/status-im/status-react/pulls/4924/comments"},"review_comment":{"href":"https://api.github.com/repos/status-im/status-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/status-im/status-react/pulls/4924/commits"},"statuses":{"href":"https://api.github.com/repos/status-im/status-react/statuses/9a348390d3bee503355bacf49948ff6331d141bf"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mandrigin","id":466427,"node_id":"MDQ6VXNlcjQ2NjQyNw==","avatar_url":"https://avatars0.githubusercontent.com/u/466427?v=4","gravatar_id":"","url":"https://api.github.com/users/mandrigin","html_url":"https://github.com/mandrigin","followers_url":"https://api.github.com/users/mandrigin/followers","following_url":"https://api.github.com/users/mandrigin/following{/other_user}","gists_url":"https://api.github.com/users/mandrigin/gists{/gist_id}","starred_url":"https://api.github.com/users/mandrigin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandrigin/subscriptions","organizations_url":"https://api.github.com/users/mandrigin/orgs","repos_url":"https://api.github.com/users/mandrigin/repos","events_url":"https://api.github.com/users/mandrigin/events{/privacy}","received_events_url":"https://api.github.com/users/mandrigin/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":17,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"mandrigin"}}