{"action":"created","comment":{"url":"https://api.github.com/repos/scalableminds/webknossos/pulls/comments/209889205","pull_request_review_id":145987205,"id":209889205,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTg4OTIwNQ==","diff_hunk":"@@ -75,12 +75,12 @@ class GalleryDatasetView extends React.PureComponent<Props, State> {\n       .entries()\n       .map(([organization, datasets]) =>\n         // Sort each group of datasets\n-        [organization, datasets.sort(Utils.localeCompareBy(([]: DatasetType[]), \"created\", false))],\n+        [organization, datasets.sort(Utils.compareBy(([]: DatasetType[]), \"created\", false))],\n       )\n       .value()\n       .sort(\n         // Sort groups by creation date of first dataset\n-        Utils.localeCompareBy(\n+        Utils.compareBy(\n           ([]: DatasetType[]),","path":"app/assets/javascripts/dashboard/gallery_dataset_view.js","position":12,"original_position":12,"commit_id":"79a3e145cc77c3c1dd48915162e52187089ca60b","original_commit_id":"79a3e145cc77c3c1dd48915162e52187089ca60b","user":{"login":"philippotto","id":2486553,"node_id":"MDQ6VXNlcjI0ODY1NTM=","avatar_url":"https://avatars3.githubusercontent.com/u/2486553?v=4","gravatar_id":"","url":"https://api.github.com/users/philippotto","html_url":"https://github.com/philippotto","followers_url":"https://api.github.com/users/philippotto/followers","following_url":"https://api.github.com/users/philippotto/following{/other_user}","gists_url":"https://api.github.com/users/philippotto/gists{/gist_id}","starred_url":"https://api.github.com/users/philippotto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philippotto/subscriptions","organizations_url":"https://api.github.com/users/philippotto/orgs","repos_url":"https://api.github.com/users/philippotto/repos","events_url":"https://api.github.com/users/philippotto/events{/privacy}","received_events_url":"https://api.github.com/users/philippotto/received_events","type":"User","site_admin":false},"body":"Can you change this line to `([]: Array<[string, APIDatasetType]>)`? Then, the old error should have been caught in my opinion.","created_at":"2018-08-14T09:40:08Z","updated_at":"2018-08-14T09:41:51Z","html_url":"https://github.com/scalableminds/webknossos/pull/3046#discussion_r209889205","pull_request_url":"https://api.github.com/repos/scalableminds/webknossos/pulls/3046","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/scalableminds/webknossos/pulls/comments/209889205"},"html":{"href":"https://github.com/scalableminds/webknossos/pull/3046#discussion_r209889205"},"pull_request":{"href":"https://api.github.com/repos/scalableminds/webknossos/pulls/3046"}}},"pull_request":{"url":"https://api.github.com/repos/scalableminds/webknossos/pulls/3046","id":208015626,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MDE1NjI2","html_url":"https://github.com/scalableminds/webknossos/pull/3046","diff_url":"https://github.com/scalableminds/webknossos/pull/3046.diff","patch_url":"https://github.com/scalableminds/webknossos/pull/3046.patch","issue_url":"https://api.github.com/repos/scalableminds/webknossos/issues/3046","number":3046,"state":"open","locked":false,"title":"Use correct compare method for numbers","user":{"login":"daniel-wer","id":1702075,"node_id":"MDQ6VXNlcjE3MDIwNzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1702075?v=4","gravatar_id":"","url":"https://api.github.com/users/daniel-wer","html_url":"https://github.com/daniel-wer","followers_url":"https://api.github.com/users/daniel-wer/followers","following_url":"https://api.github.com/users/daniel-wer/following{/other_user}","gists_url":"https://api.github.com/users/daniel-wer/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-wer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-wer/subscriptions","organizations_url":"https://api.github.com/users/daniel-wer/orgs","repos_url":"https://api.github.com/users/daniel-wer/repos","events_url":"https://api.github.com/users/daniel-wer/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-wer/received_events","type":"User","site_admin":false},"body":"I didn't manage to change the flowtypes for the compareBy methods, so that one can only be called with numbers and the other with strings. However, I fixed our usage of compareBy and localeCompareBy in the admin views and added a console error message to warn of wrong usage in the future.\r\n\r\n### URL of deployed dev instance (used for testing):\r\n- https://repairsorting.webknossos.xyz\r\n\r\n### Steps to test:\r\n- Open the admin views that are affected by this PR and check whether the sorting works correctly.\r\n\r\n### Issues:\r\n- fixes incorrect sorting in some admin views\r\n\r\n------\r\n- [ ] Updated [changelog](../blob/master/CHANGELOG.md#unreleased)\r\n- [x] Ready for review\r\n","created_at":"2018-08-13T15:28:03Z","updated_at":"2018-08-14T09:41:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b02a044763c74b9f872de957150879161c29da51","assignee":{"login":"daniel-wer","id":1702075,"node_id":"MDQ6VXNlcjE3MDIwNzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1702075?v=4","gravatar_id":"","url":"https://api.github.com/users/daniel-wer","html_url":"https://github.com/daniel-wer","followers_url":"https://api.github.com/users/daniel-wer/followers","following_url":"https://api.github.com/users/daniel-wer/following{/other_user}","gists_url":"https://api.github.com/users/daniel-wer/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-wer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-wer/subscriptions","organizations_url":"https://api.github.com/users/daniel-wer/orgs","repos_url":"https://api.github.com/users/daniel-wer/repos","events_url":"https://api.github.com/users/daniel-wer/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-wer/received_events","type":"User","site_admin":false},"assignees":[{"login":"daniel-wer","id":1702075,"node_id":"MDQ6VXNlcjE3MDIwNzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1702075?v=4","gravatar_id":"","url":"https://api.github.com/users/daniel-wer","html_url":"https://github.com/daniel-wer","followers_url":"https://api.github.com/users/daniel-wer/followers","following_url":"https://api.github.com/users/daniel-wer/following{/other_user}","gists_url":"https://api.github.com/users/daniel-wer/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-wer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-wer/subscriptions","organizations_url":"https://api.github.com/users/daniel-wer/orgs","repos_url":"https://api.github.com/users/daniel-wer/repos","events_url":"https://api.github.com/users/daniel-wer/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-wer/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":5005367,"node_id":"MDU6TGFiZWw1MDA1MzY3","url":"https://api.github.com/repos/scalableminds/webknossos/labels/bug","name":"bug","color":"f7c6c7","default":true},{"id":60646770,"node_id":"MDU6TGFiZWw2MDY0Njc3MA==","url":"https://api.github.com/repos/scalableminds/webknossos/labels/frontend","name":"frontend","color":"207de5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/scalableminds/webknossos/pulls/3046/commits","review_comments_url":"https://api.github.com/repos/scalableminds/webknossos/pulls/3046/comments","review_comment_url":"https://api.github.com/repos/scalableminds/webknossos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scalableminds/webknossos/issues/3046/comments","statuses_url":"https://api.github.com/repos/scalableminds/webknossos/statuses/79a3e145cc77c3c1dd48915162e52187089ca60b","head":{"label":"scalableminds:repair-sorting","ref":"repair-sorting","sha":"79a3e145cc77c3c1dd48915162e52187089ca60b","user":{"login":"scalableminds","id":1648557,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDg1NTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1648557?v=4","gravatar_id":"","url":"https://api.github.com/users/scalableminds","html_url":"https://github.com/scalableminds","followers_url":"https://api.github.com/users/scalableminds/followers","following_url":"https://api.github.com/users/scalableminds/following{/other_user}","gists_url":"https://api.github.com/users/scalableminds/gists{/gist_id}","starred_url":"https://api.github.com/users/scalableminds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalableminds/subscriptions","organizations_url":"https://api.github.com/users/scalableminds/orgs","repos_url":"https://api.github.com/users/scalableminds/repos","events_url":"https://api.github.com/users/scalableminds/events{/privacy}","received_events_url":"https://api.github.com/users/scalableminds/received_events","type":"Organization","site_admin":false},"repo":{"id":4326197,"node_id":"MDEwOlJlcG9zaXRvcnk0MzI2MTk3","name":"webknossos","full_name":"scalableminds/webknossos","owner":{"login":"scalableminds","id":1648557,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDg1NTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1648557?v=4","gravatar_id":"","url":"https://api.github.com/users/scalableminds","html_url":"https://github.com/scalableminds","followers_url":"https://api.github.com/users/scalableminds/followers","following_url":"https://api.github.com/users/scalableminds/following{/other_user}","gists_url":"https://api.github.com/users/scalableminds/gists{/gist_id}","starred_url":"https://api.github.com/users/scalableminds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalableminds/subscriptions","organizations_url":"https://api.github.com/users/scalableminds/orgs","repos_url":"https://api.github.com/users/scalableminds/repos","events_url":"https://api.github.com/users/scalableminds/events{/privacy}","received_events_url":"https://api.github.com/users/scalableminds/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scalableminds/webknossos","description":"A fully cloud- and browser-based 3D annotation tool for distributed large-scale data analysis in light- and electron-microscopy based Connectomics","fork":false,"url":"https://api.github.com/repos/scalableminds/webknossos","forks_url":"https://api.github.com/repos/scalableminds/webknossos/forks","keys_url":"https://api.github.com/repos/scalableminds/webknossos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalableminds/webknossos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalableminds/webknossos/teams","hooks_url":"https://api.github.com/repos/scalableminds/webknossos/hooks","issue_events_url":"https://api.github.com/repos/scalableminds/webknossos/issues/events{/number}","events_url":"https://api.github.com/repos/scalableminds/webknossos/events","assignees_url":"https://api.github.com/repos/scalableminds/webknossos/assignees{/user}","branches_url":"https://api.github.com/repos/scalableminds/webknossos/branches{/branch}","tags_url":"https://api.github.com/repos/scalableminds/webknossos/tags","blobs_url":"https://api.github.com/repos/scalableminds/webknossos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalableminds/webknossos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalableminds/webknossos/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalableminds/webknossos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalableminds/webknossos/statuses/{sha}","languages_url":"https://api.github.com/repos/scalableminds/webknossos/languages","stargazers_url":"https://api.github.com/repos/scalableminds/webknossos/stargazers","contributors_url":"https://api.github.com/repos/scalableminds/webknossos/contributors","subscribers_url":"https://api.github.com/repos/scalableminds/webknossos/subscribers","subscription_url":"https://api.github.com/repos/scalableminds/webknossos/subscription","commits_url":"https://api.github.com/repos/scalableminds/webknossos/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalableminds/webknossos/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalableminds/webknossos/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalableminds/webknossos/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalableminds/webknossos/contents/{+path}","compare_url":"https://api.github.com/repos/scalableminds/webknossos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalableminds/webknossos/merges","archive_url":"https://api.github.com/repos/scalableminds/webknossos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalableminds/webknossos/downloads","issues_url":"https://api.github.com/repos/scalableminds/webknossos/issues{/number}","pulls_url":"https://api.github.com/repos/scalableminds/webknossos/pulls{/number}","milestones_url":"https://api.github.com/repos/scalableminds/webknossos/milestones{/number}","notifications_url":"https://api.github.com/repos/scalableminds/webknossos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalableminds/webknossos/labels{/name}","releases_url":"https://api.github.com/repos/scalableminds/webknossos/releases{/id}","deployments_url":"https://api.github.com/repos/scalableminds/webknossos/deployments","created_at":"2012-05-14T16:26:17Z","updated_at":"2018-08-14T09:28:24Z","pushed_at":"2018-08-14T09:28:21Z","git_url":"git://github.com/scalableminds/webknossos.git","ssh_url":"git@github.com:scalableminds/webknossos.git","clone_url":"https://github.com/scalableminds/webknossos.git","svn_url":"https://github.com/scalableminds/webknossos","homepage":"https://webknossos.org/","size":114346,"stargazers_count":22,"watchers_count":22,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":87,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":5,"open_issues":87,"watchers":22,"default_branch":"master"}},"base":{"label":"scalableminds:master","ref":"master","sha":"cead81552aa84effb4bdc2afee021b6a946a24f9","user":{"login":"scalableminds","id":1648557,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDg1NTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1648557?v=4","gravatar_id":"","url":"https://api.github.com/users/scalableminds","html_url":"https://github.com/scalableminds","followers_url":"https://api.github.com/users/scalableminds/followers","following_url":"https://api.github.com/users/scalableminds/following{/other_user}","gists_url":"https://api.github.com/users/scalableminds/gists{/gist_id}","starred_url":"https://api.github.com/users/scalableminds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalableminds/subscriptions","organizations_url":"https://api.github.com/users/scalableminds/orgs","repos_url":"https://api.github.com/users/scalableminds/repos","events_url":"https://api.github.com/users/scalableminds/events{/privacy}","received_events_url":"https://api.github.com/users/scalableminds/received_events","type":"Organization","site_admin":false},"repo":{"id":4326197,"node_id":"MDEwOlJlcG9zaXRvcnk0MzI2MTk3","name":"webknossos","full_name":"scalableminds/webknossos","owner":{"login":"scalableminds","id":1648557,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDg1NTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1648557?v=4","gravatar_id":"","url":"https://api.github.com/users/scalableminds","html_url":"https://github.com/scalableminds","followers_url":"https://api.github.com/users/scalableminds/followers","following_url":"https://api.github.com/users/scalableminds/following{/other_user}","gists_url":"https://api.github.com/users/scalableminds/gists{/gist_id}","starred_url":"https://api.github.com/users/scalableminds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalableminds/subscriptions","organizations_url":"https://api.github.com/users/scalableminds/orgs","repos_url":"https://api.github.com/users/scalableminds/repos","events_url":"https://api.github.com/users/scalableminds/events{/privacy}","received_events_url":"https://api.github.com/users/scalableminds/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scalableminds/webknossos","description":"A fully cloud- and browser-based 3D annotation tool for distributed large-scale data analysis in light- and electron-microscopy based Connectomics","fork":false,"url":"https://api.github.com/repos/scalableminds/webknossos","forks_url":"https://api.github.com/repos/scalableminds/webknossos/forks","keys_url":"https://api.github.com/repos/scalableminds/webknossos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalableminds/webknossos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalableminds/webknossos/teams","hooks_url":"https://api.github.com/repos/scalableminds/webknossos/hooks","issue_events_url":"https://api.github.com/repos/scalableminds/webknossos/issues/events{/number}","events_url":"https://api.github.com/repos/scalableminds/webknossos/events","assignees_url":"https://api.github.com/repos/scalableminds/webknossos/assignees{/user}","branches_url":"https://api.github.com/repos/scalableminds/webknossos/branches{/branch}","tags_url":"https://api.github.com/repos/scalableminds/webknossos/tags","blobs_url":"https://api.github.com/repos/scalableminds/webknossos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalableminds/webknossos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalableminds/webknossos/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalableminds/webknossos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalableminds/webknossos/statuses/{sha}","languages_url":"https://api.github.com/repos/scalableminds/webknossos/languages","stargazers_url":"https://api.github.com/repos/scalableminds/webknossos/stargazers","contributors_url":"https://api.github.com/repos/scalableminds/webknossos/contributors","subscribers_url":"https://api.github.com/repos/scalableminds/webknossos/subscribers","subscription_url":"https://api.github.com/repos/scalableminds/webknossos/subscription","commits_url":"https://api.github.com/repos/scalableminds/webknossos/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalableminds/webknossos/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalableminds/webknossos/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalableminds/webknossos/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalableminds/webknossos/contents/{+path}","compare_url":"https://api.github.com/repos/scalableminds/webknossos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalableminds/webknossos/merges","archive_url":"https://api.github.com/repos/scalableminds/webknossos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalableminds/webknossos/downloads","issues_url":"https://api.github.com/repos/scalableminds/webknossos/issues{/number}","pulls_url":"https://api.github.com/repos/scalableminds/webknossos/pulls{/number}","milestones_url":"https://api.github.com/repos/scalableminds/webknossos/milestones{/number}","notifications_url":"https://api.github.com/repos/scalableminds/webknossos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalableminds/webknossos/labels{/name}","releases_url":"https://api.github.com/repos/scalableminds/webknossos/releases{/id}","deployments_url":"https://api.github.com/repos/scalableminds/webknossos/deployments","created_at":"2012-05-14T16:26:17Z","updated_at":"2018-08-14T09:28:24Z","pushed_at":"2018-08-14T09:28:21Z","git_url":"git://github.com/scalableminds/webknossos.git","ssh_url":"git@github.com:scalableminds/webknossos.git","clone_url":"https://github.com/scalableminds/webknossos.git","svn_url":"https://github.com/scalableminds/webknossos","homepage":"https://webknossos.org/","size":114346,"stargazers_count":22,"watchers_count":22,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":87,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":5,"open_issues":87,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scalableminds/webknossos/pulls/3046"},"html":{"href":"https://github.com/scalableminds/webknossos/pull/3046"},"issue":{"href":"https://api.github.com/repos/scalableminds/webknossos/issues/3046"},"comments":{"href":"https://api.github.com/repos/scalableminds/webknossos/issues/3046/comments"},"review_comments":{"href":"https://api.github.com/repos/scalableminds/webknossos/pulls/3046/comments"},"review_comment":{"href":"https://api.github.com/repos/scalableminds/webknossos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scalableminds/webknossos/pulls/3046/commits"},"statuses":{"href":"https://api.github.com/repos/scalableminds/webknossos/statuses/79a3e145cc77c3c1dd48915162e52187089ca60b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"philippotto"}}