{"action":"created","issue":{"url":"https://api.github.com/repos/gitextensions/gitextensions/issues/5196","repository_url":"https://api.github.com/repos/gitextensions/gitextensions","labels_url":"https://api.github.com/repos/gitextensions/gitextensions/issues/5196/labels{/name}","comments_url":"https://api.github.com/repos/gitextensions/gitextensions/issues/5196/comments","events_url":"https://api.github.com/repos/gitextensions/gitextensions/issues/5196/events","html_url":"https://github.com/gitextensions/gitextensions/pull/5196","id":343954922,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNDYyNjY5","number":5196,"title":"Reset file to index failed due to ObjectId handling","user":{"login":"gerhardol","id":6248932,"node_id":"MDQ6VXNlcjYyNDg5MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/6248932?v=4","gravatar_id":"","url":"https://api.github.com/users/gerhardol","html_url":"https://github.com/gerhardol","followers_url":"https://api.github.com/users/gerhardol/followers","following_url":"https://api.github.com/users/gerhardol/following{/other_user}","gists_url":"https://api.github.com/users/gerhardol/gists{/gist_id}","starred_url":"https://api.github.com/users/gerhardol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gerhardol/subscriptions","organizations_url":"https://api.github.com/users/gerhardol/orgs","repos_url":"https://api.github.com/users/gerhardol/repos","events_url":"https://api.github.com/users/gerhardol/events{/privacy}","received_events_url":"https://api.github.com/users/gerhardol/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-07-24T09:24:30Z","updated_at":"2018-07-25T09:10:53Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/gitextensions/gitextensions/pulls/5196","html_url":"https://github.com/gitextensions/gitextensions/pull/5196","diff_url":"https://github.com/gitextensions/gitextensions/pull/5196.diff","patch_url":"https://github.com/gitextensions/gitextensions/pull/5196.patch"},"body":"Regression from ObjectId handling in #5087\r\n\r\nFixes #5193\r\n\r\nNote: The only other command with special handling for ObjectId.InndexId is GetFileBlobHash(), OK special handling there.\r\n\r\nChanges proposed in this pull request:\r\n- Exception when resetting to Index\r\n \r\nScreenshots before and after (if PR changes UI):\r\n- n/a\r\n\r\nWhat did I do to test the code and ensure quality:\r\n- manual test resetting worktree file\r\n\r\nHas been tested on (remove any that don't apply):\r\n- Windows 10\r\n"},"comment":{"url":"https://api.github.com/repos/gitextensions/gitextensions/issues/comments/407688190","html_url":"https://github.com/gitextensions/gitextensions/pull/5196#issuecomment-407688190","issue_url":"https://api.github.com/repos/gitextensions/gitextensions/issues/5196","id":407688190,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNzY4ODE5MA==","user":{"login":"gerhardol","id":6248932,"node_id":"MDQ6VXNlcjYyNDg5MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/6248932?v=4","gravatar_id":"","url":"https://api.github.com/users/gerhardol","html_url":"https://github.com/gerhardol","followers_url":"https://api.github.com/users/gerhardol/followers","following_url":"https://api.github.com/users/gerhardol/following{/other_user}","gists_url":"https://api.github.com/users/gerhardol/gists{/gist_id}","starred_url":"https://api.github.com/users/gerhardol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gerhardol/subscriptions","organizations_url":"https://api.github.com/users/gerhardol/orgs","repos_url":"https://api.github.com/users/gerhardol/repos","events_url":"https://api.github.com/users/gerhardol/events{/privacy}","received_events_url":"https://api.github.com/users/gerhardol/received_events","type":"User","site_admin":false},"created_at":"2018-07-25T09:10:53Z","updated_at":"2018-07-25T09:10:53Z","author_association":"CONTRIBUTOR","body":"Updated according to drew's proposal, added tests\r\n\r\n> I can't think of a time when you'd need to pass an artificial commit ID to a git.exe process. \r\n\r\nSure\r\nWhat I meant was sending artificial ids to the argument builder and let the argument builder resolve the arguments (like Index -> \"\").\r\nFor now, the proposal is the best"}}
{"actor":{"display_login":"gerhardol"}}