{"action":"created","comment":{"url":"https://api.github.com/repos/redhat-developer/odo/pulls/comments/241006505","pull_request_review_id":184167882,"id":241006505,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTAwNjUwNQ==","diff_hunk":"@@ -45,46 +49,96 @@ func NewServiceCreateOptions() *ServiceCreateOptions {\n \n // Complete completes ServiceCreateOptions after they've been created\n func (o *ServiceCreateOptions) Complete(name string, cmd *cobra.Command, args []string) (err error) {\n-\to.serviceType = args[0]\n-\t// if only one arg is given, then it is considered as service name and service type both\n-\to.serviceName = o.serviceType\n-\t// if two args are given, first is service type and second one is service name\n-\tif len(args) == 2 {\n-\t\to.serviceName = args[1]\n+\tif len(args) == 0 || !cmd.HasFlags() {\n+\t\to.interactive = true","path":"pkg/odo/cli/service/create.go","position":38,"original_position":38,"commit_id":"4d27c1ae67913d99e0bce2f96f29521d2d56f1bc","original_commit_id":"4d27c1ae67913d99e0bce2f96f29521d2d56f1bc","user":{"login":"metacosm","id":120057,"node_id":"MDQ6VXNlcjEyMDA1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/120057?v=4","gravatar_id":"","url":"https://api.github.com/users/metacosm","html_url":"https://github.com/metacosm","followers_url":"https://api.github.com/users/metacosm/followers","following_url":"https://api.github.com/users/metacosm/following{/other_user}","gists_url":"https://api.github.com/users/metacosm/gists{/gist_id}","starred_url":"https://api.github.com/users/metacosm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metacosm/subscriptions","organizations_url":"https://api.github.com/users/metacosm/orgs","repos_url":"https://api.github.com/users/metacosm/repos","events_url":"https://api.github.com/users/metacosm/events{/privacy}","received_events_url":"https://api.github.com/users/metacosm/received_events","type":"User","site_admin":false},"body":"See the discussion above: it's been agreed that interactive mode only kicks in when there are no flags or parameters. If you believe otherwise (as I do ^_^), please comment to that effect on #76","created_at":"2018-12-12T13:09:06Z","updated_at":"2018-12-12T13:09:06Z","html_url":"https://github.com/redhat-developer/odo/pull/857#discussion_r241006505","pull_request_url":"https://api.github.com/repos/redhat-developer/odo/pulls/857","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/redhat-developer/odo/pulls/comments/241006505"},"html":{"href":"https://github.com/redhat-developer/odo/pull/857#discussion_r241006505"},"pull_request":{"href":"https://api.github.com/repos/redhat-developer/odo/pulls/857"}},"in_reply_to_id":241001176},"pull_request":{"url":"https://api.github.com/repos/redhat-developer/odo/pulls/857","id":224789712,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0Nzg5NzEy","html_url":"https://github.com/redhat-developer/odo/pull/857","diff_url":"https://github.com/redhat-developer/odo/pull/857.diff","patch_url":"https://github.com/redhat-developer/odo/pull/857.patch","issue_url":"https://api.github.com/repos/redhat-developer/odo/issues/857","number":857,"state":"open","locked":false,"title":"Interactive service survey","user":{"login":"metacosm","id":120057,"node_id":"MDQ6VXNlcjEyMDA1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/120057?v=4","gravatar_id":"","url":"https://api.github.com/users/metacosm","html_url":"https://github.com/metacosm","followers_url":"https://api.github.com/users/metacosm/followers","following_url":"https://api.github.com/users/metacosm/following{/other_user}","gists_url":"https://api.github.com/users/metacosm/gists{/gist_id}","starred_url":"https://api.github.com/users/metacosm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metacosm/subscriptions","organizations_url":"https://api.github.com/users/metacosm/orgs","repos_url":"https://api.github.com/users/metacosm/repos","events_url":"https://api.github.com/users/metacosm/events{/privacy}","received_events_url":"https://api.github.com/users/metacosm/received_events","type":"User","site_admin":false},"body":"What is the purpose of this change? What does it change?\r\nTakes the work that was done to implement interactive mode for `odo service create` and replace `promptui` library by `survey` (https://github.com/AlecAivazis/survey).\r\n\r\nWas the change discussed in an issue?\r\n#76 \r\n\r\nHow to test changes?\r\nRun `odo service create` and enjoy!","created_at":"2018-10-22T19:39:06Z","updated_at":"2018-12-12T13:09:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3fb470ac0bf0c0a09a3432ac9895ee138e248bbf","assignee":{"login":"kadel","id":57206,"node_id":"MDQ6VXNlcjU3MjA2","avatar_url":"https://avatars1.githubusercontent.com/u/57206?v=4","gravatar_id":"","url":"https://api.github.com/users/kadel","html_url":"https://github.com/kadel","followers_url":"https://api.github.com/users/kadel/followers","following_url":"https://api.github.com/users/kadel/following{/other_user}","gists_url":"https://api.github.com/users/kadel/gists{/gist_id}","starred_url":"https://api.github.com/users/kadel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadel/subscriptions","organizations_url":"https://api.github.com/users/kadel/orgs","repos_url":"https://api.github.com/users/kadel/repos","events_url":"https://api.github.com/users/kadel/events{/privacy}","received_events_url":"https://api.github.com/users/kadel/received_events","type":"User","site_admin":false},"assignees":[{"login":"kadel","id":57206,"node_id":"MDQ6VXNlcjU3MjA2","avatar_url":"https://avatars1.githubusercontent.com/u/57206?v=4","gravatar_id":"","url":"https://api.github.com/users/kadel","html_url":"https://github.com/kadel","followers_url":"https://api.github.com/users/kadel/followers","following_url":"https://api.github.com/users/kadel/following{/other_user}","gists_url":"https://api.github.com/users/kadel/gists{/gist_id}","starred_url":"https://api.github.com/users/kadel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadel/subscriptions","organizations_url":"https://api.github.com/users/kadel/orgs","repos_url":"https://api.github.com/users/kadel/repos","events_url":"https://api.github.com/users/kadel/events{/privacy}","received_events_url":"https://api.github.com/users/kadel/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":907351840,"node_id":"MDU6TGFiZWw5MDczNTE4NDA=","url":"https://api.github.com/repos/redhat-developer/odo/labels/kind/UX","name":"kind/UX","color":"f9d0c4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/redhat-developer/odo/pulls/857/commits","review_comments_url":"https://api.github.com/repos/redhat-developer/odo/pulls/857/comments","review_comment_url":"https://api.github.com/repos/redhat-developer/odo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/redhat-developer/odo/issues/857/comments","statuses_url":"https://api.github.com/repos/redhat-developer/odo/statuses/4d27c1ae67913d99e0bce2f96f29521d2d56f1bc","head":{"label":"metacosm:interactive-service-survey","ref":"interactive-service-survey","sha":"4d27c1ae67913d99e0bce2f96f29521d2d56f1bc","user":{"login":"metacosm","id":120057,"node_id":"MDQ6VXNlcjEyMDA1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/120057?v=4","gravatar_id":"","url":"https://api.github.com/users/metacosm","html_url":"https://github.com/metacosm","followers_url":"https://api.github.com/users/metacosm/followers","following_url":"https://api.github.com/users/metacosm/following{/other_user}","gists_url":"https://api.github.com/users/metacosm/gists{/gist_id}","starred_url":"https://api.github.com/users/metacosm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metacosm/subscriptions","organizations_url":"https://api.github.com/users/metacosm/orgs","repos_url":"https://api.github.com/users/metacosm/repos","events_url":"https://api.github.com/users/metacosm/events{/privacy}","received_events_url":"https://api.github.com/users/metacosm/received_events","type":"User","site_admin":false},"repo":{"id":150439585,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA0Mzk1ODU=","name":"odo","full_name":"metacosm/odo","private":false,"owner":{"login":"metacosm","id":120057,"node_id":"MDQ6VXNlcjEyMDA1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/120057?v=4","gravatar_id":"","url":"https://api.github.com/users/metacosm","html_url":"https://github.com/metacosm","followers_url":"https://api.github.com/users/metacosm/followers","following_url":"https://api.github.com/users/metacosm/following{/other_user}","gists_url":"https://api.github.com/users/metacosm/gists{/gist_id}","starred_url":"https://api.github.com/users/metacosm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metacosm/subscriptions","organizations_url":"https://api.github.com/users/metacosm/orgs","repos_url":"https://api.github.com/users/metacosm/repos","events_url":"https://api.github.com/users/metacosm/events{/privacy}","received_events_url":"https://api.github.com/users/metacosm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/metacosm/odo","description":"OpenShift Command line for Developers","fork":true,"url":"https://api.github.com/repos/metacosm/odo","forks_url":"https://api.github.com/repos/metacosm/odo/forks","keys_url":"https://api.github.com/repos/metacosm/odo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metacosm/odo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metacosm/odo/teams","hooks_url":"https://api.github.com/repos/metacosm/odo/hooks","issue_events_url":"https://api.github.com/repos/metacosm/odo/issues/events{/number}","events_url":"https://api.github.com/repos/metacosm/odo/events","assignees_url":"https://api.github.com/repos/metacosm/odo/assignees{/user}","branches_url":"https://api.github.com/repos/metacosm/odo/branches{/branch}","tags_url":"https://api.github.com/repos/metacosm/odo/tags","blobs_url":"https://api.github.com/repos/metacosm/odo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metacosm/odo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metacosm/odo/git/refs{/sha}","trees_url":"https://api.github.com/repos/metacosm/odo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metacosm/odo/statuses/{sha}","languages_url":"https://api.github.com/repos/metacosm/odo/languages","stargazers_url":"https://api.github.com/repos/metacosm/odo/stargazers","contributors_url":"https://api.github.com/repos/metacosm/odo/contributors","subscribers_url":"https://api.github.com/repos/metacosm/odo/subscribers","subscription_url":"https://api.github.com/repos/metacosm/odo/subscription","commits_url":"https://api.github.com/repos/metacosm/odo/commits{/sha}","git_commits_url":"https://api.github.com/repos/metacosm/odo/git/commits{/sha}","comments_url":"https://api.github.com/repos/metacosm/odo/comments{/number}","issue_comment_url":"https://api.github.com/repos/metacosm/odo/issues/comments{/number}","contents_url":"https://api.github.com/repos/metacosm/odo/contents/{+path}","compare_url":"https://api.github.com/repos/metacosm/odo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metacosm/odo/merges","archive_url":"https://api.github.com/repos/metacosm/odo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metacosm/odo/downloads","issues_url":"https://api.github.com/repos/metacosm/odo/issues{/number}","pulls_url":"https://api.github.com/repos/metacosm/odo/pulls{/number}","milestones_url":"https://api.github.com/repos/metacosm/odo/milestones{/number}","notifications_url":"https://api.github.com/repos/metacosm/odo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metacosm/odo/labels{/name}","releases_url":"https://api.github.com/repos/metacosm/odo/releases{/id}","deployments_url":"https://api.github.com/repos/metacosm/odo/deployments","created_at":"2018-09-26T14:27:15Z","updated_at":"2018-10-18T07:33:08Z","pushed_at":"2018-12-11T17:24:43Z","git_url":"git://github.com/metacosm/odo.git","ssh_url":"git@github.com:metacosm/odo.git","clone_url":"https://github.com/metacosm/odo.git","svn_url":"https://github.com/metacosm/odo","homepage":"","size":139130,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"redhat-developer:master","ref":"master","sha":"2f1450717989c68a9c00d401e72e425b79d59009","user":{"login":"redhat-developer","id":11033755,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDMzNzU1","avatar_url":"https://avatars0.githubusercontent.com/u/11033755?v=4","gravatar_id":"","url":"https://api.github.com/users/redhat-developer","html_url":"https://github.com/redhat-developer","followers_url":"https://api.github.com/users/redhat-developer/followers","following_url":"https://api.github.com/users/redhat-developer/following{/other_user}","gists_url":"https://api.github.com/users/redhat-developer/gists{/gist_id}","starred_url":"https://api.github.com/users/redhat-developer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhat-developer/subscriptions","organizations_url":"https://api.github.com/users/redhat-developer/orgs","repos_url":"https://api.github.com/users/redhat-developer/repos","events_url":"https://api.github.com/users/redhat-developer/events{/privacy}","received_events_url":"https://api.github.com/users/redhat-developer/received_events","type":"Organization","site_admin":false},"repo":{"id":118630356,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg2MzAzNTY=","name":"odo","full_name":"redhat-developer/odo","private":false,"owner":{"login":"redhat-developer","id":11033755,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDMzNzU1","avatar_url":"https://avatars0.githubusercontent.com/u/11033755?v=4","gravatar_id":"","url":"https://api.github.com/users/redhat-developer","html_url":"https://github.com/redhat-developer","followers_url":"https://api.github.com/users/redhat-developer/followers","following_url":"https://api.github.com/users/redhat-developer/following{/other_user}","gists_url":"https://api.github.com/users/redhat-developer/gists{/gist_id}","starred_url":"https://api.github.com/users/redhat-developer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhat-developer/subscriptions","organizations_url":"https://api.github.com/users/redhat-developer/orgs","repos_url":"https://api.github.com/users/redhat-developer/repos","events_url":"https://api.github.com/users/redhat-developer/events{/privacy}","received_events_url":"https://api.github.com/users/redhat-developer/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/redhat-developer/odo","description":"OpenShift Do - Fast, iterative OpenShift development","fork":false,"url":"https://api.github.com/repos/redhat-developer/odo","forks_url":"https://api.github.com/repos/redhat-developer/odo/forks","keys_url":"https://api.github.com/repos/redhat-developer/odo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redhat-developer/odo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redhat-developer/odo/teams","hooks_url":"https://api.github.com/repos/redhat-developer/odo/hooks","issue_events_url":"https://api.github.com/repos/redhat-developer/odo/issues/events{/number}","events_url":"https://api.github.com/repos/redhat-developer/odo/events","assignees_url":"https://api.github.com/repos/redhat-developer/odo/assignees{/user}","branches_url":"https://api.github.com/repos/redhat-developer/odo/branches{/branch}","tags_url":"https://api.github.com/repos/redhat-developer/odo/tags","blobs_url":"https://api.github.com/repos/redhat-developer/odo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redhat-developer/odo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redhat-developer/odo/git/refs{/sha}","trees_url":"https://api.github.com/repos/redhat-developer/odo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redhat-developer/odo/statuses/{sha}","languages_url":"https://api.github.com/repos/redhat-developer/odo/languages","stargazers_url":"https://api.github.com/repos/redhat-developer/odo/stargazers","contributors_url":"https://api.github.com/repos/redhat-developer/odo/contributors","subscribers_url":"https://api.github.com/repos/redhat-developer/odo/subscribers","subscription_url":"https://api.github.com/repos/redhat-developer/odo/subscription","commits_url":"https://api.github.com/repos/redhat-developer/odo/commits{/sha}","git_commits_url":"https://api.github.com/repos/redhat-developer/odo/git/commits{/sha}","comments_url":"https://api.github.com/repos/redhat-developer/odo/comments{/number}","issue_comment_url":"https://api.github.com/repos/redhat-developer/odo/issues/comments{/number}","contents_url":"https://api.github.com/repos/redhat-developer/odo/contents/{+path}","compare_url":"https://api.github.com/repos/redhat-developer/odo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redhat-developer/odo/merges","archive_url":"https://api.github.com/repos/redhat-developer/odo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redhat-developer/odo/downloads","issues_url":"https://api.github.com/repos/redhat-developer/odo/issues{/number}","pulls_url":"https://api.github.com/repos/redhat-developer/odo/pulls{/number}","milestones_url":"https://api.github.com/repos/redhat-developer/odo/milestones{/number}","notifications_url":"https://api.github.com/repos/redhat-developer/odo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redhat-developer/odo/labels{/name}","releases_url":"https://api.github.com/repos/redhat-developer/odo/releases{/id}","deployments_url":"https://api.github.com/repos/redhat-developer/odo/deployments","created_at":"2018-01-23T15:36:17Z","updated_at":"2018-12-12T12:01:59Z","pushed_at":"2018-12-12T12:01:54Z","git_url":"git://github.com/redhat-developer/odo.git","ssh_url":"git@github.com:redhat-developer/odo.git","clone_url":"https://github.com/redhat-developer/odo.git","svn_url":"https://github.com/redhat-developer/odo","homepage":"","size":139152,"stargazers_count":281,"watchers_count":281,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":57,"mirror_url":null,"archived":false,"open_issues_count":155,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":57,"open_issues":155,"watchers":281,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/redhat-developer/odo/pulls/857"},"html":{"href":"https://github.com/redhat-developer/odo/pull/857"},"issue":{"href":"https://api.github.com/repos/redhat-developer/odo/issues/857"},"comments":{"href":"https://api.github.com/repos/redhat-developer/odo/issues/857/comments"},"review_comments":{"href":"https://api.github.com/repos/redhat-developer/odo/pulls/857/comments"},"review_comment":{"href":"https://api.github.com/repos/redhat-developer/odo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/redhat-developer/odo/pulls/857/commits"},"statuses":{"href":"https://api.github.com/repos/redhat-developer/odo/statuses/4d27c1ae67913d99e0bce2f96f29521d2d56f1bc"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"metacosm"}}