{"action":"created","comment":{"url":"https://api.github.com/repos/kids-first/kf-api-dataservice/pulls/comments/196143373","pull_request_review_id":129640284,"id":196143373,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjE0MzM3Mw==","diff_hunk":"@@ -20,6 +22,15 @@ class DiagnosisSchema(BaseSchema):\n     diagnosis_category = field_for(Diagnosis, 'diagnosis_category',\n                                    validate=enum_validation_generator(\n                                        DIAGNOSIS_CATEGORY_ENUM))\n+    mondo_id_diagnosis = FieldValidator(attribute='mondo_id_diagnosis',\n+                                        validate=validate_ontology_id_prefix)\n+    icd_id_diagnosis = FieldValidator(attribute='icd_id_diagnosis',\n+                                      validate=validate_ontology_id_prefix)\n+    uberon_id_tumor_location = FieldValidator(\n+        attribute='uberon_id_tumor_location',\n+        validate=validate_ontology_id_prefix)\n+    ncit_id_diagnosis = FieldValidator(attribute='ncit_id_diagnosis',\n+                                       validate=validate_ontology_id_prefix)","path":"dataservice/api/diagnosis/schemas.py","position":23,"original_position":23,"commit_id":"1b1de9c9aa35c1b38dc634f7396b0ed08714080a","original_commit_id":"1b1de9c9aa35c1b38dc634f7396b0ed08714080a","user":{"login":"dankolbman","id":2495894,"node_id":"MDQ6VXNlcjI0OTU4OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2495894?v=4","gravatar_id":"","url":"https://api.github.com/users/dankolbman","html_url":"https://github.com/dankolbman","followers_url":"https://api.github.com/users/dankolbman/followers","following_url":"https://api.github.com/users/dankolbman/following{/other_user}","gists_url":"https://api.github.com/users/dankolbman/gists{/gist_id}","starred_url":"https://api.github.com/users/dankolbman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dankolbman/subscriptions","organizations_url":"https://api.github.com/users/dankolbman/orgs","repos_url":"https://api.github.com/users/dankolbman/repos","events_url":"https://api.github.com/users/dankolbman/events{/privacy}","received_events_url":"https://api.github.com/users/dankolbman/received_events","type":"User","site_admin":false},"body":"maybe `validate_ontology_id_prefix` could be a generator that takes a prefix and returns a function that validates that field using the prefix? That way lookup dict won't be needed and you won't have to pass attributes to it.","created_at":"2018-06-18T16:30:42Z","updated_at":"2018-06-18T16:30:46Z","html_url":"https://github.com/kids-first/kf-api-dataservice/pull/338#discussion_r196143373","pull_request_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/pulls/338","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kids-first/kf-api-dataservice/pulls/comments/196143373"},"html":{"href":"https://github.com/kids-first/kf-api-dataservice/pull/338#discussion_r196143373"},"pull_request":{"href":"https://api.github.com/repos/kids-first/kf-api-dataservice/pulls/338"}}},"pull_request":{"url":"https://api.github.com/repos/kids-first/kf-api-dataservice/pulls/338","id":187972013,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg3OTcyMDEz","html_url":"https://github.com/kids-first/kf-api-dataservice/pull/338","diff_url":"https://github.com/kids-first/kf-api-dataservice/pull/338.diff","patch_url":"https://github.com/kids-first/kf-api-dataservice/pull/338.patch","issue_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/issues/338","number":338,"state":"open","locked":false,"title":"✨Add ontology prefix validation","user":{"login":"parimalak","id":20447220,"node_id":"MDQ6VXNlcjIwNDQ3MjIw","avatar_url":"https://avatars2.githubusercontent.com/u/20447220?v=4","gravatar_id":"","url":"https://api.github.com/users/parimalak","html_url":"https://github.com/parimalak","followers_url":"https://api.github.com/users/parimalak/followers","following_url":"https://api.github.com/users/parimalak/following{/other_user}","gists_url":"https://api.github.com/users/parimalak/gists{/gist_id}","starred_url":"https://api.github.com/users/parimalak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parimalak/subscriptions","organizations_url":"https://api.github.com/users/parimalak/orgs","repos_url":"https://api.github.com/users/parimalak/repos","events_url":"https://api.github.com/users/parimalak/events{/privacy}","received_events_url":"https://api.github.com/users/parimalak/received_events","type":"User","site_admin":false},"body":"\r\n","created_at":"2018-05-14T22:52:19Z","updated_at":"2018-06-18T16:30:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70ff789cccedb2632093c0738edd8fd0f96b629d","assignee":{"login":"parimalak","id":20447220,"node_id":"MDQ6VXNlcjIwNDQ3MjIw","avatar_url":"https://avatars2.githubusercontent.com/u/20447220?v=4","gravatar_id":"","url":"https://api.github.com/users/parimalak","html_url":"https://github.com/parimalak","followers_url":"https://api.github.com/users/parimalak/followers","following_url":"https://api.github.com/users/parimalak/following{/other_user}","gists_url":"https://api.github.com/users/parimalak/gists{/gist_id}","starred_url":"https://api.github.com/users/parimalak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parimalak/subscriptions","organizations_url":"https://api.github.com/users/parimalak/orgs","repos_url":"https://api.github.com/users/parimalak/repos","events_url":"https://api.github.com/users/parimalak/events{/privacy}","received_events_url":"https://api.github.com/users/parimalak/received_events","type":"User","site_admin":false},"assignees":[{"login":"parimalak","id":20447220,"node_id":"MDQ6VXNlcjIwNDQ3MjIw","avatar_url":"https://avatars2.githubusercontent.com/u/20447220?v=4","gravatar_id":"","url":"https://api.github.com/users/parimalak","html_url":"https://github.com/parimalak","followers_url":"https://api.github.com/users/parimalak/followers","following_url":"https://api.github.com/users/parimalak/following{/other_user}","gists_url":"https://api.github.com/users/parimalak/gists{/gist_id}","starred_url":"https://api.github.com/users/parimalak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parimalak/subscriptions","organizations_url":"https://api.github.com/users/parimalak/orgs","repos_url":"https://api.github.com/users/parimalak/repos","events_url":"https://api.github.com/users/parimalak/events{/privacy}","received_events_url":"https://api.github.com/users/parimalak/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"znatty22","id":10283712,"node_id":"MDQ6VXNlcjEwMjgzNzEy","avatar_url":"https://avatars2.githubusercontent.com/u/10283712?v=4","gravatar_id":"","url":"https://api.github.com/users/znatty22","html_url":"https://github.com/znatty22","followers_url":"https://api.github.com/users/znatty22/followers","following_url":"https://api.github.com/users/znatty22/following{/other_user}","gists_url":"https://api.github.com/users/znatty22/gists{/gist_id}","starred_url":"https://api.github.com/users/znatty22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/znatty22/subscriptions","organizations_url":"https://api.github.com/users/znatty22/orgs","repos_url":"https://api.github.com/users/znatty22/repos","events_url":"https://api.github.com/users/znatty22/events{/privacy}","received_events_url":"https://api.github.com/users/znatty22/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":890251781,"node_id":"MDU6TGFiZWw4OTAyNTE3ODE=","url":"https://api.github.com/repos/kids-first/kf-api-dataservice/labels/Ready%20for%20review","name":"Ready for review","color":"0bd6ed","default":false},{"id":799831732,"node_id":"MDU6TGFiZWw3OTk4MzE3MzI=","url":"https://api.github.com/repos/kids-first/kf-api-dataservice/labels/feature","name":"feature","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/pulls/338/commits","review_comments_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/pulls/338/comments","review_comment_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/issues/338/comments","statuses_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/statuses/1b1de9c9aa35c1b38dc634f7396b0ed08714080a","head":{"label":"kids-first:pre-onto","ref":"pre-onto","sha":"1b1de9c9aa35c1b38dc634f7396b0ed08714080a","user":{"login":"kids-first","id":29782953,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzgyOTUz","avatar_url":"https://avatars2.githubusercontent.com/u/29782953?v=4","gravatar_id":"","url":"https://api.github.com/users/kids-first","html_url":"https://github.com/kids-first","followers_url":"https://api.github.com/users/kids-first/followers","following_url":"https://api.github.com/users/kids-first/following{/other_user}","gists_url":"https://api.github.com/users/kids-first/gists{/gist_id}","starred_url":"https://api.github.com/users/kids-first/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kids-first/subscriptions","organizations_url":"https://api.github.com/users/kids-first/orgs","repos_url":"https://api.github.com/users/kids-first/repos","events_url":"https://api.github.com/users/kids-first/events{/privacy}","received_events_url":"https://api.github.com/users/kids-first/received_events","type":"Organization","site_admin":false},"repo":{"id":116870795,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY4NzA3OTU=","name":"kf-api-dataservice","full_name":"kids-first/kf-api-dataservice","owner":{"login":"kids-first","id":29782953,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzgyOTUz","avatar_url":"https://avatars2.githubusercontent.com/u/29782953?v=4","gravatar_id":"","url":"https://api.github.com/users/kids-first","html_url":"https://github.com/kids-first","followers_url":"https://api.github.com/users/kids-first/followers","following_url":"https://api.github.com/users/kids-first/following{/other_user}","gists_url":"https://api.github.com/users/kids-first/gists{/gist_id}","starred_url":"https://api.github.com/users/kids-first/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kids-first/subscriptions","organizations_url":"https://api.github.com/users/kids-first/orgs","repos_url":"https://api.github.com/users/kids-first/repos","events_url":"https://api.github.com/users/kids-first/events{/privacy}","received_events_url":"https://api.github.com/users/kids-first/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kids-first/kf-api-dataservice","description":":file_cabinet: Primary API for interacting with the Kids First data","fork":false,"url":"https://api.github.com/repos/kids-first/kf-api-dataservice","forks_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/forks","keys_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/teams","hooks_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/hooks","issue_events_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/issues/events{/number}","events_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/events","assignees_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/assignees{/user}","branches_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/branches{/branch}","tags_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/tags","blobs_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/git/refs{/sha}","trees_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/statuses/{sha}","languages_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/languages","stargazers_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/stargazers","contributors_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/contributors","subscribers_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/subscribers","subscription_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/subscription","commits_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/commits{/sha}","git_commits_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/git/commits{/sha}","comments_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/comments{/number}","issue_comment_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/issues/comments{/number}","contents_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/contents/{+path}","compare_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/merges","archive_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/downloads","issues_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/issues{/number}","pulls_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/pulls{/number}","milestones_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/milestones{/number}","notifications_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/labels{/name}","releases_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/releases{/id}","deployments_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/deployments","created_at":"2018-01-09T21:06:39Z","updated_at":"2018-06-18T16:22:26Z","pushed_at":"2018-06-18T16:22:51Z","git_url":"git://github.com/kids-first/kf-api-dataservice.git","ssh_url":"git@github.com:kids-first/kf-api-dataservice.git","clone_url":"https://github.com/kids-first/kf-api-dataservice.git","svn_url":"https://github.com/kids-first/kf-api-dataservice","homepage":"http://kf-api-dataservice-qa.kids-first.io","size":13848,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":53,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":53,"watchers":1,"default_branch":"master"}},"base":{"label":"kids-first:master","ref":"master","sha":"b7b5ab2c38c821c4493a6f081323f4c6018a6fc4","user":{"login":"kids-first","id":29782953,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzgyOTUz","avatar_url":"https://avatars2.githubusercontent.com/u/29782953?v=4","gravatar_id":"","url":"https://api.github.com/users/kids-first","html_url":"https://github.com/kids-first","followers_url":"https://api.github.com/users/kids-first/followers","following_url":"https://api.github.com/users/kids-first/following{/other_user}","gists_url":"https://api.github.com/users/kids-first/gists{/gist_id}","starred_url":"https://api.github.com/users/kids-first/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kids-first/subscriptions","organizations_url":"https://api.github.com/users/kids-first/orgs","repos_url":"https://api.github.com/users/kids-first/repos","events_url":"https://api.github.com/users/kids-first/events{/privacy}","received_events_url":"https://api.github.com/users/kids-first/received_events","type":"Organization","site_admin":false},"repo":{"id":116870795,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY4NzA3OTU=","name":"kf-api-dataservice","full_name":"kids-first/kf-api-dataservice","owner":{"login":"kids-first","id":29782953,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzgyOTUz","avatar_url":"https://avatars2.githubusercontent.com/u/29782953?v=4","gravatar_id":"","url":"https://api.github.com/users/kids-first","html_url":"https://github.com/kids-first","followers_url":"https://api.github.com/users/kids-first/followers","following_url":"https://api.github.com/users/kids-first/following{/other_user}","gists_url":"https://api.github.com/users/kids-first/gists{/gist_id}","starred_url":"https://api.github.com/users/kids-first/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kids-first/subscriptions","organizations_url":"https://api.github.com/users/kids-first/orgs","repos_url":"https://api.github.com/users/kids-first/repos","events_url":"https://api.github.com/users/kids-first/events{/privacy}","received_events_url":"https://api.github.com/users/kids-first/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kids-first/kf-api-dataservice","description":":file_cabinet: Primary API for interacting with the Kids First data","fork":false,"url":"https://api.github.com/repos/kids-first/kf-api-dataservice","forks_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/forks","keys_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/teams","hooks_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/hooks","issue_events_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/issues/events{/number}","events_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/events","assignees_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/assignees{/user}","branches_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/branches{/branch}","tags_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/tags","blobs_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/git/refs{/sha}","trees_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/statuses/{sha}","languages_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/languages","stargazers_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/stargazers","contributors_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/contributors","subscribers_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/subscribers","subscription_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/subscription","commits_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/commits{/sha}","git_commits_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/git/commits{/sha}","comments_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/comments{/number}","issue_comment_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/issues/comments{/number}","contents_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/contents/{+path}","compare_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/merges","archive_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/downloads","issues_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/issues{/number}","pulls_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/pulls{/number}","milestones_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/milestones{/number}","notifications_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/labels{/name}","releases_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/releases{/id}","deployments_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/deployments","created_at":"2018-01-09T21:06:39Z","updated_at":"2018-06-18T16:22:26Z","pushed_at":"2018-06-18T16:22:51Z","git_url":"git://github.com/kids-first/kf-api-dataservice.git","ssh_url":"git@github.com:kids-first/kf-api-dataservice.git","clone_url":"https://github.com/kids-first/kf-api-dataservice.git","svn_url":"https://github.com/kids-first/kf-api-dataservice","homepage":"http://kf-api-dataservice-qa.kids-first.io","size":13848,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":53,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":53,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kids-first/kf-api-dataservice/pulls/338"},"html":{"href":"https://github.com/kids-first/kf-api-dataservice/pull/338"},"issue":{"href":"https://api.github.com/repos/kids-first/kf-api-dataservice/issues/338"},"comments":{"href":"https://api.github.com/repos/kids-first/kf-api-dataservice/issues/338/comments"},"review_comments":{"href":"https://api.github.com/repos/kids-first/kf-api-dataservice/pulls/338/comments"},"review_comment":{"href":"https://api.github.com/repos/kids-first/kf-api-dataservice/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kids-first/kf-api-dataservice/pulls/338/commits"},"statuses":{"href":"https://api.github.com/repos/kids-first/kf-api-dataservice/statuses/1b1de9c9aa35c1b38dc634f7396b0ed08714080a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dankolbman"}}