{"action":"created","comment":{"url":"https://api.github.com/repos/mapsme/omim/pulls/comments/194229540","pull_request_review_id":127368762,"id":194229540,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDIyOTU0MA==","diff_hunk":"@@ -62,19 +78,28 @@ double VehicleModel::GetSpeed(FeatureType const & f) const\n double VehicleModel::GetMinTypeSpeed(feature::TypesHolder const & types) const\n {\n   double speed = m_maxSpeedKMpH * 2;\n+  // Decreasing speed factor based on road surface (cover).\n+  double speedFactor = 1.0;\n   for (uint32_t t : types)\n   {\n     uint32_t const type = ftypes::BaseChecker::PrepareToMatch(t, 2);\n-    auto it = m_types.find(type);\n-    if (it != m_types.end())\n-      speed = min(speed, it->second.GetSpeedKMpH());\n+    auto itHighway = m_highwayTypes.find(type);","path":"routing_common/vehicle_model.cpp","position":56,"original_position":56,"commit_id":"b28c384b9672c0974fa7b1d51ae6ab1999733070","original_commit_id":"b28c384b9672c0974fa7b1d51ae6ab1999733070","user":{"login":"bykoianko","id":1768114,"node_id":"MDQ6VXNlcjE3NjgxMTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1768114?v=4","gravatar_id":"","url":"https://api.github.com/users/bykoianko","html_url":"https://github.com/bykoianko","followers_url":"https://api.github.com/users/bykoianko/followers","following_url":"https://api.github.com/users/bykoianko/following{/other_user}","gists_url":"https://api.github.com/users/bykoianko/gists{/gist_id}","starred_url":"https://api.github.com/users/bykoianko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bykoianko/subscriptions","organizations_url":"https://api.github.com/users/bykoianko/orgs","repos_url":"https://api.github.com/users/bykoianko/repos","events_url":"https://api.github.com/users/bykoianko/events{/privacy}","received_events_url":"https://api.github.com/users/bykoianko/received_events","type":"User","site_admin":false},"body":"Done. It was old code.","created_at":"2018-06-09T14:38:17Z","updated_at":"2018-06-09T14:38:18Z","html_url":"https://github.com/mapsme/omim/pull/8850#discussion_r194229540","pull_request_url":"https://api.github.com/repos/mapsme/omim/pulls/8850","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments/194229540"},"html":{"href":"https://github.com/mapsme/omim/pull/8850#discussion_r194229540"},"pull_request":{"href":"https://api.github.com/repos/mapsme/omim/pulls/8850"}},"in_reply_to_id":194225410},"pull_request":{"url":"https://api.github.com/repos/mapsme/omim/pulls/8850","id":193626957,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNjI2OTU3","html_url":"https://github.com/mapsme/omim/pull/8850","diff_url":"https://github.com/mapsme/omim/pull/8850.diff","patch_url":"https://github.com/mapsme/omim/pull/8850.patch","issue_url":"https://api.github.com/repos/mapsme/omim/issues/8850","number":8850,"state":"open","locked":false,"title":" [routing] Taking into account road surface type for speed calculating.","user":{"login":"bykoianko","id":1768114,"node_id":"MDQ6VXNlcjE3NjgxMTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1768114?v=4","gravatar_id":"","url":"https://api.github.com/users/bykoianko","html_url":"https://github.com/bykoianko","followers_url":"https://api.github.com/users/bykoianko/followers","following_url":"https://api.github.com/users/bykoianko/following{/other_user}","gists_url":"https://api.github.com/users/bykoianko/gists{/gist_id}","starred_url":"https://api.github.com/users/bykoianko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bykoianko/subscriptions","organizations_url":"https://api.github.com/users/bykoianko/orgs","repos_url":"https://api.github.com/users/bykoianko/repos","events_url":"https://api.github.com/users/bykoianko/events{/privacy}","received_events_url":"https://api.github.com/users/bykoianko/received_events","type":"User","site_admin":false},"body":"Учет дорожного покрытия при расчете скорости на фиче.\r\n\r\nВ мае 2016 @Zverik в геометрию (а не в meta data) добавил св-во:\r\npsurface|paved_good\r\npsurface|paved_bad\r\npsurface|unpaved_good\r\npsurface|unpaved_bad\r\n\r\nТ.о. любая дорога может содержать информацию о качестве покрытия, которая влияет на скорость на данной дороге.\r\n\r\nДанный PR вводит понижающие коэффициент для каждого типа покрытий. Т.е. скорость на фиче рассчитывается (грубо), как скорость заданная для highway класса умножить на понижающей коэффициент. \r\n\r\nЗаданы отдельные наборы коэффициентов  для авто, вело и пешего роутинга.\r\n\r\n@tatiana-yan @mpimenov @Zverik PTAL","created_at":"2018-06-08T14:14:01Z","updated_at":"2018-06-09T14:38:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5594d55be9ab68bf422823e98aba61764cf8fe7d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tatiana-yan","id":9213190,"node_id":"MDQ6VXNlcjkyMTMxOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/9213190?v=4","gravatar_id":"","url":"https://api.github.com/users/tatiana-yan","html_url":"https://github.com/tatiana-yan","followers_url":"https://api.github.com/users/tatiana-yan/followers","following_url":"https://api.github.com/users/tatiana-yan/following{/other_user}","gists_url":"https://api.github.com/users/tatiana-yan/gists{/gist_id}","starred_url":"https://api.github.com/users/tatiana-yan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatiana-yan/subscriptions","organizations_url":"https://api.github.com/users/tatiana-yan/orgs","repos_url":"https://api.github.com/users/tatiana-yan/repos","events_url":"https://api.github.com/users/tatiana-yan/events{/privacy}","received_events_url":"https://api.github.com/users/tatiana-yan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapsme/omim/pulls/8850/commits","review_comments_url":"https://api.github.com/repos/mapsme/omim/pulls/8850/comments","review_comment_url":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapsme/omim/issues/8850/comments","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/b28c384b9672c0974fa7b1d51ae6ab1999733070","head":{"label":"bykoianko:master-surface-type","ref":"master-surface-type","sha":"b28c384b9672c0974fa7b1d51ae6ab1999733070","user":{"login":"bykoianko","id":1768114,"node_id":"MDQ6VXNlcjE3NjgxMTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1768114?v=4","gravatar_id":"","url":"https://api.github.com/users/bykoianko","html_url":"https://github.com/bykoianko","followers_url":"https://api.github.com/users/bykoianko/followers","following_url":"https://api.github.com/users/bykoianko/following{/other_user}","gists_url":"https://api.github.com/users/bykoianko/gists{/gist_id}","starred_url":"https://api.github.com/users/bykoianko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bykoianko/subscriptions","organizations_url":"https://api.github.com/users/bykoianko/orgs","repos_url":"https://api.github.com/users/bykoianko/repos","events_url":"https://api.github.com/users/bykoianko/events{/privacy}","received_events_url":"https://api.github.com/users/bykoianko/received_events","type":"User","site_admin":false},"repo":{"id":43428862,"node_id":"MDEwOlJlcG9zaXRvcnk0MzQyODg2Mg==","name":"omim","full_name":"bykoianko/omim","owner":{"login":"bykoianko","id":1768114,"node_id":"MDQ6VXNlcjE3NjgxMTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1768114?v=4","gravatar_id":"","url":"https://api.github.com/users/bykoianko","html_url":"https://github.com/bykoianko","followers_url":"https://api.github.com/users/bykoianko/followers","following_url":"https://api.github.com/users/bykoianko/following{/other_user}","gists_url":"https://api.github.com/users/bykoianko/gists{/gist_id}","starred_url":"https://api.github.com/users/bykoianko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bykoianko/subscriptions","organizations_url":"https://api.github.com/users/bykoianko/orgs","repos_url":"https://api.github.com/users/bykoianko/repos","events_url":"https://api.github.com/users/bykoianko/events{/privacy}","received_events_url":"https://api.github.com/users/bykoianko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bykoianko/omim","description":"MAPS.ME - Offline OpenStreetMap maps for iOS/Android/Mac/Linux/Windows","fork":true,"url":"https://api.github.com/repos/bykoianko/omim","forks_url":"https://api.github.com/repos/bykoianko/omim/forks","keys_url":"https://api.github.com/repos/bykoianko/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bykoianko/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bykoianko/omim/teams","hooks_url":"https://api.github.com/repos/bykoianko/omim/hooks","issue_events_url":"https://api.github.com/repos/bykoianko/omim/issues/events{/number}","events_url":"https://api.github.com/repos/bykoianko/omim/events","assignees_url":"https://api.github.com/repos/bykoianko/omim/assignees{/user}","branches_url":"https://api.github.com/repos/bykoianko/omim/branches{/branch}","tags_url":"https://api.github.com/repos/bykoianko/omim/tags","blobs_url":"https://api.github.com/repos/bykoianko/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bykoianko/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bykoianko/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/bykoianko/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bykoianko/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/bykoianko/omim/languages","stargazers_url":"https://api.github.com/repos/bykoianko/omim/stargazers","contributors_url":"https://api.github.com/repos/bykoianko/omim/contributors","subscribers_url":"https://api.github.com/repos/bykoianko/omim/subscribers","subscription_url":"https://api.github.com/repos/bykoianko/omim/subscription","commits_url":"https://api.github.com/repos/bykoianko/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/bykoianko/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/bykoianko/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/bykoianko/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/bykoianko/omim/contents/{+path}","compare_url":"https://api.github.com/repos/bykoianko/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bykoianko/omim/merges","archive_url":"https://api.github.com/repos/bykoianko/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bykoianko/omim/downloads","issues_url":"https://api.github.com/repos/bykoianko/omim/issues{/number}","pulls_url":"https://api.github.com/repos/bykoianko/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/bykoianko/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/bykoianko/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bykoianko/omim/labels{/name}","releases_url":"https://api.github.com/repos/bykoianko/omim/releases{/id}","deployments_url":"https://api.github.com/repos/bykoianko/omim/deployments","created_at":"2015-09-30T11:21:20Z","updated_at":"2018-03-15T15:16:23Z","pushed_at":"2018-06-09T08:24:18Z","git_url":"git://github.com/bykoianko/omim.git","ssh_url":"git@github.com:bykoianko/omim.git","clone_url":"https://github.com/bykoianko/omim.git","svn_url":"https://github.com/bykoianko/omim","homepage":null,"size":3788656,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapsme:master","ref":"master","sha":"1b8e60abad25a62cbd15b3473fc76563c7d92d62","user":{"login":"mapsme","id":14185141,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTg1MTQx","avatar_url":"https://avatars1.githubusercontent.com/u/14185141?v=4","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"repo":{"id":42798033,"node_id":"MDEwOlJlcG9zaXRvcnk0Mjc5ODAzMw==","name":"omim","full_name":"mapsme/omim","owner":{"login":"mapsme","id":14185141,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTg1MTQx","avatar_url":"https://avatars1.githubusercontent.com/u/14185141?v=4","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapsme/omim","description":"🗺️ MAPS.ME — Offline OpenStreetMap maps for iOS and Android","fork":false,"url":"https://api.github.com/repos/mapsme/omim","forks_url":"https://api.github.com/repos/mapsme/omim/forks","keys_url":"https://api.github.com/repos/mapsme/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapsme/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapsme/omim/teams","hooks_url":"https://api.github.com/repos/mapsme/omim/hooks","issue_events_url":"https://api.github.com/repos/mapsme/omim/issues/events{/number}","events_url":"https://api.github.com/repos/mapsme/omim/events","assignees_url":"https://api.github.com/repos/mapsme/omim/assignees{/user}","branches_url":"https://api.github.com/repos/mapsme/omim/branches{/branch}","tags_url":"https://api.github.com/repos/mapsme/omim/tags","blobs_url":"https://api.github.com/repos/mapsme/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapsme/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapsme/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapsme/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/mapsme/omim/languages","stargazers_url":"https://api.github.com/repos/mapsme/omim/stargazers","contributors_url":"https://api.github.com/repos/mapsme/omim/contributors","subscribers_url":"https://api.github.com/repos/mapsme/omim/subscribers","subscription_url":"https://api.github.com/repos/mapsme/omim/subscription","commits_url":"https://api.github.com/repos/mapsme/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapsme/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapsme/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapsme/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapsme/omim/contents/{+path}","compare_url":"https://api.github.com/repos/mapsme/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapsme/omim/merges","archive_url":"https://api.github.com/repos/mapsme/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapsme/omim/downloads","issues_url":"https://api.github.com/repos/mapsme/omim/issues{/number}","pulls_url":"https://api.github.com/repos/mapsme/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/mapsme/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/mapsme/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapsme/omim/labels{/name}","releases_url":"https://api.github.com/repos/mapsme/omim/releases{/id}","deployments_url":"https://api.github.com/repos/mapsme/omim/deployments","created_at":"2015-09-20T02:57:13Z","updated_at":"2018-06-08T23:23:47Z","pushed_at":"2018-06-09T14:02:51Z","git_url":"git://github.com/mapsme/omim.git","ssh_url":"git@github.com:mapsme/omim.git","clone_url":"https://github.com/mapsme/omim.git","svn_url":"https://github.com/mapsme/omim","homepage":"","size":3945190,"stargazers_count":2678,"watchers_count":2678,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":578,"mirror_url":null,"archived":false,"open_issues_count":706,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":578,"open_issues":706,"watchers":2678,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/8850"},"html":{"href":"https://github.com/mapsme/omim/pull/8850"},"issue":{"href":"https://api.github.com/repos/mapsme/omim/issues/8850"},"comments":{"href":"https://api.github.com/repos/mapsme/omim/issues/8850/comments"},"review_comments":{"href":"https://api.github.com/repos/mapsme/omim/pulls/8850/comments"},"review_comment":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapsme/omim/pulls/8850/commits"},"statuses":{"href":"https://api.github.com/repos/mapsme/omim/statuses/b28c384b9672c0974fa7b1d51ae6ab1999733070"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bykoianko"}}