{"action":"created","comment":{"url":"https://api.github.com/repos/gentoo/gentoo/pulls/comments/187782828","pull_request_review_id":119636498,"id":187782828,"diff_hunk":"@@ -0,0 +1,93 @@\n+# Copyright 1999-2018 Gentoo Foundation\n+# Distributed under the terms of the GNU General Public License v2\n+\n+EAPI=6\n+PYTHON_COMPAT=( python3_4 python3_5 python3_6 )\n+\n+inherit python-single-r1 xdg\n+\n+DESCRIPTION=\"A curses-based client for Tox.\"\n+HOMEPAGE=\"https://github.com/JFreegman/toxic\"\n+SRC_URI=\"https://github.com/JFreegman/toxic/archive/v${PV}.tar.gz -> ${P}.tar.gz\"\n+\n+LICENSE=\"GPL-3\"\n+SLOT=\"0\"\n+KEYWORDS=\"~amd64 ~x86\"\n+IUSE=\"+X +audio notifications +python qrpng +video\"\n+REQUIRED_USE=\"python? ( ${PYTHON_REQUIRED_USE} )\"\n+\n+# Not a typo; net-libs/tox only has a 'both or neither' option\n+RDEPEND=\"\n+\t|| (\n+\taudio? ( net-libs/tox:0/0.1[av] )\n+\tvideo? ( net-libs/tox:0/0.1[av] )\n+\tnet-libs/tox:0/0.1\n+\t)\n+\tdev-libs/libconfig\n+\tmedia-gfx/qrencode\n+\tmedia-libs/libpng:0=","path":"net-im/toxic/toxic-0.8.0-r2.ebuild","position":null,"original_position":28,"commit_id":"660df5fb461f5b08ffd5f61f5ebcb0830d24dc78","original_commit_id":"1dab58fd6a88fc3fda0f180d0e1f507c02754135","user":{"login":"mgorny","id":110765,"avatar_url":"https://avatars1.githubusercontent.com/u/110765?v=4","gravatar_id":"","url":"https://api.github.com/users/mgorny","html_url":"https://github.com/mgorny","followers_url":"https://api.github.com/users/mgorny/followers","following_url":"https://api.github.com/users/mgorny/following{/other_user}","gists_url":"https://api.github.com/users/mgorny/gists{/gist_id}","starred_url":"https://api.github.com/users/mgorny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgorny/subscriptions","organizations_url":"https://api.github.com/users/mgorny/orgs","repos_url":"https://api.github.com/users/mgorny/repos","events_url":"https://api.github.com/users/mgorny/events{/privacy}","received_events_url":"https://api.github.com/users/mgorny/received_events","type":"User","site_admin":false},"body":"You're going too far in context. If this package has optional PNG support, and you expose it via USE flag, you should also make the dependency optional. Otherwise, the package built with `USE=-qrpng` has a dependency on libpng even though it doesn't use it.\r\n\r\nOf course, whether disabling PNG support makes any sense is another question. If it doesn't, you can remove the flag entirely and keep it always on.\r\n\r\nJust don't do it halfway, please.","created_at":"2018-05-12T20:43:24Z","updated_at":"2018-05-12T20:43:24Z","html_url":"https://github.com/gentoo/gentoo/pull/8271#discussion_r187782828","pull_request_url":"https://api.github.com/repos/gentoo/gentoo/pulls/8271","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/gentoo/gentoo/pulls/comments/187782828"},"html":{"href":"https://github.com/gentoo/gentoo/pull/8271#discussion_r187782828"},"pull_request":{"href":"https://api.github.com/repos/gentoo/gentoo/pulls/8271"}},"in_reply_to_id":187778903},"pull_request":{"url":"https://api.github.com/repos/gentoo/gentoo/pulls/8271","id":186163533,"html_url":"https://github.com/gentoo/gentoo/pull/8271","diff_url":"https://github.com/gentoo/gentoo/pull/8271.diff","patch_url":"https://github.com/gentoo/gentoo/pull/8271.patch","issue_url":"https://api.github.com/repos/gentoo/gentoo/issues/8271","number":8271,"state":"open","locked":false,"title":"net-im/toxic-0.8.0-r3: Revision bump to fix dependencies","user":{"login":"kitsunenokenja","id":16778803,"avatar_url":"https://avatars2.githubusercontent.com/u/16778803?v=4","gravatar_id":"","url":"https://api.github.com/users/kitsunenokenja","html_url":"https://github.com/kitsunenokenja","followers_url":"https://api.github.com/users/kitsunenokenja/followers","following_url":"https://api.github.com/users/kitsunenokenja/following{/other_user}","gists_url":"https://api.github.com/users/kitsunenokenja/gists{/gist_id}","starred_url":"https://api.github.com/users/kitsunenokenja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitsunenokenja/subscriptions","organizations_url":"https://api.github.com/users/kitsunenokenja/orgs","repos_url":"https://api.github.com/users/kitsunenokenja/repos","events_url":"https://api.github.com/users/kitsunenokenja/events{/privacy}","received_events_url":"https://api.github.com/users/kitsunenokenja/received_events","type":"User","site_admin":false},"body":"This revision of the ebuild fixes a build failure when compiling with `USE=\"-qrencode\"`. The qrencode library is actually a required dependency; attempting to compile without it will cause the build of `qt_encode.c` to fail upon the `#include <qtencode.h>` statement. What is optional at build time is the PNG support that the qrencode library provides, which is properly configured in upstream's Makefile.\r\n\r\nReferences:\r\n\r\nhttps://github.com/JFreegman/toxic/blob/master/INSTALL.md (Confirms the qrencode library is required by the base package)\r\nhttps://github.com/JFreegman/toxic/blob/master/cfg/checks/check_features.mk\r\nhttps://github.com/JFreegman/toxic/blob/master/Makefile\r\n\r\nhttps://github.com/JFreegman/toxic/blob/master/src/qr_code.c\r\nSource exhibits the existential macro for the PNG support but the usage of qrencode overall is required.\r\n\r\nNote: Upstream is at 0.8.2 but the changes in that version did not contain relevant commits that affect this review.","created_at":"2018-05-05T16:14:36Z","updated_at":"2018-05-12T20:43:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc1f9096020900f34ec034e760058679e2c834d9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":257560845,"url":"https://api.github.com/repos/gentoo/gentoo/labels/assigned","name":"assigned","color":"5319e7","default":false},{"id":263047939,"url":"https://api.github.com/repos/gentoo/gentoo/labels/maintainer-needed","name":"maintainer-needed","color":"d4c5f9","default":false},{"id":740399504,"url":"https://api.github.com/repos/gentoo/gentoo/labels/no%20bug%20found","name":"no bug found","color":"b78a0e","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/gentoo/gentoo/pulls/8271/commits","review_comments_url":"https://api.github.com/repos/gentoo/gentoo/pulls/8271/comments","review_comment_url":"https://api.github.com/repos/gentoo/gentoo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gentoo/gentoo/issues/8271/comments","statuses_url":"https://api.github.com/repos/gentoo/gentoo/statuses/660df5fb461f5b08ffd5f61f5ebcb0830d24dc78","head":{"label":"kitsunenokenja:toxic","ref":"toxic","sha":"660df5fb461f5b08ffd5f61f5ebcb0830d24dc78","user":{"login":"kitsunenokenja","id":16778803,"avatar_url":"https://avatars2.githubusercontent.com/u/16778803?v=4","gravatar_id":"","url":"https://api.github.com/users/kitsunenokenja","html_url":"https://github.com/kitsunenokenja","followers_url":"https://api.github.com/users/kitsunenokenja/followers","following_url":"https://api.github.com/users/kitsunenokenja/following{/other_user}","gists_url":"https://api.github.com/users/kitsunenokenja/gists{/gist_id}","starred_url":"https://api.github.com/users/kitsunenokenja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitsunenokenja/subscriptions","organizations_url":"https://api.github.com/users/kitsunenokenja/orgs","repos_url":"https://api.github.com/users/kitsunenokenja/repos","events_url":"https://api.github.com/users/kitsunenokenja/events{/privacy}","received_events_url":"https://api.github.com/users/kitsunenokenja/received_events","type":"User","site_admin":false},"repo":{"id":115846510,"name":"gentoo","full_name":"kitsunenokenja/gentoo","owner":{"login":"kitsunenokenja","id":16778803,"avatar_url":"https://avatars2.githubusercontent.com/u/16778803?v=4","gravatar_id":"","url":"https://api.github.com/users/kitsunenokenja","html_url":"https://github.com/kitsunenokenja","followers_url":"https://api.github.com/users/kitsunenokenja/followers","following_url":"https://api.github.com/users/kitsunenokenja/following{/other_user}","gists_url":"https://api.github.com/users/kitsunenokenja/gists{/gist_id}","starred_url":"https://api.github.com/users/kitsunenokenja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitsunenokenja/subscriptions","organizations_url":"https://api.github.com/users/kitsunenokenja/orgs","repos_url":"https://api.github.com/users/kitsunenokenja/repos","events_url":"https://api.github.com/users/kitsunenokenja/events{/privacy}","received_events_url":"https://api.github.com/users/kitsunenokenja/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kitsunenokenja/gentoo","description":"The official mirror of the Gentoo ebuild repository","fork":true,"url":"https://api.github.com/repos/kitsunenokenja/gentoo","forks_url":"https://api.github.com/repos/kitsunenokenja/gentoo/forks","keys_url":"https://api.github.com/repos/kitsunenokenja/gentoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kitsunenokenja/gentoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kitsunenokenja/gentoo/teams","hooks_url":"https://api.github.com/repos/kitsunenokenja/gentoo/hooks","issue_events_url":"https://api.github.com/repos/kitsunenokenja/gentoo/issues/events{/number}","events_url":"https://api.github.com/repos/kitsunenokenja/gentoo/events","assignees_url":"https://api.github.com/repos/kitsunenokenja/gentoo/assignees{/user}","branches_url":"https://api.github.com/repos/kitsunenokenja/gentoo/branches{/branch}","tags_url":"https://api.github.com/repos/kitsunenokenja/gentoo/tags","blobs_url":"https://api.github.com/repos/kitsunenokenja/gentoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kitsunenokenja/gentoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kitsunenokenja/gentoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/kitsunenokenja/gentoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kitsunenokenja/gentoo/statuses/{sha}","languages_url":"https://api.github.com/repos/kitsunenokenja/gentoo/languages","stargazers_url":"https://api.github.com/repos/kitsunenokenja/gentoo/stargazers","contributors_url":"https://api.github.com/repos/kitsunenokenja/gentoo/contributors","subscribers_url":"https://api.github.com/repos/kitsunenokenja/gentoo/subscribers","subscription_url":"https://api.github.com/repos/kitsunenokenja/gentoo/subscription","commits_url":"https://api.github.com/repos/kitsunenokenja/gentoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/kitsunenokenja/gentoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/kitsunenokenja/gentoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/kitsunenokenja/gentoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/kitsunenokenja/gentoo/contents/{+path}","compare_url":"https://api.github.com/repos/kitsunenokenja/gentoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kitsunenokenja/gentoo/merges","archive_url":"https://api.github.com/repos/kitsunenokenja/gentoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kitsunenokenja/gentoo/downloads","issues_url":"https://api.github.com/repos/kitsunenokenja/gentoo/issues{/number}","pulls_url":"https://api.github.com/repos/kitsunenokenja/gentoo/pulls{/number}","milestones_url":"https://api.github.com/repos/kitsunenokenja/gentoo/milestones{/number}","notifications_url":"https://api.github.com/repos/kitsunenokenja/gentoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kitsunenokenja/gentoo/labels{/name}","releases_url":"https://api.github.com/repos/kitsunenokenja/gentoo/releases{/id}","deployments_url":"https://api.github.com/repos/kitsunenokenja/gentoo/deployments","created_at":"2017-12-31T06:15:04Z","updated_at":"2018-05-12T13:28:00Z","pushed_at":"2018-05-12T13:27:38Z","git_url":"git://github.com/kitsunenokenja/gentoo.git","ssh_url":"git@github.com:kitsunenokenja/gentoo.git","clone_url":"https://github.com/kitsunenokenja/gentoo.git","svn_url":"https://github.com/kitsunenokenja/gentoo","homepage":"https://wiki.gentoo.org/wiki/Gentoo_Github","size":522994,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gentoo:master","ref":"master","sha":"b1bded37f8f09ce2c35805d365694dab7569fc27","user":{"login":"gentoo","id":52242,"avatar_url":"https://avatars3.githubusercontent.com/u/52242?v=4","gravatar_id":"","url":"https://api.github.com/users/gentoo","html_url":"https://github.com/gentoo","followers_url":"https://api.github.com/users/gentoo/followers","following_url":"https://api.github.com/users/gentoo/following{/other_user}","gists_url":"https://api.github.com/users/gentoo/gists{/gist_id}","starred_url":"https://api.github.com/users/gentoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gentoo/subscriptions","organizations_url":"https://api.github.com/users/gentoo/orgs","repos_url":"https://api.github.com/users/gentoo/repos","events_url":"https://api.github.com/users/gentoo/events{/privacy}","received_events_url":"https://api.github.com/users/gentoo/received_events","type":"Organization","site_admin":false},"repo":{"id":40499714,"name":"gentoo","full_name":"gentoo/gentoo","owner":{"login":"gentoo","id":52242,"avatar_url":"https://avatars3.githubusercontent.com/u/52242?v=4","gravatar_id":"","url":"https://api.github.com/users/gentoo","html_url":"https://github.com/gentoo","followers_url":"https://api.github.com/users/gentoo/followers","following_url":"https://api.github.com/users/gentoo/following{/other_user}","gists_url":"https://api.github.com/users/gentoo/gists{/gist_id}","starred_url":"https://api.github.com/users/gentoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gentoo/subscriptions","organizations_url":"https://api.github.com/users/gentoo/orgs","repos_url":"https://api.github.com/users/gentoo/repos","events_url":"https://api.github.com/users/gentoo/events{/privacy}","received_events_url":"https://api.github.com/users/gentoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gentoo/gentoo","description":"The official mirror of the Gentoo ebuild repository","fork":false,"url":"https://api.github.com/repos/gentoo/gentoo","forks_url":"https://api.github.com/repos/gentoo/gentoo/forks","keys_url":"https://api.github.com/repos/gentoo/gentoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gentoo/gentoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gentoo/gentoo/teams","hooks_url":"https://api.github.com/repos/gentoo/gentoo/hooks","issue_events_url":"https://api.github.com/repos/gentoo/gentoo/issues/events{/number}","events_url":"https://api.github.com/repos/gentoo/gentoo/events","assignees_url":"https://api.github.com/repos/gentoo/gentoo/assignees{/user}","branches_url":"https://api.github.com/repos/gentoo/gentoo/branches{/branch}","tags_url":"https://api.github.com/repos/gentoo/gentoo/tags","blobs_url":"https://api.github.com/repos/gentoo/gentoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gentoo/gentoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gentoo/gentoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/gentoo/gentoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gentoo/gentoo/statuses/{sha}","languages_url":"https://api.github.com/repos/gentoo/gentoo/languages","stargazers_url":"https://api.github.com/repos/gentoo/gentoo/stargazers","contributors_url":"https://api.github.com/repos/gentoo/gentoo/contributors","subscribers_url":"https://api.github.com/repos/gentoo/gentoo/subscribers","subscription_url":"https://api.github.com/repos/gentoo/gentoo/subscription","commits_url":"https://api.github.com/repos/gentoo/gentoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/gentoo/gentoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/gentoo/gentoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/gentoo/gentoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/gentoo/gentoo/contents/{+path}","compare_url":"https://api.github.com/repos/gentoo/gentoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gentoo/gentoo/merges","archive_url":"https://api.github.com/repos/gentoo/gentoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gentoo/gentoo/downloads","issues_url":"https://api.github.com/repos/gentoo/gentoo/issues{/number}","pulls_url":"https://api.github.com/repos/gentoo/gentoo/pulls{/number}","milestones_url":"https://api.github.com/repos/gentoo/gentoo/milestones{/number}","notifications_url":"https://api.github.com/repos/gentoo/gentoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gentoo/gentoo/labels{/name}","releases_url":"https://api.github.com/repos/gentoo/gentoo/releases{/id}","deployments_url":"https://api.github.com/repos/gentoo/gentoo/deployments","created_at":"2015-08-10T18:47:32Z","updated_at":"2018-05-12T20:30:56Z","pushed_at":"2018-05-12T20:41:30Z","git_url":"git://github.com/gentoo/gentoo.git","ssh_url":"git@github.com:gentoo/gentoo.git","clone_url":"https://github.com/gentoo/gentoo.git","svn_url":"https://github.com/gentoo/gentoo","homepage":"https://wiki.gentoo.org/wiki/Gentoo_Github","size":523149,"stargazers_count":860,"watchers_count":860,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":748,"mirror_url":null,"archived":false,"open_issues_count":227,"license":null,"forks":748,"open_issues":227,"watchers":860,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gentoo/gentoo/pulls/8271"},"html":{"href":"https://github.com/gentoo/gentoo/pull/8271"},"issue":{"href":"https://api.github.com/repos/gentoo/gentoo/issues/8271"},"comments":{"href":"https://api.github.com/repos/gentoo/gentoo/issues/8271/comments"},"review_comments":{"href":"https://api.github.com/repos/gentoo/gentoo/pulls/8271/comments"},"review_comment":{"href":"https://api.github.com/repos/gentoo/gentoo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gentoo/gentoo/pulls/8271/commits"},"statuses":{"href":"https://api.github.com/repos/gentoo/gentoo/statuses/660df5fb461f5b08ffd5f61f5ebcb0830d24dc78"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mgorny"}}