{"action":"created","issue":{"url":"https://api.github.com/repos/istio/istio/issues/4145","repository_url":"https://api.github.com/repos/istio/istio","labels_url":"https://api.github.com/repos/istio/istio/issues/4145/labels{/name}","comments_url":"https://api.github.com/repos/istio/istio/issues/4145/comments","events_url":"https://api.github.com/repos/istio/istio/issues/4145/events","html_url":"https://github.com/istio/istio/pull/4145","id":303945692,"number":4145,"title":"Pod cache should only track RUNNING and PENDING pods","user":{"login":"kyessenov","id":9537734,"avatar_url":"https://avatars2.githubusercontent.com/u/9537734?v=4","gravatar_id":"","url":"https://api.github.com/users/kyessenov","html_url":"https://github.com/kyessenov","followers_url":"https://api.github.com/users/kyessenov/followers","following_url":"https://api.github.com/users/kyessenov/following{/other_user}","gists_url":"https://api.github.com/users/kyessenov/gists{/gist_id}","starred_url":"https://api.github.com/users/kyessenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyessenov/subscriptions","organizations_url":"https://api.github.com/users/kyessenov/orgs","repos_url":"https://api.github.com/users/kyessenov/repos","events_url":"https://api.github.com/users/kyessenov/events{/privacy}","received_events_url":"https://api.github.com/users/kyessenov/received_events","type":"User","site_admin":false},"labels":[{"id":491318011,"url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-03-09T19:00:15Z","updated_at":"2018-03-09T19:42:16Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/4145","html_url":"https://github.com/istio/istio/pull/4145","diff_url":"https://github.com/istio/istio/pull/4145.diff","patch_url":"https://github.com/istio/istio/pull/4145.patch"},"body":"Fixes https://github.com/istio/issues/issues/234\r\nSigned-off-by: Kuat Yessenov <kuat@google.com>"},"comment":{"url":"https://api.github.com/repos/istio/istio/issues/comments/371924679","html_url":"https://github.com/istio/istio/pull/4145#issuecomment-371924679","issue_url":"https://api.github.com/repos/istio/istio/issues/4145","id":371924679,"user":{"login":"bobbytables","id":521627,"avatar_url":"https://avatars2.githubusercontent.com/u/521627?v=4","gravatar_id":"","url":"https://api.github.com/users/bobbytables","html_url":"https://github.com/bobbytables","followers_url":"https://api.github.com/users/bobbytables/followers","following_url":"https://api.github.com/users/bobbytables/following{/other_user}","gists_url":"https://api.github.com/users/bobbytables/gists{/gist_id}","starred_url":"https://api.github.com/users/bobbytables/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobbytables/subscriptions","organizations_url":"https://api.github.com/users/bobbytables/orgs","repos_url":"https://api.github.com/users/bobbytables/repos","events_url":"https://api.github.com/users/bobbytables/events{/privacy}","received_events_url":"https://api.github.com/users/bobbytables/received_events","type":"User","site_admin":false},"created_at":"2018-03-09T19:42:16Z","updated_at":"2018-03-09T19:42:16Z","author_association":"NONE","body":"> This LGTM, but do we want to add some test to validate ?\r\n\r\nI was looking into this, and it seems the `controller_test.go` doesn't exercise this path at all actually. What's more weird to me is that we'll return a list of service endpoints that can potentially not have a pod attached to them at all.\r\n\r\nFor example:https://github.com/istio/istio/blob/master/pilot/pkg/serviceregistry/kube/controller.go#L369\r\n\r\nThat line does a check if the pod existed for the given IP, and will continue if it's not congruent with the service node we're fetching for. \r\n\r\nThe opposite case though, when a pod doesn't exist for an IP, will still append to the list of service instances for the IP. This seems confusing to me."}}
{"actor":{"display_login":"bobbytables"}}