{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/213053923","pull_request_review_id":149808256,"id":213053923,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzA1MzkyMw==","diff_hunk":"@@ -55,16 +55,34 @@ amp-carousel[controls] .amp-carousel-button,\n \n .amp-carousel-button-prev {\n   left: 16px;\n-  background-image: url('data:image/svg+xml;charset=utf-8,<svg xmlns=\"http://www.w3.org/2000/svg\" width=\"18\" height=\"18\" fill=\"#fff\" viewBox=\"0 0 18 18\"><path d=\"M15 8.25H5.87l4.19-4.19L9 3 3 9l6 6 1.06-1.06-4.19-4.19H15v-1.5z\"/></svg>');\n-  background-size: 18px 18px;\n }\n \n .amp-carousel-button-next {\n   right: 16px;\n+}\n+\n+.i-amphtml-carousel-button-prev-legacy {\n+  background-image: url('data:image/svg+xml;charset=utf-8,<svg xmlns=\"http://www.w3.org/2000/svg\" width=\"18\" height=\"18\" fill=\"#fff\" viewBox=\"0 0 18 18\"><path d=\"M15 8.25H5.87l4.19-4.19L9 3 3 9l6 6 1.06-1.06-4.19-4.19H15v-1.5z\"/></svg>');\n+  background-size: 18px 18px;\n+}\n+\n+.i-amphtml-carousel-button-prev-new {\n+  background-color: transparent;\n+  background-image: url('data:image/svg+xml;charset=utf-8,<svg viewBox=\"0 0 24 24\" version=\"1.1\" xmlns=\"http://www.w3.org/2000/svg\"><path  d=\"M14,7.4 L9.4,12 L14,16.6\" fill=\"none\" stroke=\"#fff\" stroke-width=\"2px\" stroke-linejoin=\"round\" stroke-linecap=\"round\" /></svg>');","path":"extensions/amp-carousel/0.1/amp-carousel.css","position":19,"original_position":19,"commit_id":"1bfedd65734e142a9e16709086c52838af140e2d","original_commit_id":"1bfedd65734e142a9e16709086c52838af140e2d","user":{"login":"sparhami","id":1410321,"node_id":"MDQ6VXNlcjE0MTAzMjE=","avatar_url":"https://avatars0.githubusercontent.com/u/1410321?v=4","gravatar_id":"","url":"https://api.github.com/users/sparhami","html_url":"https://github.com/sparhami","followers_url":"https://api.github.com/users/sparhami/followers","following_url":"https://api.github.com/users/sparhami/following{/other_user}","gists_url":"https://api.github.com/users/sparhami/gists{/gist_id}","starred_url":"https://api.github.com/users/sparhami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sparhami/subscriptions","organizations_url":"https://api.github.com/users/sparhami/orgs","repos_url":"https://api.github.com/users/sparhami/repos","events_url":"https://api.github.com/users/sparhami/events{/privacy}","received_events_url":"https://api.github.com/users/sparhami/received_events","type":"User","site_admin":false},"body":"Actually, you can remove the version attribute.","created_at":"2018-08-27T17:36:27Z","updated_at":"2018-08-27T17:36:54Z","html_url":"https://github.com/ampproject/amphtml/pull/17692#discussion_r213053923","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/17692","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/213053923"},"html":{"href":"https://github.com/ampproject/amphtml/pull/17692#discussion_r213053923"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/17692"}}},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/17692","id":210546566,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNTQ2NTY2","html_url":"https://github.com/ampproject/amphtml/pull/17692","diff_url":"https://github.com/ampproject/amphtml/pull/17692.diff","patch_url":"https://github.com/ampproject/amphtml/pull/17692.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/17692","number":17692,"state":"open","locked":false,"title":"Add new arrows for <amp-carousel> (gated under an experiment)","user":{"login":"nainar","id":7919520,"node_id":"MDQ6VXNlcjc5MTk1MjA=","avatar_url":"https://avatars2.githubusercontent.com/u/7919520?v=4","gravatar_id":"","url":"https://api.github.com/users/nainar","html_url":"https://github.com/nainar","followers_url":"https://api.github.com/users/nainar/followers","following_url":"https://api.github.com/users/nainar/following{/other_user}","gists_url":"https://api.github.com/users/nainar/gists{/gist_id}","starred_url":"https://api.github.com/users/nainar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nainar/subscriptions","organizations_url":"https://api.github.com/users/nainar/orgs","repos_url":"https://api.github.com/users/nainar/repos","events_url":"https://api.github.com/users/nainar/events{/privacy}","received_events_url":"https://api.github.com/users/nainar/received_events","type":"User","site_admin":false},"body":"This PR uses internal classes for the internal styling of elements.\r\n\r\nIf no override is provided:\r\n<img width=\"703\" alt=\"screen shot 2018-08-22 at 3 30 19 pm\" src=\"https://user-images.githubusercontent.com/7919520/44483300-17e7d100-a621-11e8-807a-ddb4687318f8.png\">\r\n<img width=\"703\" alt=\"screen shot 2018-08-22 at 3 30 24 pm\" src=\"https://user-images.githubusercontent.com/7919520/44483301-17e7d100-a621-11e8-9f81-dddf85509530.png\">\r\n\r\nIf override is provided:\r\n<img width=\"384\" alt=\"screen shot 2018-08-23 at 4 02 32 pm\" src=\"https://user-images.githubusercontent.com/7919520/44546360-0ddfd400-a6ee-11e8-8e20-e6075e7f0271.png\">\r\nPlease note that the default for ABE in this case used to use the default background provided by the internal styling which is not available now. Is this a regression we want? I am assuming some other sites use this as well?","created_at":"2018-08-23T19:07:33Z","updated_at":"2018-08-27T17:36:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"32c9d26a6e7f2c7ed3d6e1c00d88c6e278a72a2f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cathyxz","id":1528181,"node_id":"MDQ6VXNlcjE1MjgxODE=","avatar_url":"https://avatars1.githubusercontent.com/u/1528181?v=4","gravatar_id":"","url":"https://api.github.com/users/cathyxz","html_url":"https://github.com/cathyxz","followers_url":"https://api.github.com/users/cathyxz/followers","following_url":"https://api.github.com/users/cathyxz/following{/other_user}","gists_url":"https://api.github.com/users/cathyxz/gists{/gist_id}","starred_url":"https://api.github.com/users/cathyxz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cathyxz/subscriptions","organizations_url":"https://api.github.com/users/cathyxz/orgs","repos_url":"https://api.github.com/users/cathyxz/repos","events_url":"https://api.github.com/users/cathyxz/events{/privacy}","received_events_url":"https://api.github.com/users/cathyxz/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":596633554,"node_id":"MDU6TGFiZWw1OTY2MzM1NTQ=","url":"https://api.github.com/repos/ampproject/amphtml/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/17692/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/17692/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/17692/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/1bfedd65734e142a9e16709086c52838af140e2d","head":{"label":"nainar:carousel_arrows_new","ref":"carousel_arrows_new","sha":"1bfedd65734e142a9e16709086c52838af140e2d","user":{"login":"nainar","id":7919520,"node_id":"MDQ6VXNlcjc5MTk1MjA=","avatar_url":"https://avatars2.githubusercontent.com/u/7919520?v=4","gravatar_id":"","url":"https://api.github.com/users/nainar","html_url":"https://github.com/nainar","followers_url":"https://api.github.com/users/nainar/followers","following_url":"https://api.github.com/users/nainar/following{/other_user}","gists_url":"https://api.github.com/users/nainar/gists{/gist_id}","starred_url":"https://api.github.com/users/nainar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nainar/subscriptions","organizations_url":"https://api.github.com/users/nainar/orgs","repos_url":"https://api.github.com/users/nainar/repos","events_url":"https://api.github.com/users/nainar/events{/privacy}","received_events_url":"https://api.github.com/users/nainar/received_events","type":"User","site_admin":false},"repo":{"id":117491033,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc0OTEwMzM=","name":"amphtml","full_name":"nainar/amphtml","owner":{"login":"nainar","id":7919520,"node_id":"MDQ6VXNlcjc5MTk1MjA=","avatar_url":"https://avatars2.githubusercontent.com/u/7919520?v=4","gravatar_id":"","url":"https://api.github.com/users/nainar","html_url":"https://github.com/nainar","followers_url":"https://api.github.com/users/nainar/followers","following_url":"https://api.github.com/users/nainar/following{/other_user}","gists_url":"https://api.github.com/users/nainar/gists{/gist_id}","starred_url":"https://api.github.com/users/nainar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nainar/subscriptions","organizations_url":"https://api.github.com/users/nainar/orgs","repos_url":"https://api.github.com/users/nainar/repos","events_url":"https://api.github.com/users/nainar/events{/privacy}","received_events_url":"https://api.github.com/users/nainar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nainar/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/nainar/amphtml","forks_url":"https://api.github.com/repos/nainar/amphtml/forks","keys_url":"https://api.github.com/repos/nainar/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nainar/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nainar/amphtml/teams","hooks_url":"https://api.github.com/repos/nainar/amphtml/hooks","issue_events_url":"https://api.github.com/repos/nainar/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/nainar/amphtml/events","assignees_url":"https://api.github.com/repos/nainar/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/nainar/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/nainar/amphtml/tags","blobs_url":"https://api.github.com/repos/nainar/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nainar/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nainar/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/nainar/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nainar/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/nainar/amphtml/languages","stargazers_url":"https://api.github.com/repos/nainar/amphtml/stargazers","contributors_url":"https://api.github.com/repos/nainar/amphtml/contributors","subscribers_url":"https://api.github.com/repos/nainar/amphtml/subscribers","subscription_url":"https://api.github.com/repos/nainar/amphtml/subscription","commits_url":"https://api.github.com/repos/nainar/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/nainar/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/nainar/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/nainar/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/nainar/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/nainar/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nainar/amphtml/merges","archive_url":"https://api.github.com/repos/nainar/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nainar/amphtml/downloads","issues_url":"https://api.github.com/repos/nainar/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/nainar/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/nainar/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/nainar/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nainar/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/nainar/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/nainar/amphtml/deployments","created_at":"2018-01-15T03:09:24Z","updated_at":"2018-01-15T03:09:36Z","pushed_at":"2018-08-24T01:47:20Z","git_url":"git://github.com/nainar/amphtml.git","ssh_url":"git@github.com:nainar/amphtml.git","clone_url":"https://github.com/nainar/amphtml.git","svn_url":"https://github.com/nainar/amphtml","homepage":"https://www.ampproject.org","size":511266,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"9e31fe137e197f0530aaa6b119dbc4acc607a09c","user":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"node_id":"MDEwOlJlcG9zaXRvcnk0MTc2NjAwMg==","name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2018-08-27T17:34:47Z","pushed_at":"2018-08-27T17:34:18Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://www.ampproject.org","size":495626,"stargazers_count":11900,"watchers_count":11900,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2548,"mirror_url":null,"archived":false,"open_issues_count":1360,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2548,"open_issues":1360,"watchers":11900,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/17692"},"html":{"href":"https://github.com/ampproject/amphtml/pull/17692"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/17692"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/17692/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/17692/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/17692/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/1bfedd65734e142a9e16709086c52838af140e2d"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"sparhami"}}