{"action":"created","comment":{"url":"https://api.github.com/repos/couchbase/couchbase-lite-core/pulls/comments/242412045","pull_request_review_id":185912955,"id":242412045,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjQxMjA0NQ==","diff_hunk":"@@ -172,6 +184,21 @@ private static void documentEndedCallback(long handle, boolean pushing,\n         }\n     }\n \n+    private static boolean validationFunction(String docID, int flags, long dict, boolean isPush, long ctx) throws Exception {//\n+        Log.e(TAG, \"validationFunction() \" +","path":"Java/src/com/couchbase/litecore/C4Replicator.java","position":49,"original_position":49,"commit_id":"296d404aba2fe246cff9aaa758ea1c88a0fffdc5","original_commit_id":"296d404aba2fe246cff9aaa758ea1c88a0fffdc5","user":{"login":"pasin","id":801454,"node_id":"MDQ6VXNlcjgwMTQ1NA==","avatar_url":"https://avatars1.githubusercontent.com/u/801454?v=4","gravatar_id":"","url":"https://api.github.com/users/pasin","html_url":"https://github.com/pasin","followers_url":"https://api.github.com/users/pasin/followers","following_url":"https://api.github.com/users/pasin/following{/other_user}","gists_url":"https://api.github.com/users/pasin/gists{/gist_id}","starred_url":"https://api.github.com/users/pasin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pasin/subscriptions","organizations_url":"https://api.github.com/users/pasin/orgs","repos_url":"https://api.github.com/users/pasin/repos","events_url":"https://api.github.com/users/pasin/events{/privacy}","received_events_url":"https://api.github.com/users/pasin/received_events","type":"User","site_admin":false},"body":"Please don't use Log.e as Log.e means error.","created_at":"2018-12-18T05:39:03Z","updated_at":"2018-12-18T05:43:22Z","html_url":"https://github.com/couchbase/couchbase-lite-core/pull/635#discussion_r242412045","pull_request_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/pulls/635","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/couchbase/couchbase-lite-core/pulls/comments/242412045"},"html":{"href":"https://github.com/couchbase/couchbase-lite-core/pull/635#discussion_r242412045"},"pull_request":{"href":"https://api.github.com/repos/couchbase/couchbase-lite-core/pulls/635"}}},"pull_request":{"url":"https://api.github.com/repos/couchbase/couchbase-lite-core/pulls/635","id":238893092,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4ODkzMDky","html_url":"https://github.com/couchbase/couchbase-lite-core/pull/635","diff_url":"https://github.com/couchbase/couchbase-lite-core/pull/635.diff","patch_url":"https://github.com/couchbase/couchbase-lite-core/pull/635.patch","issue_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/issues/635","number":635,"state":"open","locked":false,"title":"Feature/Replication filters","user":{"login":"Sandychuang8","id":16504419,"node_id":"MDQ6VXNlcjE2NTA0NDE5","avatar_url":"https://avatars1.githubusercontent.com/u/16504419?v=4","gravatar_id":"","url":"https://api.github.com/users/Sandychuang8","html_url":"https://github.com/Sandychuang8","followers_url":"https://api.github.com/users/Sandychuang8/followers","following_url":"https://api.github.com/users/Sandychuang8/following{/other_user}","gists_url":"https://api.github.com/users/Sandychuang8/gists{/gist_id}","starred_url":"https://api.github.com/users/Sandychuang8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sandychuang8/subscriptions","organizations_url":"https://api.github.com/users/Sandychuang8/orgs","repos_url":"https://api.github.com/users/Sandychuang8/repos","events_url":"https://api.github.com/users/Sandychuang8/events{/privacy}","received_events_url":"https://api.github.com/users/Sandychuang8/received_events","type":"User","site_admin":false},"body":"Replication filters: Add validation callback function in JNI and LiteCore related classes\r\nReplication filter: add push filter and pull filter as part of replicator parameters, add replicator filter interface, add a new table to store replicator with replicator context key, remove filter method from replicator listener interface.\r\nReplication filter fix: make sure return the value from validationFunction.\r\nReplication filters fix: JNI methods requires returning j values","created_at":"2018-12-15T05:51:34Z","updated_at":"2018-12-18T05:43:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"04bfc7bd9bb5112ea370040e69dfdf84fa92afdc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":463491831,"node_id":"MDU6TGFiZWw0NjM0OTE4MzE=","url":"https://api.github.com/repos/couchbase/couchbase-lite-core/labels/in%20progress","name":"in progress","color":"ededed","default":false},{"id":459853887,"node_id":"MDU6TGFiZWw0NTk4NTM4ODc=","url":"https://api.github.com/repos/couchbase/couchbase-lite-core/labels/review","name":"review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/pulls/635/commits","review_comments_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/pulls/635/comments","review_comment_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/issues/635/comments","statuses_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/statuses/296d404aba2fe246cff9aaa758ea1c88a0fffdc5","head":{"label":"couchbase:feature/replication_filters","ref":"feature/replication_filters","sha":"296d404aba2fe246cff9aaa758ea1c88a0fffdc5","user":{"login":"couchbase","id":605755,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwNTc1NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/605755?v=4","gravatar_id":"","url":"https://api.github.com/users/couchbase","html_url":"https://github.com/couchbase","followers_url":"https://api.github.com/users/couchbase/followers","following_url":"https://api.github.com/users/couchbase/following{/other_user}","gists_url":"https://api.github.com/users/couchbase/gists{/gist_id}","starred_url":"https://api.github.com/users/couchbase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/couchbase/subscriptions","organizations_url":"https://api.github.com/users/couchbase/orgs","repos_url":"https://api.github.com/users/couchbase/repos","events_url":"https://api.github.com/users/couchbase/events{/privacy}","received_events_url":"https://api.github.com/users/couchbase/received_events","type":"Organization","site_admin":false},"repo":{"id":66783145,"node_id":"MDEwOlJlcG9zaXRvcnk2Njc4MzE0NQ==","name":"couchbase-lite-core","full_name":"couchbase/couchbase-lite-core","private":false,"owner":{"login":"couchbase","id":605755,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwNTc1NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/605755?v=4","gravatar_id":"","url":"https://api.github.com/users/couchbase","html_url":"https://github.com/couchbase","followers_url":"https://api.github.com/users/couchbase/followers","following_url":"https://api.github.com/users/couchbase/following{/other_user}","gists_url":"https://api.github.com/users/couchbase/gists{/gist_id}","starred_url":"https://api.github.com/users/couchbase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/couchbase/subscriptions","organizations_url":"https://api.github.com/users/couchbase/orgs","repos_url":"https://api.github.com/users/couchbase/repos","events_url":"https://api.github.com/users/couchbase/events{/privacy}","received_events_url":"https://api.github.com/users/couchbase/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/couchbase/couchbase-lite-core","description":"Cross-platform C++ core library for Couchbase Lite","fork":false,"url":"https://api.github.com/repos/couchbase/couchbase-lite-core","forks_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/forks","keys_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/teams","hooks_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/hooks","issue_events_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/issues/events{/number}","events_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/events","assignees_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/assignees{/user}","branches_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/branches{/branch}","tags_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/tags","blobs_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/statuses/{sha}","languages_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/languages","stargazers_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/stargazers","contributors_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/contributors","subscribers_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/subscribers","subscription_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/subscription","commits_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/contents/{+path}","compare_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/merges","archive_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/downloads","issues_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/issues{/number}","pulls_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/pulls{/number}","milestones_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/milestones{/number}","notifications_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/labels{/name}","releases_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/releases{/id}","deployments_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/deployments","created_at":"2016-08-28T18:07:47Z","updated_at":"2018-12-18T05:24:18Z","pushed_at":"2018-12-18T05:24:16Z","git_url":"git://github.com/couchbase/couchbase-lite-core.git","ssh_url":"git@github.com:couchbase/couchbase-lite-core.git","clone_url":"https://github.com/couchbase/couchbase-lite-core.git","svn_url":"https://github.com/couchbase/couchbase-lite-core","homepage":null,"size":96596,"stargazers_count":103,"watchers_count":103,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":29,"mirror_url":null,"archived":false,"open_issues_count":64,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":29,"open_issues":64,"watchers":103,"default_branch":"master"}},"base":{"label":"couchbase:master","ref":"master","sha":"63c0090d568d1ef02236cdd698bfe29bd95136ee","user":{"login":"couchbase","id":605755,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwNTc1NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/605755?v=4","gravatar_id":"","url":"https://api.github.com/users/couchbase","html_url":"https://github.com/couchbase","followers_url":"https://api.github.com/users/couchbase/followers","following_url":"https://api.github.com/users/couchbase/following{/other_user}","gists_url":"https://api.github.com/users/couchbase/gists{/gist_id}","starred_url":"https://api.github.com/users/couchbase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/couchbase/subscriptions","organizations_url":"https://api.github.com/users/couchbase/orgs","repos_url":"https://api.github.com/users/couchbase/repos","events_url":"https://api.github.com/users/couchbase/events{/privacy}","received_events_url":"https://api.github.com/users/couchbase/received_events","type":"Organization","site_admin":false},"repo":{"id":66783145,"node_id":"MDEwOlJlcG9zaXRvcnk2Njc4MzE0NQ==","name":"couchbase-lite-core","full_name":"couchbase/couchbase-lite-core","private":false,"owner":{"login":"couchbase","id":605755,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwNTc1NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/605755?v=4","gravatar_id":"","url":"https://api.github.com/users/couchbase","html_url":"https://github.com/couchbase","followers_url":"https://api.github.com/users/couchbase/followers","following_url":"https://api.github.com/users/couchbase/following{/other_user}","gists_url":"https://api.github.com/users/couchbase/gists{/gist_id}","starred_url":"https://api.github.com/users/couchbase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/couchbase/subscriptions","organizations_url":"https://api.github.com/users/couchbase/orgs","repos_url":"https://api.github.com/users/couchbase/repos","events_url":"https://api.github.com/users/couchbase/events{/privacy}","received_events_url":"https://api.github.com/users/couchbase/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/couchbase/couchbase-lite-core","description":"Cross-platform C++ core library for Couchbase Lite","fork":false,"url":"https://api.github.com/repos/couchbase/couchbase-lite-core","forks_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/forks","keys_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/teams","hooks_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/hooks","issue_events_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/issues/events{/number}","events_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/events","assignees_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/assignees{/user}","branches_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/branches{/branch}","tags_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/tags","blobs_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/statuses/{sha}","languages_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/languages","stargazers_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/stargazers","contributors_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/contributors","subscribers_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/subscribers","subscription_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/subscription","commits_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/contents/{+path}","compare_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/merges","archive_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/downloads","issues_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/issues{/number}","pulls_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/pulls{/number}","milestones_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/milestones{/number}","notifications_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/labels{/name}","releases_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/releases{/id}","deployments_url":"https://api.github.com/repos/couchbase/couchbase-lite-core/deployments","created_at":"2016-08-28T18:07:47Z","updated_at":"2018-12-18T05:24:18Z","pushed_at":"2018-12-18T05:24:16Z","git_url":"git://github.com/couchbase/couchbase-lite-core.git","ssh_url":"git@github.com:couchbase/couchbase-lite-core.git","clone_url":"https://github.com/couchbase/couchbase-lite-core.git","svn_url":"https://github.com/couchbase/couchbase-lite-core","homepage":null,"size":96596,"stargazers_count":103,"watchers_count":103,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":29,"mirror_url":null,"archived":false,"open_issues_count":64,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":29,"open_issues":64,"watchers":103,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/couchbase/couchbase-lite-core/pulls/635"},"html":{"href":"https://github.com/couchbase/couchbase-lite-core/pull/635"},"issue":{"href":"https://api.github.com/repos/couchbase/couchbase-lite-core/issues/635"},"comments":{"href":"https://api.github.com/repos/couchbase/couchbase-lite-core/issues/635/comments"},"review_comments":{"href":"https://api.github.com/repos/couchbase/couchbase-lite-core/pulls/635/comments"},"review_comment":{"href":"https://api.github.com/repos/couchbase/couchbase-lite-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/couchbase/couchbase-lite-core/pulls/635/commits"},"statuses":{"href":"https://api.github.com/repos/couchbase/couchbase-lite-core/statuses/296d404aba2fe246cff9aaa758ea1c88a0fffdc5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pasin"}}