{"action":"created","comment":{"url":"https://api.github.com/repos/EOSIO/eos/pulls/comments/177434572","pull_request_review_id":107302849,"id":177434572,"diff_hunk":"@@ -48,6 +48,10 @@ namespace eosio { namespace chain { namespace contracts {\n       );\n    }\n \n+   struct symbol_name {\n+      uint64_t value;\n+   };","path":"libraries/chain/contracts/abi_serializer.cpp","position":null,"original_position":6,"commit_id":"d450e52872704c8771489d554bb5fce4bf84e906","original_commit_id":"238a141a3d1532ac333e5cba5d7bec81d0494cf6","user":{"login":"heifner","id":3933649,"avatar_url":"https://avatars3.githubusercontent.com/u/3933649?v=4","gravatar_id":"","url":"https://api.github.com/users/heifner","html_url":"https://github.com/heifner","followers_url":"https://api.github.com/users/heifner/followers","following_url":"https://api.github.com/users/heifner/following{/other_user}","gists_url":"https://api.github.com/users/heifner/gists{/gist_id}","starred_url":"https://api.github.com/users/heifner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heifner/subscriptions","organizations_url":"https://api.github.com/users/heifner/orgs","repos_url":"https://api.github.com/users/heifner/repos","events_url":"https://api.github.com/users/heifner/events{/privacy}","received_events_url":"https://api.github.com/users/heifner/received_events","type":"User","site_admin":false},"body":"Yes, symbol.hpp for it and the variant code would be better. How about `symbol_code` I know code is very overloaded, but here at least those things are called currency codes. http://www.xe.com/symbols.php\r\n\r\nI have also seen them called \"Currency Abbreviation\".","created_at":"2018-03-27T13:59:44Z","updated_at":"2018-03-27T13:59:44Z","html_url":"https://github.com/EOSIO/eos/pull/1874#discussion_r177434572","pull_request_url":"https://api.github.com/repos/EOSIO/eos/pulls/1874","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/EOSIO/eos/pulls/comments/177434572"},"html":{"href":"https://github.com/EOSIO/eos/pull/1874#discussion_r177434572"},"pull_request":{"href":"https://api.github.com/repos/EOSIO/eos/pulls/1874"}},"in_reply_to_id":177404954},"pull_request":{"url":"https://api.github.com/repos/EOSIO/eos/pulls/1874","id":177627251,"html_url":"https://github.com/EOSIO/eos/pull/1874","diff_url":"https://github.com/EOSIO/eos/pull/1874.diff","patch_url":"https://github.com/EOSIO/eos/pull/1874.patch","issue_url":"https://api.github.com/repos/EOSIO/eos/issues/1874","number":1874,"state":"open","locked":false,"title":"Make get_table_rows via chain_plugin (and thus cleos) easier to use","user":{"login":"arhag","id":8333406,"avatar_url":"https://avatars0.githubusercontent.com/u/8333406?v=4","gravatar_id":"","url":"https://api.github.com/users/arhag","html_url":"https://github.com/arhag","followers_url":"https://api.github.com/users/arhag/followers","following_url":"https://api.github.com/users/arhag/following{/other_user}","gists_url":"https://api.github.com/users/arhag/gists{/gist_id}","starred_url":"https://api.github.com/users/arhag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arhag/subscriptions","organizations_url":"https://api.github.com/users/arhag/orgs","repos_url":"https://api.github.com/users/arhag/repos","events_url":"https://api.github.com/users/arhag/events{/privacy}","received_events_url":"https://api.github.com/users/arhag/received_events","type":"User","site_admin":false},"body":"Added `symbol_name` built_in_type to abi_serializer, which is like `symbol` except it does not include the leading precision in the displayed string.\r\n\r\nNow treating scope string as (in order of attempts): `name`, `uint64_t`, `symbol`, or `symbol_name`. Only throw error if the string cannot be interpreted as any of those four types. Ambiguity between a name consisting of only the digits 1 through 5 and an actual `uint64_t` number can be resolved by adding whitespace to the beginning or end of the string representation of the `uint64_t` number passed into cleos.\r\n\r\nSwitched order of scope and code arguments in cleos to better reflect the table structure.\r\n\r\nUpdated currency.abi to use the more descriptive types (such as `symbol` and `symbol_name`) and also to use the correct table name (\"accounts\") for the accounts tables.\r\n\r\nThis PR should fix issue #1742, #1827 and maybe #1832.","created_at":"2018-03-27T04:11:57Z","updated_at":"2018-03-27T13:59:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c842245c358e5dfe4fcea09e2fe8f5c31332e72","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/EOSIO/eos/pulls/1874/commits","review_comments_url":"https://api.github.com/repos/EOSIO/eos/pulls/1874/comments","review_comment_url":"https://api.github.com/repos/EOSIO/eos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EOSIO/eos/issues/1874/comments","statuses_url":"https://api.github.com/repos/EOSIO/eos/statuses/d450e52872704c8771489d554bb5fce4bf84e906","head":{"label":"EOSIO:improve-get-table","ref":"improve-get-table","sha":"d450e52872704c8771489d554bb5fce4bf84e906","user":{"login":"EOSIO","id":26932212,"avatar_url":"https://avatars2.githubusercontent.com/u/26932212?v=4","gravatar_id":"","url":"https://api.github.com/users/EOSIO","html_url":"https://github.com/EOSIO","followers_url":"https://api.github.com/users/EOSIO/followers","following_url":"https://api.github.com/users/EOSIO/following{/other_user}","gists_url":"https://api.github.com/users/EOSIO/gists{/gist_id}","starred_url":"https://api.github.com/users/EOSIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EOSIO/subscriptions","organizations_url":"https://api.github.com/users/EOSIO/orgs","repos_url":"https://api.github.com/users/EOSIO/repos","events_url":"https://api.github.com/users/EOSIO/events{/privacy}","received_events_url":"https://api.github.com/users/EOSIO/received_events","type":"Organization","site_admin":false},"repo":{"id":87335980,"name":"eos","full_name":"EOSIO/eos","owner":{"login":"EOSIO","id":26932212,"avatar_url":"https://avatars2.githubusercontent.com/u/26932212?v=4","gravatar_id":"","url":"https://api.github.com/users/EOSIO","html_url":"https://github.com/EOSIO","followers_url":"https://api.github.com/users/EOSIO/followers","following_url":"https://api.github.com/users/EOSIO/following{/other_user}","gists_url":"https://api.github.com/users/EOSIO/gists{/gist_id}","starred_url":"https://api.github.com/users/EOSIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EOSIO/subscriptions","organizations_url":"https://api.github.com/users/EOSIO/orgs","repos_url":"https://api.github.com/users/EOSIO/repos","events_url":"https://api.github.com/users/EOSIO/events{/privacy}","received_events_url":"https://api.github.com/users/EOSIO/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EOSIO/eos","description":"An open source smart contract platform ","fork":false,"url":"https://api.github.com/repos/EOSIO/eos","forks_url":"https://api.github.com/repos/EOSIO/eos/forks","keys_url":"https://api.github.com/repos/EOSIO/eos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EOSIO/eos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EOSIO/eos/teams","hooks_url":"https://api.github.com/repos/EOSIO/eos/hooks","issue_events_url":"https://api.github.com/repos/EOSIO/eos/issues/events{/number}","events_url":"https://api.github.com/repos/EOSIO/eos/events","assignees_url":"https://api.github.com/repos/EOSIO/eos/assignees{/user}","branches_url":"https://api.github.com/repos/EOSIO/eos/branches{/branch}","tags_url":"https://api.github.com/repos/EOSIO/eos/tags","blobs_url":"https://api.github.com/repos/EOSIO/eos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EOSIO/eos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EOSIO/eos/git/refs{/sha}","trees_url":"https://api.github.com/repos/EOSIO/eos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EOSIO/eos/statuses/{sha}","languages_url":"https://api.github.com/repos/EOSIO/eos/languages","stargazers_url":"https://api.github.com/repos/EOSIO/eos/stargazers","contributors_url":"https://api.github.com/repos/EOSIO/eos/contributors","subscribers_url":"https://api.github.com/repos/EOSIO/eos/subscribers","subscription_url":"https://api.github.com/repos/EOSIO/eos/subscription","commits_url":"https://api.github.com/repos/EOSIO/eos/commits{/sha}","git_commits_url":"https://api.github.com/repos/EOSIO/eos/git/commits{/sha}","comments_url":"https://api.github.com/repos/EOSIO/eos/comments{/number}","issue_comment_url":"https://api.github.com/repos/EOSIO/eos/issues/comments{/number}","contents_url":"https://api.github.com/repos/EOSIO/eos/contents/{+path}","compare_url":"https://api.github.com/repos/EOSIO/eos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EOSIO/eos/merges","archive_url":"https://api.github.com/repos/EOSIO/eos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EOSIO/eos/downloads","issues_url":"https://api.github.com/repos/EOSIO/eos/issues{/number}","pulls_url":"https://api.github.com/repos/EOSIO/eos/pulls{/number}","milestones_url":"https://api.github.com/repos/EOSIO/eos/milestones{/number}","notifications_url":"https://api.github.com/repos/EOSIO/eos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EOSIO/eos/labels{/name}","releases_url":"https://api.github.com/repos/EOSIO/eos/releases{/id}","deployments_url":"https://api.github.com/repos/EOSIO/eos/deployments","created_at":"2017-04-05T17:09:53Z","updated_at":"2018-03-27T13:56:00Z","pushed_at":"2018-03-27T13:56:07Z","git_url":"git://github.com/EOSIO/eos.git","ssh_url":"git@github.com:EOSIO/eos.git","clone_url":"https://github.com/EOSIO/eos.git","svn_url":"https://github.com/EOSIO/eos","homepage":"https://eosio.github.io/eos/","size":29647,"stargazers_count":5623,"watchers_count":5623,"language":"WebAssembly","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1198,"mirror_url":null,"archived":false,"open_issues_count":316,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1198,"open_issues":316,"watchers":5623,"default_branch":"master"}},"base":{"label":"EOSIO:master","ref":"master","sha":"1cd5cf86207cffcfbb59c949a6a383d06827a975","user":{"login":"EOSIO","id":26932212,"avatar_url":"https://avatars2.githubusercontent.com/u/26932212?v=4","gravatar_id":"","url":"https://api.github.com/users/EOSIO","html_url":"https://github.com/EOSIO","followers_url":"https://api.github.com/users/EOSIO/followers","following_url":"https://api.github.com/users/EOSIO/following{/other_user}","gists_url":"https://api.github.com/users/EOSIO/gists{/gist_id}","starred_url":"https://api.github.com/users/EOSIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EOSIO/subscriptions","organizations_url":"https://api.github.com/users/EOSIO/orgs","repos_url":"https://api.github.com/users/EOSIO/repos","events_url":"https://api.github.com/users/EOSIO/events{/privacy}","received_events_url":"https://api.github.com/users/EOSIO/received_events","type":"Organization","site_admin":false},"repo":{"id":87335980,"name":"eos","full_name":"EOSIO/eos","owner":{"login":"EOSIO","id":26932212,"avatar_url":"https://avatars2.githubusercontent.com/u/26932212?v=4","gravatar_id":"","url":"https://api.github.com/users/EOSIO","html_url":"https://github.com/EOSIO","followers_url":"https://api.github.com/users/EOSIO/followers","following_url":"https://api.github.com/users/EOSIO/following{/other_user}","gists_url":"https://api.github.com/users/EOSIO/gists{/gist_id}","starred_url":"https://api.github.com/users/EOSIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EOSIO/subscriptions","organizations_url":"https://api.github.com/users/EOSIO/orgs","repos_url":"https://api.github.com/users/EOSIO/repos","events_url":"https://api.github.com/users/EOSIO/events{/privacy}","received_events_url":"https://api.github.com/users/EOSIO/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EOSIO/eos","description":"An open source smart contract platform ","fork":false,"url":"https://api.github.com/repos/EOSIO/eos","forks_url":"https://api.github.com/repos/EOSIO/eos/forks","keys_url":"https://api.github.com/repos/EOSIO/eos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EOSIO/eos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EOSIO/eos/teams","hooks_url":"https://api.github.com/repos/EOSIO/eos/hooks","issue_events_url":"https://api.github.com/repos/EOSIO/eos/issues/events{/number}","events_url":"https://api.github.com/repos/EOSIO/eos/events","assignees_url":"https://api.github.com/repos/EOSIO/eos/assignees{/user}","branches_url":"https://api.github.com/repos/EOSIO/eos/branches{/branch}","tags_url":"https://api.github.com/repos/EOSIO/eos/tags","blobs_url":"https://api.github.com/repos/EOSIO/eos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EOSIO/eos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EOSIO/eos/git/refs{/sha}","trees_url":"https://api.github.com/repos/EOSIO/eos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EOSIO/eos/statuses/{sha}","languages_url":"https://api.github.com/repos/EOSIO/eos/languages","stargazers_url":"https://api.github.com/repos/EOSIO/eos/stargazers","contributors_url":"https://api.github.com/repos/EOSIO/eos/contributors","subscribers_url":"https://api.github.com/repos/EOSIO/eos/subscribers","subscription_url":"https://api.github.com/repos/EOSIO/eos/subscription","commits_url":"https://api.github.com/repos/EOSIO/eos/commits{/sha}","git_commits_url":"https://api.github.com/repos/EOSIO/eos/git/commits{/sha}","comments_url":"https://api.github.com/repos/EOSIO/eos/comments{/number}","issue_comment_url":"https://api.github.com/repos/EOSIO/eos/issues/comments{/number}","contents_url":"https://api.github.com/repos/EOSIO/eos/contents/{+path}","compare_url":"https://api.github.com/repos/EOSIO/eos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EOSIO/eos/merges","archive_url":"https://api.github.com/repos/EOSIO/eos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EOSIO/eos/downloads","issues_url":"https://api.github.com/repos/EOSIO/eos/issues{/number}","pulls_url":"https://api.github.com/repos/EOSIO/eos/pulls{/number}","milestones_url":"https://api.github.com/repos/EOSIO/eos/milestones{/number}","notifications_url":"https://api.github.com/repos/EOSIO/eos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EOSIO/eos/labels{/name}","releases_url":"https://api.github.com/repos/EOSIO/eos/releases{/id}","deployments_url":"https://api.github.com/repos/EOSIO/eos/deployments","created_at":"2017-04-05T17:09:53Z","updated_at":"2018-03-27T13:56:00Z","pushed_at":"2018-03-27T13:56:07Z","git_url":"git://github.com/EOSIO/eos.git","ssh_url":"git@github.com:EOSIO/eos.git","clone_url":"https://github.com/EOSIO/eos.git","svn_url":"https://github.com/EOSIO/eos","homepage":"https://eosio.github.io/eos/","size":29647,"stargazers_count":5623,"watchers_count":5623,"language":"WebAssembly","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1198,"mirror_url":null,"archived":false,"open_issues_count":316,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1198,"open_issues":316,"watchers":5623,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EOSIO/eos/pulls/1874"},"html":{"href":"https://github.com/EOSIO/eos/pull/1874"},"issue":{"href":"https://api.github.com/repos/EOSIO/eos/issues/1874"},"comments":{"href":"https://api.github.com/repos/EOSIO/eos/issues/1874/comments"},"review_comments":{"href":"https://api.github.com/repos/EOSIO/eos/pulls/1874/comments"},"review_comment":{"href":"https://api.github.com/repos/EOSIO/eos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EOSIO/eos/pulls/1874/commits"},"statuses":{"href":"https://api.github.com/repos/EOSIO/eos/statuses/d450e52872704c8771489d554bb5fce4bf84e906"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"heifner"}}