{"action":"created","issue":{"url":"https://api.github.com/repos/cms-dev/cms/issues/976","repository_url":"https://api.github.com/repos/cms-dev/cms","labels_url":"https://api.github.com/repos/cms-dev/cms/issues/976/labels{/name}","comments_url":"https://api.github.com/repos/cms-dev/cms/issues/976/comments","events_url":"https://api.github.com/repos/cms-dev/cms/issues/976/events","html_url":"https://github.com/cms-dev/cms/pull/976","id":329482177,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNzI2ODU5","number":976,"title":"Small refactoring of programstarter","user":{"login":"stefano-maggiolo","id":485490,"node_id":"MDQ6VXNlcjQ4NTQ5MA==","avatar_url":"https://avatars2.githubusercontent.com/u/485490?v=4","gravatar_id":"","url":"https://api.github.com/users/stefano-maggiolo","html_url":"https://github.com/stefano-maggiolo","followers_url":"https://api.github.com/users/stefano-maggiolo/followers","following_url":"https://api.github.com/users/stefano-maggiolo/following{/other_user}","gists_url":"https://api.github.com/users/stefano-maggiolo/gists{/gist_id}","starred_url":"https://api.github.com/users/stefano-maggiolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefano-maggiolo/subscriptions","organizations_url":"https://api.github.com/users/stefano-maggiolo/orgs","repos_url":"https://api.github.com/users/stefano-maggiolo/repos","events_url":"https://api.github.com/users/stefano-maggiolo/events{/privacy}","received_events_url":"https://api.github.com/users/stefano-maggiolo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"lerks","id":120810,"node_id":"MDQ6VXNlcjEyMDgxMA==","avatar_url":"https://avatars1.githubusercontent.com/u/120810?v=4","gravatar_id":"","url":"https://api.github.com/users/lerks","html_url":"https://github.com/lerks","followers_url":"https://api.github.com/users/lerks/followers","following_url":"https://api.github.com/users/lerks/following{/other_user}","gists_url":"https://api.github.com/users/lerks/gists{/gist_id}","starred_url":"https://api.github.com/users/lerks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lerks/subscriptions","organizations_url":"https://api.github.com/users/lerks/orgs","repos_url":"https://api.github.com/users/lerks/repos","events_url":"https://api.github.com/users/lerks/events{/privacy}","received_events_url":"https://api.github.com/users/lerks/received_events","type":"User","site_admin":false},"assignees":[{"login":"lerks","id":120810,"node_id":"MDQ6VXNlcjEyMDgxMA==","avatar_url":"https://avatars1.githubusercontent.com/u/120810?v=4","gravatar_id":"","url":"https://api.github.com/users/lerks","html_url":"https://github.com/lerks","followers_url":"https://api.github.com/users/lerks/followers","following_url":"https://api.github.com/users/lerks/following{/other_user}","gists_url":"https://api.github.com/users/lerks/gists{/gist_id}","starred_url":"https://api.github.com/users/lerks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lerks/subscriptions","organizations_url":"https://api.github.com/users/lerks/orgs","repos_url":"https://api.github.com/users/lerks/repos","events_url":"https://api.github.com/users/lerks/events{/privacy}","received_events_url":"https://api.github.com/users/lerks/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-06-05T14:27:02Z","updated_at":"2018-06-05T14:35:41Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/cms-dev/cms/pulls/976","html_url":"https://github.com/cms-dev/cms/pull/976","diff_url":"https://github.com/cms-dev/cms/pull/976.diff","patch_url":"https://github.com/cms-dev/cms/pull/976.patch"},"body":"While addressing the comment in the other PR, I realised the problem\nwas in the structure of ps (too many shared responsibilities).\n\nAlso, even if we terminated the services gracefully, we only waited\nuntil the RPC server didn't respond, and then we killed them with\nlittle grace. Turns out the RPC server stops responding immediately,\nbut the service still runs for a while, so we killed them every time.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cms-dev/cms/976)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cms-dev/cms/issues/comments/394733393","html_url":"https://github.com/cms-dev/cms/pull/976#issuecomment-394733393","issue_url":"https://api.github.com/repos/cms-dev/cms/issues/976","id":394733393,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDczMzM5Mw==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-06-05T14:35:41Z","updated_at":"2018-06-05T14:35:41Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/cms-dev/cms/pull/976?src=pr&el=h1) Report\n> Merging [#976](https://codecov.io/gh/cms-dev/cms/pull/976?src=pr&el=desc) into [master](https://codecov.io/gh/cms-dev/cms/commit/bbe7e2c591951ced5e07a9b4d3f262ffc914726c?src=pr&el=desc) will **decrease** coverage by `0.11%`.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/cms-dev/cms/pull/976/graphs/tree.svg?height=150&width=650&token=XVAwZdiUV8&src=pr)](https://codecov.io/gh/cms-dev/cms/pull/976?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master     #976      +/-   ##\n==========================================\n- Coverage   64.38%   64.26%   -0.12%     \n==========================================\n  Files         224      224              \n  Lines       17614    17614              \n==========================================\n- Hits        11340    11319      -21     \n- Misses       6274     6295      +21\n```\n\n| Flag | Coverage Δ | |\n|---|---|---|\n| #functionaltests | `47.77% <ø> (-0.21%)` | :arrow_down: |\n| #unittests | `45.01% <ø> (+0.01%)` | :arrow_up: |\n\n| [Impacted Files](https://codecov.io/gh/cms-dev/cms/pull/976?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [cms/service/\\_\\_init\\_\\_.py](https://codecov.io/gh/cms-dev/cms/pull/976/diff?src=pr&el=tree#diff-Y21zL3NlcnZpY2UvX19pbml0X18ucHk=) | `28.98% <0%> (-4.35%)` | :arrow_down: |\n| [cms/io/service.py](https://codecov.io/gh/cms-dev/cms/pull/976/diff?src=pr&el=tree#diff-Y21zL2lvL3NlcnZpY2UucHk=) | `73.41% <0%> (-4.05%)` | :arrow_down: |\n| [cms/service/esoperations.py](https://codecov.io/gh/cms-dev/cms/pull/976/diff?src=pr&el=tree#diff-Y21zL3NlcnZpY2UvZXNvcGVyYXRpb25zLnB5) | `80.4% <0%> (-2.71%)` | :arrow_down: |\n| [cms/db/base.py](https://codecov.io/gh/cms-dev/cms/pull/976/diff?src=pr&el=tree#diff-Y21zL2RiL2Jhc2UucHk=) | `93.51% <0%> (-1.86%)` | :arrow_down: |\n| [cms/server/admin/handlers/contestuser.py](https://codecov.io/gh/cms-dev/cms/pull/976/diff?src=pr&el=tree#diff-Y21zL3NlcnZlci9hZG1pbi9oYW5kbGVycy9jb250ZXN0dXNlci5weQ==) | `34.67% <0%> (-1.62%)` | :arrow_down: |\n| [cms/server/contest/phase\\_management.py](https://codecov.io/gh/cms-dev/cms/pull/976/diff?src=pr&el=tree#diff-Y21zL3NlcnZlci9jb250ZXN0L3BoYXNlX21hbmFnZW1lbnQucHk=) | `95.4% <0%> (-1.15%)` | :arrow_down: |\n| [cms/service/ProxyService.py](https://codecov.io/gh/cms-dev/cms/pull/976/diff?src=pr&el=tree#diff-Y21zL3NlcnZpY2UvUHJveHlTZXJ2aWNlLnB5) | `59.89% <0%> (-1.02%)` | :arrow_down: |\n| [cms/server/admin/handlers/base.py](https://codecov.io/gh/cms-dev/cms/pull/976/diff?src=pr&el=tree#diff-Y21zL3NlcnZlci9hZG1pbi9oYW5kbGVycy9iYXNlLnB5) | `69% <0%> (-1%)` | :arrow_down: |\n| [cms/server/contest/handlers/contest.py](https://codecov.io/gh/cms-dev/cms/pull/976/diff?src=pr&el=tree#diff-Y21zL3NlcnZlci9jb250ZXN0L2hhbmRsZXJzL2NvbnRlc3QucHk=) | `90.09% <0%> (-1%)` | :arrow_down: |\n| [cms/service/workerpool.py](https://codecov.io/gh/cms-dev/cms/pull/976/diff?src=pr&el=tree#diff-Y21zL3NlcnZpY2Uvd29ya2VycG9vbC5weQ==) | `62.06% <0%> (-0.99%)` | :arrow_down: |\n| ... and [7 more](https://codecov.io/gh/cms-dev/cms/pull/976/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/cms-dev/cms/pull/976?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/cms-dev/cms/pull/976?src=pr&el=footer). Last update [bbe7e2c...455de83](https://codecov.io/gh/cms-dev/cms/pull/976?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}