{"action":"closed","number":3601,"pull_request":{"url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/3601","id":232747674,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNzQ3Njc0","html_url":"https://github.com/wildfly/wildfly-core/pull/3601","diff_url":"https://github.com/wildfly/wildfly-core/pull/3601.diff","patch_url":"https://github.com/wildfly/wildfly-core/pull/3601.patch","issue_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/3601","number":3601,"state":"closed","locked":false,"title":"[WFCORE-3905] Improve SuspendController code","user":{"login":"yersan","id":5951113,"node_id":"MDQ6VXNlcjU5NTExMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/5951113?v=4","gravatar_id":"","url":"https://api.github.com/users/yersan","html_url":"https://github.com/yersan","followers_url":"https://api.github.com/users/yersan/followers","following_url":"https://api.github.com/users/yersan/following{/other_user}","gists_url":"https://api.github.com/users/yersan/gists{/gist_id}","starred_url":"https://api.github.com/users/yersan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yersan/subscriptions","organizations_url":"https://api.github.com/users/yersan/orgs","repos_url":"https://api.github.com/users/yersan/repos","events_url":"https://api.github.com/users/yersan/events{/privacy}","received_events_url":"https://api.github.com/users/yersan/received_events","type":"User","site_admin":false},"body":"Minor fixes for SuspendController\r\n\r\n1. The Timer allocated at L103 is pointless unless timeoutMillis > 0\r\n2. activityPaused() and timeout() can be private\r\n3. The logging message L80-L82 is incorrect if timeoutMillis == 0\r\n\r\nJira issue: https://issues.jboss.org/browse/WFCORE-3905","created_at":"2018-11-21T17:35:04Z","updated_at":"2018-12-05T10:20:33Z","closed_at":"2018-12-05T10:20:33Z","merged_at":"2018-12-05T10:20:33Z","merge_commit_sha":"24d617d5976d13ac3f589e1a19ad46efcb056e83","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":124784775,"node_id":"MDU6TGFiZWwxMjQ3ODQ3NzU=","url":"https://api.github.com/repos/wildfly/wildfly-core/labels/ready-for-merge","name":"ready-for-merge","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/3601/commits","review_comments_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/3601/comments","review_comment_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/3601/comments","statuses_url":"https://api.github.com/repos/wildfly/wildfly-core/statuses/26ca97ba59d3f3335c57c85886c1c529ab13a24a","head":{"label":"yersan:bugs/WFCORE-3905","ref":"bugs/WFCORE-3905","sha":"26ca97ba59d3f3335c57c85886c1c529ab13a24a","user":{"login":"yersan","id":5951113,"node_id":"MDQ6VXNlcjU5NTExMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/5951113?v=4","gravatar_id":"","url":"https://api.github.com/users/yersan","html_url":"https://github.com/yersan","followers_url":"https://api.github.com/users/yersan/followers","following_url":"https://api.github.com/users/yersan/following{/other_user}","gists_url":"https://api.github.com/users/yersan/gists{/gist_id}","starred_url":"https://api.github.com/users/yersan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yersan/subscriptions","organizations_url":"https://api.github.com/users/yersan/orgs","repos_url":"https://api.github.com/users/yersan/repos","events_url":"https://api.github.com/users/yersan/events{/privacy}","received_events_url":"https://api.github.com/users/yersan/received_events","type":"User","site_admin":false},"repo":{"id":50686693,"node_id":"MDEwOlJlcG9zaXRvcnk1MDY4NjY5Mw==","name":"wildfly-core","full_name":"yersan/wildfly-core","private":false,"owner":{"login":"yersan","id":5951113,"node_id":"MDQ6VXNlcjU5NTExMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/5951113?v=4","gravatar_id":"","url":"https://api.github.com/users/yersan","html_url":"https://github.com/yersan","followers_url":"https://api.github.com/users/yersan/followers","following_url":"https://api.github.com/users/yersan/following{/other_user}","gists_url":"https://api.github.com/users/yersan/gists{/gist_id}","starred_url":"https://api.github.com/users/yersan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yersan/subscriptions","organizations_url":"https://api.github.com/users/yersan/orgs","repos_url":"https://api.github.com/users/yersan/repos","events_url":"https://api.github.com/users/yersan/events{/privacy}","received_events_url":"https://api.github.com/users/yersan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/yersan/wildfly-core","description":"The core runtime that is used by the Wildfly application server","fork":true,"url":"https://api.github.com/repos/yersan/wildfly-core","forks_url":"https://api.github.com/repos/yersan/wildfly-core/forks","keys_url":"https://api.github.com/repos/yersan/wildfly-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yersan/wildfly-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yersan/wildfly-core/teams","hooks_url":"https://api.github.com/repos/yersan/wildfly-core/hooks","issue_events_url":"https://api.github.com/repos/yersan/wildfly-core/issues/events{/number}","events_url":"https://api.github.com/repos/yersan/wildfly-core/events","assignees_url":"https://api.github.com/repos/yersan/wildfly-core/assignees{/user}","branches_url":"https://api.github.com/repos/yersan/wildfly-core/branches{/branch}","tags_url":"https://api.github.com/repos/yersan/wildfly-core/tags","blobs_url":"https://api.github.com/repos/yersan/wildfly-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yersan/wildfly-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yersan/wildfly-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/yersan/wildfly-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yersan/wildfly-core/statuses/{sha}","languages_url":"https://api.github.com/repos/yersan/wildfly-core/languages","stargazers_url":"https://api.github.com/repos/yersan/wildfly-core/stargazers","contributors_url":"https://api.github.com/repos/yersan/wildfly-core/contributors","subscribers_url":"https://api.github.com/repos/yersan/wildfly-core/subscribers","subscription_url":"https://api.github.com/repos/yersan/wildfly-core/subscription","commits_url":"https://api.github.com/repos/yersan/wildfly-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/yersan/wildfly-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/yersan/wildfly-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/yersan/wildfly-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/yersan/wildfly-core/contents/{+path}","compare_url":"https://api.github.com/repos/yersan/wildfly-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yersan/wildfly-core/merges","archive_url":"https://api.github.com/repos/yersan/wildfly-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yersan/wildfly-core/downloads","issues_url":"https://api.github.com/repos/yersan/wildfly-core/issues{/number}","pulls_url":"https://api.github.com/repos/yersan/wildfly-core/pulls{/number}","milestones_url":"https://api.github.com/repos/yersan/wildfly-core/milestones{/number}","notifications_url":"https://api.github.com/repos/yersan/wildfly-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yersan/wildfly-core/labels{/name}","releases_url":"https://api.github.com/repos/yersan/wildfly-core/releases{/id}","deployments_url":"https://api.github.com/repos/yersan/wildfly-core/deployments","created_at":"2016-01-29T19:40:18Z","updated_at":"2018-12-03T13:17:35Z","pushed_at":"2018-12-03T13:17:33Z","git_url":"git://github.com/yersan/wildfly-core.git","ssh_url":"git@github.com:yersan/wildfly-core.git","clone_url":"https://github.com/yersan/wildfly-core.git","svn_url":"https://github.com/yersan/wildfly-core","homepage":null,"size":70775,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wildfly:master","ref":"master","sha":"c075dc513d8a05af71a07bf2b8f940b6afb22cc9","user":{"login":"wildfly","id":3066274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNjYyNzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3066274?v=4","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"repo":{"id":21394954,"node_id":"MDEwOlJlcG9zaXRvcnkyMTM5NDk1NA==","name":"wildfly-core","full_name":"wildfly/wildfly-core","private":false,"owner":{"login":"wildfly","id":3066274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNjYyNzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3066274?v=4","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wildfly/wildfly-core","description":"The core runtime that is used by the Wildfly application server","fork":false,"url":"https://api.github.com/repos/wildfly/wildfly-core","forks_url":"https://api.github.com/repos/wildfly/wildfly-core/forks","keys_url":"https://api.github.com/repos/wildfly/wildfly-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wildfly/wildfly-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wildfly/wildfly-core/teams","hooks_url":"https://api.github.com/repos/wildfly/wildfly-core/hooks","issue_events_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/events{/number}","events_url":"https://api.github.com/repos/wildfly/wildfly-core/events","assignees_url":"https://api.github.com/repos/wildfly/wildfly-core/assignees{/user}","branches_url":"https://api.github.com/repos/wildfly/wildfly-core/branches{/branch}","tags_url":"https://api.github.com/repos/wildfly/wildfly-core/tags","blobs_url":"https://api.github.com/repos/wildfly/wildfly-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wildfly/wildfly-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wildfly/wildfly-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/wildfly/wildfly-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wildfly/wildfly-core/statuses/{sha}","languages_url":"https://api.github.com/repos/wildfly/wildfly-core/languages","stargazers_url":"https://api.github.com/repos/wildfly/wildfly-core/stargazers","contributors_url":"https://api.github.com/repos/wildfly/wildfly-core/contributors","subscribers_url":"https://api.github.com/repos/wildfly/wildfly-core/subscribers","subscription_url":"https://api.github.com/repos/wildfly/wildfly-core/subscription","commits_url":"https://api.github.com/repos/wildfly/wildfly-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/wildfly/wildfly-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/wildfly/wildfly-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/wildfly/wildfly-core/contents/{+path}","compare_url":"https://api.github.com/repos/wildfly/wildfly-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wildfly/wildfly-core/merges","archive_url":"https://api.github.com/repos/wildfly/wildfly-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wildfly/wildfly-core/downloads","issues_url":"https://api.github.com/repos/wildfly/wildfly-core/issues{/number}","pulls_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls{/number}","milestones_url":"https://api.github.com/repos/wildfly/wildfly-core/milestones{/number}","notifications_url":"https://api.github.com/repos/wildfly/wildfly-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wildfly/wildfly-core/labels{/name}","releases_url":"https://api.github.com/repos/wildfly/wildfly-core/releases{/id}","deployments_url":"https://api.github.com/repos/wildfly/wildfly-core/deployments","created_at":"2014-07-01T16:33:34Z","updated_at":"2018-11-30T18:33:40Z","pushed_at":"2018-12-05T10:20:33Z","git_url":"git://github.com/wildfly/wildfly-core.git","ssh_url":"git@github.com:wildfly/wildfly-core.git","clone_url":"https://github.com/wildfly/wildfly-core.git","svn_url":"https://github.com/wildfly/wildfly-core","homepage":null,"size":73957,"stargazers_count":103,"watchers_count":103,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":345,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":345,"open_issues":32,"watchers":103,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/3601"},"html":{"href":"https://github.com/wildfly/wildfly-core/pull/3601"},"issue":{"href":"https://api.github.com/repos/wildfly/wildfly-core/issues/3601"},"comments":{"href":"https://api.github.com/repos/wildfly/wildfly-core/issues/3601/comments"},"review_comments":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/3601/comments"},"review_comment":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/3601/commits"},"statuses":{"href":"https://api.github.com/repos/wildfly/wildfly-core/statuses/26ca97ba59d3f3335c57c85886c1c529ab13a24a"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jmesnil","id":6193,"node_id":"MDQ6VXNlcjYxOTM=","avatar_url":"https://avatars2.githubusercontent.com/u/6193?v=4","gravatar_id":"","url":"https://api.github.com/users/jmesnil","html_url":"https://github.com/jmesnil","followers_url":"https://api.github.com/users/jmesnil/followers","following_url":"https://api.github.com/users/jmesnil/following{/other_user}","gists_url":"https://api.github.com/users/jmesnil/gists{/gist_id}","starred_url":"https://api.github.com/users/jmesnil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmesnil/subscriptions","organizations_url":"https://api.github.com/users/jmesnil/orgs","repos_url":"https://api.github.com/users/jmesnil/repos","events_url":"https://api.github.com/users/jmesnil/events{/privacy}","received_events_url":"https://api.github.com/users/jmesnil/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":10,"deletions":4,"changed_files":2}}
{"actor":{"display_login":"jmesnil"}}