{"action":"created","issue":{"url":"https://api.github.com/repos/AssemblyScript/binaryen.js/issues/5","repository_url":"https://api.github.com/repos/AssemblyScript/binaryen.js","labels_url":"https://api.github.com/repos/AssemblyScript/binaryen.js/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/AssemblyScript/binaryen.js/issues/5/comments","events_url":"https://api.github.com/repos/AssemblyScript/binaryen.js/issues/5/events","html_url":"https://github.com/AssemblyScript/binaryen.js/issues/5","id":377003829,"node_id":"MDU6SXNzdWUzNzcwMDM4Mjk=","number":5,"title":"Store returns an expression","user":{"login":"SeboCode","id":8930054,"node_id":"MDQ6VXNlcjg5MzAwNTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/8930054?v=4","gravatar_id":"","url":"https://api.github.com/users/SeboCode","html_url":"https://github.com/SeboCode","followers_url":"https://api.github.com/users/SeboCode/followers","following_url":"https://api.github.com/users/SeboCode/following{/other_user}","gists_url":"https://api.github.com/users/SeboCode/gists{/gist_id}","starred_url":"https://api.github.com/users/SeboCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeboCode/subscriptions","organizations_url":"https://api.github.com/users/SeboCode/orgs","repos_url":"https://api.github.com/users/SeboCode/repos","events_url":"https://api.github.com/users/SeboCode/events{/privacy}","received_events_url":"https://api.github.com/users/SeboCode/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-03T00:13:13Z","updated_at":"2018-11-03T05:44:19Z","closed_at":null,"author_association":"NONE","body":"Is there a specific reason why the `store()` method returns an expression?\r\nI think a statement would be much more fitting."},"comment":{"url":"https://api.github.com/repos/AssemblyScript/binaryen.js/issues/comments/435562848","html_url":"https://github.com/AssemblyScript/binaryen.js/issues/5#issuecomment-435562848","issue_url":"https://api.github.com/repos/AssemblyScript/binaryen.js/issues/5","id":435562848,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTU2Mjg0OA==","user":{"login":"dcodeIO","id":1136893,"node_id":"MDQ6VXNlcjExMzY4OTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1136893?v=4","gravatar_id":"","url":"https://api.github.com/users/dcodeIO","html_url":"https://github.com/dcodeIO","followers_url":"https://api.github.com/users/dcodeIO/followers","following_url":"https://api.github.com/users/dcodeIO/following{/other_user}","gists_url":"https://api.github.com/users/dcodeIO/gists{/gist_id}","starred_url":"https://api.github.com/users/dcodeIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcodeIO/subscriptions","organizations_url":"https://api.github.com/users/dcodeIO/orgs","repos_url":"https://api.github.com/users/dcodeIO/repos","events_url":"https://api.github.com/users/dcodeIO/events{/privacy}","received_events_url":"https://api.github.com/users/dcodeIO/received_events","type":"User","site_admin":false},"created_at":"2018-11-03T05:44:19Z","updated_at":"2018-11-03T05:44:19Z","author_association":"MEMBER","body":"According to our typings, a `store` should probably be a `Statement` as you pointed out. Note, though, that the distinction between `Expression` and `Statement` is artificial here, as there are actually no statements in Binaryen itself. It might make sense to reflect that in our typings by removing `Statement` entirely, as that's pretty much just an `Expression` of type `None` anyway."}}
{"actor":{"display_login":"dcodeIO"}}