{"action":"created","comment":{"url":"https://api.github.com/repos/haskell-nix/hnix-store/pulls/comments/185224340","pull_request_review_id":116564385,"id":185224340,"diff_hunk":"@@ -1,3 +1,5 @@\n+{-# LANGUAGE PackageImports #-}","path":"hnix-store-core/src/System/Nix/Store.hs","position":1,"original_position":1,"commit_id":"7f5df3456f282eb789cb1f118d63d3ebaafab796","original_commit_id":"7f5df3456f282eb789cb1f118d63d3ebaafab796","user":{"login":"shlevy","id":487050,"avatar_url":"https://avatars3.githubusercontent.com/u/487050?v=4","gravatar_id":"","url":"https://api.github.com/users/shlevy","html_url":"https://github.com/shlevy","followers_url":"https://api.github.com/users/shlevy/followers","following_url":"https://api.github.com/users/shlevy/following{/other_user}","gists_url":"https://api.github.com/users/shlevy/gists{/gist_id}","starred_url":"https://api.github.com/users/shlevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlevy/subscriptions","organizations_url":"https://api.github.com/users/shlevy/orgs","repos_url":"https://api.github.com/users/shlevy/repos","events_url":"https://api.github.com/users/shlevy/events{/privacy}","received_events_url":"https://api.github.com/users/shlevy/received_events","type":"User","site_admin":false},"body":"Why?","created_at":"2018-05-01T13:45:55Z","updated_at":"2018-05-01T13:50:36Z","html_url":"https://github.com/haskell-nix/hnix-store/pull/7#discussion_r185224340","pull_request_url":"https://api.github.com/repos/haskell-nix/hnix-store/pulls/7","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/haskell-nix/hnix-store/pulls/comments/185224340"},"html":{"href":"https://github.com/haskell-nix/hnix-store/pull/7#discussion_r185224340"},"pull_request":{"href":"https://api.github.com/repos/haskell-nix/hnix-store/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/haskell-nix/hnix-store/pulls/7","id":184920002,"html_url":"https://github.com/haskell-nix/hnix-store/pull/7","diff_url":"https://github.com/haskell-nix/hnix-store/pull/7.diff","patch_url":"https://github.com/haskell-nix/hnix-store/pull/7.patch","issue_url":"https://api.github.com/repos/haskell-nix/hnix-store/issues/7","number":7,"state":"open","locked":false,"title":"NAR parser/generator","user":{"login":"imalsogreg","id":993484,"avatar_url":"https://avatars3.githubusercontent.com/u/993484?v=4","gravatar_id":"","url":"https://api.github.com/users/imalsogreg","html_url":"https://github.com/imalsogreg","followers_url":"https://api.github.com/users/imalsogreg/followers","following_url":"https://api.github.com/users/imalsogreg/following{/other_user}","gists_url":"https://api.github.com/users/imalsogreg/gists{/gist_id}","starred_url":"https://api.github.com/users/imalsogreg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imalsogreg/subscriptions","organizations_url":"https://api.github.com/users/imalsogreg/orgs","repos_url":"https://api.github.com/users/imalsogreg/repos","events_url":"https://api.github.com/users/imalsogreg/events{/privacy}","received_events_url":"https://api.github.com/users/imalsogreg/received_events","type":"User","site_admin":false},"body":"NAR parser and generator. Moved `Path` types and functions into `Paths.hs` module.\r\n\r\n### Todo\r\n - [x] cleanup\r\n - [x] test the generator manually\r\n - [x] create tests (parse . gen === id)\r\n\r\n### Testing Done\r\n\r\nI used `nix-store --dump` to create sample nar files: a plain file, an executable, a symlink, and a directory with those files. The NAR files on disk match those generated by `hnix-store-core`, and `hnix-store-core`'s parser and generator are consistent with each other.\r\n\r\n```\r\ntests/Driver.hs\r\n  narEncoding\r\n    parser-roundtrip\r\n      roundtrips regular:    OK\r\n      roundtrips regular 2:  OK\r\n      roundtrips executable: OK\r\n      roundtrips symlink:    OK\r\n      roundtrips directory:  OK\r\n    matches-nix-store\r\n      matches regular:       OK\r\n      matches regular':      OK\r\n      matches executable:    OK\r\n      matches symlink:       OK\r\n      matches directory:     OK\r\n\r\nAll 10 tests passed (0.00s)\r\n\r\n...done\r\n```\r\n","created_at":"2018-04-30T10:10:57Z","updated_at":"2018-05-01T13:50:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ad2796e66cbf80e1d6ea012619dda765133e773","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/haskell-nix/hnix-store/pulls/7/commits","review_comments_url":"https://api.github.com/repos/haskell-nix/hnix-store/pulls/7/comments","review_comment_url":"https://api.github.com/repos/haskell-nix/hnix-store/pulls/comments{/number}","comments_url":"https://api.github.com/repos/haskell-nix/hnix-store/issues/7/comments","statuses_url":"https://api.github.com/repos/haskell-nix/hnix-store/statuses/7f5df3456f282eb789cb1f118d63d3ebaafab796","head":{"label":"imalsogreg:master","ref":"master","sha":"7f5df3456f282eb789cb1f118d63d3ebaafab796","user":{"login":"imalsogreg","id":993484,"avatar_url":"https://avatars3.githubusercontent.com/u/993484?v=4","gravatar_id":"","url":"https://api.github.com/users/imalsogreg","html_url":"https://github.com/imalsogreg","followers_url":"https://api.github.com/users/imalsogreg/followers","following_url":"https://api.github.com/users/imalsogreg/following{/other_user}","gists_url":"https://api.github.com/users/imalsogreg/gists{/gist_id}","starred_url":"https://api.github.com/users/imalsogreg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imalsogreg/subscriptions","organizations_url":"https://api.github.com/users/imalsogreg/orgs","repos_url":"https://api.github.com/users/imalsogreg/repos","events_url":"https://api.github.com/users/imalsogreg/events{/privacy}","received_events_url":"https://api.github.com/users/imalsogreg/received_events","type":"User","site_admin":false},"repo":{"id":131580487,"name":"hnix-store","full_name":"imalsogreg/hnix-store","owner":{"login":"imalsogreg","id":993484,"avatar_url":"https://avatars3.githubusercontent.com/u/993484?v=4","gravatar_id":"","url":"https://api.github.com/users/imalsogreg","html_url":"https://github.com/imalsogreg","followers_url":"https://api.github.com/users/imalsogreg/followers","following_url":"https://api.github.com/users/imalsogreg/following{/other_user}","gists_url":"https://api.github.com/users/imalsogreg/gists{/gist_id}","starred_url":"https://api.github.com/users/imalsogreg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imalsogreg/subscriptions","organizations_url":"https://api.github.com/users/imalsogreg/orgs","repos_url":"https://api.github.com/users/imalsogreg/repos","events_url":"https://api.github.com/users/imalsogreg/events{/privacy}","received_events_url":"https://api.github.com/users/imalsogreg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/imalsogreg/hnix-store","description":"Haskell implementation of the nix store API","fork":true,"url":"https://api.github.com/repos/imalsogreg/hnix-store","forks_url":"https://api.github.com/repos/imalsogreg/hnix-store/forks","keys_url":"https://api.github.com/repos/imalsogreg/hnix-store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/imalsogreg/hnix-store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/imalsogreg/hnix-store/teams","hooks_url":"https://api.github.com/repos/imalsogreg/hnix-store/hooks","issue_events_url":"https://api.github.com/repos/imalsogreg/hnix-store/issues/events{/number}","events_url":"https://api.github.com/repos/imalsogreg/hnix-store/events","assignees_url":"https://api.github.com/repos/imalsogreg/hnix-store/assignees{/user}","branches_url":"https://api.github.com/repos/imalsogreg/hnix-store/branches{/branch}","tags_url":"https://api.github.com/repos/imalsogreg/hnix-store/tags","blobs_url":"https://api.github.com/repos/imalsogreg/hnix-store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/imalsogreg/hnix-store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/imalsogreg/hnix-store/git/refs{/sha}","trees_url":"https://api.github.com/repos/imalsogreg/hnix-store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/imalsogreg/hnix-store/statuses/{sha}","languages_url":"https://api.github.com/repos/imalsogreg/hnix-store/languages","stargazers_url":"https://api.github.com/repos/imalsogreg/hnix-store/stargazers","contributors_url":"https://api.github.com/repos/imalsogreg/hnix-store/contributors","subscribers_url":"https://api.github.com/repos/imalsogreg/hnix-store/subscribers","subscription_url":"https://api.github.com/repos/imalsogreg/hnix-store/subscription","commits_url":"https://api.github.com/repos/imalsogreg/hnix-store/commits{/sha}","git_commits_url":"https://api.github.com/repos/imalsogreg/hnix-store/git/commits{/sha}","comments_url":"https://api.github.com/repos/imalsogreg/hnix-store/comments{/number}","issue_comment_url":"https://api.github.com/repos/imalsogreg/hnix-store/issues/comments{/number}","contents_url":"https://api.github.com/repos/imalsogreg/hnix-store/contents/{+path}","compare_url":"https://api.github.com/repos/imalsogreg/hnix-store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/imalsogreg/hnix-store/merges","archive_url":"https://api.github.com/repos/imalsogreg/hnix-store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/imalsogreg/hnix-store/downloads","issues_url":"https://api.github.com/repos/imalsogreg/hnix-store/issues{/number}","pulls_url":"https://api.github.com/repos/imalsogreg/hnix-store/pulls{/number}","milestones_url":"https://api.github.com/repos/imalsogreg/hnix-store/milestones{/number}","notifications_url":"https://api.github.com/repos/imalsogreg/hnix-store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/imalsogreg/hnix-store/labels{/name}","releases_url":"https://api.github.com/repos/imalsogreg/hnix-store/releases{/id}","deployments_url":"https://api.github.com/repos/imalsogreg/hnix-store/deployments","created_at":"2018-04-30T10:00:12Z","updated_at":"2018-05-01T09:53:35Z","pushed_at":"2018-05-01T09:53:34Z","git_url":"git://github.com/imalsogreg/hnix-store.git","ssh_url":"git@github.com:imalsogreg/hnix-store.git","clone_url":"https://github.com/imalsogreg/hnix-store.git","svn_url":"https://github.com/imalsogreg/hnix-store","homepage":null,"size":60,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"haskell-nix:master","ref":"master","sha":"da0f19a65f1aeca72ac3ac1b3ad9cb52874a354f","user":{"login":"haskell-nix","id":38674962,"avatar_url":"https://avatars3.githubusercontent.com/u/38674962?v=4","gravatar_id":"","url":"https://api.github.com/users/haskell-nix","html_url":"https://github.com/haskell-nix","followers_url":"https://api.github.com/users/haskell-nix/followers","following_url":"https://api.github.com/users/haskell-nix/following{/other_user}","gists_url":"https://api.github.com/users/haskell-nix/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell-nix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell-nix/subscriptions","organizations_url":"https://api.github.com/users/haskell-nix/orgs","repos_url":"https://api.github.com/users/haskell-nix/repos","events_url":"https://api.github.com/users/haskell-nix/events{/privacy}","received_events_url":"https://api.github.com/users/haskell-nix/received_events","type":"Organization","site_admin":false},"repo":{"id":21681581,"name":"hnix-store","full_name":"haskell-nix/hnix-store","owner":{"login":"haskell-nix","id":38674962,"avatar_url":"https://avatars3.githubusercontent.com/u/38674962?v=4","gravatar_id":"","url":"https://api.github.com/users/haskell-nix","html_url":"https://github.com/haskell-nix","followers_url":"https://api.github.com/users/haskell-nix/followers","following_url":"https://api.github.com/users/haskell-nix/following{/other_user}","gists_url":"https://api.github.com/users/haskell-nix/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell-nix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell-nix/subscriptions","organizations_url":"https://api.github.com/users/haskell-nix/orgs","repos_url":"https://api.github.com/users/haskell-nix/repos","events_url":"https://api.github.com/users/haskell-nix/events{/privacy}","received_events_url":"https://api.github.com/users/haskell-nix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/haskell-nix/hnix-store","description":"Haskell implementation of the nix store API","fork":false,"url":"https://api.github.com/repos/haskell-nix/hnix-store","forks_url":"https://api.github.com/repos/haskell-nix/hnix-store/forks","keys_url":"https://api.github.com/repos/haskell-nix/hnix-store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haskell-nix/hnix-store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haskell-nix/hnix-store/teams","hooks_url":"https://api.github.com/repos/haskell-nix/hnix-store/hooks","issue_events_url":"https://api.github.com/repos/haskell-nix/hnix-store/issues/events{/number}","events_url":"https://api.github.com/repos/haskell-nix/hnix-store/events","assignees_url":"https://api.github.com/repos/haskell-nix/hnix-store/assignees{/user}","branches_url":"https://api.github.com/repos/haskell-nix/hnix-store/branches{/branch}","tags_url":"https://api.github.com/repos/haskell-nix/hnix-store/tags","blobs_url":"https://api.github.com/repos/haskell-nix/hnix-store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haskell-nix/hnix-store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haskell-nix/hnix-store/git/refs{/sha}","trees_url":"https://api.github.com/repos/haskell-nix/hnix-store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haskell-nix/hnix-store/statuses/{sha}","languages_url":"https://api.github.com/repos/haskell-nix/hnix-store/languages","stargazers_url":"https://api.github.com/repos/haskell-nix/hnix-store/stargazers","contributors_url":"https://api.github.com/repos/haskell-nix/hnix-store/contributors","subscribers_url":"https://api.github.com/repos/haskell-nix/hnix-store/subscribers","subscription_url":"https://api.github.com/repos/haskell-nix/hnix-store/subscription","commits_url":"https://api.github.com/repos/haskell-nix/hnix-store/commits{/sha}","git_commits_url":"https://api.github.com/repos/haskell-nix/hnix-store/git/commits{/sha}","comments_url":"https://api.github.com/repos/haskell-nix/hnix-store/comments{/number}","issue_comment_url":"https://api.github.com/repos/haskell-nix/hnix-store/issues/comments{/number}","contents_url":"https://api.github.com/repos/haskell-nix/hnix-store/contents/{+path}","compare_url":"https://api.github.com/repos/haskell-nix/hnix-store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haskell-nix/hnix-store/merges","archive_url":"https://api.github.com/repos/haskell-nix/hnix-store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haskell-nix/hnix-store/downloads","issues_url":"https://api.github.com/repos/haskell-nix/hnix-store/issues{/number}","pulls_url":"https://api.github.com/repos/haskell-nix/hnix-store/pulls{/number}","milestones_url":"https://api.github.com/repos/haskell-nix/hnix-store/milestones{/number}","notifications_url":"https://api.github.com/repos/haskell-nix/hnix-store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haskell-nix/hnix-store/labels{/name}","releases_url":"https://api.github.com/repos/haskell-nix/hnix-store/releases{/id}","deployments_url":"https://api.github.com/repos/haskell-nix/hnix-store/deployments","created_at":"2014-07-10T05:59:13Z","updated_at":"2018-05-01T09:18:07Z","pushed_at":"2018-05-01T09:53:35Z","git_url":"git://github.com/haskell-nix/hnix-store.git","ssh_url":"git@github.com:haskell-nix/hnix-store.git","clone_url":"https://github.com/haskell-nix/hnix-store.git","svn_url":"https://github.com/haskell-nix/hnix-store","homepage":null,"size":50,"stargazers_count":17,"watchers_count":17,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3,"open_issues":2,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/haskell-nix/hnix-store/pulls/7"},"html":{"href":"https://github.com/haskell-nix/hnix-store/pull/7"},"issue":{"href":"https://api.github.com/repos/haskell-nix/hnix-store/issues/7"},"comments":{"href":"https://api.github.com/repos/haskell-nix/hnix-store/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/haskell-nix/hnix-store/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/haskell-nix/hnix-store/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/haskell-nix/hnix-store/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/haskell-nix/hnix-store/statuses/7f5df3456f282eb789cb1f118d63d3ebaafab796"}},"author_association":"NONE"}}
{"actor":{"display_login":"shlevy"}}