{"action":"created","issue":{"url":"https://api.github.com/repos/chrisallenlane/cheat/issues/391","repository_url":"https://api.github.com/repos/chrisallenlane/cheat","labels_url":"https://api.github.com/repos/chrisallenlane/cheat/issues/391/labels{/name}","comments_url":"https://api.github.com/repos/chrisallenlane/cheat/issues/391/comments","events_url":"https://api.github.com/repos/chrisallenlane/cheat/issues/391/events","html_url":"https://github.com/chrisallenlane/cheat/pull/391","id":352970518,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMTQ2Njcw","number":391,"title":"Make cheat easier to pack","user":{"login":"TomasKorbar","id":25184281,"node_id":"MDQ6VXNlcjI1MTg0Mjgx","avatar_url":"https://avatars1.githubusercontent.com/u/25184281?v=4","gravatar_id":"","url":"https://api.github.com/users/TomasKorbar","html_url":"https://github.com/TomasKorbar","followers_url":"https://api.github.com/users/TomasKorbar/followers","following_url":"https://api.github.com/users/TomasKorbar/following{/other_user}","gists_url":"https://api.github.com/users/TomasKorbar/gists{/gist_id}","starred_url":"https://api.github.com/users/TomasKorbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomasKorbar/subscriptions","organizations_url":"https://api.github.com/users/TomasKorbar/orgs","repos_url":"https://api.github.com/users/TomasKorbar/repos","events_url":"https://api.github.com/users/TomasKorbar/events{/privacy}","received_events_url":"https://api.github.com/users/TomasKorbar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-08-22T14:08:35Z","updated_at":"2019-01-02T08:50:54Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/chrisallenlane/cheat/pulls/391","html_url":"https://github.com/chrisallenlane/cheat/pull/391","diff_url":"https://github.com/chrisallenlane/cheat/pull/391.diff","patch_url":"https://github.com/chrisallenlane/cheat/pull/391.patch"},"body":"Hello,\r\nThis pull request contains changes that\r\n1. move cheatsheets default location to /usr/share/cheat which i think is better location than /usr/lib/python-2.7/site-packages/cheat/cheatsheets\r\n2. divide cheat into classes and methods which in result makes cheat code more readable and allows easier using of unittests\r\n3. add Configuration class which allows creation of local and global config files. Environment variables still work\r\n4. add ConfigurationTestCase which proves hiearchy of configuration system. (env vars > local config file > global config file)\r\nTogether these changes make cheat easier to pack into rpm package and add more options how to edit cheats settings.\r\nresolve #271 \r\nresolve #273 \r\n"},"comment":{"url":"https://api.github.com/repos/chrisallenlane/cheat/issues/comments/450811192","html_url":"https://github.com/chrisallenlane/cheat/pull/391#issuecomment-450811192","issue_url":"https://api.github.com/repos/chrisallenlane/cheat/issues/391","id":450811192,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDgxMTE5Mg==","user":{"login":"pirat89","id":1656374,"node_id":"MDQ6VXNlcjE2NTYzNzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1656374?v=4","gravatar_id":"","url":"https://api.github.com/users/pirat89","html_url":"https://github.com/pirat89","followers_url":"https://api.github.com/users/pirat89/followers","following_url":"https://api.github.com/users/pirat89/following{/other_user}","gists_url":"https://api.github.com/users/pirat89/gists{/gist_id}","starred_url":"https://api.github.com/users/pirat89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pirat89/subscriptions","organizations_url":"https://api.github.com/users/pirat89/orgs","repos_url":"https://api.github.com/users/pirat89/repos","events_url":"https://api.github.com/users/pirat89/events{/privacy}","received_events_url":"https://api.github.com/users/pirat89/received_events","type":"User","site_admin":false},"created_at":"2019-01-02T08:50:54Z","updated_at":"2019-01-02T08:50:54Z","author_association":"NONE","body":"@chrisallenlane Hi Chris, it's a time ago, but do you think you would have time this month to the a review? As there are anore PRs and this is the biggest patch at all, it would be nice to resolve this one first, so it will not have to be modiffied again and again.\r\n\r\nI see that a rebase is needed now. @TomasKorbar, would you rebase the PR against master branch so it will be prepared again for review?"}}
{"actor":{"display_login":"pirat89"}}