{"action":"created","comment":{"url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/pulls/comments/174389667","pull_request_review_id":103733752,"id":174389667,"diff_hunk":"@@ -42,10 +54,52 @@ var partnerValidator = function (configs) {\n                 properties: {\n                     '*': {\n                         type: 'object',\n+                        someKeys: ['placementId', 'placementKey'],\n+                        $impliesPresence : {\n+                            if: \"placementKey\",\n+                            then: \"publisherId\"\n+                        },\n                         properties: {\n+                            currency: {\n+                                type: 'string',\n+                                optional: true,\n+                                pattern: /^USD|EUR|GBP|AUD|DKK|SEK|CZK|CHF|NOK$/\n+                            },\n                             placementId: {\n+                                type: 'number',\n+                                optional: true\n+                            },\n+                            size:{\n+                                type: 'object',\n+                                optional: true,\n+                                properties: {\n+                                    w: {\n+                                        type: 'number'\n+                                    },\n+                                    h: {\n+                                        type: 'number'\n+                                    }\n+                                }\n+                            },\n+                            publisherId: {\n+                                type: 'number',","path":"improve-digital-htb-validator.js","position":70,"original_position":51,"commit_id":"ee398141d303724ba0d753e257c1b9fcd2770829","original_commit_id":"5bb39acce4810c9c3d2c187bdbc6b63fc69c00cc","user":{"login":"agregorio-improve","id":19835904,"avatar_url":"https://avatars0.githubusercontent.com/u/19835904?v=4","gravatar_id":"","url":"https://api.github.com/users/agregorio-improve","html_url":"https://github.com/agregorio-improve","followers_url":"https://api.github.com/users/agregorio-improve/followers","following_url":"https://api.github.com/users/agregorio-improve/following{/other_user}","gists_url":"https://api.github.com/users/agregorio-improve/gists{/gist_id}","starred_url":"https://api.github.com/users/agregorio-improve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agregorio-improve/subscriptions","organizations_url":"https://api.github.com/users/agregorio-improve/orgs","repos_url":"https://api.github.com/users/agregorio-improve/repos","events_url":"https://api.github.com/users/agregorio-improve/events{/privacy}","received_events_url":"https://api.github.com/users/agregorio-improve/received_events","type":"User","site_admin":false},"body":"Extra validation has been added.","created_at":"2018-03-14T09:00:41Z","updated_at":"2018-03-14T09:00:41Z","html_url":"https://github.com/indexexchange/improve-digital-adapter/pull/1#discussion_r174389667","pull_request_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/pulls/1","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/indexexchange/improve-digital-adapter/pulls/comments/174389667"},"html":{"href":"https://github.com/indexexchange/improve-digital-adapter/pull/1#discussion_r174389667"},"pull_request":{"href":"https://api.github.com/repos/indexexchange/improve-digital-adapter/pulls/1"}},"in_reply_to_id":173844007},"pull_request":{"url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/pulls/1","id":159107829,"html_url":"https://github.com/indexexchange/improve-digital-adapter/pull/1","diff_url":"https://github.com/indexexchange/improve-digital-adapter/pull/1.diff","patch_url":"https://github.com/indexexchange/improve-digital-adapter/pull/1.patch","issue_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/issues/1","number":1,"state":"open","locked":false,"title":"Improve Digital Adapter Implementation","user":{"login":"agregorio-improve","id":19835904,"avatar_url":"https://avatars0.githubusercontent.com/u/19835904?v=4","gravatar_id":"","url":"https://api.github.com/users/agregorio-improve","html_url":"https://github.com/agregorio-improve","followers_url":"https://api.github.com/users/agregorio-improve/followers","following_url":"https://api.github.com/users/agregorio-improve/following{/other_user}","gists_url":"https://api.github.com/users/agregorio-improve/gists{/gist_id}","starred_url":"https://api.github.com/users/agregorio-improve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agregorio-improve/subscriptions","organizations_url":"https://api.github.com/users/agregorio-improve/orgs","repos_url":"https://api.github.com/users/agregorio-improve/repos","events_url":"https://api.github.com/users/agregorio-improve/events{/privacy}","received_events_url":"https://api.github.com/users/agregorio-improve/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-12-19T08:44:37Z","updated_at":"2018-03-14T09:00:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"72cd261ef03a6f83c88b1dce804b9ac18ba7ec36","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/pulls/1/commits","review_comments_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/pulls/1/comments","review_comment_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/issues/1/comments","statuses_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/statuses/ee398141d303724ba0d753e257c1b9fcd2770829","head":{"label":"indexexchange:development-v2","ref":"development-v2","sha":"ee398141d303724ba0d753e257c1b9fcd2770829","user":{"login":"indexexchange","id":17625003,"avatar_url":"https://avatars1.githubusercontent.com/u/17625003?v=4","gravatar_id":"","url":"https://api.github.com/users/indexexchange","html_url":"https://github.com/indexexchange","followers_url":"https://api.github.com/users/indexexchange/followers","following_url":"https://api.github.com/users/indexexchange/following{/other_user}","gists_url":"https://api.github.com/users/indexexchange/gists{/gist_id}","starred_url":"https://api.github.com/users/indexexchange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indexexchange/subscriptions","organizations_url":"https://api.github.com/users/indexexchange/orgs","repos_url":"https://api.github.com/users/indexexchange/repos","events_url":"https://api.github.com/users/indexexchange/events{/privacy}","received_events_url":"https://api.github.com/users/indexexchange/received_events","type":"Organization","site_admin":false},"repo":{"id":108020125,"name":"improve-digital-adapter","full_name":"indexexchange/improve-digital-adapter","owner":{"login":"indexexchange","id":17625003,"avatar_url":"https://avatars1.githubusercontent.com/u/17625003?v=4","gravatar_id":"","url":"https://api.github.com/users/indexexchange","html_url":"https://github.com/indexexchange","followers_url":"https://api.github.com/users/indexexchange/followers","following_url":"https://api.github.com/users/indexexchange/following{/other_user}","gists_url":"https://api.github.com/users/indexexchange/gists{/gist_id}","starred_url":"https://api.github.com/users/indexexchange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indexexchange/subscriptions","organizations_url":"https://api.github.com/users/indexexchange/orgs","repos_url":"https://api.github.com/users/indexexchange/repos","events_url":"https://api.github.com/users/indexexchange/events{/privacy}","received_events_url":"https://api.github.com/users/indexexchange/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/indexexchange/improve-digital-adapter","description":null,"fork":false,"url":"https://api.github.com/repos/indexexchange/improve-digital-adapter","forks_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/forks","keys_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/teams","hooks_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/hooks","issue_events_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/issues/events{/number}","events_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/events","assignees_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/assignees{/user}","branches_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/branches{/branch}","tags_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/tags","blobs_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/git/refs{/sha}","trees_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/statuses/{sha}","languages_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/languages","stargazers_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/stargazers","contributors_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/contributors","subscribers_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/subscribers","subscription_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/subscription","commits_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/commits{/sha}","git_commits_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/git/commits{/sha}","comments_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/comments{/number}","issue_comment_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/issues/comments{/number}","contents_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/contents/{+path}","compare_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/merges","archive_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/downloads","issues_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/issues{/number}","pulls_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/pulls{/number}","milestones_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/milestones{/number}","notifications_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/labels{/name}","releases_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/releases{/id}","deployments_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/deployments","created_at":"2017-10-23T18:09:04Z","updated_at":"2018-03-12T15:44:22Z","pushed_at":"2018-03-14T08:59:23Z","git_url":"git://github.com/indexexchange/improve-digital-adapter.git","ssh_url":"git@github.com:indexexchange/improve-digital-adapter.git","clone_url":"https://github.com/indexexchange/improve-digital-adapter.git","svn_url":"https://github.com/indexexchange/improve-digital-adapter","homepage":null,"size":39,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master-v2"}},"base":{"label":"indexexchange:master-v2","ref":"master-v2","sha":"59ab82e48044b8b25a807b4ea51a7329dd2daca5","user":{"login":"indexexchange","id":17625003,"avatar_url":"https://avatars1.githubusercontent.com/u/17625003?v=4","gravatar_id":"","url":"https://api.github.com/users/indexexchange","html_url":"https://github.com/indexexchange","followers_url":"https://api.github.com/users/indexexchange/followers","following_url":"https://api.github.com/users/indexexchange/following{/other_user}","gists_url":"https://api.github.com/users/indexexchange/gists{/gist_id}","starred_url":"https://api.github.com/users/indexexchange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indexexchange/subscriptions","organizations_url":"https://api.github.com/users/indexexchange/orgs","repos_url":"https://api.github.com/users/indexexchange/repos","events_url":"https://api.github.com/users/indexexchange/events{/privacy}","received_events_url":"https://api.github.com/users/indexexchange/received_events","type":"Organization","site_admin":false},"repo":{"id":108020125,"name":"improve-digital-adapter","full_name":"indexexchange/improve-digital-adapter","owner":{"login":"indexexchange","id":17625003,"avatar_url":"https://avatars1.githubusercontent.com/u/17625003?v=4","gravatar_id":"","url":"https://api.github.com/users/indexexchange","html_url":"https://github.com/indexexchange","followers_url":"https://api.github.com/users/indexexchange/followers","following_url":"https://api.github.com/users/indexexchange/following{/other_user}","gists_url":"https://api.github.com/users/indexexchange/gists{/gist_id}","starred_url":"https://api.github.com/users/indexexchange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indexexchange/subscriptions","organizations_url":"https://api.github.com/users/indexexchange/orgs","repos_url":"https://api.github.com/users/indexexchange/repos","events_url":"https://api.github.com/users/indexexchange/events{/privacy}","received_events_url":"https://api.github.com/users/indexexchange/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/indexexchange/improve-digital-adapter","description":null,"fork":false,"url":"https://api.github.com/repos/indexexchange/improve-digital-adapter","forks_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/forks","keys_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/teams","hooks_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/hooks","issue_events_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/issues/events{/number}","events_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/events","assignees_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/assignees{/user}","branches_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/branches{/branch}","tags_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/tags","blobs_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/git/refs{/sha}","trees_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/statuses/{sha}","languages_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/languages","stargazers_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/stargazers","contributors_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/contributors","subscribers_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/subscribers","subscription_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/subscription","commits_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/commits{/sha}","git_commits_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/git/commits{/sha}","comments_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/comments{/number}","issue_comment_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/issues/comments{/number}","contents_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/contents/{+path}","compare_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/merges","archive_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/downloads","issues_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/issues{/number}","pulls_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/pulls{/number}","milestones_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/milestones{/number}","notifications_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/labels{/name}","releases_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/releases{/id}","deployments_url":"https://api.github.com/repos/indexexchange/improve-digital-adapter/deployments","created_at":"2017-10-23T18:09:04Z","updated_at":"2018-03-12T15:44:22Z","pushed_at":"2018-03-14T08:59:23Z","git_url":"git://github.com/indexexchange/improve-digital-adapter.git","ssh_url":"git@github.com:indexexchange/improve-digital-adapter.git","clone_url":"https://github.com/indexexchange/improve-digital-adapter.git","svn_url":"https://github.com/indexexchange/improve-digital-adapter","homepage":null,"size":39,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master-v2"}},"_links":{"self":{"href":"https://api.github.com/repos/indexexchange/improve-digital-adapter/pulls/1"},"html":{"href":"https://github.com/indexexchange/improve-digital-adapter/pull/1"},"issue":{"href":"https://api.github.com/repos/indexexchange/improve-digital-adapter/issues/1"},"comments":{"href":"https://api.github.com/repos/indexexchange/improve-digital-adapter/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/indexexchange/improve-digital-adapter/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/indexexchange/improve-digital-adapter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/indexexchange/improve-digital-adapter/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/indexexchange/improve-digital-adapter/statuses/ee398141d303724ba0d753e257c1b9fcd2770829"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"agregorio-improve"}}