{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-app-ios/pulls/comments/179721531","pull_request_review_id":109959330,"id":179721531,"diff_hunk":"@@ -0,0 +1,535 @@\n+//\n+//  VideoPlayerControls.swift\n+//  edX\n+//\n+//  Created by Salman on 06/03/2018.\n+//  Copyright © 2018 edX. All rights reserved.\n+//\n+\n+import UIKit\n+import CoreMedia\n+\n+protocol VideoPlayerControlsDelegate {\n+    func playPausePressed(isPlaying: Bool)\n+    func seekBackwardPressed()\n+    func fullscreenPressed()\n+    func setPlayBackSpeed(playerControls: VideoPlayerControls, speed:OEXVideoSpeed)\n+    func sliderValueChanged(playerControls: VideoPlayerControls)\n+    func sliderTouchBegan(playerControls: VideoPlayerControls)\n+    func sliderTouchEnded(playerControls: VideoPlayerControls)\n+}\n+\n+class VideoPlayerControls: UIView, VideoPlayerSettingsDelegate {\n+    \n+    var video : OEXHelperVideoDownload? {\n+        didSet {\n+            startBufferedTimer()\n+        }\n+    }\n+    private var playerSettings : OEXVideoPlayerSettings = OEXVideoPlayerSettings()\n+    private var isControlsHidden: Bool = true\n+    private var subtitleActivated : Bool = false\n+    private var bufferedTimer: Timer?\n+    private var dataInterface = OEXInterface.shared()\n+    private let videoPlayerController: AVVideoPlayer\n+    var delegate : VideoPlayerControlsDelegate?\n+    var playerStartTime: TimeInterval = 0","path":"Source/CutomePlayer/VideoPlayerControls.swift","position":36,"original_position":36,"commit_id":"2df8bc9dc2c416c20933880ac60e290549ec2ba1","original_commit_id":"2df8bc9dc2c416c20933880ac60e290549ec2ba1","user":{"login":"saeedbashir","id":5606473,"avatar_url":"https://avatars2.githubusercontent.com/u/5606473?v=4","gravatar_id":"","url":"https://api.github.com/users/saeedbashir","html_url":"https://github.com/saeedbashir","followers_url":"https://api.github.com/users/saeedbashir/followers","following_url":"https://api.github.com/users/saeedbashir/following{/other_user}","gists_url":"https://api.github.com/users/saeedbashir/gists{/gist_id}","starred_url":"https://api.github.com/users/saeedbashir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saeedbashir/subscriptions","organizations_url":"https://api.github.com/users/saeedbashir/orgs","repos_url":"https://api.github.com/users/saeedbashir/repos","events_url":"https://api.github.com/users/saeedbashir/events{/privacy}","received_events_url":"https://api.github.com/users/saeedbashir/received_events","type":"User","site_admin":false},"body":"It can be removed because its unused.","created_at":"2018-04-06T10:44:28Z","updated_at":"2018-04-06T10:48:52Z","html_url":"https://github.com/edx/edx-app-ios/pull/1093#discussion_r179721531","pull_request_url":"https://api.github.com/repos/edx/edx-app-ios/pulls/1093","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-app-ios/pulls/comments/179721531"},"html":{"href":"https://github.com/edx/edx-app-ios/pull/1093#discussion_r179721531"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-app-ios/pulls/1093"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-app-ios/pulls/1093","id":178790678,"html_url":"https://github.com/edx/edx-app-ios/pull/1093","diff_url":"https://github.com/edx/edx-app-ios/pull/1093.diff","patch_url":"https://github.com/edx/edx-app-ios/pull/1093.patch","issue_url":"https://api.github.com/repos/edx/edx-app-ios/issues/1093","number":1093,"state":"open","locked":false,"title":"iOS - Deprecate MPMoviePlayerController for iPhoneX support and add new AVPlayer","user":{"login":"salman2013","id":4454296,"avatar_url":"https://avatars3.githubusercontent.com/u/4454296?v=4","gravatar_id":"","url":"https://api.github.com/users/salman2013","html_url":"https://github.com/salman2013","followers_url":"https://api.github.com/users/salman2013/followers","following_url":"https://api.github.com/users/salman2013/following{/other_user}","gists_url":"https://api.github.com/users/salman2013/gists{/gist_id}","starred_url":"https://api.github.com/users/salman2013/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salman2013/subscriptions","organizations_url":"https://api.github.com/users/salman2013/orgs","repos_url":"https://api.github.com/users/salman2013/repos","events_url":"https://api.github.com/users/salman2013/events{/privacy}","received_events_url":"https://api.github.com/users/salman2013/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\n[LEARNER-4146](https://openedx.atlassian.net/browse/LEARNER-4146)\r\n\r\nDeprecate MPMoviePlayerController for iPhoneX support and add new AVPlayer.","created_at":"2018-04-02T07:41:42Z","updated_at":"2018-04-06T10:48:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31209b187fcd3c023b354fb634d156e82442e9d6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-app-ios/pulls/1093/commits","review_comments_url":"https://api.github.com/repos/edx/edx-app-ios/pulls/1093/comments","review_comment_url":"https://api.github.com/repos/edx/edx-app-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-app-ios/issues/1093/comments","statuses_url":"https://api.github.com/repos/edx/edx-app-ios/statuses/2df8bc9dc2c416c20933880ac60e290549ec2ba1","head":{"label":"edx:salman/LEARNER-4146","ref":"salman/LEARNER-4146","sha":"2df8bc9dc2c416c20933880ac60e290549ec2ba1","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":29251733,"name":"edx-app-ios","full_name":"edx/edx-app-ios","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-app-ios","description":"The Open EdX mobile app for iOS!","fork":false,"url":"https://api.github.com/repos/edx/edx-app-ios","forks_url":"https://api.github.com/repos/edx/edx-app-ios/forks","keys_url":"https://api.github.com/repos/edx/edx-app-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-app-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-app-ios/teams","hooks_url":"https://api.github.com/repos/edx/edx-app-ios/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-app-ios/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-app-ios/events","assignees_url":"https://api.github.com/repos/edx/edx-app-ios/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-app-ios/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-app-ios/tags","blobs_url":"https://api.github.com/repos/edx/edx-app-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-app-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-app-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-app-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-app-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-app-ios/languages","stargazers_url":"https://api.github.com/repos/edx/edx-app-ios/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-app-ios/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-app-ios/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-app-ios/subscription","commits_url":"https://api.github.com/repos/edx/edx-app-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-app-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-app-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-app-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-app-ios/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-app-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-app-ios/merges","archive_url":"https://api.github.com/repos/edx/edx-app-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-app-ios/downloads","issues_url":"https://api.github.com/repos/edx/edx-app-ios/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-app-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-app-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-app-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-app-ios/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-app-ios/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-app-ios/deployments","created_at":"2015-01-14T15:49:29Z","updated_at":"2018-04-04T08:52:54Z","pushed_at":"2018-04-05T13:20:25Z","git_url":"git://github.com/edx/edx-app-ios.git","ssh_url":"git@github.com:edx/edx-app-ios.git","clone_url":"https://github.com/edx/edx-app-ios.git","svn_url":"https://github.com/edx/edx-app-ios","homepage":"https://docs.google.com/document/d/15MYZ2LAmahB82P5wkPkQOqjszfou0Qkeae3qz7STxUQ/edit","size":225869,"stargazers_count":117,"watchers_count":117,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":117,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":117,"open_issues":13,"watchers":117,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"f2d81120d8e1ab32a28f1ff4011da4321e29f8cf","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":29251733,"name":"edx-app-ios","full_name":"edx/edx-app-ios","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-app-ios","description":"The Open EdX mobile app for iOS!","fork":false,"url":"https://api.github.com/repos/edx/edx-app-ios","forks_url":"https://api.github.com/repos/edx/edx-app-ios/forks","keys_url":"https://api.github.com/repos/edx/edx-app-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-app-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-app-ios/teams","hooks_url":"https://api.github.com/repos/edx/edx-app-ios/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-app-ios/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-app-ios/events","assignees_url":"https://api.github.com/repos/edx/edx-app-ios/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-app-ios/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-app-ios/tags","blobs_url":"https://api.github.com/repos/edx/edx-app-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-app-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-app-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-app-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-app-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-app-ios/languages","stargazers_url":"https://api.github.com/repos/edx/edx-app-ios/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-app-ios/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-app-ios/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-app-ios/subscription","commits_url":"https://api.github.com/repos/edx/edx-app-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-app-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-app-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-app-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-app-ios/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-app-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-app-ios/merges","archive_url":"https://api.github.com/repos/edx/edx-app-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-app-ios/downloads","issues_url":"https://api.github.com/repos/edx/edx-app-ios/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-app-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-app-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-app-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-app-ios/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-app-ios/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-app-ios/deployments","created_at":"2015-01-14T15:49:29Z","updated_at":"2018-04-04T08:52:54Z","pushed_at":"2018-04-05T13:20:25Z","git_url":"git://github.com/edx/edx-app-ios.git","ssh_url":"git@github.com:edx/edx-app-ios.git","clone_url":"https://github.com/edx/edx-app-ios.git","svn_url":"https://github.com/edx/edx-app-ios","homepage":"https://docs.google.com/document/d/15MYZ2LAmahB82P5wkPkQOqjszfou0Qkeae3qz7STxUQ/edit","size":225869,"stargazers_count":117,"watchers_count":117,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":117,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":117,"open_issues":13,"watchers":117,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-app-ios/pulls/1093"},"html":{"href":"https://github.com/edx/edx-app-ios/pull/1093"},"issue":{"href":"https://api.github.com/repos/edx/edx-app-ios/issues/1093"},"comments":{"href":"https://api.github.com/repos/edx/edx-app-ios/issues/1093/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-app-ios/pulls/1093/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-app-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-app-ios/pulls/1093/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-app-ios/statuses/2df8bc9dc2c416c20933880ac60e290549ec2ba1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"saeedbashir"}}