{"action":"created","comment":{"url":"https://api.github.com/repos/exodev/wiki/pulls/comments/232737214","pull_request_review_id":169767657,"id":232737214,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjczNzIxNA==","diff_hunk":"@@ -194,9 +195,10 @@ public static PageEntity convertPageToPageEntity(Page page, WikiDAO wikiDAO) {\n     return permissionEntities;\n   }\n \n-  public static Attachment convertAttachmentEntityToAttachment(FileService fileService, AttachmentEntity attachmentEntity) throws WikiException {\n+  public static Attachment convertAttachmentEntityToAttachment(FileService fileService, AttachmentEntity attachmentEntity,boolean loadContent) throws WikiException {","path":"wiki-jpa-dao/src/main/java/org/exoplatform/wiki/jpa/EntityConverter.java","position":13,"original_position":13,"commit_id":"64e4da0722adb6607af589b85a9af5849752e599","original_commit_id":"64e4da0722adb6607af589b85a9af5849752e599","user":{"login":"lbengayed","id":35059943,"node_id":"MDQ6VXNlcjM1MDU5OTQz","avatar_url":"https://avatars3.githubusercontent.com/u/35059943?v=4","gravatar_id":"","url":"https://api.github.com/users/lbengayed","html_url":"https://github.com/lbengayed","followers_url":"https://api.github.com/users/lbengayed/followers","following_url":"https://api.github.com/users/lbengayed/following{/other_user}","gists_url":"https://api.github.com/users/lbengayed/gists{/gist_id}","starred_url":"https://api.github.com/users/lbengayed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbengayed/subscriptions","organizations_url":"https://api.github.com/users/lbengayed/orgs","repos_url":"https://api.github.com/users/lbengayed/repos","events_url":"https://api.github.com/users/lbengayed/events{/privacy}","received_events_url":"https://api.github.com/users/lbengayed/received_events","type":"User","site_admin":false},"body":"I think that we should keep this new parameter.\r\nJust with this parameter we decrease the computation, \r\nIf we need the binary we calculate it, if not we recover only fileItem = new FileItem(fileInfo);","created_at":"2018-11-12T16:58:07Z","updated_at":"2018-11-12T16:58:11Z","html_url":"https://github.com/exodev/wiki/pull/181#discussion_r232737214","pull_request_url":"https://api.github.com/repos/exodev/wiki/pulls/181","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/exodev/wiki/pulls/comments/232737214"},"html":{"href":"https://github.com/exodev/wiki/pull/181#discussion_r232737214"},"pull_request":{"href":"https://api.github.com/repos/exodev/wiki/pulls/181"}},"in_reply_to_id":232326762},"pull_request":{"url":"https://api.github.com/repos/exodev/wiki/pulls/181","id":226644823,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NjQ0ODIz","html_url":"https://github.com/exodev/wiki/pull/181","diff_url":"https://github.com/exodev/wiki/pull/181.diff","patch_url":"https://github.com/exodev/wiki/pull/181.patch","issue_url":"https://api.github.com/repos/exodev/wiki/issues/181","number":181,"state":"open","locked":false,"title":"FIX/PLF-8174:Out of memory in heap space encoutered by Wiki Page","user":{"login":"lbengayed","id":35059943,"node_id":"MDQ6VXNlcjM1MDU5OTQz","avatar_url":"https://avatars3.githubusercontent.com/u/35059943?v=4","gravatar_id":"","url":"https://api.github.com/users/lbengayed","html_url":"https://github.com/lbengayed","followers_url":"https://api.github.com/users/lbengayed/followers","following_url":"https://api.github.com/users/lbengayed/following{/other_user}","gists_url":"https://api.github.com/users/lbengayed/gists{/gist_id}","starred_url":"https://api.github.com/users/lbengayed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbengayed/subscriptions","organizations_url":"https://api.github.com/users/lbengayed/orgs","repos_url":"https://api.github.com/users/lbengayed/repos","events_url":"https://api.github.com/users/lbengayed/events{/privacy}","received_events_url":"https://api.github.com/users/lbengayed/received_events","type":"User","site_admin":false},"body":"I note that we lose memory each time to calculate the CHECkSUM and data, or we need it only on create update and upload a file.\r\nSo i proposed a PR that the checksum and data are calculated only when we really need it.(uploading creating and updating file)\r\n","created_at":"2018-10-29T17:17:22Z","updated_at":"2018-11-12T16:58:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca2c6a0c66d38af339f18d862f5344b7cd5d2c5d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/exodev/wiki/pulls/181/commits","review_comments_url":"https://api.github.com/repos/exodev/wiki/pulls/181/comments","review_comment_url":"https://api.github.com/repos/exodev/wiki/pulls/comments{/number}","comments_url":"https://api.github.com/repos/exodev/wiki/issues/181/comments","statuses_url":"https://api.github.com/repos/exodev/wiki/statuses/64e4da0722adb6607af589b85a9af5849752e599","head":{"label":"exodev:FIX/PLF-8174","ref":"FIX/PLF-8174","sha":"64e4da0722adb6607af589b85a9af5849752e599","user":{"login":"exodev","id":1606522,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDY1MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1606522?v=4","gravatar_id":"","url":"https://api.github.com/users/exodev","html_url":"https://github.com/exodev","followers_url":"https://api.github.com/users/exodev/followers","following_url":"https://api.github.com/users/exodev/following{/other_user}","gists_url":"https://api.github.com/users/exodev/gists{/gist_id}","starred_url":"https://api.github.com/users/exodev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exodev/subscriptions","organizations_url":"https://api.github.com/users/exodev/orgs","repos_url":"https://api.github.com/users/exodev/repos","events_url":"https://api.github.com/users/exodev/events{/privacy}","received_events_url":"https://api.github.com/users/exodev/received_events","type":"Organization","site_admin":false},"repo":{"id":4126238,"node_id":"MDEwOlJlcG9zaXRvcnk0MTI2MjM4","name":"wiki","full_name":"exodev/wiki","private":false,"owner":{"login":"exodev","id":1606522,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDY1MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1606522?v=4","gravatar_id":"","url":"https://api.github.com/users/exodev","html_url":"https://github.com/exodev","followers_url":"https://api.github.com/users/exodev/followers","following_url":"https://api.github.com/users/exodev/following{/other_user}","gists_url":"https://api.github.com/users/exodev/gists{/gist_id}","starred_url":"https://api.github.com/users/exodev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exodev/subscriptions","organizations_url":"https://api.github.com/users/exodev/orgs","repos_url":"https://api.github.com/users/exodev/repos","events_url":"https://api.github.com/users/exodev/events{/privacy}","received_events_url":"https://api.github.com/users/exodev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/exodev/wiki","description":"eXo Wiki","fork":true,"url":"https://api.github.com/repos/exodev/wiki","forks_url":"https://api.github.com/repos/exodev/wiki/forks","keys_url":"https://api.github.com/repos/exodev/wiki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exodev/wiki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exodev/wiki/teams","hooks_url":"https://api.github.com/repos/exodev/wiki/hooks","issue_events_url":"https://api.github.com/repos/exodev/wiki/issues/events{/number}","events_url":"https://api.github.com/repos/exodev/wiki/events","assignees_url":"https://api.github.com/repos/exodev/wiki/assignees{/user}","branches_url":"https://api.github.com/repos/exodev/wiki/branches{/branch}","tags_url":"https://api.github.com/repos/exodev/wiki/tags","blobs_url":"https://api.github.com/repos/exodev/wiki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exodev/wiki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exodev/wiki/git/refs{/sha}","trees_url":"https://api.github.com/repos/exodev/wiki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exodev/wiki/statuses/{sha}","languages_url":"https://api.github.com/repos/exodev/wiki/languages","stargazers_url":"https://api.github.com/repos/exodev/wiki/stargazers","contributors_url":"https://api.github.com/repos/exodev/wiki/contributors","subscribers_url":"https://api.github.com/repos/exodev/wiki/subscribers","subscription_url":"https://api.github.com/repos/exodev/wiki/subscription","commits_url":"https://api.github.com/repos/exodev/wiki/commits{/sha}","git_commits_url":"https://api.github.com/repos/exodev/wiki/git/commits{/sha}","comments_url":"https://api.github.com/repos/exodev/wiki/comments{/number}","issue_comment_url":"https://api.github.com/repos/exodev/wiki/issues/comments{/number}","contents_url":"https://api.github.com/repos/exodev/wiki/contents/{+path}","compare_url":"https://api.github.com/repos/exodev/wiki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exodev/wiki/merges","archive_url":"https://api.github.com/repos/exodev/wiki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exodev/wiki/downloads","issues_url":"https://api.github.com/repos/exodev/wiki/issues{/number}","pulls_url":"https://api.github.com/repos/exodev/wiki/pulls{/number}","milestones_url":"https://api.github.com/repos/exodev/wiki/milestones{/number}","notifications_url":"https://api.github.com/repos/exodev/wiki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exodev/wiki/labels{/name}","releases_url":"https://api.github.com/repos/exodev/wiki/releases{/id}","deployments_url":"https://api.github.com/repos/exodev/wiki/deployments","created_at":"2012-04-24T15:28:02Z","updated_at":"2018-10-31T16:58:49Z","pushed_at":"2018-11-11T18:59:08Z","git_url":"git://github.com/exodev/wiki.git","ssh_url":"git@github.com:exodev/wiki.git","clone_url":"https://github.com/exodev/wiki.git","svn_url":"https://github.com/exodev/wiki","homepage":"","size":52419,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":5,"open_issues":17,"watchers":1,"default_branch":"develop"}},"base":{"label":"exodev:develop","ref":"develop","sha":"5ccdcbb2cf400e6018bd859be12cb7d4e51cbace","user":{"login":"exodev","id":1606522,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDY1MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1606522?v=4","gravatar_id":"","url":"https://api.github.com/users/exodev","html_url":"https://github.com/exodev","followers_url":"https://api.github.com/users/exodev/followers","following_url":"https://api.github.com/users/exodev/following{/other_user}","gists_url":"https://api.github.com/users/exodev/gists{/gist_id}","starred_url":"https://api.github.com/users/exodev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exodev/subscriptions","organizations_url":"https://api.github.com/users/exodev/orgs","repos_url":"https://api.github.com/users/exodev/repos","events_url":"https://api.github.com/users/exodev/events{/privacy}","received_events_url":"https://api.github.com/users/exodev/received_events","type":"Organization","site_admin":false},"repo":{"id":4126238,"node_id":"MDEwOlJlcG9zaXRvcnk0MTI2MjM4","name":"wiki","full_name":"exodev/wiki","private":false,"owner":{"login":"exodev","id":1606522,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDY1MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1606522?v=4","gravatar_id":"","url":"https://api.github.com/users/exodev","html_url":"https://github.com/exodev","followers_url":"https://api.github.com/users/exodev/followers","following_url":"https://api.github.com/users/exodev/following{/other_user}","gists_url":"https://api.github.com/users/exodev/gists{/gist_id}","starred_url":"https://api.github.com/users/exodev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exodev/subscriptions","organizations_url":"https://api.github.com/users/exodev/orgs","repos_url":"https://api.github.com/users/exodev/repos","events_url":"https://api.github.com/users/exodev/events{/privacy}","received_events_url":"https://api.github.com/users/exodev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/exodev/wiki","description":"eXo Wiki","fork":true,"url":"https://api.github.com/repos/exodev/wiki","forks_url":"https://api.github.com/repos/exodev/wiki/forks","keys_url":"https://api.github.com/repos/exodev/wiki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exodev/wiki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exodev/wiki/teams","hooks_url":"https://api.github.com/repos/exodev/wiki/hooks","issue_events_url":"https://api.github.com/repos/exodev/wiki/issues/events{/number}","events_url":"https://api.github.com/repos/exodev/wiki/events","assignees_url":"https://api.github.com/repos/exodev/wiki/assignees{/user}","branches_url":"https://api.github.com/repos/exodev/wiki/branches{/branch}","tags_url":"https://api.github.com/repos/exodev/wiki/tags","blobs_url":"https://api.github.com/repos/exodev/wiki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exodev/wiki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exodev/wiki/git/refs{/sha}","trees_url":"https://api.github.com/repos/exodev/wiki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exodev/wiki/statuses/{sha}","languages_url":"https://api.github.com/repos/exodev/wiki/languages","stargazers_url":"https://api.github.com/repos/exodev/wiki/stargazers","contributors_url":"https://api.github.com/repos/exodev/wiki/contributors","subscribers_url":"https://api.github.com/repos/exodev/wiki/subscribers","subscription_url":"https://api.github.com/repos/exodev/wiki/subscription","commits_url":"https://api.github.com/repos/exodev/wiki/commits{/sha}","git_commits_url":"https://api.github.com/repos/exodev/wiki/git/commits{/sha}","comments_url":"https://api.github.com/repos/exodev/wiki/comments{/number}","issue_comment_url":"https://api.github.com/repos/exodev/wiki/issues/comments{/number}","contents_url":"https://api.github.com/repos/exodev/wiki/contents/{+path}","compare_url":"https://api.github.com/repos/exodev/wiki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exodev/wiki/merges","archive_url":"https://api.github.com/repos/exodev/wiki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exodev/wiki/downloads","issues_url":"https://api.github.com/repos/exodev/wiki/issues{/number}","pulls_url":"https://api.github.com/repos/exodev/wiki/pulls{/number}","milestones_url":"https://api.github.com/repos/exodev/wiki/milestones{/number}","notifications_url":"https://api.github.com/repos/exodev/wiki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exodev/wiki/labels{/name}","releases_url":"https://api.github.com/repos/exodev/wiki/releases{/id}","deployments_url":"https://api.github.com/repos/exodev/wiki/deployments","created_at":"2012-04-24T15:28:02Z","updated_at":"2018-10-31T16:58:49Z","pushed_at":"2018-11-11T18:59:08Z","git_url":"git://github.com/exodev/wiki.git","ssh_url":"git@github.com:exodev/wiki.git","clone_url":"https://github.com/exodev/wiki.git","svn_url":"https://github.com/exodev/wiki","homepage":"","size":52419,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":5,"open_issues":17,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/exodev/wiki/pulls/181"},"html":{"href":"https://github.com/exodev/wiki/pull/181"},"issue":{"href":"https://api.github.com/repos/exodev/wiki/issues/181"},"comments":{"href":"https://api.github.com/repos/exodev/wiki/issues/181/comments"},"review_comments":{"href":"https://api.github.com/repos/exodev/wiki/pulls/181/comments"},"review_comment":{"href":"https://api.github.com/repos/exodev/wiki/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/exodev/wiki/pulls/181/commits"},"statuses":{"href":"https://api.github.com/repos/exodev/wiki/statuses/64e4da0722adb6607af589b85a9af5849752e599"}},"author_association":"NONE"}}
{"actor":{"display_login":"lbengayed"}}