{"action":"created","comment":{"url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/comments/213337944","pull_request_review_id":150152326,"id":213337944,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzMzNzk0NA==","diff_hunk":"@@ -799,32 +796,30 @@ export default class JingleSessionPC extends JingleSession {\n             for (const localTrack of localTracks) {\n                 this.peerconnection.addTrack(localTrack);\n             }\n-            this.peerconnection.createOffer(\n-                offerSdp => {\n-                    this.peerconnection.setLocalDescription(\n-                        offerSdp,\n-                        () => {\n+            this.peerconnection.createOffer(this.mediaConstraints)\n+                .then(offerSdp => {","path":"modules/xmpp/JingleSessionPC.js","position":26,"original_position":26,"commit_id":"0167cee25fc45291448e170d5eccbe5bc03ff217","original_commit_id":"6ef787e2871a403b6b1bcf60de99d1cf83518369","user":{"login":"paweldomas","id":2965063,"node_id":"MDQ6VXNlcjI5NjUwNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/2965063?v=4","gravatar_id":"","url":"https://api.github.com/users/paweldomas","html_url":"https://github.com/paweldomas","followers_url":"https://api.github.com/users/paweldomas/followers","following_url":"https://api.github.com/users/paweldomas/following{/other_user}","gists_url":"https://api.github.com/users/paweldomas/gists{/gist_id}","starred_url":"https://api.github.com/users/paweldomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paweldomas/subscriptions","organizations_url":"https://api.github.com/users/paweldomas/orgs","repos_url":"https://api.github.com/users/paweldomas/repos","events_url":"https://api.github.com/users/paweldomas/events{/privacy}","received_events_url":"https://api.github.com/users/paweldomas/received_events","type":"User","site_admin":false},"body":"can we keep the existing then(success, failure) behaviour here ?","created_at":"2018-08-28T14:30:47Z","updated_at":"2018-08-28T14:30:47Z","html_url":"https://github.com/jitsi/lib-jitsi-meet/pull/803#discussion_r213337944","pull_request_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/803","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/comments/213337944"},"html":{"href":"https://github.com/jitsi/lib-jitsi-meet/pull/803#discussion_r213337944"},"pull_request":{"href":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/803"}}},"pull_request":{"url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/803","id":210117993,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMTE3OTkz","html_url":"https://github.com/jitsi/lib-jitsi-meet/pull/803","diff_url":"https://github.com/jitsi/lib-jitsi-meet/pull/803.diff","patch_url":"https://github.com/jitsi/lib-jitsi-meet/pull/803.patch","issue_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/issues/803","number":803,"state":"open","locked":false,"title":"Promises","user":{"login":"saghul","id":317464,"node_id":"MDQ6VXNlcjMxNzQ2NA==","avatar_url":"https://avatars0.githubusercontent.com/u/317464?v=4","gravatar_id":"","url":"https://api.github.com/users/saghul","html_url":"https://github.com/saghul","followers_url":"https://api.github.com/users/saghul/followers","following_url":"https://api.github.com/users/saghul/following{/other_user}","gists_url":"https://api.github.com/users/saghul/gists{/gist_id}","starred_url":"https://api.github.com/users/saghul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saghul/subscriptions","organizations_url":"https://api.github.com/users/saghul/orgs","repos_url":"https://api.github.com/users/saghul/repos","events_url":"https://api.github.com/users/saghul/events{/privacy}","received_events_url":"https://api.github.com/users/saghul/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-22T12:31:51Z","updated_at":"2018-08-28T14:30:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7db3c3b356f63d13770b8b146a7eaac166f7fdeb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/803/commits","review_comments_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/803/comments","review_comment_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/issues/803/comments","statuses_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/statuses/0167cee25fc45291448e170d5eccbe5bc03ff217","head":{"label":"saghul:promises","ref":"promises","sha":"0167cee25fc45291448e170d5eccbe5bc03ff217","user":{"login":"saghul","id":317464,"node_id":"MDQ6VXNlcjMxNzQ2NA==","avatar_url":"https://avatars0.githubusercontent.com/u/317464?v=4","gravatar_id":"","url":"https://api.github.com/users/saghul","html_url":"https://github.com/saghul","followers_url":"https://api.github.com/users/saghul/followers","following_url":"https://api.github.com/users/saghul/following{/other_user}","gists_url":"https://api.github.com/users/saghul/gists{/gist_id}","starred_url":"https://api.github.com/users/saghul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saghul/subscriptions","organizations_url":"https://api.github.com/users/saghul/orgs","repos_url":"https://api.github.com/users/saghul/repos","events_url":"https://api.github.com/users/saghul/events{/privacy}","received_events_url":"https://api.github.com/users/saghul/received_events","type":"User","site_admin":false},"repo":{"id":79503764,"node_id":"MDEwOlJlcG9zaXRvcnk3OTUwMzc2NA==","name":"lib-jitsi-meet","full_name":"saghul/lib-jitsi-meet","owner":{"login":"saghul","id":317464,"node_id":"MDQ6VXNlcjMxNzQ2NA==","avatar_url":"https://avatars0.githubusercontent.com/u/317464?v=4","gravatar_id":"","url":"https://api.github.com/users/saghul","html_url":"https://github.com/saghul","followers_url":"https://api.github.com/users/saghul/followers","following_url":"https://api.github.com/users/saghul/following{/other_user}","gists_url":"https://api.github.com/users/saghul/gists{/gist_id}","starred_url":"https://api.github.com/users/saghul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saghul/subscriptions","organizations_url":"https://api.github.com/users/saghul/orgs","repos_url":"https://api.github.com/users/saghul/repos","events_url":"https://api.github.com/users/saghul/events{/privacy}","received_events_url":"https://api.github.com/users/saghul/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/saghul/lib-jitsi-meet","description":null,"fork":true,"url":"https://api.github.com/repos/saghul/lib-jitsi-meet","forks_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/forks","keys_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/teams","hooks_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/hooks","issue_events_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/issues/events{/number}","events_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/events","assignees_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/assignees{/user}","branches_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/branches{/branch}","tags_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/tags","blobs_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/git/refs{/sha}","trees_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/statuses/{sha}","languages_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/languages","stargazers_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/stargazers","contributors_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/contributors","subscribers_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/subscribers","subscription_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/subscription","commits_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/commits{/sha}","git_commits_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/git/commits{/sha}","comments_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/comments{/number}","issue_comment_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/issues/comments{/number}","contents_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/contents/{+path}","compare_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/merges","archive_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/downloads","issues_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/issues{/number}","pulls_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/pulls{/number}","milestones_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/milestones{/number}","notifications_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/labels{/name}","releases_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/releases{/id}","deployments_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/deployments","created_at":"2017-01-19T22:58:50Z","updated_at":"2017-01-19T22:58:54Z","pushed_at":"2018-08-28T10:13:18Z","git_url":"git://github.com/saghul/lib-jitsi-meet.git","ssh_url":"git@github.com:saghul/lib-jitsi-meet.git","clone_url":"https://github.com/saghul/lib-jitsi-meet.git","svn_url":"https://github.com/saghul/lib-jitsi-meet","homepage":null,"size":7496,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jitsi:master","ref":"master","sha":"3e0ed6c7b1dff39d430b51021b69f6f241160190","user":{"login":"jitsi","id":3671647,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NzE2NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/3671647?v=4","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"repo":{"id":50543360,"node_id":"MDEwOlJlcG9zaXRvcnk1MDU0MzM2MA==","name":"lib-jitsi-meet","full_name":"jitsi/lib-jitsi-meet","owner":{"login":"jitsi","id":3671647,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NzE2NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/3671647?v=4","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jitsi/lib-jitsi-meet","description":"A low-level JS video API that allows adding a completely custom video experience to web apps.","fork":false,"url":"https://api.github.com/repos/jitsi/lib-jitsi-meet","forks_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/forks","keys_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/teams","hooks_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/hooks","issue_events_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/issues/events{/number}","events_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/events","assignees_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/assignees{/user}","branches_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/branches{/branch}","tags_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/tags","blobs_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/git/refs{/sha}","trees_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/statuses/{sha}","languages_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/languages","stargazers_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/stargazers","contributors_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/contributors","subscribers_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/subscribers","subscription_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/subscription","commits_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/commits{/sha}","git_commits_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/git/commits{/sha}","comments_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/comments{/number}","issue_comment_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/issues/comments{/number}","contents_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/contents/{+path}","compare_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/merges","archive_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/downloads","issues_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/issues{/number}","pulls_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls{/number}","milestones_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/milestones{/number}","notifications_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/labels{/name}","releases_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/releases{/id}","deployments_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/deployments","created_at":"2016-01-27T22:44:09Z","updated_at":"2018-08-17T15:59:06Z","pushed_at":"2018-08-28T10:13:20Z","git_url":"git://github.com/jitsi/lib-jitsi-meet.git","ssh_url":"git@github.com:jitsi/lib-jitsi-meet.git","clone_url":"https://github.com/jitsi/lib-jitsi-meet.git","svn_url":"https://github.com/jitsi/lib-jitsi-meet","homepage":"","size":7575,"stargazers_count":126,"watchers_count":126,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":157,"mirror_url":null,"archived":false,"open_issues_count":39,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":157,"open_issues":39,"watchers":126,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/803"},"html":{"href":"https://github.com/jitsi/lib-jitsi-meet/pull/803"},"issue":{"href":"https://api.github.com/repos/jitsi/lib-jitsi-meet/issues/803"},"comments":{"href":"https://api.github.com/repos/jitsi/lib-jitsi-meet/issues/803/comments"},"review_comments":{"href":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/803/comments"},"review_comment":{"href":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/803/commits"},"statuses":{"href":"https://api.github.com/repos/jitsi/lib-jitsi-meet/statuses/0167cee25fc45291448e170d5eccbe5bc03ff217"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"paweldomas"}}