{"action":"opened","issue":{"url":"https://api.github.com/repos/jenkins-x/draft-packs/issues/69","repository_url":"https://api.github.com/repos/jenkins-x/draft-packs","labels_url":"https://api.github.com/repos/jenkins-x/draft-packs/issues/69/labels{/name}","comments_url":"https://api.github.com/repos/jenkins-x/draft-packs/issues/69/comments","events_url":"https://api.github.com/repos/jenkins-x/draft-packs/issues/69/events","html_url":"https://github.com/jenkins-x/draft-packs/issues/69","id":356092151,"node_id":"MDU6SXNzdWUzNTYwOTIxNTE=","number":69,"title":"Liberty pack doesn't work with provided quick start","user":{"login":"davidcurrie","id":5929680,"node_id":"MDQ6VXNlcjU5Mjk2ODA=","avatar_url":"https://avatars1.githubusercontent.com/u/5929680?v=4","gravatar_id":"","url":"https://api.github.com/users/davidcurrie","html_url":"https://github.com/davidcurrie","followers_url":"https://api.github.com/users/davidcurrie/followers","following_url":"https://api.github.com/users/davidcurrie/following{/other_user}","gists_url":"https://api.github.com/users/davidcurrie/gists{/gist_id}","starred_url":"https://api.github.com/users/davidcurrie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidcurrie/subscriptions","organizations_url":"https://api.github.com/users/davidcurrie/orgs","repos_url":"https://api.github.com/users/davidcurrie/repos","events_url":"https://api.github.com/users/davidcurrie/events{/privacy}","received_events_url":"https://api.github.com/users/davidcurrie/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-31T19:02:57Z","updated_at":"2018-08-31T19:02:57Z","closed_at":null,"author_association":"NONE","body":"The `liberty` pack doesn't work with the provided [Open Liberty quick start](https://github.com/jenkins-x-quickstarts/open-liberty). The getting started app used for the quick start uses features that aren't in the default `server.xml` provided in the `open-liberty/openliberty:javaee7` image. Also, the `probePath` specified in the `values.yaml` for the chart isn't going to work as the sample application uses MicroProfile health which uses `/health`.\r\n\r\nI'm going to seek opinions on the Open Liberty mailing list as to the right answer for the first part. Ideally you'd be copying the `server.xml` in along with the app but that also means switching from using `dropins` to `apps` where you'll run in to trouble with the versioned naming of the WAR file. I suspect in the end changes will be needed both here and in the quick start.\r\n\r\nFor the probe you just need to decide whether you think Spring or MicroProfile is the more likely scenario."}}
{"actor":{"display_login":"davidcurrie"}}