{"action":"closed","number":201,"pull_request":{"url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/pulls/201","id":241654285,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNjU0Mjg1","html_url":"https://github.com/Block-Equity/stellar-ios-wallet/pull/201","diff_url":"https://github.com/Block-Equity/stellar-ios-wallet/pull/201.diff","patch_url":"https://github.com/Block-Equity/stellar-ios-wallet/pull/201.patch","issue_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/issues/201","number":201,"state":"closed","locked":false,"title":"[FEATURE] Asset coordinator","user":{"login":"ndizazzo","id":728690,"node_id":"MDQ6VXNlcjcyODY5MA==","avatar_url":"https://avatars3.githubusercontent.com/u/728690?v=4","gravatar_id":"","url":"https://api.github.com/users/ndizazzo","html_url":"https://github.com/ndizazzo","followers_url":"https://api.github.com/users/ndizazzo/followers","following_url":"https://api.github.com/users/ndizazzo/following{/other_user}","gists_url":"https://api.github.com/users/ndizazzo/gists{/gist_id}","starred_url":"https://api.github.com/users/ndizazzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndizazzo/subscriptions","organizations_url":"https://api.github.com/users/ndizazzo/orgs","repos_url":"https://api.github.com/users/ndizazzo/repos","events_url":"https://api.github.com/users/ndizazzo/events{/privacy}","received_events_url":"https://api.github.com/users/ndizazzo/received_events","type":"User","site_admin":false},"body":"## Priority\r\nHigh\r\n\r\n## Description\r\nThis PR integrates the `AssetCoordinator` into the `ApplicationCoordinator`. It removes all of the old shared `WalletSwitchingViewController` code and replaces it with the appropriate alternative.\r\n\r\nIt also removes the redundant conformance to all the `WalletSwitchingViewController` code in `TradingCoordinator` too. This is nice because we don't need separate implementations for all of that asset management code.\r\n\r\n## Screenshot\r\n<img width=\"545\" alt=\"screen shot 2019-01-02 at 9 02 00 pm\" src=\"https://user-images.githubusercontent.com/728690/50621100-bd655800-0ed1-11e9-9df8-3e3b359f9ef9.png\">\r\n<img width=\"545\" alt=\"screen shot 2019-01-02 at 9 02 03 pm\" src=\"https://user-images.githubusercontent.com/728690/50621101-bd655800-0ed1-11e9-9c6e-f030ce3d3fc6.png\">\r\n<img width=\"545\" alt=\"screen shot 2019-01-02 at 9 02 09 pm\" src=\"https://user-images.githubusercontent.com/728690/50621102-bd655800-0ed1-11e9-9652-76908d779dac.png\">\r\n<img width=\"545\" alt=\"screen shot 2019-01-02 at 9 02 18 pm\" src=\"https://user-images.githubusercontent.com/728690/50621103-bdfdee80-0ed1-11e9-9fb6-1fcccb93e710.png\">\r\n\r\n\r\n## Notes\r\n* Removing redundant code in TradingCoordinator and ApplicationCoordinator","created_at":"2019-01-01T22:37:33Z","updated_at":"2019-01-04T20:46:25Z","closed_at":"2019-01-04T20:46:25Z","merged_at":"2019-01-04T20:46:25Z","merge_commit_sha":"870df24e716ae8bfc8ce74361c8e725e625e1227","assignee":{"login":"ndizazzo","id":728690,"node_id":"MDQ6VXNlcjcyODY5MA==","avatar_url":"https://avatars3.githubusercontent.com/u/728690?v=4","gravatar_id":"","url":"https://api.github.com/users/ndizazzo","html_url":"https://github.com/ndizazzo","followers_url":"https://api.github.com/users/ndizazzo/followers","following_url":"https://api.github.com/users/ndizazzo/following{/other_user}","gists_url":"https://api.github.com/users/ndizazzo/gists{/gist_id}","starred_url":"https://api.github.com/users/ndizazzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndizazzo/subscriptions","organizations_url":"https://api.github.com/users/ndizazzo/orgs","repos_url":"https://api.github.com/users/ndizazzo/repos","events_url":"https://api.github.com/users/ndizazzo/events{/privacy}","received_events_url":"https://api.github.com/users/ndizazzo/received_events","type":"User","site_admin":false},"assignees":[{"login":"ndizazzo","id":728690,"node_id":"MDQ6VXNlcjcyODY5MA==","avatar_url":"https://avatars3.githubusercontent.com/u/728690?v=4","gravatar_id":"","url":"https://api.github.com/users/ndizazzo","html_url":"https://github.com/ndizazzo","followers_url":"https://api.github.com/users/ndizazzo/followers","following_url":"https://api.github.com/users/ndizazzo/following{/other_user}","gists_url":"https://api.github.com/users/ndizazzo/gists{/gist_id}","starred_url":"https://api.github.com/users/ndizazzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndizazzo/subscriptions","organizations_url":"https://api.github.com/users/ndizazzo/orgs","repos_url":"https://api.github.com/users/ndizazzo/repos","events_url":"https://api.github.com/users/ndizazzo/events{/privacy}","received_events_url":"https://api.github.com/users/ndizazzo/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/pulls/201/commits","review_comments_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/pulls/201/comments","review_comment_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/issues/201/comments","statuses_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/statuses/615a609503ff507cc76809f20709685064671976","head":{"label":"Block-Equity:feature/asset-coordinator","ref":"feature/asset-coordinator","sha":"615a609503ff507cc76809f20709685064671976","user":{"login":"Block-Equity","id":36420670,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NDIwNjcw","avatar_url":"https://avatars1.githubusercontent.com/u/36420670?v=4","gravatar_id":"","url":"https://api.github.com/users/Block-Equity","html_url":"https://github.com/Block-Equity","followers_url":"https://api.github.com/users/Block-Equity/followers","following_url":"https://api.github.com/users/Block-Equity/following{/other_user}","gists_url":"https://api.github.com/users/Block-Equity/gists{/gist_id}","starred_url":"https://api.github.com/users/Block-Equity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Block-Equity/subscriptions","organizations_url":"https://api.github.com/users/Block-Equity/orgs","repos_url":"https://api.github.com/users/Block-Equity/repos","events_url":"https://api.github.com/users/Block-Equity/events{/privacy}","received_events_url":"https://api.github.com/users/Block-Equity/received_events","type":"Organization","site_admin":false},"repo":{"id":125148307,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUxNDgzMDc=","name":"stellar-ios-wallet","full_name":"Block-Equity/stellar-ios-wallet","private":false,"owner":{"login":"Block-Equity","id":36420670,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NDIwNjcw","avatar_url":"https://avatars1.githubusercontent.com/u/36420670?v=4","gravatar_id":"","url":"https://api.github.com/users/Block-Equity","html_url":"https://github.com/Block-Equity","followers_url":"https://api.github.com/users/Block-Equity/followers","following_url":"https://api.github.com/users/Block-Equity/following{/other_user}","gists_url":"https://api.github.com/users/Block-Equity/gists{/gist_id}","starred_url":"https://api.github.com/users/Block-Equity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Block-Equity/subscriptions","organizations_url":"https://api.github.com/users/Block-Equity/orgs","repos_url":"https://api.github.com/users/Block-Equity/repos","events_url":"https://api.github.com/users/Block-Equity/events{/privacy}","received_events_url":"https://api.github.com/users/Block-Equity/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Block-Equity/stellar-ios-wallet","description":"An open source iOS wallet for Stellar.","fork":false,"url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet","forks_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/forks","keys_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/teams","hooks_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/hooks","issue_events_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/issues/events{/number}","events_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/events","assignees_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/assignees{/user}","branches_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/branches{/branch}","tags_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/tags","blobs_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/statuses/{sha}","languages_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/languages","stargazers_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/stargazers","contributors_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/contributors","subscribers_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/subscribers","subscription_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/subscription","commits_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/issues/comments{/number}","contents_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/contents/{+path}","compare_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/merges","archive_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/downloads","issues_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/issues{/number}","pulls_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/pulls{/number}","milestones_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/milestones{/number}","notifications_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/labels{/name}","releases_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/releases{/id}","deployments_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/deployments","created_at":"2018-03-14T03:13:24Z","updated_at":"2019-01-01T19:11:07Z","pushed_at":"2019-01-04T20:46:25Z","git_url":"git://github.com/Block-Equity/stellar-ios-wallet.git","ssh_url":"git@github.com:Block-Equity/stellar-ios-wallet.git","clone_url":"https://github.com/Block-Equity/stellar-ios-wallet.git","svn_url":"https://github.com/Block-Equity/stellar-ios-wallet","homepage":"http://www.blockeq.com","size":7347,"stargazers_count":25,"watchers_count":25,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":5,"watchers":25,"default_branch":"develop"}},"base":{"label":"Block-Equity:develop","ref":"develop","sha":"04499d9aead87b2369f8246069c1a002486cbdc4","user":{"login":"Block-Equity","id":36420670,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NDIwNjcw","avatar_url":"https://avatars1.githubusercontent.com/u/36420670?v=4","gravatar_id":"","url":"https://api.github.com/users/Block-Equity","html_url":"https://github.com/Block-Equity","followers_url":"https://api.github.com/users/Block-Equity/followers","following_url":"https://api.github.com/users/Block-Equity/following{/other_user}","gists_url":"https://api.github.com/users/Block-Equity/gists{/gist_id}","starred_url":"https://api.github.com/users/Block-Equity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Block-Equity/subscriptions","organizations_url":"https://api.github.com/users/Block-Equity/orgs","repos_url":"https://api.github.com/users/Block-Equity/repos","events_url":"https://api.github.com/users/Block-Equity/events{/privacy}","received_events_url":"https://api.github.com/users/Block-Equity/received_events","type":"Organization","site_admin":false},"repo":{"id":125148307,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUxNDgzMDc=","name":"stellar-ios-wallet","full_name":"Block-Equity/stellar-ios-wallet","private":false,"owner":{"login":"Block-Equity","id":36420670,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NDIwNjcw","avatar_url":"https://avatars1.githubusercontent.com/u/36420670?v=4","gravatar_id":"","url":"https://api.github.com/users/Block-Equity","html_url":"https://github.com/Block-Equity","followers_url":"https://api.github.com/users/Block-Equity/followers","following_url":"https://api.github.com/users/Block-Equity/following{/other_user}","gists_url":"https://api.github.com/users/Block-Equity/gists{/gist_id}","starred_url":"https://api.github.com/users/Block-Equity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Block-Equity/subscriptions","organizations_url":"https://api.github.com/users/Block-Equity/orgs","repos_url":"https://api.github.com/users/Block-Equity/repos","events_url":"https://api.github.com/users/Block-Equity/events{/privacy}","received_events_url":"https://api.github.com/users/Block-Equity/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Block-Equity/stellar-ios-wallet","description":"An open source iOS wallet for Stellar.","fork":false,"url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet","forks_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/forks","keys_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/teams","hooks_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/hooks","issue_events_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/issues/events{/number}","events_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/events","assignees_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/assignees{/user}","branches_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/branches{/branch}","tags_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/tags","blobs_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/statuses/{sha}","languages_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/languages","stargazers_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/stargazers","contributors_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/contributors","subscribers_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/subscribers","subscription_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/subscription","commits_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/issues/comments{/number}","contents_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/contents/{+path}","compare_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/merges","archive_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/downloads","issues_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/issues{/number}","pulls_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/pulls{/number}","milestones_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/milestones{/number}","notifications_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/labels{/name}","releases_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/releases{/id}","deployments_url":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/deployments","created_at":"2018-03-14T03:13:24Z","updated_at":"2019-01-01T19:11:07Z","pushed_at":"2019-01-04T20:46:25Z","git_url":"git://github.com/Block-Equity/stellar-ios-wallet.git","ssh_url":"git@github.com:Block-Equity/stellar-ios-wallet.git","clone_url":"https://github.com/Block-Equity/stellar-ios-wallet.git","svn_url":"https://github.com/Block-Equity/stellar-ios-wallet","homepage":"http://www.blockeq.com","size":7347,"stargazers_count":25,"watchers_count":25,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":5,"watchers":25,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/pulls/201"},"html":{"href":"https://github.com/Block-Equity/stellar-ios-wallet/pull/201"},"issue":{"href":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/issues/201"},"comments":{"href":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/issues/201/comments"},"review_comments":{"href":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/pulls/201/comments"},"review_comment":{"href":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/pulls/201/commits"},"statuses":{"href":"https://api.github.com/repos/Block-Equity/stellar-ios-wallet/statuses/615a609503ff507cc76809f20709685064671976"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ndizazzo","id":728690,"node_id":"MDQ6VXNlcjcyODY5MA==","avatar_url":"https://avatars3.githubusercontent.com/u/728690?v=4","gravatar_id":"","url":"https://api.github.com/users/ndizazzo","html_url":"https://github.com/ndizazzo","followers_url":"https://api.github.com/users/ndizazzo/followers","following_url":"https://api.github.com/users/ndizazzo/following{/other_user}","gists_url":"https://api.github.com/users/ndizazzo/gists{/gist_id}","starred_url":"https://api.github.com/users/ndizazzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndizazzo/subscriptions","organizations_url":"https://api.github.com/users/ndizazzo/orgs","repos_url":"https://api.github.com/users/ndizazzo/repos","events_url":"https://api.github.com/users/ndizazzo/events{/privacy}","received_events_url":"https://api.github.com/users/ndizazzo/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1188,"deletions":1439,"changed_files":67}}
{"actor":{"display_login":"ndizazzo"}}