{"action":"created","comment":{"url":"https://api.github.com/repos/atomist/sdm-pack-spring/pulls/comments/229017040","pull_request_review_id":169415349,"id":229017040,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTAxNzA0MA==","diff_hunk":"@@ -35,6 +41,24 @@ export async function findDeclaredDependencies(p: Project, glob: string = \"pom.x\n         glob, {});\n }\n \n+/**\n+ * Return plugins under plugins section\n+ */\n+export async function findDeclaredPlugins(p: Project, glob: string = \"pom.xml\"): Promise<Plugins> {\n+    return findDeclaredPluginsWith(p,\n+        \"//project/build/plugins/plugin\",\n+        glob, {});\n+}\n+\n+/**\n+ * Return plugins under plugin management section\n+ */\n+export async function findDeclaredManagedPlugins(p: Project, glob: string = \"pom.xml\"): Promise<Plugins> {","path":"lib/maven/parse/fromPom.ts","position":31,"original_position":31,"commit_id":"9de909b10b7e405d5fec8296187efc900b8afc0c","original_commit_id":"9de909b10b7e405d5fec8296187efc900b8afc0c","user":{"login":"jessitron","id":1149737,"node_id":"MDQ6VXNlcjExNDk3Mzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1149737?v=4","gravatar_id":"","url":"https://api.github.com/users/jessitron","html_url":"https://github.com/jessitron","followers_url":"https://api.github.com/users/jessitron/followers","following_url":"https://api.github.com/users/jessitron/following{/other_user}","gists_url":"https://api.github.com/users/jessitron/gists{/gist_id}","starred_url":"https://api.github.com/users/jessitron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessitron/subscriptions","organizations_url":"https://api.github.com/users/jessitron/orgs","repos_url":"https://api.github.com/users/jessitron/repos","events_url":"https://api.github.com/users/jessitron/events{/privacy}","received_events_url":"https://api.github.com/users/jessitron/received_events","type":"User","site_admin":false},"body":"why does this not return ManagedPlugin","created_at":"2018-10-29T17:08:30Z","updated_at":"2018-10-29T17:36:48Z","html_url":"https://github.com/atomist/sdm-pack-spring/pull/94#discussion_r229017040","pull_request_url":"https://api.github.com/repos/atomist/sdm-pack-spring/pulls/94","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/atomist/sdm-pack-spring/pulls/comments/229017040"},"html":{"href":"https://github.com/atomist/sdm-pack-spring/pull/94#discussion_r229017040"},"pull_request":{"href":"https://api.github.com/repos/atomist/sdm-pack-spring/pulls/94"}}},"pull_request":{"url":"https://api.github.com/repos/atomist/sdm-pack-spring/pulls/94","id":225416217,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NDE2MjE3","html_url":"https://github.com/atomist/sdm-pack-spring/pull/94","diff_url":"https://github.com/atomist/sdm-pack-spring/pull/94.diff","patch_url":"https://github.com/atomist/sdm-pack-spring/pull/94.patch","issue_url":"https://api.github.com/repos/atomist/sdm-pack-spring/issues/94","number":94,"state":"open","locked":false,"title":"Add support for adding plugins in Maven POM through code transform","user":{"login":"lievendoclo","id":218316,"node_id":"MDQ6VXNlcjIxODMxNg==","avatar_url":"https://avatars0.githubusercontent.com/u/218316?v=4","gravatar_id":"","url":"https://api.github.com/users/lievendoclo","html_url":"https://github.com/lievendoclo","followers_url":"https://api.github.com/users/lievendoclo/followers","following_url":"https://api.github.com/users/lievendoclo/following{/other_user}","gists_url":"https://api.github.com/users/lievendoclo/gists{/gist_id}","starred_url":"https://api.github.com/users/lievendoclo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lievendoclo/subscriptions","organizations_url":"https://api.github.com/users/lievendoclo/orgs","repos_url":"https://api.github.com/users/lievendoclo/repos","events_url":"https://api.github.com/users/lievendoclo/events{/privacy}","received_events_url":"https://api.github.com/users/lievendoclo/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-24T14:02:26Z","updated_at":"2018-10-29T17:36:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b5d5a83057966cff6379831028779784006be53","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1031837793,"node_id":"MDU6TGFiZWwxMDMxODM3Nzkz","url":"https://api.github.com/repos/atomist/sdm-pack-spring/labels/auto-merge:on-approve","name":"auto-merge:on-approve","color":"277D7D","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/atomist/sdm-pack-spring/pulls/94/commits","review_comments_url":"https://api.github.com/repos/atomist/sdm-pack-spring/pulls/94/comments","review_comment_url":"https://api.github.com/repos/atomist/sdm-pack-spring/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atomist/sdm-pack-spring/issues/94/comments","statuses_url":"https://api.github.com/repos/atomist/sdm-pack-spring/statuses/9de909b10b7e405d5fec8296187efc900b8afc0c","head":{"label":"atomist:maven-plugin-transform","ref":"maven-plugin-transform","sha":"9de909b10b7e405d5fec8296187efc900b8afc0c","user":{"login":"atomist","id":19392,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5Mzky","avatar_url":"https://avatars3.githubusercontent.com/u/19392?v=4","gravatar_id":"","url":"https://api.github.com/users/atomist","html_url":"https://github.com/atomist","followers_url":"https://api.github.com/users/atomist/followers","following_url":"https://api.github.com/users/atomist/following{/other_user}","gists_url":"https://api.github.com/users/atomist/gists{/gist_id}","starred_url":"https://api.github.com/users/atomist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atomist/subscriptions","organizations_url":"https://api.github.com/users/atomist/orgs","repos_url":"https://api.github.com/users/atomist/repos","events_url":"https://api.github.com/users/atomist/events{/privacy}","received_events_url":"https://api.github.com/users/atomist/received_events","type":"Organization","site_admin":false},"repo":{"id":136957476,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY5NTc0NzY=","name":"sdm-pack-spring","full_name":"atomist/sdm-pack-spring","private":false,"owner":{"login":"atomist","id":19392,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5Mzky","avatar_url":"https://avatars3.githubusercontent.com/u/19392?v=4","gravatar_id":"","url":"https://api.github.com/users/atomist","html_url":"https://github.com/atomist","followers_url":"https://api.github.com/users/atomist/followers","following_url":"https://api.github.com/users/atomist/following{/other_user}","gists_url":"https://api.github.com/users/atomist/gists{/gist_id}","starred_url":"https://api.github.com/users/atomist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atomist/subscriptions","organizations_url":"https://api.github.com/users/atomist/orgs","repos_url":"https://api.github.com/users/atomist/repos","events_url":"https://api.github.com/users/atomist/events{/privacy}","received_events_url":"https://api.github.com/users/atomist/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/atomist/sdm-pack-spring","description":"Extension Pack for an Atomist SDM to automate delivery of Spring and Spring Boot applications","fork":false,"url":"https://api.github.com/repos/atomist/sdm-pack-spring","forks_url":"https://api.github.com/repos/atomist/sdm-pack-spring/forks","keys_url":"https://api.github.com/repos/atomist/sdm-pack-spring/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atomist/sdm-pack-spring/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atomist/sdm-pack-spring/teams","hooks_url":"https://api.github.com/repos/atomist/sdm-pack-spring/hooks","issue_events_url":"https://api.github.com/repos/atomist/sdm-pack-spring/issues/events{/number}","events_url":"https://api.github.com/repos/atomist/sdm-pack-spring/events","assignees_url":"https://api.github.com/repos/atomist/sdm-pack-spring/assignees{/user}","branches_url":"https://api.github.com/repos/atomist/sdm-pack-spring/branches{/branch}","tags_url":"https://api.github.com/repos/atomist/sdm-pack-spring/tags","blobs_url":"https://api.github.com/repos/atomist/sdm-pack-spring/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atomist/sdm-pack-spring/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atomist/sdm-pack-spring/git/refs{/sha}","trees_url":"https://api.github.com/repos/atomist/sdm-pack-spring/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atomist/sdm-pack-spring/statuses/{sha}","languages_url":"https://api.github.com/repos/atomist/sdm-pack-spring/languages","stargazers_url":"https://api.github.com/repos/atomist/sdm-pack-spring/stargazers","contributors_url":"https://api.github.com/repos/atomist/sdm-pack-spring/contributors","subscribers_url":"https://api.github.com/repos/atomist/sdm-pack-spring/subscribers","subscription_url":"https://api.github.com/repos/atomist/sdm-pack-spring/subscription","commits_url":"https://api.github.com/repos/atomist/sdm-pack-spring/commits{/sha}","git_commits_url":"https://api.github.com/repos/atomist/sdm-pack-spring/git/commits{/sha}","comments_url":"https://api.github.com/repos/atomist/sdm-pack-spring/comments{/number}","issue_comment_url":"https://api.github.com/repos/atomist/sdm-pack-spring/issues/comments{/number}","contents_url":"https://api.github.com/repos/atomist/sdm-pack-spring/contents/{+path}","compare_url":"https://api.github.com/repos/atomist/sdm-pack-spring/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atomist/sdm-pack-spring/merges","archive_url":"https://api.github.com/repos/atomist/sdm-pack-spring/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atomist/sdm-pack-spring/downloads","issues_url":"https://api.github.com/repos/atomist/sdm-pack-spring/issues{/number}","pulls_url":"https://api.github.com/repos/atomist/sdm-pack-spring/pulls{/number}","milestones_url":"https://api.github.com/repos/atomist/sdm-pack-spring/milestones{/number}","notifications_url":"https://api.github.com/repos/atomist/sdm-pack-spring/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atomist/sdm-pack-spring/labels{/name}","releases_url":"https://api.github.com/repos/atomist/sdm-pack-spring/releases{/id}","deployments_url":"https://api.github.com/repos/atomist/sdm-pack-spring/deployments","created_at":"2018-06-11T17:13:30Z","updated_at":"2018-10-18T00:33:54Z","pushed_at":"2018-10-29T17:04:53Z","git_url":"git://github.com/atomist/sdm-pack-spring.git","ssh_url":"git@github.com:atomist/sdm-pack-spring.git","clone_url":"https://github.com/atomist/sdm-pack-spring.git","svn_url":"https://github.com/atomist/sdm-pack-spring","homepage":"","size":1760,"stargazers_count":4,"watchers_count":4,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":10,"watchers":4,"default_branch":"master"}},"base":{"label":"atomist:master","ref":"master","sha":"fd9bc4c57c97752a2fb6b46f15f243765499a399","user":{"login":"atomist","id":19392,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5Mzky","avatar_url":"https://avatars3.githubusercontent.com/u/19392?v=4","gravatar_id":"","url":"https://api.github.com/users/atomist","html_url":"https://github.com/atomist","followers_url":"https://api.github.com/users/atomist/followers","following_url":"https://api.github.com/users/atomist/following{/other_user}","gists_url":"https://api.github.com/users/atomist/gists{/gist_id}","starred_url":"https://api.github.com/users/atomist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atomist/subscriptions","organizations_url":"https://api.github.com/users/atomist/orgs","repos_url":"https://api.github.com/users/atomist/repos","events_url":"https://api.github.com/users/atomist/events{/privacy}","received_events_url":"https://api.github.com/users/atomist/received_events","type":"Organization","site_admin":false},"repo":{"id":136957476,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY5NTc0NzY=","name":"sdm-pack-spring","full_name":"atomist/sdm-pack-spring","private":false,"owner":{"login":"atomist","id":19392,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5Mzky","avatar_url":"https://avatars3.githubusercontent.com/u/19392?v=4","gravatar_id":"","url":"https://api.github.com/users/atomist","html_url":"https://github.com/atomist","followers_url":"https://api.github.com/users/atomist/followers","following_url":"https://api.github.com/users/atomist/following{/other_user}","gists_url":"https://api.github.com/users/atomist/gists{/gist_id}","starred_url":"https://api.github.com/users/atomist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atomist/subscriptions","organizations_url":"https://api.github.com/users/atomist/orgs","repos_url":"https://api.github.com/users/atomist/repos","events_url":"https://api.github.com/users/atomist/events{/privacy}","received_events_url":"https://api.github.com/users/atomist/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/atomist/sdm-pack-spring","description":"Extension Pack for an Atomist SDM to automate delivery of Spring and Spring Boot applications","fork":false,"url":"https://api.github.com/repos/atomist/sdm-pack-spring","forks_url":"https://api.github.com/repos/atomist/sdm-pack-spring/forks","keys_url":"https://api.github.com/repos/atomist/sdm-pack-spring/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atomist/sdm-pack-spring/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atomist/sdm-pack-spring/teams","hooks_url":"https://api.github.com/repos/atomist/sdm-pack-spring/hooks","issue_events_url":"https://api.github.com/repos/atomist/sdm-pack-spring/issues/events{/number}","events_url":"https://api.github.com/repos/atomist/sdm-pack-spring/events","assignees_url":"https://api.github.com/repos/atomist/sdm-pack-spring/assignees{/user}","branches_url":"https://api.github.com/repos/atomist/sdm-pack-spring/branches{/branch}","tags_url":"https://api.github.com/repos/atomist/sdm-pack-spring/tags","blobs_url":"https://api.github.com/repos/atomist/sdm-pack-spring/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atomist/sdm-pack-spring/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atomist/sdm-pack-spring/git/refs{/sha}","trees_url":"https://api.github.com/repos/atomist/sdm-pack-spring/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atomist/sdm-pack-spring/statuses/{sha}","languages_url":"https://api.github.com/repos/atomist/sdm-pack-spring/languages","stargazers_url":"https://api.github.com/repos/atomist/sdm-pack-spring/stargazers","contributors_url":"https://api.github.com/repos/atomist/sdm-pack-spring/contributors","subscribers_url":"https://api.github.com/repos/atomist/sdm-pack-spring/subscribers","subscription_url":"https://api.github.com/repos/atomist/sdm-pack-spring/subscription","commits_url":"https://api.github.com/repos/atomist/sdm-pack-spring/commits{/sha}","git_commits_url":"https://api.github.com/repos/atomist/sdm-pack-spring/git/commits{/sha}","comments_url":"https://api.github.com/repos/atomist/sdm-pack-spring/comments{/number}","issue_comment_url":"https://api.github.com/repos/atomist/sdm-pack-spring/issues/comments{/number}","contents_url":"https://api.github.com/repos/atomist/sdm-pack-spring/contents/{+path}","compare_url":"https://api.github.com/repos/atomist/sdm-pack-spring/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atomist/sdm-pack-spring/merges","archive_url":"https://api.github.com/repos/atomist/sdm-pack-spring/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atomist/sdm-pack-spring/downloads","issues_url":"https://api.github.com/repos/atomist/sdm-pack-spring/issues{/number}","pulls_url":"https://api.github.com/repos/atomist/sdm-pack-spring/pulls{/number}","milestones_url":"https://api.github.com/repos/atomist/sdm-pack-spring/milestones{/number}","notifications_url":"https://api.github.com/repos/atomist/sdm-pack-spring/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atomist/sdm-pack-spring/labels{/name}","releases_url":"https://api.github.com/repos/atomist/sdm-pack-spring/releases{/id}","deployments_url":"https://api.github.com/repos/atomist/sdm-pack-spring/deployments","created_at":"2018-06-11T17:13:30Z","updated_at":"2018-10-18T00:33:54Z","pushed_at":"2018-10-29T17:04:53Z","git_url":"git://github.com/atomist/sdm-pack-spring.git","ssh_url":"git@github.com:atomist/sdm-pack-spring.git","clone_url":"https://github.com/atomist/sdm-pack-spring.git","svn_url":"https://github.com/atomist/sdm-pack-spring","homepage":"","size":1760,"stargazers_count":4,"watchers_count":4,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":10,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atomist/sdm-pack-spring/pulls/94"},"html":{"href":"https://github.com/atomist/sdm-pack-spring/pull/94"},"issue":{"href":"https://api.github.com/repos/atomist/sdm-pack-spring/issues/94"},"comments":{"href":"https://api.github.com/repos/atomist/sdm-pack-spring/issues/94/comments"},"review_comments":{"href":"https://api.github.com/repos/atomist/sdm-pack-spring/pulls/94/comments"},"review_comment":{"href":"https://api.github.com/repos/atomist/sdm-pack-spring/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atomist/sdm-pack-spring/pulls/94/commits"},"statuses":{"href":"https://api.github.com/repos/atomist/sdm-pack-spring/statuses/9de909b10b7e405d5fec8296187efc900b8afc0c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jessitron"}}