{"action":"closed","number":23785,"pull_request":{"url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/23785","id":185042084,"html_url":"https://github.com/Microsoft/TypeScript/pull/23785","diff_url":"https://github.com/Microsoft/TypeScript/pull/23785.diff","patch_url":"https://github.com/Microsoft/TypeScript/pull/23785.patch","issue_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/23785","number":23785,"state":"closed","locked":false,"title":"add lib.es2018.intl + fix lib.es2017.intl","user":{"login":"dsifford","id":5240018,"avatar_url":"https://avatars0.githubusercontent.com/u/5240018?v=4","gravatar_id":"","url":"https://api.github.com/users/dsifford","html_url":"https://github.com/dsifford","followers_url":"https://api.github.com/users/dsifford/followers","following_url":"https://api.github.com/users/dsifford/following{/other_user}","gists_url":"https://api.github.com/users/dsifford/gists{/gist_id}","starred_url":"https://api.github.com/users/dsifford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsifford/subscriptions","organizations_url":"https://api.github.com/users/dsifford/orgs","repos_url":"https://api.github.com/users/dsifford/repos","events_url":"https://api.github.com/users/dsifford/events{/privacy}","received_events_url":"https://api.github.com/users/dsifford/received_events","type":"User","site_admin":false},"body":"This PR addresses the two separate issues discuessed in #23691. Namely:\n\n1. There currently existed no type definitions for `Intl.PluralRules`.\n2. The type definitions for `DateTimeFormat` were incorrectly associated with the global namespace, rather than in the `Intl` namespace.\n\nI'd appreciate a code review on this if at all possible. Most of the changes made were based off of #15369, so there is a chance that I may have edited one or two things incorrectly.\n\nOnce the changes are found to be correct, if you could please let me know if/where you'd like tests placed for this, I'll go ahead and add those.\n\nThanks so much!\n\ncc: @mhegazy \n\nFixes #23691","created_at":"2018-04-30T19:26:10Z","updated_at":"2018-04-30T21:45:16Z","closed_at":"2018-04-30T21:45:16Z","merged_at":"2018-04-30T21:45:15Z","merge_commit_sha":"0bbf4d5c489ca3cae205a38009045bdb3d411334","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/23785/commits","review_comments_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/23785/comments","review_comment_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/23785/comments","statuses_url":"https://api.github.com/repos/Microsoft/TypeScript/statuses/1b118a446908df9df3286c0913485728d3021549","head":{"label":"dsifford:dsifford-lib-intl-fix","ref":"dsifford-lib-intl-fix","sha":"1b118a446908df9df3286c0913485728d3021549","user":{"login":"dsifford","id":5240018,"avatar_url":"https://avatars0.githubusercontent.com/u/5240018?v=4","gravatar_id":"","url":"https://api.github.com/users/dsifford","html_url":"https://github.com/dsifford","followers_url":"https://api.github.com/users/dsifford/followers","following_url":"https://api.github.com/users/dsifford/following{/other_user}","gists_url":"https://api.github.com/users/dsifford/gists{/gist_id}","starred_url":"https://api.github.com/users/dsifford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsifford/subscriptions","organizations_url":"https://api.github.com/users/dsifford/orgs","repos_url":"https://api.github.com/users/dsifford/repos","events_url":"https://api.github.com/users/dsifford/events{/privacy}","received_events_url":"https://api.github.com/users/dsifford/received_events","type":"User","site_admin":false},"repo":{"id":101810913,"name":"TypeScript","full_name":"dsifford/TypeScript","owner":{"login":"dsifford","id":5240018,"avatar_url":"https://avatars0.githubusercontent.com/u/5240018?v=4","gravatar_id":"","url":"https://api.github.com/users/dsifford","html_url":"https://github.com/dsifford","followers_url":"https://api.github.com/users/dsifford/followers","following_url":"https://api.github.com/users/dsifford/following{/other_user}","gists_url":"https://api.github.com/users/dsifford/gists{/gist_id}","starred_url":"https://api.github.com/users/dsifford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsifford/subscriptions","organizations_url":"https://api.github.com/users/dsifford/orgs","repos_url":"https://api.github.com/users/dsifford/repos","events_url":"https://api.github.com/users/dsifford/events{/privacy}","received_events_url":"https://api.github.com/users/dsifford/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dsifford/TypeScript","description":"TypeScript is a superset of JavaScript that compiles to clean JavaScript output.","fork":true,"url":"https://api.github.com/repos/dsifford/TypeScript","forks_url":"https://api.github.com/repos/dsifford/TypeScript/forks","keys_url":"https://api.github.com/repos/dsifford/TypeScript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dsifford/TypeScript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dsifford/TypeScript/teams","hooks_url":"https://api.github.com/repos/dsifford/TypeScript/hooks","issue_events_url":"https://api.github.com/repos/dsifford/TypeScript/issues/events{/number}","events_url":"https://api.github.com/repos/dsifford/TypeScript/events","assignees_url":"https://api.github.com/repos/dsifford/TypeScript/assignees{/user}","branches_url":"https://api.github.com/repos/dsifford/TypeScript/branches{/branch}","tags_url":"https://api.github.com/repos/dsifford/TypeScript/tags","blobs_url":"https://api.github.com/repos/dsifford/TypeScript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dsifford/TypeScript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dsifford/TypeScript/git/refs{/sha}","trees_url":"https://api.github.com/repos/dsifford/TypeScript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dsifford/TypeScript/statuses/{sha}","languages_url":"https://api.github.com/repos/dsifford/TypeScript/languages","stargazers_url":"https://api.github.com/repos/dsifford/TypeScript/stargazers","contributors_url":"https://api.github.com/repos/dsifford/TypeScript/contributors","subscribers_url":"https://api.github.com/repos/dsifford/TypeScript/subscribers","subscription_url":"https://api.github.com/repos/dsifford/TypeScript/subscription","commits_url":"https://api.github.com/repos/dsifford/TypeScript/commits{/sha}","git_commits_url":"https://api.github.com/repos/dsifford/TypeScript/git/commits{/sha}","comments_url":"https://api.github.com/repos/dsifford/TypeScript/comments{/number}","issue_comment_url":"https://api.github.com/repos/dsifford/TypeScript/issues/comments{/number}","contents_url":"https://api.github.com/repos/dsifford/TypeScript/contents/{+path}","compare_url":"https://api.github.com/repos/dsifford/TypeScript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dsifford/TypeScript/merges","archive_url":"https://api.github.com/repos/dsifford/TypeScript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dsifford/TypeScript/downloads","issues_url":"https://api.github.com/repos/dsifford/TypeScript/issues{/number}","pulls_url":"https://api.github.com/repos/dsifford/TypeScript/pulls{/number}","milestones_url":"https://api.github.com/repos/dsifford/TypeScript/milestones{/number}","notifications_url":"https://api.github.com/repos/dsifford/TypeScript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dsifford/TypeScript/labels{/name}","releases_url":"https://api.github.com/repos/dsifford/TypeScript/releases{/id}","deployments_url":"https://api.github.com/repos/dsifford/TypeScript/deployments","created_at":"2017-08-29T22:05:45Z","updated_at":"2017-08-29T22:06:34Z","pushed_at":"2018-04-30T20:39:11Z","git_url":"git://github.com/dsifford/TypeScript.git","ssh_url":"git@github.com:dsifford/TypeScript.git","clone_url":"https://github.com/dsifford/TypeScript.git","svn_url":"https://github.com/dsifford/TypeScript","homepage":"http://www.typescriptlang.org","size":603586,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"2c956af927941d33fca22049213280470916e7ed","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":20929025,"name":"TypeScript","full_name":"Microsoft/TypeScript","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/TypeScript","description":"TypeScript is a superset of JavaScript that compiles to clean JavaScript output.","fork":false,"url":"https://api.github.com/repos/Microsoft/TypeScript","forks_url":"https://api.github.com/repos/Microsoft/TypeScript/forks","keys_url":"https://api.github.com/repos/Microsoft/TypeScript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/TypeScript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/TypeScript/teams","hooks_url":"https://api.github.com/repos/Microsoft/TypeScript/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/TypeScript/events","assignees_url":"https://api.github.com/repos/Microsoft/TypeScript/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/TypeScript/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/TypeScript/tags","blobs_url":"https://api.github.com/repos/Microsoft/TypeScript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/TypeScript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/TypeScript/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/TypeScript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/TypeScript/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/TypeScript/languages","stargazers_url":"https://api.github.com/repos/Microsoft/TypeScript/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/TypeScript/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/TypeScript/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/TypeScript/subscription","commits_url":"https://api.github.com/repos/Microsoft/TypeScript/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/TypeScript/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/TypeScript/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/TypeScript/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/TypeScript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/TypeScript/merges","archive_url":"https://api.github.com/repos/Microsoft/TypeScript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/TypeScript/downloads","issues_url":"https://api.github.com/repos/Microsoft/TypeScript/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/TypeScript/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/TypeScript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/TypeScript/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/TypeScript/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/TypeScript/deployments","created_at":"2014-06-17T15:28:39Z","updated_at":"2018-04-30T21:39:18Z","pushed_at":"2018-04-30T21:45:15Z","git_url":"git://github.com/Microsoft/TypeScript.git","ssh_url":"git@github.com:Microsoft/TypeScript.git","clone_url":"https://github.com/Microsoft/TypeScript.git","svn_url":"https://github.com/Microsoft/TypeScript","homepage":"http://www.typescriptlang.org","size":638438,"stargazers_count":33571,"watchers_count":33571,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4877,"mirror_url":null,"archived":false,"open_issues_count":2728,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":4877,"open_issues":2728,"watchers":33571,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/23785"},"html":{"href":"https://github.com/Microsoft/TypeScript/pull/23785"},"issue":{"href":"https://api.github.com/repos/Microsoft/TypeScript/issues/23785"},"comments":{"href":"https://api.github.com/repos/Microsoft/TypeScript/issues/23785/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/23785/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/23785/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/TypeScript/statuses/1b118a446908df9df3286c0913485728d3021549"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mhegazy","id":8000722,"avatar_url":"https://avatars3.githubusercontent.com/u/8000722?v=4","gravatar_id":"","url":"https://api.github.com/users/mhegazy","html_url":"https://github.com/mhegazy","followers_url":"https://api.github.com/users/mhegazy/followers","following_url":"https://api.github.com/users/mhegazy/following{/other_user}","gists_url":"https://api.github.com/users/mhegazy/gists{/gist_id}","starred_url":"https://api.github.com/users/mhegazy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhegazy/subscriptions","organizations_url":"https://api.github.com/users/mhegazy/orgs","repos_url":"https://api.github.com/users/mhegazy/repos","events_url":"https://api.github.com/users/mhegazy/events{/privacy}","received_events_url":"https://api.github.com/users/mhegazy/received_events","type":"User","site_admin":false},"comments":0,"review_comments":4,"maintainer_can_modify":false,"commits":2,"additions":1032,"deletions":995,"changed_files":9}}
{"actor":{"display_login":"mhegazy"}}