{"action":"created","issue":{"url":"https://api.github.com/repos/nunit/nunit/issues/3036","repository_url":"https://api.github.com/repos/nunit/nunit","labels_url":"https://api.github.com/repos/nunit/nunit/issues/3036/labels{/name}","comments_url":"https://api.github.com/repos/nunit/nunit/issues/3036/comments","events_url":"https://api.github.com/repos/nunit/nunit/issues/3036/events","html_url":"https://github.com/nunit/nunit/pull/3036","id":365187620,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MTgxOTg1","number":3036,"title":"Apartment state can't be used for .NET Standard 2.0 tests","user":{"login":"MatthewBeardmore","id":808932,"node_id":"MDQ6VXNlcjgwODkzMg==","avatar_url":"https://avatars3.githubusercontent.com/u/808932?v=4","gravatar_id":"","url":"https://api.github.com/users/MatthewBeardmore","html_url":"https://github.com/MatthewBeardmore","followers_url":"https://api.github.com/users/MatthewBeardmore/followers","following_url":"https://api.github.com/users/MatthewBeardmore/following{/other_user}","gists_url":"https://api.github.com/users/MatthewBeardmore/gists{/gist_id}","starred_url":"https://api.github.com/users/MatthewBeardmore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatthewBeardmore/subscriptions","organizations_url":"https://api.github.com/users/MatthewBeardmore/orgs","repos_url":"https://api.github.com/users/MatthewBeardmore/repos","events_url":"https://api.github.com/users/MatthewBeardmore/events{/privacy}","received_events_url":"https://api.github.com/users/MatthewBeardmore/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-30T03:20:57Z","updated_at":"2018-09-30T18:08:29Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/nunit/nunit/pulls/3036","html_url":"https://github.com/nunit/nunit/pull/3036","diff_url":"https://github.com/nunit/nunit/pull/3036.diff","patch_url":"https://github.com/nunit/nunit/pull/3036.patch"},"body":"Closes #3035.\r\n\r\nEnables apartment state for .NET Standard 2.0 builds. All tests pass under Windows, Unix may have some failing tests, but I think I've added platform includes in all the places they might."},"comment":{"url":"https://api.github.com/repos/nunit/nunit/issues/comments/425739631","html_url":"https://github.com/nunit/nunit/pull/3036#issuecomment-425739631","issue_url":"https://api.github.com/repos/nunit/nunit/issues/3036","id":425739631,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTczOTYzMQ==","user":{"login":"jnm2","id":8040367,"node_id":"MDQ6VXNlcjgwNDAzNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/8040367?v=4","gravatar_id":"","url":"https://api.github.com/users/jnm2","html_url":"https://github.com/jnm2","followers_url":"https://api.github.com/users/jnm2/followers","following_url":"https://api.github.com/users/jnm2/following{/other_user}","gists_url":"https://api.github.com/users/jnm2/gists{/gist_id}","starred_url":"https://api.github.com/users/jnm2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnm2/subscriptions","organizations_url":"https://api.github.com/users/jnm2/orgs","repos_url":"https://api.github.com/users/jnm2/repos","events_url":"https://api.github.com/users/jnm2/events{/privacy}","received_events_url":"https://api.github.com/users/jnm2/received_events","type":"User","site_admin":false},"created_at":"2018-09-30T18:08:29Z","updated_at":"2018-09-30T18:08:29Z","author_association":"CONTRIBUTOR","body":"@MatthewBeardmore In order to enable this, we are going to need to catch the PlatformNotSupportedException and set the test result to Error. Otherwise the entire test run gets skipped because of one test.\r\n\r\nSomething that I expect will help with precisely this is https://www.nuget.org/packages/Microsoft.DotNet.Analyzers.Compatibility/. Would you be so kind as to add this to Directory.Build.props?\r\n\r\n```xml\r\n    <PackageReference Include=\"\r\nMicrosoft.DotNet.Analyzers.Compatibility\" Version=\"0.2.12-alpha\" PrivateAssets=\"all\" />\r\n```\r\n\r\n(More info at https://docs.microsoft.com/dotnet/standard/analyzers/portability-analyzer. I want to add all these analyzers to NUnit at some point.)"}}
{"actor":{"display_login":"jnm2"}}