{"action":"created","comment":{"url":"https://api.github.com/repos/getyourguide/sem-ad/pulls/comments/167585019","pull_request_review_id":95823335,"id":167585019,"diff_hunk":"@@ -0,0 +1,84 @@\n+from sqlalchemy import MetaData\n+\n+from tests.ad_templates.factories import EtaAdTemplateFactory, EtaAdLocationFactory, EtaAdCustomerInterestFactory","path":"tests/ad_templates/models/test_eta_ad_location.py","position":3,"original_position":3,"commit_id":"c177e2518d67cc6871f6688e03558b9cd1a00607","original_commit_id":"c177e2518d67cc6871f6688e03558b9cd1a00607","user":{"login":"andrebco","id":262594,"avatar_url":"https://avatars2.githubusercontent.com/u/262594?v=4","gravatar_id":"","url":"https://api.github.com/users/andrebco","html_url":"https://github.com/andrebco","followers_url":"https://api.github.com/users/andrebco/followers","following_url":"https://api.github.com/users/andrebco/following{/other_user}","gists_url":"https://api.github.com/users/andrebco/gists{/gist_id}","starred_url":"https://api.github.com/users/andrebco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrebco/subscriptions","organizations_url":"https://api.github.com/users/andrebco/orgs","repos_url":"https://api.github.com/users/andrebco/repos","events_url":"https://api.github.com/users/andrebco/events{/privacy}","received_events_url":"https://api.github.com/users/andrebco/received_events","type":"User","site_admin":false},"body":"Tks. ;-)","created_at":"2018-02-12T15:15:14Z","updated_at":"2018-02-12T15:15:14Z","html_url":"https://github.com/getyourguide/sem-ad/pull/23#discussion_r167585019","pull_request_url":"https://api.github.com/repos/getyourguide/sem-ad/pulls/23","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/getyourguide/sem-ad/pulls/comments/167585019"},"html":{"href":"https://github.com/getyourguide/sem-ad/pull/23#discussion_r167585019"},"pull_request":{"href":"https://api.github.com/repos/getyourguide/sem-ad/pulls/23"}},"in_reply_to_id":167575349},"pull_request":{"url":"https://api.github.com/repos/getyourguide/sem-ad/pulls/23","id":168471624,"html_url":"https://github.com/getyourguide/sem-ad/pull/23","diff_url":"https://github.com/getyourguide/sem-ad/pull/23.diff","patch_url":"https://github.com/getyourguide/sem-ad/pull/23.patch","issue_url":"https://api.github.com/repos/getyourguide/sem-ad/issues/23","number":23,"state":"open","locked":false,"title":"PERF-640: Represent location and customer interest ids as zero","user":{"login":"andrebco","id":262594,"avatar_url":"https://avatars2.githubusercontent.com/u/262594?v=4","gravatar_id":"","url":"https://api.github.com/users/andrebco","html_url":"https://github.com/andrebco","followers_url":"https://api.github.com/users/andrebco/followers","following_url":"https://api.github.com/users/andrebco/following{/other_user}","gists_url":"https://api.github.com/users/andrebco/gists{/gist_id}","starred_url":"https://api.github.com/users/andrebco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrebco/subscriptions","organizations_url":"https://api.github.com/users/andrebco/orgs","repos_url":"https://api.github.com/users/andrebco/repos","events_url":"https://api.github.com/users/andrebco/events{/privacy}","received_events_url":"https://api.github.com/users/andrebco/received_events","type":"User","site_admin":false},"body":"This PR will enable us to solve a possible issue using MySql instead of Postgres. We will be considering a change on how we represent Null values on DB.","created_at":"2018-02-11T20:12:53Z","updated_at":"2018-02-12T15:15:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9a5608ebad13182fb164b757d3c4a9bb778fa61","assignee":null,"assignees":[],"requested_reviewers":[{"login":"olel-gyg","id":23188692,"avatar_url":"https://avatars3.githubusercontent.com/u/23188692?v=4","gravatar_id":"","url":"https://api.github.com/users/olel-gyg","html_url":"https://github.com/olel-gyg","followers_url":"https://api.github.com/users/olel-gyg/followers","following_url":"https://api.github.com/users/olel-gyg/following{/other_user}","gists_url":"https://api.github.com/users/olel-gyg/gists{/gist_id}","starred_url":"https://api.github.com/users/olel-gyg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olel-gyg/subscriptions","organizations_url":"https://api.github.com/users/olel-gyg/orgs","repos_url":"https://api.github.com/users/olel-gyg/repos","events_url":"https://api.github.com/users/olel-gyg/events{/privacy}","received_events_url":"https://api.github.com/users/olel-gyg/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/getyourguide/sem-ad/pulls/23/commits","review_comments_url":"https://api.github.com/repos/getyourguide/sem-ad/pulls/23/comments","review_comment_url":"https://api.github.com/repos/getyourguide/sem-ad/pulls/comments{/number}","comments_url":"https://api.github.com/repos/getyourguide/sem-ad/issues/23/comments","statuses_url":"https://api.github.com/repos/getyourguide/sem-ad/statuses/c177e2518d67cc6871f6688e03558b9cd1a00607","head":{"label":"getyourguide:PERF-640_ids_as_zero","ref":"PERF-640_ids_as_zero","sha":"c177e2518d67cc6871f6688e03558b9cd1a00607","user":{"login":"getyourguide","id":3775006,"avatar_url":"https://avatars2.githubusercontent.com/u/3775006?v=4","gravatar_id":"","url":"https://api.github.com/users/getyourguide","html_url":"https://github.com/getyourguide","followers_url":"https://api.github.com/users/getyourguide/followers","following_url":"https://api.github.com/users/getyourguide/following{/other_user}","gists_url":"https://api.github.com/users/getyourguide/gists{/gist_id}","starred_url":"https://api.github.com/users/getyourguide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getyourguide/subscriptions","organizations_url":"https://api.github.com/users/getyourguide/orgs","repos_url":"https://api.github.com/users/getyourguide/repos","events_url":"https://api.github.com/users/getyourguide/events{/privacy}","received_events_url":"https://api.github.com/users/getyourguide/received_events","type":"Organization","site_admin":false},"repo":{"id":116401511,"name":"sem-ad","full_name":"getyourguide/sem-ad","owner":{"login":"getyourguide","id":3775006,"avatar_url":"https://avatars2.githubusercontent.com/u/3775006?v=4","gravatar_id":"","url":"https://api.github.com/users/getyourguide","html_url":"https://github.com/getyourguide","followers_url":"https://api.github.com/users/getyourguide/followers","following_url":"https://api.github.com/users/getyourguide/following{/other_user}","gists_url":"https://api.github.com/users/getyourguide/gists{/gist_id}","starred_url":"https://api.github.com/users/getyourguide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getyourguide/subscriptions","organizations_url":"https://api.github.com/users/getyourguide/orgs","repos_url":"https://api.github.com/users/getyourguide/repos","events_url":"https://api.github.com/users/getyourguide/events{/privacy}","received_events_url":"https://api.github.com/users/getyourguide/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/getyourguide/sem-ad","description":null,"fork":false,"url":"https://api.github.com/repos/getyourguide/sem-ad","forks_url":"https://api.github.com/repos/getyourguide/sem-ad/forks","keys_url":"https://api.github.com/repos/getyourguide/sem-ad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getyourguide/sem-ad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getyourguide/sem-ad/teams","hooks_url":"https://api.github.com/repos/getyourguide/sem-ad/hooks","issue_events_url":"https://api.github.com/repos/getyourguide/sem-ad/issues/events{/number}","events_url":"https://api.github.com/repos/getyourguide/sem-ad/events","assignees_url":"https://api.github.com/repos/getyourguide/sem-ad/assignees{/user}","branches_url":"https://api.github.com/repos/getyourguide/sem-ad/branches{/branch}","tags_url":"https://api.github.com/repos/getyourguide/sem-ad/tags","blobs_url":"https://api.github.com/repos/getyourguide/sem-ad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getyourguide/sem-ad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getyourguide/sem-ad/git/refs{/sha}","trees_url":"https://api.github.com/repos/getyourguide/sem-ad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getyourguide/sem-ad/statuses/{sha}","languages_url":"https://api.github.com/repos/getyourguide/sem-ad/languages","stargazers_url":"https://api.github.com/repos/getyourguide/sem-ad/stargazers","contributors_url":"https://api.github.com/repos/getyourguide/sem-ad/contributors","subscribers_url":"https://api.github.com/repos/getyourguide/sem-ad/subscribers","subscription_url":"https://api.github.com/repos/getyourguide/sem-ad/subscription","commits_url":"https://api.github.com/repos/getyourguide/sem-ad/commits{/sha}","git_commits_url":"https://api.github.com/repos/getyourguide/sem-ad/git/commits{/sha}","comments_url":"https://api.github.com/repos/getyourguide/sem-ad/comments{/number}","issue_comment_url":"https://api.github.com/repos/getyourguide/sem-ad/issues/comments{/number}","contents_url":"https://api.github.com/repos/getyourguide/sem-ad/contents/{+path}","compare_url":"https://api.github.com/repos/getyourguide/sem-ad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getyourguide/sem-ad/merges","archive_url":"https://api.github.com/repos/getyourguide/sem-ad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getyourguide/sem-ad/downloads","issues_url":"https://api.github.com/repos/getyourguide/sem-ad/issues{/number}","pulls_url":"https://api.github.com/repos/getyourguide/sem-ad/pulls{/number}","milestones_url":"https://api.github.com/repos/getyourguide/sem-ad/milestones{/number}","notifications_url":"https://api.github.com/repos/getyourguide/sem-ad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getyourguide/sem-ad/labels{/name}","releases_url":"https://api.github.com/repos/getyourguide/sem-ad/releases{/id}","deployments_url":"https://api.github.com/repos/getyourguide/sem-ad/deployments","created_at":"2018-01-05T15:54:06Z","updated_at":"2018-01-23T12:00:20Z","pushed_at":"2018-02-12T13:01:32Z","git_url":"git://github.com/getyourguide/sem-ad.git","ssh_url":"git@github.com:getyourguide/sem-ad.git","clone_url":"https://github.com/getyourguide/sem-ad.git","svn_url":"https://github.com/getyourguide/sem-ad","homepage":null,"size":140,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"getyourguide:PERF-625_test_template","ref":"PERF-625_test_template","sha":"da239b99625e74084daf70b365da7e3ca144a53b","user":{"login":"getyourguide","id":3775006,"avatar_url":"https://avatars2.githubusercontent.com/u/3775006?v=4","gravatar_id":"","url":"https://api.github.com/users/getyourguide","html_url":"https://github.com/getyourguide","followers_url":"https://api.github.com/users/getyourguide/followers","following_url":"https://api.github.com/users/getyourguide/following{/other_user}","gists_url":"https://api.github.com/users/getyourguide/gists{/gist_id}","starred_url":"https://api.github.com/users/getyourguide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getyourguide/subscriptions","organizations_url":"https://api.github.com/users/getyourguide/orgs","repos_url":"https://api.github.com/users/getyourguide/repos","events_url":"https://api.github.com/users/getyourguide/events{/privacy}","received_events_url":"https://api.github.com/users/getyourguide/received_events","type":"Organization","site_admin":false},"repo":{"id":116401511,"name":"sem-ad","full_name":"getyourguide/sem-ad","owner":{"login":"getyourguide","id":3775006,"avatar_url":"https://avatars2.githubusercontent.com/u/3775006?v=4","gravatar_id":"","url":"https://api.github.com/users/getyourguide","html_url":"https://github.com/getyourguide","followers_url":"https://api.github.com/users/getyourguide/followers","following_url":"https://api.github.com/users/getyourguide/following{/other_user}","gists_url":"https://api.github.com/users/getyourguide/gists{/gist_id}","starred_url":"https://api.github.com/users/getyourguide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getyourguide/subscriptions","organizations_url":"https://api.github.com/users/getyourguide/orgs","repos_url":"https://api.github.com/users/getyourguide/repos","events_url":"https://api.github.com/users/getyourguide/events{/privacy}","received_events_url":"https://api.github.com/users/getyourguide/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/getyourguide/sem-ad","description":null,"fork":false,"url":"https://api.github.com/repos/getyourguide/sem-ad","forks_url":"https://api.github.com/repos/getyourguide/sem-ad/forks","keys_url":"https://api.github.com/repos/getyourguide/sem-ad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getyourguide/sem-ad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getyourguide/sem-ad/teams","hooks_url":"https://api.github.com/repos/getyourguide/sem-ad/hooks","issue_events_url":"https://api.github.com/repos/getyourguide/sem-ad/issues/events{/number}","events_url":"https://api.github.com/repos/getyourguide/sem-ad/events","assignees_url":"https://api.github.com/repos/getyourguide/sem-ad/assignees{/user}","branches_url":"https://api.github.com/repos/getyourguide/sem-ad/branches{/branch}","tags_url":"https://api.github.com/repos/getyourguide/sem-ad/tags","blobs_url":"https://api.github.com/repos/getyourguide/sem-ad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getyourguide/sem-ad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getyourguide/sem-ad/git/refs{/sha}","trees_url":"https://api.github.com/repos/getyourguide/sem-ad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getyourguide/sem-ad/statuses/{sha}","languages_url":"https://api.github.com/repos/getyourguide/sem-ad/languages","stargazers_url":"https://api.github.com/repos/getyourguide/sem-ad/stargazers","contributors_url":"https://api.github.com/repos/getyourguide/sem-ad/contributors","subscribers_url":"https://api.github.com/repos/getyourguide/sem-ad/subscribers","subscription_url":"https://api.github.com/repos/getyourguide/sem-ad/subscription","commits_url":"https://api.github.com/repos/getyourguide/sem-ad/commits{/sha}","git_commits_url":"https://api.github.com/repos/getyourguide/sem-ad/git/commits{/sha}","comments_url":"https://api.github.com/repos/getyourguide/sem-ad/comments{/number}","issue_comment_url":"https://api.github.com/repos/getyourguide/sem-ad/issues/comments{/number}","contents_url":"https://api.github.com/repos/getyourguide/sem-ad/contents/{+path}","compare_url":"https://api.github.com/repos/getyourguide/sem-ad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getyourguide/sem-ad/merges","archive_url":"https://api.github.com/repos/getyourguide/sem-ad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getyourguide/sem-ad/downloads","issues_url":"https://api.github.com/repos/getyourguide/sem-ad/issues{/number}","pulls_url":"https://api.github.com/repos/getyourguide/sem-ad/pulls{/number}","milestones_url":"https://api.github.com/repos/getyourguide/sem-ad/milestones{/number}","notifications_url":"https://api.github.com/repos/getyourguide/sem-ad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getyourguide/sem-ad/labels{/name}","releases_url":"https://api.github.com/repos/getyourguide/sem-ad/releases{/id}","deployments_url":"https://api.github.com/repos/getyourguide/sem-ad/deployments","created_at":"2018-01-05T15:54:06Z","updated_at":"2018-01-23T12:00:20Z","pushed_at":"2018-02-12T13:01:32Z","git_url":"git://github.com/getyourguide/sem-ad.git","ssh_url":"git@github.com:getyourguide/sem-ad.git","clone_url":"https://github.com/getyourguide/sem-ad.git","svn_url":"https://github.com/getyourguide/sem-ad","homepage":null,"size":140,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/getyourguide/sem-ad/pulls/23"},"html":{"href":"https://github.com/getyourguide/sem-ad/pull/23"},"issue":{"href":"https://api.github.com/repos/getyourguide/sem-ad/issues/23"},"comments":{"href":"https://api.github.com/repos/getyourguide/sem-ad/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/getyourguide/sem-ad/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/getyourguide/sem-ad/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/getyourguide/sem-ad/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/getyourguide/sem-ad/statuses/c177e2518d67cc6871f6688e03558b9cd1a00607"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"andrebco"}}