{"action":"closed","number":1000,"pull_request":{"url":"https://api.github.com/repos/tensorflow/tensorboard/pulls/1000","id":171153979,"html_url":"https://github.com/tensorflow/tensorboard/pull/1000","diff_url":"https://github.com/tensorflow/tensorboard/pull/1000.diff","patch_url":"https://github.com/tensorflow/tensorboard/pull/1000.patch","issue_url":"https://api.github.com/repos/tensorflow/tensorboard/issues/1000","number":1000,"state":"closed","locked":false,"title":"Fix DB-based is_active() methods to not always return True","user":{"login":"nfelt","id":710113,"avatar_url":"https://avatars0.githubusercontent.com/u/710113?v=4","gravatar_id":"","url":"https://api.github.com/users/nfelt","html_url":"https://github.com/nfelt","followers_url":"https://api.github.com/users/nfelt/followers","following_url":"https://api.github.com/users/nfelt/following{/other_user}","gists_url":"https://api.github.com/users/nfelt/gists{/gist_id}","starred_url":"https://api.github.com/users/nfelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfelt/subscriptions","organizations_url":"https://api.github.com/users/nfelt/orgs","repos_url":"https://api.github.com/users/nfelt/repos","events_url":"https://api.github.com/users/nfelt/events{/privacy}","received_events_url":"https://api.github.com/users/nfelt/received_events","type":"User","site_admin":false},"body":"Applying `bool()` to a `sqlite3.Cursor` always returns `True` - while the Cursor can be used like an iterable, it doesn't define `__len__()` (since the result set size isn't necessarily known until you start iterating over it) or `__nonzero__()` and hence is Truthy always, even when the result set is empty.\r\n\r\nThe fix for this is just to convert it to a list first.","created_at":"2018-02-24T01:52:34Z","updated_at":"2018-02-24T01:59:15Z","closed_at":"2018-02-24T01:59:15Z","merged_at":"2018-02-24T01:59:15Z","merge_commit_sha":"fa73d57879db0e774a5f0f246d3715d98bcfb4a2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tensorflow/tensorboard/pulls/1000/commits","review_comments_url":"https://api.github.com/repos/tensorflow/tensorboard/pulls/1000/comments","review_comment_url":"https://api.github.com/repos/tensorflow/tensorboard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tensorflow/tensorboard/issues/1000/comments","statuses_url":"https://api.github.com/repos/tensorflow/tensorboard/statuses/94523f9f006806f1dda0e370d4c78e12a82d7433","head":{"label":"nfelt:fix-db-isactive","ref":"fix-db-isactive","sha":"94523f9f006806f1dda0e370d4c78e12a82d7433","user":{"login":"nfelt","id":710113,"avatar_url":"https://avatars0.githubusercontent.com/u/710113?v=4","gravatar_id":"","url":"https://api.github.com/users/nfelt","html_url":"https://github.com/nfelt","followers_url":"https://api.github.com/users/nfelt/followers","following_url":"https://api.github.com/users/nfelt/following{/other_user}","gists_url":"https://api.github.com/users/nfelt/gists{/gist_id}","starred_url":"https://api.github.com/users/nfelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfelt/subscriptions","organizations_url":"https://api.github.com/users/nfelt/orgs","repos_url":"https://api.github.com/users/nfelt/repos","events_url":"https://api.github.com/users/nfelt/events{/privacy}","received_events_url":"https://api.github.com/users/nfelt/received_events","type":"User","site_admin":false},"repo":{"id":105821787,"name":"tensorboard","full_name":"nfelt/tensorboard","owner":{"login":"nfelt","id":710113,"avatar_url":"https://avatars0.githubusercontent.com/u/710113?v=4","gravatar_id":"","url":"https://api.github.com/users/nfelt","html_url":"https://github.com/nfelt","followers_url":"https://api.github.com/users/nfelt/followers","following_url":"https://api.github.com/users/nfelt/following{/other_user}","gists_url":"https://api.github.com/users/nfelt/gists{/gist_id}","starred_url":"https://api.github.com/users/nfelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfelt/subscriptions","organizations_url":"https://api.github.com/users/nfelt/orgs","repos_url":"https://api.github.com/users/nfelt/repos","events_url":"https://api.github.com/users/nfelt/events{/privacy}","received_events_url":"https://api.github.com/users/nfelt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nfelt/tensorboard","description":"TensorFlow's Visualization Toolkit","fork":true,"url":"https://api.github.com/repos/nfelt/tensorboard","forks_url":"https://api.github.com/repos/nfelt/tensorboard/forks","keys_url":"https://api.github.com/repos/nfelt/tensorboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nfelt/tensorboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nfelt/tensorboard/teams","hooks_url":"https://api.github.com/repos/nfelt/tensorboard/hooks","issue_events_url":"https://api.github.com/repos/nfelt/tensorboard/issues/events{/number}","events_url":"https://api.github.com/repos/nfelt/tensorboard/events","assignees_url":"https://api.github.com/repos/nfelt/tensorboard/assignees{/user}","branches_url":"https://api.github.com/repos/nfelt/tensorboard/branches{/branch}","tags_url":"https://api.github.com/repos/nfelt/tensorboard/tags","blobs_url":"https://api.github.com/repos/nfelt/tensorboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nfelt/tensorboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nfelt/tensorboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/nfelt/tensorboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nfelt/tensorboard/statuses/{sha}","languages_url":"https://api.github.com/repos/nfelt/tensorboard/languages","stargazers_url":"https://api.github.com/repos/nfelt/tensorboard/stargazers","contributors_url":"https://api.github.com/repos/nfelt/tensorboard/contributors","subscribers_url":"https://api.github.com/repos/nfelt/tensorboard/subscribers","subscription_url":"https://api.github.com/repos/nfelt/tensorboard/subscription","commits_url":"https://api.github.com/repos/nfelt/tensorboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/nfelt/tensorboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/nfelt/tensorboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/nfelt/tensorboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/nfelt/tensorboard/contents/{+path}","compare_url":"https://api.github.com/repos/nfelt/tensorboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nfelt/tensorboard/merges","archive_url":"https://api.github.com/repos/nfelt/tensorboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nfelt/tensorboard/downloads","issues_url":"https://api.github.com/repos/nfelt/tensorboard/issues{/number}","pulls_url":"https://api.github.com/repos/nfelt/tensorboard/pulls{/number}","milestones_url":"https://api.github.com/repos/nfelt/tensorboard/milestones{/number}","notifications_url":"https://api.github.com/repos/nfelt/tensorboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nfelt/tensorboard/labels{/name}","releases_url":"https://api.github.com/repos/nfelt/tensorboard/releases{/id}","deployments_url":"https://api.github.com/repos/nfelt/tensorboard/deployments","created_at":"2017-10-04T21:46:15Z","updated_at":"2017-10-04T21:46:18Z","pushed_at":"2018-02-24T01:47:29Z","git_url":"git://github.com/nfelt/tensorboard.git","ssh_url":"git@github.com:nfelt/tensorboard.git","clone_url":"https://github.com/nfelt/tensorboard.git","svn_url":"https://github.com/nfelt/tensorboard","homepage":null,"size":10457,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tensorflow:master","ref":"master","sha":"4c0e2582ac1d3ba20481167e466e27d967da8481","user":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"repo":{"id":91379993,"name":"tensorboard","full_name":"tensorflow/tensorboard","owner":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tensorflow/tensorboard","description":"TensorFlow's Visualization Toolkit","fork":false,"url":"https://api.github.com/repos/tensorflow/tensorboard","forks_url":"https://api.github.com/repos/tensorflow/tensorboard/forks","keys_url":"https://api.github.com/repos/tensorflow/tensorboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tensorflow/tensorboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tensorflow/tensorboard/teams","hooks_url":"https://api.github.com/repos/tensorflow/tensorboard/hooks","issue_events_url":"https://api.github.com/repos/tensorflow/tensorboard/issues/events{/number}","events_url":"https://api.github.com/repos/tensorflow/tensorboard/events","assignees_url":"https://api.github.com/repos/tensorflow/tensorboard/assignees{/user}","branches_url":"https://api.github.com/repos/tensorflow/tensorboard/branches{/branch}","tags_url":"https://api.github.com/repos/tensorflow/tensorboard/tags","blobs_url":"https://api.github.com/repos/tensorflow/tensorboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tensorflow/tensorboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tensorflow/tensorboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/tensorflow/tensorboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tensorflow/tensorboard/statuses/{sha}","languages_url":"https://api.github.com/repos/tensorflow/tensorboard/languages","stargazers_url":"https://api.github.com/repos/tensorflow/tensorboard/stargazers","contributors_url":"https://api.github.com/repos/tensorflow/tensorboard/contributors","subscribers_url":"https://api.github.com/repos/tensorflow/tensorboard/subscribers","subscription_url":"https://api.github.com/repos/tensorflow/tensorboard/subscription","commits_url":"https://api.github.com/repos/tensorflow/tensorboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/tensorflow/tensorboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/tensorflow/tensorboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/tensorflow/tensorboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/tensorflow/tensorboard/contents/{+path}","compare_url":"https://api.github.com/repos/tensorflow/tensorboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tensorflow/tensorboard/merges","archive_url":"https://api.github.com/repos/tensorflow/tensorboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tensorflow/tensorboard/downloads","issues_url":"https://api.github.com/repos/tensorflow/tensorboard/issues{/number}","pulls_url":"https://api.github.com/repos/tensorflow/tensorboard/pulls{/number}","milestones_url":"https://api.github.com/repos/tensorflow/tensorboard/milestones{/number}","notifications_url":"https://api.github.com/repos/tensorflow/tensorboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tensorflow/tensorboard/labels{/name}","releases_url":"https://api.github.com/repos/tensorflow/tensorboard/releases{/id}","deployments_url":"https://api.github.com/repos/tensorflow/tensorboard/deployments","created_at":"2017-05-15T20:08:07Z","updated_at":"2018-02-23T19:09:49Z","pushed_at":"2018-02-24T01:59:15Z","git_url":"git://github.com/tensorflow/tensorboard.git","ssh_url":"git@github.com:tensorflow/tensorboard.git","clone_url":"https://github.com/tensorflow/tensorboard.git","svn_url":"https://github.com/tensorflow/tensorboard","homepage":null,"size":10904,"stargazers_count":1268,"watchers_count":1268,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":309,"mirror_url":null,"archived":false,"open_issues_count":191,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":309,"open_issues":191,"watchers":1268,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tensorflow/tensorboard/pulls/1000"},"html":{"href":"https://github.com/tensorflow/tensorboard/pull/1000"},"issue":{"href":"https://api.github.com/repos/tensorflow/tensorboard/issues/1000"},"comments":{"href":"https://api.github.com/repos/tensorflow/tensorboard/issues/1000/comments"},"review_comments":{"href":"https://api.github.com/repos/tensorflow/tensorboard/pulls/1000/comments"},"review_comment":{"href":"https://api.github.com/repos/tensorflow/tensorboard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tensorflow/tensorboard/pulls/1000/commits"},"statuses":{"href":"https://api.github.com/repos/tensorflow/tensorboard/statuses/94523f9f006806f1dda0e370d4c78e12a82d7433"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"nfelt","id":710113,"avatar_url":"https://avatars0.githubusercontent.com/u/710113?v=4","gravatar_id":"","url":"https://api.github.com/users/nfelt","html_url":"https://github.com/nfelt","followers_url":"https://api.github.com/users/nfelt/followers","following_url":"https://api.github.com/users/nfelt/following{/other_user}","gists_url":"https://api.github.com/users/nfelt/gists{/gist_id}","starred_url":"https://api.github.com/users/nfelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfelt/subscriptions","organizations_url":"https://api.github.com/users/nfelt/orgs","repos_url":"https://api.github.com/users/nfelt/repos","events_url":"https://api.github.com/users/nfelt/events{/privacy}","received_events_url":"https://api.github.com/users/nfelt/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"nfelt"}}