{"action":"created","comment":{"url":"https://api.github.com/repos/elixir-ecto/ecto_sql/pulls/comments/236000510","pull_request_review_id":178001756,"id":236000510,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjAwMDUxMA==","diff_hunk":"@@ -6,6 +6,11 @@ Code.require_file \"#{ecto}/integration_test/cases/preload.exs\", __DIR__\n Code.require_file \"#{ecto}/integration_test/cases/repo.exs\", __DIR__\n Code.require_file \"#{ecto}/integration_test/cases/type.exs\", __DIR__\n \n+# TODO:\n+# if TestHelper.mysql_8?() do\n+#   Code.require_file \"#{ecto}/integration_test/cases/windows.exs\", __DIR__","path":"integration_test/mysql/all_test.exs","position":6,"original_position":6,"commit_id":"68931187a1bf7b54375a1431024b4e577c55ebb0","original_commit_id":"68931187a1bf7b54375a1431024b4e577c55ebb0","user":{"login":"wojtekmach","id":76071,"node_id":"MDQ6VXNlcjc2MDcx","avatar_url":"https://avatars0.githubusercontent.com/u/76071?v=4","gravatar_id":"","url":"https://api.github.com/users/wojtekmach","html_url":"https://github.com/wojtekmach","followers_url":"https://api.github.com/users/wojtekmach/followers","following_url":"https://api.github.com/users/wojtekmach/following{/other_user}","gists_url":"https://api.github.com/users/wojtekmach/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtekmach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtekmach/subscriptions","organizations_url":"https://api.github.com/users/wojtekmach/orgs","repos_url":"https://api.github.com/users/wojtekmach/repos","events_url":"https://api.github.com/users/wojtekmach/events{/privacy}","received_events_url":"https://api.github.com/users/wojtekmach/received_events","type":"User","site_admin":false},"body":"it almost works, might be a bug in Mariaex:\r\n\r\n```\r\n  1) test frame (Ecto.Integration.WindowsTest)\r\n     deps/ecto/integration_test/cases/windows.exs:30\r\n     match (=) failed\r\n     code:  assert [[0, 3], [1, 7], [2, 14], [3, 28], [4, 56], [5, 112], [6, 96]] = TestRepo.all(query)\r\n     right: [\r\n              [0, #Decimal<3>],\r\n              [1, #Decimal<7>],\r\n              [2, #Decimal<14>],\r\n              [3, #Decimal<28>],\r\n              [4, #Decimal<56>],\r\n              [5, #Decimal<112>],\r\n              [6, #Decimal<96>]\r\n            ]\r\n     stacktrace:\r\n       deps/ecto/integration_test/cases/windows.exs:39: (test)\r\n```","created_at":"2018-11-23T17:54:27Z","updated_at":"2018-11-23T17:54:27Z","html_url":"https://github.com/elixir-ecto/ecto_sql/pull/50#discussion_r236000510","pull_request_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/pulls/50","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/elixir-ecto/ecto_sql/pulls/comments/236000510"},"html":{"href":"https://github.com/elixir-ecto/ecto_sql/pull/50#discussion_r236000510"},"pull_request":{"href":"https://api.github.com/repos/elixir-ecto/ecto_sql/pulls/50"}}},"pull_request":{"url":"https://api.github.com/repos/elixir-ecto/ecto_sql/pulls/50","id":233258827,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMjU4ODI3","html_url":"https://github.com/elixir-ecto/ecto_sql/pull/50","diff_url":"https://github.com/elixir-ecto/ecto_sql/pull/50.diff","patch_url":"https://github.com/elixir-ecto/ecto_sql/pull/50.patch","issue_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/issues/50","number":50,"state":"open","locked":false,"title":"Run tests on MySQL 8.0","user":{"login":"wojtekmach","id":76071,"node_id":"MDQ6VXNlcjc2MDcx","avatar_url":"https://avatars0.githubusercontent.com/u/76071?v=4","gravatar_id":"","url":"https://api.github.com/users/wojtekmach","html_url":"https://github.com/wojtekmach","followers_url":"https://api.github.com/users/wojtekmach/followers","following_url":"https://api.github.com/users/wojtekmach/following{/other_user}","gists_url":"https://api.github.com/users/wojtekmach/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtekmach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtekmach/subscriptions","organizations_url":"https://api.github.com/users/wojtekmach/orgs","repos_url":"https://api.github.com/users/wojtekmach/repos","events_url":"https://api.github.com/users/wojtekmach/events{/privacy}","received_events_url":"https://api.github.com/users/wojtekmach/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-23T17:53:06Z","updated_at":"2018-11-23T17:54:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a88f4e6d71318b1c077e217f2d69b6369ff73bb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/pulls/50/commits","review_comments_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/pulls/50/comments","review_comment_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/issues/50/comments","statuses_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/statuses/68931187a1bf7b54375a1431024b4e577c55ebb0","head":{"label":"wojtekmach:wm-mysql-8.0","ref":"wm-mysql-8.0","sha":"68931187a1bf7b54375a1431024b4e577c55ebb0","user":{"login":"wojtekmach","id":76071,"node_id":"MDQ6VXNlcjc2MDcx","avatar_url":"https://avatars0.githubusercontent.com/u/76071?v=4","gravatar_id":"","url":"https://api.github.com/users/wojtekmach","html_url":"https://github.com/wojtekmach","followers_url":"https://api.github.com/users/wojtekmach/followers","following_url":"https://api.github.com/users/wojtekmach/following{/other_user}","gists_url":"https://api.github.com/users/wojtekmach/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtekmach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtekmach/subscriptions","organizations_url":"https://api.github.com/users/wojtekmach/orgs","repos_url":"https://api.github.com/users/wojtekmach/repos","events_url":"https://api.github.com/users/wojtekmach/events{/privacy}","received_events_url":"https://api.github.com/users/wojtekmach/received_events","type":"User","site_admin":false},"repo":{"id":151558760,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE1NTg3NjA=","name":"ecto_sql","full_name":"wojtekmach/ecto_sql","private":false,"owner":{"login":"wojtekmach","id":76071,"node_id":"MDQ6VXNlcjc2MDcx","avatar_url":"https://avatars0.githubusercontent.com/u/76071?v=4","gravatar_id":"","url":"https://api.github.com/users/wojtekmach","html_url":"https://github.com/wojtekmach","followers_url":"https://api.github.com/users/wojtekmach/followers","following_url":"https://api.github.com/users/wojtekmach/following{/other_user}","gists_url":"https://api.github.com/users/wojtekmach/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtekmach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtekmach/subscriptions","organizations_url":"https://api.github.com/users/wojtekmach/orgs","repos_url":"https://api.github.com/users/wojtekmach/repos","events_url":"https://api.github.com/users/wojtekmach/events{/privacy}","received_events_url":"https://api.github.com/users/wojtekmach/received_events","type":"User","site_admin":false},"html_url":"https://github.com/wojtekmach/ecto_sql","description":"SQL-based adapters for Ecto and database migrations","fork":true,"url":"https://api.github.com/repos/wojtekmach/ecto_sql","forks_url":"https://api.github.com/repos/wojtekmach/ecto_sql/forks","keys_url":"https://api.github.com/repos/wojtekmach/ecto_sql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wojtekmach/ecto_sql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wojtekmach/ecto_sql/teams","hooks_url":"https://api.github.com/repos/wojtekmach/ecto_sql/hooks","issue_events_url":"https://api.github.com/repos/wojtekmach/ecto_sql/issues/events{/number}","events_url":"https://api.github.com/repos/wojtekmach/ecto_sql/events","assignees_url":"https://api.github.com/repos/wojtekmach/ecto_sql/assignees{/user}","branches_url":"https://api.github.com/repos/wojtekmach/ecto_sql/branches{/branch}","tags_url":"https://api.github.com/repos/wojtekmach/ecto_sql/tags","blobs_url":"https://api.github.com/repos/wojtekmach/ecto_sql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wojtekmach/ecto_sql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wojtekmach/ecto_sql/git/refs{/sha}","trees_url":"https://api.github.com/repos/wojtekmach/ecto_sql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wojtekmach/ecto_sql/statuses/{sha}","languages_url":"https://api.github.com/repos/wojtekmach/ecto_sql/languages","stargazers_url":"https://api.github.com/repos/wojtekmach/ecto_sql/stargazers","contributors_url":"https://api.github.com/repos/wojtekmach/ecto_sql/contributors","subscribers_url":"https://api.github.com/repos/wojtekmach/ecto_sql/subscribers","subscription_url":"https://api.github.com/repos/wojtekmach/ecto_sql/subscription","commits_url":"https://api.github.com/repos/wojtekmach/ecto_sql/commits{/sha}","git_commits_url":"https://api.github.com/repos/wojtekmach/ecto_sql/git/commits{/sha}","comments_url":"https://api.github.com/repos/wojtekmach/ecto_sql/comments{/number}","issue_comment_url":"https://api.github.com/repos/wojtekmach/ecto_sql/issues/comments{/number}","contents_url":"https://api.github.com/repos/wojtekmach/ecto_sql/contents/{+path}","compare_url":"https://api.github.com/repos/wojtekmach/ecto_sql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wojtekmach/ecto_sql/merges","archive_url":"https://api.github.com/repos/wojtekmach/ecto_sql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wojtekmach/ecto_sql/downloads","issues_url":"https://api.github.com/repos/wojtekmach/ecto_sql/issues{/number}","pulls_url":"https://api.github.com/repos/wojtekmach/ecto_sql/pulls{/number}","milestones_url":"https://api.github.com/repos/wojtekmach/ecto_sql/milestones{/number}","notifications_url":"https://api.github.com/repos/wojtekmach/ecto_sql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wojtekmach/ecto_sql/labels{/name}","releases_url":"https://api.github.com/repos/wojtekmach/ecto_sql/releases{/id}","deployments_url":"https://api.github.com/repos/wojtekmach/ecto_sql/deployments","created_at":"2018-10-04T11:06:41Z","updated_at":"2018-11-23T08:45:40Z","pushed_at":"2018-11-23T17:44:55Z","git_url":"git://github.com/wojtekmach/ecto_sql.git","ssh_url":"git@github.com:wojtekmach/ecto_sql.git","clone_url":"https://github.com/wojtekmach/ecto_sql.git","svn_url":"https://github.com/wojtekmach/ecto_sql","homepage":null,"size":247,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"elixir-ecto:master","ref":"master","sha":"09e896b672f3ccfe0df2c40577b05d959113aab9","user":{"login":"elixir-ecto","id":19973437,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTczNDM3","avatar_url":"https://avatars3.githubusercontent.com/u/19973437?v=4","gravatar_id":"","url":"https://api.github.com/users/elixir-ecto","html_url":"https://github.com/elixir-ecto","followers_url":"https://api.github.com/users/elixir-ecto/followers","following_url":"https://api.github.com/users/elixir-ecto/following{/other_user}","gists_url":"https://api.github.com/users/elixir-ecto/gists{/gist_id}","starred_url":"https://api.github.com/users/elixir-ecto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elixir-ecto/subscriptions","organizations_url":"https://api.github.com/users/elixir-ecto/orgs","repos_url":"https://api.github.com/users/elixir-ecto/repos","events_url":"https://api.github.com/users/elixir-ecto/events{/privacy}","received_events_url":"https://api.github.com/users/elixir-ecto/received_events","type":"Organization","site_admin":false},"repo":{"id":151455245,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE0NTUyNDU=","name":"ecto_sql","full_name":"elixir-ecto/ecto_sql","private":false,"owner":{"login":"elixir-ecto","id":19973437,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTczNDM3","avatar_url":"https://avatars3.githubusercontent.com/u/19973437?v=4","gravatar_id":"","url":"https://api.github.com/users/elixir-ecto","html_url":"https://github.com/elixir-ecto","followers_url":"https://api.github.com/users/elixir-ecto/followers","following_url":"https://api.github.com/users/elixir-ecto/following{/other_user}","gists_url":"https://api.github.com/users/elixir-ecto/gists{/gist_id}","starred_url":"https://api.github.com/users/elixir-ecto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elixir-ecto/subscriptions","organizations_url":"https://api.github.com/users/elixir-ecto/orgs","repos_url":"https://api.github.com/users/elixir-ecto/repos","events_url":"https://api.github.com/users/elixir-ecto/events{/privacy}","received_events_url":"https://api.github.com/users/elixir-ecto/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elixir-ecto/ecto_sql","description":"SQL-based adapters for Ecto and database migrations","fork":false,"url":"https://api.github.com/repos/elixir-ecto/ecto_sql","forks_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/forks","keys_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/teams","hooks_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/hooks","issue_events_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/issues/events{/number}","events_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/events","assignees_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/assignees{/user}","branches_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/branches{/branch}","tags_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/tags","blobs_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/git/refs{/sha}","trees_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/statuses/{sha}","languages_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/languages","stargazers_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/stargazers","contributors_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/contributors","subscribers_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/subscribers","subscription_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/subscription","commits_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/commits{/sha}","git_commits_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/git/commits{/sha}","comments_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/comments{/number}","issue_comment_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/issues/comments{/number}","contents_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/contents/{+path}","compare_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/merges","archive_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/downloads","issues_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/issues{/number}","pulls_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/pulls{/number}","milestones_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/milestones{/number}","notifications_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/labels{/name}","releases_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/releases{/id}","deployments_url":"https://api.github.com/repos/elixir-ecto/ecto_sql/deployments","created_at":"2018-10-03T17:48:11Z","updated_at":"2018-11-23T15:45:05Z","pushed_at":"2018-11-23T17:53:06Z","git_url":"git://github.com/elixir-ecto/ecto_sql.git","ssh_url":"git@github.com:elixir-ecto/ecto_sql.git","clone_url":"https://github.com/elixir-ecto/ecto_sql.git","svn_url":"https://github.com/elixir-ecto/ecto_sql","homepage":null,"size":236,"stargazers_count":86,"watchers_count":86,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":23,"open_issues":5,"watchers":86,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elixir-ecto/ecto_sql/pulls/50"},"html":{"href":"https://github.com/elixir-ecto/ecto_sql/pull/50"},"issue":{"href":"https://api.github.com/repos/elixir-ecto/ecto_sql/issues/50"},"comments":{"href":"https://api.github.com/repos/elixir-ecto/ecto_sql/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/elixir-ecto/ecto_sql/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/elixir-ecto/ecto_sql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elixir-ecto/ecto_sql/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/elixir-ecto/ecto_sql/statuses/68931187a1bf7b54375a1431024b4e577c55ebb0"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"wojtekmach"}}