{"action":"created","issue":{"url":"https://api.github.com/repos/official-stockfish/Stockfish/issues/1792","repository_url":"https://api.github.com/repos/official-stockfish/Stockfish","labels_url":"https://api.github.com/repos/official-stockfish/Stockfish/issues/1792/labels{/name}","comments_url":"https://api.github.com/repos/official-stockfish/Stockfish/issues/1792/comments","events_url":"https://api.github.com/repos/official-stockfish/Stockfish/issues/1792/events","html_url":"https://github.com/official-stockfish/Stockfish/pull/1792","id":374777251,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MzgyOTY4","number":1792,"title":"Fix issues from using adjustedDepth too broadly","user":{"login":"vondele","id":4202567,"node_id":"MDQ6VXNlcjQyMDI1Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/4202567?v=4","gravatar_id":"","url":"https://api.github.com/users/vondele","html_url":"https://github.com/vondele","followers_url":"https://api.github.com/users/vondele/followers","following_url":"https://api.github.com/users/vondele/following{/other_user}","gists_url":"https://api.github.com/users/vondele/gists{/gist_id}","starred_url":"https://api.github.com/users/vondele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vondele/subscriptions","organizations_url":"https://api.github.com/users/vondele/orgs","repos_url":"https://api.github.com/users/vondele/repos","events_url":"https://api.github.com/users/vondele/events{/privacy}","received_events_url":"https://api.github.com/users/vondele/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-10-28T17:23:46Z","updated_at":"2018-10-31T10:30:38Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/official-stockfish/Stockfish/pulls/1792","html_url":"https://github.com/official-stockfish/Stockfish/pull/1792","diff_url":"https://github.com/official-stockfish/Stockfish/pull/1792.diff","patch_url":"https://github.com/official-stockfish/Stockfish/pull/1792.patch"},"body":"the committed FH patch (081af9080542a0d076a5482da37103a96ee15f64) had a number of changes beyond adjusting the depth of search on fail high, with some undesirable side effects.\r\n\r\n1) decreasing depth on PV output, confusing GUIs and players alike as described in issue #1787. The depth printed is anyway a convention, let's consider adjustedDepth an implementation detail, and continue to print rootDepth. Depth, nodes, time and move quality all increase as we compute more. (fixing this output has no effect on play).\r\n\r\n2) fixes go depth output (now based on rootDepth again, no effect on play), also reported in issue #1787\r\n\r\n3) lastBestDepth is used to compute how long a move is stable, a new move found during FH is incorrectly considered stable if based on adjustedDepth instead of rootDepth. (Changes TM). Reverting this:\r\npassed STC [-3,1]\r\nLLR: 2.95 (-2.94,2.94) [-3.00,1.00]\r\nTotal: 82982 W: 17810 L: 17808 D: 47364\r\nhttp://tests.stockfishchess.org/tests/view/5bd391a80ebc595e0ae1e993\r\n\r\npassed LTC [-3,1]\r\nLLR: 2.95 (-2.94,2.94) [-3.00,1.00]\r\nTotal: 109083 W: 17602 L: 17619 D: 73862\r\nhttp://tests.stockfishchess.org/tests/view/5bd40c820ebc595e0ae1f1fb\r\n\r\n4) In the thread voting scheme, the rank of the FH thread is now artificially low, incorrectly since the quality of the move is much better than what adjustedDepth suggests (e.g. if it takes 10 iterations to find VALUE_KNOWN_WIN, it has very low depth). Further evidence comes from a test that showed that the move of highest depth is not better than that of the last PV (which is potentially of much lower adjustedDepth).\r\nI.e. this test http://tests.stockfishchess.org/tests/view/5bd37a120ebc595e0ae1e7c3 failed SPRT [0, 5]\r\nLLR: -2.95 (-2.94,2.94) [0.00,5.00]\r\nTotal: 10609 W: 2266 L: 2345 D: 5998\r\n\r\nIn a running 5+0.05 th 8 test (more than 10000 games) a positive Elo estimate is shown (strong enough for a [-3,1], possibly not [0,4]):\r\nhttp://tests.stockfishchess.org/tests/view/5bd421be0ebc595e0ae1f315\r\nLLR: -0.13 (-2.94,2.94) [0.00,4.00]\r\nTotal: 13644 W: 2573 L: 2532 D: 8539\r\nElo\t1.04 [-2.52,4.61] / LOS 71%\r\n\r\nThus, restore old behavior as a bugfix, keeping the core of the FH resolving scheme. (This is non-functional for a bench, but changes searches via TM and in the threaded case).\r\n\r\nBench: 3166402"},"comment":{"url":"https://api.github.com/repos/official-stockfish/Stockfish/issues/comments/434637108","html_url":"https://github.com/official-stockfish/Stockfish/pull/1792#issuecomment-434637108","issue_url":"https://api.github.com/repos/official-stockfish/Stockfish/issues/1792","id":434637108,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDYzNzEwOA==","user":{"login":"pb00068","id":1720741,"node_id":"MDQ6VXNlcjE3MjA3NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/1720741?v=4","gravatar_id":"","url":"https://api.github.com/users/pb00068","html_url":"https://github.com/pb00068","followers_url":"https://api.github.com/users/pb00068/followers","following_url":"https://api.github.com/users/pb00068/following{/other_user}","gists_url":"https://api.github.com/users/pb00068/gists{/gist_id}","starred_url":"https://api.github.com/users/pb00068/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pb00068/subscriptions","organizations_url":"https://api.github.com/users/pb00068/orgs","repos_url":"https://api.github.com/users/pb00068/repos","events_url":"https://api.github.com/users/pb00068/events{/privacy}","received_events_url":"https://api.github.com/users/pb00068/received_events","type":"User","site_admin":false},"created_at":"2018-10-31T10:30:38Z","updated_at":"2018-10-31T10:30:38Z","author_association":"NONE","body":"@vondele Ahh, now I have understood. Thanks for clarification!"}}
{"actor":{"display_login":"pb00068"}}