{"action":"closed","number":244,"pull_request":{"url":"https://api.github.com/repos/ebroecker/canmatrix/pulls/244","id":229837360,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5ODM3MzYw","html_url":"https://github.com/ebroecker/canmatrix/pull/244","diff_url":"https://github.com/ebroecker/canmatrix/pull/244.diff","patch_url":"https://github.com/ebroecker/canmatrix/pull/244.patch","issue_url":"https://api.github.com/repos/ebroecker/canmatrix/issues/244","number":244,"state":"closed","locked":false,"title":"Use module loggers.","user":{"login":"Funth0mas","id":43621609,"node_id":"MDQ6VXNlcjQzNjIxNjA5","avatar_url":"https://avatars2.githubusercontent.com/u/43621609?v=4","gravatar_id":"","url":"https://api.github.com/users/Funth0mas","html_url":"https://github.com/Funth0mas","followers_url":"https://api.github.com/users/Funth0mas/followers","following_url":"https://api.github.com/users/Funth0mas/following{/other_user}","gists_url":"https://api.github.com/users/Funth0mas/gists{/gist_id}","starred_url":"https://api.github.com/users/Funth0mas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Funth0mas/subscriptions","organizations_url":"https://api.github.com/users/Funth0mas/orgs","repos_url":"https://api.github.com/users/Funth0mas/repos","events_url":"https://api.github.com/users/Funth0mas/events{/privacy}","received_events_url":"https://api.github.com/users/Funth0mas/received_events","type":"User","site_admin":false},"body":"As discussed in #237, use module loggers based on module names and only configure logger in main(). It is intended to replace+finish #164.\r\n\r\n* every logger is child of main \"canmatrix\" logger\r\n* if used as a standalone converter/comparator, the 'canmatrix' logger is configured to provide all messages\r\n* if used as a library, the logger setting is up to the user. He can either configure its root logger or use default config by calling `canmatrix.log.setup_logger()`. Or leave default `logging` behavior.\r\n\r\nIf you agree with this change, it would be gentle to document the above points somewhere, but I don't know where.\r\n\r\nThe rows\r\n```\r\nif __name__ == '__main__':\r\n    sys.exit(main())\r\n```\r\nin compare.py and convert.py don't work (at least due to import issues). It must be run using either examples/convert.py or the script generated by setuptool. I'll propose another PR to remove them, not to confuse anymore.","created_at":"2018-11-09T22:30:52Z","updated_at":"2018-11-21T09:33:51Z","closed_at":"2018-11-21T09:33:51Z","merged_at":"2018-11-21T09:33:51Z","merge_commit_sha":"9dfd08efe39980be459a7377e4f28da9b07efc7d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ebroecker/canmatrix/pulls/244/commits","review_comments_url":"https://api.github.com/repos/ebroecker/canmatrix/pulls/244/comments","review_comment_url":"https://api.github.com/repos/ebroecker/canmatrix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ebroecker/canmatrix/issues/244/comments","statuses_url":"https://api.github.com/repos/ebroecker/canmatrix/statuses/3db20119d06a328e98329403380b7396a7d8cfa0","head":{"label":"Funth0mas:logger_usage","ref":"logger_usage","sha":"3db20119d06a328e98329403380b7396a7d8cfa0","user":{"login":"Funth0mas","id":43621609,"node_id":"MDQ6VXNlcjQzNjIxNjA5","avatar_url":"https://avatars2.githubusercontent.com/u/43621609?v=4","gravatar_id":"","url":"https://api.github.com/users/Funth0mas","html_url":"https://github.com/Funth0mas","followers_url":"https://api.github.com/users/Funth0mas/followers","following_url":"https://api.github.com/users/Funth0mas/following{/other_user}","gists_url":"https://api.github.com/users/Funth0mas/gists{/gist_id}","starred_url":"https://api.github.com/users/Funth0mas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Funth0mas/subscriptions","organizations_url":"https://api.github.com/users/Funth0mas/orgs","repos_url":"https://api.github.com/users/Funth0mas/repos","events_url":"https://api.github.com/users/Funth0mas/events{/privacy}","received_events_url":"https://api.github.com/users/Funth0mas/received_events","type":"User","site_admin":false},"repo":{"id":150540181,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA1NDAxODE=","name":"canmatrix","full_name":"Funth0mas/canmatrix","private":false,"owner":{"login":"Funth0mas","id":43621609,"node_id":"MDQ6VXNlcjQzNjIxNjA5","avatar_url":"https://avatars2.githubusercontent.com/u/43621609?v=4","gravatar_id":"","url":"https://api.github.com/users/Funth0mas","html_url":"https://github.com/Funth0mas","followers_url":"https://api.github.com/users/Funth0mas/followers","following_url":"https://api.github.com/users/Funth0mas/following{/other_user}","gists_url":"https://api.github.com/users/Funth0mas/gists{/gist_id}","starred_url":"https://api.github.com/users/Funth0mas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Funth0mas/subscriptions","organizations_url":"https://api.github.com/users/Funth0mas/orgs","repos_url":"https://api.github.com/users/Funth0mas/repos","events_url":"https://api.github.com/users/Funth0mas/events{/privacy}","received_events_url":"https://api.github.com/users/Funth0mas/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Funth0mas/canmatrix","description":"Converting Can (Controller Area Network) Database Formats .arxml .dbc .dbf .kcd ...","fork":true,"url":"https://api.github.com/repos/Funth0mas/canmatrix","forks_url":"https://api.github.com/repos/Funth0mas/canmatrix/forks","keys_url":"https://api.github.com/repos/Funth0mas/canmatrix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Funth0mas/canmatrix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Funth0mas/canmatrix/teams","hooks_url":"https://api.github.com/repos/Funth0mas/canmatrix/hooks","issue_events_url":"https://api.github.com/repos/Funth0mas/canmatrix/issues/events{/number}","events_url":"https://api.github.com/repos/Funth0mas/canmatrix/events","assignees_url":"https://api.github.com/repos/Funth0mas/canmatrix/assignees{/user}","branches_url":"https://api.github.com/repos/Funth0mas/canmatrix/branches{/branch}","tags_url":"https://api.github.com/repos/Funth0mas/canmatrix/tags","blobs_url":"https://api.github.com/repos/Funth0mas/canmatrix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Funth0mas/canmatrix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Funth0mas/canmatrix/git/refs{/sha}","trees_url":"https://api.github.com/repos/Funth0mas/canmatrix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Funth0mas/canmatrix/statuses/{sha}","languages_url":"https://api.github.com/repos/Funth0mas/canmatrix/languages","stargazers_url":"https://api.github.com/repos/Funth0mas/canmatrix/stargazers","contributors_url":"https://api.github.com/repos/Funth0mas/canmatrix/contributors","subscribers_url":"https://api.github.com/repos/Funth0mas/canmatrix/subscribers","subscription_url":"https://api.github.com/repos/Funth0mas/canmatrix/subscription","commits_url":"https://api.github.com/repos/Funth0mas/canmatrix/commits{/sha}","git_commits_url":"https://api.github.com/repos/Funth0mas/canmatrix/git/commits{/sha}","comments_url":"https://api.github.com/repos/Funth0mas/canmatrix/comments{/number}","issue_comment_url":"https://api.github.com/repos/Funth0mas/canmatrix/issues/comments{/number}","contents_url":"https://api.github.com/repos/Funth0mas/canmatrix/contents/{+path}","compare_url":"https://api.github.com/repos/Funth0mas/canmatrix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Funth0mas/canmatrix/merges","archive_url":"https://api.github.com/repos/Funth0mas/canmatrix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Funth0mas/canmatrix/downloads","issues_url":"https://api.github.com/repos/Funth0mas/canmatrix/issues{/number}","pulls_url":"https://api.github.com/repos/Funth0mas/canmatrix/pulls{/number}","milestones_url":"https://api.github.com/repos/Funth0mas/canmatrix/milestones{/number}","notifications_url":"https://api.github.com/repos/Funth0mas/canmatrix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Funth0mas/canmatrix/labels{/name}","releases_url":"https://api.github.com/repos/Funth0mas/canmatrix/releases{/id}","deployments_url":"https://api.github.com/repos/Funth0mas/canmatrix/deployments","created_at":"2018-09-27T06:36:37Z","updated_at":"2018-11-20T08:32:10Z","pushed_at":"2018-11-21T08:53:53Z","git_url":"git://github.com/Funth0mas/canmatrix.git","ssh_url":"git@github.com:Funth0mas/canmatrix.git","clone_url":"https://github.com/Funth0mas/canmatrix.git","svn_url":"https://github.com/Funth0mas/canmatrix","homepage":"","size":3581,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"ebroecker:development","ref":"development","sha":"19fd2c53ac22307f6f03750ccf795afcefd80861","user":{"login":"ebroecker","id":4096406,"node_id":"MDQ6VXNlcjQwOTY0MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4096406?v=4","gravatar_id":"","url":"https://api.github.com/users/ebroecker","html_url":"https://github.com/ebroecker","followers_url":"https://api.github.com/users/ebroecker/followers","following_url":"https://api.github.com/users/ebroecker/following{/other_user}","gists_url":"https://api.github.com/users/ebroecker/gists{/gist_id}","starred_url":"https://api.github.com/users/ebroecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebroecker/subscriptions","organizations_url":"https://api.github.com/users/ebroecker/orgs","repos_url":"https://api.github.com/users/ebroecker/repos","events_url":"https://api.github.com/users/ebroecker/events{/privacy}","received_events_url":"https://api.github.com/users/ebroecker/received_events","type":"User","site_admin":false},"repo":{"id":9304497,"node_id":"MDEwOlJlcG9zaXRvcnk5MzA0NDk3","name":"canmatrix","full_name":"ebroecker/canmatrix","private":false,"owner":{"login":"ebroecker","id":4096406,"node_id":"MDQ6VXNlcjQwOTY0MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4096406?v=4","gravatar_id":"","url":"https://api.github.com/users/ebroecker","html_url":"https://github.com/ebroecker","followers_url":"https://api.github.com/users/ebroecker/followers","following_url":"https://api.github.com/users/ebroecker/following{/other_user}","gists_url":"https://api.github.com/users/ebroecker/gists{/gist_id}","starred_url":"https://api.github.com/users/ebroecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebroecker/subscriptions","organizations_url":"https://api.github.com/users/ebroecker/orgs","repos_url":"https://api.github.com/users/ebroecker/repos","events_url":"https://api.github.com/users/ebroecker/events{/privacy}","received_events_url":"https://api.github.com/users/ebroecker/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ebroecker/canmatrix","description":"Converting Can (Controller Area Network) Database Formats .arxml .dbc .dbf .kcd ...","fork":false,"url":"https://api.github.com/repos/ebroecker/canmatrix","forks_url":"https://api.github.com/repos/ebroecker/canmatrix/forks","keys_url":"https://api.github.com/repos/ebroecker/canmatrix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ebroecker/canmatrix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ebroecker/canmatrix/teams","hooks_url":"https://api.github.com/repos/ebroecker/canmatrix/hooks","issue_events_url":"https://api.github.com/repos/ebroecker/canmatrix/issues/events{/number}","events_url":"https://api.github.com/repos/ebroecker/canmatrix/events","assignees_url":"https://api.github.com/repos/ebroecker/canmatrix/assignees{/user}","branches_url":"https://api.github.com/repos/ebroecker/canmatrix/branches{/branch}","tags_url":"https://api.github.com/repos/ebroecker/canmatrix/tags","blobs_url":"https://api.github.com/repos/ebroecker/canmatrix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ebroecker/canmatrix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ebroecker/canmatrix/git/refs{/sha}","trees_url":"https://api.github.com/repos/ebroecker/canmatrix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ebroecker/canmatrix/statuses/{sha}","languages_url":"https://api.github.com/repos/ebroecker/canmatrix/languages","stargazers_url":"https://api.github.com/repos/ebroecker/canmatrix/stargazers","contributors_url":"https://api.github.com/repos/ebroecker/canmatrix/contributors","subscribers_url":"https://api.github.com/repos/ebroecker/canmatrix/subscribers","subscription_url":"https://api.github.com/repos/ebroecker/canmatrix/subscription","commits_url":"https://api.github.com/repos/ebroecker/canmatrix/commits{/sha}","git_commits_url":"https://api.github.com/repos/ebroecker/canmatrix/git/commits{/sha}","comments_url":"https://api.github.com/repos/ebroecker/canmatrix/comments{/number}","issue_comment_url":"https://api.github.com/repos/ebroecker/canmatrix/issues/comments{/number}","contents_url":"https://api.github.com/repos/ebroecker/canmatrix/contents/{+path}","compare_url":"https://api.github.com/repos/ebroecker/canmatrix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ebroecker/canmatrix/merges","archive_url":"https://api.github.com/repos/ebroecker/canmatrix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ebroecker/canmatrix/downloads","issues_url":"https://api.github.com/repos/ebroecker/canmatrix/issues{/number}","pulls_url":"https://api.github.com/repos/ebroecker/canmatrix/pulls{/number}","milestones_url":"https://api.github.com/repos/ebroecker/canmatrix/milestones{/number}","notifications_url":"https://api.github.com/repos/ebroecker/canmatrix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ebroecker/canmatrix/labels{/name}","releases_url":"https://api.github.com/repos/ebroecker/canmatrix/releases{/id}","deployments_url":"https://api.github.com/repos/ebroecker/canmatrix/deployments","created_at":"2013-04-08T19:08:14Z","updated_at":"2018-11-21T08:53:25Z","pushed_at":"2018-11-21T09:33:50Z","git_url":"git://github.com/ebroecker/canmatrix.git","ssh_url":"git@github.com:ebroecker/canmatrix.git","clone_url":"https://github.com/ebroecker/canmatrix.git","svn_url":"https://github.com/ebroecker/canmatrix","homepage":"","size":3630,"stargazers_count":227,"watchers_count":227,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":128,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":128,"open_issues":30,"watchers":227,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/ebroecker/canmatrix/pulls/244"},"html":{"href":"https://github.com/ebroecker/canmatrix/pull/244"},"issue":{"href":"https://api.github.com/repos/ebroecker/canmatrix/issues/244"},"comments":{"href":"https://api.github.com/repos/ebroecker/canmatrix/issues/244/comments"},"review_comments":{"href":"https://api.github.com/repos/ebroecker/canmatrix/pulls/244/comments"},"review_comment":{"href":"https://api.github.com/repos/ebroecker/canmatrix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ebroecker/canmatrix/pulls/244/commits"},"statuses":{"href":"https://api.github.com/repos/ebroecker/canmatrix/statuses/3db20119d06a328e98329403380b7396a7d8cfa0"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ebroecker","id":4096406,"node_id":"MDQ6VXNlcjQwOTY0MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4096406?v=4","gravatar_id":"","url":"https://api.github.com/users/ebroecker","html_url":"https://github.com/ebroecker","followers_url":"https://api.github.com/users/ebroecker/followers","following_url":"https://api.github.com/users/ebroecker/following{/other_user}","gists_url":"https://api.github.com/users/ebroecker/gists{/gist_id}","starred_url":"https://api.github.com/users/ebroecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebroecker/subscriptions","organizations_url":"https://api.github.com/users/ebroecker/orgs","repos_url":"https://api.github.com/users/ebroecker/repos","events_url":"https://api.github.com/users/ebroecker/events{/privacy}","received_events_url":"https://api.github.com/users/ebroecker/received_events","type":"User","site_admin":false},"comments":2,"review_comments":9,"maintainer_can_modify":false,"commits":7,"additions":39,"deletions":26,"changed_files":15}}
{"actor":{"display_login":"ebroecker"}}