{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/201893609","pull_request_review_id":136484625,"id":201893609,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTg5MzYwOQ==","diff_hunk":"@@ -266,26 +272,33 @@ internal SourceText TryReadFileContent(CommandLineSourceFile file, IList<Diagnos\n         /// <param name=\"messageProvider\">Used to produce diagnostics.</param>\n         /// <param name=\"diagnostics\">Any produced diagnostics are added to this bag.</param>\n         /// <returns>\n-        /// A list of diagnostic options, where the dictionary index corresponds\n+        /// A list of diagnostic and analyzer options, where the dictionary index corresponds\n         /// to the options for the source path at the same index. If there are\n-        /// no diagnostic options for the given path, the entry is null. Otherwise,\n-        /// the options are a map from diagnostic ID to diagnostic severity, and\n+        /// no options for the given path, the entry is null. Otherwise, the diagnostic\n+        /// options are a map from diagnostic ID to diagnostic severity, and\n         /// correspond to options provided for <see cref=\"SyntaxTree.DiagnosticOptions\"/>.\n+        /// The analyzerOptions are an OptionSet consisting of all properties that were not\n+        /// diagnostic options.\n         /// </returns>\n-        internal static ImmutableArray<ImmutableDictionary<string, ReportDiagnostic>> GetAnalyzerConfigOptions(\n-            IReadOnlyList<string> sourcePaths,\n-            ArrayBuilder<EditorConfig> analyzerConfigs,\n-            CommonMessageProvider messageProvider,\n-            DiagnosticBag diagnostics)\n+        internal static (ImmutableArray<ImmutableDictionary<string, ReportDiagnostic>> treeOptions,\n+                         ImmutableArray<ImmutableDictionary<string, string>> analyzerOptions)\n+            GetAnalyzerConfigOptions(IReadOnlyList<string> sourcePaths,\n+                                     IReadOnlyList<EditorConfig> analyzerConfigs,\n+                                     CommonMessageProvider messageProvider,\n+                                     DiagnosticBag diagnostics)","path":"src/Compilers/Core/Portable/CommandLine/CommonCompiler.cs","position":57,"original_position":57,"commit_id":"1c412bc965d305d7e46b9783e80f7ca17c014dbb","original_commit_id":"1c412bc965d305d7e46b9783e80f7ca17c014dbb","user":{"login":"CyrusNajmabadi","id":4564579,"node_id":"MDQ6VXNlcjQ1NjQ1Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/4564579?v=4","gravatar_id":"","url":"https://api.github.com/users/CyrusNajmabadi","html_url":"https://github.com/CyrusNajmabadi","followers_url":"https://api.github.com/users/CyrusNajmabadi/followers","following_url":"https://api.github.com/users/CyrusNajmabadi/following{/other_user}","gists_url":"https://api.github.com/users/CyrusNajmabadi/gists{/gist_id}","starred_url":"https://api.github.com/users/CyrusNajmabadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyrusNajmabadi/subscriptions","organizations_url":"https://api.github.com/users/CyrusNajmabadi/orgs","repos_url":"https://api.github.com/users/CyrusNajmabadi/repos","events_url":"https://api.github.com/users/CyrusNajmabadi/events{/privacy}","received_events_url":"https://api.github.com/users/CyrusNajmabadi/received_events","type":"User","site_admin":false},"body":"i had a lot of trouble understanding what this was even parsed as.  perhaps consider a simple named struct for the return type of this method.","created_at":"2018-07-12T02:36:52Z","updated_at":"2018-07-12T02:36:52Z","html_url":"https://github.com/dotnet/roslyn/pull/27397#discussion_r201893609","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/27397","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/201893609"},"html":{"href":"https://github.com/dotnet/roslyn/pull/27397#discussion_r201893609"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/27397"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/27397","id":192286347,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMjg2MzQ3","html_url":"https://github.com/dotnet/roslyn/pull/27397","diff_url":"https://github.com/dotnet/roslyn/pull/27397.diff","patch_url":"https://github.com/dotnet/roslyn/pull/27397.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/27397","number":27397,"state":"open","locked":false,"title":"Add analyzer options threading","user":{"login":"agocke","id":515774,"node_id":"MDQ6VXNlcjUxNTc3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/515774?v=4","gravatar_id":"","url":"https://api.github.com/users/agocke","html_url":"https://github.com/agocke","followers_url":"https://api.github.com/users/agocke/followers","following_url":"https://api.github.com/users/agocke/following{/other_user}","gists_url":"https://api.github.com/users/agocke/gists{/gist_id}","starred_url":"https://api.github.com/users/agocke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agocke/subscriptions","organizations_url":"https://api.github.com/users/agocke/orgs","repos_url":"https://api.github.com/users/agocke/repos","events_url":"https://api.github.com/users/agocke/events{/privacy}","received_events_url":"https://api.github.com/users/agocke/received_events","type":"User","site_admin":false},"body":"This change introduces a new PerTreeOptionsProvider on AnalyzerOptions\r\nso that analyzer can get access to the non-diagnostic information\r\nprovided in analyzer config files. The PerTreeOptionsProvider provides\r\nan OptionSet containing the properties of analzyer config files for a\r\ngiven SyntaxTree.","created_at":"2018-06-04T02:50:59Z","updated_at":"2018-07-12T02:36:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40a20cf3671146b82c1b0c24cc73b1eeb342e6ae","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mavasani","id":10605811,"node_id":"MDQ6VXNlcjEwNjA1ODEx","avatar_url":"https://avatars2.githubusercontent.com/u/10605811?v=4","gravatar_id":"","url":"https://api.github.com/users/mavasani","html_url":"https://github.com/mavasani","followers_url":"https://api.github.com/users/mavasani/followers","following_url":"https://api.github.com/users/mavasani/following{/other_user}","gists_url":"https://api.github.com/users/mavasani/gists{/gist_id}","starred_url":"https://api.github.com/users/mavasani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavasani/subscriptions","organizations_url":"https://api.github.com/users/mavasani/orgs","repos_url":"https://api.github.com/users/mavasani/repos","events_url":"https://api.github.com/users/mavasani/events{/privacy}","received_events_url":"https://api.github.com/users/mavasani/received_events","type":"User","site_admin":false}],"requested_teams":[{"name":"roslyn-interactive","id":1803183,"node_id":"MDQ6VGVhbTE4MDMxODM=","slug":"roslyn-interactive","description":"C# & VB Interactive (scripting, debugging, etc)","privacy":"closed","url":"https://api.github.com/teams/1803183","members_url":"https://api.github.com/teams/1803183/members{/member}","repositories_url":"https://api.github.com/teams/1803183/repos","permission":"pull"}],"labels":[{"id":166673288,"node_id":"MDU6TGFiZWwxNjY2NzMyODg=","url":"https://api.github.com/repos/dotnet/roslyn/labels/Area-Compilers","name":"Area-Compilers","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/27397/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/27397/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/27397/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/1c412bc965d305d7e46b9783e80f7ca17c014dbb","head":{"label":"agocke:add-analyzer-options-threading","ref":"add-analyzer-options-threading","sha":"1c412bc965d305d7e46b9783e80f7ca17c014dbb","user":{"login":"agocke","id":515774,"node_id":"MDQ6VXNlcjUxNTc3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/515774?v=4","gravatar_id":"","url":"https://api.github.com/users/agocke","html_url":"https://github.com/agocke","followers_url":"https://api.github.com/users/agocke/followers","following_url":"https://api.github.com/users/agocke/following{/other_user}","gists_url":"https://api.github.com/users/agocke/gists{/gist_id}","starred_url":"https://api.github.com/users/agocke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agocke/subscriptions","organizations_url":"https://api.github.com/users/agocke/orgs","repos_url":"https://api.github.com/users/agocke/repos","events_url":"https://api.github.com/users/agocke/events{/privacy}","received_events_url":"https://api.github.com/users/agocke/received_events","type":"User","site_admin":false},"repo":{"id":30560754,"node_id":"MDEwOlJlcG9zaXRvcnkzMDU2MDc1NA==","name":"roslyn","full_name":"agocke/roslyn","owner":{"login":"agocke","id":515774,"node_id":"MDQ6VXNlcjUxNTc3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/515774?v=4","gravatar_id":"","url":"https://api.github.com/users/agocke","html_url":"https://github.com/agocke","followers_url":"https://api.github.com/users/agocke/followers","following_url":"https://api.github.com/users/agocke/following{/other_user}","gists_url":"https://api.github.com/users/agocke/gists{/gist_id}","starred_url":"https://api.github.com/users/agocke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agocke/subscriptions","organizations_url":"https://api.github.com/users/agocke/orgs","repos_url":"https://api.github.com/users/agocke/repos","events_url":"https://api.github.com/users/agocke/events{/privacy}","received_events_url":"https://api.github.com/users/agocke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/agocke/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/agocke/roslyn","forks_url":"https://api.github.com/repos/agocke/roslyn/forks","keys_url":"https://api.github.com/repos/agocke/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agocke/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agocke/roslyn/teams","hooks_url":"https://api.github.com/repos/agocke/roslyn/hooks","issue_events_url":"https://api.github.com/repos/agocke/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/agocke/roslyn/events","assignees_url":"https://api.github.com/repos/agocke/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/agocke/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/agocke/roslyn/tags","blobs_url":"https://api.github.com/repos/agocke/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agocke/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agocke/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/agocke/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agocke/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/agocke/roslyn/languages","stargazers_url":"https://api.github.com/repos/agocke/roslyn/stargazers","contributors_url":"https://api.github.com/repos/agocke/roslyn/contributors","subscribers_url":"https://api.github.com/repos/agocke/roslyn/subscribers","subscription_url":"https://api.github.com/repos/agocke/roslyn/subscription","commits_url":"https://api.github.com/repos/agocke/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/agocke/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/agocke/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/agocke/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/agocke/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/agocke/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agocke/roslyn/merges","archive_url":"https://api.github.com/repos/agocke/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agocke/roslyn/downloads","issues_url":"https://api.github.com/repos/agocke/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/agocke/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/agocke/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/agocke/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agocke/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/agocke/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/agocke/roslyn/deployments","created_at":"2015-02-09T21:57:03Z","updated_at":"2018-05-11T06:03:22Z","pushed_at":"2018-07-11T21:36:19Z","git_url":"git://github.com/agocke/roslyn.git","ssh_url":"git@github.com:agocke/roslyn.git","clone_url":"https://github.com/agocke/roslyn.git","svn_url":"https://github.com/agocke/roslyn","homepage":"","size":357658,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dotnet:features/editorconfig-in-compiler","ref":"features/editorconfig-in-compiler","sha":"21ca9b9f5876192f4586ba2bc13e6c9d458c8db7","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"node_id":"MDEwOlJlcG9zaXRvcnkyOTA3ODk5Nw==","name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2018-07-11T21:01:22Z","pushed_at":"2018-07-12T02:36:27Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":411562,"stargazers_count":9551,"watchers_count":9551,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2274,"mirror_url":null,"archived":false,"open_issues_count":4916,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2274,"open_issues":4916,"watchers":9551,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/27397"},"html":{"href":"https://github.com/dotnet/roslyn/pull/27397"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/27397"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/27397/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/27397/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/27397/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/1c412bc965d305d7e46b9783e80f7ca17c014dbb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"CyrusNajmabadi"}}