{"action":"created","comment":{"url":"https://api.github.com/repos/ulaval/modul-components/pulls/comments/183043059","pull_request_review_id":113967968,"id":183043059,"diff_hunk":"@@ -0,0 +1,39 @@\n+import Vue, { DirectiveOptions, PluginObject, VNode, VNodeDirective } from 'vue';\n+import { I_18_N } from '../directive-names';\n+import { Messages } from '../../utils/i18n/i18n';\n+\n+const I18nDirective: DirectiveOptions = {\n+    bind(\n+        el: HTMLElement,\n+        binding: VNodeDirective,\n+        vnode: VNode\n+    ): void {\n+        if (binding.arg) {\n+            let expression = binding.expression;\n+            const modifiers: string[] = Object.getOwnPropertyNames(binding.modifiers);\n+            const options = binding.value || {};\n+\n+            if (modifiers.length > 0) {\n+                // do not use modifiers out of expression (like \"medaille-olympique.f\")\n+                // const modifier = options.modifier ? options.modifier : modifiers[1];","path":"src/directives/i18n/i18n.ts","position":18,"original_position":18,"commit_id":"f3f3817a999ad5ab898b06f574ff8e706aed9409","original_commit_id":"f3f3817a999ad5ab898b06f574ff8e706aed9409","user":{"login":"gabra20","id":38441217,"avatar_url":"https://avatars1.githubusercontent.com/u/38441217?v=4","gravatar_id":"","url":"https://api.github.com/users/gabra20","html_url":"https://github.com/gabra20","followers_url":"https://api.github.com/users/gabra20/followers","following_url":"https://api.github.com/users/gabra20/following{/other_user}","gists_url":"https://api.github.com/users/gabra20/gists{/gist_id}","starred_url":"https://api.github.com/users/gabra20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabra20/subscriptions","organizations_url":"https://api.github.com/users/gabra20/orgs","repos_url":"https://api.github.com/users/gabra20/repos","events_url":"https://api.github.com/users/gabra20/events{/privacy}","received_events_url":"https://api.github.com/users/gabra20/received_events","type":"User","site_admin":false},"body":"oui c'est ça, c'est en rapport. je vais mettre le même commentaire que dans le test pour que ce soit plus clair? ou alors je supprime la ligne, ça devrait pas être compliqué a retrouver ;-)","created_at":"2018-04-20T13:05:35Z","updated_at":"2018-04-20T13:05:35Z","html_url":"https://github.com/ulaval/modul-components/pull/197#discussion_r183043059","pull_request_url":"https://api.github.com/repos/ulaval/modul-components/pulls/197","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ulaval/modul-components/pulls/comments/183043059"},"html":{"href":"https://github.com/ulaval/modul-components/pull/197#discussion_r183043059"},"pull_request":{"href":"https://api.github.com/repos/ulaval/modul-components/pulls/197"}},"in_reply_to_id":182867949},"pull_request":{"url":"https://api.github.com/repos/ulaval/modul-components/pulls/197","id":182184752,"html_url":"https://github.com/ulaval/modul-components/pull/197","diff_url":"https://github.com/ulaval/modul-components/pull/197.diff","patch_url":"https://github.com/ulaval/modul-components/pull/197.patch","issue_url":"https://api.github.com/repos/ulaval/modul-components/issues/197","number":197,"state":"open","locked":false,"title":"Feature/ena2 724 optimiser i18n","user":{"login":"gabra20","id":38441217,"avatar_url":"https://avatars1.githubusercontent.com/u/38441217?v=4","gravatar_id":"","url":"https://api.github.com/users/gabra20","html_url":"https://github.com/gabra20","followers_url":"https://api.github.com/users/gabra20/followers","following_url":"https://api.github.com/users/gabra20/following{/other_user}","gists_url":"https://api.github.com/users/gabra20/gists{/gist_id}","starred_url":"https://api.github.com/users/gabra20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabra20/subscriptions","organizations_url":"https://api.github.com/users/gabra20/orgs","repos_url":"https://api.github.com/users/gabra20/repos","events_url":"https://api.github.com/users/gabra20/events{/privacy}","received_events_url":"https://api.github.com/users/gabra20/received_events","type":"User","site_admin":false},"body":"## `@ulaval/modul-components`\r\n# PR Checklist\r\n\r\n- [x ] Provide a small description of the changes introduced by this PR\r\n  optimiser la gestion des tradutions (i18n)\r\n- [x ] Include links to issues\r\nhttps://jira.dti.ulaval.ca/browse/ENA2-724\r\nhttps://jira.dti.ulaval.ca/browse/MODUL-82","created_at":"2018-04-17T14:26:48Z","updated_at":"2018-04-20T13:05:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bef03f9affe90329d23621f2fdad1a6f701eab1d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ulaval/modul-components/pulls/197/commits","review_comments_url":"https://api.github.com/repos/ulaval/modul-components/pulls/197/comments","review_comment_url":"https://api.github.com/repos/ulaval/modul-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ulaval/modul-components/issues/197/comments","statuses_url":"https://api.github.com/repos/ulaval/modul-components/statuses/f3f3817a999ad5ab898b06f574ff8e706aed9409","head":{"label":"ulaval:feature/ENA2-724_optimiserI18n","ref":"feature/ENA2-724_optimiserI18n","sha":"f3f3817a999ad5ab898b06f574ff8e706aed9409","user":{"login":"ulaval","id":28366814,"avatar_url":"https://avatars2.githubusercontent.com/u/28366814?v=4","gravatar_id":"","url":"https://api.github.com/users/ulaval","html_url":"https://github.com/ulaval","followers_url":"https://api.github.com/users/ulaval/followers","following_url":"https://api.github.com/users/ulaval/following{/other_user}","gists_url":"https://api.github.com/users/ulaval/gists{/gist_id}","starred_url":"https://api.github.com/users/ulaval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulaval/subscriptions","organizations_url":"https://api.github.com/users/ulaval/orgs","repos_url":"https://api.github.com/users/ulaval/repos","events_url":"https://api.github.com/users/ulaval/events{/privacy}","received_events_url":"https://api.github.com/users/ulaval/received_events","type":"Organization","site_admin":false},"repo":{"id":91692643,"name":"modul-components","full_name":"ulaval/modul-components","owner":{"login":"ulaval","id":28366814,"avatar_url":"https://avatars2.githubusercontent.com/u/28366814?v=4","gravatar_id":"","url":"https://api.github.com/users/ulaval","html_url":"https://github.com/ulaval","followers_url":"https://api.github.com/users/ulaval/followers","following_url":"https://api.github.com/users/ulaval/following{/other_user}","gists_url":"https://api.github.com/users/ulaval/gists{/gist_id}","starred_url":"https://api.github.com/users/ulaval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulaval/subscriptions","organizations_url":"https://api.github.com/users/ulaval/orgs","repos_url":"https://api.github.com/users/ulaval/repos","events_url":"https://api.github.com/users/ulaval/events{/privacy}","received_events_url":"https://api.github.com/users/ulaval/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ulaval/modul-components","description":"Library of VueJS components.","fork":false,"url":"https://api.github.com/repos/ulaval/modul-components","forks_url":"https://api.github.com/repos/ulaval/modul-components/forks","keys_url":"https://api.github.com/repos/ulaval/modul-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ulaval/modul-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ulaval/modul-components/teams","hooks_url":"https://api.github.com/repos/ulaval/modul-components/hooks","issue_events_url":"https://api.github.com/repos/ulaval/modul-components/issues/events{/number}","events_url":"https://api.github.com/repos/ulaval/modul-components/events","assignees_url":"https://api.github.com/repos/ulaval/modul-components/assignees{/user}","branches_url":"https://api.github.com/repos/ulaval/modul-components/branches{/branch}","tags_url":"https://api.github.com/repos/ulaval/modul-components/tags","blobs_url":"https://api.github.com/repos/ulaval/modul-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ulaval/modul-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ulaval/modul-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/ulaval/modul-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ulaval/modul-components/statuses/{sha}","languages_url":"https://api.github.com/repos/ulaval/modul-components/languages","stargazers_url":"https://api.github.com/repos/ulaval/modul-components/stargazers","contributors_url":"https://api.github.com/repos/ulaval/modul-components/contributors","subscribers_url":"https://api.github.com/repos/ulaval/modul-components/subscribers","subscription_url":"https://api.github.com/repos/ulaval/modul-components/subscription","commits_url":"https://api.github.com/repos/ulaval/modul-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/ulaval/modul-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/ulaval/modul-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/ulaval/modul-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/ulaval/modul-components/contents/{+path}","compare_url":"https://api.github.com/repos/ulaval/modul-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ulaval/modul-components/merges","archive_url":"https://api.github.com/repos/ulaval/modul-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ulaval/modul-components/downloads","issues_url":"https://api.github.com/repos/ulaval/modul-components/issues{/number}","pulls_url":"https://api.github.com/repos/ulaval/modul-components/pulls{/number}","milestones_url":"https://api.github.com/repos/ulaval/modul-components/milestones{/number}","notifications_url":"https://api.github.com/repos/ulaval/modul-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ulaval/modul-components/labels{/name}","releases_url":"https://api.github.com/repos/ulaval/modul-components/releases{/id}","deployments_url":"https://api.github.com/repos/ulaval/modul-components/deployments","created_at":"2017-05-18T12:49:44Z","updated_at":"2018-04-16T13:26:57Z","pushed_at":"2018-04-19T19:18:45Z","git_url":"git://github.com/ulaval/modul-components.git","ssh_url":"git@github.com:ulaval/modul-components.git","clone_url":"https://github.com/ulaval/modul-components.git","svn_url":"https://github.com/ulaval/modul-components","homepage":null,"size":6334,"stargazers_count":10,"watchers_count":10,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":5,"open_issues":32,"watchers":10,"default_branch":"develop"}},"base":{"label":"ulaval:develop","ref":"develop","sha":"d8d276a7a2782c9ef327e8c0bbaf4edcdbdfd473","user":{"login":"ulaval","id":28366814,"avatar_url":"https://avatars2.githubusercontent.com/u/28366814?v=4","gravatar_id":"","url":"https://api.github.com/users/ulaval","html_url":"https://github.com/ulaval","followers_url":"https://api.github.com/users/ulaval/followers","following_url":"https://api.github.com/users/ulaval/following{/other_user}","gists_url":"https://api.github.com/users/ulaval/gists{/gist_id}","starred_url":"https://api.github.com/users/ulaval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulaval/subscriptions","organizations_url":"https://api.github.com/users/ulaval/orgs","repos_url":"https://api.github.com/users/ulaval/repos","events_url":"https://api.github.com/users/ulaval/events{/privacy}","received_events_url":"https://api.github.com/users/ulaval/received_events","type":"Organization","site_admin":false},"repo":{"id":91692643,"name":"modul-components","full_name":"ulaval/modul-components","owner":{"login":"ulaval","id":28366814,"avatar_url":"https://avatars2.githubusercontent.com/u/28366814?v=4","gravatar_id":"","url":"https://api.github.com/users/ulaval","html_url":"https://github.com/ulaval","followers_url":"https://api.github.com/users/ulaval/followers","following_url":"https://api.github.com/users/ulaval/following{/other_user}","gists_url":"https://api.github.com/users/ulaval/gists{/gist_id}","starred_url":"https://api.github.com/users/ulaval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulaval/subscriptions","organizations_url":"https://api.github.com/users/ulaval/orgs","repos_url":"https://api.github.com/users/ulaval/repos","events_url":"https://api.github.com/users/ulaval/events{/privacy}","received_events_url":"https://api.github.com/users/ulaval/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ulaval/modul-components","description":"Library of VueJS components.","fork":false,"url":"https://api.github.com/repos/ulaval/modul-components","forks_url":"https://api.github.com/repos/ulaval/modul-components/forks","keys_url":"https://api.github.com/repos/ulaval/modul-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ulaval/modul-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ulaval/modul-components/teams","hooks_url":"https://api.github.com/repos/ulaval/modul-components/hooks","issue_events_url":"https://api.github.com/repos/ulaval/modul-components/issues/events{/number}","events_url":"https://api.github.com/repos/ulaval/modul-components/events","assignees_url":"https://api.github.com/repos/ulaval/modul-components/assignees{/user}","branches_url":"https://api.github.com/repos/ulaval/modul-components/branches{/branch}","tags_url":"https://api.github.com/repos/ulaval/modul-components/tags","blobs_url":"https://api.github.com/repos/ulaval/modul-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ulaval/modul-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ulaval/modul-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/ulaval/modul-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ulaval/modul-components/statuses/{sha}","languages_url":"https://api.github.com/repos/ulaval/modul-components/languages","stargazers_url":"https://api.github.com/repos/ulaval/modul-components/stargazers","contributors_url":"https://api.github.com/repos/ulaval/modul-components/contributors","subscribers_url":"https://api.github.com/repos/ulaval/modul-components/subscribers","subscription_url":"https://api.github.com/repos/ulaval/modul-components/subscription","commits_url":"https://api.github.com/repos/ulaval/modul-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/ulaval/modul-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/ulaval/modul-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/ulaval/modul-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/ulaval/modul-components/contents/{+path}","compare_url":"https://api.github.com/repos/ulaval/modul-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ulaval/modul-components/merges","archive_url":"https://api.github.com/repos/ulaval/modul-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ulaval/modul-components/downloads","issues_url":"https://api.github.com/repos/ulaval/modul-components/issues{/number}","pulls_url":"https://api.github.com/repos/ulaval/modul-components/pulls{/number}","milestones_url":"https://api.github.com/repos/ulaval/modul-components/milestones{/number}","notifications_url":"https://api.github.com/repos/ulaval/modul-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ulaval/modul-components/labels{/name}","releases_url":"https://api.github.com/repos/ulaval/modul-components/releases{/id}","deployments_url":"https://api.github.com/repos/ulaval/modul-components/deployments","created_at":"2017-05-18T12:49:44Z","updated_at":"2018-04-16T13:26:57Z","pushed_at":"2018-04-19T19:18:45Z","git_url":"git://github.com/ulaval/modul-components.git","ssh_url":"git@github.com:ulaval/modul-components.git","clone_url":"https://github.com/ulaval/modul-components.git","svn_url":"https://github.com/ulaval/modul-components","homepage":null,"size":6334,"stargazers_count":10,"watchers_count":10,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":5,"open_issues":32,"watchers":10,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ulaval/modul-components/pulls/197"},"html":{"href":"https://github.com/ulaval/modul-components/pull/197"},"issue":{"href":"https://api.github.com/repos/ulaval/modul-components/issues/197"},"comments":{"href":"https://api.github.com/repos/ulaval/modul-components/issues/197/comments"},"review_comments":{"href":"https://api.github.com/repos/ulaval/modul-components/pulls/197/comments"},"review_comment":{"href":"https://api.github.com/repos/ulaval/modul-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ulaval/modul-components/pulls/197/commits"},"statuses":{"href":"https://api.github.com/repos/ulaval/modul-components/statuses/f3f3817a999ad5ab898b06f574ff8e706aed9409"}},"author_association":"NONE"}}
{"actor":{"display_login":"gabra20"}}