{"action":"created","issue":{"url":"https://api.github.com/repos/mariozaizar/language-eml/issues/15","repository_url":"https://api.github.com/repos/mariozaizar/language-eml","labels_url":"https://api.github.com/repos/mariozaizar/language-eml/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/mariozaizar/language-eml/issues/15/comments","events_url":"https://api.github.com/repos/mariozaizar/language-eml/issues/15/events","html_url":"https://github.com/mariozaizar/language-eml/issues/15","id":350445592,"node_id":"MDU6SXNzdWUzNTA0NDU1OTI=","number":15,"title":"Quoted-printable encoding unrecognized on GitHub","user":{"login":"pchaigno","id":1764210,"node_id":"MDQ6VXNlcjE3NjQyMTA=","avatar_url":"https://avatars2.githubusercontent.com/u/1764210?v=4","gravatar_id":"","url":"https://api.github.com/users/pchaigno","html_url":"https://github.com/pchaigno","followers_url":"https://api.github.com/users/pchaigno/followers","following_url":"https://api.github.com/users/pchaigno/following{/other_user}","gists_url":"https://api.github.com/users/pchaigno/gists{/gist_id}","starred_url":"https://api.github.com/users/pchaigno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pchaigno/subscriptions","organizations_url":"https://api.github.com/users/pchaigno/orgs","repos_url":"https://api.github.com/users/pchaigno/repos","events_url":"https://api.github.com/users/pchaigno/events{/privacy}","received_events_url":"https://api.github.com/users/pchaigno/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-08-14T14:09:45Z","updated_at":"2018-09-24T23:16:13Z","closed_at":null,"author_association":"NONE","body":"### Prerequisites\r\n\r\n*I haven't reproduced the issue in Atom. Please see the description.*\r\n* [ ] Put an X between the brackets on this line if you have done all of the following:\r\n    * Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode\r\n    * Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/\r\n    * Checked that your issue isn't already filed: https://github.com/mariozaizar/language-eml/issues\r\n\r\n### Description\r\n\r\nWe're considering (cf. github/linguist#4201) using this EML grammar to highlight all `.eml` and `.mbox` files on GitHub and GitLab. Unfortunately, the grammar's output has some errors (see [Lightshow example](https://github-lightshow.herokuapp.com/?utf8=%E2%9C%93&scope=from-url&grammar_format=auto&grammar_url=https%3A%2F%2Fgithub.com%2Fmariozaizar%2Flanguage-eml%2Fblob%2Fmaster%2Fgrammars%2Flanguage-eml.cson&grammar_text=&code_source=from-url&code_url=https%3A%2F%2Fgithub.com%2Fmariozaizar%2Flanguage-eml%2Fblob%2F894a2697e04b0448c0d92e9c346586e193bcedf0%2Fspec%2Ffixtures%2Fwindows-1251.eml&code=)) for [quoted-printable encoding](https://stackoverflow.com/a/4016098/6884590) (if that's not obvious, I don't know much about EML).\r\n\r\nI haven't tested under Atom yet, so it's possible the issue is only with GitHub's interpreter for grammars. GitHub uses a PCRE-based regular expression engine, which has a few differences in interpretation. I had a quick look at the grammar and did not spotted any though.\r\n\r\n### Steps to Reproduce\r\n\r\n1. Try to highlight a EML file containing quoted-printable encoding [with Lightshow](https://github-lightshow.herokuapp.com/?utf8=%E2%9C%93&scope=from-url&grammar_format=auto&grammar_url=https%3A%2F%2Fgithub.com%2Fmariozaizar%2Flanguage-eml%2Fblob%2Fmaster%2Fgrammars%2Flanguage-eml.cson&grammar_text=&code_source=from-url&code_url=https%3A%2F%2Fgithub.com%2Fmariozaizar%2Flanguage-eml%2Fblob%2F894a2697e04b0448c0d92e9c346586e193bcedf0%2Fspec%2Ffixtures%2Fwindows-1251.eml&code=).\r\n\r\n**Expected behavior:** Characters following the quoted-printable marker (`=3D`) to be highlighted correctly.\r\n\r\n**Actual behavior:** Characters following the quoted-printable marker are highlighted with a red background.\r\n\r\n**Reproduces how often:** 100%\r\n\r\n### Versions\r\n\r\nThe highlighting bug happens with commit c9f354e of the present grammar.\r\n\r\n### Additional Information\r\n\r\nLightshow is a simple interface to test the highlighter used on GitHub.com. It simply takes the grammar provided and interprets it on the given example."},"comment":{"url":"https://api.github.com/repos/mariozaizar/language-eml/issues/comments/424156168","html_url":"https://github.com/mariozaizar/language-eml/issues/15#issuecomment-424156168","issue_url":"https://api.github.com/repos/mariozaizar/language-eml/issues/15","id":424156168,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDE1NjE2OA==","user":{"login":"Alhadis","id":2346707,"node_id":"MDQ6VXNlcjIzNDY3MDc=","avatar_url":"https://avatars0.githubusercontent.com/u/2346707?v=4","gravatar_id":"","url":"https://api.github.com/users/Alhadis","html_url":"https://github.com/Alhadis","followers_url":"https://api.github.com/users/Alhadis/followers","following_url":"https://api.github.com/users/Alhadis/following{/other_user}","gists_url":"https://api.github.com/users/Alhadis/gists{/gist_id}","starred_url":"https://api.github.com/users/Alhadis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alhadis/subscriptions","organizations_url":"https://api.github.com/users/Alhadis/orgs","repos_url":"https://api.github.com/users/Alhadis/repos","events_url":"https://api.github.com/users/Alhadis/events{/privacy}","received_events_url":"https://api.github.com/users/Alhadis/received_events","type":"User","site_admin":false},"created_at":"2018-09-24T23:16:13Z","updated_at":"2018-09-24T23:16:13Z","author_association":"NONE","body":"The expressions aren't the problem. [This is](https://github.com/mariozaizar/language-eml/blob/c9f354e6b33b4d4de73668be4660e6519a32e51d/grammars/language-eml.cson#L98):\r\n\r\n~~~cson\r\n# Content-Type: text/html;\r\n{\r\n\t'match': '^(?i)<html>(.|\\s)*<\\/html>$',\r\n\t'include': 'text.html.basic'\r\n},\r\n~~~\r\n\r\nWe're still using the [old TextMate grammar](https://github.com/textmate/html.tmbundle) for HTML highlighting, which is the likely culprit. Ergo, we have two choices:\r\n\r\n1. Submit a fix upstream\r\n2. Switch to Atom's grammar for HTML highlighting (recommended)"}}
{"actor":{"display_login":"Alhadis"}}