{"action":"created","comment":{"url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/pulls/comments/212887243","pull_request_review_id":149601689,"id":212887243,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjg4NzI0Mw==","diff_hunk":"@@ -0,0 +1,139 @@\n+.civicase__table--caselist {\n+  .fixed-col {\n+    .label {\n+      font-size: 0.8em;\n+    }\n+  }\n+\n+  .crm_notification-badge {\n+    line-height: 18px;\n+    padding: 0 10px;\n+  }\n+\n+  &__header {\n+    &.affix {","path":"scss/components/_case-list-table.scss","position":14,"original_position":14,"commit_id":"92a5764542206349cf93b211676b3c92fac54512","original_commit_id":"92a5764542206349cf93b211676b3c92fac54512","user":{"login":"deb1990","id":5058867,"node_id":"MDQ6VXNlcjUwNTg4Njc=","avatar_url":"https://avatars1.githubusercontent.com/u/5058867?v=4","gravatar_id":"","url":"https://api.github.com/users/deb1990","html_url":"https://github.com/deb1990","followers_url":"https://api.github.com/users/deb1990/followers","following_url":"https://api.github.com/users/deb1990/following{/other_user}","gists_url":"https://api.github.com/users/deb1990/gists{/gist_id}","starred_url":"https://api.github.com/users/deb1990/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deb1990/subscriptions","organizations_url":"https://api.github.com/users/deb1990/orgs","repos_url":"https://api.github.com/users/deb1990/repos","events_url":"https://api.github.com/users/deb1990/events{/privacy}","received_events_url":"https://api.github.com/users/deb1990/received_events","type":"User","site_admin":false},"body":"What is the usage of `affix` class?","created_at":"2018-08-27T07:27:57Z","updated_at":"2018-08-27T07:39:46Z","html_url":"https://github.com/compucorp/uk.co.compucorp.civicase/pull/7#discussion_r212887243","pull_request_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/pulls/7","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/pulls/comments/212887243"},"html":{"href":"https://github.com/compucorp/uk.co.compucorp.civicase/pull/7#discussion_r212887243"},"pull_request":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/pulls/7","id":210735274,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNzM1Mjc0","html_url":"https://github.com/compucorp/uk.co.compucorp.civicase/pull/7","diff_url":"https://github.com/compucorp/uk.co.compucorp.civicase/pull/7.diff","patch_url":"https://github.com/compucorp/uk.co.compucorp.civicase/pull/7.patch","issue_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/issues/7","number":7,"state":"open","locked":false,"title":"C51 38: Update html for case list table","user":{"login":"swastikpareek","id":3340537,"node_id":"MDQ6VXNlcjMzNDA1Mzc=","avatar_url":"https://avatars0.githubusercontent.com/u/3340537?v=4","gravatar_id":"","url":"https://api.github.com/users/swastikpareek","html_url":"https://github.com/swastikpareek","followers_url":"https://api.github.com/users/swastikpareek/followers","following_url":"https://api.github.com/users/swastikpareek/following{/other_user}","gists_url":"https://api.github.com/users/swastikpareek/gists{/gist_id}","starred_url":"https://api.github.com/users/swastikpareek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swastikpareek/subscriptions","organizations_url":"https://api.github.com/users/swastikpareek/orgs","repos_url":"https://api.github.com/users/swastikpareek/repos","events_url":"https://api.github.com/users/swastikpareek/events{/privacy}","received_events_url":"https://api.github.com/users/swastikpareek/received_events","type":"User","site_admin":false},"body":"## Overview\r\nPR contains following features integration/fixes\r\n * Changed class from `case-list-table` to `table` - based upon shoreditch style guide\r\n * Sticky header bug fix for case list table\r\n * Improved HTML to follow BEM sturcture\r\n * Refactored part of css to scss from `caselist.css` to `_case-list-tables.scss`\r\n * Added sticky footer functionality to case list table\r\n * Changed badge class to `crm_notification-badge` - based upon shoreditch styleguide\r\n * Update pager styles to match new designs\r\n\r\n## Before\r\n \r\n<img width=\"1680\" alt=\"c51-38 - before\" src=\"https://user-images.githubusercontent.com/3340537/44586038-f8d97280-a7cb-11e8-9d58-90e3f401819f.png\">\r\n\r\n## After\r\n<img width=\"1680\" alt=\"c51-38 - after\" src=\"https://user-images.githubusercontent.com/3340537/44586062-0989e880-a7cc-11e8-93ed-9cdd51e5d62d.png\">\r\n\r\n## Technical Details\r\n * Created `_case-list-tables.scss` inside scss/component which contains sass related to the case list table\r\n * Added `table civicase__table--caselist`. This is based upon BEM guidelines\r\n * Added `civicase__table--caselist__header` to `<thead>` and `civicase__table--caselist__body` to `<tbody>` - BEM guidelines\r\n * Added `stickyTableHeader` directive for making the table header sticky when user scrolls the page down in `civicase/Util.js`.\r\n * Added `stickyFooterPager` directive in  `civicase/Util.js` for the sticky footer pager feature. \r\n  *Logic* - Adds `civicase__pager--fixed` class to the pager if it is not in the screen view, which through css adds `position: fixed` (with some extra styles) to the pager to make it sticky to the bottom\r\n * Pager related styles resides under `scss/components/_case-pager.scss` file\r\n * Refactored most of the styles under `caseList.css` and moved them to '_case-list-tables.scss' file. \r\n * Many css selectors were having long unneccessary long selectors which can be reduced in size and converted into sass \r\n   e.g. \r\n\r\n```css\r\n#bootstrap-theme :not(.viewing-case) .scrolling .custom-scroll-wrapper .custom-scroll\r\n```\r\n\r\n```scss\r\n.case-list-panel:not(.viewing-case) {\r\n  ........\r\n   .custom-scroll-wrapper {\r\n    border: 0;\r\n    margin-left: 310px;\r\n    overflow-x: scroll;\r\n    overflow-y: hidden;\r\n    width: calc(100% - 310px);\r\n  }\r\n}\r\n```\r\n* After changing the table class from `case-list-table` to `table` the unused css like \r\n\r\n```css\r\n#bootstrap-theme :not(.viewing-case) .scrolling table.case-list-table thead.affix\r\n\r\n#bootstrap-theme :not(.viewing-case) .scrolling table.case-list-table \r\n```\r\nare also removed as a part of this ticket.\r\n\r\n## Comments\r\n * Test cases for newly added directives are still pending.","created_at":"2018-08-24T13:07:12Z","updated_at":"2018-08-27T07:39:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"864dc9a8cfd78d1ec75b2ac40c2b2b41d6af0a4f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/pulls/7/commits","review_comments_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/pulls/7/comments","review_comment_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/pulls/comments{/number}","comments_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/issues/7/comments","statuses_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/statuses/92a5764542206349cf93b211676b3c92fac54512","head":{"label":"compucorp:C51-38-update-html-for-table","ref":"C51-38-update-html-for-table","sha":"92a5764542206349cf93b211676b3c92fac54512","user":{"login":"compucorp","id":2040164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDAxNjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2040164?v=4","gravatar_id":"","url":"https://api.github.com/users/compucorp","html_url":"https://github.com/compucorp","followers_url":"https://api.github.com/users/compucorp/followers","following_url":"https://api.github.com/users/compucorp/following{/other_user}","gists_url":"https://api.github.com/users/compucorp/gists{/gist_id}","starred_url":"https://api.github.com/users/compucorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compucorp/subscriptions","organizations_url":"https://api.github.com/users/compucorp/orgs","repos_url":"https://api.github.com/users/compucorp/repos","events_url":"https://api.github.com/users/compucorp/events{/privacy}","received_events_url":"https://api.github.com/users/compucorp/received_events","type":"Organization","site_admin":false},"repo":{"id":143011708,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMwMTE3MDg=","name":"uk.co.compucorp.civicase","full_name":"compucorp/uk.co.compucorp.civicase","owner":{"login":"compucorp","id":2040164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDAxNjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2040164?v=4","gravatar_id":"","url":"https://api.github.com/users/compucorp","html_url":"https://github.com/compucorp","followers_url":"https://api.github.com/users/compucorp/followers","following_url":"https://api.github.com/users/compucorp/following{/other_user}","gists_url":"https://api.github.com/users/compucorp/gists{/gist_id}","starred_url":"https://api.github.com/users/compucorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compucorp/subscriptions","organizations_url":"https://api.github.com/users/compucorp/orgs","repos_url":"https://api.github.com/users/compucorp/repos","events_url":"https://api.github.com/users/compucorp/events{/privacy}","received_events_url":"https://api.github.com/users/compucorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/compucorp/uk.co.compucorp.civicase","description":"CiviCase Extension","fork":true,"url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase","forks_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/forks","keys_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/keys{/key_id}","collaborators_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/teams","hooks_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/hooks","issue_events_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/issues/events{/number}","events_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/events","assignees_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/assignees{/user}","branches_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/branches{/branch}","tags_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/tags","blobs_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/git/refs{/sha}","trees_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/git/trees{/sha}","statuses_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/statuses/{sha}","languages_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/languages","stargazers_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/stargazers","contributors_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/contributors","subscribers_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/subscribers","subscription_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/subscription","commits_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/commits{/sha}","git_commits_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/git/commits{/sha}","comments_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/comments{/number}","issue_comment_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/issues/comments{/number}","contents_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/contents/{+path}","compare_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/compare/{base}...{head}","merges_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/merges","archive_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/downloads","issues_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/issues{/number}","pulls_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/pulls{/number}","milestones_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/milestones{/number}","notifications_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/labels{/name}","releases_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/releases{/id}","deployments_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/deployments","created_at":"2018-07-31T12:33:33Z","updated_at":"2018-08-15T11:40:22Z","pushed_at":"2018-08-27T06:34:50Z","git_url":"git://github.com/compucorp/uk.co.compucorp.civicase.git","ssh_url":"git@github.com:compucorp/uk.co.compucorp.civicase.git","clone_url":"https://github.com/compucorp/uk.co.compucorp.civicase.git","svn_url":"https://github.com/compucorp/uk.co.compucorp.civicase","homepage":null,"size":1477,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"compucorp:develop","ref":"develop","sha":"ea604092ee6dd83b44e4c62cbcb24dd2d10e6c4f","user":{"login":"compucorp","id":2040164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDAxNjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2040164?v=4","gravatar_id":"","url":"https://api.github.com/users/compucorp","html_url":"https://github.com/compucorp","followers_url":"https://api.github.com/users/compucorp/followers","following_url":"https://api.github.com/users/compucorp/following{/other_user}","gists_url":"https://api.github.com/users/compucorp/gists{/gist_id}","starred_url":"https://api.github.com/users/compucorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compucorp/subscriptions","organizations_url":"https://api.github.com/users/compucorp/orgs","repos_url":"https://api.github.com/users/compucorp/repos","events_url":"https://api.github.com/users/compucorp/events{/privacy}","received_events_url":"https://api.github.com/users/compucorp/received_events","type":"Organization","site_admin":false},"repo":{"id":143011708,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMwMTE3MDg=","name":"uk.co.compucorp.civicase","full_name":"compucorp/uk.co.compucorp.civicase","owner":{"login":"compucorp","id":2040164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDAxNjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2040164?v=4","gravatar_id":"","url":"https://api.github.com/users/compucorp","html_url":"https://github.com/compucorp","followers_url":"https://api.github.com/users/compucorp/followers","following_url":"https://api.github.com/users/compucorp/following{/other_user}","gists_url":"https://api.github.com/users/compucorp/gists{/gist_id}","starred_url":"https://api.github.com/users/compucorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compucorp/subscriptions","organizations_url":"https://api.github.com/users/compucorp/orgs","repos_url":"https://api.github.com/users/compucorp/repos","events_url":"https://api.github.com/users/compucorp/events{/privacy}","received_events_url":"https://api.github.com/users/compucorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/compucorp/uk.co.compucorp.civicase","description":"CiviCase Extension","fork":true,"url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase","forks_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/forks","keys_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/keys{/key_id}","collaborators_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/teams","hooks_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/hooks","issue_events_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/issues/events{/number}","events_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/events","assignees_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/assignees{/user}","branches_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/branches{/branch}","tags_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/tags","blobs_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/git/refs{/sha}","trees_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/git/trees{/sha}","statuses_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/statuses/{sha}","languages_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/languages","stargazers_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/stargazers","contributors_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/contributors","subscribers_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/subscribers","subscription_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/subscription","commits_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/commits{/sha}","git_commits_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/git/commits{/sha}","comments_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/comments{/number}","issue_comment_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/issues/comments{/number}","contents_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/contents/{+path}","compare_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/compare/{base}...{head}","merges_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/merges","archive_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/downloads","issues_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/issues{/number}","pulls_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/pulls{/number}","milestones_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/milestones{/number}","notifications_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/labels{/name}","releases_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/releases{/id}","deployments_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/deployments","created_at":"2018-07-31T12:33:33Z","updated_at":"2018-08-15T11:40:22Z","pushed_at":"2018-08-27T06:34:50Z","git_url":"git://github.com/compucorp/uk.co.compucorp.civicase.git","ssh_url":"git@github.com:compucorp/uk.co.compucorp.civicase.git","clone_url":"https://github.com/compucorp/uk.co.compucorp.civicase.git","svn_url":"https://github.com/compucorp/uk.co.compucorp.civicase","homepage":null,"size":1477,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/pulls/7"},"html":{"href":"https://github.com/compucorp/uk.co.compucorp.civicase/pull/7"},"issue":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/issues/7"},"comments":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/statuses/92a5764542206349cf93b211676b3c92fac54512"}},"author_association":"NONE"}}
{"actor":{"display_login":"deb1990"}}