{"action":"created","issue":{"url":"https://api.github.com/repos/laumann/compiletest-rs/issues/149","repository_url":"https://api.github.com/repos/laumann/compiletest-rs","labels_url":"https://api.github.com/repos/laumann/compiletest-rs/issues/149/labels{/name}","comments_url":"https://api.github.com/repos/laumann/compiletest-rs/issues/149/comments","events_url":"https://api.github.com/repos/laumann/compiletest-rs/issues/149/events","html_url":"https://github.com/laumann/compiletest-rs/issues/149","id":382400290,"node_id":"MDU6SXNzdWUzODI0MDAyOTA=","number":149,"title":"Rustc args: strings vs vectors & extracting link directories","user":{"login":"aldanor","id":2418513,"node_id":"MDQ6VXNlcjI0MTg1MTM=","avatar_url":"https://avatars0.githubusercontent.com/u/2418513?v=4","gravatar_id":"","url":"https://api.github.com/users/aldanor","html_url":"https://github.com/aldanor","followers_url":"https://api.github.com/users/aldanor/followers","following_url":"https://api.github.com/users/aldanor/following{/other_user}","gists_url":"https://api.github.com/users/aldanor/gists{/gist_id}","starred_url":"https://api.github.com/users/aldanor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aldanor/subscriptions","organizations_url":"https://api.github.com/users/aldanor/orgs","repos_url":"https://api.github.com/users/aldanor/repos","events_url":"https://api.github.com/users/aldanor/events{/privacy}","received_events_url":"https://api.github.com/users/aldanor/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-19T21:29:35Z","updated_at":"2018-11-19T21:30:07Z","closed_at":null,"author_association":"NONE","body":"@laumann \r\n\r\nWe need to parse the flags in utility methods like `.clean_rmeta()` which proves to be quite painful, e.g. link flags could be either `-Lfoo` or `-L foo` or `-Lnative=foo`, etc. The current method of splitting by whitespace is wrong and generally dangerous. It would also be hard to handle paths with spaces correctly.\r\n\r\nOne possible suggestion: instead, store flags as `Vec<String>`, so we can at least skip parsing quotes, whitespace, etc; each flags and its (optional) value to be stored in each element. An example would be `[\"-Lfoo\", \"-L\",  \"foo\", \"-Lnative=foo\"]`. This would obviously be a breaking change.\r\n\r\nAnother option would be to still store flags as strings but only perform cleaning in the \"default\" locations (those added by the `.link_deps()`), but then the user folders would be ignored.\r\n\r\nFinally, yet another option: still store flags as strings, but store link flags separately, link `link_flags`. It's also a little weird since then there would be an overlap."},"comment":{"url":"https://api.github.com/repos/laumann/compiletest-rs/issues/comments/440048119","html_url":"https://github.com/laumann/compiletest-rs/issues/149#issuecomment-440048119","issue_url":"https://api.github.com/repos/laumann/compiletest-rs/issues/149","id":440048119,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MDA0ODExOQ==","user":{"login":"aldanor","id":2418513,"node_id":"MDQ6VXNlcjI0MTg1MTM=","avatar_url":"https://avatars0.githubusercontent.com/u/2418513?v=4","gravatar_id":"","url":"https://api.github.com/users/aldanor","html_url":"https://github.com/aldanor","followers_url":"https://api.github.com/users/aldanor/followers","following_url":"https://api.github.com/users/aldanor/following{/other_user}","gists_url":"https://api.github.com/users/aldanor/gists{/gist_id}","starred_url":"https://api.github.com/users/aldanor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aldanor/subscriptions","organizations_url":"https://api.github.com/users/aldanor/orgs","repos_url":"https://api.github.com/users/aldanor/repos","events_url":"https://api.github.com/users/aldanor/events{/privacy}","received_events_url":"https://api.github.com/users/aldanor/received_events","type":"User","site_admin":false},"created_at":"2018-11-19T21:30:07Z","updated_at":"2018-11-19T21:30:07Z","author_association":"NONE","body":"Related: #148 "}}
{"actor":{"display_login":"aldanor"}}