{"action":"created","issue":{"url":"https://api.github.com/repos/alibaba/pouch/issues/2252","repository_url":"https://api.github.com/repos/alibaba/pouch","labels_url":"https://api.github.com/repos/alibaba/pouch/issues/2252/labels{/name}","comments_url":"https://api.github.com/repos/alibaba/pouch/issues/2252/comments","events_url":"https://api.github.com/repos/alibaba/pouch/issues/2252/events","html_url":"https://github.com/alibaba/pouch/pull/2252","id":361276893,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2Mjg3NDgz","number":2252,"title":"fixes: top options can't work","user":{"login":"lifubang","id":783424,"node_id":"MDQ6VXNlcjc4MzQyNA==","avatar_url":"https://avatars1.githubusercontent.com/u/783424?v=4","gravatar_id":"","url":"https://api.github.com/users/lifubang","html_url":"https://github.com/lifubang","followers_url":"https://api.github.com/users/lifubang/followers","following_url":"https://api.github.com/users/lifubang/following{/other_user}","gists_url":"https://api.github.com/users/lifubang/gists{/gist_id}","starred_url":"https://api.github.com/users/lifubang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lifubang/subscriptions","organizations_url":"https://api.github.com/users/lifubang/orgs","repos_url":"https://api.github.com/users/lifubang/repos","events_url":"https://api.github.com/users/lifubang/events{/privacy}","received_events_url":"https://api.github.com/users/lifubang/received_events","type":"User","site_admin":false},"labels":[{"id":684575943,"node_id":"MDU6TGFiZWw2ODQ1NzU5NDM=","url":"https://api.github.com/repos/alibaba/pouch/labels/kind/bug","name":"kind/bug","color":"f77e56","default":false},{"id":729585786,"node_id":"MDU6TGFiZWw3Mjk1ODU3ODY=","url":"https://api.github.com/repos/alibaba/pouch/labels/size/XS","name":"size/XS","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-09-18T12:20:52Z","updated_at":"2018-09-18T12:28:04Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/alibaba/pouch/pulls/2252","html_url":"https://github.com/alibaba/pouch/pull/2252","diff_url":"https://github.com/alibaba/pouch/pull/2252.diff","patch_url":"https://github.com/alibaba/pouch/pull/2252.patch"},"body":"Signed-off-by: Lifubang <lifubang@acmcoder.com>\r\n\r\n### Ⅰ. Describe what this PR did\r\n1. When pouch top --help:\r\ntop command is to display the running processes of a container.You can add options just like using Linux ps command.\r\nBut when I run: pouch top redisps -aux\r\nIt returns:\r\nError: unknown shorthand flag: 'a' in -aux\r\n\r\n2. in https://github.com/alibaba/pouch/blob/master/docs/api/HTTP_API.md\r\nDisplay the running processes of a container\r\nPOST /containers/{id}/top\r\n\r\nBut in https://github.com/alibaba/pouch/blob/master/client/container_top.go#L19\r\nand https://github.com/alibaba/pouch/blob/master/apis/server/router.go#L57\r\nThe type is get.\r\n\r\nAnd, in https://github.com/alibaba/pouch/blob/master/apis/server/container_bridge.go#L323\r\nIt uses req.Form.Get\r\n\r\nIs post? or get?\r\n\r\n### Ⅱ. Does this pull request fix one issue?\r\nNONE\r\n\r\n### Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)\r\nYes, you already had test cases.\r\n\r\n### Ⅳ. Describe how to verify it\r\npouch top redisps -aux\r\n\r\n### Ⅴ. Special notes for reviews\r\nMake pouch top options work\r\nAccording to https://github.com/alibaba/pouch/blob/master/docs/api/HTTP_API.md, use post.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/alibaba/pouch/issues/comments/422371906","html_url":"https://github.com/alibaba/pouch/pull/2252#issuecomment-422371906","issue_url":"https://api.github.com/repos/alibaba/pouch/issues/2252","id":422371906,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjM3MTkwNg==","user":{"login":"lifubang","id":783424,"node_id":"MDQ6VXNlcjc4MzQyNA==","avatar_url":"https://avatars1.githubusercontent.com/u/783424?v=4","gravatar_id":"","url":"https://api.github.com/users/lifubang","html_url":"https://github.com/lifubang","followers_url":"https://api.github.com/users/lifubang/followers","following_url":"https://api.github.com/users/lifubang/following{/other_user}","gists_url":"https://api.github.com/users/lifubang/gists{/gist_id}","starred_url":"https://api.github.com/users/lifubang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lifubang/subscriptions","organizations_url":"https://api.github.com/users/lifubang/orgs","repos_url":"https://api.github.com/users/lifubang/repos","events_url":"https://api.github.com/users/lifubang/events{/privacy}","received_events_url":"https://api.github.com/users/lifubang/received_events","type":"User","site_admin":false},"created_at":"2018-09-18T12:28:04Z","updated_at":"2018-09-18T12:28:04Z","author_association":"NONE","body":"So, change to get?"}}
{"actor":{"display_login":"lifubang"}}