{"action":"created","comment":{"url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/comments/169318283","pull_request_review_id":97823391,"id":169318283,"diff_hunk":"@@ -2699,9 +2714,19 @@ vm_loop (vm_frame_ctx_t *frame_ctx_p) /**< frame context */\n           && !(frame_ctx_p->bytecode_header_p->status_flags & CBC_CODE_FLAGS_DEBUGGER_IGNORE)\n           && !(JERRY_CONTEXT (debugger_flags) & (JERRY_DEBUGGER_VM_IGNORE_EXCEPTION | JERRY_DEBUGGER_VM_IGNORE)))\n       {\n+        /* Save the error to a local value, because the engine enters breakpoint mode after,\n+           therefore an evaluation error, or user-created error throw would overwrite it. */\n+        ecma_value_t local_err = JERRY_CONTEXT (error_value);\n         if (jerry_debugger_send_exception_string ())\n         {\n           jerry_debugger_breakpoint_hit (JERRY_DEBUGGER_EXCEPTION_HIT);\n+          if (JERRY_CONTEXT (debugger_flags) & JERRY_DEBUGGER_THROW_ERROR_FLAG)\n+          {\n+            result = JERRY_CONTEXT (error_value);\n+            ecma_free_value (local_err);\n+            goto error;","path":"jerry-core/vm/vm.c","position":50,"original_position":50,"commit_id":"24c12e5deecd8573a327f9cb21c2f6143d76b08c","original_commit_id":"24c12e5deecd8573a327f9cb21c2f6143d76b08c","user":{"login":"zherczeg","id":2270193,"avatar_url":"https://avatars2.githubusercontent.com/u/2270193?v=4","gravatar_id":"","url":"https://api.github.com/users/zherczeg","html_url":"https://github.com/zherczeg","followers_url":"https://api.github.com/users/zherczeg/followers","following_url":"https://api.github.com/users/zherczeg/following{/other_user}","gists_url":"https://api.github.com/users/zherczeg/gists{/gist_id}","starred_url":"https://api.github.com/users/zherczeg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zherczeg/subscriptions","organizations_url":"https://api.github.com/users/zherczeg/orgs","repos_url":"https://api.github.com/users/zherczeg/repos","events_url":"https://api.github.com/users/zherczeg/events{/privacy}","received_events_url":"https://api.github.com/users/zherczeg/received_events","type":"User","site_admin":false},"body":"Perhaps I would rename `local_err` to `current_error_value`","created_at":"2018-02-20T13:33:37Z","updated_at":"2018-02-20T13:33:37Z","html_url":"https://github.com/jerryscript-project/jerryscript/pull/2188#discussion_r169318283","pull_request_url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/2188","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/comments/169318283"},"html":{"href":"https://github.com/jerryscript-project/jerryscript/pull/2188#discussion_r169318283"},"pull_request":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/2188"}},"in_reply_to_id":169318020},"pull_request":{"url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/2188","id":166335448,"html_url":"https://github.com/jerryscript-project/jerryscript/pull/2188","diff_url":"https://github.com/jerryscript-project/jerryscript/pull/2188.diff","patch_url":"https://github.com/jerryscript-project/jerryscript/pull/2188.patch","issue_url":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/2188","number":2188,"state":"open","locked":false,"title":"Add the ability to throw an error to python debugger","user":{"login":"DanielBallaSZTE","id":20175069,"avatar_url":"https://avatars0.githubusercontent.com/u/20175069?v=4","gravatar_id":"","url":"https://api.github.com/users/DanielBallaSZTE","html_url":"https://github.com/DanielBallaSZTE","followers_url":"https://api.github.com/users/DanielBallaSZTE/followers","following_url":"https://api.github.com/users/DanielBallaSZTE/following{/other_user}","gists_url":"https://api.github.com/users/DanielBallaSZTE/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielBallaSZTE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielBallaSZTE/subscriptions","organizations_url":"https://api.github.com/users/DanielBallaSZTE/orgs","repos_url":"https://api.github.com/users/DanielBallaSZTE/repos","events_url":"https://api.github.com/users/DanielBallaSZTE/events{/privacy}","received_events_url":"https://api.github.com/users/DanielBallaSZTE/received_events","type":"User","site_admin":false},"body":"This patch makes it possible to throw an error from the python debugger client using the `throw` command.\r\n\r\nJerryScript-DCO-1.0-Signed-off-by: Daniel Balla dballa@inf.u-szeged.hu","created_at":"2018-01-31T18:06:40Z","updated_at":"2018-02-20T13:33:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79ebb278462576632939523fca49278555530592","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/2188/commits","review_comments_url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/2188/comments","review_comment_url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/2188/comments","statuses_url":"https://api.github.com/repos/jerryscript-project/jerryscript/statuses/24c12e5deecd8573a327f9cb21c2f6143d76b08c","head":{"label":"DanielBallaSZTE:jerry_debugger_throw_error","ref":"jerry_debugger_throw_error","sha":"24c12e5deecd8573a327f9cb21c2f6143d76b08c","user":{"login":"DanielBallaSZTE","id":20175069,"avatar_url":"https://avatars0.githubusercontent.com/u/20175069?v=4","gravatar_id":"","url":"https://api.github.com/users/DanielBallaSZTE","html_url":"https://github.com/DanielBallaSZTE","followers_url":"https://api.github.com/users/DanielBallaSZTE/followers","following_url":"https://api.github.com/users/DanielBallaSZTE/following{/other_user}","gists_url":"https://api.github.com/users/DanielBallaSZTE/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielBallaSZTE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielBallaSZTE/subscriptions","organizations_url":"https://api.github.com/users/DanielBallaSZTE/orgs","repos_url":"https://api.github.com/users/DanielBallaSZTE/repos","events_url":"https://api.github.com/users/DanielBallaSZTE/events{/privacy}","received_events_url":"https://api.github.com/users/DanielBallaSZTE/received_events","type":"User","site_admin":false},"repo":{"id":90849938,"name":"jerryscript","full_name":"DanielBallaSZTE/jerryscript","owner":{"login":"DanielBallaSZTE","id":20175069,"avatar_url":"https://avatars0.githubusercontent.com/u/20175069?v=4","gravatar_id":"","url":"https://api.github.com/users/DanielBallaSZTE","html_url":"https://github.com/DanielBallaSZTE","followers_url":"https://api.github.com/users/DanielBallaSZTE/followers","following_url":"https://api.github.com/users/DanielBallaSZTE/following{/other_user}","gists_url":"https://api.github.com/users/DanielBallaSZTE/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielBallaSZTE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielBallaSZTE/subscriptions","organizations_url":"https://api.github.com/users/DanielBallaSZTE/orgs","repos_url":"https://api.github.com/users/DanielBallaSZTE/repos","events_url":"https://api.github.com/users/DanielBallaSZTE/events{/privacy}","received_events_url":"https://api.github.com/users/DanielBallaSZTE/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DanielBallaSZTE/jerryscript","description":"Ultra-lightweight JavaScript engine for the Internet of Things.","fork":true,"url":"https://api.github.com/repos/DanielBallaSZTE/jerryscript","forks_url":"https://api.github.com/repos/DanielBallaSZTE/jerryscript/forks","keys_url":"https://api.github.com/repos/DanielBallaSZTE/jerryscript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DanielBallaSZTE/jerryscript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DanielBallaSZTE/jerryscript/teams","hooks_url":"https://api.github.com/repos/DanielBallaSZTE/jerryscript/hooks","issue_events_url":"https://api.github.com/repos/DanielBallaSZTE/jerryscript/issues/events{/number}","events_url":"https://api.github.com/repos/DanielBallaSZTE/jerryscript/events","assignees_url":"https://api.github.com/repos/DanielBallaSZTE/jerryscript/assignees{/user}","branches_url":"https://api.github.com/repos/DanielBallaSZTE/jerryscript/branches{/branch}","tags_url":"https://api.github.com/repos/DanielBallaSZTE/jerryscript/tags","blobs_url":"https://api.github.com/repos/DanielBallaSZTE/jerryscript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DanielBallaSZTE/jerryscript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DanielBallaSZTE/jerryscript/git/refs{/sha}","trees_url":"https://api.github.com/repos/DanielBallaSZTE/jerryscript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DanielBallaSZTE/jerryscript/statuses/{sha}","languages_url":"https://api.github.com/repos/DanielBallaSZTE/jerryscript/languages","stargazers_url":"https://api.github.com/repos/DanielBallaSZTE/jerryscript/stargazers","contributors_url":"https://api.github.com/repos/DanielBallaSZTE/jerryscript/contributors","subscribers_url":"https://api.github.com/repos/DanielBallaSZTE/jerryscript/subscribers","subscription_url":"https://api.github.com/repos/DanielBallaSZTE/jerryscript/subscription","commits_url":"https://api.github.com/repos/DanielBallaSZTE/jerryscript/commits{/sha}","git_commits_url":"https://api.github.com/repos/DanielBallaSZTE/jerryscript/git/commits{/sha}","comments_url":"https://api.github.com/repos/DanielBallaSZTE/jerryscript/comments{/number}","issue_comment_url":"https://api.github.com/repos/DanielBallaSZTE/jerryscript/issues/comments{/number}","contents_url":"https://api.github.com/repos/DanielBallaSZTE/jerryscript/contents/{+path}","compare_url":"https://api.github.com/repos/DanielBallaSZTE/jerryscript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DanielBallaSZTE/jerryscript/merges","archive_url":"https://api.github.com/repos/DanielBallaSZTE/jerryscript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DanielBallaSZTE/jerryscript/downloads","issues_url":"https://api.github.com/repos/DanielBallaSZTE/jerryscript/issues{/number}","pulls_url":"https://api.github.com/repos/DanielBallaSZTE/jerryscript/pulls{/number}","milestones_url":"https://api.github.com/repos/DanielBallaSZTE/jerryscript/milestones{/number}","notifications_url":"https://api.github.com/repos/DanielBallaSZTE/jerryscript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DanielBallaSZTE/jerryscript/labels{/name}","releases_url":"https://api.github.com/repos/DanielBallaSZTE/jerryscript/releases{/id}","deployments_url":"https://api.github.com/repos/DanielBallaSZTE/jerryscript/deployments","created_at":"2017-05-10T10:04:34Z","updated_at":"2017-05-10T10:04:39Z","pushed_at":"2018-02-14T16:36:37Z","git_url":"git://github.com/DanielBallaSZTE/jerryscript.git","ssh_url":"git@github.com:DanielBallaSZTE/jerryscript.git","clone_url":"https://github.com/DanielBallaSZTE/jerryscript.git","svn_url":"https://github.com/DanielBallaSZTE/jerryscript","homepage":"http://jerryscript.net","size":28939,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jerryscript-project:master","ref":"master","sha":"d7991ae54c42f7a994a5da1ef1909989857014b4","user":{"login":"jerryscript-project","id":23194380,"avatar_url":"https://avatars1.githubusercontent.com/u/23194380?v=4","gravatar_id":"","url":"https://api.github.com/users/jerryscript-project","html_url":"https://github.com/jerryscript-project","followers_url":"https://api.github.com/users/jerryscript-project/followers","following_url":"https://api.github.com/users/jerryscript-project/following{/other_user}","gists_url":"https://api.github.com/users/jerryscript-project/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryscript-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryscript-project/subscriptions","organizations_url":"https://api.github.com/users/jerryscript-project/orgs","repos_url":"https://api.github.com/users/jerryscript-project/repos","events_url":"https://api.github.com/users/jerryscript-project/events{/privacy}","received_events_url":"https://api.github.com/users/jerryscript-project/received_events","type":"Organization","site_admin":false},"repo":{"id":33339660,"name":"jerryscript","full_name":"jerryscript-project/jerryscript","owner":{"login":"jerryscript-project","id":23194380,"avatar_url":"https://avatars1.githubusercontent.com/u/23194380?v=4","gravatar_id":"","url":"https://api.github.com/users/jerryscript-project","html_url":"https://github.com/jerryscript-project","followers_url":"https://api.github.com/users/jerryscript-project/followers","following_url":"https://api.github.com/users/jerryscript-project/following{/other_user}","gists_url":"https://api.github.com/users/jerryscript-project/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryscript-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryscript-project/subscriptions","organizations_url":"https://api.github.com/users/jerryscript-project/orgs","repos_url":"https://api.github.com/users/jerryscript-project/repos","events_url":"https://api.github.com/users/jerryscript-project/events{/privacy}","received_events_url":"https://api.github.com/users/jerryscript-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jerryscript-project/jerryscript","description":"Ultra-lightweight JavaScript engine for the Internet of Things.","fork":false,"url":"https://api.github.com/repos/jerryscript-project/jerryscript","forks_url":"https://api.github.com/repos/jerryscript-project/jerryscript/forks","keys_url":"https://api.github.com/repos/jerryscript-project/jerryscript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jerryscript-project/jerryscript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jerryscript-project/jerryscript/teams","hooks_url":"https://api.github.com/repos/jerryscript-project/jerryscript/hooks","issue_events_url":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/events{/number}","events_url":"https://api.github.com/repos/jerryscript-project/jerryscript/events","assignees_url":"https://api.github.com/repos/jerryscript-project/jerryscript/assignees{/user}","branches_url":"https://api.github.com/repos/jerryscript-project/jerryscript/branches{/branch}","tags_url":"https://api.github.com/repos/jerryscript-project/jerryscript/tags","blobs_url":"https://api.github.com/repos/jerryscript-project/jerryscript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jerryscript-project/jerryscript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jerryscript-project/jerryscript/git/refs{/sha}","trees_url":"https://api.github.com/repos/jerryscript-project/jerryscript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jerryscript-project/jerryscript/statuses/{sha}","languages_url":"https://api.github.com/repos/jerryscript-project/jerryscript/languages","stargazers_url":"https://api.github.com/repos/jerryscript-project/jerryscript/stargazers","contributors_url":"https://api.github.com/repos/jerryscript-project/jerryscript/contributors","subscribers_url":"https://api.github.com/repos/jerryscript-project/jerryscript/subscribers","subscription_url":"https://api.github.com/repos/jerryscript-project/jerryscript/subscription","commits_url":"https://api.github.com/repos/jerryscript-project/jerryscript/commits{/sha}","git_commits_url":"https://api.github.com/repos/jerryscript-project/jerryscript/git/commits{/sha}","comments_url":"https://api.github.com/repos/jerryscript-project/jerryscript/comments{/number}","issue_comment_url":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/comments{/number}","contents_url":"https://api.github.com/repos/jerryscript-project/jerryscript/contents/{+path}","compare_url":"https://api.github.com/repos/jerryscript-project/jerryscript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jerryscript-project/jerryscript/merges","archive_url":"https://api.github.com/repos/jerryscript-project/jerryscript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jerryscript-project/jerryscript/downloads","issues_url":"https://api.github.com/repos/jerryscript-project/jerryscript/issues{/number}","pulls_url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls{/number}","milestones_url":"https://api.github.com/repos/jerryscript-project/jerryscript/milestones{/number}","notifications_url":"https://api.github.com/repos/jerryscript-project/jerryscript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jerryscript-project/jerryscript/labels{/name}","releases_url":"https://api.github.com/repos/jerryscript-project/jerryscript/releases{/id}","deployments_url":"https://api.github.com/repos/jerryscript-project/jerryscript/deployments","created_at":"2015-04-03T01:10:31Z","updated_at":"2018-02-20T08:12:36Z","pushed_at":"2018-02-20T13:20:54Z","git_url":"git://github.com/jerryscript-project/jerryscript.git","ssh_url":"git@github.com:jerryscript-project/jerryscript.git","clone_url":"https://github.com/jerryscript-project/jerryscript.git","svn_url":"https://github.com/jerryscript-project/jerryscript","homepage":"http://jerryscript.net","size":45241,"stargazers_count":2814,"watchers_count":2814,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":327,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":327,"open_issues":49,"watchers":2814,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/2188"},"html":{"href":"https://github.com/jerryscript-project/jerryscript/pull/2188"},"issue":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/2188"},"comments":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/2188/comments"},"review_comments":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/2188/comments"},"review_comment":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/2188/commits"},"statuses":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/statuses/24c12e5deecd8573a327f9cb21c2f6143d76b08c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"zherczeg"}}