{"action":"created","comment":{"url":"https://api.github.com/repos/HERA-Team/hera_pspec/pulls/comments/186581082","pull_request_review_id":118188005,"id":186581082,"diff_hunk":"@@ -959,7 +953,45 @@ def scalar(self, pol='I', taper='none', little_h=True,\n                                                num_steps=num_steps)\n         return scalar\n \n-    def pspec(self, bls1, bls2, dsets, input_data_weight='identity', norm='I', \n+    def validate_pol(self, dsets, pol_pair):\n+        \"\"\"\n+        Validate polarization and returns the index of the datasets so that the polarization pair is consistent with the UVData objects\n+\n+        Parameters\n+        ----------\n+        dsets : length-2 list or length-2 tuple of integers or str\n+            Contains indices of self.dsets to use in forming power spectra,\n+            where the first index is for the Left-Hand dataset and second index\n+            is used for the Right-Hand dataset (see above).\n+\n+        pol_pair : length-2 tuple\n+            Contains polarization pair which will be used in estiamting the power spectrum e,g ('xx','xx') or  ('xy','yx'). Only equal polarization pair is implemented for the time being.               ","path":"hera_pspec/pspecdata.py","position":32,"original_position":32,"commit_id":"59f3ee61b5965785d5bdb599da5986246825fa0d","original_commit_id":"59f3ee61b5965785d5bdb599da5986246825fa0d","user":{"login":"philbull","id":710867,"avatar_url":"https://avatars3.githubusercontent.com/u/710867?v=4","gravatar_id":"","url":"https://api.github.com/users/philbull","html_url":"https://github.com/philbull","followers_url":"https://api.github.com/users/philbull/followers","following_url":"https://api.github.com/users/philbull/following{/other_user}","gists_url":"https://api.github.com/users/philbull/gists{/gist_id}","starred_url":"https://api.github.com/users/philbull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philbull/subscriptions","organizations_url":"https://api.github.com/users/philbull/orgs","repos_url":"https://api.github.com/users/philbull/repos","events_url":"https://api.github.com/users/philbull/events{/privacy}","received_events_url":"https://api.github.com/users/philbull/received_events","type":"User","site_admin":false},"body":"This docstring should have a `Returns` block too.","created_at":"2018-05-07T23:34:37Z","updated_at":"2018-05-08T00:01:42Z","html_url":"https://github.com/HERA-Team/hera_pspec/pull/86#discussion_r186581082","pull_request_url":"https://api.github.com/repos/HERA-Team/hera_pspec/pulls/86","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/HERA-Team/hera_pspec/pulls/comments/186581082"},"html":{"href":"https://github.com/HERA-Team/hera_pspec/pull/86#discussion_r186581082"},"pull_request":{"href":"https://api.github.com/repos/HERA-Team/hera_pspec/pulls/86"}}},"pull_request":{"url":"https://api.github.com/repos/HERA-Team/hera_pspec/pulls/86","id":185052068,"html_url":"https://github.com/HERA-Team/hera_pspec/pull/86","diff_url":"https://github.com/HERA-Team/hera_pspec/pull/86.diff","patch_url":"https://github.com/HERA-Team/hera_pspec/pull/86.patch","issue_url":"https://api.github.com/repos/HERA-Team/hera_pspec/issues/86","number":86,"state":"open","locked":false,"title":"Add polarization abilities to Hera pspec stokes","user":{"login":"Chuneeta","id":8384144,"avatar_url":"https://avatars1.githubusercontent.com/u/8384144?v=4","gravatar_id":"","url":"https://api.github.com/users/Chuneeta","html_url":"https://github.com/Chuneeta","followers_url":"https://api.github.com/users/Chuneeta/followers","following_url":"https://api.github.com/users/Chuneeta/following{/other_user}","gists_url":"https://api.github.com/users/Chuneeta/gists{/gist_id}","starred_url":"https://api.github.com/users/Chuneeta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chuneeta/subscriptions","organizations_url":"https://api.github.com/users/Chuneeta/orgs","repos_url":"https://api.github.com/users/Chuneeta/repos","events_url":"https://api.github.com/users/Chuneeta/events{/privacy}","received_events_url":"https://api.github.com/users/Chuneeta/received_events","type":"User","site_admin":false},"body":"This branch includes a module stokes.py that allows to combine visibilities to form Stokes visibiliities. Also the pspecdata has been modified to be able to estimated cross-polarized power spectra. However, at the moment, only equal polarization pair are implemented, waiting for cross-polarized beam normalization to be implemented.","created_at":"2018-04-30T20:11:59Z","updated_at":"2018-05-08T00:01:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"edba4ab642e54dad74dca5482753ef3f5a01c182","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/HERA-Team/hera_pspec/pulls/86/commits","review_comments_url":"https://api.github.com/repos/HERA-Team/hera_pspec/pulls/86/comments","review_comment_url":"https://api.github.com/repos/HERA-Team/hera_pspec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HERA-Team/hera_pspec/issues/86/comments","statuses_url":"https://api.github.com/repos/HERA-Team/hera_pspec/statuses/59f3ee61b5965785d5bdb599da5986246825fa0d","head":{"label":"HERA-Team:hera_pspec_stokes","ref":"hera_pspec_stokes","sha":"59f3ee61b5965785d5bdb599da5986246825fa0d","user":{"login":"HERA-Team","id":14352544,"avatar_url":"https://avatars1.githubusercontent.com/u/14352544?v=4","gravatar_id":"","url":"https://api.github.com/users/HERA-Team","html_url":"https://github.com/HERA-Team","followers_url":"https://api.github.com/users/HERA-Team/followers","following_url":"https://api.github.com/users/HERA-Team/following{/other_user}","gists_url":"https://api.github.com/users/HERA-Team/gists{/gist_id}","starred_url":"https://api.github.com/users/HERA-Team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HERA-Team/subscriptions","organizations_url":"https://api.github.com/users/HERA-Team/orgs","repos_url":"https://api.github.com/users/HERA-Team/repos","events_url":"https://api.github.com/users/HERA-Team/events{/privacy}","received_events_url":"https://api.github.com/users/HERA-Team/received_events","type":"Organization","site_admin":false},"repo":{"id":95261834,"name":"hera_pspec","full_name":"HERA-Team/hera_pspec","owner":{"login":"HERA-Team","id":14352544,"avatar_url":"https://avatars1.githubusercontent.com/u/14352544?v=4","gravatar_id":"","url":"https://api.github.com/users/HERA-Team","html_url":"https://github.com/HERA-Team","followers_url":"https://api.github.com/users/HERA-Team/followers","following_url":"https://api.github.com/users/HERA-Team/following{/other_user}","gists_url":"https://api.github.com/users/HERA-Team/gists{/gist_id}","starred_url":"https://api.github.com/users/HERA-Team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HERA-Team/subscriptions","organizations_url":"https://api.github.com/users/HERA-Team/orgs","repos_url":"https://api.github.com/users/HERA-Team/repos","events_url":"https://api.github.com/users/HERA-Team/events{/privacy}","received_events_url":"https://api.github.com/users/HERA-Team/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HERA-Team/hera_pspec","description":"HERA power spectrum estimation code and data formats","fork":false,"url":"https://api.github.com/repos/HERA-Team/hera_pspec","forks_url":"https://api.github.com/repos/HERA-Team/hera_pspec/forks","keys_url":"https://api.github.com/repos/HERA-Team/hera_pspec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HERA-Team/hera_pspec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HERA-Team/hera_pspec/teams","hooks_url":"https://api.github.com/repos/HERA-Team/hera_pspec/hooks","issue_events_url":"https://api.github.com/repos/HERA-Team/hera_pspec/issues/events{/number}","events_url":"https://api.github.com/repos/HERA-Team/hera_pspec/events","assignees_url":"https://api.github.com/repos/HERA-Team/hera_pspec/assignees{/user}","branches_url":"https://api.github.com/repos/HERA-Team/hera_pspec/branches{/branch}","tags_url":"https://api.github.com/repos/HERA-Team/hera_pspec/tags","blobs_url":"https://api.github.com/repos/HERA-Team/hera_pspec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HERA-Team/hera_pspec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HERA-Team/hera_pspec/git/refs{/sha}","trees_url":"https://api.github.com/repos/HERA-Team/hera_pspec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HERA-Team/hera_pspec/statuses/{sha}","languages_url":"https://api.github.com/repos/HERA-Team/hera_pspec/languages","stargazers_url":"https://api.github.com/repos/HERA-Team/hera_pspec/stargazers","contributors_url":"https://api.github.com/repos/HERA-Team/hera_pspec/contributors","subscribers_url":"https://api.github.com/repos/HERA-Team/hera_pspec/subscribers","subscription_url":"https://api.github.com/repos/HERA-Team/hera_pspec/subscription","commits_url":"https://api.github.com/repos/HERA-Team/hera_pspec/commits{/sha}","git_commits_url":"https://api.github.com/repos/HERA-Team/hera_pspec/git/commits{/sha}","comments_url":"https://api.github.com/repos/HERA-Team/hera_pspec/comments{/number}","issue_comment_url":"https://api.github.com/repos/HERA-Team/hera_pspec/issues/comments{/number}","contents_url":"https://api.github.com/repos/HERA-Team/hera_pspec/contents/{+path}","compare_url":"https://api.github.com/repos/HERA-Team/hera_pspec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HERA-Team/hera_pspec/merges","archive_url":"https://api.github.com/repos/HERA-Team/hera_pspec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HERA-Team/hera_pspec/downloads","issues_url":"https://api.github.com/repos/HERA-Team/hera_pspec/issues{/number}","pulls_url":"https://api.github.com/repos/HERA-Team/hera_pspec/pulls{/number}","milestones_url":"https://api.github.com/repos/HERA-Team/hera_pspec/milestones{/number}","notifications_url":"https://api.github.com/repos/HERA-Team/hera_pspec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HERA-Team/hera_pspec/labels{/name}","releases_url":"https://api.github.com/repos/HERA-Team/hera_pspec/releases{/id}","deployments_url":"https://api.github.com/repos/HERA-Team/hera_pspec/deployments","created_at":"2017-06-23T22:50:27Z","updated_at":"2018-05-07T22:59:17Z","pushed_at":"2018-05-07T23:57:27Z","git_url":"git://github.com/HERA-Team/hera_pspec.git","ssh_url":"git@github.com:HERA-Team/hera_pspec.git","clone_url":"https://github.com/HERA-Team/hera_pspec.git","svn_url":"https://github.com/HERA-Team/hera_pspec","homepage":"http://hera-pspec.readthedocs.io/en/latest/","size":79036,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":1,"open_issues":30,"watchers":1,"default_branch":"master"}},"base":{"label":"HERA-Team:master","ref":"master","sha":"447b9e86118369b3ced51bb4f6778cc81e4fa92e","user":{"login":"HERA-Team","id":14352544,"avatar_url":"https://avatars1.githubusercontent.com/u/14352544?v=4","gravatar_id":"","url":"https://api.github.com/users/HERA-Team","html_url":"https://github.com/HERA-Team","followers_url":"https://api.github.com/users/HERA-Team/followers","following_url":"https://api.github.com/users/HERA-Team/following{/other_user}","gists_url":"https://api.github.com/users/HERA-Team/gists{/gist_id}","starred_url":"https://api.github.com/users/HERA-Team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HERA-Team/subscriptions","organizations_url":"https://api.github.com/users/HERA-Team/orgs","repos_url":"https://api.github.com/users/HERA-Team/repos","events_url":"https://api.github.com/users/HERA-Team/events{/privacy}","received_events_url":"https://api.github.com/users/HERA-Team/received_events","type":"Organization","site_admin":false},"repo":{"id":95261834,"name":"hera_pspec","full_name":"HERA-Team/hera_pspec","owner":{"login":"HERA-Team","id":14352544,"avatar_url":"https://avatars1.githubusercontent.com/u/14352544?v=4","gravatar_id":"","url":"https://api.github.com/users/HERA-Team","html_url":"https://github.com/HERA-Team","followers_url":"https://api.github.com/users/HERA-Team/followers","following_url":"https://api.github.com/users/HERA-Team/following{/other_user}","gists_url":"https://api.github.com/users/HERA-Team/gists{/gist_id}","starred_url":"https://api.github.com/users/HERA-Team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HERA-Team/subscriptions","organizations_url":"https://api.github.com/users/HERA-Team/orgs","repos_url":"https://api.github.com/users/HERA-Team/repos","events_url":"https://api.github.com/users/HERA-Team/events{/privacy}","received_events_url":"https://api.github.com/users/HERA-Team/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HERA-Team/hera_pspec","description":"HERA power spectrum estimation code and data formats","fork":false,"url":"https://api.github.com/repos/HERA-Team/hera_pspec","forks_url":"https://api.github.com/repos/HERA-Team/hera_pspec/forks","keys_url":"https://api.github.com/repos/HERA-Team/hera_pspec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HERA-Team/hera_pspec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HERA-Team/hera_pspec/teams","hooks_url":"https://api.github.com/repos/HERA-Team/hera_pspec/hooks","issue_events_url":"https://api.github.com/repos/HERA-Team/hera_pspec/issues/events{/number}","events_url":"https://api.github.com/repos/HERA-Team/hera_pspec/events","assignees_url":"https://api.github.com/repos/HERA-Team/hera_pspec/assignees{/user}","branches_url":"https://api.github.com/repos/HERA-Team/hera_pspec/branches{/branch}","tags_url":"https://api.github.com/repos/HERA-Team/hera_pspec/tags","blobs_url":"https://api.github.com/repos/HERA-Team/hera_pspec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HERA-Team/hera_pspec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HERA-Team/hera_pspec/git/refs{/sha}","trees_url":"https://api.github.com/repos/HERA-Team/hera_pspec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HERA-Team/hera_pspec/statuses/{sha}","languages_url":"https://api.github.com/repos/HERA-Team/hera_pspec/languages","stargazers_url":"https://api.github.com/repos/HERA-Team/hera_pspec/stargazers","contributors_url":"https://api.github.com/repos/HERA-Team/hera_pspec/contributors","subscribers_url":"https://api.github.com/repos/HERA-Team/hera_pspec/subscribers","subscription_url":"https://api.github.com/repos/HERA-Team/hera_pspec/subscription","commits_url":"https://api.github.com/repos/HERA-Team/hera_pspec/commits{/sha}","git_commits_url":"https://api.github.com/repos/HERA-Team/hera_pspec/git/commits{/sha}","comments_url":"https://api.github.com/repos/HERA-Team/hera_pspec/comments{/number}","issue_comment_url":"https://api.github.com/repos/HERA-Team/hera_pspec/issues/comments{/number}","contents_url":"https://api.github.com/repos/HERA-Team/hera_pspec/contents/{+path}","compare_url":"https://api.github.com/repos/HERA-Team/hera_pspec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HERA-Team/hera_pspec/merges","archive_url":"https://api.github.com/repos/HERA-Team/hera_pspec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HERA-Team/hera_pspec/downloads","issues_url":"https://api.github.com/repos/HERA-Team/hera_pspec/issues{/number}","pulls_url":"https://api.github.com/repos/HERA-Team/hera_pspec/pulls{/number}","milestones_url":"https://api.github.com/repos/HERA-Team/hera_pspec/milestones{/number}","notifications_url":"https://api.github.com/repos/HERA-Team/hera_pspec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HERA-Team/hera_pspec/labels{/name}","releases_url":"https://api.github.com/repos/HERA-Team/hera_pspec/releases{/id}","deployments_url":"https://api.github.com/repos/HERA-Team/hera_pspec/deployments","created_at":"2017-06-23T22:50:27Z","updated_at":"2018-05-07T22:59:17Z","pushed_at":"2018-05-07T23:57:27Z","git_url":"git://github.com/HERA-Team/hera_pspec.git","ssh_url":"git@github.com:HERA-Team/hera_pspec.git","clone_url":"https://github.com/HERA-Team/hera_pspec.git","svn_url":"https://github.com/HERA-Team/hera_pspec","homepage":"http://hera-pspec.readthedocs.io/en/latest/","size":79036,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":1,"open_issues":30,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HERA-Team/hera_pspec/pulls/86"},"html":{"href":"https://github.com/HERA-Team/hera_pspec/pull/86"},"issue":{"href":"https://api.github.com/repos/HERA-Team/hera_pspec/issues/86"},"comments":{"href":"https://api.github.com/repos/HERA-Team/hera_pspec/issues/86/comments"},"review_comments":{"href":"https://api.github.com/repos/HERA-Team/hera_pspec/pulls/86/comments"},"review_comment":{"href":"https://api.github.com/repos/HERA-Team/hera_pspec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HERA-Team/hera_pspec/pulls/86/commits"},"statuses":{"href":"https://api.github.com/repos/HERA-Team/hera_pspec/statuses/59f3ee61b5965785d5bdb599da5986246825fa0d"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"philbull"}}