{"action":"closed","number":693,"pull_request":{"url":"https://api.github.com/repos/Microsoft/cpprestsdk/pulls/693","id":167694173,"html_url":"https://github.com/Microsoft/cpprestsdk/pull/693","diff_url":"https://github.com/Microsoft/cpprestsdk/pull/693.diff","patch_url":"https://github.com/Microsoft/cpprestsdk/pull/693.patch","issue_url":"https://api.github.com/repos/Microsoft/cpprestsdk/issues/693","number":693,"state":"closed","locked":false,"title":"Don't use the ``U()`` preprocessor macro in public headers","user":{"login":"garethsb-sony","id":31761158,"avatar_url":"https://avatars3.githubusercontent.com/u/31761158?v=4","gravatar_id":"","url":"https://api.github.com/users/garethsb-sony","html_url":"https://github.com/garethsb-sony","followers_url":"https://api.github.com/users/garethsb-sony/followers","following_url":"https://api.github.com/users/garethsb-sony/following{/other_user}","gists_url":"https://api.github.com/users/garethsb-sony/gists{/gist_id}","starred_url":"https://api.github.com/users/garethsb-sony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garethsb-sony/subscriptions","organizations_url":"https://api.github.com/users/garethsb-sony/orgs","repos_url":"https://api.github.com/users/garethsb-sony/repos","events_url":"https://api.github.com/users/garethsb-sony/events{/privacy}","received_events_url":"https://api.github.com/users/garethsb-sony/received_events","type":"User","site_admin":false},"body":"…in order that SDK clients can build with ``_TURN_OFF_PLATFORM_STRING`` defined.\r\n\r\nThere are currently many instances of ``U()`` in src, samples and tests\\functional, that mean it's not currently possible to build the SDK itself or many of the samples or tests with ``_TURN_OFF_PLATFORM_STRING`` defined. This PR doesn't address that.\r\n\r\n Fixes #692.\r\n","created_at":"2018-02-07T13:35:57Z","updated_at":"2018-02-07T18:22:42Z","closed_at":"2018-02-07T18:22:42Z","merged_at":"2018-02-07T18:22:42Z","merge_commit_sha":"f3ec72364703eab8ec8dfae41d50cb63c700933b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/cpprestsdk/pulls/693/commits","review_comments_url":"https://api.github.com/repos/Microsoft/cpprestsdk/pulls/693/comments","review_comment_url":"https://api.github.com/repos/Microsoft/cpprestsdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/cpprestsdk/issues/693/comments","statuses_url":"https://api.github.com/repos/Microsoft/cpprestsdk/statuses/35d40093fe785df1f3b36f98796e2fe64cf50dfd","head":{"label":"garethsb-sony:use-_xplatstr-not-u","ref":"use-_xplatstr-not-u","sha":"35d40093fe785df1f3b36f98796e2fe64cf50dfd","user":{"login":"garethsb-sony","id":31761158,"avatar_url":"https://avatars3.githubusercontent.com/u/31761158?v=4","gravatar_id":"","url":"https://api.github.com/users/garethsb-sony","html_url":"https://github.com/garethsb-sony","followers_url":"https://api.github.com/users/garethsb-sony/followers","following_url":"https://api.github.com/users/garethsb-sony/following{/other_user}","gists_url":"https://api.github.com/users/garethsb-sony/gists{/gist_id}","starred_url":"https://api.github.com/users/garethsb-sony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garethsb-sony/subscriptions","organizations_url":"https://api.github.com/users/garethsb-sony/orgs","repos_url":"https://api.github.com/users/garethsb-sony/repos","events_url":"https://api.github.com/users/garethsb-sony/events{/privacy}","received_events_url":"https://api.github.com/users/garethsb-sony/received_events","type":"User","site_admin":false},"repo":{"id":107283412,"name":"cpprestsdk","full_name":"garethsb-sony/cpprestsdk","owner":{"login":"garethsb-sony","id":31761158,"avatar_url":"https://avatars3.githubusercontent.com/u/31761158?v=4","gravatar_id":"","url":"https://api.github.com/users/garethsb-sony","html_url":"https://github.com/garethsb-sony","followers_url":"https://api.github.com/users/garethsb-sony/followers","following_url":"https://api.github.com/users/garethsb-sony/following{/other_user}","gists_url":"https://api.github.com/users/garethsb-sony/gists{/gist_id}","starred_url":"https://api.github.com/users/garethsb-sony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garethsb-sony/subscriptions","organizations_url":"https://api.github.com/users/garethsb-sony/orgs","repos_url":"https://api.github.com/users/garethsb-sony/repos","events_url":"https://api.github.com/users/garethsb-sony/events{/privacy}","received_events_url":"https://api.github.com/users/garethsb-sony/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/garethsb-sony/cpprestsdk","description":"The C++ REST SDK is a Microsoft project for cloud-based client-server communication in native code using a modern asynchronous C++ API design. This project aims to help C++ developers connect to and interact with services.","fork":true,"url":"https://api.github.com/repos/garethsb-sony/cpprestsdk","forks_url":"https://api.github.com/repos/garethsb-sony/cpprestsdk/forks","keys_url":"https://api.github.com/repos/garethsb-sony/cpprestsdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/garethsb-sony/cpprestsdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/garethsb-sony/cpprestsdk/teams","hooks_url":"https://api.github.com/repos/garethsb-sony/cpprestsdk/hooks","issue_events_url":"https://api.github.com/repos/garethsb-sony/cpprestsdk/issues/events{/number}","events_url":"https://api.github.com/repos/garethsb-sony/cpprestsdk/events","assignees_url":"https://api.github.com/repos/garethsb-sony/cpprestsdk/assignees{/user}","branches_url":"https://api.github.com/repos/garethsb-sony/cpprestsdk/branches{/branch}","tags_url":"https://api.github.com/repos/garethsb-sony/cpprestsdk/tags","blobs_url":"https://api.github.com/repos/garethsb-sony/cpprestsdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/garethsb-sony/cpprestsdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/garethsb-sony/cpprestsdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/garethsb-sony/cpprestsdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/garethsb-sony/cpprestsdk/statuses/{sha}","languages_url":"https://api.github.com/repos/garethsb-sony/cpprestsdk/languages","stargazers_url":"https://api.github.com/repos/garethsb-sony/cpprestsdk/stargazers","contributors_url":"https://api.github.com/repos/garethsb-sony/cpprestsdk/contributors","subscribers_url":"https://api.github.com/repos/garethsb-sony/cpprestsdk/subscribers","subscription_url":"https://api.github.com/repos/garethsb-sony/cpprestsdk/subscription","commits_url":"https://api.github.com/repos/garethsb-sony/cpprestsdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/garethsb-sony/cpprestsdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/garethsb-sony/cpprestsdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/garethsb-sony/cpprestsdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/garethsb-sony/cpprestsdk/contents/{+path}","compare_url":"https://api.github.com/repos/garethsb-sony/cpprestsdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/garethsb-sony/cpprestsdk/merges","archive_url":"https://api.github.com/repos/garethsb-sony/cpprestsdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/garethsb-sony/cpprestsdk/downloads","issues_url":"https://api.github.com/repos/garethsb-sony/cpprestsdk/issues{/number}","pulls_url":"https://api.github.com/repos/garethsb-sony/cpprestsdk/pulls{/number}","milestones_url":"https://api.github.com/repos/garethsb-sony/cpprestsdk/milestones{/number}","notifications_url":"https://api.github.com/repos/garethsb-sony/cpprestsdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/garethsb-sony/cpprestsdk/labels{/name}","releases_url":"https://api.github.com/repos/garethsb-sony/cpprestsdk/releases{/id}","deployments_url":"https://api.github.com/repos/garethsb-sony/cpprestsdk/deployments","created_at":"2017-10-17T14:54:02Z","updated_at":"2017-10-17T14:54:07Z","pushed_at":"2018-02-07T14:19:58Z","git_url":"git://github.com/garethsb-sony/cpprestsdk.git","ssh_url":"git@github.com:garethsb-sony/cpprestsdk.git","clone_url":"https://github.com/garethsb-sony/cpprestsdk.git","svn_url":"https://github.com/garethsb-sony/cpprestsdk","homepage":"","size":9610,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"fea848e2a77563cf2a6f28f8eab396fd6e787fbf","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":23202799,"name":"cpprestsdk","full_name":"Microsoft/cpprestsdk","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/cpprestsdk","description":"The C++ REST SDK is a Microsoft project for cloud-based client-server communication in native code using a modern asynchronous C++ API design. This project aims to help C++ developers connect to and interact with services.","fork":false,"url":"https://api.github.com/repos/Microsoft/cpprestsdk","forks_url":"https://api.github.com/repos/Microsoft/cpprestsdk/forks","keys_url":"https://api.github.com/repos/Microsoft/cpprestsdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/cpprestsdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/cpprestsdk/teams","hooks_url":"https://api.github.com/repos/Microsoft/cpprestsdk/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/cpprestsdk/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/cpprestsdk/events","assignees_url":"https://api.github.com/repos/Microsoft/cpprestsdk/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/cpprestsdk/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/cpprestsdk/tags","blobs_url":"https://api.github.com/repos/Microsoft/cpprestsdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/cpprestsdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/cpprestsdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/cpprestsdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/cpprestsdk/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/cpprestsdk/languages","stargazers_url":"https://api.github.com/repos/Microsoft/cpprestsdk/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/cpprestsdk/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/cpprestsdk/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/cpprestsdk/subscription","commits_url":"https://api.github.com/repos/Microsoft/cpprestsdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/cpprestsdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/cpprestsdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/cpprestsdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/cpprestsdk/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/cpprestsdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/cpprestsdk/merges","archive_url":"https://api.github.com/repos/Microsoft/cpprestsdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/cpprestsdk/downloads","issues_url":"https://api.github.com/repos/Microsoft/cpprestsdk/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/cpprestsdk/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/cpprestsdk/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/cpprestsdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/cpprestsdk/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/cpprestsdk/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/cpprestsdk/deployments","created_at":"2014-08-21T20:57:45Z","updated_at":"2018-02-07T06:57:52Z","pushed_at":"2018-02-07T18:22:42Z","git_url":"git://github.com/Microsoft/cpprestsdk.git","ssh_url":"git@github.com:Microsoft/cpprestsdk.git","clone_url":"https://github.com/Microsoft/cpprestsdk.git","svn_url":"https://github.com/Microsoft/cpprestsdk","homepage":"","size":9548,"stargazers_count":2423,"watchers_count":2423,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":658,"mirror_url":null,"archived":false,"open_issues_count":339,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":658,"open_issues":339,"watchers":2423,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/cpprestsdk/pulls/693"},"html":{"href":"https://github.com/Microsoft/cpprestsdk/pull/693"},"issue":{"href":"https://api.github.com/repos/Microsoft/cpprestsdk/issues/693"},"comments":{"href":"https://api.github.com/repos/Microsoft/cpprestsdk/issues/693/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/cpprestsdk/pulls/693/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/cpprestsdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/cpprestsdk/pulls/693/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/cpprestsdk/statuses/35d40093fe785df1f3b36f98796e2fe64cf50dfd"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ras0219-msft","id":12301622,"avatar_url":"https://avatars2.githubusercontent.com/u/12301622?v=4","gravatar_id":"","url":"https://api.github.com/users/ras0219-msft","html_url":"https://github.com/ras0219-msft","followers_url":"https://api.github.com/users/ras0219-msft/followers","following_url":"https://api.github.com/users/ras0219-msft/following{/other_user}","gists_url":"https://api.github.com/users/ras0219-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/ras0219-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ras0219-msft/subscriptions","organizations_url":"https://api.github.com/users/ras0219-msft/orgs","repos_url":"https://api.github.com/users/ras0219-msft/repos","events_url":"https://api.github.com/users/ras0219-msft/events{/privacy}","received_events_url":"https://api.github.com/users/ras0219-msft/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":5,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"ras0219-msft"}}