{"action":"created","comment":{"url":"https://api.github.com/repos/status-im/status-go/pulls/comments/166905149","pull_request_review_id":95038036,"id":166905149,"diff_hunk":"@@ -332,15 +333,15 @@ func (s *WhisperMailboxSuite) startMailboxBackend() (*api.StatusBackend, func())\n \tmailboxBackend := api.NewStatusBackend()\n \tmailboxConfig, err := e2e.MakeTestNodeConfig(GetNetworkID())\n \ts.Require().NoError(err)\n-\tdatadir := \"../../.ethereumtest/mailbox/mailserver/\"\n+\tdatadir := filepath.Join(RootDir, \".ethereumtest/mailbox/mailserver\")\n \n \tmailboxConfig.LightEthConfig.Enabled = false\n \tmailboxConfig.WhisperConfig.Enabled = true\n-\tmailboxConfig.KeyStoreDir = \"../../.ethereumtest/mailbox/mailserver\"\n+\tmailboxConfig.KeyStoreDir = datadir\n \tmailboxConfig.WhisperConfig.EnableMailServer = true\n-\tmailboxConfig.WhisperConfig.IdentityFile = \"../../static/keys/wnodekey\"\n-\tmailboxConfig.WhisperConfig.PasswordFile = \"../../static/keys/wnodepassword\"\n-\tmailboxConfig.WhisperConfig.DataDir = \"../../.ethereumtest/mailbox/mailserver/data\"\n+\tmailboxConfig.WhisperConfig.IdentityFile = filepath.Join(RootDir, \"/static/keys/wnodekey\")\n+\tmailboxConfig.WhisperConfig.PasswordFile = filepath.Join(RootDir, \"/static/keys/wnodepassword\")\n+\tmailboxConfig.WhisperConfig.DataDir = datadir + \"/data\"","path":"t/e2e/whisper/whisper_mailbox_test.go","position":47,"original_position":47,"commit_id":"9861042b1f8aadf002ba8ae91d235457718cd79c","original_commit_id":"9861042b1f8aadf002ba8ae91d235457718cd79c","user":{"login":"mandrigin","id":466427,"avatar_url":"https://avatars0.githubusercontent.com/u/466427?v=4","gravatar_id":"","url":"https://api.github.com/users/mandrigin","html_url":"https://github.com/mandrigin","followers_url":"https://api.github.com/users/mandrigin/followers","following_url":"https://api.github.com/users/mandrigin/following{/other_user}","gists_url":"https://api.github.com/users/mandrigin/gists{/gist_id}","starred_url":"https://api.github.com/users/mandrigin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandrigin/subscriptions","organizations_url":"https://api.github.com/users/mandrigin/orgs","repos_url":"https://api.github.com/users/mandrigin/repos","events_url":"https://api.github.com/users/mandrigin/events{/privacy}","received_events_url":"https://api.github.com/users/mandrigin/received_events","type":"User","site_admin":false},"body":"yeah, let's use `Join` everywhere","created_at":"2018-02-08T11:23:23Z","updated_at":"2018-02-08T11:23:34Z","html_url":"https://github.com/status-im/status-go/pull/629#discussion_r166905149","pull_request_url":"https://api.github.com/repos/status-im/status-go/pulls/629","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/status-im/status-go/pulls/comments/166905149"},"html":{"href":"https://github.com/status-im/status-go/pull/629#discussion_r166905149"},"pull_request":{"href":"https://api.github.com/repos/status-im/status-go/pulls/629"}},"in_reply_to_id":166879065},"pull_request":{"url":"https://api.github.com/repos/status-im/status-go/pulls/629","id":167692570,"html_url":"https://github.com/status-im/status-go/pull/629","diff_url":"https://github.com/status-im/status-go/pull/629.diff","patch_url":"https://github.com/status-im/status-go/pull/629.patch","issue_url":"https://api.github.com/repos/status-im/status-go/issues/629","number":629,"state":"open","locked":false,"title":"Group tests in a dedicated testing package","user":{"login":"sekl","id":1530700,"avatar_url":"https://avatars0.githubusercontent.com/u/1530700?v=4","gravatar_id":"","url":"https://api.github.com/users/sekl","html_url":"https://github.com/sekl","followers_url":"https://api.github.com/users/sekl/followers","following_url":"https://api.github.com/users/sekl/following{/other_user}","gists_url":"https://api.github.com/users/sekl/gists{/gist_id}","starred_url":"https://api.github.com/users/sekl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sekl/subscriptions","organizations_url":"https://api.github.com/users/sekl/orgs","repos_url":"https://api.github.com/users/sekl/repos","events_url":"https://api.github.com/users/sekl/events{/privacy}","received_events_url":"https://api.github.com/users/sekl/received_events","type":"User","site_admin":false},"body":"Moved `e2e` and `testing` directories to a new package `t`.\r\n\r\nAll I did was moving the files and updating imports and docs where necessary. Please let me know if this is as intended or if I missed anything. \r\n\r\nCloses #620\r\n","created_at":"2018-02-07T13:28:58Z","updated_at":"2018-02-08T11:23:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"985c4ef94bd89e85d1f7019557b3668e1dfb2f0b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dshulyak","id":1964576,"avatar_url":"https://avatars2.githubusercontent.com/u/1964576?v=4","gravatar_id":"","url":"https://api.github.com/users/dshulyak","html_url":"https://github.com/dshulyak","followers_url":"https://api.github.com/users/dshulyak/followers","following_url":"https://api.github.com/users/dshulyak/following{/other_user}","gists_url":"https://api.github.com/users/dshulyak/gists{/gist_id}","starred_url":"https://api.github.com/users/dshulyak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dshulyak/subscriptions","organizations_url":"https://api.github.com/users/dshulyak/orgs","repos_url":"https://api.github.com/users/dshulyak/repos","events_url":"https://api.github.com/users/dshulyak/events{/privacy}","received_events_url":"https://api.github.com/users/dshulyak/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/status-im/status-go/pulls/629/commits","review_comments_url":"https://api.github.com/repos/status-im/status-go/pulls/629/comments","review_comment_url":"https://api.github.com/repos/status-im/status-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/status-im/status-go/issues/629/comments","statuses_url":"https://api.github.com/repos/status-im/status-go/statuses/9861042b1f8aadf002ba8ae91d235457718cd79c","head":{"label":"sekl:issue-620-group-tests","ref":"issue-620-group-tests","sha":"9861042b1f8aadf002ba8ae91d235457718cd79c","user":{"login":"sekl","id":1530700,"avatar_url":"https://avatars0.githubusercontent.com/u/1530700?v=4","gravatar_id":"","url":"https://api.github.com/users/sekl","html_url":"https://github.com/sekl","followers_url":"https://api.github.com/users/sekl/followers","following_url":"https://api.github.com/users/sekl/following{/other_user}","gists_url":"https://api.github.com/users/sekl/gists{/gist_id}","starred_url":"https://api.github.com/users/sekl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sekl/subscriptions","organizations_url":"https://api.github.com/users/sekl/orgs","repos_url":"https://api.github.com/users/sekl/repos","events_url":"https://api.github.com/users/sekl/events{/privacy}","received_events_url":"https://api.github.com/users/sekl/received_events","type":"User","site_admin":false},"repo":{"id":119792039,"name":"status-go","full_name":"sekl/status-go","owner":{"login":"sekl","id":1530700,"avatar_url":"https://avatars0.githubusercontent.com/u/1530700?v=4","gravatar_id":"","url":"https://api.github.com/users/sekl","html_url":"https://github.com/sekl","followers_url":"https://api.github.com/users/sekl/followers","following_url":"https://api.github.com/users/sekl/following{/other_user}","gists_url":"https://api.github.com/users/sekl/gists{/gist_id}","starred_url":"https://api.github.com/users/sekl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sekl/subscriptions","organizations_url":"https://api.github.com/users/sekl/orgs","repos_url":"https://api.github.com/users/sekl/repos","events_url":"https://api.github.com/users/sekl/events{/privacy}","received_events_url":"https://api.github.com/users/sekl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sekl/status-go","description":"The Status module that consumes go-ethereum","fork":true,"url":"https://api.github.com/repos/sekl/status-go","forks_url":"https://api.github.com/repos/sekl/status-go/forks","keys_url":"https://api.github.com/repos/sekl/status-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sekl/status-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sekl/status-go/teams","hooks_url":"https://api.github.com/repos/sekl/status-go/hooks","issue_events_url":"https://api.github.com/repos/sekl/status-go/issues/events{/number}","events_url":"https://api.github.com/repos/sekl/status-go/events","assignees_url":"https://api.github.com/repos/sekl/status-go/assignees{/user}","branches_url":"https://api.github.com/repos/sekl/status-go/branches{/branch}","tags_url":"https://api.github.com/repos/sekl/status-go/tags","blobs_url":"https://api.github.com/repos/sekl/status-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sekl/status-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sekl/status-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/sekl/status-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sekl/status-go/statuses/{sha}","languages_url":"https://api.github.com/repos/sekl/status-go/languages","stargazers_url":"https://api.github.com/repos/sekl/status-go/stargazers","contributors_url":"https://api.github.com/repos/sekl/status-go/contributors","subscribers_url":"https://api.github.com/repos/sekl/status-go/subscribers","subscription_url":"https://api.github.com/repos/sekl/status-go/subscription","commits_url":"https://api.github.com/repos/sekl/status-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/sekl/status-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/sekl/status-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/sekl/status-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/sekl/status-go/contents/{+path}","compare_url":"https://api.github.com/repos/sekl/status-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sekl/status-go/merges","archive_url":"https://api.github.com/repos/sekl/status-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sekl/status-go/downloads","issues_url":"https://api.github.com/repos/sekl/status-go/issues{/number}","pulls_url":"https://api.github.com/repos/sekl/status-go/pulls{/number}","milestones_url":"https://api.github.com/repos/sekl/status-go/milestones{/number}","notifications_url":"https://api.github.com/repos/sekl/status-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sekl/status-go/labels{/name}","releases_url":"https://api.github.com/repos/sekl/status-go/releases{/id}","deployments_url":"https://api.github.com/repos/sekl/status-go/deployments","created_at":"2018-02-01T06:16:21Z","updated_at":"2018-02-01T06:16:23Z","pushed_at":"2018-02-07T13:58:32Z","git_url":"git://github.com/sekl/status-go.git","ssh_url":"git@github.com:sekl/status-go.git","clone_url":"https://github.com/sekl/status-go.git","svn_url":"https://github.com/sekl/status-go","homepage":"https://status.im","size":34504,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"status-im:develop","ref":"develop","sha":"ca719af71c2ecdc793673820a039b46d96e1ec7d","user":{"login":"status-im","id":11767950,"avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"repo":{"id":61047867,"name":"status-go","full_name":"status-im/status-go","owner":{"login":"status-im","id":11767950,"avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/status-im/status-go","description":"The Status module that consumes go-ethereum","fork":false,"url":"https://api.github.com/repos/status-im/status-go","forks_url":"https://api.github.com/repos/status-im/status-go/forks","keys_url":"https://api.github.com/repos/status-im/status-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/status-im/status-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/status-im/status-go/teams","hooks_url":"https://api.github.com/repos/status-im/status-go/hooks","issue_events_url":"https://api.github.com/repos/status-im/status-go/issues/events{/number}","events_url":"https://api.github.com/repos/status-im/status-go/events","assignees_url":"https://api.github.com/repos/status-im/status-go/assignees{/user}","branches_url":"https://api.github.com/repos/status-im/status-go/branches{/branch}","tags_url":"https://api.github.com/repos/status-im/status-go/tags","blobs_url":"https://api.github.com/repos/status-im/status-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/status-im/status-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/status-im/status-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/status-im/status-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/status-im/status-go/statuses/{sha}","languages_url":"https://api.github.com/repos/status-im/status-go/languages","stargazers_url":"https://api.github.com/repos/status-im/status-go/stargazers","contributors_url":"https://api.github.com/repos/status-im/status-go/contributors","subscribers_url":"https://api.github.com/repos/status-im/status-go/subscribers","subscription_url":"https://api.github.com/repos/status-im/status-go/subscription","commits_url":"https://api.github.com/repos/status-im/status-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/status-im/status-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/status-im/status-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/status-im/status-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/status-im/status-go/contents/{+path}","compare_url":"https://api.github.com/repos/status-im/status-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/status-im/status-go/merges","archive_url":"https://api.github.com/repos/status-im/status-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/status-im/status-go/downloads","issues_url":"https://api.github.com/repos/status-im/status-go/issues{/number}","pulls_url":"https://api.github.com/repos/status-im/status-go/pulls{/number}","milestones_url":"https://api.github.com/repos/status-im/status-go/milestones{/number}","notifications_url":"https://api.github.com/repos/status-im/status-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/status-im/status-go/labels{/name}","releases_url":"https://api.github.com/repos/status-im/status-go/releases{/id}","deployments_url":"https://api.github.com/repos/status-im/status-go/deployments","created_at":"2016-06-13T15:32:03Z","updated_at":"2018-02-07T18:28:49Z","pushed_at":"2018-02-08T10:43:26Z","git_url":"git://github.com/status-im/status-go.git","ssh_url":"git@github.com:status-im/status-go.git","clone_url":"https://github.com/status-im/status-go.git","svn_url":"https://github.com/status-im/status-go","homepage":"https://status.im","size":34522,"stargazers_count":322,"watchers_count":322,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":104,"mirror_url":null,"archived":false,"open_issues_count":61,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":104,"open_issues":61,"watchers":322,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/status-im/status-go/pulls/629"},"html":{"href":"https://github.com/status-im/status-go/pull/629"},"issue":{"href":"https://api.github.com/repos/status-im/status-go/issues/629"},"comments":{"href":"https://api.github.com/repos/status-im/status-go/issues/629/comments"},"review_comments":{"href":"https://api.github.com/repos/status-im/status-go/pulls/629/comments"},"review_comment":{"href":"https://api.github.com/repos/status-im/status-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/status-im/status-go/pulls/629/commits"},"statuses":{"href":"https://api.github.com/repos/status-im/status-go/statuses/9861042b1f8aadf002ba8ae91d235457718cd79c"}},"author_association":"NONE"}}
{"actor":{"display_login":"mandrigin"}}