{"action":"created","comment":{"url":"https://api.github.com/repos/php-geospatial/geospatial/pulls/comments/178757828","pull_request_review_id":108867183,"id":178757828,"diff_hunk":"@@ -460,7 +460,7 @@ geo_lat_long cartesian_to_polar(double x, double y, double z, geo_ellipsoid eli)\n \tdouble phi = atan2(z, p * (1 - eSq));\n \tdouble phiP = 2 * M_PI;\n \n-\twhile (abs(phi - phiP) > precision) {\n+\twhile (fabs(phi - phiP) > precision) {","path":"geospatial.c","position":5,"original_position":5,"commit_id":"db562571517d7778472f20730de78a9c161f15a4","original_commit_id":"db562571517d7778472f20730de78a9c161f15a4","user":{"login":"derickr","id":208074,"avatar_url":"https://avatars3.githubusercontent.com/u/208074?v=4","gravatar_id":"","url":"https://api.github.com/users/derickr","html_url":"https://github.com/derickr","followers_url":"https://api.github.com/users/derickr/followers","following_url":"https://api.github.com/users/derickr/following{/other_user}","gists_url":"https://api.github.com/users/derickr/gists{/gist_id}","starred_url":"https://api.github.com/users/derickr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derickr/subscriptions","organizations_url":"https://api.github.com/users/derickr/orgs","repos_url":"https://api.github.com/users/derickr/repos","events_url":"https://api.github.com/users/derickr/events{/privacy}","received_events_url":"https://api.github.com/users/derickr/received_events","type":"User","site_admin":false},"body":"That's fine, but it breaks a test if you change it. So either the test is wrong, or something else is going on.","created_at":"2018-04-03T09:06:59Z","updated_at":"2018-04-03T09:06:59Z","html_url":"https://github.com/php-geospatial/geospatial/pull/24#discussion_r178757828","pull_request_url":"https://api.github.com/repos/php-geospatial/geospatial/pulls/24","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/php-geospatial/geospatial/pulls/comments/178757828"},"html":{"href":"https://github.com/php-geospatial/geospatial/pull/24#discussion_r178757828"},"pull_request":{"href":"https://api.github.com/repos/php-geospatial/geospatial/pulls/24"}},"in_reply_to_id":173750229},"pull_request":{"url":"https://api.github.com/repos/php-geospatial/geospatial/pulls/24","id":174172977,"html_url":"https://github.com/php-geospatial/geospatial/pull/24","diff_url":"https://github.com/php-geospatial/geospatial/pull/24.diff","patch_url":"https://github.com/php-geospatial/geospatial/pull/24.patch","issue_url":"https://api.github.com/repos/php-geospatial/geospatial/issues/24","number":24,"state":"open","locked":false,"title":"Using fabs() function instead abs()","user":{"login":"xoptov","id":2604833,"avatar_url":"https://avatars2.githubusercontent.com/u/2604833?v=4","gravatar_id":"","url":"https://api.github.com/users/xoptov","html_url":"https://github.com/xoptov","followers_url":"https://api.github.com/users/xoptov/followers","following_url":"https://api.github.com/users/xoptov/following{/other_user}","gists_url":"https://api.github.com/users/xoptov/gists{/gist_id}","starred_url":"https://api.github.com/users/xoptov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xoptov/subscriptions","organizations_url":"https://api.github.com/users/xoptov/orgs","repos_url":"https://api.github.com/users/xoptov/repos","events_url":"https://api.github.com/users/xoptov/events{/privacy}","received_events_url":"https://api.github.com/users/xoptov/received_events","type":"User","site_admin":false},"body":"This fix resolving compilation warning when making so.","created_at":"2018-03-10T14:39:51Z","updated_at":"2018-04-03T09:06:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3449863813e48753c29f66356d6976f96eff084a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/php-geospatial/geospatial/pulls/24/commits","review_comments_url":"https://api.github.com/repos/php-geospatial/geospatial/pulls/24/comments","review_comment_url":"https://api.github.com/repos/php-geospatial/geospatial/pulls/comments{/number}","comments_url":"https://api.github.com/repos/php-geospatial/geospatial/issues/24/comments","statuses_url":"https://api.github.com/repos/php-geospatial/geospatial/statuses/db562571517d7778472f20730de78a9c161f15a4","head":{"label":"xoptov:hotfix-201803101717","ref":"hotfix-201803101717","sha":"db562571517d7778472f20730de78a9c161f15a4","user":{"login":"xoptov","id":2604833,"avatar_url":"https://avatars2.githubusercontent.com/u/2604833?v=4","gravatar_id":"","url":"https://api.github.com/users/xoptov","html_url":"https://github.com/xoptov","followers_url":"https://api.github.com/users/xoptov/followers","following_url":"https://api.github.com/users/xoptov/following{/other_user}","gists_url":"https://api.github.com/users/xoptov/gists{/gist_id}","starred_url":"https://api.github.com/users/xoptov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xoptov/subscriptions","organizations_url":"https://api.github.com/users/xoptov/orgs","repos_url":"https://api.github.com/users/xoptov/repos","events_url":"https://api.github.com/users/xoptov/events{/privacy}","received_events_url":"https://api.github.com/users/xoptov/received_events","type":"User","site_admin":false},"repo":{"id":124664219,"name":"geospatial","full_name":"xoptov/geospatial","owner":{"login":"xoptov","id":2604833,"avatar_url":"https://avatars2.githubusercontent.com/u/2604833?v=4","gravatar_id":"","url":"https://api.github.com/users/xoptov","html_url":"https://github.com/xoptov","followers_url":"https://api.github.com/users/xoptov/followers","following_url":"https://api.github.com/users/xoptov/following{/other_user}","gists_url":"https://api.github.com/users/xoptov/gists{/gist_id}","starred_url":"https://api.github.com/users/xoptov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xoptov/subscriptions","organizations_url":"https://api.github.com/users/xoptov/orgs","repos_url":"https://api.github.com/users/xoptov/repos","events_url":"https://api.github.com/users/xoptov/events{/privacy}","received_events_url":"https://api.github.com/users/xoptov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xoptov/geospatial","description":"PHP Extension to handle common geospatial functions.","fork":true,"url":"https://api.github.com/repos/xoptov/geospatial","forks_url":"https://api.github.com/repos/xoptov/geospatial/forks","keys_url":"https://api.github.com/repos/xoptov/geospatial/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xoptov/geospatial/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xoptov/geospatial/teams","hooks_url":"https://api.github.com/repos/xoptov/geospatial/hooks","issue_events_url":"https://api.github.com/repos/xoptov/geospatial/issues/events{/number}","events_url":"https://api.github.com/repos/xoptov/geospatial/events","assignees_url":"https://api.github.com/repos/xoptov/geospatial/assignees{/user}","branches_url":"https://api.github.com/repos/xoptov/geospatial/branches{/branch}","tags_url":"https://api.github.com/repos/xoptov/geospatial/tags","blobs_url":"https://api.github.com/repos/xoptov/geospatial/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xoptov/geospatial/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xoptov/geospatial/git/refs{/sha}","trees_url":"https://api.github.com/repos/xoptov/geospatial/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xoptov/geospatial/statuses/{sha}","languages_url":"https://api.github.com/repos/xoptov/geospatial/languages","stargazers_url":"https://api.github.com/repos/xoptov/geospatial/stargazers","contributors_url":"https://api.github.com/repos/xoptov/geospatial/contributors","subscribers_url":"https://api.github.com/repos/xoptov/geospatial/subscribers","subscription_url":"https://api.github.com/repos/xoptov/geospatial/subscription","commits_url":"https://api.github.com/repos/xoptov/geospatial/commits{/sha}","git_commits_url":"https://api.github.com/repos/xoptov/geospatial/git/commits{/sha}","comments_url":"https://api.github.com/repos/xoptov/geospatial/comments{/number}","issue_comment_url":"https://api.github.com/repos/xoptov/geospatial/issues/comments{/number}","contents_url":"https://api.github.com/repos/xoptov/geospatial/contents/{+path}","compare_url":"https://api.github.com/repos/xoptov/geospatial/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xoptov/geospatial/merges","archive_url":"https://api.github.com/repos/xoptov/geospatial/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xoptov/geospatial/downloads","issues_url":"https://api.github.com/repos/xoptov/geospatial/issues{/number}","pulls_url":"https://api.github.com/repos/xoptov/geospatial/pulls{/number}","milestones_url":"https://api.github.com/repos/xoptov/geospatial/milestones{/number}","notifications_url":"https://api.github.com/repos/xoptov/geospatial/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xoptov/geospatial/labels{/name}","releases_url":"https://api.github.com/repos/xoptov/geospatial/releases{/id}","deployments_url":"https://api.github.com/repos/xoptov/geospatial/deployments","created_at":"2018-03-10T14:37:26Z","updated_at":"2018-03-10T14:37:27Z","pushed_at":"2018-03-10T14:38:47Z","git_url":"git://github.com/xoptov/geospatial.git","ssh_url":"git@github.com:xoptov/geospatial.git","clone_url":"https://github.com/xoptov/geospatial.git","svn_url":"https://github.com/xoptov/geospatial","homepage":null,"size":103,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"php-geospatial:master","ref":"master","sha":"b6d963b93cddd0202122969db2842a24b99c0d7a","user":{"login":"php-geospatial","id":2486587,"avatar_url":"https://avatars1.githubusercontent.com/u/2486587?v=4","gravatar_id":"","url":"https://api.github.com/users/php-geospatial","html_url":"https://github.com/php-geospatial","followers_url":"https://api.github.com/users/php-geospatial/followers","following_url":"https://api.github.com/users/php-geospatial/following{/other_user}","gists_url":"https://api.github.com/users/php-geospatial/gists{/gist_id}","starred_url":"https://api.github.com/users/php-geospatial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-geospatial/subscriptions","organizations_url":"https://api.github.com/users/php-geospatial/orgs","repos_url":"https://api.github.com/users/php-geospatial/repos","events_url":"https://api.github.com/users/php-geospatial/events{/privacy}","received_events_url":"https://api.github.com/users/php-geospatial/received_events","type":"Organization","site_admin":false},"repo":{"id":6075685,"name":"geospatial","full_name":"php-geospatial/geospatial","owner":{"login":"php-geospatial","id":2486587,"avatar_url":"https://avatars1.githubusercontent.com/u/2486587?v=4","gravatar_id":"","url":"https://api.github.com/users/php-geospatial","html_url":"https://github.com/php-geospatial","followers_url":"https://api.github.com/users/php-geospatial/followers","following_url":"https://api.github.com/users/php-geospatial/following{/other_user}","gists_url":"https://api.github.com/users/php-geospatial/gists{/gist_id}","starred_url":"https://api.github.com/users/php-geospatial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-geospatial/subscriptions","organizations_url":"https://api.github.com/users/php-geospatial/orgs","repos_url":"https://api.github.com/users/php-geospatial/repos","events_url":"https://api.github.com/users/php-geospatial/events{/privacy}","received_events_url":"https://api.github.com/users/php-geospatial/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/php-geospatial/geospatial","description":"PHP Extension to handle common geospatial functions.","fork":false,"url":"https://api.github.com/repos/php-geospatial/geospatial","forks_url":"https://api.github.com/repos/php-geospatial/geospatial/forks","keys_url":"https://api.github.com/repos/php-geospatial/geospatial/keys{/key_id}","collaborators_url":"https://api.github.com/repos/php-geospatial/geospatial/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/php-geospatial/geospatial/teams","hooks_url":"https://api.github.com/repos/php-geospatial/geospatial/hooks","issue_events_url":"https://api.github.com/repos/php-geospatial/geospatial/issues/events{/number}","events_url":"https://api.github.com/repos/php-geospatial/geospatial/events","assignees_url":"https://api.github.com/repos/php-geospatial/geospatial/assignees{/user}","branches_url":"https://api.github.com/repos/php-geospatial/geospatial/branches{/branch}","tags_url":"https://api.github.com/repos/php-geospatial/geospatial/tags","blobs_url":"https://api.github.com/repos/php-geospatial/geospatial/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/php-geospatial/geospatial/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/php-geospatial/geospatial/git/refs{/sha}","trees_url":"https://api.github.com/repos/php-geospatial/geospatial/git/trees{/sha}","statuses_url":"https://api.github.com/repos/php-geospatial/geospatial/statuses/{sha}","languages_url":"https://api.github.com/repos/php-geospatial/geospatial/languages","stargazers_url":"https://api.github.com/repos/php-geospatial/geospatial/stargazers","contributors_url":"https://api.github.com/repos/php-geospatial/geospatial/contributors","subscribers_url":"https://api.github.com/repos/php-geospatial/geospatial/subscribers","subscription_url":"https://api.github.com/repos/php-geospatial/geospatial/subscription","commits_url":"https://api.github.com/repos/php-geospatial/geospatial/commits{/sha}","git_commits_url":"https://api.github.com/repos/php-geospatial/geospatial/git/commits{/sha}","comments_url":"https://api.github.com/repos/php-geospatial/geospatial/comments{/number}","issue_comment_url":"https://api.github.com/repos/php-geospatial/geospatial/issues/comments{/number}","contents_url":"https://api.github.com/repos/php-geospatial/geospatial/contents/{+path}","compare_url":"https://api.github.com/repos/php-geospatial/geospatial/compare/{base}...{head}","merges_url":"https://api.github.com/repos/php-geospatial/geospatial/merges","archive_url":"https://api.github.com/repos/php-geospatial/geospatial/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/php-geospatial/geospatial/downloads","issues_url":"https://api.github.com/repos/php-geospatial/geospatial/issues{/number}","pulls_url":"https://api.github.com/repos/php-geospatial/geospatial/pulls{/number}","milestones_url":"https://api.github.com/repos/php-geospatial/geospatial/milestones{/number}","notifications_url":"https://api.github.com/repos/php-geospatial/geospatial/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/php-geospatial/geospatial/labels{/name}","releases_url":"https://api.github.com/repos/php-geospatial/geospatial/releases{/id}","deployments_url":"https://api.github.com/repos/php-geospatial/geospatial/deployments","created_at":"2012-10-04T13:28:46Z","updated_at":"2018-03-13T22:54:51Z","pushed_at":"2018-03-10T14:39:52Z","git_url":"git://github.com/php-geospatial/geospatial.git","ssh_url":"git@github.com:php-geospatial/geospatial.git","clone_url":"https://github.com/php-geospatial/geospatial.git","svn_url":"https://github.com/php-geospatial/geospatial","homepage":null,"size":99,"stargazers_count":33,"watchers_count":33,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":18,"open_issues":2,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/php-geospatial/geospatial/pulls/24"},"html":{"href":"https://github.com/php-geospatial/geospatial/pull/24"},"issue":{"href":"https://api.github.com/repos/php-geospatial/geospatial/issues/24"},"comments":{"href":"https://api.github.com/repos/php-geospatial/geospatial/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/php-geospatial/geospatial/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/php-geospatial/geospatial/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/php-geospatial/geospatial/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/php-geospatial/geospatial/statuses/db562571517d7778472f20730de78a9c161f15a4"}},"author_association":"NONE"}}
{"actor":{"display_login":"derickr"}}