{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/175586316","pull_request_review_id":105138275,"id":175586316,"diff_hunk":"@@ -682,6 +692,22 @@ export class AmpAnalytics extends AMP.BaseElement {\n     });\n   }\n \n+  /**\n+   * Returns the last time resource timing was reported for the spec and\n+   * updates the time for future calls.\n+   * Note that the timestamp is stored on the resourceTimingSpec.\n+   * @param {!JsonObject} resourceTimingSpec\n+   * @private","path":"extensions/amp-analytics/0.1/amp-analytics.js","position":26,"original_position":26,"commit_id":"d8a63c8b52c6f01cfcc1d9623b1ab115c1644b54","original_commit_id":"d8a63c8b52c6f01cfcc1d9623b1ab115c1644b54","user":{"login":"zhouyx","id":5419904,"avatar_url":"https://avatars0.githubusercontent.com/u/5419904?v=4","gravatar_id":"","url":"https://api.github.com/users/zhouyx","html_url":"https://github.com/zhouyx","followers_url":"https://api.github.com/users/zhouyx/followers","following_url":"https://api.github.com/users/zhouyx/following{/other_user}","gists_url":"https://api.github.com/users/zhouyx/gists{/gist_id}","starred_url":"https://api.github.com/users/zhouyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhouyx/subscriptions","organizations_url":"https://api.github.com/users/zhouyx/orgs","repos_url":"https://api.github.com/users/zhouyx/repos","events_url":"https://api.github.com/users/zhouyx/events{/privacy}","received_events_url":"https://api.github.com/users/zhouyx/received_events","type":"User","site_admin":false},"body":"nit: @return {number}","created_at":"2018-03-19T21:08:57Z","updated_at":"2018-03-19T21:16:31Z","html_url":"https://github.com/ampproject/amphtml/pull/13912#discussion_r175586316","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/13912","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/175586316"},"html":{"href":"https://github.com/ampproject/amphtml/pull/13912#discussion_r175586316"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/13912"}}},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/13912","id":174131163,"html_url":"https://github.com/ampproject/amphtml/pull/13912","diff_url":"https://github.com/ampproject/amphtml/pull/13912.diff","patch_url":"https://github.com/ampproject/amphtml/pull/13912.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/13912","number":13912,"state":"open","locked":false,"title":"Enforce that resource timing metrics are reported only once & remove the ini-load restriction","user":{"login":"warrengm","id":5326842,"avatar_url":"https://avatars2.githubusercontent.com/u/5326842?v=4","gravatar_id":"","url":"https://api.github.com/users/warrengm","html_url":"https://github.com/warrengm","followers_url":"https://api.github.com/users/warrengm/followers","following_url":"https://api.github.com/users/warrengm/following{/other_user}","gists_url":"https://api.github.com/users/warrengm/gists{/gist_id}","starred_url":"https://api.github.com/users/warrengm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warrengm/subscriptions","organizations_url":"https://api.github.com/users/warrengm/orgs","repos_url":"https://api.github.com/users/warrengm/repos","events_url":"https://api.github.com/users/warrengm/events{/privacy}","received_events_url":"https://api.github.com/users/warrengm/received_events","type":"User","site_admin":false},"body":"This PR allows resource timing metrics to be reported on any trigger, not just `ini-load`. There are some changes to prevent duplicate reporting on the same trigger (e.g. on timers). Note that `resourceTimingSpec` is currently only a trigger-level configuration.\r\n\r\nThis also adds a `responseAfter` field to `resourceTimingSpec` which can be used to filter entries that were downloaded after a specific time. Right now `responseAfter` only accepts integer values so it isn't very useful. In the future, it could be possible to specify something like: `\"responseAfter\": \"ini-load\"`.\r\n\r\nSee the I2I (#12411) for more background.\r\n\r\nI'll work on docs after this PR.","created_at":"2018-03-09T23:12:36Z","updated_at":"2018-03-19T21:16:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03e80d2c74efe8b29cbb1621a59b1b6f91f55dc5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":284397641,"url":"https://api.github.com/repos/ampproject/amphtml/labels/Category:%20Analytics","name":"Category: Analytics","color":"1d76db","default":false},{"id":596633554,"url":"https://api.github.com/repos/ampproject/amphtml/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/13912/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/13912/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/13912/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/d8a63c8b52c6f01cfcc1d9623b1ab115c1644b54","head":{"label":"warrengm:resource_timing_analytics","ref":"resource_timing_analytics","sha":"d8a63c8b52c6f01cfcc1d9623b1ab115c1644b54","user":{"login":"warrengm","id":5326842,"avatar_url":"https://avatars2.githubusercontent.com/u/5326842?v=4","gravatar_id":"","url":"https://api.github.com/users/warrengm","html_url":"https://github.com/warrengm","followers_url":"https://api.github.com/users/warrengm/followers","following_url":"https://api.github.com/users/warrengm/following{/other_user}","gists_url":"https://api.github.com/users/warrengm/gists{/gist_id}","starred_url":"https://api.github.com/users/warrengm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warrengm/subscriptions","organizations_url":"https://api.github.com/users/warrengm/orgs","repos_url":"https://api.github.com/users/warrengm/repos","events_url":"https://api.github.com/users/warrengm/events{/privacy}","received_events_url":"https://api.github.com/users/warrengm/received_events","type":"User","site_admin":false},"repo":{"id":109718309,"name":"amphtml","full_name":"warrengm/amphtml","owner":{"login":"warrengm","id":5326842,"avatar_url":"https://avatars2.githubusercontent.com/u/5326842?v=4","gravatar_id":"","url":"https://api.github.com/users/warrengm","html_url":"https://github.com/warrengm","followers_url":"https://api.github.com/users/warrengm/followers","following_url":"https://api.github.com/users/warrengm/following{/other_user}","gists_url":"https://api.github.com/users/warrengm/gists{/gist_id}","starred_url":"https://api.github.com/users/warrengm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warrengm/subscriptions","organizations_url":"https://api.github.com/users/warrengm/orgs","repos_url":"https://api.github.com/users/warrengm/repos","events_url":"https://api.github.com/users/warrengm/events{/privacy}","received_events_url":"https://api.github.com/users/warrengm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/warrengm/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/warrengm/amphtml","forks_url":"https://api.github.com/repos/warrengm/amphtml/forks","keys_url":"https://api.github.com/repos/warrengm/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/warrengm/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/warrengm/amphtml/teams","hooks_url":"https://api.github.com/repos/warrengm/amphtml/hooks","issue_events_url":"https://api.github.com/repos/warrengm/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/warrengm/amphtml/events","assignees_url":"https://api.github.com/repos/warrengm/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/warrengm/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/warrengm/amphtml/tags","blobs_url":"https://api.github.com/repos/warrengm/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/warrengm/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/warrengm/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/warrengm/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/warrengm/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/warrengm/amphtml/languages","stargazers_url":"https://api.github.com/repos/warrengm/amphtml/stargazers","contributors_url":"https://api.github.com/repos/warrengm/amphtml/contributors","subscribers_url":"https://api.github.com/repos/warrengm/amphtml/subscribers","subscription_url":"https://api.github.com/repos/warrengm/amphtml/subscription","commits_url":"https://api.github.com/repos/warrengm/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/warrengm/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/warrengm/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/warrengm/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/warrengm/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/warrengm/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/warrengm/amphtml/merges","archive_url":"https://api.github.com/repos/warrengm/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/warrengm/amphtml/downloads","issues_url":"https://api.github.com/repos/warrengm/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/warrengm/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/warrengm/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/warrengm/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/warrengm/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/warrengm/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/warrengm/amphtml/deployments","created_at":"2017-11-06T16:10:03Z","updated_at":"2017-11-06T16:10:14Z","pushed_at":"2018-03-14T18:18:03Z","git_url":"git://github.com/warrengm/amphtml.git","ssh_url":"git@github.com:warrengm/amphtml.git","clone_url":"https://github.com/warrengm/amphtml.git","svn_url":"https://github.com/warrengm/amphtml","homepage":"https://www.ampproject.org","size":411805,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"5e1d51e6b69d9735dc16e80e2f114c083e813e46","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2018-03-19T21:04:09Z","pushed_at":"2018-03-19T21:13:12Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://www.ampproject.org","size":415146,"stargazers_count":11330,"watchers_count":11330,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2295,"mirror_url":null,"archived":false,"open_issues_count":1206,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2295,"open_issues":1206,"watchers":11330,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/13912"},"html":{"href":"https://github.com/ampproject/amphtml/pull/13912"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/13912"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/13912/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/13912/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/13912/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/d8a63c8b52c6f01cfcc1d9623b1ab115c1644b54"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"zhouyx"}}