{"action":"created","comment":{"url":"https://api.github.com/repos/oppia/oppia/pulls/comments/199331229","pull_request_review_id":133435171,"id":199331229,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTMzMTIyOQ==","diff_hunk":"@@ -458,13 +460,127 @@ def convert_to_text_angular(html_data):\n     return unicode(soup).replace('<br/>', '<br>')\n \n \n-def convert_tag_contents_to_text_angular(html_data):\n+def convert_to_ck_editor(html_data):\n+    \"\"\"This function converts the html to CKEditor supported format.\n+\n+    Args:\n+        html_data: str. HTML string to be converted.\n+\n+    Returns:\n+        str. The converted HTML string.\n+    \"\"\"\n+    if not len(html_data):\n+        return html_data\n+\n+    # <br> is replaced with <br/> before conversion because BeautifulSoup\n+    # in some cases adds </br> closing tag and br is reported as parent\n+    # of other tags which produces issues in migration.\n+    html_data = html_data.replace('<br>', '<br/>')\n+\n+    # To convert the rich text content within tabs and collapsible components","path":"core/domain/html_cleaner.py","position":42,"original_position":42,"commit_id":"5db0735a91fc6f91521f00357c7999fe063f8056","original_commit_id":"5db0735a91fc6f91521f00357c7999fe063f8056","user":{"login":"AllanYangZhou","id":8732147,"node_id":"MDQ6VXNlcjg3MzIxNDc=","avatar_url":"https://avatars1.githubusercontent.com/u/8732147?v=4","gravatar_id":"","url":"https://api.github.com/users/AllanYangZhou","html_url":"https://github.com/AllanYangZhou","followers_url":"https://api.github.com/users/AllanYangZhou/followers","following_url":"https://api.github.com/users/AllanYangZhou/following{/other_user}","gists_url":"https://api.github.com/users/AllanYangZhou/gists{/gist_id}","starred_url":"https://api.github.com/users/AllanYangZhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AllanYangZhou/subscriptions","organizations_url":"https://api.github.com/users/AllanYangZhou/orgs","repos_url":"https://api.github.com/users/AllanYangZhou/repos","events_url":"https://api.github.com/users/AllanYangZhou/events{/privacy}","received_events_url":"https://api.github.com/users/AllanYangZhou/received_events","type":"User","site_admin":false},"body":"Minor nit: drop the word `To`, e.g.: `Convert the rich text...`","created_at":"2018-06-30T20:09:02Z","updated_at":"2018-06-30T20:33:22Z","html_url":"https://github.com/oppia/oppia/pull/5169#discussion_r199331229","pull_request_url":"https://api.github.com/repos/oppia/oppia/pulls/5169","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments/199331229"},"html":{"href":"https://github.com/oppia/oppia/pull/5169#discussion_r199331229"},"pull_request":{"href":"https://api.github.com/repos/oppia/oppia/pulls/5169"}}},"pull_request":{"url":"https://api.github.com/repos/oppia/oppia/pulls/5169","id":198390820,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MzkwODIw","html_url":"https://github.com/oppia/oppia/pull/5169","diff_url":"https://github.com/oppia/oppia/pull/5169.diff","patch_url":"https://github.com/oppia/oppia/pull/5169.patch","issue_url":"https://api.github.com/repos/oppia/oppia/issues/5169","number":5169,"state":"open","locked":false,"title":"Added MigrationValidation one-off job for CKEditor - Milestone 2","user":{"login":"bansalnitish","id":22434689,"node_id":"MDQ6VXNlcjIyNDM0Njg5","avatar_url":"https://avatars1.githubusercontent.com/u/22434689?v=4","gravatar_id":"","url":"https://api.github.com/users/bansalnitish","html_url":"https://github.com/bansalnitish","followers_url":"https://api.github.com/users/bansalnitish/followers","following_url":"https://api.github.com/users/bansalnitish/following{/other_user}","gists_url":"https://api.github.com/users/bansalnitish/gists{/gist_id}","starred_url":"https://api.github.com/users/bansalnitish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bansalnitish/subscriptions","organizations_url":"https://api.github.com/users/bansalnitish/orgs","repos_url":"https://api.github.com/users/bansalnitish/repos","events_url":"https://api.github.com/users/bansalnitish/events{/privacy}","received_events_url":"https://api.github.com/users/bansalnitish/received_events","type":"User","site_admin":false},"body":"This one-off job converts the TextAngular html content into a form compatible with CKEditor, and outputs the invalid strings (if they exist) after migration.","created_at":"2018-06-29T18:25:16Z","updated_at":"2018-06-30T20:33:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8fcacd2c2caca652ed52ed22980339886d4abd8a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/oppia/oppia/pulls/5169/commits","review_comments_url":"https://api.github.com/repos/oppia/oppia/pulls/5169/comments","review_comment_url":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oppia/oppia/issues/5169/comments","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/5db0735a91fc6f91521f00357c7999fe063f8056","head":{"label":"bansalnitish:migration-validation","ref":"migration-validation","sha":"5db0735a91fc6f91521f00357c7999fe063f8056","user":{"login":"bansalnitish","id":22434689,"node_id":"MDQ6VXNlcjIyNDM0Njg5","avatar_url":"https://avatars1.githubusercontent.com/u/22434689?v=4","gravatar_id":"","url":"https://api.github.com/users/bansalnitish","html_url":"https://github.com/bansalnitish","followers_url":"https://api.github.com/users/bansalnitish/followers","following_url":"https://api.github.com/users/bansalnitish/following{/other_user}","gists_url":"https://api.github.com/users/bansalnitish/gists{/gist_id}","starred_url":"https://api.github.com/users/bansalnitish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bansalnitish/subscriptions","organizations_url":"https://api.github.com/users/bansalnitish/orgs","repos_url":"https://api.github.com/users/bansalnitish/repos","events_url":"https://api.github.com/users/bansalnitish/events{/privacy}","received_events_url":"https://api.github.com/users/bansalnitish/received_events","type":"User","site_admin":false},"repo":{"id":118839208,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg4MzkyMDg=","name":"oppia","full_name":"bansalnitish/oppia","owner":{"login":"bansalnitish","id":22434689,"node_id":"MDQ6VXNlcjIyNDM0Njg5","avatar_url":"https://avatars1.githubusercontent.com/u/22434689?v=4","gravatar_id":"","url":"https://api.github.com/users/bansalnitish","html_url":"https://github.com/bansalnitish","followers_url":"https://api.github.com/users/bansalnitish/followers","following_url":"https://api.github.com/users/bansalnitish/following{/other_user}","gists_url":"https://api.github.com/users/bansalnitish/gists{/gist_id}","starred_url":"https://api.github.com/users/bansalnitish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bansalnitish/subscriptions","organizations_url":"https://api.github.com/users/bansalnitish/orgs","repos_url":"https://api.github.com/users/bansalnitish/repos","events_url":"https://api.github.com/users/bansalnitish/events{/privacy}","received_events_url":"https://api.github.com/users/bansalnitish/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bansalnitish/oppia","description":"Tool for collaboratively building interactive lessons.","fork":true,"url":"https://api.github.com/repos/bansalnitish/oppia","forks_url":"https://api.github.com/repos/bansalnitish/oppia/forks","keys_url":"https://api.github.com/repos/bansalnitish/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bansalnitish/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bansalnitish/oppia/teams","hooks_url":"https://api.github.com/repos/bansalnitish/oppia/hooks","issue_events_url":"https://api.github.com/repos/bansalnitish/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/bansalnitish/oppia/events","assignees_url":"https://api.github.com/repos/bansalnitish/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/bansalnitish/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/bansalnitish/oppia/tags","blobs_url":"https://api.github.com/repos/bansalnitish/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bansalnitish/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bansalnitish/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/bansalnitish/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bansalnitish/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/bansalnitish/oppia/languages","stargazers_url":"https://api.github.com/repos/bansalnitish/oppia/stargazers","contributors_url":"https://api.github.com/repos/bansalnitish/oppia/contributors","subscribers_url":"https://api.github.com/repos/bansalnitish/oppia/subscribers","subscription_url":"https://api.github.com/repos/bansalnitish/oppia/subscription","commits_url":"https://api.github.com/repos/bansalnitish/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/bansalnitish/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/bansalnitish/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/bansalnitish/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/bansalnitish/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/bansalnitish/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bansalnitish/oppia/merges","archive_url":"https://api.github.com/repos/bansalnitish/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bansalnitish/oppia/downloads","issues_url":"https://api.github.com/repos/bansalnitish/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/bansalnitish/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/bansalnitish/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/bansalnitish/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bansalnitish/oppia/labels{/name}","releases_url":"https://api.github.com/repos/bansalnitish/oppia/releases{/id}","deployments_url":"https://api.github.com/repos/bansalnitish/oppia/deployments","created_at":"2018-01-25T00:19:07Z","updated_at":"2018-06-29T09:47:34Z","pushed_at":"2018-06-30T19:11:28Z","git_url":"git://github.com/bansalnitish/oppia.git","ssh_url":"git@github.com:bansalnitish/oppia.git","clone_url":"https://github.com/bansalnitish/oppia.git","svn_url":"https://github.com/bansalnitish/oppia","homepage":"https://www.oppia.org","size":104631,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"oppia:develop","ref":"develop","sha":"8dce68eddea73c8f768619ef90594476da47b96e","user":{"login":"oppia","id":11620230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjIwMjMw","avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"repo":{"id":40687563,"node_id":"MDEwOlJlcG9zaXRvcnk0MDY4NzU2Mw==","name":"oppia","full_name":"oppia/oppia","owner":{"login":"oppia","id":11620230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjIwMjMw","avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oppia/oppia","description":"Tool for collaboratively building interactive lessons.","fork":false,"url":"https://api.github.com/repos/oppia/oppia","forks_url":"https://api.github.com/repos/oppia/oppia/forks","keys_url":"https://api.github.com/repos/oppia/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oppia/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oppia/oppia/teams","hooks_url":"https://api.github.com/repos/oppia/oppia/hooks","issue_events_url":"https://api.github.com/repos/oppia/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/oppia/oppia/events","assignees_url":"https://api.github.com/repos/oppia/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/oppia/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/oppia/oppia/tags","blobs_url":"https://api.github.com/repos/oppia/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oppia/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oppia/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/oppia/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/oppia/oppia/languages","stargazers_url":"https://api.github.com/repos/oppia/oppia/stargazers","contributors_url":"https://api.github.com/repos/oppia/oppia/contributors","subscribers_url":"https://api.github.com/repos/oppia/oppia/subscribers","subscription_url":"https://api.github.com/repos/oppia/oppia/subscription","commits_url":"https://api.github.com/repos/oppia/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/oppia/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/oppia/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/oppia/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/oppia/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/oppia/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oppia/oppia/merges","archive_url":"https://api.github.com/repos/oppia/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oppia/oppia/downloads","issues_url":"https://api.github.com/repos/oppia/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/oppia/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/oppia/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/oppia/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oppia/oppia/labels{/name}","releases_url":"https://api.github.com/repos/oppia/oppia/releases{/id}","deployments_url":"https://api.github.com/repos/oppia/oppia/deployments","created_at":"2015-08-14T00:16:14Z","updated_at":"2018-06-30T09:03:56Z","pushed_at":"2018-06-30T19:11:30Z","git_url":"git://github.com/oppia/oppia.git","ssh_url":"git@github.com:oppia/oppia.git","clone_url":"https://github.com/oppia/oppia.git","svn_url":"https://github.com/oppia/oppia","homepage":"https://www.oppia.org","size":104674,"stargazers_count":680,"watchers_count":680,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":652,"mirror_url":null,"archived":false,"open_issues_count":332,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":652,"open_issues":332,"watchers":680,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/5169"},"html":{"href":"https://github.com/oppia/oppia/pull/5169"},"issue":{"href":"https://api.github.com/repos/oppia/oppia/issues/5169"},"comments":{"href":"https://api.github.com/repos/oppia/oppia/issues/5169/comments"},"review_comments":{"href":"https://api.github.com/repos/oppia/oppia/pulls/5169/comments"},"review_comment":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oppia/oppia/pulls/5169/commits"},"statuses":{"href":"https://api.github.com/repos/oppia/oppia/statuses/5db0735a91fc6f91521f00357c7999fe063f8056"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"AllanYangZhou"}}