{"action":"created","issue":{"url":"https://api.github.com/repos/openssl/openssl/issues/6883","repository_url":"https://api.github.com/repos/openssl/openssl","labels_url":"https://api.github.com/repos/openssl/openssl/issues/6883/labels{/name}","comments_url":"https://api.github.com/repos/openssl/openssl/issues/6883/comments","events_url":"https://api.github.com/repos/openssl/openssl/issues/6883/events","html_url":"https://github.com/openssl/openssl/pull/6883","id":348214939,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NjE1NDky","number":6883,"title":"crypto/threads_*: remove CRYPTO_atomic_{read|write}.","user":{"login":"dot-asm","id":9038069,"node_id":"MDQ6VXNlcjkwMzgwNjk=","avatar_url":"https://avatars2.githubusercontent.com/u/9038069?v=4","gravatar_id":"","url":"https://api.github.com/users/dot-asm","html_url":"https://github.com/dot-asm","followers_url":"https://api.github.com/users/dot-asm/followers","following_url":"https://api.github.com/users/dot-asm/following{/other_user}","gists_url":"https://api.github.com/users/dot-asm/gists{/gist_id}","starred_url":"https://api.github.com/users/dot-asm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dot-asm/subscriptions","organizations_url":"https://api.github.com/users/dot-asm/orgs","repos_url":"https://api.github.com/users/dot-asm/repos","events_url":"https://api.github.com/users/dot-asm/events{/privacy}","received_events_url":"https://api.github.com/users/dot-asm/received_events","type":"User","site_admin":false},"labels":[{"id":872237503,"node_id":"MDU6TGFiZWw4NzIyMzc1MDM=","url":"https://api.github.com/repos/openssl/openssl/labels/1.1.1","name":"1.1.1","color":"bfdadc","default":false},{"id":441165144,"node_id":"MDU6TGFiZWw0NDExNjUxNDQ=","url":"https://api.github.com/repos/openssl/openssl/labels/master","name":"master","color":"bfdadc","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/openssl/openssl/milestones/9","html_url":"https://github.com/openssl/openssl/milestone/9","labels_url":"https://api.github.com/repos/openssl/openssl/milestones/9/labels","id":2145708,"node_id":"MDk6TWlsZXN0b25lMjE0NTcwOA==","number":9,"title":"1.1.1","description":"","creator":{"login":"levitte","id":698918,"node_id":"MDQ6VXNlcjY5ODkxOA==","avatar_url":"https://avatars1.githubusercontent.com/u/698918?v=4","gravatar_id":"","url":"https://api.github.com/users/levitte","html_url":"https://github.com/levitte","followers_url":"https://api.github.com/users/levitte/followers","following_url":"https://api.github.com/users/levitte/following{/other_user}","gists_url":"https://api.github.com/users/levitte/gists{/gist_id}","starred_url":"https://api.github.com/users/levitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levitte/subscriptions","organizations_url":"https://api.github.com/users/levitte/orgs","repos_url":"https://api.github.com/users/levitte/repos","events_url":"https://api.github.com/users/levitte/events{/privacy}","received_events_url":"https://api.github.com/users/levitte/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":424,"state":"open","created_at":"2016-11-19T09:18:52Z","updated_at":"2018-08-17T10:43:33Z","due_on":null,"closed_at":null},"comments":17,"created_at":"2018-08-07T08:16:38Z","updated_at":"2018-08-18T20:15:01Z","closed_at":"2018-08-17T10:43:33Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/openssl/openssl/pulls/6883","html_url":"https://github.com/openssl/openssl/pull/6883","diff_url":"https://github.com/openssl/openssl/pull/6883.diff","patch_url":"https://github.com/openssl/openssl/pull/6883.patch"},"body":"Even stop providing lock-free option in CRYPTO_atomic_add. Rationale\r\nis that combination does not provide coherent interface.\r\n\r\nCRYPTO_atomic_read was added with intention to read statistics counters,\r\nbut readings are effectively indistinguishable from regular load (even\r\nin non-lock-free case). This is because you can get out-dated value in\r\nboth cases. CRYPTO_atomic_write was added for symmetry and was never used.\r\nIn more general case involving standalone access to a variable application\r\nis unlikely to make sensible decision without keeping a lock for the time\r\ndecision is made, and not just for the time the variable is read (which\r\nwould still be indistinguishable from regular load). For this reason\r\napplication wouldn't have use for CRYPTO_atomic_read, and resort to\r\nacquiring a lock by itself. But then application wouldn't be able to use\r\nCRYPTO_atomic_add *if* it offers lock-free as target-specific option."},"comment":{"url":"https://api.github.com/repos/openssl/openssl/issues/comments/414083666","html_url":"https://github.com/openssl/openssl/pull/6883#issuecomment-414083666","issue_url":"https://api.github.com/repos/openssl/openssl/issues/6883","id":414083666,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDA4MzY2Ng==","user":{"login":"mtrojnar","id":13538198,"node_id":"MDQ6VXNlcjEzNTM4MTk4","avatar_url":"https://avatars3.githubusercontent.com/u/13538198?v=4","gravatar_id":"","url":"https://api.github.com/users/mtrojnar","html_url":"https://github.com/mtrojnar","followers_url":"https://api.github.com/users/mtrojnar/followers","following_url":"https://api.github.com/users/mtrojnar/following{/other_user}","gists_url":"https://api.github.com/users/mtrojnar/gists{/gist_id}","starred_url":"https://api.github.com/users/mtrojnar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtrojnar/subscriptions","organizations_url":"https://api.github.com/users/mtrojnar/orgs","repos_url":"https://api.github.com/users/mtrojnar/repos","events_url":"https://api.github.com/users/mtrojnar/events{/privacy}","received_events_url":"https://api.github.com/users/mtrojnar/received_events","type":"User","site_admin":false},"created_at":"2018-08-18T20:15:01Z","updated_at":"2018-08-18T20:15:01Z","author_association":"CONTRIBUTOR","body":"> The removed functions were **not** present in 1.1.0.\r\n\r\nOops.  I should have checked that before I posted my comment.\r\nThank you very much for your contributions to OpenSSL."}}
{"actor":{"display_login":"mtrojnar"}}