{"action":"created","issue":{"url":"https://api.github.com/repos/bu-ist/responsive-framework/issues/36","repository_url":"https://api.github.com/repos/bu-ist/responsive-framework","labels_url":"https://api.github.com/repos/bu-ist/responsive-framework/issues/36/labels{/name}","comments_url":"https://api.github.com/repos/bu-ist/responsive-framework/issues/36/comments","events_url":"https://api.github.com/repos/bu-ist/responsive-framework/issues/36/events","html_url":"https://github.com/bu-ist/responsive-framework/pull/36","id":343213513,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyOTI5Njkx","number":36,"title":"Feature/feature/bu banners has page title","user":{"login":"toddmilliken","id":26465346,"node_id":"MDQ6VXNlcjI2NDY1MzQ2","avatar_url":"https://avatars3.githubusercontent.com/u/26465346?v=4","gravatar_id":"","url":"https://api.github.com/users/toddmilliken","html_url":"https://github.com/toddmilliken","followers_url":"https://api.github.com/users/toddmilliken/followers","following_url":"https://api.github.com/users/toddmilliken/following{/other_user}","gists_url":"https://api.github.com/users/toddmilliken/gists{/gist_id}","starred_url":"https://api.github.com/users/toddmilliken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toddmilliken/subscriptions","organizations_url":"https://api.github.com/users/toddmilliken/orgs","repos_url":"https://api.github.com/users/toddmilliken/repos","events_url":"https://api.github.com/users/toddmilliken/events{/privacy}","received_events_url":"https://api.github.com/users/toddmilliken/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-20T18:55:19Z","updated_at":"2018-07-20T18:59:26Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/bu-ist/responsive-framework/pulls/36","html_url":"https://github.com/bu-ist/responsive-framework/pull/36","diff_url":"https://github.com/bu-ist/responsive-framework/pull/36.diff","patch_url":"https://github.com/bu-ist/responsive-framework/pull/36.patch"},"body":"Fixes issue where BU Banners plugin needs to output the page title, and not have it duplicated by responsive-framework. This new function is intended only to be used once on each page template for outputting the main page title, and has a filter that can be hooked into to change/prevent the output. Functions the same way as the_title(). This resolves the issue where bu banners used `the_title` filter to prevent output and had negative impacts on other functions trying to output page titles such as nav menu widgets.\r\n\r\n### Changes proposed in this pull request\r\n- Adds a new `responsive_the_title()` function intended to be output for the page/post title.\r\n- Changes instances where `the_title()` function was being used for templates, and replaces them with `responsive_the_title()`\r\n- The new `responsive_the_title()` function has a filter to prevent responsive-framework from outputting anything, via `responsive_filter_page_title()`.\r\n\r\n### Required pull requests to merge (usually a pull request on Foundation or a plugin)\r\n- BU Banners https://github.com/bu-ist/bu-banners/pull/156 will need to get merged for the plugin to properly prevent page title output.\r\n\r\n### Review checklist\r\n[x] I've reviewed the [contribution guidelines](https://github.com/bu-ist/coding-standards/blob/develop/CONTRIBUTING.md).\r\n[x] I've updated `CHANGELOG.MD` with a brief explanation of the main changes in this pull request.\r\n[x] My code follows [BU Coding Standards](https://github.com/bu-ist/coding-standards).\r\n"},"comment":{"url":"https://api.github.com/repos/bu-ist/responsive-framework/issues/comments/406697330","html_url":"https://github.com/bu-ist/responsive-framework/pull/36#issuecomment-406697330","issue_url":"https://api.github.com/repos/bu-ist/responsive-framework/issues/36","id":406697330,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjY5NzMzMA==","user":{"login":"toddmilliken","id":26465346,"node_id":"MDQ6VXNlcjI2NDY1MzQ2","avatar_url":"https://avatars3.githubusercontent.com/u/26465346?v=4","gravatar_id":"","url":"https://api.github.com/users/toddmilliken","html_url":"https://github.com/toddmilliken","followers_url":"https://api.github.com/users/toddmilliken/followers","following_url":"https://api.github.com/users/toddmilliken/following{/other_user}","gists_url":"https://api.github.com/users/toddmilliken/gists{/gist_id}","starred_url":"https://api.github.com/users/toddmilliken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toddmilliken/subscriptions","organizations_url":"https://api.github.com/users/toddmilliken/orgs","repos_url":"https://api.github.com/users/toddmilliken/repos","events_url":"https://api.github.com/users/toddmilliken/events{/privacy}","received_events_url":"https://api.github.com/users/toddmilliken/received_events","type":"User","site_admin":false},"created_at":"2018-07-20T18:59:26Z","updated_at":"2018-07-20T18:59:26Z","author_association":"NONE","body":"Just realized a made this branch /feature/feature/ 🤦‍♂️  haha oh well"}}
{"actor":{"display_login":"toddmilliken"}}