{"action":"created","issue":{"url":"https://api.github.com/repos/canjs/canjs/issues/4366","repository_url":"https://api.github.com/repos/canjs/canjs","labels_url":"https://api.github.com/repos/canjs/canjs/issues/4366/labels{/name}","comments_url":"https://api.github.com/repos/canjs/canjs/issues/4366/comments","events_url":"https://api.github.com/repos/canjs/canjs/issues/4366/events","html_url":"https://github.com/canjs/canjs/issues/4366","id":344802875,"node_id":"MDU6SXNzdWUzNDQ4MDI4NzU=","number":4366,"title":"can-define not updated from 2.5.2 to 2.5.3","user":{"login":"leoj3n","id":990216,"node_id":"MDQ6VXNlcjk5MDIxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/990216?v=4","gravatar_id":"","url":"https://api.github.com/users/leoj3n","html_url":"https://github.com/leoj3n","followers_url":"https://api.github.com/users/leoj3n/followers","following_url":"https://api.github.com/users/leoj3n/following{/other_user}","gists_url":"https://api.github.com/users/leoj3n/gists{/gist_id}","starred_url":"https://api.github.com/users/leoj3n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leoj3n/subscriptions","organizations_url":"https://api.github.com/users/leoj3n/orgs","repos_url":"https://api.github.com/users/leoj3n/repos","events_url":"https://api.github.com/users/leoj3n/events{/privacy}","received_events_url":"https://api.github.com/users/leoj3n/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-07-26T11:21:34Z","updated_at":"2018-08-01T21:39:53Z","closed_at":"2018-08-01T21:39:53Z","author_association":"CONTRIBUTOR","body":"`2.5.2` to `2.5.3` PR closed without merge: https://github.com/canjs/canjs/pull/4339\r\n\r\n`master` version is `can-define@2.5.2`: https://github.com/canjs/canjs/blob/master/package.json#L68\r\n\r\n---\r\n\r\nVersion mismatch causes build errors:\r\n\r\n```console\r\n$ npm run build\r\n```\r\n\r\n```\r\n(node:51438) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 3): Error: Unable to find [can-define] at ./node_modules/can-define/package.json\r\n\r\nThe package [projectnamehere] requested 2.5.2 but we found 2.5.3.\r\nRunning `npm install` should install the version listed in your package.json.\r\n\r\nSee https://stealjs.com/docs/StealJS.error-messages.html#mismatched-package-version for more information.\r\n```\r\n\r\n```console\r\n$ npm ls can-define\r\n```\r\n\r\n```\r\nprojectnamehere@0.0.1\r\n└─┬ can@5.2.2 (github:canjs/canjs#d596e62e6770885366c33a4351858f0080b195fb)\r\n  ├─┬ can-component@4.3.0\r\n  │ └── can-define@2.5.3\r\n  ├─┬ can-connect@3.0.1\r\n  │ └── can-define@2.5.3  deduped\r\n  ├── can-define@2.5.2\r\n  ├─┬ can-define-backup@2.0.0\r\n  │ └── can-define@2.5.3  deduped\r\n  ├─┬ can-define-stream@1.1.0\r\n  │ └── can-define@2.5.3  deduped\r\n  ├─┬ can-define-stream-kefir@1.1.0\r\n  │ └── can-define@2.5.3  deduped\r\n  ├─┬ can-define-validate-validatejs@1.1.0\r\n  │ └── can-define@2.5.3  deduped\r\n  └─┬ can-stream@1.1.0\r\n    └── can-define@2.5.3  deduped\r\n```\r\n\r\n---\r\n\r\nhttps://github.com/canjs/canjs/pull/4339 should probably have been merged?"},"comment":{"url":"https://api.github.com/repos/canjs/canjs/issues/comments/409733106","html_url":"https://github.com/canjs/canjs/issues/4366#issuecomment-409733106","issue_url":"https://api.github.com/repos/canjs/canjs/issues/4366","id":409733106,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTczMzEwNg==","user":{"login":"phillipskevin","id":5851984,"node_id":"MDQ6VXNlcjU4NTE5ODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5851984?v=4","gravatar_id":"","url":"https://api.github.com/users/phillipskevin","html_url":"https://github.com/phillipskevin","followers_url":"https://api.github.com/users/phillipskevin/followers","following_url":"https://api.github.com/users/phillipskevin/following{/other_user}","gists_url":"https://api.github.com/users/phillipskevin/gists{/gist_id}","starred_url":"https://api.github.com/users/phillipskevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phillipskevin/subscriptions","organizations_url":"https://api.github.com/users/phillipskevin/orgs","repos_url":"https://api.github.com/users/phillipskevin/repos","events_url":"https://api.github.com/users/phillipskevin/events{/privacy}","received_events_url":"https://api.github.com/users/phillipskevin/received_events","type":"User","site_admin":false},"created_at":"2018-08-01T21:39:53Z","updated_at":"2018-08-01T21:39:53Z","author_association":"COLLABORATOR","body":"can-define is 2.5.4 now in CanJS 5.3.0"}}
{"actor":{"display_login":"phillipskevin"}}