{"action":"created","issue":{"url":"https://api.github.com/repos/openSUSE/osc/issues/384","repository_url":"https://api.github.com/repos/openSUSE/osc","labels_url":"https://api.github.com/repos/openSUSE/osc/issues/384/labels{/name}","comments_url":"https://api.github.com/repos/openSUSE/osc/issues/384/comments","events_url":"https://api.github.com/repos/openSUSE/osc/issues/384/events","html_url":"https://github.com/openSUSE/osc/issues/384","id":299447574,"number":384,"title":"Not closing the SSL connection causes osc to hang in libcrypto","user":{"login":"sriemer","id":1803210,"avatar_url":"https://avatars0.githubusercontent.com/u/1803210?v=4","gravatar_id":"","url":"https://api.github.com/users/sriemer","html_url":"https://github.com/sriemer","followers_url":"https://api.github.com/users/sriemer/followers","following_url":"https://api.github.com/users/sriemer/following{/other_user}","gists_url":"https://api.github.com/users/sriemer/gists{/gist_id}","starred_url":"https://api.github.com/users/sriemer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sriemer/subscriptions","organizations_url":"https://api.github.com/users/sriemer/orgs","repos_url":"https://api.github.com/users/sriemer/repos","events_url":"https://api.github.com/users/sriemer/events{/privacy}","received_events_url":"https://api.github.com/users/sriemer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":23,"created_at":"2018-02-22T17:49:06Z","updated_at":"2018-02-28T17:40:19Z","closed_at":null,"author_association":"NONE","body":"https://github.com/openSUSE/osc/blob/6b04a6584b50bce79820aab99882569ad5f3927b/osc/oscssl.py#L218-L224\r\n\r\nosc requests that M2Crypto closes the SSL connection in `h.request()` due to `headers[\"Connection\"] = \"close\"`. Then it uses it again to get the response. In fact, the connection isn't closed at all because of that. It has to be closed explicitly after getting the response.\r\n\r\nFor details see: https://bugzilla.opensuse.org/show_bug.cgi?id=1068470\r\n\r\nPlease remove `headers[\"Connection\"] = \"close\"` here and call `h.close()` after getting the response.\r\n\r\nhttps://github.com/openSUSE/osc/blob/6b04a6584b50bce79820aab99882569ad5f3927b/osc/oscssl.py#L300-L302\r\n\r\nPlease add the following here:\r\n```python\r\n    def close(self):\r\n        self.sock.close()\r\n```"},"comment":{"url":"https://api.github.com/repos/openSUSE/osc/issues/comments/369319988","html_url":"https://github.com/openSUSE/osc/issues/384#issuecomment-369319988","issue_url":"https://api.github.com/repos/openSUSE/osc/issues/384","id":369319988,"user":{"login":"marcus-h","id":1067596,"avatar_url":"https://avatars3.githubusercontent.com/u/1067596?v=4","gravatar_id":"","url":"https://api.github.com/users/marcus-h","html_url":"https://github.com/marcus-h","followers_url":"https://api.github.com/users/marcus-h/followers","following_url":"https://api.github.com/users/marcus-h/following{/other_user}","gists_url":"https://api.github.com/users/marcus-h/gists{/gist_id}","starred_url":"https://api.github.com/users/marcus-h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcus-h/subscriptions","organizations_url":"https://api.github.com/users/marcus-h/orgs","repos_url":"https://api.github.com/users/marcus-h/repos","events_url":"https://api.github.com/users/marcus-h/events{/privacy}","received_events_url":"https://api.github.com/users/marcus-h/received_events","type":"User","site_admin":false},"created_at":"2018-02-28T17:40:19Z","updated_at":"2018-02-28T17:40:19Z","author_association":"MEMBER","body":"On 2018-02-28 10:25:18 +0000, Michael Schroeder wrote:\n> Hmm, why don't you implement that _makefile_refs counting like in python's ssl.py?\n> \nThat's what my PR/MR is basically doing (in a way that works with\npython2 and python3).\n"}}
{"actor":{"display_login":"marcus-h"}}