{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/217691162","pull_request_review_id":155056680,"id":217691162,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzY5MTE2Mg==","diff_hunk":"@@ -0,0 +1,135 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one\n+ * or more contributor license agreements.  See the NOTICE file\n+ * distributed with this work for additional information\n+ * regarding copyright ownership.  The ASF licenses this file\n+ * to you under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance\n+ * with the License.  You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.apache.flink.table.runtime.stream.sql\n+\n+import java.sql.Timestamp\n+\n+import org.apache.flink.api.scala._\n+import org.apache.flink.streaming.api.TimeCharacteristic\n+import org.apache.flink.streaming.api.scala.StreamExecutionEnvironment\n+import org.apache.flink.table.api.{TableEnvironment, TableException}\n+import org.apache.flink.table.api.scala._\n+import org.apache.flink.table.runtime.utils.{StreamITCase, StreamingWithStateTestBase}\n+import org.apache.flink.types.Row\n+import org.junit._\n+import org.junit.rules.ExpectedException\n+\n+import scala.collection.mutable\n+\n+class TemporalJoinITCase extends StreamingWithStateTestBase {\n+  val expectedException = ExpectedException.none()\n+\n+  @Rule\n+  def thrown = expectedException\n+\n+  @Test\n+  def testProcessTimeInnerJoin(): Unit = {","path":"flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/TemporalJoinITCase.scala","position":42,"original_position":42,"commit_id":"03c64e6afca48c159ce82e025363317a4655db12","original_commit_id":"03c64e6afca48c159ce82e025363317a4655db12","user":{"login":"twalthr","id":5746567,"node_id":"MDQ6VXNlcjU3NDY1Njc=","avatar_url":"https://avatars1.githubusercontent.com/u/5746567?v=4","gravatar_id":"","url":"https://api.github.com/users/twalthr","html_url":"https://github.com/twalthr","followers_url":"https://api.github.com/users/twalthr/followers","following_url":"https://api.github.com/users/twalthr/following{/other_user}","gists_url":"https://api.github.com/users/twalthr/gists{/gist_id}","starred_url":"https://api.github.com/users/twalthr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twalthr/subscriptions","organizations_url":"https://api.github.com/users/twalthr/orgs","repos_url":"https://api.github.com/users/twalthr/repos","events_url":"https://api.github.com/users/twalthr/events{/privacy}","received_events_url":"https://api.github.com/users/twalthr/received_events","type":"User","site_admin":false},"body":"We should mention in a comment that this test is actually not validating the actual results.","created_at":"2018-09-14T12:11:46Z","updated_at":"2018-09-14T12:16:27Z","html_url":"https://github.com/apache/flink/pull/6299#discussion_r217691162","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/6299","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/217691162"},"html":{"href":"https://github.com/apache/flink/pull/6299#discussion_r217691162"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/6299"}}},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/6299","id":200456244,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNDU2MjQ0","html_url":"https://github.com/apache/flink/pull/6299","diff_url":"https://github.com/apache/flink/pull/6299.diff","patch_url":"https://github.com/apache/flink/pull/6299.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/6299","number":6299,"state":"open","locked":false,"title":"[FLINK-9713][table][sql] Support processing time versioned joins","user":{"login":"pnowojski","id":8957547,"node_id":"MDQ6VXNlcjg5NTc1NDc=","avatar_url":"https://avatars3.githubusercontent.com/u/8957547?v=4","gravatar_id":"","url":"https://api.github.com/users/pnowojski","html_url":"https://github.com/pnowojski","followers_url":"https://api.github.com/users/pnowojski/followers","following_url":"https://api.github.com/users/pnowojski/following{/other_user}","gists_url":"https://api.github.com/users/pnowojski/gists{/gist_id}","starred_url":"https://api.github.com/users/pnowojski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnowojski/subscriptions","organizations_url":"https://api.github.com/users/pnowojski/orgs","repos_url":"https://api.github.com/users/pnowojski/repos","events_url":"https://api.github.com/users/pnowojski/events{/privacy}","received_events_url":"https://api.github.com/users/pnowojski/received_events","type":"User","site_admin":false},"body":"## What is the purpose of the change\r\n\r\nThis PR:\r\n- provides a way to define Table Version Functions in Table API \r\n- handles Table Version Functions in planning phase for streaming (both Table API and SQL)\r\n- supports execution with processing time\r\n\r\n## Brief change log\r\n\r\nFor brief change log please check individual commit messages.\r\n\r\n## Verifying this change\r\n\r\nThis change adds streaming/batching, sql/table test coverage for versioned joins handling in form of `VersionedJoinTest`s.\r\n\r\n## Does this pull request potentially affect one of the following parts:\r\n\r\n  - Dependencies (does it add or upgrade a dependency): (yes / **no**)\r\n  - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**yes** / no)\r\n  - The serializers: (yes / **no** / don't know)\r\n  - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)\r\n  - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)\r\n  - The S3 file system connector: (yes / **no** / don't know)\r\n\r\n## Documentation\r\n\r\n  - Does this pull request introduce a new feature? (**yes** / no)\r\n  - If yes, how is the feature documented? (not applicable / docs / **JavaDocs** / not documented)\r\n","created_at":"2018-07-10T16:34:18Z","updated_at":"2018-09-14T12:16:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"38afdbce4f38ea2bac7ed8ee19606ac9585562d2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/6299/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/6299/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/6299/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/03c64e6afca48c159ce82e025363317a4655db12","head":{"label":"pnowojski:enrichment","ref":"enrichment","sha":"03c64e6afca48c159ce82e025363317a4655db12","user":{"login":"pnowojski","id":8957547,"node_id":"MDQ6VXNlcjg5NTc1NDc=","avatar_url":"https://avatars3.githubusercontent.com/u/8957547?v=4","gravatar_id":"","url":"https://api.github.com/users/pnowojski","html_url":"https://github.com/pnowojski","followers_url":"https://api.github.com/users/pnowojski/followers","following_url":"https://api.github.com/users/pnowojski/following{/other_user}","gists_url":"https://api.github.com/users/pnowojski/gists{/gist_id}","starred_url":"https://api.github.com/users/pnowojski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnowojski/subscriptions","organizations_url":"https://api.github.com/users/pnowojski/orgs","repos_url":"https://api.github.com/users/pnowojski/repos","events_url":"https://api.github.com/users/pnowojski/events{/privacy}","received_events_url":"https://api.github.com/users/pnowojski/received_events","type":"User","site_admin":false},"repo":{"id":94091518,"node_id":"MDEwOlJlcG9zaXRvcnk5NDA5MTUxOA==","name":"flink","full_name":"pnowojski/flink","owner":{"login":"pnowojski","id":8957547,"node_id":"MDQ6VXNlcjg5NTc1NDc=","avatar_url":"https://avatars3.githubusercontent.com/u/8957547?v=4","gravatar_id":"","url":"https://api.github.com/users/pnowojski","html_url":"https://github.com/pnowojski","followers_url":"https://api.github.com/users/pnowojski/followers","following_url":"https://api.github.com/users/pnowojski/following{/other_user}","gists_url":"https://api.github.com/users/pnowojski/gists{/gist_id}","starred_url":"https://api.github.com/users/pnowojski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnowojski/subscriptions","organizations_url":"https://api.github.com/users/pnowojski/orgs","repos_url":"https://api.github.com/users/pnowojski/repos","events_url":"https://api.github.com/users/pnowojski/events{/privacy}","received_events_url":"https://api.github.com/users/pnowojski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pnowojski/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/pnowojski/flink","forks_url":"https://api.github.com/repos/pnowojski/flink/forks","keys_url":"https://api.github.com/repos/pnowojski/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pnowojski/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pnowojski/flink/teams","hooks_url":"https://api.github.com/repos/pnowojski/flink/hooks","issue_events_url":"https://api.github.com/repos/pnowojski/flink/issues/events{/number}","events_url":"https://api.github.com/repos/pnowojski/flink/events","assignees_url":"https://api.github.com/repos/pnowojski/flink/assignees{/user}","branches_url":"https://api.github.com/repos/pnowojski/flink/branches{/branch}","tags_url":"https://api.github.com/repos/pnowojski/flink/tags","blobs_url":"https://api.github.com/repos/pnowojski/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pnowojski/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pnowojski/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/pnowojski/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pnowojski/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/pnowojski/flink/languages","stargazers_url":"https://api.github.com/repos/pnowojski/flink/stargazers","contributors_url":"https://api.github.com/repos/pnowojski/flink/contributors","subscribers_url":"https://api.github.com/repos/pnowojski/flink/subscribers","subscription_url":"https://api.github.com/repos/pnowojski/flink/subscription","commits_url":"https://api.github.com/repos/pnowojski/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/pnowojski/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/pnowojski/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/pnowojski/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/pnowojski/flink/contents/{+path}","compare_url":"https://api.github.com/repos/pnowojski/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pnowojski/flink/merges","archive_url":"https://api.github.com/repos/pnowojski/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pnowojski/flink/downloads","issues_url":"https://api.github.com/repos/pnowojski/flink/issues{/number}","pulls_url":"https://api.github.com/repos/pnowojski/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/pnowojski/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/pnowojski/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pnowojski/flink/labels{/name}","releases_url":"https://api.github.com/repos/pnowojski/flink/releases{/id}","deployments_url":"https://api.github.com/repos/pnowojski/flink/deployments","created_at":"2017-06-12T12:03:15Z","updated_at":"2017-06-12T12:03:37Z","pushed_at":"2018-09-12T15:53:40Z","git_url":"git://github.com/pnowojski/flink.git","ssh_url":"git@github.com:pnowojski/flink.git","clone_url":"https://github.com/pnowojski/flink.git","svn_url":"https://github.com/pnowojski/flink","homepage":null,"size":162021,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"c87b9433e3225602e56497f782a610668eac8bf9","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4NzU5OQ==","name":"flink","full_name":"apache/flink","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/flink","description":"Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink/deployments","created_at":"2014-06-07T07:00:10Z","updated_at":"2018-09-14T09:39:33Z","pushed_at":"2018-09-14T12:14:30Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":"","size":164537,"stargazers_count":4397,"watchers_count":4397,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2876,"mirror_url":null,"archived":false,"open_issues_count":399,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2876,"open_issues":399,"watchers":4397,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/6299"},"html":{"href":"https://github.com/apache/flink/pull/6299"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/6299"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/6299/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/6299/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/6299/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/03c64e6afca48c159ce82e025363317a4655db12"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"twalthr"}}