{"action":"created","comment":{"url":"https://api.github.com/repos/otcshare/chromium-src/pulls/comments/225018969","pull_request_review_id":164526135,"id":225018969,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTAxODk2OQ==","diff_hunk":"@@ -588,15 +615,19 @@ bool GetMPSImageInfo(const OperandMac& operand,\n   return image;\n }\n \n-MPSImage* ExecutionImplMac::FindInputMPSImageByIndex(uint32_t index) {\n-  return FindMPSImageByIndex(index, compilation_->inputs_, input_mpsimages_);\n+MPSImage* ExecutionImplMac::FindInputOrConstantMPSImageByIndex(uint32_t index) {\n+  MPSImage* img = FindMPSImageByIndex(index, compilation_->inputs_, input_mpsimages_);\n+  if (!img) {\n+    img = FindMPSImageByIndex(index, compilation_->constants_, constant_mpsimages_);\n+  }","path":"services/ml/execution_impl_mac.mm","position":358,"original_position":158,"commit_id":"c3e85dfff816ee6359ee0f4e015c3a2a360a53e9","original_commit_id":"fc5e6ec0bba92a5e78594ffba0239ee7b684b524","user":{"login":"huningxin","id":1005673,"node_id":"MDQ6VXNlcjEwMDU2NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/1005673?v=4","gravatar_id":"","url":"https://api.github.com/users/huningxin","html_url":"https://github.com/huningxin","followers_url":"https://api.github.com/users/huningxin/followers","following_url":"https://api.github.com/users/huningxin/following{/other_user}","gists_url":"https://api.github.com/users/huningxin/gists{/gist_id}","starred_url":"https://api.github.com/users/huningxin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huningxin/subscriptions","organizations_url":"https://api.github.com/users/huningxin/orgs","repos_url":"https://api.github.com/users/huningxin/repos","events_url":"https://api.github.com/users/huningxin/events{/privacy}","received_events_url":"https://api.github.com/users/huningxin/received_events","type":"User","site_admin":false},"body":"There are multiple lines inside braces.","created_at":"2018-10-15T01:13:20Z","updated_at":"2018-10-15T01:13:20Z","html_url":"https://github.com/otcshare/chromium-src/pull/40#discussion_r225018969","pull_request_url":"https://api.github.com/repos/otcshare/chromium-src/pulls/40","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/otcshare/chromium-src/pulls/comments/225018969"},"html":{"href":"https://github.com/otcshare/chromium-src/pull/40#discussion_r225018969"},"pull_request":{"href":"https://api.github.com/repos/otcshare/chromium-src/pulls/40"}},"in_reply_to_id":224979904},"pull_request":{"url":"https://api.github.com/repos/otcshare/chromium-src/pulls/40","id":222358407,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMzU4NDA3","html_url":"https://github.com/otcshare/chromium-src/pull/40","diff_url":"https://github.com/otcshare/chromium-src/pull/40.diff","patch_url":"https://github.com/otcshare/chromium-src/pull/40.patch","issue_url":"https://api.github.com/repos/otcshare/chromium-src/issues/40","number":40,"state":"open","locked":false,"title":"Support ADD and MUL op in MPS","user":{"login":"huningxin","id":1005673,"node_id":"MDQ6VXNlcjEwMDU2NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/1005673?v=4","gravatar_id":"","url":"https://api.github.com/users/huningxin","html_url":"https://github.com/huningxin","followers_url":"https://api.github.com/users/huningxin/followers","following_url":"https://api.github.com/users/huningxin/following{/other_user}","gists_url":"https://api.github.com/users/huningxin/gists{/gist_id}","starred_url":"https://api.github.com/users/huningxin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huningxin/subscriptions","organizations_url":"https://api.github.com/users/huningxin/orgs","repos_url":"https://api.github.com/users/huningxin/repos","events_url":"https://api.github.com/users/huningxin/events{/privacy}","received_events_url":"https://api.github.com/users/huningxin/received_events","type":"User","site_admin":false},"body":"fix https://github.com/intel/webml-polyfill/issues/92 and https://github.com/intel/webml-polyfill/issues/117","created_at":"2018-10-12T06:03:42Z","updated_at":"2018-10-15T01:13:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"35cfbe49962e186a2a9f918e06764bf516142e79","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/otcshare/chromium-src/pulls/40/commits","review_comments_url":"https://api.github.com/repos/otcshare/chromium-src/pulls/40/comments","review_comment_url":"https://api.github.com/repos/otcshare/chromium-src/pulls/comments{/number}","comments_url":"https://api.github.com/repos/otcshare/chromium-src/issues/40/comments","statuses_url":"https://api.github.com/repos/otcshare/chromium-src/statuses/c3e85dfff816ee6359ee0f4e015c3a2a360a53e9","head":{"label":"huningxin:add_op","ref":"add_op","sha":"c3e85dfff816ee6359ee0f4e015c3a2a360a53e9","user":{"login":"huningxin","id":1005673,"node_id":"MDQ6VXNlcjEwMDU2NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/1005673?v=4","gravatar_id":"","url":"https://api.github.com/users/huningxin","html_url":"https://github.com/huningxin","followers_url":"https://api.github.com/users/huningxin/followers","following_url":"https://api.github.com/users/huningxin/following{/other_user}","gists_url":"https://api.github.com/users/huningxin/gists{/gist_id}","starred_url":"https://api.github.com/users/huningxin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huningxin/subscriptions","organizations_url":"https://api.github.com/users/huningxin/orgs","repos_url":"https://api.github.com/users/huningxin/repos","events_url":"https://api.github.com/users/huningxin/events{/privacy}","received_events_url":"https://api.github.com/users/huningxin/received_events","type":"User","site_admin":false},"repo":{"id":129174316,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkxNzQzMTY=","name":"chromium-src","full_name":"huningxin/chromium-src","private":false,"owner":{"login":"huningxin","id":1005673,"node_id":"MDQ6VXNlcjEwMDU2NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/1005673?v=4","gravatar_id":"","url":"https://api.github.com/users/huningxin","html_url":"https://github.com/huningxin","followers_url":"https://api.github.com/users/huningxin/followers","following_url":"https://api.github.com/users/huningxin/following{/other_user}","gists_url":"https://api.github.com/users/huningxin/gists{/gist_id}","starred_url":"https://api.github.com/users/huningxin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huningxin/subscriptions","organizations_url":"https://api.github.com/users/huningxin/orgs","repos_url":"https://api.github.com/users/huningxin/repos","events_url":"https://api.github.com/users/huningxin/events{/privacy}","received_events_url":"https://api.github.com/users/huningxin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/huningxin/chromium-src","description":"mirror of https://chromium.googlesource.com/chromium/src.git","fork":true,"url":"https://api.github.com/repos/huningxin/chromium-src","forks_url":"https://api.github.com/repos/huningxin/chromium-src/forks","keys_url":"https://api.github.com/repos/huningxin/chromium-src/keys{/key_id}","collaborators_url":"https://api.github.com/repos/huningxin/chromium-src/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/huningxin/chromium-src/teams","hooks_url":"https://api.github.com/repos/huningxin/chromium-src/hooks","issue_events_url":"https://api.github.com/repos/huningxin/chromium-src/issues/events{/number}","events_url":"https://api.github.com/repos/huningxin/chromium-src/events","assignees_url":"https://api.github.com/repos/huningxin/chromium-src/assignees{/user}","branches_url":"https://api.github.com/repos/huningxin/chromium-src/branches{/branch}","tags_url":"https://api.github.com/repos/huningxin/chromium-src/tags","blobs_url":"https://api.github.com/repos/huningxin/chromium-src/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/huningxin/chromium-src/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/huningxin/chromium-src/git/refs{/sha}","trees_url":"https://api.github.com/repos/huningxin/chromium-src/git/trees{/sha}","statuses_url":"https://api.github.com/repos/huningxin/chromium-src/statuses/{sha}","languages_url":"https://api.github.com/repos/huningxin/chromium-src/languages","stargazers_url":"https://api.github.com/repos/huningxin/chromium-src/stargazers","contributors_url":"https://api.github.com/repos/huningxin/chromium-src/contributors","subscribers_url":"https://api.github.com/repos/huningxin/chromium-src/subscribers","subscription_url":"https://api.github.com/repos/huningxin/chromium-src/subscription","commits_url":"https://api.github.com/repos/huningxin/chromium-src/commits{/sha}","git_commits_url":"https://api.github.com/repos/huningxin/chromium-src/git/commits{/sha}","comments_url":"https://api.github.com/repos/huningxin/chromium-src/comments{/number}","issue_comment_url":"https://api.github.com/repos/huningxin/chromium-src/issues/comments{/number}","contents_url":"https://api.github.com/repos/huningxin/chromium-src/contents/{+path}","compare_url":"https://api.github.com/repos/huningxin/chromium-src/compare/{base}...{head}","merges_url":"https://api.github.com/repos/huningxin/chromium-src/merges","archive_url":"https://api.github.com/repos/huningxin/chromium-src/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/huningxin/chromium-src/downloads","issues_url":"https://api.github.com/repos/huningxin/chromium-src/issues{/number}","pulls_url":"https://api.github.com/repos/huningxin/chromium-src/pulls{/number}","milestones_url":"https://api.github.com/repos/huningxin/chromium-src/milestones{/number}","notifications_url":"https://api.github.com/repos/huningxin/chromium-src/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/huningxin/chromium-src/labels{/name}","releases_url":"https://api.github.com/repos/huningxin/chromium-src/releases{/id}","deployments_url":"https://api.github.com/repos/huningxin/chromium-src/deployments","created_at":"2018-04-12T01:20:34Z","updated_at":"2018-04-12T01:22:22Z","pushed_at":"2018-10-15T01:09:57Z","git_url":"git://github.com/huningxin/chromium-src.git","ssh_url":"git@github.com:huningxin/chromium-src.git","clone_url":"https://github.com/huningxin/chromium-src.git","svn_url":"https://github.com/huningxin/chromium-src","homepage":"","size":8781593,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"webml"}},"base":{"label":"otcshare:webml","ref":"webml","sha":"861b76160616a1ecb59b9381866fb352c08b4485","user":{"login":"otcshare","id":587360,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4NzM2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/587360?v=4","gravatar_id":"","url":"https://api.github.com/users/otcshare","html_url":"https://github.com/otcshare","followers_url":"https://api.github.com/users/otcshare/followers","following_url":"https://api.github.com/users/otcshare/following{/other_user}","gists_url":"https://api.github.com/users/otcshare/gists{/gist_id}","starred_url":"https://api.github.com/users/otcshare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otcshare/subscriptions","organizations_url":"https://api.github.com/users/otcshare/orgs","repos_url":"https://api.github.com/users/otcshare/repos","events_url":"https://api.github.com/users/otcshare/events{/privacy}","received_events_url":"https://api.github.com/users/otcshare/received_events","type":"Organization","site_admin":false},"repo":{"id":114350865,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQzNTA4NjU=","name":"chromium-src","full_name":"otcshare/chromium-src","private":false,"owner":{"login":"otcshare","id":587360,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4NzM2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/587360?v=4","gravatar_id":"","url":"https://api.github.com/users/otcshare","html_url":"https://github.com/otcshare","followers_url":"https://api.github.com/users/otcshare/followers","following_url":"https://api.github.com/users/otcshare/following{/other_user}","gists_url":"https://api.github.com/users/otcshare/gists{/gist_id}","starred_url":"https://api.github.com/users/otcshare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otcshare/subscriptions","organizations_url":"https://api.github.com/users/otcshare/orgs","repos_url":"https://api.github.com/users/otcshare/repos","events_url":"https://api.github.com/users/otcshare/events{/privacy}","received_events_url":"https://api.github.com/users/otcshare/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/otcshare/chromium-src","description":"mirror of https://chromium.googlesource.com/chromium/src.git","fork":false,"url":"https://api.github.com/repos/otcshare/chromium-src","forks_url":"https://api.github.com/repos/otcshare/chromium-src/forks","keys_url":"https://api.github.com/repos/otcshare/chromium-src/keys{/key_id}","collaborators_url":"https://api.github.com/repos/otcshare/chromium-src/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/otcshare/chromium-src/teams","hooks_url":"https://api.github.com/repos/otcshare/chromium-src/hooks","issue_events_url":"https://api.github.com/repos/otcshare/chromium-src/issues/events{/number}","events_url":"https://api.github.com/repos/otcshare/chromium-src/events","assignees_url":"https://api.github.com/repos/otcshare/chromium-src/assignees{/user}","branches_url":"https://api.github.com/repos/otcshare/chromium-src/branches{/branch}","tags_url":"https://api.github.com/repos/otcshare/chromium-src/tags","blobs_url":"https://api.github.com/repos/otcshare/chromium-src/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/otcshare/chromium-src/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/otcshare/chromium-src/git/refs{/sha}","trees_url":"https://api.github.com/repos/otcshare/chromium-src/git/trees{/sha}","statuses_url":"https://api.github.com/repos/otcshare/chromium-src/statuses/{sha}","languages_url":"https://api.github.com/repos/otcshare/chromium-src/languages","stargazers_url":"https://api.github.com/repos/otcshare/chromium-src/stargazers","contributors_url":"https://api.github.com/repos/otcshare/chromium-src/contributors","subscribers_url":"https://api.github.com/repos/otcshare/chromium-src/subscribers","subscription_url":"https://api.github.com/repos/otcshare/chromium-src/subscription","commits_url":"https://api.github.com/repos/otcshare/chromium-src/commits{/sha}","git_commits_url":"https://api.github.com/repos/otcshare/chromium-src/git/commits{/sha}","comments_url":"https://api.github.com/repos/otcshare/chromium-src/comments{/number}","issue_comment_url":"https://api.github.com/repos/otcshare/chromium-src/issues/comments{/number}","contents_url":"https://api.github.com/repos/otcshare/chromium-src/contents/{+path}","compare_url":"https://api.github.com/repos/otcshare/chromium-src/compare/{base}...{head}","merges_url":"https://api.github.com/repos/otcshare/chromium-src/merges","archive_url":"https://api.github.com/repos/otcshare/chromium-src/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/otcshare/chromium-src/downloads","issues_url":"https://api.github.com/repos/otcshare/chromium-src/issues{/number}","pulls_url":"https://api.github.com/repos/otcshare/chromium-src/pulls{/number}","milestones_url":"https://api.github.com/repos/otcshare/chromium-src/milestones{/number}","notifications_url":"https://api.github.com/repos/otcshare/chromium-src/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/otcshare/chromium-src/labels{/name}","releases_url":"https://api.github.com/repos/otcshare/chromium-src/releases{/id}","deployments_url":"https://api.github.com/repos/otcshare/chromium-src/deployments","created_at":"2017-12-15T09:11:45Z","updated_at":"2018-10-12T07:32:15Z","pushed_at":"2018-10-15T01:10:02Z","git_url":"git://github.com/otcshare/chromium-src.git","ssh_url":"git@github.com:otcshare/chromium-src.git","clone_url":"https://github.com/otcshare/chromium-src.git","svn_url":"https://github.com/otcshare/chromium-src","homepage":"","size":8781587,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6,"open_issues":5,"watchers":1,"default_branch":"webml"}},"_links":{"self":{"href":"https://api.github.com/repos/otcshare/chromium-src/pulls/40"},"html":{"href":"https://github.com/otcshare/chromium-src/pull/40"},"issue":{"href":"https://api.github.com/repos/otcshare/chromium-src/issues/40"},"comments":{"href":"https://api.github.com/repos/otcshare/chromium-src/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/otcshare/chromium-src/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/otcshare/chromium-src/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/otcshare/chromium-src/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/otcshare/chromium-src/statuses/c3e85dfff816ee6359ee0f4e015c3a2a360a53e9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"huningxin"}}