{"action":"created","issue":{"url":"https://api.github.com/repos/jupyter/notebook/issues/3335","repository_url":"https://api.github.com/repos/jupyter/notebook","labels_url":"https://api.github.com/repos/jupyter/notebook/issues/3335/labels{/name}","comments_url":"https://api.github.com/repos/jupyter/notebook/issues/3335/comments","events_url":"https://api.github.com/repos/jupyter/notebook/issues/3335/events","html_url":"https://github.com/jupyter/notebook/issues/3335","id":296826925,"number":3335,"title":"Convert JS tests to Selenium","user":{"login":"takluyver","id":327925,"avatar_url":"https://avatars3.githubusercontent.com/u/327925?v=4","gravatar_id":"","url":"https://api.github.com/users/takluyver","html_url":"https://github.com/takluyver","followers_url":"https://api.github.com/users/takluyver/followers","following_url":"https://api.github.com/users/takluyver/following{/other_user}","gists_url":"https://api.github.com/users/takluyver/gists{/gist_id}","starred_url":"https://api.github.com/users/takluyver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takluyver/subscriptions","organizations_url":"https://api.github.com/users/takluyver/orgs","repos_url":"https://api.github.com/users/takluyver/repos","events_url":"https://api.github.com/users/takluyver/events{/privacy}","received_events_url":"https://api.github.com/users/takluyver/received_events","type":"User","site_admin":false},"labels":[{"id":752876013,"url":"https://api.github.com/repos/jupyter/notebook/labels/good%20first%20issue","name":"good first issue","color":"84e251","default":true},{"id":736645920,"url":"https://api.github.com/repos/jupyter/notebook/labels/help%20wanted","name":"help wanted","color":"84e251","default":true},{"id":197515308,"url":"https://api.github.com/repos/jupyter/notebook/labels/type:Enhancement","name":"type:Enhancement","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2018-02-13T17:43:57Z","updated_at":"2018-03-19T19:32:45Z","closed_at":null,"author_association":"OWNER","body":"We have a number of Javascript tests:\r\n\r\n* https://github.com/jupyter/notebook/tree/master/notebook/tests/base\r\n* https://github.com/jupyter/notebook/tree/master/notebook/tests/notebook\r\n* https://github.com/jupyter/notebook/tree/master/notebook/tests\r\n\r\nWe would like to convert these to use [Selenium](https://pypi.python.org/pypi/selenium), in [this folder](https://github.com/jupyter/notebook/tree/master/notebook/tests/selenium). To run selenium tests, you will need the Selenium Python package and a 'driver' (a backend for it to talk to your browser). Once you have those, you can run:\r\n\r\n```\r\npy.test -v notebook/tests/selenium\r\n```\r\n\r\nThis is quite a big task, and it probably won't be done in one pull request, but rather several smaller ones converting individual bits of the tests.\r\n\r\nI'm marking this 'good first issue', though it's a bit borderline. It requires a decent understanding of Javascript and Python, but you don't need to know much about Jupyter to translate the tests. It should get easier as more of the tests are translated, because there will be more examples to refer to."},"comment":{"url":"https://api.github.com/repos/jupyter/notebook/issues/comments/374340566","html_url":"https://github.com/jupyter/notebook/issues/3335#issuecomment-374340566","issue_url":"https://api.github.com/repos/jupyter/notebook/issues/3335","id":374340566,"user":{"login":"mpacer","id":2482408,"avatar_url":"https://avatars3.githubusercontent.com/u/2482408?v=4","gravatar_id":"","url":"https://api.github.com/users/mpacer","html_url":"https://github.com/mpacer","followers_url":"https://api.github.com/users/mpacer/followers","following_url":"https://api.github.com/users/mpacer/following{/other_user}","gists_url":"https://api.github.com/users/mpacer/gists{/gist_id}","starred_url":"https://api.github.com/users/mpacer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpacer/subscriptions","organizations_url":"https://api.github.com/users/mpacer/orgs","repos_url":"https://api.github.com/users/mpacer/repos","events_url":"https://api.github.com/users/mpacer/events{/privacy}","received_events_url":"https://api.github.com/users/mpacer/received_events","type":"User","site_admin":false},"created_at":"2018-03-19T19:32:45Z","updated_at":"2018-03-19T19:32:45Z","author_association":"MEMBER","body":"In order to support multiple tests in the same notebook I’m running into some issues with the utility functions as they are currently. I’m going to try to make something a bit more comprehensive for manipulating the notebook on the page. If you want to do any tests on the tree page though (not on notebooks themselves) I won’t be touching that outside of  #3412 until I get these utilities working."}}
{"actor":{"display_login":"mpacer"}}