{"push_id":3165689844,"size":2,"distinct_size":2,"ref":"refs/heads/dev","head":"9e7e06ed8713091d0b2bbb2aa09c31638a8f70a4","before":"e6920970cafa3f2bb158e7a489366daafb57cd1f","commits":[{"sha":"37bbdbe52a5411d42d30a87bab8586fa687a1a86","author":{"name":"DeckerSU","email":"5bdcd3c0d4d24ae3e71b3b452a024c6324c7e4bb@decker.su"},"message":"fix: iguana autosplit / acsplit issue\n\nthis was a most hard to find and hard to debug issue, bcz sometimes\niguana did splitfunds correctly and sometimes not. nobody tried to\nhelp me to catch the \"wrong state\" in which it fails, despite all\nprovided instructions. i spent all night along to catch the state\nof utxos in which splitfunds guarantee fails. so, i have only wallet.dat\nstate and just every acsplit try fails on it. this was a half of victory.\n\nsecond stage was debugging iguana and komodod sources, adding printouts\nfor preimage calculation, printouts for hashes, printouts for everything,\nlaunching gdb under VSCode and other things. and after spent ~24 hours\nof continuous work i found root of the issue.\n\nit was in spendamount (!) ... i found that dpow_gettxout returns\n34.26707593 in \"value\" field. but after conversion to uint_64 it becomes\n34.26707592 . for non-sapling enabled chains seems nothing hurts, but\nsince sapling activated in KMD and assetchains it's significantly.\nbcz according to zip-243 https://github.com/zcash/zips/blob/master/zip-0243.rst\namount field is a part of preimage calculation. and as we have\nwrong spendamount we have a wrong sighash when calc crypto_generichash_blake2b_salt_personal\nwith sig_hash_personal = ZCASH_SIG_HASH_SAPLING_PERSONALIZATION .\n\nLook at the \"Test vector 3\" in ZIP-243 and amount field in preimage and\nyou will understand the bug.\n\nSometimes double -> uint64_t was fine and splitfunds is success, but\nsometimes (depends on double representation of value) it was wrong and\nsplitfunds fails. That's why it was so hard to catch and fix.\n\nBut now, seems the issue is fixed!","distinct":true,"url":"https://api.github.com/repos/jl777/SuperNET/commits/37bbdbe52a5411d42d30a87bab8586fa687a1a86"},{"sha":"9e7e06ed8713091d0b2bbb2aa09c31638a8f70a4","author":{"name":"jl777","email":"a7f146188dc5b468c57ae7fb0047edb08eebeb44@users.noreply.github.com"},"message":"Merge pull request #1024 from DeckerSU/dev\n\nfix: iguana autosplit / acsplit issue","distinct":true,"url":"https://api.github.com/repos/jl777/SuperNET/commits/9e7e06ed8713091d0b2bbb2aa09c31638a8f70a4"}]}
{"actor":{"display_login":"jl777"}}