{"action":"closed","issue":{"url":"https://api.github.com/repos/zendframework/zend-servicemanager/issues/236","repository_url":"https://api.github.com/repos/zendframework/zend-servicemanager","labels_url":"https://api.github.com/repos/zendframework/zend-servicemanager/issues/236/labels{/name}","comments_url":"https://api.github.com/repos/zendframework/zend-servicemanager/issues/236/comments","events_url":"https://api.github.com/repos/zendframework/zend-servicemanager/issues/236/events","html_url":"https://github.com/zendframework/zend-servicemanager/issues/236","id":291121211,"number":236,"title":"Test suite does not cover multiple idempotency scenarios around `ServiceManager#has()` and `ServiceManager#get()`","user":{"login":"Ocramius","id":154256,"avatar_url":"https://avatars2.githubusercontent.com/u/154256?v=4","gravatar_id":"","url":"https://api.github.com/users/Ocramius","html_url":"https://github.com/Ocramius","followers_url":"https://api.github.com/users/Ocramius/followers","following_url":"https://api.github.com/users/Ocramius/following{/other_user}","gists_url":"https://api.github.com/users/Ocramius/gists{/gist_id}","starred_url":"https://api.github.com/users/Ocramius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ocramius/subscriptions","organizations_url":"https://api.github.com/users/Ocramius/orgs","repos_url":"https://api.github.com/users/Ocramius/repos","events_url":"https://api.github.com/users/Ocramius/events{/privacy}","received_events_url":"https://api.github.com/users/Ocramius/received_events","type":"User","site_admin":false},"labels":[{"id":209128286,"url":"https://api.github.com/repos/zendframework/zend-servicemanager/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-01-24T08:25:54Z","updated_at":"2018-04-16T14:17:33Z","closed_at":"2018-04-16T14:17:33Z","author_association":"MEMBER","body":"From the original issue by @fhein (#235):\r\n\r\n > I got aware of this issue, when I created a feature branch, applied some changes, ran the tests witch result OK. Then I ran the benchmarks and I got errors not related to phpbench but related to the ServiceManager.\r\n\r\n > Tracking this down I found, that the benchmarks do things that are not tested by phpunit. Example: `get()` the same service twice. Or `build()` a service, then `get()` the same service. Or `has()` a service, then `get()` it. Just to mention the trivial cases.\r\n\r\n > ServiceManager can (and probably will) change state when any of this APIs (`build()`,`get()`, `has()`) gets called. There are no tests present to cover that state changes. Not completely true, there are some, but their intention is not to track the state changes. But fortunately they do."}}
{"actor":{"display_login":"weierophinney"}}