{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node-v8/issues/46","repository_url":"https://api.github.com/repos/nodejs/node-v8","labels_url":"https://api.github.com/repos/nodejs/node-v8/issues/46/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node-v8/issues/46/comments","events_url":"https://api.github.com/repos/nodejs/node-v8/issues/46/events","html_url":"https://github.com/nodejs/node-v8/issues/46","id":308092451,"number":46,"title":"New deprecations","user":{"login":"targos","id":2352663,"avatar_url":"https://avatars0.githubusercontent.com/u/2352663?v=4","gravatar_id":"","url":"https://api.github.com/users/targos","html_url":"https://github.com/targos","followers_url":"https://api.github.com/users/targos/followers","following_url":"https://api.github.com/users/targos/following{/other_user}","gists_url":"https://api.github.com/users/targos/gists{/gist_id}","starred_url":"https://api.github.com/users/targos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/targos/subscriptions","organizations_url":"https://api.github.com/users/targos/orgs","repos_url":"https://api.github.com/users/targos/repos","events_url":"https://api.github.com/users/targos/events{/privacy}","received_events_url":"https://api.github.com/users/targos/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-23T16:15:13Z","updated_at":"2018-05-01T11:41:31Z","closed_at":"2018-05-01T11:41:31Z","author_association":"OWNER","body":"These cannot be fixed on master:\r\n\r\n```\r\n\r\n../src/async_wrap.cc: In function ‘void node::LoadAsyncWrapperInfo(node::Environment*)’:\r\n../src/async_wrap.cc:575:77: warning: ‘void v8::HeapProfiler::SetWrapperClassInfoProvider(uint16_t, v8::HeapProfiler::WrapperInfoCallback)’ is deprecated: Use SetBuildEmbedderGraphCallback to provide info about embedder nodes [-Wdeprecated-declarations]\r\n       (NODE_ASYNC_ID_OFFSET + AsyncWrap::PROVIDER_ ## PROVIDER), WrapperInfo);\r\n                                                                             ^\r\n../src/async_wrap.h:37:3: note: in expansion of macro ‘V’\r\n   V(NONE)                                                                     \\\r\n   ^\r\n../src/async_wrap.h:89:3: note: in expansion of macro ‘NODE_ASYNC_NON_CRYPTO_PROVIDER_TYPES’\r\n   NODE_ASYNC_NON_CRYPTO_PROVIDER_TYPES(V)                                     \\\r\n   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\r\n../src/async_wrap.cc:576:3: note: in expansion of macro ‘NODE_ASYNC_PROVIDER_TYPES’\r\n   NODE_ASYNC_PROVIDER_TYPES(V)\r\n   ^~~~~~~~~~~~~~~~~~~~~~~~~\r\nIn file included from ../deps/v8/include/v8.h:26:0,\r\n                 from ../src/node_persistent.h:6,\r\n                 from ../src/base_object.h:27,\r\n                 from ../src/async_wrap.h:27,\r\n                 from ../src/async_wrap-inl.h:27,\r\n                 from ../src/async_wrap.cc:22:\r\n../deps/v8/include/v8-profiler.h:882:12: note: declared here\r\n       void SetWrapperClassInfoProvider(uint16_t class_id,\r\n            ^\r\n../deps/v8/include/v8config.h:318:3: note: in definition of macro ‘V8_DEPRECATED’\r\n   declarator __attribute__((deprecated(message)))\r\n   ^~~~~~~~~~\r\n```\r\n\r\n```\r\n../src/env.cc: In lambda function:\r\n../src/env.cc:244:56: warning: ‘void v8::CpuProfiler::SetIdle(bool)’ is deprecated: Use Isolate::SetIdle(bool) instead. [-Wdeprecated-declarations]\r\n     env->isolate_data()->GetCpuProfiler()->SetIdle(true);\r\n                                                        ^\r\nIn file included from ../deps/v8/include/v8.h:26:0,\r\n                 from ../src/node.h:63,\r\n                 from ../src/node_internals.h:27,\r\n                 from ../src/env.cc:1:\r\n../deps/v8/include/v8-profiler.h:339:22: note: declared here\r\n                 void SetIdle(bool is_idle));\r\n                      ^\r\n../deps/v8/include/v8config.h:318:3: note: in definition of macro ‘V8_DEPRECATED’\r\n   declarator __attribute__((deprecated(message)))\r\n   ^~~~~~~~~~\r\n../src/env.cc: In lambda function:\r\n../src/env.cc:249:57: warning: ‘void v8::CpuProfiler::SetIdle(bool)’ is deprecated: Use Isolate::SetIdle(bool) instead. [-Wdeprecated-declarations]\r\n     env->isolate_data()->GetCpuProfiler()->SetIdle(false);\r\n                                                         ^\r\nIn file included from ../deps/v8/include/v8.h:26:0,\r\n                 from ../src/node.h:63,\r\n                 from ../src/node_internals.h:27,\r\n                 from ../src/env.cc:1:\r\n../deps/v8/include/v8-profiler.h:339:22: note: declared here\r\n                 void SetIdle(bool is_idle));\r\n                      ^\r\n../deps/v8/include/v8config.h:318:3: note: in definition of macro ‘V8_DEPRECATED’\r\n   declarator __attribute__((deprecated(message)))\r\n   ^~~~~~~~~~\r\n```"},"comment":{"url":"https://api.github.com/repos/nodejs/node-v8/issues/comments/385652828","html_url":"https://github.com/nodejs/node-v8/issues/46#issuecomment-385652828","issue_url":"https://api.github.com/repos/nodejs/node-v8/issues/46","id":385652828,"user":{"login":"targos","id":2352663,"avatar_url":"https://avatars0.githubusercontent.com/u/2352663?v=4","gravatar_id":"","url":"https://api.github.com/users/targos","html_url":"https://github.com/targos","followers_url":"https://api.github.com/users/targos/followers","following_url":"https://api.github.com/users/targos/following{/other_user}","gists_url":"https://api.github.com/users/targos/gists{/gist_id}","starred_url":"https://api.github.com/users/targos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/targos/subscriptions","organizations_url":"https://api.github.com/users/targos/orgs","repos_url":"https://api.github.com/users/targos/repos","events_url":"https://api.github.com/users/targos/events{/privacy}","received_events_url":"https://api.github.com/users/targos/received_events","type":"User","site_admin":false},"created_at":"2018-05-01T11:41:31Z","updated_at":"2018-05-01T11:41:31Z","author_association":"OWNER","body":"This issue is now being tracked in https://github.com/nodejs/node/pull/19989"}}
{"actor":{"display_login":"targos"}}