{"action":"created","issue":{"url":"https://api.github.com/repos/Lightricks/ReactiveObjC/issues/19","repository_url":"https://api.github.com/repos/Lightricks/ReactiveObjC","labels_url":"https://api.github.com/repos/Lightricks/ReactiveObjC/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/Lightricks/ReactiveObjC/issues/19/comments","events_url":"https://api.github.com/repos/Lightricks/ReactiveObjC/issues/19/events","html_url":"https://github.com/Lightricks/ReactiveObjC/pull/19","id":341319397,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNDk3MTM3","number":19,"title":"RACSignal: override combinePreviousWithStart:reduce: implementation.","user":{"login":"ofirgluzman","id":15310405,"node_id":"MDQ6VXNlcjE1MzEwNDA1","avatar_url":"https://avatars2.githubusercontent.com/u/15310405?v=4","gravatar_id":"","url":"https://api.github.com/users/ofirgluzman","html_url":"https://github.com/ofirgluzman","followers_url":"https://api.github.com/users/ofirgluzman/followers","following_url":"https://api.github.com/users/ofirgluzman/following{/other_user}","gists_url":"https://api.github.com/users/ofirgluzman/gists{/gist_id}","starred_url":"https://api.github.com/users/ofirgluzman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofirgluzman/subscriptions","organizations_url":"https://api.github.com/users/ofirgluzman/orgs","repos_url":"https://api.github.com/users/ofirgluzman/repos","events_url":"https://api.github.com/users/ofirgluzman/events{/privacy}","received_events_url":"https://api.github.com/users/ofirgluzman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-15T13:01:57Z","updated_at":"2018-07-15T17:16:10Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Lightricks/ReactiveObjC/pulls/19","html_url":"https://github.com/Lightricks/ReactiveObjC/pull/19","diff_url":"https://github.com/Lightricks/ReactiveObjC/pull/19.diff","patch_url":"https://github.com/Lightricks/ReactiveObjC/pull/19.patch"},"body":"Current implementation of combinePreviousWithStart:reduce: in RACSignal\r\nis originated in RACStream ancestor and relies on the method\r\nscanWithStart:reduce:.\r\nUsing the method forces implementation to pack the current sent value\r\nwith the reduce(previous, current) value in the scan block: the current\r\nvalue is used for the next run of the scan, becoming the previous value.\r\nThe reduce(previous, current) is used for forwarding the reduced value\r\nin the pipeline. The problem with that method is that\r\nreduce(previous, current) gets retained for no practical reason until\r\nthe next value gets sent.\r\n\r\nThe overriding implementation of the method uses a straightforward\r\napproach without relying on other RACStream existing operators. It is\r\nalso much more intuitive for reading than the original implementation.\r\n\r\nSee [RACStream combinePreviousWithStart:reduce:] for more information."},"comment":{"url":"https://api.github.com/repos/Lightricks/ReactiveObjC/issues/comments/405104944","html_url":"https://github.com/Lightricks/ReactiveObjC/pull/19#issuecomment-405104944","issue_url":"https://api.github.com/repos/Lightricks/ReactiveObjC/issues/19","id":405104944,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTEwNDk0NA==","user":{"login":"ofirgluzman","id":15310405,"node_id":"MDQ6VXNlcjE1MzEwNDA1","avatar_url":"https://avatars2.githubusercontent.com/u/15310405?v=4","gravatar_id":"","url":"https://api.github.com/users/ofirgluzman","html_url":"https://github.com/ofirgluzman","followers_url":"https://api.github.com/users/ofirgluzman/followers","following_url":"https://api.github.com/users/ofirgluzman/following{/other_user}","gists_url":"https://api.github.com/users/ofirgluzman/gists{/gist_id}","starred_url":"https://api.github.com/users/ofirgluzman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofirgluzman/subscriptions","organizations_url":"https://api.github.com/users/ofirgluzman/orgs","repos_url":"https://api.github.com/users/ofirgluzman/repos","events_url":"https://api.github.com/users/ofirgluzman/events{/privacy}","received_events_url":"https://api.github.com/users/ofirgluzman/received_events","type":"User","site_admin":false},"created_at":"2018-07-15T17:16:10Z","updated_at":"2018-07-15T17:16:10Z","author_association":"MEMBER","body":"done"}}
{"actor":{"display_login":"ofirgluzman"}}