{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments/182531697","pull_request_review_id":113343722,"id":182531697,"diff_hunk":"@@ -38,5 +46,24 @@ static class StrategyCmdlet\n \n             return newState.Get(config) ?? current.Get(config);\n         }\n+\n+        static string ToPowerShellString(object value)\n+        {\n+            if (value == null)\n+            {\n+                return \"$null\";\n+            }\n+            var s = value as string;\n+            if (s != null)\n+            {\n+                return \"\\\"\" + s + \"\\\"\";\n+            }\n+            var e = value as IEnumerable;\n+            if (e != null)\n+            {\n+                return string.Join(\",\", e.Cast<object>().Select(ToPowerShellString));\n+            }\n+            return value.ToString();","path":"src/ResourceManager/Compute/Commands.Compute/Strategies/StrategyCmdlet.cs","position":41,"original_position":41,"commit_id":"69516a3ae4ead351633d35088043e1b7c9178f64","original_commit_id":"69516a3ae4ead351633d35088043e1b7c9178f64","user":{"login":"praries880","id":35941423,"avatar_url":"https://avatars2.githubusercontent.com/u/35941423?v=4","gravatar_id":"","url":"https://api.github.com/users/praries880","html_url":"https://github.com/praries880","followers_url":"https://api.github.com/users/praries880/followers","following_url":"https://api.github.com/users/praries880/following{/other_user}","gists_url":"https://api.github.com/users/praries880/gists{/gist_id}","starred_url":"https://api.github.com/users/praries880/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praries880/subscriptions","organizations_url":"https://api.github.com/users/praries880/orgs","repos_url":"https://api.github.com/users/praries880/repos","events_url":"https://api.github.com/users/praries880/events{/privacy}","received_events_url":"https://api.github.com/users/praries880/received_events","type":"User","site_admin":false},"body":"so for this, if the type of the parameter (specifically for custom defined classes) does not implement a ToString() this would just print out the object type instead of a string representation of the data in the object? Do we want to do this? ","created_at":"2018-04-18T18:47:07Z","updated_at":"2018-04-18T18:47:29Z","html_url":"https://github.com/Azure/azure-powershell/pull/5933#discussion_r182531697","pull_request_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/5933","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments/182531697"},"html":{"href":"https://github.com/Azure/azure-powershell/pull/5933#discussion_r182531697"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/5933"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-powershell/pulls/5933","id":181051304,"html_url":"https://github.com/Azure/azure-powershell/pull/5933","diff_url":"https://github.com/Azure/azure-powershell/pull/5933.diff","patch_url":"https://github.com/Azure/azure-powershell/pull/5933.patch","issue_url":"https://api.github.com/repos/Azure/azure-powershell/issues/5933","number":5933,"state":"open","locked":false,"title":"New-AzureRmVm/VMSS: verbose parameter output.","user":{"login":"sergey-shandar","id":902339,"avatar_url":"https://avatars2.githubusercontent.com/u/902339?v=4","gravatar_id":"","url":"https://api.github.com/users/sergey-shandar","html_url":"https://github.com/sergey-shandar","followers_url":"https://api.github.com/users/sergey-shandar/followers","following_url":"https://api.github.com/users/sergey-shandar/following{/other_user}","gists_url":"https://api.github.com/users/sergey-shandar/gists{/gist_id}","starred_url":"https://api.github.com/users/sergey-shandar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergey-shandar/subscriptions","organizations_url":"https://api.github.com/users/sergey-shandar/orgs","repos_url":"https://api.github.com/users/sergey-shandar/repos","events_url":"https://api.github.com/users/sergey-shandar/events{/privacy}","received_events_url":"https://api.github.com/users/sergey-shandar/received_events","type":"User","site_admin":false},"body":"<!-- DO NOT DELETE THIS TEMPLATE -->\r\n\r\n## Description\r\n\r\n#5650 \r\n\r\nKnown issues:\r\n- [ ] It appears that the implementation also depends on the issue #5663. We need deterministic -parameter for a domain name label.\r\n- [x] Complex object PS serialization.\r\n   - `IEnumerable`\r\n   - `null`\r\n   - `.ToString()` for everything else\r\n\r\n## Checklist\r\n\r\n- [x] I have read the [_Submitting Changes_](https://github.com/Azure/azure-powershell/blob/preview/CONTRIBUTING.md#submitting-changes) section of [`CONTRIBUTING.md`](https://github.com/Azure/azure-powershell/blob/preview/CONTRIBUTING.md)\r\n- [x] The title of the PR is clear and informative\r\n- [x] The appropriate [change log has been updated](https://github.com/Azure/azure-powershell/blob/preview/CONTRIBUTING.md#updating-the-change-log)\r\n- [x] The PR does not introduce [breaking changes](https://github.com/Azure/azure-powershell/blob/preview/documentation/breaking-changes/breaking-changes-definition.md)\r\n- [ ] If applicable, the changes made in the PR have proper test coverage\r\n- [ ] For public API changes to cmdlets:\r\n    - [ ] the changes have gone through a [cmdlet design review](https://github.com/Azure/azure-powershell-cmdlet-review-pr)\r\n    - [ ] the cmdlet markdown files were [generated using the `platyPS` module](https://github.com/Azure/azure-powershell/blob/preview/documentation/development-docs/help-generation.md)\r\n","created_at":"2018-04-11T23:07:45Z","updated_at":"2018-04-18T18:47:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f196b3d873e2f9f598ed1d7d0d410c1b6ff6bf87","assignee":{"login":"praries880","id":35941423,"avatar_url":"https://avatars2.githubusercontent.com/u/35941423?v=4","gravatar_id":"","url":"https://api.github.com/users/praries880","html_url":"https://github.com/praries880","followers_url":"https://api.github.com/users/praries880/followers","following_url":"https://api.github.com/users/praries880/following{/other_user}","gists_url":"https://api.github.com/users/praries880/gists{/gist_id}","starred_url":"https://api.github.com/users/praries880/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praries880/subscriptions","organizations_url":"https://api.github.com/users/praries880/orgs","repos_url":"https://api.github.com/users/praries880/repos","events_url":"https://api.github.com/users/praries880/events{/privacy}","received_events_url":"https://api.github.com/users/praries880/received_events","type":"User","site_admin":false},"assignees":[{"login":"praries880","id":35941423,"avatar_url":"https://avatars2.githubusercontent.com/u/35941423?v=4","gravatar_id":"","url":"https://api.github.com/users/praries880","html_url":"https://github.com/praries880","followers_url":"https://api.github.com/users/praries880/followers","following_url":"https://api.github.com/users/praries880/following{/other_user}","gists_url":"https://api.github.com/users/praries880/gists{/gist_id}","starred_url":"https://api.github.com/users/praries880/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praries880/subscriptions","organizations_url":"https://api.github.com/users/praries880/orgs","repos_url":"https://api.github.com/users/praries880/repos","events_url":"https://api.github.com/users/praries880/events{/privacy}","received_events_url":"https://api.github.com/users/praries880/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":556234674,"url":"https://api.github.com/repos/Azure/azure-powershell/labels/needs-review","name":"needs-review","color":"fbcfff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/5933/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/5933/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-powershell/issues/5933/comments","statuses_url":"https://api.github.com/repos/Azure/azure-powershell/statuses/69516a3ae4ead351633d35088043e1b7c9178f64","head":{"label":"sergey-shandar:sergey-whatif","ref":"sergey-whatif","sha":"69516a3ae4ead351633d35088043e1b7c9178f64","user":{"login":"sergey-shandar","id":902339,"avatar_url":"https://avatars2.githubusercontent.com/u/902339?v=4","gravatar_id":"","url":"https://api.github.com/users/sergey-shandar","html_url":"https://github.com/sergey-shandar","followers_url":"https://api.github.com/users/sergey-shandar/followers","following_url":"https://api.github.com/users/sergey-shandar/following{/other_user}","gists_url":"https://api.github.com/users/sergey-shandar/gists{/gist_id}","starred_url":"https://api.github.com/users/sergey-shandar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergey-shandar/subscriptions","organizations_url":"https://api.github.com/users/sergey-shandar/orgs","repos_url":"https://api.github.com/users/sergey-shandar/repos","events_url":"https://api.github.com/users/sergey-shandar/events{/privacy}","received_events_url":"https://api.github.com/users/sergey-shandar/received_events","type":"User","site_admin":false},"repo":{"id":100314673,"name":"azure-powershell","full_name":"sergey-shandar/azure-powershell","owner":{"login":"sergey-shandar","id":902339,"avatar_url":"https://avatars2.githubusercontent.com/u/902339?v=4","gravatar_id":"","url":"https://api.github.com/users/sergey-shandar","html_url":"https://github.com/sergey-shandar","followers_url":"https://api.github.com/users/sergey-shandar/followers","following_url":"https://api.github.com/users/sergey-shandar/following{/other_user}","gists_url":"https://api.github.com/users/sergey-shandar/gists{/gist_id}","starred_url":"https://api.github.com/users/sergey-shandar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergey-shandar/subscriptions","organizations_url":"https://api.github.com/users/sergey-shandar/orgs","repos_url":"https://api.github.com/users/sergey-shandar/repos","events_url":"https://api.github.com/users/sergey-shandar/events{/privacy}","received_events_url":"https://api.github.com/users/sergey-shandar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sergey-shandar/azure-powershell","description":"Microsoft Azure PowerShell","fork":true,"url":"https://api.github.com/repos/sergey-shandar/azure-powershell","forks_url":"https://api.github.com/repos/sergey-shandar/azure-powershell/forks","keys_url":"https://api.github.com/repos/sergey-shandar/azure-powershell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sergey-shandar/azure-powershell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sergey-shandar/azure-powershell/teams","hooks_url":"https://api.github.com/repos/sergey-shandar/azure-powershell/hooks","issue_events_url":"https://api.github.com/repos/sergey-shandar/azure-powershell/issues/events{/number}","events_url":"https://api.github.com/repos/sergey-shandar/azure-powershell/events","assignees_url":"https://api.github.com/repos/sergey-shandar/azure-powershell/assignees{/user}","branches_url":"https://api.github.com/repos/sergey-shandar/azure-powershell/branches{/branch}","tags_url":"https://api.github.com/repos/sergey-shandar/azure-powershell/tags","blobs_url":"https://api.github.com/repos/sergey-shandar/azure-powershell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sergey-shandar/azure-powershell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sergey-shandar/azure-powershell/git/refs{/sha}","trees_url":"https://api.github.com/repos/sergey-shandar/azure-powershell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sergey-shandar/azure-powershell/statuses/{sha}","languages_url":"https://api.github.com/repos/sergey-shandar/azure-powershell/languages","stargazers_url":"https://api.github.com/repos/sergey-shandar/azure-powershell/stargazers","contributors_url":"https://api.github.com/repos/sergey-shandar/azure-powershell/contributors","subscribers_url":"https://api.github.com/repos/sergey-shandar/azure-powershell/subscribers","subscription_url":"https://api.github.com/repos/sergey-shandar/azure-powershell/subscription","commits_url":"https://api.github.com/repos/sergey-shandar/azure-powershell/commits{/sha}","git_commits_url":"https://api.github.com/repos/sergey-shandar/azure-powershell/git/commits{/sha}","comments_url":"https://api.github.com/repos/sergey-shandar/azure-powershell/comments{/number}","issue_comment_url":"https://api.github.com/repos/sergey-shandar/azure-powershell/issues/comments{/number}","contents_url":"https://api.github.com/repos/sergey-shandar/azure-powershell/contents/{+path}","compare_url":"https://api.github.com/repos/sergey-shandar/azure-powershell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sergey-shandar/azure-powershell/merges","archive_url":"https://api.github.com/repos/sergey-shandar/azure-powershell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sergey-shandar/azure-powershell/downloads","issues_url":"https://api.github.com/repos/sergey-shandar/azure-powershell/issues{/number}","pulls_url":"https://api.github.com/repos/sergey-shandar/azure-powershell/pulls{/number}","milestones_url":"https://api.github.com/repos/sergey-shandar/azure-powershell/milestones{/number}","notifications_url":"https://api.github.com/repos/sergey-shandar/azure-powershell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sergey-shandar/azure-powershell/labels{/name}","releases_url":"https://api.github.com/repos/sergey-shandar/azure-powershell/releases{/id}","deployments_url":"https://api.github.com/repos/sergey-shandar/azure-powershell/deployments","created_at":"2017-08-14T22:34:52Z","updated_at":"2017-08-14T22:35:35Z","pushed_at":"2018-04-18T02:54:45Z","git_url":"git://github.com/sergey-shandar/azure-powershell.git","ssh_url":"git@github.com:sergey-shandar/azure-powershell.git","clone_url":"https://github.com/sergey-shandar/azure-powershell.git","svn_url":"https://github.com/sergey-shandar/azure-powershell","homepage":null,"size":385478,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"preview"}},"base":{"label":"Azure:preview","ref":"preview","sha":"af9c1bfdf427774a6992ba84bcbb32bc3eab06e9","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":23891194,"name":"azure-powershell","full_name":"Azure/azure-powershell","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-powershell","description":"Microsoft Azure PowerShell","fork":false,"url":"https://api.github.com/repos/Azure/azure-powershell","forks_url":"https://api.github.com/repos/Azure/azure-powershell/forks","keys_url":"https://api.github.com/repos/Azure/azure-powershell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-powershell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-powershell/teams","hooks_url":"https://api.github.com/repos/Azure/azure-powershell/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-powershell/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-powershell/events","assignees_url":"https://api.github.com/repos/Azure/azure-powershell/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-powershell/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-powershell/tags","blobs_url":"https://api.github.com/repos/Azure/azure-powershell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-powershell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-powershell/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-powershell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-powershell/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-powershell/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-powershell/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-powershell/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-powershell/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-powershell/subscription","commits_url":"https://api.github.com/repos/Azure/azure-powershell/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-powershell/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-powershell/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-powershell/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-powershell/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-powershell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-powershell/merges","archive_url":"https://api.github.com/repos/Azure/azure-powershell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-powershell/downloads","issues_url":"https://api.github.com/repos/Azure/azure-powershell/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-powershell/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-powershell/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-powershell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-powershell/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-powershell/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-powershell/deployments","created_at":"2014-09-10T20:35:18Z","updated_at":"2018-04-18T16:02:48Z","pushed_at":"2018-04-18T18:43:48Z","git_url":"git://github.com/Azure/azure-powershell.git","ssh_url":"git@github.com:Azure/azure-powershell.git","clone_url":"https://github.com/Azure/azure-powershell.git","svn_url":"https://github.com/Azure/azure-powershell","homepage":null,"size":390467,"stargazers_count":978,"watchers_count":978,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1024,"mirror_url":null,"archived":false,"open_issues_count":612,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1024,"open_issues":612,"watchers":978,"default_branch":"preview"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/5933"},"html":{"href":"https://github.com/Azure/azure-powershell/pull/5933"},"issue":{"href":"https://api.github.com/repos/Azure/azure-powershell/issues/5933"},"comments":{"href":"https://api.github.com/repos/Azure/azure-powershell/issues/5933/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/5933/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/5933/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-powershell/statuses/69516a3ae4ead351633d35088043e1b7c9178f64"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"praries880"}}