{"action":"created","issue":{"url":"https://api.github.com/repos/nusmodifications/nusmods/issues/1213","repository_url":"https://api.github.com/repos/nusmodifications/nusmods","labels_url":"https://api.github.com/repos/nusmodifications/nusmods/issues/1213/labels{/name}","comments_url":"https://api.github.com/repos/nusmodifications/nusmods/issues/1213/comments","events_url":"https://api.github.com/repos/nusmodifications/nusmods/issues/1213/events","html_url":"https://github.com/nusmodifications/nusmods/issues/1213","id":368935436,"node_id":"MDU6SXNzdWUzNjg5MzU0MzY=","number":1213,"title":"Correct venue names to use Title Case instead of ALL CAPS ","user":{"login":"ZhangYiJiang","id":445650,"node_id":"MDQ6VXNlcjQ0NTY1MA==","avatar_url":"https://avatars0.githubusercontent.com/u/445650?v=4","gravatar_id":"","url":"https://api.github.com/users/ZhangYiJiang","html_url":"https://github.com/ZhangYiJiang","followers_url":"https://api.github.com/users/ZhangYiJiang/followers","following_url":"https://api.github.com/users/ZhangYiJiang/following{/other_user}","gists_url":"https://api.github.com/users/ZhangYiJiang/gists{/gist_id}","starred_url":"https://api.github.com/users/ZhangYiJiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZhangYiJiang/subscriptions","organizations_url":"https://api.github.com/users/ZhangYiJiang/orgs","repos_url":"https://api.github.com/users/ZhangYiJiang/repos","events_url":"https://api.github.com/users/ZhangYiJiang/events{/privacy}","received_events_url":"https://api.github.com/users/ZhangYiJiang/received_events","type":"User","site_admin":false},"labels":[{"id":1075434596,"node_id":"MDU6TGFiZWwxMDc1NDM0NTk2","url":"https://api.github.com/repos/nusmodifications/nusmods/labels/Hacktoberfest","name":"Hacktoberfest","color":"4f283a","default":false},{"id":1076421680,"node_id":"MDU6TGFiZWwxMDc2NDIxNjgw","url":"https://api.github.com/repos/nusmodifications/nusmods/labels/Taken","name":"Taken","color":"ad1a35","default":false},{"id":114040679,"node_id":"MDU6TGFiZWwxMTQwNDA2Nzk=","url":"https://api.github.com/repos/nusmodifications/nusmods/labels/good%20first%20issue","name":"good first issue","color":"fbca04","default":true},{"id":1036394521,"node_id":"MDU6TGFiZWwxMDM2Mzk0NTIx","url":"https://api.github.com/repos/nusmodifications/nusmods/labels/venue%20data","name":"venue data","color":"f9ffa5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-10-11T03:14:32Z","updated_at":"2018-10-19T08:40:12Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"ALL OF THE- sorry, my caps lock got stuck. All of the venues pulled from the NUS venue APIs currently have ALL CAPS venue names. This may work for them, but it looks pretty ugly for us. All caps text is also harder to read. \r\n\r\nIt should be possible to automatically convert names like \"SEMINAR ROOM 2\" to \"Seminar Room 2\". \r\nCurrently we use lodash to capitalize the text on the frontend, and the result is not optimal because things like abbreviations are incorrectly converted to lowercase eg. https://nusmods.com/venues/WS2-01-30. \r\n\r\nA good way to fix this is to write a script to clean up the data in venues.json https://github.com/nusmodifications/nusmods/blob/master/www/src/js/data/venues.json. Doing this offline allows us to use a proper dictionary to correctly determine which words need to be capitalized. Do note that some venue names should not be capitalized, like the i3 building. \r\n"},"comment":{"url":"https://api.github.com/repos/nusmodifications/nusmods/issues/comments/431289664","html_url":"https://github.com/nusmodifications/nusmods/issues/1213#issuecomment-431289664","issue_url":"https://api.github.com/repos/nusmodifications/nusmods/issues/1213","id":431289664,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTI4OTY2NA==","user":{"login":"ZhangYiJiang","id":445650,"node_id":"MDQ6VXNlcjQ0NTY1MA==","avatar_url":"https://avatars0.githubusercontent.com/u/445650?v=4","gravatar_id":"","url":"https://api.github.com/users/ZhangYiJiang","html_url":"https://github.com/ZhangYiJiang","followers_url":"https://api.github.com/users/ZhangYiJiang/followers","following_url":"https://api.github.com/users/ZhangYiJiang/following{/other_user}","gists_url":"https://api.github.com/users/ZhangYiJiang/gists{/gist_id}","starred_url":"https://api.github.com/users/ZhangYiJiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZhangYiJiang/subscriptions","organizations_url":"https://api.github.com/users/ZhangYiJiang/orgs","repos_url":"https://api.github.com/users/ZhangYiJiang/repos","events_url":"https://api.github.com/users/ZhangYiJiang/events{/privacy}","received_events_url":"https://api.github.com/users/ZhangYiJiang/received_events","type":"User","site_admin":false},"created_at":"2018-10-19T08:40:12Z","updated_at":"2018-10-19T08:40:12Z","author_association":"CONTRIBUTOR","body":"I was actually thinking of just using `/usr/share/dict/words` since this isn't likely going to be run very frequently, but having a more portable solution is nice. The library is GPL though, so I don't know if this is going to cause any issue. "}}
{"actor":{"display_login":"ZhangYiJiang"}}