{"action":"closed","number":1526,"pull_request":{"url":"https://api.github.com/repos/valhalla/valhalla/pulls/1526","id":215536531,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NTM2NTMx","html_url":"https://github.com/valhalla/valhalla/pull/1526","diff_url":"https://github.com/valhalla/valhalla/pull/1526.diff","patch_url":"https://github.com/valhalla/valhalla/pull/1526.patch","issue_url":"https://api.github.com/repos/valhalla/valhalla/issues/1526","number":1526,"state":"closed","locked":false,"title":"Update .gitignore","user":{"login":"molind","id":102496,"node_id":"MDQ6VXNlcjEwMjQ5Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/102496?v=4","gravatar_id":"","url":"https://api.github.com/users/molind","html_url":"https://github.com/molind","followers_url":"https://api.github.com/users/molind/followers","following_url":"https://api.github.com/users/molind/following{/other_user}","gists_url":"https://api.github.com/users/molind/gists{/gist_id}","starred_url":"https://api.github.com/users/molind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/molind/subscriptions","organizations_url":"https://api.github.com/users/molind/orgs","repos_url":"https://api.github.com/users/molind/repos","events_url":"https://api.github.com/users/molind/events{/privacy}","received_events_url":"https://api.github.com/users/molind/received_events","type":"User","site_admin":false},"body":"Removed valhalla/proto and src/proto from gitignore.\r\nThese paths is unused anymore. And it could be difficult to find why valhalla won't build if you have some old headers in those folders.\r\n\r\n# Issue\r\n\r\nSmall code cleanup. I've had files in proto folders and spent 15 minutes to understand why it won't build. With correct gitignore old files will be displayed in `git status` and it's easy to delete them by `git reset --hard`.\r\n\r\n## Tasklist\r\n\r\n - [ ] Add tests\r\n - [ ] Review - you must request approval to merge any PR to master\r\n - [ ] Add #fixes with the issue number that this PR addresses\r\n - [ ] Generally use squash merge to rebase and clean comments before merging\r\n - [ ] Update the [changelog](CHANGELOG.md)\r\n - [ ] Update relevant [documentation](docs/README.md)\r\n\r\n## Requirements / Relations\r\n\r\n Link any requirements here. Other pull requests this PR is based on?\r\n","created_at":"2018-09-14T09:37:11Z","updated_at":"2018-09-14T12:37:00Z","closed_at":"2018-09-14T12:37:00Z","merged_at":"2018-09-14T12:37:00Z","merge_commit_sha":"7c6ff3d7a6d5d5dd5b1d01e004bea774c01173b2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/valhalla/valhalla/pulls/1526/commits","review_comments_url":"https://api.github.com/repos/valhalla/valhalla/pulls/1526/comments","review_comment_url":"https://api.github.com/repos/valhalla/valhalla/pulls/comments{/number}","comments_url":"https://api.github.com/repos/valhalla/valhalla/issues/1526/comments","statuses_url":"https://api.github.com/repos/valhalla/valhalla/statuses/33e02865ed3025721c421907c7461845f6c3d9e5","head":{"label":"molind:patch-1","ref":"patch-1","sha":"33e02865ed3025721c421907c7461845f6c3d9e5","user":{"login":"molind","id":102496,"node_id":"MDQ6VXNlcjEwMjQ5Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/102496?v=4","gravatar_id":"","url":"https://api.github.com/users/molind","html_url":"https://github.com/molind","followers_url":"https://api.github.com/users/molind/followers","following_url":"https://api.github.com/users/molind/following{/other_user}","gists_url":"https://api.github.com/users/molind/gists{/gist_id}","starred_url":"https://api.github.com/users/molind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/molind/subscriptions","organizations_url":"https://api.github.com/users/molind/orgs","repos_url":"https://api.github.com/users/molind/repos","events_url":"https://api.github.com/users/molind/events{/privacy}","received_events_url":"https://api.github.com/users/molind/received_events","type":"User","site_admin":false},"repo":{"id":84201422,"node_id":"MDEwOlJlcG9zaXRvcnk4NDIwMTQyMg==","name":"valhalla","full_name":"molind/valhalla","owner":{"login":"molind","id":102496,"node_id":"MDQ6VXNlcjEwMjQ5Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/102496?v=4","gravatar_id":"","url":"https://api.github.com/users/molind","html_url":"https://github.com/molind","followers_url":"https://api.github.com/users/molind/followers","following_url":"https://api.github.com/users/molind/following{/other_user}","gists_url":"https://api.github.com/users/molind/gists{/gist_id}","starred_url":"https://api.github.com/users/molind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/molind/subscriptions","organizations_url":"https://api.github.com/users/molind/orgs","repos_url":"https://api.github.com/users/molind/repos","events_url":"https://api.github.com/users/molind/events{/privacy}","received_events_url":"https://api.github.com/users/molind/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/molind/valhalla","description":"Open Source Routing Engine for OpenStreetMap","fork":true,"url":"https://api.github.com/repos/molind/valhalla","forks_url":"https://api.github.com/repos/molind/valhalla/forks","keys_url":"https://api.github.com/repos/molind/valhalla/keys{/key_id}","collaborators_url":"https://api.github.com/repos/molind/valhalla/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/molind/valhalla/teams","hooks_url":"https://api.github.com/repos/molind/valhalla/hooks","issue_events_url":"https://api.github.com/repos/molind/valhalla/issues/events{/number}","events_url":"https://api.github.com/repos/molind/valhalla/events","assignees_url":"https://api.github.com/repos/molind/valhalla/assignees{/user}","branches_url":"https://api.github.com/repos/molind/valhalla/branches{/branch}","tags_url":"https://api.github.com/repos/molind/valhalla/tags","blobs_url":"https://api.github.com/repos/molind/valhalla/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/molind/valhalla/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/molind/valhalla/git/refs{/sha}","trees_url":"https://api.github.com/repos/molind/valhalla/git/trees{/sha}","statuses_url":"https://api.github.com/repos/molind/valhalla/statuses/{sha}","languages_url":"https://api.github.com/repos/molind/valhalla/languages","stargazers_url":"https://api.github.com/repos/molind/valhalla/stargazers","contributors_url":"https://api.github.com/repos/molind/valhalla/contributors","subscribers_url":"https://api.github.com/repos/molind/valhalla/subscribers","subscription_url":"https://api.github.com/repos/molind/valhalla/subscription","commits_url":"https://api.github.com/repos/molind/valhalla/commits{/sha}","git_commits_url":"https://api.github.com/repos/molind/valhalla/git/commits{/sha}","comments_url":"https://api.github.com/repos/molind/valhalla/comments{/number}","issue_comment_url":"https://api.github.com/repos/molind/valhalla/issues/comments{/number}","contents_url":"https://api.github.com/repos/molind/valhalla/contents/{+path}","compare_url":"https://api.github.com/repos/molind/valhalla/compare/{base}...{head}","merges_url":"https://api.github.com/repos/molind/valhalla/merges","archive_url":"https://api.github.com/repos/molind/valhalla/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/molind/valhalla/downloads","issues_url":"https://api.github.com/repos/molind/valhalla/issues{/number}","pulls_url":"https://api.github.com/repos/molind/valhalla/pulls{/number}","milestones_url":"https://api.github.com/repos/molind/valhalla/milestones{/number}","notifications_url":"https://api.github.com/repos/molind/valhalla/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/molind/valhalla/labels{/name}","releases_url":"https://api.github.com/repos/molind/valhalla/releases{/id}","deployments_url":"https://api.github.com/repos/molind/valhalla/deployments","created_at":"2017-03-07T13:20:31Z","updated_at":"2017-03-07T13:20:35Z","pushed_at":"2018-09-14T09:47:08Z","git_url":"git://github.com/molind/valhalla.git","ssh_url":"git@github.com:molind/valhalla.git","clone_url":"https://github.com/molind/valhalla.git","svn_url":"https://github.com/molind/valhalla","homepage":"","size":94814,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"valhalla:master","ref":"master","sha":"c7ef276bdc2d033dcea01feb9d066b6ea6c80a51","user":{"login":"valhalla","id":10232331,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjMyMzMx","avatar_url":"https://avatars1.githubusercontent.com/u/10232331?v=4","gravatar_id":"","url":"https://api.github.com/users/valhalla","html_url":"https://github.com/valhalla","followers_url":"https://api.github.com/users/valhalla/followers","following_url":"https://api.github.com/users/valhalla/following{/other_user}","gists_url":"https://api.github.com/users/valhalla/gists{/gist_id}","starred_url":"https://api.github.com/users/valhalla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valhalla/subscriptions","organizations_url":"https://api.github.com/users/valhalla/orgs","repos_url":"https://api.github.com/users/valhalla/repos","events_url":"https://api.github.com/users/valhalla/events{/privacy}","received_events_url":"https://api.github.com/users/valhalla/received_events","type":"Organization","site_admin":false},"repo":{"id":49978193,"node_id":"MDEwOlJlcG9zaXRvcnk0OTk3ODE5Mw==","name":"valhalla","full_name":"valhalla/valhalla","owner":{"login":"valhalla","id":10232331,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjMyMzMx","avatar_url":"https://avatars1.githubusercontent.com/u/10232331?v=4","gravatar_id":"","url":"https://api.github.com/users/valhalla","html_url":"https://github.com/valhalla","followers_url":"https://api.github.com/users/valhalla/followers","following_url":"https://api.github.com/users/valhalla/following{/other_user}","gists_url":"https://api.github.com/users/valhalla/gists{/gist_id}","starred_url":"https://api.github.com/users/valhalla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valhalla/subscriptions","organizations_url":"https://api.github.com/users/valhalla/orgs","repos_url":"https://api.github.com/users/valhalla/repos","events_url":"https://api.github.com/users/valhalla/events{/privacy}","received_events_url":"https://api.github.com/users/valhalla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/valhalla/valhalla","description":"Open Source Routing Engine for OpenStreetMap","fork":false,"url":"https://api.github.com/repos/valhalla/valhalla","forks_url":"https://api.github.com/repos/valhalla/valhalla/forks","keys_url":"https://api.github.com/repos/valhalla/valhalla/keys{/key_id}","collaborators_url":"https://api.github.com/repos/valhalla/valhalla/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/valhalla/valhalla/teams","hooks_url":"https://api.github.com/repos/valhalla/valhalla/hooks","issue_events_url":"https://api.github.com/repos/valhalla/valhalla/issues/events{/number}","events_url":"https://api.github.com/repos/valhalla/valhalla/events","assignees_url":"https://api.github.com/repos/valhalla/valhalla/assignees{/user}","branches_url":"https://api.github.com/repos/valhalla/valhalla/branches{/branch}","tags_url":"https://api.github.com/repos/valhalla/valhalla/tags","blobs_url":"https://api.github.com/repos/valhalla/valhalla/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/valhalla/valhalla/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/valhalla/valhalla/git/refs{/sha}","trees_url":"https://api.github.com/repos/valhalla/valhalla/git/trees{/sha}","statuses_url":"https://api.github.com/repos/valhalla/valhalla/statuses/{sha}","languages_url":"https://api.github.com/repos/valhalla/valhalla/languages","stargazers_url":"https://api.github.com/repos/valhalla/valhalla/stargazers","contributors_url":"https://api.github.com/repos/valhalla/valhalla/contributors","subscribers_url":"https://api.github.com/repos/valhalla/valhalla/subscribers","subscription_url":"https://api.github.com/repos/valhalla/valhalla/subscription","commits_url":"https://api.github.com/repos/valhalla/valhalla/commits{/sha}","git_commits_url":"https://api.github.com/repos/valhalla/valhalla/git/commits{/sha}","comments_url":"https://api.github.com/repos/valhalla/valhalla/comments{/number}","issue_comment_url":"https://api.github.com/repos/valhalla/valhalla/issues/comments{/number}","contents_url":"https://api.github.com/repos/valhalla/valhalla/contents/{+path}","compare_url":"https://api.github.com/repos/valhalla/valhalla/compare/{base}...{head}","merges_url":"https://api.github.com/repos/valhalla/valhalla/merges","archive_url":"https://api.github.com/repos/valhalla/valhalla/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/valhalla/valhalla/downloads","issues_url":"https://api.github.com/repos/valhalla/valhalla/issues{/number}","pulls_url":"https://api.github.com/repos/valhalla/valhalla/pulls{/number}","milestones_url":"https://api.github.com/repos/valhalla/valhalla/milestones{/number}","notifications_url":"https://api.github.com/repos/valhalla/valhalla/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/valhalla/valhalla/labels{/name}","releases_url":"https://api.github.com/repos/valhalla/valhalla/releases{/id}","deployments_url":"https://api.github.com/repos/valhalla/valhalla/deployments","created_at":"2016-01-19T19:42:29Z","updated_at":"2018-09-12T19:47:08Z","pushed_at":"2018-09-14T12:37:00Z","git_url":"git://github.com/valhalla/valhalla.git","ssh_url":"git@github.com:valhalla/valhalla.git","clone_url":"https://github.com/valhalla/valhalla.git","svn_url":"https://github.com/valhalla/valhalla","homepage":"","size":95751,"stargazers_count":678,"watchers_count":678,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":135,"mirror_url":null,"archived":false,"open_issues_count":257,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":135,"open_issues":257,"watchers":678,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/valhalla/valhalla/pulls/1526"},"html":{"href":"https://github.com/valhalla/valhalla/pull/1526"},"issue":{"href":"https://api.github.com/repos/valhalla/valhalla/issues/1526"},"comments":{"href":"https://api.github.com/repos/valhalla/valhalla/issues/1526/comments"},"review_comments":{"href":"https://api.github.com/repos/valhalla/valhalla/pulls/1526/comments"},"review_comment":{"href":"https://api.github.com/repos/valhalla/valhalla/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/valhalla/valhalla/pulls/1526/commits"},"statuses":{"href":"https://api.github.com/repos/valhalla/valhalla/statuses/33e02865ed3025721c421907c7461845f6c3d9e5"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"kevinkreiser","id":697548,"node_id":"MDQ6VXNlcjY5NzU0OA==","avatar_url":"https://avatars2.githubusercontent.com/u/697548?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinkreiser","html_url":"https://github.com/kevinkreiser","followers_url":"https://api.github.com/users/kevinkreiser/followers","following_url":"https://api.github.com/users/kevinkreiser/following{/other_user}","gists_url":"https://api.github.com/users/kevinkreiser/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinkreiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinkreiser/subscriptions","organizations_url":"https://api.github.com/users/kevinkreiser/orgs","repos_url":"https://api.github.com/users/kevinkreiser/repos","events_url":"https://api.github.com/users/kevinkreiser/events{/privacy}","received_events_url":"https://api.github.com/users/kevinkreiser/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":0,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"kevinkreiser"}}