{"action":"created","comment":{"url":"https://api.github.com/repos/apache/mynewt-mcumgr/pulls/comments/240723278","pull_request_review_id":183817976,"id":240723278,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDcyMzI3OA==","diff_hunk":"@@ -0,0 +1,233 @@\n+# Mcumgr/Newtmgr protocol\n+\n+The `newtmgr` tool uses a custom protocol to send commands and responses\n+between the manager and the end node using a variety of transports (currently\n+TTY serial or BLE).\n+\n+The protocol isn't documented but the following information has been inferred\n+from the source code available on Github and using the `-l DEBUG` flag When\n+executing commands.\n+\n+## Source Code\n+\n+The golang source for **newtmgr** is [available here](https://github.com/apache/mynewt-newtmgr),","path":"protocol.md","position":13,"original_position":13,"commit_id":"33e9c2de3c409b06b1016dddeef6024ce28b78b1","original_commit_id":"33e9c2de3c409b06b1016dddeef6024ce28b78b1","user":{"login":"carlescufi","id":12450381,"node_id":"MDQ6VXNlcjEyNDUwMzgx","avatar_url":"https://avatars3.githubusercontent.com/u/12450381?v=4","gravatar_id":"","url":"https://api.github.com/users/carlescufi","html_url":"https://github.com/carlescufi","followers_url":"https://api.github.com/users/carlescufi/followers","following_url":"https://api.github.com/users/carlescufi/following{/other_user}","gists_url":"https://api.github.com/users/carlescufi/gists{/gist_id}","starred_url":"https://api.github.com/users/carlescufi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlescufi/subscriptions","organizations_url":"https://api.github.com/users/carlescufi/orgs","repos_url":"https://api.github.com/users/carlescufi/repos","events_url":"https://api.github.com/users/carlescufi/events{/privacy}","received_events_url":"https://api.github.com/users/carlescufi/received_events","type":"User","site_admin":false},"body":"So mcumgr, the tool, is the SMP client. mcumgr, the C library, is the SMP server","created_at":"2018-12-11T17:52:16Z","updated_at":"2018-12-11T17:53:57Z","html_url":"https://github.com/apache/mynewt-mcumgr/pull/18#discussion_r240723278","pull_request_url":"https://api.github.com/repos/apache/mynewt-mcumgr/pulls/18","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/mynewt-mcumgr/pulls/comments/240723278"},"html":{"href":"https://github.com/apache/mynewt-mcumgr/pull/18#discussion_r240723278"},"pull_request":{"href":"https://api.github.com/repos/apache/mynewt-mcumgr/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/apache/mynewt-mcumgr/pulls/18","id":237660467,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NjYwNDY3","html_url":"https://github.com/apache/mynewt-mcumgr/pull/18","diff_url":"https://github.com/apache/mynewt-mcumgr/pull/18.diff","patch_url":"https://github.com/apache/mynewt-mcumgr/pull/18.patch","issue_url":"https://api.github.com/repos/apache/mynewt-mcumgr/issues/18","number":18,"state":"open","locked":false,"title":"Added initial protocol description for NMP/SMP","user":{"login":"microbuilder","id":181073,"node_id":"MDQ6VXNlcjE4MTA3Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/181073?v=4","gravatar_id":"","url":"https://api.github.com/users/microbuilder","html_url":"https://github.com/microbuilder","followers_url":"https://api.github.com/users/microbuilder/followers","following_url":"https://api.github.com/users/microbuilder/following{/other_user}","gists_url":"https://api.github.com/users/microbuilder/gists{/gist_id}","starred_url":"https://api.github.com/users/microbuilder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microbuilder/subscriptions","organizations_url":"https://api.github.com/users/microbuilder/orgs","repos_url":"https://api.github.com/users/microbuilder/repos","events_url":"https://api.github.com/users/microbuilder/events{/privacy}","received_events_url":"https://api.github.com/users/microbuilder/received_events","type":"User","site_admin":false},"body":"This PR is based on some documentation from [Adafruit_Mynewt](https://github.com/adafruit/Adafruit_Mynewt/tree/master/docs), and attempts to describe some of the basics of the nmp protocol used by both newtmgr and mcumgr.\r\n\r\nThe original documentation is based on an early release of the protocol in the context of Apache Mynewt, but an attempt has been made to bring the links and basic details up to date with the golang based `newtmgr` and the C based `mcumgr` projects.\r\n\r\nFurther extensions to this document are of course welcome and necessary to help people implement nmp in their mobile, desktop or other applications.","created_at":"2018-12-11T12:26:31Z","updated_at":"2018-12-11T17:53:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4616f3475036d1cafc5eb2e273a30d0c7ca0ead","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":770883790,"node_id":"MDU6TGFiZWw3NzA4ODM3OTA=","url":"https://api.github.com/repos/apache/mynewt-mcumgr/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/apache/mynewt-mcumgr/pulls/18/commits","review_comments_url":"https://api.github.com/repos/apache/mynewt-mcumgr/pulls/18/comments","review_comment_url":"https://api.github.com/repos/apache/mynewt-mcumgr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/mynewt-mcumgr/issues/18/comments","statuses_url":"https://api.github.com/repos/apache/mynewt-mcumgr/statuses/33e9c2de3c409b06b1016dddeef6024ce28b78b1","head":{"label":"microbuilder:master","ref":"master","sha":"33e9c2de3c409b06b1016dddeef6024ce28b78b1","user":{"login":"microbuilder","id":181073,"node_id":"MDQ6VXNlcjE4MTA3Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/181073?v=4","gravatar_id":"","url":"https://api.github.com/users/microbuilder","html_url":"https://github.com/microbuilder","followers_url":"https://api.github.com/users/microbuilder/followers","following_url":"https://api.github.com/users/microbuilder/following{/other_user}","gists_url":"https://api.github.com/users/microbuilder/gists{/gist_id}","starred_url":"https://api.github.com/users/microbuilder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microbuilder/subscriptions","organizations_url":"https://api.github.com/users/microbuilder/orgs","repos_url":"https://api.github.com/users/microbuilder/repos","events_url":"https://api.github.com/users/microbuilder/events{/privacy}","received_events_url":"https://api.github.com/users/microbuilder/received_events","type":"User","site_admin":false},"repo":{"id":161325090,"node_id":"MDEwOlJlcG9zaXRvcnkxNjEzMjUwOTA=","name":"mynewt-mcumgr","full_name":"microbuilder/mynewt-mcumgr","private":false,"owner":{"login":"microbuilder","id":181073,"node_id":"MDQ6VXNlcjE4MTA3Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/181073?v=4","gravatar_id":"","url":"https://api.github.com/users/microbuilder","html_url":"https://github.com/microbuilder","followers_url":"https://api.github.com/users/microbuilder/followers","following_url":"https://api.github.com/users/microbuilder/following{/other_user}","gists_url":"https://api.github.com/users/microbuilder/gists{/gist_id}","starred_url":"https://api.github.com/users/microbuilder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microbuilder/subscriptions","organizations_url":"https://api.github.com/users/microbuilder/orgs","repos_url":"https://api.github.com/users/microbuilder/repos","events_url":"https://api.github.com/users/microbuilder/events{/privacy}","received_events_url":"https://api.github.com/users/microbuilder/received_events","type":"User","site_admin":false},"html_url":"https://github.com/microbuilder/mynewt-mcumgr","description":"Apache mynewt","fork":true,"url":"https://api.github.com/repos/microbuilder/mynewt-mcumgr","forks_url":"https://api.github.com/repos/microbuilder/mynewt-mcumgr/forks","keys_url":"https://api.github.com/repos/microbuilder/mynewt-mcumgr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microbuilder/mynewt-mcumgr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microbuilder/mynewt-mcumgr/teams","hooks_url":"https://api.github.com/repos/microbuilder/mynewt-mcumgr/hooks","issue_events_url":"https://api.github.com/repos/microbuilder/mynewt-mcumgr/issues/events{/number}","events_url":"https://api.github.com/repos/microbuilder/mynewt-mcumgr/events","assignees_url":"https://api.github.com/repos/microbuilder/mynewt-mcumgr/assignees{/user}","branches_url":"https://api.github.com/repos/microbuilder/mynewt-mcumgr/branches{/branch}","tags_url":"https://api.github.com/repos/microbuilder/mynewt-mcumgr/tags","blobs_url":"https://api.github.com/repos/microbuilder/mynewt-mcumgr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microbuilder/mynewt-mcumgr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microbuilder/mynewt-mcumgr/git/refs{/sha}","trees_url":"https://api.github.com/repos/microbuilder/mynewt-mcumgr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microbuilder/mynewt-mcumgr/statuses/{sha}","languages_url":"https://api.github.com/repos/microbuilder/mynewt-mcumgr/languages","stargazers_url":"https://api.github.com/repos/microbuilder/mynewt-mcumgr/stargazers","contributors_url":"https://api.github.com/repos/microbuilder/mynewt-mcumgr/contributors","subscribers_url":"https://api.github.com/repos/microbuilder/mynewt-mcumgr/subscribers","subscription_url":"https://api.github.com/repos/microbuilder/mynewt-mcumgr/subscription","commits_url":"https://api.github.com/repos/microbuilder/mynewt-mcumgr/commits{/sha}","git_commits_url":"https://api.github.com/repos/microbuilder/mynewt-mcumgr/git/commits{/sha}","comments_url":"https://api.github.com/repos/microbuilder/mynewt-mcumgr/comments{/number}","issue_comment_url":"https://api.github.com/repos/microbuilder/mynewt-mcumgr/issues/comments{/number}","contents_url":"https://api.github.com/repos/microbuilder/mynewt-mcumgr/contents/{+path}","compare_url":"https://api.github.com/repos/microbuilder/mynewt-mcumgr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microbuilder/mynewt-mcumgr/merges","archive_url":"https://api.github.com/repos/microbuilder/mynewt-mcumgr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microbuilder/mynewt-mcumgr/downloads","issues_url":"https://api.github.com/repos/microbuilder/mynewt-mcumgr/issues{/number}","pulls_url":"https://api.github.com/repos/microbuilder/mynewt-mcumgr/pulls{/number}","milestones_url":"https://api.github.com/repos/microbuilder/mynewt-mcumgr/milestones{/number}","notifications_url":"https://api.github.com/repos/microbuilder/mynewt-mcumgr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microbuilder/mynewt-mcumgr/labels{/name}","releases_url":"https://api.github.com/repos/microbuilder/mynewt-mcumgr/releases{/id}","deployments_url":"https://api.github.com/repos/microbuilder/mynewt-mcumgr/deployments","created_at":"2018-12-11T11:40:28Z","updated_at":"2018-12-11T12:21:50Z","pushed_at":"2018-12-11T12:21:48Z","git_url":"git://github.com/microbuilder/mynewt-mcumgr.git","ssh_url":"git@github.com:microbuilder/mynewt-mcumgr.git","clone_url":"https://github.com/microbuilder/mynewt-mcumgr.git","svn_url":"https://github.com/microbuilder/mynewt-mcumgr","homepage":"https://mynewt.apache.org/","size":303,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"78d8ff6ffef8cc7f698927d9db07e3b82980acae","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":113273448,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMyNzM0NDg=","name":"mynewt-mcumgr","full_name":"apache/mynewt-mcumgr","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/mynewt-mcumgr","description":"Apache mynewt","fork":false,"url":"https://api.github.com/repos/apache/mynewt-mcumgr","forks_url":"https://api.github.com/repos/apache/mynewt-mcumgr/forks","keys_url":"https://api.github.com/repos/apache/mynewt-mcumgr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/mynewt-mcumgr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/mynewt-mcumgr/teams","hooks_url":"https://api.github.com/repos/apache/mynewt-mcumgr/hooks","issue_events_url":"https://api.github.com/repos/apache/mynewt-mcumgr/issues/events{/number}","events_url":"https://api.github.com/repos/apache/mynewt-mcumgr/events","assignees_url":"https://api.github.com/repos/apache/mynewt-mcumgr/assignees{/user}","branches_url":"https://api.github.com/repos/apache/mynewt-mcumgr/branches{/branch}","tags_url":"https://api.github.com/repos/apache/mynewt-mcumgr/tags","blobs_url":"https://api.github.com/repos/apache/mynewt-mcumgr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/mynewt-mcumgr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/mynewt-mcumgr/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/mynewt-mcumgr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/mynewt-mcumgr/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/mynewt-mcumgr/languages","stargazers_url":"https://api.github.com/repos/apache/mynewt-mcumgr/stargazers","contributors_url":"https://api.github.com/repos/apache/mynewt-mcumgr/contributors","subscribers_url":"https://api.github.com/repos/apache/mynewt-mcumgr/subscribers","subscription_url":"https://api.github.com/repos/apache/mynewt-mcumgr/subscription","commits_url":"https://api.github.com/repos/apache/mynewt-mcumgr/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/mynewt-mcumgr/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/mynewt-mcumgr/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/mynewt-mcumgr/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/mynewt-mcumgr/contents/{+path}","compare_url":"https://api.github.com/repos/apache/mynewt-mcumgr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/mynewt-mcumgr/merges","archive_url":"https://api.github.com/repos/apache/mynewt-mcumgr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/mynewt-mcumgr/downloads","issues_url":"https://api.github.com/repos/apache/mynewt-mcumgr/issues{/number}","pulls_url":"https://api.github.com/repos/apache/mynewt-mcumgr/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/mynewt-mcumgr/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/mynewt-mcumgr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/mynewt-mcumgr/labels{/name}","releases_url":"https://api.github.com/repos/apache/mynewt-mcumgr/releases{/id}","deployments_url":"https://api.github.com/repos/apache/mynewt-mcumgr/deployments","created_at":"2017-12-06T05:34:08Z","updated_at":"2018-12-04T00:13:49Z","pushed_at":"2018-12-11T12:26:32Z","git_url":"git://github.com/apache/mynewt-mcumgr.git","ssh_url":"git@github.com:apache/mynewt-mcumgr.git","clone_url":"https://github.com/apache/mynewt-mcumgr.git","svn_url":"https://github.com/apache/mynewt-mcumgr","homepage":"https://mynewt.apache.org/","size":291,"stargazers_count":14,"watchers_count":14,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":12,"open_issues":4,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/mynewt-mcumgr/pulls/18"},"html":{"href":"https://github.com/apache/mynewt-mcumgr/pull/18"},"issue":{"href":"https://api.github.com/repos/apache/mynewt-mcumgr/issues/18"},"comments":{"href":"https://api.github.com/repos/apache/mynewt-mcumgr/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/mynewt-mcumgr/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/mynewt-mcumgr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/mynewt-mcumgr/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/apache/mynewt-mcumgr/statuses/33e9c2de3c409b06b1016dddeef6024ce28b78b1"}},"author_association":"NONE"}}
{"actor":{"display_login":"carlescufi"}}