{"action":"created","comment":{"url":"https://api.github.com/repos/servo/servo/pulls/comments/233240249","pull_request_review_id":174610006,"id":233240249,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzI0MDI0OQ==","diff_hunk":"@@ -511,6 +511,132 @@ impl WebGLRenderingContext {\n             _ => false,\n         }\n     }\n+    \n+    // Remove all the different types of comments from a given shader source","path":"components/script/dom/webglrenderingcontext.rs","position":5,"original_position":5,"commit_id":"69572caa85c1ad4c6d9aec244810d652502da922","original_commit_id":"69572caa85c1ad4c6d9aec244810d652502da922","user":{"login":"sumit0190","id":8823156,"node_id":"MDQ6VXNlcjg4MjMxNTY=","avatar_url":"https://avatars0.githubusercontent.com/u/8823156?v=4","gravatar_id":"","url":"https://api.github.com/users/sumit0190","html_url":"https://github.com/sumit0190","followers_url":"https://api.github.com/users/sumit0190/followers","following_url":"https://api.github.com/users/sumit0190/following{/other_user}","gists_url":"https://api.github.com/users/sumit0190/gists{/gist_id}","starred_url":"https://api.github.com/users/sumit0190/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumit0190/subscriptions","organizations_url":"https://api.github.com/users/sumit0190/orgs","repos_url":"https://api.github.com/users/sumit0190/repos","events_url":"https://api.github.com/users/sumit0190/events{/privacy}","received_events_url":"https://api.github.com/users/sumit0190/received_events","type":"User","site_admin":false},"body":"@Manishearth This is mostly a direct translation of the Firefox version of this function, but I did go through *a* spec (I am not sure if it's *the* spec - based on my limited knowledge of the WebGL standard, it only accepts ES1.0 GLSL) to validate my logic:\r\nhttps://www.khronos.org/files/opengles_shading_language.pdf\r\n\r\nI'll add a comment pointing to this spec and fix the other issues in my next commit, as I am sure feedback related to the logic is yet to follow. :)","created_at":"2018-11-13T22:05:27Z","updated_at":"2018-11-13T22:05:27Z","html_url":"https://github.com/servo/servo/pull/22189#discussion_r233240249","pull_request_url":"https://api.github.com/repos/servo/servo/pulls/22189","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/comments/233240249"},"html":{"href":"https://github.com/servo/servo/pull/22189#discussion_r233240249"},"pull_request":{"href":"https://api.github.com/repos/servo/servo/pulls/22189"}},"in_reply_to_id":233228773},"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/22189","id":230553056,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNTUzMDU2","html_url":"https://github.com/servo/servo/pull/22189","diff_url":"https://github.com/servo/servo/pull/22189.diff","patch_url":"https://github.com/servo/servo/pull/22189.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/22189","number":22189,"state":"open","locked":false,"title":"Add string validation to ShaderSource; #21754","user":{"login":"sumit0190","id":8823156,"node_id":"MDQ6VXNlcjg4MjMxNTY=","avatar_url":"https://avatars0.githubusercontent.com/u/8823156?v=4","gravatar_id":"","url":"https://api.github.com/users/sumit0190","html_url":"https://github.com/sumit0190","followers_url":"https://api.github.com/users/sumit0190/followers","following_url":"https://api.github.com/users/sumit0190/following{/other_user}","gists_url":"https://api.github.com/users/sumit0190/gists{/gist_id}","starred_url":"https://api.github.com/users/sumit0190/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumit0190/subscriptions","organizations_url":"https://api.github.com/users/sumit0190/orgs","repos_url":"https://api.github.com/users/sumit0190/repos","events_url":"https://api.github.com/users/sumit0190/events{/privacy}","received_events_url":"https://api.github.com/users/sumit0190/received_events","type":"User","site_admin":false},"body":"Add string validation to ShaderSource\r\n---\r\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\r\n- [X] `./mach build -d` does not report any errors\r\n- [X] `./mach test-tidy` does not report any errors\r\n- [X] These changes fix #21754  (github issue number if applicable).\r\n\r\n<!-- Either: -->\r\n- [ ] There are tests for these changes OR\r\n- [X] These changes do not require tests because there is at least one existing test.\r\n\r\n<!-- Also, please make sure that \"Allow edits from maintainers\" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->\r\n\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/22189)\n<!-- Reviewable:end -->\n","created_at":"2018-11-13T17:00:44Z","updated_at":"2018-11-13T22:05:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89ef584cf73a8b21b8e1fb791d3cd2c8c9f8e9a5","assignee":{"login":"nox","id":123095,"node_id":"MDQ6VXNlcjEyMzA5NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/123095?v=4","gravatar_id":"","url":"https://api.github.com/users/nox","html_url":"https://github.com/nox","followers_url":"https://api.github.com/users/nox/followers","following_url":"https://api.github.com/users/nox/following{/other_user}","gists_url":"https://api.github.com/users/nox/gists{/gist_id}","starred_url":"https://api.github.com/users/nox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nox/subscriptions","organizations_url":"https://api.github.com/users/nox/orgs","repos_url":"https://api.github.com/users/nox/repos","events_url":"https://api.github.com/users/nox/events{/privacy}","received_events_url":"https://api.github.com/users/nox/received_events","type":"User","site_admin":false},"assignees":[{"login":"nox","id":123095,"node_id":"MDQ6VXNlcjEyMzA5NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/123095?v=4","gravatar_id":"","url":"https://api.github.com/users/nox","html_url":"https://github.com/nox","followers_url":"https://api.github.com/users/nox/followers","following_url":"https://api.github.com/users/nox/following{/other_user}","gists_url":"https://api.github.com/users/nox/gists{/gist_id}","starred_url":"https://api.github.com/users/nox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nox/subscriptions","organizations_url":"https://api.github.com/users/nox/orgs","repos_url":"https://api.github.com/users/nox/repos","events_url":"https://api.github.com/users/nox/events{/privacy}","received_events_url":"https://api.github.com/users/nox/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":152310043,"node_id":"MDU6TGFiZWwxNTIzMTAwNDM=","url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-review","name":"S-awaiting-review","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/22189/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/22189/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/22189/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/69572caa85c1ad4c6d9aec244810d652502da922","head":{"label":"sumit0190:validateshader","ref":"validateshader","sha":"69572caa85c1ad4c6d9aec244810d652502da922","user":{"login":"sumit0190","id":8823156,"node_id":"MDQ6VXNlcjg4MjMxNTY=","avatar_url":"https://avatars0.githubusercontent.com/u/8823156?v=4","gravatar_id":"","url":"https://api.github.com/users/sumit0190","html_url":"https://github.com/sumit0190","followers_url":"https://api.github.com/users/sumit0190/followers","following_url":"https://api.github.com/users/sumit0190/following{/other_user}","gists_url":"https://api.github.com/users/sumit0190/gists{/gist_id}","starred_url":"https://api.github.com/users/sumit0190/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumit0190/subscriptions","organizations_url":"https://api.github.com/users/sumit0190/orgs","repos_url":"https://api.github.com/users/sumit0190/repos","events_url":"https://api.github.com/users/sumit0190/events{/privacy}","received_events_url":"https://api.github.com/users/sumit0190/received_events","type":"User","site_admin":false},"repo":{"id":149684610,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk2ODQ2MTA=","name":"servo","full_name":"sumit0190/servo","private":false,"owner":{"login":"sumit0190","id":8823156,"node_id":"MDQ6VXNlcjg4MjMxNTY=","avatar_url":"https://avatars0.githubusercontent.com/u/8823156?v=4","gravatar_id":"","url":"https://api.github.com/users/sumit0190","html_url":"https://github.com/sumit0190","followers_url":"https://api.github.com/users/sumit0190/followers","following_url":"https://api.github.com/users/sumit0190/following{/other_user}","gists_url":"https://api.github.com/users/sumit0190/gists{/gist_id}","starred_url":"https://api.github.com/users/sumit0190/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumit0190/subscriptions","organizations_url":"https://api.github.com/users/sumit0190/orgs","repos_url":"https://api.github.com/users/sumit0190/repos","events_url":"https://api.github.com/users/sumit0190/events{/privacy}","received_events_url":"https://api.github.com/users/sumit0190/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sumit0190/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/sumit0190/servo","forks_url":"https://api.github.com/repos/sumit0190/servo/forks","keys_url":"https://api.github.com/repos/sumit0190/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sumit0190/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sumit0190/servo/teams","hooks_url":"https://api.github.com/repos/sumit0190/servo/hooks","issue_events_url":"https://api.github.com/repos/sumit0190/servo/issues/events{/number}","events_url":"https://api.github.com/repos/sumit0190/servo/events","assignees_url":"https://api.github.com/repos/sumit0190/servo/assignees{/user}","branches_url":"https://api.github.com/repos/sumit0190/servo/branches{/branch}","tags_url":"https://api.github.com/repos/sumit0190/servo/tags","blobs_url":"https://api.github.com/repos/sumit0190/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sumit0190/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sumit0190/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/sumit0190/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sumit0190/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/sumit0190/servo/languages","stargazers_url":"https://api.github.com/repos/sumit0190/servo/stargazers","contributors_url":"https://api.github.com/repos/sumit0190/servo/contributors","subscribers_url":"https://api.github.com/repos/sumit0190/servo/subscribers","subscription_url":"https://api.github.com/repos/sumit0190/servo/subscription","commits_url":"https://api.github.com/repos/sumit0190/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/sumit0190/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/sumit0190/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/sumit0190/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/sumit0190/servo/contents/{+path}","compare_url":"https://api.github.com/repos/sumit0190/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sumit0190/servo/merges","archive_url":"https://api.github.com/repos/sumit0190/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sumit0190/servo/downloads","issues_url":"https://api.github.com/repos/sumit0190/servo/issues{/number}","pulls_url":"https://api.github.com/repos/sumit0190/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/sumit0190/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/sumit0190/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sumit0190/servo/labels{/name}","releases_url":"https://api.github.com/repos/sumit0190/servo/releases{/id}","deployments_url":"https://api.github.com/repos/sumit0190/servo/deployments","created_at":"2018-09-20T23:55:56Z","updated_at":"2018-09-20T23:56:08Z","pushed_at":"2018-11-13T16:58:06Z","git_url":"git://github.com/sumit0190/servo.git","ssh_url":"git@github.com:sumit0190/servo.git","clone_url":"https://github.com/sumit0190/servo.git","svn_url":"https://github.com/sumit0190/servo","homepage":"https://servo.org/","size":503001,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"b1a2b6b5bfe72440059834c67dc28ad422b89a82","user":{"login":"servo","id":2566135,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NjYxMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/2566135?v=4","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"node_id":"MDEwOlJlcG9zaXRvcnkzMzkwMjQz","name":"servo","full_name":"servo/servo","private":false,"owner":{"login":"servo","id":2566135,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NjYxMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/2566135?v=4","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","deployments_url":"https://api.github.com/repos/servo/servo/deployments","created_at":"2012-02-08T19:07:25Z","updated_at":"2018-11-13T22:04:35Z","pushed_at":"2018-11-13T21:56:40Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"https://servo.org/","size":691774,"stargazers_count":12726,"watchers_count":12726,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1991,"mirror_url":null,"archived":false,"open_issues_count":2519,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":1991,"open_issues":2519,"watchers":12726,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/22189"},"html":{"href":"https://github.com/servo/servo/pull/22189"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/22189"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/22189/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/22189/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/22189/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/69572caa85c1ad4c6d9aec244810d652502da922"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sumit0190"}}