{"action":"created","comment":{"url":"https://api.github.com/repos/coq/coq/pulls/comments/180883411","pull_request_review_id":111385241,"id":180883411,"diff_hunk":"@@ -183,6 +183,8 @@ Standard Library\n - Added [Coq.Strings.String.concat] to concatenate a list of strings\n   inserting a separator between each item\n - Notation `'` for Zpos in QArith was removed.\n+- Added [Coq.Structures.OrderedTypeEx.String_as_OT] to make strings an\n+  ordered type (using lexical order)","path":"CHANGES","position":5,"original_position":5,"commit_id":"a8ee93f20c5ca1c0c5d55483ded29af3fa24787a","original_commit_id":"a8ee93f20c5ca1c0c5d55483ded29af3fa24787a","user":{"login":"Zimmi48","id":1108325,"avatar_url":"https://avatars2.githubusercontent.com/u/1108325?v=4","gravatar_id":"","url":"https://api.github.com/users/Zimmi48","html_url":"https://github.com/Zimmi48","followers_url":"https://api.github.com/users/Zimmi48/followers","following_url":"https://api.github.com/users/Zimmi48/following{/other_user}","gists_url":"https://api.github.com/users/Zimmi48/gists{/gist_id}","starred_url":"https://api.github.com/users/Zimmi48/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zimmi48/subscriptions","organizations_url":"https://api.github.com/users/Zimmi48/orgs","repos_url":"https://api.github.com/users/Zimmi48/repos","events_url":"https://api.github.com/users/Zimmi48/events{/privacy}","received_events_url":"https://api.github.com/users/Zimmi48/received_events","type":"User","site_admin":false},"body":"This entry is out of place. It should be in the very top section (changes beyond 8.8) and there you can create a new \"Standard Library\" sub-section.","created_at":"2018-04-11T20:13:53Z","updated_at":"2018-04-11T20:14:23Z","html_url":"https://github.com/coq/coq/pull/7221#discussion_r180883411","pull_request_url":"https://api.github.com/repos/coq/coq/pulls/7221","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/coq/coq/pulls/comments/180883411"},"html":{"href":"https://github.com/coq/coq/pull/7221#discussion_r180883411"},"pull_request":{"href":"https://api.github.com/repos/coq/coq/pulls/7221"}}},"pull_request":{"url":"https://api.github.com/repos/coq/coq/pulls/7221","id":181014277,"html_url":"https://github.com/coq/coq/pull/7221","diff_url":"https://github.com/coq/coq/pull/7221.diff","patch_url":"https://github.com/coq/coq/pull/7221.patch","issue_url":"https://api.github.com/repos/coq/coq/issues/7221","number":7221,"state":"open","locked":false,"title":"The usual order of strings.","user":{"login":"lastland","id":848550,"avatar_url":"https://avatars2.githubusercontent.com/u/848550?v=4","gravatar_id":"","url":"https://api.github.com/users/lastland","html_url":"https://github.com/lastland","followers_url":"https://api.github.com/users/lastland/followers","following_url":"https://api.github.com/users/lastland/following{/other_user}","gists_url":"https://api.github.com/users/lastland/gists{/gist_id}","starred_url":"https://api.github.com/users/lastland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lastland/subscriptions","organizations_url":"https://api.github.com/users/lastland/orgs","repos_url":"https://api.github.com/users/lastland/repos","events_url":"https://api.github.com/users/lastland/events{/privacy}","received_events_url":"https://api.github.com/users/lastland/received_events","type":"User","site_admin":false},"body":"**Kind:** feature.\r\n\r\n- [x] Corresponding documentation was added / updated.\r\n- [x] Entry added in CHANGES.\r\n\r\nI do not know if there is a particular reason that the order of strings is not in `OrderedTypeEx`. This PR adds that to it.","created_at":"2018-04-11T20:10:01Z","updated_at":"2018-04-11T20:14:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d52f134874d5c62ba06a789facc1f136c9e3a4a1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"letouzey","id":1541597,"avatar_url":"https://avatars2.githubusercontent.com/u/1541597?v=4","gravatar_id":"","url":"https://api.github.com/users/letouzey","html_url":"https://github.com/letouzey","followers_url":"https://api.github.com/users/letouzey/followers","following_url":"https://api.github.com/users/letouzey/following{/other_user}","gists_url":"https://api.github.com/users/letouzey/gists{/gist_id}","starred_url":"https://api.github.com/users/letouzey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letouzey/subscriptions","organizations_url":"https://api.github.com/users/letouzey/orgs","repos_url":"https://api.github.com/users/letouzey/repos","events_url":"https://api.github.com/users/letouzey/events{/privacy}","received_events_url":"https://api.github.com/users/letouzey/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/coq/coq/pulls/7221/commits","review_comments_url":"https://api.github.com/repos/coq/coq/pulls/7221/comments","review_comment_url":"https://api.github.com/repos/coq/coq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coq/coq/issues/7221/comments","statuses_url":"https://api.github.com/repos/coq/coq/statuses/a8ee93f20c5ca1c0c5d55483ded29af3fa24787a","head":{"label":"lastland:string-ordered-type","ref":"string-ordered-type","sha":"a8ee93f20c5ca1c0c5d55483ded29af3fa24787a","user":{"login":"lastland","id":848550,"avatar_url":"https://avatars2.githubusercontent.com/u/848550?v=4","gravatar_id":"","url":"https://api.github.com/users/lastland","html_url":"https://github.com/lastland","followers_url":"https://api.github.com/users/lastland/followers","following_url":"https://api.github.com/users/lastland/following{/other_user}","gists_url":"https://api.github.com/users/lastland/gists{/gist_id}","starred_url":"https://api.github.com/users/lastland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lastland/subscriptions","organizations_url":"https://api.github.com/users/lastland/orgs","repos_url":"https://api.github.com/users/lastland/repos","events_url":"https://api.github.com/users/lastland/events{/privacy}","received_events_url":"https://api.github.com/users/lastland/received_events","type":"User","site_admin":false},"repo":{"id":129145560,"name":"coq","full_name":"lastland/coq","owner":{"login":"lastland","id":848550,"avatar_url":"https://avatars2.githubusercontent.com/u/848550?v=4","gravatar_id":"","url":"https://api.github.com/users/lastland","html_url":"https://github.com/lastland","followers_url":"https://api.github.com/users/lastland/followers","following_url":"https://api.github.com/users/lastland/following{/other_user}","gists_url":"https://api.github.com/users/lastland/gists{/gist_id}","starred_url":"https://api.github.com/users/lastland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lastland/subscriptions","organizations_url":"https://api.github.com/users/lastland/orgs","repos_url":"https://api.github.com/users/lastland/repos","events_url":"https://api.github.com/users/lastland/events{/privacy}","received_events_url":"https://api.github.com/users/lastland/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lastland/coq","description":"Coq is a formal proof management system. It provides a formal language to write mathematical definitions, executable algorithms and theorems together with an environment for semi-interactive development of machine-checked proofs. ","fork":true,"url":"https://api.github.com/repos/lastland/coq","forks_url":"https://api.github.com/repos/lastland/coq/forks","keys_url":"https://api.github.com/repos/lastland/coq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lastland/coq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lastland/coq/teams","hooks_url":"https://api.github.com/repos/lastland/coq/hooks","issue_events_url":"https://api.github.com/repos/lastland/coq/issues/events{/number}","events_url":"https://api.github.com/repos/lastland/coq/events","assignees_url":"https://api.github.com/repos/lastland/coq/assignees{/user}","branches_url":"https://api.github.com/repos/lastland/coq/branches{/branch}","tags_url":"https://api.github.com/repos/lastland/coq/tags","blobs_url":"https://api.github.com/repos/lastland/coq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lastland/coq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lastland/coq/git/refs{/sha}","trees_url":"https://api.github.com/repos/lastland/coq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lastland/coq/statuses/{sha}","languages_url":"https://api.github.com/repos/lastland/coq/languages","stargazers_url":"https://api.github.com/repos/lastland/coq/stargazers","contributors_url":"https://api.github.com/repos/lastland/coq/contributors","subscribers_url":"https://api.github.com/repos/lastland/coq/subscribers","subscription_url":"https://api.github.com/repos/lastland/coq/subscription","commits_url":"https://api.github.com/repos/lastland/coq/commits{/sha}","git_commits_url":"https://api.github.com/repos/lastland/coq/git/commits{/sha}","comments_url":"https://api.github.com/repos/lastland/coq/comments{/number}","issue_comment_url":"https://api.github.com/repos/lastland/coq/issues/comments{/number}","contents_url":"https://api.github.com/repos/lastland/coq/contents/{+path}","compare_url":"https://api.github.com/repos/lastland/coq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lastland/coq/merges","archive_url":"https://api.github.com/repos/lastland/coq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lastland/coq/downloads","issues_url":"https://api.github.com/repos/lastland/coq/issues{/number}","pulls_url":"https://api.github.com/repos/lastland/coq/pulls{/number}","milestones_url":"https://api.github.com/repos/lastland/coq/milestones{/number}","notifications_url":"https://api.github.com/repos/lastland/coq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lastland/coq/labels{/name}","releases_url":"https://api.github.com/repos/lastland/coq/releases{/id}","deployments_url":"https://api.github.com/repos/lastland/coq/deployments","created_at":"2018-04-11T19:45:37Z","updated_at":"2018-04-11T19:45:53Z","pushed_at":"2018-04-11T20:08:11Z","git_url":"git://github.com/lastland/coq.git","ssh_url":"git@github.com:lastland/coq.git","clone_url":"https://github.com/lastland/coq.git","svn_url":"https://github.com/lastland/coq","homepage":"https://coq.inria.fr/","size":108153,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coq:master","ref":"master","sha":"8059a0efa79fcd72d56c424adf1bea10dae28d6d","user":{"login":"coq","id":621198,"avatar_url":"https://avatars1.githubusercontent.com/u/621198?v=4","gravatar_id":"","url":"https://api.github.com/users/coq","html_url":"https://github.com/coq","followers_url":"https://api.github.com/users/coq/followers","following_url":"https://api.github.com/users/coq/following{/other_user}","gists_url":"https://api.github.com/users/coq/gists{/gist_id}","starred_url":"https://api.github.com/users/coq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coq/subscriptions","organizations_url":"https://api.github.com/users/coq/orgs","repos_url":"https://api.github.com/users/coq/repos","events_url":"https://api.github.com/users/coq/events{/privacy}","received_events_url":"https://api.github.com/users/coq/received_events","type":"Organization","site_admin":false},"repo":{"id":1377159,"name":"coq","full_name":"coq/coq","owner":{"login":"coq","id":621198,"avatar_url":"https://avatars1.githubusercontent.com/u/621198?v=4","gravatar_id":"","url":"https://api.github.com/users/coq","html_url":"https://github.com/coq","followers_url":"https://api.github.com/users/coq/followers","following_url":"https://api.github.com/users/coq/following{/other_user}","gists_url":"https://api.github.com/users/coq/gists{/gist_id}","starred_url":"https://api.github.com/users/coq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coq/subscriptions","organizations_url":"https://api.github.com/users/coq/orgs","repos_url":"https://api.github.com/users/coq/repos","events_url":"https://api.github.com/users/coq/events{/privacy}","received_events_url":"https://api.github.com/users/coq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coq/coq","description":"Coq is a formal proof management system. It provides a formal language to write mathematical definitions, executable algorithms and theorems together with an environment for semi-interactive development of machine-checked proofs. ","fork":false,"url":"https://api.github.com/repos/coq/coq","forks_url":"https://api.github.com/repos/coq/coq/forks","keys_url":"https://api.github.com/repos/coq/coq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coq/coq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coq/coq/teams","hooks_url":"https://api.github.com/repos/coq/coq/hooks","issue_events_url":"https://api.github.com/repos/coq/coq/issues/events{/number}","events_url":"https://api.github.com/repos/coq/coq/events","assignees_url":"https://api.github.com/repos/coq/coq/assignees{/user}","branches_url":"https://api.github.com/repos/coq/coq/branches{/branch}","tags_url":"https://api.github.com/repos/coq/coq/tags","blobs_url":"https://api.github.com/repos/coq/coq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coq/coq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coq/coq/git/refs{/sha}","trees_url":"https://api.github.com/repos/coq/coq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coq/coq/statuses/{sha}","languages_url":"https://api.github.com/repos/coq/coq/languages","stargazers_url":"https://api.github.com/repos/coq/coq/stargazers","contributors_url":"https://api.github.com/repos/coq/coq/contributors","subscribers_url":"https://api.github.com/repos/coq/coq/subscribers","subscription_url":"https://api.github.com/repos/coq/coq/subscription","commits_url":"https://api.github.com/repos/coq/coq/commits{/sha}","git_commits_url":"https://api.github.com/repos/coq/coq/git/commits{/sha}","comments_url":"https://api.github.com/repos/coq/coq/comments{/number}","issue_comment_url":"https://api.github.com/repos/coq/coq/issues/comments{/number}","contents_url":"https://api.github.com/repos/coq/coq/contents/{+path}","compare_url":"https://api.github.com/repos/coq/coq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coq/coq/merges","archive_url":"https://api.github.com/repos/coq/coq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coq/coq/downloads","issues_url":"https://api.github.com/repos/coq/coq/issues{/number}","pulls_url":"https://api.github.com/repos/coq/coq/pulls{/number}","milestones_url":"https://api.github.com/repos/coq/coq/milestones{/number}","notifications_url":"https://api.github.com/repos/coq/coq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coq/coq/labels{/name}","releases_url":"https://api.github.com/repos/coq/coq/releases{/id}","deployments_url":"https://api.github.com/repos/coq/coq/deployments","created_at":"2011-02-17T05:49:37Z","updated_at":"2018-04-11T13:20:24Z","pushed_at":"2018-04-11T20:10:02Z","git_url":"git://github.com/coq/coq.git","ssh_url":"git@github.com:coq/coq.git","clone_url":"https://github.com/coq/coq.git","svn_url":"https://github.com/coq/coq","homepage":"https://coq.inria.fr/","size":108153,"stargazers_count":1109,"watchers_count":1109,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":242,"mirror_url":null,"archived":false,"open_issues_count":1504,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":242,"open_issues":1504,"watchers":1109,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coq/coq/pulls/7221"},"html":{"href":"https://github.com/coq/coq/pull/7221"},"issue":{"href":"https://api.github.com/repos/coq/coq/issues/7221"},"comments":{"href":"https://api.github.com/repos/coq/coq/issues/7221/comments"},"review_comments":{"href":"https://api.github.com/repos/coq/coq/pulls/7221/comments"},"review_comment":{"href":"https://api.github.com/repos/coq/coq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coq/coq/pulls/7221/commits"},"statuses":{"href":"https://api.github.com/repos/coq/coq/statuses/a8ee93f20c5ca1c0c5d55483ded29af3fa24787a"}},"author_association":"NONE"}}
{"actor":{"display_login":"Zimmi48"}}