{"action":"created","issue":{"url":"https://api.github.com/repos/talis/talis-php/issues/7","repository_url":"https://api.github.com/repos/talis/talis-php","labels_url":"https://api.github.com/repos/talis/talis-php/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/talis/talis-php/issues/7/comments","events_url":"https://api.github.com/repos/talis/talis-php/issues/7/events","html_url":"https://github.com/talis/talis-php/pull/7","id":373363683,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MzA5NjM4","number":7,"title":"30% Code quality checks","user":{"login":"kiyanwang","id":1135464,"node_id":"MDQ6VXNlcjExMzU0NjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1135464?v=4","gravatar_id":"","url":"https://api.github.com/users/kiyanwang","html_url":"https://github.com/kiyanwang","followers_url":"https://api.github.com/users/kiyanwang/followers","following_url":"https://api.github.com/users/kiyanwang/following{/other_user}","gists_url":"https://api.github.com/users/kiyanwang/gists{/gist_id}","starred_url":"https://api.github.com/users/kiyanwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiyanwang/subscriptions","organizations_url":"https://api.github.com/users/kiyanwang/orgs","repos_url":"https://api.github.com/users/kiyanwang/repos","events_url":"https://api.github.com/users/kiyanwang/events{/privacy}","received_events_url":"https://api.github.com/users/kiyanwang/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-10-24T08:29:39Z","updated_at":"2018-10-24T09:55:10Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/talis/talis-php/pulls/7","html_url":"https://github.com/talis/talis-php/pull/7","diff_url":"https://github.com/talis/talis-php/pull/7.diff","patch_url":"https://github.com/talis/talis-php/pull/7.patch"},"body":"This P/R introduces two tools into the project.\r\n\r\n- PHP Codesniffer to detect code quality issues, this is configured to use a Coding Standards ruleset that I've defined in test/Standards/TalisPHP which is based on conventions we use on other projects.\r\n\r\n- PHP MD which focuses more on code metrics and complexity/static analysis, which I've configured to use several built-in rulesets (codesize,unusedcode,naming)\r\n\r\nBoth of these tools can be tuned. \r\n\r\nThe `ant build.xml` file has been updated to include new targets for linting (phpcs) and codecheck (phpmd) and are configured to fail the build if you have any errors ( we have many!)\r\n\r\nThis P/R also introduces two new commands:\r\n\r\n`docker-compose run lint`\r\n`docker-compose run codecheck`\r\n"},"comment":{"url":"https://api.github.com/repos/talis/talis-php/issues/comments/432592553","html_url":"https://github.com/talis/talis-php/pull/7#issuecomment-432592553","issue_url":"https://api.github.com/repos/talis/talis-php/issues/7","id":432592553,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjU5MjU1Mw==","user":{"login":"kiyanwang","id":1135464,"node_id":"MDQ6VXNlcjExMzU0NjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1135464?v=4","gravatar_id":"","url":"https://api.github.com/users/kiyanwang","html_url":"https://github.com/kiyanwang","followers_url":"https://api.github.com/users/kiyanwang/followers","following_url":"https://api.github.com/users/kiyanwang/following{/other_user}","gists_url":"https://api.github.com/users/kiyanwang/gists{/gist_id}","starred_url":"https://api.github.com/users/kiyanwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiyanwang/subscriptions","organizations_url":"https://api.github.com/users/kiyanwang/orgs","repos_url":"https://api.github.com/users/kiyanwang/repos","events_url":"https://api.github.com/users/kiyanwang/events{/privacy}","received_events_url":"https://api.github.com/users/kiyanwang/received_events","type":"User","site_admin":false},"created_at":"2018-10-24T09:55:10Z","updated_at":"2018-10-24T09:55:10Z","author_association":"MEMBER","body":"@markwallsgrove There is already an ant target for running the coverage report\r\n\r\n```bash\r\nant coverage\r\n```\r\n\r\nBut this produces a html file inside the container. To use this we'll need to map the host filesystem to /var/talis-php inside the container like we do in other projects. the old echo php client repo has an example of this: https://github.com/talis/echo-php-client"}}
{"actor":{"display_login":"kiyanwang"}}