{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/165237720","pull_request_review_id":93142738,"id":165237720,"diff_hunk":"@@ -1015,10 +1023,43 @@ common.expectsError(\n   {\n     code: 'ERR_ASSERTION',\n     type: assert.AssertionError,\n-    message: 'test'\n+    message: 'test',\n+    generatedMessage: false\n   }\n );\n \n+// Do not try to check Node.js modules.\n+{\n+  const e = new EventEmitter();\n+\n+  e.on('hello', assert);\n+\n+  let threw = false;\n+  try {\n+    e.emit('hello', false);\n+  } catch (err) {\n+    const frames = err.stack.split('\\n');\n+    const [, filename, line, column] = frames[1].match(/\\((.+):(\\d+):(\\d+)\\)/);","path":"test/parallel/test-assert.js","position":66,"original_position":66,"commit_id":"acb1cbd49e19a991982b9bd135a03d5b89154af9","original_commit_id":"acb1cbd49e19a991982b9bd135a03d5b89154af9","user":{"login":"joyeecheung","id":4299420,"avatar_url":"https://avatars0.githubusercontent.com/u/4299420?v=4","gravatar_id":"","url":"https://api.github.com/users/joyeecheung","html_url":"https://github.com/joyeecheung","followers_url":"https://api.github.com/users/joyeecheung/followers","following_url":"https://api.github.com/users/joyeecheung/following{/other_user}","gists_url":"https://api.github.com/users/joyeecheung/gists{/gist_id}","starred_url":"https://api.github.com/users/joyeecheung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyeecheung/subscriptions","organizations_url":"https://api.github.com/users/joyeecheung/orgs","repos_url":"https://api.github.com/users/joyeecheung/repos","events_url":"https://api.github.com/users/joyeecheung/events{/privacy}","received_events_url":"https://api.github.com/users/joyeecheung/received_events","type":"User","site_admin":false},"body":"This might be affected by internal changes of events and assert...can you look for the frame that contains `__filename` instead of using hard-coded offsets?","created_at":"2018-02-01T01:24:57Z","updated_at":"2018-02-01T01:25:53Z","html_url":"https://github.com/nodejs/node/pull/18322#discussion_r165237720","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/18322","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/165237720"},"html":{"href":"https://github.com/nodejs/node/pull/18322#discussion_r165237720"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/18322"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/18322","id":164612446,"html_url":"https://github.com/nodejs/node/pull/18322","diff_url":"https://github.com/nodejs/node/pull/18322.diff","patch_url":"https://github.com/nodejs/node/pull/18322.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/18322","number":18322,"state":"open","locked":false,"title":"assert: do not read Node.js modules","user":{"login":"BridgeAR","id":8822573,"avatar_url":"https://avatars2.githubusercontent.com/u/8822573?v=4","gravatar_id":"","url":"https://api.github.com/users/BridgeAR","html_url":"https://github.com/BridgeAR","followers_url":"https://api.github.com/users/BridgeAR/followers","following_url":"https://api.github.com/users/BridgeAR/following{/other_user}","gists_url":"https://api.github.com/users/BridgeAR/gists{/gist_id}","starred_url":"https://api.github.com/users/BridgeAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BridgeAR/subscriptions","organizations_url":"https://api.github.com/users/BridgeAR/orgs","repos_url":"https://api.github.com/users/BridgeAR/repos","events_url":"https://api.github.com/users/BridgeAR/events{/privacy}","received_events_url":"https://api.github.com/users/BridgeAR/received_events","type":"User","site_admin":false},"body":"Prevent reading a Node.js module. That could theoretically lead to\r\nfalse errors being thrown otherwise.\r\n\r\n**Update**: I also added another commit that addresses a TODO about the `generatedMessage` when using simple assert.\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\nassert","created_at":"2018-01-23T15:47:33Z","updated_at":"2018-02-01T01:25:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9bc53f2dfc6f5cecdee03dc66145dcf5bca4563d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"apapirovski","id":20809,"avatar_url":"https://avatars2.githubusercontent.com/u/20809?v=4","gravatar_id":"","url":"https://api.github.com/users/apapirovski","html_url":"https://github.com/apapirovski","followers_url":"https://api.github.com/users/apapirovski/followers","following_url":"https://api.github.com/users/apapirovski/following{/other_user}","gists_url":"https://api.github.com/users/apapirovski/gists{/gist_id}","starred_url":"https://api.github.com/users/apapirovski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apapirovski/subscriptions","organizations_url":"https://api.github.com/users/apapirovski/orgs","repos_url":"https://api.github.com/users/apapirovski/repos","events_url":"https://api.github.com/users/apapirovski/events{/privacy}","received_events_url":"https://api.github.com/users/apapirovski/received_events","type":"User","site_admin":false},{"login":"mcollina","id":52195,"avatar_url":"https://avatars0.githubusercontent.com/u/52195?v=4","gravatar_id":"","url":"https://api.github.com/users/mcollina","html_url":"https://github.com/mcollina","followers_url":"https://api.github.com/users/mcollina/followers","following_url":"https://api.github.com/users/mcollina/following{/other_user}","gists_url":"https://api.github.com/users/mcollina/gists{/gist_id}","starred_url":"https://api.github.com/users/mcollina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcollina/subscriptions","organizations_url":"https://api.github.com/users/mcollina/orgs","repos_url":"https://api.github.com/users/mcollina/repos","events_url":"https://api.github.com/users/mcollina/events{/privacy}","received_events_url":"https://api.github.com/users/mcollina/received_events","type":"User","site_admin":false},{"login":"jasnell","id":439929,"avatar_url":"https://avatars2.githubusercontent.com/u/439929?v=4","gravatar_id":"","url":"https://api.github.com/users/jasnell","html_url":"https://github.com/jasnell","followers_url":"https://api.github.com/users/jasnell/followers","following_url":"https://api.github.com/users/jasnell/following{/other_user}","gists_url":"https://api.github.com/users/jasnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jasnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasnell/subscriptions","organizations_url":"https://api.github.com/users/jasnell/orgs","repos_url":"https://api.github.com/users/jasnell/repos","events_url":"https://api.github.com/users/jasnell/events{/privacy}","received_events_url":"https://api.github.com/users/jasnell/received_events","type":"User","site_admin":false},{"login":"addaleax","id":899444,"avatar_url":"https://avatars2.githubusercontent.com/u/899444?v=4","gravatar_id":"","url":"https://api.github.com/users/addaleax","html_url":"https://github.com/addaleax","followers_url":"https://api.github.com/users/addaleax/followers","following_url":"https://api.github.com/users/addaleax/following{/other_user}","gists_url":"https://api.github.com/users/addaleax/gists{/gist_id}","starred_url":"https://api.github.com/users/addaleax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addaleax/subscriptions","organizations_url":"https://api.github.com/users/addaleax/orgs","repos_url":"https://api.github.com/users/addaleax/repos","events_url":"https://api.github.com/users/addaleax/events{/privacy}","received_events_url":"https://api.github.com/users/addaleax/received_events","type":"User","site_admin":false},{"login":"TimothyGu","id":1538624,"avatar_url":"https://avatars2.githubusercontent.com/u/1538624?v=4","gravatar_id":"","url":"https://api.github.com/users/TimothyGu","html_url":"https://github.com/TimothyGu","followers_url":"https://api.github.com/users/TimothyGu/followers","following_url":"https://api.github.com/users/TimothyGu/following{/other_user}","gists_url":"https://api.github.com/users/TimothyGu/gists{/gist_id}","starred_url":"https://api.github.com/users/TimothyGu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimothyGu/subscriptions","organizations_url":"https://api.github.com/users/TimothyGu/orgs","repos_url":"https://api.github.com/users/TimothyGu/repos","events_url":"https://api.github.com/users/TimothyGu/events{/privacy}","received_events_url":"https://api.github.com/users/TimothyGu/received_events","type":"User","site_admin":false},{"login":"cjihrig","id":2512748,"avatar_url":"https://avatars1.githubusercontent.com/u/2512748?v=4","gravatar_id":"","url":"https://api.github.com/users/cjihrig","html_url":"https://github.com/cjihrig","followers_url":"https://api.github.com/users/cjihrig/followers","following_url":"https://api.github.com/users/cjihrig/following{/other_user}","gists_url":"https://api.github.com/users/cjihrig/gists{/gist_id}","starred_url":"https://api.github.com/users/cjihrig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjihrig/subscriptions","organizations_url":"https://api.github.com/users/cjihrig/orgs","repos_url":"https://api.github.com/users/cjihrig/repos","events_url":"https://api.github.com/users/cjihrig/events{/privacy}","received_events_url":"https://api.github.com/users/cjihrig/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/18322/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/18322/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/18322/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/acb1cbd49e19a991982b9bd135a03d5b89154af9","head":{"label":"BridgeAR:simple-assert-internal","ref":"simple-assert-internal","sha":"acb1cbd49e19a991982b9bd135a03d5b89154af9","user":{"login":"BridgeAR","id":8822573,"avatar_url":"https://avatars2.githubusercontent.com/u/8822573?v=4","gravatar_id":"","url":"https://api.github.com/users/BridgeAR","html_url":"https://github.com/BridgeAR","followers_url":"https://api.github.com/users/BridgeAR/followers","following_url":"https://api.github.com/users/BridgeAR/following{/other_user}","gists_url":"https://api.github.com/users/BridgeAR/gists{/gist_id}","starred_url":"https://api.github.com/users/BridgeAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BridgeAR/subscriptions","organizations_url":"https://api.github.com/users/BridgeAR/orgs","repos_url":"https://api.github.com/users/BridgeAR/repos","events_url":"https://api.github.com/users/BridgeAR/events{/privacy}","received_events_url":"https://api.github.com/users/BridgeAR/received_events","type":"User","site_admin":false},"repo":{"id":51107611,"name":"node","full_name":"BridgeAR/node","owner":{"login":"BridgeAR","id":8822573,"avatar_url":"https://avatars2.githubusercontent.com/u/8822573?v=4","gravatar_id":"","url":"https://api.github.com/users/BridgeAR","html_url":"https://github.com/BridgeAR","followers_url":"https://api.github.com/users/BridgeAR/followers","following_url":"https://api.github.com/users/BridgeAR/following{/other_user}","gists_url":"https://api.github.com/users/BridgeAR/gists{/gist_id}","starred_url":"https://api.github.com/users/BridgeAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BridgeAR/subscriptions","organizations_url":"https://api.github.com/users/BridgeAR/orgs","repos_url":"https://api.github.com/users/BridgeAR/repos","events_url":"https://api.github.com/users/BridgeAR/events{/privacy}","received_events_url":"https://api.github.com/users/BridgeAR/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BridgeAR/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/BridgeAR/node","forks_url":"https://api.github.com/repos/BridgeAR/node/forks","keys_url":"https://api.github.com/repos/BridgeAR/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BridgeAR/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BridgeAR/node/teams","hooks_url":"https://api.github.com/repos/BridgeAR/node/hooks","issue_events_url":"https://api.github.com/repos/BridgeAR/node/issues/events{/number}","events_url":"https://api.github.com/repos/BridgeAR/node/events","assignees_url":"https://api.github.com/repos/BridgeAR/node/assignees{/user}","branches_url":"https://api.github.com/repos/BridgeAR/node/branches{/branch}","tags_url":"https://api.github.com/repos/BridgeAR/node/tags","blobs_url":"https://api.github.com/repos/BridgeAR/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BridgeAR/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BridgeAR/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/BridgeAR/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BridgeAR/node/statuses/{sha}","languages_url":"https://api.github.com/repos/BridgeAR/node/languages","stargazers_url":"https://api.github.com/repos/BridgeAR/node/stargazers","contributors_url":"https://api.github.com/repos/BridgeAR/node/contributors","subscribers_url":"https://api.github.com/repos/BridgeAR/node/subscribers","subscription_url":"https://api.github.com/repos/BridgeAR/node/subscription","commits_url":"https://api.github.com/repos/BridgeAR/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/BridgeAR/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/BridgeAR/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/BridgeAR/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/BridgeAR/node/contents/{+path}","compare_url":"https://api.github.com/repos/BridgeAR/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BridgeAR/node/merges","archive_url":"https://api.github.com/repos/BridgeAR/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BridgeAR/node/downloads","issues_url":"https://api.github.com/repos/BridgeAR/node/issues{/number}","pulls_url":"https://api.github.com/repos/BridgeAR/node/pulls{/number}","milestones_url":"https://api.github.com/repos/BridgeAR/node/milestones{/number}","notifications_url":"https://api.github.com/repos/BridgeAR/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BridgeAR/node/labels{/name}","releases_url":"https://api.github.com/repos/BridgeAR/node/releases{/id}","deployments_url":"https://api.github.com/repos/BridgeAR/node/deployments","created_at":"2016-02-04T21:41:27Z","updated_at":"2016-02-04T21:41:36Z","pushed_at":"2018-01-31T18:54:12Z","git_url":"git://github.com/BridgeAR/node.git","ssh_url":"git@github.com:BridgeAR/node.git","clone_url":"https://github.com/BridgeAR/node.git","svn_url":"https://github.com/BridgeAR/node","homepage":"https://nodejs.org","size":329380,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"26ce1ae647d75dfda2359412cc7add0c26f77484","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-02-01T00:40:05Z","pushed_at":"2018-02-01T01:09:47Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":349408,"stargazers_count":45059,"watchers_count":45059,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9428,"mirror_url":null,"archived":false,"open_issues_count":811,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":9428,"open_issues":811,"watchers":45059,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/18322"},"html":{"href":"https://github.com/nodejs/node/pull/18322"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/18322"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/18322/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/18322/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/18322/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/acb1cbd49e19a991982b9bd135a03d5b89154af9"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"joyeecheung"}}