{"action":"created","issue":{"url":"https://api.github.com/repos/nextcloud/spreed/issues/928","repository_url":"https://api.github.com/repos/nextcloud/spreed","labels_url":"https://api.github.com/repos/nextcloud/spreed/issues/928/labels{/name}","comments_url":"https://api.github.com/repos/nextcloud/spreed/issues/928/comments","events_url":"https://api.github.com/repos/nextcloud/spreed/issues/928/events","html_url":"https://github.com/nextcloud/spreed/pull/928","id":327809946,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNTEzOTc1","number":928,"title":"Simplify notification wording","user":{"login":"danxuliu","id":26858233,"node_id":"MDQ6VXNlcjI2ODU4MjMz","avatar_url":"https://avatars1.githubusercontent.com/u/26858233?v=4","gravatar_id":"","url":"https://api.github.com/users/danxuliu","html_url":"https://github.com/danxuliu","followers_url":"https://api.github.com/users/danxuliu/followers","following_url":"https://api.github.com/users/danxuliu/following{/other_user}","gists_url":"https://api.github.com/users/danxuliu/gists{/gist_id}","starred_url":"https://api.github.com/users/danxuliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danxuliu/subscriptions","organizations_url":"https://api.github.com/users/danxuliu/orgs","repos_url":"https://api.github.com/users/danxuliu/repos","events_url":"https://api.github.com/users/danxuliu/events{/privacy}","received_events_url":"https://api.github.com/users/danxuliu/received_events","type":"User","site_admin":false},"labels":[{"id":488635725,"node_id":"MDU6TGFiZWw0ODg2MzU3MjU=","url":"https://api.github.com/repos/nextcloud/spreed/labels/3.%20to%20review","name":"3. to review","color":"0052cc","default":false},{"id":488635762,"node_id":"MDU6TGFiZWw0ODg2MzU3NjI=","url":"https://api.github.com/repos/nextcloud/spreed/labels/backport-request","name":"backport-request","color":"006b75","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/nextcloud/spreed/milestones/10","html_url":"https://github.com/nextcloud/spreed/milestone/10","labels_url":"https://api.github.com/repos/nextcloud/spreed/milestones/10/labels","id":2883795,"node_id":"MDk6TWlsZXN0b25lMjg4Mzc5NQ==","number":10,"title":"4.0 (Nextcloud 14)","description":"","creator":{"login":"nickvergessen","id":213943,"node_id":"MDQ6VXNlcjIxMzk0Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/213943?v=4","gravatar_id":"","url":"https://api.github.com/users/nickvergessen","html_url":"https://github.com/nickvergessen","followers_url":"https://api.github.com/users/nickvergessen/followers","following_url":"https://api.github.com/users/nickvergessen/following{/other_user}","gists_url":"https://api.github.com/users/nickvergessen/gists{/gist_id}","starred_url":"https://api.github.com/users/nickvergessen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickvergessen/subscriptions","organizations_url":"https://api.github.com/users/nickvergessen/orgs","repos_url":"https://api.github.com/users/nickvergessen/repos","events_url":"https://api.github.com/users/nickvergessen/events{/privacy}","received_events_url":"https://api.github.com/users/nickvergessen/received_events","type":"User","site_admin":false},"open_issues":27,"closed_issues":97,"state":"open","created_at":"2017-11-02T14:38:52Z","updated_at":"2018-05-30T16:38:44Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2018-05-30T16:38:44Z","updated_at":"2018-05-31T10:32:32Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nextcloud/spreed/pulls/928","html_url":"https://github.com/nextcloud/spreed/pull/928","diff_url":"https://github.com/nextcloud/spreed/pull/928.diff","patch_url":"https://github.com/nextcloud/spreed/pull/928.patch"},"body":"[As suggested by @jancborchardt](https://github.com/nextcloud/spreed/pull/500#issuecomment-356440981); although the meaning is not exactly the same (personally I would add back the _now_) the new wording is simpler and thus easier to understand.\r\n"},"comment":{"url":"https://api.github.com/repos/nextcloud/spreed/issues/comments/393488498","html_url":"https://github.com/nextcloud/spreed/pull/928#issuecomment-393488498","issue_url":"https://api.github.com/repos/nextcloud/spreed/issues/928","id":393488498,"node_id":"MDEyOklzc3VlQ29tbWVudDM5MzQ4ODQ5OA==","user":{"login":"danxuliu","id":26858233,"node_id":"MDQ6VXNlcjI2ODU4MjMz","avatar_url":"https://avatars1.githubusercontent.com/u/26858233?v=4","gravatar_id":"","url":"https://api.github.com/users/danxuliu","html_url":"https://github.com/danxuliu","followers_url":"https://api.github.com/users/danxuliu/followers","following_url":"https://api.github.com/users/danxuliu/following{/other_user}","gists_url":"https://api.github.com/users/danxuliu/gists{/gist_id}","starred_url":"https://api.github.com/users/danxuliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danxuliu/subscriptions","organizations_url":"https://api.github.com/users/danxuliu/orgs","repos_url":"https://api.github.com/users/danxuliu/repos","events_url":"https://api.github.com/users/danxuliu/events{/privacy}","received_events_url":"https://api.github.com/users/danxuliu/received_events","type":"User","site_admin":false},"created_at":"2018-05-31T10:32:32Z","updated_at":"2018-05-31T10:32:32Z","author_association":"MEMBER","body":">  **username** (now deleted) mentioned you in **Company call**\r\n\r\nFunny thing is that [we are almost going back to the original wording](https://github.com/nextcloud/spreed/pull/500/files#diff-52c5c003756b8dcc9c5318257107346dL198) (which I think makes sense, as it is more consistent with the rest of messages).\r\n\r\nNote that when the user is deleted her name is no longer known, so in that case the message would be\r\n> A user (now deleted) mentioned you in **conversation name**\r\n\r\nor something like that.\r\n\r\nIn the same way the room may have no name, so that is why current messages are\r\n>  **username** mentioned you in a group conversation\r\n>  **username** mentioned you in a group conversation: **conversation name**\r\n\r\nIf the message for deleted users is changed to \r\n>  A user (now deleted) mentioned you in **conversation name**\r\n>  A user (now deleted) mentioned you in a group conversation\r\n\r\nit would make sense to change that too for mentions by guests and users not deleted.\r\n\r\nPersonally I would keep the current _in a group conversation_ / _in a group conversation: **conversation name**_ also for deleted users (I somehow feel (so do not ask me for examples, it is just a feeling :-P ) that, depending on the conversation name, _embedding_ it could lead to unclear notification messages), but your call ;-)\r\n"}}
{"actor":{"display_login":"danxuliu"}}