{"action":"created","issue":{"url":"https://api.github.com/repos/javapathfinder/jpf-core/issues/144","repository_url":"https://api.github.com/repos/javapathfinder/jpf-core","labels_url":"https://api.github.com/repos/javapathfinder/jpf-core/issues/144/labels{/name}","comments_url":"https://api.github.com/repos/javapathfinder/jpf-core/issues/144/comments","events_url":"https://api.github.com/repos/javapathfinder/jpf-core/issues/144/events","html_url":"https://github.com/javapathfinder/jpf-core/pull/144","id":350701440,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NDgzNTUx","number":144,"title":"Remove unnecessary assertion in String#getBytes(byte[], int, byte)","user":{"login":"gayanW","id":5927747,"node_id":"MDQ6VXNlcjU5Mjc3NDc=","avatar_url":"https://avatars0.githubusercontent.com/u/5927747?v=4","gravatar_id":"","url":"https://api.github.com/users/gayanW","html_url":"https://github.com/gayanW","followers_url":"https://api.github.com/users/gayanW/followers","following_url":"https://api.github.com/users/gayanW/following{/other_user}","gists_url":"https://api.github.com/users/gayanW/gists{/gist_id}","starred_url":"https://api.github.com/users/gayanW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gayanW/subscriptions","organizations_url":"https://api.github.com/users/gayanW/orgs","repos_url":"https://api.github.com/users/gayanW/repos","events_url":"https://api.github.com/users/gayanW/events{/privacy}","received_events_url":"https://api.github.com/users/gayanW/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-15T06:35:44Z","updated_at":"2018-08-16T11:59:21Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/javapathfinder/jpf-core/pulls/144","html_url":"https://github.com/javapathfinder/jpf-core/pull/144","diff_url":"https://github.com/javapathfinder/jpf-core/pull/144.diff","patch_url":"https://github.com/javapathfinder/jpf-core/pull/144.patch"},"body":"https://github.com/javapathfinder/jpf-core/blob/9ebb98cb53b952ea3d7c7dc06aa7b822ee696395/src/classes/modules/java.base/java/lang/String.java#L249-L260\r\n\r\nOur initial conclusion that the coder is always UTF16 is wrong. As it states \"If two coders are **different** and the target is big enough, invoker guarantees that the target is in UTF16 \". So the invoker guarantees not to call when the source encoding is UTF-8 and the target is in LATIN-1.\r\n\r\nBut what if the source and target encoding are in \"UTF-8\". So the assertion statement needs to be removed.\r\n\r\nThis also fixes:\r\n\r\n    [junit] java.lang.AssertionError\r\n    [junit]     at java.lang.String.getBytes(String.java:254)\r\n\r\nThe error can be seen on ObjectStreamTest, ClassLoaderTest, StringTest and in a few other tests.\r\n"},"comment":{"url":"https://api.github.com/repos/javapathfinder/jpf-core/issues/comments/413521126","html_url":"https://github.com/javapathfinder/jpf-core/pull/144#issuecomment-413521126","issue_url":"https://api.github.com/repos/javapathfinder/jpf-core/issues/144","id":413521126,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzUyMTEyNg==","user":{"login":"cyrille-artho","id":7298631,"node_id":"MDQ6VXNlcjcyOTg2MzE=","avatar_url":"https://avatars3.githubusercontent.com/u/7298631?v=4","gravatar_id":"","url":"https://api.github.com/users/cyrille-artho","html_url":"https://github.com/cyrille-artho","followers_url":"https://api.github.com/users/cyrille-artho/followers","following_url":"https://api.github.com/users/cyrille-artho/following{/other_user}","gists_url":"https://api.github.com/users/cyrille-artho/gists{/gist_id}","starred_url":"https://api.github.com/users/cyrille-artho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyrille-artho/subscriptions","organizations_url":"https://api.github.com/users/cyrille-artho/orgs","repos_url":"https://api.github.com/users/cyrille-artho/repos","events_url":"https://api.github.com/users/cyrille-artho/events{/privacy}","received_events_url":"https://api.github.com/users/cyrille-artho/received_events","type":"User","site_admin":false},"created_at":"2018-08-16T11:59:21Z","updated_at":"2018-08-16T11:59:21Z","author_association":"CONTRIBUTOR","body":"Thanks for catching this. In this case, please turn the comment in the \"else\" condition into an assertion."}}
{"actor":{"display_login":"cyrille-artho"}}