{"action":"opened","number":1124,"pull_request":{"url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/pulls/1124","id":239379753,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5Mzc5NzUz","html_url":"https://github.com/azerothcore/azerothcore-wotlk/pull/1124","diff_url":"https://github.com/azerothcore/azerothcore-wotlk/pull/1124.diff","patch_url":"https://github.com/azerothcore/azerothcore-wotlk/pull/1124.patch","issue_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/issues/1124","number":1124,"state":"open","locked":false,"title":"Simplify quest_template table to match trinitycore's table","user":{"login":"Nefertumm","id":19627365,"node_id":"MDQ6VXNlcjE5NjI3MzY1","avatar_url":"https://avatars2.githubusercontent.com/u/19627365?v=4","gravatar_id":"","url":"https://api.github.com/users/Nefertumm","html_url":"https://github.com/Nefertumm","followers_url":"https://api.github.com/users/Nefertumm/followers","following_url":"https://api.github.com/users/Nefertumm/following{/other_user}","gists_url":"https://api.github.com/users/Nefertumm/gists{/gist_id}","starred_url":"https://api.github.com/users/Nefertumm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nefertumm/subscriptions","organizations_url":"https://api.github.com/users/Nefertumm/orgs","repos_url":"https://api.github.com/users/Nefertumm/repos","events_url":"https://api.github.com/users/Nefertumm/events{/privacy}","received_events_url":"https://api.github.com/users/Nefertumm/received_events","type":"User","site_admin":false},"body":"<!-- First of all, THANK YOU for your contribution.\r\n Please fill this template unless your PR is very simple/straightforward.\r\n Do not forget to have a look at our Pull Request tutorial: https://github.com/azerothcore/azerothcore-wotlk/wiki/Contribute#how-to-create-a-pull-request\r\n-->\r\n\r\n\r\n<!-- WRITE A RELEVANT TITLE -->\r\n\r\n\r\n##### CHANGES PROPOSED:\r\n\r\n-  Changed a lot of variable names.\r\n-  Added quest_details, quest_request_items, quest_offer_reward and sort some columns.\r\n-  Delete some useless iterations.\r\n\r\n\r\n###### ISSUES ADDRESSED:\r\n<!-- If the issue doesn't exist, describe it and how to reproduce it, please. If the issue already exists, just paste the link to the issue you close, like this: Closes https://github.com/azerothcore/azerothcore-wotlk/issues/967 -->\r\n\r\nCloses #1119 \r\n\r\n\r\n##### TESTS PERFORMED:\r\n<!-- Does it build without errors? Did you test in-game? What did you test? Did you do all these tests on Linux, Mac or Windows? Other tests performed -->\r\n\r\nWindows: It compiles, the server starts without errors and everything seems fine when you take a quest.\r\n\r\n##### HOW TO TEST THE CHANGES:\r\n<!-- We need to confirm the changes first, so try to make the work easy for testers, please:\r\n - Which commands to use? Which NPC to teleport to?\r\n - Do we need to enable debug flags on Cmake?\r\n - Do we need to look at the console? etc...\r\n - Other steps\r\n-->\r\nJust pick some quest and complete them.\r\n\r\n\r\n##### KNOWN ISSUES AND TODO LIST:\r\n<!-- This is a TODO list with checkboxes to tick -->\r\n\r\n- [ ]\r\n- [ ] \r\n\r\n\r\n##### Target branch(es):\r\n\r\nMaster\r\n\r\n\r\n<!-- NOTE: You no longer need to squash your commits, on merge we will squash them for you (when there are too many commits we merge them into one big commit for a cleaner and easy to read history). -->\r\n\r\n<!-- NOTE2: If you intend to contribute more than once, you should really join us on our discord channel!\r\n The link is on our site http://azerothcore.org/ We set cosmetic ranks for our contributors and may give access to special resources/knowledge to them! -->\r\n","created_at":"2018-12-18T06:38:47Z","updated_at":"2018-12-18T06:38:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/pulls/1124/commits","review_comments_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/pulls/1124/comments","review_comment_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/issues/1124/comments","statuses_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/statuses/f01fad0ddd79cbabb0a2ae9fe7977871ccc8ffff","head":{"label":"Nefertumm:quest_template","ref":"quest_template","sha":"f01fad0ddd79cbabb0a2ae9fe7977871ccc8ffff","user":{"login":"Nefertumm","id":19627365,"node_id":"MDQ6VXNlcjE5NjI3MzY1","avatar_url":"https://avatars2.githubusercontent.com/u/19627365?v=4","gravatar_id":"","url":"https://api.github.com/users/Nefertumm","html_url":"https://github.com/Nefertumm","followers_url":"https://api.github.com/users/Nefertumm/followers","following_url":"https://api.github.com/users/Nefertumm/following{/other_user}","gists_url":"https://api.github.com/users/Nefertumm/gists{/gist_id}","starred_url":"https://api.github.com/users/Nefertumm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nefertumm/subscriptions","organizations_url":"https://api.github.com/users/Nefertumm/orgs","repos_url":"https://api.github.com/users/Nefertumm/repos","events_url":"https://api.github.com/users/Nefertumm/events{/privacy}","received_events_url":"https://api.github.com/users/Nefertumm/received_events","type":"User","site_admin":false},"repo":{"id":161241727,"node_id":"MDEwOlJlcG9zaXRvcnkxNjEyNDE3Mjc=","name":"azerothcore-wotlk","full_name":"Nefertumm/azerothcore-wotlk","private":false,"owner":{"login":"Nefertumm","id":19627365,"node_id":"MDQ6VXNlcjE5NjI3MzY1","avatar_url":"https://avatars2.githubusercontent.com/u/19627365?v=4","gravatar_id":"","url":"https://api.github.com/users/Nefertumm","html_url":"https://github.com/Nefertumm","followers_url":"https://api.github.com/users/Nefertumm/followers","following_url":"https://api.github.com/users/Nefertumm/following{/other_user}","gists_url":"https://api.github.com/users/Nefertumm/gists{/gist_id}","starred_url":"https://api.github.com/users/Nefertumm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nefertumm/subscriptions","organizations_url":"https://api.github.com/users/Nefertumm/orgs","repos_url":"https://api.github.com/users/Nefertumm/repos","events_url":"https://api.github.com/users/Nefertumm/events{/privacy}","received_events_url":"https://api.github.com/users/Nefertumm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Nefertumm/azerothcore-wotlk","description":"AZeroThCore - MMORPG Server. Based on MaNGOS -> TrinityCore -> SunwellCore","fork":true,"url":"https://api.github.com/repos/Nefertumm/azerothcore-wotlk","forks_url":"https://api.github.com/repos/Nefertumm/azerothcore-wotlk/forks","keys_url":"https://api.github.com/repos/Nefertumm/azerothcore-wotlk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nefertumm/azerothcore-wotlk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nefertumm/azerothcore-wotlk/teams","hooks_url":"https://api.github.com/repos/Nefertumm/azerothcore-wotlk/hooks","issue_events_url":"https://api.github.com/repos/Nefertumm/azerothcore-wotlk/issues/events{/number}","events_url":"https://api.github.com/repos/Nefertumm/azerothcore-wotlk/events","assignees_url":"https://api.github.com/repos/Nefertumm/azerothcore-wotlk/assignees{/user}","branches_url":"https://api.github.com/repos/Nefertumm/azerothcore-wotlk/branches{/branch}","tags_url":"https://api.github.com/repos/Nefertumm/azerothcore-wotlk/tags","blobs_url":"https://api.github.com/repos/Nefertumm/azerothcore-wotlk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nefertumm/azerothcore-wotlk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nefertumm/azerothcore-wotlk/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nefertumm/azerothcore-wotlk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nefertumm/azerothcore-wotlk/statuses/{sha}","languages_url":"https://api.github.com/repos/Nefertumm/azerothcore-wotlk/languages","stargazers_url":"https://api.github.com/repos/Nefertumm/azerothcore-wotlk/stargazers","contributors_url":"https://api.github.com/repos/Nefertumm/azerothcore-wotlk/contributors","subscribers_url":"https://api.github.com/repos/Nefertumm/azerothcore-wotlk/subscribers","subscription_url":"https://api.github.com/repos/Nefertumm/azerothcore-wotlk/subscription","commits_url":"https://api.github.com/repos/Nefertumm/azerothcore-wotlk/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nefertumm/azerothcore-wotlk/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nefertumm/azerothcore-wotlk/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nefertumm/azerothcore-wotlk/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nefertumm/azerothcore-wotlk/contents/{+path}","compare_url":"https://api.github.com/repos/Nefertumm/azerothcore-wotlk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nefertumm/azerothcore-wotlk/merges","archive_url":"https://api.github.com/repos/Nefertumm/azerothcore-wotlk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nefertumm/azerothcore-wotlk/downloads","issues_url":"https://api.github.com/repos/Nefertumm/azerothcore-wotlk/issues{/number}","pulls_url":"https://api.github.com/repos/Nefertumm/azerothcore-wotlk/pulls{/number}","milestones_url":"https://api.github.com/repos/Nefertumm/azerothcore-wotlk/milestones{/number}","notifications_url":"https://api.github.com/repos/Nefertumm/azerothcore-wotlk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nefertumm/azerothcore-wotlk/labels{/name}","releases_url":"https://api.github.com/repos/Nefertumm/azerothcore-wotlk/releases{/id}","deployments_url":"https://api.github.com/repos/Nefertumm/azerothcore-wotlk/deployments","created_at":"2018-12-10T21:58:19Z","updated_at":"2018-12-17T23:14:30Z","pushed_at":"2018-12-18T06:30:19Z","git_url":"git://github.com/Nefertumm/azerothcore-wotlk.git","ssh_url":"git@github.com:Nefertumm/azerothcore-wotlk.git","clone_url":"https://github.com/Nefertumm/azerothcore-wotlk.git","svn_url":"https://github.com/Nefertumm/azerothcore-wotlk","homepage":"http://www.azerothcore.org","size":256592,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"azerothcore:master","ref":"master","sha":"4a52df637574c24cc056e08a739c4001e56199eb","user":{"login":"azerothcore","id":20147732,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMTQ3NzMy","avatar_url":"https://avatars0.githubusercontent.com/u/20147732?v=4","gravatar_id":"","url":"https://api.github.com/users/azerothcore","html_url":"https://github.com/azerothcore","followers_url":"https://api.github.com/users/azerothcore/followers","following_url":"https://api.github.com/users/azerothcore/following{/other_user}","gists_url":"https://api.github.com/users/azerothcore/gists{/gist_id}","starred_url":"https://api.github.com/users/azerothcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azerothcore/subscriptions","organizations_url":"https://api.github.com/users/azerothcore/orgs","repos_url":"https://api.github.com/users/azerothcore/repos","events_url":"https://api.github.com/users/azerothcore/events{/privacy}","received_events_url":"https://api.github.com/users/azerothcore/received_events","type":"Organization","site_admin":false},"repo":{"id":61980658,"node_id":"MDEwOlJlcG9zaXRvcnk2MTk4MDY1OA==","name":"azerothcore-wotlk","full_name":"azerothcore/azerothcore-wotlk","private":false,"owner":{"login":"azerothcore","id":20147732,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMTQ3NzMy","avatar_url":"https://avatars0.githubusercontent.com/u/20147732?v=4","gravatar_id":"","url":"https://api.github.com/users/azerothcore","html_url":"https://github.com/azerothcore","followers_url":"https://api.github.com/users/azerothcore/followers","following_url":"https://api.github.com/users/azerothcore/following{/other_user}","gists_url":"https://api.github.com/users/azerothcore/gists{/gist_id}","starred_url":"https://api.github.com/users/azerothcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azerothcore/subscriptions","organizations_url":"https://api.github.com/users/azerothcore/orgs","repos_url":"https://api.github.com/users/azerothcore/repos","events_url":"https://api.github.com/users/azerothcore/events{/privacy}","received_events_url":"https://api.github.com/users/azerothcore/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/azerothcore/azerothcore-wotlk","description":"AZeroThCore - MMORPG Server. Based on MaNGOS -> TrinityCore -> SunwellCore","fork":false,"url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk","forks_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/forks","keys_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/teams","hooks_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/hooks","issue_events_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/issues/events{/number}","events_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/events","assignees_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/assignees{/user}","branches_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/branches{/branch}","tags_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/tags","blobs_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/git/refs{/sha}","trees_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/statuses/{sha}","languages_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/languages","stargazers_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/stargazers","contributors_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/contributors","subscribers_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/subscribers","subscription_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/subscription","commits_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/commits{/sha}","git_commits_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/git/commits{/sha}","comments_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/comments{/number}","issue_comment_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/issues/comments{/number}","contents_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/contents/{+path}","compare_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/merges","archive_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/downloads","issues_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/issues{/number}","pulls_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/pulls{/number}","milestones_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/milestones{/number}","notifications_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/labels{/name}","releases_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/releases{/id}","deployments_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/deployments","created_at":"2016-06-26T08:40:05Z","updated_at":"2018-12-17T23:27:08Z","pushed_at":"2018-12-17T23:09:55Z","git_url":"git://github.com/azerothcore/azerothcore-wotlk.git","ssh_url":"git@github.com:azerothcore/azerothcore-wotlk.git","clone_url":"https://github.com/azerothcore/azerothcore-wotlk.git","svn_url":"https://github.com/azerothcore/azerothcore-wotlk","homepage":"http://www.azerothcore.org","size":256651,"stargazers_count":280,"watchers_count":280,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":290,"mirror_url":null,"archived":false,"open_issues_count":200,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":290,"open_issues":200,"watchers":280,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/pulls/1124"},"html":{"href":"https://github.com/azerothcore/azerothcore-wotlk/pull/1124"},"issue":{"href":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/issues/1124"},"comments":{"href":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/issues/1124/comments"},"review_comments":{"href":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/pulls/1124/comments"},"review_comment":{"href":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/pulls/1124/commits"},"statuses":{"href":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/statuses/f01fad0ddd79cbabb0a2ae9fe7977871ccc8ffff"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":398,"deletions":208,"changed_files":7}}
{"actor":{"display_login":"Nefertumm"}}